id int64 1 37.7k | comment_id int64 12.6M 18M | issue_id stringlengths 1 4 | user stringlengths 1 30 | body stringlengths 1 101k | created_at stringdate 2008-06-06 18:03:50-0400 2025-10-01 11:49:43-0400 | updated_at stringdate 2008-06-06 18:03:50-0400 2025-10-01 11:49:43-0400 | metadata stringlengths 1.46k 208k |
|---|---|---|---|---|---|---|---|
101 | 12,635,719 | 6 | Flavio Paiva Junqueira | +1 and committed | 2008-09-30T07:15:40.113000-04:00 | 2008-09-30T07:15:40.113000-04:00 | {"id": 12635719, "body": "+1 and committed", "user": "Flavio Paiva Junqueira", "created_at": "2008-09-30T07:15:40.113000-04:00", "updated_at": "2008-09-30T07:15:40.113000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397957/comment/12635719", "id": "12635719", "author":... |
102 | 12,635,749 | 6 | Hudson | Integrated in ZooKeeper-trunk #99 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/99/]) | 2008-09-30T09:47:31.330000-04:00 | 2008-09-30T09:47:31.330000-04:00 | {"id": 12635749, "body": "Integrated in ZooKeeper-trunk #99 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/99/])", "user": "Hudson", "created_at": "2008-09-30T09:47:31.330000-04:00", "updated_at": "2008-09-30T09:47:31.330000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
103 | 12,642,667 | 6 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.403000-04:00 | 2008-10-25T21:10:37.403000-04:00 | {"id": 12642667, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.403000-04:00", "updated_at": "2008-10-25T21:10:37.403000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397957/comment/12642667", "id": "126... |
104 | 12,635,031 | 7 | Mahadev Konar | this has been fixed by the ZOOKEEPER-132 and ZOOKEEPER-139.
| 2008-09-26T17:27:47.259000-04:00 | 2008-09-26T17:27:47.259000-04:00 | {"id": 12635031, "body": "this has been fixed by the ZOOKEEPER-132 and ZOOKEEPER-139.\n", "user": "Mahadev Konar", "created_at": "2008-09-26T17:27:47.259000-04:00", "updated_at": "2008-09-26T17:27:47.259000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397965/comment/12... |
105 | 12,642,668 | 7 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.448000-04:00 | 2008-10-25T21:10:37.448000-04:00 | {"id": 12642668, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.448000-04:00", "updated_at": "2008-10-25T21:10:37.448000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397965/comment/12642668", "id": "126... |
106 | 12,610,001 | 8 | Mahadev Konar | this is a preleminary patch that introduces a stat structure just for the client. This breaks all the client api's that use Stat. This does not have changes to the tests and other examples in this patch. I am still testing and making changes to the tests and examples. | 2008-07-02T14:37:12.643000-04:00 | 2008-07-02T14:37:12.643000-04:00 | {"id": 12610001, "body": "this is a preleminary patch that introduces a stat structure just for the client. This breaks all the client api's that use Stat. This does not have changes to the tests and other examples in this patch. I am still testing and making changes to the tests and examples.", "user": "Mahadev Konar"... |
107 | 12,610,027 | 8 | Benjamin Reed | I think the patch would be simpler and we would avoid breaking the client API if we kept Stat for clients and added the size and # of children and then used InternalStat for the current Stat structure. | 2008-07-02T16:07:38.921000-04:00 | 2008-07-02T16:07:38.921000-04:00 | {"id": 12610027, "body": "I think the patch would be simpler and we would avoid breaking the client API if we kept Stat for clients and added the size and # of children and then used InternalStat for the current Stat structure.", "user": "Benjamin Reed", "created_at": "2008-07-02T16:07:38.921000-04:00", "updated_at": "... |
108 | 12,610,031 | 8 | Mahadev Konar | true!! thats what i thought initially -- but then I thought that its better to explicitly break the api and let the users know that something has changed so that there applications do not implicitly break (compiling no error but then malloc or something you would get problems)... not sure... | 2008-07-02T16:20:15.650000-04:00 | 2008-07-02T16:20:15.650000-04:00 | {"id": 12610031, "body": "true!! thats what i thought initially -- but then I thought that its better to explicitly break the api and let the users know that something has changed so that there applications do not implicitly break (compiling no error but then malloc or something you would get problems)... not sure... "... |
109 | 12,635,079 | 8 | Patrick D. Hunt | Updated per Ben's suggestion, added tests and updated docs.
There is still a user Stat which now contains the 2 additional fields, there is also now a StatPersisted which is the information persisted to disk by the server.
| 2008-09-26T21:28:03.558000-04:00 | 2008-09-26T21:28:03.558000-04:00 | {"id": 12635079, "body": "Updated per Ben's suggestion, added tests and updated docs.\n\nThere is still a user Stat which now contains the 2 additional fields, there is also now a StatPersisted which is the information persisted to disk by the server.\n", "user": "Patrick D. Hunt", "created_at": "2008-09-26T21:28:03.55... |
110 | 12,635,080 | 8 | Patrick D. Hunt | Submitting patch, questionable whether this is incompatible, but marking it as such so that we are sure to document in the release notes.
| 2008-09-26T21:28:47.681000-04:00 | 2008-09-26T21:28:47.681000-04:00 | {"id": 12635080, "body": "Submitting patch, questionable whether this is incompatible, but marking it as such so that we are sure to document in the release notes.\n", "user": "Patrick D. Hunt", "created_at": "2008-09-26T21:28:47.681000-04:00", "updated_at": "2008-09-26T21:28:47.681000-04:00", "_provider": "jira", "raw... |
111 | 12,635,604 | 8 | Mahadev Konar | the cnage looks good ..... is it possible to add some tests in the c test code? (since this marks an api change in c client as well) | 2008-09-29T19:50:45.132000-04:00 | 2008-09-29T19:50:45.132000-04:00 | {"id": 12635604, "body": "the cnage looks good ..... is it possible to add some tests in the c test code? (since this marks an api change in c client as well) ", "user": "Mahadev Konar", "created_at": "2008-09-29T19:50:45.132000-04:00", "updated_at": "2008-09-29T19:50:45.132000-04:00", "_provider": "jira", "raw": {"sel... |
112 | 12,635,740 | 8 | Patrick D. Hunt | Sure, I'll look at cppunit that we already have and see what we can do. | 2008-09-30T09:15:25.882000-04:00 | 2008-09-30T09:15:25.882000-04:00 | {"id": 12635740, "body": "Sure, I'll look at cppunit that we already have and see what we can do.", "user": "Patrick D. Hunt", "created_at": "2008-09-30T09:15:25.882000-04:00", "updated_at": "2008-09-30T09:15:25.882000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/1239796... |
113 | 12,635,929 | 8 | Patrick D. Hunt | I looked at the c tests and they are all mock based. I'll open another jira for the c tests - that we should have tests that run against actual java server.
Resubmitting this patch.
| 2008-09-30T21:48:01.241000-04:00 | 2008-09-30T21:48:01.241000-04:00 | {"id": 12635929, "body": "I looked at the c tests and they are all mock based. I'll open another jira for the c tests - that we should have tests that run against actual java server.\n\nResubmitting this patch.\n", "user": "Patrick D. Hunt", "created_at": "2008-09-30T21:48:01.241000-04:00", "updated_at": "2008-09-30T21... |
114 | 12,636,466 | 8 | Mahadev Konar | this patch no longer applies after ZOOKEEPER-38 :). pat can you update the patch? | 2008-10-02T17:02:59.640000-04:00 | 2008-10-02T17:02:59.640000-04:00 | {"id": 12636466, "body": "this patch no longer applies after ZOOKEEPER-38 :). pat can you update the patch?", "user": "Mahadev Konar", "created_at": "2008-10-02T17:02:59.640000-04:00", "updated_at": "2008-10-02T17:02:59.640000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue... |
115 | 12,636,483 | 8 | Patrick D. Hunt | Updated to resolve conflict w/ latest code in svn.
| 2008-10-02T18:05:59.319000-04:00 | 2008-10-02T18:05:59.319000-04:00 | {"id": 12636483, "body": "Updated to resolve conflict w/ latest code in svn.\n", "user": "Patrick D. Hunt", "created_at": "2008-10-02T18:05:59.319000-04:00", "updated_at": "2008-10-02T18:05:59.319000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397966/comment/12636483"... |
116 | 12,637,382 | 8 | Mahadev Konar | +1 the patch looks good ....
| 2008-10-07T01:38:49.895000-04:00 | 2008-10-07T01:38:49.895000-04:00 | {"id": 12637382, "body": "+1 the patch looks good .... \n", "user": "Mahadev Konar", "created_at": "2008-10-07T01:38:49.895000-04:00", "updated_at": "2008-10-07T01:38:49.895000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397966/comment/12637382", "id": "12637382", "au... |
117 | 12,637,605 | 8 | Patrick D. Hunt | Committed revision 702583. | 2008-10-07T14:52:33.285000-04:00 | 2008-10-07T14:52:33.285000-04:00 | {"id": 12637605, "body": "Committed revision 702583.", "user": "Patrick D. Hunt", "created_at": "2008-10-07T14:52:33.285000-04:00", "updated_at": "2008-10-07T14:52:33.285000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397966/comment/12637605", "id": "12637605", "autho... |
118 | 12,637,867 | 8 | Hudson | Integrated in ZooKeeper-trunk #107 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/107/])
. Stat enchaned to include num of children and size
| 2008-10-08T07:00:55.308000-04:00 | 2008-10-08T07:00:55.308000-04:00 | {"id": 12637867, "body": "Integrated in ZooKeeper-trunk #107 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/107/])\n . Stat enchaned to include num of children and size\n", "user": "Hudson", "created_at": "2008-10-08T07:00:55.308000-04:00", "updated_at": "2008-10-08T07:00:55.308000-04:00", "_provide... |
119 | 12,642,669 | 8 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.504000-04:00 | 2008-10-25T21:10:37.504000-04:00 | {"id": 12642669, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.504000-04:00", "updated_at": "2008-10-25T21:10:37.504000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397966/comment/12642669", "id": "126... |
120 | 12,615,876 | 11 | Patrick D. Hunt | Not sure why this wasn't closed - patch was submitted to sf before snapshot for apache migration. Apache svn contains this fix. | 2008-07-23T00:30:53.357000-04:00 | 2008-07-23T00:30:53.357000-04:00 | {"id": 12615876, "body": "Not sure why this wasn't closed - patch was submitted to sf before snapshot for apache migration. Apache svn contains this fix.", "user": "Patrick D. Hunt", "created_at": "2008-07-23T00:30:53.357000-04:00", "updated_at": "2008-07-23T00:30:53.357000-04:00", "_provider": "jira", "raw": {"self": ... |
121 | 12,642,670 | 11 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.554000-04:00 | 2008-10-25T21:10:37.554000-04:00 | {"id": 12642670, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.554000-04:00", "updated_at": "2008-10-25T21:10:37.554000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397970/comment/12642670", "id": "126... |
122 | 12,615,878 | 15 | Patrick D. Hunt | This was resolved in sf prior to apache snapshot. Apache svn contains this fix. | 2008-07-23T00:31:40.305000-04:00 | 2008-07-23T00:31:40.305000-04:00 | {"id": 12615878, "body": "This was resolved in sf prior to apache snapshot. Apache svn contains this fix.", "user": "Patrick D. Hunt", "created_at": "2008-07-23T00:31:40.305000-04:00", "updated_at": "2008-07-23T00:31:40.305000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue... |
123 | 12,642,671 | 15 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.577000-04:00 | 2008-10-25T21:10:37.577000-04:00 | {"id": 12642671, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.577000-04:00", "updated_at": "2008-10-25T21:10:37.577000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397974/comment/12642671", "id": "126... |
124 | 12,635,064 | 17 | Patrick D. Hunt | updated the docs to reflect the sf issue detail - add comments for zkinit. | 2008-09-26T19:25:18.146000-04:00 | 2008-09-26T19:25:18.146000-04:00 | {"id": 12635064, "body": "updated the docs to reflect the sf issue detail - add comments for zkinit.", "user": "Patrick D. Hunt", "created_at": "2008-09-26T19:25:18.146000-04:00", "updated_at": "2008-09-26T19:25:18.146000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/1239... |
125 | 12,635,964 | 17 | Austin Bennett | The documentation states that if the client_id given to zookeeper_init is expired or invalid that a new session will be automatically generated, implying that it will proceed to the CONNECTED state.
In the implementation an expired or invalid client_id leads to the unrecoverable SESSION_EXPIRED_STATE, which requires c... | 2008-10-01T03:23:44.227000-04:00 | 2008-10-01T03:23:44.227000-04:00 | {"id": 12635964, "body": "The documentation states that if the client_id given to zookeeper_init is expired or invalid that a new session will be automatically generated, implying that it will proceed to the CONNECTED state.\n\nIn the implementation an expired or invalid client_id leads to the unrecoverable SESSION_EXP... |
126 | 12,636,234 | 17 | Patrick D. Hunt | Hrm. I'll withdraw the patch while I look into this further. Thanks for the feedback.
| 2008-10-01T19:00:45.839000-04:00 | 2008-10-01T19:00:45.839000-04:00 | {"id": 12636234, "body": "Hrm. I'll withdraw the patch while I look into this further. Thanks for the feedback.\n", "user": "Patrick D. Hunt", "created_at": "2008-10-01T19:00:45.839000-04:00", "updated_at": "2008-10-01T19:00:45.839000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api... |
127 | 12,638,122 | 17 | Benjamin Reed | The documentation is incorrect. An invalid or expired session id will result in a zookeeper_handle that is in the unrecoverable SESSION_EXPIRED_STATE. That comment documented old behavior.
It turns out that processing correctly the situation where the session is expired and a new session is assigned can be tricky. We ... | 2008-10-08T18:33:16.392000-04:00 | 2008-10-08T18:33:16.392000-04:00 | {"id": 12638122, "body": "The documentation is incorrect. An invalid or expired session id will result in a zookeeper_handle that is in the unrecoverable SESSION_EXPIRED_STATE. That comment documented old behavior.\n\nIt turns out that processing correctly the situation where the session is expired and a new session is... |
128 | 12,638,353 | 17 | Patrick D. Hunt | I updated the patch based on ben's comments, no change to the semantics of the code, just documentation change.
Does this sufficiently resolve the stated issue?
| 2008-10-09T14:19:24.619000-04:00 | 2008-10-09T14:19:24.619000-04:00 | {"id": 12638353, "body": "I updated the patch based on ben's comments, no change to the semantics of the code, just documentation change.\n\nDoes this sufficiently resolve the stated issue?\n", "user": "Patrick D. Hunt", "created_at": "2008-10-09T14:19:24.619000-04:00", "updated_at": "2008-10-09T14:19:24.619000-04:00",... |
129 | 12,638,668 | 17 | Benjamin Reed | +1 Looks great. I'd commit it, but I'm not setup to build the doc... | 2008-10-10T18:45:42.440000-04:00 | 2008-10-10T18:45:42.440000-04:00 | {"id": 12638668, "body": "+1 Looks great. I'd commit it, but I'm not setup to build the doc...", "user": "Benjamin Reed", "created_at": "2008-10-10T18:45:42.440000-04:00", "updated_at": "2008-10-10T18:45:42.440000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397976/com... |
130 | 12,638,671 | 17 | Patrick D. Hunt | Committed revision 703595. | 2008-10-10T18:56:54.160000-04:00 | 2008-10-10T18:56:54.160000-04:00 | {"id": 12638671, "body": "Committed revision 703595.", "user": "Patrick D. Hunt", "created_at": "2008-10-10T18:56:54.160000-04:00", "updated_at": "2008-10-10T18:56:54.160000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397976/comment/12638671", "id": "12638671", "autho... |
131 | 12,638,738 | 17 | Hudson | Integrated in ZooKeeper-trunk #110 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/110/])
8 FLE Test
. zookeeper_init doc needs clarification
| 2008-10-11T06:51:14.980000-04:00 | 2008-10-11T06:51:14.980000-04:00 | {"id": 12638738, "body": "Integrated in ZooKeeper-trunk #110 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/110/])\n 8 FLE Test\n. zookeeper_init doc needs clarification\n", "user": "Hudson", "created_at": "2008-10-11T06:51:14.980000-04:00", "updated_at": "2008-10-11T06:51:14.980000-04:00", "_provid... |
132 | 12,642,672 | 17 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.627000-04:00 | 2008-10-25T21:10:37.627000-04:00 | {"id": 12642672, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.627000-04:00", "updated_at": "2008-10-25T21:10:37.627000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397976/comment/12642672", "id": "126... |
133 | 12,626,722 | 18 | Patrick D. Hunt | This fix should be included as part of ZOOKEEPER-7 changes as it's the same code. | 2008-08-28T15:57:42.266000-04:00 | 2008-08-28T15:57:42.266000-04:00 | {"id": 12626722, "body": "This fix should be included as part of ZOOKEEPER-7 changes as it's the same code.", "user": "Patrick D. Hunt", "created_at": "2008-08-28T15:57:42.266000-04:00", "updated_at": "2008-08-28T15:57:42.266000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/iss... |
134 | 12,634,667 | 18 | Patrick D. Hunt | This was fixed as part of ZOOKEEPER-139, changed value was removed | 2008-09-25T18:33:39.578000-04:00 | 2008-09-25T18:33:39.578000-04:00 | {"id": 12634667, "body": "This was fixed as part of ZOOKEEPER-139, changed value was removed", "user": "Patrick D. Hunt", "created_at": "2008-09-25T18:33:39.578000-04:00", "updated_at": "2008-09-25T18:33:39.578000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397977/com... |
135 | 12,642,673 | 18 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.662000-04:00 | 2008-10-25T21:10:37.662000-04:00 | {"id": 12642673, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.662000-04:00", "updated_at": "2008-10-25T21:10:37.662000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397977/comment/12642673", "id": "126... |
136 | 12,626,234 | 20 | Patrick D. Hunt | This was fixed prior to the move to Apache (from SF). Was committed to SF SVN before SCCS snapshot. | 2008-08-27T14:36:36.506000-04:00 | 2008-08-27T14:36:36.506000-04:00 | {"id": 12626234, "body": "This was fixed prior to the move to Apache (from SF). Was committed to SF SVN before SCCS snapshot.", "user": "Patrick D. Hunt", "created_at": "2008-08-27T14:36:36.506000-04:00", "updated_at": "2008-08-27T14:36:36.506000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/j... |
137 | 12,642,674 | 20 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.696000-04:00 | 2008-10-25T21:10:37.696000-04:00 | {"id": 12642674, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.696000-04:00", "updated_at": "2008-10-25T21:10:37.696000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397979/comment/12642674", "id": "126... |
138 | 12,634,712 | 21 | Patrick D. Hunt | This patch updates the docs in both forrest and javadoc. Original issues are now addressed. | 2008-09-25T20:27:26.338000-04:00 | 2008-09-25T20:27:26.338000-04:00 | {"id": 12634712, "body": "This patch updates the docs in both forrest and javadoc. Original issues are now addressed.", "user": "Patrick D. Hunt", "created_at": "2008-09-25T20:27:26.338000-04:00", "updated_at": "2008-09-25T20:27:26.338000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest... |
139 | 12,634,950 | 21 | Flavio Paiva Junqueira | +1. Patch looks good. | 2008-09-26T14:00:33.673000-04:00 | 2008-09-26T14:00:33.673000-04:00 | {"id": 12634950, "body": "+1. Patch looks good.", "user": "Flavio Paiva Junqueira", "created_at": "2008-09-26T14:00:33.673000-04:00", "updated_at": "2008-09-26T14:00:33.673000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397980/comment/12634950", "id": "12634950", "aut... |
140 | 12,634,957 | 21 | Patrick D. Hunt | Committed revision 699442. | 2008-09-26T14:09:56.533000-04:00 | 2008-09-26T14:09:56.533000-04:00 | {"id": 12634957, "body": "Committed revision 699442.", "user": "Patrick D. Hunt", "created_at": "2008-09-26T14:09:56.533000-04:00", "updated_at": "2008-09-26T14:09:56.533000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397980/comment/12634957", "id": "12634957", "autho... |
141 | 12,635,125 | 21 | Hudson | Integrated in ZooKeeper-trunk #96 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/96/]) | 2008-09-27T06:45:05.280000-04:00 | 2008-09-27T06:45:05.280000-04:00 | {"id": 12635125, "body": "Integrated in ZooKeeper-trunk #96 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/96/])", "user": "Hudson", "created_at": "2008-09-27T06:45:05.280000-04:00", "updated_at": "2008-09-27T06:45:05.280000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
142 | 12,642,675 | 21 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.730000-04:00 | 2008-10-25T21:10:37.730000-04:00 | {"id": 12642675, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.730000-04:00", "updated_at": "2008-10-25T21:10:37.730000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397980/comment/12642675", "id": "126... |
143 | 12,609,992 | 25 | Patrick D. Hunt | Submitting ZooKeeper FUSE support. | 2008-07-02T14:04:55.571000-04:00 | 2008-07-02T14:04:55.571000-04:00 | {"id": 12609992, "body": "Submitting ZooKeeper FUSE support.", "user": "Patrick D. Hunt", "created_at": "2008-07-02T14:04:55.571000-04:00", "updated_at": "2008-07-02T14:04:55.571000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397986/comment/12609992", "id": "12609992"... |
144 | 12,609,993 | 25 | Patrick D. Hunt | Please review and provide feedback. I've tested this on an Ubuntu Linux system. See the README.txt for details on how to build. | 2008-07-02T14:06:03.894000-04:00 | 2008-07-02T14:06:03.894000-04:00 | {"id": 12609993, "body": "Please review and provide feedback. I've tested this on an Ubuntu Linux system. See the README.txt for details on how to build.", "user": "Patrick D. Hunt", "created_at": "2008-07-02T14:06:03.894000-04:00", "updated_at": "2008-07-02T14:06:03.894000-04:00", "_provider": "jira", "raw": {"self": ... |
145 | 12,610,035 | 25 | Mahadev Konar | this patch contains files like configure and others which are autogenerated by autoconf. we should get rid of them and change out README to say run autoconf --- and then do ...... | 2008-07-02T16:31:22.833000-04:00 | 2008-07-02T16:31:22.833000-04:00 | {"id": 12610035, "body": "this patch contains files like configure and others which are autogenerated by autoconf. we should get rid of them and change out README to say run autoconf --- and then do ...... ", "user": "Mahadev Konar", "created_at": "2008-07-02T16:31:22.833000-04:00", "updated_at": "2008-07-02T16:31:22.8... |
146 | 12,610,044 | 25 | Patrick D. Hunt | Updated the patch to remove some autoconf generated files that don't need to be committed to SVN. | 2008-07-02T16:51:33.588000-04:00 | 2008-07-02T16:51:33.588000-04:00 | {"id": 12610044, "body": "Updated the patch to remove some autoconf generated files that don't need to be committed to SVN.", "user": "Patrick D. Hunt", "created_at": "2008-07-02T16:51:33.588000-04:00", "updated_at": "2008-07-02T16:51:33.588000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jir... |
147 | 12,613,718 | 25 | Andrew Kornev | This patch replaces the existing FUSE configure.ac: the configure.ac script uses some macros that are not supported by the pre-2.61 autoconf tools. It's safe to drop the macros from the script for the sake of compatibility with autotools 2.59. The C client is also compatible with version 2.59.
Other than that I was ab... | 2008-07-15T16:23:18.526000-04:00 | 2008-07-15T16:23:18.526000-04:00 | {"id": 12613718, "body": "This patch replaces the existing FUSE configure.ac: the configure.ac script uses some macros that are not supported by the pre-2.61 autoconf tools. It's safe to drop the macros from the script for the sake of compatibility with autotools 2.59. The C client is also compatible with version 2.59.... |
148 | 12,621,874 | 25 | Mahadev Konar | the patch looks good. Some comments --
1) src/contrib/zkfuse/AUTHORS.txt
can we remove this file? Usually in apache authors tags are avoided since they are chanaged over and over by others and mentioning that the code belongs to someone becomes wrong to say.
2) src/contrib/zkfuse/ChangeLog
can we remove this fil... | 2008-08-12T12:30:52.945000-04:00 | 2008-08-12T12:30:52.945000-04:00 | {"id": 12621874, "body": "the patch looks good. Some comments -- \n\n1) src/contrib/zkfuse/AUTHORS.txt\ncan we remove this file? Usually in apache authors tags are avoided since they are chanaged over and over by others and mentioning that the code belongs to someone becomes wrong to say. \n\n2) src/contrib/zkfuse/Chan... |
149 | 12,622,296 | 25 | Mahadev Konar | this patch has changes with authors.txt removed and changelog cleaned up./ | 2008-08-13T13:53:54.013000-04:00 | 2008-08-13T13:53:54.013000-04:00 | {"id": 12622296, "body": "this patch has changes with authors.txt removed and changelog cleaned up./", "user": "Mahadev Konar", "created_at": "2008-08-13T13:53:54.013000-04:00", "updated_at": "2008-08-13T13:53:54.013000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/123979... |
150 | 12,622,298 | 25 | Mahadev Konar | I just committed this. Thanks Swee, Bart, Pat and Andrew. | 2008-08-13T13:59:36.429000-04:00 | 2008-08-13T13:59:36.429000-04:00 | {"id": 12622298, "body": "I just committed this. Thanks Swee, Bart, Pat and Andrew.", "user": "Mahadev Konar", "created_at": "2008-08-13T13:59:36.429000-04:00", "updated_at": "2008-08-13T13:59:36.429000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397986/comment/126222... |
151 | 12,622,509 | 25 | Hudson | Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/]) | 2008-08-14T06:44:32.122000-04:00 | 2008-08-14T06:44:32.122000-04:00 | {"id": 12622509, "body": "Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/])", "user": "Hudson", "created_at": "2008-08-14T06:44:32.122000-04:00", "updated_at": "2008-08-14T06:44:32.122000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
152 | 12,642,677 | 25 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.810000-04:00 | 2008-10-25T21:10:37.810000-04:00 | {"id": 12642677, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.810000-04:00", "updated_at": "2008-10-25T21:10:37.810000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397986/comment/12642677", "id": "126... |
153 | 12,616,628 | 32 | Andrew Kornev | Part of ZOOKEEPER-38 patch | 2008-07-24T16:17:44.218000-04:00 | 2008-07-24T16:17:44.218000-04:00 | {"id": 12616628, "body": "Part of ZOOKEEPER-38 patch", "user": "Andrew Kornev", "created_at": "2008-07-24T16:17:44.218000-04:00", "updated_at": "2008-07-24T16:17:44.218000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397997/comment/12616628", "id": "12616628", "author"... |
154 | 12,636,166 | 32 | Mahadev Konar | fixed as part of ZOOKEEPER-38. | 2008-10-01T16:51:45.451000-04:00 | 2008-10-01T16:51:45.451000-04:00 | {"id": 12636166, "body": "fixed as part of ZOOKEEPER-38.", "user": "Mahadev Konar", "created_at": "2008-10-01T16:51:45.451000-04:00", "updated_at": "2008-10-01T16:51:45.451000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397997/comment/12636166", "id": "12636166", "aut... |
155 | 12,642,679 | 32 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.874000-04:00 | 2008-10-25T21:10:37.874000-04:00 | {"id": 12642679, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.874000-04:00", "updated_at": "2008-10-25T21:10:37.874000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397997/comment/12642679", "id": "126... |
156 | 12,604,321 | 38 | Andrew Kornev | Attached are the patches for the db file header and the CRC [ZOOKEEPER-32] features, and the unit tests. The patches are generated against the latest code in Source Forge SVN.
The patch introduces a new zookeeper package: the persistence layer. The package declares a number of public (zookeeper server scope) interface... | 2008-06-11T16:13:11.848000-04:00 | 2008-06-11T16:13:11.848000-04:00 | {"id": 12604321, "body": "Attached are the patches for the db file header and the CRC [ZOOKEEPER-32] features, and the unit tests. The patches are generated against the latest code in Source Forge SVN.\n\nThe patch introduces a new zookeeper package: the persistence layer. The package declares a number of public (zooke... |
157 | 12,604,352 | 38 | Mahadev Konar | lets wait for code base to have moved and the patch would need header changes. Cancelling the patch for now. | 2008-06-11T17:47:40.570000-04:00 | 2008-06-11T17:47:40.570000-04:00 | {"id": 12604352, "body": "lets wait for code base to have moved and the patch would need header changes. Cancelling the patch for now.", "user": "Mahadev Konar", "created_at": "2008-06-11T17:47:40.570000-04:00", "updated_at": "2008-06-11T17:47:40.570000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apach... |
158 | 12,607,147 | 38 | Mahadev Konar | i was reading through the patch. It would be good if a broad overview of what each class is doing ..lso there is a lack of javadocs :) (it would help if javadocs are provided while reviewing ).... | 2008-06-23T01:54:58.552000-04:00 | 2008-06-23T01:57:05.425000-04:00 | {"id": 12607147, "body": "i was reading through the patch. It would be good if a broad overview of what each class is doing ..lso there is a lack of javadocs :) (it would help if javadocs are provided while reviewing ).... ", "user": "Mahadev Konar", "created_at": "2008-06-23T01:54:58.552000-04:00", "updated_at": "2008... |
159 | 12,608,889 | 38 | Andrew Kornev | The same patch but is now built against the apache SVN. Please review. | 2008-06-27T15:14:38.720000-04:00 | 2008-06-27T15:14:38.720000-04:00 | {"id": 12608889, "body": "The same patch but is now built against the apache SVN. Please review.", "user": "Andrew Kornev", "created_at": "2008-06-27T15:14:38.720000-04:00", "updated_at": "2008-06-27T15:14:38.720000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/c... |
160 | 12,608,899 | 38 | Mahadev Konar | Property changes on: C:\work\apache\zookeeper\trunk\src\java\test\org\apache\zookeeper\server\DataTreeMock.java
___________________________________________________________________
Name: svn:eol-style
+ native
there are some changes that are not a patch fo this patch i think and are alos not relative to the src tre... | 2008-06-27T15:56:24.261000-04:00 | 2008-06-27T15:56:24.261000-04:00 | {"id": 12608899, "body": "Property changes on: C:\\work\\apache\\zookeeper\\trunk\\src\\java\\test\\org\\apache\\zookeeper\\server\\DataTreeMock.java\n___________________________________________________________________\nName: svn:eol-style\n + native\n\n\nthere are some changes that are not a patch fo this patch i th... |
161 | 12,608,932 | 38 | Andrew Kornev | Uploading the patch (fixed the paths for the property changes) | 2008-06-27T18:12:38.537000-04:00 | 2008-06-27T18:12:38.537000-04:00 | {"id": 12608932, "body": "Uploading the patch (fixed the paths for the property changes)", "user": "Andrew Kornev", "created_at": "2008-06-27T18:12:38.537000-04:00", "updated_at": "2008-06-27T18:12:38.537000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/1... |
162 | 12,611,885 | 38 | Mahadev Konar | the patch looks good --- here are some of my comments ---
also I am not finished reviewing it :). its a long patch ---
0) overall there are too many interfaces in the patch. though i uinderstand that interfaces make things pluggable but I think we should restrict only wehn we need it and create interfaces only when... | 2008-07-08T22:29:45.131000-04:00 | 2008-07-08T22:29:45.131000-04:00 | {"id": 12611885, "body": "the patch looks good --- here are some of my comments --- \n\nalso I am not finished reviewing it :). its a long patch --- \n\n0) overall there are too many interfaces in the patch. though i uinderstand that interfaces make things pluggable but I think we should restrict only wehn we need it a... |
163 | 12,612,208 | 38 | Andrew Kornev | While JIRA comments is not the best place to discuss basics of object-oriented design, I'd like to point out that interfaces are not about "pluggability" and the number of potential implementations is not an indication of whether or not an interface should be introduced. I highly recommend the reviewer take another loo... | 2008-07-09T14:03:33.332000-04:00 | 2008-07-09T14:03:33.332000-04:00 | {"id": 12612208, "body": "While JIRA comments is not the best place to discuss basics of object-oriented design, I'd like to point out that interfaces are not about \"pluggability\" and the number of potential implementations is not an indication of whether or not an interface should be introduced. I highly recommend t... |
164 | 12,613,027 | 38 | Andrew Kornev | Added more javadocs, use the URI class for passing provider URLs, implemented support for terminating the server if the database files format is not supported (wrong version). | 2008-07-11T20:52:10.581000-04:00 | 2008-07-11T20:52:10.581000-04:00 | {"id": 12613027, "body": "Added more javadocs, use the URI class for passing provider URLs, implemented support for terminating the server if the database files format is not supported (wrong version).", "user": "Andrew Kornev", "created_at": "2008-07-11T20:52:10.581000-04:00", "updated_at": "2008-07-11T20:52:10.581000... |
165 | 12,614,540 | 38 | Benjamin Reed | I really like how you pulled the code out of the scattered locations around the source tree. I wish you would have pulled them into a couple of classes rather than scattering them into new classes. It seems like it would be really nice to have a Snapshot class and a TxnLog class. I think classes like SerializeUtils, As... | 2008-07-17T18:03:12.589000-04:00 | 2008-07-17T18:03:12.589000-04:00 | {"id": 12614540, "body": "I really like how you pulled the code out of the scattered locations around the source tree. I wish you would have pulled them into a couple of classes rather than scattering them into new classes. It seems like it would be really nice to have a Snapshot class and a TxnLog class. I think class... |
166 | 12,616,627 | 38 | Andrew Kornev | How's the cracking been going so far? | 2008-07-24T16:16:03.403000-04:00 | 2008-07-24T16:16:03.403000-04:00 | {"id": 12616627, "body": "How's the cracking been going so far?", "user": "Andrew Kornev", "created_at": "2008-07-24T16:16:03.403000-04:00", "updated_at": "2008-07-24T16:16:03.403000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/12616627", "id": "12616627... |
167 | 12,616,637 | 38 | Mahadev Konar | i am working on it... should get it out by next week .... | 2008-07-24T16:25:25.966000-04:00 | 2008-07-24T16:25:25.966000-04:00 | {"id": 12616637, "body": "i am working on it... should get it out by next week .... ", "user": "Mahadev Konar", "created_at": "2008-07-24T16:25:25.966000-04:00", "updated_at": "2008-07-24T16:25:25.966000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/12616... |
168 | 12,617,488 | 38 | Mahadev Konar | cancelling the patch for now. ill upload a new version of the patch with Ben's comments incorporated. | 2008-07-28T13:40:48.084000-04:00 | 2008-07-28T13:40:48.084000-04:00 | {"id": 12617488, "body": "cancelling the patch for now. ill upload a new version of the patch with Ben's comments incorporated. ", "user": "Mahadev Konar", "created_at": "2008-07-28T13:40:48.084000-04:00", "updated_at": "2008-07-28T13:40:48.084000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/... |
169 | 12,617,700 | 38 | Benjamin Reed | Mahadev is simplifying the patch. | 2008-07-29T01:10:42.396000-04:00 | 2008-07-29T01:10:42.396000-04:00 | {"id": 12617700, "body": "Mahadev is simplifying the patch.", "user": "Benjamin Reed", "created_at": "2008-07-29T01:10:42.396000-04:00", "updated_at": "2008-07-29T01:10:42.396000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/12617700", "id": "12617700", "... |
170 | 12,622,753 | 38 | Mahadev Konar | here's a first look at the patch. I am still in process of cleaning it up and adding javadocs. Please review and comment. Ben wil be making changes to the tests. | 2008-08-14T20:05:55.543000-04:00 | 2008-08-14T20:05:55.543000-04:00 | {"id": 12622753, "body": "here's a first look at the patch. I am still in process of cleaning it up and adding javadocs. Please review and comment. Ben wil be making changes to the tests. ", "user": "Mahadev Konar", "created_at": "2008-08-14T20:05:55.543000-04:00", "updated_at": "2008-08-14T20:05:55.543000-04:00", "_pr... |
171 | 12,624,978 | 38 | Mahadev Konar | here is a patch that applies to the trunk.
the last 2 commits made the patch stale. | 2008-08-22T17:03:34.573000-04:00 | 2008-08-22T17:03:34.573000-04:00 | {"id": 12624978, "body": "here is a patch that applies to the trunk. \nthe last 2 commits made the patch stale.", "user": "Mahadev Konar", "created_at": "2008-08-22T17:03:34.573000-04:00", "updated_at": "2008-08-22T17:03:34.573000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/... |
172 | 12,628,804 | 38 | Mahadev Konar | this is the latest updated patch that applies to the trunk ...
| 2008-09-05T20:42:02.531000-04:00 | 2008-09-05T20:42:02.531000-04:00 | {"id": 12628804, "body": "this is the latest updated patch that applies to the trunk ... \n", "user": "Mahadev Konar", "created_at": "2008-09-05T20:42:02.531000-04:00", "updated_at": "2008-09-05T20:42:02.531000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/commen... |
173 | 12,632,052 | 38 | Mahadev Konar | Here is a preliminary patch. I redid the patch for this issue. THe previous patch was complex. Now there are just two calss in the persistence layer. One for snapshot and the other for logs. There is another class FileTxnSnapLog that provides conviniecne methods for using the txnlog and snapshots. I think this is much ... | 2008-09-17T21:57:40.080000-04:00 | 2008-09-17T21:57:40.080000-04:00 | {"id": 12632052, "body": "Here is a preliminary patch. I redid the patch for this issue. THe previous patch was complex. Now there are just two calss in the persistence layer. One for snapshot and the other for logs. There is another class FileTxnSnapLog that provides conviniecne methods for using the txnlog and snapsh... |
174 | 12,632,054 | 38 | Mahadev Konar | forgot to mention that this does not pass the tests. I am still workong on making it more cleaner :) and pass the tests. | 2008-09-17T21:59:05.844000-04:00 | 2008-09-17T21:59:05.844000-04:00 | {"id": 12632054, "body": "forgot to mention that this does not pass the tests. I am still workong on making it more cleaner :) and pass the tests.", "user": "Mahadev Konar", "created_at": "2008-09-17T21:59:05.844000-04:00", "updated_at": "2008-09-17T21:59:05.844000-04:00", "_provider": "jira", "raw": {"self": "https://... |
175 | 12,632,381 | 38 | Mahadev Konar | here is aptch that passes the tests (exception recovery test). I am making some more interface cleanup changes. Ben can you take a look at this... | 2008-09-18T16:55:02.583000-04:00 | 2008-09-18T16:55:02.583000-04:00 | {"id": 12632381, "body": "here is aptch that passes the tests (exception recovery test). I am making some more interface cleanup changes. Ben can you take a look at this...", "user": "Mahadev Konar", "created_at": "2008-09-18T16:55:02.583000-04:00", "updated_at": "2008-09-18T16:55:02.583000-04:00", "_provider": "jira",... |
176 | 12,633,537 | 38 | Mahadev Konar | here is patch that passes all the tests. | 2008-09-22T18:19:48.967000-04:00 | 2008-09-22T18:19:48.967000-04:00 | {"id": 12633537, "body": "here is patch that passes all the tests. ", "user": "Mahadev Konar", "created_at": "2008-09-22T18:19:48.967000-04:00", "updated_at": "2008-09-22T18:19:48.967000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/12633537", "id": "1263... |
177 | 12,634,267 | 38 | Benjamin Reed | This looks great Mahadev. Just small comments:
- In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer
- In FileSnapLog.deserialize() if the snapshot ... | 2008-09-24T15:50:04.089000-04:00 | 2008-09-24T15:50:04.089000-04:00 | {"id": 12634267, "body": "This looks great Mahadev. Just small comments:\n\n- In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This same comment applies to Leader and QuorumPeer\n- In FileSnapLog.d... |
178 | 12,634,616 | 38 | Mahadev Konar | here is an updated patch. I cleared the patch with nice javadocs and more testing. Fixed a few bugs i found during the testing.
bq. In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the configuration methods. (This ... | 2008-09-25T16:59:40.707000-04:00 | 2008-09-25T17:00:10.993000-04:00 | {"id": 12634616, "body": "here is an updated patch. I cleared the patch with nice javadocs and more testing. Fixed a few bugs i found during the testing. \n\n bq. In ZooKeeperServerMain you changed from using the configuration methods to putting everything in the constructor. I think we should stick with the c... |
179 | 12,634,681 | 38 | Mahadev Konar | the last patch went stale with commiting of ZOOKEEPER-139.
| 2008-09-25T18:57:41.848000-04:00 | 2008-09-25T18:57:41.848000-04:00 | {"id": 12634681, "body": "the last patch went stale with commiting of ZOOKEEPER-139.\n\n", "user": "Mahadev Konar", "created_at": "2008-09-25T18:57:41.848000-04:00", "updated_at": "2008-09-25T18:57:41.848000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/1... |
180 | 12,635,561 | 38 | Mahadev Konar | this patch reverts backs the changes for ZOOKEEPER-82. my patch over rode all the changes. | 2008-09-29T18:28:26.578000-04:00 | 2008-09-29T18:28:26.578000-04:00 | {"id": 12635561, "body": "this patch reverts backs the changes for ZOOKEEPER-82. my patch over rode all the changes.", "user": "Mahadev Konar", "created_at": "2008-09-29T18:28:26.578000-04:00", "updated_at": "2008-09-29T18:28:26.578000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/ap... |
181 | 12,635,921 | 38 | Mahadev Konar | the last patch had a problem with compiling jmx ... since the jmx build is broken is didnt realize that I broke the jmx build with my patch... | 2008-09-30T20:54:34.495000-04:00 | 2008-09-30T20:54:34.495000-04:00 | {"id": 12635921, "body": "the last patch had a problem with compiling jmx ... since the jmx build is broken is didnt realize that I broke the jmx build with my patch... ", "user": "Mahadev Konar", "created_at": "2008-09-30T20:54:34.495000-04:00", "updated_at": "2008-09-30T20:54:34.495000-04:00", "_provider": "jira", "r... |
182 | 12,635,956 | 38 | Benjamin Reed | +1 Looks good mahadev. Marked as an Incompatible change since the data format is not backwards compatible. | 2008-10-01T02:28:18.489000-04:00 | 2008-10-01T02:28:18.489000-04:00 | {"id": 12635956, "body": "+1 Looks good mahadev. Marked as an Incompatible change since the data format is not backwards compatible.", "user": "Benjamin Reed", "created_at": "2008-10-01T02:28:18.489000-04:00", "updated_at": "2008-10-01T02:28:18.489000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.... |
183 | 12,636,329 | 38 | Hudson | Integrated in ZooKeeper-trunk #101 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/101/])
| 2008-10-02T06:46:01.604000-04:00 | 2008-10-02T06:46:01.604000-04:00 | {"id": 12636329, "body": "Integrated in ZooKeeper-trunk #101 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/101/])\n ", "user": "Hudson", "created_at": "2008-10-02T06:46:01.604000-04:00", "updated_at": "2008-10-02T06:46:01.604000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.or... |
184 | 12,642,681 | 38 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:37.937000-04:00 | 2008-10-25T21:10:37.937000-04:00 | {"id": 12642681, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:37.937000-04:00", "updated_at": "2008-10-25T21:10:37.937000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398003/comment/12642681", "id": "126... |
185 | 12,609,405 | 41 | Mahadev Konar | this patch fixes the current scripts to work with the svn changes and log4 properties file not being in the zookeeper.jar. | 2008-06-30T19:43:29.460000-04:00 | 2008-06-30T19:43:29.460000-04:00 | {"id": 12609405, "body": "this patch fixes the current scripts to work with the svn changes and log4 properties file not being in the zookeeper.jar.", "user": "Mahadev Konar", "created_at": "2008-06-30T19:43:29.460000-04:00", "updated_at": "2008-06-30T19:43:29.460000-04:00", "_provider": "jira", "raw": {"self": "https:... |
186 | 12,610,348 | 41 | Benjamin Reed | +1 Brilliant patch. The engineering insights are stunning! So simple, yet so powerful! | 2008-07-03T17:25:31.347000-04:00 | 2008-07-03T17:25:31.347000-04:00 | {"id": 12610348, "body": "+1 Brilliant patch. The engineering insights are stunning! So simple, yet so powerful!", "user": "Benjamin Reed", "created_at": "2008-07-03T17:25:31.347000-04:00", "updated_at": "2008-07-03T17:25:31.347000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/... |
187 | 12,610,352 | 41 | Mahadev Konar | I just committed this. Thanks Ben for appreciating the great engineering talent!! :) | 2008-07-03T17:31:30.511000-04:00 | 2008-07-03T17:31:30.511000-04:00 | {"id": 12610352, "body": "I just committed this. Thanks Ben for appreciating the great engineering talent!! :) ", "user": "Mahadev Konar", "created_at": "2008-07-03T17:31:30.511000-04:00", "updated_at": "2008-07-03T17:31:30.511000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/i... |
188 | 12,611,520 | 41 | Hudson | Integrated in ZooKeeper-trunk #16 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/16/]) | 2008-07-08T06:42:48.671000-04:00 | 2008-07-08T06:42:48.671000-04:00 | {"id": 12611520, "body": "Integrated in ZooKeeper-trunk #16 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/16/])", "user": "Hudson", "created_at": "2008-07-08T06:42:48.671000-04:00", "updated_at": "2008-07-08T06:42:48.671000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
189 | 12,642,682 | 41 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:38-04:00 | 2008-10-25T21:10:38-04:00 | {"id": 12642682, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:38-04:00", "updated_at": "2008-10-25T21:10:38-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398006/comment/12642682", "id": "12642682", "autho... |
190 | 12,615,678 | 42 | Patrick D. Hunt | Flavio please submit a patch directly to this JIRA (needed to address ip issues), reassign to Ben after for review. Thanks. | 2008-07-22T13:13:02.002000-04:00 | 2008-07-22T13:13:02.002000-04:00 | {"id": 12615678, "body": "Flavio please submit a patch directly to this JIRA (needed to address ip issues), reassign to Ben after for review. Thanks.", "user": "Patrick D. Hunt", "created_at": "2008-07-22T13:13:02.002000-04:00", "updated_at": "2008-07-22T13:13:02.002000-04:00", "_provider": "jira", "raw": {"self": "htt... |
191 | 12,616,449 | 42 | Flavio Paiva Junqueira | Changes the default leader election algorithm, and sets the default port to 2182. | 2008-07-24T07:23:41.643000-04:00 | 2008-07-24T07:23:41.643000-04:00 | {"id": 12616449, "body": "Changes the default leader election algorithm, and sets the default port to 2182.", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-24T07:23:41.643000-04:00", "updated_at": "2008-07-24T07:23:41.643000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/ap... |
192 | 12,618,862 | 42 | Patrick D. Hunt | Committed revision 681503. | 2008-07-31T17:23:06.293000-04:00 | 2008-07-31T17:23:06.293000-04:00 | {"id": 12618862, "body": "Committed revision 681503.", "user": "Patrick D. Hunt", "created_at": "2008-07-31T17:23:06.293000-04:00", "updated_at": "2008-07-31T17:23:06.293000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398007/comment/12618862", "id": "12618862", "autho... |
193 | 12,619,398 | 42 | Hudson | Integrated in ZooKeeper-trunk #42 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/42/]) | 2008-08-03T21:45:20.067000-04:00 | 2008-08-03T21:45:20.067000-04:00 | {"id": 12619398, "body": "Integrated in ZooKeeper-trunk #42 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/42/])", "user": "Hudson", "created_at": "2008-08-03T21:45:20.067000-04:00", "updated_at": "2008-08-03T21:45:20.067000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
194 | 12,642,683 | 42 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:38.042000-04:00 | 2008-10-25T21:10:38.042000-04:00 | {"id": 12642683, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:38.042000-04:00", "updated_at": "2008-10-25T21:10:38.042000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398007/comment/12642683", "id": "126... |
195 | 12,604,235 | 44 | Benjamin Reed | Actually we have been meaning to remove the sort. It causes an unnecessary burden on the server. If we really want things sorted, we should do it in the client library. The question is: do we really want things sorted? Especially in Java it is easy enough for the user to sort the list themself if needed. | 2008-06-11T10:36:26.872000-04:00 | 2008-06-11T10:36:26.872000-04:00 | {"id": 12604235, "body": "Actually we have been meaning to remove the sort. It causes an unnecessary burden on the server. If we really want things sorted, we should do it in the client library. The question is: do we really want things sorted? Especially in Java it is easy enough for the user to sort the list themself... |
196 | 12,604,265 | 44 | Patrick D. Hunt | My personal preference would be to leave it unsorted and let the client sort if needed. That way you only pay the perf penalty if you need the children sorted. Either way we should address this -- remove the unnecessary sort and make sure to document that the results are unsorted. | 2008-06-11T12:22:41.438000-04:00 | 2008-06-11T12:22:41.438000-04:00 | {"id": 12604265, "body": "My personal preference would be to leave it unsorted and let the client sort if needed. That way you only pay the perf penalty if you need the children sorted. Either way we should address this -- remove the unnecessary sort and make sure to document that the results are unsorted.", "user": "P... |
197 | 12,604,288 | 44 | Stu Hood | I'd be fine with the sort being removed from getChildren, but fixing the natural sorting problem is still important. It causes undue pain for the client to have to perform an integer-aware sort to get the proper ordering for locks.
My workaround was to pad the sequence value before appending it to the path in create:
... | 2008-06-11T13:53:46.448000-04:00 | 2008-06-11T13:53:46.448000-04:00 | {"id": 12604288, "body": "I'd be fine with the sort being removed from getChildren, but fixing the natural sorting problem is still important. It causes undue pain for the client to have to perform an integer-aware sort to get the proper ordering for locks.\n\nMy workaround was to pad the sequence value before appendin... |
198 | 12,604,290 | 44 | Benjamin Reed | +1 Excellent suggestion! | 2008-06-11T14:02:16.207000-04:00 | 2008-06-11T14:02:16.207000-04:00 | {"id": 12604290, "body": "+1 Excellent suggestion!", "user": "Benjamin Reed", "created_at": "2008-06-11T14:02:16.207000-04:00", "updated_at": "2008-06-11T14:02:16.207000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/comment/12604290", "id": "12604290", "author": ... |
199 | 12,604,292 | 44 | Patrick D. Hunt | +1, sounds like a great addition to a FAQ.
Assigning to Ben to remove the sort and document appropriately.
| 2008-06-11T14:06:09.693000-04:00 | 2008-06-11T14:06:09.693000-04:00 | {"id": 12604292, "body": "+1, sounds like a great addition to a FAQ.\n\nAssigning to Ben to remove the sort and document appropriately.\n", "user": "Patrick D. Hunt", "created_at": "2008-06-11T14:06:09.693000-04:00", "updated_at": "2008-06-11T14:06:09.693000-04:00", "_provider": "jira", "raw": {"self": "https://issues.... |
200 | 12,619,159 | 44 | Jakob Homan | I've gone ahead and implemented the patch as discussed, which does the following:
* Implements the padding for sequential file names, padding ten zeroes to the name (enough to handle as many digits as can be generated by a 32-bit int). This allows the names to be sorted by natural order.
* Removed the server sor... | 2008-08-01T18:55:03.981000-04:00 | 2008-08-01T18:55:03.981000-04:00 | {"id": 12619159, "body": "I've gone ahead and implemented the patch as discussed, which does the following:\n * Implements the padding for sequential file names, padding ten zeroes to the name (enough to handle as many digits as can be generated by a 32-bit int). This allows the names to be sorted by natural order.\... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.