id int64 1 37.7k | comment_id int64 12.6M 18M | issue_id stringlengths 1 4 | user stringlengths 1 30 | body stringlengths 1 101k | created_at stringdate 2008-06-06 18:03:50-0400 2025-10-01 11:49:43-0400 | updated_at stringdate 2008-06-06 18:03:50-0400 2025-10-01 11:49:43-0400 | metadata stringlengths 1.46k 208k |
|---|---|---|---|---|---|---|---|
201 | 12,619,160 | 44 | Jakob Homan | Implements the changes discussed in the Jira. | 2008-08-01T18:55:35.878000-04:00 | 2008-08-01T18:55:35.878000-04:00 | {"id": 12619160, "body": "Implements the changes discussed in the Jira.", "user": "Jakob Homan", "created_at": "2008-08-01T18:55:35.878000-04:00", "updated_at": "2008-08-01T18:55:35.878000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/comment/12619160", "id": "12... |
202 | 12,619,163 | 44 | Benjamin Reed | +1 Fantastic job Jakob! This looks great. Test cases and everything. | 2008-08-01T19:09:16.250000-04:00 | 2008-08-01T19:09:16.250000-04:00 | {"id": 12619163, "body": "+1 Fantastic job Jakob! This looks great. Test cases and everything.", "user": "Benjamin Reed", "created_at": "2008-08-01T19:09:16.250000-04:00", "updated_at": "2008-08-01T19:09:16.250000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/com... |
203 | 12,619,164 | 44 | Mahadev Konar | +1 .. thanks jakob ....
nit:
is %1$ redundant? i had to look up the formatter in java for this :)... i think %010d should be fine? | 2008-08-01T19:18:24.481000-04:00 | 2008-08-01T19:18:24.481000-04:00 | {"id": 12619164, "body": "+1 .. thanks jakob .... \n\nnit:\n\nis %1$ redundant? i had to look up the formatter in java for this :)... i think %010d should be fine?", "user": "Mahadev Konar", "created_at": "2008-08-01T19:18:24.481000-04:00", "updated_at": "2008-08-01T19:18:24.481000-04:00", "_provider": "jira", "raw": {... |
204 | 12,619,165 | 44 | Jakob Homan | Unnecessary placeholder removed. | 2008-08-01T19:28:09.773000-04:00 | 2008-08-01T19:28:09.773000-04:00 | {"id": 12619165, "body": "Unnecessary placeholder removed.", "user": "Jakob Homan", "created_at": "2008-08-01T19:28:09.773000-04:00", "updated_at": "2008-08-01T19:28:09.773000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/comment/12619165", "id": "12619165", "aut... |
205 | 12,619,169 | 44 | Mahadev Konar | I just committed this. THanks Jakob.
| 2008-08-01T20:09:49.004000-04:00 | 2008-08-01T20:09:49.004000-04:00 | {"id": 12619169, "body": "I just committed this. THanks Jakob. \n", "user": "Mahadev Konar", "created_at": "2008-08-01T20:09:49.004000-04:00", "updated_at": "2008-08-01T20:09:49.004000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/comment/12619169", "id": "126191... |
206 | 12,619,290 | 44 | Stu Hood | This is probably a separate issue, but is anyone worried by the fact that after ~2 billion creates, the sequence number will wrap around and break various algorithms? | 2008-08-02T19:04:49.459000-04:00 | 2008-08-02T19:04:49.459000-04:00 | {"id": 12619290, "body": "This is probably a separate issue, but is anyone worried by the fact that after ~2 billion creates, the sequence number will wrap around and break various algorithms?", "user": "Stu Hood", "created_at": "2008-08-02T19:04:49.459000-04:00", "updated_at": "2008-08-02T19:04:49.459000-04:00", "_pro... |
207 | 12,619,293 | 44 | Mahadev Konar | 2 billion creates seem to be a lot fo creates. also since we are working on an upgrade feature on zookeeper --- we can upgrade the version to be long sometime later ... -- which would make the wrap around 4* 10^18. | 2008-08-02T20:31:42.128000-04:00 | 2008-08-02T20:31:42.128000-04:00 | {"id": 12619293, "body": "2 billion creates seem to be a lot fo creates. also since we are working on an upgrade feature on zookeeper --- we can upgrade the version to be long sometime later ... -- which would make the wrap around 4* 10^18.", "user": "Mahadev Konar", "created_at": "2008-08-02T20:31:42.128000-04:00", "... |
208 | 12,619,400 | 44 | Hudson | Integrated in ZooKeeper-trunk #42 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/42/]) | 2008-08-03T21:45:20.320000-04:00 | 2008-08-03T21:45:20.320000-04:00 | {"id": 12619400, "body": "Integrated in ZooKeeper-trunk #42 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/42/])", "user": "Hudson", "created_at": "2008-08-03T21:45:20.320000-04:00", "updated_at": "2008-08-03T21:45:20.320000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
209 | 12,642,685 | 44 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:38.121000-04:00 | 2008-10-25T21:10:38.121000-04:00 | {"id": 12642685, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:38.121000-04:00", "updated_at": "2008-10-25T21:10:38.121000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398018/comment/12642685", "id": "126... |
210 | 12,604,996 | 45 | Mahadev Konar | do we want to create a zookeeper/site like in hadoop where the web pages are stored?
| 2008-06-13T18:38:17.540000-04:00 | 2008-06-13T18:38:17.540000-04:00 | {"id": 12604996, "body": "do we want to create a zookeeper/site like in hadoop where the web pages are stored?\n", "user": "Mahadev Konar", "created_at": "2008-06-13T18:38:17.540000-04:00", "updated_at": "2008-06-13T18:38:17.540000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/... |
211 | 12,604,997 | 45 | Doug Cutting | > do we want to create a zookeeper/site like in hadoop where the web pages are stored?
Yes. We can use the HBase site as a starting point.
| 2008-06-13T18:44:13.597000-04:00 | 2008-06-13T18:44:13.597000-04:00 | {"id": 12604997, "body": "> do we want to create a zookeeper/site like in hadoop where the web pages are stored? \n\nYes. We can use the HBase site as a starting point.\n", "user": "Doug Cutting", "created_at": "2008-06-13T18:44:13.597000-04:00", "updated_at": "2008-06-13T18:44:13.597000-04:00", "_provider": "jira", "... |
212 | 12,604,999 | 45 | Mahadev Konar | welcome to the world of zookeeper Doug :). | 2008-06-13T18:53:29.415000-04:00 | 2008-06-13T18:53:29.415000-04:00 | {"id": 12604999, "body": "welcome to the world of zookeeper Doug :).", "user": "Mahadev Konar", "created_at": "2008-06-13T18:53:29.415000-04:00", "updated_at": "2008-06-13T18:53:29.415000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12604999", "id": "126... |
213 | 12,605,015 | 45 | Patrick D. Hunt | Yes, we will definitely have this directory. If you look on the svn site you'll see that the empty "site" already exists:
http://svn.apache.org/repos/asf/hadoop/zookeeper/
I didn't include setting up "site" in this jira issue as I had planned "site" as a step after setting up the docs src/docs directories under zookee... | 2008-06-13T20:25:45.053000-04:00 | 2008-06-13T20:25:45.053000-04:00 | {"id": 12605015, "body": "Yes, we will definitely have this directory. If you look on the svn site you'll see that the empty \"site\" already exists:\nhttp://svn.apache.org/repos/asf/hadoop/zookeeper/\n\nI didn't include setting up \"site\" in this jira issue as I had planned \"site\" as a step after setting up the doc... |
214 | 12,607,761 | 45 | Patrick D. Hunt | I've applied the changes specified in this jira (except for docs which I will do separately)
Please review the repository and let me know if you see issues. I verified that the code can be built (ant/eclipse) and that the tests all pass. If you see anything else let me know - Otw I'll declare SVN open to all committer... | 2008-06-24T17:06:39.666000-04:00 | 2008-06-24T17:06:39.666000-04:00 | {"id": 12607761, "body": "I've applied the changes specified in this jira (except for docs which I will do separately)\n\nPlease review the repository and let me know if you see issues. I verified that the code can be built (ant/eclipse) and that the tests all pass. If you see anything else let me know - Otw I'll decla... |
215 | 12,607,811 | 45 | Mahadev Konar | 1) we have Chagelog in java and in c. This is confusing. We should just have a top level Changelog unless we want to make two speerate releases for c client, java client and one for servers. Its better to release zookeeper as one package since if we have more than c/java bindings then it would be problematic making rel... | 2008-06-24T20:07:39.075000-04:00 | 2008-06-24T20:07:39.075000-04:00 | {"id": 12607811, "body": "1) we have Chagelog in java and in c. This is confusing. We should just have a top level Changelog unless we want to make two speerate releases for c client, java client and one for servers. Its better to release zookeeper as one package since if we have more than c/java bindings then it would... |
216 | 12,607,814 | 45 | Mahadev Konar | 2) we anyway need a top level changelog for other stuff that is not either c or java.
3) workspace/zookeeper_apache/src/java/main
can we use some other name other than main..
i like core?
| 2008-06-24T20:14:39.923000-04:00 | 2008-06-24T20:14:39.923000-04:00 | {"id": 12607814, "body": "2) we anyway need a top level changelog for other stuff that is not either c or java. \n3) workspace/zookeeper_apache/src/java/main\n\ncan we use some other name other than main.. \ni like core? \n\n\n", "user": "Mahadev Konar", "created_at": "2008-06-24T20:14:39.923000-04:00", "updated_at": "... |
217 | 12,608,180 | 45 | Patrick D. Hunt | patch to fix log4j integration with tests.
| 2008-06-25T16:47:41.472000-04:00 | 2008-06-25T16:47:41.472000-04:00 | {"id": 12608180, "body": "patch to fix log4j integration with tests.\n", "user": "Patrick D. Hunt", "created_at": "2008-06-25T16:47:41.472000-04:00", "updated_at": "2008-06-25T16:47:41.472000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12608180", "id": ... |
218 | 12,608,199 | 45 | Mahadev Konar | +1 for the patch. | 2008-06-25T17:22:27.163000-04:00 | 2008-06-25T17:22:27.163000-04:00 | {"id": 12608199, "body": "+1 for the patch. ", "user": "Mahadev Konar", "created_at": "2008-06-25T17:22:27.163000-04:00", "updated_at": "2008-06-25T17:22:27.163000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12608199", "id": "12608199", "author": {"self... |
219 | 12,608,215 | 45 | Patrick D. Hunt | Re Mahadev comments 6/24: My comments:
1&2) Yes, we should move the changelog files from c/java up to the toplevel. At the same time change the name to "CHANGES.txt". See hadoop for their process: http://wiki.apache.org/hadoop/HowToRelease
3) no, I don't think we should change the name from src/java/main to src/java/... | 2008-06-25T18:04:58.613000-04:00 | 2008-06-25T18:04:58.613000-04:00 | {"id": 12608215, "body": "Re Mahadev comments 6/24: My comments:\n\n1&2) Yes, we should move the changelog files from c/java up to the toplevel. At the same time change the name to \"CHANGES.txt\". See hadoop for their process: http://wiki.apache.org/hadoop/HowToRelease\n\n3) no, I don't think we should change the name... |
220 | 12,608,483 | 45 | Patrick D. Hunt | add timestamp to log4j console output in order to help with test debugging on hudson. | 2008-06-26T12:28:06.094000-04:00 | 2008-06-26T12:28:06.094000-04:00 | {"id": 12608483, "body": "add timestamp to log4j console output in order to help with test debugging on hudson.", "user": "Patrick D. Hunt", "created_at": "2008-06-26T12:28:06.094000-04:00", "updated_at": "2008-06-26T12:28:06.094000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2... |
221 | 12,608,495 | 45 | Flavio Paiva Junqueira | +1, looks good to me | 2008-06-26T12:49:54.978000-04:00 | 2008-06-26T12:49:54.978000-04:00 | {"id": 12608495, "body": "+1, looks good to me", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-26T12:49:54.978000-04:00", "updated_at": "2008-06-26T12:49:54.978000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12608495", "id": "12608495", "auth... |
222 | 12,608,578 | 45 | Andrew Kornev | To Mahadev, Pat and other hadoop admirers: I'd like to keep the changelogs for java, c and "other stuff that is not either c or java" in their respective subdirectories. The fact that all those components released in a single package should have no bearing on the location of a source file within the source hierarchy. O... | 2008-06-26T16:54:24.648000-04:00 | 2008-06-26T16:54:24.648000-04:00 | {"id": 12608578, "body": "To Mahadev, Pat and other hadoop admirers: I'd like to keep the changelogs for java, c and \"other stuff that is not either c or java\" in their respective subdirectories. The fact that all those components released in a single package should have no bearing on the location of a source file wi... |
223 | 12,608,579 | 45 | Andrew Kornev | BTW, this config here http://www.apache.org/dev/svn-eol-style.txt is missing an entry for *.cc which is a valid C++ extention.
*.cc = svn:eol-style=native | 2008-06-26T17:00:56.028000-04:00 | 2008-06-26T17:00:56.028000-04:00 | {"id": 12608579, "body": "BTW, this config here http://www.apache.org/dev/svn-eol-style.txt is missing an entry for *.cc which is a valid C++ extention.\n*.cc = svn:eol-style=native", "user": "Andrew Kornev", "created_at": "2008-06-26T17:00:56.028000-04:00", "updated_at": "2008-06-26T17:00:56.028000-04:00", "_provider"... |
224 | 12,608,598 | 45 | Patrick D. Hunt | Andrew, re your comment on changelog - that sounds reasonable but Apache requires that we provide a change log with each release of the project that details every feature added and bug resolved since the last release.
Looking at hadoop core I see that they have a large collection of src (incl c++) and contrib packages... | 2008-06-26T18:06:16.161000-04:00 | 2008-06-26T18:06:16.161000-04:00 | {"id": 12608598, "body": "Andrew, re your comment on changelog - that sounds reasonable but Apache requires that we provide a change log with each release of the project that details every feature added and bug resolved since the last release.\n\nLooking at hadoop core I see that they have a large collection of src (in... |
225 | 12,608,602 | 45 | Patrick D. Hunt | I have committed the two approved patches (log4j). These have address the logging issues on hudson.
However tests are still failing on asf hudson. This is being looked into (and logs w/timestamps should help).
I'm planning to close this issue once hudson is stable. (at that time if there are loose threads on this jir... | 2008-06-26T18:10:00.935000-04:00 | 2008-06-26T18:10:00.935000-04:00 | {"id": 12608602, "body": "I have committed the two approved patches (log4j). These have address the logging issues on hudson.\n\nHowever tests are still failing on asf hudson. This is being looked into (and logs w/timestamps should help).\n\nI'm planning to close this issue once hudson is stable. (at that time if there... |
226 | 12,608,933 | 45 | Patrick D. Hunt | There is an issue on solaris where OP_CONNECT is not triggered for new non-blocking sockets connecting on loopback interface. On wind/linux this is not seen, happens only on solaris, see the following for more background:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6288599
Our code was basically handling this,... | 2008-06-27T18:12:53.002000-04:00 | 2008-06-27T18:12:53.002000-04:00 | {"id": 12608933, "body": "There is an issue on solaris where OP_CONNECT is not triggered for new non-blocking sockets connecting on loopback interface. On wind/linux this is not seen, happens only on solaris, see the following for more background:\n\nhttp://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6288599\n\nOur cod... |
227 | 12,608,950 | 45 | Mahadev Konar | +1 for the solaris patch! | 2008-06-27T20:03:20.022000-04:00 | 2008-06-27T20:03:20.022000-04:00 | {"id": 12608950, "body": "+1 for the solaris patch!", "user": "Mahadev Konar", "created_at": "2008-06-27T20:03:20.022000-04:00", "updated_at": "2008-06-27T20:03:20.022000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12608950", "id": "12608950", "author":... |
228 | 12,608,988 | 45 | Flavio Paiva Junqueira | It's not clear to me whether this patch works fine. The problem that I see is that under solaris the predicate:
((k.readyOps() & SelectionKey.OP_CONNECT) != 0)
will never be true, which means that we don't make the calls inside the if block. Now, you have added a line to change state to CONNECTED to the end of primeC... | 2008-06-28T05:07:00.167000-04:00 | 2008-06-28T05:10:49.267000-04:00 | {"id": 12608988, "body": "It's not clear to me whether this patch works fine. The problem that I see is that under solaris the predicate:\n\n((k.readyOps() & SelectionKey.OP_CONNECT) != 0)\n\nwill never be true, which means that we don't make the calls inside the if block. Now, you have added a line to change state to ... |
229 | 12,608,996 | 45 | Hudson | Integrated in ZooKeeper-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/6/]) | 2008-06-28T06:41:41.575000-04:00 | 2008-06-28T06:41:41.575000-04:00 | {"id": 12608996, "body": "Integrated in ZooKeeper-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/6/])", "user": "Hudson", "created_at": "2008-06-28T06:41:41.575000-04:00", "updated_at": "2008-06-28T06:41:41.575000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/res... |
230 | 12,609,393 | 45 | Patrick D. Hunt | Adds license header to shell scripts.
| 2008-06-30T18:44:56.112000-04:00 | 2008-06-30T18:44:56.112000-04:00 | {"id": 12609393, "body": "Adds license header to shell scripts.\n", "user": "Patrick D. Hunt", "created_at": "2008-06-30T18:44:56.112000-04:00", "updated_at": "2008-06-30T18:44:56.112000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12609393", "id": "1260... |
231 | 12,609,394 | 45 | Mahadev Konar | +1 on the patch for adding headers to shell scripts. | 2008-06-30T18:48:15.368000-04:00 | 2008-06-30T18:48:15.368000-04:00 | {"id": 12609394, "body": "+1 on the patch for adding headers to shell scripts.", "user": "Mahadev Konar", "created_at": "2008-06-30T18:48:15.368000-04:00", "updated_at": "2008-06-30T18:48:15.368000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12609394", ... |
232 | 12,609,395 | 45 | Patrick D. Hunt | solaris and shell license patches have been committed to SVN.
| 2008-06-30T18:49:51.001000-04:00 | 2008-06-30T18:49:51.001000-04:00 | {"id": 12609395, "body": "solaris and shell license patches have been committed to SVN.\n", "user": "Patrick D. Hunt", "created_at": "2008-06-30T18:49:51.001000-04:00", "updated_at": "2008-06-30T18:49:51.001000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/commen... |
233 | 12,611,692 | 45 | Patrick D. Hunt | Closing this issue: SVN is now setup with proper structure and Hudson is also running as part of it's CI loop.
All attached patches have been reviewed and committed to SVN.
I added ZOOKEEPER-70 & ZOOKEEPER-71 to JIRA to track a few loose ends (docs & changelog).
| 2008-07-08T13:08:01.559000-04:00 | 2008-07-08T13:08:01.559000-04:00 | {"id": 12611692, "body": "Closing this issue: SVN is now setup with proper structure and Hudson is also running as part of it's CI loop.\n\nAll attached patches have been reviewed and committed to SVN.\n\nI added ZOOKEEPER-70 & ZOOKEEPER-71 to JIRA to track a few loose ends (docs & changelog).\n", "user": "Patrick D. H... |
234 | 12,642,686 | 45 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:38.156000-04:00 | 2008-10-25T21:10:38.156000-04:00 | {"id": 12642686, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:38.156000-04:00", "updated_at": "2008-10-25T21:10:38.156000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398211/comment/12642686", "id": "126... |
235 | 12,608,221 | 53 | Mahadev Konar | this patch introduces a sleep :(. I know its evil -- this is just a temporary fix to see if we can get the tests running until we around the problem of figuring out that the quorumpeers are stable. | 2008-06-25T18:50:52.958000-04:00 | 2008-06-25T18:50:52.958000-04:00 | {"id": 12608221, "body": "this patch introduces a sleep :(. I know its evil -- this is just a temporary fix to see if we can get the tests running until we around the problem of figuring out that the quorumpeers are stable.", "user": "Mahadev Konar", "created_at": "2008-06-25T18:50:52.958000-04:00", "updated_at": "2008... |
236 | 12,608,222 | 53 | Mahadev Konar | some problem with the patch i uplaoded eariler. | 2008-06-25T18:51:38.543000-04:00 | 2008-06-25T18:51:38.543000-04:00 | {"id": 12608222, "body": "some problem with the patch i uplaoded eariler.", "user": "Mahadev Konar", "created_at": "2008-06-25T18:51:38.543000-04:00", "updated_at": "2008-06-25T18:51:38.543000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399045/comment/12608222", "id"... |
237 | 12,608,223 | 53 | Patrick D. Hunt | +1 looks good for now. | 2008-06-25T18:52:49.430000-04:00 | 2008-06-25T18:52:49.430000-04:00 | {"id": 12608223, "body": "+1 looks good for now.", "user": "Patrick D. Hunt", "created_at": "2008-06-25T18:52:49.430000-04:00", "updated_at": "2008-06-25T18:52:49.430000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399045/comment/12608223", "id": "12608223", "author": ... |
238 | 12,608,225 | 53 | Patrick D. Hunt | reviewed the patch, looks good | 2008-06-25T18:55:56.474000-04:00 | 2008-06-25T18:55:56.474000-04:00 | {"id": 12608225, "body": "reviewed the patch, looks good", "user": "Patrick D. Hunt", "created_at": "2008-06-25T18:55:56.474000-04:00", "updated_at": "2008-06-25T18:55:56.474000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399045/comment/12608225", "id": "12608225", "a... |
239 | 12,608,226 | 53 | Mahadev Konar | i just committed this. | 2008-06-25T19:06:20.498000-04:00 | 2008-06-25T19:06:20.498000-04:00 | {"id": 12608226, "body": "i just committed this.", "user": "Mahadev Konar", "created_at": "2008-06-25T19:06:20.498000-04:00", "updated_at": "2008-06-25T19:06:20.498000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399045/comment/12608226", "id": "12608226", "author": {"... |
240 | 12,608,995 | 53 | Hudson | Integrated in ZooKeeper-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/6/]) | 2008-06-28T06:41:41.499000-04:00 | 2008-06-28T06:41:41.499000-04:00 | {"id": 12608995, "body": "Integrated in ZooKeeper-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/6/])", "user": "Hudson", "created_at": "2008-06-28T06:41:41.499000-04:00", "updated_at": "2008-06-28T06:41:41.499000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/res... |
241 | 12,642,689 | 53 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.361000-04:00 | 2008-10-25T21:10:40.361000-04:00 | {"id": 12642689, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.361000-04:00", "updated_at": "2008-10-25T21:10:40.361000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399045/comment/12642689", "id": "126... |
242 | 12,621,061 | 54 | Patrick D. Hunt | This is addressed (fixed) by ZOOKEEPER-111 | 2008-08-08T16:57:55.386000-04:00 | 2008-08-08T16:57:55.386000-04:00 | {"id": 12621061, "body": "This is addressed (fixed) by ZOOKEEPER-111", "user": "Patrick D. Hunt", "created_at": "2008-08-08T16:57:55.386000-04:00", "updated_at": "2008-08-08T16:57:55.386000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399048/comment/12621061", "id": "1... |
243 | 12,625,557 | 54 | Patrick D. Hunt | sleeps removed as part of ZOOKEEPER-111 patch | 2008-08-25T19:53:48.747000-04:00 | 2008-08-25T19:53:48.747000-04:00 | {"id": 12625557, "body": "sleeps removed as part of ZOOKEEPER-111 patch", "user": "Patrick D. Hunt", "created_at": "2008-08-25T19:53:48.747000-04:00", "updated_at": "2008-08-25T19:53:48.747000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399048/comment/12625557", "id":... |
244 | 12,642,690 | 54 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.429000-04:00 | 2008-10-25T21:10:40.429000-04:00 | {"id": 12642690, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.429000-04:00", "updated_at": "2008-10-25T21:10:40.429000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399048/comment/12642690", "id": "126... |
245 | 12,608,589 | 55 | Patrick D. Hunt | Yes, the svn revision # is on the todo list for items left over from ZOOKEEPER-45, in particular I had to
comment out a line in the build.xml version-info target as follows:
<!--PDH fixme - <arg value="${lastRevision}" />-->
<arg value="1" />
I couldn't quite make heads/tails of why getting th... | 2008-06-26T17:28:42.238000-04:00 | 2008-06-26T17:28:42.238000-04:00 | {"id": 12608589, "body": "Yes, the svn revision # is on the todo list for items left over from ZOOKEEPER-45, in particular I had to\ncomment out a line in the build.xml version-info target as follows:\n\n <!--PDH fixme - <arg value=\"${lastRevision}\" />-->\n <arg value=\"1\" />\n\nI couldn't quit... |
246 | 12,608,593 | 55 | Andrew Kornev | The patch fixes the first problem by correcting the path on the directory whose revision number is retreived. The second problem was also caused by invalid paths used to produce the tar files. | 2008-06-26T17:44:19.869000-04:00 | 2008-06-26T17:44:19.869000-04:00 | {"id": 12608593, "body": "The patch fixes the first problem by correcting the path on the directory whose revision number is retreived. The second problem was also caused by invalid paths used to produce the tar files.", "user": "Andrew Kornev", "created_at": "2008-06-26T17:44:19.869000-04:00", "updated_at": "2008-06-2... |
247 | 12,608,606 | 55 | Patrick D. Hunt | +1 looks good, dist builds and revision now included. | 2008-06-26T18:17:05.311000-04:00 | 2008-06-26T18:17:05.311000-04:00 | {"id": 12608606, "body": "+1 looks good, dist builds and revision now included.", "user": "Patrick D. Hunt", "created_at": "2008-06-26T18:17:05.311000-04:00", "updated_at": "2008-06-26T18:17:05.311000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399115/comment/12608606... |
248 | 12,608,624 | 55 | Andrew Kornev | Committed revision 672058 | 2008-06-26T19:50:28.930000-04:00 | 2008-06-26T19:50:28.930000-04:00 | {"id": 12608624, "body": "Committed revision 672058", "user": "Andrew Kornev", "created_at": "2008-06-26T19:50:28.930000-04:00", "updated_at": "2008-06-26T19:50:28.930000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399115/comment/12608624", "id": "12608624", "author":... |
249 | 12,642,691 | 55 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.479000-04:00 | 2008-10-25T21:10:40.479000-04:00 | {"id": 12642691, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.479000-04:00", "updated_at": "2008-10-25T21:10:40.479000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399115/comment/12642691", "id": "126... |
250 | 12,621,042 | 56 | Patrick D. Hunt | adds clover 2 support to build (clover1 didn't work as we use java5 features)
1) CLOVER_HOME must be set to home of licensed clover-ant version 2+
2) -Drun.clover=true must be set
CLOVER_HOME=/path/to/clover ant -Drun.clover=true test
run generate-clover-reports to generate reports | 2008-08-08T16:25:21.337000-04:00 | 2008-08-08T16:25:21.337000-04:00 | {"id": 12621042, "body": "adds clover 2 support to build (clover1 didn't work as we use java5 features)\n\n1) CLOVER_HOME must be set to home of licensed clover-ant version 2+\n2) -Drun.clover=true must be set\n\nCLOVER_HOME=/path/to/clover ant -Drun.clover=true test\n\nrun generate-clover-reports to generate reports",... |
251 | 12,621,617 | 56 | Patrick D. Hunt | Made forkmode a configurable option (and a couple more junit options as well) | 2008-08-11T17:41:31.707000-04:00 | 2008-08-11T17:41:31.707000-04:00 | {"id": 12621617, "body": "Made forkmode a configurable option (and a couple more junit options as well)", "user": "Patrick D. Hunt", "created_at": "2008-08-11T17:41:31.707000-04:00", "updated_at": "2008-08-11T17:41:31.707000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/1... |
252 | 12,622,334 | 56 | Andrew Kornev | +1, looks good! | 2008-08-13T15:51:39.359000-04:00 | 2008-08-13T15:51:39.359000-04:00 | {"id": 12622334, "body": "+1, looks good!", "user": "Andrew Kornev", "created_at": "2008-08-13T15:51:39.359000-04:00", "updated_at": "2008-08-13T15:51:39.359000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399126/comment/12622334", "id": "12622334", "author": {"self": ... |
253 | 12,622,358 | 56 | Mahadev Konar | I just committed this. Thanks Patrick. | 2008-08-13T17:11:02.872000-04:00 | 2008-08-13T17:11:02.872000-04:00 | {"id": 12622358, "body": "I just committed this. Thanks Patrick.", "user": "Mahadev Konar", "created_at": "2008-08-13T17:11:02.872000-04:00", "updated_at": "2008-08-13T17:11:02.872000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399126/comment/12622358", "id": "1262235... |
254 | 12,622,510 | 56 | Hudson | Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/]) | 2008-08-14T06:44:32.217000-04:00 | 2008-08-14T06:44:32.217000-04:00 | {"id": 12622510, "body": "Integrated in ZooKeeper-trunk #53 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/])", "user": "Hudson", "created_at": "2008-08-14T06:44:32.217000-04:00", "updated_at": "2008-08-14T06:44:32.217000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
255 | 12,642,692 | 56 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.525000-04:00 | 2008-10-25T21:10:40.525000-04:00 | {"id": 12642692, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.525000-04:00", "updated_at": "2008-10-25T21:10:40.525000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399126/comment/12642692", "id": "126... |
256 | 12,608,819 | 58 | Benjamin Reed | Excellent catch! I think it is better to do this in either primeConnection or startConnect, that way we make sure everything is setup correctly at the start rather than trying to make sure that we clean up correctly. Of the two my preference would probably be startConnect. | 2008-06-27T12:08:28.006000-04:00 | 2008-06-27T12:08:28.006000-04:00 | {"id": 12608819, "body": "Excellent catch! I think it is better to do this in either primeConnection or startConnect, that way we make sure everything is setup correctly at the start rather than trying to make sure that we clean up correctly. Of the two my preference would probably be startConnect.", "user": "Benjamin ... |
257 | 12,609,000 | 58 | Flavio Paiva Junqueira | New patch, moved added code to startConnect(). | 2008-06-28T07:36:37.252000-04:00 | 2008-06-28T07:39:43.760000-04:00 | {"id": 12609000, "body": "New patch, moved added code to startConnect().", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-28T07:36:37.252000-04:00", "updated_at": "2008-06-28T07:39:43.760000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12609000... |
258 | 12,609,253 | 58 | Benjamin Reed | +1 Looks good | 2008-06-30T11:17:56.634000-04:00 | 2008-06-30T11:17:56.634000-04:00 | {"id": 12609253, "body": "+1 Looks good", "user": "Benjamin Reed", "created_at": "2008-06-30T11:17:56.634000-04:00", "updated_at": "2008-06-30T11:17:56.634000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12609253", "id": "12609253", "author": {"self": "h... |
259 | 12,616,519 | 58 | James Strachan | just marking this issue as having a patch - does a committer fancy applying it? :) | 2008-07-24T12:15:10.506000-04:00 | 2008-07-24T12:15:10.506000-04:00 | {"id": 12616519, "body": "just marking this issue as having a patch - does a committer fancy applying it? :)", "user": "James Strachan", "created_at": "2008-07-24T12:15:10.506000-04:00", "updated_at": "2008-07-24T12:15:10.506000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/iss... |
260 | 12,616,521 | 58 | Flavio Paiva Junqueira | yeah, right, I'll take care of it... :-)
| 2008-07-24T12:31:09.329000-04:00 | 2008-07-24T12:31:09.329000-04:00 | {"id": 12616521, "body": "yeah, right, I'll take care of it... :-)\n", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-24T12:31:09.329000-04:00", "updated_at": "2008-07-24T12:31:09.329000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12616521", "... |
261 | 12,616,991 | 58 | Flavio Paiva Junqueira | Adding new patch generated against the apache trunk. | 2008-07-25T14:27:25.476000-04:00 | 2008-07-25T14:27:25.476000-04:00 | {"id": 12616991, "body": "Adding new patch generated against the apache trunk.", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-25T14:27:25.476000-04:00", "updated_at": "2008-07-25T14:27:25.476000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12... |
262 | 12,616,997 | 58 | Flavio Paiva Junqueira | Ben, you have reviewed this patch before, but since I have regenerated it against the apache trunk, you have to review it again. | 2008-07-25T14:31:04.443000-04:00 | 2008-07-25T14:31:04.443000-04:00 | {"id": 12616997, "body": "Ben, you have reviewed this patch before, but since I have regenerated it against the apache trunk, you have to review it again.", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-25T14:31:04.443000-04:00", "updated_at": "2008-07-25T14:31:04.443000-04:00", "_provider": "jira", "raw": {... |
263 | 12,616,998 | 58 | Benjamin Reed | +1 | 2008-07-25T14:36:17.499000-04:00 | 2008-07-25T14:36:17.499000-04:00 | {"id": 12616998, "body": "+1", "user": "Benjamin Reed", "created_at": "2008-07-25T14:36:17.499000-04:00", "updated_at": "2008-07-25T14:36:17.499000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12616998", "id": "12616998", "author": {"self": "https://issu... |
264 | 12,617,253 | 58 | Flavio Paiva Junqueira | Committed | 2008-07-27T04:07:11.453000-04:00 | 2008-07-27T04:07:11.453000-04:00 | {"id": 12617253, "body": "Committed", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-27T04:07:11.453000-04:00", "updated_at": "2008-07-27T04:07:11.453000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12617253", "id": "12617253", "author": {"self... |
265 | 12,642,693 | 58 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.583000-04:00 | 2008-10-25T21:10:40.583000-04:00 | {"id": 12642693, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.583000-04:00", "updated_at": "2008-10-25T21:10:40.583000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399179/comment/12642693", "id": "126... |
266 | 12,609,961 | 61 | Patrick D. Hunt | quorumtest failed on asf hudson today. This test passed in the previous CI run, and this run there are supposedly no changes to the source, seems related to this issue:
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/lastBuild/testReport/org.apache.zookeeper.test/QuorumTest/testClientwithoutWatcherObj/ | 2008-07-02T11:55:08.638000-04:00 | 2008-07-02T11:55:08.638000-04:00 | {"id": 12609961, "body": "quorumtest failed on asf hudson today. This test passed in the previous CI run, and this run there are supposedly no changes to the source, seems related to this issue:\n\nhttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/lastBuild/testReport/org.apache.zookeeper.test/QuorumTest/testCl... |
267 | 12,610,290 | 61 | Mahadev Konar | they are both duplicates. | 2008-07-03T13:21:21.004000-04:00 | 2008-07-03T13:21:21.004000-04:00 | {"id": 12610290, "body": "they are both duplicates.", "user": "Mahadev Konar", "created_at": "2008-07-03T13:21:21.004000-04:00", "updated_at": "2008-07-03T13:21:21.004000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399319/comment/12610290", "id": "12610290", "author":... |
268 | 12,621,059 | 61 | Patrick D. Hunt | This is addressed (fixed) by ZOOKEEPER-111 | 2008-08-08T16:57:27.668000-04:00 | 2008-08-08T16:57:27.668000-04:00 | {"id": 12621059, "body": "This is addressed (fixed) by ZOOKEEPER-111", "user": "Patrick D. Hunt", "created_at": "2008-08-08T16:57:27.668000-04:00", "updated_at": "2008-08-08T16:57:27.668000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399319/comment/12621059", "id": "1... |
269 | 12,625,558 | 61 | Patrick D. Hunt | sleeps removed as part of ZOOKEEPER-111 patch | 2008-08-25T19:54:20.957000-04:00 | 2008-08-25T19:54:20.957000-04:00 | {"id": 12625558, "body": "sleeps removed as part of ZOOKEEPER-111 patch", "user": "Patrick D. Hunt", "created_at": "2008-08-25T19:54:20.957000-04:00", "updated_at": "2008-08-25T19:54:20.957000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399319/comment/12625558", "id":... |
270 | 12,642,694 | 61 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.634000-04:00 | 2008-10-25T21:10:40.634000-04:00 | {"id": 12642694, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.634000-04:00", "updated_at": "2008-10-25T21:10:40.634000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399319/comment/12642694", "id": "126... |
271 | 12,616,136 | 63 | James Strachan | I wonder if I've seen this too - I can reliably get a hung test when trying to close a client (though the server is still up at the point if the hang).
I'm thinking the close() method should not wait() forever on the disconnect packet, just a closeTimeout length - say a few seconds. Afterall blocking and forcing a rec... | 2008-07-23T12:04:33.596000-04:00 | 2008-07-23T12:04:33.596000-04:00 | {"id": 12616136, "body": "I wonder if I've seen this too - I can reliably get a hung test when trying to close a client (though the server is still up at the point if the hang).\n\nI'm thinking the close() method should not wait() forever on the disconnect packet, just a closeTimeout length - say a few seconds. Afteral... |
272 | 12,616,151 | 63 | James Strachan | BTW here's the hang I seem to be able to get quite easily using the test case WriteLockTest in the ZOOKEEPER-78 patch (you need to set workAroundClosingLastZNodeFails to false to make it hang)
{code}
[junit] "main" prio=5 tid=0x01001710 nid=0xb0801000 in
Object.wait() [0xb07ff000..0xb0800148]
[junit] at jav... | 2008-07-23T12:35:53.551000-04:00 | 2008-07-23T12:35:53.551000-04:00 | {"id": 12616151, "body": "BTW here's the hang I seem to be able to get quite easily using the test case WriteLockTest in the ZOOKEEPER-78 patch (you need to set workAroundClosingLastZNodeFails to false to make it hang)\n\n\n{code}\n [junit] \"main\" prio=5 tid=0x01001710 nid=0xb0801000 in\nObject.wait() [0xb07ff000..... |
273 | 12,616,156 | 63 | James Strachan | about to attach a patch | 2008-07-23T12:48:36.284000-04:00 | 2008-07-23T12:48:36.284000-04:00 | {"id": 12616156, "body": "about to attach a patch", "user": "James Strachan", "created_at": "2008-07-23T12:48:36.284000-04:00", "updated_at": "2008-07-23T12:48:36.284000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12616156", "id": "12616156", "author": ... |
274 | 12,616,159 | 63 | James Strachan | This patch avoids the close() method blocking forever. It waits just once, up to the closeTimeout so if the socket is blocked or some other strangeness is going on, the calling thread will only wait up to the timeout (which defaults to 2 seconds).
BTW this patch fixes the hang I was having in the test case to ZOOKEEPE... | 2008-07-23T12:50:30.659000-04:00 | 2008-07-23T12:50:30.659000-04:00 | {"id": 12616159, "body": "This patch avoids the close() method blocking forever. It waits just once, up to the closeTimeout so if the socket is blocked or some other strangeness is going on, the calling thread will only wait up to the timeout (which defaults to 2 seconds).\n\nBTW this patch fixes the hang I was having ... |
275 | 12,616,219 | 63 | Patrick D. Hunt | Correct me if I'm wrong but I don't believe this "fixes" anything, it merely ignores the problem.
1) there is still the stated race condition
2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1
3) if the timeout is reached a warning s... | 2008-07-23T14:48:43.736000-04:00 | 2008-07-23T14:48:43.736000-04:00 | {"id": 12616219, "body": "Correct me if I'm wrong but I don't believe this \"fixes\" anything, it merely ignores the problem. \n\n1) there is still the stated race condition\n2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1\n\n3) if t... |
276 | 12,616,426 | 63 | James Strachan | So this patch does not attempt to fix the race condition problem, apologies if I gave that impression :)
What it does do though is act as a workaround so that if a client is not able to properly send a disconnect packet to the server for *any reason at all* such as
* a hung socket (which can be quite common)
* no se... | 2008-07-24T06:00:51.046000-04:00 | 2008-07-24T06:00:51.046000-04:00 | {"id": 12616426, "body": "So this patch does not attempt to fix the race condition problem, apologies if I gave that impression :)\n\nWhat it does do though is act as a workaround so that if a client is not able to properly send a disconnect packet to the server for *any reason at all* such as\n\n* a hung socket (which... |
277 | 12,616,643 | 63 | Patrick D. Hunt | I agree with your comments, in addition the patch should address:
1) there is still the stated race condition
2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1
3) if the timeout is reached a warning should be issued in the log | 2008-07-24T16:34:23.236000-04:00 | 2008-07-24T16:34:23.236000-04:00 | {"id": 12616643, "body": "I agree with your comments, in addition the patch should address:\n\n1) there is still the stated race condition\n2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1\n\n3) if the timeout is reached a warning sho... |
278 | 12,619,041 | 63 | Benjamin Reed | -1 The submitRequest logic should not be duplicated. (It will cause maintenance problems futher down the line.) The original submitRequest should be changed to call submitRequest(h, request, response, watchRegistration, 0)
| 2008-08-01T11:23:17.981000-04:00 | 2008-08-01T11:23:17.981000-04:00 | {"id": 12619041, "body": "-1 The submitRequest logic should not be duplicated. (It will cause maintenance problems futher down the line.) The original submitRequest should be changed to call submitRequest(h, request, response, watchRegistration, 0)\n", "user": "Benjamin Reed", "created_at": "2008-08-01T11:23:17.981000-... |
279 | 12,619,050 | 63 | Benjamin Reed | I've fixed the patch to not duplicate the logic in submitRequest | 2008-08-01T11:42:54.117000-04:00 | 2008-08-01T11:42:54.117000-04:00 | {"id": 12619050, "body": "I've fixed the patch to not duplicate the logic in submitRequest", "user": "Benjamin Reed", "created_at": "2008-08-01T11:42:54.117000-04:00", "updated_at": "2008-08-01T11:42:54.117000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment... |
280 | 12,619,065 | 63 | Patrick D. Hunt | -1 on the patch, still have the stated unresolved issues with this change:
1) there is still the stated race condition
2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1
3) if the timeout is reached a warning should be issued in the l... | 2008-08-01T12:34:59.514000-04:00 | 2008-08-01T12:34:59.514000-04:00 | {"id": 12619065, "body": "-1 on the patch, still have the stated unresolved issues with this change:\n\n1) there is still the stated race condition\n2) what is causing the underlying hang? this should not be happening and needs to be addressed directly, may even be related to item 1\n\n3) if the timeout is reached a wa... |
281 | 12,619,117 | 63 | Benjamin Reed | You are correct. The patch itself is good, but it does not fix the stated issue. | 2008-08-01T16:29:35.957000-04:00 | 2008-08-01T16:29:35.957000-04:00 | {"id": 12619117, "body": "You are correct. The patch itself is good, but it does not fix the stated issue.", "user": "Benjamin Reed", "created_at": "2008-08-01T16:29:35.957000-04:00", "updated_at": "2008-08-01T16:29:35.957000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/... |
282 | 12,620,386 | 63 | Patrick D. Hunt | SessionTest testReuse test is intermittently failing seeming due to this issue. | 2008-08-06T15:12:06.842000-04:00 | 2008-08-06T15:12:06.842000-04:00 | {"id": 12620386, "body": "SessionTest testReuse test is intermittently failing seeming due to this issue. ", "user": "Patrick D. Hunt", "created_at": "2008-08-06T15:12:06.842000-04:00", "updated_at": "2008-08-06T15:12:06.842000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issu... |
283 | 12,620,396 | 63 | Patrick D. Hunt | Assigning to myself - I've cleaned up the tests as part of ZOOKEEPER-111 (this was blocking progress on this issue). I'll dig into this issue now.
Looking at the code for zk close it seems to me that the issue is related to how the client send/event threads manage state. In particular these threads look "out/up" at th... | 2008-08-06T15:26:57.627000-04:00 | 2008-08-06T15:26:57.627000-04:00 | {"id": 12620396, "body": "Assigning to myself - I've cleaned up the tests as part of ZOOKEEPER-111 (this was blocking progress on this issue). I'll dig into this issue now.\n\nLooking at the code for zk close it seems to me that the issue is related to how the client send/event threads manage state. In particular these... |
284 | 12,625,228 | 63 | Stu Hood | I believe this bug will eventually cause a client to run out of file handles if they connect and disconnect often enough, so it is a pretty serious issue.
The attached modification to the ClientTest testcase causes it to fail by running out of file handles, and we are seeing this behaviour in our application. | 2008-08-24T18:58:30.768000-04:00 | 2008-08-24T18:58:30.768000-04:00 | {"id": 12625228, "body": "I believe this bug will eventually cause a client to run out of file handles if they connect and disconnect often enough, so it is a pretty serious issue.\n\nThe attached modification to the ClientTest testcase causes it to fail by running out of file handles, and we are seeing this behaviour ... |
285 | 12,625,561 | 63 | Patrick D. Hunt | Stu, thanks for the test! I'll update ClientTest to include this, pretty ugly.
Just wondering, why are you frequently connecting/disconnecting a client? Could you establish a connection and keep it open for a long(er) period of time? Session establishment by a particular client is an expense that needs to be paid by a... | 2008-08-25T20:13:23.304000-04:00 | 2008-08-25T20:13:23.304000-04:00 | {"id": 12625561, "body": "Stu, thanks for the test! I'll update ClientTest to include this, pretty ugly.\n\nJust wondering, why are you frequently connecting/disconnecting a client? Could you establish a connection and keep it open for a long(er) period of time? Session establishment by a particular client is an expens... |
286 | 12,625,619 | 63 | Stu Hood | We had a non-daemon thread that needed to have its own ephemerals, so we let it create its own connection/session. During one of our unit tests, the thread gets created a few hundred times, and we noticed the issue. In the real world, the work the thread will be performing will take a few order of magnitude longer, but... | 2008-08-26T00:15:11.708000-04:00 | 2008-08-26T00:15:11.708000-04:00 | {"id": 12625619, "body": "We had a non-daemon thread that needed to have its own ephemerals, so we let it create its own connection/session. During one of our unit tests, the thread gets created a few hundred times, and we noticed the issue. In the real world, the work the thread will be performing will take a few orde... |
287 | 12,625,877 | 63 | Patrick D. Hunt | This patch:
1) fixes the close race condition
2) fixes a resource issue where close operation was not causing the selector to be closed (leak)
3) updated tests to look for resource leak testClientCleanup (thanks Stu)
4) updated tests to better verify close operation successful
The only real change is in ClientCnxn ... | 2008-08-26T17:29:20.675000-04:00 | 2008-08-26T17:29:20.675000-04:00 | {"id": 12625877, "body": "This patch:\n\n1) fixes the close race condition\n2) fixes a resource issue where close operation was not causing the selector to be closed (leak)\n\n3) updated tests to look for resource leak testClientCleanup (thanks Stu)\n\n4) updated tests to better verify close operation successful\n\nThe... |
288 | 12,625,880 | 63 | Patrick D. Hunt | Stu, it turned out there were two problem here - the close race but also the client connection close was not closing the selector which was causing resources to leak. This patch fixes both.
| 2008-08-26T17:32:19.962000-04:00 | 2008-08-26T17:32:19.962000-04:00 | {"id": 12625880, "body": "Stu, it turned out there were two problem here - the close race but also the client connection close was not closing the selector which was causing resources to leak. This patch fixes both.\n", "user": "Patrick D. Hunt", "created_at": "2008-08-26T17:32:19.962000-04:00", "updated_at": "2008-08-... |
289 | 12,625,881 | 63 | Patrick D. Hunt | Please review ZOOKEEPER-63.patch file and commit. | 2008-08-26T17:32:51.768000-04:00 | 2008-08-26T17:32:51.768000-04:00 | {"id": 12625881, "body": "Please review ZOOKEEPER-63.patch file and commit.", "user": "Patrick D. Hunt", "created_at": "2008-08-26T17:32:51.768000-04:00", "updated_at": "2008-08-26T17:32:51.768000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12625881", "... |
290 | 12,626,359 | 63 | Benjamin Reed | +1 Great work Pat. I'll commit. | 2008-08-27T19:25:52.037000-04:00 | 2008-08-27T19:25:52.037000-04:00 | {"id": 12626359, "body": "+1 Great work Pat. I'll commit.", "user": "Benjamin Reed", "created_at": "2008-08-27T19:25:52.037000-04:00", "updated_at": "2008-08-27T19:25:52.037000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12626359", "id": "12626359", "au... |
291 | 12,626,367 | 63 | Benjamin Reed | Committed revision 689668. | 2008-08-27T19:39:25.301000-04:00 | 2008-08-27T19:39:25.301000-04:00 | {"id": 12626367, "body": "Committed revision 689668. ", "user": "Benjamin Reed", "created_at": "2008-08-27T19:39:25.301000-04:00", "updated_at": "2008-08-27T19:39:25.301000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12626367", "id": "12626367", "auth... |
292 | 12,626,541 | 63 | Hudson | Integrated in ZooKeeper-trunk #67 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/67/]) | 2008-08-28T08:32:04.172000-04:00 | 2008-08-28T08:32:04.172000-04:00 | {"id": 12626541, "body": "Integrated in ZooKeeper-trunk #67 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/67/])", "user": "Hudson", "created_at": "2008-08-28T08:32:04.172000-04:00", "updated_at": "2008-08-28T08:32:04.172000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
293 | 12,631,021 | 63 | Stu Hood | Great work Patrick! Thanks a bunch for looking into it. | 2008-09-15T09:33:20.420000-04:00 | 2008-09-15T09:33:20.420000-04:00 | {"id": 12631021, "body": "Great work Patrick! Thanks a bunch for looking into it.", "user": "Stu Hood", "created_at": "2008-09-15T09:33:20.420000-04:00", "updated_at": "2008-09-15T09:33:20.420000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12631021", "i... |
294 | 12,631,506 | 63 | Patrick D. Hunt | Thank you for taking the time to report the issue. Regards. | 2008-09-16T14:58:23.967000-04:00 | 2008-09-16T14:58:23.967000-04:00 | {"id": 12631506, "body": "Thank you for taking the time to report the issue. Regards.", "user": "Patrick D. Hunt", "created_at": "2008-09-16T14:58:23.967000-04:00", "updated_at": "2008-09-16T14:58:23.967000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12... |
295 | 12,642,695 | 63 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.660000-04:00 | 2008-10-25T21:10:40.660000-04:00 | {"id": 12642695, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.660000-04:00", "updated_at": "2008-10-25T21:10:40.660000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399322/comment/12642695", "id": "126... |
296 | 12,611,375 | 68 | Jakob Homan | Changes second call to indexOf to lastIndexOf | 2008-07-07T18:11:59.862000-04:00 | 2008-07-07T18:11:59.862000-04:00 | {"id": 12611375, "body": "Changes second call to indexOf to lastIndexOf", "user": "Jakob Homan", "created_at": "2008-07-07T18:11:59.862000-04:00", "updated_at": "2008-07-07T18:11:59.862000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399765/comment/12611375", "id": "12... |
297 | 12,611,381 | 68 | Mahadev Konar | the patch seems fine but not generated from the trunk. you should do an svn diff from the top level directory. I created a patch thats from the trunk and uploaded it. | 2008-07-07T18:39:36.896000-04:00 | 2008-07-07T18:39:36.896000-04:00 | {"id": 12611381, "body": "the patch seems fine but not generated from the trunk. you should do an svn diff from the top level directory. I created a patch thats from the trunk and uploaded it.", "user": "Mahadev Konar", "created_at": "2008-07-07T18:39:36.896000-04:00", "updated_at": "2008-07-07T18:39:36.896000-04:00", ... |
298 | 12,611,392 | 68 | Mahadev Konar | I just committed this to trunk. Thanks Jakob. | 2008-07-07T19:03:13.146000-04:00 | 2008-07-07T19:03:13.146000-04:00 | {"id": 12611392, "body": "I just committed this to trunk. Thanks Jakob.", "user": "Mahadev Konar", "created_at": "2008-07-07T19:03:13.146000-04:00", "updated_at": "2008-07-07T19:03:13.146000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399765/comment/12611392", "id": "... |
299 | 12,611,519 | 68 | Hudson | Integrated in ZooKeeper-trunk #16 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/16/]) | 2008-07-08T06:42:46.752000-04:00 | 2008-07-08T06:42:46.752000-04:00 | {"id": 12611519, "body": "Integrated in ZooKeeper-trunk #16 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/16/])", "user": "Hudson", "created_at": "2008-07-08T06:42:46.752000-04:00", "updated_at": "2008-07-08T06:42:46.752000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/r... |
300 | 12,642,696 | 68 | Patrick D. Hunt | 3.0.0 has been released, closing issues. | 2008-10-25T21:10:40.717000-04:00 | 2008-10-25T21:10:40.717000-04:00 | {"id": 12642696, "body": "3.0.0 has been released, closing issues.", "user": "Patrick D. Hunt", "created_at": "2008-10-25T21:10:40.717000-04:00", "updated_at": "2008-10-25T21:10:40.717000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399765/comment/12642696", "id": "126... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.