repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
nodejs/node
fd038a1f1556e4d525ffb9ba07b2951e14e81cda
f86e3ea9dfc90b96d2e198a33dea07a491a608d7
worker: fix --abort-on-uncaught-exception handling The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: https://github.com/nodejs/node/p...
[ { "path": "src/api/environment.cc", "patch": "@@ -43,6 +43,7 @@ static bool ShouldAbortOnUncaughtException(Isolate* isolate) {\n Environment* env = Environment::GetCurrent(isolate);\n return env != nullptr &&\n (env->is_main_thread() || !env->is_stopping()) &&\n+ env->abort_on_uncaught_...
2020-08-11T11:12:10
golang/go
72ce9ba9cb640f1a2184389d1dc146d731882328
601ad2e4570896d07df8ace7d2ab9100a57d301c
crypto/tls: use certificate cache in client In verifyServerCertificate parse certificates using the global certificate cache. This should signficiantly reduce memory usage in TLS clients which make concurrent connections which reuse certificates (anywhere in the chain) since there will only ever be one copy of the ce...
[ { "path": "src/crypto/tls/cache.go", "patch": "@@ -39,6 +39,8 @@ type certCache struct {\n \tsync.Map\n }\n \n+var clientCertCache = new(certCache)\n+\n // activeCert is a handle to a certificate held in the cache. Once there are\n // no alive activeCerts for a given certificate, the certificate is removed\...
2022-08-29T16:40:50
nodejs/node
f86e3ea9dfc90b96d2e198a33dea07a491a608d7
77a515c31aa4383e54e032bebdc399b3704e8a3d
doc: remove typo in crypto.md Change "its[sic] recommended to" to "be sure to". This fixes a typo and also improves the passive and indirect phrasing to a more concise active and direct phrasing. PR-URL: https://github.com/nodejs/node/pull/34698 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau ...
[ { "path": "doc/api/crypto.md", "patch": "@@ -868,7 +868,7 @@ If `outputEncoding` is given a string will be returned; otherwise a\n `ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY` error when `otherPublicKey`\n lies outside of the elliptic curve. Since `otherPublicKey` is\n usually supplied from a remote user over an in...
2020-08-09T21:34:32
vercel/next.js
780594f7b6da5db7e68dba5a80768edb0996dd9e
1886478789617f2676928e0ccdb8548606715458
Fix recursive ignoring case in build traces (#60740) This ensures when a dependency has a recursive require our should ignore handling doesn't accidentally loop back and forth. x-ref: https://github.com/lovell/sharp/issues/3944 Closes NEXT-2121
[ { "path": "packages/next/src/build/collect-build-traces.ts", "patch": "@@ -37,7 +37,8 @@ function shouldIgnore(\n file: string,\n serverIgnoreFn: (file: string) => boolean,\n reasons: NodeFileTraceReasons,\n- cachedIgnoreFiles: Map<string, boolean>\n+ cachedIgnoreFiles: Map<string, boolean>,\n+ chi...
2024-01-16T22:11:17
facebook/react
12808e81c18ca8e9921b606cc680f30cca0a5bab
af8ad59a5b5cef224c1357df9a89a5d35eecef4c
Fix license header to use BSD
[ { "path": "src/browser/ui/dom/setTextContent.js", "patch": "@@ -1,17 +1,10 @@\n /**\n- * Copyright 2013-2014 Facebook, Inc.\n+ * Copyright 2013-2014, Facebook, Inc.\n+ * All rights reserved.\n *\n- * Licensed under the Apache License, Version 2.0 (the \"License\");\n- * you may not use this file except in ...
2015-02-12T22:28:32
electron/electron
3a1d6e7a424af0611aac20945530b1892d4785b4
1e4232eb3a4988274e1508bf42cde98ff3874438
recommend fixing permissions over using sudo
[ { "path": "docs/tutorial/installation.md", "patch": "@@ -59,11 +59,8 @@ You can also attempt to download Electron directly from\n [electron/electron/releases](https://github.com/electron/electron/releases) \n if installing via `npm` is failing.\n \n-If installation fails with an `EACCESS` error you may have...
2017-08-09T03:43:57
golang/go
601ad2e4570896d07df8ace7d2ab9100a57d301c
81ed1354e8fef60cac1f7043d723d9d38c9ce174
math: fix function name in comment Change-Id: Iabf955cdb161d02cb4a3e06f466b331e1b6eb2c2 Signed-off-by: cui fliter <imcusg@gmail.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/447456 Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Ian Lance Taylor ...
[ { "path": "src/math/logb.go", "patch": "@@ -44,7 +44,7 @@ func Ilogb(x float64) int {\n \treturn ilogb(x)\n }\n \n-// logb returns the binary exponent of x. It assumes x is finite and\n+// ilogb returns the binary exponent of x. It assumes x is finite and\n // non-zero.\n func ilogb(x float64) int {\n \tx, ...
2022-11-03T07:34:35
rust-lang/rust
323e23005a6a2025508e6064a0f88dae09cfa127
6d6a08cf590ec26296447b8d2cf2329bb64c303a
Fix ICE when validating transmuting ZST to inhabited enum MIR validation attempts to determine the number of bytes needed to represent the size of the source type to compute the discriminant for the inhabited target enum. For a ZST source, there is no source data to use as a discriminant so no proper runtime check can...
[ { "path": "compiler/rustc_mir_transform/src/check_enums.rs", "patch": "@@ -48,6 +48,21 @@ impl<'tcx> crate::MirPass<'tcx> for CheckEnums {\n let new_block = split_block(basic_blocks, location);\n \n match check {\n+ EnumCheckType::Direct { op_si...
2025-08-23T16:22:38
nodejs/node
9f47e5a7f74c866571512bef91e661b69a18a03e
10ed48bef487e4870158930c355247526312707d
test: fix test_worker_terminate_finalization The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in https://github.com/nodejs/node/pull/34625. PR-URL: https://github.com/nodejs/node/pull/34726 Reviewed-By: Richard Lau <r...
[ { "path": "test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c", "patch": "@@ -22,7 +22,6 @@ napi_value Test(napi_env env, napi_callback_info info) {\n size_t argc = 1;\n napi_value argv[1];\n napi_value result;\n- napi_ref ref;\n void* bufferData = malloc(BUFFER_S...
2020-08-11T14:09:29
facebook/react
af8ad59a5b5cef224c1357df9a89a5d35eecef4c
a411f3e0dcac3cada4ce0acf6603bbb8ff7024a6
Add space-before-blocks rules, fix code
[ { "path": "src/.eslintrc", "patch": "@@ -25,6 +25,7 @@ rules:\n consistent-return: 2\n no-unused-vars: [2, args: none]\n quotes: [2, 'single']\n+ space-before-blocks: 2\n \n # WARNINGS\n # This is the only one that's hard to track since we don't lint just changes.", "additions": 1, "delet...
2015-02-12T22:28:01
vercel/next.js
1886478789617f2676928e0ccdb8548606715458
2072f864fc1d716d0884628dada7e1c6fbf7fbf2
chore(docs): add docs for `.svg` unoptimized behavior (#60735) - Fixes https://github.com/vercel/next.js/discussions/53041 Closes NEXT-2119 --------- Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
[ { "path": "docs/02-app/02-api-reference/01-components/image.mdx", "patch": "@@ -620,9 +620,11 @@ module.exports = {\n \n ### `dangerouslyAllowSVG`\n \n-The default [loader](#loader) does not optimize SVG images for a few reasons. First, SVG is a vector format meaning it can be resized losslessly. Second, SV...
2024-01-16T20:06:42
golang/go
d2b5a6f332b011c75c17bfb99216cc51ac7a0b5f
50664c236f9ab38cd57e0a36cf29527d4c513010
cmd/trace: only include required frames in splits Though we split traces into 100MB chunks, currently each chunk always includes the entire stack frame map, including frames for all events in the trace file, even if they aren't needed by events in this chunk. This means that if the stack frame JSON alone is >100MB th...
[ { "path": "src/cmd/trace/trace.go", "patch": "@@ -310,15 +310,76 @@ type splitter struct {\n \tRanges []Range\n }\n \n+// walkStackFrames calls fn for id and all of its parent frames from allFrames.\n+func walkStackFrames(allFrames map[string]traceviewer.Frame, id int, fn func(id int)) {\n+\tfor id != 0 {\n...
2022-10-26T22:12:21
nodejs/node
10ed48bef487e4870158930c355247526312707d
a7477704c417f9d51eb8e859db148f12423732a2
doc: add HPE_UNEXPECTED_CONTENT_LENGTH error description PR-URL: https://github.com/nodejs/node/pull/34596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
[ { "path": "doc/api/errors.md", "patch": "@@ -2271,6 +2271,17 @@ malconfigured clients, if more than 8KB of HTTP header data is received then\n HTTP parsing will abort without a request or response object being created, and\n an `Error` with this code will be emitted.\n \n+<a id=\"HPE_UNEXPECTED_CONTENT_LENG...
2020-08-01T21:45:29
vercel/next.js
2072f864fc1d716d0884628dada7e1c6fbf7fbf2
6a3608f739bb09e1b041c9b515c976b19c5a1a8f
Fix client reference keys of barrel-optimized files (#60685) As Barrel Optimization might split one file into multiple different modules, i.e. when you import different values from it, the target file might be transformed differently, we can no longer rely on the file path as the identifier of the client reference....
[ { "path": "packages/next/src/build/webpack/loaders/next-flight-loader/index.ts", "patch": "@@ -1,7 +1,11 @@\n import { RSC_MOD_REF_PROXY_ALIAS } from '../../../../lib/constants'\n-import { RSC_MODULE_TYPES } from '../../../../shared/lib/constants'\n+import {\n+ BARREL_OPTIMIZATION_PREFIX,\n+ RSC_MODULE_TY...
2024-01-16T19:06:22
rust-lang/rust
577e181c6c29775e8e36b087183615b2c4ed9a18
825bb13e1f05ab9ed3dc5df55d9efee291fd3604
Enable LLVM download from CI for gnullvm dist It no longer fails with an error locally.
[ { "path": "src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile", "patch": "@@ -26,19 +26,10 @@ ENV CC_aarch64_pc_windows_gnullvm=aarch64-w64-mingw32-clang \\\n \n ENV HOST=aarch64-pc-windows-gnullvm\n \n-# We are bootstrapping this target and cannot use previously built artifacts.\n-# Without ...
2025-08-23T13:35:35
golang/go
1c05968c9a5d6432fc6f30196528f8f37287dd3d
a343f4017b501358c202154f074f54d710df6698
all: fix comment typos Change-Id: Ic16824482142d4de4d0b949459e36505ee944ff7 Reviewed-on: https://go-review.googlesource.com/c/go/+/448175 Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Dan Kortschak <dan@kortschak.io> Auto-Submit: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang....
[ { "path": "src/crypto/internal/edwards25519/tables.go", "patch": "@@ -38,7 +38,7 @@ func (v *projLookupTable) FromP3(q *Point) {\n \ttmpP3 := Point{}\n \ttmpP1xP1 := projP1xP1{}\n \tfor i := 0; i < 7; i++ {\n-\t\t// Compute (i+1)*Q as Q + i*Q and convert to a ProjCached\n+\t\t// Compute (i+1)*Q as Q + i*Q a...
2022-11-05T05:44:08
facebook/react
f5038829d87b97f610e94b0b4c7b905cb58a4b63
d2fcdfc7dfe9a4656ecda695d611032dd3909d4f
Moar warnings with solid prefixes! This ensures that we have a prefix that can be easily identified in logs so that we can filter out warnings based on their prefix. This also turns the remaining two monitorCodeUse callers into warnings. We'll probably still use monitorCodeUse until we know if we want to deprecate bu...
[ { "path": "src/classic/__tests__/ReactContextValidator-test.js", "patch": "@@ -147,7 +147,8 @@ describe('ReactContextValidator', function() {\n \n expect(console.warn.argsForCall.length).toBe(1);\n expect(console.warn.argsForCall[0][0]).toBe(\n- 'Warning: Required context `foo` was not specifie...
2015-02-12T21:37:19
nodejs/node
ea5eb8fc9cf137350862a046cc4f05c2f29300db
8a8416f84169c553380704ab3a754db0a1735877
test: remove test-child-process-fork-args flaky designation test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: https://github.com/nodejs/node/issues/32863 PR-URL: https://github.com/nodejs/node/pu...
[ { "path": "test/parallel/parallel.status", "patch": "@@ -7,8 +7,6 @@ prefix parallel\n [true] # This section applies to all platforms\n \n [$system==win32]\n-# https://github.com/nodejs/node/issues/32863\n-test-child-process-fork-args: PASS,FLAKY\n # https://github.com/nodejs/node/issues/20750\n test-http2-...
2020-08-08T21:04:28
rust-lang/rust
825bb13e1f05ab9ed3dc5df55d9efee291fd3604
8df154bffddcb6bbb543ad69aff971795c5adbc2
Enable LLVM tools for gnullvm dist This issue has been fixed by <https://github.com/rust-lang/rust/pull/145763>.
[ { "path": "src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile", "patch": "@@ -35,14 +35,10 @@ ENV HOST=aarch64-pc-windows-gnullvm\n ENV NO_DOWNLOAD_CI_LLVM 1\n \n ENV RUST_CONFIGURE_ARGS \\\n- --enable-extended \\\n+ --enable-full-tools \\\n --enable-profiler \\\n --enable-sanit...
2025-08-23T12:28:48
vercel/next.js
8627e7c8c09aa69dcfabcb5058bd4e6f33757443
02457862530112b534e60fe45c018c4ead99b8a7
refactor(next-swc): remove unused crashreporter (#60593) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Co...
[ { "path": "Cargo.lock", "patch": "@@ -2232,17 +2232,6 @@ version = \"0.4.3\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n checksum = \"7f24254aa9a54b5c858eaee2f5bccdb46aaf0e486a595ed5fd8f86ba55232a70\"\n \n-[[package]]\n-name = \"hostname\"\n-version = \"0.3.1\"\n-source = \"regist...
2024-01-16T19:01:47
golang/go
a74985092c14784db86fdf391b9cf939e1b06f2f
d9cc39b25c8ebef5a976e34848dc3c5216108f07
all: fix function names in comments Change-Id: I871a747b4b47bccc889f2fdc93a2bcebb041b719 Reviewed-on: https://go-review.googlesource.com/c/go/+/447895 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Rob...
[ { "path": "src/debug/plan9obj/file.go", "patch": "@@ -260,7 +260,7 @@ func walksymtab(data []byte, ptrsz int, fn func(sym) error) error {\n \treturn nil\n }\n \n-// NewTable decodes the Go symbol table in data,\n+// newTable decodes the Go symbol table in data,\n // returning an in-memory representation.\n ...
2022-11-04T02:45:43
nodejs/node
bcfb1762a3e613e71ac68ab8a6420e2f33c0f603
64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46
util: add debug and debuglog.enabled PR-URL: https://github.com/nodejs/node/pull/33424 Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/util.md", "patch": "@@ -136,6 +136,42 @@ let debuglog = util.debuglog('internals', (debug) => {\n });\n ```\n \n+### `debuglog().enabled`\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n+* {boolean}\n+\n+The `util.debuglog().enabled` getter is used to create a test that can be used\n+in conditio...
2020-06-12T15:25:38
rust-lang/rust
d210ce7dac4acb7653d647c77d56c10068dda82c
b8ee38b79e6bfbb1376785f765a233e96d0c5da2
fix visibility of private getters Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
[ { "path": "library/std/src/sync/nonpoison/mutex.rs", "patch": "@@ -457,7 +457,8 @@ impl<T: ?Sized + fmt::Display> fmt::Display for MutexGuard<'_, T> {\n }\n }\n \n-pub fn guard_lock<'a, T: ?Sized>(guard: &MutexGuard<'a, T>) -> &'a sys::Mutex {\n+/// For use in [`nonpoison::condvar`](super::condvar).\n+p...
2025-08-23T13:39:37
electron/electron
3d5acdf68232102963a58edab2803a548865f8f6
d06eeeede8b9f286a36fac92ee5eb7f5a100d9fa
Rollback debug mode changes
[ { "path": "atom/app/atom_main.cc", "patch": "@@ -34,7 +34,7 @@\n \n namespace {\n \n-const auto kRunAsNode = \"ELECTRON_RUN_AS_NODE\";\n+const char* kRunAsNode = \"ELECTRON_RUN_AS_NODE\";\n \n bool IsEnvSet(const char* name) {\n #if defined(OS_WIN)\n@@ -56,29 +56,6 @@ int APIENTRY wWinMain(HINSTANCE instanc...
2017-08-07T19:54:44
vercel/next.js
02457862530112b534e60fe45c018c4ead99b8a7
d08b3ffa50cd7defc5d33dbed84a02c97d19a553
Update module-layer test for Turbopack (#60707) ## What? Splits the passing / failing parts into separate tests, making it easier to only run the two tests that are failing in Turbopack. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible...
[ { "path": "test/e2e/module-layer/module-layer.test.ts", "patch": "@@ -7,28 +7,28 @@ createNextDescribe(\n },\n ({ next, isNextStart }) => {\n function runTests() {\n- it('should render routes marked with restriction marks without errors', async () => {\n- const routes = [\n- // ...
2024-01-16T18:36:35
facebook/react
fbe88c7e466f95e2d73c49184d71d8634cd06dff
58d705110e1f29c2a8954a571bd5f152bac91f00
fix Microdata properties' commentaries
[ { "path": "src/browser/ui/dom/HTMLDOMPropertyConfig.js", "patch": "@@ -164,7 +164,7 @@ var HTMLDOMPropertyConfig = {\n // keyboard hints.\n autoCapitalize: null,\n autoCorrect: null,\n- // itemProp, itemScope, itemType, itemType, itemID are for\n+ // itemProp, itemScope, itemType are for\n...
2015-02-11T12:50:59
golang/go
bdd1e283a914d4d161589adce4f2ad79767d029d
f187c6b08eac9dddd161bb2e7537def3bbf8ec9a
cmd/compile/internal/pgo: match on call line offsets Rather than matching calls to edges in the profile based directly on line number in the source file, use the line offset from the start of the function. This makes matching robust to changes in the source file above the function containing the call. The start line ...
[ { "path": "src/cmd/compile/internal/inline/inl.go", "patch": "@@ -112,7 +112,7 @@ func pgoInlinePrologue(p *pgo.Profile) {\n \t\t\t\t\tif e.Weight != 0 {\n \t\t\t\t\t\tedgeweightpercent := pgo.WeightInPercentage(e.Weight, p.TotalEdgeWeight)\n \t\t\t\t\t\tif edgeweightpercent > inlineHotCallSiteThresholdPerc...
2022-11-02T15:11:03
nodejs/node
64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46
b8b5e1e5d0bff0103446f92c07cbea73df174e1f
test: add vm crash regression test Refs: https://github.com/nodejs/node/issues/34606 PR-URL: https://github.com/nodejs/node/pull/34673 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "test/parallel/test-vm-set-property-proxy.js", "patch": "@@ -0,0 +1,16 @@\n+'use strict';\n+const common = require('../common');\n+const assert = require('assert');\n+const vm = require('vm');\n+\n+// Regression test for https://github.com/nodejs/node/issues/34606\n+\n+const handler = {\n+ getOwn...
2020-08-07T21:41:00
rust-lang/rust
6e5a4275f7dca9ba13b4234b3fe821816753d924
d127901d940d96209fd2ae8ff6769ad2788099fb
Fix STD build failing for target_os = espidf
[ { "path": "library/std/src/sys/fs/mod.rs", "patch": "@@ -117,9 +117,18 @@ pub fn set_permissions(path: &Path, perm: FilePermissions) -> io::Result<()> {\n #[cfg(unix)]\n pub fn set_permissions_nofollow(path: &Path, perm: crate::fs::Permissions) -> io::Result<()> {\n use crate::fs::OpenOptions;\n- use...
2025-08-22T08:02:00
facebook/react
4e5543965d9d126415791750a2056d14277f3cdc
f6f0bab2372fe4acc9e455769d9c35eff8d6c711
Flip console.warn to use warning module so users can intercept all warnings by shimming the warning module. The two remaining console.warns are: /Users/jsproch/react/src/test/mock-modules.js: 19 return mocks.generateFromMetadata(mocks.getMetadata(exports)); 20 } catch (err) { 21: console.warn(err...
[ { "path": "src/addons/transitions/ReactCSSTransitionGroupChild.js", "patch": "@@ -18,6 +18,7 @@ var CSSCore = require('CSSCore');\n var ReactTransitionEvents = require('ReactTransitionEvents');\n \n var onlyChild = require('onlyChild');\n+var warning = require('warning');\n \n // We don't remove the element...
2015-02-10T21:42:44
vercel/next.js
d08b3ffa50cd7defc5d33dbed84a02c97d19a553
f668ab580bf64e0c5ea70255113178e4e17351b1
graceful shutdown (#60059) - Both the standalone server and the `startServer` function it calls attempt to stop the server on `SIGINT` and `SIGTERM` in different ways. This lets `server.js` yield to `startServer` - The cleanup function in `startServer` was not waiting for the server to close before calling `proces...
[ { "path": "packages/next/src/bin/next.ts", "patch": "@@ -108,12 +108,11 @@ if (process.env.NODE_ENV) {\n ;(process.env as any).NODE_ENV = process.env.NODE_ENV || defaultEnv\n ;(process.env as any).NEXT_RUNTIME = 'nodejs'\n \n-// Make sure commands gracefully respect termination signals (e.g. from Docker)\n-...
2024-01-16T17:25:49
golang/go
b079640404a1e83a23b95bd22ec67cedd38798a9
7e88b866f9576d6f9ddfe0a054da7383bfff54fa
misc/cgo/test: simplify for module mode When we were first introducing module mode, CL 163418 moved many of the tests in misc/cgo/test into their own test binary under testdata so misc/cgo/test continued to work in both GOPATH mode and module mode. This introduce a somewhat complicated test driver into misc/cgo/test. ...
[ { "path": "misc/cgo/test/cgo_linux_test.go", "patch": "@@ -32,4 +32,5 @@ func TestSetgidStress(t *testing.T) {\n \n func Test1435(t *testing.T) { test1435(t) }\n func Test6997(t *testing.T) { test6997(t) }\n+func Test9400(t *testing.T) { test9400(t) }\n func TestBuildID(t *testing.T) { testBuildID(...
2022-10-21T19:18:14
nodejs/node
b8b5e1e5d0bff0103446f92c07cbea73df174e1f
5b6cd6fa1a0b54393d96ee0b34bd5d9334a9faec
deps: V8: cherry-pick e06ace6b5cdb Original commit message: [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes `Object::GetRealNamedPropertyAttributes()` can crash if an empty `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because it was not checking for that. Fix that. ...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.13',\n+ 'v8_embedder_string': '-node.14',\n \n ##### V8 defaults for Node.js #####\n...
2020-08-07T21:23:54
facebook/react
58d705110e1f29c2a8954a571bd5f152bac91f00
f6f0bab2372fe4acc9e455769d9c35eff8d6c711
rename `Id` suffix to `ID` to apply naming conventions
[ { "path": "src/browser/ui/dom/HTMLDOMPropertyConfig.js", "patch": "@@ -164,7 +164,7 @@ var HTMLDOMPropertyConfig = {\n // keyboard hints.\n autoCapitalize: null,\n autoCorrect: null,\n- // itemProp, itemScope, itemType, itemType, itemId are for\n+ // itemProp, itemScope, itemType, itemType...
2015-02-10T18:40:30
electron/electron
eeca6fcb557e099d8b83b6804079fabb9b7164cd
f1f43c51bb886a13b2facf37c669c4470fcefadc
Revert "Fix window.opener being null when nativeWindowOpen is used"
[ { "path": "atom/browser/atom_browser_client.cc", "patch": "@@ -100,32 +100,20 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(\n \n int process_id = current_instance->GetProcess()->GetID();\n if (!IsRendererSandboxed(process_id)) {\n- auto web_contents =\n- content::WebContents::FromRen...
2017-08-07T10:50:23
vercel/next.js
f668ab580bf64e0c5ea70255113178e4e17351b1
dc394483b807e5e111c175ad9afd1f09220da7ce
Stabilize flakey edge-module-error test (#60728) x-ref: https://github.com/vercel/next.js/actions/runs/7524452333/job/20539227674?pr=60651 x-ref: https://github.com/vercel/next.js/actions/runs/7541852582/job/20536776104?pr=60707 Closes NEXT-2117
[ { "path": "test/integration/edge-runtime-module-errors/test/index.test.js", "patch": "@@ -11,6 +11,7 @@ import {\n launchApp,\n nextBuild,\n nextStart,\n+ retry,\n } from 'next-test-utils'\n import {\n appOption,\n@@ -89,16 +90,15 @@ describe('Edge runtime code with imports', () => {\n co...
2024-01-16T17:24:40
golang/go
1bcfdc777ad38bbb4faec8e1db2eaa92873f4e10
ada9385a5fd3908243dbb514040c07a41e4806bb
cmd/compile: change the multiple (gossa)hash separator from ; to / Semicolon has bad copy-paste ergonomics; it requires quoting. Slash is okay, and won't be a separator ever in debug strings because it is already used in e.g. ssa/phase/debug=etc. Change-Id: I493360e9282666eea1a342971a77df2ebd6c92ad Reviewed-on: https...
[ { "path": "src/cmd/compile/internal/base/hashdebug.go", "patch": "@@ -140,7 +140,7 @@ func NewHashDebug(ev, s string, file writeSyncer) *HashDebug {\n \t\thd.no = true\n \t\treturn hd\n \t}\n-\tss := strings.Split(s, \";\")\n+\tss := strings.Split(s, \"/\")\n \thd.matches = append(hd.matches, toHashAndMask(...
2022-11-04T15:23:12
nodejs/node
b0e4970b8fe0dbd6bf437b3b06d0438d906ea94d
dd0c5228acaf5695f96809e50771ead3167b0f44
tools: add debug entitlements for macOS 10.15+ To debug native modules node should be a debuggable process, that will require the **com.apple.security.get-task-allow** entitlement to be added to the codesign procedure. PR-URL: https://github.com/nodejs/node/pull/34378 Fixes: https://github.com/nodejs/node/issues/3434...
[ { "path": "tools/osx-entitlements.plist", "patch": "@@ -12,5 +12,7 @@\n <true/>\n <key>com.apple.security.cs.disable-library-validation</key>\n <true/>\n+ <key>com.apple.security.get-task-allow</key>\n+ <true/>\n </dict>\n </plist>", "additions": 2, "deletions": 0, "language": ...
2020-07-15T09:17:35
vercel/next.js
dc394483b807e5e111c175ad9afd1f09220da7ce
521b0adf83884034990d8ff5cd2c5efd69dbd9b5
Fix hmr updates with rebuilding for build errors (#60676) ### What Sometimes the display of the error overlay is not consistent even when you fixed the error Example: * You have a client page, and you add metadata export, Next.js will error that it's not allowed in client component. * You fix it, but the err...
[ { "path": "packages/next/src/client/components/react-dev-overlay/hot-reloader-client.tsx", "patch": "@@ -91,8 +91,16 @@ function handleAvailableHash(hash: string) {\n mostRecentCompilationHash = hash\n }\n \n-// Is there a newer version of this code available?\n+/**\n+ * Is there a newer version of this c...
2024-01-16T11:31:28
rust-lang/rust
8a988658a7caba4d7caf6926ba3b78e5f52d54f6
b7d76e299e0f03f3ab005fead1a83733398b5e88
Detect infinite loop in `async fn` not returning `!` This fixes an overzealous change made to avoid signaling infinite loops in anonymous blocks that may never be used.
[ { "path": "clippy_lints/src/loops/infinite_loop.rs", "patch": "@@ -4,7 +4,8 @@ use hir::intravisit::{Visitor, walk_expr};\n use rustc_ast::Label;\n use rustc_errors::Applicability;\n use rustc_hir::{\n- self as hir, Closure, ClosureKind, CoroutineDesugaring, CoroutineKind, Expr, ExprKind, FnRetTy, FnSig,...
2025-08-23T09:46:49
facebook/react
5967915ec4783f083250d796e2cf62ac64bab086
d59a039ebdebebf5c98ab96026529f66063979bf
Warn when calling setState & other methods at wrong time Currently we use an invariant to prevent this code pattern. That is really aggressive for something that doesn't actually put React in a bad state. This diff replaces invariants with warnings and makes those code paths no-ops.
[ { "path": "src/core/ReactUpdateQueue.js", "patch": "@@ -19,6 +19,7 @@ var ReactUpdates = require('ReactUpdates');\n \n var assign = require('Object.assign');\n var invariant = require('invariant');\n+var warning = require('warning');\n \n function enqueueUpdate(internalInstance) {\n if (internalInstance !...
2015-02-10T01:04:13
golang/go
ada9385a5fd3908243dbb514040c07a41e4806bb
0758a7d82da03d38fff8619a245f5fcb05721cf9
cmd/compile: fix PGO cross-package inlining With CL 447015, we identify hot callees from edge weights, but the code only traverses edges for calls from the current package. If the callee is in a different package, when compiling that package, the edge was not visited, so the callee was not actually marked inline candi...
[ { "path": "src/cmd/compile/internal/inline/inl.go", "patch": "@@ -87,7 +87,8 @@ func pgoInlinePrologue(p *pgo.Profile) {\n \tif s, err := strconv.ParseFloat(base.Debug.InlineHotCallSiteCDFThreshold, 64); err == nil {\n \t\tinlineCDFHotCallSiteThresholdPercent = s\n \t}\n-\tinlineHotCallSiteThresholdPercent ...
2022-11-04T17:54:59
nodejs/node
dd0c5228acaf5695f96809e50771ead3167b0f44
3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a
build: add flag to build V8 with OBJECT_PRINT Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will expose auxiliar functions to inspect heap objects using native debuggers. Fixes: https://github.com/nodejs/node/issues/32402 Signed-off-by: Mary Marchini <mmarchini@netflix.com> PR-URL: https://github.com...
[ { "path": "configure.py", "patch": "@@ -706,6 +706,12 @@\n 'memory footprint, but also implies no just-in-time compilation ' +\n 'support, thus much slower execution)')\n \n+parser.add_option('--v8-enable-object-print',\n+ action='store_true',\n+ dest='v8_enable_object_print',\n+ ...
2020-04-14T00:50:55
electron/electron
0736de1e8d3e40aee6bcb60927c8e656617b9fc7
12dbcfa2ea5ad9c817bbe1db9965179483a71827
Fix lint errors
[ { "path": "atom/browser/native_window_views.h", "patch": "@@ -171,8 +171,11 @@ class NativeWindowViews : public NativeWindow,\n bool PreHandleMSG(\n UINT message, WPARAM w_param, LPARAM l_param, LRESULT* result) override;\n void HandleSizeEvent(WPARAM w_param, LPARAM l_param);\n- static LRESULT C...
2017-08-03T21:23:42
rust-lang/rust
183fbdc89b5f7f3944644a5d3d1c762d7ea35f90
cf358c09cebfe3e1c0d7145242396f6066033fad
Fix `else` completion in `let _ = if x {} $0`
[ { "path": "src/tools/rust-analyzer/crates/ide-completion/src/context/analysis.rs", "patch": "@@ -943,9 +943,14 @@ fn classify_name_ref<'db>(\n };\n let prev_sibling = non_trivia_sibling(node.into(), Direction::Prev)?.into_node()?;\n \n- ast::ExprStmt::cast(prev_sibling.clo...
2025-08-23T07:52:54
vercel/next.js
521b0adf83884034990d8ff5cd2c5efd69dbd9b5
b177ff64889f520e2e423e4152ccc9900d72927c
Remove normalizeSnapshot as it is no longer used (#60664) ## What? Removes `normalizeSnapshot` helper in the test suite as it only replaces based on `NEXT_SWC_DEV_BIN` but that env var is no longer provided anywhere. This ensures that Jest can update the inline snapshots. <!-- Thanks for opening a PR! Your con...
[ { "path": "test/development/acceptance-app/ReactRefreshLogBox.test.ts", "patch": "@@ -222,9 +222,8 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {\n \n const source = await session.getRedboxSource()\n expect(next.normalizeTestDirContent(source)).toMatchInlineSnapshot(\n- ...
2024-01-16T10:11:06
golang/go
0758a7d82da03d38fff8619a245f5fcb05721cf9
edfe07834905809d687b30632ccb849b84ebd4f2
runtime: eliminate arbitrary timeouts in runBuiltTestProg and TestGdbBacktrace This may fix the TestEINTR failures that have been frequent on the riscv64 builders since CL 445597. Updates #37405. Updates #39043. Change-Id: Iaf1403ff5ce2ff0203d5d0059908097d32d0b217 Reviewed-on: https://go-review.googlesource.com/c/go...
[ { "path": "src/runtime/crash_test.go", "patch": "@@ -6,7 +6,6 @@ package runtime_test\n \n import (\n \t\"bytes\"\n-\t\"context\"\n \t\"errors\"\n \t\"flag\"\n \t\"fmt\"\n@@ -66,15 +65,17 @@ func runBuiltTestProg(t *testing.T, exe, name string, env ...string) string {\n \t\tt.Skip(\"-quick\")\n \t}\n \n-\tc...
2022-11-03T13:08:33
nodejs/node
3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a
71aeea1061024f0d896956f3d133cfb0aa66cbe1
doc: add writable and readable options to Duplex docs Fixes: https://github.com/nodejs/node/issues/34382 PR-URL: https://github.com/nodejs/node/pull/34383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M S...
[ { "path": "doc/api/stream.md", "patch": "@@ -2535,6 +2535,10 @@ changes:\n * `allowHalfOpen` {boolean} If set to `false`, then the stream will\n automatically end the writable side when the readable side ends.\n **Default:** `true`.\n+ * `readable` {boolean} Sets whether the `Duplex` should be re...
2020-07-15T15:56:34
facebook/react
462ab93d8390bdbd8d7dd2db365af12d2b4f6bf5
60c2f56e6e30e677ba8a7a4cadf463c62589d787
Fix markdown parsing error closes #3075
[ { "path": "docs/docs/10.5-clone-with-props.md", "patch": "@@ -15,7 +15,9 @@ Do a shallow copy of `component` and merge any props provided by `extraProps`. T\n > Note:\n >\n > `cloneWithProps` does not transfer `key` to the cloned component. If you wish to preserve the key, add it to the `extraProps` object:...
2015-02-08T11:31:48
rust-lang/rust
21c30eac49307a67b1ff81564bb94590926e10c5
0470945ec8bcd1b3e5589ed979c30572ee65b30a
Fix install test on Windows
[ { "path": "src/bootstrap/src/core/builder/tests.rs", "patch": "@@ -2312,8 +2312,9 @@ mod snapshot {\n insta::assert_snapshot!(\n ctx.config(\"install\")\n .args(&[\n- \"--set\", &format!(\"install.prefix={}\", ctx.dir().display()),\n- ...
2025-08-22T19:50:31
vercel/next.js
fe7322650b407a44a1900ef1ef09d19ca4c56e99
e169e73b45c3e1080fac28de097f691f5255723b
Turbopack test updates (#60662) ## What? Updates snapshots for Turbopack tests. They're slightly different than the webpack output. Generally better because column information is preserved. The import trace is not available in Turbopack as it would make the parent module a direct dependency of the module, meanin...
[ { "path": "test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts", "patch": "@@ -50,16 +50,28 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {\n `\n )\n expect(await session.hasRedbox()).toBe(true)\n- expect(await session.getRedboxSource()).toMatchIn...
2024-01-15T13:20:29
golang/go
edfe07834905809d687b30632ccb849b84ebd4f2
7ddbadb397b18ffadd308fea84884ae363e87b58
net/http: ignore ranges if the content is empty in serveContent Fixes #54794 Change-Id: I6f2b7b86b82ea27b9d53cf989daa21cb8ace13da Reviewed-on: https://go-review.googlesource.com/c/go/+/427195 Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@goog...
[ { "path": "src/net/http/fs.go", "patch": "@@ -254,81 +254,95 @@ func serveContent(w ResponseWriter, r *Request, name string, modtime time.Time,\n \t\tError(w, err.Error(), StatusInternalServerError)\n \t\treturn\n \t}\n+\tif size < 0 {\n+\t\t// Should never happen but just to be sure\n+\t\tError(w, \"negati...
2022-08-31T20:25:51
rust-lang/rust
ba1bc643250ee4eeae57a2182b82f3f9b27955c4
0579f055cd518904523758caec98df0273d2854e
Fix doc link
[ { "path": "src/bootstrap/src/core/build_steps/dist.rs", "patch": "@@ -142,7 +142,7 @@ impl Step for JsonDocs {\n /// various in-tree helper tools (bootstrap, build_helper, tidy),\n /// and also rustc_private tools like rustdoc, clippy, miri or rustfmt.\n ///\n-/// It is currently hosted at https://doc.rust-...
2025-08-16T07:57:16
electron/electron
7d7bb1581b01b8e10e21f5e1c04d79625a2684ad
5ccae79ea725b945815d222a79c1d963aefd1280
spec: Disable crashReporter tests for some CI machines Have no idea why it is failing on our CI machines, but at least Appveyor works fine.
[ { "path": "spec/api-crash-reporter-spec.js", "patch": "@@ -12,7 +12,7 @@ const {remote} = require('electron')\n const {app, BrowserWindow, crashReporter} = remote.require('electron')\n \n describe('crashReporter module', function () {\n- if (process.mas) {\n+ if (process.mas || process.env.DISABLE_CRASH_R...
2017-08-02T06:53:26
golang/go
d65c0593c4f1dd4a9b381cf654668aa27166b24e
90b40c0496440fbd57538eb4ba303164ed923d93
text/template/parse: fix interaction of break/continue keywords and functions Fixes a bug that was introduced in CL 410414; in that CL, to avoid a race condition in the initialization of the lexer, the setting of the breakOK and continueOK options was moved to before Tree.funcs was populated from parameters. As a resu...
[ { "path": "src/text/template/parse/parse.go", "patch": "@@ -223,6 +223,11 @@ func (t *Tree) startParse(funcs []map[string]any, lex *lexer, treeSet map[string\n \tt.vars = []string{\"$\"}\n \tt.funcs = funcs\n \tt.treeSet = treeSet\n+\tlex.options = lexOptions{\n+\t\temitComment: t.Mode&ParseComments != 0,\n...
2022-11-03T19:16:06
vercel/next.js
e169e73b45c3e1080fac28de097f691f5255723b
710ead0fb5e877abe73f6fb2cd55ba4d50da2829
Add hasRedbox fix (#60522) ## What? As @leerob and I found in-person when opening #57230 the `hasRedBox()` helper was incorrectly passing when it shouldn't pass in both the true and false case. This PR uses a different approach by waiting 7 seconds before checking, this leaves enough room for HMR / reloads to...
[ { "path": "test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts", "patch": "@@ -49,7 +49,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {\n }\n `\n )\n- expect(await session.hasRedbox(true)).toBe(true)\n+ expect(await session.hasRedbox()).t...
2024-01-15T08:36:44
rust-lang/rust
3ec2abc2f466dd466634056b8ad9d65d519e9fd0
2074e1344d33884324d125271d34e35b2d503ab0
Fix staging in `x install`
[ { "path": "src/bootstrap/src/core/build_steps/dist.rs", "patch": "@@ -762,36 +762,39 @@ pub struct Std {\n pub target: TargetSelection,\n }\n \n-impl Step for Std {\n- type Output = Option<GeneratedTarball>;\n- const DEFAULT: bool = true;\n-\n- fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>...
2025-08-15T18:43:41
electron/electron
28959da2b78f5b5aca1e3097c30c2a1f140af03c
d166d08dd5c4529f651e15c7c56f3c7f7e93f198
spec: Fix the event test calling done for multiple times
[ { "path": "spec/api-browser-window-spec.js", "patch": "@@ -1144,13 +1144,16 @@ describe('BrowserWindow module', function () {\n w.loadURL('file://' + path.join(fixtures, 'api', 'sandbox.html?window-events'))\n })\n \n- it('works for web contents events', function (done) {\n+ ...
2017-08-02T06:06:06
golang/go
90b40c0496440fbd57538eb4ba303164ed923d93
bc2dc2384619d871000f9627b5d4e2bdc1dd38dc
net: add ControlContext to Dialer Fixes #55301 Change-Id: Ie8abcd383eee9af75038bde908ac638f43d33b7e Reviewed-on: https://go-review.googlesource.com/c/go/+/444955 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ia...
[ { "path": "api/next/55301.txt", "patch": "@@ -0,0 +1 @@\n+pkg net, type Dialer struct, ControlContext func(context.Context, string, string, syscall.RawConn) error #55301\n\\ No newline at end of file", "additions": 1, "deletions": 0, "language": "Plain Text" }, { "path": "src/net/dial.go...
2022-10-23T00:41:38
vercel/next.js
710ead0fb5e877abe73f6fb2cd55ba4d50da2829
f8f58f81493e55fdd24e6c089db26383a27b3008
fix breakpoints on reload (#60507) ### What? Only apply Safari workaround for safari ### Why? The workaround breaks breakpoints. See comment Closes PACK-2227
[ { "path": "packages/next/src/server/app-render/create-component-styles-and-scripts.tsx", "patch": "@@ -26,12 +26,6 @@ export async function createComponentStylesAndScripts({\n \n const styles = cssHrefs\n ? cssHrefs.map((href, index) => {\n- // In dev, Safari and Firefox will cache the resource...
2024-01-15T08:17:40
electron/electron
4e2cb549c780c328f95e51c728404aaba6e207ae
b315eb83fd720576b374534be2251da23f830043
Notify net error asyncronously Notifying net error syncronously would result in crash.
[ { "path": "atom/browser/net/asar/url_request_asar_job.cc", "patch": "@@ -15,6 +15,7 @@\n #include \"base/strings/string_util.h\"\n #include \"base/synchronization/lock.h\"\n #include \"base/task_runner.h\"\n+#include \"base/threading/thread_task_runner_handle.h\"\n #include \"net/base/file_stream.h\"\n #inc...
2017-08-02T02:07:03
golang/go
bc2dc2384619d871000f9627b5d4e2bdc1dd38dc
c1c6b0ca79233c8b7612957291c2d47d337cc2de
os/exec: allow NUL in environment variables on Plan 9 Plan 9 uses NUL as os.PathListSeparator, so it's almost always going to appear in the environment variable list. Exempt GOOS=plan9 from the check for NUL in environment variables. For #56284. Fixes #56544. Change-Id: I23df233cdf20c0a9a606fd9253e15a9b5482575a Revi...
[ { "path": "src/os/exec/env_test.go", "patch": "@@ -14,6 +14,7 @@ func TestDedupEnv(t *testing.T) {\n \n \ttests := []struct {\n \t\tnoCase bool\n+\t\tnulOK bool\n \t\tin []string\n \t\twant []string\n \t\twantErr bool\n@@ -50,9 +51,15 @@ func TestDedupEnv(t *testing.T) {\n \t\t\twant: []string...
2022-11-03T18:02:51
facebook/react
0bf88f26a45090492bedcd49ab4f803f489d03b8
007207bac4858523878a03e44416863092c6f212
Corrected pure-render-mixin documentation Fixed the PureRenderMixin documentation which was incorrectly importing the base React library instead of ReactWithAddons.
[ { "path": "docs/docs/10.7-pure-render-mixin.md", "patch": "@@ -11,7 +11,7 @@ If your React component's render function is \"pure\" (in other words, it renders\n Example:\n \n ```js\n-var PureRenderMixin = require('react').addons.PureRenderMixin;\n+var PureRenderMixin = require('react/addons').addons.PureRen...
2015-02-06T19:34:09
vercel/next.js
f85d3af12d693ebed85f511f8b9f1484a71e75f0
28e892d9f17f92830491e0cf0eaf630c7d98d36c
Fix Typo in Testing Documentation Description (#60601) just a small typo I caught, lists 4 testing tools but says three in the description first contribution :) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow...
[ { "path": "docs/02-app/01-building-your-application/08-testing/index.mdx", "patch": "@@ -1,6 +1,6 @@\n ---\n title: Testing\n-description: Learn how to set up Next.js with three commonly used testing tools — Cypress, Playwright, Vitest, and Jest.\n+description: Learn how to set up Next.js with four commonly...
2024-01-15T01:33:12
nodejs/node
71aeea1061024f0d896956f3d133cfb0aa66cbe1
0f4b4ea5c61d0655a5bf3365845b12b26fe4e09c
doc: harden policy around objections Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: https://github.com/nodejs/node/issues/34564 PR-URL: https://github.com/nodejs/node/pull/34639 Reviewed-By: Anna Henningsen <anna@addaleax.ne...
[ { "path": "doc/guides/collaborator-guide.md", "patch": "@@ -120,14 +120,22 @@ needed [approvals](#code-reviews), [CI](#testing-and-ci), and\n except the [wait time](#waiting-for-approvals), please add the\n [`author ready`](#author-ready-pull-requests) label.\n \n-Where there is disagreement among Collabora...
2020-08-05T23:54:02
electron/electron
b315eb83fd720576b374534be2251da23f830043
bd697275c24ba8711b4e89b12f9fbf200081a31b
spec: Suppress the test that destroys WebContents in event listener It is crashing when Electron is built in Debug mode.
[ { "path": "spec/api-web-contents-spec.js", "patch": "@@ -590,6 +590,12 @@ describe('webContents module', function () {\n })\n \n describe('destroy()', () => {\n+ // Destroying webContents in its event listener is going to crash when\n+ // Electron is built in Debug mode.\n+ if (process.platform...
2017-08-02T01:34:33
facebook/react
7cb1b9bdb205c9e9b12505e75a9a70fc3aaa7464
007207bac4858523878a03e44416863092c6f212
fix next page link typo 下一页链接错误
[ { "path": "docs/docs/02-displaying-data.zh-CN.md", "patch": "@@ -4,7 +4,7 @@ title: 显示数据\n layout: docs\n permalink: displaying-data-zh-CN.html\n prev: why-react-zh-CN.html\n-next: jsx-in-depth.html\n+next: jsx-in-depth-zh-CN.html\n ---\n \n 用户界面能做的最基础的事就是显示一些数据。React 让显示数据变得简单,当数据变化的时候,用户界面会自动同步更新。", "...
2015-02-06T07:53:45
golang/go
69abfab979a22307bbd1b3f5f02a64349d16d3d5
aa6240a445d2478f29add6218b19147f5bf2204f
cmd/link: support PPC64 prefixed relocations for power10 Handle emitting (to ld) or resolving commonly used ELFv2 1.5 relocations. The new ISA provides PC relative addressing with 34 bit signed addresses, and many other relocations which can replace addis + d-form type relocations with a single prefixed instruction. ...
[ { "path": "src/cmd/internal/objabi/reloctype.go", "patch": "@@ -208,18 +208,30 @@ const (\n \t// (usually called RB in X-form instructions) is assumed to be R13.\n \tR_POWER_TLS\n \n+\t// R_POWER_TLS_IE_PCREL34 is similar to R_POWER_TLS_IE, but marks a single MOVD\n+\t// which has been assembled as a single...
2021-07-12T21:53:22
nodejs/node
84ef92f7cb93c00cf164e611e7496ac29554c2c5
6f12643142039bd099f8c021923ac4deea1ae725
meta: uncomment all codeowners A recent feature was added to github-bot to ping codeowners defined on the CODEOWNERS file even if the team doesn't have write permission to the repository. That means we can enable codeowners everywhere in the repository. Ref: https://github.com/nodejs/github-bot/pull/265 Fix: https://...
[ { "path": ".github/CODEOWNERS", "patch": "@@ -5,57 +5,57 @@\n # 3. PRs touching any code with a codeowner must be signed off by at least one\n # person on the code owner team.\n \n-./.github/CODEOWNERS @nodejs/tsc\n+/.github/CODEOWNERS @nodejs/tsc\n \n # net\n \n-# ./deps/cares @nodejs/net\n-# ./doc/api/...
2020-08-07T19:30:44
rust-lang/rust
f8b3c566cc9b27816efa17a21365d36dd55cd71f
9bd83171842123bbb1a153ef13543661827366ac
Refactor and document the `DebuggerScripts` dist step
[ { "path": "src/bootstrap/src/core/build_steps/dist.rs", "patch": "@@ -458,7 +458,7 @@ impl Step for Rustc {\n return tarball.generate();\n \n fn prepare_image(builder: &Builder<'_>, target_compiler: Compiler, image: &Path) {\n- let host = target_compiler.host;\n+ let ta...
2025-08-12T09:47:26
facebook/react
678ec31e4120fdeb765a4b32a91048559468841c
007207bac4858523878a03e44416863092c6f212
Fix typos
[ { "path": "docs/docs/10.1-animation.md", "patch": "@@ -175,7 +175,7 @@ Every DOM component that React can render is available for use. However, `compon\n >\n > Prior to v0.12, when using DOM components, the `component` prop needed to be a reference to `React.DOM.*`. Since the component is simply passed to `...
2015-02-06T06:47:56
electron/electron
1577360312252982d7f0b5fee08362f0e1140dec
eaa63c880eb7e0e73368c345a18f5c16ab577abc
fix lint errors
[ { "path": "npm/test/index.js", "patch": "@@ -2,7 +2,7 @@ const tape = require('tape')\n const proxyquire = require('proxyquire')\n const path = require('path')\n const sinon = require('sinon')\n-const admZip = require('adm-zip')\n+const AdmZip = require('adm-zip')\n const temp = require('temp')\n \n let san...
2017-08-01T15:50:57
golang/go
aa6240a445d2478f29add6218b19147f5bf2204f
48ff5c1042af780dade9f539368e8bc2259d2679
cmd/compile: allow ineffectual //go:linkname in -lang=go1.17 and older Prior to Go 1.18, ineffectual //go:linkname directives (i.e., directives referring to an undeclared name, or to a declared type or constant) were treated as noops. In Go 1.18, we changed this into a compiler error to mitigate accidental misuse. Ho...
[ { "path": "src/cmd/compile/internal/noder/noder.go", "patch": "@@ -132,7 +132,9 @@ func (p *noder) processPragmas() {\n \t\t}\n \t\tn := ir.AsNode(typecheck.Lookup(l.local).Def)\n \t\tif n == nil || n.Op() != ir.ONAME {\n-\t\t\tp.errorAt(l.pos, \"//go:linkname must refer to declared function or variable\")\...
2022-11-03T18:56:43
nodejs/node
989d82fe013def851f76309bcadd2e8847c8ee73
c0be31f0efd162f0edd416ed23f5aac082edd2aa
repl: use _Node.js_ in user-facing REPL text We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place in error messages in repl.js. Use _Node.js_ in both places. PR-URL: https://github.com/nodejs/node/pull/34644 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonma...
[ { "path": "lib/repl.js", "patch": "@@ -790,7 +790,7 @@ function REPLServer(prompt,\n \n if (e && !self[kBufferedCommandSymbol] && cmd.trim().startsWith('npm ')) {\n self.output.write('npm should be run outside of the ' +\n- 'node REPL, in your normal shell.\\n' +...
2020-08-06T05:19:11
facebook/react
8ab0ecba137ba030edea84cd19fc1bfaf0f071b8
3abfe00ae79e0398115f1cd106ea72f29134a416
Sync internal modules We've actually diverged more with some modules, but we don't want a cascade of dependencies out here. Mostly, the changes internally that we don't want are tied to FB infrastructure but otherwise are functionally equivalent (usually around error reporting, code monitoring).
[ { "path": "src/vendor/core/createArrayFromMixed.js", "patch": "@@ -6,7 +6,7 @@\n * LICENSE file in the root directory of this source tree. An additional grant\n * of patent rights can be found in the PATENTS file in the same directory.\n *\n- * @providesModule createArrayFrom\n+ * @providesModule createA...
2015-02-06T00:31:54
electron/electron
f56abac7a83002d41a99ba2224ed5c2adb15a12c
5a48c1feedf931159086d6c70fe8aaf7ddf1b15b
fix linting error
[ { "path": "lib/common/asar.js", "patch": "@@ -479,14 +479,14 @@\n }\n if (info.size === 0) {\n return process.nextTick(function () {\n- callback(null, encoding? '' : new Buffer(0))\n+ callback(null, encoding ? '' : new Buffer(0))\n })\n }\n if (info....
2017-08-01T09:52:48
golang/go
48ff5c1042af780dade9f539368e8bc2259d2679
d031e9e07a07afef8d16576fd7079a739a7e4394
cmd/go: fix a bug printing error output from c compiler fmt.Sprint should be called instead of fmt.Sprintf as is done elsewhere in exec.go Change-Id: I730c1f02238fccb24323701b587d3bf1391c9f62 Reviewed-on: https://go-review.googlesource.com/c/go/+/447656 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Mi...
[ { "path": "src/cmd/go/internal/work/exec.go", "patch": "@@ -848,7 +848,8 @@ OverlayLoop:\n \t\t}\n \n \t\tif err != nil {\n-\t\t\treturn errors.New(fmt.Sprint(formatOutput(b.WorkDir, p.Dir, p.Desc(), output)))\n+\t\t\tprefix, suffix := formatOutput(b.WorkDir, p.Dir, p.Desc(), output)\n+\t\t\treturn errors.N...
2022-11-03T17:18:13
nodejs/node
c0be31f0efd162f0edd416ed23f5aac082edd2aa
614298d0113aa5b9783a12dd9adba6023954bf9b
net: don't return the stream object from onStreamRead CallJSOnreadMethod expects the return value to be undefined or a new buffer, so make sure to return nothing, even when an error causes us to destroy the stream. Fixes: https://github.com/nodejs/node/issues/34346 PR-URL: https://github.com/nodejs/node/pull/34375 R...
[ { "path": "lib/internal/stream_base_commons.js", "patch": "@@ -208,7 +208,9 @@ function onStreamRead(arrayBuffer) {\n }\n \n if (nread !== UV_EOF) {\n- return stream.destroy(errnoException(nread, 'read'));\n+ // #34375 CallJSOnreadMethod expects the return value to be a buffer.\n+ stream.destro...
2020-07-15T03:41:11
vercel/next.js
dc697245aee5991d5d36267c4ea50443244460df
2bc242535aafdd731c31be2f574fcc226607762d
Update React from f1039be4a to 60a927d04 (#60619) Includes a fix for useOptimistic. React upstream changes: - https://github.com/facebook/react/pull/27936 - https://github.com/facebook/react/pull/27924 - https://github.com/facebook/react/pull/27930 - https://github.com/facebook/react/pull/27923 - https://git...
[ { "path": "package.json", "patch": "@@ -197,16 +197,16 @@\n \"random-seed\": \"0.3.0\",\n \"react\": \"18.2.0\",\n \"react-17\": \"npm:react@17.0.2\",\n- \"react-builtin\": \"npm:react@18.3.0-canary-f1039be4a-20240107\",\n+ \"react-builtin\": \"npm:react@18.3.0-canary-60a927d04-20240113\",...
2024-01-14T07:37:08
facebook/react
6af987c524d3801efd2a330f4ab1265b81f7cff3
04e6d02e403d4404c32763656cb711962d3421a5
Drop processAttributeNameAndPrefix and invalid attribute name escaping
[ { "path": "src/browser/ui/dom/DOMPropertyOperations.js", "patch": "@@ -16,7 +16,6 @@ var DOMProperty = require('DOMProperty');\n \n var escapeTextContentForBrowser = require('escapeTextContentForBrowser');\n var quoteAttributeValueForBrowser = require('quoteAttributeValueForBrowser');\n-var memoizeStringOnl...
2015-02-03T15:46:32
nodejs/node
614298d0113aa5b9783a12dd9adba6023954bf9b
e948ef351b4111d78ae8ba08f29eb138af22fa0b
repl: use _REPL_ in user-facing text User-facing error messages should use _REPL_ for the general REPL and not _repl_ which should be reserved for referring to the module itself, etc. _REPL_ is an acronym, so it should be capitalized, as it generally is in documentation in other technologies, and is usually in our own...
[ { "path": "lib/repl.js", "patch": "@@ -19,7 +19,7 @@\n // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE\n // USE OR OTHER DEALINGS IN THE SOFTWARE.\n \n-/* A repl library that you can include in your own code to get a runtime\n+/* A REPL library that you can include in your own c...
2020-08-06T05:03:54
golang/go
d031e9e07a07afef8d16576fd7079a739a7e4394
c065bc70ef45003216271ba42bdd4a4c321ac38a
cmd/compile/internal/ssa: re-adjust CarryChainTail scheduling priority This needs to be as low as possible while not breaking priority assumptions of other scores to correctly schedule carry chains. Prior to the arm64 changes, it was set below ReadTuple. At the time, this prevented the MulHiLo implementation on PPC64...
[ { "path": "src/cmd/compile/internal/ssa/schedule.go", "patch": "@@ -16,8 +16,8 @@ const (\n \tScoreNilCheck\n \tScoreReadTuple\n \tScoreVarDef\n-\tScoreMemory\n \tScoreCarryChainTail\n+\tScoreMemory\n \tScoreReadFlags\n \tScoreDefault\n \tScoreFlags", "additions": 1, "deletions": 1, "language": ...
2022-10-28T20:59:43
electron/electron
0ee2ab8a6e4e0200f5ef0fb709b04cdf2aaf7900
4b46eca329c3fc019ef35b7dfc90bd0f5c28ae81
Fix accessing empty vector in V8FunctionInvoker
[ { "path": "atom/common/native_mate_converters/callback.h", "patch": "@@ -56,7 +56,8 @@ struct V8FunctionInvoker<v8::Local<v8::Value>(ArgTypes...)> {\n v8::Local<v8::Context> context = holder->CreationContext();\n v8::Context::Scope context_scope(context);\n std::vector<v8::Local<v8::Value>> args...
2017-07-31T07:47:14
vercel/next.js
fcb635e1cdb201fb51dab1acf3ff19eb67a2814b
f6c4c2768bae701df144705510949d97f11109a9
docs: Update Google Analytics error doc (#60612) Closes https://github.com/vercel/next.js/issues/60598.
[ { "path": "errors/next-script-for-ga.mdx", "patch": "@@ -1,95 +1,75 @@\n ---\n-title: Next Script for Google Analytics\n+title: Using Google Analytics with Next.js (through `next/script`)\n ---\n \n > Prefer `next/script` component when using the inline script for Google Analytics.\n \n ## Why This Error Oc...
2024-01-13T18:27:41
nodejs/node
e948ef351b4111d78ae8ba08f29eb138af22fa0b
f32114441c4aca6fc432897f92fc26135bf490a0
module: handle Top-Level Await non-fulfills better Handle situations in which the main `Promise` from a TLA module is not fulfilled better: - When not resolving the `Promise` at all, set a non-zero exit code (unless another one has been requested explicitly) to distinguish the result from a successful completion....
[ { "path": "doc/api/process.md", "patch": "@@ -2586,6 +2586,8 @@ cases:\n and generally can only happen during development of Node.js itself.\n * `12` **Invalid Debug Argument**: The `--inspect` and/or `--inspect-brk`\n options were set, but the port number chosen was invalid or unavailable.\n+* `13` **U...
2020-08-06T00:56:17
golang/go
3511c822f766fdf16817c1a1949971806c4eeb7e
44cabb802af220388aa1d74776e076e75c53aeb0
go/build: don't add unparsable non-Go files to InvalidGoFiles go/build attempts to parse comments at the beginning of non-Go files looking for //go:build or //+go build comments. Before this change, if the beginning of the non-Go file failed to parse (perhaps because it is in a format that isn't even meant to be built...
[ { "path": "src/cmd/go/internal/modindex/read.go", "patch": "@@ -458,14 +458,14 @@ func (rp *IndexPackage) Import(bctxt build.Context, mode build.ImportMode) (p *b\n \n \t// We need to do a second round of bad file processing.\n \tvar badGoError error\n-\tbadFiles := make(map[string]bool)\n-\tbadFile := func...
2022-11-02T18:36:51
vercel/next.js
4fc7ec1c8c29718c76f1ab578550f31068358f45
52bb91b40d3526ab7edee31e5beb593ef515df26
Update flakey dev middleware test (#60590) This error can show more than just once depending on number of requests to the page and refreshes. x-ref: https://github.com/vercel/next.js/actions/runs/7507976633/job/20442621189?pr=60589 Closes NEXT-2093
[ { "path": "test/development/middleware-errors/index.test.ts", "patch": "@@ -249,9 +249,9 @@ createNextDescribe(\n await next.fetch('/')\n await check(async () => {\n expect(next.cliOutput).toContain(`Expected '{', got '}'`)\n- expect(next.cliOutput.split(`Expected '{', got...
2024-01-12T22:43:37
facebook/react
263800e09ba778769c36757f6187bc336cbf9ce1
6672a7ec6220a3a54bb0d3fac53ffde0e0d55840
Fix isMounted inside of render This is apparently used to determine if you can access refs. Bad pattern, but a pattern nonetheless.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -196,22 +196,25 @@ var ReactCompositeComponentMixin = {\n this._pendingReplaceState = false;\n this._pendingForceUpdate = false;\n \n- if (inst.componentWillMount) {\n- var previouslyMounting = ReactLifeCycle.currentlyMountingInst...
2015-02-04T19:50:04
electron/electron
4b46eca329c3fc019ef35b7dfc90bd0f5c28ae81
9ced85d8608a1f09d33d6ae25a92f748c10f037b
spec: Always run crash-reporter at last So when a test crashed we can always see the stack trace.
[ { "path": "spec/static/index.html", "patch": "@@ -62,16 +62,17 @@\n if (query.invert) mocha.invert();\n \n // Read all test files.\n- var walker = require('walkdir').walk(require('path').dirname(__dirname), {\n+ var walker = require('walkdir').walk(path.dirname(__dirname), {\n no_recurse: true\n ...
2017-07-31T07:36:52
nodejs/node
f32114441c4aca6fc432897f92fc26135bf490a0
e1eb56fc94f4a345dfde51847e551b132cf98da8
test: fix wrong method call PR-URL: https://github.com/nodejs/node/pull/34629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewe...
[ { "path": "test/parallel/test-fs-write-reuse-callback.js", "patch": "@@ -35,5 +35,5 @@ const ondone = common.mustCall((err) => {\n write();\n function write() {\n const buf = Buffer.alloc(size, 'x');\n- fs.write(fd, buf, 0, buf.size, -1, ondone);\n+ fs.write(fd, buf, 0, buf.length, -1, ondone);\n }", ...
2020-08-05T04:52:15
golang/go
44cabb802af220388aa1d74776e076e75c53aeb0
0b76e326bb15ec828aeb1470902a71c7416b64b9
cmd/compile: if GOGC is not set, temporarily boost it for rapid starting heap growth Benchmarking suggests about a 14-17% reduction in user build time, about 3.5-7.8% reduction for wall time. This helps most builds because small packages are common. Latest benchmarks (after the last round of improvement): (12 proces...
[ { "path": "src/cmd/compile/internal/base/base.go", "patch": "@@ -5,7 +5,11 @@\n package base\n \n import (\n+\t\"fmt\"\n \t\"os\"\n+\t\"runtime\"\n+\t\"runtime/debug\"\n+\t\"runtime/metrics\"\n )\n \n var atExitFuncs []func()\n@@ -26,6 +30,196 @@ func Exit(code int) {\n // To enable tracing support (-t flag...
2022-09-28T21:10:59
vercel/next.js
4e71496e11587c248fe6a201d2da01ed5b6ced37
e620531480d7eb150a457c066179f2d08ad16d84
test(fixture): update assertion for turbopack (#60579) ### What? Minor update to test assertion to work with turbopack. Closes PACK-2234
[ { "path": "test/development/acceptance-app/component-stack.test.ts", "patch": "@@ -50,12 +50,13 @@ describe('Component Stack in error overlay', () => {\n \n await session.waitForAndOpenRuntimeError()\n \n- expect(await session.getRedboxComponentStack()).toMatchInlineSnapshot(`\n- \"p\n- ...
2024-01-12T21:43:09
electron/electron
9ced85d8608a1f09d33d6ae25a92f748c10f037b
6ee95f952944f7903b90d4c4a6e27bae56c7c66f
Terminate tests when renderer process crashed
[ { "path": "spec/static/main.js", "patch": "@@ -141,6 +141,10 @@ app.on('ready', function () {\n })\n if (chosen === 0) window.destroy()\n })\n+ window.webContents.on('crashed', function () {\n+ console.error('Renderer process crashed')\n+ process.exit(1)\n+ })\n \n // For session's downl...
2017-07-31T07:24:23
nodejs/node
e1eb56fc94f4a345dfde51847e551b132cf98da8
ac5773b1c302409c472aafea19ab13bb17320ba9
doc: add Ricky Zhou to collaborators PR-URL: https://github.com/nodejs/node/pull/34676 Fixes: https://github.com/nodejs/node/issues/34441 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
[ { "path": "README.md", "patch": "@@ -383,6 +383,8 @@ For information about the governance of the Node.js project, see\n **Pranshu Srivastava** &lt;rexagod@gmail.com&gt; (he/him)\n * [richardlau](https://github.com/richardlau) -\n **Richard Lau** &lt;riclau@uk.ibm.com&gt;\n+* [rickyes](https://github.com/ric...
2020-08-08T07:27:57
golang/go
0b76e326bb15ec828aeb1470902a71c7416b64b9
5c0d314adcc605e0198b2bb45a34db701c9e072c
net: do not modify shared test variable in TestDNSReadConfig Fixes #56542 Change-Id: I294856f8fb4d49393310ec92ab40fb7d841b6570 GitHub-Last-Rev: a4563400af816caa6119775b7b01b51134c62149 GitHub-Pull-Request: golang/go#56545 Reviewed-on: https://go-review.googlesource.com/c/go/+/447198 Reviewed-by: Bryan Mills <bcmills@...
[ { "path": "src/net/dnsconfig_unix_test.go", "patch": "@@ -176,16 +176,17 @@ func TestDNSReadConfig(t *testing.T) {\n \tgetHostname = func() (string, error) { return \"host.domain.local\", nil }\n \n \tfor _, tt := range dnsReadConfigTests {\n-\t\tif len(tt.want.search) == 0 {\n-\t\t\ttt.want.search = append...
2022-11-03T15:18:25
facebook/react
d74d0e321531fd586166b43f0d51906b370fb5b7
9174501771e9fb4776db3ec44e0fe0f0a630e8c1
Fix list formatting in glossary
[ { "path": "docs/docs/ref-09-glossary.md", "patch": "@@ -76,6 +76,7 @@ If you are using JSX you have no need for factories. JSX already provides a conv\n ## React Nodes\n \n A `ReactNode` can be either:\n+\n - `ReactElement`\n - `string` (aka `ReactText`)\n - `number` (aka `ReactText`)", "additions": 1, ...
2015-02-04T06:33:46
vercel/next.js
756027bf10881b0aa9d95529f8d39077f1d205d0
0e97fcd3c60228763cf648bc6b3998e9cef08474
fix(mdx): update word order, fix typo (#60466) Reverse directory order to indicate that `src/` or the parent of `app/` should be used. At first I thought the correct place was the parent folder of `src/`, this eliminates that confusion
[ { "path": "docs/02-app/01-building-your-application/07-configuring/05-mdx.mdx", "patch": "@@ -40,7 +40,7 @@ npm install @next/mdx @mdx-js/loader @mdx-js/react @types/mdx\n \n <AppOnly>\n \n-Create a `mdx-components.tsx` file at the root of your application (the parent folder of `app/` or `src/`):\n+Create a...
2024-01-12T21:16:45
electron/electron
6ee95f952944f7903b90d4c4a6e27bae56c7c66f
a6c8329a685090dd7c00fa25be81b196d41b508b
Fix crash when converting invalid image to JPEG
[ { "path": "atom/common/api/atom_api_native_image.cc", "patch": "@@ -291,6 +291,8 @@ v8::Local<v8::Value> NativeImage::ToBitmap(mate::Arguments* args) {\n v8::Local<v8::Value> NativeImage::ToJPEG(v8::Isolate* isolate, int quality) {\n std::vector<unsigned char> output;\n gfx::JPEG1xEncodedDataFromImage(i...
2017-07-31T06:48:54
nodejs/node
262d0d0482ffd2fe7d654422df9df1f350045635
09c5942bfd0efe92e0a4f6791681be915752283d
n-api: fix use-after-free with napi_remove_async_cleanup_hook Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 PR-URL: https://github.com/nodejs/node/pull/34662 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "src/node_api.cc", "patch": "@@ -533,6 +533,7 @@ napi_status napi_add_async_cleanup_hook(\n auto handle = node::AddEnvironmentCleanupHook(env->isolate, fun, arg);\n if (remove_handle != nullptr) {\n *remove_handle = new napi_async_cleanup_hook_handle__ { std::move(handle) };\n+ env->Ref...
2020-08-07T10:48:45
facebook/react
279b956c9b54755163fd73af3b898cee91d2a94f
9f9d833065292bcd2a0638655a5ec2c8330f850c
Set state takes a function This diff enables setState to accept a function in addition to a state partial. If you provide a function, it will be called with the up-to-date `state, props, context` as arguments. This enables some nicer syntax for complex setState patterns: If setState is doing an increment and wants t...
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -96,7 +96,8 @@ var ReactCompositeComponentMixin = {\n \n // See ReactUpdateQueue\n this._pendingElement = null;\n- this._pendingState = null;\n+ this._pendingStateQueue = null;\n+ this._pendingReplaceState = false;\n this._pe...
2015-01-31T00:42:28