repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
golang/go
5c0d314adcc605e0198b2bb45a34db701c9e072c
7abc8a2e3370bd013d9aa12b5d443e21537dfb26
runtime: support control flow guard on windows/amd64 The stack pointer must lie within system stack limits when Control Flow Guard (CFG) is enabled on Windows. This CL updates runtime.sigtramp to honor this restriction by porting some code from the windows/arm64 version, which already supports CFG. Fixes #53560 Cha...
[ { "path": "src/runtime/sys_windows_amd64.s", "patch": "@@ -116,6 +116,7 @@ TEXT sigtramp<>(SB),NOSPLIT|NOFRAME,$0-0\n \t// Make stack space for the rest of the function.\n \tADJSP\t$48\n \n+\tMOVQ\tCX, R13\t// save exception address\n \tMOVQ\tAX, R15\t// save handler address\n \n \t// find g\n@@ -153,28 +15...
2022-10-02T11:24:34
vercel/next.js
d16ff74a3bb31da2fdfd9b593d51c7e58afde9e9
9294ab2fb03f5cc76e770bef05629859269652fa
docs: small fix in Redirecting page (#60583) ref: #60435
[ { "path": "docs/02-app/01-building-your-application/01-routing/06-redirecting.mdx", "patch": "@@ -72,7 +72,7 @@ See the [`redirect` API reference](/docs/app/api-reference/functions/redirect) f\n \n ## `permanentRedirect` function\n \n-The `permanentRedirect` function allows you to **permanently** redirect t...
2024-01-12T21:08:41
facebook/react
62213e08df0bb75ab8d03f462f4a1814c883eaea
8fc4f23cdb70682e040986f72d99071cd01cc636
Fix highlighting
[ { "path": "docs/docs/tutorial.md", "patch": "@@ -482,7 +482,7 @@ var CommentForm = React.createClass({\n \n Let's make the form interactive. When the user submits the form, we should clear it, submit a request to the server, and refresh the list of comments. To start, let's listen for the form's submit even...
2015-02-03T10:38:16
nodejs/node
09c5942bfd0efe92e0a4f6791681be915752283d
9511261f350bf4791f6edf567a1c68e3ad540722
src: spin shutdown loop while immediates are pending This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: https://github.com/nodejs/node/pull/34662 Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 Reviewed-By: Gabriel Schulhof <gabriel.s...
[ { "path": "src/env.cc", "patch": "@@ -634,7 +634,10 @@ void Environment::RunCleanup() {\n initial_base_object_count_ = 0;\n CleanupHandles();\n \n- while (!cleanup_hooks_.empty()) {\n+ while (!cleanup_hooks_.empty() ||\n+ native_immediates_.size() > 0 ||\n+ native_immediates_threadsafe...
2020-08-07T14:24:36
golang/go
667c53e1599fbc61b48e3ddc95e2361b8c8fb8a5
1f65c399befa37e6727bb1a1a40aca65c4b6bcc4
cmd/compile: add debug-hash flag for fused-multiply-add This adds a -d debug flag "fmahash" for hashcode search for floating point architecture-dependent problems. This variable has no effect on architectures w/o fused-multiply-add. This was rebased onto the GOSSAHASH renovation so that this could have its own dedica...
[ { "path": "src/cmd/compile/internal/base/debug.go", "patch": "@@ -25,6 +25,7 @@ type DebugFlags struct {\n \tDumpPtrs int `help:\"show Node pointers values in dump output\"`\n \tDwarfInl int `help:\"print information about DWARF inlined function creation\"`\n ...
2022-10-21T22:10:23
vercel/next.js
3738e8ecc04f2cc3f24dcf468ad315c060b9e5ca
61803f818a1fd2865e481719ef196ad3b4180160
Fix react-refresh for transpiled packages (#60563) ### What We're applying react-refresh to browser layer and inject ESM or CJS helper based on file type. Some package from `trasnpilePackages` might contain CJS browser bundle. And injecting ESM helper breaks them. Actually they don't need to have fast refresh ab...
[ { "path": "packages/next/src/build/webpack-config.ts", "patch": "@@ -781,6 +781,12 @@ export default async function getBaseWebpackConfig(\n .join('|')})[/\\\\\\\\]`\n )\n \n+ const transpilePackagesRegex = new RegExp(\n+ `[/\\\\\\\\]node_modules[/\\\\\\\\](${config.transpilePackages\n+ ?.ma...
2024-01-12T20:44:41
electron/electron
22bf43ecc030b32bca105f97d145b06078bb3c1a
e10ebfa7f3301c23a4805d1245acda3f620735ce
Fix Linux ia32/arm build
[ { "path": "brightray/brightray.gypi", "patch": "@@ -203,12 +203,12 @@\n 'BasicRuntimeChecks': '3', # 3 = all checks enabled, 0 = off\n },\n 'VCLinkerTool': {\n- 'OptimizeReferences': 2, # /OPT:REF \n+ 'OptimizeReferences': 2, # /OPT:REF\n 'E...
2017-07-31T03:37:56
nodejs/node
9511261f350bf4791f6edf567a1c68e3ad540722
014feecc445c7dfc754378f2626cd43ee30a448d
src: fix `size` underflow in CallbackQueue Only decrease the size when actually removing items. PR-URL: https://github.com/nodejs/node/pull/34662 Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: J...
[ { "path": "src/callback_queue-inl.h", "patch": "@@ -22,8 +22,8 @@ CallbackQueue<R, Args...>::Shift() {\n head_ = ret->get_next();\n if (!head_)\n tail_ = nullptr; // The queue is now empty.\n+ size_--;\n }\n- size_--;\n return ret;\n }\n ", "additions": 1, "deletions": 1, ...
2020-08-07T14:24:05
golang/go
ebb71ad681ec5711c004537e5800a10e5a3ab533
bb3965695d3bc3586fba55c7b8d5e8a56cd4c0c9
cmd/go: update TestScripts/svn to not depend on TZ database `TestScripts/svn` test suite fails if the host does not have a TZ database installed. This CL updates those tests so SVN formats dates using UTC, which don't require a TZ database. Fixes #56527 Change-Id: I20f3c03c3cedd7d748f4623dddc66bd04d1df318 Reviewed-...
[ { "path": "src/cmd/go/testdata/vcstest/svn/hello.txt", "patch": "@@ -1,6 +1,7 @@\n handle svn\n \n-env TZ='America/New_York'\n+# Ensure SVN displays dates using UTC.\n+env TZ=''\n \n mkdir db/transactions\n mkdir db/txn-protorevs\n@@ -30,7 +31,7 @@ func main() {\n }\n -- .checkout/.svn-log --\n ------------...
2022-11-02T16:41:21
facebook/react
e3f95ea2936f06bb5986920c7f896f5c74d1a015
50c38bbc7598f1537c2928d370de78acce6a81c1
Hot fix cyclic dependency We accidentally created an unfortunate cyclic dependency because of the auto-wrapper hack that uses ReactClass. Making it injected instead.
[ { "path": "src/browser/ui/ReactDefaultInjection.js", "patch": "@@ -20,6 +20,7 @@ var ExecutionEnvironment = require('ExecutionEnvironment');\n var HTMLDOMPropertyConfig = require('HTMLDOMPropertyConfig');\n var MobileSafariClickEventPlugin = require('MobileSafariClickEventPlugin');\n var ReactBrowserCompone...
2015-02-03T07:55:34
vercel/next.js
61803f818a1fd2865e481719ef196ad3b4180160
3e221fb61443fbbc729c376acc980b007d5a17de
[PPR Nav] Fix flash of loading state during back/forward (#60578) ### Depends on - #60577 --- A popstate navigation reads data from the local cache. It does not issue new network requests (unless the cache entries have been evicted). So, when navigating with back/forward, we should not switch back to the P...
[ { "path": "packages/next/src/client/components/router-reducer/ppr-navigations.ts", "patch": "@@ -727,6 +727,67 @@ function abortPendingCacheNode(\n }\n }\n \n+export function updateCacheNodeOnPopstateRestoration(\n+ oldCacheNode: CacheNode,\n+ routerState: FlightRouterState\n+) {\n+ // A popstate navig...
2024-01-12T19:18:54
nodejs/node
0a3ac681c2f58a3c4f4ef9045b90f5a3bc30c184
607183efff97a78e4daf9b624b7d973b207db9f9
deps: update to uvwasi 0.0.10 Notable changes: - The uvwasi_preopen_t now uses const char* for the mapped_path and real_path fields. Previously, these were not `const`. - uvwasi_path_filestat_get() now properly handles the UVWASI_LOOKUP_SYMLINK_FOLLOW flag. - uvwasi_options_init() has been added to reduce the boi...
[ { "path": "deps/uvwasi/include/uvwasi.h", "patch": "@@ -10,7 +10,7 @@ extern \"C\" {\n \n #define UVWASI_VERSION_MAJOR 0\n #define UVWASI_VERSION_MINOR 0\n-#define UVWASI_VERSION_PATCH 9\n+#define UVWASI_VERSION_PATCH 10\n #define UVWASI_VERSION_HEX ((UVWASI_VERSION_MAJOR << 16) | \\\n ...
2020-08-04T16:50:53
golang/go
bb3965695d3bc3586fba55c7b8d5e8a56cd4c0c9
3e3a8fe5bed87845e7c93da50378403564ad9e69
cmd/go/internal/vcs: also check file mode when identifying VCS root Currently, FromDir identifies a VCS checkout directory just by checking whether it contains a specified file. This is not enough. For example, although there is a ".git" file (a plain file, not a directory) in a git submodule directory, this directory...
[ { "path": "src/cmd/go/internal/vcs/vcs.go", "patch": "@@ -34,8 +34,8 @@ import (\n // like Mercurial, Git, or Subversion.\n type Cmd struct {\n \tName string\n-\tCmd string // name of binary to invoke command\n-\tRootNames []string // filename indicating the root of a checkout directory\n+\tCmd...
2022-11-02T16:55:51
vercel/next.js
3da48113f98170dfcb10b160fd3ace0c1ec23f44
4640ed0604e85727fedcba758be4ac47d120d206
propagate notFound errors past a segment's error boundary (#60567) ### What? Throwing a `notFound()` error inside of a segment that has an error boundary will cause it to be handled by the segment's error boundary rather than a parent not-found boundary. ### Why? We assume anything that hits an `ErrorBoundary` ...
[ { "path": "packages/next/src/client/components/error-boundary.tsx", "patch": "@@ -2,6 +2,7 @@\n \n import React from 'react'\n import { usePathname } from './navigation'\n+import { isNextRouterError } from './is-next-router-error'\n \n const styles = {\n error: {\n@@ -73,6 +74,12 @@ export class ErrorBoun...
2024-01-12T15:58:45
nodejs/node
318c982f3b1cd2d836de0e03ca9c9ecb634b546c
bfebfdb149cf2d68ceee19f207ba65e0d8357a7f
tools: fix C++ import checker argument expansion Makefile assumes that it can pass a list of files to the import checker, whereas the import checker expects a single argument that is interpreted as a blob. Fix that mismatch by accepting multiple arguments in the import checker. Refs: https://github.com/nodejs/node/p...
[ { "path": "tools/checkimports.py", "patch": "@@ -5,7 +5,7 @@\n import io\n import re\n import sys\n-\n+import itertools\n \n def do_exist(file_name, lines, imported):\n if not any(not re.match('using \\w+::{0};'.format(imported), line) and\n@@ -41,5 +41,10 @@ def is_valid(file_name):\n return valid\n ...
2020-07-31T15:59:38
golang/go
a367981b4c8e3ae955eca9cc597d9622201155f3
1bfb51f8f79acc13ff1c79576bf0a340d4d6706e
crypto/x509: create CRLs with Issuer.RawSubject Per discussion with Roland Shoemaker, this updates x509.CreateRevocationList to mirror the behavior of x509.CreateCertificate, creating an internal struct for the ASN.1 encoding of the CRL. This allows us to switch the Issuer field type to asn1.RawValue, bypassing the ro...
[ { "path": "src/crypto/x509/x509.go", "patch": "@@ -2149,6 +2149,29 @@ type RevocationList struct {\n \tExtraExtensions []pkix.Extension\n }\n \n+// These structures reflect the ASN.1 structure of X.509 CRLs better than\n+// the existing crypto/x509/pkix variants do. These mirror the existing\n+// certificat...
2022-11-02T16:19:23
vercel/next.js
8515741933e70045db4fa1008f97dec08a5950ed
10e8f4d4379922413ac288541b5c86295ec79ad1
Fix logging order of build jobs (#60564) The Next.js version should always be output first instead of other jobs in `next build` Closes NEXT-2078
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -806,6 +806,15 @@ export default async function build(\n telemetry.record(events)\n )\n \n+ // Always log next version first then start rest jobs\n+ const { envInfo, expFeatureInfo } = await getStartServerInfo(dir)\n+ lo...
2024-01-12T14:03:20
electron/electron
5a48c1feedf931159086d6c70fe8aaf7ddf1b15b
d38c9a4644215c8095c3a115ebecd5e7649e8d22
fixes 10128
[ { "path": "lib/common/asar.js", "patch": "@@ -457,8 +457,18 @@\n }\n if (typeof options === 'function') {\n callback = options\n- options = void 0\n+ options = {\n+ encoding: null\n+ }\n+ } else if (util.isString(options)) {\n+ options = {\n+ ...
2017-07-31T01:32:45
facebook/react
ba55716a2d8a73fef2f0bfdcf191eb3858166380
28f50c8a78cffc0b0e9d60e4a7c77cc14a8e80c7
Fix warning messages wording and access of displayName
[ { "path": "src/browser/ui/ReactMount.js", "patch": "@@ -353,11 +353,12 @@ var ReactMount = {\n // verify that that's the case.\n warning(\n ReactCurrentOwner.current == null,\n- '%s._renderNewRootComponent(): Render methods should be a pure ' +\n- 'function of props and state; trigge...
2015-02-02T23:00:48
nodejs/node
bfebfdb149cf2d68ceee19f207ba65e0d8357a7f
93959b22b197e2e9fdb4a21e65e567729d76338d
src: fix linter failures Fix linter failures when running the linter on all source files. PR-URL: https://github.com/nodejs/node/pull/34582 Refs: https://github.com/nodejs/node/pull/34565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@g...
[ { "path": "src/api/hooks.cc", "patch": "@@ -10,10 +10,10 @@ using v8::HandleScope;\n using v8::Integer;\n using v8::Isolate;\n using v8::Local;\n+using v8::NewStringType;\n using v8::Object;\n using v8::String;\n using v8::Value;\n-using v8::NewStringType;\n \n void RunAtExit(Environment* env) {\n env->Ru...
2020-07-31T15:58:53
golang/go
1bfb51f8f79acc13ff1c79576bf0a340d4d6706e
582a6c2db4dfb617e709b7c8d859ff548aee1b1a
all: fix a few function names on comments Change-Id: Ida7e756f01a2c115ac58bf10aa13b2f8fd57b6a1 GitHub-Last-Rev: 4694d397bd3ad488fd05ed2cc6ad97909f09e707 GitHub-Pull-Request: golang/go#56537 Reviewed-on: https://go-review.googlesource.com/c/go/+/447436 Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Goph...
[ { "path": "src/go/printer/printer.go", "patch": "@@ -1040,7 +1040,7 @@ func (p *printer) flush(next token.Position, tok token.Token) (wroteNewline, dro\n \treturn\n }\n \n-// getNode returns the ast.CommentGroup associated with n, if any.\n+// getDoc returns the ast.CommentGroup associated with n, if any.\n...
2022-11-03T03:46:23
electron/electron
bd99bcbf64cc72ce82757ef19920dddd68ab6365
32327b77a5a75d90ba14e40264da2aa512ea3a91
Fix typo in comment
[ { "path": "atom/browser/atom_browser_client.cc", "patch": "@@ -123,7 +123,7 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(\n //\n // NOTE: We know that nativeWindowOpen is enabled at this point\n // because we check if it is NOT enabled above this point. We\n- // will only reach thi...
2017-07-31T01:00:00
vercel/next.js
10e8f4d4379922413ac288541b5c86295ec79ad1
cc2bd0de769522f2cc2e4df9d7061a236806f7fe
Enable windowHistorySupport by default (#60557) ## What? Enables `experimental.windowHistorySupport` by default. It has been in experimental for quite a while now and has been successfully dogfooded in vercel.com as well. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your P...
[ { "path": "docs/02-app/01-building-your-application/01-routing/03-linking-and-navigating.mdx", "patch": "@@ -188,7 +188,7 @@ For a full list of `useRouter` methods, see the [API reference](/docs/app/api-re\n \n Next.js allows you to use the native [`window.history.pushState`](https://developer.mozilla.org/e...
2024-01-12T13:18:43
nodejs/node
93959b22b197e2e9fdb4a21e65e567729d76338d
57c8549c561c9892c0c1efb948728b92ddb78516
test: add debugging for callbacks in test-https-foafssl.js The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603...
[ { "path": "test/parallel/test-https-foafssl.js", "patch": "@@ -56,7 +56,7 @@ const server = https.createServer(options, common.mustCall(function(req, res) {\n assert.strictEqual(cert.exponent, exponent);\n assert.strictEqual(cert.modulus, modulus);\n res.writeHead(200, { 'content-type': 'text/plain' }...
2020-08-02T18:10:49
golang/go
2af48cbb7d85e5fdc635e75b99f949010c607786
fb4f7fdb26da9ed0fee6beab280c84b399edaa42
cmd/go: add -C flag The -C flag is like tar -C or make -C: it changes to the named directory early in command startup, before anything else happens. Fixes #50332. Change-Id: I8e4546f69044cb3a028d4d26dfba482b08cb845d Reviewed-on: https://go-review.googlesource.com/c/go/+/421436 Reviewed-by: Bryan Mills <bcmills@googl...
[ { "path": "src/cmd/doc/main.go", "patch": "@@ -57,12 +57,13 @@ import (\n )\n \n var (\n-\tunexported bool // -u flag\n-\tmatchCase bool // -c flag\n-\tshowAll bool // -all flag\n-\tshowCmd bool // -cmd flag\n-\tshowSrc bool // -src flag\n-\tshort bool // -short flag\n+\tunexported bool // ...
2022-08-05T17:09:20
vercel/next.js
cc2bd0de769522f2cc2e4df9d7061a236806f7fe
bb105ef4fbfed9d96a93794eeaed956eda2116d8
chore: update next-repo-info actions (#60559) ## Description A few changes to https://github.com/vercel/next.js/tree/canary/.github/actions/next-repo-info and related workflows. ## Changes - Update `generateBlocks()` function - Fix Slack channel title typo - Fix `issuesAndPullRequests({ ... })` API call ...
[ { "path": ".github/actions/next-repo-info/package.json", "patch": "@@ -2,9 +2,8 @@\n \"private\": true,\n \"description\": \"Notify Next.js team about pending PRs and popular issues\",\n \"scripts\": {\n- \"build\": \"pnpm build-pr && pnpm build-issues\",\n- \"build-pr\": \"ncc build src/pr-appr...
2024-01-12T11:19:22
facebook/react
c371709d23557831c3779914a9773bbc471b228c
8d6c8a77931a67200e043466a1add6eabeb30a97
Newlines handled incorrectly in innerText in IE8
[ { "path": "src/browser/ui/dom/DOMChildrenOperations.js", "patch": "@@ -15,17 +15,9 @@\n var Danger = require('Danger');\n var ReactMultiChildUpdateTypes = require('ReactMultiChildUpdateTypes');\n \n-var getTextContentAccessor = require('getTextContentAccessor');\n+var setTextContent = require('setTextConten...
2014-07-18T09:38:16
nodejs/node
57c8549c561c9892c0c1efb948728b92ddb78516
0dff5bc2d8d03733093848d6691a347755f914cc
test: add debugging for test-https-foafssl.js The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603 Reviewed-By:...
[ { "path": "test/parallel/test-https-foafssl.js", "patch": "@@ -57,6 +57,7 @@ const server = https.createServer(options, common.mustCall(function(req, res) {\n assert.strictEqual(cert.modulus, modulus);\n res.writeHead(200, { 'content-type': 'text/plain' });\n res.end(body);\n+ console.log('sent respo...
2020-08-02T18:10:49
golang/go
ca8b31920a23541dda56bc76d3ddcaef3c3c0866
be7068fb0804f661515c678bee9224b90b32869a
cmd/api: make check pickier about api/*.txt We don't have a formatter for these files, so check here that they are in the right form to allow 'cat next/*.txt >go1.X.txt' at the end of each cycle. Fix the api files that the check finds. Change-Id: I0c5e4ab11751c7d0afce32503131d487313f41c0 Reviewed-on: https://go-revi...
[ { "path": "api/next/42537.txt", "patch": "@@ -1,4 +1,4 @@\n pkg bytes, func CutPrefix([]uint8, []uint8) ([]uint8, bool) #42537\n pkg bytes, func CutSuffix([]uint8, []uint8) ([]uint8, bool) #42537\n pkg strings, func CutPrefix(string, string) (string, bool) #42537\n-pkg strings, func CutSuffix(string, string...
2022-09-13T13:51:55
electron/electron
3ac2f674bc61807ba94a496601bf9cb447cfef74
d38c9a4644215c8095c3a115ebecd5e7649e8d22
Fix nativeWindowOpen's opener being null
[ { "path": "atom/browser/atom_browser_client.cc", "patch": "@@ -100,20 +100,29 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(\n \n int process_id = current_instance->GetProcess()->GetID();\n if (!IsRendererSandboxed(process_id)) {\n- if (!RendererUsesNativeWindowOpen(process_id)) {\n+ auto...
2017-07-29T09:21:28
vercel/next.js
68cecd6a3a6dad50fe06e75d0d60ea06d37f0d36
9fd25b4be2a3a890a9000a091d241f0444d3f28c
Update default error rate for client filter (#60542) This updates our default error rate to be much more precise and reduce false positives by increasing the default size of the client filter we generate. We can afford to increase the default size as it compresses extremely well and gives us more accurate navigatio...
[ { "path": "packages/next/src/shared/lib/bloom-filter.ts", "patch": "@@ -10,14 +10,17 @@ function murmurhash2(str: string) {\n return h >>> 0\n }\n \n+// default to 0.01% error rate as the filter compresses very well\n+const DEFAULT_ERROR_RATE = 0.0001\n+\n export class BloomFilter {\n numItems: number\n...
2024-01-12T01:51:53
nodejs/node
0dff5bc2d8d03733093848d6691a347755f914cc
0fd73696a5bc324adcddad6953ab8984b3d30937
doc: update fs.watch() availability for IBM i Add a line that IBM i does not support `fs.watch()`. Fixes: https://github.com/nodejs/node/issues/34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: https://github.com/nodejs/node/pull/34611 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewe...
[ { "path": "doc/api/fs.md", "patch": "@@ -4016,6 +4016,7 @@ to be notified of filesystem changes.\n * On SunOS systems (including Solaris and SmartOS), this uses [`event ports`][].\n * On Windows systems, this feature depends on [`ReadDirectoryChangesW`][].\n * On Aix systems, this feature depends on [`AHAFS...
2020-08-03T15:30:29
electron/electron
7d8f62293f4b71bf58cd0aea5bb595b1ab5a4662
20ae611dd97d25ddb25e29270049bb7984efc58e
Fix conflicting dependencies for building arm
[ { "path": "script/cibuild", "patch": "@@ -18,14 +18,20 @@ LINUX_DEPS = [\n 'libnotify-dev',\n 'libnss3-dev',\n 'libxtst-dev',\n+]\n+\n+LINUX_DEPS_NO_ARM = [\n 'gcc-multilib',\n 'g++-multilib',\n ]\n \n LINUX_DEPS_ARM = [\n- 'libc6-dev-armhf-cross',\n- 'linux-libc-dev-armhf-cross',\n- 'g++-arm-l...
2017-07-28T16:24:44
golang/go
be7068fb0804f661515c678bee9224b90b32869a
c53390b078b4d3b18e3aca8970d4b31d4d82cce1
text/template: correct assignment, not declaration, in range We were mishandling {{range $i = .}}, treating it as though it were {{range $i := .}}. That happened to work if $i were the most recently declared variable, but not otherwise. Fixes #56490 Change-Id: I222a009d671d86c06a980a54388e05f12101c00b Reviewed-on: h...
[ { "path": "src/text/template/exec.go", "patch": "@@ -363,11 +363,19 @@ func (s *state) walkRange(dot reflect.Value, r *parse.RangeNode) {\n \toneIteration := func(index, elem reflect.Value) {\n \t\t// Set top var (lexically the second if there are two) to the element.\n \t\tif len(r.Pipe.Decl) > 0 {\n-\t\t\...
2022-10-31T22:58:06
nodejs/node
0fd73696a5bc324adcddad6953ab8984b3d30937
33060703cc214b4056718eaaf5738f8fc83130f7
doc: fix typo in path.md PR-URL: https://github.com/nodejs/node/pull/34550 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/path.md", "patch": "@@ -549,7 +549,7 @@ On Windows systems only, returns an equivalent [namespace-prefixed path][] for\n the given `path`. If `path` is not a string, `path` will be returned without\n modifications.\n \n-This method is meaningful only on Windows system. On POSIX systems, t...
2020-07-29T12:00:59
golang/go
c53390b078b4d3b18e3aca8970d4b31d4d82cce1
07a70bcabb3c81a2f97e894a6910d95b19d6b074
net: store IPv4 returned from cgo resolver as 4-byte slice net.IP net.IP states that a 16-byte slice can still be an IPv4 address. But after netip.Addr is introduced, it requires extra care to keep it as an IPv4 address when converting it to a netip.Addr using netip.AddrFromSlice. To address this issue, let's change ...
[ { "path": "src/net/cgo_unix.go", "patch": "@@ -327,12 +327,3 @@ func cgoSockaddr(ip IP, zone string) (*_C_struct_sockaddr, _C_socklen_t) {\n \t}\n \treturn nil, 0\n }\n-\n-func copyIP(x IP) IP {\n-\tif len(x) < 16 {\n-\t\treturn x.To16()\n-\t}\n-\ty := make(IP, len(x))\n-\tcopy(y, x)\n-\treturn y\n-}", ...
2022-10-27T01:43:16
nodejs/node
46bef7b7716b377055260490bb6f713ffb593672
a11aa9b9806380b22308af2f0b327946b2b7f557
test: add Actions annotation output It's possible to annotate failures in Actions by printing "::error file={},line={},col={}::{message}". This methos is preferrable over using a problem matcher because problem matchers only allow single-line messages, whereas ::error allows multi-line messages. PR-URL: https://githu...
[ { "path": ".github/workflows/test-asan.yml", "patch": "@@ -36,4 +36,4 @@ jobs:\n - name: Build\n run: make build-ci -j2 V=1\n - name: Test\n- run: make run-ci -j2 V=1 TEST_CI_ARGS=\"-p dots\"\n+ run: make run-ci -j2 V=1 TEST_CI_ARGS=\"-p actions\"", "additions": 1, ...
2020-08-01T04:40:47
facebook/react
b7860b7da4f87bbe4b66dd5f5b1be8ff698a71b4
905bfcec60d4aec271d523c4076661bec2a30b60
Fix consistency of component api document
[ { "path": "docs/docs/ref-02-component-api.md", "patch": "@@ -39,7 +39,7 @@ replaceState(object nextState[, function callback])\n Like `setState()` but deletes any pre-existing state keys that are not in nextState.\n \n \n-### forceUpdate()\n+### forceUpdate\n \n ```javascript\n forceUpdate([function callbac...
2015-02-02T00:52:08
vercel/next.js
4466ba436b996263307171d344cca199e8087744
98b99e408bf205492e373339519bb861cb832890
chore(examples): use default prettier for examples/templates (#60530) ## Description This PR ensures that the default prettier config is used for examples and templates. This config is compatible with `prettier@3` as well (upgrading prettier is bigger change that can be a future PR). ## Changes - Updated `.p...
[ { "path": ".prettierrc.json", "patch": "@@ -1,4 +1,5 @@\n {\n+ \"trailingComma\": \"es5\",\n \"singleQuote\": true,\n \"semi\": false\n }", "additions": 1, "deletions": 0, "language": "JSON" }, { "path": "examples/.prettierrc.json", "patch": "@@ -0,0 +1,5 @@\n+{\n+ \"trailingCo...
2024-01-11T23:01:44
nodejs/node
22cbbcf9d9374d4b663bf1409f292212fa57623a
a4e1755df2f9bb8c712d7ca767a5944d9d71e33b
n-api,src: provide asynchronous cleanup hooks Sometimes addons need to perform cleanup actions, for example closing libuv handles or waiting for requests to finish, that cannot be performed synchronously. Add C++ API and N-API functions that allow providing such asynchronous cleanup hooks. Fixes: https://github.com/...
[ { "path": "doc/api/addons.md", "patch": "@@ -232,6 +232,12 @@ NODE_MODULE_INIT(/* exports, module, context */) {\n ```\n \n #### Worker support\n+<!-- YAML\n+changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/34572\n+ description: Cleanup hooks may now be asynchronous.\n+...
2020-07-31T00:10:14
electron/electron
59e85c0f33af0dbaf79851a3e73e5b09e6874ea3
2467d91f27c0ef1904e957bf04387168c2dd0bbf
Fix stupid or check in scrubber defaults
[ { "path": "lib/browser/api/touch-bar.js", "patch": "@@ -292,7 +292,7 @@ TouchBar.TouchBarScrubber = class TouchBarScrubber extends TouchBarItem {\n this._addLiveProperty('overlayStyle', overlayStyle || null)\n this._addLiveProperty('showArrowButtons', showArrowButtons || false)\n this._addLivePr...
2017-07-27T07:49:05
golang/go
581a822a9ed8fcae4afbc93daa6a74db7d9ea9a2
03f6d81fc7d52ec53deb94cff69b63d04e689c24
regexp: add ErrLarge error For #56041 Change-Id: I6c98458b5c0d3b3636a53ee04fc97221f3fd8bbc Reviewed-on: https://go-review.googlesource.com/c/go/+/444817 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Ta...
[ { "path": "api/next/56041.txt", "patch": "@@ -0,0 +1,2 @@\n+pkg regexp/syntax, const ErrLarge = \"expression too large\" #56041\n+pkg regexp/syntax, const ErrLarge ErrorCode #56041", "additions": 2, "deletions": 0, "language": "Plain Text" }, { "path": "src/regexp/all_test.go", "patc...
2022-10-22T14:07:07
vercel/next.js
98b99e408bf205492e373339519bb861cb832890
e07161a563248b5e4430517b80607b60a99f5ef0
Fix global-error for nested routes (#60539) ## What This fixes when the deep nested routes throws a client side error, it can still be caught by the `global-error.js` ## How We should always resolve global-error from root app directory instead of current route's layout. Also fixed a bad test before where th...
[ { "path": "packages/next/src/build/webpack/loaders/next-app-loader.ts", "patch": "@@ -198,7 +198,7 @@ async function createTreeCodeFromPath(\n const pages: string[] = []\n \n let rootLayout: string | undefined\n- let globalError: string = defaultGlobalErrorPath\n+ let globalError: string | undefined\n...
2024-01-11T22:28:17
facebook/react
2ea00ea772b6e08297eed6d3813020aa20a26fe4
bab59cd0905f2ea8e88ee5cffe259f80f42ec720
Fixed linewrap issue on markdown output css. Fixes #2986
[ { "path": "docs/css/react.scss", "patch": "@@ -684,6 +684,10 @@ p code {\n height: 100px\n }\n \n+.MarkdownEditor .content {\n+ white-space: pre-wrap;\n+}\n+\n .hll {\n background-color: #f7ebc6;\n border-left: 5px solid #f7d87c;", "additions": 4, "deletions": 0, "language": "Unknown" }...
2015-01-30T20:06:09
nodejs/node
734327280daeb0f358a89651b119283631bf7211
b04f2b661802adf5fd2c7731cd2d5e0f5cfe16d1
test: convert most N-API tests from C++ to C * Prefix functions with `static` to make them local * Remove anonymous namespaces * `nullptr` -> `NULL` * .cc -> .c and update binding.gyp * `static_cast<x>()` -> `(x)()` * Replace `new`/`delete` with `malloc()`/`free()` (only in test_callback_scope) * Move lambda out and...
[ { "path": "test/node-api/test_async/binding.gyp", "patch": "@@ -2,7 +2,7 @@\n \"targets\": [\n {\n \"target_name\": \"test_async\",\n- \"sources\": [ \"test_async.cc\" ]\n+ \"sources\": [ \"test_async.c\" ]\n }\n ]\n }", "additions": 1, "deletions": 1, "language": "Un...
2020-08-03T19:53:01
golang/go
03f6d81fc7d52ec53deb94cff69b63d04e689c24
3ba3b4893f3630b2bd78ec6f4f366d60e16bd636
cmd/compile: renovate GOSSAHASH Randomized feature enable/disable might be something we use to help users debug any problems with changed loop variable capture, and there's another CL that would like to use it to help in locating places where "fused" multiply add instructions change program behavior. This CL: - adds ...
[ { "path": "src/cmd/compile/internal/base/debug.go", "patch": "@@ -26,6 +26,7 @@ type DebugFlags struct {\n \tDwarfInl int `help:\"print information about DWARF inlined function creation\"`\n \tExport int `help:\"print export data\"`\n \tGCProg ...
2022-10-14T16:04:52
vercel/next.js
2138facc1284d2bb1321e0e82a3006cf8337f67a
9b7a5c0bbf9d8bbe64c52892e15aa7fdaaa6a1b0
chore: update pull_request_approved workflow (#60537) ## Description Updating https://github.com/vercel/next.js/blob/canary/.github/workflows/pull_request_approved.yml and related. ## Changes - Fix path so workflow runs - Update cron schedule to be on a weekly basis on instead of daily - Update Slack channel ...
[ { "path": ".github/actions/pr-approved-open/src/index.mjs", "patch": "@@ -20,9 +20,9 @@ async function run() {\n \n if (pendingPRs) {\n await slackClient.chat.postMessage({\n- channel: '#coord-next-turbopack',\n- text: `🤖 Pending PRs for Next.js: There are <https://github.com/vercel...
2024-01-11T21:34:42
nodejs/node
e0d181cf2b690c4f2a4cd797a61d9b69997f4c75
861a54c0e1265e5020348892b87f3ec8935dd9fe
build: increase startCI verbosity and fix job name Ref: https://github.com/nodejs/node/issues/34594#issuecomment-669245839 PR-URL: https://github.com/nodejs/node/pull/34635 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
[ { "path": ".github/workflows/auto-start-ci.yml", "patch": "@@ -12,7 +12,7 @@ on:\n - cron: \"*/5 * * * *\"\n \n jobs:\n- commitQueue:\n+ startCI:\n runs-on: ubuntu-latest\n steps:\n - uses: actions/checkout@master", "additions": 1, "deletions": 1, "language": "YAML" }, { ...
2020-08-05T15:03:22
rust-lang/rust
3de3b279f0e2490ed1a76f4a9abe75656a1c0dab
e6f9e2e6237713a59cebedc38b2cac254a544c00
Go around firefox bug
[ { "path": "src/librustdoc/html/static/css/rustdoc.css", "patch": "@@ -1001,7 +1001,13 @@ rustdoc-topbar {\n \t\t+ var(--line-number-right-margin));\n }\n .src .example-wrap .expansion [data-nosnippet] {\n-\tleft: calc((\n+\t/* FIXME: Once <https://bugzilla.mozilla.org/show_bug.cgi?id=1949948> is solved, unc...
2025-05-12T12:07:23
electron/electron
8cf00fece66a4da7715c0b44a50be0feb7c85e6d
1cfd20f861d93e9e518b749ffc405fe9f321038d
add onError with three params and move to atom-auto-updater
[ { "path": "atom/browser/api/atom_api_auto_updater.cc", "patch": "@@ -57,6 +57,24 @@ void AutoUpdater::OnError(const std::string& message) {\n message);\n }\n \n+void AutoUpdater::OnError(const std::string& message, const int code, const std::string& domain) {\n+ v8::Locker locker(isolate());\n+ v8::...
2017-07-27T00:33:32
golang/go
e23876a3835a67dfab936da273fb050dabe765d1
d73885588ac0a7520ac3e848112e44f5dbe97006
net: drop unused _C_ai_addrlen function Fixes AIX build. Change-Id: Icbb33896017bbcc488a8baff20e10eb0e14ea4b9 Reviewed-on: https://go-review.googlesource.com/c/go/+/447095 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Rev...
[ { "path": "src/net/cgo_unix_cgo.go", "patch": "@@ -36,20 +36,19 @@ const (\n )\n \n type (\n-\t_C_char = C.char\n-\t_C_uchar = C.uchar\n-\t_C_int = C.int\n-\t_C_uint = C.uint\n-\t_C_socklen_t = C.socklen_t\n-\t_C_struct_addrinfo = C.struct_...
2022-11-01T19:56:12
facebook/react
b2f77e6de31c71999a8d294a9bb742643c936b01
5bd078508a1beb500b801eb7de9488927a874376
Add detectable prefix to ReactElement proptype warning.
[ { "path": "src/classic/element/ReactElementValidator.js", "patch": "@@ -269,7 +269,7 @@ function checkPropTypes(componentName, propTypes, props, location) {\n loggedTypeFailures[error.message] = true;\n \n var addendum = getDeclarationErrorAddendum(this);\n- warning(false, error.messa...
2015-01-27T18:14:09
vercel/next.js
9b7a5c0bbf9d8bbe64c52892e15aa7fdaaa6a1b0
a1d0259ea06592c5ca6df882e9b1d0d0121c5083
Handle non server action post requests safely (#60526) When sending post requests but it's not server action, skip logging warning or calling non-existed server action. Instead we only log the warning like missnig headers for server actions when it's a server action and call the action handler when it's decoded as ...
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -41,6 +41,7 @@ import {\n getServerActionRequestMetadata,\n } from '../lib/server-action-request-meta'\n import { isCsrfOriginAllowed } from './csrf-protection'\n+import { warn } from '../../build/output/log'\n \n function for...
2024-01-11T20:03:43
nodejs/node
861a54c0e1265e5020348892b87f3ec8935dd9fe
96fd6810b697aa0ec9d090c010f25f139f3995c7
repl: improve static import error message in repl Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: https://github.com/nodejs/node/issues/33576 PR-URL: https://github.c...
[ { "path": "lib/repl.js", "patch": "@@ -58,6 +58,7 @@ const {\n PromiseRace,\n RegExp,\n Set,\n+ StringPrototypeIncludes,\n Symbol,\n WeakSet,\n } = primordials;\n@@ -576,6 +577,14 @@ function REPLServer(prompt,\n e.stack = e.stack\n .replace(/^REPL\\d+:\\d+\\r?\\n/, '')\...
2020-05-27T16:05:55
electron/electron
85d76acebbb4252c3d239cd16d0a717298ee897f
2467d91f27c0ef1904e957bf04387168c2dd0bbf
Fix No module named google_compute_engine error
[ { "path": ".travis.yml", "patch": "@@ -3,6 +3,9 @@ git:\n notifications:\n email: false\n \n+before_install:\n+ - export BOTO_CONFIG=/dev/null\n+ \n language: node_js\n node_js:\n - \"4\"", "additions": 3, "deletions": 0, "language": "YAML" } ]
2017-07-26T19:53:27
golang/go
d73885588ac0a7520ac3e848112e44f5dbe97006
1ae93e4c201af78b000dccef0c2489bf7fb879ca
cmd/compile/internal/pgo: remove ListOfHotCallSites The global ListOfHotCallSites set is used to communicate between CanInline and InlineCalls the set of call sites that InlineCalls may increase the budget for. CanInline clears this map on each call, thus assuming that InlineCalls(x) is called immediately after CanIn...
[ { "path": "src/cmd/compile/internal/inline/inl.go", "patch": "@@ -56,13 +56,16 @@ const (\n )\n \n var (\n-\t// List of all hot ndes.\n+\t// List of all hot nodes.\n+\t// TODO(prattmic): Make this non-global.\n \tcandHotNodeMap = make(map[*pgo.IRNode]struct{})\n \n-\t// List of all hot call sites.\n+\t// Li...
2022-10-31T16:20:09
facebook/react
295ef0063b933e13b2ddd541c108b386b35b648b
16a56afadaf8b66ad598374aa3824ce954c83534
We don't currently have a way to trace the origin of a mixin This makes it more difficult to find bugs in mixins both dynamically and using a static type system. We also don't have a way to find these to be upgraded to a new mixin syntax if we needed to. This hook is currently an optional noop but could be made requ...
[ { "path": "src/browser/ui/React.js", "patch": "@@ -65,6 +65,10 @@ var React = {\n createClass: ReactClass.createClass,\n createElement: createElement,\n createFactory: createFactory,\n+ createMixin: function(mixin) {\n+ // Currently a noop. Will be used to validate and trace mixins.\n+ return m...
2015-01-27T17:36:14
vercel/next.js
601eaf0e875f2e58828346075b6f158d0a2dc718
553aeaec0f7da99cb9bcb80bc1658410a27b3bb3
chore: Fix multiple typos (#60531) ## For Contributors Fix multiple typos
[ { "path": "examples/panda-css/README.md", "patch": "@@ -6,7 +6,7 @@ This example contains a simple implementation of [Panda CSS](https://panda-css.c\n \n - [Atomic Recipe (CVA)](https://panda-css.com/docs/concepts/recipes#atomic-recipe-or-cva) Create multi-variant atomic styles with a type-safe runtime API....
2024-01-11T18:44:55
nodejs/node
84b35b286769758610173291c6e9fd9eebdaaf1f
d5c7aec3cb7c90d026cfa9bfb2c75ed2ad3ee15f
doc: clarify process.title inconsistencies Many users assume the act of assigning a value to `process.title` will update the name of their application in apps like macOS Activity Monitor or Windows Services Manager. This has worked in the past, but fails in some versions of Node.js. Ultimately developers are left conf...
[ { "path": "doc/api/process.md", "patch": "@@ -2423,6 +2423,12 @@ allowed for longer process title strings by also overwriting the `environ`\n memory but that was potentially insecure and confusing in some (rather obscure)\n cases.\n \n+Assigning a value to `process.title` _may_ not reflect an accurate\n+(or...
2020-07-29T22:23:51
rust-lang/rust
eb009082321f15f2a6faed1198d4e31d2d163ff9
450e25b2412f76391260220539c41e4a0aa8530e
fix: `derivable_impls` FN when enum is qualified with `Self`
[ { "path": "clippy_lints/src/derivable_impls.rs", "patch": "@@ -10,7 +10,7 @@ use rustc_hir::{\n };\n use rustc_lint::{LateContext, LateLintPass};\n use rustc_middle::ty::adjustment::{Adjust, PointerCoercion};\n-use rustc_middle::ty::{self, AdtDef, GenericArgsRef, Ty, TypeckResults};\n+use rustc_middle::ty::...
2025-08-22T18:30:44
electron/electron
1cfd20f861d93e9e518b749ffc405fe9f321038d
2467d91f27c0ef1904e957bf04387168c2dd0bbf
prefix autoupdater error with statuscode and domain
[ { "path": "atom/browser/auto_updater_mac.mm", "patch": "@@ -104,8 +104,8 @@\n delegate->OnUpdateNotAvailable();\n }\n } error:^(NSError *error) {\n- NSMutableString* failureString =\n- [NSMutableString stringWithString:error.localizedDescription];\n+ NSMutableS...
2017-07-26T19:44:45
golang/go
1587c3658349643ae76acf3d3fc3f0ea5cafe61d
082afccebfc068207328fcaeb4b01e540784ff24
runtime: check for ErrWaitDelay in runBuiltTestProg ErrWaitDelay is not expected to occur in this test, but if it does it indicates a failure mode very different from the “failed to start” catchall that we log for other non-ExitError errors. Updates #50436. Change-Id: I3f4d87d502f772bf471fc17303d5a6b483446f8f Review...
[ { "path": "src/runtime/crash_test.go", "patch": "@@ -77,6 +77,8 @@ func runBuiltTestProg(t *testing.T, exe, name string, env ...string) string {\n \tif err != nil {\n \t\tif _, ok := err.(*exec.ExitError); ok {\n \t\t\tt.Logf(\"%v: %v\", cmd, err)\n+\t\t} else if errors.Is(err, exec.ErrWaitDelay) {\n+\t\t\t...
2022-11-01T13:24:54
facebook/react
103bf101ae2bc2a6d67490efde43480a42bbb274
9b23807cfd80dd870affd3fa72dc90b3ff1008c5
Fix broken jest test jest accidentally picked up this .d.ts file as a test. I'll just move it out to fix it.
[ { "path": "src/modern/class/__tests__/ReactTypeScriptClass-test.ts", "patch": "@@ -8,7 +8,7 @@\n */\n \n ///<reference path='../../../../jest/jest.d.ts'/>\n-///<reference path='./react.d.ts'/>\n+///<reference path='../React.d.ts'/>\n \n import React = require('React');\n ", "additions": 1, "deletio...
2015-01-27T07:37:30
vercel/next.js
5836a497da8f64341f5b389704ab213a55bde49a
8d129534da0f28a41d25e1ddb0d5ac3ea6df8082
Expand hydration error test to check recovery (#60423) ## What? Adds an additional condition to the hydration error test to check if it recovers correctly when making a change that removes the hydration error. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled...
[ { "path": "test/development/acceptance-app/hydration-error.test.ts", "patch": "@@ -17,7 +17,7 @@ describe('Error overlay for hydration errors', () => {\n })\n \n it('should show correct hydration error when client and server render different text', async () => {\n- const { cleanup, session } = await ...
2024-01-11T17:34:44
nodejs/node
0bb70b0a02c2e6d5e6de61f9f9619f379b09a92e
74df7496ff6d899e4b8ceed9505a641e79ad6366
test: replace flaky pummel regression tests These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We ...
[ { "path": "test/parallel/test-fs-write-reuse-callback.js", "patch": "@@ -0,0 +1,39 @@\n+// Flags: --expose-gc\n+'use strict';\n+const common = require('../common');\n+const tmpdir = require('../common/tmpdir');\n+const assert = require('assert');\n+const path = require('path');\n+\n+// Regression test for h...
2020-07-27T16:19:33
facebook/react
05e2bc6b5cbe51e1fc7b90d85b55bcb12473295a
4054bb13cd955b8fa798ffd70056941a0e0bfeba
Fixing lint failures
[ { "path": "src/browser/ui/dom/CSSPropertyOperations.js", "patch": "@@ -73,12 +73,13 @@ if (__DEV__) {\n if (warnedStyleValues.hasOwnProperty(value) && warnedStyleValues[value]) {\n return;\n }\n- \n+\n warnedStyleValues[value] = true;\n warning(\n false,\n 'Style propert...
2015-01-27T00:41:54
golang/go
082afccebfc068207328fcaeb4b01e540784ff24
50c59194758999487f577030ca11d91c65530559
internal/testenv: adjust timeout calculations in CommandContext I noticed some test failures in the build dashboard after CL 445597 that made me realize the grace period should be based on the test timeout, not the Context timeout: if the test itself sets a short timeout for a command, we still want to give the test p...
[ { "path": "src/internal/testenv/exec.go", "patch": "@@ -79,63 +79,65 @@ func CleanCmdEnv(cmd *exec.Cmd) *exec.Cmd {\n // - skips t if the platform does not support os/exec,\n // - sends SIGQUIT (if supported by the platform) instead of SIGKILL\n // in its Cancel function\n-// - adds a timeout (wit...
2022-11-01T12:26:58
vercel/next.js
8d129534da0f28a41d25e1ddb0d5ac3ea6df8082
b21a2b94451eb144e1c1770c5a872e485f303176
add retry logic to loadClientReferenceManifest (#56518) ### What? This fixes a race condition where loadClientReferenceManifest reads an empty file. All other manifest already have retries, this adds it for the client reference manifest too for consistency. Closes WEB-1727 --------- Co-authored-by: Tim...
[ { "path": "packages/next/src/export/worker.ts", "patch": "@@ -263,7 +263,7 @@ async function exportPageImpl(\n optimizeFonts,\n optimizeCss,\n disableOptimizedLoading,\n- fontManifest: optimizeFonts ? requireFontManifest(distDir) : null,\n+ fontManifest: optimizeFonts ? requireFo...
2024-01-11T15:25:05
rust-lang/rust
c2c3e0990b4430cd2ce9c27b1eb8ff5dd57091cb
df0499a5edbd668b7ba4c8666c11bb8a063fb3f7
fix: don't check for `!x = y`/`x = !y` misc: rm "as shown" from help message - clippy guidelines recommend against this misc: pull conditions into let-chain misc: use `Span::to` misc: inline `{l,r}_ty` misc: move the type checks out of `check_comparison` misc: make test cases much less verbose
[ { "path": "clippy_lints/src/needless_bool.rs", "patch": "@@ -7,7 +7,7 @@ use clippy_utils::{\n };\n use rustc_ast::ast::LitKind;\n use rustc_errors::Applicability;\n-use rustc_hir::{BinOpKind, Expr, ExprKind, UnOp};\n+use rustc_hir::{BinOpKind, Expr, ExprKind};\n use rustc_lint::{LateContext, LateLintPass};...
2025-08-15T10:42:47
nodejs/node
ca26eae9665b846831be2289714d8c21897b0d44
54746bb763ebea0dc7e99d88ff4b379bcd680964
repl: give repl entries unique names This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: https://github.com/nodejs/node/issues/1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: https://github.com/nodejs/node/pull/34372 Reviewed-By: Rube...
[ { "path": "lib/repl.js", "patch": "@@ -128,6 +128,12 @@ const {\n } = internalBinding('contextify');\n \n const history = require('internal/repl/history');\n+let nextREPLResourceNumber = 1;\n+// This prevents v8 code cache from getting confused and using a different\n+// cache from a resource of the same na...
2020-07-14T21:31:29
electron/electron
1811b0cbda8aa079f2044fb1e97ac523b9d12b62
e80f9d7e492dfb803c8d7a23303c6f391941ce50
fix heading levels for class docs
[ { "path": "docs/api/browser-view.md", "patch": "@@ -1,4 +1,4 @@\n-# Class: BrowserView\n+## Class: BrowserView\n \n > Create and control views.\n ", "additions": 1, "deletions": 1, "language": "Markdown" }, { "path": "docs/api/menu.md", "patch": "@@ -1,4 +1,5 @@\n-# Class: Menu\n+## ...
2017-07-26T20:02:40
golang/go
50c59194758999487f577030ca11d91c65530559
49bbece44c93b4de62ff360268c420e45f27ad63
cmd/dist: fix a variable scope bug: We reused p so we were deleting the same directory twice instead of two different directories. Fix that. For #47257 Change-Id: I315ad87d0a9182e00ae4c11b82986227e2b02e17 Reviewed-on: https://go-review.googlesource.com/c/go/+/447115 TryBot-Result: Gopher Robot <gobot@golang.org> Rev...
[ { "path": "src/cmd/dist/build.go", "patch": "@@ -481,22 +481,22 @@ func setup() {\n \t// We used to use it for C objects.\n \t// Now we use it for the build cache, to separate dist's cache\n \t// from any other cache the user might have.\n-\tp = pathf(\"%s/pkg/obj/go-build\", goroot)\n+\tobjGobuild := pathf...
2022-11-01T20:14:06
vercel/next.js
b21a2b94451eb144e1c1770c5a872e485f303176
b8b104506d776a983ae923c63c7ccba84d32cae1
chore: Fix typo s/desireable/desirable/ (#60518) Fix typo s/desireable/desirable/ in 2 README.md files Co-authored-by: Steven <steven@ceriously.com>
[ { "path": "examples/reproduction-template-pages/README.md", "patch": "@@ -5,7 +5,7 @@ This is a [Next.js](https://nextjs.org/) template to use when reporting a [bug i\n These are the steps you should follow when creating a bug report:\n \n - Bug reports must be verified against the `next@canary` release. Th...
2024-01-11T14:43:13
rust-lang/rust
7494d927cb7a50bc3403f0ddaaf21e3fc710f3b7
9fe0b28db2439efa1a8147870c3e50f26f426ab5
Fix stderr normalization.
[ { "path": "tests/ui/consts/transmute-size-mismatch-before-typeck.rs", "patch": "@@ -1,9 +1,9 @@\n-//@ normalize-stderr-64bit: \"8 byte\" -> \"word size\"\n-//@ normalize-stderr-32bit: \"4 byte\" -> \"word size\"\n+//@ normalize-stderr-64bit: \"8-byte\" -> \"word size\"\n+//@ normalize-stderr-32bit: \"4-byte...
2025-08-15T22:19:16
nodejs/node
8d8090b9bb3ee657e20f0cb00fdc1c120a58537c
a6a368498425c846e4074c24a97bb93d760f1db2
test: fix flaky http-parser-timeout-reset Refs: https://github.com/nodejs/node/pull/34578#issuecomment-667941698 PR-URL: https://github.com/nodejs/node/pull/34609 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
[ { "path": "test/parallel/test-http-parser-timeout-reset.js", "patch": "@@ -34,7 +34,7 @@ const server = net.createServer((socket) => {\n \n parser[HTTPParser.kOnHeaders] = common.mustNotCall();\n \n- parser[HTTPParser.kOnExecute] = common.mustCall(3);\n+ parser[HTTPParser.kOnExecute] = common.mustCallAt...
2020-08-03T10:52:08
electron/electron
cb93f035aa55f89503aee63584fd18cd1863e4dc
0c3d15d8906fdf3beae1c6913db81702dbfc0107
fix previous merge conflict resolution for .gitignore
[ { "path": ".gitignore", "patch": "@@ -37,28 +37,6 @@\n /vendor/debian_wheezy_i386-sysroot/\n /vendor/download/\n /vendor/llvm-build/\n-/vendor/.gclient\n-node_modules/\n-*.xcodeproj\n-*.swp\n-*.pyc\n-*.VC.db\n-*.VC.VC.opendb\n-.vs/\n-.vscode/\n-*.vcxproj\n-*.vcxproj.user\n-*.vcxproj.filters\n-*.sln\n-*.log\...
2017-07-26T19:22:06
vercel/next.js
e6e6609674e2872aaf47d0f7035b12f6ceb4b8d5
7c1d50a1bc0ad10d40b4fa716fb0903de277d4ab
Remove unused target: es5 from tsconfig.json in create-next-app (#60521) fixes #58640 When there is no tsconfig.json, `npm run dev` generates `tsconfig.json`, which has no `target` option. But create-next-app generates `tsconfig.json` with `"target": "es5"` Related to: #44567 Related to: #14390
[ { "path": "packages/create-next-app/templates/app-tw/ts/tsconfig.json", "patch": "@@ -1,6 +1,5 @@\n {\n \"compilerOptions\": {\n- \"target\": \"es5\",\n \"lib\": [\"dom\", \"dom.iterable\", \"esnext\"],\n \"allowJs\": true,\n \"skipLibCheck\": true,", "additions": 0, "deletions": 1,...
2024-01-11T14:35:17
golang/go
6a44a3aa9f250cbe0b329b60eeb555c7dde83f10
767df51b4dc4d952fd3f3ff14dffdf5fd8cffb4e
test/bench/go1: eliminate start-up time The go1 benchmark suite does a lot of work at package init time, which makes it take quite a while to run even if you're not running any of the benchmarks, or if you're only running a subset of them. This leads to an awkward workaround in dist test to compile but not run the pac...
[ { "path": "src/cmd/dist/test.go", "patch": "@@ -828,9 +828,8 @@ func (t *tester) registerTests() {\n \n \tif goos != \"android\" && !t.iOS() {\n \t\t// There are no tests in this directory, only benchmarks.\n-\t\t// Check that the test binary builds but don't bother running it.\n-\t\t// (It has init-time wo...
2022-09-16T19:56:16
nodejs/node
ee0b44fd93fa695e902a725cbe3da2f18c032c55
6e65f26b73c67869a3ac5ee2caf0dfd011177d66
tools: add meta.fixable to fixable lint rules This commit adds the meta.fixable property to all fixable ESLint rules. This is required as of ESLint 7.6.0. PR-URL: https://github.com/nodejs/node/pull/34589 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luig...
[ { "path": "tools/eslint-rules/async-iife-no-unused-result.js", "patch": "@@ -12,6 +12,9 @@ const message =\n '(e.g. with `.then(common.mustCall())`)';\n \n module.exports = {\n+ meta: {\n+ fixable: 'code'\n+ },\n create: function(context) {\n let hasCommonModule = false;\n return {", "a...
2020-08-01T18:22:51
rust-lang/rust
06eb782c4e727c33d8548a791998a0a2cbedceae
6ba0ce40941eee1ca02e9ba49c791ada5158747a
modify `LazyLock` poison panic message Fixes an issue where if the underlying `Once` panics because it is poisoned, the panic displays the wrong message. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
[ { "path": "library/std/src/sync/lazy_lock.rs", "patch": "@@ -244,7 +244,11 @@ impl<T, F: FnOnce() -> T> LazyLock<T, F> {\n #[inline]\n #[stable(feature = \"lazy_cell\", since = \"1.80.0\")]\n pub fn force(this: &LazyLock<T, F>) -> &T {\n- this.once.call_once(|| {\n+ this.once.call_...
2025-08-22T18:58:42
vercel/next.js
f06685f420f9616f8db85f7b6e39b3144c380148
d8691f5c069bf40aff8c6636480696d9d91a0884
Skip webpack loader test in Turbopack (#60509) ## What? This test can be skipped as it checks a webpack loader. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the righ...
[ { "path": "test/development/acceptance-app/ReactRefreshRegression.test.ts", "patch": "@@ -335,56 +335,60 @@ describe('ReactRefreshRegression app', () => {\n })\n \n // https://github.com/vercel/next.js/issues/13574\n- test('custom loader mdx should have Fast Refresh enabled', async () => {\n- const ...
2024-01-11T12:10:21
golang/go
767df51b4dc4d952fd3f3ff14dffdf5fd8cffb4e
e72da1c15dc273b39dcb5dd87c56d5713dbc1b37
runtime: fix missing error print in TestCgoSigfwd The result of the call to fmt.Errorf was unused. It was clearly intending to print the message, not simply construct an error. Change-Id: I14856214c521a51fe4b45690e6c35fbb17e66577 Reviewed-on: https://go-review.googlesource.com/c/go/+/443375 Run-TryBot: Austin Clement...
[ { "path": "src/runtime/testdata/testprogcgo/sigfwd.go", "patch": "@@ -61,7 +61,7 @@ var nilPtr *byte\n func f() (ret bool) {\n \tdefer func() {\n \t\tif recover() == nil {\n-\t\t\tfmt.Errorf(\"ERROR: couldn't raise SIGSEGV in Go.\")\n+\t\t\tfmt.Fprintf(os.Stderr, \"ERROR: couldn't raise SIGSEGV in Go\\n\")\...
2022-10-17T15:29:34
nodejs/node
b7a23295e84479843c4975bd6ed876392a9d7602
2ba93e1db4992e73af42c47b445a54c2a767bd6e
async_hooks: fix id assignment in fast-path promise hook Native side of fast-path promise hook was not calling JS fastPromiseHook function when there were no async ids previously assigned to the promise. Because of that already created promises could not get id assigned in situations when an async hook without a befor...
[ { "path": "src/async_wrap.cc", "patch": "@@ -39,9 +39,12 @@ using v8::Global;\n using v8::HandleScope;\n using v8::Integer;\n using v8::Isolate;\n+using v8::Just;\n using v8::Local;\n+using v8::Maybe;\n using v8::MaybeLocal;\n using v8::Name;\n+using v8::Nothing;\n using v8::Number;\n using v8::Object;\n us...
2020-07-28T19:36:40
facebook/react
c33d443c0b5a069d3c39981c96f7a2c9b4f5bc10
8a5c5ba69d33c5dd0372cca03ccb9109361cb1e8
Fix a couple small lint issues These aren't caught by eslint yet :(
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -675,7 +675,6 @@ var ReactCompositeComponentMixin = assign({},\n _warnIfContextsDiffer: function(ownerBasedContext, parentBasedContext) {\n ownerBasedContext = this._maskContext(ownerBasedContext);\n parentBasedContext = this._maskCont...
2015-01-22T22:39:08
vercel/next.js
207efc9a0d410b41a578eb2edcd64ce91edbab3e
a65ea447d899fbfbbda223c3645a68937b591ff2
Ensure aliased variable is used in test (#60428) ## What? This test fails in Turbopack currently as Turbopack handles unused imports smarter than webpack. This change makes sure the variable is used so the import is not shaken out. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make s...
[ { "path": "test/development/acceptance-app/ReactRefreshModule.test.ts", "patch": "@@ -31,6 +31,7 @@ describe('ReactRefreshModule app', () => {\n outdent`\n 'use client'\n import { default as ${variable} } from 'next/link'\n+ console.log({ ${variable} })\n expor...
2024-01-11T10:12:22
golang/go
e72da1c15dc273b39dcb5dd87c56d5713dbc1b37
61ae0a37a8c96e2b1745594e477244100f1a7046
runtime: skip TestArenaCollision on failed reservation If TestArenaCollision cannot reserve the address range it expects to reserve, it currently fails somewhat mysteriously. Detect this case and skip the test. This could lead to test rot if we wind up always skipping this test, but it's not clear that there's a bette...
[ { "path": "src/runtime/export_test.go", "patch": "@@ -503,7 +503,10 @@ func KeepNArenaHints(n int) {\n // MapNextArenaHint reserves a page at the next arena growth hint,\n // preventing the arena from growing there, and returns the range of\n // addresses that are no longer viable.\n-func MapNextArenaHint()...
2022-11-01T14:00:25
nodejs/node
2ba93e1db4992e73af42c47b445a54c2a767bd6e
a9c5b873ca47555aeaaaffa9c7374358f33cc28e
async_hooks: fix resource stack for deep stacks 460c81dc0e0 introduced a bug where the execution resource was not stored properly if we needed to call into C++ to extend the stack size. Fix that bug by always storing the resource. Refs: https://github.com/nodejs/node/pull/34319 Fixes: https://github.com/nodejs/node/i...
[ { "path": "lib/internal/async_hooks.js", "patch": "@@ -499,11 +499,11 @@ function hasAsyncIdStack() {\n // This is the equivalent of the native push_async_ids() call.\n function pushAsyncContext(asyncId, triggerAsyncId, resource) {\n const offset = async_hook_fields[kStackLength];\n+ execution_async_reso...
2020-07-31T00:32:33
rust-lang/rust
f64fbe118409e29e2e3000c79d2ad2bbafc09788
877967959ae8da9814df4f2614971f4d784bf53f
fix: also get `ty_sugg` in the `matches!` case
[ { "path": "clippy_lints/src/manual_is_ascii_check.rs", "patch": "@@ -97,11 +97,12 @@ impl<'tcx> LateLintPass<'tcx> for ManualIsAsciiCheck {\n return;\n }\n \n- if let Some(macro_call) = matching_root_macro_call(cx, expr.span, sym::matches_macro) {\n- if let ExprKind::Ma...
2025-08-15T07:33:00
vercel/next.js
a65ea447d899fbfbbda223c3645a68937b591ff2
9bdaf07233574b6a090c523d1be255549ba8bc92
fix: redirect logic missing basePath in App Render (#60184) ### What? Fixes #58570 ### How? Include the **basePath** to the **fetchUrl** to ensure the relative URL matches the app when deployed under a **basePath**. ### Tested? I have added an **e2e** test with a basic custom server & server action r...
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -147,6 +147,7 @@ async function createRedirectRenderResult(\n req: IncomingMessage,\n res: ServerResponse,\n redirectUrl: string,\n+ basePath: string,\n staticGenerationStore: StaticGenerationStore\n ) {\n res.setHead...
2024-01-11T10:08:29
golang/go
61ae0a37a8c96e2b1745594e477244100f1a7046
ad5d2f64fbb90dd13c4587aa5bf2ed3c86a6dec2
syscall, os/exec: reject environment variables containing NULs Check for and reject environment variables containing NULs. The conventions for passing environment variables to subprocesses cause most or all systems to interpret a NUL as a separator. The syscall package rejects environment variables containing a NUL o...
[ { "path": "src/os/exec/env_test.go", "patch": "@@ -13,9 +13,10 @@ func TestDedupEnv(t *testing.T) {\n \tt.Parallel()\n \n \ttests := []struct {\n-\t\tnoCase bool\n-\t\tin []string\n-\t\twant []string\n+\t\tnoCase bool\n+\t\tin []string\n+\t\twant []string\n+\t\twantErr bool\n \t}{\n \t\t{\n \...
2022-10-18T00:38:29
nodejs/node
a9c5b873ca47555aeaaaffa9c7374358f33cc28e
cb142d13413c1c2c6eadb00a0257059a5fec9533
test: move buffer-as-path symlink test to its own test file The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: https://github.com/no...
[ { "path": "test/parallel/test-fs-symlink-buffer-path.js", "patch": "@@ -0,0 +1,63 @@\n+// Copyright Joyent, Inc. and other Node contributors.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a\n+// copy of this software and associated documentation files (the\n+// \"Software\"...
2020-07-30T18:43:40
vercel/next.js
9bdaf07233574b6a090c523d1be255549ba8bc92
f45a15b621225a4ad3d401e4d3d114dd17647a90
Add --ci to jest tests in CI (#60432) ## What? Ensures snapshot tests fail instead of being written in CI. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right chec...
[ { "path": "run-tests.js", "patch": "@@ -422,6 +422,7 @@ ${ENDGROUP}`)\n ...(shouldRecordTestWithReplay\n ? [`--config=jest.replay.config.js`]\n : []),\n+ ...(process.env.CI ? ['--ci'] : []),\n '--runInBand',\n '--forceExit',\n '--verbose',", "ad...
2024-01-11T09:23:20
golang/go
ad5d2f64fbb90dd13c4587aa5bf2ed3c86a6dec2
02cffcde177bf3fbb36e75d749d0cb338b4f7566
testing: print names of running tests on test timeout Track the running tests and when they started, so that we can report the running tests on a test timeout. % go test -timeout=5s panic: test timed out after 5s running tests: TestTCPSpuriousConnSetupCompletion (4s) ... stack traces as usual ... % go test -...
[ { "path": "src/testing/testing.go", "patch": "@@ -381,6 +381,7 @@ import (\n \t\"runtime\"\n \t\"runtime/debug\"\n \t\"runtime/trace\"\n+\t\"sort\"\n \t\"strconv\"\n \t\"strings\"\n \t\"sync\"\n@@ -477,6 +478,8 @@ var (\n \ttestlogFile *os.File\n \n \tnumFailed atomic.Uint32 // number of test failures\n+\n+...
2022-10-28T13:19:32
nodejs/node
cb142d13413c1c2c6eadb00a0257059a5fec9533
64481c2b133f9314c560c635f06da1abfaf3123a
async_hooks: execute destroy hooks earlier Use a microtask to call destroy hooks in case there are a lot queued as immediate may be scheduled late in case of long running promise chains. Queuing a mircrotasks in GC context is not allowed therefore an interrupt is triggered to do this in JS context as fast as possible...
[ { "path": "src/async_wrap.cc", "patch": "@@ -856,6 +856,18 @@ void AsyncWrap::EmitDestroy(Environment* env, double async_id) {\n env->SetImmediate(&DestroyAsyncIdsCallback, CallbackFlags::kUnrefed);\n }\n \n+ // If the list gets very large empty it faster using a Microtask.\n+ // Microtasks can't be...
2020-07-13T18:31:00
vercel/next.js
d6c754f332e08d4f2d432a02cbc206d0b7f8e5d6
b16187213e5be6ad92d0a4e30643969d7040402b
parallel routes: fix client reference manifest grouping for catch-all segments (#60482) ### What? When using catch-all routes in conjunction with parallel routes, and when importing a client component (`"use client"`), the build would fail with the following error: > Could not find the module "PathToClientCompon...
[ { "path": "packages/next/src/build/webpack/plugins/flight-manifest-plugin.ts", "patch": "@@ -125,12 +125,19 @@ function getAppPathRequiredChunks(\n // - app/foo/page -> app/foo\n // - app/(group)/@named/foo/page -> app/foo\n // - app/(.)foo/(..)bar/loading -> app/bar\n+// - app/[...catchAll]/page -> app\n+/...
2024-01-10T22:14:19
facebook/react
b94adc9724bf3df8306b3f47de706c737471495e
54b565de938b569847cfcf33192313596cdfa818
Added fb.me url to error message.
[ { "path": "src/browser/ui/ReactDOMComponent.js", "patch": "@@ -63,7 +63,7 @@ function assertValidProps(props) {\n invariant(\n props.dangerouslySetInnerHTML.__html != null,\n '`props.dangerouslySetInnerHTML` must be in the form `{__html: ...}`. ' +\n- 'For more information, lookup docum...
2015-01-21T20:39:10
golang/go
02cffcde177bf3fbb36e75d749d0cb338b4f7566
99dc2a1859f15fafc5950ad7ef6026dfbde826c6
cmd/cover: fix buglet causing differences in -m output Use a slightly different line number pragma when emitting instrumented code, so as to ensure that we don't get any changes in the "-gcflags=-m" output for coverage vs non-coverage. Fixes #56475. Change-Id: I3079171fdf83c0434ed6ea0ce3eb2797c2280c55 Reviewed-on: h...
[ { "path": "src/cmd/cover/cover.go", "patch": "@@ -629,7 +629,7 @@ func (p *Package) annotateFile(name string, fd io.Writer, last bool) {\n \t}\n \tnewContent := file.edit.Bytes()\n \n-\tfmt.Fprintf(fd, \"//line %s:1\\n\", name)\n+\tfmt.Fprintf(fd, \"//line %s:1:1\\n\", name)\n \tfd.Write(newContent)\n \n \t...
2022-10-28T17:46:32
nodejs/node
0be93eeb335d48636a4e338ef7a501cdb3beabd4
da4d8de9d09f98e6d81b9d5778fa44c26c25ec75
doc: add DerekNonGeneric to collaborators Fixes: https://github.com/nodejs/node/issues/34369 PR-URL: https://github.com/nodejs/node/pull/34602 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
[ { "path": "README.md", "patch": "@@ -283,6 +283,8 @@ For information about the governance of the Node.js project, see\n **Danielle Adams** &lt;adamzdanielle@gmail.com&gt; (she/her)\n * [davisjam](https://github.com/davisjam) -\n **Jamie Davis** &lt;davisjam@vt.edu&gt; (he/him)\n+* [DerekNonGeneric](https://...
2020-08-02T16:19:20
rust-lang/rust
049c32797b5f797d5823cdc0e5aaeb0fd68175da
f5703d5dd3eec176f86a6e9bf7e668b48b84eabb
On E0277, point at type that doesn't implement bound When encountering an unmet trait bound, point at local type that doesn't implement the trait: ``` error[E0277]: the trait bound `Bar<T>: Foo` is not satisfied --> $DIR/issue-64855.rs:9:19 | LL | pub struct Bar<T>(<Self as Foo>::Type) where Self: ; | ...
[ { "path": "compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs", "patch": "@@ -275,8 +275,9 @@ impl<'a, 'tcx> TypeErrCtxt<'a, 'tcx> {\n *err.long_ty_path() = long_ty_file;\n \n let mut suggested = false;\n+ le...
2025-08-19T17:49:20
vercel/next.js
ac325dfd0bbef1f16699196e76626cc39f91c55d
55917c064ee911acf8f6e1315a2dc89cd2844e11
Fix intercepted segments with basepath (#60485) ### Fixing a bug ### What? When basePath is added, intercepted routes stop working correctly. ### Why? For them, basePath was not added at all. ### How? Added basePath to the rewrites for intercepted routes. Fixes #52624, #58268
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -1020,7 +1020,9 @@ export default async function build(\n \n const appPaths = Array.from(appPageKeys)\n // Interception routes are modelled as beforeFiles rewrites\n- rewrites.beforeFiles.push(...generateInterceptionRoutesRewrites(a...
2024-01-10T21:18:00