repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
e749bb0bcf8783f71209c6c80ee1c6c611c480ed
a52e1695f0868473f14e6ee30825dc5694999d54
Fix some clippy issues, ignore others (vercel/turbo#6129) Along with #6128, this should address most the reported clippy issues. Closes WEB-1734
[ { "path": "crates/turbo-tasks-memory/src/aggregation_tree/bottom_tree.rs", "patch": "@@ -642,6 +642,7 @@ fn propagate_change_to_upper<C: AggregationContext>(\n }\n }\n \n+#[allow(clippy::disallowed_methods)] // Allow VecDeque::new() in this test\n #[cfg(test)]\n fn visit_graph<C: AggregationContext>(\n ...
2023-10-10T17:01:29
rust-lang/rust
754654d5a98a81a2f4f033a1cf4b2f9e7bb55f06
889701db1ff614160314734fe4138c2f820a95bb
rename rust_panic_without_hook
[ { "path": "library/std/src/panic.rs", "patch": "@@ -388,7 +388,7 @@ pub fn catch_unwind<F: FnOnce() -> R + UnwindSafe, R>(f: F) -> Result<R> {\n /// ```\n #[stable(feature = \"resume_unwind\", since = \"1.9.0\")]\n pub fn resume_unwind(payload: Box<dyn Any + Send>) -> ! {\n- panicking::rust_panic_without...
2025-08-03T12:59:37
nodejs/node
ef95de3492152290321f1f8a811401146c464138
077f9dc6036b97e9e12e3681e3c3bdf29d44de2b
doc: link setRawMode() from signal docs Fixes: https://github.com/nodejs/node/issues/32065 PR-URL: https://github.com/nodejs/node/pull/32088 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gma...
[ { "path": "doc/api/process.md", "patch": "@@ -502,7 +502,7 @@ process.on('SIGTERM', handle);\n * `'SIGTERM'` is not supported on Windows, it can be listened on.\n * `'SIGINT'` from the terminal is supported on all platforms, and can usually be\n generated with `<Ctrl>+C` (though this may be configurable)....
2020-03-04T13:45:45
facebook/react
46713c3d7d10f56ab4df29d04396958a6660c8e6
b0152049386b6192f9fb994577e3ccbfe9bc1033
Fix Lint Enabling bitwise linting caught another user. Also fixed a semicolon misuse.
[ { "path": "src/test/ReactPerf.js", "patch": "@@ -49,9 +49,9 @@ var ReactPerf = {\n measuredFunc = ReactPerf.storedMeasure(objName, fnName, func);\n }\n return measuredFunc.apply(this, arguments);\n- };\n+ }\n return func.apply(this, arguments);\n- }...
2013-10-16T00:57:45
electron/electron
af2ca221b4f8e60e445d5085c09a95a33f3c560e
d5bb1d87ccdf3cc19de80f0c700891a71c15ced0
Ignore npm-debug.log
[ { "path": "npm/.gitignore", "patch": "@@ -2,3 +2,4 @@ node_modules\n dist\n path.txt\n .DS_Store\n+npm-debug.log", "additions": 1, "deletions": 0, "language": "Unknown" }, { "path": "npm/.npmignore", "patch": "@@ -6,3 +6,4 @@ appveyor.yml\n CONTRIBUTING.md\n issue_template.md\n test/...
2016-12-27T19:21:18
golang/go
1e3c19f3fee12e5e2b7802a54908a4d4d03960da
f28fa952b5f81a63afd96c9c58dceb99cc7d1dbf
runtime: support riscv64 SV57 mode riscv64 has SV57 mode when user-space VA is 56 bits. Linux kernel recently got support for this mode and Go binaries started crashing as: runtime: lfstack.push invalid packing: node=0xffffff5908a940 cnt=0x1 packed=0xffff5908a9400001 -> node=0xffff5908a940 Adjust lfstack code to use...
[ { "path": "src/runtime/lfstack_64bit.go", "patch": "@@ -36,12 +36,21 @@ const (\n \t// We use one bit to distinguish between the two ranges.\n \taixAddrBits = 57\n \taixCntBits = 64 - aixAddrBits + 3\n+\n+\t// riscv64 SV57 mode gives 56 bits of userspace VA.\n+\t// lfstack code supports it, but broader sup...
2022-05-27T16:55:35
rust-lang/rust
03bc1be8dd9be8fb6a0672e89731d0826dff0a09
1698c8e322d0cd95aea94b85ef098e5ccfe3c856
Simplify `SymbolMangler::print_type`. `Bound`/`Placeholder`/`Infer`/`Error` shouldn't occur, so we can handle them in the second exhaustive `match`, and ignore them in the first non-exhaustive `match`.
[ { "path": "compiler/rustc_symbol_mangling/src/v0.rs", "patch": "@@ -425,7 +425,6 @@ impl<'tcx> Printer<'tcx> for SymbolMangler<'tcx> {\n ty::Bool => \"b\",\n ty::Char => \"c\",\n ty::Str => \"e\",\n- ty::Tuple(_) if ty.is_unit() => \"u\",\n ty::Int(...
2025-08-01T03:10:35
vercel/next.js
a52e1695f0868473f14e6ee30825dc5694999d54
093af1850a17b480fc34ebe4bd3e65c47329fc50
Update rust-toolchain to nightly-2023-10-06 (vercel/turbo#6128) This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimat...
[ { "path": "crates/turbo-tasks-memory/src/aggregation_tree/bottom_tree.rs", "patch": "@@ -555,7 +555,7 @@ impl<T, I: Clone + Eq + Hash + IsEnabled> BottomTree<T, I> {\n ) {\n let mut state = self.state.write();\n let change = aggregation_context.apply_change(&mut state.data, change);\n- ...
2023-10-10T17:00:27
nodejs/node
077f9dc6036b97e9e12e3681e3c3bdf29d44de2b
98f44296dcf5ba526f1a517effaeb309b10b9ea1
test: allow EAI_FAIL in test-net-dns-error.js Test test-net-dns-error.js causes assertion failure on SunOS, test expects ENOTFOUND, but OS returns EAI_FAIL. Maximum length of a host name is 63 characters. Test test-net-dns-error.js makes a connection attempt to invalid host name (longer than maximum). Such connection...
[ { "path": "test/parallel/test-net-dns-error.js", "patch": "@@ -26,15 +26,16 @@ const assert = require('assert');\n const net = require('net');\n \n const host = '*'.repeat(64);\n-const errCode = common.isOpenBSD ? 'EAI_FAIL' : 'ENOTFOUND';\n+// Resolving hostname > 63 characters may return EAI_FAIL (permane...
2020-02-13T18:17:42
golang/go
87384801dce4ddb70a43aaf4b2f4eea549a7e047
c6a2dada0df8c2d75cf3ae599d7caed77d416fa2
cmd/asm: update package doc to describe "-p" option Include a description of the assembler's "-p" command line option in the package doc. Fixes #54215. Change-Id: I641abad573c37aa9447af6e8b84716093c2a2b70 Reviewed-on: https://go-review.googlesource.com/c/go/+/420900 Reviewed-by: Ian Lance Taylor <iant@google.com> Tr...
[ { "path": "src/cmd/asm/doc.go", "patch": "@@ -37,6 +37,8 @@ Flags:\n \t\tWrite symbol ABI information to output file. Don't assemble.\n \t-o file\n \t\tWrite output to file. The default is foo.o for /a/b/c/foo.s.\n+\t-p pkgpath\n+\t\tSet expected package import to pkgpath.\n \t-shared\n \t\tGenerate code th...
2022-08-03T18:59:58
vercel/next.js
093af1850a17b480fc34ebe4bd3e65c47329fc50
8f017cf91bd8d710549943fc5a3b00e5637c84c8
Turbopack: detect `spawn(process.argv[0], ['-e', ...])` (vercel/turbo#6118) This detects a specific pattern for invoking a node process to evaluate a string of JavaScript code. Since a filepath can't (or shouldn't) be passed here, this exempts it from static analysis. This pattern is used by the package `xmlhttpreque...
[ { "path": "crates/turbopack-ecmascript/src/analyzer/mod.rs", "patch": "@@ -1370,6 +1370,10 @@ impl JsValue {\n \"process\",\n \"The Node.js process module: https://nodejs.org/api/process.html\",\n ),\n+ WellKnownObjectKin...
2023-10-10T17:00:14
facebook/react
b0645bd5d3bbea40e93194a6c403ce3ba633d45a
5a13dd090d63c0c779c0e3b75a3a7bc70459c456
Be consistent with object naming in tests This also fixes line length issues our linter was complaining about.
[ { "path": "src/dom/components/__tests__/ReactDOMInput-test.js", "patch": "@@ -64,14 +64,14 @@ describe('ReactDOMInput', function() {\n expect(node.value).toBe('false');\n });\n \n- it('should display \"foobar\" for `defaultValue` of `objectToString`', function() {\n- var objectToString = {\n+ it(...
2013-10-15T17:42:06
electron/electron
5ee3915c400ab38d8264500b7e538ae8f470ec95
6f2f3ed1ac1ee0c9e2a247e81a71d23f2c858bc3
[ci skip]fixed glossary.md incorrect words
[ { "path": "docs-translations/zh-CN/glossary.md", "patch": "@@ -4,7 +4,7 @@\n \n ### ASAR\n \n-ASAR 代表了 Atom Shell Archive Format。一个 [asar][asar] 压缩包就是一个简单的 `tar` 文件-就像将那些有联系的文件格式化至一个单独的文件中。Electron 能够任意读取其中的文件并且不需要解压缩整个文件。\n+ASAR 代表了 Atom Shell Archive Format。一个 asar 压缩包就是一个简单的 `tar` 文件-就像将那些有联系的文件格式化至一个单独的...
2016-12-26T09:57:20
golang/go
0ad2ec6596afc51341fa3059528d89a0508956ab
7e952962dff6aafb9ed888a86a7208f01fbe9508
runtime: clean up dopanic_m gp is a user G running on the same M as getg(), so it is a fine proxy for gp.m. Change-Id: I9aa1dd283ecf28878eeedd7da4ded5c901809832 Reviewed-on: https://go-review.googlesource.com/c/go/+/418576 Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Austin Clements <austin@google.com> ...
[ { "path": "src/runtime/panic.go", "patch": "@@ -1240,6 +1240,8 @@ func startpanic_m() bool {\n var didothers bool\n var deadlock mutex\n \n+// gp is the crashing g running on this M, but may be a user G, while getg() is\n+// always g0.\n func dopanic_m(gp *g, pc, sp uintptr) bool {\n \tif gp.sig != 0 {\n \t...
2022-07-20T15:18:15
facebook/react
53324222398e4cb2d9c3159133b1a28aaf5158d4
7909c3e71b299fd100c7af660ab68ae3716b0a25
[docs] Fix a broken link to JSX syntax in README.
[ { "path": "README.md", "patch": "@@ -28,7 +28,7 @@ React.renderComponent(\n \n This example will render \"Hello John\" into a container on the page.\n \n-You'll notice that we used an XML-like syntax; [we call it JSX](http://facebook.github.io/react/docs/syntax.html). JSX is not required to use React, but i...
2013-10-15T00:10:26
vercel/next.js
1c078482977ef092b4d36948fc48bc96e4dcf1e8
f6d6acd9ec801724726c888b5b7f4706addbc1c3
fix(docs): adjust api route documentation examples (#56660) Fixed the example functions in the documentation to use `async` in order to use `await` within the function body. Co-authored-by: Michael Novotny <446260+manovotny@users.noreply.github.com>
[ { "path": "docs/03-pages/01-building-your-application/01-routing/07-api-routes.mdx", "patch": "@@ -217,7 +217,10 @@ The following example sends a JSON response with the status code `200` (`OK`) an\n ```ts filename=\"pages/api/hello.ts\" switcher\n import type { NextApiRequest, NextApiResponse } from 'next'\...
2023-10-10T15:23:00
facebook/react
7909c3e71b299fd100c7af660ab68ae3716b0a25
b45c82c25658fcbadd0ff1d861ce0d3c4e7dff27
Forcibly wrap SVG nodes with <svg> on creation Forcing wrapping seems necessary here: I compared a <circle> created within a <div> with a <circle> created inside an <svg> and they appear to have exactly the same properties with the exception of .parentNode (and .parentElement), yet the former refuses to show up when a...
[ { "path": "src/vendor/core/getMarkupWrap.js", "patch": "@@ -32,23 +32,52 @@ var dummyNode =\n *\n * In IE8, certain elements cannot render alone, so wrap all elements ('*').\n */\n-var shouldWrap = {};\n+var shouldWrap = {\n+ // Force wrapping for SVG elements because if they get created inside a <div>,...
2013-09-10T02:23:05
electron/electron
dcead89507a32483958a7d1f33bd400f7dad28a6
f8a9f628ae326586a47526575f65d5ac6ef3fd2b
:memo: Fix a broken asar link.
[ { "path": "docs/glossary.md", "patch": "@@ -12,9 +12,10 @@ The ASAR format was created primarily to improve performance on Windows... TODO\n \n ### Brightray\n \n-Brightray is a static library that makes [libchromiumcontent] easier to use in\n-applications. It was created specifically for Electron, but can ...
2016-12-26T09:28:08
golang/go
7e952962dff6aafb9ed888a86a7208f01fbe9508
9dbc0f3556b3401b0f3339d4c33cd32ea16d5241
runtime: clean up canpanic * The gp argument to canpanic is always equivalent to getg(), so no need to pass it at all. * gp must not be nil or _g_.m would have crashed, so no need to check for nil. * Use acquirem to better reason about preemption. Change-Id: Ic7dc8dc1e56ab4c1644965f6aeba16807cdb2df4 Reviewed-on: http...
[ { "path": "src/runtime/os_js.go", "patch": "@@ -50,7 +50,7 @@ const _SIGSEGV = 0xb\n \n func sigpanic() {\n \tg := getg()\n-\tif !canpanic(g) {\n+\tif !canpanic() {\n \t\tthrow(\"unexpected signal during runtime execution\")\n \t}\n ", "additions": 1, "deletions": 1, "language": "Go" }, { ...
2022-07-20T15:09:14
nodejs/node
0a539ddc0ad53c609199465dcb85008811e57bd2
9dbe6ab2773372bd04c0626826efd7ed845227a8
fs: fix valid id range on chown, lchown, fchown PR-URL: https://github.com/nodejs/node/pull/31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
[ { "path": "lib/fs.js", "patch": "@@ -109,9 +109,10 @@ const {\n parseFileMode,\n validateBuffer,\n validateInteger,\n- validateInt32,\n- validateUint32\n+ validateInt32\n } = require('internal/validators');\n+// 2 ** 32 - 1\n+const kMaxUserId = 4294967295;\n \n let truncateWarn = true;\n let fs;\n@...
2020-02-09T15:13:41
electron/electron
d224f5d998645f3f502656c25546e4b0e7135fcf
f8a9f628ae326586a47526575f65d5ac6ef3fd2b
Fix electron-jp's link in README.md
[ { "path": "README.md", "patch": "@@ -73,7 +73,7 @@ forums\n - [`Atom`](http://atom-slack.herokuapp.com/) channel on Slack\n - [`electron-br`](https://electron-br.slack.com) *(Brazilian Portuguese)*\n - [`electron-kr`](http://www.meetup.com/electron-kr/) *(Korean)*\n-- [`electron-jp`](https://electron-jp-sla...
2016-12-25T09:07:25
golang/go
9dbc0f3556b3401b0f3339d4c33cd32ea16d5241
d723df76da3ee4c8f3c03fd03be29fba9bfeb02a
runtime: fix outdated g.m comment in traceback.go Change-Id: Idfd02781a9ee550da240ef53898943e8cd37dd64 Reviewed-on: https://go-review.googlesource.com/c/go/+/418574 Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
[ { "path": "src/runtime/traceback.go", "patch": "@@ -1051,10 +1051,10 @@ func tracebackothers(me *g) {\n \t\t}\n \t\tprint(\"\\n\")\n \t\tgoroutineheader(gp)\n-\t\t// Note: gp.m == g.m occurs when tracebackothers is\n-\t\t// called from a signal handler initiated during a\n-\t\t// systemstack call. The origi...
2022-07-20T17:20:48
rust-lang/rust
1063b0f09010ffae99b6a3b55bec5539876ce57e
d1d44d44f15f32ea4c53abc2dbb35bd8304e582e
Change `TestCx::error` to `error_prefix`, which returns a string This reduces the amount of "hidden" printing in error-reporting code, which will be helpful when overhauling compiletest's error handling and output capture.
[ { "path": "src/tools/compiletest/src/runtest.rs", "patch": "@@ -603,7 +603,10 @@ impl<'test> TestCx<'test> {\n );\n } else {\n for pattern in missing_patterns {\n- self.error(&format!(\"error pattern '{}' not found!\", pattern));\n+ println!(\n+ ...
2025-08-02T03:07:01
nodejs/node
7bb4f95c1cdf860082a27e2592488c2ba6734c20
3b8d70d924bee5126b1583fc3f1c4a8c70bce53b
src: fix -Wreorder compiler warning ../src/node_http_common-inl.h:126:7: warning: field 'token_' will be initialized after field 'name_' [-Wreorder] : token_(other.token_), PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.com/nodejs/node/pull/32069 Reviewed-By: Denys Otrishko <shishugi@gmail...
[ { "path": "src/node_http_common-inl.h", "patch": "@@ -123,9 +123,9 @@ NgHeader<T>::NgHeader(\n \n template <typename T>\n NgHeader<T>::NgHeader(NgHeader<T>&& other) noexcept\n- : token_(other.token_),\n- name_(std::move(other.name_)),\n+ : name_(std::move(other.name_)),\n value_(std::move(o...
2020-03-06T16:21:00
facebook/react
4549fd7510fe752b98c7b77d9817d4300c9d824c
ef60eee57ab8a86e47847761532cf72a1205b668
fix namesToPlugins for gcc advanced mode
[ { "path": "src/core/ReactDefaultInjection.js", "patch": "@@ -58,12 +58,12 @@ function inject() {\n * them).\n */\n EventPluginHub.injection.injectEventPluginsByName({\n- 'SimpleEventPlugin': SimpleEventPlugin,\n- 'EnterLeaveEventPlugin': EnterLeaveEventPlugin,\n- 'ChangeEventPlugin': Change...
2013-10-06T11:08:25
electron/electron
b0c4c79c49a289c240bf911efa4f525fa5f7ce89
eb4038d626a8a3f502c175f5965b40da154d2a2a
remove unused webview fixture
[ { "path": "spec/fixtures/pages/webview-log-process.html", "patch": "@@ -1,13 +0,0 @@\n-<!DOCTYPE html>\n-<html>\n- <head>\n- <meta charset=\"utf-8\">\n- <title>test</title>\n- <script>\n- console.log(typeof process)\n- </script>\n- </head>\n- <body>\n- test?\n- </body>\n-</html>", ...
2016-11-22T22:44:24
golang/go
1b7e71e8ae824c2ac661dd793bca29cf60378936
f2a9f3e2e0ce7e582d226ad9a41d3c36b146fc25
all: disable tests that fail on Alpine These changes are enough to pass all.bash using the disabled linux-amd64-alpine builder via debugnewvm. For #19938. For #39857. Change-Id: I7d160612259c77764b70d429ad94f0864689cdce Reviewed-on: https://go-review.googlesource.com/c/go/+/419995 TryBot-Result: Gopher Robot <gobot@...
[ { "path": "misc/cgo/test/issue1435.go", "patch": "@@ -10,6 +10,7 @@ package cgotest\n import (\n \t\"fmt\"\n \t\"os\"\n+\t\"runtime\"\n \t\"sort\"\n \t\"strings\"\n \t\"syscall\"\n@@ -145,6 +146,11 @@ func test1435(t *testing.T) {\n \tif syscall.Getuid() != 0 {\n \t\tt.Skip(\"skipping root only test\")\n \t...
2022-07-29T04:32:14
facebook/react
ef60eee57ab8a86e47847761532cf72a1205b668
7a9c13dee8a37f7dfaf02d76c75f67b403df0045
Make transferPropsTo() message easier to debug Summary: Made the transferPropsTo() error introduced in 325322898cc413454feede0201b61da1abe1e67e easier to use to debug.
[ { "path": "src/core/ReactPropTransferer.js", "patch": "@@ -93,9 +93,11 @@ var ReactPropTransferer = {\n transferPropsTo: function(component) {\n invariant(\n component.props.__owner__ === this,\n- 'You can\\'t call transferPropsTo() on a component that you don\\'t ' +\n- 'own...
2013-10-09T18:11:41
nodejs/node
3b8d70d924bee5126b1583fc3f1c4a8c70bce53b
99e57259ecc15cdcd7fc73d454ff93ce36a94bcd
src: fix -Winconsistent-missing-override warning ../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void MemoryInfo(MemoryTracker* tracker) const { PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.co...
[ { "path": "src/node_http_common.h", "patch": "@@ -494,7 +494,7 @@ class NgHeader : public MemoryRetainer {\n inline std::string value() const;\n inline size_t length() const;\n \n- void MemoryInfo(MemoryTracker* tracker) const {\n+ void MemoryInfo(MemoryTracker* tracker) const override {\n tracker...
2020-03-06T16:15:43
vercel/next.js
f6d6acd9ec801724726c888b5b7f4706addbc1c3
35f507242cbb10d17ea70e1716635246aa2a7998
Update 01-contribution-guide.mdx: Fix a typo (#56665) Fix a small typo in the metadata section of the contributing guide. Kindly add the label: `hacktoberfest-accepted`.
[ { "path": "docs/05-community/01-contribution-guide.mdx", "patch": "@@ -111,7 +111,7 @@ The following fields are **required**:\n \n ```yaml filename=\"required-fields.mdx\"\n ---\n-tile: Page Title\n+title: Page Title\n description: Page Description\n ---\n ```", "additions": 1, "deletions": 1, "...
2023-10-10T15:15:13
golang/go
27038b70f860e29fdf472ac5fb208b6ad9598c10
e99f53fed98b0378c147588789b8c56b0305469b
cmd/compile: fix wrong dict pass condition for type assertions Fixes #54135 Change-Id: I2b27af8124014b2699ea44bdc765e1fb8f6c8028 Reviewed-on: https://go-review.googlesource.com/c/go/+/420394 Reviewed-by: Keith Randall <khr@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@gola...
[ { "path": "src/cmd/compile/internal/noder/stencil.go", "patch": "@@ -1357,6 +1357,9 @@ func (g *genInst) dictPass(info *instInfo) {\n \t\t\t}\n \t\tcase ir.ODOTTYPE, ir.ODOTTYPE2:\n \t\t\tdt := m.(*ir.TypeAssertExpr)\n+\t\t\tif dt.Type().IsEmptyInterface() || (dt.Type().IsInterface() && !dt.Type().HasShape(...
2022-07-31T09:20:26
facebook/react
7a9c13dee8a37f7dfaf02d76c75f67b403df0045
d652dd928a77848df824ba9245291924c8d6b727
Set _renderedComponent before it's fully mounted For debugging so that we can inspect the currently rendering tree. I think this should be safe and makes sense since it tried to mount.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -798,6 +798,7 @@ var ReactCompositeComponentMixin = {\n var thisID = this._rootNodeID;\n var currentComponentID = currentComponent._rootNodeID;\n currentComponent.unmountComponent();\n+ this._renderedComponent = nex...
2013-10-09T18:11:29
nodejs/node
5688eb8f83646a8c4896d5b81086377eb5092b3e
1b35e8402f890a7b7c9b701a0d2f61cf39a0fc7c
doc: fix broken links in benchmark README PR-URL: https://github.com/nodejs/node/pull/32121 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <a...
[ { "path": "benchmark/README.md", "patch": "@@ -76,17 +76,17 @@ writing benchmarks.\n \n ### `createBenchmark(fn, configs[, options])`\n \n-See [the guide on writing benchmarks](../doc/guides/contributing/writing-and-running-benchmarks.md#basics-of-a-benchmark).\n+See [the guide on writing benchmarks](../doc...
2020-03-06T07:27:02
rust-lang/rust
557737062d1a65b25f9bbb257f07755078e5cdae
9c4a35e0e705dbe93dcfbba9fbde9d3dbfc13e11
corrected lifetime in core::panic::Location::file return type
[ { "path": "library/core/src/panic/location.rs", "patch": "@@ -195,7 +195,7 @@ impl<'a> Location<'a> {\n #[must_use]\n #[unstable(feature = \"file_with_nul\", issue = \"141727\")]\n #[inline]\n- pub const fn file_with_nul(&self) -> &CStr {\n+ pub const fn file_with_nul(&self) -> &'a CStr {\...
2024-10-24T00:13:56
vercel/next.js
35f507242cbb10d17ea70e1716635246aa2a7998
5d2c503eacfa45243dfe82125a6c029d34c59586
fix: next dev with edge runtime on windows (#56502) - Reverts https://github.com/vercel/next.js/pull/44616 - Regression introduced in https://github.com/vercel/next.js/pull/51651 - Fixes https://github.com/vercel/next.js/issues/55013
[ { "path": ".github/actions/next-stats-action/src/index.js", "patch": "@@ -127,9 +127,6 @@ if (!allowedActions.has(actionInfo.actionName) && !actionInfo.isRelease) {\n )\n .catch(console.error)\n \n- console.log(await exec(`ls ${path.join(__dirname, '../native')}`))\n- console.log(a...
2023-10-10T14:03:03
golang/go
8b13a073a19336923622a1de47d2b4fa2994545d
e95fd4c2380b0adaa10be40812739156198037b7
doc: mention removal of cmd/compile's -importmap and -installsuffix flags Updates #51225. Change-Id: I820f3f5ba169635fee37c30e41b370c9399a436d Reviewed-on: https://go-review.googlesource.com/c/go/+/417534 Reviewed-by: Russ Cox <rsc@golang.org>
[ { "path": "doc/go1.19.html", "patch": "@@ -252,6 +252,13 @@ <h2 id=\"compiler\">Compiler</h2>\n that invoke the Go compiler directly will need to make sure they\n pass this flag as well.\n </p>\n+<p><!-- CL 415235 --><!-- CL 415236 -->\n+ The Go compiler no longer accepts the <code>-importmap</code>\n+...
2022-07-13T22:00:53
facebook/react
2e6092b2171cf8f7ecdc2993a4f6f5e6ebc7becb
f658c32df13ceb5aad23b5644297fe6c9dc9bdb7
react-with-addons build This creates a new standalone build which should have everything the default build has, plus a little extra. This is not a sustainable long term solution (we shouldn't make people choose like this) but it fixes the problem we have in the short term. This also removes the terrible react-transit...
[ { "path": "Gruntfile.js", "patch": "@@ -68,9 +68,10 @@ module.exports = function(grunt) {\n });\n \n grunt.registerTask('build:basic', ['jsx:debug', 'version-check', 'browserify:basic']);\n+ grunt.registerTask('build:addons', ['jsx:debug', 'browserify:addons']);\n grunt.registerTask('build:transforme...
2013-09-24T19:55:20
rust-lang/rust
8f6b43dd656743730d32f5f7ee5a768434d25189
b8c16e47f4a2757992941a421423534be2dc8a87
fix: `option_if_let_else` don't suggest argless function for Result::map_or_else closes rust-clippy/issues/15002 Signed-off-by: Zihan <zihanli0822@gmail.com>
[ { "path": "clippy_lints/src/option_if_let_else.rs", "patch": "@@ -224,8 +224,8 @@ fn try_get_option_occurrence<'tcx>(\n \n let mut app = Applicability::Unspecified;\n \n- let (none_body, is_argless_call) = match none_body.kind {\n- ExprKind::Call(call_expr, []) if !none_body.span.f...
2025-08-02T16:54:04
nodejs/node
1b35e8402f890a7b7c9b701a0d2f61cf39a0fc7c
4c6ef4b7e28afb31228ce29bf3a20f94b90554dc
test: remove superfluous checks in test-net-reconnect-error The process.on('exit', ...) checks duplicate the work of `common.mustCall()` and are superfluous. Remove them. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Revi...
[ { "path": "test/sequential/test-net-reconnect-error.js", "patch": "@@ -24,24 +24,17 @@ const common = require('../common');\n const net = require('net');\n const assert = require('assert');\n const N = 20;\n-let clientErrorCount = 0;\n let disconnectCount = 0;\n \n const c = net.createConnection(common.PORT...
2020-03-06T07:12:19
vercel/next.js
5d2c503eacfa45243dfe82125a6c029d34c59586
d4fcd039666caefe2a69bd22f487f6b694d595c3
remove unnecessary structuredClone (#56570) An issue discovered from #56502 in azure pipeline ``` > Build error occurred ReferenceError: structuredClone is not defined ``` `structuredClone` is not supported until nodejs 17, here we actually don't need to use `structuredClone` as the values are almost primitives, the...
[ { "path": "packages/next/src/build/webpack-build/index.ts", "patch": "@@ -24,7 +24,7 @@ function deepMerge(target: any, source: any) {\n ? (target[key] = [...target[key], ...(source[key] || [])])\n : typeof target[key] == 'object' && typeof source[key] == 'object'\n ? deepMerge(target[key]...
2023-10-10T13:43:04
golang/go
e95fd4c2380b0adaa10be40812739156198037b7
dee3efd9f879335cfb583752b0729cc57f61897e
doc/go1.19: fix typo: EM_LONGARCH -> EM_LOONGARCH Another last-minute fix. The whole repo is checked case-insensitively against "longarch" and this is the only occurrence. Change-Id: If13c123c1e44001a346f1df1df9d839c699703b0 Reviewed-on: https://go-review.googlesource.com/c/go/+/420494 Auto-Submit: Dmitri Shuralyov <...
[ { "path": "doc/go1.19.html", "patch": "@@ -490,7 +490,7 @@ <h3 id=\"minor_library_changes\">Minor changes to the library</h3>\n <dl id=\"debug/elf\"><dt><a href=\"/pkg/debug/elf/\">debug/elf</a></dt>\n <dd>\n <p><!-- CL 396735 -->\n- The new <code>EM_LONGARCH</code> and <code>R_LARCH_*</code> con...
2022-08-01T13:19:29
facebook/react
b9a657db2cbd7d8c9d168686f6ce1b384f1f60cd
dbc613199bd9f7da81692d5c0941339d3ffe0a8e
fixed broken link on Community Round-up #9 blog post closes #409
[ { "path": "docs/_posts/2013-10-3-community-roundup-9.md", "patch": "@@ -13,7 +13,7 @@ We organized a React hackathon last week-end in the Facebook Seattle office. 50\n \n [Alex Swan](http://bold-it.com/) implemented [Qu.izti.me](http://qu.izti.me/), a multi-player quiz game. It is real-time via Web Socket a...
2013-10-06T07:54:10
rust-lang/rust
9c4a35e0e705dbe93dcfbba9fbde9d3dbfc13e11
e772f7ab3ee7d5f217c60b640b95f8bfc84d9536
added regression test for `core::panic::Location::file`'s lifetime
[ { "path": "library/core/tests/panic/location.rs", "patch": "@@ -0,0 +1,39 @@\n+use core::panic::Location;\n+\n+// Note: Some of the following tests depend on the source location,\n+// so please be careful when editing this file.\n+\n+#[test]\n+fn location_const_caller() {\n+ const _CALLER_REFERENCE: &Loc...
2024-10-24T03:49:23
nodejs/node
4c6ef4b7e28afb31228ce29bf3a20f94b90554dc
6aff62fcb326bd3d51dbbcf91e63f6d2150488b3
test: apply camelCase in test-net-reconnect-error Rename two idnetifiers that were snake_case rather than camelCase. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-B...
[ { "path": "test/sequential/test-net-reconnect-error.js", "patch": "@@ -24,24 +24,24 @@ const common = require('../common');\n const net = require('net');\n const assert = require('assert');\n const N = 20;\n-let client_error_count = 0;\n-let disconnect_count = 0;\n+let clientErrorCount = 0;\n+let disconnect...
2020-03-06T07:07:49
vercel/next.js
260ea16467c87a95fe6391e6478f3917d0243f53
3f25a2e747fc27da6c2166e45d54fc95e96d7895
Improve error handling of Server Actions with skewed deployment (#56618) When there's a version skew, it might be possible that the Action's ID has changed and we're no longer able to locate it. By definition, that means we **should** return a 404 because it might have a different implementation now. Currently this th...
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -284,269 +284,285 @@ export async function handleAction({\n typeof actionId === 'string' &&\n req.method === 'POST'\n \n- if (isFetchAction || isURLEncodedAction || isMultipartAction) {\n- // ensure we avoid caching ...
2023-10-09T20:42:41
facebook/react
dbc613199bd9f7da81692d5c0941339d3ffe0a8e
920c4206f4491b2b61a27559b88214292d89fc48
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ...
[ { "path": "src/eventPlugins/ChangeEventPlugin.js", "patch": "@@ -25,6 +25,7 @@ var ExecutionEnvironment = require('ExecutionEnvironment');\n var SyntheticEvent = require('SyntheticEvent');\n \n var isEventSupported = require('isEventSupported');\n+var isTextInputElement = require('isTextInputElement');\n va...
2013-10-08T17:26:51
golang/go
dee3efd9f879335cfb583752b0729cc57f61897e
f32519e5fbcf1b12f9654a6175e5e72b09ae8f3a
doc/go1.19: fix a few links that were missing trailing slashes They were part of a chain of three redirects. Now it's only two, but that's #54081. Change-Id: Ibfe6a17a372df61df40124892951b48577e4ced9 Reviewed-on: https://go-review.googlesource.com/c/go/+/419634 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Revie...
[ { "path": "doc/go1.19.html", "patch": "@@ -77,7 +77,7 @@ <h3 id=\"go-doc\">Doc Comments</h3>\n now reformats doc comments to make their rendered meaning clearer.\n See “<a href=\"/doc/comment\">Go Doc Comments</a>”\n for syntax details and descriptions of common mistakes now highlighted by <code>gofmt</code...
2022-07-27T02:28:00
rust-lang/rust
e772f7ab3ee7d5f217c60b640b95f8bfc84d9536
6d091b2baa33698682453c7bb72809554204e434
corrected lifetime in core::panic::Location::file return type
[ { "path": "library/core/src/panic/location.rs", "patch": "@@ -183,7 +183,7 @@ impl<'a> Location<'a> {\n #[must_use]\n #[stable(feature = \"panic_hooks\", since = \"1.10.0\")]\n #[rustc_const_stable(feature = \"const_location_fields\", since = \"1.79.0\")]\n- pub const fn file(&self) -> &str {...
2024-10-24T00:13:56
electron/electron
387dd67b6021ff4a4f80157c305f032d50cecf37
ec46d578163d24436c5ca31ab9dea7b27d12d0c1
[ci skip]fix chinese incorrect words
[ { "path": "docs-translations/zh-CN/README.md", "patch": "@@ -4,7 +4,7 @@\n \n ## 常见问题\n \n-这里是一些被经常问到的问题,再提 issue 之前请先看一下这里。\n+这里是一些被经常问到的问题,在提 issue 之前请先看一下这里。\n \n + [Electron 常见问题](faq/electron-faq.md)\n ", "additions": 1, "deletions": 1, "language": "Markdown" }, { "path": "docs-tran...
2016-12-22T09:10:27
nodejs/node
6aff62fcb326bd3d51dbbcf91e63f6d2150488b3
4d93e105bfad79ff6c6f01e4b7c2fdd70caeb43b
wasi: add returnOnExit option This commit adds a WASI option allowing the __wasi_proc_exit() function to return an exit code instead of forcefully terminating the process. PR-URL: https://github.com/nodejs/node/pull/32101 Fixes: https://github.com/nodejs/node/issues/32093 Reviewed-By: James M Snell <jasnell@gmail.com...
[ { "path": "doc/api/wasi.md", "patch": "@@ -58,6 +58,10 @@ added: v13.3.0\n sandbox directory structure. The string keys of `preopens` are treated as\n directories within the sandbox. The corresponding values in `preopens` are\n the real paths to those directories on the host machine.\n+ * `retu...
2020-03-05T01:46:02
facebook/react
ed9c0ca87c2a7ceb8803ee26cf0beacba9a23176
68abbacc3954ca088d3bdea4e45789079c4f8069
Expose bound function, context and arguments Exposes the bound context, original method and bound arguments for any auto-bound methods, for debugging purposes.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -891,6 +891,9 @@ var ReactCompositeComponentMixin = {\n return method.apply(component, arguments);\n };\n if (__DEV__) {\n+ boundMethod.__reactBoundContext = component;\n+ boundMethod.__reactBoundMethod = method;\n+ b...
2013-10-07T21:53:36
vercel/next.js
b4660d8f252f303b78c6823538f0faa3c527e9dd
9b2f29ebaf5add67cec0cac7296f9e64567b3fb4
feat(turbopack): add support for edge app pages (#56426) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Co...
[ { "path": "packages/next-swc/crates/next-core/src/next_app/app_page_entry.rs", "patch": "@@ -9,6 +9,7 @@ use turbopack_binding::{\n core::{\n asset::{Asset, AssetContent},\n context::AssetContext,\n+ module::Module,\n reference_type::ReferenceType,\n ...
2023-10-09T14:32:20
golang/go
f32519e5fbcf1b12f9654a6175e5e72b09ae8f3a
9a2001a8cc75b1ceda17da828edcee93c9d9f42c
runtime: fix typos Change-Id: I30c125be6cb321aa03ea827bd11c3169087e3d4c Reviewed-on: https://go-review.googlesource.com/c/go/+/420314 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Keith Randall <khr@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com...
[ { "path": "src/runtime/chan.go", "patch": "@@ -780,7 +780,7 @@ func (q *waitq) dequeue() *sudog {\n \t\t} else {\n \t\t\ty.prev = nil\n \t\t\tq.first = y\n-\t\t\tsgp.next = nil // mark as removed (see dequeueSudog)\n+\t\t\tsgp.next = nil // mark as removed (see dequeueSudoG)\n \t\t}\n \n \t\t// if a gorouti...
2022-07-30T14:11:32
nodejs/node
4d93e105bfad79ff6c6f01e4b7c2fdd70caeb43b
c49286ba8b3b8aeac1aa40abcc1da7bb4dd7cbf1
stream: don't destroy final readable stream in pipeline If the last stream in a pipeline is still usable/readable don't destroy it to allow further composition. Fixes: https://github.com/nodejs/node/issues/32105 PR-URL: https://github.com/nodejs/node/pull/32110 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ...
[ { "path": "lib/internal/streams/pipeline.js", "patch": "@@ -25,9 +25,12 @@ let EE;\n let PassThrough;\n let createReadableStreamAsyncIterator;\n \n-function destroyer(stream, reading, writing, callback) {\n+function destroyer(stream, reading, writing, final, callback) {\n const _destroy = once((err) => {\...
2020-03-05T22:18:23
facebook/react
68abbacc3954ca088d3bdea4e45789079c4f8069
a9b3139ff8f4e36ce3971f1ea97e5712d03763d7
Expose the rendered children before they're actually mounted Exposing the _renderedChildren property before all the children are fully mounted. This allows us to debug a partially mounted tree when the debugger has a breakpoint in the one of the mounting children. This only has a functional difference in the case whe...
[ { "path": "src/core/ReactMultiChild.js", "patch": "@@ -197,6 +197,7 @@ var ReactMultiChild = {\n mountChildren: function(children, transaction) {\n var mountImages = [];\n var index = 0;\n+ this._renderedChildren = children;\n for (var name in children) {\n var child = chi...
2013-10-07T21:53:20
vercel/next.js
9b2f29ebaf5add67cec0cac7296f9e64567b3fb4
bfc2ab9cff8f319474e4035450e04f858dc1e4e5
Update actions.ts (#56579) fixed depricated nonempty()
[ { "path": "examples/next-forms/app/actions.ts", "patch": "@@ -11,7 +11,7 @@ import { z } from 'zod'\n \n export async function createTodo(prevState: any, formData: FormData) {\n const schema = z.object({\n- todo: z.string().nonempty(),\n+ todo: z.string().min(1),\n })\n const data = schema.parse...
2023-10-09T02:32:42
rust-lang/rust
b8c16e47f4a2757992941a421423534be2dc8a87
e8185ec091d7fe71b03cacb7846ae1c8323e013a
fix: `option_if_let_else` keep deref op if the inner expr is a raw pointer closes rust-clippy/issues/15379 Signed-off-by: Zihan <zihanli0822@gmail.com>
[ { "path": "clippy_lints/src/option_if_let_else.rs", "patch": "@@ -127,7 +127,8 @@ fn try_get_option_occurrence<'tcx>(\n if_else: &'tcx Expr<'_>,\n ) -> Option<OptionOccurrence> {\n let cond_expr = match expr.kind {\n- ExprKind::Unary(UnOp::Deref, inner_expr) | ExprKind::AddrOf(_, _, inner_exp...
2025-08-02T16:20:31
golang/go
994ff78ba01b921870866f9ce9db7563bd89494f
23554d474443ef8f2dacc8c92be5636504df61ac
[dev.unified] go/internal: set underlying types in proper order This problem appeared in google-internal testing. If the run-later functions are run in the wrong order, type definitions won't resolve properly. Change-Id: I9da0775976282e92ca036d20fd9fd6650900daf9 Reviewed-on: https://go-review.googlesource.com/c/go/+/...
[ { "path": "src/go/internal/gcimporter/gcimporter_test.go", "patch": "@@ -583,6 +583,30 @@ func TestIssue13566(t *testing.T) {\n \t}\n }\n \n+func TestTypeNamingOrder(t *testing.T) {\n+\tskipSpecialPlatforms(t)\n+\n+\t// This package only handles gc export data.\n+\tif runtime.Compiler != \"gc\" {\n+\t\tt.Sk...
2022-07-29T16:06:50
electron/electron
e296d4826fa347023b648a0d0ce80ca101dc48f0
2b955a5ae12ca4b15f0c018243b99c78d5e79e40
Fix a typo, there => their
[ { "path": "docs/api/system-preferences.md", "patch": "@@ -18,7 +18,7 @@ The `systemPreferences` object emits the following events:\n Returns:\n \n * `event` Event\n-* `newColor` String - The new RGBA color the user assigned to be there system\n+* `newColor` String - The new RGBA color the user assigned to b...
2016-12-22T03:21:04
facebook/react
84d8e1841a72a94a2f2794aa941439a94c6c2df3
a9b3139ff8f4e36ce3971f1ea97e5712d03763d7
renamed ReactOnDOMReady module to ReactMountReady fix renamed ReactOnDOMReady module to ReactMountReady
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -579,7 +579,7 @@ var ReactCompositeComponentMixin = {\n mountDepth + 1\n );\n if (this.componentDidMount) {\n- transaction.getReactOnDOMReady().enqueue(this, this.componentDidMount);\n+ transaction.getReactMountR...
2013-10-05T06:18:34
nodejs/node
654dbd001b797f9d38f3267edef0ef3e8110df21
8700d89306cc4c1fd1a540d4b8f27a59f7b4957e
test: update tests for larger Buffers V8 is about to increase the max TypedArray length to 2**32-1, which Node inherits as Buffer.kMaxLength. Some tests relied on values greater than the previous max length (2**31-1) to throw errors; this updates those tests for the new max length. PR-URL: https://github.com/nodejs/n...
[ { "path": "test/parallel/test-buffer-alloc.js", "patch": "@@ -8,8 +8,8 @@ const SlowBuffer = require('buffer').SlowBuffer;\n // Verify the maximum Uint8Array size. There is no concrete limit by spec. The\n // internal limits should be updated if this fails.\n assert.throws(\n- () => new Uint8Array(2 ** 31)...
2020-01-20T15:51:02
vercel/next.js
dbf35a7fd436cd72174fb7dc22cd5c8d55774857
c60ecfcc1c10758ab6a336855e414bbec950d3da
Fix build restart log (#56543) ### Observed Issue ``` ⚠ Restarted collecting page data for [object Object] because it took more than 60 seconds ``` ### Fix The original issue is caused because the path is assigned to the `argument` array itself. Passing the argument type to the he worker, so in restart callback we're...
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -4,7 +4,11 @@ import type { PagesManifest } from './webpack/plugins/pages-manifest-plugin'\n import type { ExportPathMap, NextConfigComplete } from '../server/config-shared'\n import type { MiddlewareManifest } from './webpack/plugins/middleware-plu...
2023-10-07T22:17:10
golang/go
9a2001a8cc75b1ceda17da828edcee93c9d9f42c
5c8ec89cb53025bc76b242b0d2410bf5060b697e
cmd/dist: always pass -short=true with -quick Fixes #53818 Change-Id: I190a8bcf50d92b9c10e9980e630ebb362d8b19ec Reviewed-on: https://go-review.googlesource.com/c/go/+/417918 Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Re...
[ { "path": "src/cmd/dist/test.go", "patch": "@@ -542,7 +542,7 @@ func (t *tester) registerTests() {\n \t\t\tname: testName,\n \t\t\theading: \"GOMAXPROCS=2 runtime -cpu=1,2,4 -quick\",\n \t\t\tfn: func(dt *distTest) error {\n-\t\t\t\tcmd := t.addCmd(dt, \"src\", t.goTest(), t.timeout(300), \"runtime\", \"...
2022-07-16T23:08:35
electron/electron
3cfe94c5efa02ca948cee183cce9ac8ff87e2ac2
2b955a5ae12ca4b15f0c018243b99c78d5e79e40
Fixed link to Quick Start
[ { "path": "docs/tutorial/about.md", "patch": "@@ -6,7 +6,7 @@ Electron began in 2013 as the framework on which [Atom](https://atom.io), GitHub\n \n It has since become a popular tool used by open source developers, startups, and established companies. [See who is building on Electron](/apps).\n \n-Read on t...
2016-12-21T22:41:34
facebook/react
7c0f5c3237ddf0f3cbc12382bbe59b177075659a
f43449d333089b4e06088c832d86e47be7de6142
Fix isEventSupported in recent versions of jsdom. Setting the `eventName` attribute of an element to the empty string is not enough to cause `typeof element[eventName] === 'function'` in jsdom. The attribute value actually has to look like a function body.
[ { "path": "src/dom/isEventSupported.js", "patch": "@@ -54,7 +54,7 @@ function isEventSupported(eventNameSuffix, capture) {\n var isSupported = eventName in element;\n \n if (!isSupported) {\n- element.setAttribute(eventName, '');\n+ element.setAttribute(eventName, 'return;');\n isSupported = t...
2013-10-01T22:46:14
nodejs/node
8700d89306cc4c1fd1a540d4b8f27a59f7b4957e
1b3dbc9635d45c83e355d312b6114d58664b1e7a
http: fix socket re-use races Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can h...
[ { "path": "doc/api/http.md", "patch": "@@ -239,6 +239,9 @@ added: v0.11.4\n An object which contains arrays of sockets currently awaiting use by\n the agent when `keepAlive` is enabled. Do not modify.\n \n+Sockets in the `freeSockets` list will be automatically destroyed and\n+removed from the array on `'ti...
2020-02-28T21:27:39
golang/go
027855e8d86f461b50946b006ea032d4b4a7d817
462b78fe7027ef0d2e2b40c3cfd1f5a37d307310
os/exec: add GODEBUG setting to opt out of ErrDot changes The changes are likely to break users, and we need to make it easy to unbreak without code changes. For #43724. Fixes #53962. Change-Id: I105c5d6c801d354467e0cefd268189c18846858e Reviewed-on: https://go-review.googlesource.com/c/go/+/419794 Reviewed-by: Bryan...
[ { "path": "src/go/build/deps_test.go", "patch": "@@ -177,7 +177,11 @@ var depsRules = `\n \n \tos/signal, STR\n \t< path/filepath\n-\t< io/ioutil, os/exec;\n+\t< io/ioutil;\n+\n+\tos < internal/godebug;\n+\n+\tpath/filepath, internal/godebug < os/exec;\n \n \tio/ioutil, os/exec, os/signal\n \t< OS;\n@@ -187...
2022-07-27T18:36:05
electron/electron
ead5275d6389333125b5d95b06dc9eafdab3e166
4e8c21549b4cd26632b067a492c8f4c11791656d
fix heading level
[ { "path": "docs/glossary.md", "patch": "@@ -60,7 +60,7 @@ building native modules.\n \n See also [Using Native Node Modules].\n \n-# process\n+## process\n \n A process is an instance of a computer program that is being executed. Electron\n apps that make use of the [main] and one or many [renderer] process...
2016-11-04T18:28:46
nodejs/node
1b3dbc9635d45c83e355d312b6114d58664b1e7a
960be159ac3b21bf8a4f8c3bca7e733d483fb7d9
events: fix removeListener for Symbols Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () => { }; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) => { console.log('remove...
[ { "path": "lib/events.js", "patch": "@@ -31,7 +31,6 @@ const {\n ObjectDefineProperty,\n ObjectGetPrototypeOf,\n ObjectSetPrototypeOf,\n- ObjectKeys,\n Promise,\n PromiseReject,\n PromiseResolve,\n@@ -526,7 +525,7 @@ EventEmitter.prototype.removeAllListeners =\n \n // Emit removeListener ...
2020-02-18T14:35:08
vercel/next.js
c60ecfcc1c10758ab6a336855e414bbec950d3da
e039cc72fc09dcc5554bd7bdaa4e4eb8b0a11796
Ensure react-server-dom-turbopack-experimental uses the right package (#56560) Was investigating why Turbopack with `serverActions: true` sometimes crashes with a webpack specific error. Found it wasn't using the right package. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure you...
[ { "path": "package.json", "patch": "@@ -199,7 +199,7 @@\n \"react-dom-experimental-builtin\": \"npm:react-dom@0.0.0-experimental-d900fadbf-20230929\",\n \"react-experimental-builtin\": \"npm:react@0.0.0-experimental-d900fadbf-20230929\",\n \"react-server-dom-turbopack\": \"18.3.0-canary-d900fadb...
2023-10-07T17:37:58
nodejs/node
960be159ac3b21bf8a4f8c3bca7e733d483fb7d9
f69de13bfe1102ff53aa93d40045352441880704
stream: add comments to pipeline implementation Fixes: https://github.com/nodejs/node/issues/32039 PR-URL: https://github.com/nodejs/node/pull/32042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "lib/internal/streams/pipeline.js", "patch": "@@ -202,6 +202,11 @@ function pipeline(...streams) {\n PassThrough = require('_stream_passthrough');\n }\n \n+ // If the last argument to pipeline is not a stream\n+ // we must create a proxy stream so that pipeline(...)...
2020-03-02T11:44:42
vercel/next.js
e75c366826596a3bf9ccc6cf8e34e72ce7ab9ac2
542f080524cd19d3be7b37b0ccc12761d6d7247c
fix: don't add `isolateModules` to `tsconfig` when extending from tsconfig with `verbatimModuleSyntax` (#54164) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right check...
[ { "path": "packages/next/src/lib/typescript/writeConfigurationDefaults.ts", "patch": "@@ -20,7 +20,7 @@ type DesiredCompilerOptionsShape = {\n \n function getDesiredCompilerOptions(\n ts: typeof import('typescript'),\n- userTsConfig?: { compilerOptions?: CompilerOptions }\n+ tsOptions?: CompilerOptions\...
2023-10-07T14:38:56
nodejs/node
f69de13bfe1102ff53aa93d40045352441880704
6f0ec79e42c07357fe33f353e65d76856d922582
fs: fix writeFile[Sync] for non-seekable files Completely disables the use of positioned writes at writeFile and writeFileSync, which allows it to work with non-seekable files. Fixes: https://github.com/nodejs/node/issues/31926 PR-URL: https://github.com/nodejs/node/pull/32006 Reviewed-By: Anna Henningsen <anna@adda...
[ { "path": "lib/fs.js", "patch": "@@ -1248,9 +1248,9 @@ function futimesSync(fd, atime, mtime) {\n handleErrorFromBinding(ctx);\n }\n \n-function writeAll(fd, isUserFd, buffer, offset, length, position, callback) {\n+function writeAll(fd, isUserFd, buffer, offset, length, callback) {\n // write(fd, buffe...
2020-02-28T12:40:30
golang/go
c8d5ccf82ec24ff3855c1717d46df6a0c60684de
ac0844ec274bf6cfd64bc8fa1e2cc8b24c789dee
[dev.unified] go/internal/gcimporter: flatten imports The current documentation for go/types.(*Packages).Imports requires that the import graph be flattened when read from export data. I think this is a documentation bug (incorrectly codifying the existing behavior, rather than documenting it as a known bug), but unti...
[ { "path": "src/go/internal/gcimporter/ureader.go", "patch": "@@ -206,11 +206,41 @@ func (r *reader) doPkg() *types.Package {\n \tfor i := range imports {\n \t\timports[i] = r.pkg()\n \t}\n-\tpkg.SetImports(imports)\n+\n+\t// The documentation for (*types.Package).Imports requires\n+\t// flattening the impor...
2022-07-27T21:24:46
electron/electron
d20e2ec349fff465efb12da3c173598a3c31ad27
38681d0a2b1a1ba24ca9e42279a683cb39481730
[ci skip] fix link in screen docs
[ { "path": "docs/api/screen.md", "patch": "@@ -118,5 +118,5 @@ Returns [`Display`](structures/display.md) - The display nearest the specified p\n \n * `rect` [Rectangle](structures/rectangle.md)\n \n-Returns `Display`](structures/display.md) - The display that most closely\n+Returns [`Display`](structures/di...
2016-12-21T08:43:47
vercel/next.js
50dff9390268e402492db5a1bdc43ca781a94f43
67cd9146c63f2c3f4f4358193cc89a9aaf0d604b
Unsilence Taskr Webpack errors (#56542) Discovered while investigating https://github.com/vercel/next.js/pull/56526, turns out errors occuring during webpack builds do not fail the `pnpm build` which kicks off `taskr`. This is because `taskr` runs their plugins within coroutines, which based on the result, was not han...
[ { "path": "packages/next/taskfile-webpack.js", "patch": "@@ -1,35 +1,40 @@\n const webpack = require('webpack')\n \n module.exports = function (task) {\n+ // eslint-disable-next-line require-yield\n task.plugin('webpack', {}, function* (_, options) {\n options = options || {}\n \n const compiler ...
2023-10-06T23:38:18
nodejs/node
6f0ec79e42c07357fe33f353e65d76856d922582
86ab4ee6e49681fb4a9603128af4f6fa29806183
http,stream: make virtual methods throw an error Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it. The error is not recoverable and the only way to handle it is to override the method. PR-URL: https://github.com/nodejs/node/pull/31912 Refs: https://github.com/nodejs/node/pull/318...
[ { "path": "lib/_http_outgoing.js", "patch": "@@ -619,7 +619,7 @@ OutgoingMessage.prototype.removeHeader = function removeHeader(name) {\n \n \n OutgoingMessage.prototype._implicitHeader = function _implicitHeader() {\n- this.emit('error', new ERR_METHOD_NOT_IMPLEMENTED('_implicitHeader()'));\n+ throw new ...
2020-02-22T11:28:26
golang/go
462b78fe7027ef0d2e2b40c3cfd1f5a37d307310
055113ef364337607e3e72ed7d48df67fde6fc66
misc/cgo/test: use fewer threads in TestSetgidStress in long mode TestSetgidStress originally spawns 1000 threads for stress testing. It caused timeout on some builders so CL 415677 reduced to 50 in short mode. But it still causes flaky timeouts in longtest builders, so reduce the number of threads in long mode as wel...
[ { "path": "misc/cgo/test/setgid2_linux.go", "patch": "@@ -20,10 +20,7 @@ import (\n )\n \n func testSetgidStress(t *testing.T) {\n-\tvar N = 1000\n-\tif testing.Short() {\n-\t\tN = 50\n-\t}\n+\tconst N = 50\n \tch := make(chan int, N)\n \tfor i := 0; i < N; i++ {\n \t\tgo func() {", "additions": 1, ...
2022-07-27T16:59:16
vercel/next.js
67cd9146c63f2c3f4f4358193cc89a9aaf0d604b
edb92a30b5e7d5a10a64e2038699359317cad98f
fix: log error cause (#56528) ### What? While debugging #56456, I noticed that we cut useful information, namely the `Error` instances' [`cause` property](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause). ### Why? In #56456, it was hiding the following: ```sh Error: get...
[ { "path": "packages/next/src/server/dev/log-app-dir-error.ts", "patch": "@@ -1,7 +1,7 @@\n import isError from '../../lib/is-error'\n import * as Log from '../../build/output/log'\n \n-export function logAppDirError(err: any) {\n+export function logAppDirError(err: unknown) {\n if (isError(err) && err?.st...
2023-10-06T23:22:13
facebook/react
3ca507d73ffc07087ed4e95e010a101298f78146
84dea7e971adecbc9c5a06f6500fffb84065d943
Fix reconciling when switching to/from innerHTML There's no way that this can work if _updateDOMChildren doesn't know about dangerouslySetInnerHTML, so tell it. Fixes #377.
[ { "path": "src/core/ReactDOMIDOperations.js", "patch": "@@ -49,6 +49,8 @@ var INVALID_PROPERTY_ERRORS = {\n */\n var textContentAccessor = getTextContentAccessor() || 'NA';\n \n+var LEADING_SPACE = /^ /;\n+\n /**\n * Operations used to process updates to DOM nodes. This is made injectable via\n * `ReactC...
2013-09-27T06:52:58
nodejs/node
86ab4ee6e49681fb4a9603128af4f6fa29806183
434d39dd670845cafd122fadb0a75d72c1658b05
async_hooks: fix ctx loss after nested ALS calls PR-URL: https://github.com/nodejs/node/pull/32085 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
[ { "path": "lib/async_hooks.js", "patch": "@@ -255,23 +255,21 @@ class AsyncLocalStorage {\n resource[this.kResourceStore] = store;\n }\n \n- _exit() {\n- const resource = executionAsyncResource();\n- if (resource) {\n- resource[this.kResourceStore] = undefined;\n- }\n- }\n-\n runSync...
2020-03-04T11:57:56
golang/go
055113ef364337607e3e72ed7d48df67fde6fc66
424814615491c604e6a0945f33e5a7b779dc2be5
math/big: check buffer lengths in GobDecode In Float.GobDecode and Rat.GobDecode, check buffer sizes before indexing slices. Fixes #53871 Change-Id: I1b652c32c2bc7a0e8aa7620f7be9b2740c568b0a Reviewed-on: https://go-review.googlesource.com/c/go/+/417774 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Tati...
[ { "path": "src/math/big/floatmarsh.go", "patch": "@@ -8,6 +8,7 @@ package big\n \n import (\n \t\"encoding/binary\"\n+\t\"errors\"\n \t\"fmt\"\n )\n \n@@ -67,6 +68,9 @@ func (z *Float) GobDecode(buf []byte) error {\n \t\t*z = Float{}\n \t\treturn nil\n \t}\n+\tif len(buf) < 6 {\n+\t\treturn errors.New(\"Flo...
2022-07-15T17:43:44
vercel/next.js
8f017cf91bd8d710549943fc5a3b00e5637c84c8
ecfc3ffa9db2ac125cba24202e546fae2567f853
Ensure process.env.TURBOPACK is always set (vercel/turbo#6116) ### Description Related to https://github.com/vercel/next.js/pull/56496. Server Actions currently shows an error as it seems to use the react-dom-webpack version instead of react-dom-turbopack. This seems to be caused by the changes in https://github...
[ { "path": "crates/turbopack-cli/src/contexts.rs", "patch": "@@ -177,6 +177,7 @@ pub fn get_client_asset_context(\n fn client_defines(node_env: &NodeEnv) -> Vc<CompileTimeDefines> {\n compile_time_defines!(\n process.turbopack = true,\n+ process.env.TURBOPACK = true,\n process.env....
2023-10-06T16:46:48
facebook/react
94d2bbb2214f3d88ac6cc1b1c48a59b377222727
84dea7e971adecbc9c5a06f6500fffb84065d943
Fix lint errors including use of `global`
[ { "path": "src/core/ReactDOMSelection.js", "patch": "@@ -57,7 +57,7 @@ function getIESelection(node) {\n * @param {DOMElement} node\n */\n function getModernSelection(node) {\n- var selection = global.getSelection();\n+ var selection = window.getSelection();\n var anchorNode = selection.anchorNode;\n ...
2013-09-25T21:48:23
nodejs/node
b6cd2155c3442a8c56aa6f6ffa0dc9b6a308a7b1
5cc0754090b4dc504652ea57803312c9b9f1cef0
doc: remove em dashes Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together ...
[ { "path": "CHANGELOG.md", "patch": "@@ -2,19 +2,19 @@\n \n Select a Node.js version below to view the changelog history:\n \n-* [Node.js 13](doc/changelogs/CHANGELOG_V13.md) - **Current**\n-* [Node.js 12](doc/changelogs/CHANGELOG_V12.md) - **Long Term Support**\n-* [Node.js 11](doc/changelogs/CHANGELOG_V11....
2020-03-04T05:23:59
rust-lang/rust
0f98da7c5ccb5e873ddc08aef7508213a98b6aaa
94b703588e1da6b7492375575da92c2859a3c39b
fix: let_with_type_underscore don't eat closing paren in let (i): _ = 0; add failing tests fix also remove whitespace before `:`
[ { "path": "clippy_lints/src/let_with_type_underscore.rs", "patch": "@@ -1,5 +1,6 @@\n use clippy_utils::diagnostics::span_lint_and_then;\n use clippy_utils::is_from_proc_macro;\n+use clippy_utils::source::{IntoSpan, SpanRangeExt};\n use rustc_errors::Applicability;\n use rustc_hir::{LetStmt, TyKind};\n use ...
2025-08-02T07:13:16
electron/electron
2e1feb63e47686a170bdcd2eaef2dc23e618d231
78a89c666bef8dbfbf202fdfc8ca7973a0117420
Corrected some grammatical errors
[ { "path": "docs/api/browser-window.md", "patch": "@@ -30,8 +30,7 @@ you can use the [Frameless Window](frameless-window.md) API.\n \n ## Showing window gracefully\n \n-When loading a page in window directly, users will see the progress of loading\n-page, which is not good experience for native app. To make ...
2016-12-20T03:01:35
facebook/react
84dea7e971adecbc9c5a06f6500fffb84065d943
781bbe2916e8f593eb8a40ab526611b3d5b53e6e
Fix server rendering
[ { "path": "src/core/ReactDOMSelection.js", "patch": "@@ -149,13 +149,19 @@ var ReactDOMSelection = {\n /**\n * @param {DOMElement} node\n */\n- get: document.selection ? getIESelection : getModernSelection,\n+ get: function(node) {\n+ var getSelection = document.selection ? getIESelection : get...
2013-09-26T22:49:03
golang/go
faf4e97200df9415d55b04924ce77599f9e6fdfa
caa225dd297a467b0d720d5f1d63050e49061ad3
net: fix WriteMsgUDPAddrPort addr handling WriteMsgUDPAddrPort should accept IPv4 target addresses on IPv6 UDP sockets. An IPv4 target address will be converted to an IPv4-mapped IPv6 address. Fixes #52264. Change-Id: Ib9ed4c61fa1289ae7bbc8c4c9de1a9951b647ec0 GitHub-Last-Rev: 6776fdb0a76faa71ebde58f5143fb1ffb3112adf...
[ { "path": "src/net/ipsock_posix.go", "patch": "@@ -215,8 +215,12 @@ func addrPortToSockaddrInet4(ap netip.AddrPort) (syscall.SockaddrInet4, error) {\n func addrPortToSockaddrInet6(ap netip.AddrPort) (syscall.SockaddrInet6, error) {\n \t// ipToSockaddrInet6 has special handling here for zero length slices.\n...
2022-04-29T17:29:58
vercel/next.js
bc15b5803cd554629b065b52c7c3b93a651b0da5
61122ebc404551bae80a9f975604a27020f4229c
misc: fix wrong next start start duration (#56512) This PR fixes `next start` and `next dev` so that they show the correct server boot-up time. The previous way of computing the start time was incorrect and misleading as it did not start exactly when next started. Before: > ✓ Ready in 120ms After: > ✓ Ready in 286ms
[ { "path": "packages/next/src/bin/next.ts", "patch": "@@ -1,4 +1,5 @@\n #!/usr/bin/env node\n+performance.mark('next-start')\n import '../server/require-hook'\n import * as log from '../build/output/log'\n import arg from 'next/dist/compiled/arg/index.js'", "additions": 1, "deletions": 0, "langua...
2023-10-06T14:57:59
nodejs/node
5cc0754090b4dc504652ea57803312c9b9f1cef0
c3c64a1034a52e58c9684a0135a2e4ce536e41ef
benchmark: remove problematic tls params These very small values can cause crashes/exceptions to occur on some systems because most time is spent in V8 GC or in parts of node core that are not being tested (e.g. streams). PR-URL: https://github.com/nodejs/node/pull/31816 Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "benchmark/tls/secure-pair.js", "patch": "@@ -3,7 +3,7 @@ const common = require('../common.js');\n const bench = common.createBenchmark(main, {\n dur: [5],\n securing: ['SecurePair', 'TLSSocket', 'clear'],\n- size: [2, 100, 1024, 1024 * 1024]\n+ size: [100, 1024, 1024 * 1024]\n });\n \n con...
2020-02-16T08:50:01
facebook/react
fc0b68af287e7c26a377e866ee83617aa1a8b3d5
c6f831e85f13496993ddcb54f35ba936a87b691d
Fix 404s to non-existent API docs
[ { "path": "docs/_posts/2013-07-23-community-roundup-5.md", "patch": "@@ -96,4 +96,4 @@ React.renderComponent(\n > * [Working With the Browser](/react/docs/working-with-the-browser.html)\n > * [More About Refs](/react/docs/more-about-refs.html)\n > * [Tooling integration](/react/docs/tooling-integration.ht...
2013-09-24T23:00:52
electron/electron
9e626c5fee45152de91475bdcbab2344ea3d62b8
78a89c666bef8dbfbf202fdfc8ca7973a0117420
fix relative link to CertificatePrincipal doc
[ { "path": "docs/api/structures/certificate.md", "patch": "@@ -1,10 +1,10 @@\n # Certificate Object\n \n * `data` String - PEM encoded data\n-* `issuer` [CertificatePrincipal](structures/certificate-principal.md) - Issuer principal\n+* `issuer` [CertificatePrincipal](certificate-principal.md) - Issuer princi...
2016-12-19T21:49:02
golang/go
ceefd3a37bb2a77b1e9a76fc74360c68ef16ddb8
3e97294663d978bf8abb7acec7cc615ef2f1ea75
bytes: document that Reader.Reset affects the result of Size The Reader.Reset changes the underlying byte slice, so it actually changes the return value of the Size method. Fixes #54018 Change-Id: I160deaa2244e95cb93303cb5dfb67a8d90a375ef GitHub-Last-Rev: b04724a072d956db1f84a8f5db0afa0dbb158e96 GitHub-Pull-Request:...
[ { "path": "src/bytes/reader.go", "patch": "@@ -32,8 +32,7 @@ func (r *Reader) Len() int {\n \n // Size returns the original length of the underlying byte slice.\n // Size is the number of bytes available for reading via ReadAt.\n-// The returned value is always the same and is not affected by calls\n-// to ...
2022-07-24T21:44:11
vercel/next.js
61122ebc404551bae80a9f975604a27020f4229c
5aca71cfa6c5e46d874ec1dce3b334e6bbea65d0
Improve failed to fetch RSC error (#56517) Ensures the specific URL that failed is highlighted in this error. Useful for debugging when the fetch fails.
[ { "path": "packages/next/src/client/components/router-reducer/fetch-server-response.ts", "patch": "@@ -145,7 +145,7 @@ export async function fetchServerResponse(\n return [flightData, canonicalUrl]\n } catch (err) {\n console.error(\n- 'Failed to fetch RSC payload. Falling back to browser nav...
2023-10-06T14:14:40
rust-lang/rust
4b24c4bf23df8ae5c53669e3209b9f3074769b69
77f75f91c5822c3c83f55317b76330153859a12a
Tweak rendering of cfg'd out item ``` error[E0433]: failed to resolve: could not find `doesnt_exist` in `inner` --> $DIR/diagnostics-cross-crate.rs:18:23 | LL | cfged_out::inner::doesnt_exist::hello(); | ^^^^^^^^^^^^ could not find `doesnt_exist` in `inner` | note: found an item th...
[ { "path": "compiler/rustc_resolve/src/diagnostics.rs", "patch": "@@ -2845,16 +2845,13 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {\n continue;\n }\n \n- let note = errors::FoundItemConfigureOut { span: ident.span };\n- err.subdiagnostic(note);\n-\n- i...
2025-08-01T23:58:15
nodejs/node
9ec87815027ddf6782ab930975b86333a61ed554
b1d4c13430c92e94920f0c8c9ba1295c075c9e89
crypto: make update(buf, enc) ignore encoding Make the cipher/decipher/hash/hmac update() methods ignore the input encoding when the input is a buffer. This is the documented behavior but some inputs were rejected, notably when the specified encoding is 'hex' and the buffer has an odd length (because a _string_ with ...
[ { "path": "lib/internal/crypto/cipher.js", "patch": "@@ -151,13 +151,13 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding) {\n inputEncoding = inputEncoding || encoding;\n outputEncoding = outputEncoding || encoding;\n \n- if (typeof data !== 'string' && !isArrayBufferVie...
2020-02-13T11:05:18
facebook/react
458836abd3e74fce7addfef3749391176cc72085
5d7633d74cc79d6bb6498c9dd57d62b6718648e2
Fix use of 'window' in CompositionEventPlugin access to `window` needs to be guarded by `ExecutionEnvironment.canUseDOM`.
[ { "path": "src/eventPlugins/CompositionEventPlugin.js", "patch": "@@ -21,6 +21,7 @@\n \n var EventConstants = require('EventConstants');\n var EventPropagators = require('EventPropagators');\n+var ExecutionEnvironment = require('ExecutionEnvironment');\n var ReactInputSelection = require('ReactInputSelectio...
2013-09-24T06:00:54
electron/electron
e2bb8088d4dd3e1bd0a42c30d70e58c49ffc1ca1
2a8b36c761bea11b2fd16eafc46bf6b47dfa99fd
[ci skip]update electron-faq.md in Simplified Chinese docs and fix a little words
[ { "path": "docs-translations/zh-CN/README.md", "patch": "@@ -6,7 +6,7 @@\n \n 这里是一些被经常问到的问题,再提 issue 之前请先看一下这里。\n \n-+ [Electron 常见问题](faq/electron-faq.md) 需要更新\n++ [Electron 常见问题](faq/electron-faq.md)\n \n ## 向导\n \n@@ -83,7 +83,7 @@\n ## 开发\n \n * [代码规范](development/coding-style.md)\n-* [在 C++ 代码中试用 clang...
2016-12-19T07:01:50
golang/go
3e97294663d978bf8abb7acec7cc615ef2f1ea75
24dc27a3c084b901ee456637541ea818495888b0
runtime/cgo: use frame address to set g0 stack bound For a cgo binary, at startup we set g0's stack bounds using the address of a local variable (&size) in a C function x_cgo_init and the stack size from pthread_attr_getstacksize. Normally, &size is an address within the current stack frame. However, when it is compi...
[ { "path": "src/runtime/cgo/gcc_linux_amd64.c", "patch": "@@ -44,7 +44,9 @@ x_cgo_init(G *g, void (*setg)(void*), void **tlsg, void **tlsbase)\n \t}\n \tpthread_attr_init(attr);\n \tpthread_attr_getstacksize(attr, &size);\n-\tg->stacklo = (uintptr)&size - size + 4096;\n+\tg->stacklo = (uintptr)__builtin_fram...
2022-07-25T15:02:56