repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
bfdb349ebadced0346aa5b9c017851a166c493f6
f95421289f3fd399f360a372c4a5bc5e2b1a0cd8
Remove ServerDirectiveTransformer (#56496) As discussed with @jridgewell this removes the hard error when using `"use server"` in Turbopack. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sectio...
[ { "path": "packages/next-swc/crates/next-core/src/next_client/context.rs", "patch": "@@ -19,7 +19,6 @@ use turbopack_binding::{\n },\n dev::{react_refresh::assert_can_resolve_react_refresh, DevChunkingContext},\n ecmascript::chunk::EcmascriptChunkingContext,\n- ecmascript_plug...
2023-10-06T09:16:57
rust-lang/rust
adcda6ca9a6d27c04399e3efe1c67fc6ff04d997
e5e79f8bd428d0b8d26e8240d718b134ef297459
Detect more `cfg`d out items in resolution errors Use a visitor to collect *all* items (including those nested) that were stripped behind a `cfg` condition. ``` error[E0425]: cannot find function `f` in this scope --> $DIR/nested-cfg-attrs.rs:4:13 | LL | fn main() { f() } | ^ not found in this sco...
[ { "path": "compiler/rustc_expand/src/expand.rs", "patch": "@@ -1399,25 +1399,35 @@ impl InvocationCollectorNode for P<ast::Item> {\n }\n \n fn declared_idents(&self) -> Vec<Ident> {\n- if let ItemKind::Use(ut) = &self.kind {\n- fn collect_use_tree_leaves(ut: &ast::UseTree, idents: ...
2024-08-17T05:45:10
nodejs/node
b1d4c13430c92e94920f0c8c9ba1295c075c9e89
616a729b3837c6152da6bb7f7c06aecbbdaa2696
test: add coverage for FSWatcher exception Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.ara...
[ { "path": "test/sequential/test-fs-watch.js", "patch": "@@ -125,9 +125,31 @@ tmpdir.refresh();\n w.close();\n },\n {\n+ name: 'Error',\n+ code: 'ERR_INTERNAL_ASSERTION',\n message: /^handle must be a FSEvent/,\n+ }\n+ );\n+ oldhandle.close(); // clean up\n+}\n+\n+{\n+ let...
2020-03-01T00:19:17
facebook/react
d13ce702a8346b72bf6461cb1da52d08d39a2d4a
d262285827d244a058319e9607f63c9e74e9fbb0
Fix typo in doc
[ { "path": "docs/docs/07.1-more-about-refs.md", "patch": "@@ -39,7 +39,7 @@ Consider the case when you wish to tell an `<input />` element (that exists with\n ```\n \n \n-Notice how, in this example, we want to \"tell\" the input something - something that it cannot infer from its props over time. In this ca...
2013-09-22T22:09:36
electron/electron
b85367113260145c1620984e555c3dbe9cde0b95
00d9baa605bc57bc180aee23236daa5e876c38d9
fix fullscreen, maximize, unmaximize
[ { "path": "atom/browser/native_window_views.cc", "patch": "@@ -425,7 +425,7 @@ bool NativeWindowViews::IsEnabled() {\n void NativeWindowViews::Maximize() {\n #if defined(OS_WIN)\n // For window without WS_THICKFRAME style, we can not call Maximize().\n- if (!thick_frame_) {\n+ if (!(::GetWindowLong(GetA...
2016-12-15T06:01:03
golang/go
24dc27a3c084b901ee456637541ea818495888b0
9fcc8b2c1eeb2333751d80626e4204d304c8b3c6
cmd/compile: fix blank label code When checkEnabled is forced true, the 52278 test fails. Be a bit more careful about processing blank labels. Update #52278 Change-Id: I48aa89e2c9e3715d8efe599bc4363b5b5879d8a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/419318 Run-TryBot: Keith Randall <khr@golang.org> Tr...
[ { "path": "src/cmd/compile/internal/ssagen/ssa.go", "patch": "@@ -1496,6 +1496,10 @@ func (s *state) stmt(n ir.Node) {\n \tcase ir.OLABEL:\n \t\tn := n.(*ir.LabelStmt)\n \t\tsym := n.Label\n+\t\tif sym.IsBlank() {\n+\t\t\t// Nothing to do because the label isn't targetable. See issue 52278.\n+\t\t\tbreak\n+...
2022-07-24T16:48:56
vercel/next.js
f95421289f3fd399f360a372c4a5bc5e2b1a0cd8
5a49b88fb9a4a773703c0ab82f107d72e3f5cabe
Remove isTurbo check in custom-routes test (#56360) This variable wasn't used anymore. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) t...
[ { "path": "test/integration/custom-routes/test/index.test.js", "patch": "@@ -38,7 +38,7 @@ let buildId\n let appPort\n let app\n \n-const runTests = (isDev = false, isTurbo = false) => {\n+const runTests = (isDev = false) => {\n it.each([\n {\n path: '/to-ANOTHER',\n@@ -78,9 +78,6 @@ const runTe...
2023-10-06T09:10:12
rust-lang/rust
f516d4c9e341847d8f452adef68fe99cfdcfccc0
4b55fe199cfe9c710555a5af7f2a49491ad38254
rustdoc font links only emit `crossorigin` when needed The `crossorigin` attribute may cause issues when the href is not actuall across origins. Specifically, the tag causes the browser to send a preflight OPTIONS request to the href even if it is same-origin. Some tempermental servers may reject all CORS preflect req...
[ { "path": "src/librustdoc/html/layout.rs", "patch": "@@ -8,6 +8,9 @@ use super::static_files::{STATIC_FILES, StaticFiles};\n use crate::externalfiles::ExternalHtml;\n use crate::html::render::{StylePath, ensure_trailing_slash};\n \n+#[cfg(test)]\n+mod tests;\n+\n pub(crate) struct Layout {\n pub(crate) ...
2025-07-25T20:21:50
nodejs/node
787143bf3e3a96bed9da17c453c8f77e016fd1b1
213047489002d3f7f7a8cc8a12d64ecf99723b82
src: pass resource object along with InternalMakeCallback This was an oversight in 9fdb6e6aaf45b2364bac89a. Fixing this is necessary to make `executionAsyncResource()` work as expected. Refs: https://github.com/nodejs/node/pull/30959 Fixes: https://github.com/nodejs/node/issues/32060 PR-URL: https://github.com/nodej...
[ { "path": "src/api/callback.cc", "patch": "@@ -139,6 +139,7 @@ void InternalCallbackScope::Close() {\n }\n \n MaybeLocal<Value> InternalMakeCallback(Environment* env,\n+ Local<Object> resource,\n Local<Object> recv,\n ...
2020-03-03T10:29:06
facebook/react
d262285827d244a058319e9607f63c9e74e9fbb0
b5a11a431e3f6d2d431422ecd70fb57729c123b5
Fix use of "it's" in docs
[ { "path": "docs/_posts/2013-07-17-react-v0-4-0.md", "patch": "@@ -24,7 +24,7 @@ When you're ready, [go download it](/react/downloads.html)!\n * Removed `React.autoBind`. [Read our blog post for details...](http://facebook.github.io/react/blog/2013/07/02/react-v0-4-autobind-by-default.html)\n * Improvements ...
2013-09-22T20:24:25
golang/go
9fcc8b2c1eeb2333751d80626e4204d304c8b3c6
795a88d0c383fae04242632449518a5985d50973
runtime: fix runtime.Breakpoint() on windows/arm64 Fixes #53837 Change-Id: I4219fe35aac1a88aae2905998fbb1d7db87bbfb2 Reviewed-on: https://go-review.googlesource.com/c/go/+/418734 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Alessandro Arzilli <alessandro.ar...
[ { "path": "src/runtime/asm_arm64.s", "patch": "@@ -107,8 +107,18 @@ nocgo:\n DATA\truntime·mainPC+0(SB)/8,$runtime·main<ABIInternal>(SB)\n GLOBL\truntime·mainPC(SB),RODATA,$8\n \n+// Windows ARM64 needs an immediate 0xf000 argument.\n+// See go.dev/issues/53837.\n+#define BREAK\t\\\n+#ifdef GOOS_windows\t\\...
2022-07-21T10:18:51
vercel/next.js
5a49b88fb9a4a773703c0ab82f107d72e3f5cabe
2a479316ea4f28b4e9f48c8babf5dcabae2fb164
Use consistent name for App Router tests (#56352) Ensures all App Router tests have a unique name and similar reference (with `-`). <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below....
[ { "path": "test/e2e/app-dir/app-css-pageextensions/index.test.ts", "patch": "@@ -1,7 +1,7 @@\n import { createNextDescribe } from 'e2e-utils'\n \n createNextDescribe(\n- 'app dir css with pageextensions',\n+ 'app dir - css with pageextensions',\n {\n files: __dirname,\n skipDeployment: true,", ...
2023-10-06T09:06:06
nodejs/node
213047489002d3f7f7a8cc8a12d64ecf99723b82
75466869fb6e1dd09b36dc2b44ef8748ecc6e7de
build: fix zlib tarball generation PR-URL: https://github.com/nodejs/node/pull/32094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
[ { "path": "Makefile", "patch": "@@ -1032,7 +1032,6 @@ $(TARBALL): release-only $(NODE_EXE) doc\n \t$(RM) -r $(TARNAME)/deps/v8/samples\n \t$(RM) -r $(TARNAME)/deps/v8/tools/profviz\n \t$(RM) -r $(TARNAME)/deps/v8/tools/run-tests.py\n-\t$(RM) -r $(TARNAME)/deps/zlib/contrib # too big, unused\n \t$(RM) -r $(T...
2020-03-04T19:11:37
rust-lang/rust
4c7c9de8acc7abc1788d6134716f3aeff8616300
4b55fe199cfe9c710555a5af7f2a49491ad38254
Fix safety comment for new_unchecked in niche_types
[ { "path": "library/core/src/num/niche_types.rs", "patch": "@@ -46,11 +46,11 @@ macro_rules! define_valid_range_type {\n /// primitive without checking whether its zero.\n ///\n /// # Safety\n- /// Immediate language UB if `val == 0`, as it violates the validity...
2025-08-01T20:55:18
electron/electron
a3b65ad48157e5f50f056de1fc05e9c1a507e3c3
3290c6b335a4a98a6a6c17319eb0f065d50e9e8a
Add before-input-event event for webContents (fixes #7586) Embedding arbitrary web content is problematic when it comes to keyboard shortcuts because: * Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408) * Blocked web content (e.g. a focused <webview> performing expensive computation) will also...
[ { "path": "atom/browser/api/atom_api_web_contents.cc", "patch": "@@ -70,6 +70,7 @@\n #include \"third_party/WebKit/public/web/WebFindOptions.h\"\n #include \"third_party/WebKit/public/web/WebInputEvent.h\"\n #include \"ui/display/screen.h\"\n+#include \"ui/events/keycodes/dom/keycode_converter.h\"\n \n #if ...
2016-12-06T22:41:18
golang/go
795a88d0c383fae04242632449518a5985d50973
9eb3992dddb561001f27ddf0c0d9e29d8d295f66
cmd/go: add space after comma in 'go help test' This PR fixes a simple typo. It adds a space after a comma. Noticed while looking at `go help test` output. Change-Id: I5b54f4da0d08a056bffc04899983d858dfa91043 GitHub-Last-Rev: da9cab5eb946523b8783aafe4f05f516e4a77437 GitHub-Pull-Request: golang/go#53931 Reviewed-on: h...
[ { "path": "src/cmd/go/alldocs.go", "patch": "@@ -1708,7 +1708,7 @@\n // the package's source root (usually $GOPATH) or that consult environment\n // variables only match future runs in which the files and environment\n // variables are unchanged. A cached test result is treated as executing\n-// in no time ...
2022-07-20T14:20:41
facebook/react
ea0cde2cf440a28733cd6511a3649b4de6405a58
e5ba82a44b2f3badf29312c47a7bb80e978d4e46
Fix PropTypes Documentation
[ { "path": "src/core/ReactPropTypes.js", "patch": "@@ -42,7 +42,7 @@ var invariant = require('invariant');\n *\n * A more formal specification of how these methods are used:\n *\n- * type := array|bool|object|number|string|oneOf([...])|instanceOf(...)\n+ * type := array|bool|func|object|number|string|...
2013-09-17T21:29:06
vercel/next.js
2a479316ea4f28b4e9f48c8babf5dcabae2fb164
c95e4b7841bda8aebc919da261dd008619e40d88
Remove app dir warning test (#56350) This test was failing in Turbopack because the option no longer exists. Fine to remove it for now. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections be...
[ { "path": "test/integration/config-experimental-warning/test/index.test.js", "patch": "@@ -19,17 +19,6 @@ async function collectStdout(appDir) {\n return stdout\n }\n \n-async function collectStderr(appDir) {\n- let stderr = ''\n- const port = await findPort()\n- app = await launchApp(appDir, port, {\n...
2023-10-06T09:05:45
nodejs/node
37287d3f5819daabade7b8ade81c4265bd596edf
bf7409e9740ce602b09e088aac70b7c817f5d27c
doc: visibility of Worker threads cli options Fixes: https://github.com/nodejs/node/issues/28518 PR-URL: https://github.com/nodejs/node/pull/31380 Fixes: https://github.com/nodejs/node/issues/28518 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/worker_threads.md", "patch": "@@ -55,6 +55,10 @@ correlation between tasks and their outcomes. See\n [\"Using `AsyncResource` for a `Worker` thread pool\"][async-resource-worker-pool]\n in the `async_hooks` documentation for an example implementation.\n \n+Worker threads inherit non-proce...
2020-01-16T12:25:22
rust-lang/rust
ae2f8d921654f01e008824385fb1e1d7b36ce705
6c02dd4eae83befde07dc4782395e2005055e9fa
Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standar...
[ { "path": "compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs", "patch": "@@ -374,11 +374,3 @@ impl<S: Stage> CombineAttributeParser<S> for TargetFeatureParser {\n features\n }\n }\n-\n-pub(crate) struct OmitGdbPrettyPrinterSectionParser;\n-\n-impl<S: Stage> NoArgsAttributeParser<S> for...
2025-07-31T14:56:49
facebook/react
e5ba82a44b2f3badf29312c47a7bb80e978d4e46
735223fc9fe29dfd3083bca64bc3a81cecb11bca
Fix DOM node warning bdf2a9bb124b8fc34120949b322202497741f239 broke the warning that children aren't suppose to be real DOM nodes.
[ { "path": "src/utils/traverseAllChildren.js", "patch": "@@ -74,7 +74,7 @@ var traverseAllChildrenImpl =\n } else {\n if (type === 'object') {\n invariant(\n- children || children.nodeType !== 1,\n+ !children || children.nodeType !== 1,\n 'traverseAll...
2013-09-17T21:28:43
golang/go
9eb3992dddb561001f27ddf0c0d9e29d8d295f66
dcea1ee6e3b805c2967950d48fddff5c69d2af85
doc/go1.19: minor fixes EM_LONGARCH and R_LARCH_* are defined in package debug/elf. Change the definition list title accordingly. Format links sort.Find and sort.Search as code. Add a link to syscall.Getrusage. Change-Id: I30602baedda8ccac028101858a608f1d8ffb633b Reviewed-on: https://go-review.googlesource.com/c/go...
[ { "path": "doc/go1.19.html", "patch": "@@ -471,14 +471,14 @@ <h3 id=\"minor_library_changes\">Minor changes to the library</h3>\n </dd>\n </dl><!-- crypto/x509/pkix -->\n \n-<dl id=\"debug\"><dt><a href=\"/pkg/debug/\">debug</a></dt>\n+<dl id=\"debug/elf\"><dt><a href=\"/pkg/debug/elf\">debug/elf</a></dt>...
2022-07-22T21:35:41
vercel/next.js
c95e4b7841bda8aebc919da261dd008619e40d88
2af1e784c290eba505b2de76ab0e83eb110cf30e
update turbopack, fix sass peer dependency (#56508) * https://github.com/vercel/turbo/pull/6076 <!-- Tobias Koppers - Performance Improvements (5) !--> Closes WEB-1725
[ { "path": "Cargo.lock", "patch": "@@ -321,7 +321,7 @@ dependencies = [\n [[package]]\n name = \"auto-hash-map\"\n version = \"0.1.0\"\n-source = \"git+https://github.com/vercel/turbo.git?tag=turbopack-231006.1#59ac1533324bfac62e75d759dd6cdee0f44a0b96\"\n+source = \"git+https://github.com/vercel/turbo.git?ta...
2023-10-06T08:59:43
nodejs/node
bf7409e9740ce602b09e088aac70b7c817f5d27c
de6cbd0e374e3d9209ddf56d1041b83b41efcbe6
doc: improve doc/markdown file organization coherence * Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the fil...
[ { "path": "CONTRIBUTING.md", "patch": "@@ -5,13 +5,13 @@\n * [Pull Requests](#pull-requests)\n * [Developer's Certificate of Origin 1.1](#developers-certificate-of-origin)\n \n-## [Code of Conduct](./doc/guides/contributing/coc.md)\n+## [Code of Conduct](./doc/guides/contributing/code-of-conduct.md)\n \n Th...
2020-02-14T12:54:11
facebook/react
ed7fa0ed225522009e5560dac08fcff356e2098f
3e4302e6aeced51d3d36a47517ce26835960d4d2
Stop ReactInputSelection breaking in IE8 In the IE code path the method assumed that the input.value property was non-null. A quick fix is to use either value or innerText; which means the same code can be shared for textarea and contentEditable components. The code is slightly buggy because the range.parentElement()...
[ { "path": "src/core/ReactInputSelection.js", "patch": "@@ -18,6 +18,8 @@\n \n \"use strict\";\n \n+var getTextContentAccessor = require('getTextContentAccessor');\n+\n // It is not safe to read the document.activeElement property in IE if there's\n // nothing focused.\n function getActiveElement() {\n@@ -80...
2013-09-14T12:59:25
rust-lang/rust
1a64684b0421d9e7090c0f805ef7637d0d6789ba
4b55fe199cfe9c710555a5af7f2a49491ad38254
LLVM error with unsupported expression in static initializer for const pointer in array on macOS
[ { "path": "tests/ui/codegen/unsupported-static-initializer-in-const-array.rs", "patch": "@@ -0,0 +1,18 @@\n+//! LLVM error with unsupported expression in static\n+//! initializer for const pointer in array on macOS.\n+//!\n+//! Regression test for <https://github.com/rust-lang/rust/issues/89225>.\n+\n+//@ b...
2025-08-01T14:04:58
golang/go
37c8112b825a2c60d1b3776c0b4f4c643391d490
850d547d2de9044eb84ba65ceefb90880f3a776c
internal/fuzz: fix typo in function comments The correct word to use here is 'retrieve' not 'retrive' Change-Id: I8de0961a254cf429ddbaf599fe996155e24c7af2 GitHub-Last-Rev: 65aaeec8db14c23e7bc8a62ce9ecfde98a263a49 GitHub-Pull-Request: golang/go#54026 Reviewed-on: https://go-review.googlesource.com/c/go/+/419317 Review...
[ { "path": "src/internal/fuzz/mem.go", "patch": "@@ -50,7 +50,7 @@ type sharedMemHeader struct {\n \t// rawInMem is true if the region holds raw bytes, which occurs during\n \t// minimization. If true after the worker fails during minimization, this\n \t// indicates that an unrecoverable error occurred, and ...
2022-07-24T15:05:37
vercel/next.js
6c9540cbfc30f8181caf80fdfeb37da376209ee9
cce85300a6384c6a9111d8ad6e1817a8e8d98d0f
Performance Improvements (5) (vercel/turbo#6076) ### Description The `AsyncModule` code generation in every ESM flags it as "needs availability info" which causes code generation to be duplicated for each entrypoints. This improves it a little bit by checking is the module is an async module before. It also f...
[ { "path": "crates/turbo-tasks/src/manager.rs", "patch": "@@ -410,7 +410,7 @@ impl<B: Backend + 'static> TurboTasks<B> {\n /// Calls a native function with arguments. Resolves arguments when needed\n /// with a wrapper [Task].\n pub fn dynamic_call(&self, func: FunctionId, inputs: Vec<ConcreteTas...
2023-10-06T06:28:51
nodejs/node
de6cbd0e374e3d9209ddf56d1041b83b41efcbe6
8429295c5b2bf3eb52a5b57eaceaffc3158a0c4a
build: fix building with ninja The ninja build places objects in a different directory. Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32071 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gabriel ...
[ { "path": "node.gyp", "patch": "@@ -251,6 +251,11 @@\n 'node_mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)node_mksnapshot<(EXECUTABLE_SUFFIX)',\n 'mkcodecache_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkcodecache<(EXECUTABLE_SUFFIX)',\n 'conditions': [\n+ ['GENERATOR == \"ninja\"'...
2020-03-03T20:02:02
rust-lang/rust
7d167260ca00ab7778d3198d9b34fbb3fd95d1e4
053f68151b8e6fb079b6a9254699d5a46220e52f
Fix more docs
[ { "path": "src/tools/rust-analyzer/docs/book/src/contributing/style.md", "patch": "@@ -49,8 +49,8 @@ In this case, we'll probably ask you to split API changes into a separate PR.\n Changes of the third group should be pretty rare, so we don't specify any specific process for them.\n That said, adding an inn...
2025-08-01T05:33:01
golang/go
850d547d2de9044eb84ba65ceefb90880f3a776c
64f2829c9cdf12b893068305b2451c81b0a5b3a6
doc/go1.19: expand crypto release notes Not included are the following changes that were backported to Go 1.18 minor releases. bb1f441618 crypto/rand: properly handle large Read on windows 35998c0109 crypto/x509: only disable SHA-1 verification for certificates 0fca8a8f25 crypto/x509: fix Certificate.Verify crash fe4...
[ { "path": "doc/go1.19.html", "patch": "@@ -322,16 +322,58 @@ <h3 id=\"minor_library_changes\">Minor changes to the library</h3>\n </dd>\n </dl><!-- archive/zip -->\n \n+<dl id=\"crypto/elliptic\"><dt><a href=\"/pkg/crypto/elliptic/\">crypto/elliptic</a></dt>\n+ <dd>\n+ <p><!-- CL 382995 -->\n+ Op...
2022-07-24T13:48:29
facebook/react
3e4302e6aeced51d3d36a47517ce26835960d4d2
1a38cb9e07cc904f079ab7743aa893949994c7aa
Fix lint errors in tests
[ { "path": "src/core/__tests__/ReactRenderDocument-test.js", "patch": "@@ -17,6 +17,8 @@\n * @emails react-core\n */\n \n+/*jslint evil: true */\n+\n \"use strict\";\n \n var React;", "additions": 2, "deletions": 0, "language": "JavaScript" }, { "path": "src/dom/__tests__/mutateHTMLNode...
2013-09-14T12:59:16
vercel/next.js
9d150b116de6aa8df2e14fa804fcccf4da477bb4
35e45393048082b8aa1f4b0e2727cb8a6b55827e
Loose RSC import restrictions for 3rd party packages (#56501) When we landed #51179 it broke library like `apollo-client` as it's bundling client hooks into RSC bundle, so our RSC linter caught them and reported fatal errors. But those client hook APIs won't get executed in RSC. The original purpose of erroring on inv...
[ { "path": "packages/next-swc/crates/core/src/react_server_components.rs", "patch": "@@ -344,6 +344,10 @@ impl<C: Comments> ReactServerComponents<C> {\n }\n \n fn assert_server_graph(&self, imports: &[ModuleImports], module: &Module) {\n+ // If the\n+ if self.is_from_node_modules(&self....
2023-10-05T23:59:22
rust-lang/rust
bc5c2229d01cd06bfd91476636409d619bd5a807
071606b2a385b734fddf27d67a60484dc7df1797
Fix issues in count_leading_zeroes
[ { "path": "src/intrinsic/mod.rs", "patch": "@@ -889,10 +889,17 @@ impl<'a, 'gcc, 'tcx> Builder<'a, 'gcc, 'tcx> {\n // TODO(antoyo): use width?\n let arg_type = arg.get_type();\n let result_type = self.u32_type;\n+ let arg = if arg_type.is_signed(self.cx) {\n+ let ne...
2025-08-01T15:29:05
nodejs/node
7cafd5f3a924451294a4f2ce6efb628b53fce7eb
3ec4b21b1c438255df6f1652377011080dc28052
stream: fix finished w/ 'close' before 'end' Emitting 'close' before 'end' on a Readable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31545 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
[ { "path": "lib/internal/streams/end-of-stream.js", "patch": "@@ -34,6 +34,13 @@ function isWritableFinished(stream) {\n \n function nop() {}\n \n+function isReadableEnded(stream) {\n+ if (stream.readableEnded) return true;\n+ const rState = stream._readableState;\n+ if (!rState || rState.errored) return ...
2020-01-28T06:05:03
electron/electron
704433f3d620d5dcb49ad813848816615288372e
8ae7d01d1a479771d4b5adcca84d1398845541be
Fix broken link in dialog.md [ci skip]
[ { "path": "docs/api/dialog.md", "patch": "@@ -77,7 +77,7 @@ shown.\n * `defaultPath` String (optional)\n * `buttonLabel` String (optional) - Custom label for the confirmation button, when\n left empty the default label will be used.\n- * `filters` [FileFilter[]](structrs/file-filter.md) (optional)\...
2016-12-13T08:42:47
facebook/react
1a38cb9e07cc904f079ab7743aa893949994c7aa
71ad5cb37a4ba930b6a4c78926c36911387c603d
Ensure selection range exists The selection object doesn't always have ranges. In Chrome the selection is not updated before 'focus' event handlers are fired. See http://jsfiddle.net/t4DYA/ for example. The selection will have rangeCount of 0 and calling getRangeAt(0) will throw error "Uncaught IndexSizeError: Index ...
[ { "path": "src/core/ReactInputSelection.js", "patch": "@@ -87,16 +87,18 @@ var ReactInputSelection = {\n getSelection: function(input) {\n var range;\n if (input.contentEditable === 'true' && window.getSelection) {\n- range = window.getSelection().getRangeAt(0);\n- var commonAncestor = r...
2013-09-14T12:59:06
rust-lang/rust
58a38cd7deba18d4b449214cab5cad36d3b4cceb
8652d96ff7b58ec491de45d0767b211f631dfbee
Fix verbosity setting
[ { "path": "src/bootstrap/src/core/config/config.rs", "patch": "@@ -93,7 +93,6 @@ pub struct Config {\n pub ccache: Option<String>,\n /// Call Build::ninja() instead of this.\n pub ninja_in_file: bool,\n- pub verbose: usize,\n pub submodules: Option<bool>,\n pub compiler_docs: bool,\n ...
2025-07-30T11:38:52
golang/go
64f2829c9cdf12b893068305b2451c81b0a5b3a6
2ff563a00e45308fad74f1f86d816f4f636584a0
runtime: fix typo in function comments The correct word to use here is 'receive' not 'recieve' Change-Id: Ia33e2a91c1c2da6dbe479a05518dbb9b8733d20d GitHub-Last-Rev: e3c3e211dd7055d1dab8699a88d0b35c459da149 GitHub-Pull-Request: golang/go#54025 Reviewed-on: https://go-review.googlesource.com/c/go/+/419316 Reviewed-by: ...
[ { "path": "src/runtime/string.go", "patch": "@@ -432,7 +432,7 @@ func atoi32(s string) (int32, bool) {\n // - KiB, MiB, GiB, TiB which represent binary IEC/ISO 80000 units, or\n // - B, which just represents bytes.\n //\n-// Returns an int64 because that's what its callers want and recieve,\n+// Returns an ...
2022-07-24T13:41:16
vercel/next.js
a44b4f85b56ef1c5cfe9ab931839a24241c10230
d21025cc3a50e2ff8a7137d5d5c94576218f01e7
Dev Service (#56442) This replaces the `(global as any)._nextDevHandlers` invocation with references to a specific service instance while also removing the module scoped `devInstances`. This ensures that correct types are used. This was done while changing the `match` parameter in `ensurePage` to `definition` which d...
[ { "path": ".github/CODEOWNERS", "patch": "@@ -28,13 +28,13 @@\n \n # Tooling & Telemetry\n \n-/packages/next/src/build/ @timneutkens @ijjk @shuding @huozhi @ztanner @feedthejim @vercel/web-tooling\n-/packages/next/src/server/lib/router-utils/setup-dev.ts @timneutkens @ijjk @s...
2023-10-05T17:45:00
rust-lang/rust
8652d96ff7b58ec491de45d0767b211f631dfbee
cfc40de9c504c9e05bd9905e3f99011199026ac8
Fix logging of config skip values
[ { "path": "src/bootstrap/src/core/config/config.rs", "patch": "@@ -446,13 +446,23 @@ impl Config {\n enable_bolt_settings: flags_enable_bolt_settings,\n skip_stage0_validation: flags_skip_stage0_validation,\n reproducible_artifact: flags_reproducible_artifact,\n- ...
2025-07-30T11:26:38
nodejs/node
987a67339518d0380177a2e589f2bbd274230d0e
dd8183632d4bc8929371ee4676ef9bb5c95f7aaa
src: start the .text section with an asm symbol We create an object file in assembly which introduces the symbol `__node_text_start` into the .text section and place the resulting object file as the first file the linker encounters. We do this to ensure that we can recognize the boundaries of the .text section when at...
[ { "path": "node.gyp", "patch": "@@ -314,6 +314,19 @@\n },\n \n 'targets': [\n+ {\n+ 'target_name': 'node_text_start',\n+ 'type': 'none',\n+ 'conditions': [\n+ [ 'OS==\"linux\" and '\n+ 'target_arch==\"x64\"', {\n+ 'type': 'static_library',\n+ 'sources'...
2020-02-27T00:21:41
golang/go
2ff563a00e45308fad74f1f86d816f4f636584a0
c5da4fb7ac5cb7434b41fc9a1df3bee66c7f1a4d
cmd/compile/internal/noder: correct spelling errors for instantiation Change-Id: I8091b3181e6dd0c335763c411a6a64026fe5a651 GitHub-Last-Rev: 505c6caa9cd4538f76dde4287b9266e8947e395e GitHub-Pull-Request: golang/go#54024 Reviewed-on: https://go-review.googlesource.com/c/go/+/419315 Run-TryBot: Keith Randall <khr@golang.o...
[ { "path": "src/cmd/compile/internal/noder/stencil.go", "patch": "@@ -623,7 +623,7 @@ func checkFetchBody(nameNode *ir.Name) {\n \t}\n }\n \n-// getInstantiation gets the instantiantion and dictionary of the function or method nameNode\n+// getInstantiation gets the instantiation and dictionary of the functi...
2022-07-24T12:38:48
electron/electron
04da9257ef345549a8c28e53963a1c33b3ec96c8
cae601a682de95ddb6f08dfb16741828f29bee1e
Catch any close window errors
[ { "path": "spec/chromium-spec.js", "patch": "@@ -133,6 +133,8 @@ describe('chromium feature', function () {\n closeWindow(w).then(function () {\n w = null\n done()\n+ }).catch(function (error) {\n+ done(error)\n })\n } else {\n ...
2016-12-12T21:32:27
rust-lang/rust
8a2a9db29eca4468eb1ccf58183b01fe61d00120
2b640216aea9527c67c82cfc781d979247ac6028
Fix LTO errors by not adding AlwaysInline to __rust_alloc_error_handler_should_panic_v2
[ { "path": "src/allocator.rs", "patch": "@@ -104,7 +104,8 @@ fn create_const_value_function(\n tcx.sess.default_visibility(),\n )));\n \n- func.add_attribute(FnAttribute::AlwaysInline);\n+ // FIXME(antoyo): cg_llvm sets AlwaysInline, but AlwaysInline is different in GCC and ...
2025-08-01T14:40:19
nodejs/node
dd8183632d4bc8929371ee4676ef9bb5c95f7aaa
96e70c4ce786f43de16a0267a92ee73abf218356
src: add node_crypto_common and refactor Two things in one on this commit: (a) For the QUIC implementation, we need to separate out various bits from node_crypto.cc to allow them to be reused. That's where this commit starts. (b) Quite a bit of the node_crypto.cc code was just messy in terms of it's orga...
[ { "path": "node.gyp", "patch": "@@ -823,9 +823,11 @@\n [ 'node_use_openssl==\"true\"', {\n 'sources': [\n 'src/node_crypto.cc',\n+ 'src/node_crypto_common.cc',\n 'src/node_crypto_bio.cc',\n 'src/node_crypto_clienthello.cc',\n 'src/...
2020-02-29T01:13:08
vercel/next.js
d21025cc3a50e2ff8a7137d5d5c94576218f01e7
7e1f31118bb53a57c9209b709e6f93598272a6db
refactor: rewrite config schema in zod (#56383) The PR supersedes the https://github.com/vercel/next.js/pull/53150, which is way too outdated, has way too many conflicts, and also heavily relies on GitHub Copilot (which makes the progress slow and tedious). The PR uses [`json-schema-to-zod`](https://github.com/Stefan...
[ { "path": "packages/next/package.json", "patch": "@@ -151,7 +151,6 @@\n \"@next/swc\": \"13.5.5-canary.2\",\n \"@opentelemetry/api\": \"1.4.1\",\n \"@playwright/test\": \"^1.35.1\",\n- \"@segment/ajv-human-errors\": \"2.1.2\",\n \"@taskr/clear\": \"1.1.0\",\n \"@taskr/esnext\": \"1.1....
2023-10-05T15:46:53
golang/go
c5da4fb7ac5cb7434b41fc9a1df3bee66c7f1a4d
774fa58d1d3c9926709e108afdf83af7010bde72
cmd/compile: make jump table symbol local When using plugins, if the plugin and the main executable both have the same function, and if it uses jump table, currently the jump table symbol have the same name so it will be deduplicated by the dynamic linker. This causes a function in the plugin may (in the middle of the...
[ { "path": "misc/cgo/testplugin/plugin_test.go", "patch": "@@ -307,6 +307,12 @@ func TestIssue52937(t *testing.T) {\n \tgoCmd(t, \"build\", \"-buildmode=plugin\", \"-o\", \"issue52937.so\", \"./issue52937/main.go\")\n }\n \n+func TestIssue53989(t *testing.T) {\n+\tgoCmd(t, \"build\", \"-buildmode=plugin\", \...
2022-07-21T22:23:39
electron/electron
cae601a682de95ddb6f08dfb16741828f29bee1e
e043dabcb870b269686ab6e7a11729ca80080339
Upgrade brightray for media device salt fix
[ { "path": "vendor/brightray", "patch": "@@ -1 +1 @@\n-Subproject commit 86a5d053234a3eb9b2df47087738ab0b68ac1e25\n+Subproject commit b8c8a31e9253406ef410f0d253bf1507448c222d", "additions": 1, "deletions": 1, "language": "Unknown" } ]
2016-12-12T21:12:45
nodejs/node
ed8007af0bc8fd4fa575217b50e8ca611a7e8679
5e1f059db4f8b324ef4448e0fbdc5dc7fc6c57d8
events: convert errorMonitor to a normal property Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: https://github.com/nodejs/node/pull/30932#discussion_r379679982 PR-URL: https://github.com/nodejs/node/pull/31848 Reviewed-By: Michaël Zasso <targos@protonmail.com>...
[ { "path": "lib/events.js", "patch": "@@ -90,12 +90,7 @@ ObjectDefineProperty(EventEmitter, 'captureRejections', {\n enumerable: true\n });\n \n-ObjectDefineProperty(EventEmitter, 'errorMonitor', {\n- value: kErrorMonitor,\n- writable: false,\n- configurable: true,\n- enumerable: true\n-});\n+EventEmit...
2020-02-18T14:33:31
vercel/next.js
524b31513a58e58e15862ac8aa3f27da8a47a267
d9627df25b1595a172eaab78d87f9e4823cf88b8
Fix logging level in actions test (#56473) This test was using the old format and because of that failed in Turbopack. This fixes that. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections be...
[ { "path": "test/e2e/app-dir/actions/next.config.js", "patch": "@@ -2,7 +2,9 @@\n module.exports = {\n productionBrowserSourceMaps: true,\n experimental: {\n- logging: 'verbose',\n+ logging: {\n+ level: 'verbose',\n+ },\n serverActions: true,\n },\n }", "additions": 3, "deleti...
2023-10-05T10:30:39
facebook/react
133ea3df091e01347ee74086bde7c091caf7a929
f729a28f3c4e131ace1ac58333cf50ab47dbc5cd
Use a regular expression to parse out React.version. This fixes a silent failure of the test suite that appears to be due to the call require('./build/modules/React').
[ { "path": "Gruntfile.js", "patch": "@@ -55,8 +55,11 @@ module.exports = function(grunt) {\n // Check that the version we're exporting is the same one we expect in the\n // package. This is not an ideal way to do this, but makes sure that we keep\n // them in sync.\n+ var reactVersionExp = /\\bReact\\...
2013-09-11T22:40:27
golang/go
131f981df0a7d17361839b55fd4d588e652f16a9
ae43bdc3e3f87f8ba05ba12a17104ddbb0e6b30c
[dev.unified] cmd/compile: make Unified IR always writes concrete type for const exprs So we don't have to depend on typecheck pass to fixup the concrete type for some constant expressions. Previously, the problem won't show up, until CL 418475 sent, which removes an un-necessary type conversion in "append(a, b...) to...
[ { "path": "src/cmd/compile/internal/noder/expr.go", "patch": "@@ -6,7 +6,6 @@ package noder\n \n import (\n \t\"fmt\"\n-\t\"go/constant\"\n \n \t\"cmd/compile/internal/base\"\n \t\"cmd/compile/internal/ir\"\n@@ -53,31 +52,9 @@ func (g *irgen) expr(expr syntax.Expr) ir.Node {\n \n \tbase.Assert(g.exprStmtOK)...
2022-07-20T13:27:58
electron/electron
cac85d2a12fc6e8bbd1aab083ab7864447a1ccc2
381f55b3cb67258128fb38eb6a199886fb2a520d
Remove linter errors
[ { "path": "atom/app/atom_content_client.cc", "patch": "@@ -207,8 +207,7 @@ void AtomContentClient::AddSecureSchemesAndOrigins(\n std::set<std::string>* secure_schemes,\n std::set<GURL>* secure_origins) {\n std::vector<std::string> schemes;\n- ConvertStringWithSeparatorToVector(&schemes, \",\",\n-...
2016-12-12T20:45:57
rust-lang/rust
1d1efed4d46531fc185887b7f3849501eb28ed24
528e7dc9aec150250097e5918879023051f06249
Fix `x test cargo`
[ { "path": "src/bootstrap/src/core/build_steps/test.rs", "patch": "@@ -18,7 +18,8 @@ use crate::core::build_steps::llvm::get_llvm_version;\n use crate::core::build_steps::run::get_completion_paths;\n use crate::core::build_steps::synthetic_targets::MirOptPanicAbortSyntheticTarget;\n use crate::core::build_st...
2025-07-29T11:31:40
nodejs/node
9ac42f1be42f162ec9cf6bb56e817d7b210a6db9
a0c3c4de3ba0d6286b6670d42dd598652237d2e0
test: remove common.port from test-tls-securepair-client OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e461673c44cb550a7aadc20f0af6453810f1b18. Hopefully the race condition in OpenSSL s_se...
[ { "path": "test/sequential/test-tls-securepair-client.js", "patch": "@@ -62,7 +62,7 @@ function test(keyPath, certPath, check, next) {\n const cert = fixtures.readSync(certPath).toString();\n \n const server = spawn(common.opensslCli, ['s_server',\n- '-accept', ...
2020-02-29T17:48:44
vercel/next.js
ad42b610c25b72561ad367b82b1c7383fd2a5dd2
ae1b89984d26b2af3658001fa19a19e1e77c312d
Fix cli log next.js color (#56448) The color of "Next.js <version>" in CLI was changed to `magenta` accidentally in #55992 , this PR added the original color back
[ { "path": "packages/next/src/lib/picocolors.ts", "patch": "@@ -65,6 +65,9 @@ export const green = enabled ? formatter('\\x1b[32m', '\\x1b[39m') : String\n export const yellow = enabled ? formatter('\\x1b[33m', '\\x1b[39m') : String\n export const blue = enabled ? formatter('\\x1b[34m', '\\x1b[39m') : String...
2023-10-04T21:41:49
golang/go
2d655fb15a50036547a6bf8f77608aab9fb31368
076c3d7f077ff0f8d02675b66b9794bbff8d2147
unsafe: document when Sizeof/Offsetof/Alignof are not constant They are not constant if their arguments have types that are variable size. Fixes #53921 Change-Id: I2d46754c27f55a281331c099a11ea3cd85ec4e89 Reviewed-on: https://go-review.googlesource.com/c/go/+/417917 Auto-Submit: Ian Lance Taylor <iant@google.com> Ru...
[ { "path": "src/unsafe/unsafe.go", "patch": "@@ -189,13 +189,18 @@ type Pointer *ArbitraryType\n // For instance, if x is a slice, Sizeof returns the size of the slice\n // descriptor, not the size of the memory referenced by the slice.\n // For a struct, the size includes any padding introduced by field ali...
2022-07-16T22:51:25
rust-lang/rust
91d40d270d66baa374169be662c403993f5a6591
2c7581fd256b50d33494595e36e8319a18318ce2
Fix `ToolRustc` build with `download-rustc`
[ { "path": "src/bootstrap/src/core/build_steps/tool.rs", "patch": "@@ -111,7 +111,13 @@ impl Step for ToolBuild {\n let path = self.path;\n \n match self.mode {\n- Mode::ToolRustc => {}\n+ Mode::ToolRustc => {\n+ // FIXME: remove this, it's only needed for...
2025-07-22T11:28:13
electron/electron
4e01ab59c167d6f2205f556dad0477d507da5e2a
a46040a4faaaee0eabc22124b0cf1577f6700093
fix documentation for planned breaking changes
[ { "path": "docs/tutorial/planned-breaking-changes.md", "patch": "@@ -121,12 +121,12 @@ webFrame.setVisualZoomLevelLimits(1, 2)\n // Deprecated\n webFrame.registerURLSchemeAsSecure('app')\n // Replace with\n-protocol.registerStandardSchemes('app', {secure: true})\n+protocol.registerStandardSchemes(['app'], {...
2016-11-16T14:41:06
facebook/react
58fae896fe60647b537e20e7f2281e0c377d59f0
63b58cf6b593a8442477721a0c9645b6440c75b3
Fix full-page rendering Closes #337. Test Plan: Opened react-page sample without any JS errors. Also ran grunt test after cherry-picking this changeset on top of #338.
[ { "path": "src/core/ReactMount.js", "patch": "@@ -28,6 +28,9 @@ var SEPARATOR = ReactInstanceHandles.SEPARATOR;\n var ATTR_NAME = 'data-reactid';\n var nodeCache = {};\n \n+var ELEMENT_NODE_TYPE = 1;\n+var DOC_NODE_TYPE = 9;\n+\n var $ = require('$');\n \n /** Mapping from reactRootID to React component ins...
2013-09-11T05:54:41
nodejs/node
a0c3c4de3ba0d6286b6670d42dd598652237d2e0
eb2fe5ff90d68520b148fdc86362c07561c1c635
deps: openssl: cherry-pick 4dcb150ea30f OpenSSL 1.1.1d does not ship with getrandom syscall being predefined on all architectures. So when NodeJS is run with glibc prior to 2.25, where getentropy is unavailable, and the getrandom syscall is unknown, it will fail. PPC64LE or s390 are affected by lack of this definition...
[ { "path": "deps/openssl/openssl/crypto/rand/rand_unix.c", "patch": "@@ -282,12 +282,58 @@ static ssize_t sysctl_random(char *buf, size_t buflen)\n # if defined(OPENSSL_RAND_SEED_GETRANDOM)\n \n # if defined(__linux) && !defined(__NR_getrandom)\n-# if defined(__arm__) && defined(__NR_SYSCALL_BASE)\n+# ...
2020-02-28T11:14:18
vercel/next.js
187df91438200546516ed54ae7ef4e561a64c8b8
65b0bb24af8a14d20871d830acc5a12ee03989cd
fix: `.../templates/*/app/layout.*` import order (#56380) - fixes #56379
[ { "path": "packages/create-next-app/templates/app-tw/js/app/layout.js", "patch": "@@ -1,5 +1,5 @@\n-import './globals.css'\n import { Inter } from 'next/font/google'\n+import './globals.css'\n \n const inter = Inter({ subsets: ['latin'] })\n ", "additions": 1, "deletions": 1, "language": "JavaSc...
2023-10-04T20:41:47
golang/go
076c3d7f077ff0f8d02675b66b9794bbff8d2147
c4a6d3048bb89f372662083695f957f22973e4a6
net/http: remove accidental heading in Head documentation This short sentence was missing a period at the end, which caused it to be interpreted as a heading. It also gained a '# ' prefix as part of new gofmt formatting applied in CL 384268. This change makes it a regular sentence as originally intended. Updates #510...
[ { "path": "src/net/http/client.go", "patch": "@@ -896,7 +896,7 @@ func (c *Client) PostForm(url string, data url.Values) (resp *Response, err erro\n //\t307 (Temporary Redirect)\n //\t308 (Permanent Redirect)\n //\n-// # Head is a wrapper around DefaultClient.Head\n+// Head is a wrapper around DefaultClient...
2022-07-21T21:09:35
electron/electron
4b53cd9c3c0b17b535d3fc49b30c3b8ea840edab
2fa9ca1f6dcc0acfdf19854576b6d946f2f1f717
:bug: Allow buttons to be optional in 'showMessageBox'
[ { "path": "lib/browser/api/dialog.js", "patch": "@@ -61,9 +61,7 @@ module.exports = {\n \n if (properties == null) {\n properties = ['openFile']\n- }\n-\n- if (!Array.isArray(properties)) {\n+ } else if (!Array.isArray(properties)) {\n throw new TypeError('Properties must be an arra...
2016-12-12T18:05:01
facebook/react
fea4fec0bc3cd72b57cc65e75ef6ba2131cdedcb
63b58cf6b593a8442477721a0c9645b6440c75b3
Fix ReactRenderDocument tests I am unsure how this was ever supposed to work, as testDocument is guaranteed to be undefined at that point since beforeEach doesn't run synchronously. (I don't think there's any way to have beforeEach halt the tests.)
[ { "path": "src/core/__tests__/ReactRenderDocument-test.js", "patch": "@@ -37,12 +37,12 @@ describe('rendering React components at document', function() {\n testDocument = getTestDocument();\n });\n \n- if (!testDocument) {\n- // These tests are not applicable in jst, since jsdom is buggy.\n- re...
2013-09-11T05:42:05
nodejs/node
4c35b62f64a72eb5234ba805c19add36e46b1e9e
fb74e98243e3fabd5fa45587cf1c68948673662e
doc: revise --zero-fill-buffers text in buffer.md There was an unclear sentence fragment that needed fixing, so I edited the entire paragraph for clarity. I also removed irrelevant information about behavior before Node.js 8.0.0. That version of Node.js is no longer supported and these docs will never apply to 8.0.0. ...
[ { "path": "doc/api/buffer.md", "patch": "@@ -123,15 +123,12 @@ added: v5.10.0\n -->\n \n Node.js can be started using the `--zero-fill-buffers` command line option to\n-cause all newly allocated `Buffer` instances to be zero-filled upon creation by\n-default. Before Node.js 8.0.0, this included buffers allo...
2020-02-29T06:12:47
vercel/next.js
65b0bb24af8a14d20871d830acc5a12ee03989cd
400c67979155082742ae4b4787f803413aa97f89
Separate RSC and SSR jsx-runtime modules (#56438) There should be no shared react packages in our server runtime. rsc should always be separate from ssr. This update reconfigures the runtiem to eliminate shared react modules. the jsx runtime will now be separate for RSC and SSR. this is necessary because the implemen...
[ { "path": "packages/next-swc/crates/next-core/src/next_import_map.rs", "patch": "@@ -452,7 +452,7 @@ async fn insert_next_server_special_aliases(\n match runtime {\n NextRuntime::Edge => \"next/dist/compiled/react/jsx-runtime\",\n NextRunti...
2023-10-04T20:29:10
rust-lang/rust
e2981f099ca037269844a3ec6fccbe0b1f45fd38
942f33be468e057fb599ea6b6f6e165ba25689b1
Update host toolchain Necessary to avoid a bolt-related crash.
[ { "path": "src/ci/docker/scripts/build-clang.sh", "patch": "@@ -5,7 +5,7 @@ set -ex\n source shared.sh\n \n # Try to keep the LLVM version here in sync with src/ci/scripts/install-clang.sh\n-LLVM=llvmorg-20.1.0-rc2\n+LLVM=llvmorg-21.1.0-rc2\n \n mkdir llvm-project\n cd llvm-project", "additions": 1, ...
2025-07-17T12:25:53
golang/go
c4a6d3048bb89f372662083695f957f22973e4a6
244c8b050093ec546311707760afaafabcbf2fef
cmd/dist: enable race detector test on S390X The support was added but the test was not enabled. Enable it. Fixes #53981. Change-Id: I81ea73ea4ebc1013c35cb70ae88b096e02497887 Reviewed-on: https://go-review.googlesource.com/c/go/+/418914 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant...
[ { "path": "src/cmd/dist/test.go", "patch": "@@ -1720,7 +1720,7 @@ func (t *tester) runPrecompiledStdTest(timeout time.Duration) error {\n func raceDetectorSupported(goos, goarch string) bool {\n \tswitch goos {\n \tcase \"linux\":\n-\t\treturn goarch == \"amd64\" || goarch == \"ppc64le\" || goarch == \"arm6...
2022-07-21T19:11:13
nodejs/node
fb74e98243e3fabd5fa45587cf1c68948673662e
6bcea0a38365f518580a4dbbf2f5627bede5aac5
test: fix flaky test-dns-any.js Remove google.com from domains tested with ANY queries. Fixes: https://github.com/nodejs/node/issues/31721 PR-URL: https://github.com/nodejs/node/pull/32017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipi...
[ { "path": "test/internet/test-dns-any.js", "patch": "@@ -115,28 +115,6 @@ function processResult(res) {\n return types;\n }\n \n-TEST(async function test_google(done) {\n- function validateResult(res) {\n- const types = processResult(res);\n- assert.ok(\n- types.A && types.AAAA && types.MX && ...
2020-02-29T04:37:07
vercel/next.js
338f80b4fd76ddfe8defac2bdcac7d31a2474dc4
a278e94df5f7a2e651e34a88d5403d8847dd65a7
fix empty externals list, pnpm special case, and project path (#56402) ### What? * node.js doesn't allow module requests starting with `.` since node.js 18, so we need to remove out .pnpm special case * externals should be resolvable from the project dir instead of the root dir * fix a problem when the list of ...
[ { "path": "packages/next-swc/crates/next-core/src/next_server/context.rs", "patch": "@@ -109,6 +109,7 @@ pub async fn get_server_resolve_options_context(\n let unsupported_modules_resolve_plugin = UnsupportedModulesResolvePlugin::new(project_path);\n let server_component_externals_plugin = ExternalC...
2023-10-04T17:29:26
facebook/react
f69112cb3f080fc92ddb6543cca58282fd5e6c0b
63b58cf6b593a8442477721a0c9645b6440c75b3
JSX: Respect original spacing and newlines better Fixes #335. Now this JSX: ``` /** @jsx React.DOM */ var HelloMessage = React.createClass({ render: function() { return <div> Look! <a href= "http://www.facebook.com/">Facebook </a> </div>; } }); ``` produces ``` /** @jsx React....
[ { "path": "vendor/fbtransform/transforms/react.js", "patch": "@@ -19,6 +19,7 @@\n var Syntax = require('esprima-fb').Syntax;\n \n var catchup = require('jstransform/src/utils').catchup;\n+var catchupWhiteSpace = require('jstransform/src/utils').catchupWhiteSpace;\n var append = require('jstransform/src/util...
2013-09-11T00:14:36
nodejs/node
1e8625c622d4f3463fa0138e9912615b162ec296
11b76845228421ea2134c2f0036bcaa498375a7d
test: fix flaky test-gc-net-timeout If the timeout is called in the time between 'end' and 'close' that would cause a EPIPE error. Essentially making the test flaky. PR-URL: https://github.com/nodejs/node/pull/31918 Reviewed-By: Anna Henningsen <anna@addaleax.net>
[ { "path": "test/parallel/test-gc-net-timeout.js", "patch": "@@ -12,6 +12,9 @@ function serverHandler(sock) {\n sock.on('close', function() {\n clearTimeout(timer);\n });\n+ sock.on('end', function() {\n+ clearTimeout(timer);\n+ });\n sock.on('error', function(err) {\n assert.strictEqual(e...
2020-02-22T21:01:06
vercel/next.js
a278e94df5f7a2e651e34a88d5403d8847dd65a7
f8308c9e39c098712fa3149cdeb3d5cbab27e5cb
fix: avoid creation of buffers for read ops (#56421) Example usage of `readFileSync().toString()` first creates a `Buffer` instance and later does another C++ call to convert Buffer to UTF-8. This pull request reduces the C++ calls.
[ { "path": "packages/next/src/export/helpers/create-incremental-cache.ts", "patch": "@@ -35,8 +35,8 @@ export function createIncrementalCache(\n notFoundRoutes: [],\n }),\n fs: {\n- readFile: (f) => fs.promises.readFile(f),\n- readFileSync: (f) => fs.readFileSync(f),\n+ readFile:...
2023-10-04T16:40:59
facebook/react
cd019871e3b492ad32d9a3ac11973100687b06b7
63b58cf6b593a8442477721a0c9645b6440c75b3
Fix input/textarea `value` of number 0 and `false` Previously, setting textarea `value` to number 0 is treated as if `value` wasn't set at all (thus the textarea is cleared from 0 to '' upon `onChange`). `false` also renders as `"false"` instead of `""` for both `defaultValue` and `value`, on textarea _and_ input.
[ { "path": "src/dom/components/ReactDOMInput.js", "patch": "@@ -50,9 +50,10 @@ var instancesByReactID = {};\n var ReactDOMInput = ReactCompositeComponent.createClass({\n \n getInitialState: function() {\n+ var defaultValue = this.props.defaultValue;\n return {\n checked: this.props.defaultChec...
2013-08-17T16:16:59
golang/go
244c8b050093ec546311707760afaafabcbf2fef
df38614bd7f233f36a3f5ac07f0ec9029043243f
cmd/cgo: allow cgo to pass strings or []bytes bigger than 1<<30 There's no real reason to limit to 1<<30 bytes. Maybe it would catch some mistakes, but probably ones that would quickly manifest in other ways. We can't use the fancy new unsafe.Slice function because this code may still be generated for people with 1.1...
[ { "path": "src/cmd/cgo/out.go", "patch": "@@ -1653,10 +1653,18 @@ const cStringDef = `\n // freed, such as by calling C.free (be sure to include stdlib.h\n // if C.free is needed).\n func _Cfunc_CString(s string) *_Ctype_char {\n+\tif len(s)+1 <= 0 {\n+\t\tpanic(\"string too large\")\n+\t}\n \tp := _cgo_cma...
2022-07-20T19:46:33
nodejs/node
46b92c854deeca6cb0d1b3d473f7f006b3f59639
311e12b96201c01d6c66c800d8cfc59ebf9bc4ae
crypto: turn impossible DH errors into assertions PR-URL: https://github.com/nodejs/node/pull/31934 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca ...
[ { "path": "src/node_crypto.cc", "patch": "@@ -5938,11 +5938,7 @@ void DiffieHellman::ComputeSecret(const FunctionCallbackInfo<Value>& args) {\n \n ClearErrorOnReturn clear_error_on_return;\n \n- if (args.Length() == 0) {\n- return THROW_ERR_MISSING_ARGS(\n- env, \"Other party's public key argum...
2020-02-24T13:25:03
facebook/react
63b58cf6b593a8442477721a0c9645b6440c75b3
5388d70bb12cb93885f23d695f476cc2e1971b18
AUTHORS Created a .mailmap file with all of the associations, then used git + perl to create the AUTHORS file. In theory these should all get picked up by npm. I used ABC order so it would remain unbiased and automatable. I wish we could go back and fill out the history or at least fix the commits we have from Commit...
[ { "path": ".mailmap", "patch": "@@ -0,0 +1,18 @@\n+Ben Newman <bn@cs.stanford.edu> <benjamn@fb.com>\n+Dan Schafer <dschafer@fb.com>\n+Jeff Morrison <jeff@anafx.com> <Jeff@anafx.com>\n+Jeff Morrison <jeff@anafx.com> JeffMo <jeffmo@fb.com>\n+Jeffrey Lin <lin.jeffrey@gmail.com> <jeffreylin@fb.com>\n+Jordan Wal...
2013-09-09T23:55:58
vercel/next.js
f8308c9e39c098712fa3149cdeb3d5cbab27e5cb
b436589ff86a8a4c5109120d07148ec75483ecdd
fix: avoid unnecessary `existSync` call (#56419) Co-authored-by: Jiachi Liu <inbox@huozhi.im>
[ { "path": "packages/next/src/server/next-server.ts", "patch": "@@ -367,8 +367,8 @@ export default class NextNodeServer extends BaseServer {\n const buildIdFile = join(this.distDir, BUILD_ID_FILE)\n try {\n return fs.readFileSync(buildIdFile, 'utf8').trim()\n- } catch (err) {\n- if (!fs...
2023-10-04T15:44:26
electron/electron
82bd1d98d5fd0cd91ef23f2d31dd67917fc379c8
de625bfb655eff580e72b558850722edf7cefaad
Indent tree structure to fix Markdown list number rendering
[ { "path": "docs/tutorial/application-distribution.md", "patch": "@@ -149,11 +149,11 @@ we appreciate your help.\n \n 2. Create a new S3 bucket and create the following empty directory structure:\n \n-```\n-- atom-shell/\n- - symbols/\n- - dist/\n-```\n+ ```\n+ - atom-shell/\n+ - symbols/\n+ ...
2016-12-10T16:14:10
golang/go
7a8ba83b729e37d0bdddc9a3c93ae866d1ef199a
64cd6faa13e9155e7942f3f51127c1d61a38fcf7
[dev.unified] cmd/compile/internal/reflectdata: remove hasRType's `required` param Unified IR now always provides RTTI needed by the backend, no need to allow exceptions anymore. 🥳 Change-Id: Ie1ba42c81f92cc43e1b01b3289de10e261ccef57 Reviewed-on: https://go-review.googlesource.com/c/go/+/415576 TryBot-Result: Gopher...
[ { "path": "src/cmd/compile/internal/reflectdata/helpers.go", "patch": "@@ -11,13 +11,21 @@ import (\n \t\"cmd/internal/src\"\n )\n \n-func hasRType(n, rtype ir.Node, fieldName string, required bool) bool {\n+func hasRType(n, rtype ir.Node, fieldName string) bool {\n \tif rtype != nil {\n \t\treturn true\n \...
2022-07-01T01:48:02
nodejs/node
311e12b96201c01d6c66c800d8cfc59ebf9bc4ae
8b1efe0306c4c0ed35a271cfa9ea00033b75c6c2
stream: fix multiple destroy calls Previously destroy could be called multiple times causing inconsistent and hard to predict behavior. Furthermore, since the stream _destroy implementation can only be called once, the behavior of applying destroy multiple times becomes unclear. This changes so that only the first de...
[ { "path": "doc/api/stream.md", "patch": "@@ -385,6 +385,10 @@ This is a destructive and immediate way to destroy a stream. Previous calls to\n `write()` may not have drained, and may trigger an `ERR_STREAM_DESTROYED` error.\n Use `end()` instead of destroy if data should flush before close, or wait for\n th...
2019-08-18T21:38:35
facebook/react
3bbd966a829b10285fbf9548b280f05ca2a45543
aa765e8fa379acb49204ab6d00673b61134e9b7f
Fix radio input test in Chrome It seems like the `form="pluto"` was throwing it off and making the input live outside the form it should have been contained in, causing it to uncheck A. I added it intending to test the form attribute but ended up not needing it so removing it should be fine. (The tests were passing in...
[ { "path": "src/dom/components/__tests__/ReactDOMInput-test.js", "patch": "@@ -61,8 +61,7 @@ describe('ReactDOMInput', function() {\n <input ref=\"b\" type=\"radio\" name=\"fruit\" />B\n \n <form>\n- <input ref=\"c\" type=\"radio\" name=\"fruit\" form=\"pluto\"\n- ...
2013-09-10T01:44:36
vercel/next.js
b436589ff86a8a4c5109120d07148ec75483ecdd
28767ad96aec540c224bf9d2e7f6d1806fa07e38
Maintenance: minor example dep bumps to fix moderate vulns (#56375) ### What? Merged a bunch of dependabot alerts in my own canary branch, mainly postcss patch updates, and one graphql minor update, to fix moderate security vulnerabilities in examples. Spot checked most and look good still. EDIT: also one in scrip...
[ { "path": "examples/api-routes-apollo-server/package.json", "patch": "@@ -9,7 +9,7 @@\n \"@apollo/server\": \"^4.1.1\",\n \"@as-integrations/next\": \"^1.1.0\",\n \"@graphql-tools/schema\": \"^9.0.9\",\n- \"graphql\": \"16.6.0\",\n+ \"graphql\": \"16.8.1\",\n \"graphql-tag\": \"^2.12.6...
2023-10-04T15:18:54
electron/electron
6a829e01790a53dbec6dfb6415abc3e880066a8e
4085ba309a01c4457e840e0515487f8030fcc571
Throw error when options object is invalid
[ { "path": "atom/browser/api/atom_api_session.cc", "patch": "@@ -571,7 +571,10 @@ void Session::ClearHostResolverCache(mate::Arguments* args) {\n \n void Session::ClearAuthCache(mate::Arguments* args) {\n ClearAuthCacheOptions options;\n- args->GetNext(&options);\n+ if (!args->GetNext(&options)) {\n+ ...
2016-12-09T18:07:04
golang/go
318027044aa33c109a6f3e6ac12792f129ff2d6a
e971b6a9be7e10df28a9e9bbc6e3f6cf46201957
[dev.unified] cmd/compile/internal/noder: explicit nil handling Currently, uses of "nil" are handling as references to cmd/compile's own untyped "nil" object, and then we rely on implicitly converting that to its appropriate type. But there are cases where this can subtly go wrong (e.g., the switch test case added in ...
[ { "path": "src/cmd/compile/internal/noder/codes.go", "patch": "@@ -53,6 +53,7 @@ const (\n \texprConvert\n \texprNew\n \texprMake\n+\texprNil\n )\n \n type codeAssign int", "additions": 1, "deletions": 0, "language": "Go" }, { "path": "src/cmd/compile/internal/noder/reader.go", "patc...
2022-07-18T20:13:46
facebook/react
888cc309e09ebc6bde7e13a30521ba5a47f217a2
4ed7b85ed8296259c61eeb4747a067afb35d4f52
Stop using comments as boundary markers in dangerouslyRenderMarkup. Jordan warned (and StackOverflow confirmed) that IE8 doesn't respect HTML comment nodes when setting `.innerHTML`: http://stackoverflow.com/questions/15006001/inserting-a-comment-in-innerhtml The virtue of the comment strategy was that the parser did...
[ { "path": "src/dom/Danger.js", "patch": "@@ -29,11 +29,8 @@ var getMarkupWrap = require('getMarkupWrap');\n var invariant = require('invariant');\n var mutateHTMLNodeWithMarkup = require('mutateHTMLNodeWithMarkup');\n \n-var COMMENT_NODE_TYPE = 8;\n-\n-// This buffer will be reused in dangerouslyRenderMarku...
2013-09-09T21:59:36
nodejs/node
3d894d0511bc76c2bd886077d1cb434d878527de
331d63624007be4bf49d6d161bdef2b5e540affa
deps: V8: backport f7771e5b0cc4 Original commit message: [runtime] Recompute enumeration indices of dictionaries upon bitfield overflow Otherwise we'll get weird semantics when enumerating objects after many deletes/reinserts. Bug: chromium:1033771 Change-Id: If0a459169c3794a30d9632d09e80da3cfcd...
[ { "path": "common.gypi", "patch": "@@ -39,7 +39,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.29',\n+ 'v8_embedder_string': '-node.30',\n \n ##### V8 defaults for Node.js #####\n...
2020-02-26T00:00:48
vercel/next.js
bfee8eaa6e8a6bda6119fbb03b23a1887a4d4bfc
2c5a8b1abb5cd9500420c60194c1ed7d63d3a63a
Move Edge SSR event `waitUntil` into the handler (#56404) Fixes the code added in #56381 where the event isn't passed to the outer function, but the adapter inside.
[ { "path": "packages/next/src/build/webpack/loaders/next-edge-ssr-loader/index.ts", "patch": "@@ -225,8 +225,6 @@ const edgeSSRLoader: webpack.LoaderDefinitionFunction<EdgeSSRLoaderQuery> =\n }\n const nextFontManifest = maybeJSONParse(self.__NEXT_FONT_MANIFEST)\n \n- globalThis.__next_private_glo...
2023-10-04T13:13:18
golang/go
ebd34e3e4500b3feef4b4f98526ae95172cd8088
76a82f09d6da7e6fe18b703e5497795a19a780df
[dev.unified] test: relax panic message expectations In this test, traditionally the comparison `*l == r[0]` was left as a comparison between `*l` (type `any`) and `r[0]` (type `*int`), and the rest of the compiler needed to handle mixed-typed comparisons. However, this means more complexity for wiring up explicit rty...
[ { "path": "test/fixedbugs/issue32187.go", "patch": "@@ -36,24 +36,26 @@ func main() {\n \t\t{\"type assertion\", \"\", func() { _ = x == x.(*int) }},\n \t\t{\"out of bounds\", \"\", func() { _ = x == s[1] }},\n \t\t{\"nil pointer dereference #1\", \"\", func() { _ = x == *p }},\n-\t\t{\"nil pointer derefere...
2022-07-18T02:53:19
facebook/react
e010a2d90beb44b7d6751098eed512b61d3a42f2
d704bc24f4c9cdafbcde53017daba750933ca33a
Fix bugs with CSS3 animation event in webkit We were incorrectly sniffing the animationend event.
[ { "path": "src/addons/transitions/ReactTransitionEvents.js", "patch": "@@ -21,22 +21,34 @@\n var ExecutionEnvironment = require('ExecutionEnvironment');\n \n var EVENT_NAME_MAP = {\n- 'transition': ['animationend', 'transitionend'],\n- 'WebkitTransition': ['webkitAnimationEnd', 'webkitTransitionEnd'],\n- ...
2013-09-09T18:52:04
electron/electron
4085ba309a01c4457e840e0515487f8030fcc571
975d677f55c0bedd3746ccaf8c431e70c0a7eb1a
fix spec
[ { "path": "spec/api-session-spec.js", "patch": "@@ -673,9 +673,7 @@ describe('session module', function () {\n res.setHeader('WWW-Authenticate', 'Basic realm=\"Restricted\"')\n res.end()\n } else {\n- res.statusCode = 200\n- res.write('authenticated')\n- ...
2016-12-01T12:40:02
nodejs/node
331d63624007be4bf49d6d161bdef2b5e540affa
1b2e2944bc069abd1dd7cbf90d3badad4289235d
errors: remove unused ERR_SOCKET_CANNOT_SEND error This error is no longer used within core. This commit removes it. PR-URL: https://github.com/nodejs/node/pull/31958 Refs: https://github.com/nodejs/help/issues/2484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Revie...
[ { "path": "doc/api/errors.md", "patch": "@@ -1727,11 +1727,6 @@ value.\n While using [`dgram.createSocket()`][], the size of the receive or send `Buffer`\n could not be determined.\n \n-<a id=\"ERR_SOCKET_CANNOT_SEND\"></a>\n-### `ERR_SOCKET_CANNOT_SEND`\n-\n-Data could be sent on a socket.\n-\n <a id=\"ERR...
2020-02-26T01:51:40
vercel/next.js
a46c5afa608b88fed85d152530b22383b51bf416
09b0ca42fb9d809e1417039c444b5957d57104c3
fix: use `fs.existsSync` to avoid race condition (#56387) Using `await fs.access` has couple of downsides. It creates unnecessary async contexts where async scope can be removed. Also, it creates the possibility of race conditions such as `Time-of-Check to Time-of-Use`. It would be nice if someone can benchmark t...
[ { "path": "packages/next/src/build/entries.ts", "patch": "@@ -15,6 +15,7 @@ import type { AppLoaderOptions } from './webpack/loaders/next-app-loader'\n import { cyan } from '../lib/picocolors'\n import { posix, join, dirname, extname } from 'path'\n import { stringify } from 'querystring'\n+import fs from '...
2023-10-03T22:19:10
electron/electron
d705f4cbac4f4074a15fe6f8977e1696d8bcaa24
5d94221c61b196a16001ce0cff192e1274556919
Fix issue where actual/expected was same variable
[ { "path": "spec/api-session-spec.js", "patch": "@@ -587,10 +587,9 @@ describe('session module', function () {\n it('can create an interrupted download item', function (done) {\n ipcRenderer.sendSync('set-download-option', true, false)\n const filePath = path.join(__dirname, 'fixtures', 'mock...
2016-12-09T17:36:44
nodejs/node
1b2e2944bc069abd1dd7cbf90d3badad4289235d
fb26b136238240eeac1b3ede098e097a343aef0b
dgram: don't hide implicit bind errors When dgram socket implicit binding fails, an attempt is made to clean up the send queue. This was originally implemented using an 'error' handler that performed cleanup and then emitted a fake error, which concealed the original error. This was done to prevent cases where the sam...
[ { "path": "lib/dgram.js", "patch": "@@ -45,7 +45,6 @@ const {\n ERR_SOCKET_BAD_BUFFER_SIZE,\n ERR_SOCKET_BAD_PORT,\n ERR_SOCKET_BUFFER_SIZE,\n- ERR_SOCKET_CANNOT_SEND,\n ERR_SOCKET_DGRAM_IS_CONNECTED,\n ERR_SOCKET_DGRAM_NOT_CONNECTED,\n ERR_SOCKET_DGRAM_NOT_RUNNING,\n@@ -506,23 +505,22 @@ funct...
2020-02-26T01:18:35
facebook/react
78d305eb167af7f5446c5d4812a160946f493234
3cf14e8f9b14ac05bcd24634daa26ac6772bd31b
Fix backbone todo example bugs. Fixed: - New todo not submitting correctly (page refreshes. `preventDefault` wasn't there. - Old checked todo being removed will leave the checkmark on the next todo replacing its position. - Cannot change todo (`value`'s now a controlled field). - `autofocus` (should be `autoFocus`, ho...
[ { "path": "examples/todomvc-backbone/README.md", "patch": "@@ -0,0 +1,3 @@\n+# TodoMVC-Backbone\n+\n+This is a lightweight version of TodoMVC. Its primary purpose is to demo the Backbone integration rather than being feature-complete (refer to `todomvc-director` for a full TodoMVC-compilant app).", "add...
2013-09-06T20:40:35
electron/electron
5d94221c61b196a16001ce0cff192e1274556919
f124732431326031b585a3be0831f9d7556733f5
fix code style
[ { "path": "atom/browser/api/atom_api_session.cc", "patch": "@@ -554,8 +554,16 @@ void Session::CreateInterruptedDownload(const mate::Dictionary& options) {\n options.Get(\"lastModified\", &last_modified);\n options.Get(\"eTag\", &etag);\n options.Get(\"startTime\", &start_time);\n- if (path.empty() |...
2016-12-07T07:28:53
nodejs/node
fb26b136238240eeac1b3ede098e097a343aef0b
a777cfa843d5b996e45c4f8188733b637594378b
module: port source map sort logic from chromium Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: #31286...
[ { "path": "lib/internal/source_map/source_map.js", "patch": "@@ -152,10 +152,12 @@ class SourceMap {\n * @param {SourceMapV3} mappingPayload\n */\n #parseMappingPayload = () => {\n- if (this.#payload.sections)\n+ if (this.#payload.sections) {\n this.#parseSections(this.#payload.sections)...
2020-02-24T03:19:15