instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
dask__dask-8305@922396e | dask/dask | Python | 8,305 | Deprecate `AxisError` | Closes #8301 | 2021-10-27T16:58:48Z | Deprecate AxisError, itemgetter, methodcaller
These classes and functions no longer have a reason to exist:
- dask.array.utils.AxisError (backwards compatibility around numpy.AxisError - no longer needed with the current minimum numpy dependency)
- dask.utils.itemgetter (serializable variant of operator.itemgetter ... | [
{
"body": "These classes and functions no longer have a reason to exist:\r\n\r\n- dask.array.utils.AxisError (backwards compatibility around numpy.AxisError - no longer needed with the current minimum numpy dependency)\r\n- dask.utils.itemgetter (serializable variant of operator.itemgetter - which can be serial... | 3b61950cbdf033d53ae98937d19a9ff0b2a38f40 | {
"head_commit": "922396eeb6c0de136fc6f3400276751e8ec94ed8",
"head_commit_message": "Deprecate AxisError and itemgetter",
"patch_to_review": "diff --git a/dask/array/creation.py b/dask/array/creation.py\nindex 81c02af3969..e953b03f02f 100644\n--- a/dask/array/creation.py\n+++ b/dask/array/creation.py\n@@ -26,7 +2... | [
{
"diff_hunk": "@@ -530,3 +522,17 @@ def scipy_linalg_safe(func_name, *args, **kwargs):\n \n def solve_triangular_safe(a, b, lower=False):\n return scipy_linalg_safe(\"solve_triangular\", a, b, lower=lower)\n+\n+\n+def __getattr__(name):\n+ # Can't use the @_deprecated decorator as it would not work on `... | 8cf1379f3a4646b901d83ea38e00d8c26b0fc9c8 | diff --git a/dask/array/creation.py b/dask/array/creation.py
index 81c02af3969..e953b03f02f 100644
--- a/dask/array/creation.py
+++ b/dask/array/creation.py
@@ -26,7 +26,7 @@
)
from .numpy_compat import _numpy_120
from .ufunc import greater_equal, rint
-from .utils import AxisError, meta_from_array
+from .utils impo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
dask__dask-8304@6387e3f | dask/dask | Python | 8,304 | Add series is_monotonic* | - [x] Closes #8297
- [x] Tests added / passed
- [x] Passes `pre-commit run --all-files`
| 2021-10-27T16:54:13Z | Series is_monotonic, is_monotonic_decreasing, is_monotonic_increasing
I'd like to be able to use is_monotonic, is_monotonic_decreasing, is_monotonic_increasing. As of today, I can do this in pandas but not dask
```python
import pandas as pd
import dask.dataframe as dd
pdf = pd.DataFrame({
"a": [0,1,0,1,1... | Thanks for the feature request @mesejo. Adding these `is_monotonic*` methods is certainly in scope for Dask DataFrame. Is this something you're interested in working on? (no obligation though)
@jrbourbeau You are welcome! Yes, I'm interested in working on this.
I believe this should not hard to implement, my idea ... | [
{
"body": "I'd like to be able to use is_monotonic, is_monotonic_decreasing, is_monotonic_increasing. As of today, I can do this in pandas but not dask\r\n\r\n```python\r\n\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\n\r\npdf = pd.DataFrame({\r\n \"a\": [0,1,0,1,1,0],\r\n \"b\": range(6),\r\n ... | a135dd96e1ec6a56f4c80a1c3ad29d50caabe848 | {
"head_commit": "6387e3fb0a02f28932f2efcfc86838158c035643",
"head_commit_message": "Add is_monotonic* properties to Index",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex a76cba3c7f7..2a0661c64ab 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -3766... | [
{
"diff_hunk": "@@ -7349,3 +7409,45 @@ def series_map(base_series, map_series):\n divisions = list(base_series.divisions)\n \n return new_dd_object(graph, final_prefix, meta, divisions)\n+\n+\n+def _monotonic_increasing_chunk(x):\n+ return pd.DataFrame(\n+ data=[[x.is_monotonic_increasing, x.i... | 24cf4ce2262a1c84c4d86b4c77b99a558f7b43c4 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index a76cba3c7f7..ffdac84a1c8 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -3766,9 +3766,35 @@ def __rdivmod__(self, other):
res2 = other % self
return res1, res2
+ @property
+ @derived_from(pd.Series)
+ de... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
cupy__cupy-2455@44b4c10 | cupy/cupy | Python | 2,455 | Add appropriate pointer types in Cython to the contribute guide | Followup of #1952. Fixes #1913 further.
This PR is encouraged in https://github.com/cupy/cupy/issues/1913#issuecomment-529298038. The main change is that most of the types in `cupy.cuda.driver` (such as `Function` and `Stream`) are pointers, and thus should be represented by `intptr_t`, see https://github.com/cupy/... | 2019-09-10T06:30:06Z | Use correct integer types in Cython
Currently incorrect integer types are used in Cython implementation.
It's less portable and perhaps more importantly, confusing for developers.
For example:
* Pointers should be `intptr_t`.
* Memory sizes should be `size_t`.
* Memory offsets should be `ptrdiff_t`. | Hi @ninoshi, when I was working on PRs that would touch the driver wrappers, I noticed that in `driver.pxd`/`driver.pyx` there are many types that should have been changed from `size_t` to `intptr_t` but were left untouched in #1952, which made me thought that using `size_t` was the deliberately chosen convention for d... | [
{
"body": "Currently incorrect integer types are used in Cython implementation.\r\nIt's less portable and perhaps more importantly, confusing for developers.\r\n\r\nFor example:\r\n* Pointers should be `intptr_t`.\r\n* Memory sizes should be `size_t`.\r\n* Memory offsets should be `ptrdiff_t`.\r\n",
"number... | a3e7046b00a308617d9bea19ed02d840fd34bd5e | {
"head_commit": "44b4c1023519d9cc71763d6059298918e838ce5b",
"head_commit_message": "improved language in contribution guide\n\nCo-authored-by: Sean Farley <sean@farley.io>",
"patch_to_review": "diff --git a/cupy/core/raw.pyx b/cupy/core/raw.pyx\nindex 1a94562fd90..7d0ea226838 100644\n--- a/cupy/core/raw.pyx\n+++... | [
{
"diff_hunk": "@@ -261,6 +261,15 @@ Please note the followings when writing the document.\n original one, users should explicitly describe only what is implemented in\n the document.\n \n+For changes that modify or add new Cython files, please make sure the pointer types follow these guidelines (`GH-1913 <... | e9a655bbf3228da72fed47a0d40b14ac6afcccc6 | diff --git a/cupy/core/raw.pyx b/cupy/core/raw.pyx
index 1a94562fd90..7d0ea226838 100644
--- a/cupy/core/raw.pyx
+++ b/cupy/core/raw.pyx
@@ -256,6 +256,6 @@ cdef class RawModule:
name (str): Name of the texture reference.
Returns:
- size_t: A ``CUtexref`` handle, to be passed to :clas... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dask__dask-8248@ea36400 | dask/dask | Python | 8,248 | Make slice errors match numpy | - [ ] Partially fixes #8229
- [ ] Tests added / passed
- [ ] Passes `black dask` / `flake8 dask` / `isort dask`
| 2021-10-11T15:56:10Z | Unexpected behaviour with out-of-bound indices
**What happened**:
I encountered the following issue when slicing a Dask array with a one-dimensional Dask array of integers. If the array used for slicing contains indices that are out of range in addition to some valid indices, I would expect an `IndexError` to be rai... | Thank you for opening this issue. I agree with your assessment that this behavior is unexpected and can be cleaned up. Are you interested in opening a pull request?
I ended up taking a look and changing the error messages is relatively straightforward, but correcting the results is more involved. I think this might hav... | [
{
"body": "**What happened**:\r\n\r\nI encountered the following issue when slicing a Dask array with a one-dimensional Dask array of integers. If the array used for slicing contains indices that are out of range in addition to some valid indices, I would expect an `IndexError` to be raised. Instead, no error i... | e93f4d5b42862f92f0fe6246ac9f68ab9d56ebe3 | {
"head_commit": "ea36400eb6ac0d50c74510ca562c0ff230662730",
"head_commit_message": "Make slice errors match numpy",
"patch_to_review": "diff --git a/dask/array/slicing.py b/dask/array/slicing.py\nindex 59f17489e54..f2d8c70ed85 100644\n--- a/dask/array/slicing.py\n+++ b/dask/array/slicing.py\n@@ -912,54 +912,54 @... | [
{
"diff_hunk": "@@ -973,25 +973,23 @@ def check_index(ind, dimension):\n if ind.dtype == bool:\n if ind.size != dimension:\n raise IndexError(\n- \"Boolean array length %s doesn't equal dimension %s\"\n- % (ind.size, dimension)\n+ ... | 3994bf31078016477b4ab8c0de5bcfc8bd0c010a | diff --git a/dask/array/slicing.py b/dask/array/slicing.py
index 59f17489e54..5a49da726f5 100644
--- a/dask/array/slicing.py
+++ b/dask/array/slicing.py
@@ -912,54 +912,54 @@ def normalize_index(idx, shape):
else:
none_shape.append(None)
- for i, d in zip(idx, none_shape):
+ for axis, (i, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-4739@034cdfa | deepset-ai/haystack | Python | 4,739 | fix: Tiktoken does not support Azure gpt-35-turbo | ### Related Issues
- Fixes #4738 4738
### Proposed Changes:
Just force the tokenizer if the model is `gpt-35-turbo` basically.
### Notes for the reviewer
This is currently in open PR with Tiktoken, but it's been sat there for a while: https://github.com/openai/tiktoken/pull/72
### Checklist
- [X] I have ... | 2023-04-24T11:52:49Z | Azure's gpt-35-turbo gets wrong max_token_limit
**Describe the bug**
Due to Tiktoken's lack of support for Azure's `gpt-35-turbo`, the open_ai_utils.py script returns the wrong value for the max token length.
**Error message**
Returned token length is default of 2049
**Expected behavior**
Token length should b... | [
{
"body": "**Describe the bug**\r\nDue to Tiktoken's lack of support for Azure's `gpt-35-turbo`, the open_ai_utils.py script returns the wrong value for the max token length.\r\n\r\n**Error message**\r\nReturned token length is default of 2049\r\n\r\n**Expected behavior**\r\nToken length should be 4096\r\n",
... | 7db025a97bd9b5cce611988a245ffea4790281a0 | {
"head_commit": "034cdfa5c51212286c84d1085bc17bc8aed1bbf9",
"head_commit_message": "Remove trailing whitespace",
"patch_to_review": "diff --git a/haystack/utils/openai_utils.py b/haystack/utils/openai_utils.py\nindex 66fef9c5ce..289fb7dd04 100644\n--- a/haystack/utils/openai_utils.py\n+++ b/haystack/utils/openai... | [
{
"diff_hunk": "@@ -110,6 +114,10 @@ def _openai_text_completion_tokenization_details(model_name: str):\n elif model_name.startswith(\"gpt-3\"):\n max_tokens_limit = 4096\n tokenizer_name = model_tokenizer\n+ # covering the lack of support in Tiktoken. https://github.com/o... | d18a82e52c6c2698e59bf563b725627146d6c1dd | diff --git a/haystack/utils/openai_utils.py b/haystack/utils/openai_utils.py
index 66fef9c5ce..eccb5676cf 100644
--- a/haystack/utils/openai_utils.py
+++ b/haystack/utils/openai_utils.py
@@ -99,6 +99,10 @@ def _openai_text_completion_tokenization_details(model_name: str):
max_tokens_limit = 2049 # Based on this r... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
cupy__cupy-2426@1169dca | cupy/cupy | Python | 2,426 | Support separate compilation in `RawKernel` | Resolves #2324. The example there can be run with this PR.
The main change of this PR is two-fold:
1. add wrappers for `cuLinkAddFile` at various levels (driver & function),
2. link to CUDA device runtime (cudadevrt) if requested.
***UPDATE:*** With this PR the separate compilation becomes possible. The dynamic... | 2019-08-23T18:27:54Z | Dynamic Parallelism
I am interested in utilizing Dynamic Parallelism in my cupy projects.
```cpp
extern "C"
{
__global__ void test_kernel_inner()
{
printf(" Hello inner world!\n");
}
__global__ void test_kernel()
{
printf("Hello outer world!\n");
test_kernel_inner<<<2, 1>>>();
}
}
`... | ref: https://stackoverflow.com/questions/57152396/dynamic-parallelism-in-cupy
@palmerss could you test #2426? With that your example worked in my environment.
I will have time to test within the next week or two! Sorry for the delay.
@leofang This seems to be working correctly :) thanks!
@palmerss Thank you for testing... | [
{
"body": "I am interested in utilizing Dynamic Parallelism in my cupy projects. \r\n```cpp\r\nextern \"C\"\r\n{\r\n\r\n__global__ void test_kernel_inner()\r\n{\r\n printf(\" Hello inner world!\\n\");\r\n\r\n}\r\n\r\n__global__ void test_kernel()\r\n{\r\n printf(\"Hello outer world!\\n\");\r\n test_ke... | 810f10ff35145d37b49fbcabb80e1b0e07835041 | {
"head_commit": "1169dcae9f870c181593448ebd9d52f3a3ba1af8",
"head_commit_message": "Fixed path on Win",
"patch_to_review": "diff --git a/cupy/cuda/compiler.py b/cupy/cuda/compiler.py\nindex d2a40fd4351..27ddbc7cb67 100644\n--- a/cupy/cuda/compiler.py\n+++ b/cupy/cuda/compiler.py\n@@ -16,6 +16,8 @@\n \n _nvrtc_ve... | [
{
"diff_hunk": "@@ -67,6 +69,27 @@ def _get_arch():\n _nvrtc_max_compute_capability)\n \n \n+def _check_cudadevrt_needed(options):\n+ require_cudadevrt = False\n+ for option in options:\n+ if option in ('--device-c', '-dc', '-rdc=true',",
"line": null,
"original_line": 75,
... | ff95d378043d035d320c0109b0596fcb5476b954 | diff --git a/cupy/cuda/compiler.py b/cupy/cuda/compiler.py
index d2a40fd4351..7604928b9c7 100644
--- a/cupy/cuda/compiler.py
+++ b/cupy/cuda/compiler.py
@@ -16,6 +16,10 @@
_nvrtc_version = None
_nvrtc_max_compute_capability = None
+_win32 = sys.platform.startswith('win32')
+_rdc_flags = ('--device-c', '-dc', '-rdc=... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dask__dask-7974@88a13f7 | dask/dask | Python | 7,974 | Add colors to represent high level layer types | - [ ] Closes #7919
- [x] Tests passed
- [x] Passes `black dask` / `flake8 dask` / `isort dask`
In this PR, I have added an extra attribute to the graphviz output of High-Level graphs - node fill color. Nodes are colored on the basis of their `layer_type`.
This was achieved by using DOT's `fillcolor` attribute... | 2021-08-02T10:08:04Z | Categorise high level layers for display
There are currently a concrete number of subclasses of the base highlevelgraph.Layer. Some of these have specific contexts or collection linkage (array Vs dataframe), others do not. For the sake of the work being done by @freyam , it would be nice to create some categories for t... | cc @GenevieveBuckley
This is amazing! I will get started on finding more about this and share my findings here! :rocket:
I suggest starting with a concrete list of the current known implementations of Layer.
# List of Layers
## General
```py
# High level graph layer
class Layer(collections.abc.Mapping)
# Ful... | [
{
"body": "There are currently a concrete number of subclasses of the base highlevelgraph.Layer. Some of these have specific contexts or collection linkage (array Vs dataframe), others do not. For the sake of the work being done by @freyam , it would be nice to create some categories for the purpose of being sh... | 4a59a6827578fdf8e105d1fb7e9d50d428c9d5fa | {
"head_commit": "88a13f77f374a11425961c074f4e579f3befe721",
"head_commit_message": "update doc",
"patch_to_review": "diff --git a/dask/base.py b/dask/base.py\nindex d321269fd7a..9bc6996ecb6 100644\n--- a/dask/base.py\n+++ b/dask/base.py\n@@ -571,7 +571,7 @@ def compute(*args, **kwargs):\n \n def visualize(*args,... | [
{
"diff_hunk": "@@ -571,15 +571,15 @@ def compute(*args, **kwargs):\n \n def visualize(*args, **kwargs):\n \"\"\"\n- Visualize several dask graphs at once.\n+ Visualize a dask low level graph.",
"line": null,
"original_line": 574,
"original_start_line": null,
"path": "dask/base.py",
... | cf39759f10bc06107b48fa2cc307b6db6a3e42d0 | diff --git a/dask/base.py b/dask/base.py
index d321269fd7a..2c9cf3ac89e 100644
--- a/dask/base.py
+++ b/dask/base.py
@@ -571,15 +571,15 @@ def compute(*args, **kwargs):
def visualize(*args, **kwargs):
"""
- Visualize several dask graphs at once.
+ Visualize several low level dask graphs at once.
Re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
cupy__cupy-1819@566f041 | cupy/cupy | Python | 1,819 | Add `order` argument to` empty_like`,` zeros_like`, etc. | closes #1654 | 2018-11-23T21:02:55Z | Feature: preserve memory layout order in empty_like, etc?
One thing that was surprising to me on using `cupy.zeros_like`, `cupy.empty_like` or `cupy.ones_like` were that when the input array was Fortran-ordered, the output is C-ordered. This differs from the NumPy behavior which preserves order. I see that it the docst... | [
{
"body": "One thing that was surprising to me on using `cupy.zeros_like`, `cupy.empty_like` or `cupy.ones_like` were that when the input array was Fortran-ordered, the output is C-ordered. This differs from the NumPy behavior which preserves order. I see that it the docstring does state that \"this function do... | 7f219da6ce618b5da70233fbbddb34ce2ac503f2 | {
"head_commit": "566f0416163510b635e3ab0f67f1512713d22ebe",
"head_commit_message": "pep8 fix",
"patch_to_review": "diff --git a/cupy/creation/basic.py b/cupy/creation/basic.py\nindex ba429f56078..13cff939c6b 100644\n--- a/cupy/creation/basic.py\n+++ b/cupy/creation/basic.py\n@@ -20,7 +20,56 @@ def empty(shape, d... | [
{
"diff_hunk": "@@ -20,14 +20,67 @@ def empty(shape, dtype=float, order='C'):\n return cupy.ndarray(shape, dtype, order=order)\n \n \n-def empty_like(a, dtype=None):\n+def _new_like_order_and_strides(a, dtype, order):\n+ \"\"\"\n+ Determine order and strides as in NumPy's PyArray_NewLikeArray.\n+\n+ ... | 4876f49af0982770fe754be16859cbc3fb968c33 | diff --git a/cupy/core/core.pyx b/cupy/core/core.pyx
index b7263c11fe2..13e694441c6 100644
--- a/cupy/core/core.pyx
+++ b/cupy/core/core.pyx
@@ -390,26 +390,10 @@ cdef class ndarray:
order_char == 'F' and self._f_contiguous):
return self
- if order_char == 'A':
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
dask__dask-7894@8758799 | dask/dask | Python | 7,894 | Fix map_overlap trimming behavior when drop_axis is not None | This is a bug fix PR
It regenerates the depth and boundary variables, taking `drop_axis` into account before calling `trim_internal`
- [x] Closes #7893 (See more detailed description and example there)
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask` / `isort dask`
| 2021-07-14T03:51:29Z | map_overlap does not always trim properly when drop_axis is not None
**What happened**:
If either the `depth` or `boundary` argument to `map_overlap` is not the same for all axes and `trim=True`, then the code that trims the output does not take `drop_axis` into account, leading to incorrect trimming.
**What you ... | [
{
"body": "**What happened**:\r\n\r\nIf either the `depth` or `boundary` argument to `map_overlap` is not the same for all axes and `trim=True`, then the code that trims the output does not take `drop_axis` into account, leading to incorrect trimming.\r\n\r\n**What you expected to happen**:\r\n\r\nWhen axes are... | bf4bc7dd8dc96021b171e0941abde7a5f60ce89f | {
"head_commit": "87587998881541f4527fda9e531551c4769ec4ab",
"head_commit_message": "TST: add test case for map_overlap with drop_axis and non-uniform depth",
"patch_to_review": "diff --git a/dask/array/overlap.py b/dask/array/overlap.py\nindex 3f9550e2e86..8ff62f39345 100644\n--- a/dask/array/overlap.py\n+++ b/d... | [
{
"diff_hunk": "@@ -696,7 +696,16 @@ def assert_int_chunksize(xs):\n # Find index of array argument with maximum rank and break ties by choosing first provided\n i = sorted(enumerate(args), key=lambda v: (v[1].ndim, -v[0]))[-1][0]\n # Trim using depth/boundary setting for array of highes... | 3b156d53609c7b1a9bdbdebd22e87923853b6cd8 | diff --git a/dask/array/overlap.py b/dask/array/overlap.py
index 3f9550e2e86..6d771a81d32 100644
--- a/dask/array/overlap.py
+++ b/dask/array/overlap.py
@@ -1,5 +1,5 @@
import warnings
-from numbers import Integral
+from numbers import Integral, Number
import numpy as np
from tlz import concat, get, partial
@@ -69... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
cupy__cupy-2081@288fba8 | cupy/cupy | Python | 2,081 | Optimize the initialization of `List[ndarray]` in `cupy.array` | - Implement `cupy.array(<List[cupy.ndarray]>)`
- Improve the performance of `cupy.array(<List[numpy.ndarray]>)`
Fixes #409 and #1084. Ref #1030. | 2019-03-04T07:46:09Z | cupy.asarray doesn't accept list of cupy.ndarray
Both `numpy.asarray` and `cupy.asarray` accept list of `numpy.ndarray`:
```
>>> numpy.asarray([numpy.zeros(1)])
array([[ 0.]])
>>> cupy.asarray([numpy.zeros(1)])
array([[ 0.]])
```
However, `cupy.asarray` doesn't accept list of `cupy.ndarray`:
```
>>> cupy... | When writing code with Chainer, `Unsupported dtype object` was one of the common issue, especially in pre-processing code that is both compatible with NumPy/CuPy.
It is hard to guess the reason from this error message for first-timers.
How about documenting it in https://docs-cupy.chainer.org/en/stable/reference/di... | [
{
"body": "Both `numpy.asarray` and `cupy.asarray` accept list of `numpy.ndarray`:\r\n\r\n```\r\n>>> numpy.asarray([numpy.zeros(1)])\r\narray([[ 0.]])\r\n>>> cupy.asarray([numpy.zeros(1)])\r\narray([[ 0.]])\r\n```\r\n\r\nHowever, `cupy.asarray` doesn't accept list of `cupy.ndarray`:\r\n\r\n```\r\n>>> cupy.asarr... | 52aab3365ff3eae3b2c62fe9e7ad5fe83d11488d | {
"head_commit": "288fba86aa64f71840e6ca589d0979572c80cbcd",
"head_commit_message": "add tests for a list of views",
"patch_to_review": "diff --git a/cupy/core/core.pxd b/cupy/core/core.pxd\nindex 35d32f5591e..d064890f359 100644\n--- a/cupy/core/core.pxd\n+++ b/cupy/core/core.pxd\n@@ -94,6 +94,14 @@ cdef class In... | [
{
"diff_hunk": "@@ -1717,51 +1719,177 @@ cpdef ndarray array(obj, dtype=None, bint copy=True, order='K',\n elif hasattr(obj, '__cuda_array_interface__'):\n return array(_convert_object_with_cuda_array_interface(obj),\n dtype, copy, order, subok, ndmin)\n+ else: # obj is sequ... | f24918af5f049eb4c9e67e8374009f7533ce882f | diff --git a/cupy/core/core.pyx b/cupy/core/core.pyx
index 7f089a63540..1f9c888b18f 100644
--- a/cupy/core/core.pyx
+++ b/cupy/core/core.pyx
@@ -1695,10 +1695,12 @@ cpdef ndarray array(obj, dtype=None, bint copy=True, order='K',
cdef Py_ssize_t ndim
cdef ndarray a, src
cdef size_t nbytes
+
if subok:... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dask__dask-7935@0f2cb69 | dask/dask | Python | 7,935 | Add tail and head to SeriesGroupby (#7934) | - [x] Closes #7934
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask` / `isort dask`
| 2021-07-25T21:19:37Z | Series GroupBy head and tail
I'd like to be able to use head and tail on group-by Series. Today, I can do this in pandas but not dask.
```python
import pandas as pd
import dask.dataframe as dd
pdf = pd.DataFrame({
"a": [0,1,0,1,1,0],
"b": range(6),
"c": ["a","b","c","d","e","f"]
})
ddf = dd.from... | Looks like the `head` and `tail` methods are defined in the `_Frame` class, but the `SeriesGroupBy` class inherits only from `_GroupBy` and so doesn't know anything about them.
https://github.com/dask/dask/blob/1fab96cb763e7273079083d0093a55aad096549e/dask/dataframe/core.py#L1057-L1121
Ah, I see you have a WIP open... | [
{
"body": "I'd like to be able to use head and tail on group-by Series. Today, I can do this in pandas but not dask.\r\n```python\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\n\r\npdf = pd.DataFrame({\r\n \"a\": [0,1,0,1,1,0],\r\n \"b\": range(6),\r\n \"c\": [\"a\",\"b\",\"c\",\"d\",\"e\",\"... | d3bf07cec0b77c37b3ec1c8c30a3ae0cf00a993a | {
"head_commit": "0f2cb69c5d622f39e3f4127d2e099411f05e1893",
"head_commit_message": "fix issue with index levels",
"patch_to_review": "diff --git a/dask/dataframe/groupby.py b/dask/dataframe/groupby.py\nindex a845c8ada63..cbc53287536 100644\n--- a/dask/dataframe/groupby.py\n+++ b/dask/dataframe/groupby.py\n@@ -11... | [
{
"diff_hunk": "@@ -1143,6 +1143,7 @@ def _aca_agg(\n token,\n func,\n aggfunc=None,\n+ metafunc=None,",
"line": null,
"original_line": 1143,
"original_start_line": null,
"path": "dask/dataframe/groupby.py",
"start_line": null,
"text": "@user1:\nIt would pr... | b06b39a0950b1478f95eb4fb05cdcac920883b8c | diff --git a/dask/dataframe/groupby.py b/dask/dataframe/groupby.py
index a845c8ada63..03605d454c5 100644
--- a/dask/dataframe/groupby.py
+++ b/dask/dataframe/groupby.py
@@ -1140,6 +1140,7 @@ def _aca_agg(
token,
func,
aggfunc=None,
+ meta=None,
split_every=None,
split... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
cupy__cupy-1355@990addc | cupy/cupy | Python | 1,355 | Support weak reference to CuPy array | fix #1346 | 2018-06-13T00:08:34Z | Support weak reference of CuPy array
The following code fails with 'TypeError: cannot create weak reference to 'cupy.core.core.ndarray' object'
```
import numpy as np
import weakref
import chainer
from chainer.backends import cuda
x_np = np.array([3.2, 9.1])
# this works
np_weak_ref = weakref.ref(x_np)
... | [
{
"body": "The following code fails with 'TypeError: cannot create weak reference to 'cupy.core.core.ndarray' object'\r\n```\r\nimport numpy as np\r\n\r\nimport weakref\r\nimport chainer\r\nfrom chainer.backends import cuda\r\n\r\nx_np = np.array([3.2, 9.1])\r\n# this works\r\nnp_weak_ref = weakref.ref(x_np)\r\... | 36ea293b9af860c3f7afa4b53b750ca43d92e424 | {
"head_commit": "990addc7f21d8cd60eaa1870fd102964fd5f7eb7",
"head_commit_message": "edits",
"patch_to_review": "diff --git a/cupy/core/core.pxd b/cupy/core/core.pxd\nindex 2dc7b0d6097..548584fdd9a 100644\n--- a/cupy/core/core.pxd\n+++ b/cupy/core/core.pxd\n@@ -4,6 +4,7 @@ from cupy.cuda cimport memory\n from cup... | [
{
"diff_hunk": "@@ -4,6 +4,7 @@ from cupy.cuda cimport memory\n from cupy.cuda.function cimport CPointer\n \n cdef class ndarray:\n+ cdef object __weakref__",
"line": null,
"original_line": 7,
"original_start_line": null,
"path": "cupy/core/core.pxd",
"start_line": null,
"text": "@use... | b9418cdbd4191dd356dc7c5d483c4defff5b6c18 | diff --git a/cupy/core/core.pxd b/cupy/core/core.pxd
index 2dc7b0d6097..7140b73b573 100644
--- a/cupy/core/core.pxd
+++ b/cupy/core/core.pxd
@@ -5,6 +5,7 @@ from cupy.cuda.function cimport CPointer
cdef class ndarray:
cdef:
+ object __weakref__
readonly Py_ssize_t size
public vector.vec... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
cupy__cupy-1209@755dad5 | cupy/cupy | Python | 1,209 | Fix default dtype of full | This PR fixes #1203. The default `dtype` of `cupy.full` should be determined by `fill_value`. | 2018-04-27T04:29:29Z | default type of `full`is int in numpy but float in cupy
```python
In [53]: np.full((2,2), -1)
Out[53]:
array([[-1, -1],
[-1, -1]])
In [54]: cp.full((2,2), -1)
Out[54]:
array([[-1., -1.],
[-1., -1.]])
In [55]: cp.full((2,2), -1, dtype=int)
Out[55]:
array([[-1, -1],
[-1, -1]])
``` | [
{
"body": "```python\r\nIn [53]: np.full((2,2), -1)\r\nOut[53]:\r\narray([[-1, -1],\r\n [-1, -1]])\r\n\r\nIn [54]: cp.full((2,2), -1)\r\nOut[54]:\r\narray([[-1., -1.],\r\n [-1., -1.]])\r\n\r\nIn [55]: cp.full((2,2), -1, dtype=int)\r\nOut[55]:\r\narray([[-1, -1],\r\n [-1, -1]])\r\n```",
"nu... | 6162f9ac78b40e8cc6897f51dba9bb80bbbc8610 | {
"head_commit": "755dad5797ffa75e75a20ae9c540af7e12a1fe35",
"head_commit_message": "Fix default dtype of full",
"patch_to_review": "diff --git a/cupy/creation/basic.py b/cupy/creation/basic.py\nindex 0e28f2e0a33..57ae51d910a 100644\n--- a/cupy/creation/basic.py\n+++ b/cupy/creation/basic.py\n@@ -188,6 +188,8 @@ ... | [
{
"diff_hunk": "@@ -188,6 +188,8 @@ def full(shape, fill_value, dtype=None):\n \n \"\"\"\n # TODO(beam2d): Support ordering option\n+ if dtype is None:\n+ dtype = cupy.array(fill_value).dtype",
"line": null,
"original_line": 192,
"original_start_line": null,
"path": "cupy/creat... | a5218db7a278a2319a735073b094aa8db02116e3 | diff --git a/cupy/creation/basic.py b/cupy/creation/basic.py
index 0e28f2e0a33..d11ca6c6681 100644
--- a/cupy/creation/basic.py
+++ b/cupy/creation/basic.py
@@ -1,4 +1,5 @@
import cupy
+import numpy
def empty(shape, dtype=float, order='C'):
@@ -188,6 +189,11 @@ def full(shape, fill_value, dtype=None):
"""
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
cupy__cupy-1239@fc25386 | cupy/cupy | Python | 1,239 | Fix dtype option of sum and prod | This PR fixes the logic of `dtype` argument of `sum` and `prod`, so that it enables e.g.
`cupy.sum(cupy.arange(3).astype(cupy.int16), dtype=cupy.int32)`
close #1240. | 2018-05-13T19:31:08Z | sum without upcast
`cupy.sum` and `cupy.prod` upcasts ints (or bool) to `int64` or `uint64`, to align with numpy. This feature would be disabled with `x.sum(dtype=x.dtype)` but not supported in cupy.
```
>>> x = cupy.arange(3).astype(cupy.int16)
>>> x.sum(dtype=x.dtype)
Traceback (most recent call last):
File "... | [
{
"body": "`cupy.sum` and `cupy.prod` upcasts ints (or bool) to `int64` or `uint64`, to align with numpy. This feature would be disabled with `x.sum(dtype=x.dtype)` but not supported in cupy.\r\n```\r\n>>> x = cupy.arange(3).astype(cupy.int16)\r\n>>> x.sum(dtype=x.dtype)\r\nTraceback (most recent call last):\r... | e07882ae4b496f6966ebb31d2b08fcbb7399002d | {
"head_commit": "fc25386327f7b41850234d6653f7f6fc152c046b",
"head_commit_message": "remove tests between real and compex",
"patch_to_review": "diff --git a/cupy/core/core.pyx b/cupy/core/core.pyx\nindex 03f901e72d4..183d087f397 100644\n--- a/cupy/core/core.pyx\n+++ b/cupy/core/core.pyx\n@@ -1144,7 +1144,10 @@ cd... | [
{
"diff_hunk": "@@ -118,6 +118,16 @@ def test_sum_axes4(self, xp, dtype):\n a = testing.shaped_arange((20, 30, 40, 50), xp, dtype)\n return a.sum(axis=(0, 2, 3))\n \n+ @testing.for_all_dtypes_combination(names=['src_dtype', 'dst_dtype'])\n+ @testing.numpy_cupy_allclose()\n+ def test_sum... | fce962446ea0b0ebe556cd0f7b92edbc51b4e12a | diff --git a/cupy/core/core.pyx b/cupy/core/core.pyx
index 03f901e72d4..90516fd647a 100644
--- a/cupy/core/core.pyx
+++ b/cupy/core/core.pyx
@@ -1144,7 +1144,10 @@ cdef class ndarray:
:meth:`numpy.ndarray.sum`
"""
- return _sum(self, axis, dtype, out, keepdims)
+ if dtype is None:
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dask__dask-7769@031e3b7 | dask/dask | Python | 7,769 | Evaluate graph lazily if meta is provided in from_delayed | The `from_delayed` no longer is lazy and always computes the first element. This is unfortunate, particularly since the tasks typically involve remote connections.
This is a regression which was introduced in https://github.com/dask/dask/pull/7586
Apparently this was somehow purposefully done, see https://github... | 2021-06-07T14:29:31Z | from_delayed can trigger large computation
**What happened**:
Creation of a dask dataframe from delayed objects now triggers computation.
**What you expected to happen**:
When a using a `dd.from_delayed` with the `meta` keyword, no computation should be done.
**Minimal Complete Verifiable Example**:
The ... | I think [this line](https://github.com/dask/dask/blob/d9df00058f3b52b6c6d26ed836fbed9a7e3b4232/dask/dataframe/io/io.py#L591) is the culprit.
I'm not familiar with what `parent_meta` is representing here. @galipremsagar , what is the intention here, and is it possible to avoid triggering a computation? | [
{
"body": "**What happened**:\r\n\r\nCreation of a dask dataframe from delayed objects now triggers computation.\r\n\r\n**What you expected to happen**:\r\n\r\nWhen a using a `dd.from_delayed` with the `meta` keyword, no computation should be done.\r\n\r\n**Minimal Complete Verifiable Example**:\r\n\r\nThe foll... | e6df62058431b6b652f2d6f5759e74e7bb809116 | {
"head_commit": "031e3b7ab5a5b52d05f8041748996003559b011d",
"head_commit_message": "Evaluate graph lazily if meta is provided in from_delayed",
"patch_to_review": "diff --git a/dask/dataframe/io/io.py b/dask/dataframe/io/io.py\nindex 266f375f3d3..8ec331fcaf5 100644\n--- a/dask/dataframe/io/io.py\n+++ b/dask/data... | [
{
"diff_hunk": "@@ -2189,6 +2189,27 @@ def test_fillna():\n assert_eq(df.fillna(method=\"pad\", limit=3), ddf.fillna(method=\"pad\", limit=3))\n \n \n+def test_from_delayed_lazy_if_meta_provided():\n+ \"\"\"Ensure that the graph is 100% lazily evaluted if meta is provided\"\"\"\n+\n+ @dask.delayed\n+ ... | 1b5dbe200e367f28ea2853de88997b92b4e9d106 | diff --git a/dask/dataframe/io/io.py b/dask/dataframe/io/io.py
index 266f375f3d3..8ec331fcaf5 100644
--- a/dask/dataframe/io/io.py
+++ b/dask/dataframe/io/io.py
@@ -584,16 +584,18 @@ def from_delayed(
delayed(df) if not isinstance(df, Delayed) and hasattr(df, "key") else df
for df in dfs
]
+
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-4545@252ab37 | deepset-ai/haystack | Python | 4,545 | feat: Load documents from remote - helper function | First step of the Community Sprint issue I'm working on with @recrudesce #2372
- introduces a helper function in utils to 'load dataset from remote'
- Checks that the dataset exists
- Checks that the dataset has the required fields to _be_ a Haystack document
Can someone guide us as to how we should handle escep... | 2023-03-29T14:36:50Z | Add a helper function to get datasets from HF and write them to a DocumentStore
As suggested by @vblagoje on the Haystack slack, it would be nice to have a helper function, similar to `open_search_index_to_documentstore` or `convert_files_to_docs` that would allow users to provide a HF dataset name and that would write... | Hey @ZanSara, I'm a research engineer working on language modelling and wanting to contribute to open source. I was wondering if this is still open and if I could try to implement a solution?
Hey @jackapbutler - it is still open actually yes :) - me and @mayankjobanputra were working on an implementation idea. Our curr... | [
{
"body": "As suggested by @vblagoje on the Haystack slack, it would be nice to have a helper function, similar to `open_search_index_to_documentstore` or `convert_files_to_docs` that would allow users to provide a HF dataset name and that would write them in Document format to a DocumentStore",
"number": 2... | c20286609385b6d0b5cf0a174ec8775fbbd50c33 | {
"head_commit": "252ab373b79c47b898cd6909f77f27dfc0983eae",
"head_commit_message": "fixed black",
"patch_to_review": "diff --git a/haystack/utils/import_utils.py b/haystack/utils/import_utils.py\nindex 5a1385a2e9..de92eaa3bb 100644\n--- a/haystack/utils/import_utils.py\n+++ b/haystack/utils/import_utils.py\n@@ -... | [
{
"diff_hunk": "@@ -62,6 +63,30 @@ def _optional_component_not_installed(component: str, dep_group: str, source_err\n ) from source_error\n \n \n+def load_documents_from_datasets(dataset_name: str, split: Optional[str] = \"train\") -> List[Document]:\n+ \"\"\"\n+ Load a list of Haystack Documents from... | 5c8aaa5b5a3e8d46b26e2f4a333b859613ba15ed | diff --git a/haystack/errors.py b/haystack/errors.py
index 3ad605252c..d9cf31f998 100644
--- a/haystack/errors.py
+++ b/haystack/errors.py
@@ -62,6 +62,17 @@ def __init__(
super().__init__(message=message, docs_link=docs_link)
+class DatasetsError(HaystackError):
+ """Exception for issues raised within ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-7760@0f52ea3 | dask/dask | Python | 7,760 | Initial da.select() implementation and test (#6067) | - [X] Closes #6067
- [X] Tests added / passed
- [X] Passes `black dask` / `flake8 dask` / `isort dask`
̉First contribution! :muscle:
I just implemented it as much as `da.piecewise()`, there are potential improvements as benchmarks, tests for broadcasting, but I think that it works for a first implementation. | 2021-06-03T23:36:59Z | Please implement numpy.select()
4. **Feature Request:** then please do a quick search of existing issues to
make sure that this has not been asked before.
This is a feature request. I have been convert my pandas code for dask and couldnt find a substitution for numpy.select(). My current workaround is to use .ap... | Thanks for raising an issue @Biarys. Adding a `da.select` method would be a welcome contribution, is this something you're interesting in working on (no obligation though)? There's already a `da.where` method, as `da.select` provides similar functionality, looking at how things are implemented in `da.where` would be a ... | [
{
"body": "4. **Feature Request:** then please do a quick search of existing issues to\r\n make sure that this has not been asked before.\r\nThis is a feature request. I have been convert my pandas code for dask and couldnt find a substitution for numpy.select(). My current workaround is to use .apply() wit... | c6b1426159ce7401bc4512c048ebe95ca33b94a7 | {
"head_commit": "0f52ea32c5c531588dee8dbbcace4b970a4fc289",
"head_commit_message": "Initial da.select() implementation and test (#6067)",
"patch_to_review": "diff --git a/dask/array/__init__.py b/dask/array/__init__.py\nindex 5996e09243a..a4fb819509f 100644\n--- a/dask/array/__init__.py\n+++ b/dask/array/__init_... | [
{
"diff_hunk": "@@ -1843,6 +1843,22 @@ def piecewise(x, condlist, funclist, *args, **kw):\n )\n \n \n+@derived_from(np)\n+def select(condlist, choicelist, default=0):\n+ return blockwise(\n+ np.select,\n+ \"m\",\n+ condlist,\n+ \"nm\",",
"line": null,
"original_line": ... | a8bcd75f165196ba7058b52ac69138aa10042234 | diff --git a/dask/array/__init__.py b/dask/array/__init__.py
index 5996e09243a..a4fb819509f 100644
--- a/dask/array/__init__.py
+++ b/dask/array/__init__.py
@@ -134,6 +134,7 @@
rot90,
round,
searchsorted,
+ select,
shape,
squeeze,
swapaxes,
diff --git a/dask/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-4562@4c07845 | deepset-ai/haystack | Python | 4,562 | fix: ParsrConverter list element added | This PR tackles the following issue [https://github.com/deepset-ai/haystack/issues/4156](https://github.com/deepset-ai/haystack/issues/4156) in the context of the Community Sprint.
### Related Issues
- fixes #4156
### Proposed Changes:
As the issuer reported, ParsrConverter is not mapping currently the element... | 2023-03-30T14:03:42Z | fix: "list" support missing in ParsrConverter
**Describe the bug**
In the ParsrConverter, the "list" type is missing in haystack/nodes/file_converter/parsr.py line 176.
**Error message**
The contents of type "list" are missing in the output document.
**Expected behavior**
The contents should be appended and ad... | I am picking this issue in the context of the first virtual community sprint [https://github.com/deepset-ai/haystack/discussions/4489](https://github.com/deepset-ai/haystack/discussions/4489)
I was playing with the code and I've confirmed the content of type "list" is not being mapped from a ParsrDocument into a Haysta... | [
{
"body": "**Describe the bug**\r\nIn the ParsrConverter, the \"list\" type is missing in haystack/nodes/file_converter/parsr.py line 176.\r\n\r\n**Error message**\r\nThe contents of type \"list\" are missing in the output document.\r\n\r\n**Expected behavior**\r\nThe contents should be appended and added to th... | 1ac9ca7fac276f1cd299c8f2923f609a82d06b32 | {
"head_commit": "4c0784558ff29e12cf786cdf7baea2d36604537e",
"head_commit_message": "fix: list element and mapping logic around it added to ParsrConverter convert step + unit test covering the specific mapping of list content from Parsr's to Haystack's",
"patch_to_review": "diff --git a/haystack/nodes/file_conver... | [
{
"diff_hunk": "@@ -243,6 +243,10 @@ def _convert_text_element(self, element: Dict[str, Any]) -> str:\n current_paragraph = \"\\n\".join([self._get_paragraph_string(elem) for elem in element[\"content\"]])\n return current_paragraph\n \n+ if element[\"type\"] == \"list\":"... | 9fc353440c244fdc5b57d44fce67f6bec3718f4e | diff --git a/haystack/nodes/file_converter/parsr.py b/haystack/nodes/file_converter/parsr.py
index e4036be044..d307b3dacd 100644
--- a/haystack/nodes/file_converter/parsr.py
+++ b/haystack/nodes/file_converter/parsr.py
@@ -173,7 +173,7 @@ def convert(
headlines = []
for page_idx, page in enume... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cupy__cupy-565@584b496 | cupy/cupy | Python | 565 | Fix csrmm2 to support transa | I noticed that I misunderstood arguments `m` and `n` in `csrmm2` especially when `transa=True`.
fix #552 | 2017-10-02T01:41:27Z | csrmm2 crashes when using transa=True
When running the following code
```
import numpy as np
import scipy.sparse as sp
from chainer import cuda
import cupy
import cupy.sparse
def main():
x = np.random.uniform(-1, 1, (4, 3)).astype(np.float32)
x = cuda.to_gpu(x)
W = sp.csr_matrix(np.random.un... | [
{
"body": "When running the following code\r\n```\r\nimport numpy as np\r\nimport scipy.sparse as sp\r\n\r\nfrom chainer import cuda\r\n\r\nimport cupy\r\nimport cupy.sparse\r\n\r\ndef main():\r\n x = np.random.uniform(-1, 1, (4, 3)).astype(np.float32)\r\n x = cuda.to_gpu(x)\r\n W = sp.csr_matrix(np.ra... | 529fc8338e9e5ed7f4cea322d886fcb6838dd291 | {
"head_commit": "584b49616618cdfa16fc6728476ab6f4b914d32f",
"head_commit_message": "Use random value",
"patch_to_review": "diff --git a/cupy/cusparse.py b/cupy/cusparse.py\nindex 927068e4b7d..b51aa514b27 100644\n--- a/cupy/cusparse.py\n+++ b/cupy/cusparse.py\n@@ -143,7 +143,8 @@ def csrmm(a, b, c=None, alpha=1, ... | [
{
"diff_hunk": "@@ -0,0 +1,91 @@\n+import unittest\n+\n+import numpy\n+try:\n+ import scipy.sparse\n+except ImportError:\n+ pass\n+\n+import cupy\n+from cupy import testing\n+\n+\n+@testing.parameterize(*testing.product({\n+ 'dtype': [numpy.float32, numpy.float64],\n+ 'transa': [True, False],\n+}))\... | 0e36b95d2f21eb0965603f8c99b5e794aa88fe86 | diff --git a/cupy/cusparse.py b/cupy/cusparse.py
index 927068e4b7d..b51aa514b27 100644
--- a/cupy/cusparse.py
+++ b/cupy/cusparse.py
@@ -143,7 +143,8 @@ def csrmm(a, b, c=None, alpha=1, beta=0, transa=False):
beta = numpy.array(beta, a.dtype).ctypes
_call_cusparse(
'csrmm', a.dtype,
- handle, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dask__dask-7719@6477de2 | dask/dask | Python | 7,719 | Add `datetime_is_numeric` to dataframe.describe | Start working on adding `datetime_is_numeric` to the `dataframe.describe` method.
Part of https://github.com/dask/dask/issues/7100
Closes #6434
Update, this is getting closer. The last remaining issue is that the means of `np.datetime` are not correct.
My current thinking is that somehow the empty rows ar... | 2021-05-27T16:02:35Z | Update dataframe.describe for pandas 1.1
In pandas 1.1, the default behavior of handling datetimes has been deprecated. Previously they were treated like categoricals (gave things like unique). In the future they'll be treated like numerics (will give things like quantiles).
```python
In [15]: df = pd.DataFrame({"A... | cc @shwina who might care about these changes as well
NO. This is not a problem. I like this behavior
`# Good ^_^`
`df_in_date_range.describe()`
date | file
-- | --
1808 | 1808
66 | 1806
2021-06-08 21:25:35 | aiml_file_0101b.mp4
67 | 2
2021-06-07 13:24:53 | NaN
2021-06-11 20:31:42 | NaN
VS
`# BAD >:(... | [
{
"body": "In pandas 1.1, the default behavior of handling datetimes has been deprecated. Previously they were treated like categoricals (gave things like unique). In the future they'll be treated like numerics (will give things like quantiles).\r\n\r\n```python\r\nIn [15]: df = pd.DataFrame({\"A\": pd.date_ran... | 6188f6bc2a2698045effdbd782c28cc7c972d34f | {
"head_commit": "6477de21dfd6bc770b05b84275bb692e24108663",
"head_commit_message": "Make sure that it works with pandas < 1.1.0",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex df6f64c5f02..3d326141b40 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@... | [
{
"diff_hunk": "@@ -2464,24 +2464,46 @@ def describe(\n percentiles_method=\"default\",\n include=None,\n exclude=None,\n+ datetime_is_numeric=False,\n ):\n+ if PANDAS_GT_110:\n+ datetime_is_numeric_kwarg = {\"datetime_is_numeric\": datetime_is_numeric}\n+ ... | dced50838f76102ee3f6d31848e1b361dc8a5a30 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index df6f64c5f02..ca8c42b7dc8 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -2464,24 +2464,52 @@ def describe(
percentiles_method="default",
include=None,
exclude=None,
+ datetime_is_numeric=False,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cupy__cupy-347@a2bb5a3 | cupy/cupy | Python | 347 | Support NumPy 1.13 again | This PR includes #281, #336 and #344,
This PR fixes #342. | 2017-08-01T01:48:00Z | numpy<1.13 do not have numpy.AxisError
When using numpy 1.12.1:
```python
>>> import cupy
>>> cupy.cumprod
<function cumprod at 0x7f9a460b4c80>
>>> cupy.cumprod(cupy.ndarray(()), axis=-10000) ... | `numpy.AxisError` was introduced at https://github.com/cupy/cupy/pull/281. | [
{
"body": "When using numpy 1.12.1:\r\n```python\r\n>>> import cupy\r\n>>> cupy.cumprod\r\n<function cumprod at 0x7f9a460b4c80>\r\n>>> cupy.cumprod(cupy.ndarray(()), axis=-10000) ... | 11d7d7bebf73f67511c8fddd55f5c1f07a7e7c3c | {
"head_commit": "a2bb5a371e892a7d6c4d20ded6db2bc1c1e6b17b",
"head_commit_message": "Add underscore",
"patch_to_review": "diff --git a/cupy/core/__init__.py b/cupy/core/__init__.py\nindex 7fc262f748b..dfddabc943b 100644\n--- a/cupy/core/__init__.py\n+++ b/cupy/core/__init__.py\n@@ -3,6 +3,7 @@\n \n \n # import cl... | [
{
"diff_hunk": "@@ -36,6 +36,17 @@ cdef inline _should_use_rop(x, y):\n return xp < yp and not isinstance(y, ndarray)\n \n \n+class IndexOrValueError(IndexError, ValueError):",
"line": null,
"original_line": 39,
"original_start_line": null,
"path": "cupy/core/core.pyx",
"start_line": nul... | 211d3642d417f5d3e8d695eb3e028a69d85caf18 | diff --git a/cupy/core/core.pyx b/cupy/core/core.pyx
index 7b094e57d39..16bc3598456 100644
--- a/cupy/core/core.pyx
+++ b/cupy/core/core.pyx
@@ -36,6 +36,17 @@ cdef inline _should_use_rop(x, y):
return xp < yp and not isinstance(y, ndarray)
+try:
+ _AxisError = numpy.AxisError
+except AttributeError:
+ c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-4454@9db987a | deepset-ai/haystack | Python | 4,454 | feat: prompt at query time | ### Related Issues
- fixes https://github.com/deepset-ai/haystack/issues/4394
### Proposed Changes:
- add `prompt_template` param to `PromptTemplate.run` which can be used in pipelines like this
```python
# p is the pipeline
# PROMPT_TEMPLATE is one of the following
# - PromptTemplate: use the given prompt tem... | 2023-03-17T08:39:13Z | Change prompt at query time for pipelines
**Is your feature request related to a problem? Please describe.**
Currently it's already possible to change the prompt at query time when `PromptNode` is used outside of pipelines via `prompt_template_name` kwarg.
We also want to enable this when `PromptNode` is used in a pi... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nCurrently it's already possible to change the prompt at query time when `PromptNode` is used outside of pipelines via `prompt_template_name` kwarg.\r\nWe also want to enable this when `PromptNode` is used in a pipeline to enable fa... | 382ca8094ec7a5e16c377fd6a816700820dafc64 | {
"head_commit": "9db987ad5289a265a2302c55a4bbe14260f54648",
"head_commit_message": "Merge branch 'main' into feat/prompt_at_query_time",
"patch_to_review": "diff --git a/haystack/agents/base.py b/haystack/agents/base.py\nindex 572346886d..e6af407fc5 100644\n--- a/haystack/agents/base.py\n+++ b/haystack/agents/ba... | [
{
"diff_hunk": "@@ -239,14 +241,22 @@ class PromptTemplate(BasePromptTemplate, ABC):\n [PromptNode](https://docs.haystack.deepset.ai/docs/prompt_node).\n \"\"\"\n \n- def __init__(self, name: str, prompt_text: str, output_parser: Optional[BaseOutputParser] = None):\n+ def __init__(\n+ self,... | 29854069394d8f0408022fef6117e8f143af8c69 | diff --git a/haystack/agents/base.py b/haystack/agents/base.py
index 572346886d..e6af407fc5 100644
--- a/haystack/agents/base.py
+++ b/haystack/agents/base.py
@@ -163,7 +163,12 @@ def __init__(
)
)
self.prompt_node = prompt_node
- self.prompt_template = prompt_node.get_prompt_templ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-4357@9225932 | deepset-ai/haystack | Python | 4,357 | feat: Add ChatGPT PromptNode layer | ### Related Issues
- no relevant issue
### Proposed Changes:
Adds ChatGPTInvocationLayer as PromptModelInvocationLayer implementation for the support of [ChatGPT](https://platform.openai.com/docs/guides/chat) model
Note that `gpt-3.5-turbo` model requires special payload messages to be specified. Having said th... | 2023-03-08T14:42:37Z | add support for gpt-3.5
**Is your feature request related to a problem? Please describe.**
No.
**Describe the solution you'd like**
OpenAI recently launched the API for GPT-3.5, but currently the `OpenAIInvocationLayer` only supports the GPT-3 models (i.e. "ada", "babbage", "davinci", "curie"), not GPT-3.5 (gp... | Thanks for raising this point @observerw ; already in the works. Should be available next week. | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nNo.\r\n\r\n**Describe the solution you'd like**\r\n\r\nOpenAI recently launched the API for GPT-3.5, but currently the `OpenAIInvocationLayer` only supports the GPT-3 models (i.e. \"ada\", \"babbage\", \"davinci\", \"curie\"), ... | f04b2f3cee056c6faa7230462a7d4ef2e4b1661c | {
"head_commit": "9225932d7ef5cc5cde58dd7cb427a434cfe5ed56",
"head_commit_message": "align method name",
"patch_to_review": "diff --git a/haystack/nodes/answer_generator/openai.py b/haystack/nodes/answer_generator/openai.py\nindex ad44c03ffe..8ae2fd9325 100644\n--- a/haystack/nodes/answer_generator/openai.py\n+++... | [
{
"diff_hunk": "@@ -545,3 +547,111 @@ def supports(cls, model_name_or_path: str, **kwargs) -> bool:\n return (\n valid_model and kwargs.get(\"azure_base_url\") is not None and kwargs.get(\"azure_deployment_name\") is not None\n )\n+\n+\n+class ChatGPTInvocationLayer(OpenAIInvocationL... | 4a1b262e70fd1a03ad02c0f4180bdbe704705c44 | diff --git a/haystack/nodes/answer_generator/openai.py b/haystack/nodes/answer_generator/openai.py
index ad44c03ffe..8ae2fd9325 100644
--- a/haystack/nodes/answer_generator/openai.py
+++ b/haystack/nodes/answer_generator/openai.py
@@ -11,7 +11,7 @@
openai_request,
count_openai_tokens,
_openai_text_comple... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dask__dask-7575@2069d8c | dask/dask | Python | 7,575 | Harden DataFrame merge between clumn-selection and index | This PR is intended to fix both of the merge issues discussed in #7558. The first problem is that `searchsorted` fails for object columns when there are null values in the data. The `TypeError` can be avoided by explicitly mapping nulls to the 0th partition. The second problem is that the hash values of an index can... | 2021-04-19T15:12:25Z | Merge produces incorrect results with partitioned data
**What happened**:
Pandas result works, Dask result produces an error and does not work with example above.
Changing in the example below: `df2_d = dd.from_pandas(df2, npartitions=3).set_index('b')` to
`df2_d = dd.from_pandas(df2, npartitions=3).set_index(... | When I ran the example above I get type error:
> TypeError: '<' not supported between instances of 'str' and 'NoneType'
Ah sorry my comment might not have been clear:
```python
import pandas as pd
df1 = pd.DataFrame({'a': ['0', '0', None, None, None, None, '5', '7', '15', '33']})
df2 = pd.DataFrame({'b': ['0', '... | [
{
"body": "**What happened**:\r\n\r\nPandas result works, Dask result produces an error and does not work with example above.\r\n\r\nChanging in the example below: `df2_d = dd.from_pandas(df2, npartitions=3).set_index('b')` to \r\n`df2_d = dd.from_pandas(df2, npartitions=3).set_index('b').repartition(npartitio... | 29e17a05f605a5ad5b8e308540387f489434cde6 | {
"head_commit": "2069d8ca739e16a193561966f30cd3b6243b5fd6",
"head_commit_message": "preserve divisions in Index -> to_frame",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 5ac2bbedf9c..e738ec36370 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -37... | [
{
"diff_hunk": "@@ -209,3 +209,25 @@ def test_merge_known_to_double_bcast_left(\n assert_eq(result, expected)\n assert_eq(result.divisions, ddf_right.divisions)\n assert len(result.__dask_graph__()) < 90\n+\n+\n+@pytest.mark.parametrize(\"repartition\", [None, 4])\n+def test_merge_column_with_nulls(... | 565ed438ff64772f5b65b73099e301a1081c532c | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 5ac2bbedf9c..e738ec36370 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -3710,7 +3710,11 @@ def to_frame(self, index=True, name=None):
raise NotImplementedError()
return self.map_partitions(
- M.to... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-4304@9993e93 | deepset-ai/haystack | Python | 4,304 | build: Use `uvicorn` instead of `gunicorn` as server in REST API's Dockerfile | ### Related Issues
- fixes #3913
### Proposed Changes:
<!--- In case of a bug: Describe what caused the issue and how you solved it -->
<!--- In case of a feature: Describe what did you add and how it works -->
This PR changes the Dockerfile of our REST API to use `uvicorn` as a server instead of using `gunic... | 2023-03-01T10:26:57Z | Investigate alternatives to `gunicorn` settings in REST API
We run the REST API server using the following command:
`gunicorn rest_api.application:app -b 0.0.0.0 -k uvicorn.workers.UvicornWorker --workers 1 --timeout 180`
We suspect that changing the settings could help us make the application more robust and effi... | As we're currently using a single uvicorn worker, there's no need to use a gunicorn server as the process manager - we can directly use uvicorn as suggested in the [FastAPI Docs](https://fastapi.tiangolo.com/de/deployment/docker/#replication-number-of-processes). | [
{
"body": "We run the REST API server using the following command: \r\n`gunicorn rest_api.application:app -b 0.0.0.0 -k uvicorn.workers.UvicornWorker --workers 1 --timeout 180`\r\n\r\nWe suspect that changing the settings could help us make the application more robust and efficient.",
"number": 3913,
"t... | ee7442121294e84409d3f4921b541fdd7e2efe3c | {
"head_commit": "9993e9300602c030300d3ac0401da1b321c8b8fd",
"head_commit_message": "Use uvicorn instead of gunicorn as server",
"patch_to_review": "diff --git a/docker/Dockerfile.api b/docker/Dockerfile.api\nindex 37615c76df..fcf48c2bc4 100644\n--- a/docker/Dockerfile.api\n+++ b/docker/Dockerfile.api\n@@ -3,7 +3... | [
{
"diff_hunk": "@@ -3,7 +3,7 @@ ARG base_image\n \n FROM ${base_image}:${base_image_tag}\n \n-ENV SERVICE_NAME=\"gunicorn-service\"\n+ENV SERVICE_NAME=\"uvicorn-service\"",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "docker/Dockerfile.api",
"start_line": null,
... | 73170d7eba266a0ae1bd3163d7c391444303ef1d | diff --git a/docker/Dockerfile.api b/docker/Dockerfile.api
index 37615c76df..7f1d6141ad 100644
--- a/docker/Dockerfile.api
+++ b/docker/Dockerfile.api
@@ -3,8 +3,10 @@ ARG base_image
FROM ${base_image}:${base_image_tag}
-ENV SERVICE_NAME="gunicorn-service"
+ENV SERVICE_NAME="haystackd"
+# Haystack pipelines are ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
deepset-ai__haystack-4326@2a07850 | deepset-ai/haystack | Python | 4,326 | refactor: Allow flexible document id generation | ### Related Issues
- fixes #4317
### Proposed Changes:
Allow users to choose custom meta keys to be used as part of the id generation. This will help to avoid rebuilding the documents in cases where just part of the meta keys make sense for identification, and sometimes even more than the content.
@julian-risch ... | 2023-03-03T17:23:23Z | Allow more flexible Document id hashing
**Is your feature request related to a problem? Please describe.**
As a Document user, I found myself in a situation where content and meta fields are too broad or too narrow for id calculations. We currently don't allow a specific set of keys in meta to be used as `id_hash_keys... | That's great. Indeed, we use a document builder on top of Haystack because of the lack of flexibility. We store a bunch of metadata and just a small piece of it makes sense for the ID (helping to control when to overwrite, without the need to query before each write and update related documents).
I think this will b... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nAs a Document user, I found myself in a situation where content and meta fields are too broad or too narrow for id calculations. We currently don't allow a specific set of keys in meta to be used as `id_hash_keys` in the Document c... | 19311119db77d409667928bc551fe3b7518b3b1a | {
"head_commit": "2a07850516afddcce8bcccf081b4122815641517",
"head_commit_message": "refactor: allow flexible document id generation",
"patch_to_review": "diff --git a/haystack/schema.py b/haystack/schema.py\nindex 0bda792214..f0acafe2a0 100644\n--- a/haystack/schema.py\n+++ b/haystack/schema.py\n@@ -101,11 +101,... | [
{
"diff_hunk": "@@ -101,11 +101,15 @@ def __init__(\n allowed_hash_key_attributes = [\"content\", \"content_type\", \"score\", \"meta\", \"embedding\"]\n \n if id_hash_keys is not None:\n- if not set(id_hash_keys) <= set(allowed_hash_key_attributes):\n+ if not all(\n+ ... | 3b9adcd1befeb5b315553ae0c55679e7e6de8b41 | diff --git a/haystack/schema.py b/haystack/schema.py
index cf69558b06..4f044bdebf 100644
--- a/haystack/schema.py
+++ b/haystack/schema.py
@@ -88,6 +88,13 @@ def __init__(
In this case, the id is generated by using the content and the defined metadata.
If you ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-7562@c4d5a8c | dask/dask | Python | 7,562 | stack nd array w/unknown chunks | - [x] Closes #7546
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask` / `isort dask`
| 2021-04-15T21:29:02Z | numpy/dask difference in stacking multi-dim arrays with unknown chunk sizes
**What happened**:
When using da.stack and stacking a multi-dim list (of arrays), the allow_unknown_chunksizes parameter is not passed into asarray. This is needed as asarray calls back to stack if it is passed a sequence, and an error is r... | [
{
"body": "**What happened**:\r\n\r\nWhen using da.stack and stacking a multi-dim list (of arrays), the allow_unknown_chunksizes parameter is not passed into asarray. This is needed as asarray calls back to stack if it is passed a sequence, and an error is raised if the unknown chunksize is not the first dimen... | 90fccabb15e10daf7e03811401ab3d2be47d8abb | {
"head_commit": "c4d5a8cc5136167027fefec0d35d540d96db5f1f",
"head_commit_message": "Add allow_unknown_chunksizes to asarray",
"patch_to_review": "diff --git a/dask/array/core.py b/dask/array/core.py\nindex 776050c9aa6..302b1360a2e 100644\n--- a/dask/array/core.py\n+++ b/dask/array/core.py\n@@ -4090,7 +4090,7 @@ ... | [
{
"diff_hunk": "@@ -4122,7 +4122,7 @@ def asarray(a, **kwargs):\n elif type(a).__module__.split(\".\")[0] == \"xarray\" and hasattr(a, \"data\"):\n return asarray(a.data)\n elif isinstance(a, (list, tuple)) and any(isinstance(i, Array) for i in a):\n- return stack(a)\n+ return stac... | 4b6bbeab49d5312c623a0caff12c63738b76eb7e | diff --git a/dask/array/core.py b/dask/array/core.py
index 187fc1cb087..a499b431e6c 100644
--- a/dask/array/core.py
+++ b/dask/array/core.py
@@ -3872,7 +3872,7 @@ def concatenate(seq, axis=0, allow_unknown_chunksizes=False):
"""
from . import wrap
- seq = [asarray(a) for a in seq]
+ seq = [asarray(a, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dask__dask-7359@01baf6a | dask/dask | Python | 7,359 | Support custom_metadata= argument in to_parquet | Adds a `custom_metadata=` argument to `DataFrame.to_parquet`. If a dictionary is passed in by the user, those key/values will be included in all footer metadata, and in the global _metadata file, along with the usual `b"pandas"` metadata.
~Note that this PR only adds `custom_metadata=` support for the "pyarrow" eng... | 2021-03-10T15:25:19Z | Define Column Metadata with to_parquet
When writing out to the `parquet` format, I want to define some column metadata. Using pyarrow, I can write the metadata to the table using the following:
When writing out to parquet using pandas, I can create the Table using the pyarrow library, and once written, I can update... | cc @rjzamora
This sounds reasonable to me. Thanks for the suggestion @achapkowski
Just to clarify, would an appropriate solution be for dask to support a `custom_metadata=` argument, where the user can specify their own dictionary of metadata that will be added to all footer metadata in the output dataset (includ... | [
{
"body": "When writing out to the `parquet` format, I want to define some column metadata. Using pyarrow, I can write the metadata to the table using the following:\r\n\r\nWhen writing out to parquet using pandas, I can create the Table using the pyarrow library, and once written, I can update the tables' met... | bc9f087d871ae146d2d088e7e612c8b3e41a1ec1 | {
"head_commit": "01baf6aa5118a8943c613909b8cdac500ad46bbb",
"head_commit_message": "Merge remote-tracking branch 'upstream/main' into custom-metadata",
"patch_to_review": "diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py\nindex d8d5aa4c3a4..9729f587688 100644\n--- a/dask/dataf... | [
{
"diff_hunk": "@@ -3345,3 +3345,44 @@ def test_roundtrip_rename_columns(tmpdir, engine):\n df1.columns = [\"d\", \"e\", \"f\"]\n \n assert_eq(df1, ddf2.compute())\n+\n+\n+def test_pyarrow_custom_metadata(tmpdir, engine):",
"line": null,
"original_line": 3350,
"original_start_line": null,
... | 78c03a32429d778a916399b5e9b8de5e4ce3ceea | diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py
index d8d5aa4c3a4..9729f587688 100644
--- a/dask/dataframe/io/parquet/arrow.py
+++ b/dask/dataframe/io/parquet/arrow.py
@@ -828,6 +828,7 @@ def write_partition(
index_cols=None,
schema=None,
head=False,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-4113@c26b16f | deepset-ai/haystack | Python | 4,113 | refactor: `InMemoryDocumentStore` - manage documents without embedding & fix mypy errors | ### Related Issues
- fixes #4080
### Proposed Changes:
- implement @bogdankostic's proposal:
> ignoring the Documents without embeddings during retrieval. (We should probably print a warning message for this case.)
- remove mypy ignore comments and fix the errors
- fix `get_scores_numpy `and `get_scores_torch... | 2023-02-09T11:11:00Z | Improve error message for `InMemoryDocumentStore` for Documents without embeddings
**Describe the bug**
If we use the `InMemoryDocumentStore` in combination with a dense retriever and try to do retrieval when at least one of the indexed Documents doesn't contain an embedding, the error message isn't very useful to the... | Hey @bogdankostic!
Which approach do you prefer?
- raising an error
- skip the document and print a warning
I'd prefer the second approach.
@bogdankostic I started to study the code a bit and I found that `numpy.ndarray` does not have the `unsqueeze` method.
See also mypy warnings in https://github.com/deepset-ai... | [
{
"body": "**Describe the bug**\r\nIf we use the `InMemoryDocumentStore` in combination with a dense retriever and try to do retrieval when at least one of the indexed Documents doesn't contain an embedding, the error message isn't very useful to the user.\r\n\r\n**Error message**\r\n```\r\nTraceback (most rece... | d86a511cc1edbef4e053d0a086399f24ef43b220 | {
"head_commit": "c26b16f56fa18b34c39d99e62a06360326c3e801",
"head_commit_message": "try to replace error with warning",
"patch_to_review": "diff --git a/haystack/document_stores/memory.py b/haystack/document_stores/memory.py\nindex bf3029c745..87e4082fb4 100644\n--- a/haystack/document_stores/memory.py\n+++ b/ha... | [
{
"diff_hunk": "@@ -281,47 +281,57 @@ def get_document_by_id(\n else:\n return None\n \n- def get_documents_by_id(self, ids: List[str], index: Optional[str] = None) -> List[Document]: # type: ignore\n+ def get_documents_by_id(\n+ self,\n+ ids: List[str],\n+ index:... | 4ba63305e31694a4be3681652d920276438f1b91 | diff --git a/haystack/document_stores/memory.py b/haystack/document_stores/memory.py
index bf3029c745..4a6a4d36d1 100644
--- a/haystack/document_stores/memory.py
+++ b/haystack/document_stores/memory.py
@@ -281,47 +281,60 @@ def get_document_by_id(
else:
return None
- def get_documents_by_id(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-4226@8d81274 | deepset-ai/haystack | Python | 4,226 | feat: Enable PDFToTextConverter multiprocessing, increase general performance and simplify installation | ### Related Issues
- fixes #4225
### Proposed Changes:
- ~~Remove xpdf binary installation by the user, it will be automatic as a fallback mechanism~~
- Remove xpdf binary dependency completely
- Enable **pure pythonic** implementation for PDF converter
- **Increase** PDF converter realiability for non-standar... | 2023-02-21T20:26:48Z | Improve PDF converter performance and simplify installation
**Is your feature request related to a problem? Please describe.**
As a user, I want to use the PDF converter without extra installation steps. And I would like the performance to be reasonable, specially when processing large PDF files.
**Describe the sol... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nAs a user, I want to use the PDF converter without extra installation steps. And I would like the performance to be reasonable, specially when processing large PDF files.\r\n\r\n**Describe the solution you'd like**\r\nImplement a n... | 2a1d73e16d1036010d51d9906154230d562def48 | {
"head_commit": "8d81274c07d78f6a8e1e56042d10fd1bf046ccb4",
"head_commit_message": "fix: regression when moved code",
"patch_to_review": "diff --git a/haystack/nodes/file_converter/__init__.py b/haystack/nodes/file_converter/__init__.py\nindex 53a83e8bda..1a60448a92 100644\n--- a/haystack/nodes/file_converter/__... | [
{
"diff_hunk": "@@ -73,6 +73,7 @@ dependencies = [\n \"python-docx\",\n \"langdetect\", # for PDF conversions\n \"tika\", # Apache Tika (text & metadata extractor)\n+ \"PyMuPDF>=1.18.16\" , # PDF text extraction",
"line": null,
"original_line": 76,
"original_start_line": null,
"path": ... | 689d2a07f4acfbbd060843f7d84e54fad060b32b | diff --git a/haystack/nodes/file_converter/__init__.py b/haystack/nodes/file_converter/__init__.py
index 1a60448a92..4514a144ad 100644
--- a/haystack/nodes/file_converter/__init__.py
+++ b/haystack/nodes/file_converter/__init__.py
@@ -9,7 +9,7 @@
from haystack.nodes.file_converter.txt import TextConverter
from haysta... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
certbot__certbot-10323@7372236 | certbot/certbot | Python | 10,323 | Add a changelog entry describing the impacts of ARI on short `renew_before_expiry` | Fixes #10312. This is perhaps overly detailed, but I was hoping that by giving a viable path forward it would forestall requests to change it back, add a flag to ignore ari, or otherwise change the behavior. Very open to suggestions on wording/content/length/etc. | 2025-06-09T18:54:37Z | [Task]: double check ARI & renew_before_expiry info in changelog
### Task description
in this release we:
* fixed an unintended change introduced 4.0.0 where renew_before_expiry could not be shorter than certbot's default renewal time
* introduced ARI support which completely overrides both renew_before_expiry or cer... | [
{
"body": "### Task description\n\nin this release we:\n\n* fixed an unintended change introduced 4.0.0 where renew_before_expiry could not be shorter than certbot's default renewal time\n* introduced ARI support which completely overrides both renew_before_expiry or certbot defaults if ACME renewal info is ava... | 1d9fc8dccf103abe6cf1fbe83c58ab7b66791190 | {
"head_commit": "73722365b63bb83ce6ffe9769aec0f6316cfb24b",
"head_commit_message": "Add a changelog entry describing the impacts of ARI on short renew_before_expiry",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex adc0a46ab93..a18d45a0cd9 100644\n--- a/certbot/CHANGELOG.md\n+... | [
{
"diff_hunk": "@@ -37,6 +37,13 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n polling for finalization readiness.\n * The --preferred-profile and --required-profile flags now have their values stored in\n the renewal configuration so the same setting will be used on renewal.\n+* Fixed ... | d837be15381a1cae5f632a54c5d84173730c1935 | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index adc0a46ab93..52a56e8edd1 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -37,6 +37,13 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
polling for finalization readiness.
* The --preferred-profile and --required-profile ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
dask__dask-7234@1586ae0 | dask/dask | Python | 7,234 | Add sliding_window_view | - [x] Closes #4659
- [x] Tests added / passed
- [x] needs docstring
- [x] match numpy's default kwargs
- [x] copy over error checking from numpy
- [x] Passes `black dask` / `flake8 dask`
| 2021-02-16T20:05:58Z | Support sliding window computations
Consider the following code:
```python
import dask.array as da
import numpy as np
d = da.arange(8, chunks=4)
g = d.map_overlap(np.mean, depth=0, boundary=0, trim=False, keepdims=True)
```
After computing `g`, this will return the mean of the two chunks `[0:4]` and `[4:... | I've renamed this issue to "Support sliding window comptutations" (I hope that that's ok). The map_overlap function is more specifically for mapping a function over chunks of data, my guess is that it would be used internally by some sort of sliding window function, but may not be the user level API directly.
Today... | [
{
"body": "Consider the following code:\r\n\r\n```python\r\nimport dask.array as da\r\nimport numpy as np\r\n\r\nd = da.arange(8, chunks=4)\r\n\r\ng = d.map_overlap(np.mean, depth=0, boundary=0, trim=False, keepdims=True)\r\n```\r\n\r\nAfter computing `g`, this will return the mean of the two chunks `[0:4]` and... | 707af9dd8b57e1e4235f4f442b36e370f785e171 | {
"head_commit": "1586ae055d11e1f1dfdd588adc1def78a521a292",
"head_commit_message": "add breaking test",
"patch_to_review": "diff --git a/dask/array/__init__.py b/dask/array/__init__.py\nindex 9d9d5ef7121..9d061f5b3f4 100644\n--- a/dask/array/__init__.py\n+++ b/dask/array/__init__.py\n@@ -219,7 +219,7 @@\n fr... | [
{
"diff_hunk": "@@ -841,3 +845,63 @@ def coerce_boundary(ndim, boundary):\n if isinstance(boundary, dict):\n boundary = {ax: boundary.get(ax, default) for ax in range(ndim)}\n return boundary\n+\n+\n+def _window_view(arr, window_shape, axis, fix_first_block, block_info):\n+ \"\"\" core slidin... | 3c327ee08538315bca2cfc29a382033562abd50e | diff --git a/dask/array/__init__.py b/dask/array/__init__.py
index 92e7013fcb1..4e803648324 100644
--- a/dask/array/__init__.py
+++ b/dask/array/__init__.py
@@ -224,6 +224,7 @@
reduction,
)
from .percentile import percentile
+ from . import lib
from . import ma
from . import random, lina... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-3953@66fac50 | deepset-ai/haystack | Python | 3,953 | feat: add frontmatter to meta in `MarkdownConverter` | ### Related Issues
- fixes #3945
### Proposed Changes:
I propose using the `python-frontmatter` package to split the content of a markdown from it's frontmatter and providing an option for people to add the frontmatter to the `meta`
### How did you test it?
`MarkdownConverter(add_frontmatter_to_meta=True)`
... | 2023-01-26T10:45:19Z | Remove frontmatter and add to `meta` in markdown converter
**Is your feature request related to a problem? Please describe.**
We would like to use the markdown converter for the `haystack-tutorials` search
**Describe the solution you'd like**
Frontmatter is often used to store some meta information of markdown fil... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWe would like to use the markdown converter for the `haystack-tutorials` search\r\n\r\n**Describe the solution you'd like**\r\nFrontmatter is often used to store some meta information of markdown files. So it would be a useful feat... | 2bbe11b598476e325c2d1fb2bdf76a7cebc4c984 | {
"head_commit": "66fac50f6185bf07edf49235784723e277adbf0e",
"head_commit_message": "running black and pre-commit",
"patch_to_review": "diff --git a/haystack/nodes/file_converter/markdown.py b/haystack/nodes/file_converter/markdown.py\nindex 7c5af831c9..e17aaa7ade 100644\n--- a/haystack/nodes/file_converter/markd... | [
{
"diff_hunk": "@@ -1,5 +1,6 @@\n import logging\n import re\n+import frontmatter",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "haystack/nodes/file_converter/markdown.py",
"start_line": null,
"text": "@user1:\nCould you put the `import frontmatter` in the `try... | 1c3db20a8c5abb75cedd3121fe97df99b84dd54a | diff --git a/haystack/nodes/file_converter/markdown.py b/haystack/nodes/file_converter/markdown.py
index 7c5af831c9..2483c25dff 100644
--- a/haystack/nodes/file_converter/markdown.py
+++ b/haystack/nodes/file_converter/markdown.py
@@ -4,6 +4,7 @@
from typing import Dict, List, Optional, Tuple, Any
try:
+ import ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-4048@2cada4d | deepset-ai/haystack | Python | 4,048 | fix: Fix `TableTextRetriever` for input consisting of tables only | ### Related Issues
- fixes #4013
### Proposed Changes:
* The `language_model3` within `TriAdaptiveModel` expects kwargs which don't contain the "passage_" prefix. I changed these to conform with the function kwargs.
* The `TableTextRetriever` is composed of an underlying `BertModel` which in turn contains a `Ber... | 2023-02-02T18:05:21Z | `TypeError` when updating embeddings with `TableTextRetriever`
**Describe the bug**
When calling update_embeddings using the TableTextRetriever, we run into a `TypeError`.
**Error message**
```
Updating Embedding: 0%| | 0/1 [00:00<?, ? docs/s]
Traceback (most recent call last):
File "/Users/bogdan/... | Hey, I'm a research engineer currently working on a mix of ml research and software engineering with a focus on language modelling. I'd like to get involved and take this issue if it's still free?
Hey @jebbbbb, we would be more than happy to get your contribution here! Feel free to reach out whenever you come across a ... | [
{
"body": "**Describe the bug**\r\nWhen calling update_embeddings using the TableTextRetriever, we run into a `TypeError`.\r\n\r\n**Error message**\r\n```\r\nUpdating Embedding: 0%| | 0/1 [00:00<?, ? docs/s]\r\nTraceback (most recent call last):\r\n File \"/Users/bogdan/Repositories/haystack/bogdan_... | 986472c26fa7fbaa2d6101bf12c5c7de20442ed2 | {
"head_commit": "2cada4d053cc4abf63687630327d0fb0c77bc0cd",
"head_commit_message": "test: add test for ttr + dataframe case",
"patch_to_review": "diff --git a/haystack/modeling/model/language_model.py b/haystack/modeling/model/language_model.py\nindex a2290d4665..82f3186fe2 100644\n--- a/haystack/modeling/model/... | [
{
"diff_hunk": "@@ -310,9 +310,9 @@ def forward_lm(self, **kwargs):\n # Current batch consists of only tables\n if all(table_mask):\n pooled_output2, _ = self.language_model3(\n- passage_input_ids=kwargs[\"passage_input_ids\"],\n- pas... | c15f3ad716c1bf69d534203fde4c45806ae970ff | diff --git a/haystack/modeling/model/language_model.py b/haystack/modeling/model/language_model.py
index a2290d4665..82f3186fe2 100644
--- a/haystack/modeling/model/language_model.py
+++ b/haystack/modeling/model/language_model.py
@@ -705,9 +705,9 @@ def forward(
:param input_ids: The IDs of each token in the ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
certbot__certbot-10288@2db1836 | certbot/certbot | Python | 10,288 | Respect Retry-After header when polling for order finalization | Fixes #10273. | 2025-05-12T20:35:32Z | [Bug]: Respect Retry-After header when polling for order finalization (if given)
```
If a request to finalize an order is successful, the server will
return a 200 (OK) with an updated order object. The status of the
order will indicate what action the client should take:
o "invalid": The certificate will no... | [
{
"body": "```\nIf a request to finalize an order is successful, the server will\n return a 200 (OK) with an updated order object. The status of the\n order will indicate what action the client should take:\n\n o \"invalid\": The certificate will not be issued. Consider this\n order process abando... | c5686e66539c8a92112172c57e4b43dfc3fde258 | {
"head_commit": "2db1836843faba8ce6259efa2c3b91aecc0c8954",
"head_commit_message": "update changelog",
"patch_to_review": "diff --git a/acme/src/acme/_internal/tests/client_test.py b/acme/src/acme/_internal/tests/client_test.py\nindex fb900e38c79..8380f090fa1 100644\n--- a/acme/src/acme/_internal/tests/client_te... | [
{
"diff_hunk": "@@ -280,6 +282,15 @@ def poll_finalization(self, orderr: messages.OrderResource,\n alt_chains = [self._post_as_get(url).text for url in alt_chains_urls]\n orderr = orderr.update(alternative_fullchains_pem=alt_chains)\n return orderr\n+ ... | 058586a4bdb4287ee1fd3d3bb073e7cc5adfd863 | diff --git a/acme/src/acme/_internal/tests/client_test.py b/acme/src/acme/_internal/tests/client_test.py
index fb900e38c79..8380f090fa1 100644
--- a/acme/src/acme/_internal/tests/client_test.py
+++ b/acme/src/acme/_internal/tests/client_test.py
@@ -281,7 +281,9 @@ def test_finalize_order_invalid_status(self):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dask__dask-7026@4bd2923 | dask/dask | Python | 7,026 | Add index to meta after .str.split with expand | This PR proposes a fix for https://github.com/dask/dask/issues/7021.
Without the proposed fix, `dask/dataframe/tests/test_accessors.py::test_str_accessor_expand` fails if the index is of any other type than `int`.
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
| 2021-01-04T12:23:02Z | `index.dtype` changes from date to int after `.str.split`
When I apply `.str.split` to a column with datetime index, the dtype of the index changes to int64.
Example:
```
import pandas as pd
import dask.dataframe as dd
series_with_strings = dd.from_pandas(
pd.Series(
data=["some_text", "split_i... | [
{
"body": "When I apply `.str.split` to a column with datetime index, the dtype of the index changes to int64.\r\n\r\nExample:\r\n\r\n```\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\n\r\nseries_with_strings = dd.from_pandas(\r\n pd.Series(\r\n data=[\"some_text\", \"split_it\"],\r\n ... | dcf3c3a1ee5f7bdaa1f45701fca6a7502d3ccb20 | {
"head_commit": "4bd2923338271fe054b8d0f6ccfa0e9c4ca59409",
"head_commit_message": "iloc[:0] more expressive than .drop(0)",
"patch_to_review": "diff --git a/dask/dataframe/accessor.py b/dask/dataframe/accessor.py\nindex 28573b1e5a2..0c8a3ade3a1 100644\n--- a/dask/dataframe/accessor.py\n+++ b/dask/dataframe/acce... | [
{
"diff_hunk": "@@ -129,6 +129,7 @@ def split(self, pat=None, n=-1, expand=False):\n delimiter = \" \" if pat is None else pat\n meta = type(self._series._meta)([delimiter.join([\"a\"] * (n + 1))])",
"line": null,
"original_line": 130,
"original_start_line": null,
... | 259ba5ad54200eaab689ff1f79305f75854f8d01 | diff --git a/dask/dataframe/accessor.py b/dask/dataframe/accessor.py
index 28573b1e5a2..be766c256b0 100644
--- a/dask/dataframe/accessor.py
+++ b/dask/dataframe/accessor.py
@@ -127,7 +127,10 @@ def split(self, pat=None, n=-1, expand=False):
)
else:
delimiter = " " if pat i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dask__dask-6863@c584f77 | dask/dask | Python | 6,863 | Allow mixing dask and numpy arrays in @guvectorize | - [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
- [x] Closes #6855
I am not sure that this is the right time for adding a meta_nonempty for dask.array but I thought it might be? Also I suspect that this'll have repercussions for cupy @quasiben.
| 2020-11-19T16:23:23Z | Mixing of dask.array and numpy.ndarray in Numba @guvectorize
<!-- Please do a quick search of existing issues to make sure that this has not been asked before. -->
It appears that `dask.array` and `numpy.ndarray` cannot be mixed when using Numba's `@guvectorize` decorator - see the minimal example below. It would be... | Thanks for opening this issue. I can reproduce on lastest master and this feels like something that should be allowed. I am opening a PR now with a proposed fix.
Much appreciated! Agreed that it intuitively feels like this should work ... (the exception left me chasing my tail for a while) | [
{
"body": "<!-- Please do a quick search of existing issues to make sure that this has not been asked before. -->\r\n\r\nIt appears that `dask.array` and `numpy.ndarray` cannot be mixed when using Numba's `@guvectorize` decorator - see the minimal example below. It would be a nice feature if dask could resolve ... | 1797c2bbb7c9dcf597840810ed6986f871de333d | {
"head_commit": "c584f77c3e7e762fedfb1d3db97e1b3cca3f123e",
"head_commit_message": "Make sure that args is an evaluated array",
"patch_to_review": "diff --git a/dask/array/core.py b/dask/array/core.py\nindex e0123995311..664474dfce6 100644\n--- a/dask/array/core.py\n+++ b/dask/array/core.py\n@@ -369,8 +369,15 @@... | [
{
"diff_hunk": "@@ -369,8 +369,15 @@ def apply_infer_dtype(func, args, kwargs, funcname, suggest_dtype=\"dtype\", nout=\n : dtype or List of dtype\n One or many dtypes (depending on ``nout``)\n \"\"\"\n+ from .utils import ones_like_safe",
"line": null,
"original_line": 372,
"orig... | 812a660210fb717bd80b5902430b2ff8956102e0 | diff --git a/dask/array/core.py b/dask/array/core.py
index e0123995311..9ff52ea3547 100644
--- a/dask/array/core.py
+++ b/dask/array/core.py
@@ -369,8 +369,13 @@ def apply_infer_dtype(func, args, kwargs, funcname, suggest_dtype="dtype", nout=
: dtype or List of dtype
One or many dtypes (depending on ``nou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-6818@c5137c1 | dask/dask | Python | 6,818 | Add blocksize to task name | - [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
Closes #6814
I am still thinking about how to add tests. I think this only happens on a distributed cluster. | 2020-11-09T15:31:33Z | blocksize and persist has impact on result
**What happened**:
When running `read_csv` in combination with `persist` and `blocksize`, results change on re-evaluation.
I am using a 10 worker dask-cluster with version 2.29.0 (I skip the cluster setup part of the script).
```python
import dask.dataframe as dd
from d... | Yikes. I can reproduce on dask/distributed master although I get a different final number. I suspect that there might be some issue with tasks having the same name even if the blocksize is different. | [
{
"body": "**What happened**:\r\nWhen running `read_csv` in combination with `persist` and `blocksize`, results change on re-evaluation.\r\nI am using a 10 worker dask-cluster with version 2.29.0 (I skip the cluster setup part of the script).\r\n\r\n```python\r\nimport dask.dataframe as dd\r\nfrom distributed i... | 554ca8877d36d30732712698f3135e13edd6654a | {
"head_commit": "c5137c1b8d1c78969428de1b6ab29de180c9e652",
"head_commit_message": "Have test check that task names are different",
"patch_to_review": "diff --git a/dask/dataframe/io/csv.py b/dask/dataframe/io/csv.py\nindex 6b34c09fba5..80972b22e00 100644\n--- a/dask/dataframe/io/csv.py\n+++ b/dask/dataframe/io/... | [
{
"diff_hunk": "@@ -208,6 +209,25 @@ def test_text_blocks_to_pandas_kwargs(reader, files):\n assert (result.columns == df.columns).all()\n \n \n+@csv_and_table\n+def test_text_blocks_to_pandas_has_different_task_names_based_on_blocksize(\n+ reader, files\n+):\n+ blocks = [[files[k]] for k in sorted(fi... | f79b3acde3f5cc560ce8d0e64c3af467d4afdbfd | diff --git a/dask/dataframe/io/csv.py b/dask/dataframe/io/csv.py
index 6b34c09fba5..80972b22e00 100644
--- a/dask/dataframe/io/csv.py
+++ b/dask/dataframe/io/csv.py
@@ -318,6 +318,7 @@ def text_blocks_to_pandas(
enforce=False,
specified_dtypes=None,
path=None,
+ blocksize=None,
):
"""Convert blo... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-3837@e0d9ac8 | deepset-ai/haystack | Python | 3,837 | feat: preprocessor raises warning when doc length exceeds threshold | ### Related Issues
- fixes https://github.com/deepset-ai/haystack/issues/3285
### Proposed Changes:
- Adds a `max_chars` parameter to `PreProcessor.__init__`
- This parameter will make PreProcessor output a warning when documents longer than `max_chars` are about to be returned.
- See #3557 about the reason wh... | 2023-01-10T17:50:05Z | Preprocessing: Warning when max doc length significantly exceeds preprocessor split length
**Is your feature request related to a problem? Please describe.**
When running a retriever-reader pipeline, we noticed that certain inference times were much longer than others, and were even running into timeout problems. We t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWhen running a retriever-reader pipeline, we noticed that certain inference times were much longer than others, and were even running into timeout problems. We thought this was odd, since we had a preprocessor splitting files into ... | 62935bde6dcfa37354ae2c8ccea7406202f0914e | {
"head_commit": "e0d9ac8541b6696281af4922b4a65fed12692cd7",
"head_commit_message": "improve test",
"patch_to_review": "diff --git a/haystack/nodes/preprocessor/preprocessor.py b/haystack/nodes/preprocessor/preprocessor.py\nindex 0d24e93ae1..3cee9375d2 100644\n--- a/haystack/nodes/preprocessor/preprocessor.py\n++... | [
{
"diff_hunk": "@@ -97,6 +98,7 @@ def __init__(\n field `\"page\"`. Page boundaries are determined by `\"\\f\"' character which is added\n in between pages by `PDFToTextConverter`, `TikaConverter`, `ParsrConverter` and\n ... | c5b11d0380193465232419c51acfcb169f9391fc | diff --git a/haystack/nodes/preprocessor/preprocessor.py b/haystack/nodes/preprocessor/preprocessor.py
index 990806a8be..a4706f46d5 100644
--- a/haystack/nodes/preprocessor/preprocessor.py
+++ b/haystack/nodes/preprocessor/preprocessor.py
@@ -64,6 +64,7 @@ def __init__(
id_hash_keys: Optional[List[str]] = None... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-3666@591ea2f | deepset-ai/haystack | Python | 3,666 | feat: add `index` parameter to `TfidfRetriever` | ### Related Issues
- fixes #1634
### Proposed Changes:
`TfidfRetriever` automatically uses the default index of the Document Store.
You can't set/change index, eg for evaluation purposes.
This PR is just a first draft to implement this feature by minimally changing the node.
### How did you test it?
CI;
... | 2022-12-04T20:12:21Z | Feature Request: Add index parameter to TFiDF retriever
**Problem**
When using the inmemory docstore on a non standard index (e.g. for evaluation) we cannot use the TFiDF Retriever, because you cannot set an index there.
**Solution**
Lets add the index option to the TFiDF retriever please.
**Background**
I wou... | Related? #1637
Nice one! Yes it is. I stumbled upon this exact same error by adding the data in an InMemoryStore at a custom index in combination with TFiDFRetriever.
Though in #1637 I do not see a custom index being used...
What's the status on this? I'm actually facing the same problem 🥲
And also, what would be ... | [
{
"body": "**Problem**\r\nWhen using the inmemory docstore on a non standard index (e.g. for evaluation) we cannot use the TFiDF Retriever, because you cannot set an index there.\r\n\r\n**Solution**\r\nLets add the index option to the TFiDF retriever please.\r\n\r\n**Background**\r\nI would like the inmemory st... | a1d8557c80465ecb93aed9be07640b0453c62851 | {
"head_commit": "591ea2fdff2656337efebe055208e65fac1bfcb4",
"head_commit_message": "remove newline from openapi json",
"patch_to_review": "diff --git a/docs/_src/api/openapi/openapi-1.12.0rc0.json b/docs/_src/api/openapi/openapi-1.12.0rc0.json\nindex 402e8139f7..53ea29c8cb 100644\n--- a/docs/_src/api/openapi/ope... | [
{
"diff_hunk": "@@ -27,7 +27,7 @@ def __init__(\n scale_score: bool = True,\n ):\n \"\"\"\n- :param document_store: an instance of one of the following DocumentStores to retrieve from: ElasticsearchDocumentStore, OpenSearchDocumentStore and OpenDistroElasticsearchDocumentStore.\n+ ... | 9820f2db0e318aa85b8b293ff9afa49acf85a842 | diff --git a/haystack/nodes/retriever/sparse.py b/haystack/nodes/retriever/sparse.py
index 2badb0ca87..37355c56fb 100644
--- a/haystack/nodes/retriever/sparse.py
+++ b/haystack/nodes/retriever/sparse.py
@@ -1,5 +1,5 @@
# mypy: disable-error-code=override
-from typing import Dict, List, Optional, Union
+from typing imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-10905@17619b2 | dbt-labs/dbt-core | Python | 10,905 | Fix: Source quoting ignores global configuration | Resolves #10892 (regression)
<!---
Include the number of the issue addressed by this PR above, if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
Add the `user docs` label to this PR if it will need docs changes. An
issue... | 2024-10-22T21:01:32Z | [Regression] Quoting behavior for sources
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
In dbt-core 1.7 and earlier, quoting behavior for sources was not contr... | Internal thread: https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1729130247375769 | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nIn dbt-core 1.7 and earlier, quoting behavior for sources was not controlled by ... | f7b7935a977432fa699e4673ff19ced8c926d1ba | {
"head_commit": "17619b2294f3da95e90cd54f8b6eaeae3d24e8ac",
"head_commit_message": "changelog entry",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20241023-152054.yaml b/.changes/unreleased/Fixes-20241023-152054.yaml\nnew file mode 100644\nindex 00000000000..976f4cf3add\n--- /dev/null\n+++ b/.chang... | [
{
"diff_hunk": "@@ -684,8 +684,15 @@ def resolve(self, source_name: str, table_name: str):\n target_kind=\"source\",\n disabled=(isinstance(target_source, Disabled)),\n )\n+\n+ # Source quoting does _not_ respect global configs in dbt_project.yml, as documented... | 28438768a47c83d40e27b70ea918afbd62a29a0c | diff --git a/.changes/unreleased/Fixes-20241023-152054.yaml b/.changes/unreleased/Fixes-20241023-152054.yaml
new file mode 100644
index 00000000000..976f4cf3add
--- /dev/null
+++ b/.changes/unreleased/Fixes-20241023-152054.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Restore source quoting behaviour when quoting config pro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-3546@a260299 | deepset-ai/haystack | Python | 3,546 | feat: add query_by_embedding_batch | ### Related Issues
- fixes https://github.com/deepset-ai/haystack/issues/3647
### Proposed Changes:
- create a batch pendant of `query_by_embedding` like `query_batch` for DocumentStores
- default impl would be to delegate to `query_by_embedding`
- for `OpenSearchDocumentStore` and `ElasticsearchDocumentStore` i... | 2022-11-09T16:37:22Z | Execute dense searches in parallel in OpenSearchDocumentStore when in batch mode
**Is your feature request related to a problem? Please describe.**
If we call `run_batch` `OpenSearchDocumentStore` makes use of `msearch` if it is a sparse query. That is, it executes the searches in parallel. For dense searches this is ... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIf we call `run_batch` `OpenSearchDocumentStore` makes use of `msearch` if it is a sparse query. That is, it executes the searches in parallel. For dense searches this is not the case, all searches are executed in sequence.\r\n\r\n... | af06519fc4eb646ba77d97da261a7dd5ec3fc7f3 | {
"head_commit": "a2602992a4b6c323df467065896074d0f5496d2a",
"head_commit_message": "fix pylint",
"patch_to_review": "diff --git a/haystack/document_stores/base.py b/haystack/document_stores/base.py\nindex acaa1ecffc..cef9e16824 100644\n--- a/haystack/document_stores/base.py\n+++ b/haystack/document_stores/base.p... | [
{
"diff_hunk": "@@ -205,18 +205,15 @@ def retrieve_batch( # type: ignore\n query_embeddings = self.query_embedder.embed(documents=query_docs, batch_size=batch_size)\n \n # Query documents by embedding (the actual retrieval step)\n- documents = []\n- for query_embedding, query_filt... | 144766d7bb37ab0ffea8d73fc8be8ccfe9d93fc8 | diff --git a/haystack/document_stores/base.py b/haystack/document_stores/base.py
index acaa1ecffc..4e0712cb5e 100644
--- a/haystack/document_stores/base.py
+++ b/haystack/document_stores/base.py
@@ -12,7 +12,7 @@
from haystack.schema import Document, Label, MultiLabel
from haystack.nodes.base import BaseComponent
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
certbot__certbot-9829@be8261f | certbot/certbot | Python | 9,829 | Fix change detection on mutable values | Fixes https://github.com/certbot/certbot/issues/9825.
If we don't like this, as a workaround we could directly set `argument_sources` inside the webroot plugin which is I believe the only place in our first party code where currently we have a problem here, but I personally think we need a better long term solution ... | 2023-10-30T22:18:20Z | Webroot path is not saved when entered interactively, only when given on command line
## My operating system is (include version):
Debian 12
## I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):
Docker
## I ran this command and it produced this output:
I first ran:
```
# doc... | Thanks so much for the detailed bug report. I was able to reproduce this and we'll get this fixed ASAP. | [
{
"body": "## My operating system is (include version):\r\n\r\nDebian 12\r\n\r\n## I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):\r\n\r\nDocker\r\n\r\n## I ran this command and it produced this output:\r\n\r\nI first ran:\r\n\r\n```\r\n# docker run --rm -it [...volume storage setup... | 7bb85f844069cafbf1184d46f6e3c649fbfcc7d4 | {
"head_commit": "be8261f05f88e7efec2da0434b310d8f7ddf6f40",
"head_commit_message": "add changelog entry",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex 729f2146a9e..658fd210357 100644\n--- a/certbot/CHANGELOG.md\n+++ b/certbot/CHANGELOG.md\n@@ -14,6 +14,8 @@ Certbot adheres ... | [
{
"diff_hunk": "@@ -145,15 +146,48 @@ def _mark_runtime_override(self, name: str) -> None:\n \"\"\"\n If an argument_sources dict was set, overwrites an argument's source to\n be ArgumentSource.RUNTIME. Used when certbot sets an argument's values\n- at runtime.\n+ at runtim... | 0355e7ea1cd7fa7fce39be8f663315e8a38654fd | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index 729f2146a9e..658fd210357 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -14,6 +14,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Fixed
+* Fixed a bug introduced in version 2.7.0 that caused interactively entere... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10830@f343f0c | dbt-labs/dbt-core | Python | 10,830 | Ensure consistent `current_time` across microbatch models in an invocation | Resolves #10819
### Problem
Different microbatch models in the same `dbt run` could end up with different `current_time`. This could cause a situation where two microbatch models operating on the same inputs could end up with more/less data if one microbatch model was executed significantly later than the other.
... | 2024-10-07T17:03:07Z | Set a singular "current_time" for microbatch models per invocation
Currently, microbatch models get a "current_time" (`datetime.datetime.now(pytz.UTC)`) when they are executed. Notably, each microbatch model gets a _different_ "current_time". This works, but has some funkiness.
Consider the following:
1. There is a... | [
{
"body": "Currently, microbatch models get a \"current_time\" (`datetime.datetime.now(pytz.UTC)`) when they are executed. Notably, each microbatch model gets a _different_ \"current_time\". This works, but has some funkiness.\r\n\r\nConsider the following:\r\n1. There is a source, `source_1`, which is constant... | fc83f5edfac353516f37b281ccc46c1f15810cd8 | {
"head_commit": "f343f0c0701cebbb696ccd20ff7cd60b421b0eb0",
"head_commit_message": "Add changie doc",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20241007-115853.yaml b/.changes/unreleased/Features-20241007-115853.yaml\nnew file mode 100644\nindex 00000000000..ac2e61c5b59\n--- /dev/null\n+++ b/... | [
{
"diff_hunk": "@@ -98,6 +101,7 @@ class RuntimeConfig(Project, Profile, AdapterRequiredConfig):\n profile_name: str\n cli_vars: Dict[str, Any]\n dependencies: Optional[Mapping[str, \"RuntimeConfig\"]] = None\n+ invocated_at: datetime = field(default_factory=lambda: datetime.now(pytz.UTC))",
... | 9cd6ceabbb7076a47ad836e82d40e18ddf0e084e | diff --git a/.changes/unreleased/Features-20241007-115853.yaml b/.changes/unreleased/Features-20241007-115853.yaml
new file mode 100644
index 00000000000..ac2e61c5b59
--- /dev/null
+++ b/.changes/unreleased/Features-20241007-115853.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Ensure microbatch models use same `current_t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-3769@6f1e1d2 | deepset-ai/haystack | Python | 3,769 | feat: adding the ability to use Ray Serve async functionality | As I have explained in issue #2968 , a deployment on Ray Serve can be called `async`, which can make a lot of sense, as Ray Serve is typically used to serve large ML models - which means it takes a while for each request sent to a cluster of Ray Serve Deployment to return (from a few ms up to about a 100ms depending on... | 2022-12-27T01:29:58Z | Adding the ability to use Ray Serve `async` functionality
**Is your feature request related to a problem? Please describe.**
Ray Serve uses `async` extensively. There are lots of functionalities in Ray Serve (like batch inference), which are only available if you are using `async`.
Also, ML model serving is a perfect... | Hey @ZanSara ,
I think this was closed by mistake.
The mentioned [refactoring I did on the Raypipeline](https://github.com/deepset-ai/haystack/pull/2981) was NOT about adding `async`, that is still coming.
Would you mind reopening it and then I will attempt a PR on this.
Thanks
Hey @zoltan-fedor! Right, thank you f... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nRay Serve uses `async` extensively. There are lots of functionalities in Ray Serve (like batch inference), which are only available if you are using `async`.\r\nAlso, ML model serving is a perfect use-case for async - especially on... | d2bba4935b2ccfa7ef875815a4a1bf98afcedbc1 | {
"head_commit": "6f1e1d2899bc0931306dec8ef8f023f1d6374964",
"head_commit_message": "Merge branch 'deepset-ai:main' into feature-ray-serve-async2",
"patch_to_review": "diff --git a/haystack/pipelines/base.py b/haystack/pipelines/base.py\nindex ba8f093d08..8d3eda67aa 100644\n--- a/haystack/pipelines/base.py\n+++ b... | [
{
"diff_hunk": "@@ -578,6 +578,132 @@ def run( # type: ignore\n self.send_pipeline_event_if_needed(is_indexing=file_paths is not None)\n return node_output\n \n+ # async version of the above `run()` method\n+ async def run_async( # type: ignore",
"line": null,
"original_line": 58... | 3a0f2d4a5a9dc8cd41fcd7a22ef444620d456506 | diff --git a/haystack/pipelines/ray.py b/haystack/pipelines/ray.py
index 298a4bd7bc..9cd37eec69 100644
--- a/haystack/pipelines/ray.py
+++ b/haystack/pipelines/ray.py
@@ -1,8 +1,9 @@
from __future__ import annotations
import inspect
-from typing import Any, Dict, List, Optional, Tuple
-
+import logging
+from typing i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-3561@ac67603 | deepset-ai/haystack | Python | 3,561 | feat: add support for `BM25Retriever` in `InMemoryDocumentStore` | ### Related Issues
- fixes #3447
Only a first draft...
### Checklist
- [X] I have read the [contributors guidelines](https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md) and the [code of conduct](https://github.com/deepset-ai/haystack/blob/main/code_of_conduct.txt)
- [X] I have updated the related... | 2022-11-12T12:24:37Z | Add support for BM25Retriever in InMemoryDocumentStore
**Is your feature request related to a problem? Please describe.**
Many of our tutorials are using the ElasticsearchDocumentStore. While this is a good choice for a production system, it can be quite cumbersome to set up and run during your "first minutes with hay... | Some additional context (same idea from @bglearning): https://github.com/deepset-ai/haystack-tutorials/pull/44#issuecomment-1282170131
BM25 was recently added to gensim: https://github.com/RaRe-Technologies/gensim/pull/3304, we might use this.
@ZanSara: please advise me on how I can contribute to the haystack, in gener... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nMany of our tutorials are using the ElasticsearchDocumentStore. While this is a good choice for a production system, it can be quite cumbersome to set up and run during your \"first minutes with haystack\". It would be awesome to u... | c7e3483f62d4c8dce15d71d032fa49c8deba39a8 | {
"head_commit": "ac6760304cfc56b5e4af194fefb00a4fa4377b50",
"head_commit_message": "better docstrings; revert not running tests",
"patch_to_review": "diff --git a/haystack/document_stores/memory.py b/haystack/document_stores/memory.py\nindex dd61bd9286..091c13fc94 100644\n--- a/haystack/document_stores/memory.py... | [
{
"diff_hunk": "@@ -146,6 +172,25 @@ def write_documents(\n )\n continue\n self.indexes[index][document.id] = document\n+ modified_documents += 1\n+\n+ if self.use_bm25 is True and modified_documents > 0:\n+ self.update_bm25(index=... | aad1970b1f46fcb139b88145a6d98d25106728fc | diff --git a/haystack/document_stores/memory.py b/haystack/document_stores/memory.py
index dd61bd9286..5d893cd00c 100644
--- a/haystack/document_stores/memory.py
+++ b/haystack/document_stores/memory.py
@@ -1,17 +1,24 @@
from typing import Any, Dict, List, Optional, Union, Generator
+try:
+ from typing import Lit... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dask__dask-6503@30bee38 | dask/dask | Python | 6,503 | ENH Adds items to dataframe | Fixes https://github.com/dask/dask/issues/6501
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
| 2020-08-11T15:50:52Z | Implement DataFrame.items
DataFrame.items should return an iterator that produces the column name, series pairs:
```
In [6]: import pandas as pd
In [7]: df = pd.DataFrame({"A": [1, 2], "B": [3, 4]})
In [8]: df.items()
Out[8]: <generator object DataFrame.items at 0x11bf27970>
In [9]: for k, v in df.items()... | [
{
"body": "DataFrame.items should return an iterator that produces the column name, series pairs:\r\n\r\n```\r\nIn [6]: import pandas as pd\r\n\r\nIn [7]: df = pd.DataFrame({\"A\": [1, 2], \"B\": [3, 4]})\r\n\r\nIn [8]: df.items()\r\nOut[8]: <generator object DataFrame.items at 0x11bf27970>\r\n\r\nIn [9]: for k... | 14c53510a5a58f8eb452c148a97f7813234193d1 | {
"head_commit": "30bee389571491e4eaffe05900bb6a5ef57d7778",
"head_commit_message": "ENH Adds items to dataframe",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex d94daa0147b..eca570a4af4 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -4148,6 +4148,1... | [
{
"diff_hunk": "@@ -4148,6 +4148,11 @@ def itertuples(self, index=True, name=\"Pandas\"):\n for row in df.itertuples(index=index, name=name):\n yield row\n \n+ @derived_from(pd.DataFrame)\n+ def items(self):\n+ for key in self.columns:\n+ yield key, self[key]"... | 3d472ef428e5ad92bcf03d12d39c6f3c72502c78 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index d94daa0147b..94d4d44a052 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -4148,6 +4148,11 @@ def itertuples(self, index=True, name="Pandas"):
for row in df.itertuples(index=index, name=name):
yield row
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-3587@08e5c79 | deepset-ai/haystack | Python | 3,587 | feat: Add `CsvTextConverter` | Fixes #3550, allow user to build full FAQ using YAML pipeline description and with CSV import and indexing.
### Related Issues
- fixes #3550
### Proposed Changes:
I've added ~2~1 node to be able to build a full FAQ pipeline with CSV import :
- **Csv2Documents** : Takes a file input, parse it an FAQ CSV file ... | 2022-11-16T09:50:40Z | FAQ CSV Indexing using YAML description, adding missing nodes
**Is your feature request related to a problem? Please describe.**
Not really.
**Describe the solution you'd like**
As an Haystack user I would like to be able to import FAQ (as CSV files), index them though API endpoint using an indexing pipeline descr... | Pushed 👍, thanks in advance for the review of #3587
@vblagoje can you double check if this is somehow related to your proposal https://github.com/deepset-ai/haystack/pull/3558 ? In case, I would merge the efforts.
Hi @masci and @vblagoje I took a look at the proposal, the focus here is in having the ability to impor... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nNot really.\r\n\r\n**Describe the solution you'd like**\r\nAs an Haystack user I would like to be able to import FAQ (as CSV files), index them though API endpoint using an indexing pipeline described as YAML.\r\n\r\n**Describe alt... | 90c877a559c0dcee3c596e7ab5af4ab0140ced1e | {
"head_commit": "08e5c79faa709d8e278123bc7d316c6ecae206e1",
"head_commit_message": "black",
"patch_to_review": "diff --git a/haystack/nodes/__init__.py b/haystack/nodes/__init__.py\nindex ec3e6126d7..facbb3ce73 100644\n--- a/haystack/nodes/__init__.py\n+++ b/haystack/nodes/__init__.py\n@@ -19,6 +19,7 @@\n Te... | [
{
"diff_hunk": "@@ -0,0 +1,54 @@\n+from typing import Union, List, Optional, Any, Dict\n+\n+import logging\n+from pathlib import Path\n+\n+import pandas as pd\n+\n+from haystack import Document\n+from haystack.nodes.file_converter import BaseConverter\n+\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class C... | 5f9f3612891411f2c539315bb55df2c6213ee858 | diff --git a/haystack/nodes/__init__.py b/haystack/nodes/__init__.py
index ec3e6126d7..facbb3ce73 100644
--- a/haystack/nodes/__init__.py
+++ b/haystack/nodes/__init__.py
@@ -19,6 +19,7 @@
TextConverter,
AzureConverter,
ParsrConverter,
+ CsvTextConverter,
)
from haystack.nodes.label_generator import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-6471@7304b8b | dask/dask | Python | 6,471 | Add single quotes around column names if strings | - [ ] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
Fixes #6470
Adds explicit single quotes around the column names in `bad_dtypes` so that it's easier to distinguish between `str(int)` column names and `int` column names.
```
Traceback (most recent call last):
File "metadata_mismatch.py... | 2020-07-30T13:55:21Z | Metadata mismatch is not clear about why columns are different
Reproducible code
```
import pandas as pd
from dask.delayed import delayed
import dask.dataframe as dd
def df_with_str_columns():
return pd.DataFrame({'7': [1, 2], '8': [3, 4]})
# Note in meta columns are ints
meta = {7: 'int', 8: 'int'}... | I can see how this could be moderately infuriating. Thanks for reporting @birdsarah -- proposed fix incoming. | [
{
"body": "Reproducible code\r\n\r\n```\r\nimport pandas as pd\r\nfrom dask.delayed import delayed\r\nimport dask.dataframe as dd\r\n\r\ndef df_with_str_columns(): \r\n return pd.DataFrame({'7': [1, 2], '8': [3, 4]}) \r\n\r\n# Note in meta columns are ints\r\nmeta = {7: 'int', 8: 'int'}\r\ndf = dd.from_delay... | 26e722f02738232518b46294c95c6beac93ae113 | {
"head_commit": "7304b8b22311afee4abf5f38d5ceadf51e64d399",
"head_commit_message": "Add single quotes around column names if strings",
"patch_to_review": "diff --git a/dask/dataframe/utils.py b/dask/dataframe/utils.py\nindex db9e6951eac..649e61c4a2c 100644\n--- a/dask/dataframe/utils.py\n+++ b/dask/dataframe/uti... | [
{
"diff_hunk": "@@ -647,7 +647,9 @@ def equal_dtypes(a, b):\n elif is_dataframe_like(meta):\n dtypes = pd.concat([x.dtypes, meta.dtypes], axis=1, sort=True)\n bad_dtypes = [\n- (col, a, b)\n+ # add single quotes around string variables\n+ # to more clearly de... | 32792cdaeaceccc0de8a2c98595624dcff0a996b | diff --git a/dask/dataframe/tests/test_utils_dataframe.py b/dask/dataframe/tests/test_utils_dataframe.py
index fa6a6625190..fba57b59e55 100644
--- a/dask/dataframe/tests/test_utils_dataframe.py
+++ b/dask/dataframe/tests/test_utils_dataframe.py
@@ -361,9 +361,9 @@ def test_check_meta():
"+--------+----------+-... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-3452@e25fb40 | deepset-ai/haystack | Python | 3,452 | refactor: simplify Summarizer, add Document Merger | ### Related Issues
- fixes #3403
### Proposed Changes:
As discussed in #3403
- make the summarizer suitable for indexing pipelines
- write the summarization results in meta instead of altering document content (current behavior)
- remove `generate_single_summary` parameter: currently it transforms several docum... | 2022-10-21T18:55:57Z | Make Summarizer work in indexing pipeline
Currently, when the Summarizer is run at query time, its primary output is the summarized text, and the original, full text is stored in metadata as "context".
There should be support for the Summarizer to be used in an indexing pipeline. When run, the Summarizer should not... | @brandenchan it seems fair and reasonable to me!
How to distinguish if the Summarizer is used for queryies or for indexing?
Any suggestions/resources?
So `BaseDocumentClassifier.run()` takes `root_node` as an argument. When `root_node=="File"` it's indexing, and when `root_node=="Query"` it's querying. I'm sure tha... | [
{
"body": "Currently, when the Summarizer is run at query time, its primary output is the summarized text, and the original, full text is stored in metadata as \"context\". \r\n\r\nThere should be support for the Summarizer to be used in an indexing pipeline. When run, the Summarizer should not change `Document... | fc551b90ac9cc601e53189113adc0a7cffd29aac | {
"head_commit": "e25fb408b59504130d68da04b44276d39b99a5e2",
"head_commit_message": "added test that will fail in 1.12",
"patch_to_review": "diff --git a/haystack/nodes/other/document_merger.py b/haystack/nodes/other/document_merger.py\nnew file mode 100644\nindex 0000000000..87d37d2009\n--- /dev/null\n+++ b/hays... | [
{
"diff_hunk": "@@ -0,0 +1,110 @@\n+import logging\n+from copy import deepcopy\n+from typing import Optional, List, Dict, Union\n+\n+from haystack.schema import Document\n+from haystack.nodes.base import BaseComponent\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class DocumentMerger(BaseComponent):\n+ \... | ab8e6ba33bdaace7300a4d020a940460fd3e3711 | diff --git a/docs/_src/api/pydoc/other.yml b/docs/_src/api/pydoc/other.yml
index d94eb69743..5bc079a3e6 100644
--- a/docs/_src/api/pydoc/other.yml
+++ b/docs/_src/api/pydoc/other.yml
@@ -1,7 +1,7 @@
loaders:
- type: python
search_path: [../../../../haystack/nodes/other]
- modules: ['docs2answers', 'join_doc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dask__dask-6428@4acc820 | dask/dask | Python | 6,428 | Multi value pivot table | - [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
Closes #6008 | 2020-07-19T15:52:10Z | dask.dataframe.pivot_table does not work with multiple values
In pivot_table when I use multiple columns for values `values=['D','A']` I have the following error in dask.
`ValueError: 'values' must be the name of an existing column`
With the same scripts but with just one value for `values='A'` there is no error.
... | Thanks for raising this issue! MultiIndexes are not supported in dask, so I don't think you can create a `pivot_table` passing a list of columns. That said, it would be more friendly to include a specific error for this case since it is supported in pandas. Would you be willing to open a PR to catch this case and retur... | [
{
"body": "In pivot_table when I use multiple columns for values `values=['D','A']` I have the following error in dask.\r\n`ValueError: 'values' must be the name of an existing column`\r\nWith the same scripts but with just one value for `values='A'` there is no error. \r\nSame scripts with `values=['D','A']` w... | dacda1379965784b2d4b58d82ca3a1a094029405 | {
"head_commit": "4acc820833a24d987364249a58358085be8eb009",
"head_commit_message": "remove comment",
"patch_to_review": "diff --git a/dask/dataframe/reshape.py b/dask/dataframe/reshape.py\nindex e775f06e46d..c1eb32618aa 100644\n--- a/dask/dataframe/reshape.py\n+++ b/dask/dataframe/reshape.py\n@@ -6,6 +6,7 @@\n f... | [
{
"diff_hunk": "@@ -220,14 +222,23 @@ def pivot_table(df, index=None, columns=None, values=None, aggfunc=\"mean\"):\n \"`df[columns].cat.as_known()` beforehand to ensure \"\n \"known categories\"\n )\n- if not is_scalar(values) or values is None:\n- raise ValueError(\"'... | ad71c07bb8d3909044308d8413089994cc9a25ad | diff --git a/dask/dataframe/reshape.py b/dask/dataframe/reshape.py
index e775f06e46d..6f194fe0efe 100644
--- a/dask/dataframe/reshape.py
+++ b/dask/dataframe/reshape.py
@@ -6,6 +6,7 @@
from .utils import is_categorical_dtype, is_scalar, has_known_categories
from ..utils import M
import sys
+from pandas.api.types imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
certbot__certbot-9622@e00ce4d | certbot/certbot | Python | 9,622 | Add async interface for finalization to acme.client.ClientV2 | Add `begin_order_finalization()`/`poll_finalization()` to `acme.client.ClientV2`, which are directly analogous to `answer_challenge()`/`poll_authorizations()`. This allows us to finalize an order and then later poll for its completion as separate steps. Also rewrite `finalize_order()` to call these two methods (which a... | 2023-03-22T14:16:15Z | acme: no interface for asynchronous finalization a la validation
`acme` provides API for answering challenges and later polling the status of authorizations. It would be very helpful for our use case if similar API existed for finalization (separating "start finalization" from "poll for completion of finalization"), wh... | 👍 This sounds like a good idea and I'd be happy to review it. | [
{
"body": "`acme` provides API for answering challenges and later polling the status of authorizations. It would be very helpful for our use case if similar API existed for finalization (separating \"start finalization\" from \"poll for completion of finalization\"), which would essentially just entail splittin... | 5d5dc429c477a308a23764a3bd19659b1c5b169e | {
"head_commit": "e00ce4db7ec8f110ff6133c5848fd630a95e7839",
"head_commit_message": "Add async interface for finalization to acme.client.ClientV2\n\nAdd `begin_order_finalization()`/`poll_finalization()` to\n`acme.client.ClientV2`, which are directly analogous to\n`answer_challenge()`/`poll_authorizations()`. This ... | [
{
"diff_hunk": "@@ -210,23 +210,35 @@ def poll_authorizations(self, orderr: messages.OrderResource, deadline: datetime\n raise errors.ValidationError(failed)\n return orderr.update(authorizations=responses)\n \n- def finalize_order(self, orderr: messages.OrderResource, deadline: datetime.... | 26426409cdbe391095c2c5158d8cd010dc151f1a | diff --git a/acme/acme/client.py b/acme/acme/client.py
index ee31f58a79a..ee1dd86ab08 100644
--- a/acme/acme/client.py
+++ b/acme/acme/client.py
@@ -210,23 +210,35 @@ def poll_authorizations(self, orderr: messages.OrderResource, deadline: datetime
raise errors.ValidationError(failed)
return orderr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-3445@3763116 | deepset-ai/haystack | Python | 3,445 | feat: Extraction of headlines in markdown files | ### Related Issues
- fixes #3056
### Proposed Changes:
<!--- In case of a bug: Describe what caused the issue and how you solved it -->
<!--- In case of a feature: Describe what did you add and how it works -->
This PR adds the possibility to extract headlines out of a markdown file. For this, it adds the para... | 2022-10-20T18:40:18Z | Extract headings from Markdown files
**Describe the solution you'd like**
Markdown files tag headlines with the `#` character. Different levels of headings are marked by the number of `#` characters. We should use this information and add headline information to the documents metadata. This information might be used... | [
{
"body": "\r\n**Describe the solution you'd like**\r\nMarkdown files tag headlines with the `#` character. Different levels of headings are marked by the number of `#` characters. We should use this information and add headline information to the documents metadata. This information might be used to improve re... | df4d20d32ce77f92456ab23e3f7c69ed59ad7b3b | {
"head_commit": "3763116f9a7023791de7c13b48085d2627371988",
"head_commit_message": "Generate JSON schema",
"patch_to_review": "diff --git a/docs/_src/api/api/file_converter.md b/docs/_src/api/api/file_converter.md\nindex 8fd6a86c3e..e954390de1 100644\n--- a/docs/_src/api/api/file_converter.md\n+++ b/docs/_src/ap... | [
{
"diff_hunk": "@@ -19,14 +19,46 @@\n \n \n class MarkdownConverter(BaseConverter):\n+ def __init__(\n+ self,\n+ remove_numeric_tables: bool = False,\n+ valid_languages: Optional[List[str]] = None,\n+ id_hash_keys: Optional[List[str]] = None,\n+ progress_bar: bool = True,\n... | eea5a72e4a83e2a9ddd9ec2548a6343a024a4b38 | diff --git a/docs/_src/api/api/file_converter.md b/docs/_src/api/api/file_converter.md
index 8fd6a86c3e..e954390de1 100644
--- a/docs/_src/api/api/file_converter.md
+++ b/docs/_src/api/api/file_converter.md
@@ -17,10 +17,7 @@ Base class for implementing file converts to transform input documents to text f
#### BaseCon... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
certbot__certbot-9644@75225b1 | certbot/certbot | Python | 9,644 | validate lineage name | Fixes [#6127](https://github.com/certbot/certbot/issues/6127).
Added blacklist mechanism for lineage name that avoids characters that are known to cause issues. Check occurs only when creating new lineage; this should avoid introducing a breaking change for lineages with those characters that users may have already ... | 2023-03-30T10:53:09Z | Don't allow special characters in lineage name
## My operating system is (include version):
Ubuntu 16.04.4
## I installed Certbot with (certbot-auto, OS package manager, pip, etc):
PPA, certbot 0.22.2
## I ran this command and it produced this output:
```bash
root@tom-vps:/etc/letsencrypt# certbot certonly --... | Thanks for reporting!
I'm trying to fix this by raising an error in the function `get_certnames` inside `cert_manager.py`.
"certname" appears in several places though, so I'm not sure if this will cover all cases where the user has input the certname.
Since we're not actually seeing people run into this, moving it t... | [
{
"body": "## My operating system is (include version):\r\nUbuntu 16.04.4\r\n\r\n## I installed Certbot with (certbot-auto, OS package manager, pip, etc):\r\nPPA, certbot 0.22.2\r\n\r\n## I ran this command and it produced this output:\r\n```bash\r\nroot@tom-vps:/etc/letsencrypt# certbot certonly --staging --we... | dc05b4da7a79bf33622ffb9d6b571c59b4415688 | {
"head_commit": "75225b16f012aca9f6a9dd165ee3a499cf437686",
"head_commit_message": "Use filepath seperators to determine lineagename validity",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex e429d80c3ec..2f22a930ef5 100644\n--- a/certbot/CHANGELOG.md\n+++ b/certbot/CHANGELOG.... | [
{
"diff_hunk": "@@ -20,6 +20,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n removed in a future version of Certbot.\n * Packaged tests for all Certbot components besides josepy were moved inside\n the `_internal/tests` module.\n+* Lineage name validity is performed for new lineages. `... | 3f17845abb12adf0315781c2c929dcdca322d34e | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index 3a9221f42ee..3d236b4f7c3 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -10,7 +10,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Changed
-*
+* Lineage name validity is performed for new lineages. `--cert-name` ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-3488@e07a8b3 | deepset-ai/haystack | Python | 3,488 | feat: Add headline extraction to `ParsrConverter` | ### Related Issues
- fixes #3057
### Proposed Changes:
<!--- In case of a bug: Describe what caused the issue and how you solved it -->
<!--- In case of a feature: Describe what did you add and how it works -->
This PR adds the possibility to extract headlines out of PDF files using `ParsrConverter`. It foll... | 2022-10-27T15:00:19Z | Make use of Parsr's heading detection
**Describe the solution you'd like**
Parsr has built-in heading detection. We should make use of it and add headline information of PDFs to the converted Documents. As far as I know, Parsr only detects the headings but not the hierarchy of the headings. We might determine the hi... | [
{
"body": "\r\n**Describe the solution you'd like**\r\nParsr has built-in heading detection. We should make use of it and add headline information of PDFs to the converted Documents. As far as I know, Parsr only detects the headings but not the hierarchy of the headings. We might determine the hierarchy of the ... | 8ddeda811a809838f7c58b8edb8a1bdfea72482e | {
"head_commit": "e07a8b3ed2f8d3087fa3782ef80eb53d007c23e0",
"head_commit_message": "Use extract_headlines if set in convert method",
"patch_to_review": "diff --git a/haystack/nodes/file_converter/parsr.py b/haystack/nodes/file_converter/parsr.py\nindex a13d609f0a..4186ed1751 100644\n--- a/haystack/nodes/file_con... | [
{
"diff_hunk": "@@ -290,5 +311,17 @@ def _convert_table_element(\n if self.add_page_number:\n table_meta[\"page\"] = page_idx + 1\n \n+ if extract_headlines:\n+ relevant_headlines = []\n+ cur_lowest_headline_level = 1000\n+ for headline in reversed(hea... | c070fcfc96b365dc98c71b8ba31f33794345d538 | diff --git a/haystack/nodes/file_converter/parsr.py b/haystack/nodes/file_converter/parsr.py
index a13d609f0a..fee43fe094 100644
--- a/haystack/nodes/file_converter/parsr.py
+++ b/haystack/nodes/file_converter/parsr.py
@@ -1,5 +1,5 @@
# pylint: disable=missing-timeout
-
+import sys
from typing import Optional, Dict, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dask__dask-6331@cb20c03 | dask/dask | Python | 6,331 | Update expected error msg for protocol difference in fsspec | Also remove check for error is a set of filenames is passed in as this
is now supported upstream.
Fixes #6327
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
Open question around whether a `set` of filenames is OK. I've removed the test for that for now, happy to put it back in and add... | 2020-06-17T14:25:43Z | Failing dask/bytes/tests/test_local.py with fsspec master
cc @martindurant
```
========================================================================= FAILURES =========================================================================
______________________________________________________________ test_urlpath_inf... | For the first one: he test should be updated to the new error message
For the second one, fsspec.core.get_fs_token_paths should probably call `fsspec.utils.stringify_path` for the input path(s)
Hey, I'm putting in a PR to update the error messages now that @martindurant merged in the fixes in `fsspec` --
question... | [
{
"body": "cc @martindurant\r\n\r\n```\r\n========================================================================= FAILURES =========================================================================\r\n______________________________________________________________ test_urlpath_inference_errors _________________... | 9f67c13b7b5558ad1dc2a5cc7579259709042f1c | {
"head_commit": "cb20c037bc9ae8c0688a1f76cd4ab897856c4b9c",
"head_commit_message": "Move check for ordered collections into bytes/core.py\n\n`fsspec` allows for sets to be pasted to `get_fs_token_paths` since\nother libraries using `fsspec` may not rely on the paths being in an\nordered collection. Dask does, so ... | [
{
"diff_hunk": "@@ -70,7 +70,7 @@ def test_urlpath_inference_errors():\n get_fs_token_paths([])\n \n # Protocols differ\n- with pytest.raises(ValueError, match=\"the same protocol\"):\n+ with pytest.raises(ValueError, match=\"Protocol mismatch\"):",
"line": null,
"original_line": 73,
... | b4bfb366d1e01ab894e589e9da96b9800d94c401 | diff --git a/dask/bytes/core.py b/dask/bytes/core.py
index 76b5a3b312f..e6b203ed158 100644
--- a/dask/bytes/core.py
+++ b/dask/bytes/core.py
@@ -1,3 +1,4 @@
+import os
import copy
from fsspec.core import ( # noqa: F401
@@ -90,6 +91,9 @@ def read_bytes(
represented in the corresponding block.
"""
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
cvat-ai__cvat-7697@f6df734 | cvat-ai/cvat | Python | 7,697 | [GSoC2024] feature: allow downloading video frames in custom extension | <!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will be approved and merged.
Read the [Contribution guide](https://opencv.github.io/cvat/doc... | 2024-03-28T18:10:48Z | Feature Request - Allow to download annotated video frames as JPG images (instead of PNG)
Hello everyone, I have a question regarding the "export dataset" feature in CVAT. When I use it and select the "save images" option, then all video frames will be downloaded as PNG images. Is there a way to tell CVAT that I would ... | @haimat , thanks for the report. I agree that it is an important feature which should be implemented.
You can export in any desired dataset format and convert images using [Datumaro](https://openvinotoolkit.github.io/datumaro/docs/user-manual/command-reference/convert/):
```
pip install datumaro[default]
datum con... | [
{
"body": "Hello everyone, I have a question regarding the \"export dataset\" feature in CVAT. When I use it and select the \"save images\" option, then all video frames will be downloaded as PNG images. Is there a way to tell CVAT that I would rather download all those images as JPG files?\r\n\r\nIf that is no... | 82a7635c6e0f417672b0faeb067e57bbf4e796e4 | {
"head_commit": "f6df73471f82a13f14180b8b12ec5859f7e36869",
"head_commit_message": "feature: allow downloading video frames in custom extension",
"patch_to_review": "diff --git a/cvat-sdk/cvat_sdk/core/proxies/tasks.py b/cvat-sdk/cvat_sdk/core/proxies/tasks.py\nindex 0bebcc6507d4..7384beba65bb 100644\n--- a/cvat... | [
{
"diff_hunk": "@@ -219,31 +219,24 @@ def download_chunk(\n def download_frames(\n self,\n frame_ids: Sequence[int],\n+ image_extension: str,\n *,\n- outdir: StrPath = \".\",\n+ outdir: str = \".\",\n quality: str = \"original\",\n filename_patter... | 2e682e7e0201856cc3196bb26770d548349d7097 | diff --git a/changelog.d/20240410_200046_harsh_k_feature_custom_extension.md b/changelog.d/20240410_200046_harsh_k_feature_custom_extension.md
new file mode 100644
index 000000000000..037957eff9d6
--- /dev/null
+++ b/changelog.d/20240410_200046_harsh_k_feature_custom_extension.md
@@ -0,0 +1,4 @@
+### Changed
+
+- Job a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-3379@5d172cb | deepset-ai/haystack | Python | 3,379 | feat: add `document_store` to all `BaseRetriever.retrieve()` and `BaseRetriever.retrieve_batch()` implementations | ### Related Issues
- fixes #3348
### Proposed Changes:
- Makes the document store optional in all Retrievers' `__init__` methods
- Adds a `document_store` optional parameter to all the Retrievers' `retrieve` and `retrieve_batch` methods.
### How did you test it?
- Existing tests
### Notes for the reviewer
... | 2022-10-13T16:14:53Z | Move `document_store` argument to `retrieve` method instead of the Retriever's constructor
**Is your feature request related to a problem? Please describe.**
Retrievers' constructors require the `document_store` parameter to be created. While this may be ok for sparse retrievers, DPR, for example, requires loading m... | Hi @Goader thank you for making this suggestion and for describing it in so much detail. 👍 We thought about improving the current coupling of retriever and document store in our team too. What do you think about the suggestion here @ZanSara @masci ?
@julian-risch I think the solution proposed here could be implemented... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n\r\nRetrievers' constructors require the `document_store` parameter to be created. While this may be ok for sparse retrievers, DPR, for example, requires loading models. And then, when I want to use the same retriever, but with a d... | d0691a4bd5112a88b76b66a3249bfc20770e2110 | {
"head_commit": "5d172cbf6a32df4da2078121d91191c1973fdb67",
"head_commit_message": "revert accidental test changes",
"patch_to_review": "diff --git a/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json b/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json\nindex cdf8de2789..60affda944 100644\... | [
{
"diff_hunk": "@@ -155,7 +159,13 @@ def eval(\n \n timed_retrieve = self.timing(self.retrieve, \"retrieve_time\")\n \n- labels: List[MultiLabel] = self.document_store.get_all_labels_aggregated(\n+ if document_store is None:\n+ document_store = self.document_store\n+ ... | 3f036dcaaadfd6fe98121eb0056429f2c9612375 | diff --git a/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json b/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json
index cdf8de2789..60affda944 100644
--- a/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json
+++ b/haystack/json-schemas/haystack-pipeline-1.10.0rc0.schema.json
@@ -227,8... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dask__dask-6263@22195a4 | dask/dask | Python | 6,263 | Generalize `from_dask_array` | Fixes: https://github.com/rapidsai/cudf/issues/5263
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
cc: @kkraus14 @quasiben | 2020-05-29T23:53:21Z | [BUG] Adding a random int column in dask cudf dataframe results in a string BINARY_OP error
**Describe the bug**
I want to add a new column of random integers to a dask cudf dataframe. A strange BINARY_OP error occured.
**Steps/Code to reproduce bug**
```
import cudf as gd
import dask_cudf
df = gd.DataFrame(lis... | [
{
"body": "**Describe the bug**\r\nI want to add a new column of random integers to a dask cudf dataframe. A strange BINARY_OP error occured.\r\n\r\n**Steps/Code to reproduce bug**\r\n```\r\nimport cudf as gd\r\nimport dask_cudf\r\ndf = gd.DataFrame(list(range(100)))\r\nddf = dask_cudf.from_cudf(df,npartitions=... | 79836fe4a52c9cf0e1eb32525792ad6bfed1c62b | {
"head_commit": "22195a4f64bc1fc5e2f587a97b330abbaa0dea8a",
"head_commit_message": "typos",
"patch_to_review": "diff --git a/dask/array/core.py b/dask/array/core.py\nindex ef897009182..7b55c1dea28 100644\n--- a/dask/array/core.py\n+++ b/dask/array/core.py\n@@ -1430,7 +1430,7 @@ def to_hdf5(self, filename, datapa... | [
{
"diff_hunk": "@@ -1430,7 +1430,7 @@ def to_hdf5(self, filename, datapath, **kwargs):\n \"\"\"\n return to_hdf5(filename, datapath, self, **kwargs)\n \n- def to_dask_dataframe(self, columns=None, index=None):\n+ def to_dask_dataframe(self, columns=None, index=None, meta_df=None):",
"l... | 586c7eb3796ffe9bf8f95cb4768b847bdbff9698 | diff --git a/dask/array/core.py b/dask/array/core.py
index ef897009182..0c82c6240e9 100644
--- a/dask/array/core.py
+++ b/dask/array/core.py
@@ -1430,7 +1430,7 @@ def to_hdf5(self, filename, datapath, **kwargs):
"""
return to_hdf5(filename, datapath, self, **kwargs)
- def to_dask_dataframe(self, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
dask__dask-6226@082c0fd | dask/dask | Python | 6,226 | Avoid shuffle when setting a presorted index with overlapping divisions | - [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
Resolves https://github.com/dask/dask/pull/5076, closes https://github.com/dask/dask/issues/4860 | 2020-05-20T09:44:23Z | Repartition randomly dropping some rows
**Bug report**
When I called `set_index(..., sorted=True)`, I got a warning saying partition indices have overlap, which is fine. From here, after calling `repartition`, I lost a row. This must be a bug in the `repartition` code since I don't see why `repartition` would make m... | I found a workaround to this phenomenon. Instead of using `repartition`, I just manually constructed the graph using `methods.boundary_slice`, though it seems like overkill to me.
It's possible that `sorted=True` is assuming that the provided index is
strictly increasing. Are you interested in investigating?
On Thu, M... | [
{
"body": "**Bug report**\r\n\r\nWhen I called `set_index(..., sorted=True)`, I got a warning saying partition indices have overlap, which is fine. From here, after calling `repartition`, I lost a row. This must be a bug in the `repartition` code since I don't see why `repartition` would make me lose rows.\r\n\... | 3b92efff2e779f59e95e05af9b8f371d56227d02 | {
"head_commit": "082c0fd4615de09531727cee273bce316142324e",
"head_commit_message": "flake8",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 26048654b0d..c320ad78cb3 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -6294,8 +6294,6 @@ def prefix_reduct... | [
{
"diff_hunk": "@@ -776,6 +773,49 @@ def set_index_post_series(df, index_name, drop, column_dtype):\n return df2\n \n \n+def drop_overlap(df, index):\n+ return df.drop(index) if index in df.index else df\n+\n+\n+def get_overlap(df, index):\n+ return df.loc[[index]] if index in df.index else None\n+\n+... | 698c6c0e11f1c03aede37e8a0dceef4887753c34 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 26048654b0d..c320ad78cb3 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -6294,8 +6294,6 @@ def prefix_reduction(f, ddf, identity, **kwargs):
ddf : dd.DataFrame
identity : pd.DataFrame
an identity element of f, tha... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-6090@3d85beb | dask/dask | Python | 6,090 | [WIP] [Parquet] Handle new (dtype) pandas metadata with pyarrow | Closes #6085
Uses `ignore_metadata=False` during arrow -> pandas conversion in `ArrowEngine` parquet reader. Before these changes, `ignore_metadata=True` was used to simplify the setting of the index. However, the pandas metadata is needed to get certain dtype conversions correct.
- [ ] Tests added / passed
- ... | 2020-04-13T18:25:37Z | DataFrames with nullable integer or new string dtype don't support the full roundtrip to parquet
Hi guys,
Regarding the nullable integer dtype, pandas v1.0.0 offers the writing and reading back in with to_parquet() / read_parquet() starting with pyarrow >= 0.16.
It seems Dask Dataframes do not comply yet
```python... | Thanks for the report. The fact that the metadata is correct is helpful.
The issue seems to be the `ignore_metadata` at https://github.com/dask/dask/blob/263187bbc263a395dc871e5874ee4fda21abb190/dask/dataframe/io/parquet/arrow.py#L549
```
517 -> df = df.to_pandas(categories=categories, use_threads=False... | [
{
"body": "Hi guys,\r\n\r\nRegarding the nullable integer dtype, pandas v1.0.0 offers the writing and reading back in with to_parquet() / read_parquet() starting with pyarrow >= 0.16.\r\nIt seems Dask Dataframes do not comply yet\r\n```python\r\nimport dask.dataframe as dd\r\n\r\ndf = dd.from_pandas(pd.DataFram... | 71113eacbf83437f59984d053c10e52f6ce97f70 | {
"head_commit": "3d85bebf9de71d8cca3f0f0f89912e19b7648ac0",
"head_commit_message": "use issubset for clarity",
"patch_to_review": "diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py\nindex b75a764d000..2fae52a1e9e 100644\n--- a/dask/dataframe/io/parquet/arrow.py\n+++ b/dask/data... | [
{
"diff_hunk": "@@ -2358,3 +2358,23 @@ def test_filter_nonpartition_columns(\n df_read = ddf_read.compute()\n assert len(df_read) == len(df_read[df_read[\"time\"] < 5])\n assert df_read[\"time\"].max() < 5\n+\n+\n+@pytest.mark.parametrize(\"dtype\", [\"Int64\", \"str\"])",
"line": null,
"ori... | c7010d69c67f94e4af1311297928de69935fa025 | diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py
index b75a764d000..2fae52a1e9e 100644
--- a/dask/dataframe/io/parquet/arrow.py
+++ b/dask/dataframe/io/parquet/arrow.py
@@ -546,9 +546,34 @@ def read_partition(
use_pandas_metadata=True,
use_threads=False,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
certbot__certbot-9537@5b598c7 | certbot/certbot | Python | 9,537 | Deprecate {csr, keys} dirs & automatically truncate lineages | Based on my design [here](https://docs.google.com/document/d/1jGh_bZPnrhi96KzuIcyCJfnudl4m3pRPGkiK4fTo8e4/edit?usp=sharing).
Fixes https://github.com/certbot/certbot/issues/4634 and https://github.com/certbot/certbot/issues/4635.
- [x] Deprecate `NamespaceConfig.csr_dir`,`NamespaceConfig.key_dir`, ~~`constants.C... | 2023-01-16T21:28:14Z | Deprecate /etc/letsencrypt/{keys,csr}
Although these were added for super-plausible reasons about going back and finding stuff that people might need, I'm not sure if I've ever come across any case where someone successfully used their contents correctly (with the possible exception of people who naively deleted all of... | While I understand the argument for deleting private keys (for the future secrecy (FS)), I might be missing the argument(s) for deleting the past CSRs (except for people being confused).
I don't think CSRs affect FS, do they?
I've just actually looked at CSRs to analyze certain aspects of it... While it is not a co... | [
{
"body": "Although these were added for super-plausible reasons about going back and finding stuff that people might need, I'm not sure if I've ever come across any case where someone successfully used their contents correctly (with the possible exception of people who naively deleted all of `/etc/letsencrypt/... | e7fcd0e08d177d22f92f690e8fe1c47877fb3e77 | {
"head_commit": "5b598c7beaae831f0b804d9fd8caaadbce3e1c4e",
"head_commit_message": "docs: remove reference to /archive and /keys",
"patch_to_review": "diff --git a/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py b/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py\nindex 65eca976d58.... | [
{
"diff_hunk": "@@ -15,7 +15,9 @@\n # certbot-dns-rfc2136.\n # 2) pytest-cov uses deprecated functionality in pytest-xdist, to be resolved by\n # https://github.com/pytest-dev/pytest-cov/issues/557.\n+# 3) csr_dir and key_dir are deprecated and should be removed in Certbot 3.0.\n filterwarnings =\n er... | cfa98292c5b81f93abe106f0bd3cb24934466815 | diff --git a/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py b/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py
index 65eca976d58..356eaa77406 100644
--- a/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py
+++ b/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dask__dask-6143@3c16a2e | dask/dask | Python | 6,143 | Add Tom's log config example | Fixes https://github.com/dask/distributed/issues/3669
| 2020-04-27T17:11:19Z | Write logs to disk as well
IIUC the scheduler and workers currently only log in memory. This works fine except if the scheduler or worker dies, in which case these logs are lost. It would be useful for logs to also be written to disk. This would allow users to inspect logs from dead workers to better understand what is... | I think the scheduler and workers will log to stdout (or may stderr?). For example:
```python
In [1]: from distributed import Scheduler
In [2]: s = await Scheduler(host="localhost")
distributed.scheduler - INFO - Clear task state
distributed.scheduler - INFO - Scheduler at: tcp://127.0.0.1:51582
In [3... | [
{
"body": "IIUC the scheduler and workers currently only log in memory. This works fine except if the scheduler or worker dies, in which case these logs are lost. It would be useful for logs to also be written to disk. This would allow users to inspect logs from dead workers to better understand what is happeni... | ae42c727f1fe75be7a7386f5014e48c4d5734004 | {
"head_commit": "3c16a2e787add7f6744cb8c12b5d136660f0d415",
"head_commit_message": "Add Tom's log config example",
"patch_to_review": "diff --git a/docs/source/debugging.rst b/docs/source/debugging.rst\nindex ba3c4aef402..7a32ce087b9 100644\n--- a/docs/source/debugging.rst\n+++ b/docs/source/debugging.rst\n@@ -1... | [
{
"diff_hunk": "@@ -189,9 +190,48 @@ Defaults currently look like the following:\n distributed.client: warning\n bokeh: error\n \n-So, for example, you could add a line like ``distributed.worker: debug`` to get\n+The specific components which you can set are ``distributed.client``, ``distributed.sche... | 6ca7c23bfbff1ed5d52699b9f7c5111c48eac2d1 | diff --git a/docs/source/debugging.rst b/docs/source/debugging.rst
index ba3c4aef402..f0bc3de929b 100644
--- a/docs/source/debugging.rst
+++ b/docs/source/debugging.rst
@@ -179,7 +179,8 @@ launching Dask on your own, they will probably dump to the screen unless you
<https://en.wikipedia.org/wiki/Redirection_(computing... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-3301@e702924 | deepset-ai/haystack | Python | 3,301 | feat: Adding filters param to MostSimilarDocumentsPipeline run and run_batch | ### Related Issues
- fixes #3288
### Proposed Changes:
Adding a param called "filters" to methods run and run_batch of MostSimilarDocumentsPipeline class, this param is sent to the query_by_embedding method of document_store, which already implements the logic to filter the results
### How did you test it?
Exi... | 2022-10-01T11:41:53Z | Add filters param to MostSimilarDocumentsPipeline
I tried to get the most similar documents given a document identifier, which is essentially the functionality of MostSimilarDocumentsPipeline. However, I would like the returned documents follow certain rules, for instance, only return documents which belongs to a categ... | Hi @JacdDev, thanks for opening the issue! I think that is a great idea. Would you be willing to open a PR with the suggested changes? We'd be happy to help answer any questions you have about the process.
Sure, I'm going to read the Contributor Guidelines and try to help, thanks. | [
{
"body": "I tried to get the most similar documents given a document identifier, which is essentially the functionality of MostSimilarDocumentsPipeline. However, I would like the returned documents follow certain rules, for instance, only return documents which belongs to a category.\r\n\r\nI think the easiest... | b84a6b17165dbf10665794b5decdefa113300749 | {
"head_commit": "e702924ae050f16f0a5ab3264bba14826e1e00c1",
"head_commit_message": "Adding filters param to MostSimilarDocumentsPipeline run and run_batch",
"patch_to_review": "diff --git a/haystack/pipelines/standard_pipelines.py b/haystack/pipelines/standard_pipelines.py\nindex 6275b0272c..7ef798f5e0 100644\n-... | [
{
"diff_hunk": "@@ -213,6 +246,37 @@ def test_most_similar_documents_pipeline_batch(retriever, document_store):\n document_store.write_documents(documents)\n document_store.update_embeddings(retriever)\n \n+ docs_id: list = [\"a\", \"b\"]\n+ filters = {\"source\": [\"wiki3\", \"wiki4\", \"wiki5\"]... | 9329bc972ad7bc937f4478e7bb9bbadb55f90454 | diff --git a/haystack/pipelines/standard_pipelines.py b/haystack/pipelines/standard_pipelines.py
index 203cf5e29d..de18bd8ac5 100644
--- a/haystack/pipelines/standard_pipelines.py
+++ b/haystack/pipelines/standard_pipelines.py
@@ -717,27 +717,43 @@ def __init__(self, document_store: BaseDocumentStore):
self.pi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-10784@ff76596 | dbt-labs/dbt-core | Python | 10,784 | Attempt to skip saved query processing when no semantic manifest changes | Resolves #10563
### Problem
We run "process_saved_queries" even when nothing has changed in the semantic manifest.
### Solution
Check for changes to saved queries, semantic models, and metrics before executing process saved queries. This will have false positives because of cascading re-parsing, but will en... | 2024-09-26T14:15:38Z | Do not execute process_saved_queries if nothing in semantic manifest has changed
### Description
Currently we run process_saved_queries for every saved query in a manifest, even if nothing has changed in the semantic manifest. In the right circumstances this can be a performance problem.
### Acceptance Criteria
... | Saved queries, metrics and semantic models are in the semantic manifest. In some cases semantic_models may be "scheduled for parsing" because a model that it refers to has changed, but nothing in the actual definition has changed. If we want to minimize the cases where we run process_saved_queries, it might make sense ... | [
{
"body": "### Description\r\n\r\nCurrently we run process_saved_queries for every saved query in a manifest, even if nothing has changed in the semantic manifest. In the right circumstances this can be a performance problem.\r\n\r\n### Acceptance Criteria\r\n\r\nCheck for actual changes to the semantic manifes... | 1fd4d2eae6e8d052ea8997a68ca4de18255da7a7 | {
"head_commit": "ff76596b7bbb6d6cf5825b1396fc3849019374f0",
"head_commit_message": "Attempt to skip saved query processing when no semantic manifest changes",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240926-101220.yaml b/.changes/unreleased/Fixes-20240926-101220.yaml\nnew file mode 100644\nin... | [
{
"diff_hunk": "@@ -1141,6 +1141,24 @@ def process_metrics(self, config: RuntimeConfig):\n \n def process_saved_queries(self, config: RuntimeConfig):\n \"\"\"Processes SavedQuery nodes to populate their `depends_on`.\"\"\"\n+ # Note: This will also capture various nodes which have been re-par... | cebb1ceaef218d84e1fbbec1a635dab790329b8f | diff --git a/.changes/unreleased/Fixes-20240926-101220.yaml b/.changes/unreleased/Fixes-20240926-101220.yaml
new file mode 100644
index 00000000000..677ee458048
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240926-101220.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Attempt to skip saved query processing when no semantic ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
dbt-labs__dbt-core-10756@0c6e9a2 | dbt-labs/dbt-core | Python | 10,756 | Add required 'begin' config support for microbatch models | Resolves https://github.com/dbt-labs/dbt-core/issues/10701
<!---
Include the number of the issue addressed by this PR above, if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
Add the `user docs` label to this PR if it will ne... | 2024-09-22T18:11:45Z | Require defining a `begin` config for microbatch incremental models
We need to know what the "beginning of time" is for a microbatch model, to know when to start for these two cases:
- The first time this model is run
- If you run in “full-refresh-mode”
This is distinct from the CLI parameter `--event-time-start` ... | [
{
"body": "We need to know what the \"beginning of time\" is for a microbatch model, to know when to start for these two cases:\r\n- The first time this model is run\r\n- If you run in “full-refresh-mode”\r\n\r\nThis is distinct from the CLI parameter `--event-time-start` which can also be used when running in ... | db694731c9c9048745b10f0aa51dec88e008288e | {
"head_commit": "0c6e9a2e5f2c2c82dfed53c14c4c3f4c7e5c9635",
"head_commit_message": "fix functional tests",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20240923-155903.yaml b/.changes/unreleased/Features-20240923-155903.yaml\nnew file mode 100644\nindex 00000000000..b05e81b94d2\n--- /dev/null\n+... | [
{
"diff_hunk": "@@ -46,41 +46,39 @@ def build_start_time(self, checkpoint: Optional[datetime]):\n to build a start time. This is because we build the start time relative to the checkpoint",
"line": 47,
"original_line": 46,
"original_start_line": null,
"path": "core/dbt/materializations/i... | 9e0f6849c915239efb4a5318a55a02add4db6c53 | diff --git a/.changes/unreleased/Features-20240923-155903.yaml b/.changes/unreleased/Features-20240923-155903.yaml
new file mode 100644
index 00000000000..b05e81b94d2
--- /dev/null
+++ b/.changes/unreleased/Features-20240923-155903.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Support required 'begin' config for microbat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dask__dask-5977@317720c | dask/dask | Python | 5,977 | Fixed flaky test-rearrange | Puts file cleanup in the task graph, rather than relying on Partd to do it for us. I'm not really happy with my approach, but wanted to try this on CI a few times.
Closes #5867
| 2020-03-04T22:13:40Z | Flaky test test_rearrange
```
=================================== FAILURES ===================================
________________________ test_rearrange[processes-disk] ________________________
shuffle = 'disk', scheduler = 'processes'
@pytest.mark.parametrize("shuffle", ["tasks", "disk"])
@pytest.ma... | This seems to occur when the directory is removed prior between creating the `partd.File` object and attempting to append data to it. Roughly
```pytb
In [13]: import partd
In [14]: f = partd.File("data", )
In [16]: !rm -rf data
In [17]: f.append({"x": b"abc"})
-----------------------------------------------... | [
{
"body": "```\r\n=================================== FAILURES ===================================\r\n\r\n________________________ test_rearrange[processes-disk] ________________________\r\n\r\nshuffle = 'disk', scheduler = 'processes'\r\n\r\n @pytest.mark.parametrize(\"shuffle\", [\"tasks\", \"disk\"])\r\n\... | fa63ce13ee1773d2042654a26a479bce932f292e | {
"head_commit": "317720cfb6f0bf5078c98001ae9f3ea8191d1283",
"head_commit_message": "hrmm",
"patch_to_review": "diff --git a/dask/dataframe/shuffle.py b/dask/dataframe/shuffle.py\nindex 1d29d0b4220..153704cb67c 100644\n--- a/dask/dataframe/shuffle.py\n+++ b/dask/dataframe/shuffle.py\n@@ -1,6 +1,9 @@\n+import logg... | [
{
"diff_hunk": "@@ -257,8 +258,8 @@ def test_shuffle_sort(shuffle):\n assert_eq(ddf2.loc[2:3], df2.loc[2:3])\n \n \n-@pytest.mark.parametrize(\"shuffle\", [\"tasks\", \"disk\"])\n-@pytest.mark.parametrize(\"scheduler\", [\"threads\", \"processes\"])\n+@pytest.mark.parametrize(\"shuffle\", [\"disk\"])\n+@pyt... | a2d211afc1d73381f709fe9792ede03a74210e8b | diff --git a/dask/dataframe/shuffle.py b/dask/dataframe/shuffle.py
index 8e7c536b48d..4553aa22724 100644
--- a/dask/dataframe/shuffle.py
+++ b/dask/dataframe/shuffle.py
@@ -1,6 +1,10 @@
+import contextlib
+import logging
import math
+import shutil
from operator import getitem
import uuid
+import tempfile
import war... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
deepset-ai__haystack-3283@907bce7 | deepset-ai/haystack | Python | 3,283 | refactor: remove Inferencer multiprocessing | ### Related Issues
- fixes #3272
### Proposed Changes:
Inferencer multiprocessing just as in https://github.com/deepset-ai/haystack/issues/3087 started to cause lockups recently due to various inconsistencies around multiprocessing in torch. Some torch versions worked well, while others caused outright deadlocks.... | 2022-09-27T07:57:37Z | QA inferencer very slow because of bad default multiprocessing settings
**Describe the bug**
When doing pipeline.eval I realized that it is very slow and also outputs way too many lines of tqdm.
That is why I tested it with and without multiprocessing. My results are incredible:
MP on
Elapsed: 22.35
MP off
E... | Confirming performance speedup when using FARMReader `predict` API and MP turned off, see colab [notebook](https://colab.research.google.com/drive/129-VEBDzBc0RF3D0dg8b2wWumSw8RhkU)
Considering the findings of issue #3289 my guess is that the multiprocessing present in the `Inferencer` does not work properly when using... | [
{
"body": "**Describe the bug**\r\nWhen doing pipeline.eval I realized that it is very slow and also outputs way too many lines of tqdm.\r\nThat is why I tested it with and without multiprocessing. My results are incredible:\r\n\r\nMP on \r\nElapsed: 22.35\r\n\r\nMP off\r\nElapsed: **6.079**\r\n\r\n\r\n**To Rep... | e6767fccefdc6c36cd57613453ca98488c49392b | {
"head_commit": "907bce728028563c62790a91489ae30c143fda9d",
"head_commit_message": "Add more deprecated notes in pydoc",
"patch_to_review": "diff --git a/haystack/modeling/infer.py b/haystack/modeling/infer.py\nindex c7c289b4c5..c301b85d0e 100644\n--- a/haystack/modeling/infer.py\n+++ b/haystack/modeling/infer.p... | [
{
"diff_hunk": "@@ -399,57 +341,6 @@ def _inference_without_multiprocessing(self, dicts: List[Dict], return_json: boo\n \n return preds_all\n \n- def _inference_with_multiprocessing(\n- self,\n- dicts: Union[List[Dict], Generator[Dict, None, None]],\n- return_json: bool,\n- ... | f0850b765bb3f19e89731c0b6815136e6928cc87 | diff --git a/haystack/modeling/infer.py b/haystack/modeling/infer.py
index c7c289b4c5..d8ab26a27e 100644
--- a/haystack/modeling/infer.py
+++ b/haystack/modeling/infer.py
@@ -1,9 +1,7 @@
-from typing import List, Optional, Dict, Union, Generator, Set, Any
+from typing import List, Optional, Dict, Union, Set, Any
imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
dask__dask-5929@7e936eb | dask/dask | Python | 5,929 | Implement dask.dataframe.to_numeric | Closes: #5698
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
@TomAugspurger I haven't added any of the kwargs yet, but just wanted to make sure that this is what you intended. | 2020-02-19T21:41:02Z | Implement dask.dataframe.to_numeric
Which mimics `pandas.to_numeric`.
For scalar inputs, this could return a Delayed object.
For array inputs, this would return a `dask.array.Array` and would be `.map_blocks(pd.to_numeric)`.
For Series, it'd be `.map_partitions(pd.to_numeric)`.
I'm not sure if downcasting c... | Just to say that I am taking a crack at this | [
{
"body": "Which mimics `pandas.to_numeric`.\r\n\r\nFor scalar inputs, this could return a Delayed object.\r\n\r\nFor array inputs, this would return a `dask.array.Array` and would be `.map_blocks(pd.to_numeric)`.\r\n\r\nFor Series, it'd be `.map_partitions(pd.to_numeric)`.\r\n\r\nI'm not sure if downcasting ca... | 3f68b43057724365e485b3cd6e68cacbcd9f5811 | {
"head_commit": "7e936eb507787b5a862aebc6bb16fd593551c03c",
"head_commit_message": "Implement downcast and errors kwargs",
"patch_to_review": "diff --git a/dask/dataframe/__init__.py b/dask/dataframe/__init__.py\nindex 064a795b9df..a7ffeb53b68 100644\n--- a/dask/dataframe/__init__.py\n+++ b/dask/dataframe/__init... | [
{
"diff_hunk": "@@ -0,0 +1,70 @@\n+import pandas as pd\n+from pandas.core.dtypes.common import is_scalar as pd_is_scalar\n+\n+from ..utils import derived_from\n+from ..delayed import delayed\n+from ..array import Array\n+from .core import Series\n+\n+\n+__all__ = (\"to_numeric\",)\n+\n+\n+@derived_from(pd)\n+de... | efcc97007f70e4b61e92d9091d328b902ff8b25a | diff --git a/dask/dataframe/__init__.py b/dask/dataframe/__init__.py
index 064a795b9df..a7ffeb53b68 100644
--- a/dask/dataframe/__init__.py
+++ b/dask/dataframe/__init__.py
@@ -29,6 +29,7 @@
to_json,
read_fwf,
)
+ from .numeric import to_numeric
from .optimize import optimize
from .m... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-5765@f5a8435 | dask/dask | Python | 5,765 | Unify chunks in broadcast_arrays | Fixes #5754
- [ ] Tests added / passed
- [ ] Passes `black dask` / `flake8 dask`
| 2020-01-05T04:07:03Z | numpy.broadcast_array on dask array raises ValueError("Chunks do not align").
This is a regression. The old behaviour seems to be broadcast_array forces dask to perform a compute() to return arrays instead.
The new current behaviour seems to be going through the `__array_function__` protocol and perform a dask broad... | Thanks @rainwoodman . I'm not entirely sure I understand the context. Do you have a small example that causes this error?
Yes.
numpy.broadcast_array used to trigger .compute() (presumably via numpy.array) and did not dispatch this into dask's broadcast_arrays function.
With 2.9.0, it goes through dask's broad... | [
{
"body": "This is a regression. The old behaviour seems to be broadcast_array forces dask to perform a compute() to return arrays instead.\r\n\r\nThe new current behaviour seems to be going through the `__array_function__` protocol and perform a dask broadcast without automatic rechunking.\r\n\r\nI am not sure... | 03a75ca4a7a6afd3bf7ee9ace1ce78c287545bad | {
"head_commit": "f5a8435717f69b2b8ab93b25c3d80ac51175792c",
"head_commit_message": "Unify chunks in broadcast_arrays",
"patch_to_review": "diff --git a/dask/array/core.py b/dask/array/core.py\nindex 75b7682de4a..9221cacb4ed 100644\n--- a/dask/array/core.py\n+++ b/dask/array/core.py\n@@ -4025,6 +4025,11 @@ def br... | [
{
"diff_hunk": "@@ -4025,6 +4025,11 @@ def broadcast_arrays(*args, **kwargs):\n if kwargs:\n raise TypeError(\"unsupported keyword argument(s) provided\")\n \n+ # Unify uneven chunking\n+ inds = [list(range(x.ndim))[::-1] for x in args]",
"line": null,
"original_line": 4029,
"origi... | 86c9fff0b47b295ef5d4a9e9c8143f9bebcc5ae8 | diff --git a/dask/array/core.py b/dask/array/core.py
index 75b7682de4a..3938fe3fe4b 100644
--- a/dask/array/core.py
+++ b/dask/array/core.py
@@ -4025,6 +4025,11 @@ def broadcast_arrays(*args, **kwargs):
if kwargs:
raise TypeError("unsupported keyword argument(s) provided")
+ # Unify uneven chunking
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10721@12f6436 | dbt-labs/dbt-core | Python | 10,721 | Add Snowplow tracking for behavior flags | resolves #10552
### Problem
We need to track deprecated states of behavior flags in Snowplow so that we get telemetry for both Cloud and Core users.
### Solution
Handle the event that is already firing for logging with a callback that tracks the event in Snowplow.
### Checklist
- [x] I have read [the ... | 2024-09-16T18:08:46Z | [Behavior Flags] Track behavior flags in Snowplow
### Housekeeping
- [X] I am a maintainer of dbt-core
## Short description
As a maintainer, I need to track what proportion of users are using legacy behavior, so that I know when it's safe to retire that behavior. We already fire a warning event when the flag e... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of dbt-core\r\n\r\n## Short description\r\n\r\nAs a maintainer, I need to track what proportion of users are using legacy behavior, so that I know when it's safe to retire that behavior. We already fire a warning event when the flag evaluates to `False`... | 1e20772d3374a37b7a5443836514ef13a232a190 | {
"head_commit": "12f6436df24c135da48bb000989c16ba41c9c218",
"head_commit_message": "update tests for new callback",
"patch_to_review": "diff --git a/.changes/unreleased/Under the Hood-20240911-162730.yaml b/.changes/unreleased/Under the Hood-20240911-162730.yaml\nnew file mode 100644\nindex 00000000000..0d35aeb5... | [
{
"diff_hunk": "@@ -68,6 +70,7 @@ def setup_event_logger(flags, callbacks: List[Callable[[EventMsg], None]] = [])\n make_log_dir_if_missing(flags.LOG_PATH)\n event_manager = get_event_manager()\n event_manager.callbacks = callbacks.copy()\n+ add_callback_to_manager(track_behavior_deprecation_warn... | 1e20bd8c027bded2baa335001288e644042a7e64 | diff --git a/.changes/unreleased/Under the Hood-20240911-162730.yaml b/.changes/unreleased/Under the Hood-20240911-162730.yaml
new file mode 100644
index 00000000000..0d35aeb5262
--- /dev/null
+++ b/.changes/unreleased/Under the Hood-20240911-162730.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Add Snowplow tracki... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-3168@9817ffa | deepset-ai/haystack | Python | 3,168 | feat: add health check endpoint to rest api | ### Related Issues
- fixes #3165
### Proposed Changes:
One FastAPI /health endpoint has been added. This endpoint's purpose is to allow faster diagnoses in the REST API environment and to use advanced monitoring tools to check the API status.
Users can set up alerts into monitoring tools to tell when the CPU, ... | 2022-09-05T21:35:18Z | REST API Health endpoint
**Is your feature request related to a problem? Please describe.**
Today, when using the REST API deployed on a container or any other environment, there is no health endpoint for extensive health monitoring of the system.
Only /initialized provides some information regarding the system, bu... | @masci I noticed you have been working on the REST API, what do you think about this endpoint?
@ZanSara You always have interesting points. Any opinions regarding it? | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nToday, when using the REST API deployed on a container or any other environment, there is no health endpoint for extensive health monitoring of the system.\r\n\r\nOnly /initialized provides some information regarding the system, bu... | 84acb6584fe09bbfd4aca2ae3a073578a8744e24 | {
"head_commit": "9817ffa95d10b1b8b8c11908d549ce8d99247374",
"head_commit_message": "docs: manual black run",
"patch_to_review": "diff --git a/docs/_src/api/openapi/openapi-1.8.1rc0.json b/docs/_src/api/openapi/openapi-1.8.1rc0.json\nindex 4acf2a9c9d..ea79d2dd19 100644\n--- a/docs/_src/api/openapi/openapi-1.8.1rc... | [
{
"diff_hunk": "@@ -0,0 +1,126 @@\n+from typing import List\n+\n+import logging\n+\n+import os\n+import pynvml\n+import psutil\n+\n+from pydantic import BaseModel, Field\n+\n+from fastapi import FastAPI, APIRouter\n+\n+import haystack\n+\n+from rest_api.utils import get_app\n+from rest_api.config import LOG_LEV... | e9e24c80df481a4e070ee8380e1f2cfb33be5bbc | diff --git a/docs/_src/api/openapi/openapi-1.8.1rc0.json b/docs/_src/api/openapi/openapi-1.8.1rc0.json
index 4acf2a9c9d..7e588f01fa 100644
--- a/docs/_src/api/openapi/openapi-1.8.1rc0.json
+++ b/docs/_src/api/openapi/openapi-1.8.1rc0.json
@@ -398,6 +398,28 @@
}
}
}
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
certbot__certbot-9355@eb932e1 | certbot/certbot | Python | 9,355 | Configuration File Update w/o Certificate Issuance | Fixes #8822
This PR allows a user to modify the configuration of a certificate without renewing it. This can be used to add or modify hooks, change the authenticator, or modify other renewal options. It will attempt a dry run in the process to verify that the new options work.
Also creates a `reconfigure` help s... | 2022-07-18T23:48:56Z | Configuration File Update w/o Certificate Issuance
This is really more of a feature suggestion.
Over in the Let's Encrypt Community, we frequently see certbot users trying to make changes to their renewal configurations. Some try to edit the files manually, which often results in disaster. Others try to issue a cert... | See also
- #5828 for modifying renewal parameters without actually renewing
- #5658 for invoking hooks on dry runs
It appears from the history both here and in the Let's Encrypt Community that demand for this functionally has remained strong for years. While I've been advocating for some time now the splitting of ... | [
{
"body": "This is really more of a feature suggestion.\r\n\r\nOver in the Let's Encrypt Community, we frequently see certbot users trying to make changes to their renewal configurations. Some try to edit the files manually, which often results in disaster. Others try to issue a certbot command to make the chan... | 724635bbbd7c31a262f5c7b6cc1e8f43907d26c1 | {
"head_commit": "eb932e1a4174544ef0d7ad1e88b020d3469f59f0",
"head_commit_message": "add flag to run deploy hook despite doing a dry run, and recommend setting that to yes when running reconfigure and modifying the deploy hook",
"patch_to_review": "diff --git a/certbot/certbot/_internal/cli/__init__.py b/certbot/... | [
{
"diff_hunk": "@@ -102,6 +102,11 @@\n \"opts\": 'Options useful for the \"show_account\" subcommand:',\n \"usage\": \"\\n\\n certbot show_account [options]\\n\\n\"\n }),\n+ (\"reconfigure\", {\n+ \"short\": \"Update configuration information for a certificate specified by --cert-... | 3dabf98b0a062c7f0b28cdcdbe4a173659f1b320 | diff --git a/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py b/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py
index 356eaa77406..17010454451 100644
--- a/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py
+++ b/certbot-ci/certbot_integration_tests/certbot_tests/test_main.py... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-5804@20c3d5a | dask/dask | Python | 5,804 | Add support for reductions on empty dataframes | Fixes #5802
- modifications to handle calculation for empty dataframes
- adds test to check result is equivalent to pandas
- [ ] Tests added / passed
- [ ] Passes `black dask` / `flake8 dask`
| 2020-01-19T21:40:41Z | Dataframe operations not working on empty dataframes
```
>>> import dask.dataframe as dd
>>> import pandas as pd
>>> pdf = pd.DataFrame()
>>> ddf = dd.from_pandas(pdf, npartitions=1)
>>> pdf.sum()
Series([], dtype: float64)
>>> ddf.sum().compute()
Traceback (most recent call last):
File "<stdin>", line 1, in... | Thanks for reporting @exemplary-citizen! I'm able to reproduce the `ValueError`. Perhaps this can be fixed by adding a check that `self.columns != 0`. Is this something you're interested in looking into? (no obligation though)
I was going to open a PR in a bit. I was thinking of replacing the above line with ```result.... | [
{
"body": "```\r\n>>> import dask.dataframe as dd\r\n>>> import pandas as pd\r\n>>> pdf = pd.DataFrame()\r\n>>> ddf = dd.from_pandas(pdf, npartitions=1)\r\n>>> pdf.sum()\r\nSeries([], dtype: float64)\r\n>>> ddf.sum().compute()\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n ... | 4ddcc9374533e7765f341f86edfedf5c8d82df8c | {
"head_commit": "20c3d5a8bdaa85b7a6fbff5cc06c6773beb0384d",
"head_commit_message": "add test",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex cccd4307a27..b308de3ebd2 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -1487,7 +1487,7 @@ def _reduction_... | [
{
"diff_hunk": "@@ -1645,7 +1645,9 @@ def count(self, axis=None, split_every=False):\n split_every=split_every,\n )\n if isinstance(self, DataFrame):\n- result.divisions = (min(self.columns), max(self.columns))\n+ result.divisions = (self.col... | ffee14c8c76c3c4111d3479e31d28cb8c63ceee3 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 3bc18dd7587..1a62f34644d 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -1491,7 +1491,7 @@ def _reduction_agg(self, name, axis=None, skipna=True, split_every=False, out=No
split_every=split_every,
)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
certbot__certbot-9226@23a6bb3 | certbot/certbot | Python | 9,226 | Must staple: check for OCSP support | Fixes #3867 as #6014 was closed. | 2022-03-04T22:36:30Z | Error about being unable to staple a must staple cert
If the user requests a cert with `--must-staple`, is asking `certbot` to install it, and the installer doesn't support OCSP-stapling, we should error out before requesting the cert with a helpful error message. | This change should be in `certbot.main.run`. If `config.must_staple` is set, after calling `choose_configurator_plugins` you should check if the installer supports OCSP stapling by calling `supported_enchancements` on it which returns a list of strings and seeing if `ocsp-stapling` is included in list. If it's not, we ... | [
{
"body": "If the user requests a cert with `--must-staple`, is asking `certbot` to install it, and the installer doesn't support OCSP-stapling, we should error out before requesting the cert with a helpful error message.",
"number": 3867,
"title": "Error about being unable to staple a must staple cert"... | f251a13f322e10c530897be31aa07a1199061f10 | {
"head_commit": "23a6bb31b12a39a1ccf1f36aa0cbffffa3170c07",
"head_commit_message": "Must staple: check for OCSP support",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex 29ccd5913c4..76164e6a1ba 100644\n--- a/certbot/CHANGELOG.md\n+++ b/certbot/CHANGELOG.md\n@@ -13,6 +13,10 @@... | [
{
"diff_hunk": "@@ -1394,6 +1394,10 @@ def run(config: configuration.NamespaceConfig,\n except errors.PluginSelectionError as e:\n return str(e)\n \n+ if config.must_staple and installer and \"staple-ocsp\" not in installer.supported_enhancements():\n+ raise errors.NotSupportedError(\"Must... | 8e47e2b8447e62e84739053db6c1e0515d52b3cd | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index 29ccd5913c4..76164e6a1ba 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -13,6 +13,10 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
* Dropped 32 bit support for the Windows beta installer
* Windows beta installer is now... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__httpx-2442@232049f | encode/httpx | Python | 2,442 | Version 0.23.1 | I think we should probably roll a 0.23.1 (or a 0.24.0) release here.
We've got a fairly substantial list of work since the latest release.
There are a couple of minor removals included here, but they're only for old undocumented aspects, so I *think* we're probably okay including them in a minor, but I'm happy to... | 2022-11-17T15:13:46Z | Support httpcore>=0.16.0
Hi,
I have a project that uses `fastapi` and `uvicorn` which demands `h11>=0.8`. Latest version of `fastapi` changed their test suite from `requests` to `httpx`. So I had to add `httpx` to my tests requirements.
Now the problem is, that `httpx` requires `httpcore`, which since version `0.... | [
{
"body": "Hi,\r\n\r\nI have a project that uses `fastapi` and `uvicorn` which demands `h11>=0.8`. Latest version of `fastapi` changed their test suite from `requests` to `httpx`. So I had to add `httpx` to my tests requirements.\r\n\r\nNow the problem is, that `httpx` requires `httpcore`, which since version `... | a2a69e4bf7fc071b3ad237a643b306e5e131337f | {
"head_commit": "232049f9cc8ce6762bddb221ff2da6e112f223ac",
"head_commit_message": "Update CHANGELOG.md\n\nCo-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 6f5e7c4256..9d44b5a0b4 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -... | [
{
"diff_hunk": "@@ -4,6 +4,25 @@ All notable changes to this project will be documented in this file.\n \n The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).\n \n+## 0.23.1\n+\n+### Added\n+\n+* Support for Python 3.11. (#2420)\n+* Allow setting an explicit multipart boundary in `C... | 622aa9e4e642f0bd5d67b1a68de154b433a0a04b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6f5e7c4256..d719b08ef8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,25 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
+## 0.23.1
+
+### Added
+
+* Supp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
certbot__certbot-9208@2584184 | certbot/certbot | Python | 9,208 | Add extra challenge info to `--debug-challenges` | Fixes #6042, I believe.
This PR outputs the URLs (`http-01`) and FQDNs (`dns-01`) used for the challenges and their expected values when Certbot is being run with the `--debug-challenges` option.
This allows users to double/triple-check their challenges before continuing the validation.
Certbot currently does ... | 2022-02-19T12:36:20Z | [Feature Request] Print output on how to validate challenges with --debug-challenges
Can you please add a parameter, that keeps certbot running after the challenge is served in standalone mode?
So that the internal webserver is still running, that would simplify debugging complex network issues.
Currently with "--deb... | This is a great idea, feel free to submit a PR adding this feature! We called our internal webserver "standalone", so the flag should maybe reference that.
I think there may have been a misunderstanding here.
When running with `--debug-challenges` using the standalone plugin, the internal webserver is running when a... | [
{
"body": "Can you please add a parameter, that keeps certbot running after the challenge is served in standalone mode?\r\nSo that the internal webserver is still running, that would simplify debugging complex network issues.\r\nCurrently with \"--debug-challenge --test-cert\", one is asked to press return *bef... | c96420dbe0b9c6950b4fd862cd5a43e565b14834 | {
"head_commit": "2584184819410ce0eedf8a72a126bd3db5162fd3",
"head_commit_message": "Mention feature in --help output",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex 9794e84268f..73d2a5a7cba 100644\n--- a/certbot/CHANGELOG.md\n+++ b/certbot/CHANGELOG.md\n@@ -6,6 +6,9 @@ Certb... | [
{
"diff_hunk": "@@ -87,9 +87,34 @@ def handle_authorizations(self, orderr: messages.OrderResource,\n \n # If debug is on, wait for user input before starting the verification process.\n if config.debug_challenges:\n+ msg = []\n+ if config.ver... | e497e653ed0a5968f08c1b3aeb115b7d2075897c | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index 9794e84268f..73d2a5a7cba 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -6,6 +6,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Added
+* When the `--debug-challenges` option is used in combination with `-v`, Cer... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-5690@218e9ac | dask/dask | Python | 5,690 | Auto-detect categorical columns in ArrowEngine-based read_parquet | Closes #5677
Explicit use of the `categories` keyword is currently required to preserve the `"categorical"` dtype during the read phase of a parquet round-trip. Since the categorical dtype is typically defined within the pandas metadata, there is no reason not to auto-detect the categorical columns. This PR adds ... | 2019-12-09T03:52:04Z | Reading parquet with category dtype
Hi,
We have encountered a problem reading `category` dtype format from `parquet` file.
versions:
dask: 2.8.1
pandas: 0.25.3
pyarrow: 0.15.1
fastparquet:0.3.2
```python
import dask.dataframe as dd
import dask.datasets as ds
import pandas as pd
df = ds.timeseries(... | Thanks for the report. Can you reproduce this issue when writing / reading using pandas or PyArrow directly? Or is it just with Dask?
> 2. when reading the parquet file directly with `pandas engine=pyarrow` the categorical column is preserved.
When using `pandas` there is no problem.
Also we used `PyArrow` ... | [
{
"body": "Hi,\r\nWe have encountered a problem reading `category` dtype format from `parquet` file. \r\nversions:\r\n dask: 2.8.1\r\n pandas: 0.25.3\r\n pyarrow: 0.15.1 \r\n fastparquet:0.3.2\r\n\r\n```python\r\nimport dask.dataframe as dd\r\nimport dask.datasets as ds\r\nimport pandas as pd\r\n\r\ndf = ds.ti... | d0daa5bc7e86677b38794d4f9294fcc386f7b067 | {
"head_commit": "218e9acbb5202e57861fb698254178d3d84e4320",
"head_commit_message": "only auto-populate categories if originally set to None",
"patch_to_review": "diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py\nindex 938c1dfa20e..708a3ab7bdd 100644\n--- a/dask/dataframe/io/pa... | [
{
"diff_hunk": "@@ -1794,13 +1798,13 @@ def test_append_cat_fp(tmpdir, engine):\n pytest.param(\n pd.DataFrame({\"x\": pd.Categorical([\"a\", \"b\", \"a\"])}),\n marks=pytest.mark.xfail(\n- reason=\"https://issues.apache.org/jira/browse/ARROW-3652\"\n+ ... | 2c9b02a5a383776712ca171acd79b7ea7a14edce | diff --git a/dask/dataframe/io/parquet/arrow.py b/dask/dataframe/io/parquet/arrow.py
index 938c1dfa20e..708a3ab7bdd 100644
--- a/dask/dataframe/io/parquet/arrow.py
+++ b/dask/dataframe/io/parquet/arrow.py
@@ -168,6 +168,13 @@ def read_metadata(
storage_name_mapping,
column_index_names,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10664@4a736f4 | dbt-labs/dbt-core | Python | 10,664 | Add custom granularities to YAML spec | Resolves #9265
<!---
Include the number of the issue addressed by this PR above, if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
Add the `user docs` label to this PR if it will need docs changes. An
issue will get open... | 2024-09-05T01:22:17Z | [CT-3485] Semantic Layer custom calendar config support
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
Details unknown.
The spec for this is still in the ideation phase.
### Acceptance criteria
People can specify the attributes necessary for custom calendar support 👀
### I... | @QMalcolm I wrote up our proposed implementation of this feature [here](https://www.notion.so/dbtlabs/Custom-Calendar-bb8e98131c1247b084dba242e05421db#6451e3fe4c994a778ef9554959bdaf8c). You can use this doc to help estimate how much work is needed for this ticket.
Just to add some color on use case for this - could be... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of dbt-core\r\n\r\n### Short description\r\nDetails unknown.\r\n\r\nThe spec for this is still in the ideation phase.\r\n\r\n### Acceptance criteria\r\nPeople can specify the attributes necessary for custom calendar support 👀 \r\n\r\n### Impact to Othe... | c28cb92af51d7f2cb27618aeb43705ba951aa3ef | {
"head_commit": "4a736f478ed764f0a3520a9e66e48f2f547e750c",
"head_commit_message": "Add tests",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20240904-182320.yaml b/.changes/unreleased/Features-20240904-182320.yaml\nnew file mode 100644\nindex 00000000000..7d216ec749a\n--- /dev/null\n+++ b/.chang... | [
{
"diff_hunk": "@@ -207,9 +207,16 @@ class UnparsedNodeUpdate(HasConfig, HasColumnTests, HasColumnAndTestProps, HasYa\n access: Optional[str] = None\n \n \n+@dataclass\n+class UnparsedCustomGranularity(dbtClassMixin):\n+ name: str\n+ column_name: Optional[str] = None\n+\n+",
"line": null,
"ori... | bf5646f2d0435fe54414ea6fd32389ced60f285b | diff --git a/.changes/unreleased/Features-20240904-182320.yaml b/.changes/unreleased/Features-20240904-182320.yaml
new file mode 100644
index 00000000000..7d216ec749a
--- /dev/null
+++ b/.changes/unreleased/Features-20240904-182320.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Add custom_granularities to YAML spec for ti... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dask__dask-5627@c5206b3 | dask/dask | Python | 5,627 | Fix "file_path_0" bug in aggregate_row_groups | Closes #5624
PR #5607 does not check if there is a `"file_path_0"` entry in the `statistics` item before checking it's value. This entry will **not** be present in the case that each partition corresponds to a distinct file (because there are not multiple row-groups per file). The changes here just add a simple ch... | 2019-11-22T22:07:13Z | Support chunksize parameter for read_parquet with a single file
I'd like to be able to read a single parquet file into multiple partitions, determined by the chunksize.
Without chunksize
```python
import pandas as pd
import dask.dataframe as dd
df = pd.DataFrame({"a":range(100000), "b":range(100000)})
df.to_... | cc @rjzamora because of the file_path_0 bug
@beckernick just to be clear the finest granularity that we're able to manage is an individual row group. Parquet doesn't really support reading data at finer granularities. In your case I would ask the question of how did `pandas.DataFrame.to_parquet` choose to save you... | [
{
"body": "I'd like to be able to read a single parquet file into multiple partitions, determined by the chunksize.\r\n\r\nWithout chunksize\r\n```python\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\n\r\ndf = pd.DataFrame({\"a\":range(100000), \"b\":range(100000)})\r\ndf.to_parquet(\"out.parquet\")\... | 1d3dc4b11c14f0ff188f2e3a086cf31181450624 | {
"head_commit": "c5206b36d65cbe6bb648f805bcb3eaa8e0b579a4",
"head_commit_message": "simple fix for #5624",
"patch_to_review": "diff --git a/dask/dataframe/io/parquet/core.py b/dask/dataframe/io/parquet/core.py\nindex 7cee9105cb3..9508e1c8c19 100644\n--- a/dask/dataframe/io/parquet/core.py\n+++ b/dask/dataframe/i... | [
{
"diff_hunk": "@@ -721,7 +721,7 @@ def set_index_columns(meta, index, columns, index_in_columns, auto_index_allowed\n \n \n def aggregate_row_groups(parts, stats, chunksize):\n- if not stats[0][\"file_path_0\"]:\n+ if (\"file_path_0\" not in stats[0]) or (stats[0][\"file_path_0\"] is None):",
"line":... | df3d156edf172cfea3db30a8dde3b8b63c594476 | diff --git a/dask/dataframe/io/parquet/core.py b/dask/dataframe/io/parquet/core.py
index 7cee9105cb3..1032fe30a6a 100644
--- a/dask/dataframe/io/parquet/core.py
+++ b/dask/dataframe/io/parquet/core.py
@@ -721,7 +721,7 @@ def set_index_columns(meta, index, columns, index_in_columns, auto_index_allowed
def aggregate... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
encode__httpx-1570@fca05bd | encode/httpx | Python | 1,570 | Added docs for using client-side ssl certificates | Closes https://github.com/encode/httpx/issues/1224
| 2021-04-13T11:14:55Z | Document client side certificate support
Our Advanced docs don’t currently document the `cert=...` option, for client-side certificate support.
This should probably come at the bottom of the SSL Certificates section.
Requests currently has some good docs for the support there, which we might want to base our own wo... | [
{
"body": "Our Advanced docs don’t currently document the `cert=...` option, for client-side certificate support.\r\nThis should probably come at the bottom of the SSL Certificates section.\r\n\r\nRequests currently has some good docs for the support there, which we might want to base our own wording on.",
... | eb7433bf8edc90f064adcaedfd4897f9c059d8d7 | {
"head_commit": "fca05bd80dc576208898901e6206555a82a58005",
"head_commit_message": "Added docs for using client-side ssl certificates",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex 07ca28a3f7..d868cc408a 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -945,6 +945,32 @@ c... | [
{
"diff_hunk": "@@ -945,6 +945,32 @@ client = httpx.Client(verify=False)\n \n The `client.get(...)` method and other request methods *do not* support changing the SSL settings on a per-request basis. If you need different SSL settings in different cases you should use more that one client instance, with differe... | cf091d613b76e581e0b1f4d78327616589ebc724 | diff --git a/docs/advanced.md b/docs/advanced.md
index 07ca28a3f7..1902b0eeb5 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -945,6 +945,32 @@ client = httpx.Client(verify=False)
The `client.get(...)` method and other request methods *do not* support changing the SSL settings on a per-request basis. If you ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
certbot__certbot-9184@3d09191 | certbot/certbot | Python | 9,184 | If an installer is provided to certonly, restart after cert issuance | Fixes #8912. I wasn't sure if any docs needed updating for this, since it sounded like this change was making `--nginx` and `--apache` behave closer to how they're described in the docs in the `certonly` case. Let me know if that's not the case!
## Pull Request Checklist
- [x] If the change being made is to a [di... | 2022-01-27T20:43:42Z | Should certonly call `restart` at the end if the installer is set? And/or if no installer is set but the authenticator is also an installer?
Based on an ad-hoc user test from a user who was upgrading to an ACMEv2-compatible version of certbot after using an old version entombed in a docker distribution.
Since the us... | > They'll be fine on renewal since `--nginx` does set an installer and so will restart nginx despite having run `certonly` (is this weird and unexpected?)
Personally, I think this is very weird. Not everyone knows the `-a` and `-i` options and it's very much possible to get a certificate for a hostname for which a V... | [
{
"body": "Based on an ad-hoc user test from a user who was upgrading to an ACMEv2-compatible version of certbot after using an old version entombed in a docker distribution.\r\n\r\nSince the user already had their nginx config set up, they only wanted to renew an existing cert, not install it, so they used `ce... | b95deaa7e4980cccb780d116cffa3b6a9c2837cf | {
"head_commit": "3d09191941cae71e9d8e2b2b82de6f79d7f9144d",
"head_commit_message": "fix trailing whitespace",
"patch_to_review": "diff --git a/AUTHORS.md b/AUTHORS.md\nindex d82ddcb7688..377ba5d0d79 100644\n--- a/AUTHORS.md\n+++ b/AUTHORS.md\n@@ -273,6 +273,7 @@ Authors\n * [Wilfried Teiken](https://github.com/w... | [
{
"diff_hunk": "@@ -534,12 +534,21 @@ def _report_next_steps(config: configuration.NamespaceConfig, installer_err: Opt\n \n # If the installation or enhancement raised an error, show advice on trying again\n if installer_err:\n- steps.append(\n- \"The certificate was saved, but could n... | ecd4cead51a247eb3094b049728609a3728880ee | diff --git a/AUTHORS.md b/AUTHORS.md
index d82ddcb7688..377ba5d0d79 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -273,6 +273,7 @@ Authors
* [Wilfried Teiken](https://github.com/wteiken)
* [Willem Fibbe](https://github.com/fibbers)
* [William Budington](https://github.com/Hainish)
+* [Will Greenberg](https://github.co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-5646@6b9f87d | dask/dask | Python | 5,646 | Redo `dask.order.order`. Fix #5584. Use structural info, not key names | Closes #5584
This is a rewrite of `dask.order.order`, but the goals remain the same and many previous lessons were taken into consideration. The new version relies less on the key name by using more metrics and using a different strategy for walking up and down the DAG.
Performance appears to be about the same ... | 2019-11-27T20:22:06Z | Tasks order and scheduling
First of all I apologies because this is more a question than an issue or feature request (though it might turn to one of those in the end).
I am having a really hard time to figure out how to influence task scheduling to get it the way I want it.
Here is my setup. I have two set of tas... | This page may interest you:
https://distributed.dask.org/en/latest/priority.html
In general though if you are submitting a single graph with `dask.compute`
then I would expect Dask to choose a prioritization that minimized memory
footprint. It's heuristics are usually pretty good at this. If you have
task graphs tha... | [
{
"body": "First of all I apologies because this is more a question than an issue or feature request (though it might turn to one of those in the end).\r\n\r\nI am having a really hard time to figure out how to influence task scheduling to get it the way I want it.\r\n\r\nHere is my setup. I have two set of tas... | 5b05368a4f1be47900e47a5ba2dea29171cd5420 | {
"head_commit": "6b9f87d4180c982e37283f91918d0302a218c427",
"head_commit_message": "Clean up: update docstrings, code comments, and some performance tweaks",
"patch_to_review": "diff --git a/dask/order.py b/dask/order.py\nindex 15a8fe52ba1..574a59e571b 100644\n--- a/dask/order.py\n+++ b/dask/order.py\n@@ -74,6 +... | [
{
"diff_hunk": "@@ -168,11 +175,10 @@ def test_avoid_upwards_branching_complex(abcde):\n }\n \n o = order(dsk)\n-\n assert o[(c, 1)] < o[(b, 1)]\n \n \n-@pytest.mark.xfail(reason=\"this case is ambiguous\", strict=False)\n+# @pytest.mark.xfail(reason=\"this case is ambiguous\", strict=False) # this... | 90fafd1f9034cb8d14dc9ecc022cae920e21f684 | diff --git a/dask/order.py b/dask/order.py
index 15a8fe52ba1..8abf24789d8 100644
--- a/dask/order.py
+++ b/dask/order.py
@@ -74,7 +74,8 @@
This relies on the regularity of graph constructors like dask.array to be a
good proxy for ordering. This is usually a good idea and a sane default.
"""
-from .core impo... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10644@7fdc452 | dbt-labs/dbt-core | Python | 10,644 | Add flags from dbt_project.yml to the Project and RuntimeConfig objects | Resolves #10618
### Problem
We need to pass project flags from `dbt_project.yml` into the `BaseAdapter` instantiation to support behavior flags. Without this, users cannot override a behavior flag.
### Solution
- add `flags` as an attribute on `Project`, which then adds it to `RuntimeConfig`
- pull the fla... | 2024-08-29T17:43:52Z | [Behavior Flags] Add project flags to `Project` to be passed into `BaseAdapter`
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
`BaseAdapter` needs access to project flags so that users are able to override default settings on behavior flags. `BaseAdapter` cannot get this information... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of dbt-core\r\n\r\n### Short description\r\n\r\n`BaseAdapter` needs access to project flags so that users are able to override default settings on behavior flags. `BaseAdapter` cannot get this information from project files; all config gets passed in du... | 9b7f4ff842831d8b0975f3ca4a588756ef48d836 | {
"head_commit": "7fdc4520105f3cc792cb09d86b8a613993bce2de",
"head_commit_message": "add the new attribute to the expected repr",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20240829-135320.yaml b/.changes/unreleased/Features-20240829-135320.yaml\nnew file mode 100644\nindex 00000000000..c7f5cf9... | [
{
"diff_hunk": "@@ -1,6 +1,6 @@\n-git+https://github.com/dbt-labs/dbt-adapters.git@main\n-git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter\n-git+https://github.com/dbt-labs/dbt-common.git@main\n+git+https://github.com/dbt-labs/dbt-adapters.git@behavior-flags",
"line": nul... | cc628f206dd9452c56c179f211a4e5e1a91da919 | diff --git a/.changes/unreleased/Features-20240829-135320.yaml b/.changes/unreleased/Features-20240829-135320.yaml
new file mode 100644
index 00000000000..c7f5cf9d8b4
--- /dev/null
+++ b/.changes/unreleased/Features-20240829-135320.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Add support for behavior flags
+time: 2024-0... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
certbot__certbot-9076@01f570d | certbot/certbot | Python | 9,076 | Add Signed Windows Installer Workflow | This PR updates the Windows installer to be signed and trusted in Windows, by modifying the release workflow to integrate the new code signing server.
## Pull Request Checklist
- [x] If the change being made is to a [distributed component](https://certbot.eff.org/docs/contributing.html#code-components-and-layout)... | 2021-11-01T19:33:07Z | Make the Certbot Windows installer trusted by Windows
To do this, we need to securely generate and distribute a new signing key, obtain an authenticode certificate using that key, and then update the release process with instructions/scripts on how to perform this signature. | I think we should do this soonish and I may move this back to this milestone, but the milestone is currently pretty stuffed and I don't think we MUST do this this month so I'm kicking this to the next milestone for now. | [
{
"body": "To do this, we need to securely generate and distribute a new signing key, obtain an authenticode certificate using that key, and then update the release process with instructions/scripts on how to perform this signature.",
"number": 8046,
"title": "Make the Certbot Windows installer trusted ... | dedbdea1d9854761df9ba28d26e368bdd78d72c9 | {
"head_commit": "01f570dbf4082bd1b9e0d3c876b9b1675fc4729d",
"head_commit_message": "Amend Chnagelog and Remove Unneeded Deps",
"patch_to_review": "diff --git a/AUTHORS.md b/AUTHORS.md\nindex d82ddcb7688..962fbd6d9dd 100644\n--- a/AUTHORS.md\n+++ b/AUTHORS.md\n@@ -17,6 +17,7 @@ Authors\n * [Alex Halderman](https:... | [
{
"diff_hunk": "@@ -216,23 +167,19 @@ def promote_snaps(version):\n print(e.stdout)\n raise\n \n-\n def main(args):\n parsed_args = parse_args(args)\n \n- github_access_token_file = parsed_args.githubpat\n- github_access_token = open(github_access_token_file, 'r').read(... | 1903841715e1e70fc70970eee5d143b56ad490e4 | diff --git a/AUTHORS.md b/AUTHORS.md
index d5cb664cbdb..9e92568c547 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -17,6 +17,7 @@ Authors
* [Alex Halderman](https://github.com/jhalderm)
* [Alex Jordan](https://github.com/strugee)
* [Alex Zorin](https://github.com/alexzorin)
+* [Alexis Hancock](https://github.com/zoraco... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} |
dask__dask-5574@5747251 | dask/dask | Python | 5,574 | Implement complete dask.array.tile function | This implements a complete `dask.array.tile` function, based on this https://github.com/dask/dask/issues/2447#issuecomment-500614803.
For example,
```python
>>> from dask import array as da
>>> a = da.asarray([1, 2, 3])
>>> da.tile(a, [2, 1]).compute()
array([[1, 2, 3],
[1, 2, 3]])
```
now works as e... | 2019-11-09T22:53:56Z | New da.tile implementation
Someone privately sent me this da.tile implementation.
```python
def tile(A, reps):
try:
tup = tuple(reps)
except TypeError:
tup = (reps,)
d = len(tup)
if (d < A.ndim):
tup = (1,)*(A.ndim-d) + tup
nnd = len(tup) - A.ndim # Number of ne... | What does this offer over the existing `tile` implementation?
This version using broadcasting (with `broadcast_to`) instead of copying (with `np.tile`) when possible. Presumably this should be significantly faster when tiling dimensions of length 1.
@mrocklin - I wanted to checkout + test this implementation for a PR.
... | [
{
"body": "Someone privately sent me this da.tile implementation. \r\n\r\n```python\r\ndef tile(A, reps):\r\n try:\r\n tup = tuple(reps)\r\n except TypeError:\r\n tup = (reps,)\r\n d = len(tup)\r\n if (d < A.ndim):\r\n tup = (1,)*(A.ndim-d) + tup\r\n nnd = len(tup) - A.ndim ... | 98a1e61fcf9230e3a4dcdf8523e435ed83dfb2c0 | {
"head_commit": "5747251e95fe146551ef31ee52af805ddc455597",
"head_commit_message": "Implement complete tile function",
"patch_to_review": "diff --git a/dask/array/creation.py b/dask/array/creation.py\nindex 0d17b1ae984..1b10a2585b7 100644\n--- a/dask/array/creation.py\n+++ b/dask/array/creation.py\n@@ -796,17 +7... | [
{
"diff_hunk": "@@ -591,13 +597,29 @@ def test_tile_neg_reps(shape, chunks, reps):\n \n \n @pytest.mark.parametrize(\"shape, chunks\", [((10,), (1,)), ((10, 11, 13), (4, 5, 3))])\n-@pytest.mark.parametrize(\"reps\", [[1], [1, 2]])\n-def test_tile_array_reps(shape, chunks, reps):\n+@pytest.mark.parametrize(\"rep... | 6326ab08291f51926091a50b67f5bc5de88420cd | diff --git a/dask/array/creation.py b/dask/array/creation.py
index 0d17b1ae984..1b10a2585b7 100644
--- a/dask/array/creation.py
+++ b/dask/array/creation.py
@@ -796,17 +796,28 @@ def repeat(a, repeats, axis=None):
@derived_from(np)
def tile(A, reps):
- if not isinstance(reps, Integral):
- raise NotImpleme... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dask__dask-5628@7336b1b | dask/dask | Python | 5,628 | Change type of Dask array when meta type changes | Previously da.map_blocks would always return a Dask Array,
even when we mapped a function like pandas.Series.
Now we convert the underlying collection type to a dataframe
Fixes https://github.com/dask/dask/issues/5606
cc @quasiben
| 2019-11-22T23:52:28Z | [FEA] Dask CuPy Array -> Dask CuDF DataFrame
In dask, we can create a dataframe from a dask array like the following:
> dd.from_dask_array(da.random.random(n_rows))
In the above, random numpy data is generated then transformed to a Pandas dataframe. It would be really cool if I could do something similar with Cu... | I suspect that `x.map_blocks(cudf.Series)` will work ok and that you don't need the special `from_dask_array` function.
I need to do a bit more than that -- though not much:
```python
import cudf
import cupy
import dask.array as da
import dask.dataframe as dd
from dask.dataframe.utils import make_meta
rs = d... | [
{
"body": "In dask, we can create a dataframe from a dask array like the following:\r\n\r\n> dd.from_dask_array(da.random.random(n_rows))\r\n\r\nIn the above, random numpy data is generated then transformed to a Pandas dataframe. It would be really cool if I could do something similar with CuPy arrays -> CuDF ... | 9e994bad3be012c4ecb03678a88934c4e66cdebb | {
"head_commit": "7336b1b9e77340ab55c8a562ab1b57c43f87d6a0",
"head_commit_message": "Explicitly support series objects in da.reduction",
"patch_to_review": "diff --git a/dask/array/blockwise.py b/dask/array/blockwise.py\nindex 240baa35ae9..d58c1b7dfe1 100644\n--- a/dask/array/blockwise.py\n+++ b/dask/array/blockw... | [
{
"diff_hunk": "@@ -590,7 +593,13 @@ def map_blocks(\n original_kwargs = kwargs\n \n if dtype is None and meta is None:\n- dtype = apply_infer_dtype(func, args, original_kwargs, \"map_blocks\")\n+ try:\n+ meta = func(\n+ *[getattr(arg, \"_meta\", arg) for arg in a... | 51f00160adcb5c4a6e51264e11bf232a369ff670 | diff --git a/dask/array/blockwise.py b/dask/array/blockwise.py
index a3faffc9920..bcdabd95495 100644
--- a/dask/array/blockwise.py
+++ b/dask/array/blockwise.py
@@ -139,7 +139,7 @@ def blockwise(
if new:
raise ValueError("Unknown dimension", new)
- from .core import Array, unify_chunks, normalize_arg... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-10526@e774234 | dbt-labs/dbt-core | Python | 10,526 | Improve tree traversal of select_children | Resolves #10434
### Problem
DBT core performance was reported as degraded between `1.5` and `1.8` for some users with selectors of the style `tag:mytag+`. For selectors like this and for some large DAGs, the current implementation of getting descendants makes unnecessarily many calls to find children get the edge... | 2024-08-06T00:44:07Z | [Regression] 1.8.2 slower to build than 1.5.9 when tag+ includes many nodes
### Is this a regression in a recent version of dbt-core?
- [X] I believe this is a regression in dbt-core functionality
- [X] I have searched the existing issues, and I could not find an existing issue for this regression
### Current Be... | Thanks @cajubelt! Is this only for the `build` command (i.e. not `run`)?
I suspect this might be due to the large number of tests in your project (per our conversation), and the additional time that dbt spends "linking" the DAG (adding edges between test on upstream model -> downstream models, so that they skip on t... | [
{
"body": "### Is this a regression in a recent version of dbt-core?\r\n\r\n- [X] I believe this is a regression in dbt-core functionality\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this regression\r\n\r\n### Current Behavior\r\n\r\n`dbt build -s tag:my_tag+` takes ... | 47848b8ea8ee2b9ba1a1ced81213bd5cfdcd9182 | {
"head_commit": "e774234be31c2d989a945cdc2e9fa349e90626ad",
"head_commit_message": "remove unused function",
"patch_to_review": "diff --git a/.changes/unreleased/Under the Hood-20240809-130234.yaml b/.changes/unreleased/Under the Hood-20240809-130234.yaml\nnew file mode 100644\nindex 00000000000..964dd2fedf2\n--... | [
{
"diff_hunk": "@@ -59,18 +59,40 @@ def select_childrens_parents(self, selected: Set[UniqueId]) -> Set[UniqueId]:\n def select_children(\n self, selected: Set[UniqueId], max_depth: Optional[int] = None\n ) -> Set[UniqueId]:\n- descendants: Set[UniqueId] = set()\n- for node in selec... | 9b8e8877576064dd1efef2bbbbf3c62f71fa5118 | diff --git a/.changes/unreleased/Under the Hood-20240809-130234.yaml b/.changes/unreleased/Under the Hood-20240809-130234.yaml
new file mode 100644
index 00000000000..964dd2fedf2
--- /dev/null
+++ b/.changes/unreleased/Under the Hood-20240809-130234.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Improve speed of tr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
dbt-labs__dbt-core-10591@014990c | dbt-labs/dbt-core | Python | 10,591 | Fixes dbt retry does not respect --threads | Resolves #10584
### Problem
Solving the problem when retry has been run. dbt does not respect a new --threads value when passed in on a retry.
### Solution
Added the threads in ALLOW_CLI_OVERRIDE_FLAGS to fetch the thread value
### Checklist
- [x] I have read [the contributing guide](https://github.com... | 2024-08-22T07:03:35Z | [Bug] dbt retry does not respect --threads
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
Sometimes concurrency can be the cause of failures (e.g. database OOM, connec... | Thanks for reaching out about this @barberscott !
Was able to reproduce what you described. Agreed that `dbt retry` should respect any CLI flags (including `--threads`!).
<details>
<summary>
### Reprex
</summary>
`models/my_model.sql`
```sql
{% if execute %}
{{ exceptions.raise_compiler_error("Fo... | [
{
"body": "### Is this a new bug in dbt-core?\n\n- [X] I believe this is a new bug in dbt-core\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\n\n### Current Behavior\n\nSometimes concurrency can be the cause of failures (e.g. database OOM, connection timeouts) an... | bba020fcc0c1e2b7a31b7411db90a04e98c6b516 | {
"head_commit": "014990c5487a353027acd9ddcba846f8c6661e51",
"head_commit_message": "Bug Fix: 10584",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240822-122132.yaml b/.changes/unreleased/Fixes-20240822-122132.yaml\nnew file mode 100644\nindex 00000000000..d169520ea99\n--- /dev/null\n+++ b/.change... | [
{
"diff_hunk": "@@ -0,0 +1,57 @@\n+import pytest\n+\n+from dbt.contracts.results import RunStatus, TestStatus\n+from dbt.tests.util import run_dbt, write_file\n+from tests.functional.retry.fixtures import models__thread_model, schema_test_thread_yml\n+\n+\n+class TestCustomThreadRetry:\n+ @pytest.fixture(sco... | e3261ec7d522c64aff082c3481972c86b271ca68 | diff --git a/.changes/unreleased/Fixes-20240822-122132.yaml b/.changes/unreleased/Fixes-20240822-122132.yaml
new file mode 100644
index 00000000000..d169520ea99
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240822-122132.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: dbt retry does not respect --threads
+time: 2024-08-22T1... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
dask__dask-5459@3d93fcf | dask/dask | Python | 5,459 | Fix map(series) for unsorted base series index | Found a bug where tests were not actually catching this, fixes https://github.com/dask/dask/issues/5458
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask`
| 2019-10-03T20:03:49Z | Bug in MapSeries for unsorted index base series
Tests were not actually testing the intended base-series index being unsorted case.
Code to show error in current dask:
```python
import pandas as pd
import dask.dataframe as dd
ser1 = dd.from_pandas(pd.Series([0,1,2,3], index=["a", "c", "b", "d"]), npartitions=1... | [
{
"body": "Tests were not actually testing the intended base-series index being unsorted case.\r\n\r\nCode to show error in current dask:\r\n```python\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\n\r\nser1 = dd.from_pandas(pd.Series([0,1,2,3], index=[\"a\", \"c\", \"b\", \"d\"]), npartitions=1)\r\nse... | fd39ddae003fda95d2dddc77982b5df738fbebcc | {
"head_commit": "3d93fcfdcb8888c9cf3ea8968636981e5100bb3e",
"head_commit_message": "Update tests to actually catch the not sorted case and fix.",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 97da856a617..8e727e400f8 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataf... | [
{
"diff_hunk": "@@ -6098,7 +6098,7 @@ def mapseries(base_chunk, concat_map):\n \n def mapseries_combine(index, concat_result):\n final_series = concat_result.sort_index()\n- final_series.index = index\n+ final_series = pd.Series(index, index=index).map(final_series)",
"line": null,
"original_l... | aece8d5e23e26fc70bd808c9255d08688b64f947 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 97da856a617..4ae58cb6e58 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -6098,7 +6098,7 @@ def mapseries(base_chunk, concat_map):
def mapseries_combine(index, concat_result):
final_series = concat_result.sort_index()
- fi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
encode__httpx-1326@53bd245 | encode/httpx | Python | 1,326 | Support header comparisons with dict or list. | Allows comparison of headers with dict or list:
```
response = httpx.get(...)
assert response.status_code == 200
assert response.text == "Hello, world!"
assert response.headers == {"Content-Length": "13"} # True
assert response.headers == [("Content-Length", "13")] # True
```
Closes #1325 | 2020-09-25T08:43:44Z | Support header comparisons with dict / list.
We should support direct header comparisons with dicts, or with lists of two-tuples.
This would be nice because it would help folks clean up test cases, eg...
```python
response = httpx.get(...)
assert response.status_code == 200
assert response.text == "Hello, world!... | [
{
"body": "We should support direct header comparisons with dicts, or with lists of two-tuples.\r\nThis would be nice because it would help folks clean up test cases, eg...\r\n\r\n```python\r\nresponse = httpx.get(...)\r\nassert response.status_code == 200\r\nassert response.text == \"Hello, world!\"\r\nassert ... | 666cbbdfe8259e7b6363a2eec5df8ab60e7b6003 | {
"head_commit": "53bd245b3ac52ada9fdc322c2093b0b0cf5403b8",
"head_commit_message": "Add check for no headers item",
"patch_to_review": "diff --git a/.vscode/settings.json b/.vscode/settings.json\nnew file mode 100644\nindex 0000000000..8c85075de4\n--- /dev/null\n+++ b/.vscode/settings.json\n@@ -0,0 +1,3 @@\n+{\n... | [
{
"diff_hunk": "@@ -0,0 +1,3 @@\n+{\n+ \"python.pythonPath\": \"/Users/mus/Projects/httpx/venv/bin/python3\"\n+}",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": ".vscode/settings.json",
"start_line": null,
"text": "@user1:\nWe don't really want this file. You ... | ac594264129865a7e32c474d7465d65b6b6e5191 | diff --git a/httpx/_models.py b/httpx/_models.py
index 4fe59d4c50..4ef35ed88a 100644
--- a/httpx/_models.py
+++ b/httpx/_models.py
@@ -724,9 +724,11 @@ def __len__(self) -> int:
return len(self._list)
def __eq__(self, other: typing.Any) -> bool:
- if not isinstance(other, Headers):
+ try:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dask__dask-5436@a0c574a | dask/dask | Python | 5,436 | Option to not check meta while using from_delayed | closes #5435 | 2019-09-26T17:32:30Z | ValueError: Metadata mismatch found in `from_delayed`.
It seems that merging multiple delayed dataframes does not work when the dataframes are series of category type.
It seems that the error is coming from the equality of categorical dtypes includes the categories used, which makes this approach to concatenation no... | Thank you for the excellent issue @CJ-Wright .
Looking into the code a bit it looks like this strictness in `check_meta` was intentional at some point:
https://github.com/dask/dask/blob/8001ee2e258f3f27d40e78990c5b98d44edc138e/dask/dataframe/utils.py#L593-L602
And it looks like we enforce the metadata check ... | [
{
"body": "It seems that merging multiple delayed dataframes does not work when the dataframes are series of category type.\r\n\r\nIt seems that the error is coming from the equality of categorical dtypes includes the categories used, which makes this approach to concatenation not work. This came up in the cont... | 8001ee2e258f3f27d40e78990c5b98d44edc138e | {
"head_commit": "a0c574a7192f5cddbffd2379c49ff7a08c76ff18",
"head_commit_message": "add test",
"patch_to_review": "diff --git a/dask/dataframe/io/io.py b/dask/dataframe/io/io.py\nindex d1c47f96455..675d9c089ab 100644\n--- a/dask/dataframe/io/io.py\n+++ b/dask/dataframe/io/io.py\n@@ -524,7 +524,8 @@ def to_record... | [
{
"diff_hunk": "@@ -562,12 +566,20 @@ def from_delayed(dfs, meta=None, divisions=None, prefix=\"from-delayed\"):\n \n name = prefix + \"-\" + tokenize(*dfs)\n dsk = merge(df.dask for df in dfs)\n- dsk.update(\n- {\n- (name, i): (check_meta, df.key, meta, \"from_delayed\")\n- ... | 122f7e90c10c526e66bc2086bf2a5cb63645ba98 | diff --git a/dask/dataframe/io/io.py b/dask/dataframe/io/io.py
index d1c47f96455..95c64524f1f 100644
--- a/dask/dataframe/io/io.py
+++ b/dask/dataframe/io/io.py
@@ -524,7 +524,9 @@ def to_records(df):
@insert_meta_param_description
-def from_delayed(dfs, meta=None, divisions=None, prefix="from-delayed"):
+def from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10371@f49d790 | dbt-labs/dbt-core | Python | 10,371 | Incremental models with a contract don't need their columns modified | resolves #10362
### Problem
Incremental models with existing tables had their columns updated by "expand_target_column_types", but this is unnecessary when models have a contract.
### Solution
Do not call "expand_target_column_types" when an incremental model has an enforced contract.
### Checklist
... | 2024-06-26T20:57:31Z | [Bug] Incorrect column data type with incremental contracted model and varchar data_type
### Current Behavior
A temporary table is created for incremental models when the table already exists. When this temporary table is created and one of the column contracted data_types is "character varying(1)" (size is not sign... | I was able to reproduce this for both `varchar(1)` and `character varying(1)`. In both cases running dbt-postgres 1.6.16 the following occurs on the incremental run.
Both models are the same SQL
```
with source_data as (
select 1 as id, 'a' as vchar
)
select *
from source_data
```
yml
```
mod... | [
{
"body": "### Current Behavior\r\n\r\nA temporary table is created for incremental models when the table already exists. When this temporary table is created and one of the column contracted data_types is \"character varying(1)\" (size is not significant) the string size is lost in the creation of the temporar... | 25c2042dc976e0a4452be40e46cc238f5a2484bc | {
"head_commit": "f49d790c0ef7111921e26dc8afe8f2cae62b3413",
"head_commit_message": "Changie",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240728-221421.yaml b/.changes/unreleased/Fixes-20240728-221421.yaml\nnew file mode 100644\nindex 00000000000..420414e3f52\n--- /dev/null\n+++ b/.changes/unrel... | [
{
"diff_hunk": "@@ -1,4 +1,4 @@\n-git+https://github.com/dbt-labs/dbt-adapters.git@main\n+git+https://github.com/dbt-labs/dbt-adapters.git@incremental_contract_varchar",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "dev-requirements.txt",
"start_line": null,
"te... | abd22747f59c3f940ec575c5042d0999300eb682 | diff --git a/.changes/unreleased/Fixes-20240728-221421.yaml b/.changes/unreleased/Fixes-20240728-221421.yaml
new file mode 100644
index 00000000000..420414e3f52
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240728-221421.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Do not update varchar column definitions if a contract e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__httpx-1277@7c40709 | encode/httpx | Python | 1,277 | Support for `chunk_size` | Closes https://github.com/encode/httpx/issues/394
- [x] Add `iter_raw(chunk_size: int=None)`
- [x] Add `iter_bytes(chunk_size: int=None)`
- [x] Add `iter_text(chunk_size: int=None)`
First bit of work towards `chunk_size` on the `response.iter_[raw|bytes|text]` methods,
using a decoder class in line with the ot... | 2020-09-10T15:08:14Z | Allow setting `chunk_size` for `Response.iter_bytes()` etc...
Requests allowed setting chunk_size within `.iter_content()` which is currently not an option for our alternatives `.stream()` and `.stream_text()`.
For `.stream_text()` we should go the extra step and fix the issue that users sometimes run into when usin... | I seem to remeber this playing into some primitives around streaming bytes vs text that we never ended up digging into?
A good first pass onto this would be to change the decoder interface slightly, so that instead of eg. yeilding a byte chunk, they yield a *list* of byte chunks.
On the first refactoring pass, we do... | [
{
"body": "Requests allowed setting chunk_size within `.iter_content()` which is currently not an option for our alternatives `.stream()` and `.stream_text()`.\r\n\r\nFor `.stream_text()` we should go the extra step and fix the issue that users sometimes run into when using this feature and use chunk-size for m... | c4d2e6fa2872e9f035e5369d25e94aec8886b18e | {
"head_commit": "7c40709ee819407d95755190bc7ca1858622e823",
"head_commit_message": "Add TextChunker",
"patch_to_review": "diff --git a/httpx/_decoders.py b/httpx/_decoders.py\nindex 40c6da9fc0..c5b3764b88 100644\n--- a/httpx/_decoders.py\n+++ b/httpx/_decoders.py\n@@ -4,6 +4,7 @@\n See: https://developer.mozilla... | [
{
"diff_hunk": "@@ -912,19 +913,28 @@ def read(self) -> bytes:\n self._content = b\"\".join(self.iter_bytes())\n return self._content\n \n- def iter_bytes(self) -> typing.Iterator[bytes]:\n+ def iter_bytes(self, chunk_size: int = None) -> typing.Iterator[bytes]:",
"line": 1167,
... | d61e384305096026e26920c80919a222e9c16b26 | diff --git a/httpx/_decoders.py b/httpx/_decoders.py
index bac5f9c86f..8ef0157e6f 100644
--- a/httpx/_decoders.py
+++ b/httpx/_decoders.py
@@ -4,6 +4,7 @@
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
"""
import codecs
+import io
import typing
import zlib
@@ -155,6 +156,84 @@ de... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
encode__httpx-1240@9001c50 | encode/httpx | Python | 1,240 | Handle multiple auth headers correctly | Closes #1234 by correctly treating WWW-Authenticate headers as possibly occurring multiple times, and only dealing with “Digest” headers, and just ignoring other types of authentications. | 2020-08-31T15:40:13Z | Auth fails for responses that include multiple WWW-Authenticate headers.
### Checklist
httpx==0.11.1
### Describe the bug
I use httpx request camera mjpeg,The camera response two WWW-Authenticate headers,I used the right username and password,but It response 401. When I user chrome, everything is ok, I doubt the... | Hello!
* You're using a rather old-ish HTTPX version (0.11.1). What does this look like on the latest HTTPX release (0.14.2)?
* Can you share a minimal example that reproduces the issue on your side?
* Are there any details about the server/device you're requesting worth sharing? (Make and model, server documentat... | [
{
"body": "### Checklist\r\n\r\nhttpx==0.11.1\r\n\r\n### Describe the bug\r\nI use httpx request camera mjpeg,The camera response two WWW-Authenticate headers,I used the right username and password,but It response 401. When I user chrome, everything is ok, I doubt the httpx.DigestAuth may have bug when handle d... | fa7661b306037b36b97c3cb5ce007cabc5ad2dab | {
"head_commit": "9001c50143e609095611602534cc38dbfd848420",
"head_commit_message": "Handle multiple auth headers correctly",
"patch_to_review": "diff --git a/httpx/_auth.py b/httpx/_auth.py\nindex 571584593b..eb110dea3a 100644\n--- a/httpx/_auth.py\n+++ b/httpx/_auth.py\n@@ -112,28 +112,34 @@ def auth_flow(self,... | [
{
"diff_hunk": "@@ -354,6 +354,21 @@ async def test_digest_auth_returns_no_auth_if_no_digest_header_in_response() ->\n assert len(response.history) == 0\n \n \n+def test_digest_auth_returns_no_auth_if_alternate_auth_scheme() -> None:\n+ url = \"https://example.org/\"\n+ auth = DigestAuth(username=\"to... | 2e9ca699f621f9c5d6da625f192a0c1ec0d9c3d1 | diff --git a/httpx/_auth.py b/httpx/_auth.py
index 571584593b..eb110dea3a 100644
--- a/httpx/_auth.py
+++ b/httpx/_auth.py
@@ -112,28 +112,34 @@ def auth_flow(self, request: Request) -> typing.Generator[Request, Response, Non
response = yield request
if response.status_code != 401 or "www-authentica... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__httpx-1182@402681c | encode/httpx | Python | 1,182 | Drop urllib3 in favor of public gist | Fixes #1143
This PR removes the `URLLib3Transport` from HTTPX, and moves it to a public gist that we're now pointing to in the "Custom transports" docs.
Also adds a small additional section to the Requests compatibility guide, so that people know this option exists if they're migrating from Requests to HTTPX. | 2020-08-15T19:45:09Z | Move URLLib3Transport out of core and into a stand-alone package.
We should remove `URLLib3Transport` from `httpx`, and make it a stand-alone package, with a simple README documenting how to install and use it, with `transport=...`.
In fact, we *could* even just drop it from core, and *aim* at delivering a third par... | I think we could pretty much get away with just a GitHub gist implementation, that we can then point to in the docs as an example of a custom transport, using URLLib3.
Things to do here would be to make sure everything in the implementation is using public API, so...
* Drop `verify`, `cert`, `trust_env`, and inst... | [
{
"body": "We should remove `URLLib3Transport` from `httpx`, and make it a stand-alone package, with a simple README documenting how to install and use it, with `transport=...`.\r\n\r\nIn fact, we *could* even just drop it from core, and *aim* at delivering a third party package but *not* treat having to do so ... | 642aabdac093cf9798f4881cbdd8b39bd3398bb5 | {
"head_commit": "402681c611964f95cf25d26740e210c9378cc3e8",
"head_commit_message": "Merge branch 'master' into fm/urllib3-gist",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex e43ecca6df..b2a07df371 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -809,6 +809,8 @@ HTTPX's `... | [
{
"diff_hunk": "@@ -83,3 +83,11 @@ Besides, `httpx.Request()` does not support the `auth`, `timeout`, `allow_redire\n ## Mocking\n \n If you need to mock HTTPX the same way that test utilities like `responses` and `requests-mock` does for `requests`, see [RESPX](https://github.com/lundberg/respx).\n+\n+## Netwo... | da4a456cf1165562c4006e48a016cce07823489a | diff --git a/README.md b/README.md
index 3072daf79e..f8fe0f9b60 100644
--- a/README.md
+++ b/README.md
@@ -122,7 +122,6 @@ The HTTPX project relies on these excellent libraries:
* `rfc3986` - URL parsing & normalization.
* `idna` - Internationalized domain name support.
* `sniffio` - Async library autodetection.
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dask__dask-5163@5473bd1 | dask/dask | Python | 5,163 | Update setup/python docs for async/await API | Fixes #2895
cc @jcrist for review (I think that this is in line with what you asked for a while ago) | 2019-07-27T17:36:41Z | Slow performance adding to a large Dask-graph
I was replacing a delayed object (`A` in the example), with a Dask array of 1000 chunks (`B` in the example). This increased the bottom of the Dask-graph with a factor of 1000.
The result was that the time for constructing the graph became unpleasantly long.
Testing some ... | Have you tried with `cytoolz` installed?
`cytoolz` version `0.8.2` was already installed.
Could you please include all the dependencies from the environment used? If using `conda`, can just run `conda env export`. Alternatively `pip freeze` would work if not using `conda`.
I'm not sure how this helps, but here is the o... | [
{
"body": "I was replacing a delayed object (`A` in the example), with a Dask array of 1000 chunks (`B` in the example). This increased the bottom of the Dask-graph with a factor of 1000.\r\nThe result was that the time for constructing the graph became unpleasantly long.\r\nTesting some more, the speed of addi... | 5f335e9c383d54bc8f376a8cb153171e1f905e65 | {
"head_commit": "5473bd10ab27c48ec0548ced10ffb0ce4fe3e8bf",
"head_commit_message": "Update setup/python docs for async/await API\n\nFixes #2895",
"patch_to_review": "diff --git a/docs/source/futures.rst b/docs/source/futures.rst\nindex e12118c07c9..aca0e1cf079 100644\n--- a/docs/source/futures.rst\n+++ b/docs/so... | [
{
"diff_hunk": "@@ -1,62 +1,207 @@\n Python API (advanced)\n =====================\n \n-In some rare cases, experts may want to create ``Scheduler`` and ``Worker``\n-objects explicitly in Python manually. This is often necessary when making\n+.. currentmodule:: distributed\n+\n+In some rare cases, experts may ... | 706517fca0626ff9c1e42df40a6574d1a9c7044d | diff --git a/docs/source/futures.rst b/docs/source/futures.rst
index e12118c07c9..aca0e1cf079 100644
--- a/docs/source/futures.rst
+++ b/docs/source/futures.rst
@@ -257,7 +257,7 @@ Or collect all futures in batches that had arrived since the last iteration:
for future, result in batch:
...
-Addition... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
dask__dask-5096@37bcd79 | dask/dask | Python | 5,096 | fix groupby.std() with integer colum names | - [X] Tests added / passed
- [ ] Passes `black dask` / `flake8 dask`
Fixes #3560
I tried using the tuples solution proposed in https://github.com/dask/dask/issues/3560#issuecomment-395842847 but pandas wasn't happy.
Note that the solution in this PR might cause collisions if we have a column 0 and another col... | 2019-07-13T21:06:24Z | Standard Deviation error after GroupBy, Dask DataFrame
**Description**
I bumped into a case where, after GroupBy's of two Dask DataFrames, I can calculate the *sum* and *mean* but not *std*.
**Steps to reproduce**
```py
import numpy as np
import dask.array as da
import dask.dataframe as dd
# Data
data_array... | Thanks for reporting this issue and providing an example to reproduce the problem @JukkaKeisala! It looks like the issue might be arising here
https://github.com/dask/dask/blob/e1c48e0c970aeb81ffeb58791db2ca3ce76fa846/dask/dataframe/groupby.py#L243-L244
where `c + '-x2'` and `c + '-count'` are raising the `TypeE... | [
{
"body": "**Description**\r\nI bumped into a case where, after GroupBy's of two Dask DataFrames, I can calculate the *sum* and *mean* but not *std*.\r\n\r\n**Steps to reproduce**\r\n```py\r\nimport numpy as np\r\nimport dask.array as da\r\nimport dask.dataframe as dd\r\n\r\n# Data\r\ndata_array = da.from_array... | c792364d1528c9c688a66c4d116e5f3b49776bb8 | {
"head_commit": "37bcd79a86fe344f5b019ddebd8081a432ff355e",
"head_commit_message": "used tuples",
"patch_to_review": "diff --git a/dask/dataframe/groupby.py b/dask/dataframe/groupby.py\nindex b0c9e42ac93..894cd6bba08 100644\n--- a/dask/dataframe/groupby.py\n+++ b/dask/dataframe/groupby.py\n@@ -284,11 +284,11 @@ ... | [
{
"diff_hunk": "@@ -302,8 +302,9 @@ def _var_agg(g, levels, ddof):\n g = g.groupby(level=levels, sort=False).sum()\n nc = len(g.columns)\n x = g[g.columns[: nc // 3]]\n- x2 = g[g.columns[nc // 3 : 2 * nc // 3]].rename(columns=lambda c: c[:-3])\n- n = g[g.columns[-nc // 3 :]].rename(columns=lam... | 99800e6c810058b12dd08954f79793a4817f7656 | diff --git a/dask/dataframe/groupby.py b/dask/dataframe/groupby.py
index b0c9e42ac93..eaa4c4e812e 100644
--- a/dask/dataframe/groupby.py
+++ b/dask/dataframe/groupby.py
@@ -284,11 +284,11 @@ def _var_chunk(df, *index):
g = _groupby_raise_unaligned(df, by=index)
x = g.sum()
- n = g[x.columns].count().rena... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-5066@131ae6b | dask/dask | Python | 5,066 | Fix pd.MultiIndex size estimate | Fixes #5002.
Couple of new values with the above test setup:
Actual 3.4e6, old dask 308e6, new dask 3.34e6 (100 x 10000)
Actual 75e6, old dask 1525e6, new dask 57e6 (5 x 1000000)
Still not perfect but definitely an improvement :)
- [x] Tests added / passed
- [x] Passes `black dask` / `flake8 dask` | 2019-07-04T01:45:23Z | dask.sizeof very wrong for MultiIndex
Noticed in `distributed` diagnostics page when scattering large multi-index series:
```
import sys
import pandas as pd
from uuid import uuid4
def object_size(x): # from dask.sizeof.register_pandas
if not len(x):
return 0
sample = np.random.choice(x, size=... | The `object_size` there looks a little strange for MultiIndex. That forces a conversion to an ndarray of objects, which likely isn't what we want.
@mrocklin do you recall the reason for not just using `index.memory_usage(deep=True)`?
`memory_usage` is very slow when the object is large, so the subsampling approach ... | [
{
"body": "Noticed in `distributed` diagnostics page when scattering large multi-index series:\r\n```\r\nimport sys\r\nimport pandas as pd\r\nfrom uuid import uuid4\r\n\r\ndef object_size(x): # from dask.sizeof.register_pandas\r\n if not len(x):\r\n return 0\r\n sample = np.random.choice(x, size=2... | 188930f24ce317ffba643ab669a22136226cb98e | {
"head_commit": "131ae6bb7d9a6a6dbc73313b0bc6530555f72a34",
"head_commit_message": "Fix pd.MultiIndex size estimate",
"patch_to_review": "diff --git a/dask/sizeof.py b/dask/sizeof.py\nindex 9b72b00bbf8..46a7a4ff171 100644\n--- a/dask/sizeof.py\n+++ b/dask/sizeof.py\n@@ -84,6 +84,13 @@ def sizeof_pandas_index(i):... | [
{
"diff_hunk": "@@ -37,10 +37,12 @@ def test_pandas():\n assert sizeof(df.x) >= sizeof(df.index)\n assert sizeof(df.y) >= 100 * 3\n assert sizeof(df.index) >= 20\n+ assert sizeof(df.set_index(['x', 'y'].index)) < 1800",
"line": null,
"original_line": 40,
"original_start_line": null,
... | 6eaef96233493a54674a337cd25280f2537445ca | diff --git a/dask/sizeof.py b/dask/sizeof.py
index 9b72b00bbf8..46a7a4ff171 100644
--- a/dask/sizeof.py
+++ b/dask/sizeof.py
@@ -84,6 +84,13 @@ def sizeof_pandas_index(i):
p += object_size(i)
return int(p) + 1000
+ @sizeof.register(pd.MultiIndex)
+ def sizeof_pandas_multiindex(i):
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__httpx-1098@70765e6 | encode/httpx | Python | 1,098 | URL matching | This pull request refactors our URL matching for proxy lookups.
It adds a utility class `URLMatcher` that handles matching against the [proxy keys that we currently support](https://www.python-httpx.org/advanced/#http-proxying).
It's best explained through some examples...
```python
>>> from httpx._utils impo... | 2020-07-29T12:03:05Z | Don't call `should_not_be_proxied` on each request
Currently we're calling `should_not_be_proxied` on each request, which is problematic for two reasons...
* It's ignoring the `trust_env`, and relying on an environment variable unilaterally.
* It's preforming an extra chunk of work on each request that we'd rather ... | @tomchristie
Do I understand correctly, that you told about working with requests on session level?
Something a-la introducing url->proxy transport cache on the Session level
Also there is a question about "trust_env". Do you mean this piece of code: [httpx/_utils.py#L267](https://github.com/encode/httpx/blob... | [
{
"body": "Currently we're calling `should_not_be_proxied` on each request, which is problematic for two reasons...\r\n\r\n* It's ignoring the `trust_env`, and relying on an environment variable unilaterally.\r\n* It's preforming an extra chunk of work on each request that we'd rather not do.",
"number": 10... | 9728d8960f1b10502365cbdb414c16442fca7d05 | {
"head_commit": "70765e6b3efd6198224fe0cd10e9e6c6d50beca4",
"head_commit_message": "Merge branch 'master' into url-matching",
"patch_to_review": "diff --git a/httpx/_client.py b/httpx/_client.py\nindex 518531986d..dca8718fcf 100644\n--- a/httpx/_client.py\n+++ b/httpx/_client.py\n@@ -44,6 +44,7 @@\n )\n from ._u... | [
{
"diff_hunk": "@@ -429,5 +429,89 @@ def elapsed(self) -> timedelta:\n return timedelta(seconds=self.end - self.start)\n \n \n+class URLMatcher:\n+ \"\"\"\n+ A utility class currently used for making lookups against proxy keys...\n+\n+ # Wildcard matching...\n+ >>> pattern = URLMatcher(\"all... | a0e58d4c8ea5218b40c6aed222d7e1273e2972b2 | diff --git a/httpx/_client.py b/httpx/_client.py
index 518531986d..dca8718fcf 100644
--- a/httpx/_client.py
+++ b/httpx/_client.py
@@ -44,6 +44,7 @@
)
from ._utils import (
NetRCInfo,
+ URLMatcher,
enforce_http_url,
get_environment_proxies,
get_logger,
@@ -471,8 +472,8 @@ def __init__(
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.