instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
encode__httpx-1103@2008ce7 | encode/httpx | Python | 1,103 | Cleaner no proxy support | Builds on #1099, and #1098.
Closes #1062.
Refactors our NO_PROXY logic, so that instead of calling `should_not_be_proxied` we instead setup the `proxies` infomation in such a way that it has any exclusions within it, eg...
```
# The following environment...
# ALL_PROXY=http://localhost:1234
# NO_PROXY=examp... | 2020-07-30T14:23:23Z | Don't call `should_not_be_proxied` on each request
Currently we're calling `should_not_be_proxied` on each request, which is problematic for two reasons...
* It's ignoring the `trust_env`, and relying on an environment variable unilaterally.
* It's preforming an extra chunk of work on each request that we'd rather ... | @tomchristie
Do I understand correctly, that you told about working with requests on session level?
Something a-la introducing url->proxy transport cache on the Session level
Also there is a question about "trust_env". Do you mean this piece of code: [httpx/_utils.py#L267](https://github.com/encode/httpx/blob... | [
{
"body": "Currently we're calling `should_not_be_proxied` on each request, which is problematic for two reasons...\r\n\r\n* It's ignoring the `trust_env`, and relying on an environment variable unilaterally.\r\n* It's preforming an extra chunk of work on each request that we'd rather not do.",
"number": 10... | f67e925f72166ac89c4ff430540173b5910ec315 | {
"head_commit": "2008ce79ee30251097dcf5727bb6d53ae1795008",
"head_commit_message": "Tweak comment on domain wildcards",
"patch_to_review": "diff --git a/httpx/_client.py b/httpx/_client.py\nindex 4a7fc030a0..246defcba1 100644\n--- a/httpx/_client.py\n+++ b/httpx/_client.py\n@@ -49,7 +49,6 @@\n get_environmen... | [
{
"diff_hunk": "@@ -228,75 +227,85 @@ def test_obfuscate_sensitive_headers(headers, output):\n [\n (\n \"http://127.0.0.1\",\n- {\"NO_PROXY\": \"\"},\n+ {\"ALL_PROXY\": \"http://localhost:123\", \"NO_PROXY\": \"\"},\n False,\n ), # everything pr... | 34f92881feef27ebae7c92a8479613d05f1aeabf | diff --git a/httpx/_client.py b/httpx/_client.py
index bfc4e623b2..4110fd7d96 100644
--- a/httpx/_client.py
+++ b/httpx/_client.py
@@ -49,7 +49,6 @@
get_environment_proxies,
get_logger,
same_origin,
- should_not_be_proxied,
warn_deprecated,
)
@@ -95,7 +94,7 @@ def _get_proxy_map(
if p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
encode__httpx-1032@f36984f | encode/httpx | Python | 1,032 | Add support for multiple files per POST field | fixes #777
inspired by great work done on #891
separates files and data as per @florimondmanca suggesiton in gitter
I commented below a mypy error I ignored because I'm clueless on how to deal with it to be honest | 2020-06-24T14:24:35Z | Support for multiple files per POST field
```
async def http_upload():
async with httpx.AsyncClient(verify=False) as client:
data_path = os.path.join(PARENT_PATH, 'data_file/blob/data')
index_path = os.path.join(PARENT_PATH, 'data_file/blob/index')
files = {
"upload_file": ... | You should read the manual https://www.python-httpx.org/advanced/#multipart-file-encoding
Hi, not sure was the problem was exactly, but going to close this as resolved for now. If there's anything unclear/missing in the docs relative to your problem, feel free to ping back here! Thanks.
It seems to me the OP's problem ... | [
{
"body": "```\r\nasync def http_upload():\r\n async with httpx.AsyncClient(verify=False) as client:\r\n data_path = os.path.join(PARENT_PATH, 'data_file/blob/data')\r\n index_path = os.path.join(PARENT_PATH, 'data_file/blob/index')\r\n files = {\r\n \"upload_file\": [\r\n ... | 0f7d644b8dba432c5eec08157947a4e551996fa1 | {
"head_commit": "f36984f9e3fa9c20a1db8481eb0b660043fd173b",
"head_commit_message": "Fixed some docs typos",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex 76321dd1b2..40055611bd 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -464,6 +464,16 @@ MIME header field.\n It i... | [
{
"diff_hunk": "@@ -464,6 +464,16 @@ MIME header field.\n It is safe to upload large files this way. File uploads are streaming by default, meaning that only one chunk will be loaded into memory at a time.\n \n Non-file data fields can be included in the multipart form using by passing them to `data=...`.... | d9278b0c2daea86d433816df7a364438ab38de2b | diff --git a/docs/advanced.md b/docs/advanced.md
index 76321dd1b2..9d416e6f01 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -464,6 +464,16 @@ MIME header field.
It is safe to upload large files this way. File uploads are streaming by default, meaning that only one chunk will be loaded into memory at a ti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-4945@35174a1 | dask/dask | Python | 4,945 | Preserve NumPy condition in da.asarray to preserve output shape | This PR resolves #4940 by allowing the `condition` argument to be a numpy array and leaving it as such.
- [ ] Tests added / passed
- [ ] Passes `flake8 dask`
| 2019-06-17T08:56:12Z | Mask selection vs compress() - inconsistent shape
Using dask 1.2.2. In the following example:
```
In [16]: x = da.from_array(np.arange(5), chunks=2)
In [17]: x ... | Maybe the difference is because ``compress()`` calls ``asarray(condition)`` [here](https://github.com/dask/dask/blob/d8ff4c4d155d51cf275776c1ec8ef27c16d43f17/dask/array/routines.py#L1005). I.e., the ``condition`` array is coerced to a dask array, although it doesn't really need to be if it is a numpy array.
Perhaps ... | [
{
"body": "Using dask 1.2.2. In the following example:\r\n\r\n```\r\nIn [16]: x = da.from_array(np.arange(5), chunks=2) \r\n\r\nIn [17]: x ... | 76f55fdeedaf79877e7274323e2fb193008fda5b | {
"head_commit": "35174a144fa10762613fb5bc9891e4021a39dfec",
"head_commit_message": "allow condition to be ndarray and leave it as such",
"patch_to_review": "diff --git a/dask/array/routines.py b/dask/array/routines.py\nindex 548700bb6f6..ab3201ddfd2 100644\n--- a/dask/array/routines.py\n+++ b/dask/array/routines... | [
{
"diff_hunk": "@@ -1002,7 +1002,12 @@ def squeeze(a, axis=None):\n \n @derived_from(np)\n def compress(condition, a, axis=None):\n- condition = asarray(condition).astype(bool)\n+\n+ if not isinstance(condition, np.ndarray):",
"line": null,
"original_line": 1006,
"original_start_line": null,
... | 850c3311872ad08a7b331f81184b5a6a77e70635 | diff --git a/dask/array/routines.py b/dask/array/routines.py
index 548700bb6f6..4612e938faa 100644
--- a/dask/array/routines.py
+++ b/dask/array/routines.py
@@ -14,7 +14,7 @@
from ..core import flatten
from ..base import tokenize
from ..highlevelgraph import HighLevelGraph
-from ..utils import funcname, derived_from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-4935@229a988 | dask/dask | Python | 4,935 | 4809 fix extra cr | - [x] Tests added / passed
- [x] Passes `flake8 dask`
Fixes #4809.
Includes the following new test, which demonstrates the issue, and did, indeed, fail prior to the fix here.
```python
def test_to_csv_line_ending():
df = pd.DataFrame({'x': [0]})
ddf = dd.from_pandas(df, npartitions=1)
expected... | 2019-06-13T11:35:10Z | dask DataFrame.to_csv writes extra carriage return on Windows
When using `dask.dataframe.DataFrame.to_csv`, I noticed that lines end with `\r\r\n`, as opposed to simply `\r\n`. I'm guessing this is a Windows issue, although I haven't had the opportunity to test on another system.
The following example shows the byte... | What version of pandas do you have? This changed recently, and there were some (unavoidable) issues.
I'm not sure, but https://github.com/pandas-dev/pandas/issues/25048 may be relevant.
My pandas version is 0.24.0
I don't see a direct connection between this and https://github.com/pandas-dev/pandas/issues/25048, as it ... | [
{
"body": "When using `dask.dataframe.DataFrame.to_csv`, I noticed that lines end with `\\r\\r\\n`, as opposed to simply `\\r\\n`. I'm guessing this is a Windows issue, although I haven't had the opportunity to test on another system.\r\n\r\nThe following example shows the bytes produced when using pandas and d... | 6e8c1b76feb12337574f40032dbd3818626b8e28 | {
"head_commit": "229a98881dfe4e0e686ec186ea0ec56ebe95d9e7",
"head_commit_message": "modfied open_files/OpenFile to accept a newline parameter, similar to io.TextIOWrapper or the builtin open on py3. Pass newline='' to open_files when preparing to write csv files.\n\nFixed #4809",
"patch_to_review": "diff --git a... | [
{
"diff_hunk": "@@ -162,15 +162,18 @@ class OpenFile(object):\n The encoding to use if opened in text mode.\n errors : str or None, optional\n How to handle encoding errors if opened in text mode.\n+ newline : None, '', '\\n', '\\r', or '\\r\\n'.",
"line": null,
"original_line": 1... | 85af811055c15d3bded54d18793a87a8377fe241 | diff --git a/dask/bytes/core.py b/dask/bytes/core.py
index 7cc4840fa96..b7e31a15981 100644
--- a/dask/bytes/core.py
+++ b/dask/bytes/core.py
@@ -162,15 +162,18 @@ class OpenFile(object):
The encoding to use if opened in text mode.
errors : str or None, optional
How to handle encoding errors if op... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
encode__httpx-963@82faccb | encode/httpx | Python | 963 | Transport API | Closes https://github.com/encode/httpx/issues/768
~I did some `dispatch > transport` renaming but did not rename the `_dispatch` package and the `*Dispatch` classes in it. I considered renaming the package to `_transports` and all classes to `*Transport` with `*Dispatch` aliases but thought it might be better to che... | 2020-05-20T14:38:59Z | Transport API
**What is the dispatcher API, and why is it useful?...**
The dispatcher is the part of the system that's responsible for actually sending the request and returning a response to the client. Having an API to override the dispatcher used by the client allows you to take complete control over that process... | I think it's probably a good time for us to start pushing ahead with this, and ensuring that we've got a nice clean interface split between everything in the dispatcher implementation vs. everything at the client level.
Here's a plan towards how we could approach that...
* Drop `cert`, `verify`, `trust_env` from ... | [
{
"body": "**What is the dispatcher API, and why is it useful?...**\r\n\r\nThe dispatcher is the part of the system that's responsible for actually sending the request and returning a response to the client. Having an API to override the dispatcher used by the client allows you to take complete control over tha... | ba073c8a4635dfe2f0b49280d1650a469cde3050 | {
"head_commit": "82faccb7fc7af020522afddcea734cab6f74bc63",
"head_commit_message": "_dispatch > _transports\n\nAlso rename *Dispatch classes to *Transport and added aliases",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex 5203258bca..1e879d6607 100644\n--- a/docs/advanced.md\n+++ b/d... | [
{
"diff_hunk": "@@ -3,8 +3,8 @@\n from ._auth import Auth, BasicAuth, DigestAuth\n from ._client import AsyncClient, Client\n from ._config import PoolLimits, Proxy, Timeout\n-from ._dispatch.asgi import ASGIDispatch\n-from ._dispatch.wsgi import WSGIDispatch\n+from ._transports.asgi import ASGIDispatch, ASGITr... | 83a0e2c3ff07241cb3fd7b2b08e2acd570125cfc | diff --git a/docs/advanced.md b/docs/advanced.md
index 5203258bca..4d1f1d8a78 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -173,7 +173,7 @@ with httpx.Client(app=app, base_url="http://testserver") as client:
assert r.text == "Hello World!"
```
-For some more complex cases you might need to customize ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
encode__httpx-823@df7a50c | encode/httpx | Python | 823 | Add docs on request instances to Requests compatibility guide | * Add prepare_request equivalent of httpx to compatibility document
* Add difference b/w httpx.Request and requests.Request arguments to compatibility document
Fixes #795, fixes #794 | 2020-02-24T17:42:14Z | httpx.Request don't take the same arguments
the `httpx.Request` takes `(method, url, [params], [data], [json], [headers], [cookies])`
and the `requests.Request` takes `(method=None, url=None, headers=None, files=None, data={}, params={}, auth=None, cookies=None, hooks=None)`
this should be pointed out in the docume... | Happy to review any PRs that document which parameters aren’t present on our `Request` class compared to Requests. :)
From what I can see these are:
- `files` (I believe this is handled via `data`, isn’t it?)
- `hooks`
`files` is there, but `auth` isn't.
https://github.com/encode/httpx/blob/82dc6f32f864d26677df... | [
{
"body": "the `httpx.Request` takes `(method, url, [params], [data], [json], [headers], [cookies])`\r\nand the `requests.Request` takes `(method=None, url=None, headers=None, files=None, data={}, params={}, auth=None, cookies=None, hooks=None)`\r\n\r\nthis should be pointed out in the documentation or implemen... | 50d337e807839c21e796fd8b01c67d8a672a9721 | {
"head_commit": "df7a50c567e60fb9daabc65406f7c0c5129aa76a",
"head_commit_message": "Update docs/compatibility.md\n\n* Add prepare_request equivalent of httpx to compatibility document\n\n* Add difference b/w httpx.Request and requests.Request arguments to compatibility document",
"patch_to_review": "diff --git a... | [
{
"diff_hunk": "@@ -64,6 +64,20 @@ is generally equivalent to\n client = httpx.Client(**kwargs)\n ```\n \n+The HTTPX equivalent of `prepare_request` of `requests.Session` instance is `build_request` of `httpx.Client`.",
"line": null,
"original_line": 67,
"original_start_line": null,
"path": "doc... | 5103fd561826634a9033c63828dc4d1eda46f488 | diff --git a/docs/compatibility.md b/docs/compatibility.md
index 89235b1262..c827f35221 100644
--- a/docs/compatibility.md
+++ b/docs/compatibility.md
@@ -64,6 +64,12 @@ is generally equivalent to
client = httpx.Client(**kwargs)
```
+## Request instantiation
+
+There is no notion of [prepared requests](https://requ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
dbt-labs__dbt-core-10282@9237332 | dbt-labs/dbt-core | Python | 10,282 | Migrate selector tests to pytest | resolves #9868
### Problem
In #9868 we wanted to ensure we write, and can write, some selector tests. After creating the ticket, we actually found some selector tests while we were reorganizing tests. Thus #9868 became about converting these tests to use pytest.
### Solution
Converted selector tests to use... | 2024-06-08T00:09:33Z | [SPIKE+] Write a unittest for a simple selection
Creating this one as a Spike + because there is not a single unit test for selection, and selection is very involved.
By trying to write out one unit test for a simple selection, we aim to get a sense of
- what fixture do we need to properly start writing unit tests fo... | The test should be about giving a list of selection specs (can be defined in yaml or python objects), and a list of nodes, how to write a test to check the logic will filter down the list of nodes to the output nodes.
A list of node types is defined on the task and will filter down the node.(This should be treated a... | [
{
"body": "Creating this one as a Spike + because there is not a single unit test for selection, and selection is very involved.\r\nBy trying to write out one unit test for a simple selection, we aim to get a sense of\r\n- what fixture do we need to properly start writing unit tests for selection\r\n- how much ... | 4df120e40e82837b10b3c83f6c6acf763bf325e1 | {
"head_commit": "9237332b4b666664fb6ddbc3a690d1947409498d",
"head_commit_message": "Move `test__partial_parse` from `test_selector.py` to `test_manifest.py`\n\nThere was a test `test__partial_parse` in `test_selector.py` which tested\nthe functionality of `is_partial_parsable` of the `ManifestLoader`. This\ndoesn'... | [
{
"diff_hunk": "@@ -82,7 +68,7 @@ def graph():\n \n \n @pytest.fixture\n-def manifest(graph):\n+def mock_manifest(graph):\n return _get_manifest(graph)",
"line": 73,
"original_line": 72,
"original_start_line": null,
"path": "tests/unit/graph/test_selector.py",
"start_line": null,
"te... | 1f496188d5a36b9254e649afe639b99aed29462f | diff --git a/tests/unit/graph/test_selector.py b/tests/unit/graph/test_selector.py
index 677fb1c46bd..48b3c78436c 100644
--- a/tests/unit/graph/test_selector.py
+++ b/tests/unit/graph/test_selector.py
@@ -1,9 +1,8 @@
-import os
import string
-import unittest
from argparse import Namespace
from queue import Empty
-fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
encode__httpx-803@c6fbc88 | encode/httpx | Python | 803 | Add Auth.requires_response_body attribute | If set then responses are read by the client before being sent back into the auth flow.
This is a work-in-progress. This branch has no test coverage right now because I don't fully understand the implications of this change. Currently there are five tests which fail if `requires_response_body` is set to `True`. Thes... | 2020-02-03T11:46:40Z | Can't read response in Auth.auth_flow
I want to implement auto-refreshing of a token but in order to get the new token I need to be able to read the server response in the custom auth_flow method.
It seems like a trivial change to get the client to `read()` or `aread()` the response before sending it back (like it d... | Hi!
I assume you’d like to access the response body because the server returns an auth token as a JSON payload, eg `{"token": "123abc"}`, right?
Being able to access the request body is documented at the end of [Customizing Authentication](https://www.python-httpx.org/advanced/#customizing-authentication), but we... | [
{
"body": "I want to implement auto-refreshing of a token but in order to get the new token I need to be able to read the server response in the custom auth_flow method.\r\n\r\nIt seems like a trivial change to get the client to `read()` or `aread()` the response before sending it back (like it does with the re... | 82dc6f32f864d26677df8fc61249a7fc74c687e8 | {
"head_commit": "c6fbc8878426d7988c84bad8ee679e1093fee791",
"head_commit_message": "Update tests and docs",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex 809d84383c..895ee66e8d 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -421,6 +421,30 @@ class MyCustomAuth(httpx.Auth... | [
{
"diff_hunk": "@@ -421,6 +421,30 @@ class MyCustomAuth(httpx.Auth):\n ...\n ```\n \n+Similarly, if you are implementing a scheme that requires access to the response body, then use the `requires_response_body` property.\n+\n+```python\n+class MyCustomAuth(httpx.Auth):\n+ requires_response_body = Tru... | 5d4fbfef9eb4792b633c205c42445b270a6e94ef | diff --git a/docs/advanced.md b/docs/advanced.md
index 809d84383c..84ec10a0ad 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -421,6 +421,41 @@ class MyCustomAuth(httpx.Auth):
...
```
+Similarly, if you are implementing a scheme that requires access to the response body, then use the `requires_respo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-10196@161b32e | dbt-labs/dbt-core | Python | 10,196 | Add initial unit tests for `ModelRunner` class | resolves #9867
### Problem
We haven't had a way to _easily_ unit test things like the `ModelRunner` class previously. This is because there were A LOT of things to mock / build before getting to "testing". We've been building a fair amount of testing fixtures and utilities over the past few months. We wanted t... | 2024-05-21T16:36:10Z | [SPIKE+] Make a plan for how to write a unittest for ModelRunner
# Description
make a plan for how to write a unit test for the ModelRunner, and implement it if possible.
This may require:
- mocking adapter
- utils/fixtures to generate manifest that we already have
- Mocking logging system to capture logging behav... | Blocked on
- mocking the adapters: this should be part of the Spike
- [mocking the logger](https://github.com/dbt-labs/dbt-core/issues/9947) | [
{
"body": "# Description\r\nmake a plan for how to write a unit test for the ModelRunner, and implement it if possible.\r\nThis may require:\r\n- mocking adapter\r\n- utils/fixtures to generate manifest that we already have\r\n- Mocking logging system to capture logging behavior\r\n\r\nThis is not amid to have ... | d4a64820919719f8291b0615c62e8b35de3a7a1f | {
"head_commit": "161b32eab71933afa18a4d077e7ad32a352324b1",
"head_commit_message": "Add spoofed macro fixture `materialization_table_default` for `test_execute` test\n\nPreviously the `TestModelRunner:test_execute` test was running into a runtime error\ndo to the macro `materialization_table_default` macro not exi... | [
{
"diff_hunk": "@@ -50,3 +59,72 @@ def test_run_task_preserve_edges():\n task.get_graph_queue()\n # when we get the graph queue, preserve_edges is True\n mock_node_selector.get_graph_queue.assert_called_with(mock_spec, True)\n+\n+\n+class TestModelRunner:\n+ @pytest.fixture\n+ def ... | 4bda8ab2e7d5083f2dda62aeb6d5f41792b324e4 | diff --git a/tests/unit/task/test_run.py b/tests/unit/task/test_run.py
index c689e8f41aa..19a88f6aa8f 100644
--- a/tests/unit/task/test_run.py
+++ b/tests/unit/task/test_run.py
@@ -3,10 +3,19 @@
import pytest
+from dbt.adapters.postgres import PostgresAdapter
+from dbt.artifacts.schemas.results import RunStatus
+f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
encode__httpx-692@458e322 | encode/httpx | Python | 692 | response.elapsed now reflects entire request/response time. | Couple of further tweaks on top of #687, with thanks to @gdhameeja ✨
* `Response(content=...)` is a closed response and should have `response.elapsed == datetime.timedelta(0)`.
* `._elapsed` should only be set when the response is closed. Any further calls to `.close` should have no effect.
Closes #655 | 2019-12-29T14:58:07Z | Make `.elapsed` reflect the entire response time.
I think we should probably switch the behavior of `.elapsed` so that rather than reflecting the "time for the response to start", it is instead only available once `.close()` has been called, and is calculated from the start of the request to the point that the response... | Two different options here during streaming responses...
* `.elapsed` is not available until the response is closed.
* `.elapsed` is available, but will reflect "elapsed so far", until the response is finally closed.
I *guess* we probably just want to go with the former, as a more constrained option.
We'll also ... | [
{
"body": "I think we should probably switch the behavior of `.elapsed` so that rather than reflecting the \"time for the response to start\", it is instead only available once `.close()` has been called, and is calculated from the start of the request to the point that the response is closed.\r\n\r\nThat way i... | e284b84bf9365c8c10a681140a72066980e0da9d | {
"head_commit": "458e322cd62e3967abf897868258c06668f1a0b2",
"head_commit_message": "Response instantiated with content should have elapsed==0",
"patch_to_review": "diff --git a/docs/api.md b/docs/api.md\nindex 7762c05947..9061824a93 100644\n--- a/docs/api.md\n+++ b/docs/api.md\n@@ -56,8 +56,7 @@\n * `.cookies` -... | [
{
"diff_hunk": "@@ -683,11 +683,25 @@ def __init__(\n self.is_closed = True\n self.is_stream_consumed = True\n self._raw_content = content or b\"\"\n+ self._elapsed = datetime.timedelta(0)",
"line": null,
"original_line": 686,
"original_start_line": nul... | aae9332793f902d54fadc2f0a8ff1c6f04f82c82 | diff --git a/docs/api.md b/docs/api.md
index 3f45c90652..ae4d201eb5 100644
--- a/docs/api.md
+++ b/docs/api.md
@@ -56,8 +56,7 @@
* `.cookies` - **Cookies**
* `.history` - **List[Response]**
* `.elapsed` - **[timedelta](https://docs.python.org/3/library/datetime.html)**
- * The amount of time elapsed between sending... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
dbt-labs__dbt-core-10177@547937a | dbt-labs/dbt-core | Python | 10,177 | Add more accurate RSS high water mark measurement for Linux | resolves #10120
### Problem
Memory measurement on Linux reflected the maximum RSS level of not just the current process, but all parent processes.
### Solution
Measure max RSS on Linux via a platform-specific mechanism that does not have this defect.
### Checklist
- [x] I have read [the contributing g... | 2024-05-19T19:55:11Z | Make Memory Usage Reporting More Reliable
At present, dbt uses python's resource.getrusage() function to record the max RSS upon termination. This is not reliable in all of our use cases. Unfortunately this value persists across fork and exec calls on linux, which means that the process which kicks off dbt may set a me... | [
{
"body": "At present, dbt uses python's resource.getrusage() function to record the max RSS upon termination. This is not reliable in all of our use cases. Unfortunately this value persists across fork and exec calls on linux, which means that the process which kicks off dbt may set a memory floor that dbt nev... | 341803d78454f26932267b4c5da361c83556e96a | {
"head_commit": "547937a98888d6408870802001b750ebb8f21a07",
"head_commit_message": "Add changelog entry.",
"patch_to_review": "diff --git a/.changes/unreleased/Under the Hood-20240519-155946.yaml b/.changes/unreleased/Under the Hood-20240519-155946.yaml\nnew file mode 100644\nindex 00000000000..920c7ff860d\n--- ... | [
{
"diff_hunk": "@@ -386,3 +386,21 @@ def strtobool(val: str) -> bool:\n return False\n else:\n raise ValueError(\"invalid truth value %r\" % (val,))\n+\n+\n+def try_get_max_rss_kb() -> Optional[int]:\n+ \"\"\"Attempts to get the high water mark for this process's memory use via\n+ the ... | 75d296b2a101fcd2ee4f839a2454d582f523c7df | diff --git a/.changes/unreleased/Under the Hood-20240519-155946.yaml b/.changes/unreleased/Under the Hood-20240519-155946.yaml
new file mode 100644
index 00000000000..920c7ff860d
--- /dev/null
+++ b/.changes/unreleased/Under the Hood-20240519-155946.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Make RSS high water... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
dask__dask-4865@9e8b539 | dask/dask | Python | 4,865 | Parallel variance computation for dataframes | Fixes #4233
- [x] Tests added / passed
- [x] Passes `flake8 dask`
Re-using array variance computation logic in dataframe. | 2019-05-31T21:09:59Z | Dask Series std function returns NaN for valid array
When executing `memory_usage_series.std().compute()` where `memory_usage_series = task_dataframe["memory_consumption"]` I got a Warning.
```
/home/lfdversluis/miniconda3/envs/format2/lib/python3.6/site-packages/dask/compatibility.py:95: RuntimeWarning: invalid va... | Thanks for the bug report @lfdversluis . If you're able to provide a minimal reproducible example that would help maintainers be able to identify what is wrong more quickly.
Also possibly a repeat of https://github.com/dask/dask/issues/3906
Sure thing. I don't think it is related to #3906, there are no gaps AFAIK.
He... | [
{
"body": "When executing `memory_usage_series.std().compute()` where `memory_usage_series = task_dataframe[\"memory_consumption\"]` I got a Warning.\r\n\r\n```\r\n/home/lfdversluis/miniconda3/envs/format2/lib/python3.6/site-packages/dask/compatibility.py:95: RuntimeWarning: invalid value encountered in sqrt\r\... | 24ee370e32812ca1cf9df6164f64f817fc658f9e | {
"head_commit": "9e8b539659ffff5883e4170fb2261dbe9b51c916",
"head_commit_message": "Adding support of timedelta64",
"patch_to_review": "diff --git a/dask/array/reductions.py b/dask/array/reductions.py\nindex e22489a1d3b..f093ac4249b 100644\n--- a/dask/array/reductions.py\n+++ b/dask/array/reductions.py\n@@ -6,7 ... | [
{
"diff_hunk": "@@ -1461,17 +1461,76 @@ def var(self, axis=None, skipna=True, ddof=1, split_every=False, dtype=None, out\n axis=axis, skipna=skipna, ddof=ddof)\n return handle_out(out, result)\n else:\n- num = self._get_numeric_data()\n- ... | f846d687f9b4b2052ff995fd3cd77071b676ee4f | diff --git a/dask/array/reductions.py b/dask/array/reductions.py
index e22489a1d3b..f093ac4249b 100644
--- a/dask/array/reductions.py
+++ b/dask/array/reductions.py
@@ -6,7 +6,7 @@
from math import factorial, log, ceil
import numpy as np
-from numbers import Integral
+from numbers import Integral, Number
from to... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
encode__httpx-534@3ddc9dd | encode/httpx | Python | 534 | Document when to use AsyncClient | Fixes #179, refs (or fixes?) #508.
| 2019-11-17T10:46:55Z | Use the existing runloop for sync calls in async handler
Hi, this library looks awesome and I really want to use it; but I seem to have hit a blocker and can't seem to find a solution in the docs.
TL;DR: Is there any way to provide our own runloop when using the `sync` calls as looking through the source the sync ca... | FWIW; I tried the following in a vein hope that it would do what I wanted:
```
import httpx
client = httpx.Client(backend=<my app uvloop>)
```
But alas, no success.. this the end of the stacktrace.
```
self.client = httpx.Client(backend=kwargs.get('runloop'))
File "/usr/local/lib/python3.6/site-package... | [
{
"body": "Hi, this library looks awesome and I really want to use it; but I seem to have hit a blocker and can't seem to find a solution in the docs.\r\n\r\nTL;DR: Is there any way to provide our own runloop when using the `sync` calls as looking through the source the sync calls are actually using the async r... | 6045ee242fbe0308ce9d5faf654f5de68e1a3dd8 | {
"head_commit": "3ddc9ddc63b7d065586881836e443f4a51d2f32e",
"head_commit_message": "Document when to use AsyncClient",
"patch_to_review": "diff --git a/docs/async.md b/docs/async.md\nindex 45620bf8c2..9161669dff 100644\n--- a/docs/async.md\n+++ b/docs/async.md\n@@ -105,3 +105,78 @@ trio.run(main)\n \n !!! import... | [
{
"diff_hunk": "@@ -105,3 +105,78 @@ trio.run(main)\n \n !!! important\n `trio` must be installed to import and use the `TrioBackend`.\n+\n+## FAQ\n+\n+### When should I use an `AsyncClient`?\n+\n+You should use an `AsyncClient` whenever you are inside an *async environment*.\n+\n+In particular, using `http... | c93c02d15beb03c8b37a47b9238cb5664a474dcb | diff --git a/docs/async.md b/docs/async.md
index 45620bf8c2..c631d54551 100644
--- a/docs/async.md
+++ b/docs/async.md
@@ -105,3 +105,38 @@ trio.run(main)
!!! important
`trio` must be installed to import and use the `TrioBackend`.
+
+## FAQ
+
+### When should I use an `AsyncClient`?
+
+You should use an `AsyncC... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
cvat-ai__cvat-6712@473fa3e | cvat-ai/cvat | Python | 6,712 | Fixed removing job assignee | <!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will be approved and merged.
Read the [Contribution guide](https://opencv.github.io/cvat/doc... | 2023-08-21T09:38:31Z | Remove assignee from job
Hi!
How do I remove a user from a job via the UI? I can only reassign to another user, but I can't completely delete it. It turns out to be deleted only through the admin panel. | @klakhov Could you please take a look at the issue?
@vaneuss1 Thank you for report, as a temporary workaround you can assign yourself. | [
{
"body": "Hi!\r\nHow do I remove a user from a job via the UI? I can only reassign to another user, but I can't completely delete it. It turns out to be deleted only through the admin panel.",
"number": 6700,
"title": "Remove assignee from job"
}
] | 61c39b57f5a7482b5db58ef624d7bca24e7258ae | {
"head_commit": "473fa3ef1b10a939fe26e3c7c9e0a4ae72b73dd4",
"head_commit_message": "updated changelog and verisions",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 27692a58d4af..15ffb8035f17 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -25,7 +25,7 @@ and this project adheres to [Seman... | [
{
"diff_hunk": "@@ -140,6 +141,7 @@ context('Multiple users. Assign task, job. Deactivating users.', () => {\n it('First user login and assign the job to the third user. Logout', () => {\n cy.login();\n cy.openTask(taskName);\n+ cy.assignJobToUser(0, '');",
"line":... | 0dfcef582d2331d7c35e5487b8c44d0fbedcecd3 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4046439bbb50..5b146bc5b5f7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
+- Removing job assignee (<https://github.com/opencv/cvat/pull/6712>)
- Fixed switchin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
cvat-ai__cvat-6586@ab6626a | cvat-ai/cvat | Python | 6,586 | Added cached frames indication | <!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will be approved and merged.
Read the [Contribution guide](https://opencv.github.io/cvat/doc... | 2023-07-30T10:24:13Z | Video/Image loading status as on youtube
Another question and likely feature suggestion.
When start a job, if I wait long enough, will all the frames be loaded into the browser?
Or, are they loaded on demand as I seek through the video?
Are they cached locally in memory?
I'm working with 4k video and the interf... | > When start a job, if I wait long enough, will all the frames be loaded into the browser?
Or, are they loaded on demand as I seek through the video?
No, they don't. To reduce server load it will try to preload next 500 frames and it will continue preload other frames as soon as necessary. After jump it will start ... | [
{
"body": "Another question and likely feature suggestion.\r\n\r\nWhen start a job, if I wait long enough, will all the frames be loaded into the browser?\r\nOr, are they loaded on demand as I seek through the video?\r\nAre they cached locally in memory?\r\n\r\nI'm working with 4k video and the interface isn't ... | 70fc428311365b626962f92a03101288eb75ceb3 | {
"head_commit": "ab6626a3815124d68e748b3291f13b4b96cba377",
"head_commit_message": "Removed extra arguments",
"patch_to_review": "diff --git a/cvat-core/src/frames.ts b/cvat-core/src/frames.ts\nindex 158e35821141..2f5b328f81bf 100644\n--- a/cvat-core/src/frames.ts\n+++ b/cvat-core/src/frames.ts\n@@ -582,12 +582,... | [
{
"diff_hunk": "@@ -581,10 +581,41 @@ export function switchPlay(playing: boolean): AnyAction {\n };\n }\n \n-export function confirmCanvasReady(): AnyAction {\n+export function confirmCanvasReady(ranges?: string[]): AnyAction {\n return {\n type: AnnotationActionTypes.CONFIRM_CANVAS_READY,\n- ... | 79431a1a4367e924aa8716767785b4550d916550 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f34bfcef5fa8..162f24495b6c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
user-provided function on the local machine, and a corresponding CLI command
(`auto-annotate`)
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
encode__httpx-485@7a8625f | encode/httpx | Python | 485 | Drop proxies arg from the high level API | Closes https://github.com/encode/httpx/issues/480
| 2019-10-19T10:28:17Z | Drop proxies argument from top-level API functions.
Somehow the `proxies` argument has crept into our top-level API functions (eg. `httpx.get()`).
It's not actually wired up anyplace. We should drop the argument for now.
We *will* want per-request control for proxies, but that should be implemented alongside adding... | [
{
"body": "Somehow the `proxies` argument has crept into our top-level API functions (eg. `httpx.get()`).\r\nIt's not actually wired up anyplace. We should drop the argument for now.\r\n\r\nWe *will* want per-request control for proxies, but that should be implemented alongside adding support for `proxies=...` ... | 7200717e82e6b4ed16f264883e5e541e254ebef5 | {
"head_commit": "7a8625f40a24cb7605cf4d516ebfb2fcee4eae16",
"head_commit_message": "Add note on not supporting proxies at request level",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex 973ffed486..b9fa085b7d 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -168,6 +168,11 @@... | [
{
"diff_hunk": "@@ -168,6 +168,11 @@ client = httpx.Client(proxies=proxy)\n client.get(\"http://example.com\")\n ```\n \n+!!! note\n+\n+ Per request proxy configuration, i.e. `client.get(url, proxies=...)`,\n+ have not yet been implemented. To use proxies you must pass the proxy",
"line": null,
"o... | 1b85431fa04881a0a1fdc944ba9ff35349094570 | diff --git a/docs/advanced.md b/docs/advanced.md
index 973ffed486..d360e317a7 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -168,6 +168,11 @@ client = httpx.Client(proxies=proxy)
client.get("http://example.com")
```
+!!! note
+
+ Per request proxy configuration, i.e. `client.get(url, proxies=...)`,
+ ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
dask__dask-4719@f3e886d | dask/dask | Python | 4,719 | Remove hard pandas dependency for melt by using methodcaller | **Summary of Changes**
- This PR updates the `melt` function to use `M.melt` instead of `pd.melt`, removing the hard coding of dask's `melt` function to pandas.
- [ X ] Tests added / passed
- ```====================================== 5358 passed, 472 skipped, 23 xfailed, 6 xpassed, 149 warnings in 793.61 secon... | 2019-04-19T18:27:32Z | [FEA] Use M methodcaller in melt
### Request
As a dask user, I'd like to be able to potentially use `melt` for multiple types of dataframe data structures. Currently, melt is hard tied to pandas via `pd.melt`. Switching dask's melt to use the `M` methodcaller should make this possible.
Note: I'm going to open a PR ... | [
{
"body": "### Request\r\nAs a dask user, I'd like to be able to potentially use `melt` for multiple types of dataframe data structures. Currently, melt is hard tied to pandas via `pd.melt`. Switching dask's melt to use the `M` methodcaller should make this possible.\r\n\r\nNote: I'm going to open a PR for this... | f43153bf39d2db446275c733e7bb513d3e228b66 | {
"head_commit": "f3e886d44c57661dda8dd95397158a24321a7079",
"head_commit_message": "remove hard pandas dependency for melt by using methodcaller",
"patch_to_review": "diff --git a/dask/dataframe/reshape.py b/dask/dataframe/reshape.py\nindex 528249e794b..75bfb3dcf54 100644\n--- a/dask/dataframe/reshape.py\n+++ b/... | [
{
"diff_hunk": "@@ -239,8 +239,9 @@ def melt(frame, id_vars=None, value_vars=None, var_name=None,\n value_name='value', col_level=None):\n \n from dask.dataframe.core import no_default\n+ from ..utils import M",
"line": null,
"original_line": 242,
"original_start_line": null,
"pa... | 3029b883b6002186e382b22b97d2f965b5d279ea | diff --git a/dask/dataframe/reshape.py b/dask/dataframe/reshape.py
index 528249e794b..160fbcd96f4 100644
--- a/dask/dataframe/reshape.py
+++ b/dask/dataframe/reshape.py
@@ -8,6 +8,7 @@
from .utils import (
is_categorical_dtype, is_scalar, has_known_categories, PANDAS_VERSION
)
+from ..utils import M
#######... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dask__dask-4714@8963fa3 | dask/dask | Python | 4,714 | Add Dataframe.replace | Fixes #4573
- [ ] Tests added / passed
- [ ] Passes `flake8 dask`
| 2019-04-18T13:35:43Z | pandas .replace() method in dask
Hi All,
I would like to recode a column variable using dask. It could be done in pandas using .replace(). An example code is below.
in pandas:
```python
months = {'jan':1,'feb':2,'mar':3,'apr':4,'may':5,'jun':6,'jul':7,'aug':8,'sep':9,'oct':10,'nov':11,'dec':12}
df.replace(mont... | Does `DataFrame.map_partitions(pandas.DataFrame.replace, months)` work?
This should be relatively easy to add to dask dataframe.
On Sat, Mar 9, 2019 at 2:32 AM MichaelSchroter <notifications@github.com>
wrote:
> Hi All,
>
> I would like to recode a column variable using dask. It could be done in
> pandas using .repl... | [
{
"body": "Hi All,\r\n\r\nI would like to recode a column variable using dask. It could be done in pandas using .replace(). An example code is below.\r\n\r\nin pandas:\r\n```python\r\nmonths = {'jan':1,'feb':2,'mar':3,'apr':4,'may':5,'jun':6,'jul':7,'aug':8,'sep':9,'oct':10,'nov':11,'dec':12}\r\ndf.replace(mont... | 967e30c3a4b17400b91b83e0fc28dd1da50c06b9 | {
"head_commit": "8963fa3ca9669152c5dc2995ac89ce2c3fe10f8d",
"head_commit_message": "Add Dataframe.replace\n\nFixes #4573",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 86a5a300ae1..d031528d253 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -1109,... | [
{
"diff_hunk": "@@ -1109,6 +1109,10 @@ def sample(self, n=None, frac=None, replace=False, random_state=None):\n graph = HighLevelGraph.from_collections(name, dsk, dependencies=[self])\n return new_dd_object(graph, name, self._meta, self.divisions)\n \n+ def replace(self, to_replace=None, valu... | 949dbffdc75361253499b65e9956aded77802825 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 86a5a300ae1..21f05a9c899 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -1109,6 +1109,11 @@ def sample(self, n=None, frac=None, replace=False, random_state=None):
graph = HighLevelGraph.from_collections(name, dsk, dependenc... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-2605@c1fea88 | deepset-ai/haystack | Python | 2,605 | Add node to use OpenAI's GPT-3 for QA | **Proposed changes**:
Integrating OpenAI's GPT-3 model via their API.
The node can take documents as input and generates `top_k` answers by calling the remote API from OpenAI.
Users will need to signup at OpenAI and supply their `api_key` to the node.
**Example:**
```
node = OpenAIAnswerGenerator(api_key="... | 2022-05-28T16:12:44Z | Feature request: Use gpt-3 (or other services) as Reader
It would be cool if gpt-3/openai or other services could be used as reader.
Instead of running a local modal, a request to the service could be made (containing the preselection).
If this feature has demand, I would volunteer to integrate it :) | Hello @jacksbox I'm glad you want to contribute to Haystack! However it's not too evident to me how you imagine this GTP3-based Reader to work. Can you flesh out your idea a bit more? Once we have a clear idea of the effort required it's going to be easier to see if it's worth it or not :wink:
The idea as a rough outl... | [
{
"body": "It would be cool if gpt-3/openai or other services could be used as reader.\r\nInstead of running a local modal, a request to the service could be made (containing the preselection).\r\n\r\nIf this feature has demand, I would volunteer to integrate it :)",
"number": 2344,
"title": "Feature re... | a766b70a8fd19775c8ef0053242e7bbd721d07b4 | {
"head_commit": "c1fea88d0ab99056f8e98a94ee07248cd5e392c2",
"head_commit_message": "Make use of api key in tests",
"patch_to_review": "diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml\nindex 64706dd5b8..8840453c66 100644\n--- a/.github/workflows/tests.yml\n+++ b/.github/workflows/tests.yml\... | [
{
"diff_hunk": "@@ -0,0 +1,185 @@\n+from typing import Optional, List, Tuple\n+import json\n+import logging\n+import requests\n+\n+from transformers import GPT2TokenizerFast\n+\n+from haystack.nodes.answer_generator import BaseGenerator\n+from haystack import Document\n+\n+\n+logger = logging.getLogger(__name__... | 5d5d24cd2a5cbe0736ce97ef5fbf71c97e65a136 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 64706dd5b8..8840453c66 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -30,6 +30,7 @@ env:
--ignore=test/nodes/test_connector.py
--ignore=test/nodes/test_summarizer_translation.py
--ignore=test/no... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
certbot__certbot-8643@555e373 | certbot/certbot | Python | 8,643 | Deprecate acme.typing_magic module, stop using it in certbot | Fixes #8628
On top of the deprecation and code cleanup, I also execute isort to fix the import sections. | 2021-02-06T11:45:28Z | Stop using magic_typing and deprecate it
Now that we no longer support Python 2, we can stop using `acme.magic_typing` and `josepy.magic_typing` in favor of `typing` which is part of the standard library in Python 3.5+. We should also deprecate these modules so they raise deprecation warnings if they're imported.
Th... | [
{
"body": "Now that we no longer support Python 2, we can stop using `acme.magic_typing` and `josepy.magic_typing` in favor of `typing` which is part of the standard library in Python 3.5+. We should also deprecate these modules so they raise deprecation warnings if they're imported.\r\n\r\nThis issue may want ... | 76895457c9f5956ec97ccadc3e0d7e894db17094 | {
"head_commit": "555e373d6a4afbf4eb3c783f664c26b0b1822c77",
"head_commit_message": "Merge branch 'master' into deprecate-magic-typing",
"patch_to_review": "diff --git a/acme/acme/challenges.py b/acme/acme/challenges.py\nindex 41a2aa25804..58b457e0d3f 100644\n--- a/acme/acme/challenges.py\n+++ b/acme/acme/challen... | [
{
"diff_hunk": "@@ -1,12 +1,17 @@\n \"\"\"Shim class to not have to depend on typing module in prod.\"\"\"\n import sys\n+import warnings\n+\n+warnings.warn(\"Module acme.magic_typing is deprecated and will be removed in a future release.\",",
"line": null,
"original_line": 5,
"original_start_line":... | 4bc41a4fbd8f597fac100e8932220832c6cec4a9 | diff --git a/acme/acme/challenges.py b/acme/acme/challenges.py
index 41a2aa25804..58b457e0d3f 100644
--- a/acme/acme/challenges.py
+++ b/acme/acme/challenges.py
@@ -8,14 +8,15 @@
from cryptography.hazmat.primitives import hashes # type: ignore
import josepy as jose
-import requests
-from OpenSSL import SSL # type... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
deepset-ai__haystack-2619@eb4c557 | deepset-ai/haystack | Python | 2,619 | Simplify loading of `EmbeddingRetriever` | This PR adds a method to the `EmbeddingRetriever` to infer the model_format parameter automatically from the model's config files if no model_format is provided by the user.
Closes #2406
| 2022-06-01T10:08:22Z | Simplify loading of `EmbeddingRetriever`
Loading of `EmbeddingRetriever`s is quite complex, e.g. it is quite confusing to determine which model to use with which model format (we can use model format `"sentence_transformers"` with model that are on the HF model hub (e.g. `sentence-transformers/all-mpnet-base-v2`)).
... | I just had an in-depth look into the `EmbeddingRetriever` and came to the conclusion that it might be possible to drop the `model_format` entirely. Currently, we support the following formats: `"farm"`, `"transformers"`, `"sentence_transformers"` and `"retribert"`.
- Both `"farm"` and `"transformers"` use the `_Defa... | [
{
"body": "Loading of `EmbeddingRetriever`s is quite complex, e.g. it is quite confusing to determine which model to use with which model format (we can use model format `\"sentence_transformers\"` with model that are on the HF model hub (e.g. `sentence-transformers/all-mpnet-base-v2`)). \r\n\r\nAlso, it might ... | a617ab950b603aab27e500bc66f40654ade69b22 | {
"head_commit": "eb4c5575c344ba3ee6aa1d65678c253d6bb87d3a",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/docs/_src/api/api/retriever.md b/docs/_src/api/api/retriever.md\nindex 8cfe87ab81..43cdfae618 100644\n--- a/docs/_src/api/api/retriever.md\n+++ b/docs/_src/api/... | [
{
"diff_hunk": "@@ -1391,7 +1391,9 @@ def test_elasticsearch_synonyms():\n @pytest.mark.embedding_dim(384)\n def test_similarity_score(document_store_with_docs):\n retriever = EmbeddingRetriever(\n- document_store=document_store_with_docs, embedding_model=\"sentence-transformers/paraphrase-MiniLM-L3-... | 4f0846260a9a78b39906e20ef8757cae095044a2 | diff --git a/docs/_src/api/api/retriever.md b/docs/_src/api/api/retriever.md
index 8cfe87ab81..3f7ec06596 100644
--- a/docs/_src/api/api/retriever.md
+++ b/docs/_src/api/api/retriever.md
@@ -1171,7 +1171,7 @@ class EmbeddingRetriever(BaseRetriever)
#### EmbeddingRetriever.\_\_init\_\_
```python
-def __init__(docume... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
dask__dask-4684@954e535 | dask/dask | Python | 4,684 | dask.array.bincount() - make 'minlength' keyword argument optional | This PR would make the `minlength` keyword argument to `dask.array.bincount()` optional, instead of required.
It implements @mrocklin 's [suggested approach](https://github.com/dask/dask/pull/4683#pullrequestreview-224744657):
> As an alternative, what if we just called `np.bincount` on all of the chunks without ... | 2019-04-10T07:05:43Z | `bincount` assumes `minlength` is the length
Currently Dask Array's `bincount` assumes `minlength` is the length of the underlying array. Unfortunately, as noted in NumPy's docs, "if minlength is specified, there will be at least this number of bins in the output array (though it will be longer if necessary, depending... | cc @GenevieveBuckley
I've played around with da.bincount() a bit, and feel like I sometimes got inconsistent output regarding minlength. Maybe this was due to switching between different versions of dask (or even numpy?) at the time?
I don't really remember (and don't have time to dig into it either), but wanted to... | [
{
"body": "Currently Dask Array's `bincount` assumes `minlength` is the length of the underlying array. Unfortunately, as noted in NumPy's docs, \"if minlength is specified, there will be at least this number of bins in the output array (though it will be longer if necessary, depending on the contents of x).\"... | 13ed28d020638dd92002d1206a0f4876f70bc43c | {
"head_commit": "954e535dd26291584963fcf3a180060578444a03",
"head_commit_message": "Bump pandas to 0.20.2 for python 3.5 travis build",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 7de0412b195..3baa0a1e109 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -27,8 +27,8 @@ jobs:\n \n - env:\... | [
{
"diff_hunk": "@@ -523,34 +523,44 @@ def gradient(f, *varargs, **kwargs):\n return results\n \n \n+def _bincount_sum(bincounts, dtype=int):\n+ n = max(map(len, bincounts))\n+ out = np.zeros(n, dtype=dtype)\n+ for b in bincounts:\n+ out[:len(b)] += b[:len(b)]\n+ return out\n+\n+\n @wraps(... | 41c6b00f96a3c0c11a6d374ce9500ee24fa912c3 | diff --git a/dask/array/routines.py b/dask/array/routines.py
index 907ad5e2adb..261f7501e66 100644
--- a/dask/array/routines.py
+++ b/dask/array/routines.py
@@ -515,17 +515,27 @@ def gradient(f, *varargs, **kwargs):
return results
+def _bincount_sum(bincounts, dtype=int):
+ n = max(map(len, bincounts))
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-4613@cdb2c29 | dask/dask | Python | 4,613 | Fix comparison against pd.Series | fixes #4596
- [x] Tests added / passed
- [x] Passes `flake8 dask`
| 2019-03-19T13:56:51Z | dask.dataframe.fillna fails with "ValueError: cannot reindex from a duplicate axis"
Starting with Dask 1.1.0, `dask.dataframe.fillna` fails when trying to fill based on a series from the same dataframe if the index is not unique. The following example works under Dask 1.0.0, but fails with more recent versions:
```
... | Thanks. For reference can you attach the stacktrace?
Did you also change pandas versions when upgrading from dask 1.0 to 1.1?
```Traceback (most recent call last):
File "test.py", line 13, in <module>
ddf.compute()
File "/home/amerkel/venv/lib/python3.6/site-packages/dask/base.py", line 156, in compute
... | [
{
"body": "Starting with Dask 1.1.0, `dask.dataframe.fillna` fails when trying to fill based on a series from the same dataframe if the index is not unique. The following example works under Dask 1.0.0, but fails with more recent versions:\r\n\r\n```\r\nimport dask\r\nimport dask.dataframe as dd \r\nimport nump... | 3a461039fda35873d1f3abd0302457420b95fad0 | {
"head_commit": "cdb2c29a1e32b6ec89d47bebf6bb4099463bd897",
"head_commit_message": "Fix comparison against pd.Series.",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 609f7c9cc95..1102153d69f 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -1024,7 +... | [
{
"diff_hunk": "@@ -1024,7 +1024,7 @@ def fillna(self, value=None, method=None, limit=None, axis=None):\n # Control whether or not dask's partition alignment happens.\n # We don't want for a pandas Series.\n # We do want it for a dask Series\n- if is_series_like(va... | 33b672f345062a2ec4cde5a56c89827343d94666 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 609f7c9cc95..72c116774a8 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -1024,7 +1024,7 @@ def fillna(self, value=None, method=None, limit=None, axis=None):
# Control whether or not dask's partition alignment happens.
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
dask__dask-4513@54ce73e | dask/dask | Python | 4,513 | Modify mean chunk functions to return dicts rather than arrays | These functions return two array chunks each:
1. The sum of the array
2. The counts of the array
We need to return these as a single intermediate value.
Previously we did this by constructing an empty numpy array and then
assigning into it. This doesn't work as well with numpy-like arrays
like cupy and s... | 2019-02-20T03:40:51Z | NEP-18: mean_chunk() object __array__ method not producing an array
Several Dask operations that utilize `mean_chunk()` from `dask/array/reductions.py` fail for Dask arrays created from non-NumPy (e.g., CuPy, sparse) arrays.
Some of the operations confirmed to fail are (including other non-core Dask projects):
* `d... | Hrm, @jcrist do you have any suggestions here? The challenge is that we're creating an `empty` numpy array and then assigning into it. This makes things hard for non-Numpy implementations like sparse or cupy.
Two thoughts:
1. We could see if dask array is returning a tuple rather than a record array. My guess... | [
{
"body": "Several Dask operations that utilize `mean_chunk()` from `dask/array/reductions.py` fail for Dask arrays created from non-NumPy (e.g., CuPy, sparse) arrays.\r\n\r\nSome of the operations confirmed to fail are (including other non-core Dask projects):\r\n* `dask.mean()`\r\n* `dask.glm.algorithms.*`\r\... | b1430f03b9e0ebe015cfbed48ac9091fe2f81935 | {
"head_commit": "54ce73e58ffd6c8869e2862125765458d4674349",
"head_commit_message": "Modify mean chunk functions to return dicts rather than arrays\n\nThese functions return two array chunks each:\n\n1. The sum of the array\n2. The counts of the array\n\nWe need to return these as a single intermediate value.\n\n... | [
{
"diff_hunk": "@@ -331,26 +331,27 @@ def nannumel(x, **kwargs):\n def mean_chunk(x, sum=chunk.sum, numel=numel, dtype='f8', **kwargs):\n n = numel(x, dtype=dtype, **kwargs)\n total = sum(x, dtype=dtype, **kwargs)\n- empty = empty_lookup.dispatch(type(n))\n- result = empty(n.shape, dtype=[('total'... | b2f3394d44f57e81a9fdf6172afd04b0a2ed373f | diff --git a/dask/array/reductions.py b/dask/array/reductions.py
index 947e24d8819..56c7a60ab80 100644
--- a/dask/array/reductions.py
+++ b/dask/array/reductions.py
@@ -22,7 +22,7 @@
from ..compatibility import getargspec, builtins
from ..base import tokenize
from ..highlevelgraph import HighLevelGraph
-from ..utils... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
encode__httpx-353@975b79a | encode/httpx | Python | 353 | Proxy Configurations | Here's part 2 of the HTTP proxy PRs, configuring on the client. I also worked out some issues with re-using the TCP tunnel connection.
Closes #33 | 2019-09-18T12:38:33Z | Environment support
Needs to handle anything that requests currently deals with when `trust_env=True` is set.
`.netrc`, `REQUEST_CA_BUNDLE` and anything else relevant.
First step to dealing with this would be to outline *exactly* what set of stuff `requests` includes. If anyone wants to dig into this and comment on... | If this is still important, I'd be interested in doing some research here to determine what exactly requests includes, and then possibly implementing proper functionality.
This is definitely important! If you can lend a hand with discovery that'd be great.
Hi, I tried to include netrc support. #177 what do you think ab... | [
{
"body": "Needs to handle anything that requests currently deals with when `trust_env=True` is set.\r\n`.netrc`, `REQUEST_CA_BUNDLE` and anything else relevant.\r\n\r\nFirst step to dealing with this would be to outline *exactly* what set of stuff `requests` includes. If anyone wants to dig into this and comme... | 338a3607852634200b880bbb361c0e2d6dd20f90 | {
"head_commit": "975b79a038b82213e1b6c01cb7f2ece0010574ea",
"head_commit_message": "Start of proxy config",
"patch_to_review": "diff --git a/docs/advanced.md b/docs/advanced.md\nindex dba5128ded..97b0db0576 100644\n--- a/docs/advanced.md\n+++ b/docs/advanced.md\n@@ -111,3 +111,48 @@ password example-password\n \... | [
{
"diff_hunk": "@@ -162,13 +173,20 @@ def merge_headers(\n cert: CertTypes = None,\n timeout: TimeoutTypes = None,\n trust_env: bool = None,\n+ proxies: ProxiesTypes = None,\n ) -> AsyncResponse:\n if request.url.scheme not in (\"http\", \"https\"):\n raise... | e2da12da2ca68af0b90eb97ebb4fb568c82363d0 | diff --git a/docs/advanced.md b/docs/advanced.md
index dba5128ded..6acad3b67b 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -111,3 +111,52 @@ password example-password
...
```
+
+## HTTP Proxying
+
+HTTPX supports setting up proxies the same way that Requests does via the `proxies` parameter.
+For example... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
deepset-ai__haystack-2618@65fc0ea | deepset-ai/haystack | Python | 2,618 | first version of save_to_remote for HF from FarmReader | Fixes #2416
This draft PR introduces the `save_to_remote()` function to the `FarmReader`
It converts a model to the transformer models format using the `convert_to_transformer` method from the `AdaptiveModel` class.
I have tested this by fine-tuning a model and then calling `save_to_remote` - then loading that s... | 2022-05-31T23:17:11Z | Autoupload models to huggingface hub after training
**Is your feature request related to a problem? Please describe.**
When training with FARMReader finishes, there should be an option to upload it automatically to HF hub.
**Describe the solution you'd like**
Add option and template to auto upload trained / fine-t... | Using [huggingface_hub lib](https://github.com/huggingface/huggingface_hub) we can [create a repo](https://huggingface.co/docs/hub/how-to-upstream#%60Repository%60) and upload them model files. To add a model card, we simply have to upload a README.md according to [this](https://huggingface.co/docs/hub/model-repos#what... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWhen training with FARMReader finishes, there should be an option to upload it automatically to HF hub.\r\n\r\n**Describe the solution you'd like**\r\nAdd option and template to auto upload trained / fine-tuned model to HF.\r\n\r\n... | ffb7e4e4bd900616f3e9154755847c91b23fb340 | {
"head_commit": "65fc0ea39ad31512fdd55bc482a601c10c75bd38",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/haystack/nodes/reader/farm.py b/haystack/nodes/reader/farm.py\nindex 260528d0a9..70ed5a1cc0 100644\n--- a/haystack/nodes/reader/farm.py\n+++ b/haystack/nodes/re... | [
{
"diff_hunk": "@@ -688,6 +691,50 @@ def save(self, directory: Path):\n self.inferencer.model.save(directory)\n self.inferencer.processor.save(directory)\n \n+ def save_to_remote(\n+ self,\n+ model_name: str,\n+ hf_organization: Optional[str] = None,\n+ private: Op... | 2840b009870dfccfa82b9b0c7de52e5b79406672 | diff --git a/docs/_src/api/api/reader.md b/docs/_src/api/api/reader.md
index 1ce4ed4e73..bc58a11b60 100644
--- a/docs/_src/api/api/reader.md
+++ b/docs/_src/api/api/reader.md
@@ -333,6 +333,25 @@ Saves the Reader model so that it can be reused at a later point in time.
- `directory`: Directory where the Reader model... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
certbot__certbot-8500@6c9307c | certbot/certbot | Python | 8,500 | Fix add deprecated argument | Fixes https://github.com/certbot/certbot/issues/8495.
To further explain the problem here, `modify_kwargs_for_default_detection` as called in `add` is simplistic and doesn't always work. See https://github.com/certbot/certbot/issues/6164 for one other example.
In this case, were bitten by the code https://github.... | 2020-12-02T21:04:34Z | manual-public-ip-logging-ok deprecation leads to error
I am regularly running Certbot (latest docker image) to obtain new certificates when necessary. Tonight the Certbot command failed, which seems to be related to the deprecation of `manual-public-ip-logging-ok` within version `1.11.0`. Seems like this flag now requi... | Hi @st-h,
Could you please share the exact command which produces this error?
This is the command when it failed:
```
certbot certonly --manual --preferred-challenges dns-01 -m $ACME_EMAIL --manual-public-ip-logging-ok --agree-tos --no-bootstrap --non-interactive --manual-auth-hook './src/authenticate.sh' --manual... | [
{
"body": "I am regularly running Certbot (latest docker image) to obtain new certificates when necessary. Tonight the Certbot command failed, which seems to be related to the deprecation of `manual-public-ip-logging-ok` within version `1.11.0`. Seems like this flag now requires an argument, which it previously... | d1e7404358c05734aaf436ef3c9d709029d62b09 | {
"head_commit": "6c9307cb3c9fdbf20be5ddb22374b797c7546f21",
"head_commit_message": "Add changelog entry",
"patch_to_review": "diff --git a/certbot-ci/certbot_integration_tests/utils/certbot_call.py b/certbot-ci/certbot_integration_tests/utils/certbot_call.py\nindex a71c610e560..2ddaa41c8ad 100755\n--- a/certbot-... | [
{
"diff_hunk": "@@ -410,8 +424,22 @@ def add_deprecated_argument(self, argument_name, num_args):\n :param int nargs: Number of arguments the option takes.\n \n \"\"\"\n- util.add_deprecated_argument(\n- self.parser.add_argument, argument_name, num_args)\n+ # certbot.util... | ca887a89e3bc478db21c8b2be8c49e3c60b5e126 | diff --git a/certbot-ci/certbot_integration_tests/utils/certbot_call.py b/certbot-ci/certbot_integration_tests/utils/certbot_call.py
index a71c610e560..2ddaa41c8ad 100755
--- a/certbot-ci/certbot_integration_tests/utils/certbot_call.py
+++ b/certbot-ci/certbot_integration_tests/utils/certbot_call.py
@@ -92,6 +92,7 @@ d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
encode__httpx-277@7568fcf | encode/httpx | Python | 277 | Add easier debug logging for users | This builds on #240 and adds it to all request-making dispatchers. It can be added to ASGI and WSGI dispatchers as well but I'm less familiar with what information would be useful for debugging those use-cases.
This also adds a new environment variable `HTTPX_DEBUG` which can be turned on to automatically display th... | 2019-08-26T11:58:35Z | Add DEBUG logging to Dispatchers and Client for easier debugging
I was finding it difficult to debug some low-level behaviors when connecting to a specific host due to some HTTP/2-specific events. I'm sure our users will feel the same way when using HTTPX if something's not working. | 💯 Yes please! | [
{
"body": "I was finding it difficult to debug some low-level behaviors when connecting to a specific host due to some HTTP/2-specific events. I'm sure our users will feel the same way when using HTTPX if something's not working.",
"number": 221,
"title": "Add DEBUG logging to Dispatchers and Client for... | 33032df0b03e885f1cb6215bb093389481c8a3dc | {
"head_commit": "7568fcf431036ac1be2bf3d0e6e5075d8814815b",
"head_commit_message": "Add easier debug logging for users",
"patch_to_review": "diff --git a/docs/environment_variables.md b/docs/environment_variables.md\nnew file mode 100644\nindex 0000000000..bb55151461\n--- /dev/null\n+++ b/docs/environment_variab... | [
{
"diff_hunk": "@@ -0,0 +1,47 @@\n+Environment Variables\n+=====================\n+\n+The HTTPX library can be configured via environment variables.\n+Here are a list of environment variables that HTTPX recognizes\n+and what function they serve:\n+\n+HTTPX_DEBUG\n+-----------\n+\n+Valid values: `1`, `true`\n+\n... | 2024938b4e5f4f27f7186b01b9cf8ab1b3b20353 | diff --git a/docs/environment_variables.md b/docs/environment_variables.md
new file mode 100644
index 0000000000..be1b5810b7
--- /dev/null
+++ b/docs/environment_variables.md
@@ -0,0 +1,46 @@
+Environment Variables
+=====================
+
+The HTTPX library can be configured via environment variables.
+Here is a list ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-4423@19049ad | dask/dask | Python | 4,423 | Add key argument to Bag.distinct | - [x] Tests added / passed
- [x] Passes `flake8 dask`
closes #2493
A few things to discuss:
1. Should we change the implementation to use `fold` instead of `reduction`?
2. Is it ok to default `key` to `toolz.identity` instead of `None` + conditional logic? | 2019-01-25T22:47:41Z | Ability to drop duplicates on Bag based on subset of data
It would be nice if it was possible to drop duplicates on a bag based on a subset of the data, similar to `DataFrame.drop_duplicates(subset=[...])`. Perhaps the API could be `Bag.distinct(key=lambda x: x['name'])`.
I can help implement this feature, just let... | Hi @munro this seems useful to me. The current thing to look at is (as you seem to have found) [Bag.distinct](http://dask.pydata.org/en/latest/bag-api.html#dask.bag.Bag.distinct). This operates as a reduction, and assumes that the output set will fit nicely into memory in a single partition. Adding a `key=` keyword ... | [
{
"body": "It would be nice if it was possible to drop duplicates on a bag based on a subset of the data, similar to `DataFrame.drop_duplicates(subset=[...])`. Perhaps the API could be `Bag.distinct(key=lambda x: x['name'])`.\r\n\r\nI can help implement this feature, just let me know what the ideal API would b... | 81bebb682674472c9726f66e05ac351674450fd5 | {
"head_commit": "19049ad5d7d98da1997dbca05a5c714e4a68d70a",
"head_commit_message": "Removed unused import",
"patch_to_review": "diff --git a/dask/bag/core.py b/dask/bag/core.py\nindex 99f5645ecdb..3a9e923251a 100644\n--- a/dask/bag/core.py\n+++ b/dask/bag/core.py\n@@ -817,16 +817,34 @@ def topk(self, k, key=None... | [
{
"diff_hunk": "@@ -817,16 +817,34 @@ def topk(self, k, key=None, split_every=None):\n return self.reduction(func, compose(func, toolz.concat), out_type=Bag,\n split_every=split_every, name='topk')\n \n- def distinct(self):\n+ def distinct(self, key=None):\n \... | 152b376d0de5553559607e336f8bf4ef2e7f4ade | diff --git a/dask/bag/core.py b/dask/bag/core.py
index 99f5645ecdb..b8753bfeedb 100644
--- a/dask/bag/core.py
+++ b/dask/bag/core.py
@@ -19,13 +19,13 @@
try:
import cytoolz
from cytoolz import (frequencies, merge_with, join, reduceby,
- count, pluck, groupby, topk)
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dask__dask-3893@ac04285 | dask/dask | Python | 3,893 | add expand_environment_variables to dask.config | closes #3879
- [x] Tests added / passed
- [x] Passes `flake8 dask`
cc @jacobtomlinson and @mrocklin | 2018-08-21T02:38:25Z | utility to expand environment variables in dask config
It would be useful if dask could (optionally) expand environment variables in its config module. This may not always be useful but @mrocklin and I ran into a case today where it is the logical solution. Consider the following dask configuration file.
```yaml
# ... | Right, so this would be a utility function in `dask/config.py` and then a use of that utility function in dask-kubernetes?
Exactly. We should ping @jacobtomlinson for comment as well.
We do currently use this in [a few places](https://github.com/dask/dask-kubernetes/blob/master/dask_kubernetes/core.py#L190) in dask-kub... | [
{
"body": "It would be useful if dask could (optionally) expand environment variables in its config module. This may not always be useful but @mrocklin and I ran into a case today where it is the logical solution. Consider the following dask configuration file.\r\n\r\n```yaml\r\n# dask config file...\r\nkuberne... | ad450dd83db0e80f0adb20cbc215731f43a53470 | {
"head_commit": "ac04285e795f15e59ce6878e77eecb3969bad9f1",
"head_commit_message": "add expand_environment_variables to dask.config",
"patch_to_review": "diff --git a/dask/config.py b/dask/config.py\nindex 24ed1e3a673..67be157ed7d 100644\n--- a/dask/config.py\n+++ b/dask/config.py\n@@ -9,6 +9,8 @@\n except Impor... | [
{
"diff_hunk": "@@ -434,4 +436,26 @@ def update_defaults(new, config=config, defaults=defaults):\n update(config, new, priority='old')\n \n \n+def expand_environment_variables(config):\n+ ''' Utility to expand environment variables in a config dictionary\n+\n+ This function will recursively search thr... | 4b1267fc001a91e1d68f3a51d416dc872566e49d | diff --git a/dask/config.py b/dask/config.py
index 24ed1e3a673..5b576cd2d8c 100644
--- a/dask/config.py
+++ b/dask/config.py
@@ -9,7 +9,9 @@
except ImportError:
yaml = None
-from .compatibility import makedirs
+from collections import Mapping
+
+from .compatibility import makedirs, builtins
no_default = '_... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-2513@144fd86 | deepset-ai/haystack | Python | 2,513 | Make `DeepsetCloudDocumentStore` work with non-existing index | **Proposed changes**:
This PR makes the `DeepsetCloudDocumentStore` work with a non-existing index. Non-existing index refers to either `None` (no index specified), or an index/pipeline that is not deployed on deepset Cloud.
**Status (please check what you already did)**:
- [x] First draft (up for discussions & fe... | 2022-05-06T11:57:52Z | Make `DeepsetCloudDocumentStore` work with non-existing index
We want to allow users to connect to the DC docstore without having to create a pipeline first. This will enable the worflow to create a pipeline from scratch using the DC SDK.
Implementation:
- Set default index value to `None`
- Make sure `info()`... | [
{
"body": "We want to allow users to connect to the DC docstore without having to create a pipeline first. This will enable the worflow to create a pipeline from scratch using the DC SDK. \r\n\r\nImplementation: \r\n - Set default index value to `None`\r\n - Make sure `info()` call does not raise an exception i... | 1ed407cb5a20aae122e79f06cec522fbe0b9f30b | {
"head_commit": "144fd86b8f8cd3676dd93478d5c155c0a029232b",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md\nindex b816bd78f0..2cd829adc2 100644\n--- a/docs/_src/api/api/document_store.md\n+++ b... | [
{
"diff_hunk": "@@ -61,12 +62,32 @@ def __init__(\n self.client = DeepsetCloud.get_index_client(\n api_key=api_key, api_endpoint=api_endpoint, workspace=workspace, index=index\n )\n+ # Check if index exists\n+ pipeline_client = DeepsetCloud.get_pipeline_client(\n+ ... | a50d5daba58c8fe7898ca8db14101e0136bbef8a | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index b816bd78f0..652eec9d83 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -4014,31 +4014,43 @@ class DeepsetCloudDocumentStore(KeywordDocumentStore)
#### \_\_init\_\_
```python
-de... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
dask__dask-3410@d87d9e2 | dask/dask | Python | 3,410 | Support `traverse` keyword in persist/optimize | Adds support for `traverse` keyword to `persist`/`optimize`, and changes how this is implemented for `compute`.
The general gist is that we wrap all collection transforms in `unpack`/`repack` calls. The pattern is:
```
collections, repack = unpack(*args) # extract all collections from arguments
results = trans... | 2018-04-16T19:06:09Z | Progressbar on list of delayed objects
I have a list of delayed objects in "scores". Following the documentation, I should be able to do
```
from dask import compute, persist
from dask.distributed import progress
...
x = persist(scores) # start computation in the background
progress(x) # watch progress
score... | Perhaps they are already in memory? If you call x[0].compute() does it
return immediately?
On Fri, Apr 13, 2018 at 12:57 PM, Alvaro Ulloa <notifications@github.com>
wrote:
> I have a list of delayed objects in "scores". Following the documentation,
> I should be able to do
>
> from dask import compute, persist
> fro... | [
{
"body": "I have a list of delayed objects in \"scores\". Following the documentation, I should be able to do \r\n```\r\nfrom dask import compute, persist\r\nfrom dask.distributed import progress\r\n...\r\nx = persist(scores) # start computation in the background\r\nprogress(x) # watch progress\r\nscores = c... | 6fffd1957d281d457d005ecc5f0a15527436f5e8 | {
"head_commit": "d87d9e24196d66d643016eda4c8739f37e917122",
"head_commit_message": "Add traverse keyword to optimize\n\nAlso support task literals in both graph and results",
"patch_to_review": "diff --git a/dask/base.py b/dask/base.py\nindex e129fadfe07..015c9caabff 100644\n--- a/dask/base.py\n+++ b/dask/base.p... | [
{
"diff_hunk": "@@ -342,6 +342,51 @@ def __dask_graph__(self):\n assert not is_dask_collection(DummyCollection)\n \n \n+def test_unpack_collections():\n+ a = delayed(1) + 5\n+ b = a + 1\n+ c = a + 2\n+\n+ def build(a, b, c, iterator):\n+ return (a, b, # Top-level collections... | cef35b01a5e4941ed96e7af147a63328c6d55926 | diff --git a/dask/base.py b/dask/base.py
index e129fadfe07..015c9caabff 100644
--- a/dask/base.py
+++ b/dask/base.py
@@ -4,6 +4,7 @@
from collections import OrderedDict, Iterator
from functools import partial
from hashlib import md5
+from operator import getitem
import inspect
import pickle
import os
@@ -16,7 +17... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
dask__dask-3744@d3d5bf9 | dask/dask | Python | 3,744 | Change doctests to Python 3 #3690 | This fixes #3690
Modified travis.yml and documentation accordingly.
Modified some doctests in order to run with Python 3.6 (mainly sets, bytes, unicode, etc)
- [x] Tests added / passed
- [x] Passes `flake8 dask`
| 2018-07-10T21:06:30Z | Change doctests to Python 3
Subtle differences between Python 2 and 3 mean that it is inconvenient to test doctests in both versions. Today our CI systems only run doctests in Python 2. This policy was made several years ago, when Python 2 was more common.
It would be nice to switch our CI to test docstrings in ... | [
{
"body": "Subtle differences between Python 2 and 3 mean that it is inconvenient to test doctests in both versions. Today our CI systems only run doctests in Python 2. This policy was made several years ago, when Python 2 was more common. \r\n\r\nIt would be nice to switch our CI to test docstrings in Pytho... | a2d58c011233c8c7abc45b9ed1919f4678e884d6 | {
"head_commit": "d3d5bf9af499c6c3cf918adea8142a35465a0fa7",
"head_commit_message": "Modified doctests in order to run with Python 3.6 #3690",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex fca0b8dc03f..15cd1e5eaf9 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -20,7 +20,7 @@ jobs:\n - ... | [
{
"diff_hunk": "@@ -364,11 +364,15 @@ def _slice_1d(dim_shape, lengths, index):\n \n And negative slicing\n \n- >>> _slice_1d(100, [20, 20, 20, 20, 20], slice(100, 0, -3))\n- {0: slice(-2, -20, -3), 1: slice(-1, -21, -3), 2: slice(-3, -21, -3), 3: slice(-2, -21, -3), 4: slice(-1, -21, -3)}\n+ >>> e... | 9e0c054454f7f33618a50724b66dbe19a6f7c3ee | diff --git a/.travis.yml b/.travis.yml
index fca0b8dc03f..15cd1e5eaf9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -20,7 +20,7 @@ jobs:
- NUMPY=1.14.1
- PANDAS=0.22.0
- *test_and_lint
- - *coverage
+ - *no_coverage
- *no_optimize
- *no_imports
@@ -57,7 +57,7 @@ jobs:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
encode__httpx-161@3823c01 | encode/httpx | Python | 161 | Update IDNA encoding to 2008 spec | Resolves #150 and adds tests based on deviations from 2003 spec: https://unicode.org/reports/tr46/#Deviations
This also enables Unicode® Technical Standard #46 to normalize capital letters and such, and a test based on the example given in the [module documentation](https://github.com/kjd/idna#compatibility-mapping-... | 2019-07-27T23:07:27Z | Use IDNA 2008 instead of IDNA 2003
Using `str.encode("idna")` uses IDNA 2003 which isn't recommended for modern use. We should be using IDNA 2008 provided by the `idna` module (which is a dependency of `httpx` but I don't think we're using it anywhere?) | [
{
"body": "Using `str.encode(\"idna\")` uses IDNA 2003 which isn't recommended for modern use. We should be using IDNA 2008 provided by the `idna` module (which is a dependency of `httpx` but I don't think we're using it anywhere?)",
"number": 150,
"title": "Use IDNA 2008 instead of IDNA 2003"
}
] | 66754ad0c58d61d34489294530351aa4b17e217f | {
"head_commit": "3823c012df0bd91180f80398c548f86ed42fc4d3",
"head_commit_message": "Add test for IRI object",
"patch_to_review": "diff --git a/httpx/models.py b/httpx/models.py\nindex 2f29be5f9f..c8634a5807 100644\n--- a/httpx/models.py\n+++ b/httpx/models.py\n@@ -87,17 +87,14 @@ def __init__(\n ) -> None:\n... | [
{
"diff_hunk": "@@ -87,17 +87,14 @@ def __init__(\n ) -> None:\n if isinstance(url, rfc3986.uri.URIReference):\n self.components = url\n+ elif isinstance(url, rfc3986.iri.IRIReference):",
"line": null,
"original_line": 90,
"original_start_line": null,
"path": "http... | 9bd13f121172e8aeac00a4939c71e6f2fb1a1a62 | diff --git a/httpx/models.py b/httpx/models.py
index df5d071589..32e412fc76 100644
--- a/httpx/models.py
+++ b/httpx/models.py
@@ -89,16 +89,10 @@ def __init__(
params: QueryParamTypes = None,
) -> None:
if isinstance(url, str):
- self._uri_reference = rfc3986.api.uri_reference(url)
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
dask__dask-3088@8a001b8 | dask/dask | Python | 3,088 | Allow the CI dev build to fail | Closes https://github.com/dask/dask/issues/3043
Partially addresses https://github.com/dask/dask/issues/2744
As dev libraries tend to breaking things rather frequently, simply mark this build as an allowed failure. This doesn't mean that we don't care about fixing issues with dev libraries. Simply that we don't exp... | 2018-01-21T22:42:26Z | Allow failures in development tests
Currently one of the travis-ci configurations tests against master versions of NumPy, Pandas, and other libraries. This has caused Dask testing builds to fail a couple of times recently. Do we want to consider changing our travis-ci settings to allow this testing configuration to f... | I would prefer leaving it as for now (now that https://github.com/dask/dask/issues/3039 is fixed)
When something upstream does break dask, a maintainer could quickly make an issue calling attention to it and a PR [allowing failures](https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail... | [
{
"body": "Currently one of the travis-ci configurations tests against master versions of NumPy, Pandas, and other libraries. This has caused Dask testing builds to fail a couple of times recently. Do we want to consider changing our travis-ci settings to allow this testing configuration to fail short term?",... | 071225f9acb8c5657e1ce85f91b770272b6e39ce | {
"head_commit": "8a001b8df70ef3e043a9e4132e79a5eeda360f2a",
"head_commit_message": "Use newest NumPy and Pandas with Python 3.6\n\nMake sure to use the newest stable releases of NumPy and Pandas in the\nPython 3.6 build. That way we get the most benefit out of it.",
"patch_to_review": "diff --git a/.travis.yml b... | [
{
"diff_hunk": "@@ -47,20 +47,29 @@ jobs:\n - *no_optimize\n - *no_imports\n \n- - env: &py36_env\n+ - env:\n - PYTHON=3.6\n+ - NUMPY=1.14.0\n+ - PANDAS=0.22.0\n+ - *no_coverage\n+ - *no_optimize\n+ - *imports\n+\n+ - env: &py36_dev\n - UPSTREAM_DEV=1 #... | 754fa3442d4f275970bb8fe87522510dc9eacdfe | diff --git a/.travis.yml b/.travis.yml
index 3f664f818bf..411066f405d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -54,6 +54,15 @@ jobs:
- env: &py36_env
- PYTHON=3.6
+ - NUMPY=1.14.0
+ - PANDAS=0.22.0
+ - *test_and_lint
+ - COVERAGE='false'
+ - PARALLEL='false'
+ - *no_opti... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
dask__dask-2464@249836d | dask/dask | Python | 2,464 | Catch and raise type errors on meta reductions | Attempt to fix #2452
Not really sure about the approach, it feels like there just isn't an elegant way to solve this properly. | 2017-06-16T09:45:30Z | Failing to specify numeric columns fails with "could not convert foofoo to numeric"
A minor suggestion to improve error messages: The following code fails, because the meta data does not specify that column `A` is numeric. However, the error message is somewhat non-intuitive:
```python
import pandas as pd
import d... | I agree that this would be a good change. Can I interest you in submitting a small PR? ("no" is a fine answer)
In general yes, but I don't know when I will get to it.
On first glance: Solving it for `df.mean()` only is trivial, but identifying + solving the issue for all affected operations requires a bit more tho... | [
{
"body": "A minor suggestion to improve error messages: The following code fails, because the meta data does not specify that column `A` is numeric. However, the error message is somewhat non-intuitive:\r\n\r\n```python\r\nimport pandas as pd\r\nimport dask.dataframe as dd\r\nfrom dask import delayed\r\n\r\ndf... | ecdae84aa3b8ee5408876b0b7d7eade3d127e177 | {
"head_commit": "249836d771fa97d8d8e7655b9c83bd5697a3e334",
"head_commit_message": "switched to upfront raise",
"patch_to_review": "diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py\nindex 5f0be93456c..9895b94a3c1 100644\n--- a/dask/dataframe/core.py\n+++ b/dask/dataframe/core.py\n@@ -5,6 +5,7 @@\n im... | [
{
"diff_hunk": "@@ -2632,3 +2632,14 @@ def test_boundary_slice_same(index, left, right):\n df = pd.DataFrame({\"A\": range(len(index))}, index=index)\n result = boundary_slice(df, left, right)\n tm.assert_frame_equal(result, df)\n+\n+\n+def test_meaningful_error_on_wrong_meta():",
"line": null,
... | 817b7e298ada2463b03878d557103d32422423c0 | diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py
index 5f0be93456c..a7e929e3bcc 100644
--- a/dask/dataframe/core.py
+++ b/dask/dataframe/core.py
@@ -1079,6 +1079,7 @@ def _reduction_agg(self, name, axis=None, skipna=True,
@derived_from(pd.DataFrame)
def abs(self):
+ _raise_if_object_serie... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dask__dask-1927@7eb0eba | dask/dask | Python | 1,927 | Add persist function | This is an initial step to resolve #1908
This copies over some code from dask/distributed to implement a persist function that uses a get function to compute results and re-insert those results back into a Dask collection with the same keys.
Short term I'm likely to take this only as far as I need to accomplish ... | 2017-01-22T18:15:27Z | Add persist function
The distributed scheduler makes heavy use of `persist`, which creates a new dask collection with a collection that points to more evaluated data.
It might be convenient to add this verb to dask generally.
```python
df = dd.read_csv(...) # lazy loading
df = dask.persist(df) # df is dask.... | I like the idea. It may be nice to also support a general mutable-mapping to persist to, to allow for spilling to disk. I could see a few options for how to do this:
- Set persist mapping globally using `set_options`
- Pass a mapping to the persist call `persist(collection, cache=cache)`
The graph returned from ... | [
{
"body": "The distributed scheduler makes heavy use of `persist`, which creates a new dask collection with a collection that points to more evaluated data. \r\n\r\nIt might be convenient to add this verb to dask generally.\r\n\r\n```python\r\ndf = dd.read_csv(...) # lazy loading\r\ndf = dask.persist(df) # d... | 5868c5a80bf02596a8cea1da4141ecc01287cdd6 | {
"head_commit": "7eb0eba5edbd95823315019d87e252eb355e9e31",
"head_commit_message": "flake8",
"patch_to_review": "diff --git a/dask/__init__.py b/dask/__init__.py\nindex f5f266a6883..5da166f83dd 100644\n--- a/dask/__init__.py\n+++ b/dask/__init__.py\n@@ -8,7 +8,7 @@\n except ImportError:\n pass\n try:\n- f... | [
{
"diff_hunk": "@@ -383,3 +387,151 @@ def tokenize(*args, **kwargs):\n if kwargs:\n args = args + (kwargs,)\n return md5(str(tuple(map(normalize_token, args))).encode()).hexdigest()\n+\n+\n+def collections_to_dsk(collections, optimize_graph=True, **kwargs):\n+ \"\"\"\n+ Convert many collec... | 8b8ff8ad791677bdc9db30e7f337636df240114f | diff --git a/dask/__init__.py b/dask/__init__.py
index f5f266a6883..5da166f83dd 100644
--- a/dask/__init__.py
+++ b/dask/__init__.py
@@ -8,7 +8,7 @@
except ImportError:
pass
try:
- from .base import visualize, compute
+ from .base import visualize, compute, persist
except ImportError:
pass
diff --g... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-2345@10eff9c | deepset-ai/haystack | Python | 2,345 | EvaluationSetClient for deepset cloud to fetch evaluation sets and la… | …bels for one specific evaluation set
**Proposed changes**:
This PR adds a EvaluationSetClient class, that will handle the communication with deepset cloud, to allow the fetching of labels of an evaluation set uploaded to deepset cloud.
New functionality:
* list all labels for a given index name
* fetch the numb... | 2022-03-22T14:22:54Z | Allow DCDocumentStore to read labels
In order to communicate with DocumentStores in DC we need a readonly DocumentStore implementation that is compatible with all retrievers incl. `ElasticsearchRetriever`.
Here we want to make it support getting all labels.
The following methods need to be implemented:
| method ... | [
{
"body": "In order to communicate with DocumentStores in DC we need a readonly DocumentStore implementation that is compatible with all retrievers incl. `ElasticsearchRetriever`.\r\n\r\nHere we want to make it support getting all labels.\r\n\r\nThe following methods need to be implemented:\r\n| method | API Ca... | a73717b2eab91abbc2e38cf2d5b39855fe5e19f8 | {
"head_commit": "10eff9cb88f7ae4eafa3f1f454144761678ec95e",
"head_commit_message": "DeepsetCloudDocumentStore - update docstrings for EvaluationSetClient",
"patch_to_review": "diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md\nindex b369d6f320..a8bf39dc98 100644\n--- a/docs/_... | [
{
"diff_hunk": "@@ -700,9 +700,9 @@ def get_labels_count(self, evaluation_set: Optional[str] = None, workspace: Opti\n \"\"\"\n Counts labels for a given evaluation set in deepset cloud.\n \n- :param evaluation_set: Optional index in Deepset Cloud\n- If None, th... | 709ac213d5f5bc551b6eb2e11567abada72b87ca | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index b369d6f320..265bf82798 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -3938,7 +3938,7 @@ class DeepsetCloudDocumentStore(KeywordDocumentStore)
#### \_\_init\_\_
```python
-def ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
dbt-labs__dbt-core-9986@c2889e3 | dbt-labs/dbt-core | Python | 9,986 | Add more package validation | resolves #9985
### Problem
dbt hangs when packages have empty values. This is generally not intentional but the result of empty env-vars.
### Solution
Add validation
### Checklist
- [ ] I have read [the contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md) and understand... | 2024-04-19T14:51:35Z | [Bug] dbt hangs when packages have empty values
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
When a package is defined as
```
packages:
- local: ""
```
... | [
{
"body": "### Is this a new bug in dbt-core?\n\n- [X] I believe this is a new bug in dbt-core\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\n\n### Current Behavior\n\nWhen a package is defined as \r\n\r\n```\r\npackages:\r\n - local: \"\" \r\n```\r\n\r\nRun... | 27943a5ebc1a1487145c835b89296277affe226e | {
"head_commit": "c2889e37ad75d76dd5495996d1e046f48f1d81a3",
"head_commit_message": "Merge branch 'main' of https://github.com/dbt-labs/dbt-core into er/9986-packages-validation",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240422-152244.yaml b/.changes/unreleased/Fixes-20240422-152244.yaml\nnew ... | [
{
"diff_hunk": "@@ -101,13 +101,26 @@ class PackageConfig(dbtClassMixin):\n @classmethod\n def validate(cls, data):\n for package in data.get(\"packages\", data):\n+ # This can happen when the target is a variable that is not filled and results in hangs\n+ if isinstance(pac... | 3cf437e18de8f9d655dd3ed20c425187f79f3895 | diff --git a/.changes/unreleased/Fixes-20240422-152244.yaml b/.changes/unreleased/Fixes-20240422-152244.yaml
new file mode 100644
index 00000000000..869d152fda9
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240422-152244.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Validate against empty strings in package definitions
+t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
certbot__certbot-8131@54d743b | certbot/certbot | Python | 8,131 | Use 3rd party plugins without prefix + set a deprecation path for the prefixed version | Fixes #4351
This PR proposes a solution to use the third party plugins with the prefix `pip_package_name:` in the plugin name, plugin specific flags and keys in dns plugin credential files.
A first solution has been proposed in #6372, and a more advanced one in #7026. In #7026 was also added a deprecation warning... | 2020-07-05T12:52:23Z | 3rd party plugin flags
The name of 3rd party plugins is generated in `certbot/plugins/disco.py`. Currently, all third party plugin names are `<package>:<entry point>`. Because we use the plugin name to prefix the CLI flag name, this generates some really awkward flags `--certbot-foo:bar-baz`. We should do better, but m... | I think we can stop adding the name of the package to the plugin flag and just use the name of the entry point which the plugin author controls. The big thing here is we don't want to break backwards compatibility. The `package_name:entry_point_name` version of the flags still need to work. This affects both adding the... | [
{
"body": "The name of 3rd party plugins is generated in `certbot/plugins/disco.py`. Currently, all third party plugin names are `<package>:<entry point>`. Because we use the plugin name to prefix the CLI flag name, this generates some really awkward flags `--certbot-foo:bar-baz`. We should do better, but make ... | d434b92945f04f84b10fee1048cb45a15d3a36ba | {
"head_commit": "54d743b71ef016726460a0d16de2fd1a9a911b91",
"head_commit_message": "Add a changelog",
"patch_to_review": "diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md\nindex fbd603d92ff..09f58a09889 100644\n--- a/certbot/CHANGELOG.md\n+++ b/certbot/CHANGELOG.md\n@@ -15,6 +15,9 @@ Certbot adheres to [... | [
{
"diff_hunk": "@@ -15,6 +15,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n * Added `--preferred-chain <issuer CN>`. If a CA offers multiple certificate chains,\n it may be used to indicate to Certbot which chain should be preferred.\n * e.g. `--preferred-chain \"DST Root CA X3\"`\n+... | 971c49694cbc7eb021fa5b96f91880114f16a64d | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index c127d83a68b..8124d1e0cd2 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -6,7 +6,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Added
-*
+* Third-party plugins can be used without prefix (`plugin_name` instead o... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
deepset-ai__haystack-2209@ee89c32 | deepset-ai/haystack | Python | 2,209 | YAML versioning | **Proposed changes**:
- Make YAML files get the same version as Haystack when saved with `save_to_yaml()`
- Throw a warning in `load_from_yaml()` in case of mismatch (no error will be thrown)
- Update tests and test pipeline YAMLs to comply
**Status (please check what you already did)**:
- [X] First draft (up f... | 2022-02-17T10:37:55Z | Make version of pipeline config/YAML configurable
**Is your feature request related to a problem? Please describe.**
If we call `pipeline.save_to_yaml()` a YAML is stored having a version attribute that takes the fixed value `0.8`.
If I get the purpose of the version attribute correctly, this should be made configura... | Versioning of the YAML files right now is just a stub.
We also met with this topic in #2020 and informally with @tholor decided to postpone this issue a bit, until we decide which versioning structure we want for the YAML files. There are still some open questions, for example: the YAML version should match Haystac... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIf we call `pipeline.save_to_yaml()` a YAML is stored having a version attribute that takes the fixed value `0.8`.\r\nIf I get the purpose of the version attribute correctly, this should be made configurable as it depicts the versi... | abc1057869d72b7ce654f40f3945dd2a387aa127 | {
"head_commit": "ee89c327455e3b615ccdf7733e5326cc8369be79",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/.github/utils/generate_json_schema.py b/.github/utils/generate_json_schema.py\nindex a15b64e874..9f21b55e30 100644\n--- a/.github/utils/generate_json_schema.py\... | [
{
"diff_hunk": "@@ -1299,6 +1317,12 @@ def load_from_yaml(\n :param address: The IP address for the Ray cluster. If set to None, a local Ray instance is started.\n \"\"\"\n pipeline_config = cls._read_pipeline_config_from_yaml(path)\n+ if pipeline_config[\"version\"] != __version_... | 9cf756b391205addd160976880c3789cfe72b305 | diff --git a/.github/utils/generate_json_schema.py b/.github/utils/generate_json_schema.py
index a15b64e874..9f21b55e30 100644
--- a/.github/utils/generate_json_schema.py
+++ b/.github/utils/generate_json_schema.py
@@ -4,6 +4,7 @@
from pathlib import Path
from typing import Any, Dict, Optional, Set, Tuple
+from hay... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
certbot__certbot-7797@5b29e46 | certbot/certbot | Python | 7,797 | Use UTF-8 encoding for nginx plugin | Based on and supersedes #6725, which was originally based on #5341.
Fixes #5337.
Closes #6725.
## Pull Request Checklist
- [x] If the change being made is to a [distributed component](https://certbot.eff.org/docs/contributing.html#code-components-and-layout), edit the `master` section of `certbot/CHANGELOG.md... | 2020-02-23T17:59:44Z | Nginx plugin crashes when non-ascii configuration file read
## My operating system is (include version):
Arch Linux ARM 4.9.69-1-ARCH
## I installed Certbot with (certbot-auto, OS package manager, pip, etc):
OS package manager (`pacman -S certbot-nginx`)
## I ran this command and it produced this output:
... | And this is how I fixed the issue: https://github.com/g6123/certbot/commit/e74505968ba24a364a5be70ef86bbe20620d17db#diff-b2dab7e6fe39d3a1bf642d561d045633.
This looks to be essentially a duplicate of #5236
The parent issue for all of these UTF-8 problems is #4516
I think we'd be happy to take a PR of the changes you m... | [
{
"body": "## My operating system is (include version):\r\n\r\nArch Linux ARM 4.9.69-1-ARCH\r\n\r\n## I installed Certbot with (certbot-auto, OS package manager, pip, etc):\r\n\r\nOS package manager (`pacman -S certbot-nginx`)\r\n\r\n## I ran this command and it produced this output:\r\n\r\nI ran this command:\... | 809cb516c918575bc1688141dfe9b4da001d6570 | {
"head_commit": "5b29e4616c4a7bae3ba18b0eca8ae245afbf97f1",
"head_commit_message": "Add simple comments",
"patch_to_review": "diff --git a/AUTHORS.md b/AUTHORS.md\nindex 80a24d3be94..8653382b8ed 100644\n--- a/AUTHORS.md\n+++ b/AUTHORS.md\n@@ -268,3 +268,4 @@ Authors\n * [YourDaddyIsHere](https://github.com/YourD... | [
{
"diff_hunk": "@@ -268,3 +268,4 @@ Authors\n * [YourDaddyIsHere](https://github.com/YourDaddyIsHere)\n * [Zach Shepherd](https://github.com/zjs)\n * [陈三](https://github.com/chenxsan)\n+* [Yuseong Cho](https://github.com/g6123)",
"line": null,
"original_line": 271,
"original_start_line": null,
"... | c6d35549d6ff62bee7305b1752cd48c78ccc408f | diff --git a/AUTHORS.md b/AUTHORS.md
index 80a24d3be94..f5b981b8eaa 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -266,5 +266,6 @@ Authors
* [Yomna](https://github.com/ynasser)
* [Yoni Jah](https://github.com/yonjah)
* [YourDaddyIsHere](https://github.com/YourDaddyIsHere)
+* [Yuseong Cho](https://github.com/g6123)
* ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-2385@202d7a6 | deepset-ai/haystack | Python | 2,385 | Change YAML version exception into a warning | **Problem**:
- The YAML version check was way too strict and raised exceptions continuously for no good reason.
**Solution**
- Change the version check so that it will raise a warning instead of an exception. As a consequence, we could:
- Remove the complex backward compatibility check
- Make one schema for... | 2022-04-01T16:53:01Z | Version check is too restrictive
**Describe the bug**
Currently when trying to load a saved pipeline YAML in older or newer versions of haystack it fails because the version is incompatible (i.e. a schema change occured). In most cases the YAML would be perfectly fine if just the version had been updated. From a usage... | [
{
"body": "**Describe the bug**\r\nCurrently when trying to load a saved pipeline YAML in older or newer versions of haystack it fails because the version is incompatible (i.e. a schema change occured). In most cases the YAML would be perfectly fine if just the version had been updated. From a usage point of vi... | ba9c976bfe93a48a6ad3c3414566b1696309f3c2 | {
"head_commit": "202d7a62789034f1e122ed4d94d7530984740e47",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/.github/utils/generate_json_schema.py b/.github/utils/generate_json_schema.py\nindex 3ecc311cd4..023a16a309 100644\n--- a/.github/utils/generate_json_schema.py\... | [
{
"diff_hunk": "@@ -1,5 +1,5 @@\n # Dummy pipeline, used when the CI needs to load the REST API to extract the OpenAPI specs. DO NOT USE.\n-version: 'unstable'\n+version: 'master'",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "rest_api/pipeline/pipeline_empty.haystack-... | dd274fbd94c82780aa74a2eeef9805f018e4285c | diff --git a/.github/utils/generate_json_schema.py b/.github/utils/generate_json_schema.py
index 3ecc311cd4..023a16a309 100644
--- a/.github/utils/generate_json_schema.py
+++ b/.github/utils/generate_json_schema.py
@@ -8,6 +8,4 @@
sys.path.append(".")
from haystack.nodes._json_schema import update_json_schema
-upda... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-2214@4f63666 | deepset-ai/haystack | Python | 2,214 | Generate code from pipeline (pipeline.to_code()) | **Proposed changes**:
- add methods `to_code()` and `to_notebook_cell()` to `Pipeline`
- `to_code()` returns the code as string
- `to_notebook_cell` creates a new cell containing the code
- param `pipeline_variable_name` controls the name of the pipeline variable to be generated
- param `generate_imports` control... | 2022-02-17T15:20:03Z | pipeline.to_code()
**What?**
As a user I want to be able to manipulate a pipeline besides isomorphic changes that are already possible through `pipeline.set_node()`.
**How?**
To add, change or delete one or multiple nodes of a pipeline other parts of the pipeline will be affected (e.g. different input, output). So... | [
{
"body": "**What?**\r\nAs a user I want to be able to manipulate a pipeline besides isomorphic changes that are already possible through `pipeline.set_node()`.\r\n\r\n**How?**\r\nTo add, change or delete one or multiple nodes of a pipeline other parts of the pipeline will be affected (e.g. different input, out... | 4bad21e9617b470cbd34860f2713a8ccbfd173f6 | {
"head_commit": "4f63666957f21514ac2f2bf8e9dc18b43bd8739a",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/docs/_src/api/api/pipelines.md b/docs/_src/api/api/pipelines.md\nindex b68750be81..48bbb7eda8 100644\n--- a/docs/_src/api/api/pipelines.md\n+++ b/docs/_src/api/... | [
{
"diff_hunk": "@@ -335,7 +389,7 @@ def save_to_deepset_cloud(\n logger.info(f\"Pipeline config '{pipeline_config_name}' successfully created.\")\n \n @classmethod\n- def _get_pipeline_definition(cls, pipeline_config: Dict, pipeline_name: Optional[str] = None):\n+ def _get_pipeline_definit... | 215206070cb913bdfbba7916216030a975388641 | diff --git a/docs/_src/api/api/pipelines.md b/docs/_src/api/api/pipelines.md
index 7d68b13ed9..0c1c0eab2b 100644
--- a/docs/_src/api/api/pipelines.md
+++ b/docs/_src/api/api/pipelines.md
@@ -37,6 +37,44 @@ Returns a configuration for the Pipeline that can be used with `BasePipeline.loa
- `return_defaults`: whether t... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-1978@165ef8d | deepset-ai/haystack | Python | 1,978 | Add models to demo docker image | Introduces a small utility to download and cache the demo's model and NLTK data, then modifies Dockerimage and Dockerimage-GPU to call this function at build time.
This will provide users with a demo that does not need to download any model at its first run, making the demo installation process easier and a bit fast... | 2022-01-10T11:40:05Z | Add model to demo docker image
When running our "quick start" via docker-compose, the API container directly triggers a download of the roberta reader model. Depending on your internet connection this might take a while. How about we add a docker image with the tag `demo_latest` that includes the roberta model and ther... | [
{
"body": "When running our \"quick start\" via docker-compose, the API container directly triggers a download of the roberta reader model. Depending on your internet connection this might take a while. How about we add a docker image with the tag `demo_latest` that includes the roberta model and therefore does... | 00dc30ae547bd4a55e035e51cd0bfe50f2e5b47d | {
"head_commit": "165ef8d862ebcbed058d65387b530fd449a14e04",
"head_commit_message": "Add utility to cache models and nltk data & modify Dockerfiles to use it",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex d4fab69233..79cca32c11 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -20,9 +20,7 @@ COPY ... | [
{
"diff_hunk": "@@ -0,0 +1,15 @@\n+\n+def cache_models():\n+ \"\"\"\n+ Small function that caches models and other data.\n+ Used only in the Dockerfile to include these caches in the images.\n+ \"\"\"\n+ # download punkt tokenizer\n+ import nltk\n+ nltk.download('punkt', download_dir='/usr/... | 794dc841028fc667689a9f35861e49e30a467549 | diff --git a/Dockerfile b/Dockerfile
index d4fab69233..f3e2a3fddb 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -18,11 +18,10 @@ COPY haystack /home/user/haystack
# install as a package
COPY setup.py requirements.txt README.md /home/user/
+RUN pip install --upgrade pip
RUN pip install -r requirements.txt
RUN pip in... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-2101@48ccc6f | deepset-ai/haystack | Python | 2,101 | Make FileTypeClassifier more flexible | This PR proposes an enhancement of `FileTypeClassifier` to make it accept more extensions rather than the 5 hardcoded ones.
Closes #1977
| 2022-02-02T09:20:51Z | Using Tika Converter
**Question**
How can I run haystack docker container with default file converter as tika?
**Additional context**
And also built in tika converter can convert and process ppt files? If no how can I add tika ppt converter to haystack? To process also from ppt files. | Hi @arater!
To your first question: As the `TikaConverter` implemented in haystack supports all data formats compatible with Tika (you can find them [here](https://tika.apache.org/2.2.1/formats.html)), using it with a `.ppt` file shouldn't be a problem.
To your second question: To load a file using `TikaConverter`,... | [
{
"body": "**Question**\r\nHow can I run haystack docker container with default file converter as tika?\r\n\r\n**Additional context**\r\nAnd also built in tika converter can convert and process ppt files? If no how can I add tika ppt converter to haystack? To process also from ppt files.\r\n\r\n",
"number":... | 649d07405770cd59696d0120107a3b2f0aafe7c2 | {
"head_commit": "48ccc6f8e9a257829e24a0064f867b9cbc51e325",
"head_commit_message": "Fix mypy",
"patch_to_review": "diff --git a/haystack/nodes/file_classifier/file_type.py b/haystack/nodes/file_classifier/file_type.py\nindex 306c5d12f2..1a1c4349d4 100644\n--- a/haystack/nodes/file_classifier/file_type.py\n+++ b/... | [
{
"diff_hunk": "@@ -1,40 +1,72 @@\n+from multiprocessing.sharedctypes import Value\n from typing import List, Union\n from pathlib import Path\n from haystack.nodes.base import BaseComponent\n \n \n+DEFAULT_TYPES = [\"txt\", \"pdf\", \"md\", \"docx\", \"html\"]\n+\n+\n class FileTypeClassifier(BaseComponent):\n... | a3b444a511c48dd7e0db9bafe74cd55c0895556f | diff --git a/haystack/nodes/file_classifier/file_type.py b/haystack/nodes/file_classifier/file_type.py
index 306c5d12f2..ec6fd171d7 100644
--- a/haystack/nodes/file_classifier/file_type.py
+++ b/haystack/nodes/file_classifier/file_type.py
@@ -1,40 +1,72 @@
+from multiprocessing.sharedctypes import Value
from typing im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1937@a6b1c9e | deepset-ai/haystack | Python | 1,937 | Fix loading a saved `FAISSDocumentStore` | Loading a saved `FAISSDocumentStore` resulted in the following error:
`TypeError: Object of type IndexFlat is not JSON serializable`
To fix this, I removed the `faiss_index` parameter from the config, as this cannot be serialized.
Closes #1932 | 2021-12-30T12:51:08Z | TypeError: Object of type IndexFlat is not JSON serializable
**Describe the bug**
Index fail to be saved after retrieval training and embedding update, getting `TypeError: Object of type IndexFlat is not JSON serializable`. This also corrupt the existing index json configuration file which is more severe in case not b... | Hi @AlonEirew! Thanks for raising this issue. The problem was not about training of the retriever, but rather saving a loaded `FAISSDocumentStore`. This should be fixed once #1937 is merged.
Hi @bogdankostic did you have a look at https://github.com/deepset-ai/haystack/issues/1842 while working on this? | [
{
"body": "**Describe the bug**\r\nIndex fail to be saved after retrieval training and embedding update, getting `TypeError: Object of type IndexFlat is not JSON serializable`. This also corrupt the existing index json configuration file which is more severe in case not backed-up.\r\nBehaviour is same also if l... | 39573cf0a94b00464cb2b9f063b574fb0c50de2c | {
"head_commit": "a6b1c9e7538da30316ef1dc1603c6b2a91092f88",
"head_commit_message": "Add Tests",
"patch_to_review": "diff --git a/haystack/document_stores/faiss.py b/haystack/document_stores/faiss.py\nindex 7d77f7614b..c375f0aeb2 100644\n--- a/haystack/document_stores/faiss.py\n+++ b/haystack/document_stores/fais... | [
{
"diff_hunk": "@@ -90,6 +94,10 @@ def test_faiss_index_save_and_load_custom_path(tmp_path):\n # Check if the init parameters are kept\n assert not new_document_store.progress_bar\n \n+ # test saving and loading the loaded faiss index\n+ new_document_store.save(tmp_path / \"haystack_test_faiss\", ... | 9b6653c325a9790f9a9015b3ef4ddba43e61b6c7 | diff --git a/haystack/document_stores/faiss.py b/haystack/document_stores/faiss.py
index 7d77f7614b..c375f0aeb2 100644
--- a/haystack/document_stores/faiss.py
+++ b/haystack/document_stores/faiss.py
@@ -106,7 +106,6 @@ def __init__(
sql_url=sql_url,
vector_dim=vector_dim,
faiss_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-2159@6869c5c | deepset-ai/haystack | Python | 2,159 | Add `DELETE /feedback` for testing and make the label's id generate server-side | Closes #1825 and adds a `DELETE /feedback` endpoint to the REST API for testing purposes.
| 2022-02-10T12:16:58Z | Create ID of the feedback labels server side
In the current REST API, the `POST /feedback` endpoint expects the request to contain the ID of the Label to create.
It should be instead the server responsibility to create these labels, and indeed the `Label` constructor does not require the ID at construction time. How... | [
{
"body": "In the current REST API, the `POST /feedback` endpoint expects the request to contain the ID of the Label to create.\r\n\r\nIt should be instead the server responsibility to create these labels, and indeed the `Label` constructor does not require the ID at construction time. However, immediate soluti... | fdc36292f1013c560d2b4006cffc325ba5324832 | {
"head_commit": "6869c5cb9bb21bca75941e27fbb6742abc2e2836",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/docs/_src/api/openapi/openapi.json b/docs/_src/api/openapi/openapi.json\nindex b8ab396b15..b093e3e545 100644\n--- a/docs/_src/api/openapi/openapi.json\n+++ b/do... | [
{
"diff_hunk": "@@ -39,6 +42,16 @@ def get_feedback():\n return labels\n \n \n+@router.delete(\"/feedback\")\n+def delete_feedback():\n+ \"\"\"\n+ This endpoint allows the API user to delete all the\n+ feedback that has been sumbitted through the\n+ `POST /feedback` endpoint\n+ \"\"\"\n+ D... | b832c805db022826d7a40c95189d80dc9715ab66 | diff --git a/docs/_src/api/openapi/openapi.json b/docs/_src/api/openapi/openapi.json
index d975f9e5ec..bba347894f 100644
--- a/docs/_src/api/openapi/openapi.json
+++ b/docs/_src/api/openapi/openapi.json
@@ -117,7 +117,15 @@
"content": {
"application/json": {
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-1976@8f7a848 | deepset-ai/haystack | Python | 1,976 | Set provider parameter when instantiating onnxruntime.InferenceSession | fixes #1973
**Proposed changes**:
* Sets a default CUDAExecutionProvider or CPUExecutionProvider provider depending on the device type passed in, if no provider is specified.
* Optionally allow passing in of a custom provider list
* The providers parameter exists in earlier versions of the `onnxruntime.InferenceS... | 2022-01-07T17:30:48Z | Provider parameter needs to be set when instantiating InferenceSession in ONNXAdaptiveModel
**Describe the bug**
More recent versions of Onnx require the provider parameter to be explicitly set when creating a `onnxruntime.InferenceSession`, which results in errors currently when loading an `ONNXAdaptiveModel`.
*... | Hi @cjb06776 thanks for pointing out that issue and for suggesting a fix already. We'd really appreciate it if you could create a PR, yes please. 👍 Would these changes be backwards compatible in the sense that users with an older ONXX version could also work with the changed code? Could you please check that in your P... | [
{
"body": "**Describe the bug**\r\nMore recent versions of Onnx require the provider parameter to be explicitly set when creating a `onnxruntime.InferenceSession`, which results in errors currently when loading an `ONNXAdaptiveModel`.\r\n\r\n\r\n**Error message**\r\n```\r\n File \"/usr/local/lib/python3.6/dist... | b8a3c930f01f26239897582dc9606a594b4d1735 | {
"head_commit": "8f7a8483a59042e587b045093ed6c0adb5ff7216",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/docs/_src/api/api/ranker.md b/docs/_src/api/api/ranker.md\nindex 6e7db33cdc..e9de4491b3 100644\n--- a/docs/_src/api/api/ranker.md\n+++ b/docs/_src/api/api/ranke... | [
{
"diff_hunk": "@@ -209,10 +210,10 @@ def augment(\n \n \n def augment_squad(\n+ model: str,\n+ tokenizer: str,\n squad_path: Path,\n output_path: Path,\n- model: str = \"bert-base-uncased\",",
"line": 214,
"original_line": 214,
"original_start_line": null,
"path": "haystack/uti... | c9b55e31e63f96c11c2edc1501d2fccd83fbfcb1 | diff --git a/docs/_src/api/api/ranker.md b/docs/_src/api/api/ranker.md
index 6e7db33cdc..e9de4491b3 100644
--- a/docs/_src/api/api/ranker.md
+++ b/docs/_src/api/api/ranker.md
@@ -92,7 +92,7 @@ p.add_node(component=ranker, name="Ranker", inputs=["ESRetriever"])
#### \_\_init\_\_
```python
-def __init__(model_name_or... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
certbot__certbot-7270@65f464e | certbot/certbot | Python | 7,270 | Fix unit tests on Windows | Fixes #6850
This PR makes the last corrections needed to run all unit tests on Windows:
* add a function to check if a hook is executable in a cross-platform compatible way
* handle correctly the PATH surgery for Windows during hook execution
* handle correctly an account compatibility over both ACMEv1 and ACMEv2... | 2019-07-26T09:10:24Z | Fix remaining broken tests on Windows
When I started to port Certbot on Windows, a lot of unit tests or the logic tested by them were not working on this platform.
In order to still have a working CI during the port, all failing tests where marked with a temporary decorator, `@broken_on_windows` to skip their execut... | Once mentioned PRs above are merged, plus logic from #6497 and #6859, all unit tests will be compatible with Windows, or skipped for a good reason.
The last pieces of this are (at least partially) blocked on landing #6895. | [
{
"body": "When I started to port Certbot on Windows, a lot of unit tests or the logic tested by them were not working on this platform.\r\n\r\nIn order to still have a working CI during the port, all failing tests where marked with a temporary decorator, `@broken_on_windows` to skip their execution. At this ti... | e6bf3fe7f81ff7651b3e8be3d530be725090ed2c | {
"head_commit": "65f464efeb4be98b1bf1870d3946e4c0769b4776",
"head_commit_message": "Adapt coverage",
"patch_to_review": "diff --git a/.codecov.yml b/.codecov.yml\nindex f4d4d1d6c19..8a1503da885 100644\n--- a/.codecov.yml\n+++ b/.codecov.yml\n@@ -13,6 +13,6 @@ coverage:\n flags: windows\n # Fixed ... | [
{
"diff_hunk": "@@ -52,26 +53,26 @@ def _call(cls, exe):\n from certbot.util import exe_exists\n return exe_exists(exe)\n \n- @mock.patch(\"certbot.util.os.path.isfile\")\n- @mock.patch(\"certbot.util.os.access\")\n- def test_full_path(self, mock_access, mock_isfile):\n- mock_acc... | f56bcc763fb3129d68baaa329e179eb421cc73d2 | diff --git a/.codecov.yml b/.codecov.yml
index f4d4d1d6c19..8a1503da885 100644
--- a/.codecov.yml
+++ b/.codecov.yml
@@ -13,6 +13,6 @@ coverage:
flags: windows
# Fixed target instead of auto set by #7173, can
# be removed when flags in Codecov are added back.
- target: 97.2
+ ta... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
dbt-labs__dbt-core-9803@f647105 | dbt-labs/dbt-core | Python | 9,803 | update triggers to use issues for opening docs issues | resolves https://github.com/dbt-labs/actions/issues/162
### Problem
PRs have to get labeled when we're already labeling the issues. Some PRs never make it to getting docs PRs created.
### Solution
Trigger docs issues to be created when an issue has the `user_docs` label and is closed as completed.
###... | 2024-03-22T17:24:49Z | Create issues in docs.getdbt.com off os issues instead of PRs
### Housekeeping
- [X] I am a maintainer of actions
### Short description
We add the `user docs` label to issues to identify it needs to have a change to docs.getdbt.com. We then have to add them to PRs to get the issues to actually be created. In... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of actions\r\n\r\n### Short description\r\n\r\nWe add the `user docs` label to issues to identify it needs to have a change to docs.getdbt.com. We then have to add them to PRs to get the issues to actually be created. Instead lets just trigger the doc... | b435e26aa42b78f0aee1d9feaa8134535f1f57d5 | {
"head_commit": "f6471058e77ee8d1e1b96825f2b17609d50430f1",
"head_commit_message": "update triggers to use issues",
"patch_to_review": "diff --git a/.github/workflows/docs-issue.yml b/.github/workflows/docs-issue.yml\nindex 00a098df827..f5b04e6d1fa 100644\n--- a/.github/workflows/docs-issue.yml\n+++ b/.github/wo... | [
{
"diff_hunk": "@@ -5,36 +5,34 @@\n # To reduce barriers for keeping docs up to date\n \n # **when?**\n-# When a PR is labeled `user docs` and is merged. Runs on pull_request_target to run off the workflow already merged,\n-# not the workflow that existed on the PR branch. This allows old PRs to get comments.... | f6b3e356d47f91c5ca925ccd93ffa594e28558ed | diff --git a/.github/workflows/docs-issue.yml b/.github/workflows/docs-issue.yml
index 00a098df827..da1659f957c 100644
--- a/.github/workflows/docs-issue.yml
+++ b/.github/workflows/docs-issue.yml
@@ -5,15 +5,14 @@
# To reduce barriers for keeping docs up to date
# **when?**
-# When a PR is labeled `user docs` and ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
dbt-labs__dbt-core-9769@323dec1 | dbt-labs/dbt-core | Python | 9,769 | Fix #9593: Validation of unit test parsing for incremental models | resolves #9593
### Problem
Unclear error message when `is_incremental` override wasn't specified for a unit test
### Solution
Add parse-time errors when:
* unit testing an incremental model but not providing an override for is_incremental
* unit testing an incremental model overriding is_incremental: tru... | 2024-03-17T07:57:14Z | [Bug] parse-time validation when unit testing incremental model
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
Suppose a model includes the `is_incremental()` m... | Curious what @MichelleArk @jtcohen6 you think here...
I actually think it's a good thing that we require you to be explicit about whether this is a unit test for the incremental model in "incremental" mode or in "full refresh" mode. I'm not convinced we _should_ set a default here (is that a spicy take?). However, i... | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nSuppose a model includes the `is_incremental()` macro.\r\n\r\nIf a unit test is ... | 2c1926cee9edad86dcc0e435677789e8e93925bb | {
"head_commit": "323dec14b1d32f7b2995216486080cc1c0ebf02b",
"head_commit_message": "Update Fixes-20240317-005611.yaml",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240317-005611.yaml b/.changes/unreleased/Fixes-20240317-005611.yaml\nnew file mode 100644\nindex 00000000000..0878779174a\n--- /dev/... | [
{
"diff_hunk": "@@ -438,6 +437,31 @@ def process_models_for_unit_test(\n target_model_id = unit_test_def.depends_on.nodes[0]\n target_model = manifest.nodes[target_model_id]\n assert isinstance(target_model, ModelNode)\n+\n+ target_model_is_incremental = \"macro.dbt.is_incremental\" in target_mod... | 5fb241eb26f2df4d0734faae8ceddb2d7256f6f1 | diff --git a/.changes/unreleased/Fixes-20240317-005611.yaml b/.changes/unreleased/Fixes-20240317-005611.yaml
new file mode 100644
index 00000000000..0878779174a
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240317-005611.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: 'Validation of unit test parsing for incremental models'... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
dbt-labs__dbt-core-9886@c678cbc | dbt-labs/dbt-core | Python | 9,886 | Begin warning people about spaces in model names | resolves #9397
### Problem
We don't support models with spaces in their names. However, we haven't been actually enforcing this. If a person have spaces in their model names, it causes issues when using selectors. Additionally, depending on a person's operating system, there were other edge case problems with spa... | 2024-04-10T06:48:42Z | [CT-3564] for deprecation - we should not support spaces in model names
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
Spaces in model names was only ever supported incidentally & by accident. It’s never been documented.
- Having a space in a model name makes in impossible to sele... | Notes from refinement:
* Let's consider adding a new ProjectFlag for this behaviour as well
* We should be able to use our existing deprecation tracking events to manage the deprecation lifecycle here. Some previous discussion: https://github.com/dbt-labs/dbt-core/issues/9518#issuecomment-1927481465
@graciegoheen ca... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of dbt-core\r\n\r\n### Short description\r\n\r\nSpaces in model names was only ever supported incidentally & by accident. It’s never been documented. \r\n- Having a space in a model name makes in impossible to select via `--select` on the model name bec... | 95581cc661ce96334485b741b762d37033ab88be | {
"head_commit": "c678cbcec5fff0951ab52a1206bd324e10f79d0c",
"head_commit_message": "Improve readability of logs related to problematic model names\n\nWe want people running dbt to be able to at a glance see warnings/errors\nwith running their project. In this case we are focused specifically on\nerrors/warnings in... | [
{
"diff_hunk": "@@ -413,6 +418,43 @@ def message(self) -> str:\n return warning_tag(f\"Deprecated functionality\\n\\n{description}\")\n \n \n+class SpacesInModelNameDeprecation(DynamicLevel):\n+ def code(self) -> str:\n+ return \"D014\"\n+\n+ def message(self) -> str:\n+ version = \"... | 9cdecaa3315ea4ed2e0c2d0c53f680dabf5a6b96 | diff --git a/.changes/unreleased/Fixes-20240409-233347.yaml b/.changes/unreleased/Fixes-20240409-233347.yaml
new file mode 100644
index 00000000000..db929c16af0
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240409-233347.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Begin warning people about spaces in model names
+time: ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
deepset-ai__haystack-2013@9f1ce41 | deepset-ai/haystack | Python | 2,013 | DC SDK - load pipeline from deepset cloud | **Proposed changes**:
Deepset cloud SDK - load, run and evaluate pipelines from deepset cloud. We already have the possibility to load an existing pipeline from a `yaml` configuration. As another origin we can now load pipelines from deepset cloud.
**Usage**
Set environment variables:
```json
DEEPSET_CLOUD_API_... | 2022-01-17T17:13:24Z | pipeline.load_from_dc()
In order to enable smooth experimentation with existing pipelines, we want to load deployed pipelines from DC:
- load YAML from DC
- API exists for downloading YAML: /workspaces/{workspace_name}/pipelines/{pipeline_name}/yaml
- Params: workspace_name, pipeline_name, api_key
- create Pipe... | ## Examples
Explicit:
```python
api_key = '<your_key>'
workspace = '<workspace>'
pipeline_name = '<my_fancy_pipeline>'
pipeline.load_from_dc(api_key=api_key, pipeline_name=pipeline_name, workspace=workspace)
```
With env variable:
```python
# api_key is set in DEEPSET_CLOUD_API_KEY env variable
works... | [
{
"body": "In order to enable smooth experimentation with existing pipelines, we want to load deployed pipelines from DC:\r\n- load YAML from DC\r\n - API exists for downloading YAML: /workspaces/{workspace_name}/pipelines/{pipeline_name}/yaml\r\n - Params: workspace_name, pipeline_name, api_key\r\n- create P... | 488c3e9e52b9286afc3ad9a5f2e3161772be2e2f | {
"head_commit": "9f1ce41acd7dc6901d3998fbad743eb5c1741fa2",
"head_commit_message": "fixed errors",
"patch_to_review": "diff --git a/haystack/pipelines/base.py b/haystack/pipelines/base.py\nindex f115dd7171..e17abab2ac 100644\n--- a/haystack/pipelines/base.py\n+++ b/haystack/pipelines/base.py\n@@ -1,8 +1,9 @@\n-f... | [
{
"diff_hunk": "@@ -92,70 +92,93 @@ def load_from_yaml(cls, path: Path, pipeline_name: Optional[str] = None, overwri\n variable 'MYDOCSTORE_PARAMS_INDEX=documents-2021' can be set. Note that an\n `_` sign must be used to s... | 0d0fadd438003c3c6b303437e0f226b6cedc8e58 | diff --git a/docs/_src/api/api/pipelines.md b/docs/_src/api/api/pipelines.md
index 4d898f0dd6..f309de1344 100644
--- a/docs/_src/api/api/pipelines.md
+++ b/docs/_src/api/api/pipelines.md
@@ -35,7 +35,7 @@ be passed.
Here's a sample configuration:
```yaml
- | version: '0.8'
+ | version: '0.9'
|
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-9758@127cf21 | dbt-labs/dbt-core | Python | 9,758 | fix source selection during catalog generation of over 100 relations | resolves https://github.com/dbt-labs/dbt-core/issues/9755
associated adapter changes: https://github.com/dbt-labs/dbt-adapters/pull/131
<!---
Include the number of the issue addressed by this PR above if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.m... | 2024-03-12T20:53:26Z | [Bug] sources not in catalog.json when dbt docs generate selects over 100 nodes
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
If I run `dbt docs generate` in m... | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nIf I run `dbt docs generate` in my dbt project selecting over 100 nodes, my sour... | bfb68b2619fa962a54bb1135ff3c015d3a65d676 | {
"head_commit": "127cf21bf2ac9629fc0f2e811de80b183abd14f1",
"head_commit_message": "changelog entry",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240312-165357.yaml b/.changes/unreleased/Fixes-20240312-165357.yaml\nnew file mode 100644\nindex 00000000000..7a391118015\n--- /dev/null\n+++ b/.chang... | [
{
"diff_hunk": "@@ -1,4 +1,4 @@\n-git+https://github.com/dbt-labs/dbt-adapters.git@main\n+git+https://github.com/dbt-labs/dbt-adapters.git@refactor-magic-catalog-int",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "dev-requirements.txt",
"start_line": null,
"text... | a17a19f2541d01d52e13c61f4c60071d84288219 | diff --git a/.changes/unreleased/Fixes-20240312-165357.yaml b/.changes/unreleased/Fixes-20240312-165357.yaml
new file mode 100644
index 00000000000..7a391118015
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240312-165357.yaml
@@ -0,0 +1,7 @@
+kind: Fixes
+body: include sources in catalog.json when over 100 relations ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
certbot__certbot-6812@2e03edf | certbot/certbot | Python | 6,812 | Correct certbot-auto for Fedora 29+ | Fixes #6698
Fedora maintainers engaged a deprecation path for Python 2.x with Fedora 29. As a first step, `python2-virtualenv` does not install the `virtualenv` binary anymore, in favor of `python3-virtualenv`, and so the installation of Python 3 virtual environments by default.
However, certbot-auto installs `p... | 2019-03-03T23:33:58Z | certbot-auto doesn't work on Fedora 29
## My operating system is (include version):
Fedora 29
## I installed Certbot with (certbot-auto, OS package manager, pip, etc):
certbot-auto
## I ran this command and it produced this output:
```
# git checkout v0.30.0
# ./certbot-auto -n
<bunch of stuff>
Creat... | Is this a regression?
Kind of? `certbot-auto` did used to work on Fedora and we're still passing tests on an old version in our test farm tests. I think what probably happened here is a more recent Fedora version changed the name of the virtualenv package and we haven't yet updated certbot-auto to reflect that.
I th... | [
{
"body": "## My operating system is (include version):\r\n\r\nFedora 29\r\n\r\n## I installed Certbot with (certbot-auto, OS package manager, pip, etc):\r\n\r\ncertbot-auto\r\n\r\n## I ran this command and it produced this output:\r\n\r\n```\r\n# git checkout v0.30.0\r\n# ./certbot-auto -n\r\n<bunch of stuff>\... | f378536ffab6213d1e34a8811e9d8a0e6ab9674b | {
"head_commit": "2e03edfa78c5f685745cf389344dda262553daea",
"head_commit_message": "Add a step to handle python3 on fedora29",
"patch_to_review": "diff --git a/letsencrypt-auto-source/letsencrypt-auto b/letsencrypt-auto-source/letsencrypt-auto\nindex ce3b35e8628..382c26fd3c0 100755\n--- a/letsencrypt-auto-source... | [
{
"diff_hunk": "@@ -323,7 +323,10 @@ elif [ -f /etc/redhat-release ]; then\n prev_le_python=\"$LE_PYTHON\"\n unset LE_PYTHON\n DeterminePythonVersion \"NOCRASH\"\n- if [ \"$PYVER\" -eq 26 ]; then\n+ # Starting to Fedora 29, python2 is on a deprecation path. Let's move to python3 then.\n+ RPM_DIST_NAME=... | 6a729ce633138825fc1820068ea749d9ec5c4f48 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c854c74bff0..3b49d527531 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,7 +6,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Added
-*
+* Fedora 29+ is now supported by certbot-auto. Since Python 2.x is on a deprecation
+ path in Fedora, ce... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
dbt-labs__dbt-core-9640@c6d0d8f | dbt-labs/dbt-core | Python | 9,640 | remove ~= from dependency definitions | resolves #9643
### Problem
### Solution
Replace `~=` with `>=,<` for equivalent dependency definitions.
### Checklist
- [ ] I have read [the contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md) and understand what's expected of me
- [ ] I have run this code in develo... | 2024-02-23T14:09:43Z | Standardize Dependency Definitions
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
As OSS at the org we are standardizing on using >=,< instead of ~= for dependency definitions. Update dbt-common dependencies to follow this pattern.
### Acceptance criteria
- No uses of ~=, inst... | [
{
"body": "### Housekeeping\r\n\r\n- [X] I am a maintainer of dbt-core\r\n\r\n### Short description\r\n\r\nAs OSS at the org we are standardizing on using >=,< instead of ~= for dependency definitions. Update dbt-common dependencies to follow this pattern.\r\n\r\n### Acceptance criteria\r\n\r\n- No uses of ~=, ... | 7ea46708327260c85460d8034ef6ab84fe3d1b78 | {
"head_commit": "c6d0d8fa22c6543b0bccb87d2c1c8e653e3ba041",
"head_commit_message": "try lower bounds of alpha version",
"patch_to_review": "diff --git a/core/setup.py b/core/setup.py\nindex 8e648838fc4..b5065c8841a 100644\n--- a/core/setup.py\n+++ b/core/setup.py\n@@ -49,9 +49,9 @@\n # ----\n # d... | [
{
"diff_hunk": "@@ -13,9 +13,9 @@ mypy==1.4.1\n pip-tools\n pre-commit\n protobuf>=4.0.0\n-pytest~=7.4\n+pytest<=7.4,<8.0",
"line": null,
"original_line": 16,
"original_start_line": null,
"path": "dev-requirements.txt",
"start_line": null,
"text": "@user1:\n`>=7.4,<8.0`\n\n@author:\n```s... | 40fe7bb3fa03fa0d8f3460a33e86c367e36d5205 | diff --git a/core/setup.py b/core/setup.py
index 82d65f6e0bc..3bd43cd31df 100644
--- a/core/setup.py
+++ b/core/setup.py
@@ -49,9 +49,9 @@
# ----
# dbt-core uses these packages deeply, throughout the codebase, and there have been breaking changes in past patch releases (even though these are major-ver... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
dbt-labs__dbt-core-9585@bd31a34 | dbt-labs/dbt-core | Python | 9,585 | Handle exceptions during node execution more elegantly. | resolves #9583
### Problem
Because of a bug in Python's thread pool mechanism, an uncaught exception on dbt's task threads would cause it to hang.
### Solution
Eliminate a follow-up exception that caused a top-level exception to escape.
### Checklist
- [x] I have read [the contributing guide](https://... | 2024-02-15T22:59:09Z | Do Not Hang on Worker Thread Exceptions
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
For a while now, when there was an exception during the execution of one ... | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nFor a while now, when there was an exception during the execution of one of dbt'... | e4fe839e4574187b574473596a471092267a9f2e | {
"head_commit": "bd31a3480eae6933522c4e452558134723985e8c",
"head_commit_message": "Add task documentation.",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240216-145632.yaml b/.changes/unreleased/Fixes-20240216-145632.yaml\nnew file mode 100644\nindex 00000000000..a02027f66a5\n--- /dev/null\n+++ ... | [
{
"diff_hunk": "@@ -221,19 +221,36 @@ def call_runner(self, runner: BaseRunner) -> RunResult:\n )\n )\n status: Dict[str, str] = {}\n+ result = None\n+ thread_exception = None\n try:\n result = runner.run_with_hook... | 1aef69000d3017884e3c62b5e7662a9188f0477f | diff --git a/.changes/unreleased/Fixes-20240216-145632.yaml b/.changes/unreleased/Fixes-20240216-145632.yaml
new file mode 100644
index 00000000000..a02027f66a5
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240216-145632.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Tighten exception handling to avoid worker thread hangs.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-1895@50098c6 | deepset-ai/haystack | Python | 1,895 | Upgrade `weaviate-client` to `3.3.3` and fix `get_all_documents` | Closes #1893, closes #2357
The issue is about `get_all_documents` returning always max. 100 documents, regardless of the amount of docs contained by the docstore that match the query. To overcome this limitation, which seems to be somewhat inherent to Weaviate, I made `_get_all_documents_in_index` request the next ... | 2021-12-15T15:20:02Z | WeaviateDocumentStore.get_all_documents does not return all documents
**Describe the bug**
Doing some experimenting with Weaviate+Haystack and running into what looks like a problem with the way `WeaviateDocumentStore.get_all_documents` is implemented. Does not look like it is actually retrieving all documents, but ... | Hello @cjb06776, thank you for this bug report. I'm going to try replicate this and be back with some feedback asap.
Yes, I confirm I can replicate this issue. Unfortunately I don't have a quick fix for it, but I'll let you know when a patch is out. In the meantime I can only recommend you to temporarily choose another... | [
{
"body": "**Describe the bug**\r\n\r\nDoing some experimenting with Weaviate+Haystack and running into what looks like a problem with the way `WeaviateDocumentStore.get_all_documents` is implemented. Does not look like it is actually retrieving all documents, but rather only the first 100. This results in sub... | 3561037e820026fda66f3b6b3c82cca4a648f047 | {
"head_commit": "50098c6a84a02b965ed7757ed6f30a3fd75122c7",
"head_commit_message": "Update Documentation & Code Style",
"patch_to_review": "diff --git a/.github/workflows/linux_ci.yml b/.github/workflows/linux_ci.yml\nindex 530626e8e5..fb4e090959 100644\n--- a/.github/workflows/linux_ci.yml\n+++ b/.github/workfl... | [
{
"diff_hunk": "@@ -458,7 +458,7 @@ def write_documents(\n batched_documents = get_batches_from_generator(document_objects, batch_size)\n with tqdm(total=len(document_objects), disable=not self.progress_bar) as progress_bar:\n for document_batch in batched_documents:\n- ... | 8dabf15b4638b37f00a5c38979033d480378207c | diff --git a/.github/workflows/linux_ci.yml b/.github/workflows/linux_ci.yml
index c4544dd15b..1a55810193 100644
--- a/.github/workflows/linux_ci.yml
+++ b/.github/workflows/linux_ci.yml
@@ -261,7 +261,7 @@ jobs:
sudo docker-compose ps
- name: Run Weaviate
- run: docker run -d -p 8080:8080 --name h... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-1665@1fc6d59 | deepset-ai/haystack | Python | 1,665 | ensure tf-idf matrix calculation before retrieval | **Bug**
The problem is that the TfidfRetriever uses a dataframe `df` to store paragraphs and term frequencies and inverse document frequencies that need to be calculated in the `fit()` method based on documents stored in the document store. This calculation needs to be done before any document retrieval step can be ex... | 2021-10-27T14:54:38Z | Exception: fit() needs to called before retrieve()
**Describe the bug**
```
version: '0.9'
components: # define all the building-blocks for Pipeline
- name: DocumentStore
type: InMemoryDocumentStore
- name: Retriever
type: TfidfRetriever
params:
document_store: DocumentStore # par... | I confirm I can reproduce this, but at a first glance I don't see anything wrong in your setup. I'm going to find out what's going on here and let you know :+1:
Hey @SaffronWolf, could you share the entire logs of your API server, from boot? I'm looking for a line similar to `Fit method called with empty document store... | [
{
"body": "**Describe the bug**\r\n```\r\nversion: '0.9'\r\n\r\ncomponents: # define all the building-blocks for Pipeline\r\n - name: DocumentStore\r\n type: InMemoryDocumentStore\r\n - name: Retriever\r\n type: TfidfRetriever\r\n params:\r\n document_store: DocumentStore # params can refe... | 171fd7be389df705d68de5de375413d16050edd5 | {
"head_commit": "1fc6d59fbdec64de150202f34d78f23d77144050",
"head_commit_message": "Add latest docstring and tutorial changes",
"patch_to_review": "diff --git a/docs/_src/api/api/retriever.md b/docs/_src/api/api/retriever.md\nindex b92ebe21cf..bb771affeb 100644\n--- a/docs/_src/api/api/retriever.md\n+++ b/docs/_... | [
{
"diff_hunk": "@@ -173,8 +177,13 @@ def retrieve(self, query: str, filters: dict = None, top_k: Optional[int] = None\n :param top_k: How many documents to return per query.\n :param index: The name of the index in the DocumentStore from which to retrieve documents\n \"\"\"\n+ if ... | 6a54dc4b2d008c835e47405ecda33f8b08dc6b70 | diff --git a/docs/_src/api/api/retriever.md b/docs/_src/api/api/retriever.md
index b92ebe21cf..bb771affeb 100644
--- a/docs/_src/api/api/retriever.md
+++ b/docs/_src/api/api/retriever.md
@@ -196,13 +196,14 @@ It uses sklearn's TfidfVectorizer to compute a tf-idf matrix.
#### \_\_init\_\_
```python
- | __init__(docu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-1747@e523df1 | deepset-ai/haystack | Python | 1,747 | Public demo | Tasks:
- [x] Create a document store with a different dataset (not GoT)
- [x] Disable file upload in the UI
- [x] Make the UI submit requests only when the button is clicked
- [x] Make the UI display a message when all workers are busy
- [x] Adjust eval mode
- [ ] Deploy the modified demo on a suitable EC insta... | 2021-11-12T12:49:01Z | Deploy public demo
Let's deploy a simple, public demo based on our docker-compose setup with elasticsearch + haystack API + streamlit UI.
We should particularly :
- streamline the UI again (disable file upload, only submit requests when clicking on run button, adjusting eval mode...)
- display an info message if ... | Tasks:
- [ ] Create a document store with a different dataset (not GoT)
- [ ] Disable file upload in the UI
- [ ] Make the UI submit requests only when the button is clicked
- [ ] Make the UI display a message when all workers are busy
- [ ] Adjust eval mode ?
- [ ] Deploy the modified demo on a suitable EC insta... | [
{
"body": "Let's deploy a simple, public demo based on our docker-compose setup with elasticsearch + haystack API + streamlit UI. \r\n\r\nWe should particularly :\r\n- streamline the UI again (disable file upload, only submit requests when clicking on run button, adjusting eval mode...)\r\n- display an info mes... | 85a08d671a68ce66b5dfc39b12c018924648ae41 | {
"head_commit": "e523df18e6520aa6c7e3204f1d839b7f136d4be6",
"head_commit_message": "Trigger the ci",
"patch_to_review": "diff --git a/docs/_src/api/api/document_classifier.md b/docs/_src/api/api/document_classifier.md\nindex a55a1e2a1d..8e89683f75 100644\n--- a/docs/_src/api/api/document_classifier.md\n+++ b/doc... | [
{
"diff_hunk": "@@ -12,175 +13,197 @@\n import SessionState\n from utils import feedback_doc, haystack_is_ready, retrieve_doc, upload_doc\n \n+\n # Adjust to a question that you would like users to see in the search bar when they load the UI:\n DEFAULT_QUESTION_AT_STARTUP = \"Who is the father of Arya Stark?\""... | d82af879fbd041b63d54f994bc098bf29cb192d9 | diff --git a/docs/_src/api/api/document_classifier.md b/docs/_src/api/api/document_classifier.md
index a55a1e2a1d..8e89683f75 100644
--- a/docs/_src/api/api/document_classifier.md
+++ b/docs/_src/api/api/document_classifier.md
@@ -2,7 +2,7 @@
# Module base
<a name="base.BaseDocumentClassifier"></a>
-## BaseDocument... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1861@36fe91e | deepset-ai/haystack | Python | 1,861 | Support custom headers per request in pipeline | **Proposed changes**:
- make retrievers and document stores support custom headers per request
- test custom headers with elastic search
- ensure it works with all retrievers (not only ElasticsearchRetriever)
- document stores that do not support headers (e.g. no http call needed) ignore the parameter silently
- a... | 2021-12-08T13:58:03Z | Modify HTTP header for retriever request
**Is your feature request related to a problem? Please describe.**
Currently our ODFE has some plugins to handle authentication and the authorization of documents based on JWT tokens. With the Elasticsearch-, OpenSearch- and OpenDistroElasticsearchRetriever I can't add this tok... | Hi @DJokes! I think this might be useful also for other users. Not sure what would be the best way to implement this, though. We could either have custom headers as optional instance variable when initializing an `ElasticsearchDocumentStore` or have an optional argument in the query methods and then pass these header (... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nCurrently our ODFE has some plugins to handle authentication and the authorization of documents based on JWT tokens. With the Elasticsearch-, OpenSearch- and OpenDistroElasticsearchRetriever I can't add this token from a user to th... | 7bdb7828714ba23668b3b696976ee06cc1807563 | {
"head_commit": "36fe91e388e9697fed2b456ef4dbbb92fcf6860b",
"head_commit_message": "Add latest docstring and tutorial changes",
"patch_to_review": "diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md\nindex 0543fb65b8..0f783ea93a 100644\n--- a/docs/_src/api/api/document_store.m... | [
{
"diff_hunk": "@@ -243,21 +243,21 @@ def _prepare_hosts(self, host, port):\n hosts = [{\"host\": host, \"port\": port}]\n return hosts\n \n- def _create_document_index(self, index_name: str):\n+ def _create_document_index(self, index_name: str, headers: MutableMapping[str, str] = None... | 972d7f402da3296624bd6566b85ef59312700308 | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index 0543fb65b8..b2eecdf4d0 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -24,7 +24,7 @@ Base class for implementing Document Stores.
```python
| @abstractmethod
- | write_documen... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
cvat-ai__cvat-4824@f212aa6 | cvat-ai/cvat | Python | 4,824 | Create multiple tasks when uploading multiple videos | <!-- Raised an issue to propose your change (https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will be approved and merged.
Read the [CONTRIBUTION](https://github.com/cvat-ai/cvat/blob/... | 2022-08-24T10:05:52Z | Create a lot of tasks with videos at the same time
I have about 240 videos which I want to tag.
But to create a single task for each video is very time-consuming. I would like to upload several videos and edit them all together. | @Dodoooh , you can use command line tools to create tasks semi-automatically https://github.com/opencv/cvat/tree/develop/utils/cli. But it makes sense to support uploading multiple videos in the future for "projects" functionality.
Any progress?
I'd be happy to see this feature too :-)
2020-6-3 loading......
I would al... | [
{
"body": "I have about 240 videos which I want to tag. \r\n\r\nBut to create a single task for each video is very time-consuming. I would like to upload several videos and edit them all together. ",
"number": 916,
"title": "Create a lot of tasks with videos at the same time"
}
] | 9f89787f95504474b154974c7ec6087dd13149dd | {
"head_commit": "f212aa658a98184712ccaf377696f04250573418",
"head_commit_message": "refactoring create queue in mutlitasks case",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex 79fd92ca1d0f..770c65309746 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -84,6 +84,7 @@ RUN apt-get update && \\\n ... | [
{
"diff_hunk": "@@ -4,15 +4,19 @@\n \n import React, { RefObject } from 'react';\n import Input from 'antd/lib/input';\n+import Text from 'antd/lib/typography/Text';\n+import Tooltip from 'antd/lib/tooltip';\n import Form, { FormInstance } from 'antd/lib/form';\n-import { Store } from 'antd/lib/form/interface';... | 26c1bfb2cfbf3a4dfd600f283886fccd3a4f1f6c | diff --git a/cvat-ui/src/actions/share-actions.ts b/cvat-ui/src/actions/share-actions.ts
index 25a4aed50f09..1ceed81e99c4 100644
--- a/cvat-ui/src/actions/share-actions.ts
+++ b/cvat-ui/src/actions/share-actions.ts
@@ -1,4 +1,5 @@
// Copyright (C) 2020-2022 Intel Corporation
+// Copyright (C) 2022 CVAT.ai Corporation
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1735@2aeb3b5 | deepset-ai/haystack | Python | 1,735 | Adding yaml functionality to standard pipelines (save/load...) | **Proposed changes**:
- adds relevant methods to BaseStandardPipeline to support loading from and saving to yaml files
- closes #1681
**Status (please check what you already did)**:
- [x] First draft (up for discussions & feedback)
- [ ] Final code
- [ ] Added tests
- [ ] Updated documentation
This would ma... | 2021-11-11T11:36:02Z | Easier way to generate a YAML file from a standard pipeline
Since the standard pipelines don't inherit from `Pipeline` but rather from `BaseStandardPipeline`, they don't have a `save_to_yaml()' method. There have been users in our community who want to create a yaml for these standard pipelines. We should make it easie... | Let's add these methods to `BaseStandardPipeline`:
- `save_to_yaml()`
- `load_from_yaml()`
- `get_nodes_by_class()`
- `get_document_store()`
@MichelBartels They can simply forward the call to the respective methods of the `Pipeline`class. Similar to the already existing functions here: https://github.com/deepset... | [
{
"body": "Since the standard pipelines don't inherit from `Pipeline` but rather from `BaseStandardPipeline`, they don't have a `save_to_yaml()' method. There have been users in our community who want to create a yaml for these standard pipelines. We should make it easier for them to generate the yaml to use in... | 158460504b6823fcbfb1691a01727c996bf3685b | {
"head_commit": "2aeb3b507692d03a8e83079b5f4b8df0d62362ba",
"head_commit_message": "Add latest docstring and tutorial changes",
"patch_to_review": "diff --git a/docs/_src/api/api/pipelines.md b/docs/_src/api/api/pipelines.md\nindex 3faa60f55f..680dc1b1c3 100644\n--- a/docs/_src/api/api/pipelines.md\n+++ b/docs/_... | [
{
"diff_hunk": "@@ -69,6 +69,84 @@ def draw(self, path: Path = Path(\"pipeline.png\")):\n :param path: the path to save the image.\n \"\"\"\n self.pipeline.draw(path)\n+ \n+ def save_to_yaml(self, path: Path, return_defaults: bool = False):\n+ \"\"\"\n+ Save a YAML co... | 7b2838af05cbd4fa4b0bd9a7ddd7a7609631e813 | diff --git a/.github/workflows/linux_ci.yml b/.github/workflows/linux_ci.yml
index 56b2bfcf88..d922ea566f 100644
--- a/.github/workflows/linux_ci.yml
+++ b/.github/workflows/linux_ci.yml
@@ -1,6 +1,7 @@
name: Linux CI
on:
+ workflow_dispatch:
push:
branches: [ master ]
pull_request:
@@ -40,7 +41,7 @@ jo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-9508@d66e48d | dbt-labs/dbt-core | Python | 9,508 | Fix filter parsing bug | resolves #9507
<!---
Include the number of the issue addressed by this PR above if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
Add the `user docs` label to this PR if it will need docs changes. An
issue will get opene... | 2024-02-02T00:42:23Z | [Bug] Semantic Layer where filter strings are parsed into lists
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
Currently, if you pass a string into a filter YAML param... | [
{
"body": "### Is this a new bug in dbt-core?\n\n- [X] I believe this is a new bug in dbt-core\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\n\n### Current Behavior\n\nCurrently, if you pass a string into a filter YAML param, it will be assumed to be a list. Thi... | 2411f93240a346961e6a965ad9cb5c766db275a0 | {
"head_commit": "d66e48d12a665124649a7a3541426f23517af9c6",
"head_commit_message": "Changelog",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20240201-164407.yaml b/.changes/unreleased/Fixes-20240201-164407.yaml\nnew file mode 100644\nindex 00000000000..a156a2a7dd5\n--- /dev/null\n+++ b/.changes/unr... | [
{
"diff_hunk": "@@ -564,7 +564,7 @@ def __bool__(self):\n @dataclass\n class UnparsedMetricInputMeasure(dbtClassMixin):\n name: str\n- filter: Optional[Union[str, List[str]]] = None\n+ filter: Union[Optional[str], Optional[List[str]]] = None",
"line": null,
"original_line": 567,
"original_... | 50fc004b22c1302ab77d3a9b127750821de783af | diff --git a/.changes/unreleased/Fixes-20240201-164407.yaml b/.changes/unreleased/Fixes-20240201-164407.yaml
new file mode 100644
index 00000000000..a156a2a7dd5
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240201-164407.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix bug where Semantic Layer filter strings are parsed i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
certbot__certbot-4970@28dc6d7 | certbot/certbot | Python | 4,970 | Change certbot-auto's installation path to /opt | In general, the purpose of this PR is to move `certbot-auto`'s install path to a single location to help people who have multiple installations and prep for #3522. This also fixes #3480.
I've broken design decisions into sections so reviewers or others in the future can read why we made specific decisions that they ... | 2017-07-27T19:09:48Z | certbot-auto doesn't appear to respect HTTPS_PROXY env var
Hello, thanks for certbot! I'm attempting to use it behind an https proxy, and it hangs after asking me for my email address, eventually erroring out with this message:
```
ConnectionError: HTTPSConnectionPool(host='acme-v01.api.letsencrypt.org', port=443): Ma... | Certbot uses `python-requests` to communicate with the server which [respects the HTTPS_PROXY env var](http://docs.python-requests.org/en/master/user/advanced/#proxies).
Are you using `letsencrypt-auto`/`certbot-auto`? If so, I suspect the problem is `sudo`. The script uses `sudo` internally to invoke Certbot which wi... | [
{
"body": "Hello, thanks for certbot! I'm attempting to use it behind an https proxy, and it hangs after asking me for my email address, eventually erroring out with this message:\n\n```\nConnectionError: HTTPSConnectionPool(host='acme-v01.api.letsencrypt.org', port=443): Max retries exceeded with url: /directo... | 48c890be61b26b4bf0b3767df994e036a14dda66 | {
"head_commit": "28dc6d7929bd6a509a56333dc125a35e17a320c4",
"head_commit_message": "Remove SUDO_ENV.",
"patch_to_review": "diff --git a/letsencrypt-auto-source/letsencrypt-auto b/letsencrypt-auto-source/letsencrypt-auto\nindex 023d5044e25..c894f372faa 100755\n--- a/letsencrypt-auto-source/letsencrypt-auto\n+++ b... | [
{
"diff_hunk": "@@ -147,35 +152,38 @@ su_sudo() {\n su root -c \"$args\"\n }\n \n-SUDO_ENV=\"\"\n-export CERTBOT_AUTO=\"$0\"\n-if [ -n \"${LE_AUTO_SUDO+x}\" ]; then\n- case \"$LE_AUTO_SUDO\" in\n- su_sudo|su)\n- SUDO=su_sudo\n- ;;\n- sudo)\n- SUDO=sudo\n- SUDO_ENV=\"CERTBOT_AUTO=$0\... | b25ea228b415fa0134d0cd8e54cfd00aed8513cf | diff --git a/letsencrypt-auto-source/letsencrypt-auto b/letsencrypt-auto-source/letsencrypt-auto
index 39f8728e8cd..8ce3342be8a 100755
--- a/letsencrypt-auto-source/letsencrypt-auto
+++ b/letsencrypt-auto-source/letsencrypt-auto
@@ -23,9 +23,11 @@ fi
if [ -z "$XDG_DATA_HOME" ]; then
XDG_DATA_HOME=~/.local/share
fi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-1601@cbb54e5 | deepset-ai/haystack | Python | 1,601 | Pipeline node names validation | Related to #1568
The `params` dictionary passed to `Pipelines.run()` does not check that a node corresponding to each node name exists. This means that a typo in the node name makes all the parameters to be silently discarded. It would be better to throw an error if no node with a given name could be found in the pi... | 2021-10-15T12:19:57Z | Add validation on the nodes names in the `params` dictionary passed to `Pipeline.run()`
The `params` dictionary passed to `Pipelines.run()` now validates the key-value pairs passed for each node. However, it does not check that a node corresponding to each node name exists. This means that a typo in the node name makes... | Let's implement it in BasePipeline so that we can leverage it in Ray as well | [
{
"body": "The `params` dictionary passed to `Pipelines.run()` now validates the key-value pairs passed for each node. However, it does not check that a node corresponding to each node name exists. This means that a typo in the node name makes all the parameters to be silently discarded. \r\n\r\nIt would be bet... | 5ec29a528340d3511b2c344f27c2890737d1ce6d | {
"head_commit": "cbb54e5809531c33bc96795659a4c0f8527d4942",
"head_commit_message": "Use roberta model for test_pipeline.yaml",
"patch_to_review": "diff --git a/haystack/pipeline.py b/haystack/pipeline.py\nindex 9ea3832426..92726582a1 100644\n--- a/haystack/pipeline.py\n+++ b/haystack/pipeline.py\n@@ -284,6 +284,... | [
{
"diff_hunk": "@@ -8,7 +8,8 @@\n \n class QueryRequest(BaseModel):\n query: str\n- params: Optional[dict] = None\n+ retriever_params: Optional[dict] = None",
"line": null,
"original_line": 11,
"original_start_line": null,
"path": "rest_api/schema.py",
"start_line": null,
"text... | 59295b006c7bae147145f8d63c41565ae0540979 | diff --git a/haystack/pipeline.py b/haystack/pipeline.py
index 9ea3832426..b9d247f505 100644
--- a/haystack/pipeline.py
+++ b/haystack/pipeline.py
@@ -284,6 +284,21 @@ def run( # type: ignore
:param debug_logs: Whether all the logs of the node should be printed in the console,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-9443@249124b | dbt-labs/dbt-core | Python | 9,443 | fix retry as CLI | Resolves: #9444
Our integration test right now goes through dbtRunner, which will add the `manifest` as None in `ctx.obj`.
When running retry as a CLI command, current code would just fail.
We should add some test to run each command as CLI command just to make sure CLI works.
| 2024-01-24T21:56:59Z | [Bug] Retry would failing running as a CLI command
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
Running `dbt retry` will fail
### Expected Behavior
retr... | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nRunning `dbt retry` will fail\r\n\r\n### Expected Behavior\r\n\r\nretry works\r\... | ad723a6db897d9779f817da522758c05dce65730 | {
"head_commit": "249124b51c8bfb13b2c76e1361c3ef0b755ea48f",
"head_commit_message": "fix running things as CLI",
"patch_to_review": "diff --git a/core/dbt/cli/main.py b/core/dbt/cli/main.py\nindex ad2fbf61a77..c1db298960b 100644\n--- a/core/dbt/cli/main.py\n+++ b/core/dbt/cli/main.py\n@@ -608,7 +608,7 @@ def retr... | [
{
"diff_hunk": "@@ -608,7 +608,7 @@ def retry(ctx, **kwargs):\n task = RetryTask(\n ctx.obj[\"flags\"],\n ctx.obj[\"runtime_config\"],\n- ctx.obj[\"manifest\"],",
"line": 611,
"original_line": 611,
"original_start_line": null,
"path": "core/dbt/cli/main.py",
"start... | 7492eb551dcc8d9fb74f87ec5af825b25312bf20 | diff --git a/.changes/unreleased/Fixes-20240124-142522.yaml b/.changes/unreleased/Fixes-20240124-142522.yaml
new file mode 100644
index 00000000000..40a8b1a6aea
--- /dev/null
+++ b/.changes/unreleased/Fixes-20240124-142522.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix retry command run from CLI
+time: 2024-01-24T14:25:2... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
dbt-labs__dbt-core-9429@099cd2c | dbt-labs/dbt-core | Python | 9,429 | Simplify core release inputs | resolves #9431
relates to https://github.com/dbt-labs/dbt-release/issues/69
### Problem
Release inputs are long and not all of them are really necessary or add value to being flexible.
![Screenshot 2024-01-23 at 12 45 52 PM](https://github.com/dbt-labs/dbt-core/assets/7070049/00885f5e-a184-49c4-91fc-6f99262f... | 2024-01-23T18:51:17Z | Simplify release inputs
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
There are too many inputs when we release and we don't touch most of them. Only require the ones that are actually needed. The most annoying one if the sha. We have to enter the sha we want to release but we end up ... | [
{
"body": "### Housekeeping\n\n- [X] I am a maintainer of dbt-core\n\n### Short description\n\nThere are too many inputs when we release and we don't touch most of them. Only require the ones that are actually needed. The most annoying one if the sha. We have to enter the sha we want to release but we end up... | af188624d5967ed996f40f1c1e20082878b8cc8a | {
"head_commit": "099cd2c2fe39ea92a7a02d8820a236bf559ef8e7",
"head_commit_message": "drop all env vars since the workflows dont like them",
"patch_to_review": "diff --git a/.github/workflows/nightly-release.yml b/.github/workflows/nightly-release.yml\nindex aefc7ff5eba..c6b5dafaca4 100644\n--- a/.github/workflows... | [
{
"diff_hunk": "@@ -114,32 +66,45 @@ defaults:\n shell: bash\n \n jobs:\n- log-inputs:\n+ job-setup:\n name: Log Inputs\n runs-on: ubuntu-latest\n+ outputs:\n+ starting_sha: ${{ steps.set_sha.outputs.changelog_path }}\n steps:\n - name: \"[DEBUG] Print Variables\"\n run: ... | ee3ab09a74525778b0a233cda79af8faa2a16bde | diff --git a/.github/workflows/nightly-release.yml b/.github/workflows/nightly-release.yml
index aefc7ff5eba..c6b5dafaca4 100644
--- a/.github/workflows/nightly-release.yml
+++ b/.github/workflows/nightly-release.yml
@@ -33,7 +33,6 @@ jobs:
runs-on: ubuntu-latest
outputs:
- commit_sha: ${{ steps.resolv... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-1606@20c4e46 | deepset-ai/haystack | Python | 1,606 | Delete documents by ID in all document stores | Related to #1532, #1383, #880 and #1269
Allows `delete_documents` to accept a list of IDs to delete in all document stores.
| 2021-10-18T15:26:08Z | Allow document stores to delete documents by ID
Currently `delete_documents()` accepts filters to narrow down the amount of documents to delete, but does not allow targeting IDs - only `meta` fields.
We should modify `delete_documents` to be able to accept a list (or a range) of IDs to delete, in all document stores... | Just a comment: There is this PR #1383 with some code that maybe could be reused.
Related https://github.com/deepset-ai/haystack/pull/880 and #1269 | [
{
"body": "Currently `delete_documents()` accepts filters to narrow down the amount of documents to delete, but does not allow targeting IDs - only `meta` fields.\r\n\r\nWe should modify `delete_documents` to be able to accept a list (or a range) of IDs to delete, in all document stores.",
"number": 1532,
... | eb95f0e8aa0af75d4538b19cffe14cfb835b235c | {
"head_commit": "20c4e46a59dc0fc43226bd19b289c636fd4227a6",
"head_commit_message": "Add latest docstring and tutorial changes",
"patch_to_review": "diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md\nindex 68bfe2f8fd..21061c2cc0 100644\n--- a/docs/_src/api/api/document_store.m... | [
{
"diff_hunk": "@@ -514,33 +514,37 @@ def delete_all_documents(self, index: Optional[str] = None, filters: Optional[Di\n For more details, please refer to the issue: https://github.com/deepset-ai/haystack/issues/1045\n \"\"\"\n )\n- self.delete_documents(index, fil... | 2d38b4b967b297a3b31e52d9d70e8fe819a30483 | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index 68bfe2f8fd..21061c2cc0 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -456,7 +456,7 @@ None
#### delete\_documents
```python
- | delete_documents(index: Optional[str] = None, f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1604@78e9795 | deepset-ai/haystack | Python | 1,604 | Add delete_labels() except for weaviate doc store | **Proposed changes**:
- Add delete_labels() method similar to delete_documents() for all document stores except for weaviate document store: labels can now be deleted by `id` (in elasticsearch this field is called `_id`) or by one of the other fields of label, such as `query`
- Small bug fix in InMemoryDocumentStore:... | 2021-10-15T15:24:42Z | Add `delete_labels()` method to all document stores
**Is your feature request related to a problem? Please describe.**
We have a couple of methods to write labels to a document store. However, there's no easy way to delete them from within haystack.
**Describe the solution you'd like**
A method `delete_labels()` t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWe have a couple of methods to write labels to a document store. However, there's no easy way to delete them from within haystack.\r\n\r\n**Describe the solution you'd like**\r\nA method `delete_labels()` that works similarly to `d... | 5a6285f23fda7ead23e0993b4985db2bd2577fd4 | {
"head_commit": "78e9795e421745f0648b4a8f50da6620688df348",
"head_commit_message": "re-add bugfix after merge",
"patch_to_review": "diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md\nindex 21061c2cc0..383b6da0d7 100644\n--- a/docs/_src/api/api/document_store.md\n+++ b/docs/_s... | [
{
"diff_hunk": "@@ -550,6 +550,32 @@ def delete_documents(self, index: Optional[str] = None, ids: Optional[List[str]]\n \n self.session.commit()\n \n+ def delete_labels(self, index: Optional[str] = None, filters: Optional[Dict[str, List[str]]] = None):\n+ \"\"\"\n+ Delete labels from th... | 62dda412efc0b6d7567535b525c500ea6c3b799f | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index 21061c2cc0..ebfc5eb2c9 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -275,6 +275,7 @@ Write annotation labels into document store.
**Arguments**:
- `labels`: A list of Python ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
certbot__certbot-4201@032d461 | certbot/certbot | Python | 4,201 | created an issue template | fixes #3195 | 2017-02-09T19:09:53Z | Create issue template
We should create an issue template for this repo to help make sure we get relevant information from a user reporting a new issue. Potential questions we could include in the template are:
- Which OS are you using?
- How did you install Certbot?
- What command(s) did you run?
- What did you expect?... | Also, if relevant, can you provide the Apache/Nginx configuration file Certbot is struggling with?
@schoen can you link me to the template on the community forums?
I'm not sure where the canonical URL is, but if you choose new topic
category Help, it pre-fills the following text:
Please fill out the fields below so w... | [
{
"body": "We should create an issue template for this repo to help make sure we get relevant information from a user reporting a new issue. Potential questions we could include in the template are:\n- Which OS are you using?\n- How did you install Certbot?\n- What command(s) did you run?\n- What did you expect... | 299512aa2ba807981b8d987021f1352b6cedf2a9 | {
"head_commit": "032d461e71cc3f1303adec5f17e87de668367bbd",
"head_commit_message": "created an issue template",
"patch_to_review": "diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md\nnew file mode 100644\nindex 00000000000..0c601f5f427\n--- /dev/null\n+++ b/ISSUE_TEMPLATE.md\n@@ -0,0 +1,18 @@\n+Thanks for using... | [
{
"diff_hunk": "@@ -0,0 +1,18 @@\n+Thanks for using Certbot - if you're experiencing issues with using Certbot",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "ISSUE_TEMPLATE.md",
"start_line": null,
"text": "@user1:\nI personally don't think any intro is nece... | c6e01005beeb9edf2647c036184d5865ff86b319 | diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md
new file mode 100644
index 00000000000..e4e56f93d77
--- /dev/null
+++ b/ISSUE_TEMPLATE.md
@@ -0,0 +1,16 @@
+## My operating system is (include version):
+
+
+## My web server is (include version):
+
+
+## How did you install Certbot:
+
+
+## What command did you run an... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
certbot__certbot-6803@e5b5ae5 | certbot/certbot | Python | 6,803 | Refactor cli.py, splitting in it smaller submodules | This is the result of a student project. We probably won't work on this anymore but we still wanted to share our work! This answers issue #4081
`cli.py` is now a package with smaller submodules.
We wrote a few unit tests but not for everything that was refactored. However the modules were already covered by higher... | 2019-02-28T22:44:12Z | certbot/cli.py is too long
Probably the easiest approach is to put `HelpfulArgumentParser` and related classes/methods into their own file. We can then use the class in `cli.py`, but it doesn't have to also be defined there.
This also dramatically simplifies unit testing `HelpfulArgumentParser`. | Hey, my university project team and I will start working on this. We might not do it completely but we'll share what we've done anyway! | [
{
"body": "Probably the easiest approach is to put `HelpfulArgumentParser` and related classes/methods into their own file. We can then use the class in `cli.py`, but it doesn't have to also be defined there.\r\n\r\nThis also dramatically simplifies unit testing `HelpfulArgumentParser`.",
"number": 4081,
... | c883efde0f649a0a7f5da1c35cbb1ae54d752109 | {
"head_commit": "e5b5ae5b81b0d8a9a75b4a2676a98bbb87431761",
"head_commit_message": "Merge branch 'master' into refactor-cli",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 3eea1923de2..703219318b2 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -24,6 +24,7 @@ Certbot adheres to [Semantic... | [
{
"diff_hunk": "@@ -0,0 +1,467 @@\n+\"\"\"Certbot command line argument parser\"\"\"\n+from __future__ import print_function\n+import argparse\n+import copy\n+import glob\n+import os\n+import sys\n+import configargparse\n+import six\n+import zope.component\n+import zope.interface\n+\n+from zope.interface import... | 842ff43ec95ebd8dce946102d4297325ee8a32e5 | diff --git a/certbot/CHANGELOG.md b/certbot/CHANGELOG.md
index ff3061e01ad..126b07eecba 100644
--- a/certbot/CHANGELOG.md
+++ b/certbot/CHANGELOG.md
@@ -13,7 +13,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Changed
-*
+* certbot._internal.cli is now a package split in submodules instead ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
deepset-ai__haystack-1558@736d3fd | deepset-ai/haystack | Python | 1,558 | Return intermediate nodes output in pipelines | Related to #1193
---------------------------
**Proposed changes**:
These changes make nodes capable of recording some debug information during execution. This is accomplished by managing one extra key in the output dictionary, called `_debug`.
By default, the data collected includes the input, the output and th... | 2021-10-05T08:01:26Z | Return Intermediate Node Output
Many users in our community have been asking to have easier ways to return the output of intermediate nodes. I can see that this could be very useful for debugging and also qualitative evaluation.
I think this feature would be very useful, though the exact design is not yet fully clea... | @oryx1729 @tholor Do either of you have strong thoughts on this topic?
One way forward here could be to add a `debug` arg to Pipeline.run() and every node.run(). If `True` the node can write information to the `_debug` key introduced in #1321 .
Ideally, we are not only returning this debug information at the very en... | [
{
"body": "Many users in our community have been asking to have easier ways to return the output of intermediate nodes. I can see that this could be very useful for debugging and also qualitative evaluation.\r\n\r\nI think this feature would be very useful, though the exact design is not yet fully clear.",
... | 3539e6b041668df2673b668b042fd7e005d7a7ad | {
"head_commit": "736d3fdefd28a29df62a0ff41c9deb90064ca488",
"head_commit_message": "Allow enable_debug and console_debug to be passed as arguments of run()",
"patch_to_review": "diff --git a/haystack/__init__.py b/haystack/__init__.py\nindex 5dad0c9bb7..10227eb803 100644\n--- a/haystack/__init__.py\n+++ b/haysta... | [
{
"diff_hunk": "@@ -10,6 +10,7 @@\n import pickle\n import urllib\n from functools import wraps\n+from networkx.algorithms.boundary import node_boundary",
"line": null,
"original_line": 13,
"original_start_line": null,
"path": "haystack/pipeline.py",
"start_line": null,
"text": "@user1:\... | 66c771bf9d7836557630709259a93f4befb2d419 | diff --git a/docs/_src/api/api/pipelines.md b/docs/_src/api/api/pipelines.md
index d1c7c3204f..747e54cf94 100644
--- a/docs/_src/api/api/pipelines.md
+++ b/docs/_src/api/api/pipelines.md
@@ -121,6 +121,34 @@ Set the component for a node in the Pipeline.
- `name`: The name of the node.
- `component`: The component obj... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-9349@d93b36b | dbt-labs/dbt-core | Python | 9,349 | Update implementation-ticket.yml | resolves #9348
### Problem
We spend time in estimation meetings talking about what specific tickets should be testing,
### Solution
Add a specific section for testing to our template.
### Checklist
- [ ] I have read [the contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.... | 2024-01-08T19:44:08Z | [CT-3531] Add testing section to Implementation template
### Housekeeping
- [X] I am a maintainer of dbt-core
### Short description
Add a "Suggested Tests" section to the implementation issue template.
### Acceptance criteria
"Suggested Tests" section to the implementation issue template.
### Impact to Other Te... | [
{
"body": "### Housekeeping\n\n- [X] I am a maintainer of dbt-core\n\n### Short description\n\nAdd a \"Suggested Tests\" section to the implementation issue template. \n\n### Acceptance criteria\n\n\"Suggested Tests\" section to the implementation issue template.\n\n### Impact to Other Teams\n\nNone\n\n### Wil... | 125982a4adaca2048e7838273b9e2ffad2cbe55f | {
"head_commit": "d93b36b2122ac9733ad3c6020621a9b32765c1d9",
"head_commit_message": "Update implementation-ticket.yml",
"patch_to_review": "diff --git a/.github/ISSUE_TEMPLATE/implementation-ticket.yml b/.github/ISSUE_TEMPLATE/implementation-ticket.yml\nindex e5bfaaa45e5..4187816d1fe 100644\n--- a/.github/ISSUE_T... | [
{
"diff_hunk": "@@ -30,6 +30,17 @@ body:\n What is the definition of done for this ticket? Include any relevant edge cases and/or test cases\n validations:\n required: true\n+ - type: textarea\n+ attributes:\n+ label: Suggested Tests\n+ description: |\n+ Provide scenarios ... | 4fb489304f745c7e76b65e1b6c1ab9b654cd21ba | diff --git a/.github/ISSUE_TEMPLATE/implementation-ticket.yml b/.github/ISSUE_TEMPLATE/implementation-ticket.yml
index e5bfaaa45e5..dd22441cd22 100644
--- a/.github/ISSUE_TEMPLATE/implementation-ticket.yml
+++ b/.github/ISSUE_TEMPLATE/implementation-ticket.yml
@@ -30,6 +30,16 @@ body:
What is the definition of... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Test Suite / CI Enhancements"
} | |
deepset-ai__haystack-1569@ace1289 | deepset-ai/haystack | Python | 1,569 | Cosine similarity for the rest of DocStores. | **Proposed changes**:
- as per https://github.com/deepset-ai/haystack/issues/1539#issuecomment-936979286
**Status (please check what you already did)**:
- [V ] First draft (up for discussions & feedback)
- [ ] Final code
- [ ] Added tests
- [ ] Updated documentation
| 2021-10-07T09:06:32Z | Implementing cosine similarity in Milvus and Weaviate doc stores
**Is your feature request related to a problem? Please describe.**
In Milvus docstore's documentation, it's mentioned that cosine similarity is not supported. In Weaviate's there is no mention of that fact, but from the source codes it can be seen that t... | Hi @fingoldo! I think it would definitely be nice to support cosine similarity across all document stores, given that it is recommended to use cosine similarity with sentence-transformers models. Nice that you already provided a way how this could be implemented! One minor thing: I think faiss' normalize_l2 method norm... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIn Milvus docstore's documentation, it's mentioned that cosine similarity is not supported. In Weaviate's there is no mention of that fact, but from the source codes it can be seen that the similarity parameter is not used anywhere... | 9025615be78218f99df87002abb4af798c5d7ffa | {
"head_commit": "ace128971cc95f5e8e84264447edbb1b8203be36",
"head_commit_message": "Fixed scores representation for cosine. Assuming Weavieate's rep needs no change.",
"patch_to_review": "diff --git a/haystack/document_store/base.py b/haystack/document_store/base.py\nindex 0a68fc529a..75fa5f9eac 100644\n--- a/ha... | [
{
"diff_hunk": "@@ -246,3 +250,23 @@ def get_batches_from_generator(iterable, n):\n while x:\n yield x\n x = tuple(islice(it, n))\n+\n+@njit(fastmath=True)\n+def normalize_vector_l2(emb: np.ndarray)->None:",
"line": null,
"original_line": 255,
"original_start_line": null,
"pa... | 67f4af1f1d426ac8cfde3a3ea3d01685431e5c5c | diff --git a/docs/_src/api/api/document_store.md b/docs/_src/api/api/document_store.md
index 90d20360a0..f9edc8ee62 100644
--- a/docs/_src/api/api/document_store.md
+++ b/docs/_src/api/api/document_store.md
@@ -100,6 +100,16 @@ object, provided that they have the same product_id (to be found in Label.meta["
:param TOD... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1360@413b24b | deepset-ai/haystack | Python | 1,360 | Add Crawler support for indexing pipeline | **Proposed changes**:
- Add Crawler support for index pipeline
**Status (please check what you already did)**:
- [X] First draft (up for discussions & feedback)
- [X] Added tests
closes #1322 | 2021-08-20T10:34:42Z | Add Crawler support for Indexing Pipelines
In the current implementation, `Crawler.crawl()` writes documents to JSON files and returns their paths.
Adding an option to return documents will enable connecting a Crawler in an Indexing Pipeline where crawled documents can be indexed directly to a document store. | [
{
"body": "In the current implementation, `Crawler.crawl()` writes documents to JSON files and returns their paths.\r\n\r\nAdding an option to return documents will enable connecting a Crawler in an Indexing Pipeline where crawled documents can be indexed directly to a document store.",
"number": 1322,
... | ff2049cd4535e5bbd199f1f13a55f86dd53c31ff | {
"head_commit": "413b24bd71c412aaaceee826cd5a2420add1935b",
"head_commit_message": "[crawler] Url updated.",
"patch_to_review": "diff --git a/haystack/connector/crawler.py b/haystack/connector/crawler.py\nindex d1809d71a4..f8a8cf01c2 100644\n--- a/haystack/connector/crawler.py\n+++ b/haystack/connector/crawler.p... | [
{
"diff_hunk": "@@ -98,32 +100,32 @@ def crawl(self, output_dir: Union[str, Path, None] = None,\n if not output_dir.exists():\n output_dir.mkdir(parents=True)\n \n+ crawled_data: list = []\n is_not_empty = len(list(output_dir.rglob(\"*\"))) > 0\n if is_not_empty and n... | 434649149a60e3e4b616d39a19779c6f5ba53f4c | diff --git a/haystack/connector/crawler.py b/haystack/connector/crawler.py
index d1809d71a4..4f29235cbe 100644
--- a/haystack/connector/crawler.py
+++ b/haystack/connector/crawler.py
@@ -98,22 +98,19 @@ def crawl(self, output_dir: Union[str, Path, None] = None,
if not output_dir.exists():
output_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-1131@a74014c | deepset-ai/haystack | Python | 1,131 | Add docu of confidence scores and calibration method | **Proposed changes**:
- Add more detailed documentation of confidence calibration to the reader's usage page.
- Add `calibrate_confidence_scores()` method to reader, which internally calls `eval()` method
closes #1032 | 2021-06-02T10:03:54Z | Simplify usage of confidence scores & add documentation
With # we introduced an option to get more reliable confidence scores for predictions from a QA model / reader.
So far the usage in Haystack seems not well documented and calibrating scores is not easily accessible.
Calibration would probably look something lik... | [
{
"body": "With # we introduced an option to get more reliable confidence scores for predictions from a QA model / reader. \n\nSo far the usage in Haystack seems not well documented and calibrating scores is not easily accessible. \nCalibration would probably look something like this: \n\n```\n evaluator_dev... | 022f8586f60b084b843d89c9bd56a0794645d5c0 | {
"head_commit": "a74014ce9381e33daabf98c62fdeef90386fbaf4",
"head_commit_message": "Explain label \"0\" and \"1\" of TextPairClassifier in Ranker",
"patch_to_review": "diff --git a/docs/_src/usage/usage/ranker.md b/docs/_src/usage/usage/ranker.md\nindex d21dc21eea..e829dcfbfd 100644\n--- a/docs/_src/usage/usage/... | [
{
"diff_hunk": "@@ -263,17 +263,22 @@ print_answers(prediction, details=\"all\")\n 'She travels with her father, Eddard, to '\n \"King's Landing when he is made Hand of the \"\n 'King. Before she leaves,',\n- 'probability': 0.989983... | 2c8a60a0dc888761e636c458e0ec05308887d79a | diff --git a/docs/_src/usage/usage/reader.md b/docs/_src/usage/usage/reader.md
index f764805ffb..2cd26d352a 100644
--- a/docs/_src/usage/usage/reader.md
+++ b/docs/_src/usage/usage/reader.md
@@ -247,7 +247,7 @@ When printing the full results of a Reader,
you will see that each prediction is accompanied
by a value in... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
deepset-ai__haystack-1025@9ddab22 | deepset-ai/haystack | Python | 1,025 | Re-ranking component for document search without QA | Ranker component that re-ranks results of a retriever. The eval() method of the Ranker is not implemented. Instead, the EvalRetriever pipeline node is renamed to EvalDocuments and works for both Retriever and Ranker nodes. For consistency, I also renamed the EvalReader node to EvalAnswers.
The train() method of the R... | 2021-05-03T16:29:42Z | Add re-ranking for pure document search
To better support pure "semantic document search" without QA functionality we could add a `Ranker` Class in Haystack that gets docs from the retriever and reranks them.
Sketch:
```
ranker = Ranker(model="roberta-xxx--xxx")
finder = Finder(retriever, ranker)
finder.get_document... | This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. | [
{
"body": "To better support pure \"semantic document search\" without QA functionality we could add a `Ranker` Class in Haystack that gets docs from the retriever and reranks them.\n\nSketch:\n``` \nranker = Ranker(model=\"roberta-xxx--xxx\")\nfinder = Finder(retriever, ranker)\nfinder.get_documents()\n```",
... | c41101ff747bc5f7025ddaa6617ff292808c6368 | {
"head_commit": "9ddab225bd222c15a86795bb6d2dcec45080fc55",
"head_commit_message": "Add documentation of k parameter in EvalDocuments",
"patch_to_review": "diff --git a/docs/_src/tutorials/tutorials/5.md b/docs/_src/tutorials/tutorials/5.md\nindex 97668294a2..9ddcf525a6 100644\n--- a/docs/_src/tutorials/tutorial... | [
{
"diff_hunk": "@@ -0,0 +1,268 @@\n+import logging\n+import multiprocessing\n+from pathlib import Path\n+from typing import List, Optional, Union\n+\n+from farm.data_handler.data_silo import DataSilo\n+from farm.data_handler.processor import TextPairClassificationProcessor\n+from farm.infer import Inferencer\n+... | 184da889cc5bb87376e697d7d6a5dd2aa9018bfc | diff --git a/README.md b/README.md
index dc7933f4ad..8d2ebc7ff7 100644
--- a/README.md
+++ b/README.md
@@ -164,12 +164,13 @@ We recommend Elasticsearch or FAISS but also have more light-weight options for
Retrievers narrow down the search space significantly and are therefore crucial for scalable QA.
Haystack... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1003@5e15b1d | deepset-ai/haystack | Python | 1,003 | Add export of Pipeline YAML config | ## Imlementation
This PR adds an `export_to_yaml()` method for the Pipeline class to create a YAML configuration for a loaded `Pipeline` instance.
Under-the-hood, the `BaseComponent` saves the init parameters used to create a Component. These parameters are put together in `export_to_yaml() `to create the complete... | 2021-04-27T10:13:13Z | Saving Pipeline to YAML
**Question**
Hello everyone , I am looking for a way to save entire pipeline (retriever, reader) so that i can use that later . Like saving deep learning models into h5 is there anyway we can do this to the pipeline?
**Additional context**
Add any other context or screenshots about the questi... | Hi @SasikiranJ, thank you for raising the issue. It's indeed a feature that would be helpful in many cases and we have it in the backlog with #599. I'll update here when it is implemented. | [
{
"body": "**Question**\r\nHello everyone , I am looking for a way to save entire pipeline (retriever, reader) so that i can use that later . Like saving deep learning models into h5 is there anyway we can do this to the pipeline?\r\n**Additional context**\r\nAdd any other context or screenshots about the quest... | 65f1da00cc4b6757752dafb8bf756531fad46dd0 | {
"head_commit": "5e15b1d282d09742e91ae7e97413e52ab839be37",
"head_commit_message": "Fix export for case when a parameter can be a dict",
"patch_to_review": "diff --git a/haystack/document_store/elasticsearch.py b/haystack/document_store/elasticsearch.py\nindex 9ec567e200..29c8ce50bd 100644\n--- a/haystack/docume... | [
{
"diff_hunk": "@@ -258,4 +260,21 @@ def run(self, *args: Any, **kwargs: Any):\n :param kwargs:\n :return:\n \"\"\"\n- pass\n\\ No newline at end of file\n+ pass\n+\n+ def set_pipeline_config(self, **kwargs):",
"line": null,
"original_line": 265,
"original_st... | 95e4f5e7ea0408ddd1e27ba58eeba55965733776 | diff --git a/haystack/document_store/elasticsearch.py b/haystack/document_store/elasticsearch.py
index 9ec567e200..e22e14e6c3 100644
--- a/haystack/document_store/elasticsearch.py
+++ b/haystack/document_store/elasticsearch.py
@@ -94,6 +94,16 @@ def __init__(
:param return_embedding: To return document embeddi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
cvat-ai__cvat-4062@ff04d8f | cvat-ai/cvat | Python | 4,062 | Added support of ellipses | <!---
Copyright (C) 2020-2021 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes wil... | 2021-12-22T13:11:48Z | Circle/Ellipse-shape annotation
Hi,
I am trying to label some circular objects. It would be nice if CVAT supports ellipse and/or circle annotation.
The following shapes would be useful:
- Center circle (two points: center and point on circle)
- Three-point circle (three points on circle)
- Center ellipse (thr... | Hi. Yes, I believe it is a useful request.
Let me know if you can help us with the implementation.
+1. "Center ellipse" tool would be most useful for our use case (digitizing traffic signs)
@nmanovic @bsekachev I am interested in implementing circular shapes. There are two possibilities:
* When the user adds a circ... | [
{
"body": "Hi,\r\n\r\nI am trying to label some circular objects. It would be nice if CVAT supports ellipse and/or circle annotation. \r\n\r\nThe following shapes would be useful:\r\n- Center circle (two points: center and point on circle)\r\n- Three-point circle (three points on circle)\r\n- Center ellipse (th... | 40f05b27f1a8592cc872ede7aa33591fd3f82e28 | {
"head_commit": "ff04d8f112090583be262d9d5ad1b0f85a3a5b82",
"head_commit_message": "Fixed statistics test",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 2d6f3b2a75fb..7bdd38a997a8 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versio... | [
{
"diff_hunk": "@@ -32,3 +35,16 @@ def transform_item(self, item):\n z_order=ann.z_order))\n \n return item.wrap(annotations=annotations)\n+\n+class EllipsesToMasks(ItemTransform):",
"line": null,
"original_line": 39,
"original_start_line": null,
"path": "cvat/apps/datase... | a28841fcd0f23dccad6352c8cafa79bf94455df8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index b0472d8a7478..00bd2498a4e1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- User is able to customize information that text labels show (<https://github.com/openvinotoolkit/cv... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-1413@fc3b61a | deepset-ai/haystack | Python | 1,413 | MostSimilarDocumentsPipeline introduced | **Proposed changes**:
- New pipeline `MostSimilarDocumentsPipeline` introduced. which helps users to find similar documents using document ids.
**Status (please check what you already did)**:
- [X] Final code
- [X] Added tests
closes #1091 | 2021-09-05T09:25:57Z | MostSimilarDocumentsPipeline -Functionality to get top n documents by document Id rather than a query
**What**
Is there an existing functionality to get top n documents by document Id rather than a query or is it possible to combine existing functionality to achieve this? | Hey @monika1800
If you just want to get documents I would not use our query functionality of the retrievers. Retrievers always want to combine a search query to retrieve relevant documents.
What you are looking for is the inside our document store directly.
We have `document_store.get_document_by_id()`
and `doc... | [
{
"body": "**What**\r\n\r\nIs there an existing functionality to get top n documents by document Id rather than a query or is it possible to combine existing functionality to achieve this?",
"number": 1091,
"title": "MostSimilarDocumentsPipeline -Functionality to get top n documents by document Id rath... | 3deff26b6057cb9213cb1707cc04acc9849d59d9 | {
"head_commit": "fc3b61a3cf6ae7fd384a58bcf7d0db1462ac391b",
"head_commit_message": "[pipeline] test cases added.",
"patch_to_review": "diff --git a/haystack/pipeline.py b/haystack/pipeline.py\nindex 577d095559..09c74053c4 100644\n--- a/haystack/pipeline.py\n+++ b/haystack/pipeline.py\n@@ -28,6 +28,7 @@\n \n from... | [
{
"diff_hunk": "@@ -1287,4 +1288,31 @@ def run(self, query, documents, **kwargs):\n # Pass also the other incoming kwargs so that future nodes still have access to it\n output.update(**kwargs)\n \n- return output, \"output_1\"\n\\ No newline at end of file\n+ return output, \"outpu... | ac718260a51758cc856a91f7ff36fafc5040cf61 | diff --git a/haystack/pipeline.py b/haystack/pipeline.py
index 99c5e275c6..8e74a933ad 100644
--- a/haystack/pipeline.py
+++ b/haystack/pipeline.py
@@ -28,6 +28,7 @@
from haystack import BaseComponent, MultiLabel, Document
from haystack.generator.base import BaseGenerator
+from haystack.document_store.base import Ba... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
deepset-ai__haystack-978@c738035 | deepset-ai/haystack | Python | 978 | Fix update_embeddings() for FAISSDocumentStore | There are three main use cases for `update_embeddings()`:
1. Creating embeddings in a new document store after writing the documents. In this case, embeddings are created for all the documents in the document store. The default parameters for update_embeddings() are sufficient for this case.
2. Incremental update... | 2021-04-19T10:31:40Z | Update Embeddings in FAISS
In the `FAISSDocumentStore`, the `update_embeddings()` has a parameter `update_existing_embeddings` to decide if existing embeddings get overwritten. Since the current implementation of FAISS do not allow updating existing embeddings, we should ensure that the FAISS index must get reset when ... | [
{
"body": "In the `FAISSDocumentStore`, the `update_embeddings()` has a parameter `update_existing_embeddings` to decide if existing embeddings get overwritten. Since the current implementation of FAISS do not allow updating existing embeddings, we should ensure that the FAISS index must get reset when `update_... | 4dd5a7a744f8e2271a6b1256c9045e86b230dfe7 | {
"head_commit": "c7380353958c7594ed8a7814f1230d5ddc69b7e2",
"head_commit_message": "Reset Milvus for tests",
"patch_to_review": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex fad0b03a05..a2039eba57 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -77,7 +77,7 @@... | [
{
"diff_hunk": "@@ -199,6 +199,14 @@ def update_embeddings(\n \"\"\"\n \n index = index or self.index\n+\n+ if update_existing_embeddings is True:\n+ if filters is None:\n+ self.faiss_indexes[index].reset()\n+ self.reset_vector_ids(index)\n+ ... | 189d80053b2647cfcc28b90880a6b48fe830f4c7 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index fad0b03a05..a2039eba57 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -77,7 +77,7 @@ jobs:
run: docker run -d -p 19530:19530 -p 19121:19121 milvusdb/milvus:1.0.0-cpu-d030521-1ea92e
- name: Run GraphDB
- ru... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-976@ee92750 | deepset-ai/haystack | Python | 976 | Update Documentation | Let's update our documentation so that the website better reflects the latest developments in Haystack.
The main changes are:
- Describing Haystack as Search instead of QA
- Replacing Finder with Pipelines
- Summarizer
- Translator
- Crawler
- Evaluation Nodes
- Pipeline Yaml config example
- Adding import s... | 2021-04-16T10:01:00Z | Haystack Documentation Backlog
Let's update the usage and API documentation for the following new components:
Summarizer
Translator
Squad to DPR script (Tutorial 9)
Knowledge Graph
Confidence
Evaluation
Website API and Usage for KG
Eval Nodes
Pipeline Config
Confidence Scores
Web Crawler
Add Import st... | I love the usage example snippets and would love to see more there. Its extremely helpful to code things fast.
Could we also add import statements to those usage examples?
Adding imports is a good idea for sure. I think I like having code snippets inside the Usage pages, but I can also imagine it would be useful to ... | [
{
"body": "Let's update the usage and API documentation for the following new components:\r\n\r\nSummarizer\r\nTranslator\r\nSquad to DPR script (Tutorial 9)\r\nKnowledge Graph\r\nConfidence\r\nEvaluation\r\n\r\nWebsite API and Usage for KG\r\nEval Nodes\r\nPipeline Config\r\nConfidence Scores\r\nWeb Crawler\r\... | 4dd5a7a744f8e2271a6b1256c9045e86b230dfe7 | {
"head_commit": "ee92750e67b63a308754dc5d4e5f02106f050ef2",
"head_commit_message": "Update tutorial link",
"patch_to_review": "diff --git a/docs/_src/api/api/crawler.md b/docs/_src/api/api/crawler.md\nnew file mode 100644\nindex 0000000000..2f852cdde7\n--- /dev/null\n+++ b/docs/_src/api/api/crawler.md\n@@ -0,0 +... | [
{
"diff_hunk": "@@ -0,0 +1,92 @@\n+<a name=\"eval\"></a>\n+# Module eval\n+\n+<a name=\"eval.EvalRetriever\"></a>\n+## EvalRetriever Objects\n+\n+```python\n+class EvalRetriever()\n+```\n+\n+This is a pipeline node that should be placed after a Retriever in order to assess its performance. Performance\n+metrics... | 89a2251bbbb0b69f6e5d0b6e5ac60c1792497af1 | diff --git a/docs/_src/api/api/crawler.md b/docs/_src/api/api/crawler.md
new file mode 100644
index 0000000000..2f852cdde7
--- /dev/null
+++ b/docs/_src/api/api/crawler.md
@@ -0,0 +1,95 @@
+<a name="crawler"></a>
+# Module crawler
+
+<a name="crawler.Crawler"></a>
+## Crawler Objects
+
+```python
+class Crawler(BaseCom... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
deepset-ai__haystack-556@eaadd75 | deepset-ai/haystack | Python | 556 | Add support for MySQL database | This PR adds makes the `SQLDocumentStore` more generic to work with MySQL database.
Resolves #543. | 2020-11-05T14:02:45Z | FAISSDocumentStore + mysql 5.7
Hi guys,
Hope you are all well !
I tried to setup a mysql connector to the FAISSDocumentStore but it triggers the following error:
```sh
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/sql/compiler.py", line 2904, in visit_create_tab... | [
{
"body": "Hi guys,\r\n\r\nHope you are all well !\r\n\r\nI tried to setup a mysql connector to the FAISSDocumentStore but it triggers the following error:\r\n\r\n```sh\r\nTraceback (most recent call last):\r\n File \"/usr/local/lib/python3.7/dist-packages/sqlalchemy/sql/compiler.py\", line 2904, in visit_crea... | 727767388ae3669993ba12d9f7cb8acf47324e84 | {
"head_commit": "eaadd75c5f69c85f37cf0a8a5075f09d457f6162",
"head_commit_message": "Revert change to UUID type for IDs",
"patch_to_review": "diff --git a/haystack/document_store/sql.py b/haystack/document_store/sql.py\nindex a2746f8747..931d2b974a 100644\n--- a/haystack/document_store/sql.py\n+++ b/haystack/docu... | [
{
"diff_hunk": "@@ -16,42 +16,43 @@\n class ORMBase(Base):\n __abstract__ = True\n \n- id = Column(String, default=lambda: str(uuid4()), primary_key=True)\n+ id = Column(String(100), default=lambda: str(uuid4()), primary_key=True)\n created = Column(DateTime, server_default=func.now())\n updat... | a4dfeec57e6450d7da063d481fc69159931a2f81 | diff --git a/haystack/document_store/sql.py b/haystack/document_store/sql.py
index a2746f8747..30d2a478e9 100644
--- a/haystack/document_store/sql.py
+++ b/haystack/document_store/sql.py
@@ -1,7 +1,7 @@
from typing import Any, Dict, Union, List, Optional
from uuid import uuid4
-from sqlalchemy import create_engine,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
deepset-ai__haystack-524@e763a92 | deepset-ai/haystack | Python | 524 | Make returning predictions in evaluation possible | This PR adds an option for Finder and Retriever evaluation to return the predictions when doing evaluation. | 2020-10-27T15:45:08Z | Returning the evaluation result as a dictionary
I would like to propose a feature for **evaluation of finder**, currently, in the finder evaluation, we receive summary results comprising of evaluation metrics and answers missed out by retriever and reader. I would like to know whether it is possible to get evaluation f... | Should be possible. What would be your use case? Calculating own metrics on the results?
Hello @tholor . I have **two** use case in particular. First I want to check **Exact Match** of my answers, there could be a case, the returned answer **skips** last portion of the string (as given in my evaluation json file), this... | [
{
"body": "I would like to propose a feature for **evaluation of finder**, currently, in the finder evaluation, we receive summary results comprising of evaluation metrics and answers missed out by retriever and reader. I would like to know whether it is possible to get evaluation for question stored in form of... | 4fa5d9c3eba860ef0a85c46465b9ff1902ebfa12 | {
"head_commit": "e763a92299222a01d8ee4fb64a96a10be0c5c7df",
"head_commit_message": "Make returning preds in evaluation possible",
"patch_to_review": "diff --git a/haystack/finder.py b/haystack/finder.py\nindex 4ead6911c7..c14ef75088 100644\n--- a/haystack/finder.py\n+++ b/haystack/finder.py\n@@ -121,6 +121,7 @@ ... | [
{
"diff_hunk": "@@ -363,7 +380,10 @@ def _retrieve_docs(self, questions: List[MultiLabel], top_k: int, doc_index: str\n \n \n @staticmethod\n- def print_eval_results(finder_eval_results: Dict):\n+ def print_eval_results(finder_eval_results: Dict, contains_preds: bool = False):\n+ if contains_pr... | b3c058fc5d5c4a026fe1ffb43400848c043f5e3b | diff --git a/haystack/finder.py b/haystack/finder.py
index 4ead6911c7..94a389dd95 100644
--- a/haystack/finder.py
+++ b/haystack/finder.py
@@ -121,6 +121,7 @@ def eval(
label_origin: str = "gold_label",
top_k_retriever: int = 10,
top_k_reader: int = 10,
+ return_preds: bool = False,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
cvat-ai__cvat-3381@2a32f00 | cvat-ai/cvat | Python | 3,381 | Make function get_progress be compatible with more video format | * Add function _get_duration with VideoReader
* Update function get_progress of VideoReader
<!---
Copyright (C) 2020-2021 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It will help avoiding duplication of efforts from... | 2021-07-01T05:28:40Z | get_prpgress function of VideoReader can compatible with more video format
<!---
Copyright (C) 2020 Intel Corporation
SPDX-License-Identifier: MIT
-->
### My actions before raising this issue
while extract from video with typical format, like mkv, it can't show precise progress. Like shown in the code:
```pyt... | @Thatwho Hi, thanks for the suggestion, would you like to prepare a PR for this?
> @Thatwho Hi, thanks for the suggestion, would you like to prepare a PR for this?
Of course! I had made a PR which is #3381. Please let me know the PR has any error. | [
{
"body": "<!---\r\nCopyright (C) 2020 Intel Corporation\r\n\r\nSPDX-License-Identifier: MIT\r\n-->\r\n\r\n### My actions before raising this issue\r\nwhile extract from video with typical format, like mkv, it can't show precise progress. Like shown in the code:\r\n```python\r\n def get_progress(self, pos):\... | 7f4b1853aba06584afb7698bd07358cb2f4ae7ca | {
"head_commit": "2a32f00cab7a4e3d769129d17bdb54adfc04a28a",
"head_commit_message": "Make function get_progress be compatible with more video format\n* Add function _get_duration with VideoReader\n* Update function get_progress of VideoReader",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 9... | [
{
"diff_hunk": "@@ -42,6 +42,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0\n - Duplication of the cuboids when redraw them (<https://github.com/openvinotoolkit/cvat/pull/3308>)\n - Some code issues in Deep Extreme Cut handler code (<https://github.com/openvinotoolkit/cvat... | 9d3d8cc27f7c7d81bcc48657e75fd7eb52966a44 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 528af0fec7c0..1af1255db815 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -42,6 +42,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Duplication of the cuboids when redraw them (<https://github.com/openvinotoolkit/cvat/pull/3308>)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
deepset-ai__haystack-92@accd8b1 | deepset-ai/haystack | Python | 92 | Provide Evaluation | 2020-05-04T13:10:56Z | Adding evaluation to Reader, Retriever & Finder
In order to compare different QA pipelines, evaluation is a core requirement.
While this is quite simple on the isolated Reader, we are more interested in the big picture of the whole pipeline & the interaction with the retriever.
## Requirements:
- Eval metrics... | [
{
"body": "In order to compare different QA pipelines, evaluation is a core requirement. \r\nWhile this is quite simple on the isolated Reader, we are more interested in the big picture of the whole pipeline & the interaction with the retriever. \r\n\r\n## Requirements: \r\n- Eval metrics of retriever should r... | f4455ee42facc96db8fc43f94038d6be8f05530f | {
"head_commit": "accd8b1860c41d894121ffc57e9198cd0f476959",
"head_commit_message": "Add data for tutorial to S3",
"patch_to_review": "diff --git a/README.rst b/README.rst\nindex 9cc77688f2..3d1167b25c 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -55,10 +55,13 @@ Components\n \n Resources\n =========\n-- Tutori... | [
{
"diff_hunk": "@@ -41,12 +41,58 @@ def __init__(self, document_store: Type[BaseDocumentStore], custom_query: str =\n self.document_store = document_store\n self.custom_query = custom_query\n \n- def retrieve(self, query: str, filters: dict = None, top_k: int = 10) -> [Document]:\n- do... | 5af75269b9b55d35b6cd49668af0cbff89d914bb | diff --git a/README.rst b/README.rst
index 9cc77688f2..3d1167b25c 100644
--- a/README.rst
+++ b/README.rst
@@ -55,10 +55,13 @@ Components
Resources
=========
-- Tutorial 1 - Basic QA Pipeline: `Jupyter notebook <https://github.com/deepset-ai/haystack/blob/master/tutorials/Tutorial1_Basic_QA_Pipeline.ipynb>`__ or... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | ||
dbt-labs__dbt-core-9031@2e84dc0 | dbt-labs/dbt-core | Python | 9,031 | Cache plugin modules | resolves #9029
Local results:
- Before: make integration 1377.96s user 124.94s system 834% cpu 3:00.16 total
- After: make integration 1057.26s user 61.76s system 719% cpu 2:35.55 total
### Problem
Scanning all available python modules is slow.
### Solution
For the purposes of detecting dbt plugins... | 2023-11-08T00:12:01Z | [CT-3336] [Test Performance] Optimize the set_up_plugin_manager() function
### Short description
Profiling shows that the set_up_plugin_manager() function takes up 30% of the runtime on the main thread during integration testing. The hot path is set_up_plugin_manager() -> from_modules() -> iter_modules(). By caching... | [
{
"body": "### Short description\r\n\r\nProfiling shows that the set_up_plugin_manager() function takes up 30% of the runtime on the main thread during integration testing. The hot path is set_up_plugin_manager() -> from_modules() -> iter_modules(). By caching the results we need after the first time iter_modul... | 1c9cec17878ca0fec537a4cc13812f91ee97b29b | {
"head_commit": "2e84dc0e18c5437b24f2842fcf9088c003224dc1",
"head_commit_message": "Add changelog entry",
"patch_to_review": "diff --git a/.changes/unreleased/Under the Hood-20231107-191546.yaml b/.changes/unreleased/Under the Hood-20231107-191546.yaml\nnew file mode 100644\nindex 00000000000..d81c0448c63\n--- /... | [
{
"diff_hunk": "@@ -63,6 +65,17 @@ def get_manifest_artifacts(self, manifest: Manifest) -> PluginArtifacts:\n raise NotImplementedError(f\"get_manifest_artifacts hook not implemented for {self.name}\")\n \n \n+@functools.cache",
"line": null,
"original_line": 68,
"original_start_line": null,... | a323ab51eb47dd792fa4a530670bd1dba4cea3d0 | diff --git a/.changes/unreleased/Under the Hood-20231107-191546.yaml b/.changes/unreleased/Under the Hood-20231107-191546.yaml
new file mode 100644
index 00000000000..d81c0448c63
--- /dev/null
+++ b/.changes/unreleased/Under the Hood-20231107-191546.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Cache dbt plugin mo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
cvat-ai__cvat-2154@5016c5b | cvat-ai/cvat | Python | 2,154 | Update media extractors | <!---
Copyright (C) 2020 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It will help avoiding duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will... | 2020-09-08T18:41:50Z | Loading PDF. RAM consumption.
When I upload a large PDF file (for example a book with 300 pages), memory usage become incredible.
It takes all available RAM (about 16 gigabytes), starts to use swap and my system literally die.
Probably we should not store all pages in memory during extraction | [
{
"body": "When I upload a large PDF file (for example a book with 300 pages), memory usage become incredible.\r\nIt takes all available RAM (about 16 gigabytes), starts to use swap and my system literally die. \r\n\r\nProbably we should not store all pages in memory during extraction",
"number": 940,
"... | c2b17a0b34841692ce7cbe3316868efe05d1f6bc | {
"head_commit": "5016c5b03cc997ae2d249fdd41b63361906129b9",
"head_commit_message": "Merge branch 'develop' into zm/update-extractors",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex ec03b776985e..9a6294bdaea8 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -31,6 +31,7 @@ and this project ... | [
{
"diff_hunk": "@@ -65,9 +66,16 @@ def _get_preview(obj):\n return preview.convert('RGB')\n \n @abstractmethod\n- def get_image_size(self):\n+ def get_image_size(self, i):\n pass\n \n+ def __len__(self):\n+ return (self._stop - self._start) // self._step",
"line": null,
... | b72fd19268759510ae336f0e41ed06c4d43f1515 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ec03b776985e..9a6294bdaea8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed multiple errors which arises when polygon is of length 5 or less (<https://github.com/opencv/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
dbt-labs__dbt-core-8762@7100ff9 | dbt-labs/dbt-core | Python | 8,762 | [Fix] respect project root when loading seeds | resolves https://github.com/dbt-labs/dbt-core/issues/6875
<!---
Include the number of the issue addressed by this PR above if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
Add the `user docs` label to this PR if it will need... | 2023-10-03T19:11:18Z | [CT-2042] Enable seeds to be handled from stored manifest data
Right now we don't store the content of a seed file, we just store a checksum of the content or just the path if the size of the seed exceeds 1 megabyte. The seed is retrieved later using the absolute path of the file. This is not functional for a world in... | My instinct here is that we should start storing raw seed contents up to 1 MB. For any seeds that are larger, we should continue storing only the file path pointing to that seed.
That would be consistent with the behavior we've established for detecting seed modifications in `state:modified`: comparing a checksum of... | [
{
"body": "Right now we don't store the content of a seed file, we just store a checksum of the content or just the path if the size of the seed exceeds 1 megabyte. The seed is retrieved later using the absolute path of the file. This is not functional for a world in which files can come from a file diff and w... | 70b2e15a2563808361c1ffec19cfe7c35123cbe8 | {
"head_commit": "7100ff953ca53de53503b7ff30d4f1b65c778bdf",
"head_commit_message": "preserve relative path in seed root_path",
"patch_to_review": "diff --git a/core/dbt/context/providers.py b/core/dbt/context/providers.py\nindex 996d5027c58..1d4820ee52e 100644\n--- a/core/dbt/context/providers.py\n+++ b/core/dbt... | [
{
"diff_hunk": "@@ -8,7 +10,7 @@\n class SeedParser(SimpleSQLParser[SeedNode]):\n def parse_from_dict(self, dct, validate=True) -> SeedNode:\n # seeds need the root_path because the contents are not loaded\n- dct[\"root_path\"] = self.project.project_root\n+ dct[\"root_path\"] = relpat... | f778deceaa3f44c73973e02ff69c93e3434c0fe9 | diff --git a/.changes/unreleased/Fixes-20231006-134551.yaml b/.changes/unreleased/Fixes-20231006-134551.yaml
new file mode 100644
index 00000000000..9dea4f6e194
--- /dev/null
+++ b/.changes/unreleased/Fixes-20231006-134551.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Enable seeds to be handled from stored manifest data
+ti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
dbt-labs__dbt-core-8743@fb6f32f | dbt-labs/dbt-core | Python | 8,743 | Enable inline csv format in unit testing | resolves #8626
### Problem
Users want to be able to use the csv format in addition to dictionaries in their unit tests.
### Solution
Add a "format" field to the given and expect structure, create an OutputFixture class (in addition to InputFixture).
### Checklist
- [x] I have read [the contributing g... | 2023-09-28T20:30:15Z | [CT-3110] [Implementation] Support a configurable `format: csv` attribute on a `given` input and `expect` fixtures in unit tests
### Acceptance Criteria:
* extend the existing unit test spec to support `format: csv`
* by default, the format should be `dict`
* support supplying __inline__ csv strings when format... | > It could be annoying to always have to specify format: csv in every given and expect configuration when the project has a general preference for csv over dict @graciegoheen. Perhaps a top-level fixtures config in dbt_project.yml?
@MichelleArk Yep, I think you're instinct is correct here. We should allow folks to o... | [
{
"body": "### Acceptance Criteria:\r\n* extend the existing unit test spec to support `format: csv` \r\n * by default, the format should be `dict` \r\n* support supplying __inline__ csv strings when format is `csv`\r\n```\r\nunit:\r\n - model: my_model\r\n tests:\r\n - name: test_my_model\r\n ... | bb6fd3029b5bf2fcdbb540528f0ff7ccebc50a41 | {
"head_commit": "fb6f32f5ff1ce910009089732ccc1592dda07f2e",
"head_commit_message": "Move format/rows validation to class method in UnitTestFixture",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20230928-163205.yaml b/.changes/unreleased/Features-20230928-163205.yaml\nnew file mode 100644\nindex ... | [
{
"diff_hunk": "@@ -736,10 +738,54 @@ def normalize_date(d: Optional[datetime.date]) -> Optional[datetime.datetime]:\n return dt\n \n \n+class UnitTestFormat(StrEnum):\n+ CSV = \"csv\"\n+ Dict = \"dict\"\n+\n+\n+class UnitTestFixture:\n+ @property\n+ def format(self) -> UnitTestFormat:\n+ ... | ada13fb92dbb9af8dc5a43105b49e5647111bee7 | diff --git a/.changes/unreleased/Features-20230928-163205.yaml b/.changes/unreleased/Features-20230928-163205.yaml
new file mode 100644
index 00000000000..7f9b7c047ac
--- /dev/null
+++ b/.changes/unreleased/Features-20230928-163205.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Enable inline csv fixtures in unit tests
+ti... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
cvat-ai__cvat-1396@bd228e1 | cvat-ai/cvat | Python | 1,396 | Fixed uploading track annotations for multi-segment tasks | <!---
Copyright (C) 2020 Intel Corporation
SPDX-License-Identifier: MIT
-->
## Fixed uploading track annotations for multi-segment tasks
resolve #1313
### Motivation and context
Uploading track annotation in case of multi-segment task works incorrectly because imported tracked shapes is not filtered by ... | 2020-04-13T13:03:42Z | annotation upload corrupt for overlapping segments
i've noticed that if one has a video in CVAT which is segmented into several jobs and then uploads an annotation (containing annotations for one segment) the annotation cannot be changed and saved or deleted and saved if the annotation is bigger than the specific segme... | i think this issue doesnt happen for every kind of annotation.
i used a single point with interpolation. fyi.
what is also interesting to explore is that i see the annotation appearing in job 1 if the object appears mostly in job 2 but overlaps with job 1 a bit. however, the interesting part is that the object in j... | [
{
"body": "i've noticed that if one has a video in CVAT which is segmented into several jobs and then uploads an annotation (containing annotations for one segment) the annotation cannot be changed and saved or deleted and saved if the annotation is bigger than the specific segment range. also the same is if th... | 3d4e7268e175557543932de115e0d7c03fae9e43 | {
"head_commit": "bd228e19a01fca672b5b6e475594b5905a2ba9f0",
"head_commit_message": "fixed comments",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex e620d960da67..02f6a059ca06 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -53,6 +53,7 @@ and this project adheres to [Semantic Versioning](h... | [
{
"diff_hunk": "@@ -290,6 +290,15 @@ def _modify_unmached_object(obj, end_frame):\n shape[\"frame\"] = end_frame\n shape[\"outside\"] = True\n obj[\"shapes\"].append(shape)\n+ # Need to update cached interpolated shapes\n+ # because key shapes were chang... | ae6523796e58d51f43d05cca9e76ac829c914053 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e620d960da67..02f6a059ca06 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -53,6 +53,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- AttributeError: 'tuple' object has no attribute 'read' in ReID algorithm (https://github.com/opencv... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
cvat-ai__cvat-1571@19c040c | cvat-ai/cvat | Python | 1,571 | Interpolation of polyshapes in CVAT | <!---
Copyright (C) 2020 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It will help avoiding duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will... | 2020-05-20T20:38:07Z | Interpolation of polygons
I understand that by enabling dragging, I can move a polygon around by shifting it in X and Y directions. Similarly, is there a feature in CVAT that would also allow me to rotate the polygon?
polygon interpolation
Is there a beta build for using polygon interpolation? If yes, can anyone tell ... | @fywu85 , it is not possible. What is the reason for the request? Could you please describe your use case?
Say if I want to label an object in a video that rotates only in the image plane from frame to frame, e.g., a vehicle making a left turn, being able to rotate the object's polygon would be huge time saver. For exa... | [
{
"body": "I understand that by enabling dragging, I can move a polygon around by shifting it in X and Y directions. Similarly, is there a feature in CVAT that would also allow me to rotate the polygon?",
"number": 824,
"title": "Interpolation of polygons"
},
{
"body": "Is there a beta build for... | 2a349d024318c685a85178ad4401100d486e7a65 | {
"head_commit": "19c040c64542069a9c5ebf835644b5df2ad155c9",
"head_commit_message": "Added pdf describing interpolation",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex deccc8e63a55..4c8d0d829803 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -13,10 +13,16 @@ and this project adheres to [... | [
{
"diff_hunk": "@@ -425,13 +507,89 @@ export class CanvasViewImpl implements CanvasView, Listener {\n }\n }\n \n+ private hideDirection(shape: SVG.Polygon | SVG.PolyLine): void {\n+ /* eslint class-methods-use-this: 0 */\n+ const handler = shape.remember('_selectHandler');\n+ ... | 5e7b404872578474f02667a2f09b54d694652d61 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6c654efac8ae..488c67b1bb75 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,11 +15,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Built-in search for labels when create an object or change a label (<https://github.com/opencv/cv... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
cvat-ai__cvat-1138@82dfb1a | cvat-ai/cvat | Python | 1,138 | updated CUDA to version 10 | Resolve #1133 | 2020-02-11T17:05:33Z | Need to update CUDA to 10 version.
Currently Installed tensorflow 1.13.1 is incompatible with cuda9.
```
Traceback (most recent call last):
File "/home/django/manage.py", line 21, in <module>
execute_from_command_line(sys.argv)
File "/usr/local/lib/python3.5/dist-packages/django/core/management/__init__.py... | [
{
"body": "Currently Installed tensorflow 1.13.1 is incompatible with cuda9.\r\n```\r\nTraceback (most recent call last):\r\n File \"/home/django/manage.py\", line 21, in <module>\r\n execute_from_command_line(sys.argv)\r\n File \"/usr/local/lib/python3.5/dist-packages/django/core/management/__init__.py\",... | 985fdd0d7032ddabed688ce3eb85e8e4d19dbeeb | {
"head_commit": "82dfb1a9fa677eadc5d46fd570ca261594819f53",
"head_commit_message": "updated CUDA to version 10",
"patch_to_review": "diff --git a/components/cuda/docker-compose.cuda.yml b/components/cuda/docker-compose.cuda.yml\nindex 66445f12437c..6c1076bd83dc 100644\n--- a/components/cuda/docker-compose.cuda.y... | [
{
"diff_hunk": "@@ -14,24 +14,25 @@ echo \"$NVIDIA_GPGKEY_SUM cudasign.pub\" | sha256sum -c --strict - && rm cudasign\n echo \"deb http://developer.download.nvidia.com/compute/cuda/repos/ubuntu1604/x86_64 /\" > /etc/apt/sources.list.d/cuda.list && \\\n echo \"deb http://developer.download.nvidia.com/compute/ma... | 304ffa09f67e80b8828787ed5e2edf79453da605 | diff --git a/components/cuda/docker-compose.cuda.yml b/components/cuda/docker-compose.cuda.yml
index 66445f12437c..41d325f3f2bf 100644
--- a/components/cuda/docker-compose.cuda.yml
+++ b/components/cuda/docker-compose.cuda.yml
@@ -15,4 +15,9 @@ services:
environment:
NVIDIA_VISIBLE_DEVICES: all
NVIDI... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
cvat-ai__cvat-2377@7309d99 | cvat-ai/cvat | Python | 2,377 | Share without copying & mount cloud storages | <!---
Copyright (C) 2020 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It will help avoiding duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes will... | 2020-10-30T17:36:44Z | Any way to avoid copying and compressing files when creating new task?
Hi,
Is there any way to avoid copying and compressing images when a new task is created with Source: Shared? Also, source is bound read-only so it shouldn't overwrite anything.
Not sure what the reason is but I have some high resolution imagery ... | Same here, I have a lot of HD images on net share and s3,
I'd like to map them to /share dir and use only links, without any data copy.
any updates on this ?
@vfdev-5 , we are going to reimplement our way to serve data from server (https://github.com/opencv/cvat/tree/az/video_stream). I hope to see the functionality m... | [
{
"body": "Hi,\r\n\r\nIs there any way to avoid copying and compressing images when a new task is created with Source: Shared? Also, source is bound read-only so it shouldn't overwrite anything.\r\nNot sure what the reason is but I have some high resolution imagery and I am loosing the important details to set ... | d6ac8cc5bef173079eeb4947470d2f6fbf1b4e27 | {
"head_commit": "7309d9907425559cc3f09497dbe8a0ec5da3e35e",
"head_commit_message": "Fixed typo",
"patch_to_review": "diff --git a/cvat-core/package-lock.json b/cvat-core/package-lock.json\nindex 6128b1d4aa18..dd36746135c6 100644\n--- a/cvat-core/package-lock.json\n+++ b/cvat-core/package-lock.json\n@@ -1,6 +1,6 ... | [
{
"diff_hunk": "@@ -42,6 +42,7 @@ const defaultState = {\n lfs: false,\n useZipChunks: true,\n useCache: true,\n+ activeTab: 'local',",
"line": null,
"original_line": 45,
"original_start_line": null,
"path": "cvat-ui/src/components/create-task-page/create-task-cont... | fcc15ced8274649cc1346f5c2c434e5a21e2d832 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 602b284de8e5..7023ec7b6749 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Manual review pipeline: issues/comments/workspace (<https://github.com/openvinotoolkit/cvat/pull/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
dbt-labs__dbt-core-8477@1f413b6 | dbt-labs/dbt-core | Python | 8,477 | 8295 unit testing artifacts | resolves #8295
### Problem
Produce artifacts in the manifest (or elsewhere) with metadata about existing unit tests.
### Solution
A dictionary of UnitTestCases is stored in manifest.unit_tests.
Selection happens against a standard manifest (filtering for UnitTestCases in manifest.unit_tests), then the un... | 2023-08-23T14:13:56Z | [CT-2922] Produce unit testing artifacts for metadata about unit testing
### Description
We should produce json artifacts which can be ingested and used as metadata about unit testing. There will be at least two types of artifacts, including a "result" artifact and a more manifest-like artifact.
The output in the... | [
{
"body": "### Description\r\n\r\nWe should produce json artifacts which can be ingested and used as metadata about unit testing. There will be at least two types of artifacts, including a \"result\" artifact and a more manifest-like artifact.\r\n\r\nThe output in the run_result should organize test output by t... | 7ea7069999ff8a0e1acb8fbfdcc7d940673ec144 | {
"head_commit": "1f413b69f090fdace85159820e0beba895a00c9b",
"head_commit_message": "rename UnitTestCase to UnitTestDefinition",
"patch_to_review": "diff --git a/.changes/unreleased/Features-20230828-101825.yaml b/.changes/unreleased/Features-20230828-101825.yaml\nnew file mode 100644\nindex 00000000000..13101ecb... | [
{
"diff_hunk": "@@ -1692,8 +1693,15 @@ def write_semantic_manifest(manifest: Manifest, target_path: str) -> None:\n semantic_manifest.write_json_to_file(path)\n \n \n-def write_manifest(manifest: Manifest, target_path: str):\n- path = os.path.join(target_path, MANIFEST_FILE_NAME)\n+def write_manifest(man... | 0625003552f2dbccccfa79727e256a6b3cfcc0d3 | diff --git a/.changes/unreleased/Features-20230828-101825.yaml b/.changes/unreleased/Features-20230828-101825.yaml
new file mode 100644
index 00000000000..13101ecbacd
--- /dev/null
+++ b/.changes/unreleased/Features-20230828-101825.yaml
@@ -0,0 +1,6 @@
+kind: Features
+body: Unit test manifest artifacts and selection
+... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
cvat-ai__cvat-4327@d8cd837 | cvat-ai/cvat | Python | 4,327 | Tus for task annotations import | <!---
Copyright (C) 2020-2022 Intel Corporation
SPDX-License-Identifier: MIT
-->
<!-- Raised an issue to propose your change (https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent contributors.
Discuss your ideas with maintainers to be sure that changes wil... | 2022-02-11T08:47:22Z | Timeout when uploading a big file with annotations
When I try upload 100 MB xml file annotation, I get this error on log and "Failed to load resource: the server responded with a status of 504 (Gateway Timeout)" error on console.
How can I increase the timeout of the upload annotation? | Probably it will be necessary to do the following changes:
- Optimize upload
- Change REST API because the operation can be heavy
Thanks for the replay!
Meanwhile I wander if there is possibility this parameter "Timeout 60" or "request-timeout=60" in the httpd.conf file.
I was trying to change this file manually, ... | [
{
"body": "When I try upload 100 MB xml file annotation, I get this error on log and \"Failed to load resource: the server responded with a status of 504 (Gateway Timeout)\" error on console.\r\n\r\nHow can I increase the timeout of the upload annotation?",
"number": 964,
"title": "Timeout when uploadin... | 1225fbb1bcf2b4b508e132e1dff29d896682c71a | {
"head_commit": "d8cd8376a77eb01808ae716802c9d2c491d05df0",
"head_commit_message": "added tus for jobs annotations import",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 62372d0614d0..16d0551b6bb2 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -33,7 +33,7 @@ and this project adheres to ... | [
{
"diff_hunk": "@@ -304,6 +304,15 @@ def get_log_path(self):\n def get_task_artifacts_dirname(self):\n return os.path.join(self.get_task_dirname(), 'artifacts')\n \n+ def get_tmp_dirname(self):\n+ return os.path.join(self.get_task_dirname(), \"tmp\")\n+\n+ def get_tmp_file(self, filenam... | 817669af38fd25ec3e58b78fb8496b3884de4662 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d874854696a5..337dc4f0d475 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## \[2.1.0] - Unreleased
### Added
+- Task annotations importing via chunk uploads (<https://github.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
cvat-ai__cvat-662@514b66f | cvat-ai/cvat | Python | 662 | CVAT documentation v5 | Resolved #620
Resolved #586 | 2019-08-23T08:54:10Z | Documentation: Add some examples of using search in a dashboard
Typing 'annotation' in search toolbar of dashboard does not filter tasks in 'annotation' mode.
Documentation v0.5.0
Describe the following features in documentation:
- [ ] Remote data source (list of URLs to create an annotation task)
- [ ] Load/Dum... | @kostasthebarbarian
Could you please provide some examples? It works for me right.
@bsekachev
See attached screenshot. The filter is 'annotation' but I also get a completed task in the list.
I am on Mac OS.
<img width="1291" alt="Screen Shot 2019-07-24 at 1 49 32 PM" src="https://user-images.githubusercontent.co... | [
{
"body": "Typing 'annotation' in search toolbar of dashboard does not filter tasks in 'annotation' mode.\r\n",
"number": 586,
"title": "Documentation: Add some examples of using search in a dashboard"
},
{
"body": "Describe the following features in documentation:\r\n\r\n- [ ] Remote data sourc... | 7fb7ba150ee313dd42f3d91327fba8cb752e4526 | {
"head_commit": "514b66f3d55b4a557fc72e173f97f7e8d2cbd27a",
"head_commit_message": "Updated User's Guide",
"patch_to_review": "diff --git a/cvat/apps/documentation/static/documentation/images/gif003.gif b/cvat/apps/documentation/static/documentation/images/gif003.gif\nindex 9cad1e66fc1a..ed8db9018887 100644\nBin... | [
{
"diff_hunk": "@@ -169,18 +172,36 @@ Go to the [Django administration panel](http://localhost:8080/admin). There you\n The option helps to load high resolution datasets faster.\n Use the value from ``1`` (completely compressed images) to ``95`` (almost not compressed images).\n \n- **Select files**.... | 083dc7fd35c74c8ba42d3dbb2027956fa33760b1 | diff --git a/cvat/apps/documentation/static/documentation/images/gif009.gif b/cvat/apps/documentation/static/documentation/images/gif009.gif
deleted file mode 100644
index 48195ba32a6e..000000000000
Binary files a/cvat/apps/documentation/static/documentation/images/gif009.gif and /dev/null differ
diff --git a/cvat/apps... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
dbt-labs__dbt-core-8298@c689853 | dbt-labs/dbt-core | Python | 8,298 | fix constructing param with 0 value | resolves #8297
[docs](https://github.com/dbt-labs/docs.getdbt.com/issues/new/choose) dbt-labs/docs.getdbt.com/#
<!---
Include the number of the issue addressed by this PR above if applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
... | 2023-08-02T21:17:27Z | [CT-2924] [Bug] Retry does not construct flags properly for 0 valued parameter
### Is this a new bug in dbt-core?
- [X] I believe this is a new bug in dbt-core
- [X] I have searched the existing issues, and I could not find an existing issue for this bug
### Current Behavior
Retry would fail if previous comma... | [
{
"body": "### Is this a new bug in dbt-core?\r\n\r\n- [X] I believe this is a new bug in dbt-core\r\n- [X] I have searched the existing issues, and I could not find an existing issue for this bug\r\n\r\n### Current Behavior\r\n\r\nRetry would fail if previous command run with `--log-file-max-bytes 0` specified... | a433c31d6ebae79bd5b281653551899b7369067c | {
"head_commit": "c6898530c2f24872b7eb4fd2ac8278c7a40b66f1",
"head_commit_message": "fix constructing param with 0 value",
"patch_to_review": "diff --git a/.changes/unreleased/Fixes-20230802-141556.yaml b/.changes/unreleased/Fixes-20230802-141556.yaml\nnew file mode 100644\nindex 00000000000..8b96ccab5c7\n--- /de... | [
{
"diff_hunk": "@@ -344,7 +342,8 @@ def add_fn(x):\n \n if k == \"macro\" and command == CliCommand.RUN_OPERATION:\n add_fn(v)\n- elif v in (None, False):\n+ # None is Signletons, False is flyweight, only one instance of each.",
"line": null,
"original_line": 345,
"... | fd57e2ac791abe3bbe38a2efb9ba8c7ea1230c87 | diff --git a/.changes/unreleased/Fixes-20230802-141556.yaml b/.changes/unreleased/Fixes-20230802-141556.yaml
new file mode 100644
index 00000000000..8b96ccab5c7
--- /dev/null
+++ b/.changes/unreleased/Fixes-20230802-141556.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix retry not working with log-file-max-bytes
+time: 202... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.