Non\\n f\\\"Node is missing data; Check you are calling super().__init__(...) in the {obj.__class__.__name__}() constructor, before setting reactives.\\\"\\n )\\n \\n+ if isinstance(value, _Mutated):\\n+ value = value.value\\n+ always = True\\n+\\n self._initialize_reactive(obj, self.name)\\n \\n if hasattr(obj, self.compute_name):\\ndiff --git a/tests/test_reactive.py b/tests/test_reactive.py\\nindex ad2da5724d..49ab1fd0f6 100644\\n--- a/tests/test_reactive.py\\n+++ b/tests/test_reactive.py\\n@@ -783,3 +783,46 @@ def compose(self) -> ComposeResult:\\n widget.mutate_reactive(TestWidget.names)\\n # Watcher should be invoked\\n assert watched_names == [[], [\\\"Paul\\\"], [\\\"Jessica\\\"]]\\n+\\n+\\n+async def test_mutate_reactive_data_bind() -> None:\\n+ \\\"\\\"\\\"https://github.com/Textualize/textual/issues/4825\\\"\\\"\\\"\\n+\\n+ # Record mutations to TestWidget.messages\\n+ widget_messages: list[list[str]] = []\\n+\\n+ class TestWidget(Widget):\\n+ messages: reactive[list[str]] = reactive(list, init=False)\\n+\\n+ def watch_messages(self, names: list[str]) -> None:\\n+ widget_messages.append(names.copy())\\n+\\n+ class TestApp(App):\\n+ messages: reactive[list[str]] = reactive(list, init=False)\\n+\\n+ def compose(self) -> ComposeResult:\\n+ yield TestWidget().data_bind(TestApp.messages)\\n+\\n+ app = TestApp()\\n+ async with app.run_test():\\n+ test_widget = app.query_one(TestWidget)\\n+ assert widget_messages == [[]]\\n+ assert test_widget.messages == []\\n+\\n+ # Previously setting a mutable object would lead to shared references\\n+ assert app.messages is not test_widget.messages\\n+\\n+ # Mutate app\\n+ app.messages.append(\\\"foo\\\")\\n+ # Mutations aren't detected\\n+ assert widget_messages == [[]]\\n+ assert app.messages == [\\\"foo\\\"]\\n+ assert test_widget.messages == []\\n+ # Explicitly mutate app reactive\\n+ app.mutate_reactive(TestApp.messages)\\n+ # Mutating app, will also invoke watchers on any data binds\\n+ assert widget_messages == [[], [\\\"foo\\\"]]\\n+ assert app.messages == [\\\"foo\\\"]\\n+ assert test_widget.messages == [\\\"foo\\\"]\\n+\\n+ assert app.messages is not test_widget.messages\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -334,7 +335,10 @@ def setter(value: object) -> None:\n \"\"\"Set bound data.\"\"\"\n _rich_traceback_omit = True\n Reactive._initialize_object(self)\n- setattr(self, variable_name, value)\n+ # Copy the bound value","line":null,"original_line":338,"original_start_line":null,"path":"src/textual/dom.py","start_line":null,"text":"@user1:\nI feel like this should be documented since copying can be expensive or potentially crash the program.\r\n\r\nI'm guessing shallow copying means it also wouldn't fix the confusion for e.g. a list of mutable objects. For example, if one of the objects in the list is mutated and I call `mutate_reactive`, the prior confusing scenario still arises.\n\n@author:\nI'm reconsidering the copy.\r\n\r\nIt's not clear what the dev would expect when modifying a child attribute that has been bound. I'm not sure if they would expect the changes to be reflected on the parent. But I don't know if they would expect the inverse either.\r\n\r\nGoing to remove the copy, until I have a better idea what it would fix (if anything)\n\n@user1:\nI agree. I actually think dealing with the mutation via offering APIs like this is likely to be filled with more footguns, \"things we need to document\", and generally worse than just saying \"only use immutable values for reactives, and watchers only fire when you assign\"."}],"string":"[\n {\n \"diff_hunk\": \"@@ -334,7 +335,10 @@ def setter(value: object) -> None:\\n \\\"\\\"\\\"Set bound data.\\\"\\\"\\\"\\n _rich_traceback_omit = True\\n Reactive._initialize_object(self)\\n- setattr(self, variable_name, value)\\n+ # Copy the bound value\",\n \"line\": null,\n \"original_line\": 338,\n \"original_start_line\": null,\n \"path\": \"src/textual/dom.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nI feel like this should be documented since copying can be expensive or potentially crash the program.\\r\\n\\r\\nI'm guessing shallow copying means it also wouldn't fix the confusion for e.g. a list of mutable objects. For example, if one of the objects in the list is mutated and I call `mutate_reactive`, the prior confusing scenario still arises.\\n\\n@author:\\nI'm reconsidering the copy.\\r\\n\\r\\nIt's not clear what the dev would expect when modifying a child attribute that has been bound. I'm not sure if they would expect the changes to be reflected on the parent. But I don't know if they would expect the inverse either.\\r\\n\\r\\nGoing to remove the copy, until I have a better idea what it would fix (if anything)\\n\\n@user1:\\nI agree. I actually think dealing with the mutation via offering APIs like this is likely to be filled with more footguns, \\\"things we need to document\\\", and generally worse than just saying \\\"only use immutable values for reactives, and watchers only fire when you assign\\\".\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"3cdc6537a410ca200ab89ae457f7f5273ce6e8a9"},"merged_patch":{"kind":"string","value":"diff --git a/docs/guide/reactivity.md b/docs/guide/reactivity.md\nindex ff7a1cebdf..eb058a130b 100644\n--- a/docs/guide/reactivity.md\n+++ b/docs/guide/reactivity.md\n@@ -410,7 +410,8 @@ Note the call to `mutate_reactive`. Without it, the display would not update whe\n \n ## Data binding\n \n-Reactive attributes from one widget may be *bound* (connected) to another widget, so that changes to a single reactive will automatically update another widget (potentially more than one).\n+Reactive attributes may be *bound* (connected) to attributes on child widgets, so that changes to the parent are automatically reflected in the children.\n+This can simplify working with compound widgets where the value of an attribute might be used in multiple places.\n \n To bind reactive attributes, call [data_bind][textual.dom.DOMNode.data_bind] on a widget.\n This method accepts reactives (as class attributes) in positional arguments or keyword arguments.\ndiff --git a/src/textual/dom.py b/src/textual/dom.py\nindex 55ce52afea..6e84f53ee3 100644\n--- a/src/textual/dom.py\n+++ b/src/textual/dom.py\n@@ -41,7 +41,7 @@\n from .css.styles import RenderStyles, Styles\n from .css.tokenize import IDENTIFIER\n from .message_pump import MessagePump\n-from .reactive import Reactive, ReactiveError, _watch\n+from .reactive import Reactive, ReactiveError, _Mutated, _watch\n from .timer import Timer\n from .walk import walk_breadth_first, walk_depth_first\n from .worker_manager import WorkerManager\n@@ -253,6 +253,10 @@ def mutate_reactive(self, reactive: Reactive[ReactiveType]) -> None:\n this method after your reactive is updated. This will ensure that all the reactive _superpowers_\n work.\n \n+ !!! note\n+\n+ This method will cause watchers to be called, even if the value hasn't changed.\n+\n Args:\n reactive: A reactive property (use the class scope syntax, i.e. `MyClass.my_reactive`).\n \"\"\"\n@@ -279,6 +283,7 @@ def compose(self) -> ComposeResult:\n yield WorldClock(\"Asia/Tokyo\").data_bind(WorldClockApp.time)\n ```\n \n+\n Raises:\n ReactiveError: If the data wasn't bound.\n \n@@ -334,7 +339,8 @@ def setter(value: object) -> None:\n \"\"\"Set bound data.\"\"\"\n _rich_traceback_omit = True\n Reactive._initialize_object(self)\n- setattr(self, variable_name, value)\n+ # Wrap the value in `_Mutated` so the setter knows to invoke watchers etc.\n+ setattr(self, variable_name, _Mutated(value))\n \n return setter\n \ndiff --git a/src/textual/reactive.py b/src/textual/reactive.py\nindex 17b109d77e..64b6e007ce 100644\n--- a/src/textual/reactive.py\n+++ b/src/textual/reactive.py\n@@ -42,6 +42,13 @@\n ReactableType = TypeVar(\"ReactableType\", bound=\"DOMNode\")\n \n \n+class _Mutated:\n+ \"\"\"A wrapper to indicate a value was mutated.\"\"\"\n+\n+ def __init__(self, value: Any) -> None:\n+ self.value = value\n+\n+\n class ReactiveError(Exception):\n \"\"\"Base class for reactive errors.\"\"\"\n \n@@ -273,6 +280,10 @@ def _set(self, obj: Reactable, value: ReactiveType, always: bool = False) -> Non\n f\"Node is missing data; Check you are calling super().__init__(...) in the {obj.__class__.__name__}() constructor, before setting reactives.\"\n )\n \n+ if isinstance(value, _Mutated):\n+ value = value.value\n+ always = True\n+\n self._initialize_reactive(obj, self.name)\n \n if hasattr(obj, self.compute_name):\ndiff --git a/tests/test_reactive.py b/tests/test_reactive.py\nindex ad2da5724d..54b57e337e 100644\n--- a/tests/test_reactive.py\n+++ b/tests/test_reactive.py\n@@ -783,3 +783,44 @@ def compose(self) -> ComposeResult:\n widget.mutate_reactive(TestWidget.names)\n # Watcher should be invoked\n assert watched_names == [[], [\"Paul\"], [\"Jessica\"]]\n+\n+\n+async def test_mutate_reactive_data_bind() -> None:\n+ \"\"\"https://github.com/Textualize/textual/issues/4825\"\"\"\n+\n+ # Record mutations to TestWidget.messages\n+ widget_messages: list[list[str]] = []\n+\n+ class TestWidget(Widget):\n+ messages: reactive[list[str]] = reactive(list, init=False)\n+\n+ def watch_messages(self, names: list[str]) -> None:\n+ widget_messages.append(names.copy())\n+\n+ class TestApp(App):\n+ messages: reactive[list[str]] = reactive(list, init=False)\n+\n+ def compose(self) -> ComposeResult:\n+ yield TestWidget().data_bind(TestApp.messages)\n+\n+ app = TestApp()\n+ async with app.run_test():\n+ test_widget = app.query_one(TestWidget)\n+ assert widget_messages == [[]]\n+ assert test_widget.messages == []\n+\n+ # Should be the same instance\n+ assert app.messages is test_widget.messages\n+\n+ # Mutate app\n+ app.messages.append(\"foo\")\n+ # Mutations aren't detected\n+ assert widget_messages == [[]]\n+ assert app.messages == [\"foo\"]\n+ assert test_widget.messages == [\"foo\"]\n+ # Explicitly mutate app reactive\n+ app.mutate_reactive(TestApp.messages)\n+ # Mutating app, will also invoke watchers on any data binds\n+ assert widget_messages == [[], [\"foo\"]]\n+ assert app.messages == [\"foo\"]\n+ assert test_widget.messages == [\"foo\"]\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":499,"cells":{"instance_id":{"kind":"string","value":"Textualize__textual-4333@74ab967"},"repo":{"kind":"string","value":"Textualize/textual"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":4333,"string":"4,333"},"title":{"kind":"string","value":"Tests re-raise exceptions that happen inside `Widget.compose`"},"body":{"kind":"string","value":"This will fix #4282.\r\n\r\nThe fix was to simply leverage the machinery introduced in #2754; for some reason, exceptions caught inside `Widget.compose` or workers were directly being sent to `App.panic` instead of using `App._handle_exception`."},"created_at":{"kind":"string","value":"2024-03-25T14:46:38Z"},"problem_statement":{"kind":"string","value":"Exception not being raised in tests\nConsider such an example:\r\n\r\n```python\r\nfrom __future__ import annotations\r\n\r\nfrom textual import work\r\nfrom textual.app import App\r\n\r\n\r\nclass SimpleAppThatCrashes(App[None]):\r\n def on_mount(self) -> None:\r\n self.crash()\r\n\r\n @work(name=\"crash\")\r\n async def crash(self) -> None:\r\n raise ValueError(\"I'm crashing!\")\r\n\r\n\r\nasync def test_exception_not_being_raised():\r\n async with SimpleAppThatCrashes().run_test() as pilot:\r\n await pilot.pause(1)\r\n\r\n# SimpleAppThatCrashes().run() # Uncomment and run as regular app\r\n```\r\n\r\nwhen running via pilot in pytest - everything is green.\r\n\r\nBut when running this app as regular :\r\n\r\n```python\r\n╭─────────────────────────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────────────────────────────────────────────────────────╮\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:365 in _run │\r\n│ │\r\n│ 362 │ │ self.state = WorkerState.RUNNING ╭──────────────────────────────────────── locals ────────────────────────────────────────╮ │\r\n│ 363 │ │ app.log.worker(self) │ app = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\r\n│ 364 │ │ try: │ error = ValueError(\"I'm crashing!\") │ │\r\n│ ❱ 365 │ │ │ self._result = await self.run() │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 366 │ │ except asyncio.CancelledError as error: │ Traceback = <class 'rich.traceback.Traceback'> │ │\r\n│ 367 │ │ │ self.state = WorkerState.CANCELLED ╰────────────────────────────────────────────────────────────────────────────────────────╯ │\r\n│ 368 │ │ │ self._error = error │\r\n│ │\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:349 in run │\r\n│ │\r\n│ 346 │ │ Returns: ╭───────────────────────── locals ─────────────────────────╮ │\r\n│ 347 │ │ │ Return value of the work. │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 348 │ │ \"\"\" ╰──────────────────────────────────────────────────────────╯ │\r\n│ ❱ 349 │ │ return await ( │\r\n│ 350 │ │ │ self._run_threaded() if self._thread_worker else self._run_async() │\r\n│ 351 │ │ ) │\r\n│ 352 │\r\n│ │\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:334 in _run_async │\r\n│ │\r\n│ 331 │ │ │ or hasattr(self._work, \"func\") ╭───────────────────────── locals ─────────────────────────╮ │\r\n│ 332 │ │ │ and inspect.iscoroutinefunction(self._work.func) │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 333 │ │ ): ╰──────────────────────────────────────────────────────────╯ │\r\n│ ❱ 334 │ │ │ return await self._work() │\r\n│ 335 │ │ elif inspect.isawaitable(self._work): │\r\n│ 336 │ │ │ return await self._work │\r\n│ 337 │ │ elif callable(self._work): │\r\n│ │\r\n│ /home/mzebrak/1workspace/textual/textual_pytest_exceptions.py:13 in crash │\r\n│ │\r\n│ 10 │ ╭───────────────────────────────────── locals ──────────────────────────────────────╮ │\r\n│ 11 │ @work(name=\"crash\") │ self = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\r\n│ 12 │ async def crash(self) -> None: ╰───────────────────────────────────────────────────────────────────────────────────╯ │\r\n│ ❱ 13 │ │ raise ValueError(\"I'm crashing!\") │\r\n│ 14 │\r\n│ 15 │\r\n│ 16 async def test_exception_not_being_raised(): │\r\n╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯\r\nValueError: I'm crashing!\r\n```"},"hints_text":{"kind":"string","value":"Thank you for your issue. Give us a little time to review it.\n\nPS. You might want to check the [FAQ](https://textual.textualize.io/FAQ/) if you haven't done so already.\n\nThis is an automated reply, generated by [FAQtory](https://github.com/willmcgugan/faqtory)\nAnother intresting (even simplier) case:\r\n\r\n```python\r\nfrom __future__ import annotations\r\n\r\nfrom textual.app import App, ComposeResult\r\nfrom textual.screen import Screen\r\n\r\n\r\nclass SomeScreen(Screen):\r\n def compose(self) -> ComposeResult:\r\n self.query_one(\"#not-existing\")\r\n return []\r\n\r\n\r\nclass SimpleAppThatCrashes(App[None]):\r\n def on_mount(self) -> None:\r\n self.push_screen(SomeScreen())\r\n\r\n\r\nasync def test_exception_not_being_raised():\r\n async with SimpleAppThatCrashes().run_test() as pilot:\r\n await pilot.pause(1)\r\n assert isinstance(pilot.app.screen, SomeScreen)\r\n\r\n\r\n# SimpleAppThatCrashes().run() # Uncomment and run as regular app\r\n```\nI think we can make `run_test()` re-raise fatal errors, such as those raised from workers."},"resolved_issues":{"kind":"list like","value":[{"body":"Consider such an example:\r\n\r\n```python\r\nfrom __future__ import annotations\r\n\r\nfrom textual import work\r\nfrom textual.app import App\r\n\r\n\r\nclass SimpleAppThatCrashes(App[None]):\r\n def on_mount(self) -> None:\r\n self.crash()\r\n\r\n @work(name=\"crash\")\r\n async def crash(self) -> None:\r\n raise ValueError(\"I'm crashing!\")\r\n\r\n\r\nasync def test_exception_not_being_raised():\r\n async with SimpleAppThatCrashes().run_test() as pilot:\r\n await pilot.pause(1)\r\n\r\n# SimpleAppThatCrashes().run() # Uncomment and run as regular app\r\n```\r\n\r\nwhen running via pilot in pytest - everything is green.\r\n\r\nBut when running this app as regular :\r\n\r\n```python\r\n╭─────────────────────────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────────────────────────────────────────────────────────╮\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:365 in _run │\r\n│ │\r\n│ 362 │ │ self.state = WorkerState.RUNNING ╭──────────────────────────────────────── locals ────────────────────────────────────────╮ │\r\n│ 363 │ │ app.log.worker(self) │ app = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\r\n│ 364 │ │ try: │ error = ValueError(\"I'm crashing!\") │ │\r\n│ ❱ 365 │ │ │ self._result = await self.run() │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 366 │ │ except asyncio.CancelledError as error: │ Traceback = <class 'rich.traceback.Traceback'> │ │\r\n│ 367 │ │ │ self.state = WorkerState.CANCELLED ╰────────────────────────────────────────────────────────────────────────────────────────╯ │\r\n│ 368 │ │ │ self._error = error │\r\n│ │\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:349 in run │\r\n│ │\r\n│ 346 │ │ Returns: ╭───────────────────────── locals ─────────────────────────╮ │\r\n│ 347 │ │ │ Return value of the work. │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 348 │ │ \"\"\" ╰──────────────────────────────────────────────────────────╯ │\r\n│ ❱ 349 │ │ return await ( │\r\n│ 350 │ │ │ self._run_threaded() if self._thread_worker else self._run_async() │\r\n│ 351 │ │ ) │\r\n│ 352 │\r\n│ │\r\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:334 in _run_async │\r\n│ │\r\n│ 331 │ │ │ or hasattr(self._work, \"func\") ╭───────────────────────── locals ─────────────────────────╮ │\r\n│ 332 │ │ │ and inspect.iscoroutinefunction(self._work.func) │ self = <Worker ERROR name='crash' description='crash()'> │ │\r\n│ 333 │ │ ): ╰──────────────────────────────────────────────────────────╯ │\r\n│ ❱ 334 │ │ │ return await self._work() │\r\n│ 335 │ │ elif inspect.isawaitable(self._work): │\r\n│ 336 │ │ │ return await self._work │\r\n│ 337 │ │ elif callable(self._work): │\r\n│ │\r\n│ /home/mzebrak/1workspace/textual/textual_pytest_exceptions.py:13 in crash │\r\n│ │\r\n│ 10 │ ╭───────────────────────────────────── locals ──────────────────────────────────────╮ │\r\n│ 11 │ @work(name=\"crash\") │ self = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\r\n│ 12 │ async def crash(self) -> None: ╰───────────────────────────────────────────────────────────────────────────────────╯ │\r\n│ ❱ 13 │ │ raise ValueError(\"I'm crashing!\") │\r\n│ 14 │\r\n│ 15 │\r\n│ 16 async def test_exception_not_being_raised(): │\r\n╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯\r\nValueError: I'm crashing!\r\n```\r\n","number":4282,"title":"Exception not being raised in tests"}],"string":"[\n {\n \"body\": \"Consider such an example:\\r\\n\\r\\n```python\\r\\nfrom __future__ import annotations\\r\\n\\r\\nfrom textual import work\\r\\nfrom textual.app import App\\r\\n\\r\\n\\r\\nclass SimpleAppThatCrashes(App[None]):\\r\\n def on_mount(self) -> None:\\r\\n self.crash()\\r\\n\\r\\n @work(name=\\\"crash\\\")\\r\\n async def crash(self) -> None:\\r\\n raise ValueError(\\\"I'm crashing!\\\")\\r\\n\\r\\n\\r\\nasync def test_exception_not_being_raised():\\r\\n async with SimpleAppThatCrashes().run_test() as pilot:\\r\\n await pilot.pause(1)\\r\\n\\r\\n# SimpleAppThatCrashes().run() # Uncomment and run as regular app\\r\\n```\\r\\n\\r\\nwhen running via pilot in pytest - everything is green.\\r\\n\\r\\nBut when running this app as regular :\\r\\n\\r\\n```python\\r\\n╭─────────────────────────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────────────────────────────────────────────────────────╮\\r\\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:365 in _run │\\r\\n│ │\\r\\n│ 362 │ │ self.state = WorkerState.RUNNING ╭──────────────────────────────────────── locals ────────────────────────────────────────╮ │\\r\\n│ 363 │ │ app.log.worker(self) │ app = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\\r\\n│ 364 │ │ try: │ error = ValueError(\\\"I'm crashing!\\\") │ │\\r\\n│ ❱ 365 │ │ │ self._result = await self.run() │ self = <Worker ERROR name='crash' description='crash()'> │ │\\r\\n│ 366 │ │ except asyncio.CancelledError as error: │ Traceback = <class 'rich.traceback.Traceback'> │ │\\r\\n│ 367 │ │ │ self.state = WorkerState.CANCELLED ╰────────────────────────────────────────────────────────────────────────────────────────╯ │\\r\\n│ 368 │ │ │ self._error = error │\\r\\n│ │\\r\\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:349 in run │\\r\\n│ │\\r\\n│ 346 │ │ Returns: ╭───────────────────────── locals ─────────────────────────╮ │\\r\\n│ 347 │ │ │ Return value of the work. │ self = <Worker ERROR name='crash' description='crash()'> │ │\\r\\n│ 348 │ │ \\\"\\\"\\\" ╰──────────────────────────────────────────────────────────╯ │\\r\\n│ ❱ 349 │ │ return await ( │\\r\\n│ 350 │ │ │ self._run_threaded() if self._thread_worker else self._run_async() │\\r\\n│ 351 │ │ ) │\\r\\n│ 352 │\\r\\n│ │\\r\\n│ /home/mzebrak/.pyenv/versions/textual/lib/python3.10/site-packages/textual/worker.py:334 in _run_async │\\r\\n│ │\\r\\n│ 331 │ │ │ or hasattr(self._work, \\\"func\\\") ╭───────────────────────── locals ─────────────────────────╮ │\\r\\n│ 332 │ │ │ and inspect.iscoroutinefunction(self._work.func) │ self = <Worker ERROR name='crash' description='crash()'> │ │\\r\\n│ 333 │ │ ): ╰──────────────────────────────────────────────────────────╯ │\\r\\n│ ❱ 334 │ │ │ return await self._work() │\\r\\n│ 335 │ │ elif inspect.isawaitable(self._work): │\\r\\n│ 336 │ │ │ return await self._work │\\r\\n│ 337 │ │ elif callable(self._work): │\\r\\n│ │\\r\\n│ /home/mzebrak/1workspace/textual/textual_pytest_exceptions.py:13 in crash │\\r\\n│ │\\r\\n│ 10 │ ╭───────────────────────────────────── locals ──────────────────────────────────────╮ │\\r\\n│ 11 │ @work(name=\\\"crash\\\") │ self = SimpleAppThatCrashes(title='SimpleAppThatCrashes', classes={'-dark-mode'}) │ │\\r\\n│ 12 │ async def crash(self) -> None: ╰───────────────────────────────────────────────────────────────────────────────────╯ │\\r\\n│ ❱ 13 │ │ raise ValueError(\\\"I'm crashing!\\\") │\\r\\n│ 14 │\\r\\n│ 15 │\\r\\n│ 16 async def test_exception_not_being_raised(): │\\r\\n╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯\\r\\nValueError: I'm crashing!\\r\\n```\\r\\n\",\n \"number\": 4282,\n \"title\": \"Exception not being raised in tests\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"ea8138913eec098ca2036294dcb9911c197e0f2b"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"74ab96763fdb02583b92050ea58d897ed3d848d1\",\n \"head_commit_message\": \"Add test to ensure exception reraised in tests.\",\n \"patch_to_review\": \"diff --git a/CHANGELOG.md b/CHANGELOG.md\\nindex 3a0cb30a51..3239310763 100644\\n--- a/CHANGELOG.md\\n+++ b/CHANGELOG.md\\n@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).\\n - Fixed a crash in `TextArea` when undoing an edit to a selection the selection was made backwards https://github.com/Textualize/textual/issues/4301\\n - Fixed issue with flickering scrollbars https://github.com/Textualize/textual/pull/4315\\n - Fix progress bar ETA not updating when setting `total` reactive https://github.com/Textualize/textual/pull/4316\\n+- Exceptions inside `Widget.compose` weren't bubbling up in tests https://github.com/Textualize/textual/issues/4282\\n \\n ### Changed \\n \\ndiff --git a/src/textual/widget.py b/src/textual/widget.py\\nindex aac76e8778..4bfaabdee0 100644\\n--- a/src/textual/widget.py\\n+++ b/src/textual/widget.py\\n@@ -3618,10 +3618,8 @@ async def _compose(self) -> None:\\n raise TypeError(\\n f\\\"{self!r} compose() method returned an invalid result; {error}\\\"\\n ) from error\\n- except Exception:\\n- from rich.traceback import Traceback\\n-\\n- self.app.panic(Traceback())\\n+ except Exception as error:\\n+ self.app._handle_exception(error)\\n else:\\n self._extend_compose(widgets)\\n await self.mount_composed_widgets(widgets)\\ndiff --git a/tests/test_pilot.py b/tests/test_pilot.py\\nindex d436f8b5fc..10ea623453 100644\\n--- a/tests/test_pilot.py\\n+++ b/tests/test_pilot.py\\n@@ -7,6 +7,7 @@\\n from textual.binding import Binding\\n from textual.containers import Center, Middle\\n from textual.pilot import OutOfBounds\\n+from textual.screen import Screen\\n from textual.widgets import Button, Label\\n \\n KEY_CHARACTERS_TO_TEST = \\\"akTW03\\\" + punctuation\\n@@ -56,7 +57,7 @@ def on_key(self, event: events.Key) -> None:\\n assert keys_pressed[-1] == char\\n \\n \\n-async def test_pilot_exception_catching_compose():\\n+async def test_pilot_exception_catching_app_compose():\\n \\\"\\\"\\\"Ensuring that test frameworks are aware of exceptions\\n inside compose methods when running via Pilot run_test().\\\"\\\"\\\"\\n \\n@@ -70,6 +71,21 @@ def compose(self) -> ComposeResult:\\n pass\\n \\n \\n+async def test_pilot_exception_cathing_widget_compose():\\n+ class SomeScreen(Screen[None]):\\n+ def compose(self) -> ComposeResult:\\n+ 1 / 0\\n+ yield Label(\\\"Beep\\\")\\n+\\n+ class FailingApp(App[None]):\\n+ def on_mount(self) -> None:\\n+ self.push_screen(SomeScreen())\\n+\\n+ with pytest.raises(ZeroDivisionError):\\n+ async with FailingApp().run_test():\\n+ pass\\n+\\n+\\n async def test_pilot_exception_catching_action():\\n \\\"\\\"\\\"Ensure that exceptions inside action handlers are presented\\n to the test framework when running via Pilot run_test().\\\"\\\"\\\"\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -70,6 +71,21 @@ def compose(self) -> ComposeResult:\n pass\n \n \n+async def test_pilot_exception_cathing_widget_compose():","line":null,"original_line":74,"original_start_line":null,"path":"tests/test_pilot.py","start_line":null,"text":"@user1:\n```suggestion\r\nasync def test_pilot_exception_catching_widget_compose():\r\n```"}],"string":"[\n {\n \"diff_hunk\": \"@@ -70,6 +71,21 @@ def compose(self) -> ComposeResult:\\n pass\\n \\n \\n+async def test_pilot_exception_cathing_widget_compose():\",\n \"line\": null,\n \"original_line\": 74,\n \"original_start_line\": null,\n \"path\": \"tests/test_pilot.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\n```suggestion\\r\\nasync def test_pilot_exception_catching_widget_compose():\\r\\n```\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"809f38341f35effd073d43c0625fe984f4d9e311"},"merged_patch":{"kind":"string","value":"diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 3a0cb30a51..ecbc5dd4b5 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).\n - Fixed a crash in `TextArea` when undoing an edit to a selection the selection was made backwards https://github.com/Textualize/textual/issues/4301\n - Fixed issue with flickering scrollbars https://github.com/Textualize/textual/pull/4315\n - Fix progress bar ETA not updating when setting `total` reactive https://github.com/Textualize/textual/pull/4316\n+- Exceptions inside `Widget.compose` or workers weren't bubbling up in tests https://github.com/Textualize/textual/issues/4282\n \n ### Changed \n \ndiff --git a/src/textual/widget.py b/src/textual/widget.py\nindex aac76e8778..4bfaabdee0 100644\n--- a/src/textual/widget.py\n+++ b/src/textual/widget.py\n@@ -3618,10 +3618,8 @@ async def _compose(self) -> None:\n raise TypeError(\n f\"{self!r} compose() method returned an invalid result; {error}\"\n ) from error\n- except Exception:\n- from rich.traceback import Traceback\n-\n- self.app.panic(Traceback())\n+ except Exception as error:\n+ self.app._handle_exception(error)\n else:\n self._extend_compose(widgets)\n await self.mount_composed_widgets(widgets)\ndiff --git a/src/textual/worker.py b/src/textual/worker.py\nindex 7719cd4dca..f7f10b60ae 100644\n--- a/src/textual/worker.py\n+++ b/src/textual/worker.py\n@@ -375,7 +375,8 @@ async def _run(self, app: App) -> None:\n \n app.log.worker(Traceback())\n if self.exit_on_error:\n- app._fatal_error()\n+ worker_failed = WorkerFailed(self._error)\n+ app._handle_exception(worker_failed)\n else:\n self.state = WorkerState.SUCCESS\n app.log.worker(self)\ndiff --git a/tests/test_pilot.py b/tests/test_pilot.py\nindex d436f8b5fc..9451237fab 100644\n--- a/tests/test_pilot.py\n+++ b/tests/test_pilot.py\n@@ -2,12 +2,14 @@\n \n import pytest\n \n-from textual import events\n+from textual import events, work\n from textual.app import App, ComposeResult\n from textual.binding import Binding\n from textual.containers import Center, Middle\n from textual.pilot import OutOfBounds\n+from textual.screen import Screen\n from textual.widgets import Button, Label\n+from textual.worker import WorkerFailed\n \n KEY_CHARACTERS_TO_TEST = \"akTW03\" + punctuation\n \"\"\"Test some \"simple\" characters (letters + digits) and all punctuation.\"\"\"\n@@ -56,7 +58,7 @@ def on_key(self, event: events.Key) -> None:\n assert keys_pressed[-1] == char\n \n \n-async def test_pilot_exception_catching_compose():\n+async def test_pilot_exception_catching_app_compose():\n \"\"\"Ensuring that test frameworks are aware of exceptions\n inside compose methods when running via Pilot run_test().\"\"\"\n \n@@ -70,6 +72,21 @@ def compose(self) -> ComposeResult:\n pass\n \n \n+async def test_pilot_exception_catching_widget_compose():\n+ class SomeScreen(Screen[None]):\n+ def compose(self) -> ComposeResult:\n+ 1 / 0\n+ yield Label(\"Beep\")\n+\n+ class FailingApp(App[None]):\n+ def on_mount(self) -> None:\n+ self.push_screen(SomeScreen())\n+\n+ with pytest.raises(ZeroDivisionError):\n+ async with FailingApp().run_test():\n+ pass\n+\n+\n async def test_pilot_exception_catching_action():\n \"\"\"Ensure that exceptions inside action handlers are presented\n to the test framework when running via Pilot run_test().\"\"\"\n@@ -85,6 +102,21 @@ def action_beep(self) -> None:\n await pilot.press(\"b\")\n \n \n+async def test_pilot_exception_catching_worker():\n+ class SimpleAppThatCrashes(App[None]):\n+ def on_mount(self) -> None:\n+ self.crash()\n+\n+ @work(name=\"crash\")\n+ async def crash(self) -> None:\n+ 1 / 0\n+\n+ with pytest.raises(WorkerFailed) as exc:\n+ async with SimpleAppThatCrashes().run_test():\n+ pass\n+ assert exc.type is ZeroDivisionError\n+\n+\n async def test_pilot_click_screen():\n \"\"\"Regression test for https://github.com/Textualize/textual/issues/3395.\n \ndiff --git a/tests/workers/test_worker.py b/tests/workers/test_worker.py\nindex 7b553d122f..61af91f638 100644\n--- a/tests/workers/test_worker.py\n+++ b/tests/workers/test_worker.py\n@@ -113,10 +113,10 @@ class ErrorApp(App):\n pass\n \n app = ErrorApp()\n- async with app.run_test():\n- worker: Worker[str] = Worker(app, run_error)\n- worker._start(app)\n- with pytest.raises(WorkerFailed):\n+ with pytest.raises(WorkerFailed):\n+ async with app.run_test():\n+ worker: Worker[str] = Worker(app, run_error)\n+ worker._start(app)\n await worker.wait()\n \n \n@@ -218,12 +218,12 @@ async def self_referential_work():\n await get_current_worker().wait()\n \n app = App()\n- async with app.run_test():\n- worker = Worker(app, self_referential_work)\n- worker._start(app)\n- with pytest.raises(WorkerFailed) as exc:\n+ with pytest.raises(WorkerFailed) as exc:\n+ async with app.run_test():\n+ worker = Worker(app, self_referential_work)\n+ worker._start(app)\n await worker.wait()\n- assert exc.type is DeadlockError\n+ assert exc.type is DeadlockError\n \n \n async def test_wait_without_start():\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Bug Fixes\"\n}"}}}],"truncated":false,"partial":false},"paginationData":{"pageIndex":4,"numItemsPerPage":100,"numTotalItems":7086,"offset":400,"length":100}},"jwt":"eyJhbGciOiJFZERTQSIsImtpZCI6IjVHZDBvd0g5MTM2eDZjc1FvbE1zcktNWUZoRVFoUm5PVVVybEpjOUhaUEEifQ.eyJyZWFkIjp0cnVlLCJwZXJtaXNzaW9ucyI6eyJyZXBvLmNvbnRlbnQucmVhZCI6dHJ1ZX0sImlhdCI6MTc4NjcyMzMyOCwianRpIjoiOTFhZTQ0ZGYtNDY3Yy00ZDYyLTk5MTktZjY3YmI4OTE0Y2IzIiwic3ViIjoiL2RhdGFzZXRzL2luY2x1c2lvbkFJL1NXRS1DQVJFIiwiZXhwIjoxNzg2NzI2OTI4LCJpc3MiOiJodHRwczovL2h1Z2dpbmdmYWNlLmNvIn0.f7M_T-0gyZVv1-fg9pFOTpPZCrW02E3XQ57lI-pGw9-KtHuqkqXp4-9gATSmgGw8P6C1EuxTnRfgItVcpsg0Dg","displayUrls":true,"splitSizeSummaries":[{"config":"default","split":"dev","numRows":7086,"numBytesParquet":125079708},{"config":"default","split":"test","numRows":671,"numBytesParquet":12126296}]},"discussionsStats":{"closed":0,"open":1,"total":1},"fullWidth":true,"hasGatedAccess":true,"hasFullAccess":true,"isEmbedded":false,"savedQueries":{"community":[{"views":[{"key":"default/test","displayName":"test","viewName":"test"}],"sql":"-- The SQL console is powered by DuckDB WASM and runs entirely in the browser.\n-- Get started by typing a query or selecting a view from the options below.\nSELECT instance_id , base_commit ,problem_statement,commit_to_review FROM test LIMIT 10;","title":"Review Test Instances","createdAt":"2026-01-14T03:09:29.315Z","slug":"JAW4VpX","private":false,"justification":"Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.","viewNames":["test"]}],"user":[]}}">
instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
sympy__sympy-14280@6d2a066 | sympy/sympy | Python | 14,280 | kinematic_equation returns zero if speeds are zero | earlier kinematic equations returned a non-zero vector if the speeds were zero. Now if the speeds are zero kinematic_equation returns a zero vector.
fixes #12600 | 2018-02-19T14:02:15Z | kinematic_equations should return a zero vector if the speeds are all zero
This is currently the behavior:
```
moorepants@garuda:sympy(master)$ ipython --pdb
Python 3.5.3 |Continuum Analytics, Inc.| (default, Mar 6 2017, 11:58:13)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.0.0 -- A... | Hello Sir, I am very much interested in contributing, but am new to open source. Where can I find this particular function kinematic_equation(), I opened sympy/physics/mechanics but could not find the function in the files. Can you please help me with this? I read that the code is present in sympy/core but could not fi... | [
{
"body": "This is currently the behavior:\r\n\r\n```\r\nmoorepants@garuda:sympy(master)$ ipython --pdb\r\nPython 3.5.3 |Continuum Analytics, Inc.| (default, Mar 6 2017, 11:58:13) \r\nType 'copyright', 'credits' or 'license' for more information\r\nIPython 6.0.0 -- An enhanced Interactive Python. Type '?' for ... | 947cc2f76ec2ce335de77b66d66b78610601c82f | {
"head_commit": "6d2a06600516d5c1e74b8feefdd76070ad6854fe",
"head_commit_message": "kinematic_equation returns zero if speeds are zero\n\nearlier kinematic equations returned a non-zero vector if the speeds were zero. Now if the speeds are zero kinematic_equation returns a zero vector.",
"patch_to_review": "diff... | [
{
"diff_hunk": "@@ -280,6 +280,8 @@ def kinematic_equations(speeds, coords, rot_type, rot_order=''):\n w1, w2, w3 = speeds",
"line": null,
"original_line": 280,
"original_start_line": null,
"path": "sympy/physics/vector/functions.py",
"start_line": null,
"text": "@user1:\nCould y... | 3e4b1adab7413b2959c9098a4809ba09368a1a3e | diff --git a/sympy/physics/vector/functions.py b/sympy/physics/vector/functions.py
index 814d2fc99724..d7f87dff153a 100644
--- a/sympy/physics/vector/functions.py
+++ b/sympy/physics/vector/functions.py
@@ -275,9 +275,11 @@ def kinematic_equations(speeds, coords, rot_type, rot_order=''):
if len(coords) != 3:
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-14253@529f319 | sympy/sympy | Python | 14,253 | solveset modifications for use of Piecewise | <!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues... | 2018-02-17T18:13:17Z | solve(x*Max(x, 15) - 10, x) doesn't work
`solve(x*Max(x, 15) - 10, x)` gives NotImplementedError. `solveset` can't solve it either.
I think to solve equations like this, one should replace the Max with each argument and solve independently, then backtrack and remove any solutions where the Max argument is not actuall... | Perhaps rewriting as a Piecewise and resubmitting to `solve` rather than handling the solution in-place would be a way to go? The `piecewise_fold`would then take care of multiple Max/Min in the expression
`x*Max(x, 15) - Max(x, 10)` -> `Piecewise ((x**2, x>15), (15, True)) - Piecewise ((x, x>10), (10, True))` for whic... | [
{
"body": "`solve(x*Max(x, 15) - 10, x)` gives NotImplementedError. `solveset` can't solve it either. \n\nI think to solve equations like this, one should replace the Max with each argument and solve independently, then backtrack and remove any solutions where the Max argument is not actually the maximum. For i... | fb536869fb7aa28b2695ad7a3b70949926b291c4 | {
"head_commit": "529f319418230403080fe3e3f45c02e811e54760",
"head_commit_message": "additional test for non-Expr SymPy object",
"patch_to_review": "diff --git a/sympy/functions/elementary/complexes.py b/sympy/functions/elementary/complexes.py\nindex f3cc98a232f1..77bc6da274f0 100644\n--- a/sympy/functions/elemen... | [
{
"diff_hunk": "@@ -1676,10 +1687,43 @@ def test__is_finite_with_finite_vars():\n Dummy(), Dummy(real=True), Dummy(complex=True)))\n assert f(1/Dummy(real=False)) is True # b/c it's finite but not 0\n \n+\n def test_issue_13550():\n assert solveset(x**2 - 2*x - 15, symbol = x, domain = Interval... | f0f38841b208d574ad0f27c3cb61837635bed42e | diff --git a/sympy/functions/elementary/complexes.py b/sympy/functions/elementary/complexes.py
index f3cc98a232f1..77bc6da274f0 100644
--- a/sympy/functions/elementary/complexes.py
+++ b/sympy/functions/elementary/complexes.py
@@ -499,7 +499,7 @@ def eval(cls, arg):
return arg2
# reject result... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-9337@693bb43 | streamlit/streamlit | Python | 9,337 | Remove `st.logo` if stale | ## Describe your changes
Currently, a stale logo persists between re-runs for a SPA, MPA v1, & MPA v2. This PR attaches the `scriptRunId` to the `st.logo` call so that a stale logo is cleaned up on script finish (when `clearStaleNodes` is called).
## GitHub Issue Link (if applicable)
Closes #9336
## Testing Pl... | 2024-08-27T01:08:18Z | Stale `st.logo` not removed
### Summary
After the MPAv2 refactor, a stale logo is not removed for single-page apps, MPA v1, & MPA v2
### Steps To Reproduce
1. Create an app with `st.logo` in the script
2. Run the script -> logo appears as expected
3. Comment out the `st.logo` call
4. Re-run script
5. Notic... | **If this issue affects you, please react with a 👍 (thumbs up emoji) to the initial post.**
Your feedback helps us prioritize which bugs to investigate and address first.
![Visits](https://hits.seeyoufarm.com/api/count/incr/badge.svg?url=https%3A%2F%2Fgithub.com%2Fstreamlit%2Fstreamlit%2Fissues%2F9336&title=visits&e... | [
{
"body": "### Summary\r\n\r\nAfter the MPAv2 refactor, a stale logo is not removed for single-page apps, MPA v1, & MPA v2\r\n\r\n### Steps To Reproduce\r\n\r\n1. Create an app with `st.logo` in the script\r\n2. Run the script -> logo appears as expected\r\n3. Comment out the `st.logo` call\r\n4. Re-run script\... | 5ca2a9aa1fc7830bab933244aad185b7be3359da | {
"head_commit": "693bb430b3d2930fec597e77e222ebf1c610c645",
"head_commit_message": "Update comments",
"patch_to_review": "diff --git a/frontend/app/src/App.tsx b/frontend/app/src/App.tsx\nindex 1cde884a75c4..ac53a8c0c015 100644\n--- a/frontend/app/src/App.tsx\n+++ b/frontend/app/src/App.tsx\n@@ -739,9 +739,17 @@... | [
{
"diff_hunk": "@@ -739,9 +739,17 @@ export class App extends PureComponent<Props, State> {\n }\n \n handleLogo = (logo: Logo, metadata: ForwardMsgMetadata): void => {\n+ // Pass the current page & run ID for cleanup\n+ const { scriptRunId } = this.state\n+ const { activeScriptHash } = metadata\n+\... | d2a3e81051d0bcda6e1cb30ab3c5d95d710f9e5b | diff --git a/frontend/app/src/App.test.tsx b/frontend/app/src/App.test.tsx
index dc61df1df051..cdf372b23c1a 100644
--- a/frontend/app/src/App.test.tsx
+++ b/frontend/app/src/App.test.tsx
@@ -1663,6 +1663,85 @@ describe("App", () => {
})
})
+ describe("Logo handling", () => {
+ it("adds logo on receipt of ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-14207@cdb2dee | sympy/sympy | Python | 14,207 | _print_Mul : parenthesize non-evaluated Pow with `exp=-1` | Fixes #14160
The issue occurs only for non-evaluated `Pow` with exponent `-1`. `_print_Mul` prints such terms as it is (like `Pow(Mul(a,a,evaluate=False), -1, evaluate=False)` gets printed to `a*a` in the denominator)
#### Brief description of what is fixed or changed
I just added a list `pow_paran` which takes a... | 2018-02-14T17:34:16Z | Necessary parenthesis in printing of some multiplications
Reproducer:
```
from sympy import *
a = Symbol('a')
u = Symbol('u')
a2inv = Pow(Mul(a,a,evaluate=False), -1, evaluate=False)
d = Mul(-2, u, a2inv, evaluate=False)
print("This should be -2*u/(a*a)")
print(d)
```
Output:
```
This should be ... | [
{
"body": "Reproducer:\r\n\r\n```\r\nfrom sympy import *\r\n\r\na = Symbol('a')\r\nu = Symbol('u')\r\n\r\na2inv = Pow(Mul(a,a,evaluate=False), -1, evaluate=False)\r\nd = Mul(-2, u, a2inv, evaluate=False)\r\n\r\nprint(\"This should be -2*u/(a*a)\")\r\nprint(d)\r\n```\r\n\r\nOutput:\r\n\r\n```\r\nThis should be -... | 9ebcce18bd0ea331b55b8538d2c45e56a3821715 | {
"head_commit": "cdb2dee4e1e0d3ed20faf97f7919b1dfcadf19c4",
"head_commit_message": "parenthesize non-evaluated Pow with exp=-1",
"patch_to_review": "diff --git a/sympy/printing/str.py b/sympy/printing/str.py\nindex 0baefe0f7fc2..16899ec94224 100644\n--- a/sympy/printing/str.py\n+++ b/sympy/printing/str.py\n@@ -2... | [
{
"diff_hunk": "@@ -43,6 +43,9 @@ def test_python_basic():\n \"y = Symbol('y')\\nx = Symbol('x')\\ne = 1 - 3*y/(2*x)\"]\n \n # Multiplication\n+ from sympy import Mul, Pow\n+ assert python(Mul(-2, x, Pow(Mul(y,y,evaluate=False), -1, evaluate=False)",
"line": null,
"original_line": 47,
... | 6a720b4005878f0855f770a1ae3af38c9f0bc28b | diff --git a/sympy/printing/codeprinter.py b/sympy/printing/codeprinter.py
index 89677d1be66f..1c28e168ae82 100644
--- a/sympy/printing/codeprinter.py
+++ b/sympy/printing/codeprinter.py
@@ -420,6 +420,8 @@ def _print_Mul(self, expr):
a = [] # items in the numerator
b = [] # items that are in the de... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
sympy__sympy-14158@bd51bc3 | sympy/sympy | Python | 14,158 | Implemented Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent() | Fixes #14112 .
Fixes #14152 .
This PR also introduces a new convergence test -- the **Ratio Test**. Actually, when I followed normalhuman's comment on the issue, I solved the particular issue, but I had another problem -
```
>>> from sympy import *
>>> n = symbols('n')
>>> a = Sum(factorial(n)/5**n, (n, 1, oo... | 2018-02-11T11:06:46Z | Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent() not implemented
```
>>> Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent()`
Traceback (most recent call last):
File "<ipython-input-23-75eab3fe4b66>", line 1, in <module>
Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent()
Fil... | @asmeurer @normalhuman I would like to fix this issue, can you guide me how to proceed!
The method `is_absolutely_convergent` returns `Sum(abs(self.function), self.limits).is_convergent()` (incidentally, that should be Abs). The problem is this:
```
>>> a = (-1)**n / sqrt(n)
>>> Abs(a)
exp(-pi*im(n))*Abs(1/sqrt(n)... | [
{
"body": "```\r\n>>> Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent()`\r\nTraceback (most recent call last):\r\n\r\n File \"<ipython-input-23-75eab3fe4b66>\", line 1, in <module>\r\n Sum((-1)**n/sqrt(n), (n, 1, oo)).is_absolutely_convergent()\r\n\r\n File \".\\sympy\\concrete\\summations.py\", ... | 98d5dd9b743116b0b967db57d53782e61f63453d | {
"head_commit": "bd51bc3b1a8a83e05b445156221f853a3c586fcc",
"head_commit_message": "Added ratio test",
"patch_to_review": "diff --git a/sympy/concrete/summations.py b/sympy/concrete/summations.py\nindex 2d6361e0a7c5..52f8825ec1d0 100644\n--- a/sympy/concrete/summations.py\n+++ b/sympy/concrete/summations.py\n@@ ... | [
{
"diff_hunk": "@@ -429,6 +433,15 @@ def is_convergent(self):\n \n order = O(sequence_term, (sym, S.Infinity))\n \n+ ### ----------- ratio test ---------------- ###\n+ next_sequence_term = sequence_term.xreplace({sym: sym + 1})\n+ ratio = simplify(next_sequence_term/sequence_term)",... | b03869f1be2e725c7e6a992f94de824b575992f1 | diff --git a/sympy/concrete/summations.py b/sympy/concrete/summations.py
index 2d6361e0a7c5..e4ca7ba44a5b 100644
--- a/sympy/concrete/summations.py
+++ b/sympy/concrete/summations.py
@@ -16,6 +16,8 @@
from sympy.series.limits import limit
from sympy.series.order import O
from sympy.sets.sets import FiniteSet
+from s... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13988@425744c | sympy/sympy | Python | 13,988 | Symbolic Riemann sums for definite integrals | #### References to other Issues or PRs
Fixes #12707
#### Brief description of what is fixed or changed
Adds a Boolean flag `evaluate` to `as_sum` method, True by default for backward compatibility.
Also allows a symbolic number of subintervals to be used, which is both natural and more interesting for a s... | 2018-01-22T07:22:00Z | Integral.as_sum() should output a Sum() object
Currently, Integral.as_sum() outputs an evaluated summation instead of an unevaluated expression:
```
In [1]: import sympy as sm
In [2]: t, t0, tf = sm.symbols('t, t0, tf')
In [3]: x = sm.Function('x')(t)
In [4]: y = sm.Function('y')(t)
In [5]: J = sm.Integ... | Hi @moorepants ! I want to work on this issue .
Go for it!
@moorepants Any kind of help will be appreciated.I'm new to this organization.
Start here: https://github.com/sympy/sympy/wiki/introduction-to-contributing
Read the materials, setup your dev environment, and do the tutorial.
@moorepants I've read the materia... | [
{
"body": "Currently, Integral.as_sum() outputs an evaluated summation instead of an unevaluated expression:\r\n\r\n```\r\nIn [1]: import sympy as sm\r\n\r\nIn [2]: t, t0, tf = sm.symbols('t, t0, tf')\r\n\r\nIn [3]: x = sm.Function('x')(t)\r\n\r\nIn [4]: y = sm.Function('y')(t)\r\n\r\nIn [5]: J = sm.Integral((x... | 219d0b02f3402e158ebd809c8e91420208870467 | {
"head_commit": "425744ced4d1ac0a8e7e2662c176c592d0eb8081",
"head_commit_message": "Symbolic Riemann sums for definite integrals\n\nFixes #12707\n\nAdds a Boolean flag `evaluate` to `as_sum` method, True by default for\nbackward compatibility.\n\nAlso allows a symbolic number of subintervals to be used, which is b... | [
{
"diff_hunk": "@@ -1047,23 +1047,29 @@ def _eval_as_leading_term(self, x):\n break\n return integrate(leading_term, *self.args[1:])\n \n- def as_sum(self, n, method=\"midpoint\"):\n+ def as_sum(self, n, method=\"midpoint\", evaluate=True):",
"line": null,
"original_line": ... | 13a358fb8fa57bd7d1a51b770a22e87134f4debd | diff --git a/sympy/integrals/integrals.py b/sympy/integrals/integrals.py
index ea787ea94b80..00a59fc11efc 100644
--- a/sympy/integrals/integrals.py
+++ b/sympy/integrals/integrals.py
@@ -1047,23 +1047,29 @@ def _eval_as_leading_term(self, x):
break
return integrate(leading_term, *self.args[1:]... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13974@3cfa337 | sympy/sympy | Python | 13,974 | Adding support for simplifying powers of tensorproducts | This commit adds support for `tensor_product_simp()` to also handle `Pow` expressions with `TensorProduct`s.
There is a new function `tensor_product_simp_Pow()` that only evaluates powers whose base is a `TensorProduct`, and `tensor_product_simp_Mul()` has been changed to call `tensor_product_simp_Pow()` when approp... | 2018-01-20T18:25:59Z | Evaluating powers of `TensorProduct`
Powers of tensor product expressions are not possible to evaluate with either `expand(tensorproduct=True)` method nor the `tensor_product_simp`function.
This is an example session showing the issue
```
In [1]: from sympy import *
from sympy.physics.quantum import Tenso... | I would like to work on it.
Can you please guide me as to how I should proceed?
@ArighnaIITG
The file would be `sympy/physics/quantum/tensorproduct.py`, in which you can see that `tensor_product_simp` acts differently depending on the argument. Just as there is a `tensor_product_simp_Mul` when the argument is `Mul`,... | [
{
"body": "Powers of tensor product expressions are not possible to evaluate with either `expand(tensorproduct=True)` method nor the `tensor_product_simp`function.\r\n\r\nThis is an example session showing the issue\r\n```\r\nIn [1]: from sympy import *\r\n from sympy.physics.quantum import TensorProduct... | 84c125972ad535b2dfb245f8d311d347b45e5b8a | {
"head_commit": "3cfa3377eec97cdfbf55b8dd70a7472576ef28d6",
"head_commit_message": "Tests for `tensor_product_simp()` acting on expressions with powers\n\nNon-trivial tests for expressions mixing powers and tensorproducts",
"patch_to_review": "diff --git a/sympy/physics/quantum/tensorproduct.py b/sympy/physics/q... | [
{
"diff_hunk": "@@ -309,19 +311,27 @@ def tensor_product_simp_Mul(e):\n (A*C)x(B*D)\n \n \"\"\"\n- # TODO: This won't work with Muls that have other composites of\n- # TensorProducts, like an Add, Pow, Commutator, etc.\n+ # TODO: This don't work with Muls that have other composites of",
... | c2360561e9fe2119791149f5b097bd860e0ab4cc | diff --git a/sympy/physics/quantum/tensorproduct.py b/sympy/physics/quantum/tensorproduct.py
index 9dd10d219e43..3ffda734c2ec 100644
--- a/sympy/physics/quantum/tensorproduct.py
+++ b/sympy/physics/quantum/tensorproduct.py
@@ -18,6 +18,7 @@
matrix_tensor_product
)
+
__all__ = [
'TensorProduct',
'tens... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13970@87b5fbd | sympy/sympy | Python | 13,970 | Convert more Pow expressions to field elements | #### References to other Issues or PRs
Fixes #13947
#### Brief description of what is fixed or changed
The `FracField._rebuild_expr` method did not try hard enough to express a given Pow in terms of field generators: it just expected the exponent to be integer, and the base be in the field. This missed, for ex... | 2018-01-20T07:30:15Z | integrate(a**t /(a**t+1), t) sucess but a**(t-s)/(a**t+1) fail
No matter whether `conds='none'`.
``` python
import sympy as sm
print(sm.__version__)
# 1.1.1
from sympy import *
a, t, s = symbols('a t s')
f = a**t/(a**t+1)
integrate(f, t)
# >> log(a**t + 1)/log(a)
g = a**(t-s)/(a**t+1)
integrate(g, t)
# ... | I don't know much about `integral` module so I read `integral.py` file and saw we can try to integrate with different methods, namely: `Full Risch algorithm`, `The Meijer G-Function algorithm` and `The "manual integration" algorithm`.
While i was getting error with first two, with `manual integration`i got :
`>>> ... | [
{
"body": "No matter whether `conds='none'`.\r\n\r\n``` python\r\nimport sympy as sm\r\nprint(sm.__version__)\r\n# 1.1.1\r\nfrom sympy import *\r\na, t, s = symbols('a t s')\r\nf = a**t/(a**t+1)\r\nintegrate(f, t)\r\n# >> log(a**t + 1)/log(a)\r\ng = a**(t-s)/(a**t+1) \r\nintegrate(g, t)\r\n# hoping : a**(-s) lo... | 84c125972ad535b2dfb245f8d311d347b45e5b8a | {
"head_commit": "87b5fbdf2383c035921ed86a91fd348a1674cfec",
"head_commit_message": "Convert more Pow expressions to field elements\n\nFixes #13947\n\nThe `FracField._rebuild_expr` method did not try hard enough to express\na given Pow in terms of field generators: it just expected the exponent\nto be integer, and ... | [
{
"diff_hunk": "@@ -214,16 +218,24 @@ def _rebuild(expr):\n return reduce(add, list(map(_rebuild, expr.args)))\n elif expr.is_Mul:\n return reduce(mul, list(map(_rebuild, expr.args)))\n- elif expr.is_Pow and expr.exp.is_Integer:\n- return _re... | 95a39c0a3fd5e8af9fbd2f312cd6149e53b3f6f7 | diff --git a/sympy/integrals/tests/test_risch.py b/sympy/integrals/tests/test_risch.py
index 821338146a76..f8b9d29c06a5 100644
--- a/sympy/integrals/tests/test_risch.py
+++ b/sympy/integrals/tests/test_risch.py
@@ -353,6 +353,13 @@ def test_integrate_hyperexponential_returns_piecewise():
# TODO: Add a test where t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13915@9f4b5b1 | sympy/sympy | Python | 13,915 | Expression should be NaN when Mul "cancels out infinity" | #### References to other Issues or PRs
Fixes #13904
#### Brief description of what is fixed or changed
Mul combines powers with identical base, adding their exponents. When this results in zero as exponent, the term is simply dropped, which is wrong to do when the base is infinite. There is already a simple ch... | 2018-01-13T20:41:07Z | Issue with a substitution that leads to an undefined expression
```
Python 3.6.4 |Anaconda custom (64-bit)| (default, Dec 21 2017, 15:39:08)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.
In [1]: from sympy import *
In [2]: a,b... | In this regard, don't you think that `r.simplify()` is wrong? It returns `-a/b` which is not correct if b=a.
`simplify` works for the generic case. SymPy would be hard to use if getting a+b from `simplify((a**2-b**2)/(a-b))` required an explicit declaration that a is not equal to b. (Besides, there is currently no way ... | [
{
"body": "```\r\nPython 3.6.4 |Anaconda custom (64-bit)| (default, Dec 21 2017, 15:39:08) \r\nType 'copyright', 'credits' or 'license' for more information\r\nIPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.\r\n\r\nIn [1]: from sympy import *\r\n\r\nIn [2]: a,b = symbols('a,b')\r\n\r\nIn [3]... | 5c1644ff85e15752f9f8721bc142bfbf975e7805 | {
"head_commit": "9f4b5b14d60b7c5a0d967f039cb225c7bcb5696b",
"head_commit_message": "Expression should be NaN when Mul \"cancels out infinity\"\n\nFixes #13904\n\nMul combines powers with identical base, adding their exponents.\nWhen this results in exponent of 0, the term is simply dropped, which\nis wrong when th... | [
{
"diff_hunk": "@@ -423,6 +423,11 @@ def _gather(c_powers):\n changed = False\n for b, e in c_powers:\n if e.is_zero:\n+ # canceling out infinities yields NaN\n+ if (b.is_Add or b.is_Mul) and any(infty in b.args \\",
"line": null,... | 5ff00e9352ae999bc7607beffd974c1e97256c9a | diff --git a/sympy/core/mul.py b/sympy/core/mul.py
index 4f01eeedbdf5..29e6085ce387 100644
--- a/sympy/core/mul.py
+++ b/sympy/core/mul.py
@@ -423,6 +423,11 @@ def _gather(c_powers):
changed = False
for b, e in c_powers:
if e.is_zero:
+ # canceling out infin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-9205@ecf7134 | streamlit/streamlit | Python | 9,205 | Extend dataframe-handling support for collection-like types | ## Describe your changes
Extends the dataframe-handling support for a variety of (Python-native) collection-like types:
- dict.keys()
- dict.values()
- dict.items()
- collections.OrderedDict
- collections.defaultdict
- collections.Counter
- collections.deque
- collections.ChainMap
- Frozenset
- NamedTupe... | 2024-08-02T15:48:31Z | Support defaultdict as data source for built-in charts
### Problem
Charts that accept regular dicts, such as st.bar_chart, throw an error when given a defaultdict, which I would expect to work and just be treated as a normal one.
### Solution
**MVP:**
Allow the use of a defaultdict by treating it as a dict, ig... | [
{
"body": "### Problem\r\nCharts that accept regular dicts, such as st.bar_chart, throw an error when given a defaultdict, which I would expect to work and just be treated as a normal one.\r\n\r\n### Solution\r\n\r\n**MVP:** \r\nAllow the use of a defaultdict by treating it as a dict, ignoring any unset keys.\r... | 8301afe06cfc52cf514f74c7993ad49c6258c791 | {
"head_commit": "ecf71342eb0e38609fe8113a5e9d47375268b9f0",
"head_commit_message": "Add test for custom dict check",
"patch_to_review": "diff --git a/e2e_playwright/__snapshots__/linux/st_data_editor_input_data_test/st_data_editor-input_data_21[chromium].png b/e2e_playwright/__snapshots__/linux/st_data_editor_in... | [
{
"diff_hunk": "@@ -599,8 +594,10 @@ def table(self, data: Data = None) -> DeltaGenerator:\n \n \"\"\"\n \n- # Check if data is uncollected, and collect it but with 100 rows max, instead of 10k rows, which is done in all other cases.\n- # Avoid this and use 100 rows in st.table, because la... | 215d380016bd2a70a307d2a9b1f9c299841db5d7 | diff --git a/e2e_playwright/__snapshots__/linux/st_data_editor_input_data_test/st_data_editor-input_data_21[chromium].png b/e2e_playwright/__snapshots__/linux/st_data_editor_input_data_test/st_data_editor-input_data_21[chromium].png
index f137b417b521..b6228ac197bf 100644
Binary files a/e2e_playwright/__snapshots__/lin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
sympy__sympy-13773@bcce686 | sympy/sympy | Python | 13,773 | @/__matmul__ now only performs matrix multiplication | <!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Add check to allow __matmul__ to perform only matrix multiplication and throws ValueError if
scalars are used as operators or operands.
#### References to other Issues or PRs
This PR will ... | 2017-12-19T10:44:38Z | @ (__matmul__) should fail if one argument is not a matrix
```
>>> A = Matrix([[1, 2], [3, 4]])
>>> B = Matrix([[2, 3], [1, 2]])
>>> A@B
Matrix([
[ 4, 7],
[10, 17]])
>>> 2@B
Matrix([
[4, 6],
[2, 4]])
```
Right now `@` (`__matmul__`) just copies `__mul__`, but it should actually only work if the multiplic... | Note to anyone fixing this: `@`/`__matmul__` only works in Python 3.5+.
I would like to work on this issue. | [
{
"body": "```\r\n>>> A = Matrix([[1, 2], [3, 4]])\r\n>>> B = Matrix([[2, 3], [1, 2]])\r\n>>> A@B\r\nMatrix([\r\n[ 4, 7],\r\n[10, 17]])\r\n>>> 2@B\r\nMatrix([\r\n[4, 6],\r\n[2, 4]])\r\n```\r\n\r\nRight now `@` (`__matmul__`) just copies `__mul__`, but it should actually only work if the multiplication is actua... | 7121bdf1facdd90d05b6994b4c2e5b2865a4638a | {
"head_commit": "bcce6867ac7646ec2e3059b4a41ffb28d2265cac",
"head_commit_message": "@/__matmul__ now only performs matrix multiplication",
"patch_to_review": "diff --git a/sympy/matrices/common.py b/sympy/matrices/common.py\nindex 8c4e21fcfbe0..3061f9a8a591 100644\n--- a/sympy/matrices/common.py\n+++ b/sympy/mat... | [
{
"diff_hunk": "@@ -1973,6 +1973,13 @@ def __div__(self, other):\n \n @call_highest_priority('__rmatmul__')\n def __matmul__(self, other):\n+ other = _matrixify(other)\n+ # matrix-like objects can have shapes. This is our check.\n+ # Non matrice operands will throw error\n+ ... | d74a605e453a63c28ce6ad15dc86735e75ba8173 | diff --git a/sympy/matrices/common.py b/sympy/matrices/common.py
index 8c4e21fcfbe0..a6f996be10d7 100644
--- a/sympy/matrices/common.py
+++ b/sympy/matrices/common.py
@@ -1973,6 +1973,10 @@ def __div__(self, other):
@call_highest_priority('__rmatmul__')
def __matmul__(self, other):
+ other = _matrixi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13564@6401bb3 | sympy/sympy | Python | 13,564 | Resolves RecursionError in latex representation | fixes #13559. It was due to factor of `1/1`
```python
expr = parse_expr('5/1', evaluate=False)
expr.args
```
it gives `(5 , 1/1)` , which was not handled properly in latex conversion . So everytime an expression was divided by 1 , it resulted in RecursionError | 2017-11-04T17:08:52Z | LaTeX representation raises RecursionError
LaTeX representation of an expression that has division by 1 causes `RecursionError`. SymPy version: 1.1.1.
Code to reproduce the bug:
```python
from sympy import latex
from sympy.parsing.sympy_parser import parse_expr
expr = parse_expr('2/1', evaluate=False)
latex(e... | [
{
"body": "LaTeX representation of an expression that has division by 1 causes `RecursionError`. SymPy version: 1.1.1.\r\n\r\nCode to reproduce the bug:\r\n```python\r\nfrom sympy import latex\r\nfrom sympy.parsing.sympy_parser import parse_expr\r\n\r\nexpr = parse_expr('2/1', evaluate=False)\r\nlatex(expr)\r\n... | 36d9c850c642bec047e2cbad0a07c48f4fc7c779 | {
"head_commit": "6401bb3207756d5d097e419c9be6d57df224757e",
"head_commit_message": "added tests for changes in latex",
"patch_to_review": "diff --git a/sympy/printing/latex.py b/sympy/printing/latex.py\nindex 51c1e67f2a1e..dab13173fbb7 100644\n--- a/sympy/printing/latex.py\n+++ b/sympy/printing/latex.py\n@@ -372... | [
{
"diff_hunk": "@@ -415,12 +416,9 @@ def convert(expr):\n _tex += term_tex\n last_term_tex = term_tex\n return _tex\n+ one_by_one = parse_expr('1/1', evaluate=False)",
"line": null,
"original_line": 419,
"original_start_line": null,
... | c39ae02943ee0e91f6d9430541413a77fd4cdb80 | diff --git a/sympy/printing/latex.py b/sympy/printing/latex.py
index 51c1e67f2a1e..8a07803d8575 100644
--- a/sympy/printing/latex.py
+++ b/sympy/printing/latex.py
@@ -372,6 +372,7 @@ def _print_Gradient(self, expr):
return r"\nabla\cdot %s" % self.parenthesize(func, PRECEDENCE['Mul'])
def _print_Mul(sel... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
sympy__sympy-13709@82f9445 | sympy/sympy | Python | 13,709 | imported filldedent in line.py | fixes https://github.com/sympy/sympy/issues/13705
@smichr please review
<!-- Please give this pull request a descriptive title. Pull requests with descriptive titles are more likely to receive reviews. Describe what you changed! A title that only references an issue number is not descriptive. -->
<!-- If this pul... | 2017-12-08T21:07:03Z | import filldedent in line.py
The following should raise a ValueError:
```
>>> Line((x,1),(2,3)).arbitrary_point(x)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "sympy\geometry\line.py", line 236, in arbitrary_point
raise ValueError(filldedent('''
NameError: global name 'fil... | @smichr I would like to work on this issue. I have looked into the arbitrary_point tests and was wondering what would be the best way to write a test for the ValueError, since that error is raised in the arbitrary_point method in the line.py file as shown below
```
if t.name in (f.name for f in self.free_symbols):
... | [
{
"body": "The following should raise a ValueError:\r\n```\r\n>>> Line((x,1),(2,3)).arbitrary_point(x)\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"sympy\\geometry\\line.py\", line 236, in arbitrary_point\r\n raise ValueError(filldedent('''\r\nNameError: global... | e01729f7e7f9d43df711084dde431aad4461b792 | {
"head_commit": "82f9445670b1ef0249bcde42b386589cf22ca3ec",
"head_commit_message": "Merge pull request #1 from TheGluck/filldedent\n\nAdds test",
"patch_to_review": "diff --git a/sympy/geometry/line.py b/sympy/geometry/line.py\nindex 6af9079a9657..ab2cc8a9e569 100644\n--- a/sympy/geometry/line.py\n+++ b/sympy/ge... | [
{
"diff_hunk": "@@ -76,6 +76,12 @@ def test_arbitrary_point():\n assert Segment3D(Point3D(x1, x1, x1), Point3D(y1, y1, y1)).length == sqrt(3) * sqrt((x1 - y1) ** 2)\n assert Segment3D((1, 1, 1), (2, 3, 4)).arbitrary_point() == \\\n Point3D(t + 1, 2 * t + 1, 3 * t + 1)\n+ try:\n+ Lin... | dc50cd7e061dcde9241d036f07b303cadaa5c1ea | diff --git a/sympy/geometry/line.py b/sympy/geometry/line.py
index 6af9079a9657..ab2cc8a9e569 100644
--- a/sympy/geometry/line.py
+++ b/sympy/geometry/line.py
@@ -32,7 +32,7 @@
from .entity import GeometryEntity, GeometrySet
from .point import Point, Point3D
-from sympy.utilities.misc import Undecidable
+from sympy... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13553@666be46 | sympy/sympy | Python | 13,553 | Wrong result with solveset. Fix issue 13550 | Fix #13550.
The expression `solveset(x**2 - 2*x - 15, symbol = x, domain = Interval(-oo, 0))`
returns `EmptySet()` instead of `FiniteSet(-3)`. The bug is due to the
function `_invert(f_x, y, x, domain=S.Complexes)` in `solveset.py`. It returns `x1, s.intersection(domain)`
but in such example `x1` is `x**2 - 2*x`, s... | 2017-10-30T16:24:51Z | Wrong result with solveset
```
>>> from sympy import *
>>> x = Symbol('x')
>>> solveset(x**2 - 2*x - 15, symbol = x, domain = Interval(-oo, 0))
EmptySet()
```
This is incorrect. The correct output for the above code should be `FiniteSet(-3)`. When the `domain = S.Reals`, `FiniteSet(-3, 5)` is returned. | [
{
"body": "```\r\n>>> from sympy import *\r\n>>> x = Symbol('x')\r\n>>> solveset(x**2 - 2*x - 15, symbol = x, domain = Interval(-oo, 0))\r\nEmptySet()\r\n```\r\nThis is incorrect. The correct output for the above code should be `FiniteSet(-3)`. When the `domain = S.Reals`, `FiniteSet(-3, 5)` is returned.\r\n",
... | 9476425b9e34363c2d9ac38e9f04aa75ae54a775 | {
"head_commit": "666be46c58a8e23962f21bb05918049953c59668",
"head_commit_message": "Wrong result with solveset. Issue 13350\n\nFix 13350.\nThe expression solveset(x**2 - 2*x - 15, symbol = x, domain = Interval(-oo, 0))\nreturns EmptySet() instead of FiniteSet(-3). The bug is due to the\nfunction _invert(f_x, y, x,... | [
{
"diff_hunk": "@@ -108,6 +108,9 @@ def _invert(f_x, y, x, domain=S.Complexes):\n if not isinstance(s, FiniteSet) or x1 == f_x:",
"line": null,
"original_line": 108,
"original_start_line": null,
"path": "sympy/solvers/solveset.py",
"start_line": null,
"text": "@user1:\nI guess the co... | 071fed89e78af5544bbb07e5109dcefb6c7e6e60 | diff --git a/sympy/solvers/solveset.py b/sympy/solvers/solveset.py
index 885918210d50..59b60b2e47b9 100644
--- a/sympy/solvers/solveset.py
+++ b/sympy/solvers/solveset.py
@@ -105,7 +105,7 @@ def _invert(f_x, y, x, domain=S.Complexes):
else:
x1, s = _invert_complex(f_x, FiniteSet(y), x)
- if not isins... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
sympy__sympy-13173@a2b464e | sympy/sympy | Python | 13,173 | degree(multivariate): multivariate expression now requires generator to specified | multivariate expressions could be passed into the degree expression, in
which case the degree was returned for the first generator. As of this pull
request, when giving the degree function multivariate expressions, a
generator is mandatory to be specified, else a TypeError is raised.
Example:
```
>>> degree(x+x... | 2017-08-22T16:57:46Z | degree(multivariate) -> degree of first generator
When giving the degree function a multivariate expression, the default degree returned is for the first generator which is chosen canonically but arbitrarily. When the degree method of Poly is called, this is not so bad because one would/should know what the generators ... | [
{
"body": "When giving the degree function a multivariate expression, the default degree returned is for the first generator which is chosen canonically but arbitrarily. When the degree method of Poly is called, this is not so bad because one would/should know what the generators are. For the case of using the... | 0ccd0b8aec14b4212d25a3171c5a5b6b5a23c79a | {
"head_commit": "a2b464ea134099b69b1b499ac3bf386c329ed72b",
"head_commit_message": "degree(multivariate): Modified if clause and edited error message\n\nThe if clause added previously is changed to an elif clause. The error\nmessage is modified so as to give an example specific to the user's passed\nmultivariate e... | [
{
"diff_hunk": "@@ -4427,6 +4426,13 @@ def degree(f, gen=0):\n if gen not in p.gens:\n return S.Zero\n \n+ elif len(f.free_symbols) > 1 and sympify(gen).is_Number and not f.is_Poly:",
"line": null,
"original_line": 4429,
"original_start_line": null,
"path": "sympy/polys/p... | b8ac4ba112863382878961a372b162cc2e9fc72b | diff --git a/sympy/polys/polytools.py b/sympy/polys/polytools.py
index ff6fedc17b71..4091e39da233 100644
--- a/sympy/polys/polytools.py
+++ b/sympy/polys/polytools.py
@@ -45,7 +45,7 @@
GeneratorsError,
)
-from sympy.utilities import group, sift, public
+from sympy.utilities import group, sift, public, filldeden... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
zulip__zulip-32359@2584ca6 | zulip/zulip | Python | 32,359 | puppet: Require libldap-common be installed. | Zulip instances without a database included, like the Docker image, would not fail to use TLS properly, since `TLS_REQCERT` was not set in `/etc/ldap/ldap.conf`. While there's a few other ways we could fix this, just installing libldap-common on app frontend instances seems like a good solution, and has no impact on ot... | 2024-11-14T23:52:48Z | Version 9.0 and 9.1 "ZulipLDAPAuthBackend" Issue with TLS on ldaps 636
Hello,
we are running zulip docker for about a year now, starting from Version 7 and really enjoying the product! Good work!
Now that we upgraded our "dev" machine to version 9.0 to test the upgrade we are facing issues with authenticating thr... | We are facing the same issue. How do we can add a SSL certificate to avoid such behavior?
Also would be nice, if LOGS will be more informative over this issue
Facing the same issue, would be nice to have a fix for this
Hi,
can we get an update on this? Please :)
BR,
Felix
Hello,
we were facing the same issue... | [
{
"body": "Hello,\r\n\r\nwe are running zulip docker for about a year now, starting from Version 7 and really enjoying the product! Good work!\r\n\r\nNow that we upgraded our \"dev\" machine to version 9.0 to test the upgrade we are facing issues with authenticating through ldap. In the logs we just see:\r\n\r\... | 8356a9d9e488c876811119b9e2dc740ee6da0f8e | {
"head_commit": "2584ca6e0617f83bfec4bbc0466b6ceb1be691cf",
"head_commit_message": "puppet: Require libldap-common be installed.\n\nZulip instances without a database included, like the Docker image,\nwould not fail to use TLS properly, since `TLS_REQCERT` was not set in\n`/etc/ldap/ldap.conf`. While there's a few... | [
{
"diff_hunk": "@@ -14,8 +14,20 @@\n # package already includes the client.\n include zulip::postgresql_client\n }\n- # For Slack import\n- zulip::safepackage { 'unzip': ensure => installed }\n+ zulip::safepackage {\n+ [\n+ # For Slack import.\n+ 'unzip',\n+ # Ensures `/etc/ldap/l... | a39edb16e0a61f98af40592fa057f58bd53845ae | diff --git a/puppet/zulip/manifests/app_frontend_base.pp b/puppet/zulip/manifests/app_frontend_base.pp
index 4bf5a8f696fd8..5eac856133884 100644
--- a/puppet/zulip/manifests/app_frontend_base.pp
+++ b/puppet/zulip/manifests/app_frontend_base.pp
@@ -14,8 +14,20 @@
# package already includes the client.
include... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-8877@7924890 | streamlit/streamlit | Python | 8,877 | Horizontal `st.bar_chart` | ## Describe your changes
PR adds a boolean kwarg `horizontal=False|True` to `st.bar_chart`. The default is `False`, which keeps the current behavior.
## Testing Plan
- E2E Tests - ✅
- Manual Testing - ✅
**Note: The substantial # of snapshot changes are a consequence of the test file organization**
Added 2 hor... | 2024-06-11T21:40:03Z | Horizontal bar charts
### Problem
When having a bar chart with string indices it is very hard to read them.
### Solution
Support `barh` type chart, where the bars are horizontal rather than vertical.
So new interface would be:
```
streamlit.bar_chart(data=None, orientation='vertical', width=0, height=0)... | Hi @AmitMY, thanks a lot for the feature request. We will triage and add to our roadmap accordingly to our prioritization. In the meantime, we do support charting libraries like `altair` and also `matplotlib` that you can use to customize a chart. In this way you can get a more advance chart with little effort. Doc lin... | [
{
"body": "### Problem \r\n\r\nWhen having a bar chart with string indices it is very hard to read them.\r\n\r\n### Solution\r\n\r\nSupport `barh` type chart, where the bars are horizontal rather than vertical.\r\n\r\nSo new interface would be:\r\n```\r\nstreamlit.bar_chart(data=None, orientation='vertical', w... | 51cd0c91dfd9b2a0e90a147a4e09ce8bbc31d87f | {
"head_commit": "792489065e58a683c1c121f62e664ca6b4347c6e",
"head_commit_message": "More snaps",
"patch_to_review": "diff --git a/e2e_playwright/__snapshots__/linux/st_builtin_chart_test/st_builtin_chart-22[chromium].png b/e2e_playwright/__snapshots__/linux/st_builtin_chart_test/st_builtin_chart-22[chromium].png... | [
{
"diff_hunk": "@@ -165,15 +167,27 @@ def generate_chart(\n \n # At this point, x_column is only None if user did not provide one AND df is empty.\n \n+ if not horizontal:\n+ x_encoding = _get_x_encoding(\n+ df, x_column, x_from_user, x_axis_label, chart_type\n+ )\n+ y_enc... | fb12e006c271d875b97ca0a9cf8ea356abf3187b | diff --git a/e2e_playwright/__snapshots__/linux/st_builtin_chart_test/st_builtin_chart-22[chromium].png b/e2e_playwright/__snapshots__/linux/st_builtin_chart_test/st_builtin_chart-22[chromium].png
index 9f31492e1cba..54eaa5af708e 100644
Binary files a/e2e_playwright/__snapshots__/linux/st_builtin_chart_test/st_builtin_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
sympy__sympy-13131@2cc8481 | sympy/sympy | Python | 13,131 | Fix powsimp issues #9183, #10095, and KeyError | - Fixed powsimp raising ValueError when base is float and Pow is argument of Mul. Since multiplicity expects integer or rational but powsimp doesn't checks it, it raises ValueError: fixes #9183
- Fixed Pow.as_numer_denom() returning nan when either numerator or denominator of base is 1 and exp is infinite. Since 1**oo... | 2017-08-15T16:39:38Z | simplify throws unexpected ValueError
The following error was unexpected for me and I could not find anything about it in the docs so I thought I'd report it. Hope it helps.
kind regards,
Jesse
this works fine:
> > > a=sympy.sympify('0.12**d+43') - sympy.sympify('0.12*d+43')
> > > a.simplify()
> > > 0.12**d - 0.12*d... | sorry, I'm new to github. I don't see the asterisks in my above code anymore (why?), but I really did type in 0.12 asterisk d and 0.12 asterisk asterisk d
Please read more about [markdown](https://guides.github.com/features/mastering-markdown/).
Enclosing the text in triple backticks ("annotate as code") should do t... | [
{
"body": "The following error was unexpected for me and I could not find anything about it in the docs so I thought I'd report it. Hope it helps.\n\nkind regards,\nJesse\n\nthis works fine:\n\n> > > a=sympy.sympify('0.12**d+43') - sympy.sympify('0.12*d+43')\n> > > a.simplify()\n> > > 0.12**d - 0.12*d\n\nhoweve... | dceb708ca035c568c816d9457af1b7ca9e57c0a5 | {
"head_commit": "2cc8481d38a28009b32e962021ac60a9c5e7f0e7",
"head_commit_message": "Fix powsimp raising KeyError when base has Float\n\nFixed powsimp raising KeyError in common_b[b] = common_b[b] + e, when\none base has Float and another has its Rational(Integer) counterpart.\nThis seems to be caused by sympy/symp... | [
{
"diff_hunk": "@@ -163,9 +163,9 @@ def recurse(arg, **kwargs):\n # allow 2**x/4 -> 2**(x - 2); don't do this when b and e are\n # Numbers since autoevaluation will undo it, e.g.\n # 2**(1/3)/4 -> 2**(1/3 - 2) -> 2**(1/3)/4\n- if (b and b.is_Number and not all(ei.i... | 309a2620c6f130fd8ed4ec3239ead736a55f4d08 | diff --git a/sympy/core/power.py b/sympy/core/power.py
index 82bc545f3307..2c31134dc460 100644
--- a/sympy/core/power.py
+++ b/sympy/core/power.py
@@ -1174,6 +1174,11 @@ def as_numer_denom(self):
if neg_exp:
n, d = d, n
exp = -exp
+ if exp.is_infinite:
+ if n is S.On... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13531@cc6b61c | sympy/sympy | Python | 13,531 | manualintegrate modifications | fixes #9687
closes #10611 as a replacement and modification | 2017-10-25T01:49:29Z | integrate(1/((x**2+4)*sqrt(4*x**2+1)), x) raises `TypeError: 'NoneType' object has no attribute '__getitem__'`
```
In [1]: integrate(1/((x**2+4)*sqrt(4*x**2+1)), x)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ip... | @lidavidm, do you have any idea what is going on here? The error seems to come from `manualintegrate`.
It's assuming that `subexpr.match(query)` is not `None` for each `subexpr in expr.find(query)`. I guess it should check if the `match` is `None`, and if so, move on to the next subexpression. | [
{
"body": "```\nIn [1]: integrate(1/((x**2+4)*sqrt(4*x**2+1)), x)\n---------------------------------------------------------------------------\nTypeError Traceback (most recent call last)\n<ipython-input-1-b25b3537657d> in <module>()\n----> 1 integrate(1/((x**2+4)*sqrt(4*x**2+1))... | bc6c481dc04e360d83c32296d02fb7b74d980822 | {
"head_commit": "cc6b61cf4d06790ebeec7d690a020bd556b9513e",
"head_commit_message": "fix ode tests",
"patch_to_review": "diff --git a/sympy/integrals/manualintegrate.py b/sympy/integrals/manualintegrate.py\nindex 8ef504501bbd..8040a16949b6 100644\n--- a/sympy/integrals/manualintegrate.py\n+++ b/sympy/integrals/ma... | [
{
"diff_hunk": "@@ -542,21 +542,17 @@ def test_checksysodesol():\n \n @slow\n def test_nonlinear_3eq_order1():\n- x, y, z = symbols('x, y, z', function=True)\n+ x, y, z, C3 = symbols('x, y, z, C3', function=True)\n t = Symbol('t')\n- eq1 = (4*diff(x(t),t) + 2*y(t)*z(t), 3*diff(y(t),t) - z(t)*x(t), ... | e476995a5feb9011fe93ac3f0dffdb66845b68f2 | diff --git a/sympy/integrals/manualintegrate.py b/sympy/integrals/manualintegrate.py
index 5bab3f5ded6b..ec16c456d900 100644
--- a/sympy/integrals/manualintegrate.py
+++ b/sympy/integrals/manualintegrate.py
@@ -28,6 +28,8 @@
from sympy.strategies.core import switch, do_one, null_safe, condition
+ZERO = sympy.S.Zer... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-12228@dd59fe6 | sympy/sympy | Python | 12,228 | differentiate_finite: set evaluate kwarg default to False (fix gh-12186) | In `differentiate_finite` , the default of the kwarg in `evaluate` is changed from `True` to `False` and hence fixes gh-12186.
"Fortunately", the default value of `evaluate` was undocumented so I think we can skip a deprecation cycle in this case.
@halpernf I would be grateful to hear if you have any feedback on ... | 2017-02-27T17:51:27Z | default behavior for product rule in differentiate_finite is incorrect
Hi everybody,
First time user of SymPy. So far I am quite enjoying this and I was able to generate Arakawa brackets of arbitrary order with just a few lines of SymPy. I wanted to report on an issue I came across.
The following expression from ... | I am +1 for just changing the default to `evaluate=False`, @halpernf would you mind opening a PR changing this and perhaps changing the docstring to include the point you've made in this issue?
@bjodah I would like to work on this issue, kindly refer to any starting point on this . Thanks
@mohit3011 are you familiar... | [
{
"body": "Hi everybody,\r\n\r\nFirst time user of SymPy. So far I am quite enjoying this and I was able to generate Arakawa brackets of arbitrary order with just a few lines of SymPy. I wanted to report on an issue I came across.\r\n\r\nThe following expression from the SymPy documentation shows use of the pro... | d60497958f6dea7f5e25bc41e9107a6a63694d01 | {
"head_commit": "dd59fe6337d145b826eb2e9bd4acc5a1d18b857f",
"head_commit_message": "Change evaluate kwarg default to False (fixes gh-12186)",
"patch_to_review": "diff --git a/doc/src/tutorial/calculus.rst b/doc/src/tutorial/calculus.rst\nindex 1c2c3c336561..61ac1077901e 100644\n--- a/doc/src/tutorial/calculus.rs... | [
{
"diff_hunk": "@@ -430,35 +430,42 @@ def differentiate_finite(expr, *symbols,\n wrt: Symbol, optional\n see ``Derivative.as_finite_difference``\n evaluate : bool\n- kwarg passed on to ``diff`` (whether or not to\n- evaluate the Derivative intermediately).\n+ kwarg passed on... | 2a44518358e27ded79e945f226a5cb1821294db1 | diff --git a/doc/src/tutorial/calculus.rst b/doc/src/tutorial/calculus.rst
index 1c2c3c336561..fcfa4a6e0f03 100644
--- a/doc/src/tutorial/calculus.rst
+++ b/doc/src/tutorial/calculus.rst
@@ -323,13 +323,15 @@ the ``differentiate_finite`` function:
>>> f, g = symbols('f g', cls=Function)
>>> differentiate_fi... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-12194@1e0c8ff | sympy/sympy | Python | 12,194 | ntheory : Add functionality to return list of all factors | Passing in the argument `multiple=True` to `factorint()` or `factorrat()` returns a list of all the prime factors constituting the number along with multiplicity.
PR #12124 got messed up, so I opened a new PR.
Example:
```
>>> factorint(222,multiple=True)
[2, 3, 37]
>>>factorrat(S(25)/14, multiple=True)
[1/2, ... | 2017-02-18T13:56:49Z | List of prime factors including multiplicity is missing
The vast majority of the time when using prime factorization in algorithms I'm interested in a list of prime factors. E.g. for 24 it's `[2, 2, 2, 3]`. However sympy (to my knowledge) only provides `sympy.factorint` which returns a dictionary. I always end up writi... | A possibility is:
```
>>> from sympy.utilities.iterables import multiset_combinations
>>> d={'a':3,'b':2,'c':2}
>>> list(multiset_combinations(d, sum(d.values())))[0]
['a', 'a', 'a', 'b', 'b', 'c', 'c']
>>> d = factoring(24)
>>> list(multiset_combinations(d, sum(d.values())))[0]
[2, 2, 2, 3]
```
But maybe... | [
{
"body": "The vast majority of the time when using prime factorization in algorithms I'm interested in a list of prime factors. E.g. for 24 it's `[2, 2, 2, 3]`. However sympy (to my knowledge) only provides `sympy.factorint` which returns a dictionary. I always end up writing a helper function:\r\n\r\n fact... | 62b1996e353fedc1e3fb51f626ffaae9583b74a6 | {
"head_commit": "1e0c8ff1eb5298bbd754a2df0ad82e7e7f2383d4",
"head_commit_message": "ntheory: Add multiple=True to return list of factors",
"patch_to_review": "diff --git a/sympy/ntheory/factor_.py b/sympy/ntheory/factor_.py\nindex 67c2c18ce7db..fe078c375fb4 100644\n--- a/sympy/ntheory/factor_.py\n+++ b/sympy/nth... | [
{
"diff_hunk": "@@ -942,6 +942,15 @@ def factorint(n, limit=None, use_trial=True, use_rho=True, use_pm1=True,\n smoothness, smoothness_p, divisors\n \n \"\"\"\n+ if multiple:\n+ fac = factorint(n, limit=limit, use_trial=use_trial,\n+ use_rho=use_rho, use_pm1=use_pm1,\... | 00d420521775e72c73966ce8c38ce2739fd12bd0 | diff --git a/sympy/ntheory/factor_.py b/sympy/ntheory/factor_.py
index 67c2c18ce7db..32b91c99be7c 100644
--- a/sympy/ntheory/factor_.py
+++ b/sympy/ntheory/factor_.py
@@ -803,7 +803,7 @@ def done(n, d):
def factorint(n, limit=None, use_trial=True, use_rho=True, use_pm1=True,
- verbose=False, visual=No... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
sympy__sympy-12066@0ab8193 | sympy/sympy | Python | 12,066 | Fix Subs._eval_derivative function for higher order derivative | Fixes #12005 , one of the test cases(only one) taken from diofant.
If this fix has any similarity with the code of skirpichev that is probably a coincidence. I have only used the test case from his PR.
<!-- If this pull request fixes an issue please indicate which issue by typing "Fixes #NNNN" below.>
| 2017-01-19T21:22:22Z | Subs._eval_derivative doubles derivatives
This issue appears in the computation of higher derivatives with respect to functions.
```
>>> x = symbols('x')
>>> f = symbols('f', cls=Function)
>>> e = Subs(Derivative(f(x), x), (x,), (x,))
>>> e._eval_derivative(x)
2*Derivative(f(x), x, x)
```
Apparently, the deriva... | This is the reason for the error encountered in #11799. | [
{
"body": "This issue appears in the computation of higher derivatives with respect to functions.\r\n```\r\n>>> x = symbols('x')\r\n>>> f = symbols('f', cls=Function)\r\n>>> e = Subs(Derivative(f(x), x), (x,), (x,))\r\n>>> e._eval_derivative(x)\r\n2*Derivative(f(x), x, x)\r\n```\r\nApparently, the derivative is... | 8b3fcd87c83de5b55a959cf18501c2a4f4d8e289 | {
"head_commit": "0ab8193b0914b4f9643c50380f56ec82705dd1b5",
"head_commit_message": "Fix Subs._eval_derivative function for higher order derivative\n\nFixes #12005, one of the test cases(only one) taken from diofant",
"patch_to_review": "diff --git a/sympy/core/function.py b/sympy/core/function.py\nindex 2d33d96b... | [
{
"diff_hunk": "@@ -1738,10 +1738,9 @@ def _eval_subs(self, old, new):\n def _eval_derivative(self, s):\n if s not in self.free_symbols:\n return S.Zero\n- return self.func(self.expr.diff(s), self.variables, self.point).doit() \\\n- + Add(*[ Subs(point.diff(s) * self.ex... | 1d1fc47a61a8951f47253a52d47569d76bcc3581 | diff --git a/sympy/core/function.py b/sympy/core/function.py
index 2d33d96b94b3..1b8005e1d230 100644
--- a/sympy/core/function.py
+++ b/sympy/core/function.py
@@ -1738,10 +1738,10 @@ def _eval_subs(self, old, new):
def _eval_derivative(self, s):
if s not in self.free_symbols:
return S.Zero
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-11951@e7a7ff3 | sympy/sympy | Python | 11,951 | Matrix hstack/vstack improved | fixes #11944
| 2016-12-16T09:56:49Z | matrix vstack/hstack can fail with immutable matrix as first argument
````
>>> A = Matrix([[1, 2], [pi, 4]])
>>> AIm = sympify(A)
>>> type(A)
sympy.matrices.dense.MutableDenseMatrix
>>> type(AIm)
sympy.matrices.immutable.ImmutableMatrix
>>> Matrix.vstack(A, AIm)
⎡1 2⎤
⎢ ⎥
⎢π 4⎥
⎢ ⎥
⎢1 2⎥
⎢ ... | I want to try this.
@cbm755 this the output in my system and seems to be fine.
```
In [36]: A=Matrix([[1,2],[pi,4]])
In [37]: AIm=sympify(A)
In [38]: type(A)
Out[38]: sympy.matrices.dense.MutableDenseMatrix
In [39]: type(AIm)
Out[39]: sympy.matrices.immutable.ImmutableMatrix
In [40]: Matrix.vstack(AIm,... | [
{
"body": "````\r\n>>> A = Matrix([[1, 2], [pi, 4]])\r\n>>> AIm = sympify(A)\r\n\r\n>>> type(A)\r\nsympy.matrices.dense.MutableDenseMatrix\r\n\r\n>>> type(AIm)\r\nsympy.matrices.immutable.ImmutableMatrix\r\n\r\n>>> Matrix.vstack(A, AIm)\r\n⎡1 2⎤\r\n⎢ ⎥\r\n⎢π 4⎥\r\n⎢ ⎥\r\n⎢1 2⎥\r\n⎢ ⎥\r\n⎣π 4⎦\r\n\r... | b1f55f2ad770cd656ebcb0207f10605f996c63cf | {
"head_commit": "e7a7ff33e6fba08bf4fb56e7129e44df39e5a919",
"head_commit_message": "Tests corrected",
"patch_to_review": "diff --git a/sympy/matrices/matrices.py b/sympy/matrices/matrices.py\nindex 2fd4efa8ca06..edd9d9fd6008 100644\n--- a/sympy/matrices/matrices.py\n+++ b/sympy/matrices/matrices.py\n@@ -2035,7 +... | [
{
"diff_hunk": "@@ -2378,6 +2378,13 @@ def test_issue_5320():\n [0, 1, 0, 2]\n ])\n \n+def test_issue_11944():\n+ A = Matrix([[1]])\n+ AIm = sympify(A)\n+ assert Matrix.hstack(AIm, A) == Matrix([[1, 1]])\n+ assert Matrix.vstack(AIm, A) == Matrix([\n+ [1, ],\n+ [1, ]])",
... | 8c1de45cd73d9c6708f6f05e2c92e21e4d3d1350 | diff --git a/sympy/matrices/matrices.py b/sympy/matrices/matrices.py
index e7d0d4998fb9..71026d1297a6 100644
--- a/sympy/matrices/matrices.py
+++ b/sympy/matrices/matrices.py
@@ -3170,7 +3170,8 @@ def hstack(cls, *args):
[1, 0, 2, 0],
[0, 1, 0, 2]])
"""
- return reduce(cls.row_join, ar... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-11818@ab1bcd5 | sympy/sympy | Python | 11,818 | Fixed behaviour of S.Complexes in unions (#11730) | This PR fixes #11730 | 2016-11-06T19:54:19Z | Union(FiniteSet(oo), S.Complexes) gives S.Complexes (should remain unevaluated)
Hi, well searching i found this:
``` python
>>> oo in S.UniversalSet
True
>>> oo in S.Complexes
False
>>> Union(FiniteSet(oo), S.Complexes)
S.Complexes
```
i don't know with this where `oo` belongs, is part of Complexes or not?
Thx. Cya. | UniversalSet doesn't come into play here. It's just a formal set that always returns True for any containment check. `Union(FiniteSet(oo), S.Complexes)` giving `S.Complexes` is a bug.
(Optimistically setting this as easy to fix. I suspect it isn't difficult, but there is a chance I am wrong)
After working for a bit ... | [
{
"body": "Hi, well searching i found this:\n\n``` python\n>>> oo in S.UniversalSet\nTrue\n>>> oo in S.Complexes\nFalse\n>>> Union(FiniteSet(oo), S.Complexes)\nS.Complexes\n```\n\ni don't know with this where `oo` belongs, is part of Complexes or not?\n\nThx. Cya.\n",
"number": 11730,
"title": "Union(Fi... | a221c376f3f382d251a600aa336b45e95f92b7fe | {
"head_commit": "ab1bcd52134398f569a28184f6ff40688052c939",
"head_commit_message": "Add unit test for issue 11730\n\n Modified test test_ComplexRegion_union to be consistent with other\n tests.",
"patch_to_review": "diff --git a/sympy/sets/fancysets.py b/sympy/sets/fancysets.py\nindex a009f3f7ab95..5f88e53... | [
{
"diff_hunk": "@@ -1443,8 +1441,13 @@ def _union(self, other):\n elif self.polar and other.polar:\n return ComplexRegion(Union(self.sets, other.sets), polar=True)\n \n- if self == S.Complexes:\n- return self\n+ # treat a subset of Reals as complex numbers\n+... | d6e6e8335ae22f09a3c9b9177333a7fb84cd2be1 | diff --git a/sympy/sets/fancysets.py b/sympy/sets/fancysets.py
index a009f3f7ab95..cae6eb7d429c 100644
--- a/sympy/sets/fancysets.py
+++ b/sympy/sets/fancysets.py
@@ -1353,6 +1353,25 @@ def _measure(self):
"""
return self.sets._measure
+ @classmethod
+ def from_real(cls, sets):
+ """
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-13016@98a97d7 | sympy/sympy | Python | 13,016 | making invert_real to work for 0**x + a type equations | This PR tries to fix [issue#11536](https://github.com/sympy/sympy/issues/11536).
The approach I applied solves the issue but other `test cases` fail, and I am not able to figure it out what might have caused the failure.
ping @kshitij10496
| 2017-07-20T19:32:13Z | Solution of 0**x + a should be EmptySet
There is some discrepancy in the behaviour of `0**x` and the solving technique for the following equations in solveset:
``` python
In []: solveset(0**x - 1, x, S.Reals)
Out[]: {0} # correct result
In []: solveset(0**x - 100, x, S.Reals)
Out[]: {0} # should be EmptySet
In []: ... | For
``` python
solve(0**x - 100, x)
```
SymPy 1.0 returns
``` python
ConditionSet(x, Eq(0**x - 100, 0), Complexes((-oo, oo) x (-oo, oo), False))
```
Which version of SymPy are you using?
I agree with you @kshitij10496. Should it be fixed? If so I would like to work on it.
> Should it be fixed? If so I would like t... | [
{
"body": "There is some discrepancy in the behaviour of `0**x` and the solving technique for the following equations in solveset:\n\n``` python\nIn []: solveset(0**x - 1, x, S.Reals)\nOut[]: {0} # correct result\n\nIn []: solveset(0**x - 100, x, S.Reals)\nOut[]: {0} # should be EmptySet \n\nIn []: solveset(0**... | 2f3eba1cd616166d3b11c7a0aa2bdb4d453093e5 | {
"head_commit": "98a97d7680cce5fe7d3a2996814417d96c474b12",
"head_commit_message": "re-implemented the logic",
"patch_to_review": "diff --git a/sympy/solvers/solveset.py b/sympy/solvers/solveset.py\nindex 7d5dc1254a81..84d8c415c590 100644\n--- a/sympy/solvers/solveset.py\n+++ b/sympy/solvers/solveset.py\n@@ -117... | [
{
"diff_hunk": "@@ -188,8 +187,13 @@ def _invert_real(f, g_ys, symbol):\n return _invert_real(base, res, symbol)\n \n if not base_has_sym:\n- return _invert_real(expo,\n- imageset(Lambda(n, log(n)/log(base)), g_ys), symbol)\n+ if base is not S.Zero:\n... | f87af89ef8eb3b1539a5b57e4f4126a40f7ac707 | diff --git a/sympy/solvers/solveset.py b/sympy/solvers/solveset.py
index 7d5dc1254a81..af0f1c1c3170 100644
--- a/sympy/solvers/solveset.py
+++ b/sympy/solvers/solveset.py
@@ -117,7 +117,6 @@ def invert_real(f_x, y, x, domain=S.Reals):
"""
return _invert(f_x, y, x, domain)
-
def _invert_real(f, g_ys, symbol... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-12888@498ebe7 | sympy/sympy | Python | 12,888 | Fix Idx bounds assumptions | This PR fixes #12780 | 2017-07-04T16:31:23Z | Idx should not require integer assumptions
```py
>>> n = symbols('n')
>>> Idx('i', (0, n))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "./sympy/tensor/indexed.py", line 585, in __new__
raise TypeError("Idx object requires integer bounds.")
TypeError: Idx object requires in... | Hi @asmeurer,
Going through the `Idx` docstring, it states that
> Note: the ``Idx`` constructor is rather pedantic in that it only accepts
integer arguments. The only exception is that you can use ``-oo`` and
``oo`` to specify an unbounded range. For all other cases, both label and
bounds must b... | [
{
"body": "```py\r\n>>> n = symbols('n')\r\n>>> Idx('i', (0, n))\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"./sympy/tensor/indexed.py\", line 585, in __new__\r\n raise TypeError(\"Idx object requires integer bounds.\")\r\nTypeError: Idx object requires intege... | c87c0fbf1223c28db8590f2591f64db75d5bdd66 | {
"head_commit": "498ebe772fa1de889e51376dbcd5262d6b449544",
"head_commit_message": "Update docs, add test for issue 12780",
"patch_to_review": "diff --git a/sympy/tensor/indexed.py b/sympy/tensor/indexed.py\nindex 7e40f1554c7e..debcffa38029 100644\n--- a/sympy/tensor/indexed.py\n+++ b/sympy/tensor/indexed.py\n@@... | [
{
"diff_hunk": "@@ -581,7 +579,7 @@ def __new__(cls, label, range=None, **kw_args):\n raise ValueError(filldedent(\"\"\"\n Idx range tuple must have length 2, but got %s\"\"\" % len(range)))\n for bound in range:\n- if not (bound.is_integer or abs(b... | 25bbdbd912c010f0ae550f4e222bcf94f85f6a31 | diff --git a/sympy/tensor/indexed.py b/sympy/tensor/indexed.py
index 7e40f1554c7e..123a47843510 100644
--- a/sympy/tensor/indexed.py
+++ b/sympy/tensor/indexed.py
@@ -510,11 +510,9 @@ class Idx(Expr):
* ``tuple``: The two elements are interpreted as the lower and upper
bounds of the range, respectiv... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
sympy__sympy-12490@a08a034 | sympy/sympy | Python | 12,490 | ccode: Add capability to _print_Indexed() to use user-defined strided schemes and offsets | <!-- Please give this pull request a descriptive title. Pull requests with descriptive titles are more likely to receive reviews. Describe what you changed! A title that only references an issue number is not descriptive. -->
As mentioned in #12464 , `ccode` unrolled 2D `Indexed` objects in row-major format. This PR a... | 2017-04-04T11:19:33Z | CCodePrinter._print_Indexed assumes row-major ordering
When working with BLAS and LAPACK it's quite common to work with column-major ordering.
To avoid unneccessary transposes `_print_Indexed` should also support column-major ordering.
It is probably easiest to add either an `ordering` or `strides` property to `Index... | Can you show me a simple example of an `Indexed` object which would use this method when translated to C code? I have gone through [this page](http://docs.sympy.org/dev/modules/tensor/indexed.html) but any `Indexed` object I'm trying out seems to lack some or the other attribute required in `_print_Indexed`.
Sure,
```... | [
{
"body": "When working with BLAS and LAPACK it's quite common to work with column-major ordering.\r\nTo avoid unneccessary transposes `_print_Indexed` should also support column-major ordering.\r\nIt is probably easiest to add either an `ordering` or `strides` property to `Indexed`.",
"number": 12464,
... | 5f7df4e47c7b36f3795456afdd2022c1463ca2a2 | {
"head_commit": "a08a034a47ad797059e46930feeb7863ddac71be",
"head_commit_message": "Rectify doctest",
"patch_to_review": "diff --git a/sympy/printing/ccode.py b/sympy/printing/ccode.py\nindex ee21ea62a954..ecf2905fabfa 100644\n--- a/sympy/printing/ccode.py\n+++ b/sympy/printing/ccode.py\n@@ -170,13 +170,33 @@ de... | [
{
"diff_hunk": "@@ -170,13 +170,33 @@ def _print_Rational(self, expr):\n \n def _print_Indexed(self, expr):\n # calculate index for 1d array\n- dims = expr.shape\n- elem = S.Zero\n- offset = S.One\n- for i in reversed(range(expr.rank)):\n- elem += expr.indices[... | e79cc4b47377d50b090eadd9949e92ea84200d2c | diff --git a/sympy/printing/ccode.py b/sympy/printing/ccode.py
index ee21ea62a954..e3914f5ff9a6 100644
--- a/sympy/printing/ccode.py
+++ b/sympy/printing/ccode.py
@@ -170,13 +170,26 @@ def _print_Rational(self, expr):
def _print_Indexed(self, expr):
# calculate index for 1d array
- dims = expr.sh... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
sympy__sympy-12286@d62a240 | sympy/sympy | Python | 12,286 | recreatable Dummy, simplified | Fixes #11847.
This is a simplification of #12144, only the last commit is new. This version has slightly weaker guarantees but is much simpler and in particular doesn't keep an extra dict around to track the ordering of Dummys.
Summary of issues to consider [added by cps from below, updated again by cbm]
----
... | 2017-03-10T23:10:16Z | Dummy fails when is re-evaluated in S and srepr
Hi all!
Well, i found this little problem, Dummy is a nice function but in the way is implemented exist this:
```
>>> alpha = Dummy("alpha")
>>> i = Integral(1/sqrt(1 - sin(alpha)**2), (alpha, 0, pi/2))
>>> N(i)
0.e+2
>>> i = S(srepr(i))
>>> N(i)
Integral(1/sqr... | I can confirm this. Quoting `printing/repr.py`
> srepr returns a string so that the relation eval(srepr(expr))=expr holds in an appropriate environment.
Here's my minimal example:
```
>>> d = Dummy('d')
>>> A = Add(d, d, evaluate=False)
>>> srepr(A) # can see what the problem will be
"Add(Dummy(... | [
{
"body": "Hi all!\r\n\r\nWell, i found this little problem, Dummy is a nice function but in the way is implemented exist this:\r\n```\r\n>>> alpha = Dummy(\"alpha\")\r\n>>> i = Integral(1/sqrt(1 - sin(alpha)**2), (alpha, 0, pi/2))\r\n>>> N(i)\r\n0.e+2\r\n>>> i = S(srepr(i))\r\n>>> N(i)\r\nIntegral(1/sqrt(-sin(... | 24ba5c32d9a6383e67cc159740152f60c48c2b2b | {
"head_commit": "d62a2407600412a63d96831ffb98c25623d23797",
"head_commit_message": "Dummy: remove untrue comment from test\n\n[skip-ci]",
"patch_to_review": "diff --git a/sympy/core/function.py b/sympy/core/function.py\nindex eec86a8540d5..c7688f5829bc 100644\n--- a/sympy/core/function.py\n+++ b/sympy/core/funct... | [
{
"diff_hunk": "@@ -178,13 +179,13 @@ def free_symbols(self):\n \n \n class Dummy(Symbol):\n- \"\"\"Dummy symbols are each unique, identified by an internal count index:\n+ \"\"\"Dummy symbols are each unique, even if they have the same name:\n \n >>> from sympy import Dummy\n >>> bool(Dummy(\"x\"... | 6c79fd29972d5a5bbde311b014cf423de14d6e8e | diff --git a/sympy/core/function.py b/sympy/core/function.py
index eec86a8540d5..c7688f5829bc 100644
--- a/sympy/core/function.py
+++ b/sympy/core/function.py
@@ -707,8 +707,7 @@ def fdiff(self, argindex=1):
else:
return Derivative(self, self.args[argindex - 1], evaluate=False)
# ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
sympy__sympy-12147@afc48d4 | sympy/sympy | Python | 12,147 | check_assumptions: Improvement in the return value of the function | closes: #12146
| 2017-02-10T11:55:26Z | Improvement in check_assumptions in solvers
check_assumption just returns True or False. So rather than just returning False if the assumption about the expression that is incorrect is also returned the user would know which of all the set of assumptions is False. This would probably help him determining the expression... | [
{
"body": "check_assumption just returns True or False. So rather than just returning False if the assumption about the expression that is incorrect is also returned the user would know which of all the set of assumptions is False. This would probably help him determining the expression correctly.\r\n",
"nu... | 69d64a71b9678aff5e8e94f38f097eaefd0f4a32 | {
"head_commit": "afc48d4478fd1176d8d08be59865d4715bd86114",
"head_commit_message": "added `failing_assumptions()` as a helper for `check_assumptions()` and tests",
"patch_to_review": "diff --git a/sympy/solvers/solvers.py b/sympy/solvers/solvers.py\nindex 5723f14c63b0..6000854756bf 100644\n--- a/sympy/solvers/so... | [
{
"diff_hunk": "@@ -361,7 +361,51 @@ def checksol(f, symbol, sol=None, **flags):\n # TODO: improve solution testing\n \n \n-def check_assumptions(expr, against=None, failing_assumption=False, **assumptions):\n+def failing_assumptions(expr, against=None, **assumptions):\n+ \"\"\"\n+ Helper for ``check_... | b5c4925421cfa56646c6b01017a00945c280b277 | diff --git a/sympy/solvers/__init__.py b/sympy/solvers/__init__.py
index c7ae36fe188e..a498d56e9699 100644
--- a/sympy/solvers/__init__.py
+++ b/sympy/solvers/__init__.py
@@ -10,7 +10,7 @@
"""
from .solvers import solve, solve_linear_system, solve_linear_system_LU, \
solve_undetermined_coeffs, nsolve, solve_line... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
streamlit__streamlit-7270@3a8b1b8 | streamlit/streamlit | Python | 7,270 | Allow `None` as index for `st.selectbox` | ## Describe your changes
This PR adds support for setting `None` as the index in `st.selectbox`. Using `index=None` will render an empty selectbox with no option selected, which returns `None` as long as the user hasn't selected an option:
<img width="718" alt="image" src="https://github.com/streamlit/streamlit/a... | 2023-09-02T16:41:25Z | st.selectbox - No selection per default
### Problem
I believe it is currently not possible to use a selectbox that has nothing selected per default. This may be undesirable in some cases.
### Solution
Replace the `index`parameter with a `default` parameter just like the multiselect item does. Problem: This is... | Here is a workaround:
Example: display a map only if a valid zoom level is selected:
```
map_zoom = st.selectbox('Zoom level',
['<select>', 12, 11, 10, 9, 8, 7],
0) # default value = index 0
if map_zoom != '<select>':
st.map(data, zoom=map_zoom)
```
... | [
{
"body": "### Problem\r\n\r\nI believe it is currently not possible to use a selectbox that has nothing selected per default. This may be undesirable in some cases.\r\n\r\n### Solution\r\n\r\nReplace the `index`parameter with a `default` parameter just like the multiselect item does. Problem: This is a breakin... | 4f45c18a4323a796440d651ba77b5eb29409cb2b | {
"head_commit": "3a8b1b8bed4c0e4afd0ea1611759bcb1ec7e72d5",
"head_commit_message": "Fix test",
"patch_to_review": "diff --git a/e2e/scripts/st_selectbox.py b/e2e/scripts/st_selectbox.py\nindex 8ba9860fefdc..46b53f98c2a0 100644\n--- a/e2e/scripts/st_selectbox.py\n+++ b/e2e/scripts/st_selectbox.py\n@@ -23,7 +23,7 ... | [
{
"diff_hunk": "@@ -51,41 +52,80 @@\n @dataclass\n class SelectboxSerde(Generic[T]):\n options: Sequence[T]\n- index: int\n+ index: int | None\n \n- def serialize(self, v: object) -> int:\n+ def serialize(self, v: object) -> int | None:\n+ if v is None:\n+ return None\n ... | c424fa238c7cadd38f5d4248d9260c5329dd5b4f | diff --git a/e2e_playwright/__snapshots__/linux/st_selectbox_test/st_selectbox-callback_help[dark_theme-chromium].png b/e2e_playwright/__snapshots__/linux/st_selectbox_test/st_selectbox-callback_help[dark_theme-chromium].png
new file mode 100644
index 000000000000..ab62d96948b7
Binary files /dev/null and b/e2e_playwrig... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-7840@be146db | streamlit/streamlit | Python | 7,840 | Add check that individual elements are "python comparable" | <!--
⚠️ BEFORE CONTRIBUTING PLEASE READ OUR CONTRIBUTING GUIDELINES!
https://github.com/streamlit/streamlit/wiki/Contributing
-->
## Describe your changes
Add check that individual elements are comparable and comparison return boolean
## GitHub Issue Link (if applicable)
Closes: #3714
## Testing Plan
... | 2023-12-14T14:47:07Z | Exception "The truth value of a Series is ambiguous" when using Pandas row object as widget state
### Summary
Note: this is a new issue when I upgraded streamlit to the current version which added session state.
Suppose I use a pandas object as the selected state for a widget like a radio button (code sample belo... | Thanks for reporting this @kahliburke. I'll look into this to see if there's a reasonable fix that doesn't require us to have to special-case the scenario where the widget values are `pd.Series` objects, although I have a hunch that there's not too much else we can do to support this.
Thanks for the response. That is h... | [
{
"body": "### Summary\r\n\r\nNote: this is a new issue when I upgraded streamlit to the current version which added session state.\r\n\r\nSuppose I use a pandas object as the selected state for a widget like a radio button (code sample below). Then when changes occur in the widget, an exception is thrown:\r\n\... | 9cfb2fc9684cbbe9928b34689f29a73ea3673df1 | {
"head_commit": "be146db11629ed2d7571277e3c00e710b3c978c9",
"head_commit_message": "Add check that individual elements are comparable and comparison return boolean",
"patch_to_review": "diff --git a/lib/streamlit/elements/widgets/multiselect.py b/lib/streamlit/elements/widgets/multiselect.py\nindex 186d81065323.... | [
{
"diff_hunk": "@@ -656,6 +657,23 @@\n return list(it)\n \n \n+def check_python_comparable(seq: Sequence) -> None:\n+ \"\"\"Check if the sequence elements support \"python comparison\".\n+ That means that the equality operator (==) returns a boolean value.\n+ Which is not True for e.g. numpy ar... | 85ab9f34fc36d890c361eefcbbd2d1144ea773de | diff --git a/lib/streamlit/elements/widgets/multiselect.py b/lib/streamlit/elements/widgets/multiselect.py
index 186d81065323..f859a7055b05 100644
--- a/lib/streamlit/elements/widgets/multiselect.py
+++ b/lib/streamlit/elements/widgets/multiselect.py
@@ -50,6 +50,7 @@
LabelVisibility,
OptionSequence,
T,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
zulip__zulip-31199@0dddf15 | zulip/zulip | Python | 31,199 | Defer computing last_edit_timestr until tooltip renders. | Earlier, we used to compute last_edit_timestr as data-tippy-content when rendering the whole message feed.
This commit changes the behaviour by computing the `last_edit_timestr` when a user hovers over the message_edit_notice.
Fixes: zulip#27240.
<!-- Describe your pull request here.-->
<!-- If the PR makes... | 2024-07-31T21:53:52Z | Defer rendering last_edit_timestr until actually hovering over a message
At present, we have logic that computes the `last_edit_timestr` to display as a Tippy tooltip when hovering over a message date element:
```
$ cat web/templates/edited_notice.hbs
{{#if msg/local_edit_timestamp}}
<div class="message_edit_noti... | [
{
"body": "At present, we have logic that computes the `last_edit_timestr` to display as a Tippy tooltip when hovering over a message date element:\r\n\r\n```\r\n$ cat web/templates/edited_notice.hbs\r\n{{#if msg/local_edit_timestamp}}\r\n<div class=\"message_edit_notice\" data-tippy-content=\"{{t 'Last edited ... | 4b25425adfb95584271f867ea995a58dd335c5fd | {
"head_commit": "0dddf152d7bf332c2874d62b907d847bfe7c6385",
"head_commit_message": "tooltips: Defer computing last_edit_timestr until tooltip renders.\n\nEarlier, we used to compute last_edit_timestr as data-tippy-content\nwhen rendering the whole message feed.\n\nThis commit changes the behaviour by computing the... | [
{
"diff_hunk": "@@ -1,7 +1,11 @@\n <div>\n <div>{{t \"View edit history\"}}</div>\n {{#if realm_allow_edit_history}}",
"line": 2,
"original_line": 2,
"original_start_line": null,
"path": "web/templates/message_edit_notice_tooltip.hbs",
"start_line": null,
"text": "@user2:\nThis p... | b18dee2c9e35d5743b71564b6080418a804e8ea6 | diff --git a/web/src/message_list_tooltips.ts b/web/src/message_list_tooltips.ts
index 58992b8a4a234..5abe9e111fd60 100644
--- a/web/src/message_list_tooltips.ts
+++ b/web/src/message_list_tooltips.ts
@@ -6,7 +6,9 @@ import render_message_edit_notice_tooltip from "../templates/message_edit_notice
import render_message... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
streamlit__streamlit-7269@007fb8e | streamlit/streamlit | Python | 7,269 | Allow `None` as index for `st.radio` | ## Describe your changes
This PR adds support for setting `None` as the index in `st.radio`. Using `index=None` will render an empty radio with no option selected which returns `None` as long as the user hasn't selected an option:
<img width="219" alt="image" src="https://github.com/streamlit/streamlit/assets/285... | 2023-09-02T12:14:56Z | Radio button without pre-selection
This option is possible as I saw in other platforms. It would be cool if you also add this option.
---
Community voting on feature requests enables the Streamlit team to understand which features are most important to our users.
**If you'd like the Streamlit team to prioriti... | Yes, this would a convenient feature. I currently insert a blank element as the 1st radio button element, as a current workaround.
@kiansina Thanks for your suggestion! This sounds like a useful enhancement 👍 I will forward this feature request to our product team.
For other users reading this enhancement: please ... | [
{
"body": "This option is possible as I saw in other platforms. It would be cool if you also add this option. \r\n\r\n---\r\n\r\nCommunity voting on feature requests enables the Streamlit team to understand which features are most important to our users.\r\n\r\n**If you'd like the Streamlit team to prioritize t... | b617e07d0ee9bfe13a3d898f2a4dfb5ae8effb72 | {
"head_commit": "007fb8eff70ad9d371582c321b2a6c9135102288",
"head_commit_message": "Use testid",
"patch_to_review": "diff --git a/e2e/scripts/st_radio.py b/e2e/scripts/st_radio.py\nindex 586c292e5114..9d0edb0dc894 100644\n--- a/e2e/scripts/st_radio.py\n+++ b/e2e/scripts/st_radio.py\n@@ -35,7 +35,7 @@\n i2 = st.r... | [
{
"diff_hunk": "@@ -51,46 +53,89 @@\n @dataclass\n class RadioSerde(Generic[T]):\n options: Sequence[T]\n- index: int\n+ index: int | None\n+\n+ def serialize(self, v: object) -> int | None:\n+ if v is None:\n+ return None\n \n- def serialize(self, v: object) -> int:\n- ... | 5ab1b6fd8b21e97d475aeef9fb0d5f80076d9a99 | diff --git a/e2e_playwright/__snapshots__/linux/st_radio_test/st_radio-callback_help[dark_theme-chromium].png b/e2e_playwright/__snapshots__/linux/st_radio_test/st_radio-callback_help[dark_theme-chromium].png
new file mode 100644
index 000000000000..711e80ddd432
Binary files /dev/null and b/e2e_playwright/__snapshots__... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
sympy__sympy-12380@cf2e3da | sympy/sympy | Python | 12,380 | Runtime Warning changed to an error | <!-- Please give this pull request a descriptive title. Pull requests with descriptive titles are more likely to receive reviews. Describe what you changed! A title that only references an issue number is not descriptive. -->
<!-- If this pull request fixes an issue please indicate which issue by typing "Fixes #NNNN... | 2017-03-21T12:07:02Z | RuntimeWarning: divide by zero encountered in true_divide in lambdify tests
```
$./bin/test lambdify
==================================================================== test process starts =====================================================================
executable: /Users/aaronmeurer/anaconda3/bin/python ... | Hi I'm new here. Can I work on this? Seems like I should be able to figure this out if I dig around.. Any suggestions is appreciated
Hi,
I encountered neither an error nor an exception. If there is a real problem can you give me a reference to a file so that I can try to fix it. @asmeurer
![screenshot from 201... | [
{
"body": "```\n$./bin/test lambdify\n==================================================================== test process starts =====================================================================\nexecutable: /Users/aaronmeurer/anaconda3/bin/python (3.5.2-final-0) [CPython]\narchitecture: 64-bit... | 22e21ed0240d529aadfe5b4fa5ea5d61fd4ec565 | {
"head_commit": "cf2e3da63922d50d275929ead1e9fbf27f09ad5c",
"head_commit_message": "Runtime Warning changed to an error",
"patch_to_review": "diff --git a/sympy/utilities/tests/test_lambdify.py b/sympy/utilities/tests/test_lambdify.py\nindex 8749c667c587..91d8db7f4833 100644\n--- a/sympy/utilities/tests/test_lam... | [
{
"diff_hunk": "@@ -364,8 +364,11 @@ def test_numpy_old_matrix():\n def test_python_div_zero_issue_11306():\n if not numpy:\n skip(\"numpy not installed.\")\n- p = Piecewise((1 / x, y < -1), (x, y <= 1), (1 / x, True))\n- lambdify([x, y], p, modules='numpy')(0, 1)\n+ p = Piecewise((1 / x, y... | 8f7e4bcfd1f50d1137e686f06adf15b5b1035495 | diff --git a/sympy/utilities/tests/test_lambdify.py b/sympy/utilities/tests/test_lambdify.py
index 94133c6c3f7d..eaebc5d19ab0 100644
--- a/sympy/utilities/tests/test_lambdify.py
+++ b/sympy/utilities/tests/test_lambdify.py
@@ -364,8 +364,11 @@ def test_numpy_old_matrix():
def test_python_div_zero_issue_11306():
i... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-7265@585c373 | streamlit/streamlit | Python | 7,265 | Allow `None` as value for `st.date_input` | ## Describe your changes
This PR adds support for setting `None` as the value in `st.date_input`. Using `value=None` will render an empty date input that returns `None` as long as the user hasn't specified a date:
<img width="723" alt="image" src="https://github.com/streamlit/streamlit/assets/2852129/1cf90c9a-8ca... | 2023-09-01T13:35:13Z | Data Widgets to start with no initial value
Can all data widgets have no initial selected value?
1. Can a date widget have no default date value on first start / load? It is only after the user selects a date, can it contain a date value. To get around this I have to use a text_input widget instead, and add date val... | This seems related to #4645 (the idea of making widgets required so as to conclusively get a value from the user). Certainly the select-type widgets can do this (in effect), but other widgets don't have simple ways to accomplish this. For things like number input or color picker where the default choice might indeed be... | [
{
"body": "Can all data widgets have no initial selected value?\r\n\r\n1. Can a date widget have no default date value on first start / load? It is only after the user selects a date, can it contain a date value. To get around this I have to use a text_input widget instead, and add date validation logic to chec... | 7a3ba24da57dfbf713b857a78d5699e300f616a7 | {
"head_commit": "585c3731dbb0d0e13ef3e4491bdaf8913543da51",
"head_commit_message": "Merge remote-tracking branch 'remote/develop' into feature/allow-none-for-date-input",
"patch_to_review": "diff --git a/e2e_playwright/__snapshots__/linux/st_date_input_test/date_input-disabled_no_date[dark_theme-chromium].png b/... | [
{
"diff_hunk": "@@ -254,3 +265,28 @@ def test_invalid_date_format_values(self, format: str):\n with self.assertRaises(StreamlitAPIException) as ex:\n st.date_input(\"the label\", format=format)\n self.assertTrue(str(ex.exception).startswith(\"The provided format\"))\n+\n+\n+class Dat... | ddda88a421b8c43a97ba8df23cadb56a762d2969 | diff --git a/e2e_playwright/__snapshots__/linux/st_date_input_test/date_input-disabled_no_date[dark_theme-chromium].png b/e2e_playwright/__snapshots__/linux/st_date_input_test/date_input-disabled_no_date[dark_theme-chromium].png
new file mode 100644
index 000000000000..4a0aead2039f
Binary files /dev/null and b/e2e_play... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-7262@8cd45fd | streamlit/streamlit | Python | 7,262 | Allow `None` as value for `st.number_input` | ## Describe your changes
This PR supports setting `None` as the value in `st.number_input`. Using `value=None` will render an empty number input that returns `None` as long as the user hasn't specified a number:
<img width="599" alt="image" src="https://github.com/streamlit/streamlit/assets/2852129/5fca5660-4c3c-... | 2023-08-31T16:58:25Z | Number input does not accept None as value parameter
### Summary
It is not possible to set the value parameter of the number_input to None, even though it is listed in the API as possible and it works for all other input widgets.
### Steps to reproduce
```
import streamlit as st
input = st.number_input('Number... | Hi @ChristophBoerlin 👋🏼
Appreciate your submission, and for helping to make Streamlit better! I was able to confirm the conflict in behavior vs. our `st.number_input` documentation 😓
We will take a look at how we can incorporate this fix into our future development plans. Thanks again!
any update on this?
+1
Is... | [
{
"body": "### Summary\r\n\r\nIt is not possible to set the value parameter of the number_input to None, even though it is listed in the API as possible and it works for all other input widgets.\r\n\r\n### Steps to reproduce\r\n```\r\nimport streamlit as st\r\ninput = st.number_input('Number input', value = Non... | 45a9273a1fe642db7fc7750c82d393e5e3bf1e39 | {
"head_commit": "8cd45fdae3cafafe3ba64f29be5b6307390d253d",
"head_commit_message": "Update docstring",
"patch_to_review": "diff --git a/e2e_playwright/__snapshots__/linux/st_number_input_test/st_number_input-clearable_input[chromium].png b/e2e_playwright/__snapshots__/linux/st_number_input_test/st_number_input-c... | [
{
"diff_hunk": "@@ -72,6 +72,15 @@\n )\n \n \n+class DefaultValue:",
"line": null,
"original_line": 75,
"original_start_line": null,
"path": "lib/streamlit/runtime/state/widgets.py",
"start_line": null,
"text": "@user1:\nIf we make this a dataclass, we can simplify some `isinstance` chec... | b3c659ddbd7617703ec6e62a19c84952cac1b8b4 | diff --git a/e2e_playwright/__snapshots__/linux/st_number_input_test/st_number_input-clearable_input[chromium].png b/e2e_playwright/__snapshots__/linux/st_number_input_test/st_number_input-clearable_input[chromium].png
new file mode 100644
index 000000000000..3af0da83f8c3
Binary files /dev/null and b/e2e_playwright/__s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
zulip__zulip-29326@890303a | zulip/zulip | Python | 29,326 | push_notifs: Make push_notifications_enabled more resistant to flapping. | Fixes #28403
Uses redis to remember the last time push notifications were experienced working. This needs to work across processes, so can't be done just in memory.
| 2024-03-18T00:21:22Z | Make `push_notifications_enabled` more resistant to flapping
Edited to remove the part that we determined is not actually a bug.
~~The `maybe_mark_pushes_disabled` logic is asymmetric, in that it checks if push notifications appear to not be working on every request, but only consider marking them as disabled -- the... | Is the conclusion that this issue was opened in error because we already have that logic?
@timabbott I believe so. The other point raised here:
> It might also be nice to use some local state to avoid flapping with networking issues; if there have been both successful and unsuccessful requests to the push bouncer s... | [
{
"body": "Edited to remove the part that we determined is not actually a bug.\r\n\r\n~~The `maybe_mark_pushes_disabled` logic is asymmetric, in that it checks if push notifications appear to not be working on every request, but only consider marking them as disabled -- they will only be switched to enabled whe... | b71f4b9342db3247ee2db32c49dd3b4b5f70d603 | {
"head_commit": "890303a2d77e072fd4a66ac77e9d199f804b3277",
"head_commit_message": "rate_limiter: Extract KEY_PREFIX to redis_utils.",
"patch_to_review": "diff --git a/zerver/lib/rate_limiter.py b/zerver/lib/rate_limiter.py\nindex c086b1fe3e0a3..6381058a72385 100644\n--- a/zerver/lib/rate_limiter.py\n+++ b/zerve... | [
{
"diff_hunk": "@@ -245,6 +250,29 @@ def send_json_to_push_bouncer(\n )\n \n \n+PUSH_NOTIFICATIONS_RECENTLY_WORKING_REDIS_KEY = \"push_notifications_recently_working_ts\"\n+\n+\n+def record_push_notifications_recently_working() -> None:\n+ # Record the timestamp in redisp, marking that push notifications... | fdf1f5541d2bcfab541b244baebe98257399bcb5 | diff --git a/zerver/lib/push_notifications.py b/zerver/lib/push_notifications.py
index 85bf6cb06fa9f..52a66a98ac9d0 100644
--- a/zerver/lib/push_notifications.py
+++ b/zerver/lib/push_notifications.py
@@ -45,6 +45,7 @@
from zerver.lib.message import access_message, huddle_users
from zerver.lib.outgoing_http import Ou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
streamlit__streamlit-7050@d08729f | streamlit/streamlit | Python | 7,050 | Assorted visual tweaks | ## Describe your changes
This PR addresses a handful of visual tweaks, namely:
1. Makes library links blue, to make them consistent with the app interface (reported by @jrieke);
2. Fixes the small bottom padding after scrolling in the sidebar (reported by Andreas Braendhaugen);
3. Hides the `-` and `+` buttons fo... | 2023-07-20T18:01:56Z | Remove number_input -/+ step toggles option
Is there an option to remove the -/+ number_input step toggles? If not, I would suggest that for a future release. Thank you!
Also, is it possible to increase the precision?
Right now I am just using a text_input and type casting to float to get around this.
---
... | Hi @ajberlier ,
There's no option to remove the +/- toggles at the moment. I'll leave this issue open as a feature request!
You can use the `step` attribute to modify the precision of the toggles. If you just want to be able to enter floats in general, use a float as the initial value.
`st.number_input("numbe... | [
{
"body": "Is there an option to remove the -/+ number_input step toggles? If not, I would suggest that for a future release. Thank you! \r\n\r\nAlso, is it possible to increase the precision? \r\n\r\nRight now I am just using a text_input and type casting to float to get around this.\r\n\r\n---\r\n\r\nCommunit... | 56c1f3e0fb4be112c8c28f22720abdd4a29be23a | {
"head_commit": "d08729fc2456d1989260c56dacaf4e3fcb15de02",
"head_commit_message": "Add modal snapshots",
"patch_to_review": "diff --git a/e2e/scripts/st_number_input.py b/e2e/scripts/st_number_input.py\nindex c135fe48ed32..0aebaeb7dcfe 100644\n--- a/e2e/scripts/st_number_input.py\n+++ b/e2e/scripts/st_number_in... | [
{
"diff_hunk": "@@ -410,30 +410,32 @@ class NumberInput extends React.PureComponent<Props, State> {\n },\n }}\n />\n- <StyledInputControls>\n- <StyledInputControl\n- className=\"step-down\"\n- onClick={this.modifyValueUsingStep(\"... | c30d2b4f567657dcd8b526b9dcf6ce2c16716410 | diff --git a/e2e/scripts/st_number_input.py b/e2e/scripts/st_number_input.py
index c135fe48ed32..0aebaeb7dcfe 100644
--- a/e2e/scripts/st_number_input.py
+++ b/e2e/scripts/st_number_input.py
@@ -47,3 +47,9 @@ def on_change():
st.number_input("number input 9", key="number_input9", on_change=on_change)
st.write... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-6865@9ed8e67 | streamlit/streamlit | Python | 6,865 | Add chat component | ## Describe your changes
This PR adds two new commands optimized for a chat UI:
- `st.chat_message`: Displays a container styled like a chat message with a configurable avatar.
- `st.chat_input`: An input widget optimized for chat apps. E.g. it autogrows, sends the message on `enter`, clears the message after it i... | 2023-06-20T11:19:12Z | Chat component
Since ChatGPT or some other LLM modules are so popular recently, lot of users want to make a web app with conversational interface. Now if I want to make one with streamlit, I can use streamlit component st-chat and st.text_input. But the user experience is not as good as streamlit official components, s... | Yup we are discussing this at the moment! No concrete plan yet but stay tuned. We're all just as excited about GPT as you are 😉 | [
{
"body": "Since ChatGPT or some other LLM modules are so popular recently, lot of users want to make a web app with conversational interface. Now if I want to make one with streamlit, I can use streamlit component st-chat and st.text_input. But the user experience is not as good as streamlit official component... | fec6a7f1ab66328342512f2232bad39ac50f983a | {
"head_commit": "9ed8e67af06ad85ce18fb6ca669471a85b524f95",
"head_commit_message": "Fix reStructuredText formatting issues",
"patch_to_review": "diff --git a/e2e/scripts/st_chat_input.py b/e2e/scripts/st_chat_input.py\nnew file mode 100644\nindex 000000000000..b2411d648295\n--- /dev/null\n+++ b/e2e/scripts/st_ch... | [
{
"diff_hunk": "@@ -0,0 +1,326 @@\n+# Copyright (c) Streamlit Inc. (2018-2022) Snowflake Inc. (2022)\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.a... | ae457bcae5b577c96607231cb24add3a33eb841f | diff --git a/e2e/scripts/st_chat_input.py b/e2e/scripts/st_chat_input.py
new file mode 100644
index 000000000000..b2411d648295
--- /dev/null
+++ b/e2e/scripts/st_chat_input.py
@@ -0,0 +1,17 @@
+# Copyright (c) Streamlit Inc. (2018-2022) Snowflake Inc. (2022)
+#
+# Licensed under the Apache License, Version 2.0 (the "Li... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-5789@1c8465c | streamlit/streamlit | Python | 5,789 | Add the label_visibility parameter to st.metric | ## 📚 Context
Adds the `label_visibility` keyword-only parameter to `st.metric`, to be consistent with other elements that have the `label` parameter.
- What kind of change does this PR introduce?
- [x] Bugfix
- [x] Feature
- [ ] Refactoring
- [ ] Other, please describe:
## 🧠 Description of Chan... | 2022-11-30T02:05:06Z | `st.metric` should have `label_visibility` parameter
We had that in the original spec but probably forgot it during implementation. Let's fix it. Not super urgent but would be good to do soon so we don't forget.
---
Community voting on feature requests enables the Streamlit team to understand which features are ... | [
{
"body": "We had that in the original spec but probably forgot it during implementation. Let's fix it. Not super urgent but would be good to do soon so we don't forget. \r\n\r\n---\r\n\r\nCommunity voting on feature requests enables the Streamlit team to understand which features are most important to our user... | 0b28bfdf50a7da392b9e83a1131cfe8a5e07351a | {
"head_commit": "1c8465ccaf2574e417ec4a0da5dfc768e2e643a4",
"head_commit_message": "Add unit tests for st.metric label_visibility",
"patch_to_review": "diff --git a/frontend/src/components/elements/Metric/Metric.test.tsx b/frontend/src/components/elements/Metric/Metric.test.tsx\nindex 7c479bc2a4bf..8be6a20c4a5c ... | [
{
"diff_hunk": "@@ -16,20 +16,29 @@\n \n import styled from \"@emotion/styled\"\n import { StyledWidgetLabel } from \"src/components/widgets/BaseWidget/styled-components\"\n+import { LabelVisibilityOptions } from \"src/lib/utils\"\n \n-export const StyledTruncateText = styled.div(({ theme }) => ({\n- overflowW... | 1f4c3a590491d926724f9af0ec6f9eeb9cd7ee0e | diff --git a/e2e/scripts/st_metric.py b/e2e/scripts/st_metric.py
index 1f3689999887..f2caec9d5296 100644
--- a/e2e/scripts/st_metric.py
+++ b/e2e/scripts/st_metric.py
@@ -33,3 +33,11 @@
st.metric("Test 2", -4.56, 1.23, "inverse")
with col3:
st.slider("Pick another")
+
+
+with col1:
+ st.metric("Test 3", -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
streamlit__streamlit-7018@a5a50db | streamlit/streamlit | Python | 7,018 | Markdown support for radio button labels | ## Describe your changes
Allows markdown in the options of `st.radio` - the same ones as permitted in Radio's label, with the exception of links because it is a clickable element.
## GitHub Issue Link (if applicable)
Closes #6085
## Testing Plan
- FE/JS unit tests: Re-wrote both `Radio.test.tsx` files to to ... | 2023-07-14T23:42:10Z | Markdown support for radio buttons
### Problem
Colored text and other markdown elements work in the label of `st.radio` but not in the texts of the radio elements. This is a bit weird since we do support it in the texts of checkboxes (where the text next to the checkbox is the label).
### Solution
Allow mar... | [
{
"body": "### Problem\r\n\r\nColored text and other markdown elements work in the label of `st.radio` but not in the texts of the radio elements. This is a bit weird since we do support it in the texts of checkboxes (where the text next to the checkbox is the label). \r\n\r\n\r\n### Solution\r\n\r\nAllow markd... | 0ae6c716a2b6bc770568eb34b907deb5f1ff1e25 | {
"head_commit": "a5a50db3bd19b27518ffea1e447b5adee4a6b5c4",
"head_commit_message": "Add updated snaps",
"patch_to_review": "diff --git a/e2e/scripts/st_radio.py b/e2e/scripts/st_radio.py\nindex 2394c567ff76..0eb963c656aa 100644\n--- a/e2e/scripts/st_radio.py\n+++ b/e2e/scripts/st_radio.py\n@@ -19,6 +19,16 @@\n f... | [
{
"diff_hunk": "@@ -248,14 +248,13 @@ describe(\"StreamlitMarkdown\", () => {\n \n it(\"doesn't render links when isButton is true\", () => {\n // Valid markdown further restricted with buttons to eliminate links\n- const source = \"Link: [text](www.example.com)\"\n- const wrapper = render(\n+ co... | 294a83ed763c7a8f2ea7ebb05ec754efd0704a2a | diff --git a/e2e/scripts/st_radio.py b/e2e/scripts/st_radio.py
index 2394c567ff76..0eb963c656aa 100644
--- a/e2e/scripts/st_radio.py
+++ b/e2e/scripts/st_radio.py
@@ -19,6 +19,16 @@
from tests.streamlit import pyspark_mocks
options = ("female", "male")
+markdown_options = (
+ "**bold text**",
+ "*italics text... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
zulip__zulip-26294@a42972f | zulip/zulip | Python | 26,294 | compose: Allow URLs to be pasted onto selected text. | This PR enables URL-pasting onto selected compose text. The logic checks for the presence of a URL on the clipboard following a `"paste"` event, and equally for a text selection in the compose area. Absent either of those things, no action is taken. Otherwise, a Markdown string of the selected text is formatted using t... | 2023-07-19T15:47:21Z | Paste URL to create a named link
At present, highlighting text in the compose box and pasting a URL replaces the text with that URL.
Instead, when a user highlights text in the compose and pastes a URL, it should turn the highlighted text into a named link to that URL.
It's a really nice UX for making links, whic... | Hello @zulip/server-compose members, this issue was labeled with the "area: compose" label, so you may want to check it out!
<!-- areaLabelAddition -->
I really like this idea actually. This is a very helpful feature of dropbox.
@zulipbot claim
Reopened by #19180.
**ERROR:** This active issue has no assignee.
**ERROR... | [
{
"body": "At present, highlighting text in the compose box and pasting a URL replaces the text with that URL.\r\n\r\nInstead, when a user highlights text in the compose and pastes a URL, it should turn the highlighted text into a named link to that URL.\r\n\r\nIt's a really nice UX for making links, which you ... | ca40e60469d0ac7d7eac3fdeecbd4023d0b27dd2 | {
"head_commit": "a42972f0cbd53c3b2bfb38193d8cb05c7527e764",
"head_commit_message": "copy_paste: Strip back tests to only test handler.\n\nThis gets us out of the brittle business of trying to mock a\ncomplex event like \"paste\"--which mocking basically means we\nare testing against the mock more than a real event... | [
{
"diff_hunk": "@@ -341,7 +341,28 @@ export function paste_handler(event) {\n }\n \n if (clipboardData.getData) {\n+ const $textarea = $(event.currentTarget);\n+ const paste_text = clipboardData.getData(\"text\");\n const paste_html = clipboardData.getData(\"text/html\");\n+ ... | 3507c6d07153ba5dc107c6f3a3aca4ee209ff051 | diff --git a/package.json b/package.json
index 103ba0eadceb6..b56b4899d01ab 100644
--- a/package.json
+++ b/package.json
@@ -44,6 +44,7 @@
"handlebars-loader": "^1.7.1",
"html-webpack-plugin": "^5.3.2",
"intl-messageformat": "^10.3.0",
+ "is-url": "^1.2.4",
"jquery": "^3.6.3",
"jquery-caret-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
zulip__zulip-26231@4162342 | zulip/zulip | Python | 26,231 | integrations: Add support for "Test plugin" in Sentry integration. | If a user tries to create a webhook using the Webhooks plugin in Sentry and uses the "Test plugin" to test the webhook, the server would send a 500 error, even though the integration worked perfectly. This led users to believe that the integration was not working.
This PR fixes that behaviour and makes sure the sam... | 2023-07-10T20:46:37Z | Sentry integration "Test Plugin" failure
Hello, I'm setting up Sentry.io integration and got this error when I tried "Test Plugin" (meaning "Test Outgoing Webhook to Zulip"); I'm assuming it's the response payload that came back from Zulip Cloud:
>"There was an internal error with the Plugin, {\"result\":\"error\",\... | @zulipbot add "area: integrations"
Hello @zulip/server-integrations members, this issue was labeled with the "area: integrations" label, so you may want to check it out!
<!-- areaLabelAddition -->
@aryairani Thanks for reporting this issue.
This issue was recently fixed in 16563a321. I tried to reproduce this by ... | [
{
"body": "Hello, I'm setting up Sentry.io integration and got this error when I tried \"Test Plugin\" (meaning \"Test Outgoing Webhook to Zulip\"); I'm assuming it's the response payload that came back from Zulip Cloud:\r\n\r\n>\"There was an internal error with the Plugin, {\\\"result\\\":\\\"error\\\",\\\"ms... | 88b200c298d66fcb8a9e437d4670e568c10d9032 | {
"head_commit": "416234269ad8de403384dffabe436e0cde059771",
"head_commit_message": "integrations: Add Raven SDK test to Sentry Integration.",
"patch_to_review": "diff --git a/zerver/webhooks/sentry/fixtures/raven_sdk_python_event.json b/zerver/webhooks/sentry/fixtures/raven_sdk_python_event.json\nnew file mode 1... | [
{
"diff_hunk": "@@ -81,6 +81,20 @@\n }\n \n \n+def is_sample_event(event: Dict[str, Any]) -> bool:\n+ # These are just some workarounds; there is no documented way to check\n+ # if an event is a sample event or not.\n+ tags = event.get(\"tags\", [])\n+ if [\"sample_event\", \"yes\"] in tags:\n+ ... | 3ac624404f83ec02a0904593f6b576ea395778f2 | diff --git a/zerver/webhooks/sentry/fixtures/raven_sdk_python_event.json b/zerver/webhooks/sentry/fixtures/raven_sdk_python_event.json
new file mode 100644
index 0000000000000..d267f1561569f
--- /dev/null
+++ b/zerver/webhooks/sentry/fixtures/raven_sdk_python_event.json
@@ -0,0 +1,134 @@
+{
+ "id": "4311163364",
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
zulip__zulip-25738@4b7a8be | zulip/zulip | Python | 25,738 | compose_validate: Use correct stream_id value for different context. | This PR addresses the issue of relying on `compose_state` for retrieving the `stream_id` to display warning banners. Previously, when the compose box was closed, the warnings were not shown in the message edit box. Now, we utilize the `get_stream_id_for_textarea` function to obtain the correct `stream_id` value and res... | 2023-05-24T12:48:58Z | Edit message UI should use correct context for warnings
When composing a message, we give warnings for some potentially problematic situations:
1. Mentioning a private stream to an audience where not everyone is subscribed to it.
2. Mentioning a user who is not subscribed to the stream being composed to.
These w... | Hello @zulip/server-message-view members, this issue was labeled with the "area: message-editing" label, so you may want to check it out!
<!-- areaLabelAddition -->
@shameondev Could you please add a this to your todo list, to pick up when you free up if nobody else fixes it in the meantime? It's not a release goal, ... | [
{
"body": "When composing a message, we give warnings for some potentially problematic situations:\r\n\r\n1. Mentioning a private stream to an audience where not everyone is subscribed to it.\r\n2. Mentioning a user who is not subscribed to the stream being composed to.\r\n\r\nThese warning are not triggered co... | 1beebb9fa101715a8949e74e7147da1fc1a1f663 | {
"head_commit": "4b7a8bec17d1e997cc1f1523aeecf5c06aa4c591",
"head_commit_message": "compose_validate: Extract the logic of getting stream_id.",
"patch_to_review": "diff --git a/web/src/compose_validate.js b/web/src/compose_validate.js\nindex b7f72d16d0f98..7b7eb3717f85a 100644\n--- a/web/src/compose_validate.js\... | [
{
"diff_hunk": "@@ -59,7 +59,16 @@ export function needs_subscribe_warning(user_id, stream_id) {\n return true;\n }\n \n-function get_stream_id() {\n+function get_stream_id_for_textarea($textarea) {\n+ const is_in_editing_area = $textarea.closest(\".message_row\").length > 0;\n+\n+ if (is_in_editing_a... | acb4cd3ad61ff75c3739801006089a55bbac1dc6 | diff --git a/web/src/compose_validate.js b/web/src/compose_validate.js
index b7f72d16d0f98..e779733693a1d 100644
--- a/web/src/compose_validate.js
+++ b/web/src/compose_validate.js
@@ -59,19 +59,49 @@ export function needs_subscribe_warning(user_id, stream_id) {
return true;
}
-export function warn_if_private_s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-5116@71dc54b | streamlit/streamlit | Python | 5,116 | Fix tabs switching couse scrolling up | <!--
Before contributing (PLEASE READ!)
⚠️ If your contribution is more than a few lines of code, then prior to starting to code on it please post in the issue saying you want to volunteer, then wait for a positive response. And if there is no issue for it yet, create it first.
This helps make sure:
1. Two ... | 2022-08-09T11:31:39Z | tabs switching cause scrolling up
### Summary
app scrolls up when I have tabs after some widgets and switch them
### Steps to reproduce
Code snippet:
```
import streamlit as st
for i in range(20):
st.markdown("dummy text")
tab1, tab2 = st.tabs(["tab1", "tab2"])
with tab1:
st.video(vi... | @RRaphaell Thanks for reporting this issue! I was able to reproduce it and have deployed a demo app [here](https://lukasmasuch-st-playground-issuesgh-5069app-tmwuwl.streamlitapp.com/). The underlying issue is that when changing tabs, the height of the actual tab content is not correct for a split second. This influence... | [
{
"body": "### Summary\r\n\r\napp scrolls up when I have tabs after some widgets and switch them\r\n\r\n\r\n### Steps to reproduce\r\n\r\nCode snippet:\r\n\r\n```\r\nimport streamlit as st\r\n\r\nfor i in range(20):\r\n st.markdown(\"dummy text\")\r\n\r\n\r\ntab1, tab2 = st.tabs([\"tab1\", \"tab2\"])\r\n\r\n... | eb72f758957ec1f0e401e2884649ff46f15a1ae8 | {
"head_commit": "71dc54b84a7ce7ddb3a49f51f98f23e5eef78e5f",
"head_commit_message": "update E2E Cypress st_tabs.spec.js to march renderAll property",
"patch_to_review": "diff --git a/e2e/specs/st_tabs.spec.js b/e2e/specs/st_tabs.spec.js\nindex f747a79513fa..24a444e9804a 100644\n--- a/e2e/specs/st_tabs.spec.js\n++... | [
{
"diff_hunk": "@@ -36,11 +36,18 @@ describe(\"st.tabs\", () => {\n 2\n );\n \n- cy.get(\"[data-testid='stSidebar'] .stTabs\")\n+ cy.get(\"[data-testid='stSidebar'] .stTabs .st-cx\")",
"line": null,
"original_line": 39,
"original_start_line": null,
"path": "e2e/specs/st_tabs.spec... | 21213c32f3b78824c683a82abd0e0fc190456b44 | diff --git a/e2e/specs/st_tabs.spec.js b/e2e/specs/st_tabs.spec.js
index f747a79513fa..0b09fce04ed5 100644
--- a/e2e/specs/st_tabs.spec.js
+++ b/e2e/specs/st_tabs.spec.js
@@ -36,10 +36,16 @@ describe("st.tabs", () => {
2
);
+ cy.get("[data-testid='stSidebar'] .stTabs").first()
+ .within(() => {
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
zulip__zulip-25154@0de167b | zulip/zulip | Python | 25,154 | message-type: Add support for "direct" as value for `type` parameter. | For endpoints with a `type` parameter to indicate whether the message is a stream or direct message, [`POST /typing`](https://zulip.com/api/set-typing-status) and [`POST /messages`](https://zulip.com/api/send-message), adds support for passing `"direct"` as a value for direct messages.
Maintains support for `"priva... | 2023-04-17T16:26:43Z | Add API support for using "direct" as the message "type" for private messages
Since we renamed "private messages" to "direct messages" in the UI, we should start thinking about API changes in line with this change. This issue is for the simplest one, which I think should be a Zulip 7.0 release goal: Allowing `send_mess... | Hello @zulip/server-api members, this issue was labeled with the "area: api" label, so you may want to check it out!
<!-- areaLabelAddition -->
@timabbott - Yeah, assigning to me makes sense. I already noted this down as a follow-up in the work I'm doing on #24806.
@laurynmm We noticed that you have not made any upda... | [
{
"body": "Since we renamed \"private messages\" to \"direct messages\" in the UI, we should start thinking about API changes in line with this change. This issue is for the simplest one, which I think should be a Zulip 7.0 release goal: Allowing `send_message` (and similar things like typing notifications requ... | 3ad5e7dfc0f081d4cc7ebecb814c5102d359559f | {
"head_commit": "0de167b5b44bb542a8f868a54f4f789b2a7620ae",
"head_commit_message": "message: Use `recipient_type_name` for API message type references.\n\nRefactors instances of `message_type_name` and `message_type`\nthat are referring to API message type value (\"stream\" or\n\"private\") to use `recipient_type_... | [
{
"diff_hunk": "@@ -210,12 +210,14 @@ def send_message_backend(\n tz_guess: Optional[str] = REQ(\"tz_guess\", default=None, documentation_pending=True),\n time: Optional[float] = REQ(default=None, converter=to_float, documentation_pending=True),\n ) -> HttpResponse:\n+ recipient_type_name = message_t... | 2f3532bc146e003a36464b286d9222344db15eeb | diff --git a/api_docs/changelog.md b/api_docs/changelog.md
index 5fdf340a3521f..0ab9db84dfb2b 100644
--- a/api_docs/changelog.md
+++ b/api_docs/changelog.md
@@ -20,6 +20,15 @@ format used by the Zulip server that they are interacting with.
## Changes in Zulip 7.0
+**Feature level 174**:
+
+* [`POST /typing`](/api/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
zulip__zulip-25349@67de2a4 | zulip/zulip | Python | 25,349 | schedule: Remove 'Schedule' state of compose box. | Fixes #25340
This means that we now schedule the message simply after selecting time if the message is valid.
Also, editing scheduled messages will now delete the scheduled message and open compose with scheduled message.
TODO:
- [x] Note that the user can always drop an accidentally scheduled message from th... | 2023-04-30T13:05:01Z | Simplify message scheduling flow
In the current scheduled message implementation, we have a somewhat awkward state of a time having been picked without a message being scheduled.
To simplify the experience, we should make selecting a time immediately schedule the message. As a result, we can:
- Remove the "Cance... | Hello @zulip/server-compose members, this issue was labeled with the "area: compose" label, so you may want to check it out!
<!-- areaLabelAddition -->
@zulipbot claim
Hello @akarsh-jain-790!
Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim... | [
{
"body": "In the current scheduled message implementation, we have a somewhat awkward state of a time having been picked without a message being scheduled. \r\n\r\nTo simplify the experience, we should make selecting a time immediately schedule the message. As a result, we can:\r\n\r\n- Remove the \"Cancel sch... | 7425079814d674672b5e1208f0742f800ba470c7 | {
"head_commit": "67de2a416521a98ac6b40ff448803d07d3c800d1",
"head_commit_message": "scheduled_messages_overlay_ui: Use CSS to display no scheduled messages.",
"patch_to_review": "diff --git a/web/src/compose.js b/web/src/compose.js\nindex 577ce1e58307d..55685f1126210 100644\n--- a/web/src/compose.js\n+++ b/web/s... | [
{
"diff_hunk": "@@ -8,28 +8,62 @@ import * as compose_ui from \"./compose_ui\";\n import {$t} from \"./i18n\";\n import * as narrow from \"./narrow\";\n import * as notifications from \"./notifications\";\n-import * as overlays from \"./overlays\";\n+import {page_params} from \"./page_params\";\n import * as pe... | 102c68c211d3e565deff4bb04015234df7f062c6 | diff --git a/web/src/compose.js b/web/src/compose.js
index 577ce1e58307d..434cb470dfe0d 100644
--- a/web/src/compose.js
+++ b/web/src/compose.js
@@ -188,7 +188,7 @@ export function clear_compose_box() {
compose_banner.clear_errors();
compose_banner.clear_warnings();
compose_ui.hide_compose_spinner();
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-4204@4ad7909 | streamlit/streamlit | Python | 4,204 | Fix issue with hidden balloons (approach 2) | ## 📚 Context
The [`Block.tsx` refactoring](https://github.com/streamlit/streamlit/pull/4053) applies a `display: none` to the element containers of `empty` and `balloons` elements. The reason is to prevent the `gap` of the parent flexbox. However, the `balloon` element is never shown on the frontend due to `display... | 2021-12-21T21:55:01Z | st.balloons() is not working in streamlit 1.3.0
### Summary
st.balloons() was working in 1.2.0 version, but not in 1.3.0.
(The st.success text is executing all right on both versions)
Code snippet:
```
with st.spinner("Analyzing..."):
pass
st.success("Done!")
st.balloons()
```
### Is this a regr... | Thanks for reporting this @RohanKaran!
This is known, and we have two proposed fixes out (#4199 and #4204) and are deciding between the two. We'll have a fix out ASAP. | [
{
"body": "### Summary\r\n\r\nst.balloons() was working in 1.2.0 version, but not in 1.3.0.\r\n(The st.success text is executing all right on both versions)\r\n\r\nCode snippet:\r\n\r\n```\r\nwith st.spinner(\"Analyzing...\"):\r\n pass\r\nst.success(\"Done!\")\r\nst.balloons()\r\n```\r\n### Is this a reg... | 435e110d457c06e6810793a3a7e0e3822042ac42 | {
"head_commit": "4ad79094fd0a30e959d9b2318e79fca4fba61b6a",
"head_commit_message": "Pin mypy to older version",
"patch_to_review": "diff --git a/e2e/scripts/st_balloons.py b/e2e/scripts/st_balloons.py\nnew file mode 100644\nindex 000000000000..32af104a16e8\n--- /dev/null\n+++ b/e2e/scripts/st_balloons.py\n@@ -0,... | [
{
"diff_hunk": "@@ -9,7 +9,7 @@ black = \"==21.6b0\"\n boto3 = \"*\"\n botocore = \">=1.13.44\"\n hypothesis = \">=6.17.4\"\n-mypy = \">=0.910\"\n+mypy = \">=0.910, <0.930\"",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": "lib/Pipfile",
"start_line": null,
"text... | f4630a9902c0824e548ba51c6cd392191cb2e71f | diff --git a/e2e/scripts/st_balloons.py b/e2e/scripts/st_balloons.py
new file mode 100644
index 000000000000..32af104a16e8
--- /dev/null
+++ b/e2e/scripts/st_balloons.py
@@ -0,0 +1,17 @@
+# Copyright 2018-2021 Streamlit Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-4358@83d68a3 | streamlit/streamlit | Python | 4,358 | Fix timezone handling with slider | ## 📚 Context
If a slider is used with a `time`/`datetime` value, it will be converted to a UTC timestamp in microseconds. The frontend itself is not aware of the actual timezone used in the backend. Thereby, it currently does some timezone conversations that results in diverging information between the value shown ... | 2022-02-01T23:07:44Z | Datetime slider showing incorrect values on the browser
### Summary
When I run my streamlit app at my localhost and the cloud, I see different st.slider time range values. To be precise the range values printed on the browser seem to be shifted. I suspect this shift is due to some time zone change.
### Code snipp... | Hey @tdincer ! Thanks for the report! We have had a couple people mention our support for timezones is lacking. I have grouped this in with other issues. Most similar is #1346. We're going to get this in front of our product team to see how we can best integrate this with our future plans. | [
{
"body": "### Summary\r\n\r\nWhen I run my streamlit app at my localhost and the cloud, I see different st.slider time range values. To be precise the range values printed on the browser seem to be shifted. I suspect this shift is due to some time zone change.\r\n\r\n### Code snippet:\r\n\r\n```\r\nfrom dateti... | fc0f126375344e3a1560745ab540bedf38940f81 | {
"head_commit": "83d68a3792e53aa3f498ce1a8c7ff135042786b4",
"head_commit_message": "Update micros values in tests",
"patch_to_review": "diff --git a/frontend/src/components/widgets/Slider/Slider.tsx b/frontend/src/components/widgets/Slider/Slider.tsx\nindex 89e4007b0e88..bfe0d223c44a 100644\n--- a/frontend/src/c... | [
{
"diff_hunk": "@@ -418,8 +421,9 @@ def _datetime_to_micros(dt):\n \n def _micros_to_datetime(micros):\n utc_dt = UTC_EPOCH + timedelta(microseconds=micros)\n- # Convert from utc back to original time (local time if naive)\n- return utc_dt.astimezone(ori... | a99126dd4bdd90ad6af3dafcad4a86fc97d6bc79 | diff --git a/frontend/src/components/widgets/Slider/Slider.tsx b/frontend/src/components/widgets/Slider/Slider.tsx
index 89e4007b0e88..bfe0d223c44a 100644
--- a/frontend/src/components/widgets/Slider/Slider.tsx
+++ b/frontend/src/components/widgets/Slider/Slider.tsx
@@ -185,7 +185,10 @@ class Slider extends React.PureC... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-3639@f3eec3c | streamlit/streamlit | Python | 3,639 | 3638/add check script endpoint | **Issue:** https://github.com/streamlit/streamlit/issues/3638
**Description:**
- add endpoint to verify if the script compiles and runs correctly
- add config option to customise the above endpoint
---
**Contribution License Agreement**
By submitting this pull request you agree that all contributions to ... | 2021-08-02T13:49:02Z | Health endpoint for checking that a script compiles and runs correctly
### Problem
Currently there is no way to detect that the streamlit app is actually not running - if there is an error inside the client script (e.g. missing dependency, script error) the application still starts and the /healthz endpoint returns ... | [
{
"body": "### Problem\r\n\r\nCurrently there is no way to detect that the streamlit app is actually not running - if there is an error inside the client script (e.g. missing dependency, script error) the application still starts and the /healthz endpoint returns success. \r\n\r\nS4T requires better app monitor... | 188568206a95992b62272d8a5813b8c601dd5bf8 | {
"head_commit": "f3eec3cd58d1b1cbcf6a2efa42f9ae7b299cf93c",
"head_commit_message": "fix return type",
"patch_to_review": "diff --git a/lib/streamlit/config.py b/lib/streamlit/config.py\nindex e66d0a8bd3db..18df80f236f7 100644\n--- a/lib/streamlit/config.py\n+++ b/lib/streamlit/config.py\n@@ -589,6 +589,17 @@ def... | [
{
"diff_hunk": "@@ -396,8 +406,38 @@ def _set_state(self, new_state):\n self._state = new_state\n \n @property\n- def is_ready_for_browser_connection(self):\n- return self._state not in (State.INITIAL, State.STOPPING, State.STOPPED)\n+ def is_ready_for_browser_connection(self) -> Tuple[... | fbe6566f37c39d73e732bcf565a2872dec32a143 | diff --git a/lib/streamlit/config.py b/lib/streamlit/config.py
index e66d0a8bd3db..750b5d52937e 100644
--- a/lib/streamlit/config.py
+++ b/lib/streamlit/config.py
@@ -589,6 +589,21 @@ def _server_port() -> int:
return 8501
+_create_option(
+ "server.scriptHealthCheckEnabled",
+ visibility="hidden",
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
streamlit__streamlit-3550@eaf6981 | streamlit/streamlit | Python | 3,550 | Allow set_page_config after callbacks | fixes #3410
We only allow set_page_config to be called once per script run, and we do not allow any other st calls to execute prior to it. Callbacks changed things, and st calls are now allowed to run before set_page_config.
This change ensures the following:
- callbacks can call st commands without throwing an... | 2021-07-14T18:42:08Z | StreamlitAPIException : set_page_config() can only be called once per app, and must be called as the first Streamlit command in your script.
I am facing this issue when trying to set page config in a multi-page app. However, I have an idea of setting the default layout to wide which will solve my issue but how to do so... | I was facing a similar issue,
Below solved the issue is my case:
in your `main.py` file, add the page config to the state object.
```python
import streamlit as st
from SessionState import _get_state
state = _get_state()
state.page_config = st.set_page_config(
page_title="BPJV SI Database Manage... | [
{
"body": "I am facing this issue when trying to set page config in a multi-page app. However, I have an idea of setting the default layout to wide which will solve my issue but how to do so?\r\n",
"number": 3410,
"title": "StreamlitAPIException : set_page_config() can only be called once per app, and m... | b817390cda935f5e3c0410c3c842fd6db764b939 | {
"head_commit": "eaf6981118b8bb485e7d1dbfe3e8515326494792",
"head_commit_message": "combine conditions",
"patch_to_review": "diff --git a/e2e/scripts/st_set_page_config.py b/e2e/scripts/st_set_page_config.py\nindex e7c992df9681..c08122f76c9a 100644\n--- a/e2e/scripts/st_set_page_config.py\n+++ b/e2e/scripts/st_s... | [
{
"diff_hunk": "@@ -63,6 +66,30 @@ def test_set_page_config_first(self):\n with self.assertRaises(StreamlitAPIException):\n ctx.enqueue(msg)\n \n+ def test_disallow_set_page_config_twice(self):\n+ \"\"\"st.set_page_config must be called before other st commands",
"line": null,
... | 04d7806e55aede5f39a38eb2faad3abb9214f055 | diff --git a/e2e/scripts/st_set_page_config.py b/e2e/scripts/st_set_page_config.py
index e7c992df9681..c08122f76c9a 100644
--- a/e2e/scripts/st_set_page_config.py
+++ b/e2e/scripts/st_set_page_config.py
@@ -22,3 +22,41 @@
)
st.sidebar.button("Sidebar!")
st.markdown("Main!")
+
+
+def show_balloons():
+ st.balloons... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-2317@69bfab7 | streamlit/streamlit | Python | 2,317 | Send initialization data in the NewReport message | Removes `ForwardMsg.initialize`. All initialization data is now carried in every `ForwardMsg.new_report` message.
This lets us remove the state from the server that stores whether a given client has already received the initialize message. This flag had a race condition - it was possible for the flag to be set to tr... | 2020-11-04T23:31:38Z | Script rerun event can cause `SessionInfo not initialized` error on the frontend
If a script is rerun very quickly after being started, it's possible to trigger an error on the frontend ("Tried to use SessionInfo before it was initialized").
An easy repro is our `streamlit run e2e/scripts/st_experimental_rerun.py` t... | I don't know if we can send two Initialize messages in a row. I think a lot of our code expects Initialize to only be sent once per session. But if we can change this, that would be great!
Another option: don't set the boolean `self._sent_initialize_message = True` until the message is _actually_ sent. But this woul... | [
{
"body": "If a script is rerun very quickly after being started, it's possible to trigger an error on the frontend (\"Tried to use SessionInfo before it was initialized\").\r\n\r\nAn easy repro is our `streamlit run e2e/scripts/st_experimental_rerun.py` test script.\r\n\r\nIt _seems like_ what is happening is:... | 4996fe9f496288995337a3315d5869e2e7e7cb90 | {
"head_commit": "69bfab700cba8acc0ca34b1bb5e0860dbded1ac7",
"head_commit_message": "Don't error if SessionInfo data changes\n\nThis is totally legit - it happens when the Streamlit server is killed and restarted, and the client reconnects.\n\nTest SessionInfo.fromInitializeMessage",
"patch_to_review": "diff --gi... | [
{
"diff_hunk": "@@ -14,6 +14,12 @@\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n+import {\n+ Config,\n+ EnvironmentInfo,\n+ Initialize,\n+ UserInfo,\n+} from \"../autogen/proto\"",
"line": null,
"original_line": 22,
"original... | 26228d02ffcfbd1531b310bf8e6974a10e40048a | diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx
index b2c55495dd53..c00f1a25d012 100644
--- a/frontend/src/App.test.tsx
+++ b/frontend/src/App.test.tsx
@@ -17,7 +17,7 @@
import React from "react"
import { shallow, mount, ReactWrapper } from "enzyme"
-import { ForwardMsg } from "autogen/proto"
+im... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
zulip__zulip-22988@5929b81 | zulip/zulip | Python | 22,988 | delete_in_topic: Split up the deletion into batches. | Fixes https://github.com/zulip/zulip/issues/22821.
As explained in the comment in the code:
Topics can be large enough that this request will inevitably time out.
In such a case, it's good for some progress to be accomplished, so that
full deletion can be achieved by repeating the request. For that purpose,
we... | 2022-09-17T21:13:09Z | Unable to delete a topic
Hi! I'm attemptimg to delete a large (over 50k messages) topic that contains alerts and logs quotations sent by elastalert. When deleting it from the web gui, the delete request gets stuck for about a minute and then i get 502 with no any entry in zulip logs. Messages from other topics and enti... | Hello @zulip/server-message-view members, this issue was labeled with the "area: message-editing" label, so you may want to check it out!
<!-- areaLabelAddition -->
Yikes, 50k messages is a topic is a lot of log spam. You can likely delete it using `do_delete_messages` via a management command shell (https://zulip.re... | [
{
"body": "Hi! I'm attemptimg to delete a large (over 50k messages) topic that contains alerts and logs quotations sent by elastalert. When deleting it from the web gui, the delete request gets stuck for about a minute and then i get 502 with no any entry in zulip logs. Messages from other topics and entire top... | 09c6ee6468e302b5c9d09fb40e6955c1d928e408 | {
"head_commit": "5929b8156dbe0cb8558565d34fdb7160056413cd",
"head_commit_message": "delete_in_topic: Split up the deletion into batches.\n\nFixes #22821.\n\nAs explained in the comment in the code:\n\nTopics can be large enough that this request will inevitably time out.\nIn such a case, it's good for some progres... | [
{
"diff_hunk": "@@ -1139,6 +1139,20 @@ export function delete_topic(stream_id, topic_name) {\n data: {\n topic_name,\n },\n+ success() {},\n+ error(xhr) {\n+ if (xhr.status === 502) {\n+ /* When trying to delete a very large topic, it's\n+ ... | 10dbe6fcd851fde01fbbdccd8967bd15cd940da9 | diff --git a/static/js/message_edit.js b/static/js/message_edit.js
index e7be7edce6433..871ca38ed38b4 100644
--- a/static/js/message_edit.js
+++ b/static/js/message_edit.js
@@ -1133,12 +1133,31 @@ export function delete_message(msg_id) {
});
}
-export function delete_topic(stream_id, topic_name) {
+export funct... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-2060@f5d153f | streamlit/streamlit | Python | 2,060 | Adding experimental_rerun | **Issue:**
Fixes https://github.com/streamlit/streamlit/issues/653
**Description:**
Added `st.experimental_rerun` and `st.experimental_get_session_id`. Given that rerun needed access to the server I chose to make the relevant test be within the e2e testing suite. This e2e test undergoes a few reruns within a ... | 2020-09-29T13:00:50Z | Add the ability to programatically re-run the streamlit script
### Problem
I am building a small labeling too where I read in an example, the user will select labels from a list of check boxes and click submit in order to save the labels, when they submit a field in the data for it being labeled is added so in the n... | Hey @blester125
We've been thinking a lot about different ways to solve issues like yours recently. We have a few really nice and clean solutions in mind but they will take a little time to implement.
In the meantime, if I understand your app correctly, I think what you need can be implemented by persisting some... | [
{
"body": "### Problem\r\n\r\nI am building a small labeling too where I read in an example, the user will select labels from a list of check boxes and click submit in order to save the labels, when they submit a field in the data for it being labeled is added so in the next read it skips that example. The prob... | 8b8d031f7574740ee596a32a91bba6d7e925ab94 | {
"head_commit": "f5d153f667e72f325b0551fa55c3701f75ba5c79",
"head_commit_message": "ignore rerun within integration tests",
"patch_to_review": "diff --git a/e2e/scripts/st_experimental_rerun.py b/e2e/scripts/st_experimental_rerun.py\nnew file mode 100644\nindex 000000000000..baf2719c10aa\n--- /dev/null\n+++ b/e2... | [
{
"diff_hunk": "@@ -0,0 +1,31 @@\n+/**\n+ * @license\n+ * Copyright 2018-2020 Streamlit Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apac... | 998fcfd982c0e9bb05503863a07158d50b9f24e8 | diff --git a/e2e/scripts/st_experimental_rerun.py b/e2e/scripts/st_experimental_rerun.py
new file mode 100644
index 000000000000..baf2719c10aa
--- /dev/null
+++ b/e2e/scripts/st_experimental_rerun.py
@@ -0,0 +1,30 @@
+# Copyright 2018-2020 Streamlit Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "Licens... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
zulip__zulip-22583@37ae377 | zulip/zulip | Python | 22,583 | unread: Indicate which streams and topics have unread @-mentions. | <!-- Describe your pull request here.-->
Fixes: #21637
<!-- If the PR makes UI changes, always include one or more still screenshots to demonstrate your changes. If it seems helpful, add a screen capture of the new functionality as well.
Tooling tips: https://zulip.readthedocs.io/en/latest/tutorials/screensho... | 2022-07-25T16:04:47Z | Indicate which streams and topics have unread @-mentions
When looking at streams and topics in the left sidebar, it would be helpful to know which ones have unread messages where the user has been @-mentioned. To address this, we should display an `@` to the left of the unread message count when there is at least one u... | Hello @zulip/server-sidebars members, this issue was labeled with the "area: left-sidebar" label, so you may want to check it out!
<!-- areaLabelAddition -->
@zulipbot claim
Hello @AnushaNathRoy, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over ... | [
{
"body": "When looking at streams and topics in the left sidebar, it would be helpful to know which ones have unread messages where the user has been @-mentioned. To address this, we should display an `@` to the left of the unread message count when there is at least one unread message with an @-mention in the... | 69685c2864428e40d0f1ddab49058f70e86bfb8c | {
"head_commit": "37ae377b954c207ebf8bc5ba53f648ada9e308c1",
"head_commit_message": "bucketer: Store bucket_keys in reverse_lookup maps.\n\nThis makes it possible to fetch the bucket_key, not just the bucket\nitself, given an item_id.",
"patch_to_review": "diff --git a/static/js/unread.js b/static/js/unread.js\ni... | [
{
"diff_hunk": "@@ -563,6 +563,11 @@ div.overlay {\n color: hsl(0, 0%, 100%);\n }\n \n+.unread_mention_info:not(:empty) {",
"line": 566,
"original_line": 566,
"original_start_line": null,
"path": "static/styles/app_components.css",
"start_line": null,
"text": "@user1:\nI think a 2px ... | 71204abb5dbc43b96895194cc61e16115ed57de7 | diff --git a/frontend_tests/node_tests/stream_list.js b/frontend_tests/node_tests/stream_list.js
index b33b83baaacc9..905d4e4142605 100644
--- a/frontend_tests/node_tests/stream_list.js
+++ b/frontend_tests/node_tests/stream_list.js
@@ -14,7 +14,7 @@ page_params.realm_users = [];
// We use this with override.
let n... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-1423@305f351 | streamlit/streamlit | Python | 1,423 | TextArea and TextInput max_chars | **Issue:** This PR fixes #613
**Description:** Adding max_chars arg to text area and text input
---
**Contribution License Agreement**
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
| 2020-05-06T18:40:14Z | Specify max number of characters in text area
### Problem
Right now, there is no limit to specify number of characters in text area. This is very risky and an overkill if users use it to process too large textual data.
### Solution
It would be great to give users the option to specify the max number of charact... | How about a `max_chars` kwarg? Default `==None` meaning infinite.
I think this should be fine. I hope the documentation will be updated accordingly once this is implemented.
Thanks a million @treuille for creating such an amazing framework.
Sorry to bother you guys. Any progress on this one? I am trying to make a... | [
{
"body": "### Problem\r\n\r\nRight now, there is no limit to specify number of characters in text area. This is very risky and an overkill if users use it to process too large textual data.\r\n\r\n### Solution\r\n\r\nIt would be great to give users the option to specify the max number of characters allowed in ... | 97e57f45738174a69ea14649a1355a2c1939478c | {
"head_commit": "305f3512c17e50d45f5e12f4c11e564683d7ba66",
"head_commit_message": "e2e",
"patch_to_review": "diff --git a/e2e/scripts/st_text_area.py b/e2e/scripts/st_text_area.py\nindex 665d302648ff..e0f0426933fa 100644\n--- a/e2e/scripts/st_text_area.py\n+++ b/e2e/scripts/st_text_area.py\n@@ -25,3 +25,6 @@\n ... | [
{
"diff_hunk": "@@ -0,0 +1,60 @@\n+import React, { ReactElement } from \"react\"\n+import { isFromMac } from \"lib/utils\"\n+import classNames from \"classnames\"\n+\n+import \"./style.scss\"\n+\n+export interface Props {\n+ dirty: boolean\n+ value: string\n+ maxLength?: number\n+ className?: string\n+ typ... | 3dc4a4358c3775495ef7b35474dd1af23b3d0ac9 | diff --git a/e2e/scripts/st_text_area.py b/e2e/scripts/st_text_area.py
index 665d302648ff..e0f0426933fa 100644
--- a/e2e/scripts/st_text_area.py
+++ b/e2e/scripts/st_text_area.py
@@ -25,3 +25,6 @@
i4 = st.text_area("text area 4", None)
st.write('value 4: "', i4, '"')
+
+i5 = st.text_area("text area 5", max_chars=10... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
streamlit__streamlit-1295@fcbac4b | streamlit/streamlit | Python | 1,295 | Showing an error when it's not localhost and has no mapbox token | **Issue:** Fix #1136 #812
**Description:** As it is not possible to render a Mapbox without any token we are delimiting the use locally.
- Prevent fetching token when it's not localhost or hello.py
- Using axios instead of fetch
- Added new step for cypress job in which we set the mapbox token
- Unittest
... | 2020-04-02T23:34:00Z | Remove Streamlit Mapbox API key
_Edit: apparently this is _not_ how Mapbox works. See Update section below._
If I understand correctly how Mapbox works, I think we don't need an API key by default since Mapbox throttles usage of their maps based on IP address (which is user-specific).
Can we just remove the defau... | ## Changes:
- When you use a DeckGL chart:
- If running `streamlit hello` AND running from localhost:
- The map is shown using our own token (which we pay for)
- Else:
- If the user has a token:
- We show the map
- Else:
- We show an error telling the u... | [
{
"body": "_Edit: apparently this is _not_ how Mapbox works. See Update section below._\r\n\r\nIf I understand correctly how Mapbox works, I think we don't need an API key by default since Mapbox throttles usage of their maps based on IP address (which is user-specific).\r\n\r\nCan we just remove the default AP... | bc28208d86b95769314b67b112d06356f65edf2f | {
"head_commit": "fcbac4b8a1b41e8b09f4e293ecb5be91854094a2",
"head_commit_message": "Update lib/streamlit/config.py\n\nCo-authored-by: Amey Deshpande <10554902+Amey-D@users.noreply.github.com>",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex e2807b3a3b19..02d6fc93e26e 100644\n... | [
{
"diff_hunk": "@@ -47,50 +48,64 @@ function withMapboxToken(\n super(props)\n \n this.state = {\n+ isFetching: true,\n mapboxToken: undefined,\n mapboxTokenError: undefined,\n }\n+\n this.initMapboxToken()\n }\n \n /**\n * Fetch our MapboxToken.\n ... | 9dc51c13e5045bb606208607c925ae39e5872339 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index bc14981c8d6f..af5b55d8066f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -482,12 +482,19 @@ jobs:
- run:
name: Install Cypress dependencies
command: |
- ${SUDO} apt-get install -y xvfb libgtk2.0-0 li... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
zulip__zulip-20379@c389759 | zulip/zulip | Python | 20,379 | compose_actions: Fix misplaced caret position when qouting. | When replying with a quote, the cursor moves back to the beginning
once the quote resolves and disrupts ongoing typing.
Fixes #20071.
| 2021-11-27T16:40:49Z | Cursor jumps after quoted message loads
When replying with a quote, the cursor moves back to the beginning once the quote resolves, disrupting ongoing typing.
Steps to reproduce:
- Select a message.
- Make sure the text box isn't currently open (press esc if necessary).
- In quick succession, press > and then i... | Hello @zulip/server-compose members, this issue was labeled with the "area: compose" label, so you may want to check it out!
<!-- areaLabelAddition -->
We certainly have logic that's intended to prevent.
```
compose_ui.insert_syntax_and_focus("[Quoting…]\n", textarea); ... | [
{
"body": "When replying with a quote, the cursor moves back to the beginning once the quote resolves, disrupting ongoing typing.\r\n\r\nSteps to reproduce:\r\n\r\n- Select a message.\r\n- Make sure the text box isn't currently open (press esc if necessary).\r\n- In quick succession, press > and then immediatel... | 089fdc4d9453790bf5e64fec40dc72ab0e8e3e29 | {
"head_commit": "c389759568d55a5dae60d8bd3beb8c080264cc77",
"head_commit_message": "compose: Fix cursor position loss in quote-and-reply.\n\nIf you used \"Quote and reply\" to start composing a message, and\nstarted typing before receiving the original message body from the\nserver, we ended up resetting your curs... | [
{
"diff_hunk": "@@ -505,7 +506,12 @@ export function quote_and_reply(opts) {\n compose_ui.replace_syntax(\"[Quoting…]\", content, textarea);\n compose_ui.autosize_textarea($(\"#compose-textarea\"));\n // Update textarea caret to point to the new line after quoted message.\n- texta... | d3772acb283fd41c6455d87bc1d984d74889f999 | diff --git a/frontend_tests/node_tests/compose_actions.js b/frontend_tests/node_tests/compose_actions.js
index 2ba4982e4e6f6..b01b45a05da8c 100644
--- a/frontend_tests/node_tests/compose_actions.js
+++ b/frontend_tests/node_tests/compose_actions.js
@@ -338,7 +338,7 @@ test("quote_and_reply", ({override}) => {
let ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-874@44afc26 | streamlit/streamlit | Python | 874 | Auto-reload page if Streamlit server version ≠ frontend version | **Issue:** This PR fixes https://github.com/streamlit/streamlit/issues/536
**Description:** Reloading frontend if Streamlit server version changes
---
**Contribution License Agreement**
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
| 2019-12-19T18:42:06Z | Auto-reload page if Streamlit server version ≠ frontend version
When users upgrade Streamlit, they sometimes have a browser tab running the frontend for the previous version. If we changed the Streamlit protos in between versions, this will break that tab in weird ways.
Thankfully, we already send the server version... | [
{
"body": "When users upgrade Streamlit, they sometimes have a browser tab running the frontend for the previous version. If we changed the Streamlit protos in between versions, this will break that tab in weird ways.\r\n\r\nThankfully, we already send the server version to the frontend every time the websocket... | b5276f49bbe9e81f65caae4fc6a6f310cd3332f9 | {
"head_commit": "44afc268709645401597340b4ada9a82278106cb",
"head_commit_message": "wrong test name",
"patch_to_review": "diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx\nindex 5e6634aff4b1..c93e50c1292b 100644\n--- a/frontend/src/App.test.tsx\n+++ b/frontend/src/App.test.tsx\n@@ -16,12 +16,22... | [
{
"diff_hunk": "@@ -185,6 +185,30 @@ class App extends PureComponent<Props, State> {\n MetricsManager.current.enqueue(\"viewReport\")\n }\n \n+ showError(title: string, errorNode: ReactNode): void {\n+ logError(errorNode)\n+ const newDialog: DialogProps = {\n+ type: DialogType.WARNING,\n+ ... | 7af002b5140f626ad8f091db8a33971feaad8bfa | diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx
index 06bbac2254e2..11463056eebe 100644
--- a/frontend/src/App.test.tsx
+++ b/frontend/src/App.test.tsx
@@ -16,12 +16,22 @@
*/
import React from "react"
-import ReactDOM from "react-dom"
-import { SessionInfo, Args as SessionInfoArgs } from "./lib/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
streamlit__streamlit-655@4d5cbc9 | streamlit/streamlit | Python | 655 | Copy-to-clipboard button is showing at wrong place | **Issue:** This PR fixes #581
**Description:** Added a div that contains both elements
---
**Contribution License Agreement**
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
| 2019-11-08T19:25:38Z | Copy-to-clipboard button is showing at wrong place
Steps to repro:
st.markdown("""
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
Some text.
```
... | [
{
"body": "Steps to repro:\r\n\r\n st.markdown(\"\"\"\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some text.\r\n\r\n Some t... | 8166563234323a086cd5045dee6eb88f05ce39bf | {
"head_commit": "4d5cbc931e52b4ae1568f4cd1769e735e651c139",
"head_commit_message": "Fixing button alignment inside alerts and margins",
"patch_to_review": "diff --git a/frontend/src/components/elements/CodeBlock/CodeBlock.scss b/frontend/src/components/elements/CodeBlock/CodeBlock.scss\nindex dbdff1935672..c70f4... | [
{
"diff_hunk": "@@ -21,6 +21,10 @@\n See https://prismjs.com/download.html#themes=prism&languages=markup+css+clike+javascript\n */\n \n+div.code-block {\n+ margin: 0 0 1rem 0;\n+}",
"line": 35,
"original_line": 26,
"original_start_line": null,
"path": "frontend/src/components/elements/CodeBlo... | d823f64bdb5b706e5e38559f8f6b0e2e3527dced | diff --git a/frontend/src/App.scss b/frontend/src/App.scss
index 53b44d8e891e..258e8428cdf1 100644
--- a/frontend/src/App.scss
+++ b/frontend/src/App.scss
@@ -15,6 +15,7 @@
*/
@import "src/assets/css/variables";
+@import "src/assets/css/mixins";
body.embedded {
overflow: hidden;
@@ -50,9 +51,10 @@ code {
}
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
streamlit__streamlit-188@8f4b5f0 | streamlit/streamlit | Python | 188 | LocalSourcesWatcher: blacklist venv and hidden folders | LocalSourcesWatcher blacklists conda folders (anaconda2/3, miniconda2/3) and any folder whose name starts with a `.`.
For simplicity, the blacklist syntax now supports Unix glob patterns.
(Also, there are a few unrelated tests that I cleaned up while I was fixing the new tests that were written for this PR.)
F... | 2019-09-25T19:26:11Z | Blacklist common virtualenv folders by default
We should blacklist the folders below from being watched by Streamlit. This would fix the issue where some people hit the inotify watch limit when running Streamlit from a weird working directory.
* */.virtualenv
* */.venv
* */anaconda3
* */anaconda2
* */miniconda3
... | [
{
"body": "We should blacklist the folders below from being watched by Streamlit. This would fix the issue where some people hit the inotify watch limit when running Streamlit from a weird working directory.\r\n\r\n* */.virtualenv\r\n* */.venv\r\n* */anaconda3\r\n* */anaconda2\r\n* */miniconda3\r\n* */miniconda... | 404987da8199097b2cbbdf40fc97f05d1b95dc85 | {
"head_commit": "8f4b5f097c187ff60225a77725a53ce2abb74487",
"head_commit_message": "Tweak",
"patch_to_review": "diff --git a/lib/streamlit/watcher/LocalSourcesWatcher.py b/lib/streamlit/watcher/LocalSourcesWatcher.py\nindex 33080a28d7cf..236c9773b4dc 100644\n--- a/lib/streamlit/watcher/LocalSourcesWatcher.py\n++... | [
{
"diff_hunk": "@@ -61,6 +66,11 @@ def __init__(self, report, on_file_changed):\n \n self._folder_blacklist = config.get_option(\"server.folderWatchBlacklist\")\n \n+ # Blacklist some additional folders, using glob syntax.\n+ self._folder_blacklist.extend(\n+ [\"**/.*\", \"**/an... | 2bfd39840b560e4061b71186ef2b12aab75cfb21 | diff --git a/lib/streamlit/watcher/LocalSourcesWatcher.py b/lib/streamlit/watcher/LocalSourcesWatcher.py
index 33080a28d7cf..0d391626e051 100644
--- a/lib/streamlit/watcher/LocalSourcesWatcher.py
+++ b/lib/streamlit/watcher/LocalSourcesWatcher.py
@@ -13,6 +13,7 @@
# See the License for the specific language governing ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
streamlit__streamlit-621@e264960 | streamlit/streamlit | Python | 621 | Display area/bar/line chart time values in UTC, rather than browser-local time | By default, vega-lite displays time data in the browser's local time zone, regardless of which time zone the data specifies. (See https://vega.github.io/vega-lite/docs/timeunit.html#output for more details.) This leads to unexpected results - see #485 for an example.
With this PR, for generated altair charts (`st.ar... | 2019-11-04T23:57:26Z | Passing a date in index to st.line_chart defaults to UTC time zone
# Summary
This may not be a Streamlit bug - it may be a Python issue where I need to declare a datetime. When I pass a date through as the index to st.line_chart my graph is then shifted 7 hours back in time from my intended time (e.g. I would want to ... | By default, Vegalite outputs time data in local time: https://vega.github.io/vega-lite/docs/timeunit.html#output
We can fix this by setting `scale: {type: "utc"}` in the chart spec:
```python
chart = (
getattr(alt.Chart(data), "mark_" + chart_type)()
.encode(
alt.X("index", title="", scale=alt... | [
{
"body": "# Summary\r\nThis may not be a Streamlit bug - it may be a Python issue where I need to declare a datetime. When I pass a date through as the index to st.line_chart my graph is then shifted 7 hours back in time from my intended time (e.g. I would want to show value 50 on the graph for midnight on 201... | 15967f076ec5a56b6072241b56731d1b0c66ab78 | {
"head_commit": "e264960550e47ebc31d75bdf78d32a14eea4f4df",
"head_commit_message": "chart_utc_time snapshot tests",
"patch_to_review": "diff --git a/e2e/scripts/chart_utc_time.py b/e2e/scripts/chart_utc_time.py\nnew file mode 100644\nindex 000000000000..b024c12c1e20\n--- /dev/null\n+++ b/e2e/scripts/chart_utc_ti... | [
{
"diff_hunk": "@@ -45,8 +44,14 @@ def generate_chart(chart_type, data):\n chart = (\n getattr(alt.Chart(data), \"mark_\" + chart_type)()\n .encode(\n- alt.X(\"index\", title=\"\"),\n- alt.Y(\"value\", title=\"\"),\n+ # Set the X and Y axes' scale to `type=\"... | 4bf273f15c65f937a8cad07e216422da5fe97363 | diff --git a/e2e/scripts/chart_utc_time.py b/e2e/scripts/chart_utc_time.py
new file mode 100644
index 000000000000..b024c12c1e20
--- /dev/null
+++ b/e2e/scripts/chart_utc_time.py
@@ -0,0 +1,27 @@
+from datetime import date
+
+import pandas as pd
+import streamlit as st
+
+df = pd.DataFrame(
+ {
+ "index": [
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-118@bafecab | streamlit/streamlit | Python | 118 | Support hashing dataframes with unhashable objects. Gracefully f… | Fixes #111. Merge #117 first. | 2019-09-16T22:16:57Z | Lists inside of DataFrames are unhashable and break st.cache
# Summary
A `DataFrame` which contains a list is unhashable and therefore breaks `st.cache`.
## Steps to reproduce
Run this code
```python
import streamlit as st
import pandas as pd
@st.cache
def return_a_list(n):
return pd.DataFrame({'n'... | This issue was first observed here: https://discuss.streamlit.io/t/using-caching-with-api-calls-and-messy-dataframes/75
This issue boils down to
```py
pd.util.hash_pandas_object(pd.DataFrame({'a': [[1,2,3]]}))
``` | [
{
"body": "# Summary\r\n\r\nA `DataFrame` which contains a list is unhashable and therefore breaks `st.cache`.\r\n\r\n## Steps to reproduce\r\n\r\nRun this code\r\n```python\r\nimport streamlit as st\r\nimport pandas as pd\r\n\r\n@st.cache\r\ndef return_a_list(n):\r\n return pd.DataFrame({'n': [n], 'result':... | ee4c4fad1e77f1e2205a7fa82b8d3c253ca92823 | {
"head_commit": "bafecab21d80ae723216ce0f79eebe170bae23e5",
"head_commit_message": "Support hashing dataframes with unhashable objects. Gracefully fail if Streamlit fails to hash.",
"patch_to_review": "diff --git a/lib/streamlit/hashing.py b/lib/streamlit/hashing.py\nindex 26a5156905c0..dd3ce26e8550 100644\n--- ... | [
{
"diff_hunk": "@@ -202,121 +202,128 @@ def _to_bytes(self, obj, context):\n Python's built in `hash` does not produce consistent results across\n runs.\"\"\"\n \n- if _is_magicmock(obj):\n- # MagicMock can result in objects that appear to be infinitely\n- # deep, so... | 63ab7ed0bf2066a086d0c551c8bbad1e4e2b2da0 | diff --git a/lib/streamlit/hashing.py b/lib/streamlit/hashing.py
index 6776124cb673..9bebab6cb765 100644
--- a/lib/streamlit/hashing.py
+++ b/lib/streamlit/hashing.py
@@ -142,6 +142,17 @@ def is_simple(obj):
return None
+def _hashing_error_message(start):
+ return (
+ start,
+ "\n\n**More info... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
streamlit__streamlit-85@a221f38 | streamlit/streamlit | Python | 85 | Email, metrics prompt | - Nicer `streamlit activate` prompt and text from @tvst
- Remove the unused "activation code" stuff from Credentials.
- Credentials: email is now optional. If the user doesn't enter one, it will be stored as the empty string. The client will omit the "authoremail" trait from the Segment.io identifier if the user didn... | 2019-09-10T22:29:13Z | On first use, ask nicely for email/metrics
When the user first runs a `streamlit foo` command on the CLI, we currently show a message asking for the user's email:
```
Enter your email for access to our beta
```
and then show a welcome message:
```
Welcome to Streamlit!
Get started by typing:
$ str... | [
{
"body": "When the user first runs a `streamlit foo` command on the CLI, we currently show a message asking for the user's email:\r\n\r\n```\r\n Enter your email for access to our beta\r\n```\r\n\r\nand then show a welcome message:\r\n```\r\n Welcome to Streamlit!\r\n\r\n Get started by typing:\r\n $ strea... | 93cf9393877c3122b569b74a4f35f0dea01d26cd | {
"head_commit": "a221f38bc74ab9c87ddacca3741870b54892464f",
"head_commit_message": "Damn. Python 2.7 doesn't have textwrap.indent",
"patch_to_review": "diff --git a/frontend/src/lib/MetricsManager.ts b/frontend/src/lib/MetricsManager.ts\nindex 4f599166eb42..7b05b36e62f4 100644\n--- a/frontend/src/lib/MetricsMana... | [
{
"diff_hunk": "@@ -43,6 +40,32 @@\n FileNotFoundError = IOError\n \n \n+EMAIL_PROMPT = '''\n+ 👋 %(welcome)s\n+ \n+ If you are one of our development partners or are interested in\n+ getting personal technical support, please enter your email address\n+ below. Otherwise, you may leave the field blank.... | fafaafea667ee928d1eb8ad3f545ac7df434ae0c | diff --git a/frontend/src/lib/MetricsManager.ts b/frontend/src/lib/MetricsManager.ts
index 4f599166eb42..7b05b36e62f4 100644
--- a/frontend/src/lib/MetricsManager.ts
+++ b/frontend/src/lib/MetricsManager.ts
@@ -34,8 +34,6 @@ interface DeltaCounter {
type Event = [string, object]
-type SendFunction = (evName: strin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
zulip__zulip-18217@3c5b3da | zulip/zulip | Python | 18,217 | hotkey: Disable left arrow hotkey when view has unreads. | On pressing left arrow key while in narrow stream to edit
the last message, if the user has unread messages sent in
topics other than the one where the user has sent its last
message (considering the topics for same stream) and the unread
messages were sent before the user message, the hotkey unexpectedly
marks th... | 2021-04-20T09:48:52Z | Edit last message keyboard shortcut (←) may unexpectedly mark many messages read
If you write a message in a narrowed view, then go back to an unnarrowed view, there may now be many unread messages between your new current position and the message you just wrote. If you then accidentally press `←`, all of those message... | Hello @zulip/server-message-view members, this issue was labeled with the "area: message-editing" label, so you may want to check it out!
<!-- areaLabelAddition -->
Hello @andersk I wanna work on this issue
I think this option makes sense to me, probably with a notice:
> disable the ← shortcut if there are unread mes... | [
{
"body": "If you write a message in a narrowed view, then go back to an unnarrowed view, there may now be many unread messages between your new current position and the message you just wrote. If you then accidentally press `←`, all of those messages will be marked read unexpectedly, causing you to lose your p... | a8abcf5210deb1894147077a19545686418198d1 | {
"head_commit": "3c5b3da20e5364aac51c581328aafa1616fe16fc",
"head_commit_message": "message_edit: Remove incorrect `from_scroll` value.\n\nSince it is important that the message being edited is visible,\nit is safe to ignore `from_scroll` here which is also an\nunlikely possibility here.",
"patch_to_review": "di... | [
{
"diff_hunk": "@@ -1252,6 +1252,30 @@ export function maybe_show_edit($row: JQuery, id: number): void {\n }\n }\n \n+function warn_user_about_unread_msgs(last_sent_msg_id: number): void {\n+ feedback_widget.show({\n+ populate(container) {\n+ container.html(\n+ $t({\n+ ... | 8af72a8a906f7601f0e9d95421a2a266c68a1df8 | diff --git a/web/src/message_edit.ts b/web/src/message_edit.ts
index 01a1d0ef49e25..9da77778a1574 100644
--- a/web/src/message_edit.ts
+++ b/web/src/message_edit.ts
@@ -6,6 +6,7 @@ import {z} from "zod";
import * as resolved_topic from "../shared/src/resolved_topic.ts";
import render_wildcard_mention_not_allowed_erro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ultralytics__ultralytics-7136@bf9a991 | ultralytics/ultralytics | Python | 7,136 | `ultralytics 8.0.236` dataset semantic & SQL search API |
copilot:all
## 🛠️ PR Summary
<sub>Made with ❤️ by [Ultralytics Actions](https://github.com/ultralytics/actions)<sub>
### 🌟 Summary
Introducing expanded dataset exploration features for Ultralytics with an API and GUI support.
### 📊 Key Changes
- Added `explorer` dependency with vector search, SQL queries, ... | 2023-12-22T20:02:38Z | Add new feature - dataset explorer
## Summary
Dataset explorer and utilities for Ultralytics
## Features
### Embedding
- Allows user to calculate embeddings as a top level operation in YOLO models.
- Start with detection/segmentation backbones for now, pose, etc. are not that relevant for embeddings.
<p><details>
<... | @AyushExel I added the information you shared to this issue and cleaned it up some. I also tried to include sub-tasks, but wasn't certain on what else would be needed. Please reference this issue with your PR and any important commits.
PR #6971 opened to add this feature
Cool. Advanced features are out of scope for no... | [
{
"body": "## Summary\nDataset explorer and utilities for Ultralytics\n\n## Features\n\n### Embedding\n\n- Allows user to calculate embeddings as a top level operation in YOLO models.\n- Start with detection/segmentation backbones for now, pose, etc. are not that relevant for embeddings.\n\n<p><details>\n<summa... | 40a5c0abe70731187b1a5d15809dcce00e479b35 | {
"head_commit": "bf9a991f3d0dc6c43fee5a4fecad2c5b5f81f1cb",
"head_commit_message": "Merge remote-tracking branch 'refs/remotes/origin/sem_search' into sem_search",
"patch_to_review": "diff --git a/ultralytics/data/explorer/__init__.py b/ultralytics/data/explorer/__init__.py\nnew file mode 100644\nindex 000000000... | [
{
"diff_hunk": "@@ -0,0 +1,158 @@\n+from pathlib import Path\n+from typing import List\n+\n+import cv2\n+import numpy as np\n+import pyarrow as pa\n+import torch\n+from tqdm import tqdm\n+\n+from ultralytics import YOLO\n+from ultralytics.data.augment import Format\n+from ultralytics.data.dataset import YOLODat... | c0a8fcf6b0f87cbeeb98e8d3ea01685b181e7695 | diff --git a/docs/ar/models/yolov5.md b/docs/ar/models/yolov5.md
index 32481a3f151..a013f04bfcd 100644
--- a/docs/ar/models/yolov5.md
+++ b/docs/ar/models/yolov5.md
@@ -59,7 +59,7 @@ keywords: YOLOv5u، كشف الكائنات، النماذج المدربة مس
```python
from ultralytics import YOLO
-#قم بتحميل نموذج YOLOv5n المدرب مسبقًا عل... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
zulip__zulip-7419@15d758e | zulip/zulip | Python | 7,419 | org settings: Add UI for managing user groups. | Fixes #165.
# To-Do
- [x] Add framework for page
- [x] Add content and design to page
- [x] Render current user groups data dynamically
- [x] Add user group creation functionality (initialized with current user inside)
- [x] Add user group deletion functionality
- [x] Add save user group state functionality ... | 2017-11-16T22:03:58Z | Add user-definable groups
[summarizing a Zulip discussion]
Add a way for users (or, at the very least, administrators) to define their own groups, such that someone can write `@group1` to notify everyone in `group1`.
Design complication: what should happen when `group1` is (say) 100 members, but someone says `@group1... | why not use a stream instead? whoever subscribed to it is in the group...
@ritschwumm It could be helpful to tag a specific group in a discussion that's open to a wider audience. For example, you might want to tag the support team in a discussion among all company employees.
As a workaround, you can simulate that tod... | [
{
"body": "[summarizing a Zulip discussion]\n\nAdd a way for users (or, at the very least, administrators) to define their own groups, such that someone can write `@group1` to notify everyone in `group1`.\n\nDesign complication: what should happen when `group1` is (say) 100 members, but someone says `@group1` i... | 5bbc46762f52ccb18a0fc8837bce65a28602f97c | {
"head_commit": "15d758e2e105503283ae9508e1980ade6447219b",
"head_commit_message": "org settings: Add user group deletion functionality.",
"patch_to_review": "diff --git a/.eslintrc.json b/.eslintrc.json\nindex 182309f2fa5f2..31a3542bf707f 100644\n--- a/.eslintrc.json\n+++ b/.eslintrc.json\n@@ -56,6 +56,7 @@\n ... | [
{
"diff_hunk": "@@ -4,5 +4,8 @@\n <div class=\"pill-container\" data-group-pills=\"{{name}}\">\n <div class=\"input\" contenteditable=\"true\"></div>\n </div>\n+ <button class=\"button rounded small delete btn-danger\">\n+ <i class=\"icon-vector-trash\" aria-hidden=\"true\"></i>",
... | b36c0c8072fa5a3aa4b500ab23618d01229555aa | diff --git a/.eslintrc.json b/.eslintrc.json
index 182309f2fa5f2..31a3542bf707f 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -56,6 +56,7 @@
"settings_streams": false,
"settings_filters": false,
"settings_invites": false,
+ "settings_user_groups": false,
"settings": fals... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ultralytics__ultralytics-4546@3acf009 | ultralytics/ultralytics | Python | 4,546 | `ultralytics 8.0.233` improve Classify train augmentations | <!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 24f5c97</samp>
### Summary
🧪🛠️🌈
<!--
1. 🧪 for adding a new test function
2. 🛠️ for adding new configuration options and modifying existing functions
3. 🌈 for adding support for new classification transforms and improving image processing
-->
This pull... | 2023-08-24T11:22:03Z | Classification augmentations
## Summary
Execute research and testing on new/additional augmentations to use for Classification task.
## Subtasks
- [x] research new/additional augmentations for image classification
- [x] identified new augmentations to test with
- [x] execute new augmentations
- [x] collect and analyze... | [
{
"body": "## Summary\nExecute research and testing on new/additional augmentations to use for Classification task.\n\n## Subtasks\n- [x] research new/additional augmentations for image classification\n- [x] identified new augmentations to test with\n- [x] execute new augmentations\n- [x] collect and analyze ne... | 6218b820723b9e8647c582589c536c63c1f473f3 | {
"head_commit": "3acf0097d6dbbc9f7289cb1a90aa30049a6f4c83",
"head_commit_message": "add eval and no_aug train augmentations ofr cls",
"patch_to_review": "diff --git a/ultralytics/cfg/default.yaml b/ultralytics/cfg/default.yaml\nindex cdeb95953d6..1d73d0280e6 100644\n--- a/ultralytics/cfg/default.yaml\n+++ b/ultr... | [
{
"diff_hunk": "@@ -225,7 +227,22 @@ def __init__(self, root, args, augment=False, cache=False, prefix=''):\n self.cache_disk = cache == 'disk'\n self.samples = self.verify_images() # filter out bad images\n self.samples = [list(x) + [Path(x[0]).with_suffix('.npy'), None] for x in self.... | 14716613a3ae0da3ce2c6f67eea023a7df7e94d1 | diff --git a/README.md b/README.md
index fcc51b4fd70..e798a33ab52 100644
--- a/README.md
+++ b/README.md
@@ -181,11 +181,11 @@ See [Classification Docs](https://docs.ultralytics.com/tasks/classify/) for usag
| Model | size<br><sup... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
vllm-project__vllm-18208@ea012f4 | vllm-project/vllm | Python | 18,208 | Allow users to pass arbitrary JSON keys from CLI | Closes #17640
Supersede #17842
Allows users to pass individual JSON keys via `FlexibleArgumentParser` in the format `--json-arg.key1.key2 value`
i.e. `--hf-overrides.key1 val1 --hf-overrides.key2.key3 val2` will result in the following args:
```console
INFO 05-15 17:09:16 [cli_args.py:297] non-default args: {'enforc... | 2025-05-15T15:11:49Z | [Feature]: provide a way to configure rope-scaling that isn't inline JSON
### 🚀 The feature, motivation and pitch
Having to use literal JSON strings as a command argument is breaking a lot automation and scripts out there. I propose it's addressed so that all configuration can be done via simple key-value pairs.
###... | @DarkLight1337 What do you think, If you agree, I can make changes.
I think this isn't necessary, you can simply pass a YAML config file to `vllm serve`.
@DarkLight1337 passing a yaml to `vllm serve` isn't a feasible solution for many situations. Most environments we work with can only be configured via ENV vars and c... | [
{
"body": "### 🚀 The feature, motivation and pitch\n\nHaving to use literal JSON strings as a command argument is breaking a lot automation and scripts out there. I propose it's addressed so that all configuration can be done via simple key-value pairs.\n\n### Alternatives\n\nInstead of configuring it as follo... | 01c22335baa03dbbc3ae662c76a089ff1c5b5742 | {
"head_commit": "ea012f4666edceffb3743f9fe6ebcd91a43fe26f",
"head_commit_message": "Add comments\n\nSigned-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>",
"patch_to_review": "diff --git a/tests/test_utils.py b/tests/test_utils.py\nindex ea7db0a79c86..d760cdceb8ca 100644\n--- a/tests/test_utils... | [
{
"diff_hunk": "@@ -1419,6 +1420,35 @@ def parse_args( # type: ignore[override]\n else:\n processed_args.append(arg)\n \n+ def create_nested_dict(keys: list[str], value: str):\n+ \"\"\"Creates a nested dictionary from a list of keys and a value.\n+\n+ Fo... | 680a78d9b3423049701dcdc9f6abbfa0c1b3d38f | diff --git a/tests/engine/test_arg_utils.py b/tests/engine/test_arg_utils.py
index ce8873d58d4d..05d9cfc7ab74 100644
--- a/tests/engine/test_arg_utils.py
+++ b/tests/engine/test_arg_utils.py
@@ -181,8 +181,8 @@ def test_get_kwargs():
# literals of literals should have merged choices
assert kwargs["literal_lit... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
vllm-project__vllm-16291@3bda5d1 | vllm-project/vllm | Python | 16,291 | [Hardware] add platform-specific request validation api | This PR adds a generic `validate_request` api to the platform interface. This allows platforms to implement any runtime checks on each request to ensure that all the requested features are supported before scheduling it. There is already one existing check in this category, `supports_structured_output`, and I'd like to... | 2025-04-08T22:04:36Z | Add platform api for request validation to reject requests that don't fit warmup shapes
From talking to @njhill, there's already precedent for doing hardware-specific request validation with the `supports_structured_output` platform api. For spyre we need a way to reject requests that don't fit a warmup shape, so we sh... | [
{
"body": "From talking to @njhill, there's already precedent for doing hardware-specific request validation with the `supports_structured_output` platform api. For spyre we need a way to reject requests that don't fit a warmup shape, so we should propose a more general api to validate requests up front. Maybe ... | db104221845e44e0b85336a54e44eb8850b8a5bc | {
"head_commit": "3bda5d15f6c86629d861791232713c8d911cd013",
"head_commit_message": ":sparkles: add platform-specific request validation\n\nSigned-off-by: Joe Runde <Joseph.Runde@ibm.com>",
"patch_to_review": "diff --git a/vllm/platforms/interface.py b/vllm/platforms/interface.py\nindex 2bb543bd73f7..a6425a7ce895... | [
{
"diff_hunk": "@@ -393,6 +396,15 @@ def use_custom_allreduce(cls) -> bool:\n \"\"\"\n return False\n \n+ @classmethod\n+ def validate_request(\n+ cls,\n+ prompt: PromptType,\n+ params: Union[SamplingParams, PoolingParams],\n+ lora_request: Optional[LoRARequest]... | 6ba2638d96f7c820e861ddab810b03206d7f49eb | diff --git a/vllm/platforms/cpu.py b/vllm/platforms/cpu.py
index cfd7bc2a4057..67466bdb9807 100644
--- a/vllm/platforms/cpu.py
+++ b/vllm/platforms/cpu.py
@@ -180,7 +180,3 @@ def get_device_communicator_cls(cls) -> str:
Get device specific communicator class for distributed communication.
"""
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
vllm-project__vllm-15417@838b01e | vllm-project/vllm | Python | 15,417 | [bugfix] add supports_v1 platform interface | This PR re-allows platform plugins to run on V1. I'm assuming that all out-of-tree platforms are responsible for all of their own validation at startup to ensure the provided configuration will work, so vllm shouldn't disallow them from running.
Our plugin currently doesn't boot with v0.8.1 (and presumably won't with ... | 2025-03-24T21:14:10Z | Plugin won't boot with vllm v0.8.1
Trying to boot with vllm 0.8.1 with `VLLM_SPYRE_DYNAMO_BACKEND=eager` and `VLLM_USE_V1=1` gives the fun error:
```
INFO 03-19 22:31:45 [config.py:2595] Downcasting torch.float32 to torch.float16.
INFO 03-19 22:31:49 [config.py:583] This model supports multiple tasks: {'score', 'rewar... | [
{
"body": "Trying to boot with vllm 0.8.1 with `VLLM_SPYRE_DYNAMO_BACKEND=eager` and `VLLM_USE_V1=1` gives the fun error:\n\n```\nINFO 03-19 22:31:45 [config.py:2595] Downcasting torch.float32 to torch.float16.\nINFO 03-19 22:31:49 [config.py:583] This model supports multiple tasks: {'score', 'reward', 'classif... | 3eb08ed9b1114fc16eaa2386b2e7ad14eae87073 | {
"head_commit": "838b01e17d8a075f99cda3b839989d2a49992b18",
"head_commit_message": ":bug: re-allow OOT platforms on V1\n\nSigned-off-by: Joe Runde <Joseph.Runde@ibm.com>",
"patch_to_review": "diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py\nindex 38a47a846df7..8d96c836fbdc 100644\n--- a/vllm/eng... | [
{
"diff_hunk": "@@ -1670,8 +1670,10 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:\n return False\n \n # No support for device type other than CUDA, AMD (experiemntal) or\n- # TPU (experimental) so far.\n- if not (current_platform.is_cuda_alike() or cu... | aaf21cd9d07d32ec682c8104bbd31a41d7239493 | diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py
index 38a47a846df7..69a164bbc6a8 100644
--- a/vllm/engine/arg_utils.py
+++ b/vllm/engine/arg_utils.py
@@ -1669,9 +1669,8 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:
_raise_or_fallback(feature_name=name, recommend_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
vllm-project__vllm-10353@3456673 | vllm-project/vllm | Python | 10,353 | [Core] Interface for accessing model from `VllmRunner` | This PR adds a new method `LLM.apply_model` to apply a function to the model in each worker without having to access `llm.llm_engine.model_executor.driver_worker.model_runner.model`.
FIX #4084 | 2024-11-15T05:51:54Z | [Usage]: How do we add model hooks?
### Your current environment
```text
PyTorch version: 2.1.0+cu118
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMa... | I have the same question. Have you solved this?
If you set enforce_eager to be True, then it will add call the hooks everytime.
But I couldn't find a cleaner way of accessing model hooks.
This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically c... | [
{
"body": "### Your current environment\n\n```text\r\nPyTorch version: 2.1.0+cu118\r\nIs debug build: False\r\nCUDA used to build PyTorch: 11.8\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Ubuntu 22.04.3 LTS (x86_64)\r\nGCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0\r\nClang version: Could not collect\r\nC... | 81763c58a01eda9205f3750177358acc79613e65 | {
"head_commit": "3456673828daa7944eb8fbf8cc8e3673b30457ea",
"head_commit_message": "Make available to LLM\n\nSigned-off-by: DarkLight1337 <tlleungac@connect.ust.hk>",
"patch_to_review": "diff --git a/tests/conftest.py b/tests/conftest.py\nindex 95af4ac1eb17..279c1bf9a377 100644\n--- a/tests/conftest.py\n+++ b/te... | [
{
"diff_hunk": "@@ -35,8 +35,7 @@ def test_models(\n vllm_outputs = vllm_model.generate_greedy(example_prompts, max_tokens)\n # This test is for verifying whether the model's extra_repr\n # can be printed correctly.\n- print(vllm_model.model.llm_engine.model_executor.driver_worker... | 2e966f0a7f3ace56ca967e4c34f66a7cf3f8ecfb | diff --git a/tests/conftest.py b/tests/conftest.py
index 95af4ac1eb17..279c1bf9a377 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -244,6 +244,7 @@ def video_assets() -> _VideoAssets:
_T = TypeVar("_T", nn.Module, torch.Tensor, BatchEncoding, BatchFeature, dict)
+_R = TypeVar("_R")
class HfRunner:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
vllm-project__vllm-18557@2ab78b1 | vllm-project/vllm | Python | 18,557 | [Platform] Add custom default max tokens | FIX: https://github.com/vllm-project/vllm-spyre/issues/148
Currently the default max tokens for the completions API is set to `max_model_len - prompt_len`. The changes in this PR make so that when a platform needs to use a different value for `default_max_tokens` it can be altered simply by overriding the `maybe_updat... | 2025-05-22T17:11:45Z | Incorrect default max_completion_tokens being set
### Changes
Trying to run vLLM with `VLLM_SPYRE_WARMUP_NEW_TOKENS` set to X number always results in error:
```
No applicable warmup shape exists for combination of prompt length (Z tokens) and maximum number of output tokens to be generated (Y tokens)
```
Where `Z` ... | To add some more context: This is observed when using the Chat API while not setting `max_completions_token` or `max_tokens` in the request body.
Turns out that the OpenAI frontend code is where the default value for `max_completions_token`/`max_tokens` is set.
For the completions API, it defaults to 16 ([REF](https:/... | [
{
"body": "### Changes\n\nTrying to run vLLM with `VLLM_SPYRE_WARMUP_NEW_TOKENS` set to X number always results in error:\n\n```\nNo applicable warmup shape exists for combination of prompt length (Z tokens) and maximum number of output tokens to be generated (Y tokens)\n```\n\nWhere `Z` is input token count a... | 536fd330036b0406786c847f68e4f67cba06f421 | {
"head_commit": "2ab78b136b3daf6c661ba87ba79b7e2b07c78dcc",
"head_commit_message": "trigger ci\n\nSigned-off-by: Gabriel Marinho <gmarinho@ibm.com>",
"patch_to_review": "diff --git a/vllm/entrypoints/openai/protocol.py b/vllm/entrypoints/openai/protocol.py\nindex 3b5281962b2d..d9d112730150 100644\n--- a/vllm/ent... | [
{
"diff_hunk": "@@ -231,3 +234,17 @@ def show_filtered_argument_or_group_from_help(parser, subcommand_name):\n print(f\"\\nNo group or parameter matching '{search_keyword}'\")\n print(\"Tip: use `--help=listgroup` to view all groups.\")\n sys.exit(1)\n+\n+\n+def get_max_token... | 5f5310ad512fba7c9d4eafd89675d556b143fbd9 | diff --git a/vllm/entrypoints/openai/protocol.py b/vllm/entrypoints/openai/protocol.py
index 3df11db33384..93d9c588d8d2 100644
--- a/vllm/entrypoints/openai/protocol.py
+++ b/vllm/entrypoints/openai/protocol.py
@@ -229,7 +229,6 @@ class ChatCompletionRequest(OpenAIBaseModel):
logit_bias: Optional[dict[str, float]]... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-9396@3d6f0bc | vllm-project/vllm | Python | 9,396 | [Model][Bugfix] Add FATReLU activation and support for openbmb/MiniCPM-S-1B-sft | Add FATReLU ([Kurtz et al., 2020](https://proceedings.mlr.press/v119/kurtz20a/kurtz20a.pdf)) and support for [openbmb/MiniCPM-S-1B-sft](https://huggingface.co/openbmb/MiniCPM-S-1B-sft)
FIX #7678 (*link existing issues this PR will resolve*)
**BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESC... | 2024-10-16T00:49:34Z | [Feature]: Please Support FATRelu
### 🚀 The feature, motivation and pitch
#### When I tried to deploy `openbmb/ProSparse-MiniCPM-1B-sft`, it raised an error:
```
File "/home/xxxxxx/.conda/envs/vllm_env/lib/python3.10/site-packages/vllm/model_executor/models/minicpm.py", line 290, in __init__
self.mlp = M... | [
{
"body": "### 🚀 The feature, motivation and pitch\r\n\r\n#### When I tried to deploy `openbmb/ProSparse-MiniCPM-1B-sft`, it raised an error:\r\n\r\n```\r\n File \"/home/xxxxxx/.conda/envs/vllm_env/lib/python3.10/site-packages/vllm/model_executor/models/minicpm.py\", line 290, in __init__\r\n self.mlp = Mi... | 717a5f82cda6dd6a52be6504179adaa64bbdc67a | {
"head_commit": "3d6f0bc694da216d693214a121d534113a3fd3e0",
"head_commit_message": "Remove an extra space in supported_models.rst",
"patch_to_review": "diff --git a/docs/source/models/supported_models.rst b/docs/source/models/supported_models.rst\nindex 102842b0a188..544f6d680d5a 100644\n--- a/docs/source/models... | [
{
"diff_hunk": "@@ -13,6 +13,30 @@\n from vllm.model_executor.utils import set_weight_attrs\n \n \n+class FatreluAndMul(CustomOp):\n+ \"\"\"An activation function for FATReLU.\n+ \n+ The function computes x -> FATReLU(x[:d]) * x[d:] where\n+ d = x.shape[-1] // 2.\n+ This is used in openbmb/MiniCP... | 695256b9e8a4840bc3505c905f6965e32ea00142 | diff --git a/docs/source/models/supported_models.rst b/docs/source/models/supported_models.rst
index 102842b0a188..544f6d680d5a 100644
--- a/docs/source/models/supported_models.rst
+++ b/docs/source/models/supported_models.rst
@@ -159,7 +159,7 @@ Text Generation
-
* - :code:`MiniCPMForCausalLM`
- MiniCPM
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Textualize__textual-5795@2648f82 | Textualize/textual | Python | 5,795 | Refresh layout of option lists on add. | Ensures options added to an empty list after mount are displayed.
Fixes #5794.
Attached screenshot of added snapshot test with fix reverted.
<img width="1495" alt="Screenshot 2025-05-10 at 11 52 38 PM" src="https://github.com/user-attachments/assets/f4241756-0c91-4bc5-9e69-fb8b989dccf0" />
| 2025-05-11T07:31:56Z | Options added to an empty (or cleared) OptionList after mount are not displayed.
OptionList._update_lines() exits early if the scroll region has zero height, which can be the case when called from add_options() after mount.
Fix is to refresh the layout before _update_lines().
Filing issue to attach a PR to. | We found the following entries in the [FAQ](https://textual.textualize.io/FAQ/) which you may find helpful:
- [How do I center a widget in a screen?](https://textual.textualize.io/FAQ/#how-do-i-center-a-widget-in-a-screen)
- [How do I pass arguments to an app?](https://textual.textualize.io/FAQ/#how-do-i-pass-argumen... | [
{
"body": "OptionList._update_lines() exits early if the scroll region has zero height, which can be the case when called from add_options() after mount.\n\nFix is to refresh the layout before _update_lines().\n\nFiling issue to attach a PR to.",
"number": 5794,
"title": "Options added to an empty (or ... | d50b353e55de9ff6364a20cc49fc2458d2b1808e | {
"head_commit": "2648f82fdf1925ad4195ac218b008469d4d8ab1e",
"head_commit_message": "Refresh layout of option lists on add.\n\nEnsures options added to an empty list after mount are displayed.",
"patch_to_review": "diff --git a/src/textual/widgets/_option_list.py b/src/textual/widgets/_option_list.py\nindex 00909... | [
{
"diff_hunk": "@@ -373,6 +373,7 @@ def add_options(self, new_options: Iterable[OptionListContent]) -> Self:\n self._id_to_option[option._id] = option\n add_option(option)\n if self.is_mounted:\n+ self.refresh(layout=True)",
"line": null,
"original_line": 3... | 1cd868f791aaee2768c2d5122d205c370985ba56 | diff --git a/src/textual/widgets/_option_list.py b/src/textual/widgets/_option_list.py
index 00909e3d9d..a63dca9726 100644
--- a/src/textual/widgets/_option_list.py
+++ b/src/textual/widgets/_option_list.py
@@ -373,6 +373,7 @@ def add_options(self, new_options: Iterable[OptionListContent]) -> Self:
sel... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-9846@d598a7c | vllm-project/vllm | Python | 9,846 | [CI/Build] Add Model Tests for Qwen2-VL | - Adds tests for comparing the HF / vLLM outputs for Qwen2 VL for single image / multi-image / video using the default size factors
- Moves the `runner_mm_key` from the test `VLMTestInfo` -> `CustomTestOptions` and sets `runner_mm_key` for `images` for single/multi image / embedding tests, and `videos` for video tests... | 2024-10-30T17:41:33Z | [Feature]: CI - Split up "Models Test" and "Vision Language Models Test"
### 🚀 The feature, motivation and pitch
Takes 1 hour+ on CI compared to others, which take <~30 min. Thus, ends up being a bottleneck
So, should be split up similar to kernels
CC: @khluu | root for this!
This sounds great! However, we should still avoid regressions. I suggest testing a representative subset per PR and perform full testing once in a while.
Any ideas on which models we should always test?
A more concrete plan:
Let's add a pytest marker `core_model` to explicitly tag model tests to be... | [
{
"body": "### 🚀 The feature, motivation and pitch\r\n\r\nTakes 1 hour+ on CI compared to others, which take <~30 min. Thus, ends up being a bottleneck\r\n\r\nSo, should be split up similar to kernels\r\n\r\nCC: @khluu \r\n",
"number": 7439,
"title": "[Feature]: CI - Split up \"Models Test\" and \"Visi... | 5608e611c2116cc17c6808b2ae1ecb4a3e263493 | {
"head_commit": "d598a7c0cd50bddfd3f04f826575b89fa5175129",
"head_commit_message": "Separate core / extended mm tests\n\nSigned-off-by: Alex-Brooks <Alex.Brooks@ibm.com>",
"patch_to_review": "diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml\nindex 32eed1a77171..49639b59c7c5 100644\n--- ... | [
{
"diff_hunk": "@@ -97,4 +97,5 @@ markers = [\n \"skip_global_cleanup\",\n \"core_model: run this model test in each PR instead of just daily\",\n \"distributed_2_gpus: run this test only in distributed tests for 2 GPUs\",\n+ \"core_mm_model_test: run this vlm test in the core decoder only mm tes... | df000e757947374c2f65f95dde64c02de72f5bd3 | diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml
index 32eed1a77171..9444dc43ea97 100644
--- a/.buildkite/test-pipeline.yaml
+++ b/.buildkite/test-pipeline.yaml
@@ -9,6 +9,7 @@
# label(str): the name of the test. emoji allowed.
# fast_check(bool): whether to run this on each commit on fastch... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
vllm-project__vllm-9242@2719fac | vllm-project/vllm | Python | 9,242 | [Model] Add GLM-4v support and meet vllm==0.6.2 | Overview
---
This PR support the [glm-4v-9b](https://github.com/THUDM/GLM-4) multimodal model while maintaining compatibility with `chatglm`.
This PR was inspired and reused some code here [#5358](https://github.com/vllm-project/vllm/pull/5358)
This PR is updated from [#8663](https://github.com/vllm-project/vllm/pu... | 2024-10-10T10:04:33Z | [Bug]: vllm deployment of GLM-4V reports KeyError: 'transformer.vision.transformer.layers.45.mlp.fc2.weight'
### Your current environment
```shell
Collecting environment information...
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubun... | GLM-4V is not supported yet. You can track its progress in #5358.
FYI: https://github.com/vllm-project/vllm/pull/5358
thanks | [
{
"body": "### Your current environment\r\n\r\n```shell\r\nCollecting environment information...\r\nPyTorch version: 2.3.0+cu121\r\nIs debug build: False\r\nCUDA used to build PyTorch: 12.1\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Ubuntu 22.04.3 LTS (x86_64)\r\nGCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 1... | cbc2ef55292b2af6ff742095c030e8425124c005 | {
"head_commit": "2719fac48cc83bc3fcf000a2be0077e3fdc6dde7",
"head_commit_message": "Add GLM-4v support and meet vllm==0.6.2",
"patch_to_review": "diff --git a/examples/offline_inference_vision_language.py b/examples/offline_inference_vision_language.py\nindex 5dd539c3d5ee..7361deac2ea2 100644\n--- a/examples/off... | [
{
"diff_hunk": "@@ -300,6 +300,20 @@ def run_mllama(question: str, modality: str):\n return llm, prompt, stop_token_ids\n \n \n+# GLM-4v\n+def run_glm4v(question):",
"line": null,
"original_line": 304,
"original_start_line": null,
"path": "examples/offline_inference_vision_language.py",
... | 0008b8f64a8edb4eae4e80f8449753f8840a3c1c | diff --git a/docs/source/models/supported_models.rst b/docs/source/models/supported_models.rst
index ec64a82de84d..3090e649976c 100644
--- a/docs/source/models/supported_models.rst
+++ b/docs/source/models/supported_models.rst
@@ -346,6 +346,12 @@ Text Generation
- :code:`adept/fuyu-8b` etc.
-
- ✅︎
+ *... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7746@85ee9ff | vllm-project/vllm | Python | 7,746 | [BugFix] Fix server crash on empty prompt | Fixes https://github.com/vllm-project/vllm/issues/7632
To reproduce, start the server with `python -m vllm.entrypoints.openai.api_server --model gpt2` and send an empty prompt:
```
$ curl http://localhost:8000/v1/completions -H "Content-Type: application/json" -d '{
"model": "gpt2",
"prompt": [... | 2024-08-21T17:56:35Z | [Bug]: assert num_new_tokens > 0 crashes entire worker instead of just failing single API call
### Your current environment
vllm docker 0.5.4
```
docker pull vllm/vllm-openai:latest
docker stop danube3_mig ; docker remove danube3_mig
docker run -d --restart=always \
--runtime=nvidia \
--gpus '"device... | To be clear, the bug is at least that the entire vllm engine is taken down by prompt='' | [
{
"body": "### Your current environment\r\n\r\nvllm docker 0.5.4\r\n\r\n```\r\ndocker pull vllm/vllm-openai:latest\r\ndocker stop danube3_mig ; docker remove danube3_mig\r\ndocker run -d --restart=always \\\r\n --runtime=nvidia \\\r\n --gpus '\"device=MIG-a6dbed35-9d05-58da-a0b5-23ae5bf8427e\"' \\\r\n ... | 15310b5101963818b76f1821e93887cb22f0aea6 | {
"head_commit": "85ee9ff94094eb318794736e57fb54397e656589",
"head_commit_message": "move test to another file due to conflicting fixtures\n\nSigned-off-by: Max de Bayser <mbayser@br.ibm.com>",
"patch_to_review": "diff --git a/tests/entrypoints/llm/test_generate.py b/tests/entrypoints/llm/test_generate.py\nindex ... | [
{
"diff_hunk": "@@ -0,0 +1,22 @@\n+# imports for guided decoding tests\n+import re\n+\n+import openai\n+import pytest\n+\n+from ...utils import RemoteOpenAIServer\n+\n+\n+@pytest.mark.asyncio\n+async def test_empty_prompt():\n+ model_name = \"gpt2\"\n+ server_args = [\"--disable-frontend-multiprocessing\"... | 68610cbe870be02cd640fbaaf5df83c4b658bb54 | diff --git a/tests/entrypoints/llm/test_prompt_validation.py b/tests/entrypoints/llm/test_prompt_validation.py
new file mode 100644
index 000000000000..565dfa01346c
--- /dev/null
+++ b/tests/entrypoints/llm/test_prompt_validation.py
@@ -0,0 +1,9 @@
+import pytest
+
+from vllm import LLM
+
+
+def test_empty_prompt():
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7710@4f278b7 | vllm-project/vllm | Python | 7,710 | [Model] Fix Phi-3.5-vision-instruct 'num_crops' issue | This PR changes phi3v to load `num_crops` config from image processor config.
FIX #7718
**BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE**
---
<details>
<!-- inside this <details> section, markdown rendering does not work, so we use raw html here. -->
<summary><b> PR ... | 2024-08-20T23:19:38Z | [Bug]: Error loading microsoft/Phi-3.5-vision-instruct
### Your current environment
vllm version: `Version: 0.5.4`
### 🐛 Describe the bug
Repro command:
```
vllm serve microsoft/Phi-3.5-vision-instruct --trust-remote-code --max-model-len 4096
```
Error:
```
vllm serve microsoft/Phi-3.5-vision-instruct --tru... | Can you check out #7710 and see if it fixes your issue? | [
{
"body": "### Your current environment\n\nvllm version: `Version: 0.5.4`\n\n### 🐛 Describe the bug\n\nRepro command:\r\n```\r\nvllm serve microsoft/Phi-3.5-vision-instruct --trust-remote-code --max-model-len 4096\r\n```\r\n\r\nError:\r\n```\r\nvllm serve microsoft/Phi-3.5-vision-instruct --trust-remote-code -... | 53328d7536b3e8ea4863e351b09e4284f5601cae | {
"head_commit": "4f278b7e28aeae55c3a38830e0bb4e0ba8ba8007",
"head_commit_message": "Address comments",
"patch_to_review": "diff --git a/docs/source/models/supported_models.rst b/docs/source/models/supported_models.rst\nindex c761d1b32cd..286d8e15bfb 100644\n--- a/docs/source/models/supported_models.rst\n+++ b/do... | [
{
"diff_hunk": "@@ -97,6 +99,14 @@ def get_config(\n return config\n \n \n+def get_hf_image_processor_config(\n+ model: Union[str, Path],\n+ revision: Optional[str] = None,\n+ **kwargs,\n+) -> Dict:",
"line": null,
"original_line": 106,
"original_start_line": null,
"path": "vllm/tra... | 17ccce8c568c2b1d7349fbaec727ceff89df4d84 | diff --git a/docs/source/models/supported_models.rst b/docs/source/models/supported_models.rst
index c761d1b32cd9..356ebf9f6bee 100644
--- a/docs/source/models/supported_models.rst
+++ b/docs/source/models/supported_models.rst
@@ -225,9 +225,9 @@ Multimodal Language Models
- :code:`google/paligemma-3b-pt-224`, :co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7453@a8e0511 | vllm-project/vllm | Python | 7,453 | [Feature]: Add OpenAI server prompt_logprobs support #6508 | This commit adds a prompt_logprobs option in the extra body field of the chat completions API. When set to true, it will return the log probabilities of the decoded input tokens.
This option was not included in the streaming API. This decision was made since streaming is meant for real time feedback with reduced lat... | 2024-08-13T01:41:59Z | [Feature]: Add OpenAI server `prompt_logprobs` support
### 🚀 The feature, motivation and pitch
As noted in documentation OpenAI API don't support outputing only one token
But it's a very strong advantage over commertial models
Been able to get logits for prompt tokens
### Alternatives
_No response_
### Additiona... | Hey I'm doing the same thing, actually, you can try `echo=True` `logprobs=1` and this should return the prompt logprobabilities. **You have to disable prompt caching**. You may have to use `max_tokens=1` as well. Let me know if it works, and what parameters you use in the end.
@gabrielhuang Thanks, it's working
With v... | [
{
"body": "### 🚀 The feature, motivation and pitch\n\nAs noted in documentation OpenAI API don't support outputing only one token\r\nBut it's a very strong advantage over commertial models\r\nBeen able to get logits for prompt tokens\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\n_No respons... | 21313e09e3f9448817016290da20d0db1adf3664 | {
"head_commit": "a8e0511cde889381cb481171c67829162ef0ef38",
"head_commit_message": "[Feature]: Add OpenAI server prompt_logprobs support #6508\n\nThis commit adds a prompt_logprobs option in the extra body field of the\nchat completions API. When set to a value higher than 0, the response\nwill return the log prob... | [
{
"diff_hunk": "@@ -506,7 +516,7 @@ async def chat_completion_full_generator(\n model=model_name,\n choices=choices,\n usage=usage,\n- )\n+ prompt_logprobs=final_res.prompt_logprobs)",
"line": null,
"original_line": 519,
"original_start_line": nu... | 6fa0b168925aa080c41bcffe6fc3629606465138 | diff --git a/tests/entrypoints/openai/test_completion.py b/tests/entrypoints/openai/test_completion.py
index 05f667231738..4d0c6d73518d 100644
--- a/tests/entrypoints/openai/test_completion.py
+++ b/tests/entrypoints/openai/test_completion.py
@@ -3,7 +3,7 @@
import re
import shutil
from tempfile import TemporaryDire... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
vllm-project__vllm-7446@986a0e9 | vllm-project/vllm | Python | 7,446 | [Frontend][Core] Add plumbing to support audio language models | This adds infrastructure to support multi-modal audio language models.
- `MultiModalDataBuiltins` defines audio as a tuple of a `numpy.ndarray` and the sample rate. (`librosa` is used to parse the audio.)
- `DEFAULT_PLUGINS` now includes an `AudioPlugin`
- The OpenAI API frontend tentatively supports `"audio_url"`... | 2024-08-12T23:34:21Z | [Feature]: support voice llm like cosyvoice
### 🚀 The feature, motivation and pitch
As we can see that vllm already support many vision language models. Do we have a plan to support voice models like cosyVoice?
### Alternatives
_No response_
### Additional context
_No response_ | [
{
"body": "### 🚀 The feature, motivation and pitch\n\nAs we can see that vllm already support many vision language models. Do we have a plan to support voice models like cosyVoice?\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\n_No response_",
"number": 7335,
"title": "[Feature]: sup... | 774cd1d3bf7890c6abae6c7ace798c4a376b2b20 | {
"head_commit": "986a0e9c2bde95da88144c558dca3b3e28552d93",
"head_commit_message": "Fix lint",
"patch_to_review": "diff --git a/docs/source/models/enabling_multimodal_inputs.rst b/docs/source/models/enabling_multimodal_inputs.rst\nindex 20be920b5f6..dc76f921d5b 100644\n--- a/docs/source/models/enabling_multimoda... | [
{
"diff_hunk": "@@ -150,7 +150,7 @@ A full code example can be found in `examples/openai_vision_api_client.py <https\n \n .. code-block:: shell\n \n- export VLLM_IMAGE_FETCH_TIMEOUT=<timeout>\n+ export VLLM_MULTIMODAL_FETCH_TIMEOUT=<timeout>",
"line": null,
"original_line": 153,
"o... | 4eb851da054d7fc2dc62c8ce7baa2c5eb30b6e97 | diff --git a/docs/source/conf.py b/docs/source/conf.py
index ded6742ea2e5..d24ed0320782 100644
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -112,6 +112,8 @@ def setup(app):
"tensorizer",
"pynvml",
"outlines",
+ "librosa",
+ "soundfile",
"gguf",
"lark",
]
diff --git a/docs/sourc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
vllm-project__vllm-7562@5b734fb | vllm-project/vllm | Python | 7,562 | [Bugfix] neuron: enable tensor parallelism | FILL IN THE PR DESCRIPTION HERE
FIX #6269
Following #7175, this enables tensor parallelism on neuron with vLLM > 0.5.0. The `block-size` choices are also reverted back to the previous values and vLLM will take the `max-model-len` as the `block-size` on neuron devices.
| 2024-08-15T17:29:40Z | f[Bug]: TypeError: Can't instantiate abstract class NeuronWorker with abstract method execute_worker
### Your current environment
```text
The output of `python collect_env.py`
```
Collecting environment information...
WARNING 07-09 19:46:51 _custom_ops.py:14] Failed to import from vllm._C with ModuleNotFoundError(... | I still get this error with the latest https://github.com/vllm-project/vllm/pull/6313 merge.
```
Traceback (most recent call last):
File "/home/ubuntu/vllm/simple_test.py", line 11, in <module>
llm = LLM(model="facebook/opt-125m",device="neuron")
File "/home/ubuntu/vllm/vllm/entrypoints/llm.py", line 150... | [
{
"body": "### Your current environment\n\n```text\r\nThe output of `python collect_env.py`\r\n```\r\nCollecting environment information...\r\nWARNING 07-09 19:46:51 _custom_ops.py:14] Failed to import from vllm._C with ModuleNotFoundError(\"No module named 'vllm._C'\")\r\nPyTorch version: 2.1.2+cu121\r\nIs deb... | 2deb029d115dadd012ce5ea70487a207cb025493 | {
"head_commit": "5b734fb7edfdf3f8a836a3ddee81eba506230fdd",
"head_commit_message": "block_size should equal max_model_len on neuron, not max_num_seqs\n\nSigned-off-by: omrishiv <327609+omrishiv@users.noreply.github.com>",
"patch_to_review": "diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py\nindex... | [
{
"diff_hunk": "@@ -40,6 +49,9 @@ def __init__(\n self.is_driver_worker = True\n \n def init_device(self) -> None:\n+ os.environ[\"PJRT_DEVICE\"] = \"NEURON\"",
"line": null,
"original_line": 52,
"original_start_line": null,
"path": "vllm/worker/neuron_worker.py",
"start_l... | 0ed98d74c14820868acb35f8467cd3f206872dbc | diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py
index 987c1be3d5ad..d759ce04d75e 100644
--- a/vllm/engine/arg_utils.py
+++ b/vllm/engine/arg_utils.py
@@ -317,9 +317,10 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
parser.add_argument('--block-size',
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-6954@68ada2d | vllm-project/vllm | Python | 6,954 | [Bugfix] Set SamplingParams.max_tokens for OpenAI requests if not provided by user | FIX #6707
vllm/engine/output_processor/multi_step.py requires `SamplingParams.max_tokens` to be set.
AFAICS, all the requests without `max_tokens` (the default) will fail if spec_decoding is turned on now.
The bug is introduced in #4028 in which `_validate_prompt_and_tokenize()` is [moved](https://github.com/... | 2024-07-30T17:36:02Z | [Bug]: Engine crashes when max_tokens undefined
### Your current environment
```text
PyTorch version: 2.3.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not c... | Add "max_tokens":xxx can solve this problem temporarily | [
{
"body": "### Your current environment\n\n```text\r\nPyTorch version: 2.3.1+cu121\r\nIs debug build: False\r\nCUDA used to build PyTorch: 12.1\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Ubuntu 20.04.6 LTS (x86_64)\r\nGCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0\r\nClang version: Could not collect\r\nC... | 6ca8031e7130f810ce7248286754a60044f65c73 | {
"head_commit": "68ada2df94c4c832c43cf87d76dad6bc990c2957",
"head_commit_message": "cleanup",
"patch_to_review": "diff --git a/tests/entrypoints/openai/test_serving_chat.py b/tests/entrypoints/openai/test_serving_chat.py\nindex 464465494b7..168ba7ba888 100644\n--- a/tests/entrypoints/openai/test_serving_chat.py\... | [
{
"diff_hunk": "@@ -134,28 +132,23 @@ async def create_chat_completion(\n \n request_id = f\"chat-{random_uuid()}\"\n try:\n- sampling_params = request.to_sampling_params(tokenizer)\n- decoding_config = await self.engine.get_decoding_config()\n- guided_decoding_b... | 5069fb70d675dd93ecc487bd7101fb77d16c16c4 | diff --git a/tests/entrypoints/openai/test_serving_chat.py b/tests/entrypoints/openai/test_serving_chat.py
index 464465494b71..168ba7ba888e 100644
--- a/tests/entrypoints/openai/test_serving_chat.py
+++ b/tests/entrypoints/openai/test_serving_chat.py
@@ -1,7 +1,12 @@
import asyncio
+from contextlib import suppress
fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7129@e78542f | vllm-project/vllm | Python | 7,129 | [Bugfix] Specify device when loading LoRA and embedding tensors | [Bugfix] Assign device when loading LoRA modules from file
Fixes [#3374](https://github.com/vllm-project/vllm/issues/3374). Note — existing PR to address this issue got stale; so bumping with some light updates.
This PR addresses the issue of CUDA device mismatch when loading LoRA modules from files. It fixes the... | 2024-08-04T20:00:06Z | lora load failed
```
Exception in callback functools.partial(<function _raise_exception_on_finish at 0x7f9123d01870>, request_tracker=<vllm.engine.async_llm_engine.RequestTracker object at 0x7f91197ea980>)
handle: <Handle functools.partial(<function _raise_exception_on_finish at 0x7f9123d01870>, request_tracker=<vllm... | Similar error (Jul 29) here:
```shell
File [/usr/local/lib/python3.10/dist-packages/vllm/lora/worker_manager.py:195](https://566mynctadei05-8888.proxy.runpod.net/lab/tree/workspace/graph-llm/usr/local/lib/python3.10/dist-packages/vllm/lora/worker_manager.py#line=194), in LRUCacheWorkerLoRAManager._apply_adapters(sel... | [
{
"body": "```\r\nException in callback functools.partial(<function _raise_exception_on_finish at 0x7f9123d01870>, request_tracker=<vllm.engine.async_llm_engine.RequestTracker object at 0x7f91197ea980>)\r\nhandle: <Handle functools.partial(<function _raise_exception_on_finish at 0x7f9123d01870>, request_tracker... | 16a1cc9bb2b4bba82d78f329e5a89b44a5523ac8 | {
"head_commit": "e78542f97feeb95f3b0643338c05fe8455c13def",
"head_commit_message": "fix: Specify device when loading LoRA and embedding tensors\n\n- Add map_location=\"device\" when loading LoRA tensors from .bin files\n- Add map_location=\"device\" when loading new embeddings from .bin files",
"patch_to_review"... | [
{
"diff_hunk": "@@ -248,7 +248,7 @@ def from_local_checkpoint(\n f\" target modules in {expected_lora_modules}\"\n f\" but received {unexpected_modules}.\"\n f\" Please verify that the loaded LoRA module is correct\")\n- tensors = torch.load... | 274c3a23c3d46b1d246c5dc4ab29d71f8f9ebbcd | diff --git a/vllm/lora/models.py b/vllm/lora/models.py
index 017a1002bb9a..279477562a94 100644
--- a/vllm/lora/models.py
+++ b/vllm/lora/models.py
@@ -248,7 +248,7 @@ def from_local_checkpoint(
f" target modules in {expected_lora_modules}"
f" but received {unexpected_modules}."... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7217@a296788 | vllm-project/vllm | Python | 7,217 | [BugFix] Fix frontend multiprocessing hang | Now that the OpenAI server has [optional multiprocessing](https://github.com/vllm-project/vllm/pull/6883), there is a hang that can happen if the backend dies during initialization and never replies to the `IS_SERVER_READY` message sent in `async_engine_client.setup()` .
This PR add an optional timeout to `_send_on... | 2024-08-06T19:50:37Z | [Bug]: With frontend multiprocessing the openai server hangs if there is an initialization error
### Your current environment
The environment is not relevant for this issue.
### 🐛 Describe the bug
With frontend multiprocessing, if there is an error in the initialization if the LLMEngine, the server prints the sta... | This happens with version `1f26efb`. | [
{
"body": "### Your current environment\n\nThe environment is not relevant for this issue.\r\n\n\n### 🐛 Describe the bug\n\nWith frontend multiprocessing, if there is an error in the initialization if the LLMEngine, the server prints the stack trace and then hangs and has to be killed. The expected behavior is... | 564985729abc267af281de11f737cfb29b5c0abb | {
"head_commit": "a296788eb3f9de0d9e0507f399366e4861a5f118",
"head_commit_message": "Merge branch 'vllm-project:main' into fix_multiprocess_hang",
"patch_to_review": "diff --git a/vllm/entrypoints/openai/api_server.py b/vllm/entrypoints/openai/api_server.py\nindex 88f0bd4ee4d..9d69002edd1 100644\n--- a/vllm/entry... | [
{
"diff_hunk": "@@ -85,14 +88,19 @@ async def _send_get_data_rpc_request(self, request: RPCUtilityRequest,\n \n return data\n \n- async def _send_one_way_rpc_request(self, request: RPC_REQUEST_TYPE,\n- error_message: str):\n+ async def _send_one_way_rpc_reque... | a2f26392fa73e9e45a84c2ceefb671d9a4ea4d74 | diff --git a/tests/entrypoints/openai/test_mp_crash.py b/tests/entrypoints/openai/test_mp_crash.py
new file mode 100644
index 000000000000..7dc595a7be35
--- /dev/null
+++ b/tests/entrypoints/openai/test_mp_crash.py
@@ -0,0 +1,35 @@
+from typing import Any
+
+import pytest
+
+from vllm.engine.async_llm_engine import Asy... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7153@7c45a52 | vllm-project/vllm | Python | 7,153 | [Model] Support SigLIP encoder and alternative decoders for LLaVA models | Based on #7067, this PR partially addresses #7143 by enabling SigLIP to be used in LLaVA models. The same code also enables them to load other LLM decoders.
This PR also fixes two hidden bugs in the calculation for the number of placeholder tokens:
- For CLIP encoder, the feature size should be increased by 1 becau... | 2024-08-05T09:11:39Z | [Bug]: The deployment function requires a divisible relationship, but the model structure does not meet this requirement. What should I do?
### 🐛 Describe the bug
def get_siglip_patch_grid_length(*, image_size: int, patch_size: int) -> int:
assert image_size % patch_size == 0
return image_size // patc... | Which HF repo are you using?
TIGER-Lab/Mantis-8B-siglip-llama3
Perhaps I should write a new Python script to support this model.
It should only take a small modification since the architecture is the same as `LlavaForConditionalGeneration`. We just need to support loading the SigLIP model inside vLLM.
> It should only ... | [
{
"body": "\r\n\r\n### 🐛 Describe the bug\r\n\r\ndef get_siglip_patch_grid_length(*, image_size: int, patch_size: int) -> int:\r\n assert image_size % patch_size == 0\r\n return image_size // patch_size\r\n \r\n<html>\r\n<body>\r\n<!--StartFragment-->\r\n\"vision_config\": {\r\n--\r\n | \"hidden_act\... | 9118217f58c39040aa935b7c85250c7364ffa72d | {
"head_commit": "7c45a523cc43e99465b6f22f99a8f4e1efab27c0",
"head_commit_message": "Auto-detect image ID to be robust against switching test models; add test code for Mantis model",
"patch_to_review": "diff --git a/requirements-test.txt b/requirements-test.txt\nindex 5f3fd15c7ee..f9f6e8a84f8 100644\n--- a/requir... | [
{
"diff_hunk": "@@ -19,6 +19,7 @@ ray\n sentence-transformers # required for embedding\n compressed-tensors==0.4.0 # required for compressed-tensors\n timm # required for internvl test\n+git+https://github.com/TIGER-AI-Lab/Mantis.git # required for llava(mantis) test",
"line": null,
"original_line": 22,... | 5a9c179736e5065980f0f3d789e8944fe71da3bc | diff --git a/requirements-test.txt b/requirements-test.txt
index 5f3fd15c7ee5..62d6cc49eade 100644
--- a/requirements-test.txt
+++ b/requirements-test.txt
@@ -20,6 +20,9 @@ sentence-transformers # required for embedding
compressed-tensors==0.4.0 # required for compressed-tensors
timm # required for internvl test
+#... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-7208@47bf473 | vllm-project/vllm | Python | 7,208 | [Core/Bugfix] Add FP8 K/V Scale and dtype conversion for prefix/prefill Triton Kernel | Fix the FP8 Triton kernel issue. Should enable FP8 KV Cache to be used with:
1. chunked prefill
2. prefix caching
FIX https://github.com/vllm-project/vllm/issues/4381 https://github.com/vllm-project/vllm/issues/3880 https://github.com/vllm-project/vllm/issues/3156 https://github.com/vllm-project/vllm/issues/3880
... | 2024-08-06T15:06:56Z | [Bug]: Chunked prefill doesn't seem to work when --kv-cache-dtype fp8
### Your current environment
H100 (but I believe it happens in any machine)
### 🐛 Describe the bug
```
--enable-chunked-prefill --num-max-batched-tokens 2048 --kv-cache-dtype "fp8"
```
Seems to be broken with some type incompatibility ... | Yep, can confirm. I think it's undocumented that using both together is not supported? I get this error on a dual 4090 machine:
```
2024-06-03T14:15:05.332567820Z raise CompilationError(fn.src, node, repr(e)) from e
2024-06-03T14:15:05.332573240Z triton.compiler.errors.CompilationError: at 114:24: off_v =... | [
{
"body": "### Your current environment\r\n\r\nH100 (but I believe it happens in any machine)\r\n\r\n### 🐛 Describe the bug\r\n\r\n```\r\n--enable-chunked-prefill --num-max-batched-tokens 2048 --kv-cache-dtype \"fp8\"\r\n```\r\n\r\nSeems to be broken with some type incompatibility error. \r\n\r\n",
"number... | 24154f8618aa5da695b18cbbd71704f59803ec6b | {
"head_commit": "47bf473676ae40b44cec49d5070bbc7bf3ca92ab",
"head_commit_message": "fix dtype conversion only when mixed-precision dot not supported",
"patch_to_review": "diff --git a/docs/source/quantization/fp8_e4m3_kvcache.rst b/docs/source/quantization/fp8_e4m3_kvcache.rst\nindex fd71c00b7bf..cc52d8f40af 100... | [
{
"diff_hunk": "@@ -117,10 +119,19 @@ def _fwd_kernel(\n cur_kv_head * stride_v_cache_h +\n offs_d[None, :] * stride_v_cache_d +\n (start_n + offs_n[:, None]) % block_size * stride_v_cache_bl)\n- k = tl.load(K_cache + off_k,\n- ma... | 39e54cbc597992caa1e72890f0b626fa6ea1556b | diff --git a/docs/source/quantization/fp8_e4m3_kvcache.rst b/docs/source/quantization/fp8_e4m3_kvcache.rst
index fd71c00b7bf8..cc52d8f40af8 100644
--- a/docs/source/quantization/fp8_e4m3_kvcache.rst
+++ b/docs/source/quantization/fp8_e4m3_kvcache.rst
@@ -45,5 +45,3 @@ Here is an example of how to enable this feature:
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-6951@82d6887 | vllm-project/vllm | Python | 6,951 | [CI/Build] Update torch to 2.4 | This PR updates pytorch to version 2.4. All dependencies that depend on pytorch have also been updated.
| 2024-07-30T15:04:56Z | [Feature]: when will support torch2.4 use it out of box?
### 🚀 The feature, motivation and pitch
[Feature]: when will support torch2.4 use it out of box?
### Alternatives
[Feature]: when will support torch2.4 use it out of box?
### Additional context
_No response_ | We are working on update soon. Currently we require torch 2.4 wheels to be released for our xformers, flashinfer, and flash-attn dependencies. I believe flashinfer is the only hold-up at the moment. | [
{
"body": "### 🚀 The feature, motivation and pitch\n\n[Feature]: when will support torch2.4 use it out of box?\n\n### Alternatives\n\n[Feature]: when will support torch2.4 use it out of box?\n\n### Additional context\n\n_No response_",
"number": 6944,
"title": "[Feature]: when will support torch2.4 use... | c8a7e93273ff4338d6f89f8a63ff16426ac240b8 | {
"head_commit": "82d68874437c42a315cf1a54f295dbd43fc4eaa1",
"head_commit_message": "update torch to 2.4",
"patch_to_review": "diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml\nindex be8807df0b0..166e94cf08c 100644\n--- a/.buildkite/test-pipeline.yaml\n+++ b/.buildkite/test-pipeline.yaml... | [
{
"diff_hunk": "@@ -3,5 +3,5 @@ cmake>=3.21\n ninja\r\n packaging\r\n setuptools>=49.4.0\r\n-torch==2.3.1\r\n+torch==2.4\r",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "requirements-build.txt",
"start_line": null,
"text": "@user1:\nCan you please set this to 2... | 90a47114c2fae1af63662294ffd72847b6c48d42 | diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml
index 9ec9ec12bfcf..573c3740f0bb 100644
--- a/.buildkite/test-pipeline.yaml
+++ b/.buildkite/test-pipeline.yaml
@@ -44,7 +44,7 @@ steps:
fast_check: true
commands:
# This flashinfer installation will fail on AMD ROCm, so it is set as op... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
vllm-project__vllm-7445@450ae2a | vllm-project/vllm | Python | 7,445 | support bitsandbytes 8-bit and FP4 quantized models | This PR does the following:
1. support quantized bitsandbytes 8-bit models, such as meta-llama/Llama-Guard-3-8B-INT8
2. support quantized bitsandbytes 4-bit FP4 models, such as PrunaAI/Einstein-v6.1-Llama3-8B-bnb-4bit-smashed
3. Add comments about enforcing eager-mode in bnb quantization, as I identified it is a bug... | 2024-08-12T23:23:37Z | [Bug]: Unable to run meta-llama/Llama-Guard-3-8B-INT8
### Your current environment
Latest Docker image, RTX 4090
### 🐛 Describe the bug
```
docker run --gpus all vllm/vllm-openai:latest --model meta-llama/Llama-Guard-3-8B-INT8
...
[rank0]: raise ValueError(f"Cannot find any of {keys} in the model's "
[ran... | @thesues @chenqianfzh It looks like this is an 8bit BNB model. Would it be easy to add support for these checkpoints as well?
> @thesues @chenqianfzh It looks like this is an 8bit BNB model. Would it be easy to add support for these checkpoints as well?
It won't be difficult. I will work on it with higher priority.
... | [
{
"body": "### Your current environment\n\nLatest Docker image, RTX 4090\r\n\n\n### 🐛 Describe the bug\n\n```\r\ndocker run --gpus all vllm/vllm-openai:latest --model meta-llama/Llama-Guard-3-8B-INT8\r\n...\r\n[rank0]: raise ValueError(f\"Cannot find any of {keys} in the model's \"\r\n[rank0]: ValueError: ... | 029c71de11bc3bcf84a1b3cf9d91e79ab6949799 | {
"head_commit": "450ae2ae997eb338459b6fdcc247878a606cc860",
"head_commit_message": "support bitsandbytes 8-bit and FP4 quantized models",
"patch_to_review": "diff --git a/tests/quantization/test_bitsandbytes.py b/tests/quantization/test_bitsandbytes.py\nindex b760e9ccb6b..f15db983744 100644\n--- a/tests/quantiza... | [
{
"diff_hunk": "@@ -5,82 +5,108 @@\n import pytest\n import torch\n \n+from tests.conftest import VllmRunner\n from tests.quantization.utils import is_quant_method_supported\n from vllm import SamplingParams\n \n-models_to_test = [\n+models_4bit_to_test = [\n ('huggyllama/llama-7b', 'quantize model inflight... | 368ce90363ea9c64bcb5d5e9fa8d9f70443eefb1 | diff --git a/tests/conftest.py b/tests/conftest.py
index ae362b228d9d..c56a3059a17e 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -205,8 +205,14 @@ class HfRunner:
def wrap_device(self, input: _T) -> _T:
if not is_cpu():
+ # Check if the input is already on the GPU
+ if... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-6942@7fdb13d | vllm-project/vllm | Python | 6,942 | [Model] SiglipVisionModel ported from transformers | This PR implemented SiglipVisionModel for VLMs.
- Some of the pre-trained SiglipVisionModel cannot use vLLM's Attention layer.
Therefore, I implemented alternative attention layers if vLLM's one is impossible.
- I tried vllm_flash_attn backend which doesn't work properly with CUDA Error.
Thus, only the basi... | 2024-07-30T11:26:22Z | [Feature]: SiglipVisionModel Support
### 🚀 The feature, motivation and pitch
Paligemma uses SiglipVisionModel from the transformers library, which can be ported to the vLLM.
As CLIPVisionModel is supported for VLMs, the SiglipVisionModel can be supported too.
### Alternatives
_No response_
### Additional context
... | Great suggestion! This is already on our roadmap (https://github.com/vllm-project/vllm/issues/4194), we'll get to it eventually! | [
{
"body": "### 🚀 The feature, motivation and pitch\n\nPaligemma uses SiglipVisionModel from the transformers library, which can be ported to the vLLM.\r\nAs CLIPVisionModel is supported for VLMs, the SiglipVisionModel can be supported too.\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\n_No r... | cc08fc7225616aeb6709a2e75e5ac47ace124985 | {
"head_commit": "7fdb13d0a5a2e2b3d4c84d70e84ed91384275de3",
"head_commit_message": "fix: remove unnecessary comments",
"patch_to_review": "diff --git a/vllm/model_executor/models/paligemma.py b/vllm/model_executor/models/paligemma.py\nindex 8a2bacbd96b..8553c3a504e 100644\n--- a/vllm/model_executor/models/palige... | [
{
"diff_hunk": "@@ -0,0 +1,780 @@\n+\"\"\"Implementation of SiglipVisionModel intended to be only used\n+within a vision language model.\"\"\"\n+\n+import math\n+from typing import Iterable, List, Optional, Tuple\n+\n+import torch\n+from PIL import Image\n+from torch import nn\n+from transformers import SiglipC... | 54faf5d36e2a8da7c270114d8ca5ba781cdf6481 | diff --git a/examples/offline_inference_vision_language.py b/examples/offline_inference_vision_language.py
index 846246a2062a..ce9dc9e457c0 100644
--- a/examples/offline_inference_vision_language.py
+++ b/examples/offline_inference_vision_language.py
@@ -65,7 +65,8 @@ def run_phi3v(question):
# PaliGemma
def run_pali... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Textualize__textual-4964@9e4f4db | Textualize/textual | Python | 4,964 | fix object leak | Fixes https://github.com/Textualize/textual/issues/4959
This turned out to be quite a rabbit hole. I fixed a class of problems where something was holding on to references to DOM nodes, and preventing garbage collection.
One culprit was `count_parameters`. The `@lru_cache` was holding on to a reference chain. I r... | 2024-09-03T16:24:57Z | `clear_panes` and memory leak
Hello! Thanks for this wonderful framework, having a blast with it.
I seem to have a memory leak with my app. I suspect the problem to be caused by my usage of the `TabbedContent`'s method `clear_panes()`. I have a `TabbedContent` which i want to refresh every time a user provides a file ... | Thank you for your issue. Give us a little time to review it.
PS. You might want to check the [FAQ](https://textual.textualize.io/FAQ/) if you haven't done so already.
This is an automated reply, generated by [FAQtory](https://github.com/willmcgugan/faqtory)
Will take a look later. In the meantime you could do `del s... | [
{
"body": "Hello! Thanks for this wonderful framework, having a blast with it.\r\nI seem to have a memory leak with my app. I suspect the problem to be caused by my usage of the `TabbedContent`'s method `clear_panes()`. I have a `TabbedContent` which i want to refresh every time a user provides a file input. Th... | ab4fc4b4890c2417cee1085c02a70e1af47cab61 | {
"head_commit": "9e4f4db5dc9db60b10ea222a9288e3f12c3145d3",
"head_commit_message": "docstring",
"patch_to_review": "diff --git a/poetry.lock b/poetry.lock\nindex b840e36ff8..4294a0ad21 100644\n--- a/poetry.lock\n+++ b/poetry.lock\n@@ -1,99 +1,114 @@\n-# This file is automatically @generated by Poetry 1.8.3 and s... | [
{
"diff_hunk": "@@ -50,4 +50,7 @@ async def on_mount(self) -> None:\n \"MyScreen#main\",\n ]\n \n+ print(unmount_ids)\n+ print(expected)",
"line": null,
"original_line": 54,
"original_start_line": 53,
"path": "tests/test_unmount.py",
"start_line": null,
"text": "@user1:... | 8ad78c74dde897f2f5e51e542910243d606ed9dd | diff --git a/poetry.lock b/poetry.lock
index b840e36ff8..4294a0ad21 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -1,99 +1,114 @@
-# This file is automatically @generated by Poetry 1.8.3 and should not be changed by hand.
+# This file is automatically @generated by Poetry 1.8.2 and should not be changed by hand.
[[p... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Textualize__textual-5022@2e612e8 | Textualize/textual | Python | 5,022 | fix(app): fix `inline_no_clear` | Fixes #5019.
I'm afraid I don't fully understand commit 8c01ef7, but this change seems to fix the broken `inline_no_clear` without any regression related to issue #4882 which I believe this commit intended to fix.
- [ ] Docstrings on all new or modified functions / classes
- [ ] Updated documentation
- [x] Up... | 2024-09-18T22:03:56Z | `inline_no_clear` broken in v0.77.0
It looks like the `inline_no_clear` option was broken in v0.77.0, from a quick git bisect the culprit seems to be commit 8c01ef7.
If you run the app below where `inline_no_clear=True`, the app output is cleared on exit:
```python
from textual.app import App, ComposeResult
fro... | Thank you for your issue. Give us a little time to review it.
PS. You might want to check the [FAQ](https://textual.textualize.io/FAQ/) if you haven't done so already.
This is an automated reply, generated by [FAQtory](https://github.com/willmcgugan/faqtory) | [
{
"body": "It looks like the `inline_no_clear` option was broken in v0.77.0, from a quick git bisect the culprit seems to be commit 8c01ef7.\r\n\r\nIf you run the app below where `inline_no_clear=True`, the app output is cleared on exit:\r\n\r\n```python\r\nfrom textual.app import App, ComposeResult\r\nfrom tex... | 8b8c10d0f1bd32a60ee74cbe00dc32a18bdb7a7f | {
"head_commit": "2e612e8c24de395a6152bfbec46b96e328701859",
"head_commit_message": "update changelog",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex ef0b9537c5..882d5c1672 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](htt... | [
{
"diff_hunk": "@@ -2909,10 +2909,14 @@ async def invoke_ready_callback() -> None:\n self._driver.write(\n Control.move(-cursor_x, -cursor_y + 1).segment.text\n )\n- if inline_no_clear and not not ... | 23844b1221715bafb1681a5ed298636f4449fa86 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb52627175..8a25970f27 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed flicker when setting `dark` reactive on startup https://github.com/Textualize/textual/pull/4989
- Fixed co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-6613@b06cd17 | vllm-project/vllm | Python | 6,613 | [Core][VLM] Support image embeddings as input | This PR adds the support for passing image embeddings as input so that they can be directly consumed by the language model.
Example usage
``` python
# Refer to the HuggingFace repo for the correct format to use
prompt = "USER: <image>\nWhat is the content of this image?\nASSISTANT:"
# Image embedding generat... | 2024-07-21T04:42:04Z | [Feature]: MultiModal LLM with vector API
### 🚀 The feature, motivation and pitch
Consider a scenario where a large model is deployed in the cloud, and the application is deployed on a computationally limited embedded device.
If we want to support multimodal dialogue interaction with vision and language, each requ... | Hey @qZhang88 thanks for the issue! Supporting image embeddings as inputs is indeed in our Q3 roadmap that you can check in #4194 | [
{
"body": "### 🚀 The feature, motivation and pitch\n\nConsider a scenario where a large model is deployed in the cloud, and the application is deployed on a computationally limited embedded device.\r\n\r\nIf we want to support multimodal dialogue interaction with vision and language, each request would send an... | 86ab567bae0698425095e28cce67e9a31a261b72 | {
"head_commit": "b06cd17cc79bf12e7a81713c24648957200f2a0d",
"head_commit_message": "revert",
"patch_to_review": "diff --git a/vllm/model_executor/models/fuyu.py b/vllm/model_executor/models/fuyu.py\nindex fdea8ee30ce6..66e4b6acb566 100644\n--- a/vllm/model_executor/models/fuyu.py\n+++ b/vllm/model_executor/model... | [
{
"diff_hunk": "@@ -187,7 +193,7 @@ def input_processor_for_llava_next(ctx: InputContext, llm_inputs: LLMInputs):\n input_width=width,\n )\n elif isinstance(image_data, torch.Tensor):\n- raise NotImplementedError(\"Embeddings input is not supported yet\")\n+ return",
"l... | 307d705d7ba6289d904195acf2fc38470f2f0f8b | diff --git a/docs/source/models/vlm.rst b/docs/source/models/vlm.rst
index a385605c9f8f..236e37b51d47 100644
--- a/docs/source/models/vlm.rst
+++ b/docs/source/models/vlm.rst
@@ -49,6 +49,17 @@ To pass an image to the model, note the following in :class:`vllm.inputs.PromptI
"multi_modal_data": {"image": image}... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
vllm-project__vllm-5654@46ef3ac | vllm-project/vllm | Python | 5,654 | [Bugfix] AsyncLLMEngine hangs with asyncio.run | This root cause is that https://github.com/vllm-project/vllm/blob/97b030005c7f5cde7c1b97c718a8841db7d6220b/vllm/engine/async_llm_engine.py#L509 triggered https://github.com/python/cpython/issues/86296
The Python bug is fixed in Python 3.12 but will not be backported.
We fix it by switching to `asyncio.timeout` fo... | 2024-06-18T19:22:28Z | [Usage]: Using AsyncLLMEngine with asyncio.run
### Your current environment
```text
Collecting environment information...
PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.... | Is there a reason why you cannot use the following?
```python
from vllm import LLM
model = LLM("mistralai/Mistral-7B-Instruct-v0.2")
model.generate([prompts])
```
The `LLM` class is intended for offline usage
The class you are using is not really intended to be used externally
That's my current backup solu... | [
{
"body": "### Your current environment\n\n```text\r\nCollecting environment information...\r\nPyTorch version: 2.1.2+cu121\r\nIs debug build: False\r\nCUDA used to build PyTorch: 12.1\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Ubuntu 22.04.4 LTS (x86_64)\r\nGCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0... | 8a173382c80d6730e1bbc81f932ac3721ab2cd9d | {
"head_commit": "46ef3ac227f44526db4ecfd0825a62b78ab5fd9e",
"head_commit_message": "Fix format",
"patch_to_review": "diff --git a/tests/async_engine/test_async_llm_engine.py b/tests/async_engine/test_async_llm_engine.py\nindex 10a46422887e..127dba2c48f0 100644\n--- a/tests/async_engine/test_async_llm_engine.py\n... | [
{
"diff_hunk": "@@ -29,6 +33,199 @@ class AsyncEngineDeadError(RuntimeError):\n pass\n \n \n+# From https://github.com/aio-libs/async-timeout/blob/master/async_timeout/__init__.py\n+# Licensed under the Apache License (Apache-2.0)\n+\n+if sys.version_info[:2] >= (3, 11):\n+ from asyncio import timeout as... | cd44c86afdbe4b70139c5654c941c8f9e75b3fbb | diff --git a/tests/async_engine/test_async_llm_engine.py b/tests/async_engine/test_async_llm_engine.py
index 10a46422887e..52d3394a96a1 100644
--- a/tests/async_engine/test_async_llm_engine.py
+++ b/tests/async_engine/test_async_llm_engine.py
@@ -2,8 +2,12 @@
from dataclasses import dataclass
import pytest
+import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-5669@2e27316 | vllm-project/vllm | Python | 5,669 | [distributed][misc] use fork by default for mp | fixes https://github.com/vllm-project/vllm/issues/5637
`fork` is not safe after we create cuda context. we should already avoid initializing cuda context before we create workers, so it should be fine to use `fork`, which can remove the necessity of `if __name__ = "__main__"` in user's code. | 2024-06-19T05:24:41Z | [Bug]: RuntimeError with tensor_parallel_size > 1 in Process Bootstrapping Phase
### Your current environment
```text
The output of `python collect_env.py`
Collecting environment information...
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
... | We are seeing the same error for LLM, LLMEngine, and AsyncLLMEngine.
Interestingly, we find wrapping everything in the python script within `if __name__ == '__main__':` can temporarily bypass the issue.
For `test.py` being the following
```
import os
from vllm import LLM, SamplingParams
prompts = ['<|begin_... | [
{
"body": "### Your current environment\r\n\r\n```text\r\nThe output of `python collect_env.py`\r\nCollecting environment information...\r\nPyTorch version: 2.3.0+cu121\r\nIs debug build: False\r\nCUDA used to build PyTorch: 12.1\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Rocky Linux release 8.9 (Green Obsid... | 3eea74889fe29534808bae41fca251e0e74c0962 | {
"head_commit": "2e2731637f1b25d7ca3086b7951a7e671e023f71",
"head_commit_message": "add comments",
"patch_to_review": "diff --git a/vllm/distributed/device_communicators/custom_all_reduce_utils.py b/vllm/distributed/device_communicators/custom_all_reduce_utils.py\nindex e0641a54c419..1bb8b8011def 100644\n--- a/v... | [
{
"diff_hunk": "@@ -198,7 +201,19 @@ def gpu_p2p_access_check(src: int, tgt: int) -> bool:\n ids = list(range(num_dev))\n # batch of all pairs of GPUs\n batch_src, batch_tgt = zip(*list(product(ids, ids)))\n- result = can_actually_p2p(batch_src, batch_tgt)\n+ # NOTE: we use... | 8348ef58bb55c57dafcc1e27c53bf98c44254ddd | diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml
index 5afe3730210e..67437ef7ea4b 100644
--- a/.buildkite/test-pipeline.yaml
+++ b/.buildkite/test-pipeline.yaml
@@ -37,6 +37,9 @@ steps:
working_dir: "/vllm-workspace/tests"
num_gpus: 2
commands:
+ # FIXIT: find out which code initiali... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-5473@b89b8e3 | vllm-project/vllm | Python | 5,473 | Add `cuda_device_count_stateless` | Calling `torch.cuda.device_count()` before `CUDA_VISIBLE_DEVICES` is set to the desired value (during worker init) will lead to issues, as the env var will be read and persisted in memory, meaning later modifications will not affect it. This PR adds a way to obtain the device count without that issue.
FIX #4969
FIX... | 2024-06-12T23:09:31Z | [Usage]: Is it possible to start 8 tp=1 LLMEngine on a 8-GPU machine?
### Your current environment
```text
Collecting environment information...
/home/corvo/.local/lib/python3.10/site-packages/transformers/utils/hub.py:124: FutureWarning: Using `TRANSFORMERS_CACHE` is deprecated and will be removed in v5 of Transfor... | Hi @sfc-gh-zhwang, I don't think this is easily doable in vLLM at the moment within a single python process. Possibly you could construct each model on GPU 0 and move each to GPU X before moving on.
I would recommend starting a separate process for each LLM and specifying `CUDA_VISIBLE_DEVICES` for each i.e. `CUDA_VI... | [
{
"body": "### Your current environment\n\n```text\r\nCollecting environment information...\r\n/home/corvo/.local/lib/python3.10/site-packages/transformers/utils/hub.py:124: FutureWarning: Using `TRANSFORMERS_CACHE` is deprecated and will be removed in v5 of Transformers. Use `HF_HOME` instead.\r\n warnings.wa... | 7d19de2e9c9a94658c36b55011b803a7991d0335 | {
"head_commit": "b89b8e366ea1b323e47311598d611c90d9a1f3af",
"head_commit_message": "Add `get_num_gpus_available_isolated`",
"patch_to_review": "diff --git a/tests/conftest.py b/tests/conftest.py\nindex e0680467d78b..554a11a74521 100644\n--- a/tests/conftest.py\n+++ b/tests/conftest.py\n@@ -21,7 +21,7 @@\n from v... | [
{
"diff_hunk": "@@ -537,15 +537,4 @@ def num_gpus_available():\n \"\"\"Get number of GPUs without initializing the CUDA context\n in current process.\"\"\"\n \n- try:\n- out = subprocess.run([\n- sys.executable, \"-c\",\n- \"import torch; print(torch.cuda.device_count())\... | bf43ffbe1ab6579302774ef81d74867b45597c48 | diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml
index 6b12d19ba611..6a2932db9f2d 100644
--- a/.buildkite/test-pipeline.yaml
+++ b/.buildkite/test-pipeline.yaml
@@ -48,6 +48,7 @@ steps:
- TEST_DIST_MODEL=meta-llama/Llama-2-7b-hf DISTRIBUTED_EXECUTOR_BACKEND=mp pytest -v -s distributed/test_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Textualize__textual-4874@67c5ad8 | Textualize/textual | Python | 4,874 | command palette dismiss logic | Fixes https://github.com/Textualize/textual/issues/4856
Screwed up the diff a bit here. Most of the updated snapshots are from a previous PR. | 2024-08-12T11:34:21Z | Command palette cancel
If you bring up the command palette (with `ctrl+\`) you have to press ESC twice to cancel it.
This makes sense when there is an auto-complete menu showing. But I think that a single ESC should dismiss the command palette in the following circumstances:
1. There is nothing in the input
2. T... | Could you please assign this issue to me? I want to work on it.
Sorry, we have a PR for this one. Will add more GFIs soon. | [
{
"body": "If you bring up the command palette (with `ctrl+\\`) you have to press ESC twice to cancel it.\r\n\r\nThis makes sense when there is an auto-complete menu showing. But I think that a single ESC should dismiss the command palette in the following circumstances:\r\n\r\n1. There is nothing in the input\... | ee5ff3ad166419599df5aff6748921e51bcfa96e | {
"head_commit": "67c5ad8cf0c531db78727a1b9eab6a638f40b703",
"head_commit_message": "snapshots",
"patch_to_review": "diff --git a/src/textual/command.py b/src/textual/command.py\nindex ad519deeb8..698cf22105 100644\n--- a/src/textual/command.py\n+++ b/src/textual/command.py\n@@ -575,6 +575,8 @@ def __init__(self)... | [
{
"diff_hunk": "@@ -735,6 +737,8 @@ def _show_no_matches() -> None:\n # discovered is a situation we don't need to highlight.\n self._list_visible = False\n \n+ self._hit_count = 0",
"line": null,
"original_line": 740,
"original_start_line": null,
"path": "... | 46bd07d6ea43c6151ee864e45fb1a738ce501a78 | diff --git a/src/textual/command.py b/src/textual/command.py
index ad519deeb8..44a03ca72c 100644
--- a/src/textual/command.py
+++ b/src/textual/command.py
@@ -575,6 +575,8 @@ def __init__(self) -> None:
"""Keeps track of if there are 'No matches found' message waiting to be displayed."""
self._provide... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
vllm-project__vllm-5402@6c3e723 | vllm-project/vllm | Python | 5,402 | [Bugfix] Add device assertion to TorchSDPA | Fix #5351
Added a device assertion to avoid using TorchSDPA with NVIDIA GPUs.
---
<details>
<!-- inside this <details> section, markdown rendering does not work, so we use raw html here. -->
<summary><b> PR Checklist (Click to Expand) </b></summary>
<p>Thank you for your contribution to vLLM! Before subm... | 2024-06-11T01:49:53Z | [Bug]: TorchSDPAMetadata is out of date
### Your current environment
alexr@roxy:~$ python collect_env.py
Collecting environment information...
PyTorch version: 2.0.0+cu117
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.1 LTS (x86_64)
GCC version: (Ubunt... | cc @bigPYJ1151 @jikunshang @zhouyuan
I'm surprised this is the case since this backend should be already be tested on CPU machine
@Reichenbachian If I understand correctly, you are using the TORCH_SDPA backend with NVIDIA GPUs. The backend is for Intel (x86) CPUs and should not be used with NVIDIA GPUs. (cc @simon-... | [
{
"body": "### Your current environment\n\nalexr@roxy:~$ python collect_env.py\r\nCollecting environment information...\r\nPyTorch version: 2.0.0+cu117\r\nIs debug build: False\r\nCUDA used to build PyTorch: 11.7\r\nROCM used to build PyTorch: N/A\r\n\r\nOS: Ubuntu 22.04.1 LTS (x86_64)\r\nGCC version: (Ubuntu 1... | 246598a6b1e22616630b7f1bf11bd9bcb31dc860 | {
"head_commit": "6c3e7239bfca6363fc812a7a8049028f06a1bf71",
"head_commit_message": "Add is_cpu assertion to TorchSDPA",
"patch_to_review": "diff --git a/vllm/attention/backends/torch_sdpa.py b/vllm/attention/backends/torch_sdpa.py\nindex 9b50adec5244..b3cd383abe7c 100644\n--- a/vllm/attention/backends/torch_sdpa... | [
{
"diff_hunk": "@@ -104,6 +105,9 @@ def __init__(\n ) -> None:\n assert blocksparse_params is None, ValueError(\n \"Torch SPDA does not support block-sparse attention.\")\n+ assert is_cpu(), RuntimeError(",
"line": null,
"original_line": 108,
"original_start_line": nul... | 9e58c42a02e4e2ce933a7da623fb342634c8620c | diff --git a/vllm/attention/selector.py b/vllm/attention/selector.py
index 7253483f9a0b..7ffaf030ae99 100644
--- a/vllm/attention/selector.py
+++ b/vllm/attention/selector.py
@@ -57,6 +57,9 @@ def get_attn_backend(
ROCmFlashAttentionBackend)
return ROCmFlashAttentionBackend
elif backend == _B... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Textualize__textual-4828@05dad38 | Textualize/textual | Python | 4,828 | mutate via data bind | Fixes https://github.com/Textualize/textual/issues/4825
- Ensures that watchers are called on data bound children, when calling `mutate_reactive`.
- Also enforces a new instance when data binding. Previously parent and child would end up sharing an instance, which would sure be a common source of errors. | 2024-08-01T09:32:18Z | mutate_reactive doesn't work with data binding and recompose=False
Note that in the following example recompose is set to False on both reactive members.
Adding an item to the list in on_mount is working as expected, and `watch_msg` is called. But changing an element in `on_button_pressed`, doesn't call `watch_msg`. A... | [
{
"body": "Note that in the following example recompose is set to False on both reactive members.\r\nAdding an item to the list in on_mount is working as expected, and `watch_msg` is called. But changing an element in `on_button_pressed`, doesn't call `watch_msg`. Apparently only changing the size of the list, ... | 13ec4c3298e3993b4a87159adece0116dfb603cb | {
"head_commit": "05dad38fcd8941fb8e7006e3a802394763a47c3f",
"head_commit_message": "better test",
"patch_to_review": "diff --git a/src/textual/dom.py b/src/textual/dom.py\nindex 55ce52afea..d3b4b83e9e 100644\n--- a/src/textual/dom.py\n+++ b/src/textual/dom.py\n@@ -8,6 +8,7 @@\n \n import re\n import threading\n+... | [
{
"diff_hunk": "@@ -334,7 +335,10 @@ def setter(value: object) -> None:\n \"\"\"Set bound data.\"\"\"\n _rich_traceback_omit = True\n Reactive._initialize_object(self)\n- setattr(self, variable_name, value)\n+ # Co... | 3cdc6537a410ca200ab89ae457f7f5273ce6e8a9 | diff --git a/docs/guide/reactivity.md b/docs/guide/reactivity.md
index ff7a1cebdf..eb058a130b 100644
--- a/docs/guide/reactivity.md
+++ b/docs/guide/reactivity.md
@@ -410,7 +410,8 @@ Note the call to `mutate_reactive`. Without it, the display would not update whe
## Data binding
-Reactive attributes from one widge... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Textualize__textual-4333@74ab967 | Textualize/textual | Python | 4,333 | Tests re-raise exceptions that happen inside `Widget.compose` | This will fix #4282.
The fix was to simply leverage the machinery introduced in #2754; for some reason, exceptions caught inside `Widget.compose` or workers were directly being sent to `App.panic` instead of using `App._handle_exception`. | 2024-03-25T14:46:38Z | Exception not being raised in tests
Consider such an example:
```python
from __future__ import annotations
from textual import work
from textual.app import App
class SimpleAppThatCrashes(App[None]):
def on_mount(self) -> None:
self.crash()
@work(name="crash")
async def crash(self)... | Thank you for your issue. Give us a little time to review it.
PS. You might want to check the [FAQ](https://textual.textualize.io/FAQ/) if you haven't done so already.
This is an automated reply, generated by [FAQtory](https://github.com/willmcgugan/faqtory)
Another intresting (even simplier) case:
```python
from... | [
{
"body": "Consider such an example:\r\n\r\n```python\r\nfrom __future__ import annotations\r\n\r\nfrom textual import work\r\nfrom textual.app import App\r\n\r\n\r\nclass SimpleAppThatCrashes(App[None]):\r\n def on_mount(self) -> None:\r\n self.crash()\r\n\r\n @work(name=\"crash\")\r\n async de... | ea8138913eec098ca2036294dcb9911c197e0f2b | {
"head_commit": "74ab96763fdb02583b92050ea58d897ed3d848d1",
"head_commit_message": "Add test to ensure exception reraised in tests.",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 3a0cb30a51..3239310763 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -12,6 +12,7 @@ and this project adher... | [
{
"diff_hunk": "@@ -70,6 +71,21 @@ def compose(self) -> ComposeResult:\n pass\n \n \n+async def test_pilot_exception_cathing_widget_compose():",
"line": null,
"original_line": 74,
"original_start_line": null,
"path": "tests/test_pilot.py",
"start_line": null,
"text": "@user1:... | 809f38341f35effd073d43c0625fe984f4d9e311 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3a0cb30a51..ecbc5dd4b5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed a crash in `TextArea` when undoing an edit to a selection the selection was made backwards https://github.c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.