instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Textualize__textual-272@7109ec0 | Textualize/textual | Python | 272 | Render opacity | Closes #271
A Panel, and the same Panel passed through the opacity renderable:
An example with `Live` because why not? :)
https://user-images.githubusercontent.com/5740731/153045908-f71efb5f-01ee-4c... | 2022-02-08T17:18:44Z | Render opacity
Create a renderable which applies an opacity value between 0 and 1.
This value should blend the foreground color to the background color. So an opacity of 0 essentially makes text invisible. And an opacity of 0.5 makes a 50% blend from background to foreground.
Interface should be something like th... | [
{
"body": "Create a renderable which applies an opacity value between 0 and 1.\r\n\r\nThis value should blend the foreground color to the background color. So an opacity of 0 essentially makes text invisible. And an opacity of 0.5 makes a 50% blend from background to foreground.\r\n\r\nInterface should be somet... | bf2f911706100a8465da9485a9e5a2598ed4ba2e | {
"head_commit": "7109ec079631c894ccaba028a6435f7f89b759a4",
"head_commit_message": "Use render instead of render_lines in Opacity, add tests",
"patch_to_review": "diff --git a/src/textual/renderables/opacity.py b/src/textual/renderables/opacity.py\nnew file mode 100644\nindex 0000000000..f6cd42986d\n--- /dev/nul... | [
{
"diff_hunk": "@@ -0,0 +1,90 @@\n+import functools\n+\n+from rich.color import Color\n+from rich.console import ConsoleOptions, Console, RenderResult, RenderableType\n+from rich.segment import Segment\n+from rich.style import Style\n+\n+from textual.renderables.utilities import blend_colors\n+\n+\n+class Opaci... | 3e890037c8a409203f9517a15a7f3ba2c8321f40 | diff --git a/src/textual/renderables/_blend_colors.py b/src/textual/renderables/_blend_colors.py
new file mode 100644
index 0000000000..a65fb0f8ce
--- /dev/null
+++ b/src/textual/renderables/_blend_colors.py
@@ -0,0 +1,23 @@
+from rich.color import Color
+
+
+def blend_colors(color1: Color, color2: Color, ratio: float)... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Textualize__textual-221@e2fd92b | Textualize/textual | Python | 221 | Margin spacing is now invisible | 2022-01-20T14:48:33Z | Don't render margin
Currently a widget renders margin as solid color (if present).
It would be more correct to allow the background to be visible. I think this will require modifying the size of a widget to compensate for margin prior to rendering | [
{
"body": "Currently a widget renders margin as solid color (if present).\r\n\r\nIt would be more correct to allow the background to be visible. I think this will require modifying the size of a widget to compensate for margin prior to rendering",
"number": 218,
"title": "Don't render margin"
}
] | 07a053fdd47734b4602240ba59a574f1c0467ba8 | {
"head_commit": "e2fd92bda228c9f62e49580ac8b5fb1d5f97a154",
"head_commit_message": "Margin space is now not rendered as solid colour",
"patch_to_review": "diff --git a/src/textual/css/_styles_builder.py b/src/textual/css/_styles_builder.py\nindex 17349a04f7..871d21f39b 100644\n--- a/src/textual/css/_styles_build... | [
{
"diff_hunk": "@@ -114,7 +114,24 @@ def get_arrangement(self, size: Size, scroll: Offset) -> Iterable[WidgetPlacemen\n cached_size, cached_scroll, arrangement = self._cached_arrangement\n if cached_size == size and cached_scroll == scroll:\n return arrangement\n- arrangement ... | 3c730665f5e37fb775cffa36510cb30f65a14ca2 | diff --git a/src/textual/css/_styles_builder.py b/src/textual/css/_styles_builder.py
index 8a826507a3..79e478f232 100644
--- a/src/textual/css/_styles_builder.py
+++ b/src/textual/css/_styles_builder.py
@@ -129,7 +129,7 @@ def _process_space(self, name: str, tokens: list[Token]) -> None:
append = space.append
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | ||
Textualize__textual-214@f9f7efb | Textualize/textual | Python | 214 | Splitting out parsing of durations into new token types, avoiding Scalar | 2022-01-18T17:33:59Z | Extract time values from CSS
Values for time in transition rule (and potentially elsewhere) are parsed in to a Scalar object.
Time is technically a scalar, but it adds a bit of confusion to the Scalar class which is mostly used for dimensions.
We should drop the use of Scalar for time and define another object to... | [
{
"body": "Values for time in transition rule (and potentially elsewhere) are parsed in to a Scalar object.\r\n\r\nTime is technically a scalar, but it adds a bit of confusion to the Scalar class which is mostly used for dimensions.\r\n\r\nWe should drop the use of Scalar for time and define another object to s... | d7bcd0093809a8ef33db2cb905ca09c724afcc7f | {
"head_commit": "f9f7efb1cf2a5516112d3573e79fd9ac58004318",
"head_commit_message": "Ensure test accounts for negative values",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex e2c607c2f5..e26fb347e6 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-commit-config.yaml\n@@ ... | [
{
"diff_hunk": "@@ -0,0 +1,43 @@\n+import re\n+\n+_match_duration = re.compile(r\"^(-?\\d+\\.?\\d*)(s|ms)$\").match\n+\n+\n+class DurationError(Exception):\n+ pass\n+\n+\n+class DurationParseError(DurationError):\n+ pass\n+\n+\n+def _duration_as_seconds(duration: str) -> float:\n+ \"\"\"\n+ Args:\n+... | c462beb31285f8a914abca7a80d341d852dc237f | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index e2c607c2f5..e26fb347e6 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -11,3 +11,4 @@ repos:
rev: 21.8b0
hooks:
- id: black
+ exclude: ^tests/
diff --git a/Makefile b/Makefile
index 80cde06d37..16489186e4 ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | ||
Textualize__textual-219@1e92b08 | Textualize/textual | Python | 219 | Invisible widgets now dont render | Fixes #217 | 2022-01-20T11:41:22Z | Invisible widgets should allow background to be rendered
Currently when a widget is set as invisible, it draws a blank rectangle in place of the content.
It would be better to not render anything and allow any background to show through. | [
{
"body": "Currently when a widget is set as invisible, it draws a blank rectangle in place of the content.\r\n\r\nIt would be better to not render anything and allow any background to show through.",
"number": 217,
"title": "Invisible widgets should allow background to be rendered"
}
] | 185788b7607266cc2e7609fb237be82cd3efb8b0 | {
"head_commit": "1e92b08e1b67900605fcc3851e93e62b5f7a01f9",
"head_commit_message": "Docstring improvements",
"patch_to_review": "diff --git a/examples/dev_sandbox.css b/examples/dev_sandbox.css\nnew file mode 100644\nindex 0000000000..2e348e1346\n--- /dev/null\n+++ b/examples/dev_sandbox.css\n@@ -0,0 +1,49 @@\n+... | [
{
"diff_hunk": "@@ -1,26 +1,22 @@\n from __future__ import annotations\n \n-from itertools import chain\n-from typing import Callable, Iterable, ClassVar, TYPE_CHECKING\n+from typing import Callable, Iterable, TYPE_CHECKING\n \n-from rich.console import RenderableType\n import rich.repr\n+from rich.console impo... | 13d7580291882c22acbb65c514c2edb42edb2a60 | diff --git a/examples/dev_sandbox.css b/examples/dev_sandbox.css
new file mode 100644
index 0000000000..2e348e1346
--- /dev/null
+++ b/examples/dev_sandbox.css
@@ -0,0 +1,49 @@
+/* CSS file for dev_sandbox.py */
+
+App > View {
+ docks: side=left/1;
+ text: on #20639b;
+}
+
+Widget:hover {
+ outline: heavy;
+ text:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
wandb__wandb-9790@82d9628 | wandb/wandb | Python | 9,790 | chore: update video documentation | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
- Fixes #3532
- Fixes WB-10374
What does the PR do? Include a concise description of the PR contents.
Updates the `wandb.video` documentation, to have a class and initiali... | 2025-04-30T18:22:26Z | [CLI]: wandb.Video takes a very long time
### Describe the bug
Running wandb.Video when providing a numpy array takes a very long time. Using the profiler I found that the issue is the quantization of the frames for the GIF that is created by default. I suggest changing the format to be mp4 by default, this avoids thi... | Hi @eliahuhorwitz,
Thank you for the request! I'll pass it along to our engineering team for review. Could you share a link to the page where you see this slowness?
Thanks,
Ramit
WandB Internal User commented:
ramit-wandb commented:
Hi @eliahuhorwitz,
Thank you for the request! I'll pass it along to our eng... | [
{
"body": "### Describe the bug\n\nRunning wandb.Video when providing a numpy array takes a very long time. Using the profiler I found that the issue is the quantization of the frames for the GIF that is created by default. I suggest changing the format to be mp4 by default, this avoids this quantization and ru... | 0fc42dd1bf44b9e777f861c2b6b632d531843f2c | {
"head_commit": "82d96280916a91f3a4a7d0b78f9bf2ad74cdc3f0",
"head_commit_message": "chore: update video documentation",
"patch_to_review": "diff --git a/BREAKING.md b/BREAKING.md\nindex f0f54be8e72..9beb2e100e6 100644\n--- a/BREAKING.md\n+++ b/BREAKING.md\n@@ -69,3 +69,7 @@ When preparing a release that can incl... | [
{
"diff_hunk": "@@ -89,10 +60,53 @@ def __init__(\n data_or_path: Union[\"np.ndarray\", str, \"TextIO\", \"BytesIO\"],\n caption: Optional[str] = None,\n fps: Optional[int] = None,\n- format: Optional[str] = None,\n+ format: Optional[Literal[\"gif\", \"mp4\", \"webm\", \"og... | 19b2b9ae26a7dbcc57e742aab3bdc991b7e69eff | diff --git a/BREAKING.md b/BREAKING.md
index f0f54be8e72..9beb2e100e6 100644
--- a/BREAKING.md
+++ b/BREAKING.md
@@ -69,3 +69,7 @@ When preparing a release that can include breaking changes, consider applying ch
- Remove fallback of storing system settings in a temporary directory when we don't have permissions to wri... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
tinygrad__tinygrad-3829@f3ea0e4 | tinygrad/tinygrad | Python | 3,829 | log optimized kernels and a script to compare with non-optimized ones | refactor fuzz_linearizer comparison to allow it to be used in for BEAM_VERIFY in device.py
Closes #3819
| 2024-03-19T22:35:47Z | generic ast comparison
Verifying beam output directly in device.py was useful to debug the recent gpt2 beam flaky issue. We have ast to ast comparison in fuzz_linearizer, which would require generating a new kernel dataset if we changed the kernel and wanted it in fuzzer test. Factoring out a generic ast to ast compari... | The idea involved an optional step to verify kernel optimization is correct. Incorrect optimization that runs with wrong output is very hard for user to debug | [
{
"body": "Verifying beam output directly in device.py was useful to debug the recent gpt2 beam flaky issue. We have ast to ast comparison in fuzz_linearizer, which would require generating a new kernel dataset if we changed the kernel and wanted it in fuzzer test. Factoring out a generic ast to ast comparison ... | 9d1d08fbb0766170feccc45904bc380c67d04b37 | {
"head_commit": "f3ea0e4116f9a9886a8414d12074753b82f5c5d3",
"head_commit_message": "cleanup fixes",
"patch_to_review": "diff --git a/extra/optimization/helpers.py b/extra/optimization/helpers.py\nindex cefbba3eb6a32..fd34c6149a865 100644\n--- a/extra/optimization/helpers.py\n+++ b/extra/optimization/helpers.py\n... | [
{
"diff_hunk": "@@ -278,6 +279,9 @@ def get_linearizer(self, *ast:LazyOp) -> Linearizer:\n timed = sorted([(nm, tk, time_linearizer(tk, test_rawbuffers, allow_test_size=False, clear_l2=True)) for nm, tk in lins], key=lambda x: x[2])\n if DEBUG >= 1: print(\" < \".join(f\"{nm:6s} : {lin.colored... | d938ac076b6fd036de73e67ff849d0c2f6b37a62 | diff --git a/extra/optimization/helpers.py b/extra/optimization/helpers.py
index cefbba3eb6a32..fd34c6149a865 100644
--- a/extra/optimization/helpers.py
+++ b/extra/optimization/helpers.py
@@ -1,5 +1,6 @@
# stuff needed to unpack a kernel
from tinygrad.ops import LazyOp, TernaryOps, BinaryOps, UnaryOps, ReduceOps, Bu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
tinygrad__tinygrad-5790@112b584 | tinygrad/tinygrad | Python | 5,790 | Add check for negative dimension in view | fixes: #5774
Is it okay to check at a view level?
~~Regression tests pending~~ | 2024-07-29T13:47:19Z | better error message for Tensor creation methods with negative dims
currently `Tensor.full((-2,-2), 2)` and `Tensor.full((-2,-2), 2).realize()` both have no error.
torch error: `RuntimeError: Trying to create tensor with negative dimension -2: [-2, -2]`
numpy error: `ValueError: negative dimensions are not allowed`... | [
{
"body": "currently `Tensor.full((-2,-2), 2)` and `Tensor.full((-2,-2), 2).realize()` both have no error.\r\n\r\ntorch error: `RuntimeError: Trying to create tensor with negative dimension -2: [-2, -2]`\r\nnumpy error: `ValueError: negative dimensions are not allowed`\r\n\r\nfix this generically for all Tensor... | ce61be16f1ecfc46a0df923a7f81c7888ec2e5ff | {
"head_commit": "112b58436377fa3cfe95ac5d852f016432f19b33",
"head_commit_message": "move check to tensor level",
"patch_to_review": "diff --git a/test/test_ops.py b/test/test_ops.py\nindex b7e57c2834269..1cca365e8154d 100644\n--- a/test/test_ops.py\n+++ b/test/test_ops.py\n@@ -1,5 +1,6 @@\n import time, math, un... | [
{
"diff_hunk": "@@ -441,6 +443,7 @@ def full(shape:Tuple[sint, ...], fill_value:ConstType, **kwargs):\n print(Tensor.full((2, 3), False).numpy())\n ```\n \"\"\"\n+ if not all(s >= 0 for s in argfix(shape)): raise RuntimeError(f\"Trying to create view with negative dimension: {shape=}\")",
"li... | 1d601bc08c5b0a2f860dd51fb8a67999c71d0c80 | diff --git a/test/test_ops.py b/test/test_ops.py
index 325b5f41f6294..06133cca447c8 100644
--- a/test/test_ops.py
+++ b/test/test_ops.py
@@ -1,5 +1,6 @@
import time, math, unittest
import numpy as np
+from typing import List, Callable
import torch
from tinygrad.helpers import getenv, IMAGE, DEBUG, CI
from tinygrad... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
wandb__wandb-9678@8d2b109 | wandb/wandb | Python | 9,678 | fix: windows throws ValueError when running from a different drive. | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
- Fixes: #9676, #9349
- Fixes: WB-24266, WB-23175, WB-7853
What does the PR do? Include a concise description of the PR contents.
When running a W&B script on Windows f... | 2025-04-03T23:25:45Z | [Bug]:
### Describe the bug
Hi, I'm getting an error in wandb version 0.19.9.
```
Traceback (most recent call last):
------------MY CUSTOM CODE---------------------
File "c:\users\paul boursin\desktop\dynamical\ml-agents\ml-agents\mlagents\plugins\stats_writer.py", line 64, in register_stats_writer_plugins
plu... | Hey Paul!
Thank you for writing in. Are you able to share the toy code example with us to so I can try and reproduce this on my side?
Looks like you are running this on windows? Could you please provide the debug.log and debug-internal.log files associated with the run where you are running into this issue? These fil... | [
{
"body": "### Describe the bug\n\nHi, I'm getting an error in wandb version 0.19.9.\n\n```\nTraceback (most recent call last):\n\n------------MY CUSTOM CODE---------------------\n File \"c:\\users\\paul boursin\\desktop\\dynamical\\ml-agents\\ml-agents\\mlagents\\plugins\\stats_writer.py\", line 64, in regist... | 9718a120b2c40127a69f949f0f13ef89310c2e0c | {
"head_commit": "8d2b1095aa3e9f89506af38ecb8097dd38e1c5d2",
"head_commit_message": "update changelog",
"patch_to_review": "diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md\nindex 0d0e94bfbe2..bda08cddeba 100644\n--- a/CHANGELOG.unreleased.md\n+++ b/CHANGELOG.unreleased.md\n@@ -16,3 +16,7 @@ Section... | [
{
"diff_hunk": "@@ -1662,6 +1662,12 @@ def _get_program_relpath(program: str, root: Optional[str] = None) -> Optional[s\n if not root:\n return None\n \n+ # On Windows if the program and root are on different drives,\n+ # Python will raise a ValueError.\n+ if platform.sy... | 72275f8ee506eb307fb28fb337e84ec27b9bb15e | diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index 0d0e94bfbe2..bda08cddeba 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -16,3 +16,7 @@ Section headings should be at level 3 (e.g. `### Added`).
### Changed
- Upgrade go version for `wandb-core` from 1.23.x to 1.24.x (@kptki... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
wandb__wandb-8255@d660b20 | wandb/wandb | Python | 8,255 | fix(sdk): fix context manager usage in disabled mode | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
Fixes #8112.
<!--
NEW: We're using a new changelog format that's more useful for users. Please
see CHANGELOG.md for details and update on relevant changes such as feature
a... | 2024-09-03T19:59:33Z | [CLI]: initializing twice leads to `AttributeError: 'Run' object has no attribute '_telemetry_obj'.`
### Describe the bug
<!--- Description of the issue below -->
## Description
Starting from `wandb==0.17.6`, I noticed an issue that if I initialize twice as `run = wandb.init(mode="disabled")` I get `AttributeEr... | I'm also hitting this :(
Looks like this is already fixed in #8101, but not yet released.
Setting `wandb.init(mode="disabled")` seems to also break the context manager usage like:
```
with wandb.init() as run:
... do training ...
```
with the same error as reported above.
I am also hitting this bug. I think it's... | [
{
"body": "### Describe the bug\r\n\r\n<!--- Description of the issue below -->\r\n## Description\r\n\r\nStarting from `wandb==0.17.6`, I noticed an issue that if I initialize twice as `run = wandb.init(mode=\"disabled\")` I get `AttributeError: 'Run' object has no attribute '_telemetry_obj'`.\r\n\r\nOrdinary ... | 3df598a880771a0346578d686308c2a14a9e9359 | {
"head_commit": "d660b20b9d252ee879d452d8a5a868141de5c131",
"head_commit_message": "add a test",
"patch_to_review": "diff --git a/tests/unit_tests/test_mode_disabled.py b/tests/unit_tests/test_mode_disabled.py\nindex 683bce498de..794f07f3d8b 100644\n--- a/tests/unit_tests/test_mode_disabled.py\n+++ b/tests/unit_... | [
{
"diff_hunk": "@@ -2160,6 +2160,9 @@ def _finish(\n quiet: Optional[bool] = None,\n ) -> None:\n logger.info(f\"finishing run {self._get_path()}\")\n+ if self.disabled:\n+ return",
"line": null,
"original_line": 2164,
"original_start_line": 2163,
"path": "w... | 328a3222a77cd06088c224cc8e42ad6053c6e85d | diff --git a/tests/unit_tests/test_mode_disabled.py b/tests/unit_tests/test_mode_disabled.py
index 683bce498de..794f07f3d8b 100644
--- a/tests/unit_tests/test_mode_disabled.py
+++ b/tests/unit_tests/test_mode_disabled.py
@@ -35,3 +35,19 @@ def test_disabled_can_pickle():
with tempfile.NamedTemporaryFile() as tem... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
tinygrad__tinygrad-7408@d53f8b6 | tinygrad/tinygrad | Python | 7,408 | metal bf16 tc support [pr] | ### CI bf16 support
I had to skip bf16 tensor core support for Metal since CI doesn’t support it, even though it worked perfectly in my local setup. The tests failed with the error message below.
I'm currently working on bf16 support using uop-casting to simulate bf16 when the target lacks native support. I’ve en... | 2024-10-30T15:11:55Z | metal bfloat16 tc
### CI bf16 support
I had to skip bf16 tensor core support for Metal since CI doesn’t support it, even though it worked perfectly in my local setup. The tests failed with the error message below.
I'm currently working on bf16 support using uop-casting to simulate bf16 when the target lacks native su... | <img width="823" alt="image" src="https://github.com/user-attachments/assets/6dab1869-2386-44ec-8f7c-6a4f9434157f">
Can't use cleaner `simdgroup_load` instruction as inputs are in thread memory. The method requires source to be either in device memory or threadgroup memory. Same for `simdgroup_store` instruction. | [
{
"body": "### CI bf16 support\n\nI had to skip bf16 tensor core support for Metal since CI doesn’t support it, even though it worked perfectly in my local setup. The tests failed with the error message below.\n\nI'm currently working on bf16 support using uop-casting to simulate bf16 when the target lacks nati... | 66a069ee25c59fbcda3b19d5f32ed7c1c7f2b8c1 | {
"head_commit": "d53f8b64b0364c5ee1556cb44627437374948c9f",
"head_commit_message": "fix tolerance and skip metal bf16 in ci",
"patch_to_review": "diff --git a/test/test_linearizer.py b/test/test_linearizer.py\nindex 957f529c1b2cd..7f8a3dc7ce85c 100644\n--- a/test/test_linearizer.py\n+++ b/test/test_linearizer.py... | [
{
"diff_hunk": "@@ -1036,14 +1036,16 @@ def helper_arg_acc_dtype(c: Tensor, expected_dtype:DType):\n @unittest.skipUnless(Device[Device.DEFAULT].renderer.tensor_cores, \"test requires tensor cores\")\n def test_tensor_cores(self):\n for tc in Device[Device.DEFAULT].renderer.tensor_cores:\n- if (get... | 4b5b693f9e7a96f98116b011c862e8358bdd4adb | diff --git a/test/test_linearizer.py b/test/test_linearizer.py
index 5f8da358301a9..8faf467dbb1a3 100644
--- a/test/test_linearizer.py
+++ b/test/test_linearizer.py
@@ -41,7 +41,7 @@ def helper_tc_allclose(n:int, m:int, k:int, dtype_in:DType, dtype_out:DType, axi
assert len([x for x in k.applied_opts if x.op is OptO... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
wandb__wandb-8101@f059b1f | wandb/wandb | Python | 8,101 | fix(sdk): fix behavior of Run in disabled mode | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
Fixes: #8112
Ensure that all public attributes and methods of the Run object are available in disabled mode.
<!--
NEW: We're using a new changelog format that's more use... | 2024-08-08T21:28:58Z | [CLI]: initializing twice leads to `AttributeError: 'Run' object has no attribute '_telemetry_obj'.`
### Describe the bug
<!--- Description of the issue below -->
## Description
Starting from `wandb==0.17.6`, I noticed an issue that if I initialize twice as `run = wandb.init(mode="disabled")` I get `AttributeEr... | [
{
"body": "### Describe the bug\r\n\r\n<!--- Description of the issue below -->\r\n## Description\r\n\r\nStarting from `wandb==0.17.6`, I noticed an issue that if I initialize twice as `run = wandb.init(mode=\"disabled\")` I get `AttributeError: 'Run' object has no attribute '_telemetry_obj'`.\r\n\r\nOrdinary ... | 18ccdf8e5cd921bf046e1916d476adb67dc519f9 | {
"head_commit": "f059b1f2d05519aa71ce29555b405a90e26d3aa7",
"head_commit_message": "clean up",
"patch_to_review": "diff --git a/.vscode/settings.json b/.vscode/settings.json\nindex d7fe64fa888..88f78d3c07a 100644\n--- a/.vscode/settings.json\n+++ b/.vscode/settings.json\n@@ -12,22 +12,11 @@\n \"./wandb/vendo... | [
{
"diff_hunk": "@@ -522,17 +525,60 @@ def _log_setup(self, settings: Settings) -> None:\n logger.info(f\"Logging internal logs to {settings.log_internal}\")\n \n def _make_run_disabled(self) -> Run:\n+ \"\"\"Create a disabled run object.",
"line": null,
"original_line": 528,
"orig... | 57e121127a9944f104b86e92b434649312644ef7 | diff --git a/.vscode/settings.json b/.vscode/settings.json
index d7fe64fa888..88f78d3c07a 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -12,22 +12,11 @@
"./wandb/vendor/gql-0.2.0",
"./wandb/vendor/graphql-core-1.1"
],
- "python.linting.enabled": true,
- "python.linting.flake8Enabled":... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
tinygrad__tinygrad-4598@78e83ff | tinygrad/tinygrad | Python | 4,598 | fix(beam): GlobalCounters kernel count increasing when clearing l2 | fixes #4595 by not updating stats when clearing l2 cache in beam search. Added a NOSTATS env var to prevent stats update with a context when some operations need to be ran without updating framework's stats. | 2024-05-15T08:23:55Z | BEAM kernel count number is wrong
```
beam2 : 16 31 31 16 2 3 2 4 3 2 : 817.92 us < hc : 4 31 31 32 4 3 3 4 2 2 : 1000.83 us
*** GPU 9 r_16_31_31_16_2_3_2_4_3_2 arg 3 mem 0.87 GB tm 1244.89us/ 4.99ms ( 113.83 GFLOPS, 24.03 GB/s)
0.00s: from ... | The problem is with this realize, will make the pr after my final exam (in 11mins).
<img width="1000" alt="image" src="https://github.com/tinygrad/tinygrad/assets/44068562/e77f442b-de5d-4dee-b2d3-68a3a94a13de"> | [
{
"body": "```\r\nbeam2 : 16 31 31 16 2 3 2 4 3 2 : 817.92 us < hc : 4 31 31 32 4 3 3 4 2 2 : 1000.83 us\r\n*** GPU 9 r_16_31_31_16_2_3_2_4_3_2 arg 3 mem 0.87 GB tm 1244.89us/ 4.99ms ( 113.83 GFLOPS, 24.03 GB/s)\r\n 0.00s: from 1 -> ... | a5204fe89d716df6db3301c31d92efa48db0d892 | {
"head_commit": "78e83ffee0f539f6315f6e81f6922b15b8fe8306",
"head_commit_message": "fix(test_search): added assert message",
"patch_to_review": "diff --git a/test/test_search.py b/test/test_search.py\nindex baac49136e791..29b1f4f0f5a20 100644\n--- a/test/test_search.py\n+++ b/test/test_search.py\n@@ -3,11 +3,11 ... | [
{
"diff_hunk": "@@ -66,5 +66,22 @@ def test_get_linearizer_actions(self):\n if Opt(OptOps.GROUPTOP, 0, 0) in actions:\n assert len([x for x in lins if x.applied_opts[0] == Opt(OptOps.GROUPTOP, axis=0, amt=3)]) == 0, \"did not de-dup GROUPTOP\"\n \n+ def test_kernel_count(self):\n+ \"\"\"\n+ Ens... | 28883cd105cd24191f72ff5569cd5b366e35c34b | diff --git a/test/test_search.py b/test/test_search.py
index ebaa9a510a0ef..da8a71c24cfc1 100644
--- a/test/test_search.py
+++ b/test/test_search.py
@@ -8,7 +8,7 @@
from tinygrad.ops import LazyOp, LoadOps, BufferOps, ReduceOps, BinaryOps, MemBuffer, ConstBuffer
from tinygrad.tensor import Tensor
from tinygrad.dtype... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
tinygrad__tinygrad-5322@1168916 | tinygrad/tinygrad | Python | 5,322 | Make vectorization of CONST explicit | Resolves #5313 | 2024-07-08T00:59:08Z | Use UOps.VECTORIZE for consts
const renderers have an extra call for rendering a vectorized const. This can simplify to:
```
# returns a str expression of the const with the given type
def render_const(self, x:ConstType, dtype:DType) -> str:
if math.isnan(x): return self.render_cast("NAN", dtype)
elif ... | new to project, can I take this one? | [
{
"body": "const renderers have an extra call for rendering a vectorized const. This can simplify to:\r\n```\r\n # returns a str expression of the const with the given type\r\n def render_const(self, x:ConstType, dtype:DType) -> str:\r\n if math.isnan(x): return self.render_cast(\"NAN\", dtype)\r\n elif... | 62c77a28319caf2c48413c3f7bb251d2e4406327 | {
"head_commit": "1168916db762c2164f110d19fc7a7bee31901cba",
"head_commit_message": "remove dead code in PTX CONST render",
"patch_to_review": "diff --git a/test/test_uop_graph.py b/test/test_uop_graph.py\nindex 2f598de887fe5..1f8f597b14ad8 100644\n--- a/test/test_uop_graph.py\n+++ b/test/test_uop_graph.py\n@@ -1... | [
{
"diff_hunk": "@@ -99,21 +102,23 @@ def divides(self, v):\n if self.arg is BinaryOps.MUL: return any(x.divides(v) for x in self.src)\n return False # generic false if we aren't sure\n @functools.cached_property\n- def vmin(self) -> UOp: return x if (x:=self._min_max[0]) is not None else self.const... | 933f8ba382ed7b16f0127a224e88108d8d1b0e33 | diff --git a/test/test_uop_graph.py b/test/test_uop_graph.py
index 75438223815bb..bbd3553fd6d0f 100644
--- a/test/test_uop_graph.py
+++ b/test/test_uop_graph.py
@@ -133,15 +133,6 @@ def test_const_cast(self):
self.assertEqual(out.op, UOps.CONST)
self.assertEqual(out.arg, 0)
- def test_const_vectorize_fold(... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
tinygrad__tinygrad-2601@dc84d59 | tinygrad/tinygrad | Python | 2,601 | threefry_2x32 | Closes: #2418
| 2023-12-04T07:45:05Z | Add fast PRNG support (remove LoadOps.RAND)
JAX uses an encryption function to encrypt arange, threefry2x32. I think this is the right idea
- [ ] Support doing math on integers
- [ ] Add BinaryOps.XOR and `bitwise_xor` (note, rotate_left is a mul+div+add)
- [ ] Implement threefry2x32 and test it
- [ ] Make arange... | [
{
"body": "JAX uses an encryption function to encrypt arange, threefry2x32. I think this is the right idea\r\n\r\n- [ ] Support doing math on integers\r\n- [ ] Add BinaryOps.XOR and `bitwise_xor` (note, rotate_left is a mul+div+add)\r\n- [ ] Implement threefry2x32 and test it\r\n- [ ] Make arange fast? Ensure t... | 53adcb34f558915595726c859d2921f0e01a17bd | {
"head_commit": "dc84d59016863e238b69037cbc17d9b3cefe08cb",
"head_commit_message": "feat: numpy xor",
"patch_to_review": "diff --git a/tinygrad/mlops.py b/tinygrad/mlops.py\nindex ee0766fbe964e..2309d6affb3fe 100644\n--- a/tinygrad/mlops.py\n+++ b/tinygrad/mlops.py\n@@ -90,6 +90,10 @@ class Less(Function):\n d... | [
{
"diff_hunk": "@@ -156,9 +156,27 @@ def empty(*shape, **kwargs):\n @staticmethod\n def manual_seed(seed=0): Tensor._seed = seed\n \n+ _rng_counter: int = 0",
"line": null,
"original_line": 159,
"original_start_line": null,
"path": "tinygrad/tensor.py",
"start_line": null,
"text": "... | f749b9670373112f2b2014dd423a5839fa42dab8 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 250cedf037f4d..0f90ba745ecc3 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -228,6 +228,9 @@ jobs:
- if: ${{ matrix.task == 'onnx' }}
name: Test MLPerf optimizers
run: GPU=1 python -m pytest ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
wandb__wandb-8009@11b36ca | wandb/wandb | Python | 8,009 | fix(sdk): Prevent stalling during artifact download when WANDB_MODE=offline | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
- Fixes #7960
- Fixes WB-20039, WB-19978, WB-19883
This PR addresses an issue where the artifact download operation hangs indefinitely when using the new core backend with... | 2024-07-25T06:38:23Z | Artifact download stalls with wandb core in offline mode
### Describe the bug
When I use wandb core and download an artifact in `offline` mode, the download hangs forever.
```python
import os
import wandb
# Download artifact function
def download_artifact(artifact_name):
artifact = wandb.Api().arti... | cc @dmitryduev @timoffex
This is a regression from the non-core wandb backend, so it's likely a blocker to version 18 where the core backend will become the default.
@jackdent thanks for reporting the issue, we escalated it internally and will have one of the engineers look into it.
Will keep you updated as soon as ... | [
{
"body": "### Describe the bug\r\n\r\nWhen I use wandb core and download an artifact in `offline` mode, the download hangs forever.\r\n\r\n```python\r\nimport os\r\n\r\nimport wandb\r\n\r\n\r\n# Download artifact function\r\ndef download_artifact(artifact_name):\r\n artifact = wandb.Api().artifact(artifact_... | a972dcca84f04c5e615c0c98cf4b14ea46fe94dc | {
"head_commit": "11b36cac5162de84717d2e3a5c57eba3089ca285",
"head_commit_message": "removed problematic offline check with the settings structure mimicing run implementation",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex f8b3844f46a..8ae212ec9db 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.... | [
{
"diff_hunk": "@@ -1647,12 +1649,16 @@ def download(\n \n Raises:\n ArtifactNotLoggedError: If the artifact is not logged.\n+ RuntimeError: If the artifact is attempted to be downloaded in offline mode.\n \"\"\"\n self._ensure_logged(\"download\")\n \n roo... | 1c68ec380a47f23da5bfb0e648c61a785b41ac8c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f8b3844f46a..62aeef6d047 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ Please add to the relevant subsections under Unreleased below on every PR where
- `run.define_metric()` raises an error when given extraneous arguments (@timoffex in https://github.c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
tinygrad__tinygrad-1832@621ffd4 | tinygrad/tinygrad | Python | 1,832 | Fix VALIDHACKS for Images and make it default | So this is just a different approach to validhacks.
Fixes #1801
---------
Notes:
* Some cases indexes have sum node but still requires valid. It should not require it as it needs to go out of bound ? | 2023-09-10T00:55:51Z | Fix VALIDHACKS for Images and make it default ($300 bounty)
When you read images out of bounds, they will return 0s. Currently the compiler is unaware of this and still gates the load. Figure out when we don't need it and disable it.
Images are used in the openpilot model `openpilot/go.sh` that have this extra gated... | If you'd like some help from GPT-4 to understand this:
https://chat.openai.com/share/cabc655a-6cc7-4afa-bda4-741d7600eb2c
I was just experimenting with the test_simple_padding_conv2d test and noticed a max operation that is performed on two equal constants. Since this might be optimized for constants or other equal ... | [
{
"body": "When you read images out of bounds, they will return 0s. Currently the compiler is unaware of this and still gates the load. Figure out when we don't need it and disable it.\r\n\r\nImages are used in the openpilot model `openpilot/go.sh` that have this extra gated load. Safely remove it!\r\n\r\nMust ... | b8ff20ffe45a3e3e05d93e18f469f6ea3f09b8ee | {
"head_commit": "621ffd4d60bbc57eb9c8cf339838778fd427f2c9",
"head_commit_message": "Managed to reduce openpilot time from 30 secs to 5 secs",
"patch_to_review": "diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml\nindex dd669dacc4bb4..f874ac1b0c469 100644\n--- a/.github/workflows/test.yml\n+++ ... | [
{
"diff_hunk": "@@ -21,25 +21,108 @@ class UOps(Enum):\n LOAD = auto(); STORE = auto(); CONST = auto(); BARRIER = auto() # noqa: E702\n ALU = auto(); WMMA = auto(); CAST = auto(); GEP = auto() # noqa: E702\n \n-def to_image_idx(base_shape:Tuple[int, ...], idxy:Node, valid:Node, validhacks=False) -> Tuple[No... | 08c467514813d69e74ac5758aa3814beb1d58d7d | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index dd669dacc4bb4..f874ac1b0c469 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -147,7 +147,7 @@ jobs:
- if: ${{ matrix.task == 'openpilot' }}
name: Test openpilot model compile and size
run: |
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
tinygrad__tinygrad-1802@df15077 | tinygrad/tinygrad | Python | 1,802 | fix jit buffer reuse when freed | Closes #1799 | 2023-09-06T18:57:22Z | Stable Diffusion Memory Usage on M1 8GB is 11.62 GB
Clip:
```
*** 0 r_386_32_12352_4_4 arg 1 sz [386] [32] OPs 2441M/ 0.00G mem 4.27 GB tm 10836.92us/ 10.84ms ( 225.27 GFLOPS, 0.02 GB/s)
```
First step:
```
*** 1 r_5_5 arg 1... | [
{
"body": "Clip:\r\n```\r\n*** 0 r_386_32_12352_4_4 arg 1 sz [386] [32] OPs 2441M/ 0.00G mem 4.27 GB tm 10836.92us/ 10.84ms ( 225.27 GFLOPS, 0.02 GB/s)\r\n```\r\n\r\nFirst step:\r\n```\r\n*** 1 r_5_5 arg 1 sz [] ... | 52a92bf95d26261b303ec97a66b1cad071cd1966 | {
"head_commit": "df150778c2c572833da20c8922600d96902972f3",
"head_commit_message": "fix jit buffer reuse when freed",
"patch_to_review": "diff --git a/test/test_cache_collector.py b/test/test_cache_collector.py\nindex 2fd52f5a4b15f..9a8b2dc2c6387 100644\n--- a/test/test_cache_collector.py\n+++ b/test/test_cache_... | [
{
"diff_hunk": "@@ -64,37 +65,41 @@ def __call__(self, *args, **kwargs) -> Any:\n \n class _CacheCollector:\n class _Placeholder:\n- def __init__(self, buf): self.size, self.dtype, self.device, self.ref, self.buftype = buf.size, buf.dtype, getattr(buf, '_device', None), ref(buf), type(buf)\n+ def __init... | fbefb9077394ba86629a032815b9c52e4cf8dcd9 | diff --git a/test/test_cache_collector.py b/test/test_cache_collector.py
index 2fd52f5a4b15f..0032f694a5b64 100644
--- a/test/test_cache_collector.py
+++ b/test/test_cache_collector.py
@@ -164,5 +164,45 @@ def test_cache_collector_anybufs_inputs(self):
assert get_bufs_count(cache) == 7
FAKE_GLOBAL_ALLOCATOR =... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
tinygrad__tinygrad-2197@f370b56 | tinygrad/tinygrad | Python | 2,197 | For cuda get current free space from device, and retry alloc failures | Instead of calculating free space use what gpu device says.
In rare case even with available space alloc may fail, due to excessive shaded space, handle that by free 10% of space more. | 2023-11-01T13:36:26Z | CUDA LRU allocator runs OOM before freeing cache.
Observation: CUDA is using LRU allocator but free does not kick in and total memory gets exhausted(pycuda._driver.MemoryError: cuMemAlloc failed: out of memory), even when mem_used is very low.
Few observation:
* Initializer : CUDAAlloc = CUDAAllocator(pycuda.driver.... | pycuda also has memory pool in api https://documen.tician.de/pycuda/util.html#device-based-memory-pool, can be used directly as allocator.
This should be a problem with all GPU backends, maybe we can stop tracking free size, and free when alloc fails, I can send a change for this it it LG. | [
{
"body": "Observation: CUDA is using LRU allocator but free does not kick in and total memory gets exhausted(pycuda._driver.MemoryError: cuMemAlloc failed: out of memory), even when mem_used is very low.\r\nFew observation:\r\n* Initializer : CUDAAlloc = CUDAAllocator(pycuda.driver.Context.get_device().total_... | 794122781dbc04ca0bd96d4ccbce51f6412be7db | {
"head_commit": "f370b5624c9763a7d0762ee786d6800982c413c9",
"head_commit_message": "For cuda get current free space from device, and rery alloc failures",
"patch_to_review": "diff --git a/tinygrad/runtime/lib.py b/tinygrad/runtime/lib.py\nindex 75e8b1b58e2a5..de5cef92b96a4 100644\n--- a/tinygrad/runtime/lib.py\n... | [
{
"diff_hunk": "@@ -49,9 +49,16 @@ class device:\n import pycuda.autoprimaryctx # type: ignore # pylint: disable=unused-import # noqa: F401\n import pycuda.driver as cuda # type: ignore\n class CUDAAllocator(LRUAllocator):\n- def _do_alloc(self, size, dtype, device, **kwargs): return cuda.mem_alloc(siz... | 897b6feb2383ed28cf075e17f3e5969e7aac38e1 | diff --git a/test/test_allocators.py b/test/test_allocators.py
index 5fd91fc5156b8..74119a90f3244 100644
--- a/test/test_allocators.py
+++ b/test/test_allocators.py
@@ -1,7 +1,9 @@
#!/usr/bin/env python
import unittest
+import pytest
import numpy as np
from weakref import ref
+
from tinygrad.helpers import GlobalC... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
tinygrad__tinygrad-976@3827b61 | tinygrad/tinygrad | Python | 976 | F64 support | Adds float64 support to the different runtimes, also included an excluded field on dtypes for unsupported platforms
From my testing float64 is not supported on metal and OpenCL on M2 Mac. OpenCL float64 is fine on my windows machine although this is an optional feature and ideally should check the OpenCL extensions ... | 2023-06-13T14:13:30Z | float64 support
Support for float64 over all plattforms.
This would also fix up to 20 ONNX tests.
Is there a plan to add this? Otherwise there is no way to fully support ONNX, since some tests are hard relying on that. | Metal currently does not support float64 / double
Would merge PR to skip those tests. float64 is not in scope for tinygrad.
You did not :-D
There are just 20 random tests in the ONNX test suite that require float64. To me its surprising, that we only have 20, since all operations support float64s.
I fear that tinyg... | [
{
"body": "Support for float64 over all plattforms.\r\nThis would also fix up to 20 ONNX tests.\r\n\r\nIs there a plan to add this? Otherwise there is no way to fully support ONNX, since some tests are hard relying on that.",
"number": 891,
"title": "float64 support"
}
] | 727416201fc05e81db7ef5af8d9af43e35c80f65 | {
"head_commit": "3827b6166555007719390a6098ae395c21361392",
"head_commit_message": "Merge branch 'f64' of github.com:dc-dc-dc/tinygrad into f64",
"patch_to_review": "diff --git a/test/test_dtype.py b/test/test_dtype.py\nindex 65fde81ab999b..8fb1202c5252a 100644\n--- a/test/test_dtype.py\n+++ b/test/test_dtype.py... | [
{
"diff_hunk": "@@ -36,6 +36,7 @@ class Tensor:\n \n def __init__(self, data:Union[int, float, list, tuple, LazyBuffer, np.ndarray], device=Device.DEFAULT, dtype:Optional[DType]=None, requires_grad:Optional[bool]=None):\n assert dtype is None or isinstance(dtype, DType), f\"invalid dtype {dtype}\"\n+ a... | 9b8e475017a85a5862be35b71ed0a506e6714833 | diff --git a/test/test_dtype.py b/test/test_dtype.py
index 65fde81ab999b..8fb1202c5252a 100644
--- a/test/test_dtype.py
+++ b/test/test_dtype.py
@@ -52,6 +52,17 @@ def test_half_mul_upcast_float(self): _test_mul_upcast(Tensor([1,2,3,4], dtype=d
def test_half_matmul_upcast_float(self): _test_matmul_upcast(Tensor([[1,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
wandb__wandb-7711@17a3f24 | wandb/wandb | Python | 7,711 | feat(sdk): add ability to overwrite history of a run from arbitrary step | Description
-----------
<!--
Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
-->
- Fixes WB-5045
- Fixes #1395
- Addresses many other issues
This PR implements the SDK changes needed for "run rewinding," a long requested feature that allows users to tr... | 2024-05-28T14:52:22Z | Overwriting old history
Is it possible to overwrite old history with wandb. I have use-case, when my experiment diverged and I lowered learning rate and used older checkpoint to restart experiment, but wandb doesn’t overwrite history and shows me this warning:
```WARNING Adding to old History rows isn't currently supp... | Issue-Label Bot is automatically applying the label `feature_request` to this issue, with a confidence of 0.53. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/wandb/client) an... | [
{
"body": "Is it possible to overwrite old history with wandb. I have use-case, when my experiment diverged and I lowered learning rate and used older checkpoint to restart experiment, but wandb doesn’t overwrite history and shows me this warning:\r\n```WARNING Adding to old History rows isn't currently support... | e411884d5554b952095e24729902da483452782e | {
"head_commit": "17a3f24de331a11b337037fb1bf5e6f57471c375",
"head_commit_message": "update changelog",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 30a2d89bda6..d5f767854c2 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -15,6 +15,7 @@ Please add to the relevant subsections under Unrele... | [
{
"diff_hunk": "@@ -890,6 +892,32 @@ def _setup_fork(self, server_run: dict):\n self._run.forked = True\n self._run.starting_step = first_step\n \n+ def _load_rewind_state(self, run: \"RunRecord\"):\n+ assert self._settings.resume_from\n+ self._rewind_response = self._api.rewind... | a63e2c139a2cfb62a9ff618e1a3d83e1f37096c3 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 48685b9528b..fea7bb0f8f9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ Please add to the relevant subsections under Unreleased below on every PR where
- Display warning when Kubernetes pod fails to schedule by @TimH98 in https://github.com/wandb/wandb/p... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
wandb__wandb-3510@395db01 | wandb/wandb | Python | 3,510 | Improve `wandb.init(settings=)` to handle `Settings` object similarly to `dict` parameter | Fixes #3505
Description
-----------
Treat a `wandb.Settings` object passed to `wandb.init()` similar to how a passed `dict` is treated. Will now detect settings that differ from defaults and apply them using `Source.INIT`, as this is probably that the user would expect when doing `wandb.init(settings=wandb.Setting... | 2022-04-11T19:12:46Z | [CLI]: _disable_stats doesn't work
### Describe the bug
<!--- Description of the issue below -->
`_disable_stats` doesn't work. `wandb.init(settings=wandb.Settings(_disable_stats=True))` It still sends stats to WANDB, which in turn leads to BSOD due to incompatibility with the old PYNVML dependency in the vendor f... | Hey @CosmicHazel, many thanks for reporting this!
This should be fixed in https://github.com/wandb/client/pull/3510, but for now, instead of passing a `wandb.Settings` object to `init()`, please try passing a simple dict, as in `wandb.init(settings=dict(_disable_stats=True))`.
Also, could you please elaborate on th... | [
{
"body": "### Describe the bug\n\n<!--- Description of the issue below -->\r\n\r\n`_disable_stats` doesn't work. `wandb.init(settings=wandb.Settings(_disable_stats=True))` It still sends stats to WANDB, which in turn leads to BSOD due to incompatibility with the old PYNVML dependency in the vendor folder in v... | e3a26cfcbf0581ae3fd0d0d0499b51e81cc0f6fe | {
"head_commit": "395db01d5c1634470f503e686c3db317dcbf3a55",
"head_commit_message": "rm unnecessary sleep statements in updated tests",
"patch_to_review": "diff --git a/tests/conftest.py b/tests/conftest.py\nindex d22ae681a6e..76480503ae4 100644\n--- a/tests/conftest.py\n+++ b/tests/conftest.py\n@@ -225,9 +225,11... | [
{
"diff_hunk": "@@ -236,16 +237,16 @@ def test_run_with_console_redirect(test_settings, capfd, console):\n \n \n @pytest.mark.parametrize(\"console\", console_modes)\n+@pytest.mark.timeout(300)",
"line": null,
"original_line": 240,
"original_start_line": null,
"path": "tests/test_redir.py",
... | 9dbbb5583e89ba3eea2da1555e3b8eb54e95e761 | diff --git a/standalone_tests/grpc_client.py b/standalone_tests/grpc_client.py
index 06663835b0a..2a31b0dcb4a 100755
--- a/standalone_tests/grpc_client.py
+++ b/standalone_tests/grpc_client.py
@@ -158,7 +158,7 @@ def _inform_init(self, settings):
def run_start(self, run_id):
settings = wandb.Settings()
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
wandb__wandb-5067@d0d5d95 | wandb/wandb | Python | 5,067 | fix(artifacts): more informative message when failing to create staging artifact directory | Fixes #5055
Description
-----------
Catch `PermissionsError` when creating the staging directory so we can raise a more informative error message with a suggested fix.
Testing
-------
1 new test.
Checklist
-------
- [x] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN... | 2023-03-01T21:29:01Z | [Q] Change staging dir
Currently when the run ends I am getting this error trace. I think it's because I do not have write access to where the staging directory is selected by default. How do I change that?
```python
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
wandb: Waiting for W&B... | I think I found the issue, I need to change the `env` variable `WANDB_DATA_DIR`.
Thank you @shenoynikhil for letting us know the solution to your issue. I will be closing it now. If you have any other issue in the future please feel free to contact us!
@shenoynikhil thanks for reporting! @billmdevs it seems like we can... | [
{
"body": "Currently when the run ends I am getting this error trace. I think it's because I do not have write access to where the staging directory is selected by default. How do I change that?\r\n\r\n```python\r\nSet the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.\r\nwandb: Waiting for... | 1f7651d7fb4a6da8197d6c95dd2846cbd23f3a71 | {
"head_commit": "d0d5d959af248b08316bd4645309ffbeac3c707d",
"head_commit_message": "w/e do it the dumb way",
"patch_to_review": "diff --git a/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py b/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py\nindex ec012a54b2a..f305bf8afaf 100644\n--- a/t... | [
{
"diff_hunk": "@@ -986,7 +986,14 @@ def get_artifacts_cache() -> ArtifactsCache:\n \n def get_staging_dir() -> FilePathStr:\n path = os.path.join(env.get_data_dir(), \"artifacts\", \"staging\")\n- mkdir_exists_ok(path)\n+ try:\n+ mkdir_exists_ok(path)\n+ except OSError as e:\n+ raise... | 74462019b07eafda4a6187f67b3f9c2d2831e32b | diff --git a/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py b/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py
index ec012a54b2a..d8c0abe6651 100644
--- a/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py
+++ b/tests/pytest_tests/unit_tests/test_artifacts/test_storage.py
@@ -6,6 +6,... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
wandb__wandb-3371@79099d5 | wandb/wandb | Python | 3,371 | [WB-8897] Properly handle command line args with service | Fixes WB-8897
Fixes #3370
Description
-----------
What does the PR do?
When command line arguments are resolved we save them as list in `Settings`, but when we convert the `Settings` to protobuf message to send over the socket we only converted tuples, meaning all list types of `Settings` will be `None`. To avo... | 2022-03-13T20:23:49Z | [CLI]: args for "Command" are not saved with the run when using `wandb.require("service")`
### Describe the bug
When `wandb.require("service")` is used and a new wandb experiment is created, the command line arguments of the python script are not saved at all - not in the local files/logs and not in the server.
... | [
{
"body": "### Describe the bug\r\n\r\nWhen `wandb.require(\"service\")` is used and a new wandb experiment is created, the command line arguments of the python script are not saved at all - not in the local files/logs and not in the server. \r\n\r\nTo reproduce:\r\n```python \r\nimport sys\r\nimport wandb\r\n... | 613f52fdb67269f12a82d5abe41354429dac9b66 | {
"head_commit": "79099d586e5abadd25d3e86644d72a0211dcabc1",
"head_commit_message": "cast _args to tuple",
"patch_to_review": "diff --git a/wandb/sdk/service/service_base.py b/wandb/sdk/service/service_base.py\nindex 82002f2a275..a7ccf00ae03 100644\n--- a/wandb/sdk/service/service_base.py\n+++ b/wandb/sdk/service... | [
{
"diff_hunk": "@@ -39,7 +39,7 @@ def _pbmap_apply_dict(\n sv.float_value = v\n elif isinstance(v, str):\n sv.string_value = v\n- elif isinstance(v, tuple):\n+ elif isinstance(v, (tuple, list)):",
"line": null,
"original_line": 42,
"original_start_line":... | 98ff0216cad23336b8957dc665f6640ae9c02b03 | diff --git a/wandb/sdk/service/service_base.py b/wandb/sdk/service/service_base.py
index 82002f2a275..a70d57af8fd 100644
--- a/wandb/sdk/service/service_base.py
+++ b/wandb/sdk/service/service_base.py
@@ -5,10 +5,10 @@
"""
from abc import abstractmethod
+from collections.abc import Iterable, Mapping
import datetim... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
wandb__wandb-5296@e93f2ac | wandb/wandb | Python | 5,296 | fix(sdk): unify offline and online mode during init and fix multiprocess attach | …xisting run (#5144)
Fixes WB-NNNN
Fixes #5071
Description
-----------
What does the PR do?
TODO:
- [x] unify `deliver_run` and `publish_run`
- [x] move attach handling from sender to handler
- [x] unify offline_run and online_run in the run class
Testing
-------
How was this PR tested?
Checklist... | 2023-04-05T04:03:23Z | [CLI]: wandb.errors.UsageError: Timeout attaching to run when in offline mode
### Describe the bug
<!--- Description of the issue below -->
When I try to access the config of the run object, I get the exception below. However, this only happens when in offline mode; it works fine when in online mode. (note that I ... | Did some digging and I can see that _attach in wandb_init.py does not have any offline handling code and always assumes online. As per a TODO comment, this code needs to be consolidated with the wandb.init() path which has handling for offline mode.
@RamyE Thanks for reporting this issue! I will take a look at this, b... | [
{
"body": "### Describe the bug\r\n\r\n<!--- Description of the issue below -->\r\nWhen I try to access the config of the run object, I get the exception below. However, this only happens when in offline mode; it works fine when in online mode. (note that I am using multiprocessing as shown below and cannot se... | 639ed72754c77ad85fb1a721a03f6925657854a9 | {
"head_commit": "e93f2ac6688f25a3f8b152f17a5e2611ee1adecc",
"head_commit_message": "fix typing",
"patch_to_review": "diff --git a/tests/functional_tests/t0_main/offline/t2_multiprocess.py b/tests/functional_tests/t0_main/offline/t2_multiprocess.py\nnew file mode 100644\nindex 00000000000..df292f0a19c\n--- /dev/n... | [
{
"diff_hunk": "@@ -717,79 +717,79 @@ def init(self) -> Union[Run, RunDisabled, None]: # noqa: C901\n with telemetry.context(run=run) as tel:\n tel.feature.offline = True\n \n- backend.interface.publish_run(run_proto)\n- run._set_run_obj_offline(run_proto)\n+ ... | 87c193fac18c14d895e100c52d342e8cb069a819 | diff --git a/tests/functional_tests/t0_main/offline/t2_multiprocess.py b/tests/functional_tests/t0_main/offline/t2_multiprocess.py
new file mode 100644
index 00000000000..df292f0a19c
--- /dev/null
+++ b/tests/functional_tests/t0_main/offline/t2_multiprocess.py
@@ -0,0 +1,39 @@
+#!/usr/bin/env python
+"""Offline runs ru... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
wandb__wandb-2358@52da6ba | wandb/wandb | Python | 2,358 | [WB-5919][CLI-2349] fix: watch compatible with disabled mode | <!--
Name your PR: (Use one of the below formats)
- [CLI-NNNN] Brief description of changes if jira ticket
- [WB-NNNN] Brief description of changes if jira ticket
- Brief description of changes
Also:
- Mark your PR as a Draft if it isnt ready for merge yet
-->
<!-- Include one or more of the fol... | 2021-07-03T16:16:41Z | [CLI] Error when trying to disable wandb
**Description**
I am getting
`torch.nn.modules.module.ModuleAttributeError: '<my model name>' object has no attribute '_wandb_hook_names' `
when I try to disable wand either with the env variable WANDB_MODE=disabled or with wandb.init(mode='disabled')
**How to reproduce*... | @borisdayma could you please take a look | [
{
"body": "**Description**\r\nI am getting\r\n`torch.nn.modules.module.ModuleAttributeError: '<my model name>' object has no attribute '_wandb_hook_names' `\r\nwhen I try to disable wand either with the env variable WANDB_MODE=disabled or with wandb.init(mode='disabled')\r\n\r\n\r\n**How to reproduce**\r\nMinim... | 0f31fb00bda0ed59a870342020e9bd9d5f0112e5 | {
"head_commit": "52da6ba675f647b0c5998f12e0eb6275962be623",
"head_commit_message": "feat: make watch more robust",
"patch_to_review": "diff --git a/wandb/sdk/wandb_run.py b/wandb/sdk/wandb_run.py\nindex 37af8650e55..9916c2a3a9f 100644\n--- a/wandb/sdk/wandb_run.py\n+++ b/wandb/sdk/wandb_run.py\n@@ -2075,8 +2075,... | [
{
"diff_hunk": "@@ -309,6 +310,7 @@ def __init__(self):\n \n @classmethod\n def hook_torch(cls, model, criterion=None, graph_idx=0):\n+ print(\"wandb: logging graph, to disable use `wandb.watch(log_graph=False)`\")",
"line": null,
"original_line": 313,
"original_start_line": null,
... | a5ef3cf62b4f0128f6f7d360ae266b9d6f3b3ea5 | diff --git a/wandb/sdk/wandb_run.py b/wandb/sdk/wandb_run.py
index 37af8650e55..9916c2a3a9f 100644
--- a/wandb/sdk/wandb_run.py
+++ b/wandb/sdk/wandb_run.py
@@ -2075,8 +2075,8 @@ def define_metric(
return m
# TODO(jhr): annotate this
- def watch(self, models, criterion=None, log="gradients", log_freq... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ultralytics__yolov5-4049@f036037 | ultralytics/yolov5 | Python | 4,049 | Feature `python train.py --cache disk` | This PR implements cache on disk.
This is useful when the image-data is too large to fit in memory.
The speed per epoch is about twice as fast as without cache.
### Usage
```bash
python train.py # default, no caching
python train.py --cache # RAM cache
python train.py --cache ram # RAM cache
python trai... | 2021-07-18T14:08:37Z | Improve the performance of training without cache.
## 🚀 Feature
When training is without cache, the usage rate of gpu will not increase.
opencv preprocessing is too slow.
It doesn't get faster even if I increase the number of workers of dataloader.
There are two improvements.
* Replace opencv preprocessing... | I've implement the cache on disk.
https://github.com/ultralytics/yolov5/pull/4049 | [
{
"body": "## 🚀 Feature\r\n\r\nWhen training is without cache, the usage rate of gpu will not increase.\r\nopencv preprocessing is too slow. \r\nIt doesn't get faster even if I increase the number of workers of dataloader.\r\n\r\nThere are two improvements.\r\n\r\n* Replace opencv preprocessing with pytorch's ... | 621caea53c393ca8b46261d369a6314f7d2736d7 | {
"head_commit": "f036037ff64194bf5dbcd80c205b32dc56b12627",
"head_commit_message": "Update cache-function on disk",
"patch_to_review": "diff --git a/train.py b/train.py\nindex 1c48fa49f0f7..0d4e2ca6c719 100644\n--- a/train.py\n+++ b/train.py\n@@ -199,7 +199,7 @@ def train(hyp, # path/to/hyp.yaml or hyp dictiona... | [
{
"diff_hunk": "@@ -439,7 +439,7 @@ def parse_opt(known=False):\n parser.add_argument('--noautoanchor', action='store_true', help='disable autoanchor check')\n parser.add_argument('--evolve', type=int, nargs='?', const=300, help='evolve hyperparameters for x generations')\n parser.add_argument('--bu... | b9f6d54661ae43b040c7ed78a264b81f6f8dbaa5 | diff --git a/export.py b/export.py
index 83e293b72e73..cec85958b4a9 100644
--- a/export.py
+++ b/export.py
@@ -156,8 +156,8 @@ def run(weights='./yolov5s.pt', # weights path
# Finish
print(f'\nExport complete ({time.time() - t:.2f}s)'
- f"Results saved to {colorstr('bold', file.parent.resolve())}\... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
ultralytics__yolov5-2982@5aaa79e | ultralytics/yolov5 | Python | 2,982 | Fix ONNX export using --grid --simplify --dynamic simultaneously | `python models/export.py --grid --dynamic --simplify` failed to export onnx model.
[#2856](https://github.com/ultralytics/yolov5/pull/2856) fix dynamic and simplify but still cannot work with grid, because the `self.grid[i]` mismatch the dynamic `y[..., 0:2]`. This pull request fixes it.
Also the removal of subsc... | 2021-04-30T09:31:51Z | Export with ONNX Simplifier with --grid error
## 🐛 Bug
An exported model as ONNX using --grid parameter cannot be used by onnx-runtime or simplified by onnx-simplifier
A Mul Node triggers a shape inference error Incompatible dimensions
## To Reproduce
Replace ONNX export in export.py with this code and run w... | @antlamon thanks for the bug report. We don't generally provide support for code customizations and external package not in requirements.txt.
If an external package is causing an error you may also want to raise an issue with the package authors.
I would like to add that without any modifications to export.py, the ... | [
{
"body": "## 🐛 Bug\r\nAn exported model as ONNX using --grid parameter cannot be used by onnx-runtime or simplified by onnx-simplifier\r\nA Mul Node triggers a shape inference error Incompatible dimensions\r\n\r\n\r\n## To Reproduce\r\n\r\nReplace ONNX export in export.py with this code and run with command `... | 41cc7caee64f78b8364db27b5326d1a53b91cb97 | {
"head_commit": "5aaa79e84bfe9bde0ae3de3026c4b6f7fb9a830c",
"head_commit_message": "rename exp_dynamic to onnx_dynamic, comment",
"patch_to_review": "diff --git a/models/export.py b/models/export.py\nindex da15079149a1..44bf1c96d959 100644\n--- a/models/export.py\n+++ b/models/export.py\n@@ -26,8 +26,8 @@\n ... | [
{
"diff_hunk": "@@ -58,7 +57,7 @@ def forward(self, x):\n y[..., 2:4] = (y[..., 2:4] * 2) ** 2 * self.anchor_grid[i] # wh\n else: # for YOLOv5 on AWS Inferentia https://github.com/ultralytics/yolov5/pull/2953\n xy = (y[..., 0:2] * 2. - 0.5 + self.grid[i]... | 0a0f9a9c354c53c50e6d094f9175dbdd2e5b7be6 | diff --git a/models/export.py b/models/export.py
index 90855d2588da..6a9f1df57e8f 100644
--- a/models/export.py
+++ b/models/export.py
@@ -26,9 +26,9 @@
parser.add_argument('--weights', type=str, default='./yolov5s.pt', help='weights path')
parser.add_argument('--img-size', nargs='+', type=int, default=[640, ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-19469@a533332 | Chia-Network/chia-blockchain | Python | 19,469 | Allow DIDs from other wallets with NIL recovery lists | Attempt to fix https://github.com/Chia-Network/chia-blockchain/issues/18947
This PR changes the `DIDCoinData` class member `recovery_list_hash` from `bytes32` to `Optional[bytes32]`. This makes it clear that None/NIL is allowed, but otherwise it should be a proper 32-byte hash. This class is marked as `Streamable`, ... | 2025-04-03T22:47:12Z | [Bug] find_lost_did Bad Bytes initializer (versions 2.0.0 -> main)
### What happened?
Steps to reproduce:
1. create a wallet in pawket
2. create a did in pawket
3. click on the wallet fingerprint in pawket to reveal the 24 word mnemonic and import it into the chia reference client
NOTE - the did will be pres... | The cause of the issue is that the recovery list hash can be null on-chain but the reference wallet doesn't allow this. Both Pawket and Sage default to a null recovery list hash since it's 32 bytes cheaper to reveal on-chain every spend. | [
{
"body": "### What happened?\r\n\r\nSteps to reproduce:\r\n\r\n1. create a wallet in pawket\r\n2. create a did in pawket\r\n3. click on the wallet fingerprint in pawket to reveal the 24 word mnemonic and import it into the chia reference client\r\n\r\nNOTE - the did will be present in the pawket app but not in... | 85a44bb4ab82da03728f991ff6cf1fe8b5df5099 | {
"head_commit": "a5333327386e87f8eb543e4d03628d9f1df013d5",
"head_commit_message": "Use Optional[bytes32] for DIDCoinData to show the list should be 32 bytes or nothing (where nothing is the NIL program)",
"patch_to_review": "diff --git a/chia/_tests/cmds/wallet/test_did.py b/chia/_tests/cmds/wallet/test_did.py\... | [
{
"diff_hunk": "@@ -2266,3 +2274,116 @@ async def test_did_coin_records(wallet_environments: WalletTestFramework, monkey\n )\n \n assert len(await wallet.wallet_state_manager.get_spendable_coins_for_wallet(did_wallet.id())) == 1\n+\n+\n+@pytest.mark.limit_consensus_modes(allowed=[ConsensusMode.PLAIN... | cd37e188494c7016cb6a44cc50cb59e3b12030a7 | diff --git a/chia/_tests/cmds/wallet/test_did.py b/chia/_tests/cmds/wallet/test_did.py
index c488df2eae97..4351d92a8a18 100644
--- a/chia/_tests/cmds/wallet/test_did.py
+++ b/chia/_tests/cmds/wallet/test_did.py
@@ -3,25 +3,41 @@
from pathlib import Path
from typing import Optional, Union
+import pytest
from chia_r... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-17856@08b202d | Chia-Network/chia-blockchain | Python | 17,856 | Fix memo plotid | <!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complex... | 2024-04-11T04:13:18Z | [Bug] Wrong type with memo argument
### What happened?
When trying to duplicate plots, errors were received when passing in the 128-byte hex string. Additionally, I was receiving an error when using the "chia plotters" command with a memo that the memo needed to be converted to a string.
### Version
2.3.0rc1
### Wh... | [
{
"body": "### What happened?\n\nWhen trying to duplicate plots, errors were received when passing in the 128-byte hex string. Additionally, I was receiving an error when using the \"chia plotters\" command with a memo that the memo needed to be converted to a string.\n\n### Version\n\n2.3.0rc1\n\n### What plat... | 5da5db127807b0712daf806143d631abdf051472 | {
"head_commit": "08b202df1306c5644c9de5f0c0950710004924c0",
"head_commit_message": "Return the args.plotid bytes32.fromhex(plot_str) instead of bytes.fromhex(plot_str)",
"patch_to_review": "diff --git a/chia/plotting/create_plots.py b/chia/plotting/create_plots.py\nindex ac33b5723153..e3c60ed0a82c 100644\n--- a/... | [
{
"diff_hunk": "@@ -210,11 +210,22 @@ async def create_plots(\n \n if args.plotid is not None:\n log.info(f\"Debug plot ID: {args.plotid}\")\n- plot_id = bytes32(bytes.fromhex(args.plotid))\n+ # Check if args.memo is of type bytes and convert it to a string if so\n+ ... | aa3b5c3df13c04df2ca744a599852ddd39aec7e9 | diff --git a/chia/plotting/create_plots.py b/chia/plotting/create_plots.py
index ac33b5723153..c6321d792cb5 100644
--- a/chia/plotting/create_plots.py
+++ b/chia/plotting/create_plots.py
@@ -202,7 +202,7 @@ async def create_plots(
# The plot id is based on the harvester, farmer, and pool keys
if keys.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-18803@bf9010e | Chia-Network/chia-blockchain | Python | 18,803 | CHIA-1697: Add new flag to support recursively scanning and following links | Fixes #16268
Adds new harvester option `follow_links` that only works when used with `recursive_scan` and uses `glob.glob` instead of `Path.rglob` in order to follow links when scanning recursively for plots.
| 2024-10-31T20:45:25Z | [Bug] Recursive plot scan ignores hard links
### What happened?
I have a main plotting directory that has a few mount points and a few hard links.
When I switched to using recursive searching I noticed that plots from mount points were picked fine, but no plots from hard-linked directories were farmed.
Here's ... | We are using pathlib.rglob(*.plot) for resolving plots. Maybe there is an issue in that for hard links. | [
{
"body": "### What happened?\r\n\r\nI have a main plotting directory that has a few mount points and a few hard links.\r\n\r\nWhen I switched to using recursive searching I noticed that plots from mount points were picked fine, but no plots from hard-linked directories were farmed.\r\n\r\nHere's the sample dir... | efb7a292edb69a61c3c1e1da6eb93167a66c06eb | {
"head_commit": "bf9010e1ae795f78a641954763b28d462abf73e4",
"head_commit_message": "Remove unneeded hardlink checks as hardlinks to directories aren't a thing",
"patch_to_review": "diff --git a/chia/_tests/plotting/test_plot_manager.py b/chia/_tests/plotting/test_plot_manager.py\nindex 6989a77b8d33..07dd7e159063... | [
{
"diff_hunk": "@@ -737,3 +737,46 @@ async def test_recursive_plot_scan(environment: Environment) -> None:\n add_plot_directory(env.root_path, str(sub_dir_1_0_1.path))\n expected_result.loaded = []\n await env.refresh_tester.run(expected_result)\n+\n+\n+@pytest.mark.limit_consensus_modes(reason=\"do... | 2bfb047ea9844c14b4c895162de576c7f4858070 | diff --git a/chia/_tests/plotting/test_plot_manager.py b/chia/_tests/plotting/test_plot_manager.py
index 6989a77b8d33..81531fdfc9ff 100644
--- a/chia/_tests/plotting/test_plot_manager.py
+++ b/chia/_tests/plotting/test_plot_manager.py
@@ -14,6 +14,7 @@
from chia_rs import G1Element
from chia._tests.plotting.util im... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
wandb__wandb-4344@081a588 | wandb/wandb | Python | 4,344 | feat(sdk): speed up iterating over directory in the `filtered_dir` function by also filtering by directories | Fixes #4322
Description
-----------
What does the PR do?
Checks also if a directory is to be excluded and if so we skip it
Testing
-------
Locally on my computer
| 2022-10-02T09:56:09Z | [Feature]: Speed up filtering files in a directory with excluded sub-directories
### Description
Currently, when calling `wandb.sdk.lib.filenames.filtered_dir`, the function iterates over every file and folder in the root directory.
The problem starts if there is a directory containing a lot of files that needs to be... | Hi @amitabe!
Thank you for your suggestion, I can create an internal feature request for this, or if you would like - you can submit a PR to this repository as well.
Thanks,
Ramit | [
{
"body": "### Description\n\nCurrently, when calling `wandb.sdk.lib.filenames.filtered_dir`, the function iterates over every file and folder in the root directory.\r\nThe problem starts if there is a directory containing a lot of files that needs to be excluded - in such case, the function will iterate all th... | 4273584c5bfd5f418b1f0568e928d7e619e984ec | {
"head_commit": "081a588c64367e6d6cc2b18ac67b0ace539d6372",
"head_commit_message": "Merge branch 'main' into master",
"patch_to_review": "diff --git a/wandb/sdk/lib/filenames.py b/wandb/sdk/lib/filenames.py\nindex 8e914b05858..ac518bd45b3 100644\n--- a/wandb/sdk/lib/filenames.py\n+++ b/wandb/sdk/lib/filenames.py... | [
{
"diff_hunk": "@@ -32,7 +32,10 @@ def filtered_dir(\n root: str, include_fn: Callable[[str], bool], exclude_fn: Callable[[str], bool]\n ) -> Generator[str, None, None]:\n \"\"\"Simple generator to walk a directory\"\"\"\n- for dirpath, _, files in os.walk(root):\n+ for dirpath, dirs, files in os.... | 64e2df3fdbb453e763c04e931f6787466f0688cc | diff --git a/wandb/sdk/lib/filenames.py b/wandb/sdk/lib/filenames.py
index 7e07a546d2f..12290533be0 100644
--- a/wandb/sdk/lib/filenames.py
+++ b/wandb/sdk/lib/filenames.py
@@ -41,6 +41,7 @@ def filtered_dir(
Yields:
Generator[str, None, None]: A generator of file paths.
"""
+
for dirpath, dirs,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
Chia-Network__chia-blockchain-13886@f2709f4 | Chia-Network/chia-blockchain | Python | 13,886 | Add a daemon heartbeat setting to config.yaml | This might not be worthwhile, but sometimes it seems having a config setting for this is useful for some troubleshooting.
Also change the default for the Daemon to be 300 seconds.
Rationale: The daemon connections are typically almost always localhost connections. The heartbeat is only useful for detecting connection... | 2022-11-09T23:23:54Z | [Bug] Harvester raise asyncio.exceptions.TimeoutError exception
### What happened?
Recently, one of my harvester started to raise asyncio.exceptions.TimeoutError after running for couple hours. I have to reboot the machine to start chia harvester again.
I have attached the log.
### Version
1.5.1
### What pl... | [
{
"body": "### What happened?\n\nRecently, one of my harvester started to raise asyncio.exceptions.TimeoutError after running for couple hours. I have to reboot the machine to start chia harvester again.\r\n\r\nI have attached the log.\r\n\r\n\n\n### Version\n\n1.5.1\n\n### What platform are you using?\n\nLinux... | a731c7e3c2cfdc83a027f0f6b043421a2c62c3c6 | {
"head_commit": "f2709f46bd1bc60dbb764f7746867b9c4f1803f7",
"head_commit_message": "Various updates from feedback",
"patch_to_review": "diff --git a/chia/daemon/client.py b/chia/daemon/client.py\nindex 99df01a12efe..9870c1a0fe2d 100644\n--- a/chia/daemon/client.py\n+++ b/chia/daemon/client.py\n@@ -18,12 +18,14 @... | [
{
"diff_hunk": "@@ -10,7 +10,7 @@ async def test_get_version_rpc(self, get_daemon, bt):\n ws_server = get_daemon\n config = bt.config\n client = await connect_to_daemon(\n- config[\"self_hostname\"], config[\"daemon_port\"], 50 * 1000 * 1000, bt.get_daemon_ssl_context()\n+ ... | 542e68df3a88c1fef88776406812f061df8c9b0f | diff --git a/chia/daemon/client.py b/chia/daemon/client.py
index 99df01a12efe..9870c1a0fe2d 100644
--- a/chia/daemon/client.py
+++ b/chia/daemon/client.py
@@ -18,12 +18,14 @@ def __init__(
self,
uri: str,
ssl_context: Optional[ssl.SSLContext],
+ heartbeat: int,
max_message_siz... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-13472@9f4c888 | Chia-Network/chia-blockchain | Python | 13,472 | Fix CAT offer aggregation edge case | This addresses https://github.com/Chia-Network/chia-blockchain/issues/13464. Aggregation is not technically a supported feature in our wallet I don't think but since we're providing a reference for it, we best make sure that it works. | 2022-09-16T21:50:00Z | [Bug] invalid hex at 1: 0xa402643c84 when taking an aggregated offer
### What happened?
I have an aggregated offer with net zero arbitrage amounts. However, converting it to a valid spend bundle gives an "invalid hex" error.
Happens in GUI as well, after pressing the button to accept the other party's offer (don'... | It looks like when parsing the cons list of hex numbers in the aggregated offer, multiple hex numbers somehow get improperly concatenated:
SyntaxError: invalid hex at 1: 0xa402643c844ad9048d4a6f9c724077254fa5e1355b7afb06088de4f92ad489a6e9045811e8797a49157ca20510bac62f3e985c5f94fbbfd3d8fbed99886750820000000000008a84**0... | [
{
"body": "### What happened?\r\n\r\nI have an aggregated offer with net zero arbitrage amounts. However, converting it to a valid spend bundle gives an \"invalid hex\" error.\r\n\r\nHappens in GUI as well, after pressing the button to accept the other party's offer (don't have a screenshot, but the error is th... | e8c11d74da3b9c014e666235eba20357d3eb9a79 | {
"head_commit": "9f4c8885441a6693f026f266738ce8eb31a4548e",
"head_commit_message": "Fix CAT offer aggregation edge case",
"patch_to_review": "diff --git a/chia/wallet/trading/offer.py b/chia/wallet/trading/offer.py\nindex 57a574390ea2..a8df7f03ddd2 100644\n--- a/chia/wallet/trading/offer.py\n+++ b/chia/wallet/tr... | [
{
"diff_hunk": "@@ -267,6 +271,11 @@ async def assert_trade_tx_number(wallet_node, trade_id, number):\n assert success is True\n assert trade_take is not None\n \n+ third_offer = Offer.from_bytes(trade_take.offer)\n+ # This tests an edge case where aggregated offers the include thr... | 7d9200b0aeb324868007715f00b90befb3cf574d | diff --git a/chia/wallet/cat_wallet/cat_outer_puzzle.py b/chia/wallet/cat_wallet/cat_outer_puzzle.py
index 3374e27587bf..fbdd4b44546c 100644
--- a/chia/wallet/cat_wallet/cat_outer_puzzle.py
+++ b/chia/wallet/cat_wallet/cat_outer_puzzle.py
@@ -74,7 +74,7 @@ def solve(self, constructor: PuzzleInfo, solver: Solver, inner_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-13298@d1e496f | Chia-Network/chia-blockchain | Python | 13,298 | Add `running_services` command to list all running services | Issue #13313
Added a `running_services` command to return the list of running services registered with the daemon. This complements the existing `is_running` command which only returns a response for a single requested service name.
The request doesn't take any params.
Request:
```{"ack": false, "command": "... | 2022-09-02T01:28:09Z | Optimize daemon `is_running` command to return all services
Currently the `is_running` command takes a single service name and returns a response indicating whether that service is running or not. To reduce traffic/logging, the GUI should be able to request status for all registered services in a single request. | [
{
"body": "Currently the `is_running` command takes a single service name and returns a response indicating whether that service is running or not. To reduce traffic/logging, the GUI should be able to request status for all registered services in a single request.",
"number": 13313,
"title": "Optimize d... | 021e5212553798f1850f28b686be25cc3fe54971 | {
"head_commit": "d1e496f8163c732f7aff7314a4b3b35f4650aabb",
"head_commit_message": "mypy",
"patch_to_review": "diff --git a/chia/daemon/server.py b/chia/daemon/server.py\nindex f54ca6fadbe4..febb09609a16 100644\n--- a/chia/daemon/server.py\n+++ b/chia/daemon/server.py\n@@ -1102,30 +1102,40 @@ async def stop_serv... | [
{
"diff_hunk": "@@ -1102,30 +1102,40 @@ async def stop_service(self, request: Dict[str, Any]) -> Dict[str, Any]:\n return response\n \n async def is_running(self, request: Dict[str, Any]) -> Dict[str, Any]:\n- service_name = request[\"service\"]\n-\n- if service_name == service_plotter... | 7a9158fb76b2f8c28273694b2c7b4259b9e2adb7 | diff --git a/chia/daemon/server.py b/chia/daemon/server.py
index f54ca6fadbe4..8d8040ab8e45 100644
--- a/chia/daemon/server.py
+++ b/chia/daemon/server.py
@@ -326,6 +326,8 @@ async def handle_message(
response = await self.stop_plotting(cast(Dict[str, Any], data))
elif command == "stop_service":
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
Chia-Network__chia-blockchain-14626@38b3f15 | Chia-Network/chia-blockchain | Python | 14,626 | Small improvements to trusted peer check to include IPv6 addresses and add tests | Refactor function `is_trusted_peer` to a standalone easily testable function. Leverage the existing `is_localhost` function to extend coverage to IPv6 local address for the trusted peer check
Added tests for the new standalone function | 2023-02-20T16:30:08Z | [Bug] Wallet does not trust local node over IPv6
### What happened?
If you configure `self-hostname` to be `::1`, or something that resolves to the IPv6 loopback address (for example, `ip6-localhost`) in `config.yaml`, and configure the wallet to use this as the full node peer, the wallet will connect to the node, h... | [
{
"body": "### What happened?\r\n\r\nIf you configure `self-hostname` to be `::1`, or something that resolves to the IPv6 loopback address (for example, `ip6-localhost`) in `config.yaml`, and configure the wallet to use this as the full node peer, the wallet will connect to the node, however, the node is not tr... | 4ed31c50d5be93f35942c0886bf09d9ae0b08ddf | {
"head_commit": "38b3f1568d97bc6e7b789d10cd6dd955aec91ec6",
"head_commit_message": "refactor is_trusted_peer",
"patch_to_review": "diff --git a/chia/server/server.py b/chia/server/server.py\nindex 766201956c7f..5ca5eb90fdbd 100644\n--- a/chia/server/server.py\n+++ b/chia/server/server.py\n@@ -36,7 +36,7 @@\n fro... | [
{
"diff_hunk": "@@ -113,6 +113,13 @@ def is_localhost(peer_host: str) -> bool:\n return peer_host == \"127.0.0.1\" or peer_host == \"localhost\" or peer_host == \"::1\" or peer_host == \"0:0:0:0:0:0:0:1\"\n \n \n+def is_trusted_peer(host: str, node_id: bytes32, trusted_peers: Dict[str, Any], testing: bool =... | 74ab82105185f0ffda49395ad969e2ad80c35288 | diff --git a/chia/cmds/peer_funcs.py b/chia/cmds/peer_funcs.py
index bca2ed5d7d73..e815883a43a9 100644
--- a/chia/cmds/peer_funcs.py
+++ b/chia/cmds/peer_funcs.py
@@ -53,7 +53,7 @@ async def print_connections(rpc_client: RpcClient, trusted_peers: Dict[str, Any]
import time
from chia.server.outbound_messag... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-12990@8dd9c0f | Chia-Network/chia-blockchain | Python | 12,990 | Fix NFT wallet naming issue | 2022-08-15T18:30:45Z | [Bug] Incorrect NFT wallet name
### What happened?
Running on testnet10 with a synced full node, start with a new wallet with some TXCH:
```
chia wallet show
Wallet keys:
1) 502984008
2) * 1239193935 (Synced)
Choose a wallet key [1-2] ('q' to quit, or Enter to use 1239193935):
Wallet height: 1373140
Sync s... | When you create a DID wallet it will create a NFT wallet automatically. You just need to rename it.
I will change the default NFT wallet to [DID_Wallet_Name] + 'NFT Wallet' | [
{
"body": "### What happened?\n\nRunning on testnet10 with a synced full node, start with a new wallet with some TXCH:\r\n\r\n```\r\nchia wallet show\r\nWallet keys:\r\n1) 502984008\r\n2) * 1239193935 (Synced)\r\nChoose a wallet key [1-2] ('q' to quit, or Enter to use 1239193935):\r\nWallet height: 1373140\r\... | dbe79f2139c1fab1e76a9e77ae9a9cf14acb9921 | {
"head_commit": "8dd9c0f5fcebdc0a962bb51165d03ccf10b47e4a",
"head_commit_message": "Fix NFT wallet naming",
"patch_to_review": "diff --git a/chia/rpc/wallet_rpc_api.py b/chia/rpc/wallet_rpc_api.py\nindex c835b89ab9d5..c59336dc3020 100644\n--- a/chia/rpc/wallet_rpc_api.py\n+++ b/chia/rpc/wallet_rpc_api.py\n@@ -54... | [
{
"diff_hunk": "@@ -541,11 +541,12 @@ async def create_new_wallet(self, request: Dict) -> EndpointResult:\n my_did_id = encode_puzzle_hash(\n bytes32.fromhex(did_wallet.get_my_DID()), AddressType.DID.hrp(self.service.config)\n )\n+ ... | bab49eb5c963a7e35db2af4bc1f5e8770e1226f0 | diff --git a/chia/rpc/wallet_rpc_api.py b/chia/rpc/wallet_rpc_api.py
index c835b89ab9d5..4a88725a274c 100644
--- a/chia/rpc/wallet_rpc_api.py
+++ b/chia/rpc/wallet_rpc_api.py
@@ -527,6 +527,9 @@ async def create_new_wallet(self, request: Dict) -> EndpointResult:
metadata = request["metadata"]
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-11732@c8ff558 | Chia-Network/chia-blockchain | Python | 11,732 | streamable: Fix default value assignments for `dataclass_from_dict` | This fixes default value assignments after https://github.com/Chia-Network/chia-blockchain/pull/10561. See the new test in c539809db49e1d0d781b3abda0fc70ede50ca2ef failing without a85be6d72f9b6e9ccb9d462b1bb2c7a590dc6418. But this also leads to worse performance due to `__post_init__` being called which at least gets m... | 2022-06-01T17:10:46Z | [Bug] Chia Farmer not showing plots all betas not showing
### What happened?
Good morning, I installed beta versions 1.3.6174.0, 1.3.6175.0, and 1.3.6179.0 on a test node. None show when selecting the PLOT tab and then the up caret, the plots
### Version
1.3.6179.0
### What platform are you using?
Windows
### Wh... | In version 1.3.6224 still not showing plots....
Are these remote harvesters, or local? Does `chia farm summary` show the plots? Please make sure any remote harvesters are on the same version.
Good evening, This is a farmer with attached disks with plots, as I have been installing these betas and keeping track and post... | [
{
"body": "### What happened?\n\nGood morning, I installed beta versions 1.3.6174.0, 1.3.6175.0, and 1.3.6179.0 on a test node. None show when selecting the PLOT tab and then the up caret, the plots\n\n### Version\n\n1.3.6179.0\n\n### What platform are you using?\n\nWindows\n\n### What ui mode are you using?\n\... | 1dccb682aeba080321e2b6f2516cf76165ca5957 | {
"head_commit": "c8ff5583b35578403c43ea4f229aeaad402a4a5b",
"head_commit_message": "tests: Test default values with `from_json_dict`",
"patch_to_review": "diff --git a/chia/util/streamable.py b/chia/util/streamable.py\nindex acb86e2be685..d65719addc25 100644\n--- a/chia/util/streamable.py\n+++ b/chia/util/stream... | [
{
"diff_hunk": "@@ -145,6 +145,28 @@ def test_dataclass_from_dict_failures(test_class: Type[Any], input_dict: Dict[st\n dataclass_from_dict(test_class, input_dict)\n \n \n+@streamable\n+@dataclass(frozen=True)\n+class TestFromJsonDictDefaultValues(Streamable):\n+ a: uint64 = uint64(1)\n+ b: str = ... | a8e6dc77a7767b25642d3fa02ee3cf44965400af | diff --git a/chia/util/streamable.py b/chia/util/streamable.py
index acb86e2be685..d65719addc25 100644
--- a/chia/util/streamable.py
+++ b/chia/util/streamable.py
@@ -132,7 +132,7 @@ def dataclass_from_dict(klass: Type[Any], item: Any) -> Any:
"""
if type(item) == klass:
return item
- obj = object... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-12261@5e711b2 | Chia-Network/chia-blockchain | Python | 12,261 | Ms.fix coin selection | Two bugs :
1. `test_smallest_coin_over_amount` did not work properly when all coins where smaller than the amount.
2. In the cases where knapsack found a solution but it was too large, we fell back to selecting the "largest coin over the amount" as in issue 1, but instead we should be adding up the largest coins that... | 2022-07-06T06:06:22Z | [Bug] Repeated timeout when trying to send XCH
### What happened?
Attempting to send ~2 XCH from one wallet to another on Win10 Chia 1.4 and getting repeated timeouts on the Tx.
EDIT: Amount accuracy
Never had trouble with this on past versions. Any suggestions? Thanks.
### Version
1.4
### What platf... | Reduced the amount to 1 XCH and same result. The spendable balance in the wallet is more than these amounts.
I reduced the amount even further and it gave the same error (Timeout after 600 seconds), but the Tx actually went through.
I confirm that I am also experiencing crashes of the wallet daemon when trying to sen... | [
{
"body": "### What happened?\r\n\r\nAttempting to send ~2 XCH from one wallet to another on Win10 Chia 1.4 and getting repeated timeouts on the Tx. \r\nEDIT: Amount accuracy \r\n\r\nNever had trouble with this on past versions. Any suggestions? Thanks.\r\n\r\n### Version\r\n\r\n1.4\r\n\r\n### What platform are... | 383326c3b7fcd0d899950697e0766e11a2ce8c8b | {
"head_commit": "5e711b275e178f23de7e77ce23e97a7289330510",
"head_commit_message": "Add another test",
"patch_to_review": "diff --git a/chia/wallet/coin_selection.py b/chia/wallet/coin_selection.py\nindex 92d950acc7c5..ea313e0f6e92 100644\n--- a/chia/wallet/coin_selection.py\n+++ b/chia/wallet/coin_selection.py\... | [
{
"diff_hunk": "@@ -288,3 +355,52 @@ async def test_coin_selection(self, a_hash: bytes32) -> None:\n assert sum([coin.amount for coin in multiple_greater_result]) > target_amount\n assert sum([coin.amount for coin in multiple_greater_result]) == 90000\n assert len(multiple_greater_result... | 71d5c1759a2dfcf234c6dae406e0e40d7046daab | diff --git a/chia/wallet/coin_selection.py b/chia/wallet/coin_selection.py
index 92d950acc7c5..2ce747de7de5 100644
--- a/chia/wallet/coin_selection.py
+++ b/chia/wallet/coin_selection.py
@@ -78,28 +78,31 @@ async def select_coins(
log.debug(f"Selected all smaller coins because they equate to an exact match of ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-10552@117bfd9 | Chia-Network/chia-blockchain | Python | 10,552 | better TLS1.3 check | A better and more compatible TLS check that works on versions of python using a non-openssl TLS library. Examples include the python3 version in Xcode which is using LibreSSL.
See issue #10285 | 2022-03-04T18:53:22Z | [Bug] 1.3 Cannot start farmer on a Mac with python3 from Xcode
### What happened?
Latest version 1.2.12.dev309 on a Mac running BigSur 11.5.2, and latest version of Xcode (13.2.1).
Here is the error when running chia start farmer
```python-traceback
File "/Users/stipus/chia-blockchain/chia/daemon/server.py",... | I just checked the problem is caused by the latest commit to the server.py file.
https://github.com/Chia-Network/chia-blockchain/commit/34d44c1324ae634a0896f7b02eaa2802af9526cd
Thanks for the report, so it looks like the underlying openssl layer would support TLS 1.3 as it's reporting > 1.1.1 version. But the pyth... | [
{
"body": "### What happened?\r\n\r\nLatest version 1.2.12.dev309 on a Mac running BigSur 11.5.2, and latest version of Xcode (13.2.1).\r\n\r\nHere is the error when running chia start farmer\r\n\r\n```python-traceback\r\n File \"/Users/stipus/chia-blockchain/chia/daemon/server.py\", line 1478, in async_run_dae... | 0909fe767299ed194ec4742fe34d0cba242795fe | {
"head_commit": "117bfd9bf8340ab73fe63c7c2a55415f83f9ea9e",
"head_commit_message": "Code simplification and cleanup",
"patch_to_review": "diff --git a/chia/daemon/server.py b/chia/daemon/server.py\nindex 1216d66de4c1..007c3ba86ca2 100644\n--- a/chia/daemon/server.py\n+++ b/chia/daemon/server.py\n@@ -156,18 +156,... | [
{
"diff_hunk": "@@ -156,18 +156,23 @@ def __init__(\n async def start(self):\n self.log.info(\"Starting Daemon Server\")\n \n- if ssl.OPENSSL_VERSION_NUMBER < 0x10101000:\n+ # Note: the minimum_version has been already set to TLSv1_2\n+ # in ssl_context_for_server()\n+ # ... | 7dbb7b17a561e878991aefdade4667eba4d2207b | diff --git a/chia/daemon/server.py b/chia/daemon/server.py
index 1216d66de4c1..1c032f57667b 100644
--- a/chia/daemon/server.py
+++ b/chia/daemon/server.py
@@ -156,18 +156,24 @@ def __init__(
async def start(self):
self.log.info("Starting Daemon Server")
- if ssl.OPENSSL_VERSION_NUMBER < 0x1010100... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-10543@4db27c8 | Chia-Network/chia-blockchain | Python | 10,543 | Detect hints correctly in the TX | Fixes: https://github.com/Chia-Network/chia-blockchain/issues/10537 | 2022-03-03T20:01:48Z | [Bug] missing CAT tokens
### What happened?
CAT tokens that are on the Verified list (Eg. CH21) that have a balance are not showing up automatically after importing from mnemonics. As reported by @cmmarslender
### Version
1.2.12 dev389
### What platform are you using?
Linux
### What ui mode are you using?
CLI
... | [
{
"body": "### What happened?\n\nCAT tokens that are on the Verified list (Eg. CH21) that have a balance are not showing up automatically after importing from mnemonics. As reported by @cmmarslender \n\n### Version\n\n1.2.12 dev389\n\n### What platform are you using?\n\nLinux\n\n### What ui mode are you using?\... | 841754b44494451a9e3e537575eeec431fe533d1 | {
"head_commit": "4db27c8fff13c1636c2dae038eb1aaa2f6e8d31a",
"head_commit_message": "Detect hints correctly in the TX",
"patch_to_review": "diff --git a/chia/wallet/util/compute_hints.py b/chia/wallet/util/compute_hints.py\nindex b6d924bbdcbf..d6e137f7c0a0 100644\n--- a/chia/wallet/util/compute_hints.py\n+++ b/ch... | [
{
"diff_hunk": "@@ -1,34 +1,22 @@\n from typing import List\n \n-from blspy import G2Element\n-\n+from chia.types.blockchain_format.sized_bytes import bytes32\n from chia.types.condition_opcodes import ConditionOpcode\n from chia.types.blockchain_format.program import INFINITE_COST\n from chia.types.coin_spend ... | 3e7d5120ba3b7eeac8a3188b7fa3756ed06de9ad | diff --git a/chia/wallet/util/compute_hints.py b/chia/wallet/util/compute_hints.py
index b6d924bbdcbf..36d35ebd1865 100644
--- a/chia/wallet/util/compute_hints.py
+++ b/chia/wallet/util/compute_hints.py
@@ -1,34 +1,20 @@
from typing import List
-from blspy import G2Element
-
+from chia.types.blockchain_format.sized_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-11167@b2766ef | Chia-Network/chia-blockchain | Python | 11,167 | Resend transactions | This PR periodically resends unconfirmed transactions to peers. This is needed because acceptance of a SpendBundle into the Mempool by a peer does not guarantee that it will be later confirmed, or even transmitted to other peers.
It does this by resetting the remembered results from add to mempool requests that were... | 2022-04-14T00:18:03Z | [Bug] Wallet gets stuck on sending out CAT
### What happened?
Sending out a CAT can sometimes block the wallet and only solution is to sync the wallet DB from 0.
Sending out a cat using CLI "chia wallet send -i 2 ..." sometimes creates a transaction that is stuck in "Status: Pending" forever, when checking it wit... | This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.
Still active
Here is another instance of this happening in which restarting chia solved the problem http... | [
{
"body": "### What happened?\r\n\r\nSending out a CAT can sometimes block the wallet and only solution is to sync the wallet DB from 0.\r\n\r\nSending out a cat using CLI \"chia wallet send -i 2 ...\" sometimes creates a transaction that is stuck in \"Status: Pending\" forever, when checking it with \"chia wal... | d1e445fac2e503ea230acf74ec24a1bb9c529aee | {
"head_commit": "b2766ef471bae920256e4151153420d09d694a9e",
"head_commit_message": "Add wallet resend parameter to config, move timeout code out of tx store, but close to call site",
"patch_to_review": "diff --git a/chia/util/initial-config.yaml b/chia/util/initial-config.yaml\nindex ef6aa9874c35..ffafa9bd52e0 1... | [
{
"diff_hunk": "@@ -141,6 +141,8 @@ def __init__(\n self.validation_semaphore = None\n self.local_node_synced = False\n self.LONG_SYNC_THRESHOLD = 200\n+ self.last_wallet_tx_resend_time: int = 0\n+ self.wallet_tx_resend_timeout_secs: int = 60",
"line": null,
"origin... | 7c3be45fd0654225e5616954eb7f8b600fe95650 | diff --git a/.github/workflows/build-test-macos-wallet.yml b/.github/workflows/build-test-macos-wallet.yml
index dfa776105f89..ae8f5cf2ab31 100644
--- a/.github/workflows/build-test-macos-wallet.yml
+++ b/.github/workflows/build-test-macos-wallet.yml
@@ -95,7 +95,7 @@ jobs:
- name: Test wallet code with pytest
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-8910@3a41934 | Chia-Network/chia-blockchain | Python | 8,910 | EL.Show NFT contract address on plot check | Minor update to display the NFT contract address during `chia plots check` and some formatting changes to improve output
Resolves #8030 | 2021-10-22T20:17:52Z | [BUG] Need to check pool contract address on existing plot
**Describe the bug**
You can see the public farmer key of a plot but not the pool contract address when using chia plots check
**To Reproduce**
Chia plots check, pool address is blank, no area for contract address
**Expected behavior**
Show pool contra... | [
{
"body": "**Describe the bug**\r\nYou can see the public farmer key of a plot but not the pool contract address when using chia plots check\r\n\r\n**To Reproduce**\r\nChia plots check, pool address is blank, no area for contract address\r\n\r\n**Expected behavior**\r\nShow pool contract address",
"number":... | 911d26d3a8b6f86ac0fa3c774eb20a7efd1df089 | {
"head_commit": "3a41934ab2020ef21159618b73497a8d3b51c04b",
"head_commit_message": "Show NFT contract address on plot check",
"patch_to_review": "diff --git a/chia/plotting/check_plots.py b/chia/plotting/check_plots.py\nindex 3a3bf1add829..f2fe3c469742 100644\n--- a/chia/plotting/check_plots.py\n+++ b/chia/plott... | [
{
"diff_hunk": "@@ -102,7 +104,11 @@ def check_plots(root_path, num, challenge_start, grep_string, list_duplicates, d\n for plot_path, plot_info in plot_manager.plots.items():\n pr = plot_info.prover\n log.info(f\"Testing plot {plot_path} k={pr.get_size()}\")\n- log.in... | a3d9eb927524c9f353f6e2448c43fa904390cb0a | diff --git a/chia/plotting/check_plots.py b/chia/plotting/check_plots.py
index 3a3bf1add829..def188d3eef4 100644
--- a/chia/plotting/check_plots.py
+++ b/chia/plotting/check_plots.py
@@ -16,6 +16,7 @@
find_duplicate_plot_IDs,
parse_plot_info,
)
+from chia.util.bech32m import encode_puzzle_hash
from chia.uti... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Chia-Network__chia-blockchain-10146@9adfe90 | Chia-Network/chia-blockchain | Python | 10,146 | Ms.wallet refactor | This is a significant change in how syncing works in the wallet. It is now organized as a queue where one of four things can get processed at once:
* New puzzle hash subscription
* New coin ID subscription
* new_peak_wallet message
* state_update message
The subscriptions are prioritized to ensure we don't miss... | 2022-02-08T17:02:33Z | [enhancement] improve and optimize light wallet sync performance
Improve the reliability of the light wallet sync that enable faster sync times and better handling of wallets with large number of coins (~ up to 500) and medium # of transactions (~ up to 2000) and ensure accuracy of what is reported in the wallet.
Va... | [
{
"body": "Improve the reliability of the light wallet sync that enable faster sync times and better handling of wallets with large number of coins (~ up to 500) and medium # of transactions (~ up to 2000) and ensure accuracy of what is reported in the wallet.\r\n\r\nValues are arbitrary and only used to convey... | e47958605a8ed360f07591d14b59a468f26f00ad | {
"head_commit": "9adfe9057b05328569ceaf0ee3a26a6dacdef34d",
"head_commit_message": "Merge branch 'main' into ms.wallet_refactor\n\n# Conflicts:\n#\tchia/wallet/wallet_node.py\n#\tchia/wallet/wallet_state_manager.py",
"patch_to_review": "diff --git a/chia/cmds/show.py b/chia/cmds/show.py\nindex c28197292411..20e4... | [
{
"diff_hunk": "@@ -0,0 +1,17 @@\n+from typing import List\n+\n+from chia.protocols.wallet_protocol import CoinState\n+\n+\n+def filter_coin_states(all_coins_state: List[CoinState], fork_height: int) -> List[CoinState]:\n+ # We only want to apply changes before the fork point, since we are synced to another ... | 0af30dea40d6f37b3a896d89f0cc2a6c28d79e33 | diff --git a/chia/cmds/show.py b/chia/cmds/show.py
index c28197292411..20e47d33959a 100644
--- a/chia/cmds/show.py
+++ b/chia/cmds/show.py
@@ -1,8 +1,58 @@
-from typing import Any, Optional, Union
+from typing import Any, Optional, Union, Dict
from chia.types.blockchain_format.sized_bytes import bytes32
import clic... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
Chia-Network__chia-blockchain-13371@7768035 | Chia-Network/chia-blockchain | Python | 13,371 | Add a try/except for individual coin states | This looks like a big change but really it's just a big tab to put a large chunk of code inside a try/except. Currently, if a single state fails during new_coin_state, an exception will be raised to the wallet node which will log an error and then return that it failed to receive the state at all (even though my under... | 2022-09-07T20:10:45Z | Wallet syncing in an infinity loop [[Bug]
### What happened?
Hi,
My wallet has over 6k NFTs, and suddenly it's not able to get synced. I'm getting always: "ERROR Error adding states" and my it tries to "perform_atomic_rollback" without success in an infinity loop...
I tried deleting my db and differents PC... | Can you provide a log (debug.log file) and sent it to me privately on keybase (sorgente711) or to trepca. @trepca
you might be hitting some rate limits on `request_puzzle_solution` locally and timing out..
> Can you provide a log (debug.log file) and sent it to me privately on keybase (sorgente711) or to trepca. @trep... | [
{
"body": "### What happened?\r\n\r\nHi,\r\n\r\nMy wallet has over 6k NFTs, and suddenly it's not able to get synced. I'm getting always: \"ERROR Error adding states\" and my it tries to \"perform_atomic_rollback\" without success in an infinity loop...\r\n\r\nI tried deleting my db and differents PCs with f... | 2b2a1e8646b5a6b335edefa8e5ec3d67d9964bee | {
"head_commit": "7768035050af59b7b3140f53e1e50adb9babbd4a",
"head_commit_message": "tiny bad merge",
"patch_to_review": "diff --git a/chia/wallet/wallet_node.py b/chia/wallet/wallet_node.py\nindex 968d2e328360..37cdb5670f15 100644\n--- a/chia/wallet/wallet_node.py\n+++ b/chia/wallet/wallet_node.py\n@@ -130,6 +13... | [
{
"diff_hunk": "@@ -932,331 +937,355 @@ async def new_coin_state(\n \n assert len(local_records) == len(coin_states)\n for coin_state, local_record in zip(coin_states, local_records):\n- existing: Optional[WalletCoinRecord]\n- coin_name: bytes32 = coin_state.coin.name()\n- ... | c4f37c3c27fb8305c2eb4c446e663a2e01c2523f | diff --git a/chia/wallet/util/wallet_sync_utils.py b/chia/wallet/util/wallet_sync_utils.py
index f3bd5fcf9a67..2113b9c6713b 100644
--- a/chia/wallet/util/wallet_sync_utils.py
+++ b/chia/wallet/util/wallet_sync_utils.py
@@ -38,6 +38,10 @@
log = logging.getLogger(__name__)
+class PeerRequestException(Exception):
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-8844@b8d8644 | Chia-Network/chia-blockchain | Python | 8,844 | List unopenable plots at end of plots check | Closes https://github.com/Chia-Network/chia-blockchain/issues/2825 | 2021-10-16T17:23:20Z | [BUG-MINOR] plots marked as "Invalid plot header magic" are not included in summary by `chia plots check`
The fact that chia seems to be randomly taking some plots with "Invalid plot header magic" aside, it is also not reporting these plots as invalid in the `chia plots check` summary:
```
(venv) speedster@cohen:~... | Same here
This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.
chia dev team would need to update if they fixed
> chia dev team would need to update if they fixed
Hi @fiveangle, have you plo... | [
{
"body": "The fact that chia seems to be randomly taking some plots with \"Invalid plot header magic\" aside, it is also not reporting these plots as invalid in the `chia plots check` summary:\r\n\r\n```\r\n(venv) speedster@cohen:~$ chia plots check -n 100 -g /farm/acre26/plots/chachacha-plot-k32-2021-04-24-0... | 732fb51fe0f5e40407a4e6f2e50044b9922d313a | {
"head_commit": "b8d864443bb3a4ecd34ba5ec11bc001e1b03bade",
"head_commit_message": "drop .keys() in len() check",
"patch_to_review": "diff --git a/chia/plotting/check_plots.py b/chia/plotting/check_plots.py\nindex b1d8291e53bd..f2b4d8f3017c 100644\n--- a/chia/plotting/check_plots.py\n+++ b/chia/plotting/check_pl... | [
{
"diff_hunk": "@@ -175,11 +174,17 @@ def check_plots(root_path, num, challenge_start, grep_string, list_duplicates, d\n log.info(f\"Found {total_plots} valid plots, total size {total_size / (1024 * 1024 * 1024 * 1024):.5f} TiB\")\n for (k, count) in sorted(dict(total_good_plots).items()):\n log... | 0a27976a8aa8066e3bbd8b5b664a3f03c3c07821 | diff --git a/chia/plotting/check_plots.py b/chia/plotting/check_plots.py
index b1d8291e53bd..905eb22c0b73 100644
--- a/chia/plotting/check_plots.py
+++ b/chia/plotting/check_plots.py
@@ -94,7 +94,6 @@ def check_plots(root_path, num, challenge_start, grep_string, list_duplicates, d
log.info("")
log.inf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-8109@1dc2272 | Chia-Network/chia-blockchain | Python | 8,109 | Check AttributeError for non-Optional members during node shutdown | During node shutdown some AttributeErrors could be thrown if the shutdown happens before the node fully started up. Checks against None are not applicable as the attributes in question were not declared Optional and not initialized to None. Added hasattr checks
See #7553 | 2021-08-17T21:59:40Z | [BUG] AttributeError: 'FullNode' object has no attribute 'blockchain'
**To Reproduce**
OS Version: Freebsd 12.2 Release P9
Built From source following wiki guide, using python3.8 instead of 3.7 and clvm_rs 0.1.8
Chia version: Latest - 1.2.3.dev0
**Expected behavior**
Probably shouldn't have a traceback why tryin... | it happens to me too since 1.2+ update . i just run a script with 'chia start farmer' on each system reboot, and most times full node won't start normally, so i have to restart it manually and see "AttributeError: 'FullNode' object has no attribute 'blockchain'" message upon restarting... tried to redownload and rebuil... | [
{
"body": "**To Reproduce**\r\nOS Version: Freebsd 12.2 Release P9\r\nBuilt From source following wiki guide, using python3.8 instead of 3.7 and clvm_rs 0.1.8\r\nChia version: Latest - 1.2.3.dev0\r\n\r\n**Expected behavior**\r\nProbably shouldn't have a traceback why trying to stop the full node\r\n\r\n**Screen... | 5ee182932ed94b2bf0f32c8df818931fa92fef30 | {
"head_commit": "1dc22726d225a7bebf4b55b974740c72e72c0017",
"head_commit_message": "Check AttributeError for non-Optional elements",
"patch_to_review": "diff --git a/chia/full_node/full_node.py b/chia/full_node/full_node.py\nindex 24781e7ce2af..24b9a998f050 100644\n--- a/chia/full_node/full_node.py\n+++ b/chia/f... | [
{
"diff_hunk": "@@ -557,10 +557,17 @@ def _close(self):\n self._shut_down = True\n if self._init_weight_proof is not None:\n self._init_weight_proof.cancel()\n- if self.blockchain is not None:\n+ # blockchain is created in _start and in certain cases it may not exist he... | cdc6665e089af58f79952ae22c1bfed440923e01 | diff --git a/chia/full_node/full_node.py b/chia/full_node/full_node.py
index 24781e7ce2af..938487d232c8 100644
--- a/chia/full_node/full_node.py
+++ b/chia/full_node/full_node.py
@@ -557,10 +557,14 @@ def _close(self):
self._shut_down = True
if self._init_weight_proof is not None:
self._i... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Chia-Network__chia-blockchain-15342@5b73926 | Chia-Network/chia-blockchain | Python | 15,342 | Added: Support CLI NFT Pagination | Closes #15260
Following the instructions in issue #15260, exposed `count` (as `--num`) and `start_index` (as `--start-index`) through to `nft_get_nfts` rpc call via the `chia wallet nft list ...` command.
Issue #15260 is assigned to @paninaro and any work by them for this issue can take precedence. The issue doe... | 2023-05-22T02:10:59Z | CLI nft listing doesn't support pagination
When listing NFTs on the CLI, the number of returned NFTs is capped at 50 due to the RPC hardcoding a default `num` value. Since the CLI doesn't expose `--start-index` and `--num` options, there's no way to get a complete listing for collections > 50 NFTs.
Should be a simpl... | [
{
"body": "When listing NFTs on the CLI, the number of returned NFTs is capped at 50 due to the RPC hardcoding a default `num` value. Since the CLI doesn't expose `--start-index` and `--num` options, there's no way to get a complete listing for collections > 50 NFTs.\r\n\r\nShould be a simple change to expose t... | 1d8d4760565dd99e4da6b35a46e7a00298302039 | {
"head_commit": "5b73926ed514639a0b4772f04d621b16ee2593ee",
"head_commit_message": "Merge branch 'Chia-Network:main' into 15260-nft-pagination-with-args-exposed-to-rpc-nft_get_nfts",
"patch_to_review": "diff --git a/chia/cmds/wallet.py b/chia/cmds/wallet.py\nindex 2acd0eae837e..9288ff80fe65 100644\n--- a/chia/cm... | [
{
"diff_hunk": "@@ -1139,12 +1139,14 @@ def nft_transfer_cmd(\n )\n @click.option(\"-f\", \"--fingerprint\", help=\"Set the fingerprint to specify which key to use\", type=int)\n @click.option(\"-i\", \"--id\", help=\"Id of the NFT wallet to use\", type=int, required=True)\n-def nft_list_cmd(wallet_rpc_port: Op... | 3f5c6297c349962c34ec4edda379fb248f2f6566 | diff --git a/chia/cmds/wallet.py b/chia/cmds/wallet.py
index 69ef56d60f89..1b78b5082cc9 100644
--- a/chia/cmds/wallet.py
+++ b/chia/cmds/wallet.py
@@ -1164,10 +1164,12 @@ def nft_transfer_cmd(
)
@click.option("-f", "--fingerprint", help="Set the fingerprint to specify which key to use", type=int)
@click.option("-i",... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
EleutherAI__lm-evaluation-harness-2139@fb4d83c | EleutherAI/lm-evaluation-harness | Python | 2,139 | bugfix and docs for API | closes #2138 and also added the option to add a custom tokenizer path. Also added an explainer to alleviate confusion. | 2024-07-26T17:14:54Z | Bug when hashing prompt when using openai-chatcompletions and log_samples
When I use openai-chatcompletions with --apply_chat_template and log_samples, it encounters an error
```
Traceback (most recent call last):
File "/root/anaconda3/envs/dschat/bin/lm_eval", line 8, in <module>
sys.exit(cli_evaluate())
... | Sorry about that. The PR should fix it! | [
{
"body": "When I use openai-chatcompletions with --apply_chat_template and log_samples, it encounters an error \r\n```\r\nTraceback (most recent call last):\r\n File \"/root/anaconda3/envs/dschat/bin/lm_eval\", line 8, in <module>\r\n sys.exit(cli_evaluate())\r\n File \"/home/xxx/lm-evaluation-harness-fla... | 42dc244867889a19ae80847254a481f446f6e4b7 | {
"head_commit": "fb4d83c9bf8126ce7b43bcded03010f292613240",
"head_commit_message": "Update API_guide.md",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 1fbec92d9b..2eb3b1775d 100644\n--- a/README.md\n+++ b/README.md\n@@ -6,7 +6,7 @@\n \n *Latest News 📣*\n \n-- [2024/07] API model support has bee... | [
{
"diff_hunk": "@@ -0,0 +1,198 @@\n+# TemplateAPI Usage Guide\n+\n+The `TemplateAPI` class is a versatile superclass designed to facilitate the integration of various API-based language models into the lm-evaluation-harness framework. This guide will explain how to use and extend the `TemplateAPI` class to impl... | 6e5ddd6538cff789ddc547d69644a770a5fe3358 | diff --git a/README.md b/README.md
index 1fbec92d9b..2eb3b1775d 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@
*Latest News 📣*
-- [2024/07] API model support has been updated and refactored, introducing support for batched and async requests, and making it significantly easier to customize and use for you... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
EleutherAI__lm-evaluation-harness-1893@e0e7305 | EleutherAI/lm-evaluation-harness | Python | 1,893 | `higher_is_better` tickers in output table | # What does this PR do?
This PR adds ticker symbols (↑/↓) for each metric in the output table.
Addresses #1153
# How does it work?
On the task level, for each metric I take the specified `higher_is_better` value, and append it to the output table.
On the group level, I first check whether the metrics fo... | 2024-05-27T15:08:15Z | Print "higher_is_better" in results table
We should add a column to the printed results table, that displays an arrow pointing up if the metric's `"higher_is_better"` value is True, arrow pointing down otherwise.
Currently `higher_is_better` is not really used in the code. | This can be a part of #1158 | [
{
"body": "We should add a column to the printed results table, that displays an arrow pointing up if the metric's `\"higher_is_better\"` value is True, arrow pointing down otherwise. \n\nCurrently `higher_is_better` is not really used in the code.",
"number": 1153,
"title": "Print \"higher_is_better\" ... | 0ff6ab9973508e0444085f0c92f1b7f47f381077 | {
"head_commit": "e0e7305c90fffc086ee713e823cd79ba8163e4d6",
"head_commit_message": "add extra check for `higher_is_better` not being None already",
"patch_to_review": "diff --git a/lm_eval/evaluator.py b/lm_eval/evaluator.py\nindex 95e018a508..ae269315ea 100644\n--- a/lm_eval/evaluator.py\n+++ b/lm_eval/evaluato... | [
{
"diff_hunk": "@@ -516,6 +522,21 @@ def evaluate(\n # or `task_name: []`.\n # we only want to operate on groups here.\n continue\n+\n+ _higher_is_better = deepcopy(higher_is_better[task_list[0]])\n+ for task in task_list:... | 1e0c56355ab1e82286d8eef5cc515c509895b0ef | diff --git a/lm_eval/evaluator.py b/lm_eval/evaluator.py
index 95e018a508..b70926b6ae 100644
--- a/lm_eval/evaluator.py
+++ b/lm_eval/evaluator.py
@@ -503,9 +503,14 @@ def evaluate(
# aggregate results ; run bootstrap CIs
for task_output in eval_tasks:
task_output.calculate_aggregate_metr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
EleutherAI__lm-evaluation-harness-1364@7d3b5ff | EleutherAI/lm-evaluation-harness | Python | 1,364 | Support for Inf2 optimum class [WIP] | Adding support for inferntia.
Closes: #1343 | 2024-01-28T06:37:09Z | Contributing AWS Inferentia Code
We at Gradient are using primarily the AWS inf2 instances. Our code is based of the `big-refactor` (v0.4.0) branch and adds a new model.
Tested them for `generate_until`, `loglikelihood` requests. There is currently no support for some generation_kwargs such as beam search afaik.
... | Hi! Thank you for your interest in the framework!
Yes, I think we'd be happy to support this model type. If you all could also contribute tests for this model type along with it to minimize the extra maintenance / overhead that supporting this model would require then that would be ideal.
I see `transformers-neur... | [
{
"body": "We at Gradient are using primarily the AWS inf2 instances. Our code is based of the `big-refactor` (v0.4.0) branch and adds a new model. \r\n\r\nTested them for `generate_until`, `loglikelihood` requests. There is currently no support for some generation_kwargs such as beam search afaik.\r\n\r\nSo fa... | 7411947112117e0339fe207fb620a70bcec22690 | {
"head_commit": "7d3b5ffee4301efe66df2d4052c8907c9bfb749d",
"head_commit_message": "initial commit",
"patch_to_review": "diff --git a/lm_eval/models/__init__.py b/lm_eval/models/__init__.py\nindex 0903077939..a87870d2df 100644\n--- a/lm_eval/models/__init__.py\n+++ b/lm_eval/models/__init__.py\n@@ -7,5 +7,5 @@\n... | [
{
"diff_hunk": "@@ -0,0 +1,756 @@\n+import copy\n+import json\n+import logging\n+import subprocess\n+from collections import defaultdict\n+from typing import List, Optional, Union\n+\n+import torch\n+import torch.nn.functional as F\n+import transformers\n+from packaging import version\n+from tqdm import tqdm\n+... | a594895aa52d4b5106d80fd0ac4fa8ab32f9e8f6 | diff --git a/README.md b/README.md
index 06b0845778..e0da1d8f2c 100644
--- a/README.md
+++ b/README.md
@@ -45,6 +45,7 @@ git clone https://github.com/EleutherAI/lm-evaluation-harness
cd lm-evaluation-harness
pip install -e .
```
+
We also provide a number of optional dependencies for extended functionality. A detai... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-12168@3ec75ab | BerriAI/litellm | Python | 12,168 | fix: support Cursor IDE tool_choice format {"type": "auto"} | ## Title
Support Cursor IDE tool_choice format {"type": "auto"}
## Relevant issues
Fixes #12098
## Pre-Submission checklist
**Please complete all items before asking a LiteLLM maintainer to review your PR**
- [x] I have Added testing in the [`tests/litellm/`](https://github.com/BerriAI/litellm/tree/main/tests/lit... | 2025-06-30T15:42:04Z | [Bug]: Cursor IDE compatibility: tool_choice validation error when using {"type": "auto"} format - should support both OpenAI specs
### What happened?
I'm encountering an API validation error when using LiteLLM as a proxy for Claude models through Cursor IDE. The issue occurs when Cursor sends requests with `tool_choi... | [
{
"body": "### What happened?\n\nI'm encountering an API validation error when using LiteLLM as a proxy for Claude models through Cursor IDE. The issue occurs when Cursor sends requests with `tool_choice: {\"type\": \"auto\"}` format, which LiteLLM rejects as invalid.\n\n**Setup:**\n- LiteLLM deployed as API pr... | f76375b65131f2dccb601995d7c5eabc3d5884fd | {
"head_commit": "3ec75ab9123aad27e1085e1215bf9c19f686b7a5",
"head_commit_message": "fix: support Cursor IDE tool_choice format {\"type\": \"auto\"}\n\n- Update validate_chat_completion_tool_choice to normalize {\"type\": \"auto\"} to \"auto\"\n- Handles Cursor IDE sending non-standard tool_choice format\n- Add com... | [
{
"diff_hunk": "@@ -6571,6 +6571,14 @@ def validate_chat_completion_tool_choice(\n elif isinstance(tool_choice, str):\n return tool_choice\n elif isinstance(tool_choice, dict):\n+ # Handle Cursor IDE format: {\"type\": \"auto\"} -> \"auto\"\n+ if (\n+ tool_choice.get(\"t... | 1a6ff128aa6568b86e1686cc0c2cdee7109e676e | diff --git a/litellm/utils.py b/litellm/utils.py
index 43f2b6c3f9f5..621221be1bb8 100644
--- a/litellm/utils.py
+++ b/litellm/utils.py
@@ -6571,6 +6571,14 @@ def validate_chat_completion_tool_choice(
elif isinstance(tool_choice, str):
return tool_choice
elif isinstance(tool_choice, dict):
+ # ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
EleutherAI__lm-evaluation-harness-1321@12bc8fc | EleutherAI/lm-evaluation-harness | Python | 1,321 | Faster Task and Group Loading, Allow Recursive Groups | @haileyschoelkopf this is still a work in progress, but feel free to test this out. It makes task loading faster because the loading part only happens to list of task that the users want to evaluate. The `initialize_task()` is only for indexing.
Updates:
1. Faster task/group loading. Only the tasks that are set ... | 2024-01-19T16:12:42Z | Evaluation Error on Scrolls Task - 2
I am trying to evaluate LLM on long text understanding.
I encountered the following error.
I tried to resolve minor bugs but couldn't resolve this one.
First I faced this issue
`acc_norm = 1.0 if np.argmax(results / completion_len) == gold else 0.0
... | Are you using `limit 1` for the second error? Might be because it divides by N - 1 to calculate the sample standard deviation.
cc @lintangsutawika
Yeah, division by zero looks like an error from using only 1 sample. I should patch that.
Yes, thanks. Indeed using limit 1 was the issue. The issue is gone but I have e... | [
{
"body": "I am trying to evaluate LLM on long text understanding. \r\nI encountered the following error. \r\nI tried to resolve minor bugs but couldn't resolve this one. \r\n\r\nFirst I faced this issue\r\n`acc_norm = 1.0 if np.argmax(results / completion_len) == gold else 0.0\r\n ... | 17191063c2cf01c2c1514ed7bbe3598bacb5ff51 | {
"head_commit": "12bc8fce72f5bbf5ed91a0f427218dda4dc21daa",
"head_commit_message": "removed unused code",
"patch_to_review": "diff --git a/lm_eval/__main__.py b/lm_eval/__main__.py\nindex 37fdabc6df..f001a4ab97 100644\n--- a/lm_eval/__main__.py\n+++ b/lm_eval/__main__.py\n@@ -10,8 +10,7 @@\n import numpy as np\n... | [
{
"diff_hunk": "@@ -479,12 +482,14 @@ def evaluate(\n if \"alias\" in metrics:\n metrics.pop(\"alias\")\n \n- current_size = metrics.pop(\"samples\")\n # TODO: There should be a way for users\n ... | aac8bcd911956efffbfa40195bbae4cb46dd62e2 | diff --git a/docs/interface.md b/docs/interface.md
index 6f750366f7..72ae59e188 100644
--- a/docs/interface.md
+++ b/docs/interface.md
@@ -61,14 +61,25 @@ import lm_eval
my_model = initialize_my_model() # create your model (could be running finetuning with some custom modeling code)
...
-lm_obj = Your_LM(model=my_m... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
BerriAI__litellm-10370@a043105 | BerriAI/litellm | Python | 10,370 | Fix Slack alerting not working if using a DB | ## Title
Fix Slack alerting not working if using a DB.
## Relevant issues
Fixes #10368
## Pre-Submission checklist
**Please complete all items before asking a LiteLLM maintainer to review your PR**
- [X] I have Added testing in the [`tests/litellm/`](https://github.com/BerriAI/litellm/tree/main/tests... | 2025-04-27T19:25:13Z | [Bug]: Slack reporting's periodic batch send is never initialized if using a DB.
### What happened?
For Slack alerting the periodic task for the CustomBatchLogger is never initialized if using a DB because alerting is never set in updateValues calls. Therefore Slack alerts never happen until 512 queue up. The UT te... | PR to fix here: https://github.com/BerriAI/litellm/pull/10370 | [
{
"body": "### What happened?\n\nFor Slack alerting the periodic task for the CustomBatchLogger is never initialized if using a DB because alerting is never set in updateValues calls. Therefore Slack alerts never happen until 512 queue up. The UT test button doesnt appear to work because of it.\n\n### Releva... | 6d27c1e6111dc2c585cca2ab2398e5e37b1da2a0 | {
"head_commit": "a043105e4a39c7f24db4b509c2e4c813d500a3bd",
"head_commit_message": "Add a unit test for the change",
"patch_to_review": "diff --git a/litellm/integrations/SlackAlerting/slack_alerting.py b/litellm/integrations/SlackAlerting/slack_alerting.py\nindex 9fde042ae79b..1d4eeb04ddea 100644\n--- a/litellm... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "tests/litellm/integrations/test_slack.py",
"start_line": null,
"text": "@user1:\nfollow same naming convention + filepath as in `litellm/` \r\n\r\nso it should be `tests/litellm/integrations/Sla... | 1e5416b140b3157fa270e3bd76ba0cace4c9d8ce | diff --git a/litellm/integrations/SlackAlerting/slack_alerting.py b/litellm/integrations/SlackAlerting/slack_alerting.py
index 7e7aa4d370ee..16305061ec86 100644
--- a/litellm/integrations/SlackAlerting/slack_alerting.py
+++ b/litellm/integrations/SlackAlerting/slack_alerting.py
@@ -85,6 +85,7 @@ def __init__(
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
EleutherAI__lm-evaluation-harness-1156@05d5fbf | EleutherAI/lm-evaluation-harness | Python | 1,156 | add bypass metric | Started on #1152. Couple of issues:
- [x] Cannot amend `metric_list` in evaluate
- [x] print results crashing
- [x] repeated generations are not saved in `log_samples` | 2023-12-18T15:55:12Z | Add `--predict_only` mode (run without scoring outputs)
As asked for by @dwadden from AI2.
We should support a CLI flag, `--predict_only`, which causes model outputs to be produced and saved, but to exit while reporting metric = `N/A` for all metrics. This is a useful feature in general.
This could also be extended, ... | cc @StellaAthena --would you be willing to allow for us to support code generation benchmarks if we did not perform the code generation online, and just supported the ability to "dry-run" the model outputs?
I think this would be a good medium where we can still support code tasks (which are in high demand and people w... | [
{
"body": "As asked for by @dwadden from AI2.\n\nWe should support a CLI flag, `--predict_only`, which causes model outputs to be produced and saved, but to exit while reporting metric = `N/A` for all metrics. This is a useful feature in general.\n\nThis could also be extended, if we so desire, to code executio... | a0a2fec8dc0c7da009029640d3316cb1091ee1c1 | {
"head_commit": "05d5fbf0f12a2b6037a7129d6a8ceb754ff36957",
"head_commit_message": "add docs",
"patch_to_review": "diff --git a/lm_eval/__main__.py b/lm_eval/__main__.py\nindex ebb1b6c4ab..2dc1c00449 100644\n--- a/lm_eval/__main__.py\n+++ b/lm_eval/__main__.py\n@@ -142,6 +142,13 @@ def parse_eval_args() -> argpa... | [
{
"diff_hunk": "@@ -130,6 +134,17 @@ def simple_evaluate(\n continue\n \n config = task_obj._config\n+ if predict_only:\n+ log_samples = True\n+ eval_logger.info(\n+ f\"Processing {task_name} in output-only mode. Metrics will not be calculated!... | bb1d1fa287a45c4d1866891f6f12c1b07f97d8c6 | diff --git a/README.md b/README.md
index 67fb450b1f..b8b3c34119 100644
--- a/README.md
+++ b/README.md
@@ -45,27 +45,7 @@ git clone https://github.com/EleutherAI/lm-evaluation-harness
cd lm-evaluation-harness
pip install -e .
```
-
-We also provide a number of optional dependencies for extended functionality. Extras... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-11645@a5a1957 | BerriAI/litellm | Python | 11,645 | [Feat] MCP expose streamable https endpoint for LiteLLM Proxy | ## [Feat] MCP expose streamable https endpoint for LiteLLM Proxy
Closes https://github.com/BerriAI/litellm/issues/11603
This PR exposes a streamable HTTPS endpoint for the LiteLLM Proxy MCP serve
h/t @wagnerjt for the initial scoping work and help on this
<!-- e.g. "Implement user authentication feature" --... | 2025-06-12T01:21:04Z | [Feature]: Upgrade to the MCP streamable http transport
### The Feature
Upgrade allowing SSE and the newer streamable http support
### Motivation, pitch
No lag behind
### LiteLLM is hiring a founding backend engineer, are you interested in joining us and shipping to all our users?
No
### Twitter / LinkedIn detail... | What is the ETA on this? @wagnerjt @ishaan-jaff | [
{
"body": "### The Feature\n\nUpgrade allowing SSE and the newer streamable http support\n\n### Motivation, pitch\n\nNo lag behind\n\n### LiteLLM is hiring a founding backend engineer, are you interested in joining us and shipping to all our users?\n\nNo\n\n### Twitter / LinkedIn details\n\n_No response_",
... | 02b02c739bb7cec08a4b21361e7258c36671541b | {
"head_commit": "a5a195763c387597faa12d841b247f6e369db628",
"head_commit_message": "Update litellm/proxy/_experimental/mcp_server/server.py\n\nCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>",
"patch_to_review": "diff --git a/litellm/constants.py b/litellm/constants.py\nindex c4adb09dc6ab..c... | [
{
"diff_hunk": "@@ -76,9 +89,80 @@ class ListMCPToolsRestAPIResponseObject(MCPTool):\n ########################################################\n ############ Initialize the MCP Server #################\n ########################################################\n- server: Server = Server(\"litell... | d4b8ef72702eb47aa0b4b828065a18d7c3919915 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 6e51e9ac7141..a1908d476b08 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1238,6 +1238,7 @@ jobs:
pip install "pytest-asyncio==0.21.1"
pip install "pytest-cov==5.0.0"
pip install "tomli==2.2.1"
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Chia-Network__chia-blockchain-15718@50d54cb | Chia-Network/chia-blockchain | Python | 15,718 | Refactor CLI by adding add new click types for fees, amounts, addresses and bytes32 | <!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complex... | 2023-07-09T04:30:13Z | [Bug] Combining coins with fee
### What happened?
The user wants to combine coins using
1. Run CLI combine
`chia wallet coins combine -f 1269832460 --number-of-coins 100 --id 25 --fee 0.0000001`
2. Response:
```
Combining 7 coins.
Would you like to Continue? (y/n): y
```
3. Response:
```
Exception fr... | [
{
"body": "### What happened?\r\n\r\nThe user wants to combine coins using\r\n\r\n1. Run CLI combine\r\n`chia wallet coins combine -f 1269832460 --number-of-coins 100 --id 25 --fee 0.0000001`\r\n\r\n2. Response:\r\n```\r\nCombining 7 coins.\r\nWould you like to Continue? (y/n): y\r\n```\r\n\r\n3. Response:\r\n`... | 2e82142396dfe92ac5b984b625abd6c83060490f | {
"head_commit": "50d54cb614e65324b9856d511e23e1e08caac44e",
"head_commit_message": "Update chia/cmds/param_types.py\n\nCo-authored-by: Kyle Altendorf <sda@fstab.net>",
"patch_to_review": "diff --git a/chia/cmds/coin_funcs.py b/chia/cmds/coin_funcs.py\nindex ace88131f206..01f7f82716f2 100644\n--- a/chia/cmds/coin... | [
{
"diff_hunk": "@@ -0,0 +1,166 @@\n+from __future__ import annotations\n+\n+from dataclasses import dataclass\n+from decimal import Decimal, InvalidOperation\n+from typing import Any, Optional, Union\n+\n+import click\n+\n+from chia.cmds.units import units\n+from chia.types.blockchain_format.sized_bytes import ... | 05938bfef375313ae3b3d61a777c29950b5e3933 | diff --git a/chia/_tests/cmds/test_click_types.py b/chia/_tests/cmds/test_click_types.py
new file mode 100644
index 000000000000..45184132c443
--- /dev/null
+++ b/chia/_tests/cmds/test_click_types.py
@@ -0,0 +1,193 @@
+from __future__ import annotations
+
+from decimal import Decimal
+from pathlib import Path
+from typ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
EleutherAI__lm-evaluation-harness-922@0085982 | EleutherAI/lm-evaluation-harness | Python | 922 | [Refactor] Mmlu subgroups and weight avg | 1. Further splits MMLU into 4 subcategories instead of just aggregating over all subtasks.
2. Add weighted averaging and stderr. | 2023-10-16T14:28:35Z | Add mmlu average score in report
Currently I am using hendrycksTest-* for measuring the performance on MMLU. However, the scores are reported for each single task. It would much more convenient if there are scores for each subcategory and average score. Also, MMLU might be a more well known name compared with hendrycks... | any progress on this average score?
@lintangsutawika is working on this! | [
{
"body": "Currently I am using hendrycksTest-* for measuring the performance on MMLU. However, the scores are reported for each single task. It would much more convenient if there are scores for each subcategory and average score. Also, MMLU might be a more well known name compared with hendrycksTest. Is it po... | ae74b808e43cd1ee6d88a157777f27eacd6b12dc | {
"head_commit": "00859825db00aee796be74292ea869978225f1e9",
"head_commit_message": "added stderr reprocessing for groups",
"patch_to_review": "diff --git a/lm_eval/evaluator.py b/lm_eval/evaluator.py\nindex bf35097c5b..5d923b1db9 100644\n--- a/lm_eval/evaluator.py\n+++ b/lm_eval/evaluator.py\n@@ -449,23 +449,8 @... | [
{
"diff_hunk": "@@ -481,18 +466,37 @@ def evaluate(\n results[task_name][metric + \"_stderr\" + \",\" + key] = stderr(items)\n \n if bool(results):\n- for task_or_group in results.keys():\n- for metric in results[task_or_group].keys():\n- ... | 44124d95a25195da0a3d129dddabb37c43ba5ce2 | diff --git a/docs/new_task_guide.md b/docs/new_task_guide.md
index 6b30bfc977..86966be541 100644
--- a/docs/new_task_guide.md
+++ b/docs/new_task_guide.md
@@ -50,7 +50,7 @@ dataset_kwargs: null # any extra keyword arguments that should be passed to the
```
dataset_path: json
dataset_name: null
-dataset_kwargs:
+dat... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
EleutherAI__lm-evaluation-harness-1372@ed26115 | EleutherAI/lm-evaluation-harness | Python | 1,372 | Create a means for caching task registration and request building. Ad… | Hey all, here's the caching proposal for task registration and request building.
Caching is optional, and has rewrite capabilities for task building and for task registration.
It works by using pickles, and by default all pickles are stored in lm_harness/caching/.cache. You can specify an alternate path via the e... | 2024-01-31T02:51:08Z | Is there a way to cache the building of datasets?
Hey all, once again, excellent framework.
I'm using the framework programatically.
I wrote code to do this myself, but I want to make sure I'm not being stupid and wanted to check that the package doesn't already support this.
I know it supports the caching of ... | Hi! Thank you for using the framework and for being interested in contributing!
I think it'd certainly be worthwhile to put that caching code in a fork and we can look to see if it makes sense to PR it.
I think this would be a huge improvement for the mentioned reasons (minimizing non-inference runtimes and maki... | [
{
"body": "Hey all, once again, excellent framework.\r\n\r\nI'm using the framework programatically.\r\n\r\nI wrote code to do this myself, but I want to make sure I'm not being stupid and wanted to check that the package doesn't already support this.\r\n\r\nI know it supports the caching of results from LLMs t... | f6befdb9ca9babbda9fda75854672b380d7e5aa2 | {
"head_commit": "ed26115d1230fc70a368600860ada92e93326a25",
"head_commit_message": "Remove extra S in cache path in caching module\n\nCo-authored-by: Hailey Schoelkopf <65563625+haileyschoelkopf@users.noreply.github.com>",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex 0e5028fb11..35a6381ea7 100... | [
{
"diff_hunk": "@@ -192,9 +211,11 @@ def simple_evaluate(\n \n @positional_deprecated\n def evaluate(\n- lm,\n+ lm: \"LM\",\n task_dict,\n limit=None,\n+ use_builder_cache=False,",
"line": null,
"original_line": 217,
"original_start_line": null,
"path": "lm_eval/evaluator.py",
... | 8ebde1315ec3b50c6fb8e7ff5000210a5dbea0f2 | diff --git a/.gitignore b/.gitignore
index aff34b70f6..020622dfdc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,5 +16,8 @@ temp
# IPython
profile_default/
ipython_config.py
+# don't track (the default location of) the cached requests
+lm_eval/caching/.cache
+# don't track files created by wandb
wandb
examples/wa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-10995@ecbb058 | BerriAI/litellm | Python | 10,995 | fix: default role for JWT authentication | ## Fix: default role for JWT authentication)
Fixes https://github.com/BerriAI/litellm/issues/10286
The PR introduces support for applying default internal user parameters when upserting a user via JWT authentication and adds a corresponding unit test to verify this behavior.
Merge default_internal_user_params... | 2025-05-21T01:30:41Z | [Feature]: default role for JWT authentication
### The Feature
Allow to specify the default role to be assigned to a new user using the JWT authentication
### Motivation, pitch
To ensure every new user has constraints in place through the default budget, rpm and budget duration
### Are you a ML Ops Team?
Yes
### ... | cc @S1LV3RJ1NX
any ETA on this @ishaan-jaff @S1LV3RJ1NX ?
hi @abarahonar doing this tomorrow.
@abarahonar added here: https://github.com/BerriAI/litellm/pull/10995 | [
{
"body": "### The Feature\n\nAllow to specify the default role to be assigned to a new user using the JWT authentication\n\n### Motivation, pitch\n\nTo ensure every new user has constraints in place through the default budget, rpm and budget duration\n\n### Are you a ML Ops Team?\n\nYes\n\n### Twitter / Linked... | 3a6802fef180e33c1e1d1e1fbe49c7cba60b9e0d | {
"head_commit": "ecbb0585b7db5b84a4fefc242543faa70d027d3d",
"head_commit_message": "test: test_default_internal_user_params_with_get_user_object",
"patch_to_review": "diff --git a/litellm/proxy/auth/auth_checks.py b/litellm/proxy/auth/auth_checks.py\nindex e18b358fa63f..f6cf9e5c87c3 100644\n--- a/litellm/proxy/a... | [
{
"diff_hunk": "@@ -697,8 +697,14 @@ async def get_user_object(\n \n if response is None:\n if user_id_upsert:\n+ new_user_params: Dict[str, Any] = {\n+ \"user_id\": user_id,\n+ }\n+ if litellm.default_internal_user_params:",
... | d3d5a94156d0c253e07a02046434bf3234ea5e9c | diff --git a/litellm/proxy/auth/auth_checks.py b/litellm/proxy/auth/auth_checks.py
index e18b358fa63f..48e9787d00da 100644
--- a/litellm/proxy/auth/auth_checks.py
+++ b/litellm/proxy/auth/auth_checks.py
@@ -697,8 +697,14 @@ async def get_user_object(
if response is None:
if user_id_upsert:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-10959@e964e20 | BerriAI/litellm | Python | 10,959 | [Fix] List Guardrails - Show config.yaml guardrails on litellm ui | ## [Fix] List Guardrails - Show config.yaml guardrails on litellm ui
Fixes #10951
- Ensure the UI lists guardrails on the config.yaml and from DB
- Ensure the UI allows clicking into config.yaml guardrails
<img width="1065" alt="Screenshot 2025-05-19 at 3 25 32 PM" src="https://github.com/user-attachment... | 2025-05-19T21:57:31Z | [Bug]: Custom GuardRail not Working
### What happened?
I've upgraded my LiteLLM from version 1.68 to 1.70.0 and I had to rollback. All my custom guardrails stopped working, even though they are on the config file, they are not shown in the UI. I've checked the documentation and I noticed that stuff changed for guardra... | Hi @fabriciojoc when you say not working, is it not working on the llm api call ? or are you just not seeing it on the UI ?
Both! I cannot see it in the UI and it's not being called.
@fabriciojoc how do you call them ? with a dynamic param?
just tested a custom guardrail, I can confirm it still works for me
```yaml... | [
{
"body": "### What happened?\n\nI've upgraded my LiteLLM from version 1.68 to 1.70.0 and I had to rollback. All my custom guardrails stopped working, even though they are on the config file, they are not shown in the UI. I've checked the documentation and I noticed that stuff changed for guardrails, but there ... | be672b2b18a12b71db08caba0d6ac81f88431719 | {
"head_commit": "e964e209cb95c2f36fcaa6c8bad394ce50c0a507",
"head_commit_message": "test: list guardrails on litellm config",
"patch_to_review": "diff --git a/litellm/model_prices_and_context_window_backup.json b/litellm/model_prices_and_context_window_backup.json\nindex 649eda96e9f0..8ed64faceba9 100644\n--- a/... | [
{
"diff_hunk": "@@ -164,9 +167,26 @@ async def list_guardrails_v2():\n guardrail_info=guardrail.get(\"guardrail_info\"),\n created_at=guardrail.get(\"created_at\"),\n updated_at=guardrail.get(\"updated_at\"),\n+ guardrail_definition_... | 4ce03da22aeb160ed86e44dab6bd6bb6481f32f8 | diff --git a/litellm/model_prices_and_context_window_backup.json b/litellm/model_prices_and_context_window_backup.json
index 649eda96e9f0..8ed64faceba9 100644
--- a/litellm/model_prices_and_context_window_backup.json
+++ b/litellm/model_prices_and_context_window_backup.json
@@ -12731,5 +12731,19 @@
"/v1/im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
BerriAI__litellm-10697@7a37201 | BerriAI/litellm | Python | 10,697 | [FIX] Update token fields in schema.prisma to use BigInt for improved… | … handling of large values across LiteLLM models.
## Title
Integer overflow in PostgreSQL spend-tracking query causes inaccurate totals (#10379)
<!-- e.g. "Implement user authentication feature" -->
## Relevant issues
Fixes #10379
## Pre-Submission checklist
**Please complete all items before asking... | 2025-05-09T14:49:26Z | [Bug]: PostgreSQL Integer Overflow Error in Spend Tracking System
### What happened?
Issue Description
When running LiteLLM with high usage, I encountered a PostgreSQL error indicating integer overflow in the spend tracking system. This occurs during the execution of the db_update_spend_transaction_handler function.
... | What is your avg daly usage @vovolie, it is more then 32^2-1?
Yes, our usage is well beyond 32^2-1, with completion_tokens exceeding 10B.
@ishaan-jaff, @krrishdholakia Should i try to fix this.
I think moving from int to bigint would fix this.
Facing the same issue...
@krrishdholakia @ishaan-jaff
tokens also 10B... | [
{
"body": "### What happened?\n\nIssue Description\nWhen running LiteLLM with high usage, I encountered a PostgreSQL error indicating integer overflow in the spend tracking system. This occurs during the execution of the db_update_spend_transaction_handler function.\n\n\n\n### Relevant log output\n\n```shell\nC... | 86f19d2fae0f0197f4c146955fcad8a5f26dc220 | {
"head_commit": "7a372019f7f8379088b470f9ecace278c6720370",
"head_commit_message": "[FIX] Update token fields in schema.prisma to use BigInt for improved handling of large values across LiteLLM models.",
"patch_to_review": "diff --git a/litellm/proxy/schema.prisma b/litellm/proxy/schema.prisma\nindex 3c20b9a3cda... | [
{
"diff_hunk": "@@ -238,9 +238,9 @@ model LiteLLM_SpendLogs {\n call_type String\n api_key String @default (\"\") // Hashed API Token. Not the actual Virtual Key. Equivalent to 'token' column in LiteLLM_VerificationToken\n spend Float @default(0.0)\n- total_tokens ... | 306ec22bb86a6a294f7b92fbf979001ef95fd1d9 | diff --git a/litellm/proxy/schema.prisma b/litellm/proxy/schema.prisma
index 3c20b9a3cda1..b3016cc38bdc 100644
--- a/litellm/proxy/schema.prisma
+++ b/litellm/proxy/schema.prisma
@@ -361,14 +361,14 @@ model LiteLLM_DailyUserSpend {
model String
model_group String?
custom_llm_provider... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
BerriAI__litellm-9756@e0c403f | BerriAI/litellm | Python | 9,756 | Fix VertexAI Credential Caching issue | ## Title
Fix VertexAI Credential Caching issue
## Relevant issues
Fixes https://github.com/BerriAI/litellm/issues/7904
## Pre-Submission checklist
**Please complete all items before asking a LiteLLM maintainer to review your PR**
- [x] I have Added testing in the [`tests/litellm/`](https://github.com/... | 2025-04-04T17:55:15Z | [Bug]: Vertex Credentials Are Cached
### What happened?
It seems that when using litellm to make calls to vertex_ai models, the vertex credentials are somehow cached within litellm and the ones passed into `completion()` are not being used on every call
```
>>> litellm.completion(
... messages=[{'role': 'user', '... | Thanks for the issue @hakan458 i plan to look into this, this week.
Hi @krrishdholakia any updates on this? Strange that the key is being cached at all in this case I would expect the `vertex_credentials` argument to take precedence over anything else. If the fix is not obvious, is there perhaps a way I can manually "... | [
{
"body": "### What happened?\n\nIt seems that when using litellm to make calls to vertex_ai models, the vertex credentials are somehow cached within litellm and the ones passed into `completion()` are not being used on every call\n\n```\n>>> litellm.completion(\n... messages=[{'role': 'user', 'content': \"... | e67d16d5bd3387fd7eccca19594e8f8d3f89f144 | {
"head_commit": "e0c403f584bc265b2e207f31a19d74d08f13fa0c",
"head_commit_message": "fix(vertex_llm_base.py): common auth logic across sync + async vertex ai calls\n\nprevents credential caching issue across both flows",
"patch_to_review": "diff --git a/litellm/llms/vertex_ai/vertex_llm_base.py b/litellm/llms/ver... | [
{
"diff_hunk": "@@ -259,6 +242,89 @@\n url=url,\n )\n \n+ def get_access_token(\n+ self,\n+ credentials: Optional[VERTEX_CREDENTIALS_TYPES],\n+ project_id: Optional[str],\n+ ) -> Tuple[str, str]:\n+ \"\"\"\n+ Get access token and project id\n+\n+ ... | 4c8aaa21487b5d9396ab3692ba28158d1628d92a | diff --git a/litellm/integrations/gcs_bucket/gcs_bucket.py b/litellm/integrations/gcs_bucket/gcs_bucket.py
index fc98b0948f4d..972a0236666c 100644
--- a/litellm/integrations/gcs_bucket/gcs_bucket.py
+++ b/litellm/integrations/gcs_bucket/gcs_bucket.py
@@ -121,6 +121,7 @@ async def async_send_batch(self):
gc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
BerriAI__litellm-8915@d1c59bb | BerriAI/litellm | Python | 8,915 | Fix #7629 - Add tzdata package to Dockerfile | ## Title
Add tzdata to Dockerfile
## Relevant issues
Fixes #7629
## Type
🐛 Bug Fix
## Changes
Add tzdata to Dockerfile
## [REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes
Start litellm with env var TZ='Austral... | 2025-03-01T15:53:52Z | [Bug]: timezone zoneinfo
### What happened?
```
zoneinfo._common.ZoneInfoNotFoundError: 'tzlocal() does not support non-zoneinfo timezones like UTC. \nPlease use a timezone in the form of Continent/City'
ERROR: Application startup failed. Exiting.
```
### Relevant log output
_No response_
### Are you a ML O... | I had the same issue. It seems the `tzdata` package needs to be updated in the Docker image.
I've been using litellm with no issues/changes for awhile, but I noticed the container stopped working recently, though haven't had my eye on it so not sure exactly what update did it. It looks like the `tzdata` package is e... | [
{
"body": "### What happened?\n\n```\r\nzoneinfo._common.ZoneInfoNotFoundError: 'tzlocal() does not support non-zoneinfo timezones like UTC. \\nPlease use a timezone in the form of Continent/City'\r\n\r\nERROR: Application startup failed. Exiting.\r\n```\n\n### Relevant log output\n\n_No response_\n\n### Are... | 313b315791db15bd44c18f2473f37868d3d916e9 | {
"head_commit": "d1c59bb000c8e32d92a30a8dd2c03e06399f21b3",
"head_commit_message": "Add tzdata package to Dockerfile",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex dd699c795b0a..0bc554a84c94 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -56,7 +56,7 @@ USER root\n \n # Install runtime dependen... | [
{
"diff_hunk": "@@ -56,7 +56,7 @@ USER root\n \n # Install runtime dependencies\n RUN apk update && \\\n- apk add --no-cache openssl\n+ apk add --no-cache openssl tzdata",
"line": null,
"original_line": 59,
"original_start_line": null,
"path": "Dockerfile",
"start_line": null,
"tex... | b1459d742816ae46a68ab2376e5f37df7b8f8873 | diff --git a/requirements.txt b/requirements.txt
index 5f4c1e1e6fe7..d9b89cfa0720 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -36,6 +36,7 @@ opentelemetry-exporter-otlp==1.25.0
sentry_sdk==2.21.0 # for sentry error handling
detect-secrets==1.5.0 # Enterprise - secret detection / masking in LLM requests
c... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
BerriAI__litellm-8162@3fdd776 | BerriAI/litellm | Python | 8,162 | fix: support azure o3 model family for fake streaming workaround | ## Support o3 model family for fake streaming workaround from Azure
`o3-mini` is already available on Azure, but sadly it looks like it doesn't support streaming, just like the `o1` models.
So this PR updates the logic for the fake streaming workaround to also support the `o3` family. Note that there's a wider refa... | 2025-01-31T23:16:36Z | [Bug]: o3-mini - Azure OpenAI
### What happened?
Surprisingly, Azure OpenAI this time added support for the o3-mini model on the same day!
But when a request is sent with `stream` set to `true`, the ability to fake the stream that worked with o1 models (behaving as if stream were false but returning full data by SSE... | [
{
"body": "### What happened?\n\nSurprisingly, Azure OpenAI this time added support for the o3-mini model on the same day! \n\nBut when a request is sent with `stream` set to `true`, the ability to fake the stream that worked with o1 models (behaving as if stream were false but returning full data by SSE in sin... | d0c5639912581423728ce6bbf99543efc2c372f2 | {
"head_commit": "3fdd776d1e9934e6d5f3bbb79364c6b8ab10887e",
"head_commit_message": "fix: support azure o3 model family for fake streaming workaround",
"patch_to_review": "diff --git a/litellm/litellm_core_utils/get_supported_openai_params.py b/litellm/litellm_core_utils/get_supported_openai_params.py\nindex e251... | [
{
"diff_hunk": "@@ -5997,7 +5997,7 @@ def get_provider_chat_config( # noqa: PLR0915\n ):\n return litellm.AI21ChatConfig()\n elif litellm.LlmProviders.AZURE == provider:\n- if litellm.AzureOpenAIO1Config().is_o1_model(model=model):\n+ if litellm.AzureOpenAIO1Co... | 8f42fa35f738d87f22419b474daf182aa351d336 | diff --git a/litellm/litellm_core_utils/get_supported_openai_params.py b/litellm/litellm_core_utils/get_supported_openai_params.py
index e251784f4e18..9358518930c9 100644
--- a/litellm/litellm_core_utils/get_supported_openai_params.py
+++ b/litellm/litellm_core_utils/get_supported_openai_params.py
@@ -81,7 +81,7 @@ def... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
BerriAI__litellm-7825@47e4a45 | BerriAI/litellm | Python | 7,825 | Fix: Problem with langfuse_tags when using litellm proxy with langfus… |
## Title
Fix: Problem with langfuse_tags when using litellm proxy with langfuse integration
## Relevant issues
Fixes #7801
## Type
<!-- Select the type of Pull Request -->
<!-- Keep only the necessary ones -->
🐛 Bug Fix
## Changes
<!-- List of changes -->
- Updated the tags processing logic ... | 2025-01-17T04:53:29Z | [Bug]: Problem with langfuse_tags when using litellm proxy with langfuse integration
### What happened?
When integrating litellm proxy with langfuse, specifying langfuse_tags in the HTTP header is expected to populate the Tags field in langfuse. However, in practice, attempting this results in the proxy crashing with ... | [
{
"body": "### What happened?\n\nWhen integrating litellm proxy with langfuse, specifying langfuse_tags in the HTTP header is expected to populate the Tags field in langfuse. However, in practice, attempting this results in the proxy crashing with the following error message:\r\n\r\n```\r\n07:52:12 - LiteLLM:ER... | 2f38e72026e2aaef127ed54da3eec86853306d66 | {
"head_commit": "47e4a45888d2de12497a3cac16d16485d00a827a",
"head_commit_message": "Fix: Problem with langfuse_tags when using litellm proxy with langfuse integration (#7801)",
"patch_to_review": "diff --git a/litellm/integrations/langfuse/langfuse.py b/litellm/integrations/langfuse/langfuse.py\nindex 2a459af9b9... | [
{
"diff_hunk": "@@ -457,7 +458,7 @@ def _log_langfuse_v2( # noqa: PLR0915\n supports_costs = langfuse_version >= Version(\"2.7.3\")\n supports_completion_start_time = langfuse_version >= Version(\"2.7.3\")\n \n- tags = metadata.pop(\"tags\", []) if supports_tags else []\n+ ... | d1dea537fbd67cbe90892fc066a444c343fdbe94 | diff --git a/litellm/integrations/langfuse/langfuse.py b/litellm/integrations/langfuse/langfuse.py
index 2a459af9b91e..9fb2f86f683f 100644
--- a/litellm/integrations/langfuse/langfuse.py
+++ b/litellm/integrations/langfuse/langfuse.py
@@ -1,6 +1,7 @@
#### What this does ####
# On success, logs events to Langfuse
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Avaiga__taipy-2296@f4ea435 | Avaiga/taipy | Python | 2,296 | feature/#398-expand-exposed-type-parameter | ## What type of PR is this? (check all applicable)
- [ ] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
## Description
We are also including pandas.DataFrame and numpy.ndarray as exposed type.
## Related Tickets & Documents
- Related Issue #398
- Closes #398
## H... | 2024-12-02T06:24:14Z | Expand the `exposed_type` parameter of DataNode to accept actual Python types
**Description**
For now, the `exposed_type` parameter only accepts a string (`"pandas", "numpy") or a custom python class.
This ticket proposes to expand the parameter type to accept actual Python types for the predefined types:
- `num... | Can i help out here ?
Thank you @sqrt676. I assigned the ticket to you.
Let us know if you need more information on this.
Thanks @trgiangdo , will ask for information wherever needed.
Hello @sqrt676, any update on this issue?
@trgiangdo can I take this one?
Absolutely. I will assign the issue to you @ranjanmangla1.
... | [
{
"body": "**Description**\r\n\r\nFor now, the `exposed_type` parameter only accepts a string (`\"pandas\", \"numpy\") or a custom python class.\r\n\r\nThis ticket proposes to expand the parameter type to accept actual Python types for the predefined types:\r\n- `numpy.array`\r\n- `pandas.DataFrame`\r\n\r\n",
... | 11ff2778e86668b082ba6f44243bff8e63fc574e | {
"head_commit": "f4ea43505f38a3c99232e570d7e0f0a546279fca",
"head_commit_message": "Merge branch 'develop' into feature/#398-expand-exposed-type-parameter",
"patch_to_review": "diff --git a/Pipfile b/Pipfile\nindex e308f18c4d..da1ab78ea4 100644\n--- a/Pipfile\n+++ b/Pipfile\n@@ -36,6 +36,7 @@ boto3 = \"==1.29.1\... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "git",
"start_line": null,
"text": "@user1:\nI believe this file is redundant"
},
{
"diff_hunk": "@@ -71,11 +74,17 @@ class DataNodeConfig(Section):\n _EXPOSED_TYPE_PANDAS = \"pandas\... | aae973f47e647a5482d8d7c3e97c6d5cddfb177b | diff --git a/taipy/core/config/data_node_config.py b/taipy/core/config/data_node_config.py
index 8edc6ce171..12c15301af 100644
--- a/taipy/core/config/data_node_config.py
+++ b/taipy/core/config/data_node_config.py
@@ -14,6 +14,9 @@
from datetime import timedelta
from typing import Any, Callable, Dict, List, Optional... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-2373@acaa0c1 | Avaiga/taipy | Python | 2,373 | feature/#397 scenario duplication | ## What type of PR is this? (check all applicable)
- [x] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
## Description
Implementation of a new feature to duplicate a scenario.
+
Make the various reason messages consistent.
## Related Tickets & Documents
#397
| 2024-12-27T07:16:59Z | Possibility to duplicate scenarios
**What would that feature address**
I want to duplicate a scenario. That means creating a new scenario and the related entities. The data nodes of the new scenario should have already been written and populated with the same data as the first scenario.
**Motivations:**
1. The possibi... | There is a problem that needs to be clarified for this feature.
If in the original scenario, there is some data nodes that has scope <= SCENARIO, we are going to need to duplicate the data.
- If the data node is a file-based one (pickle, csv, excel, ...), if the user provides an explicit path in the original data node... | [
{
"body": "**What would that feature address**\nI want to duplicate a scenario. That means creating a new scenario and the related entities. The data nodes of the new scenario should have already been written and populated with the same data as the first scenario.\n\n**Motivations:**\n1. The possibility of star... | 111f0601bc819b1f0aa2bf71b92ef7455e28b114 | {
"head_commit": "acaa0c176128e78dfa4c3b40f0f843006cc9804e",
"head_commit_message": "minor refactor",
"patch_to_review": "diff --git a/taipy/core/_repository/_filesystem_repository.py b/taipy/core/_repository/_filesystem_repository.py\nindex 721c569b36..13be55aaa6 100644\n--- a/taipy/core/_repository/_filesystem_... | [
{
"diff_hunk": "@@ -161,7 +167,8 @@ def _upload(self,\n self.__logger.error(\n f\"Error with the upload checker `{upload_checker.__name__}` \"\n f\"while checking `{up_path.name}` file for upload to the data \"\n- f\"node `{self.id}`:\")... | dbf207dd870f00d5d5fa58b725a158c9db91839f | diff --git a/taipy/core/_repository/_filesystem_repository.py b/taipy/core/_repository/_filesystem_repository.py
index 721c569b36..13be55aaa6 100644
--- a/taipy/core/_repository/_filesystem_repository.py
+++ b/taipy/core/_repository/_filesystem_repository.py
@@ -191,10 +191,14 @@ def __filter_files_by_config_and_owner_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-3298@9ead717 | BerriAI/litellm | Python | 3,298 | fix Llama models messages to prompt conversion for AWS Bedrock | Fix: #3297
----
@krrishdholakia I saw that you added support for Llama-3 recently in commit [df7db2b](https://github.com/BerriAI/litellm/commit/df7db2b870d2e1201888bb625c446e4473759ffb) but that didn't cover Llama Bedrock models.
Please let me know if this looks good otherwise. | 2024-04-25T17:24:58Z | [Bug]: Gibberish output of Llama-3 models on AWS Bedrock
### What happened?
Llama-3 models are not working properly on AWS Bedrock right now and output gibberish. Probably because the instruct models now follow a different template.
```python
response = client.chat.completions.create(
model="llama-3-8b",
... | I noticed this as well. It seems like the same for Llama 2 on Bedrock, not just Llama 3? | [
{
"body": "### What happened?\n\nLlama-3 models are not working properly on AWS Bedrock right now and output gibberish. Probably because the instruct models now follow a different template.\r\n\r\n```python\r\nresponse = client.chat.completions.create(\r\n model=\"llama-3-8b\", \r\n messages = [\r\n ... | 54e0acde351a1266f5cc31fbed59a52eab1e75b8 | {
"head_commit": "9ead7175313ab55f6323dc6b06c378d4335fdbe5",
"head_commit_message": "fix Llama models message to prompt conversion in for AWS Bedrock provider",
"patch_to_review": "diff --git a/litellm/llms/bedrock.py b/litellm/llms/bedrock.py\nindex ef6dbfb1b8ff..149b68472452 100644\n--- a/litellm/llms/bedrock.p... | [
{
"diff_hunk": "@@ -1346,6 +1346,16 @@ def prompt_factory(\n return anthropic_pt(messages=messages)\n elif \"mistral.\" in model:\n return mistral_instruct_pt(messages=messages)\n+ elif \"llama2\" in model:\n+ return llama_2_chat_pt(messages=messages)\n+ ... | 781af56f485c0d6b3b33aa71cb34df125e3e7103 | diff --git a/litellm/llms/bedrock.py b/litellm/llms/bedrock.py
index ef6dbfb1b8ff..149b68472452 100644
--- a/litellm/llms/bedrock.py
+++ b/litellm/llms/bedrock.py
@@ -653,6 +653,10 @@ def convert_messages_to_prompt(model, messages, provider, custom_prompt_dict):
prompt = prompt_factory(
model=mode... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Avaiga__taipy-2028@ca7daba | Avaiga/taipy | Python | 2,028 | Added a function to support data conversion if type is not supported by the taipy.gui.data module | Resolves: #457
So there was this issue where we thought of giving developer option to change unsupported data format to a supported type
For this I have made two functions in class Gui namely "on_invalid_data" and "set_on_invalid_data_callback"
The Second function "set_on_invalid_data_callback" accepts a callba... | 2024-10-12T00:06:34Z | Tabular Data: support a callback to change unsupported data type to supported one
**What would that feature address**
display unsupported data type
***Description of the ideal solution***
If a dataframe holds a column with unsupported data, we could handle a user callback that would transform that column to a supporte... | @FredLL-Avaiga to clarify, we're creating a user callback that alerts users of unsupported type errors and then suggests them to convert the data into a supported type as well? (which the user may accept or declineand fix the data by himself)
That is not what I had in mind.
The objective is to allow the dev to define ... | [
{
"body": "**What would that feature address**\ndisplay unsupported data type\n\n***Description of the ideal solution***\nIf a dataframe holds a column with unsupported data, we could handle a user callback that would transform that column to a supported type\n\n***Caveats***\nperformance ?\n\n***Other options*... | 99d4fd0da30603edcd4783c70e41232af30608eb | {
"head_commit": "ca7daba088be4f32415821aa85b6c5c989158063",
"head_commit_message": "Linter (2)",
"patch_to_review": "diff --git a/contributors.txt b/contributors.txt\nnew file mode 100644\nindex 0000000000..fc43f630b8\n--- /dev/null\n+++ b/contributors.txt\n@@ -0,0 +1,22 @@\n+jrobinAV\n+FabienLelaquais\n+florian... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "contributors.txt",
"start_line": null,
"text": "@user1:\nhow come ? has this file moved ?\n\n@user2:\nThis should no have been created indeed"
},
{
"diff_hunk": "@@ -0,0 +1,79 @@\n+impor... | e6d2cc9d458ec2c4459e92dd30d8b8751c25a2af | diff --git a/taipy/gui/data/data_accessor.py b/taipy/gui/data/data_accessor.py
index d20b5ea8d3..23d85445c0 100644
--- a/taipy/gui/data/data_accessor.py
+++ b/taipy/gui/data/data_accessor.py
@@ -110,13 +110,14 @@ def __init__(self, gui: "Gui") -> None:
self._register(_NumpyDataAccessor)
def _register(se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1831@8ee0275 | Avaiga/taipy | Python | 1,831 | table format function | resolves #564
```
import pandas as pd
from taipy.gui import Gui
data = pd.DataFrame()
# Create 1O columns with 100 rows of bools
for i in range(10):
data[f"col_{i}"] = list(range(100))
def my_format(state, value, index, row, col_name):
return f"value: {value} for {index} in {col_name}"
... | 2024-09-24T12:21:24Z | Add formatting in tables using functions
Currently Taipy uses printf style formatting in tables
~~~ python
<|table|data={my_data}|columns={col_format}|...|>
col_format = {'Sales':'%.2f'}
~~~
This could be extended by allowing functions, like in <|selector|adapter={...}>
~~~ python
col_format={ "Sales": {"fo... | Thank you for your issue! It seems like a good feature! We will talk about it inside our R&D team
Hey @FlorianJacta, is this feature required, may I give it a try to add this?
@FabienLelaquais @FredLL-Avaiga Could this issue be assigned?
It certainly can. The thing is, it is far more complicated than it looks since the... | [
{
"body": "Currently Taipy uses printf style formatting in tables\r\n~~~ python\r\n<|table|data={my_data}|columns={col_format}|...|>\r\ncol_format = {'Sales':'%.2f'}\r\n~~~\r\n\r\nThis could be extended by allowing functions, like in <|selector|adapter={...}> \r\n\r\n~~~ python\r\ncol_format={ \"Sales\": {\"for... | e916050306db389d8074387fe4cba48592a0c9c1 | {
"head_commit": "8ee0275d368767edba0376222bf6a82eb9bb40cd",
"head_commit_message": "Update config.pyi",
"patch_to_review": "diff --git a/frontend/taipy-gui/package-lock.json b/frontend/taipy-gui/package-lock.json\nindex ae9654a7ca..4c14ef635e 100644\n--- a/frontend/taipy-gui/package-lock.json\n+++ b/frontend/tai... | [
{
"diff_hunk": "@@ -112,6 +112,21 @@ def _enhance_columns( # noqa: C901\n col_desc[\"tooltip\"] = value\n else:\n _warn(f\"{elt_name}: tooltip[{k}] is not in the list of displayed columns.\")\n+ formats = _get_name_indexed_property(attributes, \"format_fn\")\n+ for k, ... | 0bef7d11b9ef4fab11328ae76d0357233698194b | diff --git a/frontend/taipy-gui/package-lock.json b/frontend/taipy-gui/package-lock.json
index ae9654a7ca..4c14ef635e 100644
--- a/frontend/taipy-gui/package-lock.json
+++ b/frontend/taipy-gui/package-lock.json
@@ -672,9 +672,9 @@
"integrity": "sha512-MyqliTZGuOm3+5ZRSaaBGP3USLw6+EGykkwZns2EPC5g8jJ4z9OrdZY9apkl3... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1799@1071eaa | Avaiga/taipy | Python | 1,799 | feature/#1734 Recreate the Core service | #1734 | 2024-09-18T07:35:18Z | Recreate the Core service
After the Core service is replaced by the Orchestrator service, we want to keep the Core service compatible between `3.X` and `4.Y`.
The motivation is to give time to the developers to implement the changes and help them understand how to remain compatible.
- Recreate the Core service class ... | [
{
"body": "After the Core service is replaced by the Orchestrator service, we want to keep the Core service compatible between `3.X` and `4.Y`.\nThe motivation is to give time to the developers to implement the changes and help them understand how to remain compatible. \n\n- Recreate the Core service class as a... | d608cf9ad4477d5eb98dd8ae661fa8e697e5c87f | {
"head_commit": "1071eaa2f8cf453bd29ee6219a0ea527d267e83c",
"head_commit_message": "make linter stop complaining",
"patch_to_review": "diff --git a/taipy/core/_core.py b/taipy/core/_core.py\nnew file mode 100644\nindex 0000000000..4057b197be\n--- /dev/null\n+++ b/taipy/core/_core.py\n@@ -0,0 +1,28 @@\n+# Copyrig... | [
{
"diff_hunk": "@@ -0,0 +1,28 @@\n+# Copyright 2021-2024 Avaiga Private Limited\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with\n+# the License. You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LIC... | 9be5a9c9a70ed5eb5473725300f73a8b6859d1c2 | diff --git a/taipy/core/_core.py b/taipy/core/_core.py
new file mode 100644
index 0000000000..e8883f408e
--- /dev/null
+++ b/taipy/core/_core.py
@@ -0,0 +1,29 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compli... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-1717@d5d0936 | Avaiga/taipy | Python | 1,717 | job details | resolves #1251
```
import datetime as dt
import taipy as tp
from taipy import Config, Frequency
from taipy.gui import State
def on_change(state: State, var: str, val):
print(f"on_change(state: State, var: {var}, val type: {type(val)}, val: {val})")
# Function to run a Dataiku scenario
def run_som... | 2024-08-28T09:32:00Z | Show stack trace in job selector when job fails
**What would that feature address**
When a job is failing, it is helpful to show the logs in the job selector to understand why the data is incorrect.
***Description of the ideal solution***
Display the job logs in a modal accessible from a job in the list
**Acce... | It will be really useful; you are correct! Would having a visual element called *job* be the solution for you, or should it be totally integrated within the *job selector*?
Integrated with the job selector is better, so all the job handling functionalities are supported with a single visual element. It is much easier ... | [
{
"body": "**What would that feature address**\r\nWhen a job is failing, it is helpful to show the logs in the job selector to understand why the data is incorrect.\r\n\r\n***Description of the ideal solution***\r\nDisplay the job logs in a modal accessible from a job in the list\r\n\r\n**Acceptance Criteria**\... | d6a2df03fc6de498e033601786d64b1a7a508924 | {
"head_commit": "d5d0936f1f7b6648bba10d25dda2856cfc9e669e",
"head_commit_message": "Merge branch 'develop' into feature/#1251-job-details",
"patch_to_review": "diff --git a/frontend/taipy/src/JobSelector.tsx b/frontend/taipy/src/JobSelector.tsx\nindex c7663fd9a3..b79374c147 100644\n--- a/frontend/taipy/src/JobSe... | [
{
"diff_hunk": "@@ -539,6 +539,26 @@\n \"type\": \"str\",\n \"default_value\": \"\\\"50vh\\\"\",\n \"doc\": \"The maximum height, in CSS units, of the control.\"\n+ },\n+ {\n+ \"n... | fadff348d8ab69e7c5aa05ff0bebae9d15b76c04 | diff --git a/frontend/taipy/src/JobSelector.tsx b/frontend/taipy/src/JobSelector.tsx
index c7663fd9a3..b79374c147 100644
--- a/frontend/taipy/src/JobSelector.tsx
+++ b/frontend/taipy/src/JobSelector.tsx
@@ -11,8 +11,13 @@
* specific language governing permissions and limitations under the License.
*/
-import Reac... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-3559@be85145 | BerriAI/litellm | Python | 3,559 | Langfuse integration support for `parent_observation_id` parameter | ## Title
Langfuse integration support for `parent_observation_id` parameter
## Relevant issues
Fixes #3558
Related to #1832
## Type
🆕 New Feature
📖 Documentation
## Changes
`LangFuseLogger` now receives the `parent_observation_id` metadata value and passes it along to the Langfuse generation ... | 2024-05-10T09:01:15Z | [Feature]: Langfuse integration support for `parent_observation_id ` parameter
### The Feature
Currently, we cannot pass the `parent_observation_id ` metadata parameter to LiteLLM to attach Langfuse generation objects to a given parent observation. We can therefore not create nested Langfuse generation objects.
... | [
{
"body": "### The Feature\r\n\r\nCurrently, we cannot pass the `parent_observation_id ` metadata parameter to LiteLLM to attach Langfuse generation objects to a given parent observation. We can therefore not create nested Langfuse generation objects.\r\n\r\n\r\n\r\n### Motivation, pitch\r\n\r\nI want to have d... | 07abccf96fce8c419d99e4232f4770d9d46bd6c5 | {
"head_commit": "be85145b8669e870033157f57005c26d78bc8349",
"head_commit_message": "Update langfuse integration docs wiht the new `parent_observation_id` parameter",
"patch_to_review": "diff --git a/docs/my-website/docs/observability/langfuse_integration.md b/docs/my-website/docs/observability/langfuse_integrati... | [
{
"diff_hunk": "@@ -437,6 +437,7 @@ def _log_langfuse_v2(\n generation_params = {\n \"name\": generation_name,\n \"id\": clean_metadata.pop(\"generation_id\", generation_id),\n+ \"parent_observation_id\": metadata.get(\"parent_observation_id\"),",
"... | 8ed41dee097a3bdf54fb4f9a219f35691b15af5f | diff --git a/docs/my-website/docs/observability/langfuse_integration.md b/docs/my-website/docs/observability/langfuse_integration.md
index 6dd5377ea7da..53f1c6b88fcc 100644
--- a/docs/my-website/docs/observability/langfuse_integration.md
+++ b/docs/my-website/docs/observability/langfuse_integration.md
@@ -122,6 +122,7 ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-1684@80c85a9 | Avaiga/taipy | Python | 1,684 | fix pipe warning (#467) | Resolve #467 | 2024-08-20T06:50:52Z | Missing pipe warning should be more explicit
When a user writes a visual element with a missing pipe at the end:
```python
page = "<|{data}|table|style[questions]=style_questions>"
```
The page fails to display the element (which is normal) but prompts the user with the following warning:
```
--- 1 warning(s)... | [
{
"body": "When a user writes a visual element with a missing pipe at the end:\r\n\r\n```python\r\npage = \"<|{data}|table|style[questions]=style_questions>\"\r\n```\r\n\r\nThe page fails to display the element (which is normal) but prompts the user with the following warning:\r\n```\r\n--- 1 warning(s) were fo... | 7a44f5ce0073bfe229843b3ba1f3190f86081e92 | {
"head_commit": "80c85a9ce7824b3eba7473ab276f822c9c694672",
"head_commit_message": "Merge branch 'develop' into feature/gui-fix-pipe-warning",
"patch_to_review": "diff --git a/taipy/gui/_renderers/_markdown/preproc.py b/taipy/gui/_renderers/_markdown/preproc.py\nindex 9b43a99a9f..a1ac7c4c9b 100644\n--- a/taipy/g... | [
{
"diff_hunk": "@@ -100,7 +111,7 @@ def run(self, lines: List[str]) -> List[str]:\n line += f' {property[0]}=\"{prop_value}\"'\n line += _MarkdownFactory._TAIPY_END + new_line_delimeter\n else:\n- _warn(f\"Invalid tag name '{tag}' in... | 83839c8f87ff6644c39590d8a98f044e6f531cf9 | diff --git a/taipy/gui/_renderers/_markdown/preproc.py b/taipy/gui/_renderers/_markdown/preproc.py
index 9b43a99a9f..73b7f588b9 100644
--- a/taipy/gui/_renderers/_markdown/preproc.py
+++ b/taipy/gui/_renderers/_markdown/preproc.py
@@ -60,6 +60,9 @@ class _Preprocessor(MdPreprocessor):
# Note 2: Space characters a... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Avaiga__taipy-1275@739f54b | Avaiga/taipy | Python | 1,275 | Feature/#1270 - Add action to manage stale issues and PRs | Resolves #1270
TODO:
- [x] Discuss the fields in the action
- [x] Update CONTRIBUTING.md
- [x] Add `Waiting for Contributor` label to the repositories | 2024-05-08T09:00:07Z | Automatically make inactive issues and PRs stale
**What would that feature address**
- Automatically unassign assignee from an issue after ... days of inactivity
- Automatically mark a PR as stale after ... days of inactivity
- Automatically close a stale PR after ... more days of inactivity
We need to discuss ... | [
{
"body": "**What would that feature address**\r\n\r\n- Automatically unassign assignee from an issue after ... days of inactivity\r\n- Automatically mark a PR as stale after ... days of inactivity\r\n- Automatically close a stale PR after ... more days of inactivity\r\n\r\nWe need to discuss what to do on issu... | abe39d54ab73948a6d7c362df81aa51196b24a73 | {
"head_commit": "739f54b42f48e2e890788ea02abc2600c5209bcb",
"head_commit_message": "feat: remove extempt-assignees",
"patch_to_review": "diff --git a/.github/workflows/manage-stale-issue-pr.yml b/.github/workflows/manage-stale-issue-pr.yml\nnew file mode 100644\nindex 0000000000..b4d5c1cadd\n--- /dev/null\n+++ b... | [
{
"diff_hunk": "@@ -0,0 +1,40 @@\n+name: Manage Stale Issues and PRs\n+\n+on:\n+ schedule:\n+ # Run once every day at 9 AM UTC\n+ - cron: 00 9 * * *\n+\n+jobs:\n+ stale-issues-and-prs:\n+ name: Comment on possible stable issues and PRs, and close stale PRs\n+ runs-on: ubuntu-latest\n+ steps:\n+... | f7d9c0544086a331bf1f54ff07db40229db9c481 | diff --git a/.github/workflows/manage-stale-issue-pr.yml b/.github/workflows/manage-stale-issue-pr.yml
new file mode 100644
index 0000000000..9a75402bc0
--- /dev/null
+++ b/.github/workflows/manage-stale-issue-pr.yml
@@ -0,0 +1,39 @@
+name: Manage Stale Issues and PRs
+
+on:
+ schedule:
+ # Run once every day at 9 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-1441@6a5253d | Avaiga/taipy | Python | 1,441 | broadcast callback on non shared variables | resolves #1207
~renamed current `broadcast_callback` to `broadcast_callback_on_shared`~
| 2024-06-21T13:57:14Z | Possibility to forward a change to a subset of clients (conditional broadcast)
**Description**
Being able to broadcast variables not to all the clients but only a subset. A user variable or filter function defines this subset.
**Acceptance Criteria**
- [ ] Ensure new code is unit tested, and check code coverage is... | I think we have internally a *_broadcast* function that broadcasts to a list of clients. Is it true?
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links t... | [
{
"body": "**Description**\r\nBeing able to broadcast variables not to all the clients but only a subset. A user variable or filter function defines this subset.\r\n\r\n**Acceptance Criteria**\r\n- [ ] Ensure new code is unit tested, and check code coverage is at least 90%\r\n- [ ] Propagate any change on the d... | c5618f1d5082d60ca7e57911fc0279bfe33577c3 | {
"head_commit": "6a5253db45ecfdabae4ff074f716091286399cb9",
"head_commit_message": "remove broadcast_callback_on_shared",
"patch_to_review": "diff --git a/doc/gui/examples/broadcast.py b/doc/gui/examples/broadcast.py\nindex 52e72c5738..b3ba8730be 100644\n--- a/doc/gui/examples/broadcast.py\n+++ b/doc/gui/example... | [
{
"diff_hunk": "@@ -173,7 +173,7 @@ const PaginatedTable = (props: TaipyPaginatedTableProps) => {\n }\n return [colsOrder, baseColumns, styTt.styles, styTt.tooltips, hNan, filter];\n } catch (e) {\n- console.info(\"PTable.columns: \" + ((e as Error).mes... | 9af19ae33e69f5599cd358cefd59441fe8f992b5 | diff --git a/doc/gui/examples/broadcast.py b/doc/gui/examples/broadcast.py
index 52e72c5738..32e8702a0e 100644
--- a/doc/gui/examples/broadcast.py
+++ b/doc/gui/examples/broadcast.py
@@ -15,14 +15,15 @@
# -----------------------------------------------------------------------------------------
# Demonstrate how to sh... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
BerriAI__litellm-1200@b72d372 | BerriAI/litellm | Python | 1,200 | feat: added explicit args to acomplete | Changes made to the acompletion function:
1. Replaced the use of *args and **kwargs with explicit arguments.
2. Adjusted the internal logic to accommodate the new argument structure. This involved modifying the way
arguments are passed to the completion function and ensuring that all necessary parameters are cor... | 2023-12-20T18:57:42Z | [Feature]: acomplete see explicit args instead of *args, **kwargs on acomplete,
### The Feature
> would love to see explicit args instead of *args, **kwargs on acomplete, like you have in complete
### Motivation, pitch
everyone loves intellisense
### Twitter / LinkedIn details
_No response_ | Hello there! I'd like to try it! It would be my first issue. Cheers :)
any updated @MateoCamara ? | [
{
"body": "### The Feature\n\n> would love to see explicit args instead of *args, **kwargs on acomplete, like you have in complete\n\n### Motivation, pitch\n\neveryone loves intellisense \n\n### Twitter / LinkedIn details\n\n_No response_",
"number": 1024,
"title": "[Feature]: acomplete see explicit ar... | 4cfa010dbda2cffa7a403d6e13a6156904bd056c | {
"head_commit": "b72d372aa7c2732627abc1b123b7e04c2abc68e3",
"head_commit_message": "feat: added explicit args to acomplete",
"patch_to_review": "diff --git a/litellm/main.py b/litellm/main.py\nindex b2ed72f7fd1a..6581ae1a191d 100644\n--- a/litellm/main.py\n+++ b/litellm/main.py\n@@ -117,7 +117,31 @@ def create(s... | [
{
"diff_hunk": "@@ -117,7 +117,31 @@ def create(self, messages, model=None, **kwargs):\n return response \n \n @client\n-async def acompletion(*args, **kwargs):\n+async def acompletion(",
"line": 133,
"original_line": 120,
"original_start_line": null,
"path": "litellm/main.py",
"start_l... | 203089e6c795631d732461ff3703658783872da9 | diff --git a/litellm/main.py b/litellm/main.py
index 4978c79f1af2..5e2bcc4ef64a 100644
--- a/litellm/main.py
+++ b/litellm/main.py
@@ -130,7 +130,39 @@ def create(self, messages, model=None, **kwargs):
@client
-async def acompletion(*args, **kwargs):
+async def acompletion(
+ model: str,
+ # Optional... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1228@0e2c90b | Avaiga/taipy | Python | 1,228 | Fix/#1202 - Catch cookiecutter.OutputDirExistsException and exit | Resolves #1202 | 2024-04-24T08:52:12Z | BUG-taipy create fails if the project folder already exists
**Description**
`taipy create` command fails if the project folder already exists.
**How to reproduce**
```sh
taipy create
# accept defaults. Default root folder name is 'taipy_application'
# Run the create again and accept defaults
taipy create
... | Thank you for reporting the issue. Indeed, it should at least exit gracefully with a good error message. | [
{
"body": "**Description**\r\n`taipy create` command fails if the project folder already exists.\r\n\r\n**How to reproduce**\r\n\r\n```sh\r\ntaipy create \r\n# accept defaults. Default root folder name is 'taipy_application'\r\n\r\n# Run the create again and accept defaults\r\ntaipy create\r\n```\r\n\r\nFails w... | 13fbf01c0a25a8f214abbb6ed21878d4d5245ba5 | {
"head_commit": "0e2c90bf47afb3072d267059a5389d8d17ab5371",
"head_commit_message": "fix: catch cookiecutter OutputDirExistsException and exit",
"patch_to_review": "diff --git a/taipy/_cli/_scaffold_cli.py b/taipy/_cli/_scaffold_cli.py\nindex d52caf998c..4d1d1435bb 100644\n--- a/taipy/_cli/_scaffold_cli.py\n+++ b... | [
{
"diff_hunk": "@@ -45,6 +46,10 @@ def handle_command(cls):\n args = cls._parse_arguments()\n if not args:\n return\n-\n- cookiecutter(cls._TEMPLATE_MAP[args.template])\n+ try:\n+ cookiecutter(cls._TEMPLATE_MAP[args.template])\n+ except OutputDirExists... | 3c483c31f2afd3d7e540266fcac7c2b21c7ed7ec | diff --git a/taipy/_cli/_scaffold_cli.py b/taipy/_cli/_scaffold_cli.py
index d52caf998c..92c0136847 100644
--- a/taipy/_cli/_scaffold_cli.py
+++ b/taipy/_cli/_scaffold_cli.py
@@ -12,6 +12,7 @@
import pathlib
import sys
+from cookiecutter.exceptions import OutputDirExistsException
from cookiecutter.main import cook... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Avaiga__taipy-1474@2826816 | Avaiga/taipy | Python | 1,474 | Feature/#1196 - Add download and upload api for file-based datanodes | Resolves #1196
In this PR, 2 new APIs are open for file-based DataNode:
- `_get_downloadable_path()` that returns the path to the downloadable data file
- `_upload()` that check the uploaded file and replace the current data file | 2024-07-01T15:51:45Z | Data node Viewer - Add file download/upload capability for file based data nodes
**Description**
When a data node is stored as a file, it would be handy for the end user to add a way to download or upload the file from the data node viewer easily.
This should help the end user understand its data, particularly when da... | Seems related to this https://github.com/Avaiga/taipy/issues/427
There are a few use-cases I think we need to clarify before actually implement the feature. I will only mainly on the Core side of the problem here, and error handling on GUI as well.
1. If the datanode is not file-based, what happens?
- Raise an erro... | [
{
"body": "**Description**\nWhen a data node is stored as a file, it would be handy for the end user to add a way to download or upload the file from the data node viewer easily.\n\nThis should help the end user understand its data, particularly when data is corrupted or an unexpected behavior happens.\n\nThis ... | 0782ef092375ebcd002ca54747ecc677cfdc69c4 | {
"head_commit": "2826816215e8d782e05ba3720566dfb2006b945d",
"head_commit_message": "feat: add download and upload api for file-based datanodes",
"patch_to_review": "diff --git a/taipy/core/data/_file_datanode_mixin.py b/taipy/core/data/_file_datanode_mixin.py\nindex 4521922d25..cbab6614cf 100644\n--- a/taipy/cor... | [
{
"diff_hunk": "@@ -27,7 +27,7 @@\n from .data_node_id import DataNodeId, Edit\n \n \n-class CSVDataNode(DataNode, _FileDataNodeMixin, _TabularDataNodeMixin):\n+class CSVDataNode(_FileDataNodeMixin, DataNode, _TabularDataNodeMixin):",
"line": null,
"original_line": 30,
"original_start_line": null,
... | 552c1e234de60b5d0076fdb64bf2af76b362235b | diff --git a/taipy/core/data/_file_datanode_mixin.py b/taipy/core/data/_file_datanode_mixin.py
index 4521922d25..d24356dfaa 100644
--- a/taipy/core/data/_file_datanode_mixin.py
+++ b/taipy/core/data/_file_datanode_mixin.py
@@ -14,11 +14,13 @@
import shutil
from datetime import datetime
from os.path import isfile
-fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1284@1ef0fe2 | Avaiga/taipy | Python | 1,284 | Feature/#507 separate package long desc with readme | Resolves #507
In this PR:
- Add a "package_desc.md" file for each taipy package and use that instead of "README.md" on "setup.py"
- Remove redundant "CONTRIBUTING.md" files in subpackages
- Minor updates on "README.md" files and "INSTALLATION.md" files | 2024-05-14T09:31:31Z | Stop using the README as long description in the various setup.py
In all the `setup.py` files (config, gui, core, rest, taipy, templates), the long_description is populated with the README.md content.
This is NOT a good practice since the long description represents a description of the package built. It is used in Py... | [
{
"body": "In all the `setup.py` files (config, gui, core, rest, taipy, templates), the long_description is populated with the README.md content. \nThis is NOT a good practice since the long description represents a description of the package built. It is used in Pypi to describe the package. The readme is also... | cff32624e10b83518359dd1cc88ff9b4d8dba81b | {
"head_commit": "1ef0fe25b8d1d32fd0272109dc28dc72b8d01eab",
"head_commit_message": "fix: update aterises and CONTRIBUTING.md link",
"patch_to_review": "diff --git a/package_desc.md b/package_desc.md\nnew file mode 100644\nindex 0000000000..e667663186\n--- /dev/null\n+++ b/package_desc.md\n@@ -0,0 +1,76 @@\n+# Ta... | [
{
"diff_hunk": "@@ -0,0 +1,76 @@\n+# Taipy\n+\n+## License\n+\n+Copyright 2021-2024 Avaiga Private Limited\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file\n+except in compliance with the License. You may obtain a copy of the License at\n+[http://www.apache.org/li... | 404685dab048a3b2edcfba77c3da50e346e7fcdd | diff --git a/package_desc.md b/package_desc.md
new file mode 100644
index 0000000000..bdde0533c8
--- /dev/null
+++ b/package_desc.md
@@ -0,0 +1,61 @@
+# Taipy
+
+## License
+
+Copyright 2021-2024 Avaiga Private Limited
+
+Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
+except ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
Avaiga__taipy-1194@6819b74 | Avaiga/taipy | Python | 1,194 | Feature/#410 - Import scenario from an exported one | Resolves #410 | 2024-04-16T10:08:16Z | Possbility to import a scenario (after an export)
**What would that feature address**
The possibility of importing a scenario/scenarios after exporting it with Taipy. The problem is that in the context of a project, different scenarios are present in different environments (Test, QA, Production).
For example, the ... | For the current implementation of the `taipy.export()` API, user data is not exported alongside the entities.
We will need to check if the data is Taipy generated, we should also export the user data.
The new signature of the export method can be:
```
taipy.export(include_data=True)
```
When including the data, we w... | [
{
"body": "**What would that feature address**\r\nThe possibility of importing a scenario/scenarios after exporting it with Taipy. The problem is that in the context of a project, different scenarios are present in different environments (Test, QA, Production). \r\n\r\nFor example, the end user tests its applic... | 31f236195711a2f530d64d3fa619756bae139381 | {
"head_commit": "6819b74f9ea18bd4deadd4c416e0754bcebb5d21",
"head_commit_message": "fix: mypy errors",
"patch_to_review": "diff --git a/taipy/core/_manager/_manager.py b/taipy/core/_manager/_manager.py\nindex 7219cec97f..bf406b1bdb 100644\n--- a/taipy/core/_manager/_manager.py\n+++ b/taipy/core/_manager/_manager... | [
{
"diff_hunk": "@@ -450,3 +457,85 @@ def _get_by_config_id(cls, config_id: str, version_number: Optional[str] = None)\n for fil in filters:\n fil.update({\"config_id\": config_id})\n return cls._repository._load_all(filters)\n+\n+ @classmethod\n+ def _import_scenario_and_childr... | 665e7d5a1666f90d44672edf27cb53bdf9c11871 | diff --git a/taipy/core/_manager/_manager.py b/taipy/core/_manager/_manager.py
index 7219cec97f..bf406b1bdb 100644
--- a/taipy/core/_manager/_manager.py
+++ b/taipy/core/_manager/_manager.py
@@ -157,6 +157,13 @@ def _delete_entities_of_multiple_types(cls, _entity_ids: _EntityIds):
def _export(cls, id: str, folder_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1078@3340547 | Avaiga/taipy | Python | 1,078 | Refactor - All file-based datanode should have consistent default data writing behavior | In this PR:
- Refactor the `_FileDataNodeMixin`
- Fix clean all data entities doesn't delete all generated data.
- Other minor code format fixes | 2024-04-02T09:59:22Z | Generalize default_data attribute for all predefined data nodes
Today, a default data attribute in Data Node config is implemented for csv, excel, in memory, json, parquet, pickle storage types.
We want to make it generic for all data node types, in a similar way.
- [ ] Implement the data writing with default data whe... | Is this issue still active? @jrobinAV
Yes, absolutely.
Please explain the issue in greater detail. @jrobinAV
When configure csv, excel, in memory, json, parquet, pickle data node, you can provide the "default_data" attribute that will be automatically written to the data node if the data node does not exist yet.
T... | [
{
"body": "Today, a default data attribute in Data Node config is implemented for csv, excel, in memory, json, parquet, pickle storage types.\nWe want to make it generic for all data node types, in a similar way.\n\n- [ ] Implement the data writing with default data when creating the data node for the first tim... | 7d48ce689eb6527bb2ad6cd40269c469fcb6562f | {
"head_commit": "3340547d630c04d293d6bae553075e0eac4fb512",
"head_commit_message": "fix: last_edit_date should be last_modified_datetime when writing",
"patch_to_review": "diff --git a/taipy/core/_entity/_properties.py b/taipy/core/_entity/_properties.py\nindex 043271bbca..90d2f45680 100644\n--- a/taipy/core/_en... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "tests/core/_orchestrator/test_orchestrator__submit.py",
"start_line": null,
"text": "@user1:\nTwo global remarks:\r\n\r\n1. The tests on the various timestamps are dangerous to me. Regarding the... | b7ffab3051941c727745227160ce001d32915f70 | diff --git a/taipy/core/_entity/_properties.py b/taipy/core/_entity/_properties.py
index 043271bbca..90d2f45680 100644
--- a/taipy/core/_entity/_properties.py
+++ b/taipy/core/_entity/_properties.py
@@ -11,6 +11,8 @@
from collections import UserDict
+from taipy.config.common._template_handler import _TemplateHandl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-1056@77ccc0f | Avaiga/taipy | Python | 1,056 | feature/#957 attempt to clean dn inheritance | #957 | 2024-03-28T07:39:21Z | Clean DN inheritance
The inheritance mechanism for all data nodes would benefit from some cleaning.
Suggestions:
- The `_AbstractTabularDataNode` is not a data node but a mixin. The name is misleading. It is more like a mixin.
- Same for `_AbstractFileDataNode`.
- However, the `_abstract_sql` is a data node sub-class... | @jrobinAV I think the inconsistency for `abstract_sql` is due to it extending from `DataNode` class. So instead of for example, the SQLTableDataNode class extending from DataNode and AbstractSQLDataNode, it only extending from AbstractSQLDataNode (and the abstract sql dn is extending DataNode) | [
{
"body": "The inheritance mechanism for all data nodes would benefit from some cleaning.\n\nSuggestions:\n\n- The `_AbstractTabularDataNode` is not a data node but a mixin. The name is misleading. It is more like a mixin.\n- Same for `_AbstractFileDataNode`.\n- However, the `_abstract_sql` is a data node sub-c... | 54d7d9931439c131697a49b83cb988526da691e8 | {
"head_commit": "77ccc0f01867f9dbe2b2d6eb7e6a9de453f12676",
"head_commit_message": "Merge branch 'develop' into feature/#957-clean-dn-inheritance",
"patch_to_review": "diff --git a/taipy/core/data/_abstract_file.py b/taipy/core/data/_abstract_file.py\nindex 41be0e6020..82dda99a8c 100644\n--- a/taipy/core/data/_a... | [
{
"diff_hunk": "@@ -17,7 +17,7 @@\n from ..exceptions.exceptions import InvalidExposedType\n \n \n-class _AbstractTabularDataNode(object):\n+class _AbstractTabularDataNodeMixin(object):",
"line": null,
"original_line": 20,
"original_start_line": null,
"path": "taipy/core/data/_abstract_tabular.p... | 25a275f90bc0d820f9f70d8404c38e2a00b9e4f7 | diff --git a/taipy/core/data/_abstract_file.py b/taipy/core/data/_abstract_file.py
index 41be0e6020..2dddba671e 100644
--- a/taipy/core/data/_abstract_file.py
+++ b/taipy/core/data/_abstract_file.py
@@ -13,9 +13,9 @@
import shutil
-class _AbstractFileDataNode(object):
- """Abstract base class for data node impl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
Avaiga__taipy-984@1a2fd94 | Avaiga/taipy | Python | 984 | Fix MapDict refresh error (#464) | Resolve #464 | 2024-03-18T09:50:27Z | BUG-Error when calling 'refresh' with dataframes
**Description**
An error occurs when refresh is being used inside a function and called twice.
```
TaipyGuiWarning: on_action(): Exception raised in 'change()':
maximum recursion depth exceeded
TaipyGuiWarning: on_action(): 'change' is not a valid function.
```
... | [
{
"body": "**Description**\r\nAn error occurs when refresh is being used inside a function and called twice.\r\n\r\n```\r\nTaipyGuiWarning: on_action(): Exception raised in 'change()':\r\nmaximum recursion depth exceeded\r\nTaipyGuiWarning: on_action(): 'change' is not a valid function.\r\n```\r\n\r\n**How to r... | ac839daf38a4aa55629e34a4b443cced4c142e45 | {
"head_commit": "1a2fd94cc9c4cc7efe5f080e64008624bf6e9951",
"head_commit_message": "Fix MapDict refresh error",
"patch_to_review": "diff --git a/taipy/gui/utils/_bindings.py b/taipy/gui/utils/_bindings.py\nindex 6a5185d0b4..bbbca379c4 100644\n--- a/taipy/gui/utils/_bindings.py\n+++ b/taipy/gui/utils/_bindings.py... | [
{
"diff_hunk": "@@ -39,6 +39,8 @@ def _bind(self, name: str, value: t.Any) -> None:\n \n def __get_property(self, name):\n def __setter(ud: _Bindings, value: t.Any):\n+ if isinstance(value, _MapDict):\n+ value._update_var = None\n if isinstance(value, dict):",
... | 881a21038d00c4c01d8857e53dec3e019ae5bb49 | diff --git a/taipy/gui/utils/_bindings.py b/taipy/gui/utils/_bindings.py
index 6a5185d0b4..f47ded91a6 100644
--- a/taipy/gui/utils/_bindings.py
+++ b/taipy/gui/utils/_bindings.py
@@ -39,7 +39,9 @@ def _bind(self, name: str, value: t.Any) -> None:
def __get_property(self, name):
def __setter(ud: _Binding... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
Avaiga__taipy-958@30ee8b8 | Avaiga/taipy | Python | 958 | no error when the column desc is undefined | - add a message to let the user know that he needs to bind data variables
resolves #466 | 2024-03-11T15:13:43Z | BUG- Rebuild property not working as expected
**Description**
Changing the chart will sometimes not correctly update the chart without refreshing it even with _rebuild_ set to True.
**How to reproduce**
### First example
```python
from taipy.gui import Gui
import pandas as pd
all_data = pd.DataFrame({
... | [
{
"body": "**Description**\r\nChanging the chart will sometimes not correctly update the chart without refreshing it even with _rebuild_ set to True. \r\n\r\n\r\n**How to reproduce**\r\n\r\n### First example\r\n```python\r\nfrom taipy.gui import Gui\r\nimport pandas as pd\r\n\r\nall_data = pd.DataFrame({\r\n ... | fbca22d9bd24ba2942c031af44a11a438e0ce5c3 | {
"head_commit": "30ee8b8b1bf2cb4b6279d847059995b663b0f4c0",
"head_commit_message": "no error when the column desc is undefined\nadd a message to let the user know that he needs to bind data variables\nresolves #466",
"patch_to_review": "diff --git a/frontend/taipy-gui/package-lock.json b/frontend/taipy-gui/packa... | [
{
"diff_hunk": "@@ -775,6 +775,8 @@ def set_value_and_default(\n else:\n self.__set_default_value(var_name, var_type=var_type)\n else:\n+ if var_type == PropertyType.data:\n+ _warn(f\"{self.__control_type}.data property should be binded.\")",... | 568b5344eb1947a45e97146a7782dd169235df91 | diff --git a/frontend/taipy-gui/package-lock.json b/frontend/taipy-gui/package-lock.json
index d87d24591b..99a5066cf7 100644
--- a/frontend/taipy-gui/package-lock.json
+++ b/frontend/taipy-gui/package-lock.json
@@ -1682,14 +1682,14 @@
}
},
"node_modules/@mui/base": {
- "version": "5.0.0-beta.37",
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
Avaiga__taipy-967@f90a21b | Avaiga/taipy | Python | 967 | better message on column not found | based on [srinivaspavan9](https://github.com/srinivaspavan9)'s work
linter compliance
resolves #379 | 2024-03-13T08:47:57Z | BUG-Inputting the wrong column name in a chart reports empty data
**Description**
Inputting the wrong column name in a chart visual element will report that the dataset used is empty when it is not. This leads the user to think that the issue is with the dataset instead of the column name.
**How to reproduce**
Run... | Hi @AlexandreSajus I have started working on this issue, I am trying to debug the code to find out where the warnings are being generated but it seems that I am not able to step into the Gui(page).run() line after hitting that breakpoint. what am i doing wrong ? and also i changed the first line to "from taipy.gui im... | [
{
"body": "**Description**\r\nInputting the wrong column name in a chart visual element will report that the dataset used is empty when it is not. This leads the user to think that the issue is with the dataset instead of the column name.\r\n\r\n**How to reproduce**\r\nRunning this code where I made a mistake o... | 3d35330bbb7fb444447ab0123c6a8d4c7269ada6 | {
"head_commit": "f90a21bc65d5613fd6f0f1bf2301002696b9b043",
"head_commit_message": "format and small fix",
"patch_to_review": "diff --git a/taipy/gui/_renderers/utils.py b/taipy/gui/_renderers/utils.py\nindex 54c74d0bb3..6100b0cecc 100644\n--- a/taipy/gui/_renderers/utils.py\n+++ b/taipy/gui/_renderers/utils.py\... | [
{
"diff_hunk": "@@ -31,14 +33,30 @@ def _get_columns_dict_from_list(\n ):\n col_dict = {}\n idx = 0\n+ cols = None\n+\n for col in col_list:\n if col in col_types_keys:\n col_dict[col] = {\"index\": idx}\n idx += 1\n elif col:\n- _warn(\n- ... | 219cf1200f015e7afc43728816cc8e196b368114 | diff --git a/taipy/core/_orchestrator/_orchestrator.py b/taipy/core/_orchestrator/_orchestrator.py
index c2e002de70..4a5d6d2fe4 100644
--- a/taipy/core/_orchestrator/_orchestrator.py
+++ b/taipy/core/_orchestrator/_orchestrator.py
@@ -77,7 +77,7 @@ def submit(
getattr(submittable, "config_id", None),
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
Avaiga__taipy-978@aebb894 | Avaiga/taipy | Python | 978 | Access all elements from the root of Builder API (#418) | Resolve #418
```
import taipy.gui.builder as tgb
from taipy.gui import Gui
with tgb.Page() as page:
tgb.scenario(None)
Gui(page=page).run()
``` | 2024-03-15T09:24:07Z | Access Gui-Core viz elements from the root of taipy gui builder
All Gui-Core visual elements should be accessible through the Taipy Gui Builder API.
This should work:
```python
from taipy.gui import Gui
import taipy.gui.builder as tgb
with tgb.Page() as page:
tgb.scenario(None)
Gui(page=page).run(... | Is it really solved? This is still not working on my side
Any update on this?
Did you try `tgb.gui_core.scenario`
```
C:\Users\jacta\.conda\envs\enterprise_3_1\lib\site-packages\taipy\gui\gui.py:774: TaipyGuiWarning: on... | [
{
"body": "All Gui-Core visual elements should be accessible through the Taipy Gui Builder API.\r\n\r\nThis should work:\r\n```python\r\nfrom taipy.gui import Gui \r\nimport taipy.gui.builder as tgb\r\n\r\n\r\nwith tgb.Page() as page:\r\n tgb.scenario(None)\r\n\r\n\r\nGui(page=page).run()\r\n```\r\n",
"n... | 9930266d29b81f1297ec89bef32c1a0bdc2b09fb | {
"head_commit": "aebb89435f3f541e1020f64342c46fa057d17a70",
"head_commit_message": "Access all elements from the root of Builder API",
"patch_to_review": "diff --git a/taipy/gui/builder/_api_generator.py b/taipy/gui/builder/_api_generator.py\nindex 9a20593cf2..1a002d2da3 100644\n--- a/taipy/gui/builder/_api_gene... | [
{
"diff_hunk": "@@ -83,6 +83,13 @@ def add_library(self, library: \"ElementLibrary\"):\n element_name, f\"{library_name}.{element_name}\", element.default_attribute\n ),\n )\n+ # Allow element to be accessed from the root module\n+ if hasattr... | f3f94aee108b49f0bffcc81df0596ad02b4baf17 | diff --git a/taipy/gui/builder/_api_generator.py b/taipy/gui/builder/_api_generator.py
index 9a20593cf2..7278d22e44 100644
--- a/taipy/gui/builder/_api_generator.py
+++ b/taipy/gui/builder/_api_generator.py
@@ -83,6 +83,13 @@ def add_library(self, library: "ElementLibrary"):
element_name, f"{librar... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-948@d77a2b2 | Avaiga/taipy | Python | 948 | table cell action when value is a button | - a button is shown when cell value is \[button label](button value)
- fix lov clear selection
resolves #945
resolves #947
```
import pandas as pd
from taipy.gui import Gui, State
data = {
"label": ["red", "white"],
"timedelta": [pd.Timedelta(days=1), pd.Timedelta(days=2)],
"links": ["[link ... | 2024-03-08T12:58:17Z | Clickable Links in a Table
**What would that feature address**
It is not possible to show clickable links in a table
***Description of the ideal solution***
It would be great to be able to tell Taipy that a column's data type is "link" in the table definition to make http links clickable. And it would be nice to p... | supporting a simple version of markdown links might be faisable
ie \[label](action)
would render as a button that will dispatch the table on_button_action with the label and action as args | [
{
"body": "**What would that feature address**\r\nIt is not possible to show clickable links in a table\r\n\r\n***Description of the ideal solution***\r\nIt would be great to be able to tell Taipy that a column's data type is \"link\" in the table definition to make http links clickable. And it would be nice to... | 1903c9b2142eaab7d1ac0ef0cba1ee4dd382ec7b | {
"head_commit": "d77a2b2385c5dc1df43032fa6e49f01f59f4d985",
"head_commit_message": "improve test",
"patch_to_review": "diff --git a/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx b/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx\nindex 1c281e652c..a0d4a42da2 100644\n--- a/frontend/taip... | [
{
"diff_hunk": "@@ -1111,7 +1111,7 @@\n {\n \"name\": \"on_action\",\n \"type\": \"str\",\n- \"doc\": \"The name of a function that is triggered when the user selects a row.<br/>All parameters of that function are optional:\\n<ul>\\n<li>state (<code>State^</code>): t... | 012ee854365970c19ba3ebbcecbbf35f46b7feff | diff --git a/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx b/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx
index 1c281e652c..a0d4a42da2 100644
--- a/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx
+++ b/frontend/taipy-gui/src/components/Taipy/AutoLoadingTable.tsx
@@ -110,7 +11... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Avaiga__taipy-1042@a76a34b | Avaiga/taipy | Python | 1,042 | Feature/#392 - Sort mechanism for `get_primary_scenarios()` and `get_scenarios()` API | 2024-03-25T10:18:04Z | Sort mechanism for get_all_scenarios and get_primaries functions
### Description
When calling `tp.get_scenarios()` or `tp.get_primary_scenarios()`, the user should be able to provide an optional field for sorting the scenarios.
The sort should be increasing or decreasing.
The sort could be on the name (default), i... | I would like to contribute to this issue. Could you please assign it to me?
Hello @Luke-0162, thank you for joining our project. I assigned the issue to you.
Please let me know if you need more information about the issue.
Hello @trgiangdo, thank you for your response. I am looking forward to solve this issue.
Co... | [
{
"body": "### Description\r\n\r\nWhen calling `tp.get_scenarios()` or `tp.get_primary_scenarios()`, the user should be able to provide an optional field for sorting the scenarios.\r\nThe sort should be increasing or decreasing.\r\nThe sort could be on the name (default), id, creation_date, or tag.\r\n",
"n... | 48b4f24b0a7de7764d85e5146369f5cffc77b4ac | {
"head_commit": "a76a34b48b3cebe1a0d06f64dd01715693a14480",
"head_commit_message": "Update taipy/core/taipy.py\n\nCo-authored-by: Đỗ Trường Giang <dtr.giang.1299@gmail.com>",
"patch_to_review": "diff --git a/contributors.txt b/contributors.txt\nindex 600daf7485..0c6fbdd083 100644\n--- a/contributors.txt\n+++ b/c... | [
{
"diff_hunk": "@@ -267,8 +267,16 @@ def _get_all_by_cycle(cls, cycle: Cycle) -> List[Scenario]:\n return cls._get_all_by(filters)\n \n @classmethod\n- def _get_primary_scenarios(cls) -> List[Scenario]:\n- return [scenario for scenario in cls._get_all() if scenario.is_primary]\n+ def _g... | a72cbb79ea8ad2976e87b132c6adb6cdd05e7048 | diff --git a/contributors.txt b/contributors.txt
index 600daf7485..0c6fbdd083 100644
--- a/contributors.txt
+++ b/contributors.txt
@@ -14,3 +14,4 @@ enarroied
bobbyshermi
Forchapeatl
yarikoptic
+Luke-0162
diff --git a/taipy/core/scenario/_scenario_manager.py b/taipy/core/scenario/_scenario_manager.py
index 0eb046659... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-915@11f54bf | Avaiga/taipy | Python | 915 | align core service logs | Resolves #803 | 2024-03-02T12:04:57Z | Align Core service logs.
**Description**
Here is an example of the logs generated by running a core service, executing two tasks and stopping the service.
```
[2024-02-07 10:27:44][Taipy][INFO] Start job dispatcher...
[2024-02-07 10:27:48][Taipy][INFO] job JOB_arima_training_7d61b95e-4998-4696-953b-ff74179f06b3 is com... | [
{
"body": "**Description**\nHere is an example of the logs generated by running a core service, executing two tasks and stopping the service. \n```\n[2024-02-07 10:27:44][Taipy][INFO] Start job dispatcher...\n[2024-02-07 10:27:48][Taipy][INFO] job JOB_arima_training_7d61b95e-4998-4696-953b-ff74179f06b3 is compl... | b3df2ed07d987504b4be5bb8e7fc18b6c0f90ac3 | {
"head_commit": "11f54bfa1b385b2d2ea0ec3360db941ba69bf3ca",
"head_commit_message": "add Core service started... to Core.run()",
"patch_to_review": "diff --git a/taipy/core/_core.py b/taipy/core/_core.py\nindex 413927fd63..f85122321a 100644\n--- a/taipy/core/_core.py\n+++ b/taipy/core/_core.py\n@@ -61,6 +61,7 @@ ... | [
{
"diff_hunk": "@@ -61,7 +61,7 @@ def stop(self, wait: bool = True, timeout: Optional[float] = None):\n self.join(timeout=timeout)\n \n def run(self):\n- self._logger.info(\"Start job dispatcher...\")\n+ self._logger.debug(\"Start job dispatcher...\")",
"line": null,
"origi... | afc86ab277e57350fc03b95a385166e35c1e0aa8 | diff --git a/taipy/core/_core.py b/taipy/core/_core.py
index 413927fd63..9754008aaf 100644
--- a/taipy/core/_core.py
+++ b/taipy/core/_core.py
@@ -61,6 +61,7 @@ def run(self, force_restart=False):
self.__class__._is_running = True
self._manage_version_and_block_config()
+ self.__logger.in... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
Avaiga__taipy-853@2d67df4 | Avaiga/taipy | Python | 853 | GUI: Decouple ws synchro update (#854) | Resolve #854 | 2024-02-19T16:58:48Z | Enhance decouple websocket synchro
**Description**
Decouple API should handled reload cases and recoginize data tree changes when reload
**Acceptance Criteria**
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%
- [ ] Propagate any change on the demos and run all of them to ensure there... | [
{
"body": "**Description**\r\nDecouple API should handled reload cases and recoginize data tree changes when reload\r\n\r\n**Acceptance Criteria**\r\n- [ ] Ensure new code is unit tested, and check code coverage is at least 90%\r\n- [ ] Propagate any change on the demos and run all of them to ensure there is no... | 07a0fbc50014ccb212e8fb480a99411506b761f3 | {
"head_commit": "2d67df4cdccbc48f7510e33e81fcc8f71df9b054",
"head_commit_message": "Updated websocket waterfall",
"patch_to_review": "diff --git a/frontend/taipy-gui/base/src/app.ts b/frontend/taipy-gui/base/src/app.ts\nindex 0a788d1a24..b7f5478d7d 100644\n--- a/frontend/taipy-gui/base/src/app.ts\n+++ b/frontend... | [
{
"diff_hunk": "@@ -22,10 +22,30 @@ export class VariableManager {\n constructor(variableModuleData: VariableModuleData) {\n this._data = {};\n this._variables = {};\n- this.resetInitData(variableModuleData);\n+ this.init(variableModuleData);\n }\n \n- resetInitData(vari... | ce4bf476db1ea44bb624f41c2b0c45c9261fdbfe | diff --git a/frontend/taipy-gui/base/src/app.ts b/frontend/taipy-gui/base/src/app.ts
index 0a788d1a24..b7f5478d7d 100644
--- a/frontend/taipy-gui/base/src/app.ts
+++ b/frontend/taipy-gui/base/src/app.ts
@@ -1,4 +1,5 @@
-import { sendWsMessage } from "../../src/context/wsUtils";
+import { getLocalStorageValue } from "..... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
Avaiga__taipy-833@24559da | Avaiga/taipy | Python | 833 | Clean standalone run running under with context to automatically shutdown | Resolves #763
Code cleaning to try facilitating flaky test investigation
- Use executor context to shut it down
- Remove useless test
- Make orchestrator not optional in dispatcher constructor signature.
- catch error when deleting Excel file after tests because of an openpyxl bug. | 2024-02-14T14:41:51Z | Make orchestrator mandatory in Dispatcher constructor signature.
**Description**
Today, the constructor of the JobDispatcher class has an optional `_Orchestrator` parameter.
The parameter is used in the constructor and assumes it is not None.
The parameter should be turned into a mandatory parameter.
**Acceptance Cri... | [
{
"body": "**Description**\nToday, the constructor of the JobDispatcher class has an optional `_Orchestrator` parameter.\nThe parameter is used in the constructor and assumes it is not None. \nThe parameter should be turned into a mandatory parameter.\n\n**Acceptance Criteria**\n- [ ] The parameter is mandatory... | 8d19fc00e9cb96278d1b606417d93487f1f83aa4 | {
"head_commit": "24559da36c770ca0bc3eefeaa0a3f1300b9921e4",
"head_commit_message": "simplify",
"patch_to_review": "diff --git a/taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py b/taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py\nindex fe42d59d05..a9cb05693e 100644\n--- a/tai... | [
{
"diff_hunk": "@@ -51,6 +51,22 @@ def __post_init__(self):\n setattr(self, field.name, field.type(value))\n \n \n+def test_fail():",
"line": null,
"original_line": 54,
"original_start_line": null,
"path": "tests/core/data/test_write_single_sheet_excel_data_node.py",
"start_l... | 28ecea499b1fff0484940d7399423904182b0089 | diff --git a/taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py b/taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py
index fe42d59d05..a9cb05693e 100644
--- a/taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py
+++ b/taipy/core/_orchestrator/_dispatcher/_development_job... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-799@31dcba2 | Avaiga/taipy | Python | 799 | Update Frontend Decouple | Resolves #764 #766 | 2024-02-06T08:30:30Z | Chalk'it .xprjson file life-cycle
For ensuring taipy-chalkit use-case, consider the simplest program:
```python
from taipy.gui import Gui
from taipy.chalkit import Page
a = 8
b = 10
c = a + b * 2
def on_change(state):
state.c = state.a + state.b * 2
gui = Gui()
page = Page("my_project.xprjson")
... | [
{
"body": "For ensuring taipy-chalkit use-case, consider the simplest program:\r\n\r\n```python\r\nfrom taipy.gui import Gui\r\nfrom taipy.chalkit import Page\r\n \r\na = 8\r\nb = 10\r\nc = a + b * 2\r\n \r\ndef on_change(state):\r\n state.c = state.a + state.b * 2\r\n\r\ngui = Gui()\r\npage = Page(\"my_proj... | 0877043a9fab3879dc04ff9d188dc7102a830ded | {
"head_commit": "31dcba26740a9ac301222ccd1f7fbd65b9595608",
"head_commit_message": "Update Frontend Decoupld",
"patch_to_review": "diff --git a/frontend/taipy-gui/base/src/app.ts b/frontend/taipy-gui/base/src/app.ts\nindex db665a50c1..187d3e4c7b 100644\n--- a/frontend/taipy-gui/base/src/app.ts\n+++ b/frontend/ta... | [
{
"diff_hunk": "@@ -39,19 +40,19 @@ export class TaipyApp {\n }\n set onInit(handler: OnInitHandler | undefined) {\n if (handler !== undefined && handler?.length !== 1) {\n- throw new Error(\"onInit function requires 1 parameter\")\n+ throw new Error(\"onInit function requi... | 389411a9194654b90acade7ad703e8c912db482f | diff --git a/frontend/taipy-gui/base/src/app.ts b/frontend/taipy-gui/base/src/app.ts
index db665a50c1..0a788d1a24 100644
--- a/frontend/taipy-gui/base/src/app.ts
+++ b/frontend/taipy-gui/base/src/app.ts
@@ -1,4 +1,5 @@
import { sendWsMessage } from "../../src/context/wsUtils";
+import { uploadFile } from "../../src/wo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-725@675e4b8 | Avaiga/taipy | Python | 725 | Property to not show the creation dialog | Scenario to filter list in datanode_selector.
Resolves #280
Partly resolves #214. | 2024-01-18T16:41:45Z | Data Node Selector - Filter on selected scenario
## New Feature / Improvement
Filtering the Data Node selector by scenario would allow the user to see Data Nodes of the selected scenario without all the others. It can be really useful in an application. It would also create a "bridge" between the Scenario selector a... | We could also add a generic filter. It can be extremely useful to not display every Data Node (some can be irrelevant). The selector should call this function for each Data Node, and the function should return True to display the Data Node in the Data Node Selector.
Example of code:
```
<|{datanode}|data_node_sele... | [
{
"body": "## New Feature / Improvement\r\n\r\nFiltering the Data Node selector by scenario would allow the user to see Data Nodes of the selected scenario without all the others. It can be really useful in an application. It would also create a \"bridge\" between the Scenario selector and Data Node selector.\r... | 81def5a0173a16e4e196f1509d827ddecbc10dc7 | {
"head_commit": "675e4b872c9ba8b7668a30b971c6b662844878f0",
"head_commit_message": "Property to not show a creation dialog\nscenario to limit datanode_selector list",
"patch_to_review": "diff --git a/frontend/taipy/package-lock.json b/frontend/taipy/package-lock.json\nindex 506b93a3a7..d53657c2c8 100644\n--- a/f... | [
{
"diff_hunk": "@@ -361,6 +361,16 @@ def crud_scenario(self, state: State, id: str, payload: t.Dict[str, str]): # no\n return\n elif on_creation is not None:\n _warn(f\"on_creation(): '{on_creation}' is not a function.\")\n+ elif not wi... | 46d1036c26bb84cdbc3abbd85d80f95170bdf2a0 | diff --git a/frontend/taipy/package-lock.json b/frontend/taipy/package-lock.json
index 506b93a3a7..d53657c2c8 100644
--- a/frontend/taipy/package-lock.json
+++ b/frontend/taipy/package-lock.json
@@ -40,11 +40,6 @@
"webpack-cli": "^5.0.1"
}
},
- "../../../.virtualenvs/taipy-OW_uNObx/Lib/site-pack... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-800@0217164 | Avaiga/taipy | Python | 800 | Added Step Property to the Slider component | ## Description
Added a step property to the Slider component so that users can
I need some help here
- How can I use the same setting of formatting? I just turned off formatting for the moment.
- I created the test function, but I got an assertion error. Not sure how to fix it.
## Related Issue
resolv... | 2024-02-06T19:03:35Z | Make a slider in float type with a particular step value
I'm trying to make a slider in float type with a particular step value.
How to make it?
I think it will be easier to use if there's a "step" property:
```
pressure = 0.05
with tgb.Page() as page:
tgb.slider("{pressure}", min=0.01, max=0.1, step=0.... | You can code this, for example as a way to mimic what you want to do:
```python
import taipy.gui.builder as tgb
from taipy.gui import Gui
# create a list of string 0.1, 0.2, 0.3, ...
string_list = [str(i / 10) for i in range(1, 11)]
pressure = string_list[0]
with tgb.Page() as page:
tgb.text("Slider:... | [
{
"body": "I'm trying to make a slider in float type with a particular step value. \r\nHow to make it?\r\n\r\nI think it will be easier to use if there's a \"step\" property: \r\n\r\n```\r\npressure = 0.05\r\nwith tgb.Page() as page:\r\n tgb.slider(\"{pressure}\", min=0.01, max=0.1, step=0.01)\r\n```\r\n",
... | 7a64a12957d72a49c2f99af40c90562c4d5231d6 | {
"head_commit": "02171647083b10f19f3b62810700d5c36a5c1841",
"head_commit_message": "Formatted the code",
"patch_to_review": "diff --git a/frontend/taipy-gui/src/components/Taipy/Slider.tsx b/frontend/taipy-gui/src/components/Taipy/Slider.tsx\nindex 4a082ad5ab..d710e95ef1 100644\n--- a/frontend/taipy-gui/src/comp... | [
{
"diff_hunk": "@@ -68,6 +69,7 @@ const Slider = (props: SliderProps) => {\n \n const min = lovList.length ? 0 : props.min;\n const max = lovList.length ? lovList.length - 1 : props.max;\n+ const step = props.step === undefined ? 1 : props.step;",
"line": null,
"original_line": 72,
"origi... | dc25b803e60fb0dba0e15b5857f8d88633b1d278 | diff --git a/frontend/taipy-gui/src/components/Taipy/Slider.tsx b/frontend/taipy-gui/src/components/Taipy/Slider.tsx
index 4a082ad5ab..021da45171 100644
--- a/frontend/taipy-gui/src/components/Taipy/Slider.tsx
+++ b/frontend/taipy-gui/src/components/Taipy/Slider.tsx
@@ -30,6 +30,7 @@ interface SliderProps extends LovPr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Avaiga__taipy-664@ba936b4 | Avaiga/taipy | Python | 664 | Remove in memory state in the submission | Resolves #660
# Changes
## Core code
- Remove in-memory state in submission (`_is_abandoned`, `_is_completed`, `_is_canceled`, `_running_jobs`, `_blocked_jobs`, `_pending_jobs`) and save them to repository
- Added self setting Set class so job sets in submission can be self set
- Remove in-memory state for `_... | 2024-01-10T07:45:52Z | Remove a in-memory state
We have several places in core that relies on an in-memory state for entities. This is very error prone and a pain to maintain.
Some places that I'm awared of:
- **_submission.py_**
```
self.__abandoned = False
self.__completed = False
self.__is_canceled = False
self.__running_jobs: MutableSe... | [
{
"body": "We have several places in core that relies on an in-memory state for entities. This is very error prone and a pain to maintain. \n\nSome places that I'm awared of:\n- **_submission.py_**\n```\nself.__abandoned = False\nself.__completed = False\nself.__is_canceled = False\nself.__running_jobs: Mutable... | 56e30d5e0632db457b2c1e2332bdc49c41a51b41 | {
"head_commit": "ba936b40d7621a7481d4839f83f4646bc81073c6",
"head_commit_message": "fixed typing",
"patch_to_review": "diff --git a/MANIFEST.in b/MANIFEST.in\nindex fd021f2cbd..a5aafe110a 100644\n--- a/MANIFEST.in\n+++ b/MANIFEST.in\n@@ -12,3 +12,42 @@ include taipy/config/*.pyi\n include taipy/config/*.json\n r... | [
{
"diff_hunk": "@@ -12,3 +12,42 @@ include taipy/config/*.pyi\n include taipy/config/*.json\n recursive-include taipy/templates *\n include taipy/rest/*.json\n+include taipy/core/*.json\n+include taipy/core/config/*.json\n+include taipy/*.json\n+include taipy/gui_core/*.json\n+include taipy/gui_core/lib/*.js\n+... | d181cb3e2a0803558d8362b92774ef83c715db23 | diff --git a/taipy/core/_init.py b/taipy/core/_init.py
index b6dcb2988a..124fc3b123 100644
--- a/taipy/core/_init.py
+++ b/taipy/core/_init.py
@@ -42,11 +42,13 @@
get_entities_by_config_id,
get_jobs,
get_latest_job,
+ get_latest_submission,
get_parents,
get_primary,
get_primary_scenario... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
Avaiga__taipy-603@dd895af | Avaiga/taipy | Python | 603 | feature/#485 migrate job status update for scenario status to using submission entity | Resolves #485.
# Changes:
- Removed updating scenario status based on job
- Added updating scenario status using Submission entity status
- Removed unneeded code | 2023-12-13T08:29:16Z | Migrate Scenario Management elements to the Submission entity API
The code for Scenario Management elements handles the changes in submission statuses to be reflected in the UI (see `_get_submittable_status()`).
This should be sitting on the recently provided Submission entity API that Taipy Core exposes. | [
{
"body": "The code for Scenario Management elements handles the changes in submission statuses to be reflected in the UI (see `_get_submittable_status()`).\r\n\r\nThis should be sitting on the recently provided Submission entity API that Taipy Core exposes.\r\n",
"number": 485,
"title": "Migrate Scenar... | c554c9f85fa0bc436b28c1966914feafd2f49897 | {
"head_commit": "dd895af33997f72bd35c0ce375c4ca5846ebb0b2",
"head_commit_message": "migrate job status update for scenario status to using submission entity",
"patch_to_review": "diff --git a/taipy/gui_core/_context.py b/taipy/gui_core/_context.py\nindex 3bbdded0e8..5184c963f7 100644\n--- a/taipy/gui_core/_conte... | [
{
"diff_hunk": "@@ -165,50 +149,45 @@ def scenario_refresh(self, scenario_id: t.Optional[str]):\n {\"scenario\": scenario_id or True},\n )\n \n- def scenario_status_callback(self, job_id: str, is_submission: t.Optional[bool] = False):\n- if not job_id or not (is_submission or is_re... | fc78c046e833d8c483906bccf0c49f632e0ace61 | diff --git a/taipy/gui/extension/library.py b/taipy/gui/extension/library.py
index f1843e6964..c97116b652 100644
--- a/taipy/gui/extension/library.py
+++ b/taipy/gui/extension/library.py
@@ -39,7 +39,7 @@ class ElementProperty:
def __init__(
self,
- property_type: PropertyType,
+ property_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
Avaiga__taipy-655@a4130f2 | Avaiga/taipy | Python | 655 | feature/#490 submit() functions return a Submission object | Resolves #490.
# Changes
- Added custom properties parameters (**properties) to `tp.submit` so user can pass user information to the submission
- Added `properties` attribute to `Submission` to store user information on the submission
- **Change return type of `tp.submit` from `Job` or `List[Job` to `Submission... | 2024-01-08T08:53:14Z | Change submit APIs
The `submit` methods must evolve.
- [x] Accept custom properties parameters (!kwargs). The purpose is to pass some user information. The custom parameters should be stored within the Submission so the submitter can retrieve them.
- [x] Return the Submission object instead of the list of jobs. This i... | [
{
"body": "The `submit` methods must evolve.\n\n- [x] Accept custom properties parameters (!kwargs). The purpose is to pass some user information. The custom parameters should be stored within the Submission so the submitter can retrieve them.\n- [x] Return the Submission object instead of the list of jobs. Thi... | 970fb3bb8e824c1ef3e70fd5b245f493271323d7 | {
"head_commit": "a4130f2429b644fb8d859dc33dd8e427153be2cd",
"head_commit_message": "solved conflict",
"patch_to_review": "diff --git a/taipy/core/_entity/submittable.py b/taipy/core/_entity/submittable.py\nindex a7ee747a54..aa17f84ca7 100644\n--- a/taipy/core/_entity/submittable.py\n+++ b/taipy/core/_entity/subm... | [
{
"diff_hunk": "@@ -238,19 +241,23 @@ def submit(\n in asynchronous mode.\n timeout (Union[float, int]): The optional maximum number of seconds to wait\n for the jobs to be finished before returning.\n+ **properties (dict[str, any]): A keyworded variable length list of add... | 02be686e11fc5f6bd0edd17d61f4ae23f8a7dfee | diff --git a/taipy/core/_entity/submittable.py b/taipy/core/_entity/submittable.py
index a7ee747a54..aa17f84ca7 100644
--- a/taipy/core/_entity/submittable.py
+++ b/taipy/core/_entity/submittable.py
@@ -19,6 +19,7 @@
from ..common._utils import _Subscriber
from ..data.data_node import DataNode
from ..job.job import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
HypothesisWorks__hypothesis-4412@52b15d1 | HypothesisWorks/hypothesis | Python | 4,412 | conditionally import fields from django.contrib | Closes #3716 | 2025-05-25T16:26:55Z | hypothesis.extra.django.TestCase vs. Django INSTALLED_APPS
Hello, I'm trying out Hypothesis 6.82.2 on my Django 4.2 project.
Importing `hypothesis.extra.django.TestCase` fails with `"RuntimeError: Model class django.contrib.contenttypes.models.ContentType doesn't declare an explicit app_label and isn't in an applica... | @jams2 this might be relevant to your interests?
@Zac-HD certainly. I'm afk for 2 weeks, but can take a look if this is still open when I'm back. | [
{
"body": "Hello, I'm trying out Hypothesis 6.82.2 on my Django 4.2 project.\r\n\r\nImporting `hypothesis.extra.django.TestCase` fails with `\"RuntimeError: Model class django.contrib.contenttypes.models.ContentType doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.\"`\r\n\r\nT... | 2578b7059ee4f38e9e3cdd7c952563db95e6e587 | {
"head_commit": "52b15d14b97c09e123ea062fb75e2eea50ffa575",
"head_commit_message": "adjust release notes",
"patch_to_review": "diff --git a/hypothesis-python/RELEASE.rst b/hypothesis-python/RELEASE.rst\nnew file mode 100644\nindex 0000000000..b495be4f7c\n--- /dev/null\n+++ b/hypothesis-python/RELEASE.rst\n@@ -0,... | [
{
"diff_hunk": "@@ -166,25 +166,18 @@ commands =\n niche: bash scripts/other-tests.sh\n custom: python -bb -X dev -m pytest {posargs}\n \n-[testenv:django42]\n-setenv=\n- PYTHONWARNDEFAULTENCODING=1\n-commands =\n- pip install django==4.2.20\n- python -bb -X dev -m tests.django.manage test test... | 610709564512d6cfc2b1e96dd183ad784f90b5cb | diff --git a/hypothesis-python/RELEASE.rst b/hypothesis-python/RELEASE.rst
new file mode 100644
index 0000000000..b495be4f7c
--- /dev/null
+++ b/hypothesis-python/RELEASE.rst
@@ -0,0 +1,5 @@
+RELEASE_TYPE: patch
+
+This patch fixes an error when importing :ref:`our django extra <hypothesis-django>` (via ``hypothesis.ex... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Avaiga__taipy-613@34fb30c | Avaiga/taipy | Python | 613 | GUI - Frontend Decoupling | Resolves #446 .
Resolves #656. | 2023-12-15T06:20:05Z | SPIKE-Decouple the front-end from the Taipy GUI backend
**What would that feature address**
We want to allow for the use of other technologies for the front-end side of Taipy.
That requirement is mandatory if we plan to deliver a Page Builder application, hosted on the client, using some other technology that may not ... | [
{
"body": "**What would that feature address**\nWe want to allow for the use of other technologies for the front-end side of Taipy.\n\nThat requirement is mandatory if we plan to deliver a Page Builder application, hosted on the client, using some other technology that may not even be React or TypeScript.\n\n**... | f9a1d444d970f7efb0a2a3cf5e048b1c2b765565 | {
"head_commit": "34fb30cdcfda0555d6efe30867b1d9bc46574b5c",
"head_commit_message": "register payload before handle ws message",
"patch_to_review": "diff --git a/frontend/taipy-gui/dom/package-lock.json b/frontend/taipy-gui/dom/package-lock.json\nindex dac125b852..d9afc84b08 100644\n--- a/frontend/taipy-gui/dom/p... | [
{
"diff_hunk": "@@ -0,0 +1,82 @@\n+# Copyright 2023 Avaiga Private Limited\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with\n+# the License. You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-... | 726b46d3cad56a84a43345eaad0be5b4d9b9cf73 | diff --git a/frontend/taipy-gui/.gitignore b/frontend/taipy-gui/.gitignore
index 7c95102fad..2025a29762 100644
--- a/frontend/taipy-gui/.gitignore
+++ b/frontend/taipy-gui/.gitignore
@@ -30,3 +30,4 @@ yarn-error.log*
# types generation
/extension-types
+.env
diff --git a/frontend/taipy-gui/base/.gitignore b/fronten... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.