commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
ee50817ddbae4b3ef3f09bfd797f9b541b94c0be | Emilio Cobos Álvarez | 2022-05-31T08:33:50 | Bug 1770829 - Improve Percentage -> LengthPercentage conversion. r=barret
This doesn't change behavior because we only use them for images that
have no clamping.
Depends on D147008
Differential Revision: https://phabricator.services.mozilla.com/D147511 | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 8040f18fd..289140cba 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -721,12 +721,12 @@ impl Gradient {
if items.is_empty() {
items = vec![
generic::GradientI... | 3 | 17 | 7 |
e72e2746fd58a315b9dec5b9e27feebaacccdb9f | Emilio Cobos Álvarez | 2022-05-31T08:33:49 | Bug 1770616 - Do hue interpolations in degrees rather than radians. r=barret
This gives us a bit more precision.
Differential Revision: https://phabricator.services.mozilla.com/D147007 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index a7dba508f..c34bba939 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -9,7 +9,7 @@ use crate::values::distance::{ComputeSquaredDistance, SquaredDistance};
use crate::values::generics::color::{Color as ... | 1 | 21 | 26 |
0ee8e7a01636307cd2307873b534569a13f988f7 | Emilio Cobos Álvarez | 2022-05-31T08:33:48 | Bug 1770616 - Fix hue adjustment to match the spec. r=barret
The value to sum is tau, not pi. This was caught by some tests, see
https://drafts.csswg.org/css-color/#shorter
Differential Revision: https://phabricator.services.mozilla.com/D147006 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index d3ee616f7..a7dba508f 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -432,9 +432,9 @@ fn adjust_hue(left: &mut f32, right: &mut f32, hue_interpolation: HueInterpolati
let delta = *right - ... | 1 | 3 | 3 |
3a3076e23ac3217f6d81b9aa751de823a924d1f7 | Emilio Cobos Álvarez | 2022-05-31T08:33:48 | Bug 1770616 - Fix color-mix() percentage normalization. r=barret
Differential Revision: https://phabricator.services.mozilla.com/D147005 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index 8baa2497a..d3ee616f7 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -134,10 +134,22 @@ impl Color {
pub fn mix(
interpolation: &ColorInterpolationMethod,
left_color: &Color,
- ... | 1 | 21 | 4 |
64653ca0e341b6c1c7e1a3b99398f7dd259ff88b | Emilio Cobos Álvarez | 2022-05-31T08:33:48 | Bug 1770616 - Implement more color-mix() color-spaces. r=barret
We had code to convert between these and the latest draft supports them so...
Differential Revision: https://phabricator.services.mozilla.com/D147004 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index e6d161344..8baa2497a 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -9,6 +9,7 @@ use crate::values::distance::{ComputeSquaredDistance, SquaredDistance};
use crate::values::generics::color::{Color as ... | 2 | 299 | 162 |
d61b39c443e0b8d97da0ea6ff2a49471fcc3735d | Emilio Cobos Álvarez | 2022-05-31T08:33:47 | Bug 1770616 - Make the color interpolation code more generic. r=barret
It's really piece-wise premultiplied interpolation, with a special-case
for hue, so centralize the implementation.
Differential Revision: https://phabricator.services.mozilla.com/D147003 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index 00bcf63fc..e6d161344 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -15,6 +15,7 @@ use euclid::default::{Transform3D, Vector3D};
/// Unlike in computed values, each component value may exceed the
//... | 1 | 160 | 260 |
23c250a39704c7b309317db5c9612101e754d0b7 | Emilio Cobos Álvarez | 2022-05-31T08:33:47 | Bug 1770616 - Update color-mix() syntax to match the current spec. r=barret
Test expectation updates for this in the latest patch of the bug.
Differential Revision: https://phabricator.services.mozilla.com/D147002 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index f99e344a5..00bcf63fc 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -7,7 +7,7 @@
use crate::values::animated::{Animate, Procedure, ToAnimatedZero};
use crate::values::distance::{ComputeSquaredDistan... | 4 | 141 | 85 |
b950430134ac098e74fc81af5e7c7c8c4a5587b1 | criss | 2022-05-30T23:06:55 | Backed out changeset 68b233bf0519 (bug 1771792) for causing xpcshell failures on test_css-properties-db.js . CLOSED TREE | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 3fca5ec71..a2b0804bc 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1915,6 +1915,10 @@ pub enum Appearance {
MozMacSourceList,
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
... | 2 | 8 | 0 |
b5cd80ed7771afa704936818f2cf92edc4072ca2 | Emilio Cobos Álvarez | 2022-05-30T22:17:11 | Bug 1771792 - Remove some dead vibrancy code. r=mstange
Drive-by cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D147698 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index a2b0804bc..3fca5ec71 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1915,10 +1915,6 @@ pub enum Appearance {
MozMacSourceList,
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
... | 2 | 0 | 8 |
93df56d020301813f9f7fb74d00022a4fba8f304 | Cosmin Sabou | 2022-05-30T22:18:01 | Backed out 4 changesets (bug 1770894) for causing build bustages.
Backed out changeset d4bd20e7ac74 (bug 1770894)
Backed out changeset ae6ffff33128 (bug 1770894)
Backed out changeset 2e4f492a8222 (bug 1770894)
Backed out changeset 13111f4c114a (bug 1770894) | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 95a325c0b..fc3382929 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -24,7 +24,7 @@ cssparser = "0.29"
derive_more = "0.99"
fxhash = "0.2"
log = "0.4"
-phf = "0.10"
+phf = "0.8"
precomputed-hash = "0.1"
servo_arc = { version = "0.1", pa... | 1 | 2 | 2 |
dadc0b86cdbbca3f484a1302ee184a3661e6011e | Mike Hommey | 2022-05-30T21:37:31 | Bug 1770894 - Update in-tree crates to bindgen 0.59. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D147221 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 7ad4a427c..c02f2c039 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -81,7 +81,7 @@ gecko-profiler = { path = "../../../tools/profiler/rust-api" }
[build-dependencies]
lazy_static = "1"
log = { version = "0.4", features = ["std"] }
-bindgen = {version = ... | 1 | 1 | 1 |
63dc0957ffc2406194c1b9674e8e3af20f8ce042 | Emilio Cobos Álvarez | 2022-05-30T19:07:27 | Bug 1771764 - Remove 'static bound for ToShmem for Arc/ThinArc. r=dshin,layout-reviewers
It was only needed so that we could assert with TypeId::of::<T> that we
don't have duplicate values except for an exception.
Instead, fix the exception and remove the bound.
Differential Revision: https://phabricator.services.mo... | diff --git a/to_shmem/lib.rs b/to_shmem/lib.rs
index da35b3b0f..88b96442c 100644
--- a/to_shmem/lib.rs
+++ b/to_shmem/lib.rs
@@ -24,8 +24,6 @@ use smallbitvec::{InternalStorage, SmallBitVec};
use smallvec::{Array, SmallVec};
use std::alloc::Layout;
#[cfg(debug_assertions)]
-use std::any::TypeId;
-#[cfg(debug_asserti... | 1 | 8 | 31 |
4a7b7020ec7637df7cf68309f27b586e5a105b9a | Emilio Cobos Álvarez | 2022-05-30T11:08:15 | Bug 1381071 - Cache computed styles objects display: none subtrees. r=boris
This reuses our existing undisplayed style generation, but in a
per-document rather than per-nsComputedDOMStyle object, which means that
we can avoid re-resolving styles of elements in display: none subtrees
much more often.
This brings the t... | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 39f7d7cc8..cabae61d5 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -129,6 +129,12 @@ impl StylesheetInDocument for GeckoStyleSheet {
pub struct PerDocumentStyleDataImpl {
/// Rule processor.
pub stylist: Stylist,
+
+ /// A cache ... | 3 | 46 | 9 |
cfd16dc656c062cb6e47f73d0dd9ac91c6b4dc63 | Emilio Cobos Álvarez | 2022-05-30T11:06:06 | Bug 1771151 - Make modal dialog code more generic, and make it apply to fullscreen too behind a pref. r=edgar
For now, don't turn it on by default yet, because I want to wait for
more discussion in https://github.com/w3c/csswg-drafts/issues/6965 and
so on. But I think the code is simple enough to land this.
Different... | diff --git a/style/element_state.rs b/style/element_state.rs
index 28d505129..f8f4629ef 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -118,8 +118,8 @@ bitflags! {
const IN_MODAL_DIALOG_STATE = 1 << 42;
/// <https://html.spec.whatwg.org/multipage/#inert-subtrees>
const IN... | 3 | 4 | 4 |
1196871e0993f1de0f59b1ba57c4346167f413ea | Oriol Brufau | 2022-05-27T09:47:28 | Bug 1763828 - Change order of container shorthand. r=emilio
Since the initial value of container-type is an open issue [1],
I'm leaving that as-is for now.
[1] https://github.com/w3c/csswg-drafts/issues/7202
Differential Revision: https://phabricator.services.mozilla.com/D147338 | diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs
index 251636419..7db09a818 100644
--- a/style/properties/shorthands/box.mako.rs
+++ b/style/properties/shorthands/box.mako.rs
@@ -36,7 +36,7 @@ ${helpers.two_properties_shorthand(
<%helpers:shorthand
engines="gecko"
... | 1 | 9 | 9 |
bfd5dbd459043f7cd2c7723a2c0797dd47b09750 | Emilio Cobos Álvarez | 2022-05-23T07:21:43 | Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D146432 | diff --git a/style/properties/longhands/margin.mako.rs b/style/properties/longhands/margin.mako.rs
index 75d16a3cc..5c46cebdf 100644
--- a/style/properties/longhands/margin.mako.rs
+++ b/style/properties/longhands/margin.mako.rs
@@ -28,6 +28,16 @@
)}
% endfor
+${helpers.predefined_type(
+ "overflow-clip-marg... | 1 | 10 | 0 |
eb0ee1c0fb1e743115d04645c18dbebc60fb0fb5 | Emilio Cobos Álvarez | 2022-05-21T17:23:24 | Bug 1770532 - Ensure options in listbox selects are not stacking contexts by default. r=dholbert
We could have a different property or something but this seems
reasonable as well probably.
Differential Revision: https://phabricator.services.mozilla.com/D146994 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 82fc7f9a9..a2b0804bc 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1311,7 +1311,9 @@ impl Parse for WillChange {
&["will-change", "none", "all", "auto"],
)?;
- ... | 1 | 3 | 1 |
add4ff140d5f41d9a97ca646560d434a7f4fc786 | Cristian Tuns | 2022-05-20T18:46:22 | Backed out changeset c2e017726323 (bug 1769512) for causing multiple failures(wr and c1) CLOSED TREE | diff --git a/style/properties/longhands/margin.mako.rs b/style/properties/longhands/margin.mako.rs
index 5c46cebdf..75d16a3cc 100644
--- a/style/properties/longhands/margin.mako.rs
+++ b/style/properties/longhands/margin.mako.rs
@@ -28,16 +28,6 @@
)}
% endfor
-${helpers.predefined_type(
- "overflow-clip-marg... | 1 | 0 | 10 |
b8324b7f8189c883287df463eb6cf189793d110d | Emilio Cobos Álvarez | 2022-05-20T09:59:39 | Bug 1769612 - More container queries plumbing. r=boris
Provide container information in computed::Context and use it to resolve
the container queries.
This still fails a lot of tests because we are not ensuring that layout
is up-to-date when we style the container descendants, but that's
expected.
Differential Revis... | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index 3a55060cc..387dcdab0 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -42,13 +42,7 @@ pub struct CascadePriority {
layer_order: LayerOrder,
}
-#[allow(dead_code)]
-fn size_assert() {
- ... | 18 | 420 | 143 |
9897e3886683d8e7322455a1f01f4c40acc0c0f1 | Marian-Vasile Laza | 2022-05-20T02:20:30 | Backed out changeset 99ab9844b58a (bug 1769612) for causing web-platform failures on container-size-invalidation-after-load.html. | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index 387dcdab0..3a55060cc 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -42,7 +42,13 @@ pub struct CascadePriority {
layer_order: LayerOrder,
}
-const_assert_eq!(std::mem::size_of::<Cascad... | 18 | 143 | 420 |
8838cce7755c73da71e5b1e44c9d5f45751d8855 | Narcis Beleuzu | 2022-05-19T23:15:44 | Backed out changeset 8d386f8c684d (bug 1769612) for build bustages on applicable_declarations.rs | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index 387dcdab0..3a55060cc 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -42,7 +42,13 @@ pub struct CascadePriority {
layer_order: LayerOrder,
}
-const_assert_eq!(std::mem::size_of::<Cascad... | 17 | 142 | 420 |
c7a4def991b2589f1099777b30a37637f904a4eb | Emilio Cobos Álvarez | 2022-05-19T22:23:07 | Bug 1769612 - More container queries plumbing. r=boris
Provide container information in computed::Context and use it to resolve
the container queries.
This still fails a lot of tests because we are not ensuring that layout
is up-to-date when we style the container descendants, but that's
expected.
Differential Revis... | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index 3a55060cc..387dcdab0 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -42,13 +42,7 @@ pub struct CascadePriority {
layer_order: LayerOrder,
}
-#[allow(dead_code)]
-fn size_assert() {
- ... | 17 | 420 | 142 |
93a6d688b19688caf89e23c5316b726b2cb4b3ad | Emilio Cobos Álvarez | 2022-05-17T23:20:48 | Bug 1768285 - Clean up unused -moz-window-shadow values. r=jwatt
After bug 1768278 and bug 1767815 there's no more uses of the cliprounded value
in the tree (also it causes artifacts on HiDPI screens so we probably don't
want new usages).
The "sheet" value is unused, and the other values other than "default" and
"non... | diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs
index f28964f88..f081bd353 100644
--- a/style/properties/longhands/ui.mako.rs
+++ b/style/properties/longhands/ui.mako.rs
@@ -51,12 +51,15 @@ ${helpers.single_keyword(
spec="None (Nonstandard Firefox-only property)",
)}
+... | 1 | 4 | 1 |
44ebd8d0897f8ede7e57f693e893e30ccfc4fd1c | Autumn on Tape | 2022-05-14T13:46:41 | Bug 1422312 - implement 'update' media feature r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D146338 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 8b89ae3ce..1c84a7eba 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -284,6 +284,34 @@ fn eval_overflow_inline(context: &Context, query_value: Option<OverflowInline>)
}
}
+#[derive(Clone, Copy, Deb... | 1 | 35 | 1 |
207e7e8e2499d09bb0d259faeb4f99fd4bc5b8bc | Emilio Cobos Álvarez | 2022-05-11T19:42:32 | Bug 1768905 - Lint and 32-bit build fix.
MANUAL PUSH: Bustage fix CLOSED TREE | diff --git a/style/lib.rs b/style/lib.rs
index 1e53b8a49..83fc58475 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -64,6 +64,7 @@ pub use servo_arc;
#[cfg(feature = "servo")]
#[macro_use]
extern crate servo_atoms;
+#[cfg(target_pointer_width = "64")]
#[macro_use]
extern crate static_assertions;
#[macro_use] | 1 | 1 | 0 |
44b56df08c6e0371f749ffbdcea64fc7fd06f33c | Emilio Cobos Álvarez | 2022-05-11T19:02:58 | Bug 1768905 - Move size of tests to compile-time tests in the style crate. r=dshin
Same reasoning as the previous commit.
Differential Revision: https://phabricator.services.mozilla.com/D146104 | diff --git a/size_of_test/Cargo.toml b/size_of_test/Cargo.toml
deleted file mode 100644
index bb6c81824..000000000
--- a/size_of_test/Cargo.toml
+++ /dev/null
@@ -1,9 +0,0 @@
-[package]
-name = "size_of_test"
-version = "0.0.1"
-authors = ["The Servo Project Developers"]
-license = "MPL-2.0"
-publish = false
-
-[lib]
-... | 12 | 53 | 47 |
812a22c581e520a758b5a73070edbf183249add3 | Emilio Cobos Álvarez | 2022-05-11T19:02:57 | Bug 1768905 - Convert specified value tests to compile-time tests. r=dshin
These were written at a time where std::mem::size_of wasn't a `const fn` in
Rust.
Now that it is, we can make these tests live in the style crate, and the build
not to compile if they fail.
Differential Revision: https://phabricator.services.... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 7e8a285f4..7ad4a427c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -63,6 +63,7 @@ servo_atoms = {path = "../atoms", optional = true}
servo_config = {path = "../config", optional = true}
smallbitvec = "2.3.0"
smallvec = "1.0"
+static_assertions = "1.1"
... | 3 | 28 | 7 |
1d8fbc7d9b8e7e2ee4f55520cdc1b9a204ae7020 | Emilio Cobos Álvarez | 2022-05-07T04:02:26 | Bug 1767837 - Use debug_unreachable!() in matches_simple_selector. r=boris
This shrinks the function by avoiding generating rather noisy panic
code.
Depends on D145486
Differential Revision: https://phabricator.services.mozilla.com/D145487 | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index b5b8ebfa0..fc3382929 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -30,6 +30,7 @@ servo_arc = { version = "0.1", path = "../servo_arc" }
smallvec = "1.0"
to_shmem = { path = "../to_shmem" }
to_shmem_derive = { path = "../to_shmem_derive... | 3 | 6 | 1 |
b9421f6596e76ab40fa938d636da2b2b15b79090 | Emilio Cobos Álvarez | 2022-05-07T04:02:25 | Bug 1767837 - Reorder some variants. r=boris
This doesn't make a difference, I was hoping it would allow us to remove the
special-casey code we have here:
https://searchfox.org/mozilla-central/rev/997a56b018662e2940c99bbaf57a6ac9d1aa5422/servo/components/selectors/matching.rs#610-632
But it doesn't. Still I think ... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index d3b59580e..8948c794c 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -632,70 +632,13 @@ where
debug_assert!(context.shared.is_nested() || !context.shared.in_negation());
match *selector {
- Component::Combinator(_) => ... | 2 | 70 | 69 |
4ef6258cf8915efe2afd0410af099bef358f933c | Emilio Cobos Álvarez | 2022-05-06T23:52:23 | Bug 1767837 - Simplify a bit hot selector-matching loop. r=boris
Note that element.clone() is just copying a couple pointers.
Have a single place where we compute the next element and check for linky-ness.
This saves a couple checks (very very minor win in the micro-benchmark I've
been looking at, but consistent).
D... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 3ce895029..d3b59580e 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -488,19 +488,21 @@ where
Combinator::PseudoElement => SelectorMatchingResult::NotMatchedGlobally,
};
- let mut next_element =
- next_element_f... | 1 | 7 | 11 |
c0c882e20e0181fa2d50040ea8da6b9206534422 | Emilio Cobos Álvarez | 2022-05-06T23:52:23 | Bug 1767837 - Compute hover / active quirk state lazily. r=boris
This makes the inner function much smaller which improves selector-matching
performance very mildly for the benchmarks I've been looking at. Also, this
should help selector matching on quirks mode by only doing this when we
actually find :hover / :active... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index c4e3b75ca..3ce895029 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -61,7 +61,7 @@ impl ElementSelectorFlags {
/// Holds per-compound-selector data.
struct LocalMatchingContext<'a, 'b: 'a, Impl: SelectorImpl> {
shared: &'a mut Ma... | 1 | 22 | 35 |
1cbf84a4c97bd9d9d3414c666cba265823c0cc4b | David Shin | 2022-05-06T11:49:53 | Bug 1764126 - Part 1: Implement piecewise linear function. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D145256 | diff --git a/style/lib.rs b/style/lib.rs
index 843e8b151..45dcd7946 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -106,6 +106,7 @@ pub mod matching;
pub mod media_queries;
pub mod parallel;
pub mod parser;
+pub mod piecewise_linear;
#[macro_use]
pub mod queries;
pub mod rule_cache;
diff --git a/style/piecewise_... | 2 | 224 | 0 |
4f1904966164f49390dd733320c1c41950e64928 | Emilio Cobos Álvarez | 2022-05-06T11:56:26 | Bug 1767307 - Fix layer statement rules with multiple layer names.
MANUAL PUSH: Trivial orange fix CLOSED TREE. | diff --git a/style/stylist.rs b/style/stylist.rs
index 0d595a537..520663709 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -2783,9 +2783,9 @@ impl CascadeData {
CssRule::LayerStatement(ref lock) => {
let layer_rule = lock.read_with(guard);
for name in ... | 1 | 2 | 2 |
2dee321a33596d0c4355bc37200232922c4003f3 | Emilio Cobos Álvarez | 2022-05-06T10:30:01 | Bug 1767307 - Track @container condition id in style rules. r=boris
Much like we track layer rules. Consolidate that "containing rule state
we pass down while building the cascade data" in a single struct that we
can easily restore.
For now, do nothing with it. I want to land this patch separately
because it touches ... | diff --git a/style/stylesheets/layer_rule.rs b/style/stylesheets/layer_rule.rs
index 6a91f406f..c724fd81f 100644
--- a/style/stylesheets/layer_rule.rs
+++ b/style/stylesheets/layer_rule.rs
@@ -61,17 +61,6 @@ impl LayerOrder {
}
}
-/// The id of a given layer, a sequentially-increasing identifier.
-#[derive(Clon... | 2 | 135 | 54 |
85a11daa574a50fc73d182647f5c03e04a39dd08 | Emilio Cobos Álvarez | 2022-05-06T08:17:20 | Bug 1767625 - Simplify selector flags setup even more. r=boris
In my investigation for bug 1766439, I am digging into why selector
matching regressed.
It doesn't help that the selector-matching code is instantiated a
gazillion times (so there's a ton of copies of the relevant functions).
This was needed in the past ... | diff --git a/selectors/context.rs b/selectors/context.rs
index 9146b133e..f595389d2 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -68,6 +68,14 @@ impl VisitedHandlingMode {
}
}
+/// Whether we need to set selector invalidation flags on elements for this
+/// match request.
+#[derive(Clone, Cop... | 14 | 176 | 211 |
eb62ccff6c8e6fbea7e2206a41dc1a10e017b933 | Emilio Cobos Álvarez | 2022-05-05T16:18:17 | Bug 1768004 - Remove proton places tooltip code. r=dao
There's nobody working on it, and tooltips should hopefully be nice
enough after recent changes (bug 1765423).
Having it enabled causes artifacts like bug 1767815 comment 3. We can
always rescue this from hg history if needed.
Differential Revision: https://phab... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 7923576fc..8b89ae3ce 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -537,6 +537,7 @@ macro_rules! lnf_int_feature {
/// pref, with `rust: true`. The feature name needs to be defined in
/// `StaticAtoms.... | 1 | 2 | 5 |
86c26cd7d12e158a09927358f48d2d2d0db09da0 | Emilio Cobos Álvarez | 2022-05-03T15:50:13 | Bug 1469174 - Implement media feature expression multi-range syntax. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D145231 | diff --git a/style/queries/feature_expression.rs b/style/queries/feature_expression.rs
index bf6a8bf9c..3482fae13 100644
--- a/style/queries/feature_expression.rs
+++ b/style/queries/feature_expression.rs
@@ -47,7 +47,6 @@ impl FeatureType {
}
}
-
/// The kind of matching that should be performed on a feature ... | 1 | 214 | 90 |
42a830e38ec0788ef028ee8058aadfbebe532115 | Emilio Cobos Álvarez | 2022-05-03T12:39:10 | Bug 1759686 - Extend part 4 to resolve keyword sizes correctly, and reuse existing code to turning lengths into absolute pixels. r=jfkthame
I think it doesn't make sense to support em/percentages without
supporting smaller/bigger/other font-relative things.
I have many questions about how other units like viewport-un... | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index 010c371f9..bbf3c871c 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -4,6 +4,8 @@
//! Specified values for font properties
+use crate::context::QuirksMode;
+use crate::font_metrics::FontMetricsPro... | 1 | 29 | 15 |
bf1f5f8907f561d542615e569f22c94c06fbe546 | Emilio Cobos Álvarez | 2022-05-02T23:40:28 | Bug 1469174 - Refactor media feature expression representation in preparation to support multi-range syntax. r=boris
No behavior change.
Depends on D145229
Differential Revision: https://phabricator.services.mozilla.com/D145230 | diff --git a/style/queries/feature_expression.rs b/style/queries/feature_expression.rs
index d93d0cd32..bf6a8bf9c 100644
--- a/style/queries/feature_expression.rs
+++ b/style/queries/feature_expression.rs
@@ -50,7 +50,7 @@ impl FeatureType {
/// The kind of matching that should be performed on a feature value.
#[de... | 2 | 159 | 127 |
8621bbca73bfc8f52f1aea54d547325b713f513a | Emilio Cobos Álvarez | 2022-05-02T20:27:55 | Bug 1469174 - Factor out parsing the query feature name. r=boris
No behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D145229 | diff --git a/style/queries/feature_expression.rs b/style/queries/feature_expression.rs
index cfc2df413..d93d0cd32 100644
--- a/style/queries/feature_expression.rs
+++ b/style/queries/feature_expression.rs
@@ -303,12 +303,11 @@ impl QueryFeatureExpression {
input.parse_nested_block(|input| Self::parse_in_parent... | 1 | 13 | 5 |
b5095f9264c802226a745f406127e4906632a1fc | Emilio Cobos Álvarez | 2022-04-29T11:29:37 | Bug 1766889 - Fix insertRule with layer statements before imports. r=firefox-style-system-reviewers,layout-reviewers,boris
We need to do a bit more nuanced check because @layer statements might
go before imports.
Differential Revision: https://phabricator.services.mozilla.com/D144996 | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index c72f182eb..344fda5ef 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -385,16 +385,6 @@ impl CssRule {
}
}
- fn rule_state(&self) -> State {
- match *self {
- // CssRule::Charset(..) => Sta... | 3 | 58 | 31 |
373e437f3728078e6ba87dc149d34b51e8a19938 | Emilio Cobos Álvarez | 2022-04-27T15:30:54 | Bug 1766655 - Introduce Optional<T> to represent optional values in the style system. r=dshin
cross-fade() was kinda doing this in its own way with PercentOrNone, but
since now we have more use-cases for this we should probably make this a
slightly more general solution.
I added some convenience APIs, but they're unu... | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 980017b28..49145b0bf 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -47,8 +47,6 @@ pub type Gradient = generic::GenericGradient<
/// Computed values for CSS cross-fade
/// <https://drafts.csswg.org/... | 4 | 90 | 39 |
8ceac96b064e541a9d6f0cf07e0727e29d1c61fe | Emilio Cobos Álvarez | 2022-04-27T10:52:32 | Bug 1766020 - Add support for parsing container-query-specific features. r=firefox-style-system-reviewers,layout-reviewers,boris
There are some mediaqueries-5 features that we still don't support and
explain the remaining failures in at-container-{parsing,serialization}.
Differential Revision: https://phabricator.ser... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c2e24349d..7923576fc 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -7,6 +7,7 @@
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::queries::feature::{AllowsRanges, Eva... | 16 | 205 | 79 |
b5d6e87080cef669156f8e90c57881c5cdd87d38 | Narcis Beleuzu | 2022-04-27T09:34:31 | Backed out 1 changesets (bug 1766020) for bc failures on browser_modal_print.js . CLOSED TREE
Backed out changeset 10118450bd7f (bug 1766020) | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 7923576fc..c2e24349d 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -7,7 +7,6 @@
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::queries::feature::{AllowsRanges, Eva... | 10 | 63 | 188 |
1aaaf8f4f1ce08039bb2ea610bca655eb25a33e9 | Emilio Cobos Álvarez | 2022-04-27T07:32:07 | Bug 1766020 - Add support for parsing container-query-specific features. r=firefox-style-system-reviewers,layout-reviewers,boris
There are some mediaqueries-5 features that we still don't support and
explain the remaining failures in at-container-{parsing,serialization}.
Differential Revision: https://phabricator.ser... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c2e24349d..7923576fc 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -7,6 +7,7 @@
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::queries::feature::{AllowsRanges, Eva... | 10 | 188 | 63 |
17a0202519d811cd13951af345189fe9042ab282 | Emilio Cobos Álvarez | 2022-04-25T08:23:51 | Bug 1766046 - cleanup animation-name. r=boris
Make the representation the same between Gecko and Servo code. This will
enable further clean-ups in the future.
Make serialization be correct, serializing as identifier unless it's an
invalid one (in which case we serialize as a string).
This changes our stringification... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8b95449dd..0edfbf844 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1924,10 +1924,7 @@ mask-mode mask-repeat mask-clip mask-origin mask-composite mask-position-x mask-
self.gecko.mAnimatio... | 4 | 129 | 97 |
47ab4ac913ae5e7b3ded3fb30aace4203eb5f67a | Butkovits Atila | 2022-04-25T08:06:51 | Backed out changeset dfec425c53fe (bug 1766046) for causing wpt failures at animation-timeline-computed.html. CLOSED TREE | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0edfbf844..8b95449dd 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1924,7 +1924,10 @@ mask-mode mask-repeat mask-clip mask-origin mask-composite mask-position-x mask-
self.gecko.mAnimatio... | 4 | 92 | 71 |
e162b726c33083d0a5e1ddff37f7a3ad43059974 | Emilio Cobos Álvarez | 2022-04-24T21:48:02 | Bug 1765999 - Move some of the media query code to a more generic queries module. r=hiro
No behavior change, just moving and renaming files.
The code in the "queries" module will be shared between @media and
@container.
@media has some other code that container queries doesn't need like
MediaList / MediaType / etc. ... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 9789d9646..c2e24349d 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -6,8 +6,7 @@
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
-use crate::media_queries::media_feature::{All... | 10 | 127 | 118 |
f18a750c416331c804c4ee84ff69e4b8a3183d8f | Emilio Cobos Álvarez | 2022-04-24T21:47:31 | Bug 1766046 - cleanup animation-name. r=boris
Make the representation the same between Gecko and Servo code. This will
enable further clean-ups in the future.
Make serialization be correct, serializing as identifier unless it's an
invalid one (in which case we serialize as a string).
This changes our stringification... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8b95449dd..0edfbf844 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1924,10 +1924,7 @@ mask-mode mask-repeat mask-clip mask-origin mask-composite mask-position-x mask-
self.gecko.mAnimatio... | 4 | 71 | 92 |
6624102f601cfc80a6ef5e32a27a5cea3577b39b | Emilio Cobos Álvarez | 2022-04-21T17:23:38 | Bug 1765746 - Tweak contain bitflag definition order to avoid static constructors. r=dshin
This has no behavior change otherwise. The STRICT definition depended on
SIZE, which was defined later. That's fine in Rust, but in C++ it causes
the initialization to be dynamic because it doesn't have the definition
of SIZE ye... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 5eb86a51f..113498bf3 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1372,12 +1372,12 @@ bitflags! {
const LAYOUT = 1 << 2;
/// `paint` variant, turns on paint containment
const... | 1 | 4 | 4 |
1c622b9c7e0df9a8d8e3577c93fafa5cc2702202 | Boris Chiou | 2022-04-21T17:05:17 | Bug 1737918 - Part 1: Add scroll() to animation-timeline for style system. r=emilio
scroll() is defined in the spec proposal, and there is a temporary spec:
https://drafts.csswg.org/scroll-animations-1/rewrite#scroll-notation.
The spec is still under development, so we don't drop the orignal
scroll-timeline at rule. ... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 61d2ce16c..5eb86a51f 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -752,6 +752,80 @@ impl Parse for AnimationName {
}
}
+/// A value for the <Scroller> used in scroll().
+///
+/// https://drafts.... | 1 | 91 | 0 |
9ee54cd5fa07c2962d217609a176406cbeb6d655 | Noemi Erli | 2022-04-20T22:21:14 | Backed out 4 changesets (bug 1737918) for causing bustages in ScrollTimeline.cpp CLOSED TREE
Backed out changeset cecdd071c1aa (bug 1737918)
Backed out changeset fcc5ecd364e4 (bug 1737918)
Backed out changeset f7bf3143e4a7 (bug 1737918)
Backed out changeset a143d2e54fb9 (bug 1737918) | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 5eb86a51f..61d2ce16c 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -752,80 +752,6 @@ impl Parse for AnimationName {
}
}
-/// A value for the <Scroller> used in scroll().
-///
-/// https://drafts.... | 1 | 0 | 91 |
e09495af9fe61d8cc99637a2cc706ea2835449dd | Noemi Erli | 2022-04-20T19:25:02 | Backed out changeset 7985a1fa0789 (bug 1764768) for causing multiple failures CLOSED TREE | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 927994d36..97064e483 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -20,6 +20,7 @@ use crate::values::specified::calc::{self, CalcNode};
use crate::values::specified::NonNegativeNumber;
use ... | 1 | 8 | 2 |
c2c2fe915012194589998c7d7ea8ade9a6348527 | Emilio Cobos Álvarez | 2022-04-20T17:22:36 | Bug 1764768 - Don't truncate viewport units at computed value time. r=dholbert
Instead, make the behavior consistent across all <length-percentage>
values (by truncating instead of rounding). This is the already-existing
behavior for calc() and percentages, but with this patch we also apply
it to plain length-flavored... | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 97064e483..927994d36 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -20,7 +20,6 @@ use crate::values::specified::calc::{self, CalcNode};
use crate::values::specified::NonNegativeNumber;
use ... | 1 | 2 | 8 |
955449fea40cade5e2e491732e1d912df5d81105 | Emilio Cobos Álvarez | 2022-04-20T15:30:02 | Bug 1765489 - Make media feature evaluation take a computed::Context. r=dshin
This has no behavior change right now, but will simplify sharing code
with container queries.
Container queries will have container information in the
computed::Context (this is necessary anyways for container-based units),
so this avoids h... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 57c41c95e..9789d9646 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -9,9 +9,7 @@ use crate::gecko_bindings::structs;
use crate::media_queries::media_feature::{AllowsRanges, ParsingRequirements};
use cra... | 6 | 119 | 125 |
b59c80a295fa81fc671aa2b142eec11a06a7630b | Emilio Cobos Álvarez | 2022-04-20T09:01:25 | Bug 1765401 - Simplify media query evaluation code a bit. r=boris
This patch:
* Removes generic <ident> support for media features. These were used
for some privileged media features but are no longer used.
* Simplifies media feature getters by shifting the responsibility of
dealing with RangeOrOperator to t... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c284fbd86..57c41c95e 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -8,7 +8,6 @@ use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::media_queries::media_feature::{Allows... | 3 | 89 | 230 |
9f1d7611e7b6ae7dee2a0630a9136e38e2489aca | Butkovits Atila | 2022-04-20T06:53:50 | Backed out changeset 3d29e3e5525b (bug 1765401) for causing reftest failures at mediaqueries. CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 57c41c95e..c284fbd86 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -8,6 +8,7 @@ use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::media_queries::media_feature::{Allows... | 3 | 230 | 85 |
937cc9fc4af36a1f904414829cd4a8b658dda9a4 | Emilio Cobos Álvarez | 2022-04-20T05:50:46 | Bug 1765401 - Simplify media query evaluation code a bit. r=firefox-style-system-reviewers,layout-reviewers,boris
This patch:
* Removes generic <ident> support for media features. These were used
for some privileged media features but are no longer used.
* Simplifies media feature getters by shifting the respon... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c284fbd86..57c41c95e 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -8,7 +8,6 @@ use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::media_queries::media_feature::{Allows... | 3 | 85 | 230 |
4f6f7dfe23270ab47a87c009e2026e21efe410ce | David Shin | 2022-04-19T17:44:16 | Bug 1755565 - Implement `contain: inline-size`. r=emilio,dholbert
Differential Revision: https://phabricator.services.mozilla.com/D143501 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 04735ecbf..61d2ce16c 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1267,22 +1267,26 @@ impl TouchAction {
bitflags! {
#[derive(MallocSizeOf, Parse, SpecifiedValueInfo, ToComputedValue, ToCss, To... | 1 | 12 | 8 |
5e9f3023c26a350b31dc69d10aadad6bc2c9fbf1 | Emilio Cobos Álvarez | 2022-04-19T08:39:29 | Bug 1764768 - Don't go through app-units-ratio to convert absolute lengths. r=dholbert
This doesn't change behavior on its own, but the current code introduces
some minor floating point error which we can avoid, and which would
cause failures with the other patch on the bug.
Differential Revision: https://phabricator... | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index 2a682fa8b..010c371f9 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -15,7 +15,7 @@ use crate::values::generics::font::{
self as generics, FeatureTagValue, FontSettings, FontTag, GenericFontSizeAd... | 2 | 21 | 22 |
db984ae17f8cf90cf09cf2974f50850940358587 | Emilio Cobos Álvarez | 2022-04-18T00:58:19 | Bug 1765006 - Clean-up viewport unit resolution a bit. r=hiro
I should've caught this when reviewing the new viewport units but alas :-)
Differential Revision: https://phabricator.services.mozilla.com/D143856 | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 98113587b..129faabcb 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -314,6 +314,7 @@ pub enum ViewportVariant {
}
/// https://drafts.csswg.org/css-values/#viewport-relative-units
+#[derive... | 1 | 10 | 31 |
0e2845cb74ea7962b03d08911182cb99a646c915 | Emilio Cobos Álvarez | 2022-04-13T23:11:44 | Bug 1764217 - Fix visited handling after bug 1763750. r=hiro
Before bug 1763750, we unconditionally called compute_writing_mode,
which got the writing mode from the cascade mode for visited styles.
However after that bug we only do that if we apply any
writing-mode-related property.
We could just call compute_writin... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index c8780087c..5683ceddc 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -303,55 +303,68 @@ where
rule_cache_conditions: RefCell::new(rule_cache_conditions),
};
- let using_cached_reset_properties =... | 2 | 96 | 96 |
323358341817e3879e6983eb7b47f074dde890cb | Nika Layzell | 2022-04-12T20:22:24 | Bug 1713773 - Part 2: Join servo style threads during shutdown, r=emilio
I was unable to change the BLOOM_KEY field to no longer be leaked, as the TLS
is also accessed on the main thread, which is not exited before the leak
checker shuts down.
Differential Revision: https://phabricator.services.mozilla.com/D143529 | diff --git a/style/global_style_data.rs b/style/global_style_data.rs
index c0708f58b..c5df80608 100644
--- a/style/global_style_data.rs
+++ b/style/global_style_data.rs
@@ -11,10 +11,11 @@ use crate::parallel::STYLE_THREAD_STACK_SIZE_KB;
use crate::shared_lock::SharedRwLock;
use crate::thread_state;
use gecko_profil... | 1 | 35 | 22 |
c1673c297e2d49fd4bd3d974a7ea14dd86027a40 | Emilio Cobos Álvarez | 2022-04-12T09:07:18 | Bug 1656363 - Implement prefers-contrast: custom and let prefers-contrast ride the trains. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D143198 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c873ac92b..c284fbd86 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -315,11 +315,12 @@ fn eval_prefers_reduced_motion(device: &Device, query_value: Option<PrefersReduc
#[derive(Clone, Copy, Debug, FromPr... | 1 | 3 | 2 |
b9355e126fdc7342ee335d61a20bbcf868778614 | Hiroyuki Ikezoe | 2022-04-12T04:06:38 | Bug 1610815 - Implement new *vi and *vb units. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D143253 | diff --git a/style/values/generics/calc.rs b/style/values/generics/calc.rs
index 859a0f4d8..5d52cdf5f 100644
--- a/style/values/generics/calc.rs
+++ b/style/values/generics/calc.rs
@@ -45,25 +45,33 @@ pub enum SortKey {
Cap,
Ch,
Deg,
+ Dvb,
Dvh,
+ Dvi,
Dvmax,
Dvmin,
Dvw,
Em... | 3 | 164 | 2 |
5cc804a8b78c907c29e108d6aa858c9a84a244ed | Hiroyuki Ikezoe | 2022-04-12T04:06:38 | Bug 1610815 - Implement new {small,large,dynamic} viewport units. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D143252 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 14fe9e5e0..810dc8933 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -15,6 +15,7 @@ use crate::string_cache::Atom;
use crate::values::computed::{ColorScheme, Length};
use crate::values::specified::color::Sys... | 7 | 327 | 33 |
0959cca5fd72314457dfa1a768878e1a1a02cefe | Emilio Cobos Álvarez | 2022-04-08T15:55:11 | Bug 1763750 - Tweak cascade priority to split writing-mode and font properties. r=hiro
This makes the worst case for cascade performance slightly more
expensive (4 rather than three declaration walks), but my hope is that
it will make the average case faster, since the best case is now just
two walks instead of three,... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index c11214df6..c8780087c 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -29,34 +29,8 @@ use smallvec::SmallVec;
use std::borrow::Cow;
use std::cell::RefCell;
-/// We split the cascade in two phases: 'early' prope... | 2 | 126 | 121 |
e3a69d8cbafed30e77367f78acae6164be4ee4df | Emilio Cobos Álvarez | 2022-04-08T04:15:40 | Bug 1763644 - Add basic @container rule parsing and boilerplate. r=firefox-style-system-reviewers,layout-reviewers,boris
For now parse a MediaFeatureCondition. That needs being made more
specific, but that is probably worth its own patch.
Differential Revision: https://phabricator.services.mozilla.com/D143192 | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 4fb08c3a3..893812ea7 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -15,7 +15,7 @@ use crate::gecko_bindings::structs::{
RawServoKeyframesRule, RawServoLayerBlockRule, RawServoLayerStatementRule, RawServoMediaList,
... | 10 | 134 | 6 |
77e031f80a8b44e80b5b4b9b00b15c8d48d4ccca | Butkovits Atila | 2022-04-08T04:01:01 | Backed out 2 changesets (bug 1763644, bug 1762474)for causing failures at idlharness.html. CLOSED TREE
Backed out changeset 6c5ac0c99219 (bug 1762474)
Backed out changeset 8b625593255f (bug 1763644) | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 893812ea7..4fb08c3a3 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -15,7 +15,7 @@ use crate::gecko_bindings::structs::{
RawServoKeyframesRule, RawServoLayerBlockRule, RawServoLayerStatementRule, RawServoMediaList,
... | 10 | 6 | 134 |
3d6c96409ae04c937d88b3e29e39eab139c19390 | Butkovits Atila | 2022-04-07T23:26:22 | Backed out 2 changesets (bug 1763644, bug 1762474) for causing failures at test_interfaces.html. CLOSED TREE
Backed out changeset 6a588f6d08f7 (bug 1762474)
Backed out changeset ff486de30883 (bug 1763644) | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 893812ea7..4fb08c3a3 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -15,7 +15,7 @@ use crate::gecko_bindings::structs::{
RawServoKeyframesRule, RawServoLayerBlockRule, RawServoLayerStatementRule, RawServoMediaList,
... | 10 | 6 | 134 |
6f1225c75824b6ce47a3d30983e403a96912df65 | Emilio Cobos Álvarez | 2022-04-04T18:22:04 | Bug 1762298 - Inherit used color-scheme from embedder <browser> elements. r=nika,dao,Gijs
This allows popups and sidebars to use the chrome preferred
color-scheme.
This moves the responsibility of setting the content-preferred color
scheme to the appropriate browsers to the front-end (via tabs.css).
We still return ... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 5e5ec217b..5de22993c 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -64,6 +64,20 @@ fn get_safearea_inset_right(device: &Device) -> VariableValue {
VariableValue::pixels(device.safe_area_insets().right)
}
+fn... | 1 | 21 | 1 |
2c3309d5fb75774c2f792642fdbbe5e2e5789b8f | Emilio Cobos Álvarez | 2022-04-04T14:23:23 | Bug 1762796 - Deduplicate TokenList values faster. r=smaug
Remember whether we have already de-duplicated them once and avoid doing
that again.
This is an alternative approach that doesn't add overhead to attribute
setting in the general case.
Differential Revision: https://phabricator.services.mozilla.com/D142813 | diff --git a/style/gecko/snapshot_helpers.rs b/style/gecko/snapshot_helpers.rs
index 3cb325bb6..d75cd2753 100644
--- a/style/gecko/snapshot_helpers.rs
+++ b/style/gecko/snapshot_helpers.rs
@@ -44,14 +44,14 @@ unsafe fn get_class_or_part_from_attr(attr: &structs::nsAttrValue) -> Class {
structs::nsAttrValue... | 1 | 2 | 2 |
75123b5d31a880b32087c6029599aefc70b41f11 | David Shin | 2022-04-01T22:57:05 | Bug 1759621 - Migrate `<th>` `text-align` behaviour from presentation hint to UA CSS. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D142494 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9ac1f6d1f..47664b1c5 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1723,23 +1723,9 @@ impl<'le> TElement for GeckoElement<'le> {
use crate::properties::longhands::_x_lang::SpecifiedValue as SpecifiedLang;
use cra... | 2 | 14 | 21 |
f23e00ecd0d28fafa3bbcf286529435ea52496fd | Molnar Sandor | 2022-04-01T21:18:00 | Backed out changeset caf3fd368a8e (bug 1759621) for causing xpc failures in /test_css-properties-db.js CLOSED TREE | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 47664b1c5..9ac1f6d1f 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1723,9 +1723,23 @@ impl<'le> TElement for GeckoElement<'le> {
use crate::properties::longhands::_x_lang::SpecifiedValue as SpecifiedLang;
use cra... | 2 | 21 | 14 |
bd755cf37ee862692f92e249c27cb9e3a8d50604 | Emilio Cobos Álvarez | 2022-04-01T00:26:16 | Bug 1762088 - Remove assert that doesn't hold for text-decorations because of presentation hints.
MANUAL PUSH: Orange fix CLOSED TREE | diff --git a/style_derive/to_css.rs b/style_derive/to_css.rs
index 89659d385..e0f66da37 100644
--- a/style_derive/to_css.rs
+++ b/style_derive/to_css.rs
@@ -57,7 +57,6 @@ fn derive_bitflags(input: &syn::DeriveInput, bitflags: &CssBitflagAttrs) -> Toke
}
body.append_all(quote! {
- debug_assert!(has_an... | 1 | 0 | 1 |
d94c9d20b15c61c05d908af5640c097a17e36d4f | Emilio Cobos Álvarez | 2022-03-31T22:05:02 | Bug 1762088 - Allow to derive Parse/ToCss/SpecifiedValueInfo on bitflags. r=firefox-style-system-reviewers,layout-reviewers,boris
We keep getting this pattern of properties that have a set of joint and
disjoint flags, and copy-pasting or writing the same parsing and
serialization code in slightly different ways.
cont... | diff --git a/derive_common/cg.rs b/derive_common/cg.rs
index b4ac5bb47..2c5268839 100644
--- a/derive_common/cg.rs
+++ b/derive_common/cg.rs
@@ -373,6 +373,11 @@ pub fn to_css_identifier(mut camel_case: &str) -> String {
result
}
+/// Transforms foo-bar to FOO_BAR.
+pub fn to_scream_case(css_case: &str) -> Stri... | 8 | 222 | 311 |
d51217b0883272b73ea8830b50acc821dc391cca | Hiroyuki Ikezoe | 2022-03-27T23:40:24 | Bug 1760222 - Ignore unchanged property for scroll-linked effect detector. r=hiro
I think this is cleaner.
Differential Revision: https://phabricator.services.mozilla.com/D141737 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 51c3d6c73..57e60c188 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -474,9 +474,10 @@ impl NonCustomPropertyId {
self.0
}
+ /// Convert a `NonCustomPropertyId` i... | 1 | 2 | 1 |
c7cead68e75b8f384cc904403bfb001b06080f0c | Emilio Cobos Álvarez | 2022-03-25T18:15:43 | Bug 1666059 - Really honor background-color: transparent in HCM even for form controls. r=morgan
I forgot we were doing this "revert-or-initial" shenanigans (which is needed
for stuff like link colors to be honored), so we need to early-return.
Use a more explicit test rather than a reftest for this.
Differential Re... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 964f513a6..c11214df6 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -435,14 +435,17 @@ fn tweak_when_ignoring_colors(
// otherwise, this is needed to preserve semi-transparent
// backgro... | 1 | 9 | 6 |
9b1e54f9123d01ca42181709455779cb8c8e887c | Emilio Cobos Álvarez | 2022-03-25T14:59:00 | Bug 1760579 - layout.css.moz-locale-dir.content.enabled. r=dholbert
We successfully removed these from content in bug 1740230 (Firefox 96).
Differential Revision: https://phabricator.services.mozilla.com/D141727 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 8a3224938..336df5013 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -139,9 +139,6 @@ impl NonTSPseudoClass {
/// Returns whether the pseudo-class is enabled in content sheets.
#[inline]
... | 1 | 0 | 3 |
32b5c1d7ebfbceb58a39bd30c277ba2dfbe3764d | Emilio Cobos Álvarez | 2022-03-25T14:58:59 | Bug 1760342 - Remove :-moz-lwtheme-{brighttext,darktext}. r=dao,Gijs
They are just convenience for :root[lwthemetextcolor="light"] (and dark,
respectively), but they generally shouldn't be used for dark mode
theming. In the past it was the only way to do it but now we have
prefers-color-scheme.
While at it, change lw... | diff --git a/style/element_state.rs b/style/element_state.rs
index 30c65dc9f..28d505129 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -148,9 +148,5 @@ bitflags! {
const LTR_LOCALE = 1 << 2;
/// LWTheme status
const LWTHEME = 1 << 3;
- /// LWTheme status
- c... | 4 | 6 | 24 |
940fc70a2f15450fe8fe48aec7fd65e05132a0ea | Brad Werth | 2022-03-24T18:19:49 | Bug 1751217 Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio
This is a stub that only matches "standard" for all platforms.
Differential Revision: https://phabricator.services.mozilla.com/D141053 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index af57be431..c873ac92b 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -283,6 +283,18 @@ pub enum PrefersColorScheme {
Dark,
}
+/// Values for the dynamic-range and video-dynamic-range media features... | 1 | 44 | 1 |
8b86f06cc49294777960533099661b1917e0f278 | Emilio Cobos Álvarez | 2022-03-24T15:09:47 | Bug 1680285 - Simplify selector flag setting now that flag setting is atomic. r=nika,decoder
These bits are write-only, actually, and we don't even need to read
them.
Differential Revision: https://phabricator.services.mozilla.com/D141888 | diff --git a/style/context.rs b/style/context.rs
index b4e574b24..56ce1a979 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -28,8 +28,8 @@ use crate::traversal_flags::TraversalFlags;
use app_units::Au;
use euclid::default::Size2D;
use euclid::Scale;
+#[cfg(feature = "servo")]
use fxhash::FxHashMap;
-use sel... | 8 | 30 | 176 |
6187cf037263940c0f5269ef2092f7cd17945e02 | Emilio Cobos Álvarez | 2022-03-24T10:13:13 | Bug 1758223 - Remove some no longer used use statements.
MANUAL PUSH: Bustage fix CLOSED TREE | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 205d43396..50b461876 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -41,7 +41,6 @@ use crate::gecko_bindings::bindings::Gecko_IsSignificantChild;
use crate::gecko_bindings::bindings::Gecko_MatchLang;
use crate::gecko_bindings::bin... | 1 | 0 | 1 |
d7ec24e9d36fb1c46ee168dfb9b89338eb951a97 | Emilio Cobos Álvarez | 2022-03-24T10:03:12 | Bug 1758223 - Use atomic ops to read / write node flags from stylo. r=nika
The flags stylo cares about reading and writing potentially at the same
time are disjoint, so there's no need for any strong memory ordering.
Differential Revision: https://phabricator.services.mozilla.com/D141829 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index add9a2ac4..205d43396 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -80,6 +80,7 @@ use selectors::matching::{ElementSelectorFlags, MatchingContext};
use selectors::sink::Push;
use selectors::{Element, OpaqueElement};
use servo_ar... | 1 | 24 | 7 |
3797bd6dae701814d4319be62955edf462922f79 | Cristian Tuns | 2022-03-24T06:36:42 | Backed out 4 changesets (bug 1760222) for causing reftest failures on disable-apz-for-sle-pages.html CLOSED TREE
Backed out changeset 1bf5e1ca3746 (bug 1760222)
Backed out changeset aff6bf37365d (bug 1760222)
Backed out changeset e9b3e3f52aec (bug 1760222)
Backed out changeset f65d2d719277 (bug 1760222) | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 57e60c188..51c3d6c73 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -474,10 +474,9 @@ impl NonCustomPropertyId {
self.0
}
- /// Convert a `NonCustomPropertyId` i... | 1 | 1 | 2 |
78f0c45fe3991641fdc1d25f0712cdfff2d180cb | Butkovits Atila | 2022-03-24T04:31:29 | Backed out changeset 8a3be63619de (bug 1758223) for causing bustages. CLOSED TREE | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 205d43396..add9a2ac4 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -80,7 +80,6 @@ use selectors::matching::{ElementSelectorFlags, MatchingContext};
use selectors::sink::Push;
use selectors::{Element, OpaqueElement};
use servo_ar... | 1 | 7 | 24 |
2d98bd8c03cead7ed90df5369d40146860708d77 | Butkovits Atila | 2022-03-23T20:22:54 | Backed out 5 changesets (bug 1751217) for causing failures at dynamic-range.html. CLOSED TREE
Backed out changeset f0a4879c9709 (bug 1751217)
Backed out changeset 50b6310935d4 (bug 1751217)
Backed out changeset bfa455b8bb1a (bug 1751217)
Backed out changeset 277064a1facb (bug 1751217)
Backed out changeset 21e1650b12db... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 2d8a415e9..af57be431 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -283,18 +283,6 @@ pub enum PrefersColorScheme {
Dark,
}
-/// Values for the dynamic-range and video-dynamic-range media features... | 1 | 1 | 44 |
0f4b5caba9f9904aa1debbc39ce8922fa9508236 | Brad Werth | 2022-03-23T18:23:00 | Bug 1751217 Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio
This is a stub that only matches "standard" for all platforms.
Differential Revision: https://phabricator.services.mozilla.com/D141053 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index af57be431..2d8a415e9 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -283,6 +283,18 @@ pub enum PrefersColorScheme {
Dark,
}
+/// Values for the dynamic-range and video-dynamic-range media features... | 1 | 44 | 1 |
7b3018cdfc9e549d69d52029edee0c75e2ded460 | Marian-Vasile Laza | 2022-03-23T17:11:53 | Backed out 5 changesets (bug 1751217) for causing wpt(Screen-pixelDepth-Screen-colorDepth001.html) and mochitest(test_media_queries.html) failures. CLOSED TREE
Backed out changeset 60a4497fd1f5 (bug 1751217)
Backed out changeset 785f4c5f719d (bug 1751217)
Backed out changeset 81e41f7a1ee4 (bug 1751217)
Backed out chan... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 2d8a415e9..af57be431 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -283,18 +283,6 @@ pub enum PrefersColorScheme {
Dark,
}
-/// Values for the dynamic-range and video-dynamic-range media features... | 1 | 1 | 44 |
1778e3b23cfe8678a3c699ddb4e25a22933c0c5c | Emilio Cobos Álvarez | 2022-03-23T08:41:51 | Bug 1760734 - Put overflow: -moz-hidden-unscrollable behind a pref on Nightly. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D141759 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 6b3c6c253..cc8f81916 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -2067,7 +2067,6 @@ impl BreakWithin {
Eq,
Hash,
MallocSizeOf,
- Parse,
PartialEq,
SpecifiedValueInfo,
T... | 1 | 19 | 2 |
9c95735027140521484a7e15c38ad325e4c40045 | Emilio Cobos Álvarez | 2022-03-21T22:36:13 | Bug 1666059 - Honor background-color: transparent in forced colors mode. r=morgan
See comment as for why, and linked bugs, in particular:
https://bugzilla.mozilla.org/show_bug.cgi?id=1755713#c16
And the following screenshot for example.
Differential Revision: https://phabricator.services.mozilla.com/D141514 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 6f01f5478..964f513a6 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -435,17 +435,18 @@ fn tweak_when_ignoring_colors(
// otherwise, this is needed to preserve semi-transparent
// backgro... | 1 | 11 | 10 |
d4834ace35a4860d80257de85f2389586807da9c | Cristian Tuns | 2022-03-21T20:18:59 | Backed out changeset 1b1df0fb2320 (bug 1666059) for causing mochitest failures in test_dont_use_document_colors.html CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 964f513a6..6f01f5478 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -435,18 +435,17 @@ fn tweak_when_ignoring_colors(
// otherwise, this is needed to preserve semi-transparent
// backgro... | 1 | 10 | 11 |
c87ee544283cc3374946c242d53ba2e773ad7af2 | Emilio Cobos Álvarez | 2022-03-11T18:12:56 | Bug 1758974 - Reuse inherited custom properties if they didn't change after resolution. r=jwatt
This should be cheap and gives us a lot of memory savings for the page
on the bug, by deduplicating the inherited properties between parent and
children.
WebKit implements a similar optimization.
Differential Revision: ht... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index a025f1a1f..5e5ec217b 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -714,6 +714,22 @@ impl<'a> CustomPropertiesBuilder<'a> {
true
}
+ fn inherited_properties_match(&self, map: &CustomPropertiesMap)... | 1 | 26 | 0 |
2b38afcddb238be8612e5ba6b9f6986ec7ab06f4 | Emilio Cobos Álvarez | 2022-03-11T18:12:55 | Bug 1758974 - Make custom-property substitution only traverse variables which could have references. r=jwatt
If a name is not in self.seen, it means we've inherited it from our
parent. That in turn means that it can't have any variable reference
(because we inherit the computed variables) and we can skip the work of
t... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 791627ee6..a025f1a1f 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -726,7 +726,7 @@ impl<'a> CustomPropertiesBuilder<'a> {
None => return self.inherited.cloned(),
};
if self.may_have_c... | 1 | 10 | 10 |
d17ecd505729d34f418572dceb350d674367e61c | Emilio Cobos Álvarez | 2022-02-10T15:50:31 | Bug 1754547 - Generalize moz-os-version into moz-platform. r=dao,preferences-reviewers,Gijs
Allow differentiating non-windows platforms on it.
Differential Revision: https://phabricator.services.mozilla.com/D138431 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 66722af6c..af57be431 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -13,7 +13,6 @@ use crate::media_queries::{Device, MediaType};
use crate::values::computed::CSSPixelLength;
use crate::values::computed... | 1 | 28 | 13 |
720d6bc90dc657b6f4662e66234a93ba0748f10f | Emilio Cobos Álvarez | 2022-02-09T03:15:52 | Bug 1746248 - Style system and plumbing for mix-blend-mode: plus-lighter. r=jrmuizel,layout-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D137951 | diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs
index 1cbf601ad..76b71b12c 100644
--- a/style/properties/longhands/background.mako.rs
+++ b/style/properties/longhands/background.mako.rs
@@ -111,5 +111,6 @@ ${helpers.single_keyword(
vector=True,
engine... | 2 | 2 | 1 |
8396c8400312c07882661ea3b11a8e6ea9d92576 | Mike Hommey | 2022-01-25T21:29:51 | Bug 1751331 - Use the mozbuild crate in servo. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D136562 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 827c04b9d..7e8a285f4 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -17,7 +17,7 @@ path = "lib.rs"
doctest = false
[features]
-gecko = ["nsstring", "serde", "style_traits/gecko", "bindgen", "regex", "toml"]
+gecko = ["nsstring", "serde", "style_traits/... | 2 | 5 | 12 |
b32aac323c1e2b72759f094544813eb3dfac3fc1 | Mike Hommey | 2022-01-25T21:29:49 | Bug 1751331 - Remove MOZ_DIST. r=firefox-build-system-reviewers,mhentges
As mentioned in bug 1747354, the location of the dist directory is
relied to be $topobjdir/dist, so just use that consistently rather
than getting it from a separate variable for rust build scripts.
Differential Revision: https://phabricator.ser... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index d923c25c8..1f0bf1ddd 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -58,11 +58,11 @@ lazy_static! {
};
static ref INCLUDE_RE: Regex = Regex::new(r#"#include\s*"(.+?)""#).unwrap();
static ref DISTDIR_PATH: PathBuf = {
- ... | 1 | 3 | 3 |
f70257af16186b5c78f898a243db9d8da9fc567b | criss | 2022-01-25T11:00:25 | Backed out 10 changesets (bug 1751331) for causing bustages. CLOSED TREE
Backed out changeset 5ce212465a26 (bug 1751331)
Backed out changeset 14d62b8ffa5a (bug 1751331)
Backed out changeset 76f46bd9afa1 (bug 1751331)
Backed out changeset 147faaad046f (bug 1751331)
Backed out changeset f85b049d12f9 (bug 1751331)
Backed... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 7e8a285f4..827c04b9d 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -17,7 +17,7 @@ path = "lib.rs"
doctest = false
[features]
-gecko = ["nsstring", "serde", "style_traits/gecko", "bindgen", "regex", "toml", "mozbuild"]
+gecko = ["nsstring", "serde", "s... | 2 | 12 | 5 |
7b78a27fb8f5139fa0f2a948d62b9082a7727a86 | Emily McDonough | 2022-01-24T17:29:20 | Bug 1750884 - Add style_traits::ToCss for AtomIdent r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D136290 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 35c5a5c45..8fc0900ae 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -69,7 +69,7 @@ impl ToCss for NonTSPseudoClass {
$(NonTSPseudoClass::$name => concat!(":", $css),)*
... | 6 | 20 | 20 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.