commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
8c80ae01ce482bcd9d3a5ee1fe4aa4f8be478a3f
lamoure6
2021-09-20T22:40:42
Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio Differential Revision: https://phabricator.services.mozilla.com/D125328
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 664a12f41..220288de1 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -650,37 +650,12 @@ macro_rules! lnf_int_feature { }}; } -/// bool pref-based features are an slightly less convenient to start u...
1
1
28
795b8a7c139c3f129e99f8126cfa1b96860c21e6
Csoregi Natalia
2021-09-20T20:29:05
Backed out changeset 0711ae54877b (bug 1719938) for bustages on media_features.rs. CLOSED TREE
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index e6cb6f8d5..664a12f41 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -926,4 +926,6 @@ pub static MEDIA_FEATURES: [MediaFeatureDescription; 60] = [ lnf_int_feature!(atom!("-moz-gtk-csd-close-button"), ...
1
2
0
9231ec4c53d25ae7cd6432f4b96cc05d9baf0bb1
lamoure6
2021-09-20T19:21:50
Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio Differential Revision: https://phabricator.services.mozilla.com/D125328
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 664a12f41..e6cb6f8d5 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -926,6 +926,4 @@ pub static MEDIA_FEATURES: [MediaFeatureDescription; 60] = [ lnf_int_feature!(atom!("-moz-gtk-csd-close-button"), ...
1
0
2
ca756a39cb5aa51eb199b88ad2bbef33bcdab786
Emilio Cobos Álvarez
2021-09-20T12:05:32
Bug 1596184 - Get rid of nsStackFrame. r=layout-reviewers,mats There are no legacy-stack uses anymore. Differential Revision: https://phabricator.services.mozilla.com/D126077
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index da987a992..67aad8845 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -110,8 +110,6 @@ pub enum DisplayInside { #[cfg(feature = "gecko")] MozBox, #[cfg(feature = "gecko")] - MozStack, - ...
1
0
6
616ec8534490d3d286b70744516bc9ebfca17ec2
Boris Chiou
2021-09-17T20:25:37
Bug 1676782 - Part 5: Drop the unused effective_xxx_rules. r=emilio It seems only effective_style_rules() and effective_viewport_rules() are used. Let's drop the unused ones. Differential Revision: https://phabricator.services.mozilla.com/D125905
diff --git a/style/stylesheets/stylesheet.rs b/style/stylesheets/stylesheet.rs index 7cdea20e8..cff97ea8f 100644 --- a/style/stylesheets/stylesheet.rs +++ b/style/stylesheets/stylesheet.rs @@ -278,15 +278,7 @@ pub trait StylesheetInDocument: ::std::fmt::Debug { rule_filter! { effective_style_rules(Style...
1
0
8
f836f6e47200db258545882a24f0312ca848de84
Boris Chiou
2021-09-17T20:25:36
Bug 1676782 - Part 3: Add CSSScrollTimelineRule for CSSOM. r=emilio Implement CSSScrollTimelineRule CSSOM API. https://drafts.csswg.org/scroll-animations-1/#the-css-scroll-timeline-rule-interface We rely on the CSSOM API for testing. However, the wpt doesn't match the current spec and it has some errors. We update th...
diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs index 788f75f2b..05fcdb5b1 100644 --- a/style/gecko/arc_types.rs +++ b/style/gecko/arc_types.rs @@ -10,13 +10,11 @@ use crate::gecko::url::CssUrlData; use crate::gecko_bindings::structs::{ - RawServoAnimationValue, RawServoCounterStyleRule, RawServ...
2
24
11
f50069210e1aeef4bcc6ca41fea6cdb5d64c6d99
Boris Chiou
2021-09-17T20:25:36
Bug 1676782 - Part 2: Hook @scroll-timeline rule into style system. r=emilio We add scroll-timeline rule into the stylesheet rule type, and add a new perference to protect it: layout.css.scroll-linked-animations.enabled. We will use this perference for animation-timeline property as well. Differential Revision: http...
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index f4dc0c5a4..fc39b8cca 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -543,6 +543,7 @@ impl StylesheetInvalidationSet { FontFeatureValues(..) | FontFace(..) | ...
6
57
11
c3090b75cf9b918dbc51b5aaa4d04cddc5aba968
Boris Chiou
2021-09-17T20:25:35
Bug 1676782 - Part 1: Implement @scroll-timeline in style system. r=emilio Define the data structure for @scroll-timeline rule, the parsing code, and the serialization. Differential Revision: https://phabricator.services.mozilla.com/D125764
diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs index a2f4a705b..d17bc3ffd 100644 --- a/style/stylesheets/mod.rs +++ b/style/stylesheets/mod.rs @@ -20,6 +20,7 @@ mod page_rule; mod rule_list; mod rule_parser; mod rules_iterator; +pub mod scroll_timeline_rule; mod style_rule; mod stylesheet; pub m...
3
345
17
07a5c2008fa4c378ba57d64ca5dd81e8b2a5d392
Mike Hommey
2021-09-15T07:53:20
Bug 1730397 - Remove unnecessary semi-colons in some macros. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D125503
diff --git a/style/stylesheets/viewport_rule.rs b/style/stylesheets/viewport_rule.rs index eb01e8b95..9f751ece2 100644 --- a/style/stylesheets/viewport_rule.rs +++ b/style/stylesheets/viewport_rule.rs @@ -752,7 +752,7 @@ impl MaybeNew for ViewportConstraints { }) } else { ...
2
2
2
225f967a05587a2d0bb53576f146f471c7f72666
criss
2021-09-14T14:42:03
Backed out changeset 4c5f2e282204 (bug 1729421) for bc failures
diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs index 2224100d3..ae1ba7bed 100644 --- a/style/rule_tree/core.rs +++ b/style/rule_tree/core.rs @@ -66,7 +66,7 @@ impl MallocSizeOf for RuleTree { } #[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)] -struct ChildKey(ptr::NonNull<()>); +struct ChildKey(Ca...
1
3
2
4ea0bb901a61073e92a8981abc066c5a6daab689
Emilio Cobos Álvarez
2021-09-14T13:24:37
Bug 1729421 - Do not key rule tree children by cascade level. r=jwatt This was needed before, since we used to optimize empty style rules away (and thus we could get confused between the important and non-important block for two different elements). But now we always keep them, and thus there's no way for the same de...
diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs index ae1ba7bed..2224100d3 100644 --- a/style/rule_tree/core.rs +++ b/style/rule_tree/core.rs @@ -66,7 +66,7 @@ impl MallocSizeOf for RuleTree { } #[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)] -struct ChildKey(CascadeLevel, ptr::NonNull<()>); +stru...
1
2
3
badc12ea144971364b1874084305fac57d9492a4
Emilio Cobos Álvarez
2021-09-11T00:04:18
Bug 1730123 - Fix anonymous name handling in presence of stylesheet sharing. r=firefox-style-system-reviewers,boris We need to compute the anonymous name on the fly while building the CascadeData, otherwise we may see the same layer rule in two places due to stylehseet sharing and make them incorrectly share a name. ...
diff --git a/style/stylesheets/import_rule.rs b/style/stylesheets/import_rule.rs index 80c798cb2..c6f7714b2 100644 --- a/style/stylesheets/import_rule.rs +++ b/style/stylesheets/import_rule.rs @@ -138,12 +138,10 @@ impl DeepCloneWithLock for ImportSheet { } /// The layer keyword or function in an import rule. -#[de...
4
65
60
fe3628d0b61f8e1ef9b4579565cfd776c1086bb0
Emilio Cobos Álvarez
2021-09-10T23:16:02
Bug 1730134 - Add some parsing and serialization tests for @layer. r=boris This uncovers some serialization bugs, and some missing null-checks given the statement layer doesn't have a rule list. Differential Revision: https://phabricator.services.mozilla.com/D125176
diff --git a/style/stylesheets/layer_rule.rs b/style/stylesheets/layer_rule.rs index a012c9c54..c246d5e1b 100644 --- a/style/stylesheets/layer_rule.rs +++ b/style/stylesheets/layer_rule.rs @@ -234,7 +234,7 @@ impl ToCssWithGuard for LayerRule { guard: &SharedRwLockReadGuard, dest: &mut crate::str::Css...
1
5
3
e2c90bee51ecb5a61f4afdb8abcf984632680ea2
Emilio Cobos Álvarez
2021-09-10T18:22:36
Bug 1729804 - Add experimental support for "e", "pi", and various trigonometric functions in calc(). r=firefox-style-system-reviewers,boris I'll add some tests before enabling. Also, WebKit folks (who have implemented cos() / tan() / sin()) said they will upstream their tests to WPT, so I'll extend those with the inve...
diff --git a/style/values/specified/angle.rs b/style/values/specified/angle.rs index fa60f6650..08c6b4436 100644 --- a/style/values/specified/angle.rs +++ b/style/values/specified/angle.rs @@ -130,6 +130,15 @@ impl Angle { } } + /// Creates an angle with the given value in radians. + #[inline] + ...
2
93
8
50ac6f6ff9fe23842e7054474fd85bde07bcef51
Emilio Cobos Álvarez
2021-09-10T12:08:19
Bug 1730098 - Don't consider system-ui valid for user font prioritization. r=jfkthame Since the user can't configure it, at least from the UI (we could add UI for it but it's unclear it'd be worth it). Differential Revision: https://phabricator.services.mozilla.com/D125182
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 53a0d212b..0cee5057f 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -923,12 +923,7 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> { // we have a generic family to actually replace it with. let prio...
2
24
10
9a81b2619745f37babd10e9e32d7db9a0c99566b
Emilio Cobos Álvarez
2021-09-08T11:18:32
Bug 1729330 - Add a simple CSSLayerRule implementation. r=smaug The specifics of how this is going to work are still getting spec'd / discussed in https://github.com/w3c/csswg-drafts/issues/6576, but this allows DevTools to work fine and the feature to be complete enough for Nightly experimentation (with the other in-...
diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs index 7aed10b65..788f75f2b 100644 --- a/style/gecko/arc_types.rs +++ b/style/gecko/arc_types.rs @@ -9,34 +9,26 @@ #![allow(non_snake_case, missing_docs)] use crate::gecko::url::CssUrlData; -use crate::gecko_bindings::structs::RawServoAnimationValue; -...
2
20
24
f27c026de35456a1d11e62cee18474c8bb4d407e
Emilio Cobos Álvarez
2021-09-08T11:17:04
Bug 1729289 - Fix layer statement with nested layer names. r=boris When we had: @layer A.B; We were registering "A" and "B", not "A" and "A.B", which was the intention. Fix is trivial. Depends on D124620 Differential Revision: https://phabricator.services.mozilla.com/D124621
diff --git a/style/stylist.rs b/style/stylist.rs index 08610308b..2a46e0c3a 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -2429,9 +2429,13 @@ impl CascadeData { } LayerRuleKind::Statement { ref names } => { for name in &**names { +...
1
4
0
085fd0b3f7325ea54201589563f2b09e01e6dcfb
Emilio Cobos Álvarez
2021-09-08T11:17:04
Bug 1729289 - Fix out of order child layer registration, and enable the tests. r=boris This makes layer order use a fixed set of bits per nesting level, to "reserve" bits for children before they are registered. See the comment in LayerOrder for the implementation limits it imposes, and potential alternatives if thes...
diff --git a/style/stylesheets/layer_rule.rs b/style/stylesheets/layer_rule.rs index 8d51558ec..a012c9c54 100644 --- a/style/stylesheets/layer_rule.rs +++ b/style/stylesheets/layer_rule.rs @@ -19,6 +19,97 @@ use smallvec::SmallVec; use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, ToCss}; +/// ...
2
132
18
fe82534633d3a7f7b58a9715a3a8e34aebbc8e68
Jonathan Kew
2021-09-06T18:22:37
Bug 1729147 - Fix the serialization order for the text-decoration shorthand to match the canonical order in the spec. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D124536
diff --git a/style/properties/shorthands/text.mako.rs b/style/properties/shorthands/text.mako.rs index 03637d557..5e71fc08c 100644 --- a/style/properties/shorthands/text.mako.rs +++ b/style/properties/shorthands/text.mako.rs @@ -88,6 +88,13 @@ has_value = true; } + if !is_auto...
1
7
7
f6a9510a0b4862d5e3262c483f120f2714e45dd3
Emilio Cobos Álvarez
2021-09-06T16:43:04
Bug 1699217 - Implement @import layer|layer(<name>). r=boris This works modulo the existing nested layer order bug. Will be covered by WPT /css/css-cascade/layer-import.html once the feature is enabled (I can probably enable it right away for those tests, but I'd rather fix the obvious bugs first). Differential Revis...
diff --git a/style/stylesheets/import_rule.rs b/style/stylesheets/import_rule.rs index 300b57a19..80c798cb2 100644 --- a/style/stylesheets/import_rule.rs +++ b/style/stylesheets/import_rule.rs @@ -12,6 +12,7 @@ use crate::shared_lock::{DeepCloneParams, DeepCloneWithLock}; use crate::shared_lock::{SharedRwLock, SharedR...
4
98
25
1e523a3feba8abe970c39661665b51e67f4bc4fc
Sandor Molnar
2021-09-06T16:32:53
Backed out changeset 34c1b1078f03 (bug 1699217) for causing wpt failures in /css/css-cascade/layer-import. CLOSED TREE
diff --git a/style/stylesheets/import_rule.rs b/style/stylesheets/import_rule.rs index 80c798cb2..300b57a19 100644 --- a/style/stylesheets/import_rule.rs +++ b/style/stylesheets/import_rule.rs @@ -12,7 +12,6 @@ use crate::shared_lock::{DeepCloneParams, DeepCloneWithLock}; use crate::shared_lock::{SharedRwLock, SharedR...
4
25
97
49c316ac904eb0c80ee6c90a43e8bba006dd1320
Emilio Cobos Álvarez
2021-09-06T11:15:57
Bug 1699217 - Implement @import layer|layer(<name>). r=boris This works modulo the existing nested layer order bug. Will be covered by WPT /css/css-cascade/layer-import.html once the feature is enabled (I can probably enable it right away for those tests, but I'd rather fix the obvious bugs first). Differential Revis...
diff --git a/style/stylesheets/import_rule.rs b/style/stylesheets/import_rule.rs index 300b57a19..80c798cb2 100644 --- a/style/stylesheets/import_rule.rs +++ b/style/stylesheets/import_rule.rs @@ -12,6 +12,7 @@ use crate::shared_lock::{DeepCloneParams, DeepCloneWithLock}; use crate::shared_lock::{SharedRwLock, SharedR...
4
97
25
981567117375384074b4a3545193e36b88a777cf
Emilio Cobos Álvarez
2021-09-06T10:02:07
Bug 1728754 - Plumb layer order through ApplicableDeclarationBlock, and make it have an effect. r=boris Same, I want to land this separately to see if it affects micro-benchmarks. If so, we might want to pack the layer order _somewhere_ (though in this case I'm not sure where, tbh). With this, layer rules should have...
diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs index 6353fb4c5..168aae643 100644 --- a/style/applicable_declarations.rs +++ b/style/applicable_declarations.rs @@ -69,8 +69,10 @@ pub struct ApplicableDeclarationBlock { /// The bits containing the source order, cascade level, and sh...
3
10
5
30d94808845d967e2059e04f2da05ddc51937ba9
Emilio Cobos Álvarez
2021-09-06T09:54:02
Bug 1728754 - Add layer_order to rules. r=boris I want to land this separately because we might want to get smarter with the size of the Rule struct (maybe restricting layer order to a u8 per scope and packing it with the source order, since 255 layers seem plenty), but I'd rather do the obvious thing for now. Depend...
diff --git a/style/stylist.rs b/style/stylist.rs index a1fb84d6a..9ca9687b5 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -2004,7 +2004,7 @@ impl CascadeData { selectors_for_cache_revalidation: SelectorMap::new_without_attribute_bucketing(), animations: Default::default(), ...
1
23
11
9c0e6ec2a89df6160ef9cb113e8451635282677c
Emilio Cobos Álvarez
2021-09-04T07:42:46
Bug 1728754 - Tweak recursion in add_rule to only cause a function call per recursion level. r=boris This code is really hot, and we've had perf regressions in the past for introducing function calls in the hot path. After the previous patch, add_rule is recursive and thus it can't be inlined, causing a function call...
diff --git a/style/stylist.rs b/style/stylist.rs index 45dbd9540..a1fb84d6a 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -2159,10 +2159,9 @@ impl CascadeData { } } - #[inline] - fn add_rule<S>( + fn add_rule_list<S>( &mut self, - rule: &CssRule, + rules: std::s...
1
225
229
13d43c6580f668f847f056228476232d5fc3e43d
Emilio Cobos Álvarez
2021-09-04T07:42:46
Bug 1728754 - Compute layer order during CascadeData rebuild. r=boris For that, deal with children in add_rule recursively, to keep the current layer name up-to-date in block layer rules. This is not the final version of this code, as right now something like this: @layer A { ... } @layer B { ... } ...
diff --git a/style/stylesheets/layer_rule.rs b/style/stylesheets/layer_rule.rs index c8a04ca65..8d51558ec 100644 --- a/style/stylesheets/layer_rule.rs +++ b/style/stylesheets/layer_rule.rs @@ -20,8 +20,37 @@ use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, ToCss}; /// A `<layer-name>`: https:/...
5
236
90
fa8fa5506ab93ab8a4057ab336943e9a4f6e3171
Emilio Cobos Álvarez
2021-09-04T07:42:45
Bug 1728754 - Factor out adding a rule in CascadeData::add_rule. r=boris This shouldn't have any behavior change, but is necessary because for cascade layers we are going to need to handle the child rules / sheets ourselves, in order to handle nested layers properly. Differential Revision: https://phabricator.service...
diff --git a/style/stylist.rs b/style/stylist.rs index 90f0ed8c0..cba1820d6 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -2150,6 +2150,179 @@ impl CascadeData { } } + #[inline] + fn add_rule<S>( + &mut self, + rule: &CssRule, + _device: &Device, + quirks_mode...
1
183
157
601a227e26fc7ffd8aaee9a12c6fae9137ebbefb
Emilio Cobos Álvarez
2021-09-03T15:57:30
Bug 1728851 - Add attributes to the rule hash. r=boris See the discussion here: https://twitter.com/Rich_Harris/status/1433153204678799365 This should make attribute selectors roughly as fast as class selectors. I think it's worth trying and see if perf bots complain on micro-benchmarks and stylebench and such. I m...
diff --git a/style/bloom.rs b/style/bloom.rs index d75abaa4f..c11145439 100644 --- a/style/bloom.rs +++ b/style/bloom.rs @@ -125,13 +125,11 @@ where element.each_class(|class| f(class.get_hash())); - if static_prefs::pref!("layout.css.bloom-filter-attribute-names.enabled") { - element.each_attr_name(...
5
110
30
7f3d1a67a1c50cde3fc0b4a45af5f2c6ecbdddd7
Emilio Cobos Álvarez
2021-09-03T09:28:08
Bug 1728633 - Hook up basic @layer rule parsing. r=boris Disabled, and of course doing nothing for now still, but this is another piece that is useful to get reviewed separately. Don't allow layers to be interleaved with @import / @namespace rules as per https://github.com/w3c/csswg-drafts/issues/6522. Differential ...
diff --git a/style/stylesheets/layer_rule.rs b/style/stylesheets/layer_rule.rs index 873c9e127..c8a04ca65 100644 --- a/style/stylesheets/layer_rule.rs +++ b/style/stylesheets/layer_rule.rs @@ -90,11 +90,11 @@ pub enum LayerRuleKind { /// A statement `@layer <name>, <name>, <name>;` Statement { /// Th...
3
68
48
48849c8ef55be77062a4df06e579d61004539c83
Emilio Cobos Álvarez
2021-09-03T09:26:10
Bug 1728617 - Tweak at-rule parsing APIs to support cascade layers. r=boris This needs https://github.com/servo/rust-cssparser/pull/287 and a cssparser update. Differential Revision: https://phabricator.services.mozilla.com/D124216
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 56458631d..47baea83c 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -31,7 +31,7 @@ accountable-refcell = { version = "0.2.0", optional = true } app_units = "0.7" content-security-policy = { version = "0.4.0", features ...
12
58
70
ffceae2f267465b4a4bfe9a391cdb9213647b568
Emilio Cobos Álvarez
2021-09-03T09:20:08
Bug 1728348 - Restore an #[allow] that will otherwise cause warnings. MANUAL PUSH: Trivial no-behavior-change CLOSED TREE
diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs index dbb42667b..dc3f39e03 100644 --- a/style/stylesheets/mod.rs +++ b/style/stylesheets/mod.rs @@ -308,6 +308,7 @@ impl CssRule { } /// https://drafts.csswg.org/cssom-1/#dom-cssrule-type +#[allow(missing_docs)] #[derive(Clone, Copy, Debug, Eq, FromP...
1
1
0
3d3b3f444aed16a39f630f69de855c00600596db
Emilio Cobos Álvarez
2021-09-03T09:12:43
Bug 1728348 - Add some scaffolding for @layer rules. r=boris Not hooked anywhere yet, so this doesn't change behavior, but adds the basic data model etc. Adding parsing support requires some changes to cssparser to allow the same at rule to be block and statement-like at the same time, so better done separately. Dif...
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index edecc3fc2..f4dc0c5a4 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -555,7 +555,7 @@ impl StylesheetInvalidationSet { self.collect_invalidations_for_rule(rule, guard, de...
6
208
5
0409a169337573bbe2b6a6d07ff595f21ec04972
criss
2021-09-03T09:13:11
Backed out changeset 876e53ec90c4 (bug 1728851) as requested by Emilio. CLOSED TREE
diff --git a/style/bloom.rs b/style/bloom.rs index c11145439..d75abaa4f 100644 --- a/style/bloom.rs +++ b/style/bloom.rs @@ -125,11 +125,13 @@ where element.each_class(|class| f(class.get_hash())); - element.each_attr_name(|name| { - if !is_attr_name_excluded_from_filter(name) { - f(name.g...
3
19
86
9d6d48c977975d571f394acc438808d441acbf4e
Emilio Cobos Álvarez
2021-09-03T08:58:20
Bug 1728851 - Add attributes to the rule hash. r=boris See the discussion here: https://twitter.com/Rich_Harris/status/1433153204678799365 This should make attribute selectors roughly as fast as class selectors. I think it's worth trying and see if perf bots complain on micro-benchmarks and stylebench and such. I m...
diff --git a/style/bloom.rs b/style/bloom.rs index d75abaa4f..c11145439 100644 --- a/style/bloom.rs +++ b/style/bloom.rs @@ -125,13 +125,11 @@ where element.each_class(|class| f(class.get_hash())); - if static_prefs::pref!("layout.css.bloom-filter-attribute-names.enabled") { - element.each_attr_name(...
3
86
19
d281c1479614aea9e6e47e1d354bb09794f419a0
Emilio Cobos Álvarez
2021-09-03T08:56:43
Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr Also, more directly go from StyleImageRendering to wr::ImageRendering. * image-rendering: smooth the non-deprecated version of OptimizeQuality, which maps to SamplingFilter::LINEAR / wr::ImageRendering::...
diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs index 861597f3b..177138d8e 100644 --- a/style/values/specified/image.rs +++ b/style/values/specified/image.rs @@ -1233,8 +1233,10 @@ impl MozImageRect { #[repr(u8)] pub enum ImageRendering { Auto, + Smooth, #[parse(aliases = "...
1
3
2
8a1aa310be8894faea57522558af26fa6a75a0bb
Emilio Cobos Álvarez
2021-09-02T15:24:40
Bug 1693222 - Fix selecteditem color on macOS. This is an oversight. I made selecteditem be -moz-html-cellhighlight, but that's for inactive cells. Use the inactive cell color everywhere (though android doesn't differentiate). This matches other browsers and what was reviewed on this bug. MANUAL PUSH: The semi-trans...
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 15327fa5d..5b9b2054b 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -331,14 +331,14 @@ pub enum SystemColor { /// Used to highlight valid regions to drop something onto. MozDragtargetzon...
1
4
4
9eb6dd46934fbb05ee13f6f045198f4d2a8912f5
Emilio Cobos Álvarez
2021-09-02T11:38:01
Bug 1693222 - Implement SelectedItem and SelectedItemText system colors. r=mstange Since Highlight / HighlightText are now equivalent to the text selection ones, remove those too. Differential Revision: https://phabricator.services.mozilla.com/D123964
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 9c0f5bfee..15327fa5d 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -244,10 +244,6 @@ pub enum SystemColor { #[css(skip)] TextForeground, #[parse(condition = "ParserContext::in_ua_o...
1
4
6
4370ae44a55f42d93b128ba83a7eb410772a60e2
Narcis Beleuzu
2021-09-01T23:26:12
Backed out changeset 28a0487d0291 (bug 1693222) for reftest failure on themed-widget.html. CLOSED TREE
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 15327fa5d..9c0f5bfee 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -244,6 +244,10 @@ pub enum SystemColor { #[css(skip)] TextForeground, #[parse(condition = "ParserContext::in_ua_o...
1
6
4
39fd81aedbc42a24a86a0a986000c433ca0e4072
Dzmitry Malyshau
2021-09-01T21:11:33
Bug 1726628 - Switch cargo resolver to 2 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D123157
diff --git a/style/Cargo.toml b/style/Cargo.toml index 757aa74d3..63d9e543d 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -83,7 +83,7 @@ gecko-profiler = { path = "../../../tools/profiler/rust-api" } [build-dependencies] lazy_static = "1" -log = "0.4" +log = { version = "0.4", features = ["std"] } bindge...
1
1
1
f2fcece59b15fd3e05dc96ffce06205f9f01a41e
Emilio Cobos Álvarez
2021-08-30T11:08:40
Bug 1727537 - Remove layout.css.is-and-where-better-error-recovery.enabled. r=hiro We shipped this in 84 Differential Revision: https://phabricator.services.mozilla.com/D123623
diff --git a/selectors/parser.rs b/selectors/parser.rs index e4bb66d85..b82ce139d 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -253,11 +253,6 @@ pub trait Parser<'i> { false } - /// The error recovery that selector lists inside :is() and :where() have. - fn is_and_where_error_reco...
2
5
23
230fe9605e81becae6981637c1d3ef2e06e6dba4
Emilio Cobos Álvarez
2021-08-30T11:08:23
Bug 1727536 - Avoid some clone()s in selector parsing now that lifetimes are non-lexical. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D123622
diff --git a/selectors/parser.rs b/selectors/parser.rs index 732a34a5b..e4bb66d85 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -1858,9 +1858,9 @@ where }; let start = input.state(); - // FIXME: remove clone() when lifetimes are non-lexical - match input.next_including_whitespace().map...
1
13
16
e135ac2d51f9935033533f3126e6b49105776c30
Emilio Cobos Álvarez
2021-08-24T00:32:24
Bug 1725207 - Implement transform: perspective(none). r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D123350
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 57d1900a0..598bf9b59 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1105,8 +1105,8 @@ impl Animate for ComputedTransformOperation { // interpolated as defined in s...
4
72
19
3ecb7e7563f48014582982e5027b33e8f5a6a4b1
Emilio Cobos Álvarez
2021-08-23T09:18:49
Bug 1726515 - Workaround GCC-calling-into-LLVM ABI issue by making GenericFontFamily larger. r=hiro This enum being a bit larger doesn't cause many common data structures to grow, so this should be fine. Differential Revision: https://phabricator.services.mozilla.com/D123146
diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs index 2d6f72896..49f098336 100644 --- a/style/values/computed/font.rs +++ b/style/values/computed/font.rs @@ -382,6 +382,10 @@ fn system_ui_enabled(_: &ParserContext) -> bool { /// The order here is important, if you change it make sure that /...
1
5
1
4fa26dc23509493a374d76200ae0cfb3fa8f8c72
Matt Woodrow
2021-08-22T20:46:47
Bug 1723266 - Return an infinite perspective in TransformOperation::Perspective::to_animated_zero. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D122919
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index a204ec2be..57d1900a0 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1112,8 +1112,12 @@ impl Animate for ComputedTransformOperation { let decomposed = decompose_3d_m...
3
11
7
95a77488ab5da2bff0bf79cf907cea79a5a8e486
Cosmin Sabou
2021-08-19T23:39:15
Backed out changeset 21e4ad4c8599 (bug 1723266) for causing mochitest plain failures on test_distance_of_transform.html. CLOSED TREE
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 57d1900a0..a204ec2be 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1112,12 +1112,8 @@ impl Animate for ComputedTransformOperation { let decomposed = decompose_3d_m...
3
7
11
d8471e61cba94ec8ad146215f05b19b7d0b1d922
Emilio Cobos Álvarez
2021-08-19T17:46:54
Bug 1105364 - Respect transparent and system color border colors in forced-colors mode. r=morgan Differential Revision: https://phabricator.services.mozilla.com/D123111
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 83f058820..53a0d212b 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -471,7 +471,22 @@ fn tweak_when_ignoring_colors( } } }, - _ => {}, + _ => { + //...
2
47
3
0606e320ab94343e3bbe2887b7de8c493b34b369
Mats Palmgren
2021-08-09T21:41:34
Bug 1706080 - [css-fonts] Implement 'font-synthesis: small-caps'. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D114313
diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs index 6dce53596..44927ef14 100644 --- a/style/values/specified/font.rs +++ b/style/values/specified/font.rs @@ -1950,23 +1950,24 @@ impl Parse for FontFeatureSettings { Debug, MallocSizeOf, PartialEq, - SpecifiedValueInfo, ...
1
68
32
dbb4f9179d8599c69011c07759217d011ff88a8b
Barret Rennie
2021-08-09T16:16:40
Bug 1703356 - Support color-mix() in non-sRGB color spaces r=emilio Out of gamut colours are currently clipped into sRGB. Differential Revision: https://phabricator.services.mozilla.com/D120561
diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs index 773310dd9..f99e344a5 100644 --- a/style/values/animated/color.rs +++ b/style/values/animated/color.rs @@ -7,6 +7,8 @@ use crate::values::animated::{Animate, Procedure, ToAnimatedZero}; use crate::values::distance::{ComputeSquaredDistan...
2
716
36
b9ba96cd7a1efd83d14c289993f383eccb25ac6a
Ryan VanderMeulen
2021-08-09T12:52:56
Backed out changeset 4b53d6459297 (bug 1719963) for causing topcrash bug 1722150.
diff --git a/style/gecko/data.rs b/style/gecko/data.rs index cc7db74c4..39f7d7cc8 100644 --- a/style/gecko/data.rs +++ b/style/gecko/data.rs @@ -64,10 +64,7 @@ impl GeckoStyleSheet { /// bug 1719963 and can hopefully get a useful report from fuzzers. #[inline] pub fn hack_is_null(&self) -> bool { - ...
1
1
4
04968f08480bc1b035f92ab7c1acb2cbc87b2974
mbrubeck@limpet.net
2021-08-03T17:20:36
Bug 1723791 - Upgrade to uluru 1.1.1. r=emilio MANUAL PUSH: Patch wasn't pushed via phabricator.
diff --git a/style/Cargo.toml b/style/Cargo.toml index 9dd9e96fb..757aa74d3 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -75,7 +75,7 @@ thin-slice = "0.1.0" to_shmem = {path = "../to_shmem"} to_shmem_derive = {path = "../to_shmem_derive"} time = "0.1" -uluru = "0.4" +uluru = "1.1" unicode-bidi = "0.3" u...
3
4
4
af6838c7768b8cea58db3a0960cd80090471c69a
Emilio Cobos Álvarez
2021-08-03T17:56:58
Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin break-before/after: page|column seem harder because you need to deal with nested breaks, I think, but this should be straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D121206
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index f2d0234a9..c8942fdc6 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -503,7 +503,6 @@ ${helpers.predefined_type( "BreakWithin", "computed::BreakWithin::Auto", ...
3
66
21
4915c80448743e7f4ba4d3cdbaa15f94a3a389fc
Noemi Erli
2021-08-03T17:35:10
Backed out changeset 67c33ba5566e (bug 1722945) for causing bustage in nsContainerFrame.cpp
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index c8942fdc6..f2d0234a9 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -503,6 +503,7 @@ ${helpers.predefined_type( "BreakWithin", "computed::BreakWithin::Auto", ...
3
21
66
9a0694c7c2de39287601e949efbfc5f72b11df9e
Emilio Cobos Álvarez
2021-08-01T23:08:05
Bug 1722488 - Don't alias -apple-system to system-ui for now, to keep /css/css-fonts/animations/system-fonts.html happy. We probably want to do this when they do something different, but for now behavior should be the same and it causes some subtests to fail because `getComputedStyle(..).fontFamily` for system fonts s...
diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs index 1bc95c284..2d6f72896 100644 --- a/style/values/computed/font.rs +++ b/style/values/computed/font.rs @@ -411,7 +411,7 @@ pub enum GenericFontFamily { Monospace, Cursive, Fantasy, - #[parse(aliases = "-apple-system", condit...
1
1
1
8462f7b330d651df10c0ff4d087b0506c251f893
Nazım Can Altınova
2021-07-30T21:49:23
Bug 1652560 - Remove the unused "gecko_profiler" feature from servo r=emilio This was being used when we had special code for gecko profiler in the servo codebase but we just removed the last one. This is safe to remove now. The "enabled" feature in the gecko-profiler crate is being controlled by gkrust-shared directl...
diff --git a/style/Cargo.toml b/style/Cargo.toml index 10d61dbb2..9dd9e96fb 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -25,7 +25,6 @@ servo-layout-2013 = [] servo-layout-2020 = [] gecko_debug = [] gecko_refcount_logging = [] -gecko_profiler = [] [dependencies] app_units = "0.7"
1
0
1
3ddcd58839a6ea4ac9c806d74d8a9fda124dd8a7
Nazım Can Altınova
2021-07-30T21:49:22
Bug 1652560 - Remove the old profiler label frames code in the servo codebase and replace it with the new API r=emilio Differential Revision: https://phabricator.services.mozilla.com/D120795
diff --git a/style/driver.rs b/style/driver.rs index eab7c3a6a..e5383ae74 100644 --- a/style/driver.rs +++ b/style/driver.rs @@ -140,7 +140,7 @@ where // ensures that we process all the elements at a given depth before // proceeding to the next depth, which is important for sty...
6
5
109
20f3e9855dff2afd2295a1025e81d526aab3e63b
Mike Hommey
2021-07-28T20:37:48
Bug 1722652 - Setup bindgen flags for servo similarly to cranelift and neqo. r=emilio While the use of toml allows the flags to be separated, the split is done via some shell shenanigans anyways, and servo's build.rs can handle the same just fine. Differential Revision: https://phabricator.services.mozilla.com/D12104...
diff --git a/style/build_gecko.rs b/style/build_gecko.rs index 1f034cad9..d923c25c8 100644 --- a/style/build_gecko.rs +++ b/style/build_gecko.rs @@ -46,11 +46,15 @@ lazy_static! { .join("layout/style/ServoBindings.toml"); read_config(&path) }; - static ref BUILD_CONFIG: Table = { + stat...
1
9
9
bfac70f7235a7dff09dbb2d55e9548e0fa516263
Morgan Reschenberg
2021-07-28T17:25:58
Bug 1720792: Add MozNativevisitedhyperlinktext color, use it to style visited links r=emilio Differential Revision: https://phabricator.services.mozilla.com/D120657
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 3480b545f..e490545b6 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -362,6 +362,10 @@ pub enum SystemColor { /// colors. MozNativehyperlinktext, + /// As above, but visited link col...
1
4
0
6a63686dd3abe08d4236d83b7d7cde7fed9f0c9c
Alexandru Michis
2021-07-27T17:27:46
Backed out changeset d06a9296cfab (bug 1718934) for not fixing Bug 1718934 in its entirety.
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index c96af7e5a..3480b545f 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -341,10 +341,6 @@ pub enum SystemColor { MozMacActiveSourceListSelection, MozMacTooltip, - /// Parsed for compat,...
1
0
4
131f91277d3614969359106dda699953aa5b6a79
Emilio Cobos Álvarez
2021-07-27T15:50:48
Bug 1722299 - Initial support for the color-scheme CSS property. r=mstange Add initial support for the color-scheme CSS property, allowing pages to choose between light and dark system colors per-element, and such. Things that are left to do so that this can be enabled by default: * Dark system colors on Windows / ...
diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs index f08abbc62..badcc3f20 100644 --- a/style/properties/longhands/inherited_ui.mako.rs +++ b/style/properties/longhands/inherited_ui.mako.rs @@ -95,6 +95,17 @@ ${helpers.predefined_type( has_effect_on_ge...
6
143
3
99583d35ebc65219877a3f8e7e6bb878fa4e8c30
Emilio Cobos Álvarez
2021-07-27T11:11:51
Bug 1720710 - Add system-ui boilerplate. r=jfkthame Alias -apple-system to it, and put it behind a pref for now. This is pretty boring (read: uncontroversial hopefully) code. The follow-up work is modifying StaticPresData to look up the fonts using system APIs, probably. Maybe a bit more work if on macOS they can't be...
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 85c0d060e..57f81ef6f 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -1032,6 +1032,7 @@ pub struct DefaultFontSizes { monospace: Length, cursive: Length, fantasy: Length, + system_ui: Length, } impl DefaultFontS...
4
29
21
1e63700e0af11fa73caee47a2706ca9f38d795d8
Emilio Cobos Álvarez
2021-07-27T06:59:39
Bug 1722400 - Remove layout.css.image-set.enabled. r=TYLin We shipped this in 88. Differential Revision: https://phabricator.services.mozilla.com/D120899
diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs index 1b770a07c..867c18ee4 100644 --- a/style/values/specified/image.rs +++ b/style/values/specified/image.rs @@ -81,16 +81,6 @@ fn cross_fade_enabled() -> bool { false } -#[cfg(feature = "gecko")] -fn image_set_enabled() -> bool { -...
1
3
17
8dcdaf5df1bf572b9dc1b76c250e86ed53f68fec
Emilio Cobos Álvarez
2021-07-24T21:10:44
Bug 1717873 - Factor PreferenceSheet colors to its own struct. r=morgan This will come handy in the next patch. Depends on D120678 Differential Revision: https://phabricator.services.mozilla.com/D120679
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 503eb1e07..6647076b1 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -89,7 +89,7 @@ impl Device { document, default_values: ComputedValues::default_values(doc), root_font...
2
9
9
46196dc1d0d52d8fbab708b7643a86e506917060
Emily McDonough
2021-07-23T18:11:16
Bug 1720554 Part 1 - Remove the paper size variant of GenericPageSize and add an implied default to the paper size and orientation variant. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D119915
diff --git a/style/values/computed/page.rs b/style/values/computed/page.rs index 524f6ba46..27b16d0af 100644 --- a/style/values/computed/page.rs +++ b/style/values/computed/page.rs @@ -36,16 +36,14 @@ impl ToComputedValue for specified::PageSize { fn to_computed_value(&self, ctx: &Context) -> Self::ComputedValue {...
3
19
18
f32a666d5cbb2b10d8296779c8380f582c259fe7
Emilio Cobos Álvarez
2021-07-23T07:43:59
Bug 1719963 - Better wallpaper for now. Differential Revision: https://phabricator.services.mozilla.com/D120699
diff --git a/style/gecko/data.rs b/style/gecko/data.rs index 39f7d7cc8..cc7db74c4 100644 --- a/style/gecko/data.rs +++ b/style/gecko/data.rs @@ -64,7 +64,10 @@ impl GeckoStyleSheet { /// bug 1719963 and can hopefully get a useful report from fuzzers. #[inline] pub fn hack_is_null(&self) -> bool { - ...
1
4
1
b7aefbc83cc9a71b0d0b4f95a3ac62c005bd670c
Sonia Singla
2021-07-22T08:04:47
Bug 1665638 - Remove layout.css.clip-path-path.enabled.r=emilio Differential Revision: https://phabricator.services.mozilla.com/D120235
diff --git a/style/values/specified/basic_shape.rs b/style/values/specified/basic_shape.rs index 37aaae2ec..3c571ff8e 100644 --- a/style/values/specified/basic_shape.rs +++ b/style/values/specified/basic_shape.rs @@ -55,15 +55,6 @@ pub type ShapeRadius = generic::ShapeRadius<NonNegativeLengthPercentage>; /// The speci...
1
2
13
d28bbdbeb3fb426b6c84e8c7f92605adf99919e9
Emilio Cobos Álvarez
2021-07-20T13:17:02
Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame Instead, fix up the various content data structures when the stylesheet is mutated. This makes reading a stylesheet not disable style sharing. Differential Revision: https://phabricator.services.mozilla.com/D115203
diff --git a/style/gecko/data.rs b/style/gecko/data.rs index 0689aa6c0..39f7d7cc8 100644 --- a/style/gecko/data.rs +++ b/style/gecko/data.rs @@ -56,10 +56,17 @@ impl GeckoStyleSheet { /// already holds a strong reference. #[inline] pub unsafe fn from_addrefed(s: *const DomStyleSheet) -> Self { - d...
2
15
2
22a0e0e2e8e2cf7c2bd9a0d2a97b2c419d394869
Sonia Singla
2021-07-19T09:20:14
Bug 1659266 - Remove layout.css.prefixes.columns. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D120057
diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs index 2d9a116d3..747a1c2db 100644 --- a/style/properties/longhands/column.mako.rs +++ b/style/properties/longhands/column.mako.rs @@ -13,7 +13,6 @@ ${helpers.predefined_type( engines="gecko servo-2013 servo-2020", ...
3
0
10
b7874c64822dfa053d416fc98e570f278e1422f3
Iulian Moraru
2021-07-16T13:02:09
Backed out changeset ff3b52062c5a (bug 1659266) for causing build bustages on WebIDLPrefs. CLOSED TREE
diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs index 747a1c2db..2d9a116d3 100644 --- a/style/properties/longhands/column.mako.rs +++ b/style/properties/longhands/column.mako.rs @@ -13,6 +13,7 @@ ${helpers.predefined_type( engines="gecko servo-2013 servo-2020", ...
1
7
0
f6300596f8db28493eceee1954822be270077184
Sonia Singla
2021-07-16T12:17:49
Bug 1659266 - Remove layout.css.prefixes.columns. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D120057
diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs index 2d9a116d3..747a1c2db 100644 --- a/style/properties/longhands/column.mako.rs +++ b/style/properties/longhands/column.mako.rs @@ -13,7 +13,6 @@ ${helpers.predefined_type( engines="gecko servo-2013 servo-2020", ...
1
0
7
1c674098a4d07b247bba00d67aab134d96be6164
Emilio Cobos Álvarez
2021-07-15T11:23:19
Bug 1717922 - Blockify outside markers at used value time rather than at computed value time. r=jfkthame Trusting the display value in style_adjuster is wrong, as some elements force a given kind of frame (like <details>). Differential Revision: https://phabricator.services.mozilla.com/D119609
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index 731494eeb..1d70240c0 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -232,9 +232,6 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { where E: TElement, { - #[cfg(any(feature = "servo-layout-2013", feature = "g...
1
0
13
29a8237eb42b98e9256f45a3f3b021657d69b522
Emilio Cobos Álvarez
2021-07-11T20:44:01
No bug - Fix mixed indentation in style_adjuster.rs. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D119579
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index 77d5cdf71..731494eeb 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -835,7 +835,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { let is_legacy_marker = self.style.pseudo.map_or(false, |p| p.is_marker()) && s...
1
1
1
37b5458b01edd93315358be3ff7a5d21557fb7f2
Emilio Cobos Álvarez
2021-07-09T15:22:59
Bug 1719824 - Inline GeckoNode::prev_sibling. r=smaug It's very hot when matching some kind of selectors like the ones in bug 1717267, and the two function calls show up in the profiles. Differential Revision: https://phabricator.services.mozilla.com/D119505
diff --git a/style/dom.rs b/style/dom.rs index 7ed6d4b33..4730315e1 100644 --- a/style/dom.rs +++ b/style/dom.rs @@ -152,7 +152,7 @@ pub trait TNode: Sized + Copy + Clone + Debug + NodeInfo + PartialEq { /// Get this node's first child. fn first_child(&self) -> Option<Self>; - /// Get this node's first c...
2
6
4
75c6670b5e640075cb2ad7543653454eecbe2ec7
Emilio Cobos Álvarez
2021-07-08T15:27:27
Bug 1718934 - Parse -webkit-focus-ring-color (computing to black). r=mstange,geckoview-reviewers,aklotz Some pages use this to hide the focus outline. On Blink it seems black, WebKit uses it to expose the OS accent color. Make it black, which is the default when the color isn't implemented on a given platform. Differ...
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index b2b1c0f12..eb7ae66b2 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -340,6 +340,10 @@ pub enum SystemColor { MozMacActiveSourceListSelection, MozMacTooltip, + /// Parsed for compat,...
1
4
0
c50d2201fbe95b37616fe9a50ee994f63e6d847b
Narcis Beleuzu
2021-07-07T21:37:51
Backed out changeset 66a484400799 (bug 1718934) for mochitest failures on test_value_computation.html . CLOSED TREE
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index eb7ae66b2..b2b1c0f12 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -340,10 +340,6 @@ pub enum SystemColor { MozMacActiveSourceListSelection, MozMacTooltip, - /// Parsed for compat,...
1
0
4
2408b37c96806d58aa859804036e035e885e3c34
Jonathan Kew
2021-07-07T11:58:40
Bug 1716841 - Update font-size-adjust keywords to match CSSWG resolution in csswg-drafts/#6288. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D118198
diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs index 02f91068d..a88df7be1 100644 --- a/style/values/generics/font.rs +++ b/style/values/generics/font.rs @@ -207,6 +207,7 @@ pub enum FontStyle<Angle> { /// /// https://www.w3.org/TR/css-fonts-4/#font-size-adjust-prop /// https://github.com/...
2
20
15
aa79c20a3fff947b2680108912bfa34d83737e69
Emilio Cobos Álvarez
2021-07-07T11:16:20
Bug 1718337 - More fine-grained viewport units invalidation. r=layout-reviewers,jfkthame This should speed up window resize significantly. Differential Revision: https://phabricator.services.mozilla.com/D118878
diff --git a/style/data.rs b/style/data.rs index 76d64956f..f486b24dc 100644 --- a/style/data.rs +++ b/style/data.rs @@ -175,6 +175,25 @@ impl ElementStyles { self.primary().get_box().clone_display().is_none() } + /// Whether this element uses viewport units. + pub fn uses_viewport_units(&self) ->...
6
88
1
89ba7c9e7b9f49979cf6a4a97244b0fdee383802
Emilio Cobos Álvarez
2021-07-07T08:31:54
Bug 1718281 - Reduce code size of shorthand serialization. r=layout-reviewers,AlaskanEmily Differential Revision: https://phabricator.services.mozilla.com/D118835
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 69a9fda81..0719f32b4 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -1201,7 +1201,7 @@ pub fn append_declaration_value<'a, 'b: 'a>( AppendableValue::Css(css) => de...
3
39
40
48db4e91682eba9e70609436717625f2a8c84723
Emilio Cobos Álvarez
2021-07-07T08:31:53
Bug 1718281 - Make get_shorthand_appendable_value less generic. r=layout-reviewers,AlaskanEmily This will allow to save some codesize from longhands_to_css. Differential Revision: https://phabricator.services.mozilla.com/D118834
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 05f2e0ba9..69a9fda81 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -386,7 +386,7 @@ impl PropertyDeclarationBlock { // Step 1.2.3 // We don't print !impo...
2
26
43
102e6625e8a2a920dfbbaf42ca22b574ee536b85
Matt Woodrow
2021-07-05T05:19:15
Bug 1717161 - Clamp perspective() values to a minimum of 1px. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D118250
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 621ae6008..a204ec2be 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1204,8 +1204,8 @@ impl ComputeSquaredDistance for ComputedTransformOperation { // FIXME(emilio): I...
2
4
11
49d0715363a319923c57bd73a566cbeefc8f4036
Makoto Kato
2021-06-29T01:17:23
Bug 1718510 - Add riscv64 define to hashglobe. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D118910
diff --git a/hashglobe/src/alloc.rs b/hashglobe/src/alloc.rs index b1c7a6eca..6c447107c 100644 --- a/hashglobe/src/alloc.rs +++ b/hashglobe/src/alloc.rs @@ -18,6 +18,7 @@ const MIN_ALIGN: usize = 8; target_arch = "x86_64", target_arch = "aarch64", target_arch = "mips64", + target_arch = "riscv64", ...
1
1
0
2d0bca81cac35a056b9cc2a639c42b8a20a6fc4a
Mats Palmgren
2021-06-23T02:52:42
Bug 1699964 - [css-content] Implement 'content: none' for elements. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D114130
diff --git a/style/values/resolved/counters.rs b/style/values/resolved/counters.rs index 3bb439a10..c00e63fda 100644 --- a/style/values/resolved/counters.rs +++ b/style/values/resolved/counters.rs @@ -23,20 +23,19 @@ impl ToResolvedValue for computed::Content { #[inline] fn to_resolved_value(self, context: ...
1
10
11
49cffafc73bce5470c90cbd7a612522e7b09f5d1
Mats Palmgren
2021-06-23T02:52:42
Bug 1605473 - Implement 'content: none' for ::marker. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D111707
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index b8f006b72..77d5cdf71 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -831,10 +831,11 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { fn adjust_for_marker_pseudo(&mut self) { use crate::values::computed::font::{FontFamil...
2
10
8
1c590b6528cf4fa3fa8d58d13fe3fb683c6a6f1c
Emily McDonough
2021-06-22T19:41:57
Bug 1647851 Part 1 - Use a computed type for page-size which converts paper sizes to a Size2D. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D115842
diff --git a/style/values/computed/page.rs b/style/values/computed/page.rs index d8ef03c1f..524f6ba46 100644 --- a/style/values/computed/page.rs +++ b/style/values/computed/page.rs @@ -5,10 +5,71 @@ //! Computed @page at-rule properties use crate::values::computed::length::NonNegativeLength; +use crate::values::com...
2
100
26
c97b3bce81529ec98fb7cca069f9b4bd437bfb7a
Butkovits Atila
2021-06-22T02:07:47
Backed out changeset b7e1a728dfd2 (bug 1717161) for causing failures at perspective-zero-2.html. CLOSED TREE
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index a204ec2be..621ae6008 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1204,8 +1204,8 @@ impl ComputeSquaredDistance for ComputedTransformOperation { // FIXME(emilio): I...
2
11
4
4dd049afd1d76c04186c4feb1aa6ec8b636f9efe
Emilio Cobos Álvarez
2021-06-18T19:35:50
Bug 1716045 - Unify font-family storage. r=mats,jfkthame This changes font-family storage to reuse the rust types, removing a bunch of code while at it. This allows us to, for example, use a single static font family for -moz-bullet and clone it, rather than creating a lot of expensive copies. Differential Revision: ...
diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs index a141aef4e..d8c0cea0f 100644 --- a/style/gecko_bindings/sugar/refptr.rs +++ b/style/gecko_bindings/sugar/refptr.rs @@ -308,11 +308,6 @@ impl_threadsafe_refcount!( bindings::Gecko_AddRefnsIURIArbitraryThread, bindings...
8
179
293
791eefbe153890062e8f834ef913b0e2d634b7fa
Emilio Cobos Álvarez
2021-06-16T09:48:14
Bug 1716535 - Remove nodrop dependency. r=glandium ManuallyDrop is just fine. Differential Revision: https://phabricator.services.mozilla.com/D117887
diff --git a/servo_arc/Cargo.toml b/servo_arc/Cargo.toml index f72654230..03b1004ba 100644 --- a/servo_arc/Cargo.toml +++ b/servo_arc/Cargo.toml @@ -15,6 +15,5 @@ gecko_refcount_logging = [] servo = ["serde"] [dependencies] -nodrop = { version = "0.1.8" } serde = { version = "1.0", optional = true } stable_deref_...
2
4
22
386291638f46b38fa55ee3686b6807dfde857377
Emilio Cobos Álvarez
2021-06-15T04:16:46
Bug 1715984 - Remove -moz-outline-radius. r=TYLin It does nothing since 88 and we unshipped it in 89. Differential Revision: https://phabricator.services.mozilla.com/D117532
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index a88aec3b6..0e9b17894 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -799,11 +799,8 @@ fn static_assert() { ${impl_simple_type_with_conversion("masonry_auto_flow", "mMasonryAutoFlow")} </%self:im...
4
2
72
1d548dccfffafe63a88ad67bec03a2438e82394e
Emilio Cobos Álvarez
2021-06-14T15:01:26
Bug 1715748 - Expose text selection foreground / background colors to chrome code. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D117417
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 275e28bda..b2b1c0f12 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -184,13 +184,13 @@ pub enum SystemColor { TextBackground, #[css(skip)] TextForeground, - #[css(skip)] + #[p...
1
13
7
8503aa74652728f604b9d164abe8e88230435d4c
Emilio Cobos Álvarez
2021-06-14T15:01:25
Bug 1715748 - Add an internal -moz-system-color() function to expose both light and dark system colors. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D117416
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 693cbd0c9..275e28bda 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -119,6 +119,20 @@ impl ToCss for ColorMix { } } +/// The color scheme for a specific system color. +#[cfg(feature = "gec...
1
52
7
bf32f6bf177425bfd4795df4fa8ebf3edd2459e9
Jonathan Kew
2021-06-14T12:32:36
Bug 1711479 - Implement CSS support for the optional adjustment-basis metric keywords for the font-size-adjust property (enabled on Nightly only for now). r=emilio Differential Revision: https://phabricator.services.mozilla.com/D115596
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 7a864c06d..a88aec3b6 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -1008,26 +1008,7 @@ fn static_assert() { ${impl_simple("font_variant_alternates", "mFont.variantAlternates")} - pub fn s...
5
98
99
b8859ec9183253a488adf45be708d5a83037ce45
Mats Palmgren
2021-06-14T01:22:06
Bug 1542807 part 3 - Add some style quirks for legacy ::markers created from list-style-type/list-style-image. r=emilio Specifically: For "bullets", i.e. 'list-style-type:disc|circle|square| disclosure-closed|disclosure-open', we use a built-in font (-moz-bullet-font, which has glyphs for those symbols + space) to re...
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 781f1a31f..f8fa6aa98 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -794,6 +794,34 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> { builder.add_flags(ComputedValueFlags::HAS_AUTHOR_SPECIFIED_PADDING); ...
7
128
1
6b68e43d2b91f42cf00457950d29fab7b7e45202
Butkovits Atila
2021-06-11T22:38:25
Backed out 7 changesets (bug 1542807) for causing failures at inert-retargeting-iframe.tentative.html. CLOSED TREE Backed out changeset e9ef32fa2f2e (bug 1542807) Backed out changeset 8fa0cb199975 (bug 1542807) Backed out changeset 38daf64afe59 (bug 1542807) Backed out changeset e3aee052c495 (bug 1542807) Backed out c...
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index f8fa6aa98..781f1a31f 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -794,34 +794,6 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> { builder.add_flags(ComputedValueFlags::HAS_AUTHOR_SPECIFIED_PADDING); ...
7
1
128
66dfa732bf93ef238e35244a3f16418980cb1ebd
Michelle Goossens
2021-06-11T18:14:26
Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley Differential Revision: https://phabricator.services.mozilla.com/D116903
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 683b51294..664a12f41 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -680,7 +680,7 @@ macro_rules! bool_pref_feature { /// to support new types in these entries and (2) ensuring that either /// nsPresCon...
1
1
2
21b9e2cd75118dd04fa3de8ccdee1ccfa737bd5a
Boris Chiou
2021-06-09T21:17:23
Bug 1340422 - Part 7: Notify style system when SMIL animation changes d attribute. r=emilio So we update d property in the style system as well. This makes sure we have the correct computed style and the correct rendering result. Differential Revision: https://phabricator.services.mozilla.com/D115570
diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs index 9f1c5c5e3..5e3edc2d6 100644 --- a/style/values/specified/svg_path.rs +++ b/style/values/specified/svg_path.rs @@ -60,6 +60,111 @@ impl SVGPathData { SVGPathData(crate::ArcSlice::from_iter(result.into_iter())) } + ...
1
115
0
bd6dc865d46295262967d26799940ce458599821
Nazım Can Altınova
2021-06-09T11:22:56
Bug 1690624 - Replace the old profiler thread registration FFIs with the new API in servo r=emilio Differential Revision: https://phabricator.services.mozilla.com/D116517
diff --git a/style/Cargo.toml b/style/Cargo.toml index e8d47ce73..10d61dbb2 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -80,6 +80,7 @@ uluru = "0.4" unicode-bidi = "0.3" unicode-segmentation = "1.0" void = "1.0.2" +gecko-profiler = { path = "../../../tools/profiler/rust-api" } [build-dependencies] la...
2
4
6
ae7ca54045d675330070d540e5a39d9d70b74104
Dorel Luca
2021-06-09T01:48:41
Backed out 3 changesets (bug 1714349) for Browser-chrome failures in browser/components/places/tests/browser/browser_addBookmarkForFrame.js. CLOSED TREE Backed out changeset 598f8e7d73ef (bug 1714349) Backed out changeset cc7365aacdbb (bug 1714349) Backed out changeset f0f942a93495 (bug 1714349)
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 664a12f41..683b51294 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -680,7 +680,7 @@ macro_rules! bool_pref_feature { /// to support new types in these entries and (2) ensuring that either /// nsPresCon...
1
2
1
e88c6f94becc6bf9bdafe701f1961b01c192b02e
Michelle Goossens
2021-06-08T22:45:51
Bug 1714349 - Fix build bustages. CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D117247
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 5b9407a7d..664a12f41 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -680,7 +680,7 @@ macro_rules! bool_pref_feature { /// to support new types in these entries and (2) ensuring that either /// nsPresCon...
1
1
1
260519878ae7252d5d474ba5e23f11e7dbd1e364
Michelle Goossens
2021-06-08T22:16:33
Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley Differential Revision: https://phabricator.services.mozilla.com/D116903
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 683b51294..5b9407a7d 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -927,6 +927,5 @@ pub static MEDIA_FEATURES: [MediaFeatureDescription; 61] = [ lnf_int_feature!(atom!("-moz-gtk-csd-reversed-placeme...
1
0
1
6438c07f43cc45fe8277e24cb8fe918a0cd017c4
Boris Chiou
2021-06-08T05:05:50
Bug 1312588 - Part 2: Support fit-content() in style. r=emilio Support fit-content for preferred size, min size, and max size. This patch only implement the style system. For layout part, we will do that in the following patches. Differential Revision: https://phabricator.services.mozilla.com/D107161
diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs index bcba3eb9b..3f8c04aba 100644 --- a/style/values/computed/length.rs +++ b/style/values/computed/length.rs @@ -188,7 +188,8 @@ impl Size { GenericSize::MinContent | GenericSize::MaxContent | GenericS...
3
34
1
3fadc156c6a77e4c079e3aa34b9a347ddca1fd0d
Michelle Goossens
2021-06-08T00:41:43
Bug 1714352 - Remove browser.proton.doorhangers.enabled pref r=emalysz Differential Revision: https://phabricator.services.mozilla.com/D117091
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 0c748e09f..683b51294 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -680,7 +680,7 @@ macro_rules! bool_pref_feature { /// to support new types in these entries and (2) ensuring that either /// nsPresCon...
1
1
2