commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
cfaa35d8c0df86164c1cb7e30be448c0b7f93c7a
Nick Fitzgerald
2021-09-28T22:14:42
Use `structopt` to derive CLI flags Instead of using `clap` directly
diff --git a/cranelift/isle/Cargo.lock b/cranelift/isle/Cargo.lock index f4bf43116..08c529adf 100644 --- a/cranelift/isle/Cargo.lock +++ b/cranelift/isle/Cargo.lock @@ -115,6 +115,15 @@ version = "0.25.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "f0a01e0497841a3b2db4f8afa483cce65f7e...
5
153
62
6ffb02d9f65d2938843f9adc18e86fe6eefcd26a
Nick Fitzgerald
2021-09-28T21:51:02
Use `miette` for reporting errors This gives us errors with annotated context like this: ``` Error: × type error: Unknown variable 'x' ╭─[isle_examples/let.isle:24:1] 24 │ (Lower (B.B z)) 25 │ (A.Add x y)) · ┬ · ╰── Unknown variable 'x' ╰──── ```
diff --git a/cranelift/isle/Cargo.lock b/cranelift/isle/Cargo.lock index b55178b6d..f4bf43116 100644 --- a/cranelift/isle/Cargo.lock +++ b/cranelift/isle/Cargo.lock @@ -2,6 +2,30 @@ # It is not intended for manual editing. version = 3 +[[package]] +name = "addr2line" +version = "0.16.0" +source = "registry+https://...
10
415
68
38da2cee3e173273d575c0db4e2048382b89ef33
Nick Fitzgerald
2021-09-28T20:09:24
Switch to using `thiserror`
diff --git a/cranelift/isle/Cargo.lock b/cranelift/isle/Cargo.lock index 63a6b3a94..b55178b6d 100644 --- a/cranelift/isle/Cargo.lock +++ b/cranelift/isle/Cargo.lock @@ -72,6 +72,7 @@ name = "isle" version = "0.1.0" dependencies = [ "log", + "thiserror", ] [[package]] @@ -99,12 +100,41 @@ dependencies = [ "cfg...
3
68
38
972dc00a9221fffdf77a7109ec4f990b3465a6c1
Nick Fitzgerald
2021-09-27T22:57:32
Don't use `&mut dyn Write` in codegen We always use a `String` which has infallible writing so we can remove all these `Result`s and pretend-fallible methods.
diff --git a/cranelift/isle/isle/src/codegen.rs b/cranelift/isle/isle/src/codegen.rs index f518fd12b..cc5dda999 100644 --- a/cranelift/isle/isle/src/codegen.rs +++ b/cranelift/isle/isle/src/codegen.rs @@ -1,8 +1,8 @@ //! Generate Rust code from a series of Sequences. use crate::ir::{lower_rule, ExprInst, ExprSequen...
2
120
115
3535f82056a5d0b033f6dd82920c11821a4ae156
Nick Fitzgerald
2021-09-27T21:53:38
Remove an unused field in `TermFunctionBuilder`
diff --git a/cranelift/isle/isle/src/codegen.rs b/cranelift/isle/isle/src/codegen.rs index 5a219a102..f518fd12b 100644 --- a/cranelift/isle/isle/src/codegen.rs +++ b/cranelift/isle/isle/src/codegen.rs @@ -423,14 +423,12 @@ impl TrieNode { /// the calling term). #[derive(Debug)] struct TermFunctionBuilder { - root...
1
2
4
5f5484ddbc985c858b4aaaa5021405ecc54940a5
Nick Fitzgerald
2021-09-27T21:38:12
Use `matches!(..)` to make `TrieNode::is_empty` more concise
diff --git a/cranelift/isle/isle/src/codegen.rs b/cranelift/isle/isle/src/codegen.rs index 96d0b4c02..5a219a102 100644 --- a/cranelift/isle/isle/src/codegen.rs +++ b/cranelift/isle/isle/src/codegen.rs @@ -234,10 +234,7 @@ enum TrieNode { impl TrieNode { fn is_empty(&self) -> bool { - match self { - ...
1
1
4
521010cc4f68be196d7dbe93882c7c6bf85606ad
Chris Fallin
2021-09-15T06:24:49
Split into isle and islec crates
diff --git a/cranelift/isle/Cargo.lock b/cranelift/isle/Cargo.lock index 26a438a64..63a6b3a94 100644 --- a/cranelift/isle/Cargo.lock +++ b/cranelift/isle/Cargo.lock @@ -70,17 +70,25 @@ dependencies = [ [[package]] name = "isle" version = "0.1.0" +dependencies = [ + "log", +] + +[[package]] +name = "islec" +version =...
14
42
13
e751f12ac5ba572867c95d34773c5e7f49e81e19
Chris Fallin
2021-09-15T05:55:08
Refactor to allow use as library, in order to allow build.rs usage.
diff --git a/cranelift/isle/src/main.rs b/cranelift/isle/src/bin/isle.rs similarity index 94% rename from cranelift/isle/src/main.rs rename to cranelift/isle/src/bin/isle.rs index 13c37a812..be99d7301 100644 --- a/cranelift/isle/src/main.rs +++ b/cranelift/isle/src/bin/isle.rs @@ -1,15 +1,6 @@ -#![allow(dead_code)] - ...
3
2
20
83672a88cc5cf7cdb4d5c889c6234ee8e0132b05
Chris Fallin
2021-09-10T08:27:09
bugfix to macro template generation: exclude Pos on ident from equality (broken by recent commit)
diff --git a/cranelift/isle/src/ast.rs b/cranelift/isle/src/ast.rs index bbfdc5969..9e6e06f6e 100644 --- a/cranelift/isle/src/ast.rs +++ b/cranelift/isle/src/ast.rs @@ -120,7 +120,7 @@ impl Pattern { } pub fn make_macro_template(&self, macro_args: &[Ident]) -> Pattern { - log::trace!("repplace_macro_...
1
3
2
2a574b1b42f5342677113a2c0cffb5d64c9e48ab
Chris Fallin
2021-09-10T06:56:28
Properly track locations on every AST node. Semantic errors are much more useful now. Also print parse errors in same (pseudo-standard compiler error) output format.
diff --git a/cranelift/isle/src/ast.rs b/cranelift/isle/src/ast.rs index 8f1cd820c..bbfdc5969 100644 --- a/cranelift/isle/src/ast.rs +++ b/cranelift/isle/src/ast.rs @@ -19,7 +19,7 @@ pub enum Def { /// An identifier -- a variable, term symbol, or type. #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)] -...
5
183
164
b46fa6acb0a1928e850c71442e95c06a93403b8e
Chris Fallin
2021-09-10T04:51:12
Remove old/no longer used `lower.rs`
diff --git a/cranelift/isle/src/lower.rs b/cranelift/isle/src/lower.rs deleted file mode 100644 index 52736d4f3..000000000 --- a/cranelift/isle/src/lower.rs +++ /dev/null @@ -1,33 +0,0 @@ -use crate::ir::*; -use crate::sema; - -struct LowerState<'a> { - tyenv: &'a sema::TypeEnv, - func: &'a sema::Func, - build...
1
0
33
5a8e35b253d41f11be4e6562642d954769f5b276
Chris Fallin
2021-09-10T01:12:46
Some fixes to the internal-extractor macro substitution
diff --git a/cranelift/isle/src/ast.rs b/cranelift/isle/src/ast.rs index a0d625848..8f1cd820c 100644 --- a/cranelift/isle/src/ast.rs +++ b/cranelift/isle/src/ast.rs @@ -99,6 +99,8 @@ pub enum Pattern { Wildcard, /// N sub-patterns that must all match. And { subpats: Vec<Pattern> }, + /// Internal use ...
2
120
67
d725ac13b2d1c51fbe234e223ba1f8bfa5c04da7
Chris Fallin
2021-09-06T00:53:55
Codegen: parameterize on a generated Context trait that contains external ctors/etors.
diff --git a/cranelift/isle/isle_examples/test_main.rs b/cranelift/isle/isle_examples/test_main.rs index 92cfdf2c0..5bec55a79 100644 --- a/cranelift/isle/isle_examples/test_main.rs +++ b/cranelift/isle/isle_examples/test_main.rs @@ -1,8 +1,12 @@ +mod test; -pub fn get_input<C>(ctx: &mut C, x: u32) -> Option<(test::A,...
2
110
11
7865191093383b727da54cf89c3bb8f9a1ab5c26
Chris Fallin
2021-09-05T17:41:15
Update long block comment describing priority trie in codegen.rs.
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index f15781e8b..65f3d2905 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -8,35 +8,34 @@ use std::fmt::Write; /// One "input symbol" for the decision tree that handles matching on /// a term. Each symbol re...
1
53
47
d7efd9f219a185c326d175e8dcf3920422ca0434
Chris Fallin
2021-09-05T03:03:21
Working extractor and constructor generation from rules!
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index 19c03a469..cfc4f5eb7 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -1,8 +1,8 @@ //! Generate Rust code from a series of Sequences. +use crate::error::Error; use crate::ir::{lower_rule, ExprInst, Expr...
2
137
137
8c727b175adc279dfd2c419f45551edc2286f59c
Chris Fallin
2021-09-04T21:23:47
more codegen WIP: start to generate functions
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index d503c8151..e97ef8b6c 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -2,7 +2,7 @@ use crate::error::Error; use crate::ir::{lower_rule, ExprSequence, PatternInst, PatternSequence}; -use crate::sema::{Ru...
1
98
8
638c9edd01c8c437509c7c56cd989c07e9a52718
Chris Fallin
2021-09-04T21:04:19
Support for file input and output, including multiple input files with proper position tracking.
diff --git a/cranelift/isle/Cargo.lock b/cranelift/isle/Cargo.lock index b890d9e54..f37ad0045 100644 --- a/cranelift/isle/Cargo.lock +++ b/cranelift/isle/Cargo.lock @@ -11,6 +11,15 @@ dependencies = [ "memchr", ] +[[package]] +name = "ansi_term" +version = "0.11.0" +source = "registry+https://github.com/rust-lang/...
8
255
90
e9a57d854dfcbef306c0fbe586f52dcc66306132
Chris Fallin
2021-09-04T19:59:19
Generate internal enum types.
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index e080f30a2..4a12c5d7c 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -2,8 +2,9 @@ use crate::error::Error; use crate::ir::{lower_rule, ExprSequence, PatternInst, PatternSequence}; -use crate::sema::{Ru...
3
63
10
5aa72bc060bff471a826c8ddf173b00d4fb5cfec
Chris Fallin
2021-09-04T19:45:42
skeleton for codegen
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index 4ffceb38c..e080f30a2 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -470,20 +470,48 @@ impl<'a> TermFunctionsBuilder<'a> { } } } + + fn finalize(self) -> (HashMap<TermId, Tri...
4
43
13
02ec77a45b4e3c8883d8ec9c820630d4544bb47b
Chris Fallin
2021-09-04T19:36:04
trie insertion
diff --git a/cranelift/isle/src/codegen.rs b/cranelift/isle/src/codegen.rs index b9c0c55e5..4ffceb38c 100644 --- a/cranelift/isle/src/codegen.rs +++ b/cranelift/isle/src/codegen.rs @@ -1,9 +1,9 @@ //! Generate Rust code from a series of Sequences. use crate::error::Error; -use crate::ir::{lower_rule, ExprSequence, ...
2
216
35
f2399c5384e4b78e854530c96a27cc044df103a3
Chris Fallin
2021-09-04T00:46:52
WIP -- more thinking about how to work priorities into FSM
diff --git a/cranelift/isle/src/ast.rs b/cranelift/isle/src/ast.rs index 97b7facff..53a0698d9 100644 --- a/cranelift/isle/src/ast.rs +++ b/cranelift/isle/src/ast.rs @@ -122,6 +122,8 @@ pub enum Extern { func: Ident, /// The position of this decl. pos: Pos, + /// Whether this extractor ...
4
93
4
f7543d3d10fee255a2cd7cbb999191168f55b4aa
Alex Crichton
2021-10-12T14:47:12
Update docs of `Module::serialize` (#3448) The docs hadn't been updated since `Module::deserialize` was added!
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index 3c8da4ac4..4d45669de 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -435,6 +435,10 @@ impl Module { /// [`Module::serialize`] and [`Engine::precompile_module`] back into an /// in-memory [`Modul...
1
12
3
b2d9faa4727ce8c719189d864e0fce09bf17c8cf
bjorn3
2021-10-12T13:10:54
Slightly simplify build script
diff --git a/cranelift/codegen/build.rs b/cranelift/codegen/build.rs index 10def102b..51fcf4cba 100644 --- a/cranelift/codegen/build.rs +++ b/cranelift/codegen/build.rs @@ -46,15 +46,7 @@ fn main() { isa_targets }; - let cur_dir = env::current_dir().expect("Can't access current working directory"); -...
1
2
9
b0b8c1edbfb03f3207fafc176aecfc8d90ff77e3
bjorn3
2021-10-12T13:07:49
Remove default_map
diff --git a/cranelift/codegen/meta/src/default_map.rs b/cranelift/codegen/meta/src/default_map.rs deleted file mode 100644 index 3a2be05da..000000000 --- a/cranelift/codegen/meta/src/default_map.rs +++ /dev/null @@ -1,20 +0,0 @@ -//! Trait for extending `HashMap` with `get_or_default`. -use std::collections::HashMap; ...
2
0
21
6b32fcfceade4c6d7248576ddde79e70c920716c
bjorn3
2021-10-12T13:05:45
Remove Constraint
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 5a7a1931a..110d5e660 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -4,7 +4,6 @@ use std::rc::Rc; use crate::cdsl::camel_case; use...
4
7
35
466a446f8cc3c7ebf90c900d0723cec1a33d2538
bjorn3
2021-10-12T12:58:34
Remove OpcodeNumber
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 42cf0e3af..5a7a1931a 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -1,5 +1,3 @@ -use cranelift_entity::{entity_impl, PrimaryMap}; -...
3
11
23
99114547be6270adbc8bd80998ab1ce93715c040
bjorn3
2021-10-12T12:54:39
Remove clobbers_all_regs
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 40491d9ce..42cf0e3af 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -86,8 +86,6 @@ pub(crate) struct InstructionContent { pub o...
2
0
12
e8b18b58a1b1606b94773252ca3caf7557429550
bjorn3
2021-10-12T12:53:33
Remove is_ghost
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 9db2bfba8..40491d9ce 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -76,8 +76,6 @@ pub(crate) struct InstructionContent { pub i...
3
4
26
807619a87405ab9b29329c13848a074a82c01082
Steve
2021-10-11T18:57:07
as requested: cargo fmt
diff --git a/crates/runtime/src/debug_builtins.rs b/crates/runtime/src/debug_builtins.rs index 39778fae7..411300008 100644 --- a/crates/runtime/src/debug_builtins.rs +++ b/crates/runtime/src/debug_builtins.rs @@ -14,11 +14,10 @@ pub unsafe extern "C" fn resolve_vmctx_memory(ptr: usize) -> *const u8 { "memory i...
1
1
2
8554d69e4bc1f4a591877b3e4f22155b0ab8f25b
Pat Hickey
2021-10-11T18:06:54
update userfaultfd to 0.4.1 (#3442) which updates nix to 0.23.0, getting rid of the benign RUSTSEC-2021-0119 in our dep tree
diff --git a/Cargo.lock b/Cargo.lock index c8fd80fb2..b3499921b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1653,15 +1653,15 @@ checksum = "0debeb9fcf88823ea64d64e4a815ab1643f33127d995978e099942ce38f25238" [[package]] name = "nix" -version = "0.17.0" +version = "0.23.0" source = "registry+https://github.com/rust-...
2
7
13
713ce07d35eb12729b648230512321ea93e0a908
Alex Crichton
2021-10-11T17:50:15
Add some debug logging for timing in module compiles (#3417) * Add some debug logging for timing in module compiles This is sometimes helpful when debugging slow compiles from fuzz bugs or similar. * Fix total duration calculation to not double-count
diff --git a/Cargo.lock b/Cargo.lock index 7fab29c6b..c8fd80fb2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3514,6 +3514,7 @@ dependencies = [ "cranelift-native", "cranelift-wasm", "gimli", + "log", "more-asserts", "object", "target-lexicon", diff --git a/cranelift/codegen/src/timing.rs b/cranelift/codegen...
4
13
0
a894594ae578a2628ceedd3860ea5c84ac926768
bjorn3
2021-10-10T13:23:39
Update parser
diff --git a/cranelift/reader/src/parser.rs b/cranelift/reader/src/parser.rs index 0f63a1c4f..46ac42495 100644 --- a/cranelift/reader/src/parser.rs +++ b/cranelift/reader/src/parser.rs @@ -251,7 +251,7 @@ impl Context { self.map.def_ss(ss, loc)?; while self.function.stack_slots.next_key().index() <= s...
2
10
18
20463d60f32224153f7758c26189fa9aded9110d
bjorn3
2021-10-10T12:57:35
Replace StackSlots struct with a type alias
diff --git a/cranelift/codegen/src/ir/stackslot.rs b/cranelift/codegen/src/ir/stackslot.rs index 64d643f43..4c30eb48b 100644 --- a/cranelift/codegen/src/ir/stackslot.rs +++ b/cranelift/codegen/src/ir/stackslot.rs @@ -3,11 +3,9 @@ //! The `StackSlotData` struct keeps track of a single stack slot in a function. //! -...
1
3
84
fd59a3e045718b6270155aae4beb077c824df2a2
bjorn3
2021-10-10T12:55:41
Remove all unused stackslot handling code
diff --git a/cranelift/codegen/src/ir/stackslot.rs b/cranelift/codegen/src/ir/stackslot.rs index 993fcc8ee..64d643f43 100644 --- a/cranelift/codegen/src/ir/stackslot.rs +++ b/cranelift/codegen/src/ir/stackslot.rs @@ -4,10 +4,7 @@ //! use crate::entity::{Iter, IterMut, Keys, PrimaryMap}; -use crate::ir::{StackSlot, ...
1
8
224
92a10d1ace70fe75c3e2c646ea613168fc417851
Steve
2021-10-11T08:08:14
Added resolve_vmctx_memory function to enable debuggers to resolve sandbox pointers - required because sandbox 'this' pointer cannot be resolved by lldb any other way as lldb expects "this" and "self" to be standard pointers, not sandbox handles.
diff --git a/crates/runtime/src/debug_builtins.rs b/crates/runtime/src/debug_builtins.rs index 187b6f918..39778fae7 100644 --- a/crates/runtime/src/debug_builtins.rs +++ b/crates/runtime/src/debug_builtins.rs @@ -6,6 +6,19 @@ use wasmtime_environ::{EntityRef, MemoryIndex}; static mut VMCTX_AND_MEMORY: (*mut VMContex...
1
14
0
54293a5929172956308f40db576c9b60e8abb7a1
bjorn3
2021-10-10T13:12:27
Remove predicates module It is dead code now
diff --git a/cranelift/codegen/src/lib.rs b/cranelift/codegen/src/lib.rs index 571017910..eca11115f 100644 --- a/cranelift/codegen/src/lib.rs +++ b/cranelift/codegen/src/lib.rs @@ -99,7 +99,6 @@ mod licm; mod log; mod machinst; mod nan_canonicalization; -mod predicates; mod remove_constant_phis; mod result; mod s...
2
0
141
fad3868c1d494bad3f03a3a39a88bb1ec33ef6e5
bjorn3
2021-10-10T13:08:45
Remove no longer existing passes from timing.rs
diff --git a/cranelift/codegen/src/timing.rs b/cranelift/codegen/src/timing.rs index d0c6580c0..ae8f8194f 100644 --- a/cranelift/codegen/src/timing.rs +++ b/cranelift/codegen/src/timing.rs @@ -57,7 +57,6 @@ define_passes! { loop_analysis: "Loop analysis", preopt: "Pre-legalization rewriting", dce: "Dead ...
1
0
10
f7ce91e174b87ca5bd586e663677ad69be2901fb
bjorn3
2021-10-10T13:06:15
Remove the CSSA verifier The old register allocator required CSSA as intermediate step. The new register allocator doesn't use SSA at all.
diff --git a/cranelift/codegen/src/timing.rs b/cranelift/codegen/src/timing.rs index d0c6580c0..3d81d51ad 100644 --- a/cranelift/codegen/src/timing.rs +++ b/cranelift/codegen/src/timing.rs @@ -46,9 +46,6 @@ define_passes! { wasm_translate_function: "Translate WASM function", verifier: "Verify Cranelift IR",...
4
0
664
355dd996a20c35f2395c5e855737cf4ed5e67479
bjorn3
2021-10-10T13:00:25
Fix tests
diff --git a/cranelift/codegen/src/ir/constant.rs b/cranelift/codegen/src/ir/constant.rs index 5d97cb818..8a319d7ac 100644 --- a/cranelift/codegen/src/ir/constant.rs +++ b/cranelift/codegen/src/ir/constant.rs @@ -337,22 +337,6 @@ mod tests { sut.get(a); // panics, only use constants returned by ConstantPool ...
1
0
16
aa0486eb15e018ec46f0295b40f28e29ccdcee86
bjorn3
2021-10-10T12:47:53
Remove offset fields from ConstantPool
diff --git a/cranelift/codegen/src/ir/constant.rs b/cranelift/codegen/src/ir/constant.rs index a9aa5d3a6..5d97cb818 100644 --- a/cranelift/codegen/src/ir/constant.rs +++ b/cranelift/codegen/src/ir/constant.rs @@ -167,38 +167,6 @@ impl FromStr for ConstantData { } } -/// This type describes an offset in bytes wi...
4
8
70
d78f436daf4660a4558c4c325451811fc5783c09
bjorn3
2021-10-10T12:43:49
Remove reloc_constant It is no longer used by the new backends
diff --git a/cranelift/codegen/src/binemit/memorysink.rs b/cranelift/codegen/src/binemit/memorysink.rs index fe473c4c2..dc86530b7 100644 --- a/cranelift/codegen/src/binemit/memorysink.rs +++ b/cranelift/codegen/src/binemit/memorysink.rs @@ -15,7 +15,7 @@ //! `CodeSink::put*` methods, so the performance impact of the v...
10
2
89
8a8797b91159c3c87dbdeeea2fc8f540be861995
bjorn3
2021-10-10T12:37:02
Remove the sarg_t type and dummy_sarg_t instruction They are no longer necessary with the new style backends
diff --git a/cranelift/codegen/meta/src/cdsl/types.rs b/cranelift/codegen/meta/src/cdsl/types.rs index 18657a2e2..708797a54 100644 --- a/cranelift/codegen/meta/src/cdsl/types.rs +++ b/cranelift/codegen/meta/src/cdsl/types.rs @@ -393,8 +393,6 @@ impl fmt::Debug for VectorType { #[derive(Clone, Copy, PartialEq, Eq, Hash...
8
3
56
eec3528254c1c657e66798e932267f282961839b
bjorn3
2021-10-10T12:32:18
Make ValueType::number unfailable
diff --git a/cranelift/codegen/meta/src/cdsl/types.rs b/cranelift/codegen/meta/src/cdsl/types.rs index 18657a2e2..1b767e025 100644 --- a/cranelift/codegen/meta/src/cdsl/types.rs +++ b/cranelift/codegen/meta/src/cdsl/types.rs @@ -71,12 +71,12 @@ impl ValueType { } /// Find the unique number associated with t...
2
15
26
2b89b13c574acc4c70d5a8506d49e44f8f824805
bjorn3
2021-10-10T12:23:26
Move condcodes from cranelift-codegen-shared to cranelift-codegen
diff --git a/cranelift/codegen/shared/src/lib.rs b/cranelift/codegen/shared/src/lib.rs index c031ee744..5af30f869 100644 --- a/cranelift/codegen/shared/src/lib.rs +++ b/cranelift/codegen/shared/src/lib.rs @@ -19,7 +19,6 @@ ) )] -pub mod condcodes; pub mod constant_hash; pub mod constants; diff --git a/crane...
5
5
6
ed5764c79fc108fc90e36a80b1c61e72535db752
bjorn3
2021-10-10T12:19:08
Fix cranelift-codegen benches
diff --git a/cranelift/codegen/benches/x64-evex-encoding.rs b/cranelift/codegen/benches/x64-evex-encoding.rs index e5c143418..550e88a0d 100644 --- a/cranelift/codegen/benches/x64-evex-encoding.rs +++ b/cranelift/codegen/benches/x64-evex-encoding.rs @@ -5,12 +5,9 @@ #[cfg(feature = "x86")] mod x86 { use cranelift...
1
2
85
a986cf2438303b12ba2bc7dbc59e79ef06427798
Anton Kirilov
2021-10-07T17:49:40
Increase the default code section alignment to 64 KB for AArch64 targets (#3424) Some platforms such as AArch64 Linux support different memory page sizes, so we need to be conservative when choosing the code section alignment (which is equal to the page size) by using the maximum. Copyright (c) 2021, Arm Limited.
diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index 1b6686cc7..b1ff09049 100644 --- a/cranelift/codegen/src/isa/mod.rs +++ b/cranelift/codegen/src/isa/mod.rs @@ -290,6 +290,9 @@ impl<'a> dyn TargetIsa + 'a { | OperatingSystem::Tvos, Architecture::Aarc...
2
5
1
319e1c6e16928d866dfb4ea21ff8ad5b8eb2ccce
Alex Crichton
2021-10-07T14:09:02
Enhance the publish script to be ideally run once (#3421) This commit improves our small publish script for Wasmtime with the goal of being able to run it on CI. This fixes a few issues with the current script such as: * If you rerun the script it won't try to republish crates already published. * Once a crat...
diff --git a/scripts/publish.rs b/scripts/publish.rs index 63887fb5c..30b3fe0c5 100644 --- a/scripts/publish.rs +++ b/scripts/publish.rs @@ -12,6 +12,8 @@ use std::env; use std::fs; use std::path::{Path, PathBuf}; use std::process::{Command, Stdio}; +use std::thread; +use std::time::Duration; // note that this li...
1
74
5
2db3b5b9df7601d4c46e67568831aa628debcf42
bjorn3
2021-10-07T13:54:00
Remove code offsets from Function (#3412) * Remove code offsets from Function * Remove reloc_jt and fix wasmtime-cranelift
diff --git a/cranelift/codegen/src/binemit/memorysink.rs b/cranelift/codegen/src/binemit/memorysink.rs index eb1d72e8e..fe473c4c2 100644 --- a/cranelift/codegen/src/binemit/memorysink.rs +++ b/cranelift/codegen/src/binemit/memorysink.rs @@ -15,7 +15,7 @@ //! `CodeSink::put*` methods, so the performance impact of the v...
13
6
155
91482f39d0ab29cab4939e5484701877693ba599
Alex Crichton
2021-10-05T14:12:11
Disable module linking in compilation fuzzer (#3416) Module linking is otherwise covered by other fuzzers and by enabling module linking it rejects more modules than necessary due to restrictions on import strings.
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index ce41fd141..bf7af0263 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -225,7 +225,9 @@ fn instantiate_with_dummy(store: &mut Store<StoreLimits>, module: &Module) -> Op pub fn compile(wasm: &[u8], strategy:...
1
3
1
a0f777b6777b6401a86fa3bc981d36883ee296ad
bjorn3
2021-10-04T17:40:58
Remove BranchRange
diff --git a/cranelift/codegen/src/isa/constraints.rs b/cranelift/codegen/src/isa/constraints.rs deleted file mode 100644 index 92ec94a24..000000000 --- a/cranelift/codegen/src/isa/constraints.rs +++ /dev/null @@ -1,66 +0,0 @@ -//! Register constraints for instruction operands. -//! -//! An encoding recipe specifies ho...
2
0
68
c5c75082894883126169e11d2ce8eee2bc8d86a7
bjorn3
2021-10-04T17:39:27
Remove StackLayoutInfo
diff --git a/cranelift/codegen/src/ir/mod.rs b/cranelift/codegen/src/ir/mod.rs index d97d23c44..d0836fc74 100644 --- a/cranelift/codegen/src/ir/mod.rs +++ b/cranelift/codegen/src/ir/mod.rs @@ -52,7 +52,7 @@ pub use crate::ir::libcall::{get_probestack_funcref, LibCall}; pub use crate::ir::memflags::{Endianness, MemFlag...
4
1
119
b3702f5821251b4aca473e3095a3faf158262486
bjorn3
2021-10-04T17:39:00
Remove old_signature
diff --git a/cranelift/codegen/src/ir/function.rs b/cranelift/codegen/src/ir/function.rs index 5ccca1fe5..b4258b495 100644 --- a/cranelift/codegen/src/ir/function.rs +++ b/cranelift/codegen/src/ir/function.rs @@ -79,10 +79,6 @@ pub struct Function { /// Signature of this function. pub signature: Signature, ...
1
0
5
772176dbfb0132221ed23611e559eb22b1b440cb
Benjamin Bouvier
2021-10-04T08:12:57
Cranelift: remove unused EncCursor
diff --git a/cranelift/codegen/src/context.rs b/cranelift/codegen/src/context.rs index 48503952e..f7cfb8c0c 100644 --- a/cranelift/codegen/src/context.rs +++ b/cranelift/codegen/src/context.rs @@ -347,7 +347,6 @@ impl Context { /// Perform LICM on the function. pub fn licm(&mut self, isa: &dyn TargetIsa) -> C...
3
3
139
5b3b459ad51c3dd5947eb19830350796f7ecb118
Alex Crichton
2021-10-01T19:26:30
Fix some nightly dead code warnings (#3404) * Fix some nightly dead code warnings Looks like the "struct field not used" lint has improved on nightly and caught a few more instances of fields that were never actually read. * Fix windows
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index a2d2f570f..9db2bfba8 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -35,7 +35,6 @@ impl<'all_inst> InstructionGroupBuilder<'all_inst...
3
10
10
25d3fa4d7b944b4341928a401c57feaaa0ce3c35
Alex Crichton
2021-09-30T18:09:19
Remove spec interpreter fuzz target temporarily (#3399) This commit removes the `differential_spec` fuzz target for now, although this removal is intended to be temporary. We have #3251 to track re-enabling the spec interpreter in a way that it won't time out, and additionally the spec interpreter is also failing t...
diff --git a/crates/fuzzing/Cargo.toml b/crates/fuzzing/Cargo.toml index 4e6a0ca74..fcdcfac48 100644 --- a/crates/fuzzing/Cargo.toml +++ b/crates/fuzzing/Cargo.toml @@ -32,7 +32,8 @@ rusty_v8 = "0.27" [dev-dependencies] wat = "1.0.37" +# FIXME(#3251) should re-enable once spec interpreter won't time out # We only ...
4
6
41
d590e6bc1f2dc7f15fa38e7a258f7d8ddb420b55
bjorn3
2021-09-29T17:12:51
Remove x86 old-backend special case from cranelift-codegen-meta
diff --git a/cranelift/codegen/build.rs b/cranelift/codegen/build.rs index dd6cfc999..10def102b 100644 --- a/cranelift/codegen/build.rs +++ b/cranelift/codegen/build.rs @@ -27,15 +27,6 @@ fn main() { let out_dir = env::var("OUT_DIR").expect("The OUT_DIR environment variable must be set"); let target_triple = ...
3
7
55
eb01ba1ed179af1f5b3b0aea06f86b135059630d
bjorn3
2021-09-29T17:06:12
Flatten directory structure for cranelift_codegen_meta::isa
diff --git a/cranelift/codegen/meta/src/isa/arm32/mod.rs b/cranelift/codegen/meta/src/isa/arm32.rs similarity index 100% rename from cranelift/codegen/meta/src/isa/arm32/mod.rs rename to cranelift/codegen/meta/src/isa/arm32.rs diff --git a/cranelift/codegen/meta/src/isa/arm64/mod.rs b/cranelift/codegen/meta/src/isa/arm...
6
11
13
551f1c3a14e7568d368b7a1a5b7720ddad56375a
bjorn3
2021-09-29T17:00:12
Remove BindParameter and Bindable
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 72979f935..a2d2f570f 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -1,18 +1,14 @@ use cranelift_entity::{entity_impl, PrimaryMap};...
1
0
214
e5ebef1b94345c005b8a119a26bcf19752efc81f
Dan Gohman
2021-09-30T15:14:13
Use `empty()` instead of `NONE` with rsix flags types. `empty()` is provided by all `bitflags` types, so it's more idiomatic than having `NONE` values.
diff --git a/crates/fiber/src/unix.rs b/crates/fiber/src/unix.rs index d8fbff725..e5f61e613 100644 --- a/crates/fiber/src/unix.rs +++ b/crates/fiber/src/unix.rs @@ -60,7 +60,7 @@ impl FiberStack { let mmap = rsix::io::mmap_anonymous( ptr::null_mut(), mmap_len, - ...
6
11
6
49767c73791ba0b35369edbc3028bfd1396e2abd
Alex Crichton
2021-09-30T14:09:12
Validate functions in parallel in `Module::validate` (#3394) We already validate wasm functions in parallel when compiling a module, but the same parallelism wasn't available to the `Module::validate` API. This commit peforms a minor tweak to the validate-the-whole-module API to validate all functions in parallel i...
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index eec7533a8..3c8da4ac4 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -8,7 +8,7 @@ use std::fs; use std::mem; use std::path::Path; use std::sync::Arc; -use wasmparser::Validator; +use wasmparser::{Parser...
1
10
2
fa108d9a86827a28c7bfb8ff98033734b2a5fd33
Dan Gohman
2021-09-30T13:11:29
Remove the rsix dependency in cranelift-native. (#3395) Revert the part of 47490b4383bf48cbde8b1c33301a7f7d326ee7cc which changed cranelift-native to use rsix. It's just one call, and this lets Cranelift users that don't otherwise depend on rsix to avoid it.
diff --git a/Cargo.lock b/Cargo.lock index a2e80da3e..6823f1b33 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -696,7 +696,7 @@ name = "cranelift-native" version = "0.77.0" dependencies = [ "cranelift-codegen", - "rsix", + "libc", "target-lexicon", ] diff --git a/cranelift/native/Cargo.toml b/cranelift/native/Car...
3
5
5
463a88e002251d4ba032f925a4be9420edb877a3
bjorn3
2021-09-29T20:37:45
Rename lookup_variant to lookup
diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index 069324f04..8de000409 100644 --- a/cranelift/codegen/src/isa/mod.rs +++ b/cranelift/codegen/src/isa/mod.rs @@ -111,9 +111,9 @@ macro_rules! isa_builder { }}; } -/// Look for an ISA for the given `triple`, selecting the backend...
3
5
11
3fae9e5fa9c62a6d28f40eb79b879c6e876c6106
bjorn3
2021-09-29T16:43:04
Remove outdated tests from cranelift-codegen-meta
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index ba9aeebad..72979f935 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -719,13 +719,6 @@ mod test { inst.bind(LaneType::Int(I3...
1
0
17
a2040542ce1e331d43e3f58bd57322906f411625
bjorn3
2021-09-29T16:24:24
Remove unused fields
diff --git a/cranelift/codegen/meta/src/shared/mod.rs b/cranelift/codegen/meta/src/shared/mod.rs index 521e058ec..549ae7cf9 100644 --- a/cranelift/codegen/meta/src/shared/mod.rs +++ b/cranelift/codegen/meta/src/shared/mod.rs @@ -22,9 +22,6 @@ use std::rc::Rc; pub(crate) struct Definitions { pub settings: SettingG...
1
0
6
9e5201d88f8823514170942e17255a5d90a359df
bjorn3
2021-06-21T11:11:28
Fix all dead-code warnings in cranelift-codegen
diff --git a/cranelift/codegen/src/abi.rs b/cranelift/codegen/src/abi.rs index 883ec546e..29fdbf4c8 100644 --- a/cranelift/codegen/src/abi.rs +++ b/cranelift/codegen/src/abi.rs @@ -4,8 +4,6 @@ //! `TargetIsa::legalize_signature()` method. use crate::ir::{AbiParam, ArgumentExtension, ArgumentLoc, Type}; -use alloc::...
7
2
948
3e4167ba956f15f70b3075e2536c0954d36cc383
bjorn3
2021-06-21T10:57:37
Remove registers from cranelift-codegen-meta
diff --git a/cranelift/codegen/meta/src/cdsl/isa.rs b/cranelift/codegen/meta/src/cdsl/isa.rs index 7eb7c3051..b595ffa99 100644 --- a/cranelift/codegen/meta/src/cdsl/isa.rs +++ b/cranelift/codegen/meta/src/cdsl/isa.rs @@ -1,18 +1,12 @@ -use crate::cdsl::regs::IsaRegs; use crate::cdsl::settings::SettingGroup; pub(cra...
9
6
573
d8818c967ecbad7ba92882d64151c209c70a2aa9
bjorn3
2021-06-21T10:06:24
Fix all dead-code warnings in cranelift-codegen-meta
diff --git a/cranelift/codegen/meta/src/cdsl/ast.rs b/cranelift/codegen/meta/src/cdsl/ast.rs index 6bfd1721a..f4f2afe27 100644 --- a/cranelift/codegen/meta/src/cdsl/ast.rs +++ b/cranelift/codegen/meta/src/cdsl/ast.rs @@ -456,7 +456,7 @@ impl Apply { // Apply should only operate on concrete value types, not "an...
10
14
748
98831fe4e246f7ea00ce10d337cef285841c5e17
Alex Crichton
2021-09-24T20:07:16
Update zeroize_derive to fix a rustsec warning (#3389) Should hopefully appease CI
diff --git a/Cargo.lock b/Cargo.lock index 5e791a4ce..6d7b99926 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4094,9 +4094,9 @@ dependencies = [ [[package]] name = "zeroize_derive" -version = "1.1.0" +version = "1.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a2c1e130bebaeab2f23...
1
2
2
476d0bee960b77e0bc9f50621952e6eb23639272
Alex Crichton
2021-09-23T15:48:11
Allow another trap mismatch with v8 If Wasmtime thinks a module stack-overflows and v8 says that it does something else that's ok. This means that the limits on v8 and Wasmtime are different which is expected and not something we want fuzz-bugs about.
diff --git a/crates/fuzzing/src/oracles/v8.rs b/crates/fuzzing/src/oracles/v8.rs index ff16757c0..4016b1ffd 100644 --- a/crates/fuzzing/src/oracles/v8.rs +++ b/crates/fuzzing/src/oracles/v8.rs @@ -287,7 +287,18 @@ fn assert_error_matches(wasmtime: &anyhow::Error, v8: &str) { TrapCode::IntegerDivisionByZero...
1
12
1
5cdaf3d08516a773f1099288ade5398aebdba848
Alex Crichton
2021-09-22T14:12:33
Disable simd in the instantiate-swarm target Something I forgot from #3376
diff --git a/fuzz/fuzz_targets/instantiate-swarm.rs b/fuzz/fuzz_targets/instantiate-swarm.rs index 676d6f780..0ebc70858 100644 --- a/fuzz/fuzz_targets/instantiate-swarm.rs +++ b/fuzz/fuzz_targets/instantiate-swarm.rs @@ -25,7 +25,6 @@ fn run(data: &[u8]) -> Result<()> { // that aren't otherwise enabled by default....
1
0
2
1a5a2c7c5d43cfdf0c5086e83e3254ade7800e51
Alex Crichton
2021-09-21T20:30:07
Fix a merge conflict on `main` (#3378) This commit fixes a "merge conflict" with #3319 being merged into `main`, causing CI failures on merge.
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index abadbdb34..942c6ed42 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -766,8 +766,9 @@ impl Func { bail!("cross-`Store` values are not currently supported"); } } + let ...
1
4
2
38463d11ed19b0bce27010c518787737c74cebeb
Alex Crichton
2021-09-21T18:05:31
Load generated trampolines into jitdump when profiling (#3344) * Load generated trampolines into jitdump when profiling This commit updates the jitdump profiler to generate JIT profiling records for generated trampolines in a wasm module in addition to the functions already in a module. It's also updated to learn...
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index ef499ad44..ebe823b51 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -397,13 +397,17 @@ impl CompiledModule { } /// Returns the per-signature trampolines for this module. - pub fn trampoline...
8
76
10
fc6328ae069f091a8cd53702d1f9876045d564e6
Alex Crichton
2021-09-20T19:17:19
Temporarily disable SIMD fuzzing on CI (#3376) We've got a large crop of fuzz-bugs from fuzzing with enabled-with-SIMD on oss-fuzz but at this point the fuzz stats from oss-fuzz say that the fuzzers like v8 are spending less than 50% of its time actually fuzzing and presumably mostly hitting crashes and such. While...
diff --git a/crates/fuzzing/src/generators.rs b/crates/fuzzing/src/generators.rs index 361298ca3..242a5bc3b 100644 --- a/crates/fuzzing/src/generators.rs +++ b/crates/fuzzing/src/generators.rs @@ -142,12 +142,6 @@ impl wasm_smith::Config for WasmtimeDefaultConfig { 4 } - // Turn some wasm features de...
3
1
8
8abb19cbd81a0f4562e3de2ed1e668f734879bce
dheaton-arm
2021-09-20T09:31:34
Generate `new_vec` using an iterator chain Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 515708433..4efc5b88d 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -850,14 +850,19 @@ where let new_type = ctrl_ty.merge_lanes().unwrap(); let arg0 = extractlane...
1
13
8
3fc29f5f6c9e6c41c4c85ecc16dab0ddf808d6d7
dheaton-arm
2021-09-20T08:57:19
Return `u128` from `bounds`; form `new_vec` from iter chain Copyright (c) 2021, Arm Limited
diff --git a/cranelift/codegen/src/ir/types.rs b/cranelift/codegen/src/ir/types.rs index 2d9c7e709..709c5bb08 100644 --- a/cranelift/codegen/src/ir/types.rs +++ b/cranelift/codegen/src/ir/types.rs @@ -80,23 +80,24 @@ impl Type { } /// Get the (minimum, maximum) values represented by each lane in the type. -...
2
22
17
3a4ebd772700deb77e5da2fa310e10203ba4ec9d
Afonso Bordado
2021-09-19T14:00:41
cranelift: Deduplicate match_imm functions Transforming this into a generic function is proving to be a challenge since most of the necessary methods are not in a trait. We also need to cast between the signed and unsigned types, which is difficult to do in a generic function. This can be solved for example by adding...
diff --git a/cranelift/reader/src/parser.rs b/cranelift/reader/src/parser.rs index a0e5a35e3..a8f20230f 100644 --- a/cranelift/reader/src/parser.rs +++ b/cranelift/reader/src/parser.rs @@ -31,6 +31,51 @@ use std::str::FromStr; use std::{u16, u32}; use target_lexicon::Triple; +macro_rules! match_imm { + ($signed:...
1
50
157
8115e7252d27ba67a128bdca529d50ba8490e70d
Afonso Bordado
2021-09-14T14:21:37
cranelift: Add support for i128 immediates in parser
diff --git a/cranelift/codegen/src/data_value.rs b/cranelift/codegen/src/data_value.rs index 965ce1bec..13aa23767 100644 --- a/cranelift/codegen/src/data_value.rs +++ b/cranelift/codegen/src/data_value.rs @@ -86,6 +86,7 @@ impl DataValue { DataValue::I16(i) => dst[..2].copy_from_slice(&i.to_ne_bytes()[..])...
2
51
0
e17d9cfbab7378c60026e264f37ad2afd2ad4f52
Afonso Bordado
2021-09-17T21:17:54
cranelift: Rename `icmp` type variable
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 187819aa6..331ebc02b 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -983,7 +983,7 @@ pub enum CraneliftTrap { } /// Compare two values using the given integer condition `code`. -fn icm...
1
4
4
853b986b229d694dda0f584d8264a5eaa77f4d7c
Alex Crichton
2021-09-17T20:47:47
Move `custom_limiter_detect_os_oom_failure` to its own test (#3366) This test uses `rlimit` which can't be executed in parallel with other tests. Previously this used `libc::fork` but the call afterwards to `libc::wait` was racing all other child subprocesses since it would wait for any child instead of the specifi...
diff --git a/tests/all/limits.rs b/tests/all/limits.rs index 14c070411..c6490c05a 100644 --- a/tests/all/limits.rs +++ b/tests/all/limits.rs @@ -464,91 +464,3 @@ fn custom_limiter_detect_grow_failure() -> Result<()> { Ok(()) } - -// This test only works on Linux. It may be portable to MacOS as well, -// but the...
2
94
88
0d3153c16bba2d72776e020ea8b7fcc723e893ff
Nick Fitzgerald
2021-09-17T18:06:14
Fix a warning about unnecessary `mut` in `AutoAssertNoGc`
diff --git a/crates/wasmtime/src/store.rs b/crates/wasmtime/src/store.rs index 325c30e20..015eb29c5 100644 --- a/crates/wasmtime/src/store.rs +++ b/crates/wasmtime/src/store.rs @@ -305,6 +305,7 @@ where T: std::ops::DerefMut<Target = StoreOpaque>, { pub fn new(mut store: T) -> Self { + drop(&mut store...
1
1
0
b32130d0aaede9bc6cc1392c41a9c41a2e26f788
Nick Fitzgerald
2021-09-17T18:04:33
Fix table_ops fuzz generator test's expected results
diff --git a/crates/fuzzing/src/generators/table_ops.rs b/crates/fuzzing/src/generators/table_ops.rs index 73e8905ea..0bf3e9ce5 100644 --- a/crates/fuzzing/src/generators/table_ops.rs +++ b/crates/fuzzing/src/generators/table_ops.rs @@ -266,7 +266,7 @@ mod tests { let expected = r#" (module - (type (;0;) (...
1
6
9
72f38617cae37481dbbdeef3211bb89950bdca9d
Nick Fitzgerald
2021-09-17T18:01:31
Fix links between docs
diff --git a/crates/wasmtime/src/linker.rs b/crates/wasmtime/src/linker.rs index 80dcca9ed..c3d8940c3 100644 --- a/crates/wasmtime/src/linker.rs +++ b/crates/wasmtime/src/linker.rs @@ -161,9 +161,9 @@ impl<T> Linker<T> { /// Creates a new [`Linker`]. /// /// The linker will define functions within the co...
1
6
6
f851684ebca68c45c7b57fd2e968e059e62c202f
Chris Fallin
2021-09-17T18:02:12
Ignore failing test on old-backend builds.
diff --git a/tests/all/gc.rs b/tests/all/gc.rs index 0ba46525f..8092613eb 100644 --- a/tests/all/gc.rs +++ b/tests/all/gc.rs @@ -426,6 +426,7 @@ fn global_init_no_leak() -> anyhow::Result<()> { } #[test] +#[cfg(not(feature = "old-x86-backend"))] fn no_gc_middle_of_args() -> anyhow::Result<()> { let (mut store...
1
1
0
833c93b25c293c1769704e6d3fefb4b99badab45
Nick Fitzgerald
2021-09-17T17:31:13
use public accessors, not private fields for `WasmFuncType` params/returns
diff --git a/crates/wasmtime/src/types/matching.rs b/crates/wasmtime/src/types/matching.rs index ba4bbcdb2..d422acc1a 100644 --- a/crates/wasmtime/src/types/matching.rs +++ b/crates/wasmtime/src/types/matching.rs @@ -117,13 +117,13 @@ impl MatchCx<'_> { let render = |ty: &WasmFuncType| { let par...
1
2
2
e56312e61a71f90c3d7fe9edbe817ec9a7584f4f
Dan Gohman
2021-09-16T17:43:36
Add "cargo:rerun-if-changed=build.rs" to some build.rs files. Add "cargo:rerun-if-changed=build.rs" in some build.rs files to tell cargo that it doesn't need to scan the whole package. See the [Cargo docs] for more info. [Cargo docs]: https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed
diff --git a/crates/misc/run-examples/build.rs b/crates/misc/run-examples/build.rs index 81caa36d6..a2c6171e4 100644 --- a/crates/misc/run-examples/build.rs +++ b/crates/misc/run-examples/build.rs @@ -3,4 +3,5 @@ fn main() { "cargo:rustc-env=TARGET={}", std::env::var("TARGET").unwrap() ); + pr...
2
3
0
a8aec2e0e64abce8182a232870d987a027e015f7
Anton Kirilov
2021-09-13T10:40:01
Cranelift AArch64: Avoid invalid encodings for some vector instructions Copyright (c) 2021, Arm Limited.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/emit.rs b/cranelift/codegen/src/isa/aarch64/inst/emit.rs index 74ec299be..b0122cbd7 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/emit.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/emit.rs @@ -1674,15 +1674,27 @@ impl MachInstEmit for Inst { ...
4
205
20
00d65eccafc1cd03f5ffc5bc550e3c0cb7c92352
Pat Hickey
2021-09-15T23:19:51
does this one hang on qemu too? idk
diff --git a/tests/all/limits.rs b/tests/all/limits.rs index 2c65266d4..14c070411 100644 --- a/tests/all/limits.rs +++ b/tests/all/limits.rs @@ -413,6 +413,9 @@ impl ResourceLimiter for MemoryGrowFailureDetector { #[test] fn custom_limiter_detect_grow_failure() -> Result<()> { + if std::env::var("WASMTIME_TEST_N...
1
3
0
12be7cd720eee776d33c52691896a1d5e388b56a
Pat Hickey
2021-09-15T22:50:35
skip the detect_os_oom_failure test on qemu ci
diff --git a/tests/all/limits.rs b/tests/all/limits.rs index 2849325ed..2c65266d4 100644 --- a/tests/all/limits.rs +++ b/tests/all/limits.rs @@ -462,9 +462,15 @@ fn custom_limiter_detect_grow_failure() -> Result<()> { Ok(()) } +// This test only works on Linux. It may be portable to MacOS as well, +// but the o...
1
6
0
27083e72e3ffdc5dd45282a59a296dbf8aa57931
Pat Hickey
2021-09-15T20:45:24
fix warning
diff --git a/tests/all/limits.rs b/tests/all/limits.rs index 3e276d8c8..2849325ed 100644 --- a/tests/all/limits.rs +++ b/tests/all/limits.rs @@ -1,4 +1,4 @@ -use anyhow::{bail, Result}; +use anyhow::Result; use wasmtime::*; const WASM_PAGE_SIZE: usize = wasmtime_environ::WASM_PAGE_SIZE as usize; @@ -536,10 +536,10 ...
1
3
3
bb7f58d9362c9edf30e427560a6346306fe9cb33
Pat Hickey
2021-09-14T18:24:11
add a hook to ResourceLimiter to detect memory grow failure. * allow the ResourceLimiter to reject a memory grow before the memory's own maximum. * add a hook so a ResourceLimiter can detect any reason that a memory grow fails, including if the OS denies additional memory * add tests for this new functionality. I only...
diff --git a/crates/runtime/src/instance.rs b/crates/runtime/src/instance.rs index 08a6ff2c3..f69b17a8a 100644 --- a/crates/runtime/src/instance.rs +++ b/crates/runtime/src/instance.rs @@ -12,6 +12,7 @@ use crate::vmcontext::{ VMInterrupts, VMMemoryDefinition, VMMemoryImport, VMTableDefinition, VMTableImport, }; ...
6
248
46
7da76f06017820554710c848812e9ac462d775e4
Sam Parker
2021-09-14T14:05:40
cargo fmt
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index f97cd75ef..d95a92cf9 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -794,8 +794,8 @@ pub enum Inst { }, /// An atomic read-modif...
2
4
6
d2ce1ac753afc059e32798bac3383b81a6d04456
Nick Fitzgerald
2021-08-31T21:06:02
Fix a use-after-free bug when passing `ExternRef`s to Wasm We _must not_ trigger a GC when moving refs from host code into Wasm (e.g. returned from a host function or passed as arguments to a Wasm function). After insertion into the table, this reference is no longer rooted. If multiple references are being sent from ...
diff --git a/cranelift/wasm/src/environ/dummy.rs b/cranelift/wasm/src/environ/dummy.rs index 0974d6866..7b3af0c89 100644 --- a/cranelift/wasm/src/environ/dummy.rs +++ b/cranelift/wasm/src/environ/dummy.rs @@ -688,8 +688,8 @@ impl<'data> ModuleEnvironment<'data> for DummyEnvironment { WasmType::FuncRef ...
14
665
106
eb4089e21206875bc528f336d3fbb9b70cae2ed1
Alex Crichton
2021-09-14T21:09:14
Fix a typo
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index 40af01f70..935d6a854 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1951,7 +1951,7 @@ impl HostFunc { unsafe fn register_trampoline(&self, store: &mut StoreOpaque) { // This assert is required to e...
1
1
1
b759514124c7819c0bc0052a4451a2581333a1b7
Alex Crichton
2021-09-14T15:40:24
Allow wasmtime/v8 to differ on errors slightly (#3348) I'm not sure why when run repeatedly v8 has different limits on call-stack-size but it's not particularly interesting to assert exact matches here, so this should fix a fuzz-bug-failure found on oss-fuzz.
diff --git a/crates/fuzzing/src/oracles/v8.rs b/crates/fuzzing/src/oracles/v8.rs index 59da9d374..0e66c38cb 100644 --- a/crates/fuzzing/src/oracles/v8.rs +++ b/crates/fuzzing/src/oracles/v8.rs @@ -267,7 +267,21 @@ fn assert_error_matches(wasmtime: &anyhow::Error, v8: &str) { "data segment is out of...
1
15
1
99cc95d6302b7069c4cc76150e80035cb6fb5e8e
dheaton-arm
2021-09-14T12:08:35
Factor out shared logic for widening ops. Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 78b56dba9..d01d625b5 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -840,40 +840,29 @@ where V::bool(true, types::B1)?, |acc, lane| acc.and(lane), )?), -...
1
22
33
a595bd22e37c509f00a20c313d536fa1b14fc2a5
dheaton-arm
2021-09-09T09:34:29
Replace loops with iterator methods. Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 4a013868e..78b56dba9 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -842,24 +842,20 @@ where )?), Opcode::SwidenLow => { let new_type = ctrl_ty.merge_lanes()...
1
10
14
4d4779b56311e7405c113d94241a3991857ef703
Alex Crichton
2021-09-13T20:30:46
Restore running precompiled modules with the CLI (#3343) * Restore running precompiled modules with the CLI This was accidentally broken when `Module::deserialize` was split out of `Module::new` long ago, so this adds the detection in the CLI to call the appropriate method to load the module. This feature is gate...
diff --git a/src/commands/run.rs b/src/commands/run.rs index bbcf252a7..ab01807cc 100644 --- a/src/commands/run.rs +++ b/src/commands/run.rs @@ -2,11 +2,13 @@ use crate::{CommonOptions, WasiModules}; use anyhow::{anyhow, bail, Context as _, Result}; +use std::fs::File; +use std::io::Read; use std::thread; use std...
2
55
4
d1fce1e836b12104d55ff82696cea082549294de
Dan Gohman
2021-09-13T19:59:50
Modify the `poll_oneoff_files` test tolerate OS differences. (#3346) Modify the `poll_oneoff_files` test to avoid assuming that `poll_oneoff` returns all pending events, as it may sometimes return only a subset of events. When multiple events are expected, use a loop, and loop until all events have been recorded.
diff --git a/crates/test-programs/wasi-tests/src/bin/poll_oneoff_files.rs b/crates/test-programs/wasi-tests/src/bin/poll_oneoff_files.rs index d457a8054..bb3e91e68 100644 --- a/crates/test-programs/wasi-tests/src/bin/poll_oneoff_files.rs +++ b/crates/test-programs/wasi-tests/src/bin/poll_oneoff_files.rs @@ -14,6 +14,29...
1
24
1
ec4e48d4cbc28bcfd99e25842a90704e765b800f
Nick Fitzgerald
2021-09-01T22:40:18
Stop doing fuzzy search for stack maps The new backends will not emit a stack map for a safepoint if there are zero live references. Our fuzzy search for stack maps, which was necessary for the old backend, caused us to use the wrong stack map for some PCs which would in turn cause us to treat arbitrary stack slots as...
diff --git a/crates/wasmtime/src/module/registry.rs b/crates/wasmtime/src/module/registry.rs index 08ebacdbe..89f851c48 100644 --- a/crates/wasmtime/src/module/registry.rs +++ b/crates/wasmtime/src/module/registry.rs @@ -122,61 +122,65 @@ impl ModuleInfo for RegisteredModule { let info = self.module.func_info(...
1
52
48
8805e250425f35b837c6e148961ad5fd2fdadd95
Anton Kirilov
2021-09-09T16:45:37
Cranelift AArch64: Improve the type checks for IR operations There were cases where the AArch64 backend assumed that an IR operation would always operate on certain types (the most likely reason being that the corresponding WebAssembly instruction did not cover anything else), even though the definition of the IR oper...
diff --git a/cranelift/codegen/src/isa/aarch64/inst/args.rs b/cranelift/codegen/src/isa/aarch64/inst/args.rs index 1a55029b3..f83818622 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/args.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/args.rs @@ -550,6 +550,8 @@ impl OperandSize { /// Convert from an integ...
3
259
102