commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
4d86f0ca102345555d87eaaa7524acd4260f7607
Dan Gohman
2021-09-11T17:28:30
Update to cap-std 0.19.0 and rsix 0.22.4. (#3331) This pulls in the s390x fix needed by #3330. Also a small `rsix` API update; `PollFdVec` has been removed in favor of just using `Vec<PollFd>`.
diff --git a/Cargo.lock b/Cargo.lock index 6aab4ad0c..9e071162d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -231,9 +231,9 @@ checksum = "349f9b6a179ed607305526ca489b34ad0a41aed5f7980fa90eb03160b69598fb" [[package]] name = "bitflags" -version = "1.2.1" +version = "1.3.2" source = "registry+https://github.com/rust-l...
8
45
46
256e942aa02667d4b656e3f8373cb75916d95124
Dan Gohman
2021-09-11T17:26:54
Tidy up redundant `use` declarations. (#3333) This is just a minor code cleanup.
diff --git a/cranelift/jit/src/backend.rs b/cranelift/jit/src/backend.rs index fe55719c4..07a5cad65 100644 --- a/cranelift/jit/src/backend.rs +++ b/cranelift/jit/src/backend.rs @@ -13,9 +13,6 @@ use cranelift_module::{ DataContext, DataDescription, DataId, FuncId, Init, Linkage, Module, ModuleCompiledFunction, ...
5
0
9
1b8154e0a3e3e54a82b5e62091d952a3eb6f9c75
Ulrich Weigand
2021-09-11T13:02:55
cranelift: Fix big-endian regression in data_value.rs PR https://github.com/bytecodealliance/wasmtime/pull/3187 introduced a change to the write_to_slice and read_from_slice routines in data_value.rs that switched byte order on big-endian systems: the code used to use native byte order, and now hard-codes little-endia...
diff --git a/cranelift/codegen/src/data_value.rs b/cranelift/codegen/src/data_value.rs index 7f4d1b15a..965ce1bec 100644 --- a/cranelift/codegen/src/data_value.rs +++ b/cranelift/codegen/src/data_value.rs @@ -82,12 +82,12 @@ impl DataValue { match self { DataValue::B(true) => dst[..16].copy_from_s...
1
12
12
3c1133379cbcbd18763fe35e18c5300469ba58d6
Afonso Bordado
2021-09-10T14:46:14
cranelift: Add `is_bool_vector` helper
diff --git a/cranelift/codegen/src/ir/types.rs b/cranelift/codegen/src/ir/types.rs index 1f59c9c07..428402119 100644 --- a/cranelift/codegen/src/ir/types.rs +++ b/cranelift/codegen/src/ir/types.rs @@ -208,6 +208,11 @@ impl Type { } } + /// Is this a vector boolean type? + pub fn is_bool_vector(sel...
2
7
6
85d468dc5a5168d8ae11ee0fb606a1c3b65baecd
Afonso Bordado
2021-09-10T14:38:30
cranelift: Add `coerce_bools_to_ints` helper
diff --git a/cranelift/codegen/src/ir/types.rs b/cranelift/codegen/src/ir/types.rs index 477c589a5..1f59c9c07 100644 --- a/cranelift/codegen/src/ir/types.rs +++ b/cranelift/codegen/src/ir/types.rs @@ -340,6 +340,19 @@ impl Type { Err(()) => panic!("unable to determine architecture pointer width"), ...
2
19
9
9460a4fb1613d91770f891409bd0cc1bac7539a6
Afonso Bordado
2021-09-06T19:25:23
cranelift: Support bool vectors in trampoline
diff --git a/cranelift/codegen/src/ir/types.rs b/cranelift/codegen/src/ir/types.rs index b9499435b..477c589a5 100644 --- a/cranelift/codegen/src/ir/types.rs +++ b/cranelift/codegen/src/ir/types.rs @@ -127,6 +127,21 @@ impl Type { } } + /// Get a type with the same number of lanes as this type, but wi...
2
39
9
4a4f940facf98d172243805c25ce4456fc39b8bd
dheaton-arm
2021-09-10T11:36:33
Move immediate value retrieval to `imm` Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 638db5937..bfba03017 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -76,6 +76,16 @@ where .as_slice(); DataValue::V128(buffer.try_into().expect("a 16-...
1
21
21
e7d570ddd9c67c00627acc8007a711d533351601
dheaton-arm
2021-09-10T11:26:48
Collect into Result rather than unwrap Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 2df9888e6..2c3313af1 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -685,8 +685,8 @@ where } else { let lanes = extractlanes(&arg(0)?, ctrl_ty.lane_type())? ...
1
2
2
924b0368e9b18bf9d32d52b95878704059ac99d0
dheaton-arm
2021-09-09T09:31:23
Rewrite as iterator methods Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index c5cdd82fa..eb519d2e0 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -826,24 +826,20 @@ where Opcode::SwidenHigh => unimplemented!("SwidenHigh"), Opcode::UwidenLow => { ...
1
10
14
4b256ab9682a5ae5e364137e9de1feefe040ee35
Nick Fitzgerald
2021-09-09T19:38:25
Place unwind info directly after the text section, even when debug info is enabled When debug info was enabled, we would put the debug info sections in between the text section and the unwind info section. But the unwind info is encoded in a position-independent manner (so that we don't need relocs for it) that relies...
diff --git a/crates/cranelift/src/compiler.rs b/crates/cranelift/src/compiler.rs index 444f994a7..a6b8ea74c 100644 --- a/crates/cranelift/src/compiler.rs +++ b/crates/cranelift/src/compiler.rs @@ -271,6 +271,8 @@ impl wasmtime_environ::Compiler for Compiler { trampolines.push(builder.trampoline(*i, &func))...
3
55
12
0499cca2fabe96fa6cd7b27aef274c9bf1f2a5de
Nick Fitzgerald
2021-09-03T22:45:59
Name unwind info `.eh_frame` in the Wasmtime's compiled ELF artifact We were previously using `_wasmtime_eh_frame` but there is no good reason to add the prefix Wasmtime-specific prefix. Using the standard name allows for better inspection with standard tools like `dwarfdump`.
diff --git a/crates/cranelift/src/obj.rs b/crates/cranelift/src/obj.rs index e8807834e..a5acdc29d 100644 --- a/crates/cranelift/src/obj.rs +++ b/crates/cranelift/src/obj.rs @@ -516,7 +516,7 @@ impl<'a> ObjectBuilder<'a> { let segment = self.obj.segment_name(StandardSegment::Data).to_vec(); let section...
2
2
2
dd0bc3237e70f4c3f392e6c8960f2dcb1430261d
Nick Fitzgerald
2021-09-03T22:43:55
Do not write a DWARF section if it is empty There is no point in writing an empty DWARF section, and this will make our ELF files a tiny bit smaller.
diff --git a/crates/cranelift/src/debug/write_debuginfo.rs b/crates/cranelift/src/debug/write_debuginfo.rs index a82796cb3..561b90ef0 100644 --- a/crates/cranelift/src/debug/write_debuginfo.rs +++ b/crates/cranelift/src/debug/write_debuginfo.rs @@ -54,6 +54,9 @@ fn emit_dwarf_sections( sections.for_each_mut(|id, s...
1
3
0
e26b91e890b1d2ab42efa674c2d9f7035edf22ab
Alex Crichton
2021-09-09T18:54:50
Remove unnecessary annotations on `Module::get_export` (#3318) I think these were historically needed but nowadays not necessary!
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index e8a017469..677b094ba 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -894,7 +894,7 @@ impl Module { /// # Ok(()) /// # } /// ``` - pub fn get_export<'module>(&'module self, name: &'module...
1
1
1
bd19f43f84ef23cc0d89fbf78353495f7b6a8443
Pat Hickey
2021-09-09T14:20:45
rewrite `Store::{entering,exiting}_native_code_hook` into `Store::call_hook` (#3313) which provides additional detail on what state transition is being made
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index e12ba4eb0..f11e20117 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1,7 +1,7 @@ use crate::store::{StoreData, StoreOpaque, Stored}; use crate::{ - AsContext, AsContextMut, Engine, Extern, FuncType, Instance...
6
638
346
bcb1dc90d65b823cd793124fd0f894548ad08316
Alex Crichton
2021-09-08T21:13:50
Add an assertion that a `HostFunc`'s `store` agrees on engines This commit adds an assertion which was previously forgotten when inserting a `HostFunc` into a `Store`. This can happen when a `Linker` is defined with one engine but it's used to interoperate with a store defined within a different engine. A function co...
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index e12ba4eb0..40af01f70 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1949,6 +1949,14 @@ impl HostFunc { } unsafe fn register_trampoline(&self, store: &mut StoreOpaque) { + // This assert is req...
4
69
9
dfe1c914eab555e189b5c637e021fe14acf9b862
dheaton-arm
2021-09-08T11:26:54
Cast types back to expected in macros Also neatened `popcnt` a little following feedback. Copyright (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 802fea464..2df9888e6 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -669,36 +669,25 @@ where Opcode::UshrImm => binary(Value::ushr, arg(0)?, imm_as_ctrl_ty()?)?, Opcode::...
2
16
27
3f62ef6e5851a0d8522bedb03379d68d4bf9a967
Afonso Bordado
2021-09-07T17:13:45
cranelift: Fix Build error #3304 and #3268 are slightly incomptible and caused the build to fail when they were merged together
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 309b9305d..ce53528c2 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -791,7 +791,7 @@ where Opcode::Splat => { let mut new_vector = SimdVec::new(); for _ ...
1
1
1
c73673559b0058e5cd9637a3f3cf4d92ff852f21
Alex Crichton
2021-09-03T20:14:21
Avoid vector allocations in wasm->host calls (#3294) This commit improves the runtime support for wasm-to-host invocations for functions created with `Func::new` or `wasmtime_func_new` in the C API. Previously a `Vec` (sometimes a `SmallVec`) would be dynamically allocated on each host call to store the arguments t...
diff --git a/Cargo.lock b/Cargo.lock index f6b9d6639..6aab4ad0c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3567,7 +3567,6 @@ dependencies = [ "region", "rustc-demangle", "serde", - "smallvec", "target-lexicon", "tempfile", "wasi-cap-std-sync", diff --git a/crates/c-api/src/func.rs b/crates/c-api/src/func....
7
83
39
50ce19a4a4218bbdb6a5c676e0f77014cef68fd4
Alex Crichton
2021-09-03T18:40:51
Remove an indirect function call in `Func::new` (#3293) This commit optimizes the runtime execution of `Func::new` by removing an indirect function call that happens whenever a host function is called. This indirection was generally done to prevent monomoprhizing a lot into consumer code but the few extra funct...
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index c66a43aa6..08ce16efd 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1894,11 +1894,11 @@ impl HostFunc { let ty_clone = ty.clone(); // Create a trampoline that converts raw u128 values to `Val...
2
22
24
81d5781e6cbe67141f800fea7f0e4cd6ef2ce240
Afonso Bordado
2021-09-01T22:25:40
cranelift: CLIF fuzzer generate jump tables and br_table
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index b52918069..458a6fd33 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -16,6 +16,8 @@ pub struct Config { /// This value does not apply to block0 which takes the function params /// and is ...
2
52
2
cbfae6f33609ddce9e8e6a3002ae595435aea27f
Afonso Bordado
2021-09-01T20:59:42
cranelift: CLIF fuzzer refactor param count generation
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index e492b2327..acb801be8 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -8,6 +8,7 @@ use cranelift::codegen::ir::{ use cranelift::codegen::isa::CallCon...
1
12
13
c33700087d1d9b50831154a63ab590849c9f951a
Alex Crichton
2021-09-03T16:43:56
Align order of wasm types/values across Wasmtime (#3292) Wasmtime has a few representations of `Val` and `ValType` across the internal crates, the `wasmtime` crate, and the C API. These were previously sometimes mentioned in different orders which means that converting between the two took a little extra code than ...
diff --git a/crates/wasmtime/src/types.rs b/crates/wasmtime/src/types.rs index d5cbab5be..741eabacd 100644 --- a/crates/wasmtime/src/types.rs +++ b/crates/wasmtime/src/types.rs @@ -22,6 +22,8 @@ pub enum Mutability { /// A list of all possible value types in WebAssembly. #[derive(Debug, Clone, Hash, Eq, PartialEq)] ...
2
30
10
63b7120a00080427aa7eb1e93d4b1a443f0e6985
Pat Hickey
2021-09-02T16:31:21
fix the tests
diff --git a/tests/all/module_serialize.rs b/tests/all/module_serialize.rs index 1e9aa9eff..42aadc663 100644 --- a/tests/all/module_serialize.rs +++ b/tests/all/module_serialize.rs @@ -15,24 +15,29 @@ unsafe fn deserialize_and_instantiate(store: &mut Store<()>, buffer: &[u8]) -> R #[test] fn test_version_mismatch() -...
1
16
11
20913a7473c00a4b57b867f52ee5df34b8b1d520
Afonso Bordado
2021-09-02T14:32:14
cranelift: Enable compiling br_tables for types larger than i32
diff --git a/cranelift/frontend/src/switch.rs b/cranelift/frontend/src/switch.rs index 507c2be20..7be8c8d0a 100644 --- a/cranelift/frontend/src/switch.rs +++ b/cranelift/frontend/src/switch.rs @@ -264,24 +264,19 @@ impl Switch { } }; - let discr = if bx.func.dfg.value_type(dis...
1
7
19
37b9fc53332855b662bc49af1f92affa8612a285
Alex Crichton
2021-09-02T14:38:29
Fix async build
diff --git a/crates/wasmtime/src/store.rs b/crates/wasmtime/src/store.rs index ca1fb4dd2..8b19cfcbc 100644 --- a/crates/wasmtime/src/store.rs +++ b/crates/wasmtime/src/store.rs @@ -1233,9 +1233,9 @@ impl AsyncCx { Poll::Pending => {} } - let before = wasmtime_runtime::TlsResto...
1
2
2
6b5e21d80e8b2c8542a690541a31911337281882
Alex Crichton
2021-08-31T15:37:19
Inline some trivial store accessors These were showing up in some profiles, but they're trivial functions, so `#[inline]` them.
diff --git a/crates/wasmtime/src/store.rs b/crates/wasmtime/src/store.rs index 31bdc48fb..ca1fb4dd2 100644 --- a/crates/wasmtime/src/store.rs +++ b/crates/wasmtime/src/store.rs @@ -726,6 +726,7 @@ impl StoreInnermost { Ok(()) } + #[inline] pub fn async_support(&self) -> bool { cfg!(fe...
1
3
0
230159efa76fb09d103e79649e53412540b8146e
Alex Crichton
2021-08-31T15:36:27
Inline some type conversions for `()` The `()` type accidentally wasn't getting its trivial type conversions inlined because it doesn't actually have any type parameters. This commit adds `#[inline]` to the relevant functions to ensure that these get inlined across crates.
diff --git a/crates/wasmtime/src/func/typed.rs b/crates/wasmtime/src/func/typed.rs index 119351e32..7085b84ea 100644 --- a/crates/wasmtime/src/func/typed.rs +++ b/crates/wasmtime/src/func/typed.rs @@ -368,6 +368,7 @@ macro_rules! impl_wasm_params { } } + #[inline] ...
1
2
0
c8f55ed688ad733dee333f23e51b108e0cb9b41b
Alex Crichton
2021-08-31T15:34:31
Optimize codegen slightly calling wasm functions Currently wasm-calls work with `Result<T, Trap>` internally but `Trap` is an enum defined in `wasmtime-runtime` which is actually quite large. Since traps are supposed to be rare this commit changes these functions to return a `Box<Trap>` which is un-boxed later up in t...
diff --git a/crates/runtime/src/traphandlers.rs b/crates/runtime/src/traphandlers.rs index e4c4faf6a..ad78dcb05 100644 --- a/crates/runtime/src/traphandlers.rs +++ b/crates/runtime/src/traphandlers.rs @@ -173,7 +173,7 @@ pub unsafe fn catch_traps<'a, F>( signal_handler: Option<*const SignalHandler<'static>>, ...
7
38
27
85ec11acb921738f3515d23b9480e12e61a1bbaf
Benjamin Bouvier
2021-09-01T15:53:14
Aarch64: always generate the CFA directive indicating no pointer signing
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index 46eabe5de..2a869185d 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -619,9 +619,8 @@ impl ABIMachineSpec for AArch64MachineDeps { } } - fn ge...
3
19
3
fb94b81538faaff30a9970b5a776145125051388
Benjamin Bouvier
2021-09-01T14:59:12
Use 16K code pages on Mac M1 Fixes #3278.
diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index 80a2599d3..3331534c4 100644 --- a/cranelift/codegen/src/isa/mod.rs +++ b/cranelift/codegen/src/isa/mod.rs @@ -314,6 +314,21 @@ pub trait TargetIsa: fmt::Display + Send + Sync { } } + /// Returns the code (text) sec...
2
22
5
f46f58ecc2eeb0c1b90e7b63c4222e605cd5416c
Pat Hickey
2021-09-01T17:25:28
replace Config::deserialize_check_wasmtime_version with Config::module_version which is more expressive than the former. Instead of just configuring Module::deserialize to ignore version information, we can configure Module::serialize to emit a custom version string, and Module::deserialize to check for that string. ...
diff --git a/crates/wasmtime/src/config.rs b/crates/wasmtime/src/config.rs index ebf6c8aa7..73e8cd379 100644 --- a/crates/wasmtime/src/config.rs +++ b/crates/wasmtime/src/config.rs @@ -330,6 +330,23 @@ impl Default for InstanceAllocationStrategy { } } +#[derive(Clone)] +/// Configure the strategy used for versi...
4
76
42
f0f2efba26b71493e2f429ca14cf9c60c9122fed
Afonso Bordado
2021-07-06T09:09:19
cranelift: CLIF Fuzzer generate brz/brnz/bricmp instructions
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 322b4676b..e492b2327 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -1,13 +1,13 @@ use crate::config::Config; use anyhow::Result; -use arbitrary::...
2
196
85
f4bd7d17a3d778049d5fab0225f20f1d3ca86cd7
Afonso Bordado
2021-07-05T20:23:54
cranelift: CLIF Fuzzer generate multiple blocks
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index cb10ae877..b52918069 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -9,6 +9,13 @@ pub struct Config { /// Number of variables that we allocate per function /// This value does not includ...
2
137
28
fb1201cb602ecde2d8a999e458736ada31df1acf
Afonso Bordado
2021-07-05T13:38:53
cranelift: CLIF Fuzzer limit instructions executed in interpreter
diff --git a/fuzz/fuzz_targets/cranelift-fuzzgen.rs b/fuzz/fuzz_targets/cranelift-fuzzgen.rs index 2a502ef19..234feb8ea 100644 --- a/fuzz/fuzz_targets/cranelift-fuzzgen.rs +++ b/fuzz/fuzz_targets/cranelift-fuzzgen.rs @@ -7,14 +7,17 @@ use cranelift_filetests::function_runner::{CompiledFunction, SingleFunctionCompi use...
1
15
4
4cdb2d3dacb167b41c710e9e55ccf80c05d6f3f5
dheaton-arm
2021-09-01T14:55:35
Merge vector iterators into chain Copyrght (c) 2021, Arm Limited
diff --git a/cranelift/interpreter/src/step.rs b/cranelift/interpreter/src/step.rs index 3741b7405..11671d654 100644 --- a/cranelift/interpreter/src/step.rs +++ b/cranelift/interpreter/src/step.rs @@ -974,14 +974,7 @@ where let arg0 = extractlanes(&x, vector_type.lane_type())?; let arg1 = extractlanes(&y, vec...
1
1
8
6a9378e2440f2c88d44261d9450ee5ae3e66d4c3
Afonso Bordado
2021-08-26T13:47:23
cranelift: Prevent infinite loops in ssa frontend with unreachable code. Perform a search over block predecessors trying to find loops of unreachable predecessors. We do this by iterating on predecessors and marking them as visited, stopping if we find a previously visited block or if we find a block with multiple pre...
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index cdb8ced8e..7017cfc1b 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -8,6 +8,7 @@ //! <https://link.springer.com/content/pdf/10.1007/978-3-642-37051-9_6.pdf> use crate::Variable; +use alloc::collection...
1
107
4
05d113148d628ca3b8a3024119f35d1a91cc9e36
Dan Gohman
2021-08-31T22:28:52
Use `std::alloc::alloc` instead of `libc::posix_memalign`. This makes Cranelift use the Rust `alloc` API its allocations, rather than directly calling into `libc`, which makes it respect the `#[global_allocator]` configuration. Also, use `region::page::ceil` instead of having our own copies of that logic.
diff --git a/cranelift/jit/src/memory.rs b/cranelift/jit/src/memory.rs index afd1a9e05..0aab70743 100644 --- a/cranelift/jit/src/memory.rs +++ b/cranelift/jit/src/memory.rs @@ -1,20 +1,13 @@ -#[cfg(not(any(feature = "selinux-fix", windows)))] -use libc; - #[cfg(feature = "selinux-fix")] use memmap2::MmapMut; -use r...
2
18
62
197aec9a087e91a095c2eed1f3c8c6cc993afedb
Dan Gohman
2021-08-31T20:02:37
Update io-lifetimes, cap-std, and rsix (#3269) - Fixes for compiling on OpenBSD - io-lifetimes 0.3.0 has an option (io_lifetimes_use_std, which is off by default) for testing the `io_safety` feature in Rust nightly.
diff --git a/Cargo.lock b/Cargo.lock index d2f676372..f6b9d6639 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -287,9 +287,9 @@ checksum = "b700ce4376041dcd0a327fd0097c41095743c4c8af8887265942faf1100bd040" [[package]] name = "cap-fs-ext" -version = "0.17.0" +version = "0.18.0" source = "registry+https://github.com/ru...
9
55
50
ef3ec594ce370d4894544d05ff8e8c45b548cfba
Alex Crichton
2021-08-30T18:38:35
Don't copy executable code into a `CodeMemory` (#3265) * Don't copy executable code into a `CodeMemory` This commit moves a copy from compiled artifacts into a `CodeMemory`. In general this commit drastically changes the meaning of a `CodeMemory`. Previously it was an iteratively-pushed-on structure that would a...
diff --git a/crates/cranelift/src/obj.rs b/crates/cranelift/src/obj.rs index fc3e9dfbd..3789c51b8 100644 --- a/crates/cranelift/src/obj.rs +++ b/crates/cranelift/src/obj.rs @@ -396,7 +396,7 @@ impl<'a> ObjectBuilder<'a> { unwind_info.extend_from_slice(&info.end.to_le_bytes()); unwind_info.exte...
8
219
240
eb251deca9d92cdb34afb8d753e3947233e8ef2a
Alex Crichton
2021-08-30T18:26:07
Remove `scroll` dependency from `wasmtime-jit` (#3260) Similar functionality to `scroll` is provided with the `object` crate and doesn't have a `*_derive` crate to go with it. This commit updates the jitdump linux support to use `object` instead of `scroll` to achieve the needs of writing structs-as-bytes onto disk...
diff --git a/Cargo.lock b/Cargo.lock index daf29de15..390fd7e8f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2670,26 +2670,6 @@ version = "1.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d29ab0c6d3fc0ee92fe66e2d99f700eab17a8d57d1c1d3b748380fb20baa78cd" -[[package]] -name = "scrol...
3
21
36
a978c7e384ab119f3f3a3d16ade040cd30d85eb7
Alex Crichton
2021-08-30T16:48:50
Update wasm-smith (#3267) Brings in a fix for a fuzz-bug found on oss-fuzz.
diff --git a/Cargo.lock b/Cargo.lock index 44cbe0a77..daf29de15 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3484,9 +3484,9 @@ dependencies = [ [[package]] name = "wasm-smith" -version = "0.7.0" +version = "0.7.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e10a213853964654be33c79...
1
2
2
6e1015c0b6d56865269bc185c2dc836bbe349793
Johnnie Birch
2021-08-28T19:41:13
Bench-api cargo update to allow seeing Module functions
diff --git a/crates/bench-api/Cargo.toml b/crates/bench-api/Cargo.toml index f3a663968..9ec6e6078 100644 --- a/crates/bench-api/Cargo.toml +++ b/crates/bench-api/Cargo.toml @@ -17,7 +17,7 @@ crate-type = ["rlib", "cdylib"] [dependencies] anyhow = "1.0" shuffling-allocator = { version = "1.1.1", optional = true } -wa...
1
1
1
4ccdcb110a5dc79ac6c4fec9c8a6e4fd8cb26fe9
Andrew Brown
2021-08-27T18:50:11
typo: change 'sharedable' to 'shareable' (#3259)
diff --git a/crates/wiggle/src/lib.rs b/crates/wiggle/src/lib.rs index 87847d486..18d943f06 100644 --- a/crates/wiggle/src/lib.rs +++ b/crates/wiggle/src/lib.rs @@ -332,11 +332,11 @@ unsafe impl<T: ?Sized + GuestMemory> GuestMemory for Arc<T> { /// * `GuestPtr<'_, str>` - a pointer to a guest string. Has the methods ...
1
7
7
690ea640b3280a4989e284d330b9d865f26fdcf5
bjorn3
2021-07-26T17:47:15
Implement fmin_pseudo and fmax_pseudo for scalars
diff --git a/cranelift/codegen/src/isa/x64/lower.rs b/cranelift/codegen/src/isa/x64/lower.rs index 234ba3d3f..6bd6ea7b7 100644 --- a/cranelift/codegen/src/isa/x64/lower.rs +++ b/cranelift/codegen/src/isa/x64/lower.rs @@ -4413,6 +4413,10 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>( let ty = ty.unwrap();...
1
4
0
12515e66460511067fcc38c89ae1d08942693cd1
Alex Crichton
2021-08-27T06:09:55
Move trap information to a section of the compiled image (#3241) This commit moves the `traps` field of `FunctionInfo` into a section of the compiled artifact produced by Cranelift. This section is quite large and when previously encoded/decoded with `bincode` this can take quite some time to process. Traps are exp...
diff --git a/crates/cranelift/src/compiler.rs b/crates/cranelift/src/compiler.rs index 61c268ee6..3d3443e97 100644 --- a/crates/cranelift/src/compiler.rs +++ b/crates/cranelift/src/compiler.rs @@ -28,7 +28,7 @@ use std::sync::Mutex; use wasmtime_environ::{ AddressMapSection, CompileError, FilePos, FlagValue, Func...
8
246
75
fc911766851c6dcff64d29df08b02e0a0b9aa144
Alex Crichton
2021-08-27T04:06:41
Move address maps to a section of the compiled image (#3240) This commit moves the `address_map` field of `FunctionInfo` into a custom-encoded section of the executable. The goal of this commit is, as previous commits, to push less data through `bincode`. The `address_map` field is actually extremely large and has ...
diff --git a/crates/cranelift/src/compiler.rs b/crates/cranelift/src/compiler.rs index 199c08f52..61c268ee6 100644 --- a/crates/cranelift/src/compiler.rs +++ b/crates/cranelift/src/compiler.rs @@ -3,7 +3,7 @@ use crate::func_environ::{get_func_name, FuncEnvironment}; use crate::obj::ObjectBuilder; use crate::{ b...
10
281
141
d12f1d77e650e9f07e4cd7c078e798b8b9cb90bd
Alex Crichton
2021-08-27T02:17:02
Convert compilation artifacts to just bytes (#3239) * Convert compilation artifacts to just bytes This commit strips the `CompilationArtifacts` type down to simply a list of bytes. This moves all extra metadata elsewhere to live within the list of bytes itself as `bincode`-encoded information. Small affordance...
diff --git a/Cargo.lock b/Cargo.lock index e83e40ab7..b05d7a324 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3774,6 +3774,7 @@ version = "0.29.0" dependencies = [ "addr2line", "anyhow", + "bincode", "cfg-if 1.0.0", "gimli", "ittapi-rs", diff --git a/crates/jit/Cargo.toml b/crates/jit/Cargo.toml index f5dd75e...
7
168
73
e2b9b543012e7d3de3b1a20e60eb315bed94d2f5
Peter Huene
2021-08-26T03:05:48
Add `paged_memory_initialization` to Config. This commit adds a `paged_memory_initialization` setting to `Config`. The setting controls whether or not an attempt is made to organize data segments into Wasm pages during compilation. When used in conjunction with the `uffd` feature on Linux, Wasmtime can completely sk...
diff --git a/crates/wasmtime/src/config.rs b/crates/wasmtime/src/config.rs index a2d512400..a2aff6b26 100644 --- a/crates/wasmtime/src/config.rs +++ b/crates/wasmtime/src/config.rs @@ -352,6 +352,7 @@ pub struct Config { pub(crate) async_support: bool, pub(crate) deserialize_check_wasmtime_version: bool, ...
3
49
1
d74cc3385657be14ae83516d174e017e46d22dfa
Alex Crichton
2021-08-26T21:22:11
Merge `wasmtime-jit` and `wasmtime-profiling` (#3247) * Merge `wasmtime-jit` and `wasmtime-profiling` This commit merges the `wasmtime-profiling` crate into the `wasmtime-jit` crate. It wasn't really buying a ton being a separate crate and an upcoming refactoring I'd like to do is to remove the `FinishedFunction...
diff --git a/Cargo.lock b/Cargo.lock index d080caa56..e83e40ab7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3572,7 +3572,6 @@ dependencies = [ "wasmtime-environ", "wasmtime-fiber", "wasmtime-jit", - "wasmtime-profiling", "wasmtime-runtime", "wasmtime-wasi", "wat", @@ -3777,16 +3776,18 @@ dependencies = [ ...
13
72
161
def394eca27955107a951b5828e9981a6176e964
Alex Crichton
2021-08-26T15:44:05
Rewrite gdbjit support with safety and fewer deps (#3246) This refactoring primarily removes the dependency of the gdbjit image creation on the `finished_functions` array, which shouldn't be necessary given the input object being passed in since information can be read from the object instead. Additionally, though,...
diff --git a/crates/jit/src/debug.rs b/crates/jit/src/debug.rs index f7bdd77b2..8cc7ee22f 100644 --- a/crates/jit/src/debug.rs +++ b/crates/jit/src/debug.rs @@ -1,18 +1,21 @@ -use anyhow::{bail, ensure, Error}; +use anyhow::{anyhow, bail, ensure, Error}; +use object::elf::*; use object::endian::{BigEndian, Endian, End...
2
53
116
78c1e4032f2b96c5752e498bdd9b798ab25b62c2
Nick Fitzgerald
2021-08-26T14:18:43
Include the function name in `Instance::get_typed_func` error context (#3243)
diff --git a/crates/wasmtime/src/instance.rs b/crates/wasmtime/src/instance.rs index 2e23e7950..bc66d0308 100644 --- a/crates/wasmtime/src/instance.rs +++ b/crates/wasmtime/src/instance.rs @@ -372,7 +372,8 @@ impl Instance { .get_export(store.as_context_mut(), name) .and_then(|f| f.into_func()...
1
2
1
6fbddc193161d177af680778ad55fe193c4c878b
Alex Crichton
2021-08-26T03:15:24
Replace some cfg(debug) with cfg(debug_assertions) (#3242) * Replace some cfg(debug) with cfg(debug_assertions) Cargo nor rustc ever sets `cfg(debug)` automatically, so it's expected that these usages were intended to be `cfg(debug_assertions)`. * Fix MachBuffer debug-assertion invariant checks. We should on...
diff --git a/cranelift/codegen/src/machinst/buffer.rs b/cranelift/codegen/src/machinst/buffer.rs index 03debd945..be9bf468e 100644 --- a/cranelift/codegen/src/machinst/buffer.rs +++ b/cranelift/codegen/src/machinst/buffer.rs @@ -321,8 +321,15 @@ impl<I: VCodeInst> MachBuffer<I> { /// Debug-only: check invariants...
2
16
14
da5c82b786245bd6aa8879c78275eac5131900ff
Alex Crichton
2021-08-25T17:14:13
Fix a possible use-after-free introduced in #3231 (#3238) In #3231 the wasm data sections were moved from the `wasmtime_environ::Module` structure into the `CompilationArtifacts`. Each `wasmtime_runtime::Instance` holds raw pointers into the data section owned by the compilation artifacts under the assumption that ...
diff --git a/crates/wasmtime/src/module/registry.rs b/crates/wasmtime/src/module/registry.rs index 0ff2e5073..6f9faa81b 100644 --- a/crates/wasmtime/src/module/registry.rs +++ b/crates/wasmtime/src/module/registry.rs @@ -27,7 +27,10 @@ fn func_by_pc(module: &CompiledModule, pc: usize) -> Option<(DefinedFuncIndex, u //...
2
73
10
7d05ebe7ffb18deb591a2a91c1c8975b1dac6253
Alex Crichton
2021-08-25T14:03:07
Move wasm data/debuginfo into the ELF compilation image (#3235) * Move wasm data/debuginfo into the ELF compilation image This commit moves existing allocations of `Box<[u8]>` stored separately from compilation's final ELF image into the ELF image itself. The goal of this commit is to reduce the amount of data wh...
diff --git a/Cargo.lock b/Cargo.lock index 470071fbd..d080caa56 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3713,6 +3713,7 @@ dependencies = [ "indexmap", "log", "more-asserts", + "object", "serde", "target-lexicon", "thiserror", @@ -3798,6 +3799,7 @@ dependencies = [ "cranelift-codegen", "gimli", "l...
12
273
222
a662f5361de2edeaa1b0ba8fdcc16226eb827453
Alex Crichton
2021-08-24T19:04:03
Move wasm data sections out of wasmtime_environ::Module (#3231) * Reduce indentation in `to_paged` Use a few early-returns from `match` to avoid lots of extra indentation. * Move wasm data sections out of `wasmtime_environ::Module` This is the first step down the road of #3230. The long-term goal is that `M...
diff --git a/crates/environ/src/module.rs b/crates/environ/src/module.rs index d2f109a32..8468bad29 100644 --- a/crates/environ/src/module.rs +++ b/crates/environ/src/module.rs @@ -1,11 +1,11 @@ //! Data structures for representing decoded wasm modules. -use crate::{EntityRef, PrimaryMap, Tunables}; +use crate::{Ent...
12
275
209
b05cd2e02377b4d521381eabb7fb292996de30fd
Alex Crichton
2021-08-24T18:44:28
Bounds-check all relocations we apply in linking (#3237) This commit removes the unsafety present in the `link_module` function by bounds-checking all relocations that we apply, using utilities from the `object` crate for convenience. This isn't intended to have any actual functional change, just ideally improving ...
diff --git a/crates/jit/src/link.rs b/crates/jit/src/link.rs index f18debecc..580373c1b 100644 --- a/crates/jit/src/link.rs +++ b/crates/jit/src/link.rs @@ -1,10 +1,13 @@ //! Linking for JIT-compiled code. use object::read::{Object, ObjectSection, Relocation, RelocationTarget}; -use object::{elf, File, ObjectSymbol...
1
61
57
dd58d8d61f233bc67c019666665e9ea32f7e0b84
Alex Crichton
2021-08-23T22:41:33
Update some wasm-tools deps Fixes a few fuzz bugs found on CI
diff --git a/Cargo.lock b/Cargo.lock index 67bba5f27..470071fbd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3529,15 +3529,15 @@ dependencies = [ [[package]] name = "wasmparser" -version = "0.80.0" +version = "0.80.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a5f71b80b8193e50910...
1
4
4
f3977f1d97122490e747336b98131a55bf7106ab
Alex Crichton
2021-08-23T22:08:19
Fix determinism of compiled modules (#3229) * Fix determinism of compiled modules Currently wasmtime's compilation artifacts are not deterministic due to the usage of `HashMap` during serialization which has randomized order of its elements. This commit fixes that by switching to a sorted `BTreeMap` for various ...
diff --git a/crates/cranelift/src/compiler.rs b/crates/cranelift/src/compiler.rs index d27b9b306..c930fbb4f 100644 --- a/crates/cranelift/src/compiler.rs +++ b/crates/cranelift/src/compiler.rs @@ -20,7 +20,7 @@ use cranelift_wasm::{ }; use std::any::Any; use std::cmp; -use std::collections::{BTreeSet, HashMap}; +use...
7
63
20
eb21ae149a1991b1c626ae39ccc89f7a6add1d36
Alex Crichton
2021-08-23T19:42:21
Move definition of ModuleMemoryOffset (#3228) This was historically defined in `wasmtime-environ` but it's only used in `wasmtime-cranelift`, so this commit moves the definition to the `debug` module where it's primarily used.
diff --git a/crates/cranelift/src/compiler.rs b/crates/cranelift/src/compiler.rs index d9782fd89..d27b9b306 100644 --- a/crates/cranelift/src/compiler.rs +++ b/crates/cranelift/src/compiler.rs @@ -1,3 +1,4 @@ +use crate::debug::ModuleMemoryOffset; use crate::func_environ::{get_func_name, FuncEnvironment}; use crate::...
9
28
20
22ab535ad9ddc75c83d9446219b2d60f486c54c9
Alex Crichton
2021-08-23T19:35:48
Parse fewer names in linking (#3226) We don't need an auxiliary map to tell us function addresses, we can query the symbol instead.
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index c57903088..1b392e0b2 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -426,12 +426,7 @@ fn build_code_memory( trampolines.push((i, fnptr)); } - link_module( - &allocation.obj, - ...
2
14
37
925b771d2d3590d3e394f3e2ab65ec83666c2637
Alex Crichton
2021-08-23T19:35:39
Remove some dead code from wasmtime-jit (#3225) Looks like nothing is actually using these methods, so let's remove them.
diff --git a/crates/jit/src/code_memory.rs b/crates/jit/src/code_memory.rs index 04fe5f07b..2788a6953 100644 --- a/crates/jit/src/code_memory.rs +++ b/crates/jit/src/code_memory.rs @@ -26,15 +26,6 @@ impl CodeMemoryEntry { unwind_info_len, }) } - - // Note that this intentionally excludes ...
2
1
21
3e65b467790c37c004c7fe0f58308fa4b524938d
Alex Crichton
2021-08-23T19:35:31
Update crossbeam-deque to appease cargo-deny (#3227) Hopefully unblocks some CI
diff --git a/Cargo.lock b/Cargo.lock index b3012f34c..67bba5f27 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -867,9 +867,9 @@ dependencies = [ [[package]] name = "crossbeam-deque" -version = "0.8.0" +version = "0.8.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "94af6efb46fef7261685...
1
2
2
b2bcdd13ecb87e9c7cdae9cead1e490bcd47e4fe
Chris Fallin
2021-08-20T17:54:52
Spec-interpreter fuzzing: check out `fuzzing` branch of our mirror. (#3222) In #3186, we found an issue that requires patching the spec interpreter for now. Our plan is to have a `fuzzing` branch in our spec-repo mirror that lets us make these fixes locally before they are upstreamed. This PR updates the build scri...
diff --git a/crates/fuzzing/wasm-spec-interpreter/build.rs b/crates/fuzzing/wasm-spec-interpreter/build.rs index 4d074febb..9bf0c0eb7 100644 --- a/crates/fuzzing/wasm-spec-interpreter/build.rs +++ b/crates/fuzzing/wasm-spec-interpreter/build.rs @@ -11,6 +11,7 @@ const LIB_NAME: &'static str = "interpret"; const OCAML_...
1
5
2
58bf9b7bba041ee19a6d47a318e99fa35a7966ed
Michael Gattozzi
2021-08-20T16:20:38
Fix wiggle code generation for correct span usage (#3220) * Fix wiggle code generation for correct span usage Up to this point when using wiggle to generate functions we could end up with two types of functions an async or sync one with this proc macro ``` #[allow(unreachable_code)] // deals with warnings in...
diff --git a/crates/wiggle/Cargo.toml b/crates/wiggle/Cargo.toml index d8ede624a..a17646966 100644 --- a/crates/wiggle/Cargo.toml +++ b/crates/wiggle/Cargo.toml @@ -14,7 +14,7 @@ include = ["src/**/*", "README.md", "LICENSE"] thiserror = "1" witx = { path = "../wasi-common/WASI/tools/witx", version = "0.9.1", optiona...
3
48
30
db79438ddbc3a4861f7c8da389802b553bcf0cc6
Alex Crichton
2021-08-19T16:05:54
Fix cross-compilation via the CLI (#3212) The `strategy` was chosen after the `target` which meant that the target choice was blown away because the `strategy` method overwrites the currently configured compiler.
diff --git a/src/lib.rs b/src/lib.rs index a23509710..a6ac4f2bf 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -298,13 +298,15 @@ impl CommonOptions { fn config(&self, target: Option<&str>) -> Result<Config> { let mut config = Config::new(); - // Set the target before setting any cranelift options +...
1
4
2
f1793934d66caa5cf0bde18a46f57f57f7277521
Alex Crichton
2021-08-19T15:30:18
Disable default features of `gimli` (#3208) * Disable default features of `gimli` For cranelift-less builds this avoids pulling in extra dependencies into `gimli` that we don't need, improving build times slightly. * Enable read features where necessary
diff --git a/crates/cranelift/Cargo.toml b/crates/cranelift/Cargo.toml index aa5e855af..21368f0ea 100644 --- a/crates/cranelift/Cargo.toml +++ b/crates/cranelift/Cargo.toml @@ -20,7 +20,7 @@ cranelift-entity = { path = "../../cranelift/entity", version = "0.76.0" } cranelift-native = { path = '../../cranelift/native',...
3
3
3
02ecfed7a0b78bf7018834fbec9610a304ec2812
Alex Crichton
2021-08-18T17:33:06
Print more error info on sigaltstack failures (#3204) A meager but hopefully somewhat useful attempt to further debugging of #3203
diff --git a/crates/runtime/src/traphandlers/unix.rs b/crates/runtime/src/traphandlers/unix.rs index 8d55cf219..cd635239b 100644 --- a/crates/runtime/src/traphandlers/unix.rs +++ b/crates/runtime/src/traphandlers/unix.rs @@ -278,7 +278,12 @@ pub fn lazy_per_thread_init() -> Result<(), Trap> { // enough. If so ...
1
18
3
fde767fedc7ab689797f563723beec2613f65c78
Dan Gohman
2021-08-17T23:08:03
Update to cap-std 0.17.0. (#3198) This completes the posish->rsix rename, and contains a number of other minor cleanups, including avoiding the `cstr` dependency.
diff --git a/Cargo.lock b/Cargo.lock index 6a3aac53f..c12484a74 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -88,9 +88,9 @@ dependencies = [ [[package]] name = "ambient-authority" -version = "0.0.0" +version = "0.0.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e0612772f30c7c0f946a...
9
79
91
c6cd1008f8f3526cbaf22fd8a47c710b5831ab09
Alex Crichton
2021-08-17T19:31:42
Actually process memory64 feature in CLI (#3197) I forgot the last step to actually set it in `Config`...
diff --git a/src/lib.rs b/src/lib.rs index 6403270ce..a23509710 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -363,6 +363,7 @@ impl CommonOptions { .wasm_multi_value(features.multi_value || self.enable_multi_value || self.enable_all) .wasm_threads(features.threads || self.enable_threads || self....
1
1
0
0642e62f162fded41558d4ce4b5fbb8b9bd2ba98
Alex Crichton
2021-08-17T16:42:22
Use wasm-smith to canonicalize NaN in differential fuzzing (#3195) * Update wasm-smith to 0.7.0 * Canonicalize NaN with wasm-smith for differential fuzzing This then also enables floating point executing in wasmi in addition to the spec interpreter. With NaN canonicalization at the wasm level this means that w...
diff --git a/Cargo.lock b/Cargo.lock index b29cd4b61..46e9e3f2d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3496,9 +3496,9 @@ dependencies = [ [[package]] name = "wasm-smith" -version = "0.6.0" +version = "0.7.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f93b328ed4cef568449c185...
10
63
64
bd47a74dab88955f94c8bc4635f45f01d50f8e7b
Alex Crichton
2021-08-16T17:49:56
Always call the resource limiter for memory allocations (#3189) * Always call the resource limiter for memory allocations Previously the memory64 support meant that sometimes we wouldn't call the limiter because the calculation for the minimum size requested would overflow. Instead Wasmtime now wraps the minimum ...
diff --git a/crates/runtime/src/memory.rs b/crates/runtime/src/memory.rs index 0b770247a..1f6695412 100644 --- a/crates/runtime/src/memory.rs +++ b/crates/runtime/src/memory.rs @@ -254,30 +254,40 @@ impl Memory { assert_le!(plan.memory.minimum, absolute_max); assert!(plan.memory.maximum.is_none() || p...
2
73
14
1bdafbf2268588eeecc66e7d94ccb208d246b856
Alex Crichton
2021-08-16T17:48:10
Don't require `DW_AT_comp_dir` for debuginfo I'm not too well-versed in this area of debuginfo, but I think this should address #3184 where it appears not all compilers emit `DW_AT_comp_dir`. This seems to match the default behavior of `gimli` when it maps an existing line program to a new line program as well (choosi...
diff --git a/crates/debug/src/transform/line_program.rs b/crates/debug/src/transform/line_program.rs index 7906fbcd4..a9b309bfe 100644 --- a/crates/debug/src/transform/line_program.rs +++ b/crates/debug/src/transform/line_program.rs @@ -63,17 +63,20 @@ where }; let comp_dir = root.attr_value(gimli::DW_AT_comp...
1
14
11
e9f33fc6185508204afce59c3bf7184cb1abdcad
Alex Crichton
2021-08-12T21:58:21
Move all trampoline compilation to `wasmtime-cranelift` (#3176) * Move all trampoline compilation to `wasmtime-cranelift` This commit moves compilation of all the trampolines used in wasmtime behind the `Compiler` trait object to live in `wasmtime-cranelift`. The long-term goal of this is to enable depending on c...
diff --git a/Cargo.lock b/Cargo.lock index e88dcf86f..4c84df1ef 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3564,6 +3564,7 @@ dependencies = [ "bincode", "cfg-if 1.0.0", "cpp_demangle", + "cranelift-native", "indexmap", "lazy_static", "libc", @@ -3657,6 +3658,7 @@ name = "wasmtime-cli" version = "0.29.0" ...
24
394
480
2da1b9d3759bdaecac41d7bb2bc738c113a563b8
Alex Crichton
2021-08-12T18:28:00
Delete unused code in `wasmtime-obj` (#3179) I believe this was likely used at some point historically, but nowadays this code isn't used so let's delete it.
diff --git a/crates/obj/src/context.rs b/crates/obj/src/context.rs deleted file mode 100644 index 2f737dac8..000000000 --- a/crates/obj/src/context.rs +++ /dev/null @@ -1,95 +0,0 @@ -#![allow(clippy::cast_ptr_alignment)] - -use more_asserts::assert_le; -use std::collections::hash_map::Entry; -use std::collections::Hash...
5
0
258
76a93dc112fda45d87465558840a231b1cb9c652
Andrew Brown
2021-08-10T19:03:21
fuzz: log Wasm contents to file when `log::debug` is enabled Previously, the WAT was printed as a log message. This change standardizes all of the oracles to use `log_wasm`, which emits a `.wasm` and `.wat` file for each case if `log::debug` is enabled and prints a message with the names of the created files. Closes #...
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index 8c84641fa..76b5630b1 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -621,6 +621,7 @@ impl wasm_smith::Config for SingleFunctionModuleConfig { /// should be rare if modules are generated appropriately. p...
1
2
19
cbabcacb0f07eadbd012a00fd8cf7bc308b2f421
Sergei Shulepov
2021-08-10T19:09:15
wasmtime: Option to disable parallel compilation (#3169) * Introduce parallel-compilation configuration switch * Plumb parallel_compilation config to compilation * Adjust obj.rs * Address review * Fix compilation fail in `cache` crate * Fix obj.rs Also remove the now unneeded feature in /Cargo.toml ...
diff --git a/crates/cache/src/lib.rs b/crates/cache/src/lib.rs index f29dd2105..874e48193 100644 --- a/crates/cache/src/lib.rs +++ b/crates/cache/src/lib.rs @@ -43,6 +43,8 @@ impl<'config> ModuleCacheEntry<'config> { } /// Gets cached data if state matches, otherwise calls the `compute`. + // NOTE: This ...
8
81
30
92b382b736427ce93680a22abb85a09a7f8a31db
Andrew Brown
2021-08-03T00:03:47
fuzz: count successful executions of differential_spec target
diff --git a/fuzz/fuzz_targets/differential_spec.rs b/fuzz/fuzz_targets/differential_spec.rs index 69ec7744b..bd42d6922 100644 --- a/fuzz/fuzz_targets/differential_spec.rs +++ b/fuzz/fuzz_targets/differential_spec.rs @@ -1,13 +1,31 @@ #![no_main] use libfuzzer_sys::fuzz_target; +use std::sync::atomic::{AtomicUsize,...
1
19
1
651a321f1a87250d5c18e0960ecee33cd31487ff
Andrew Brown
2021-07-28T20:21:42
fuzz: add differential_spec fuzzing target This new target compares the outputs of executing the first exported function of a Wasm module in Wasmtime and in the official Wasm spec interpreter (using the `wasm-spec-interpreter` crate). This is an initial step towards more fully-featured fuzzing (e.g. compare memories, ...
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index e45862950..8c84641fa 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -12,8 +12,9 @@ pub mod dummy; +use anyhow::Context; use arbitrary::Arbitrary; -use log::debug; +use log::{debug, warn}; use std::...
3
161
10
f3955fa62aa0b092b39e21817b80962bb12354b1
Andrew Brown
2021-07-28T20:19:09
refactor: rename `DifferentialWasmiModuleConfig` to `SingleFunctionModuleConfig` Since we plan to reuse this configuration, we rename it and ensure it has at least 1 type (this resulted in invalid modules).
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index 123a0be99..e45862950 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -563,15 +563,20 @@ pub fn table_ops( } /// Configuration options for wasm-smith such that generated modules always -/// conform to c...
2
10
5
2e95d4e7c6269640383a7f6e3fc3a130601a15a3
Andrew Brown
2021-08-09T23:54:46
wasi-nn: refactor wasi-nn context to use multiple backends
diff --git a/crates/wasi-nn/src/api.rs b/crates/wasi-nn/src/api.rs index 630a352a7..94f94526a 100644 --- a/crates/wasi-nn/src/api.rs +++ b/crates/wasi-nn/src/api.rs @@ -33,7 +33,7 @@ pub(crate) trait BackendExecutionContext { /// Errors returned by a backend; [BackendError::BackendAccess] is a catch-all /// for failu...
4
79
194
f0147f23e88f282137c14c66d286ddc20e897a91
Andrew Brown
2021-08-09T23:53:04
wiggle: emit `From<#ident> for #tag_type` for variants
diff --git a/crates/wiggle/generate/src/types/variant.rs b/crates/wiggle/generate/src/types/variant.rs index 93df4edb1..5624b43eb 100644 --- a/crates/wiggle/generate/src/types/variant.rs +++ b/crates/wiggle/generate/src/types/variant.rs @@ -96,6 +96,25 @@ pub(super) fn define_variant(names: &Names, name: &witx::Id, v: ...
1
20
0
c3bbdead7c855daf567ea79c3af08c577c0cf51b
Andrew Brown
2021-08-09T22:43:35
wasi-nn: add backend abstraction
diff --git a/crates/wasi-nn/src/api.rs b/crates/wasi-nn/src/api.rs new file mode 100644 index 000000000..630a352a7 --- /dev/null +++ b/crates/wasi-nn/src/api.rs @@ -0,0 +1,45 @@ +//! Define the Rust interface a backend must implement in order to be used by +//! this crate. the `Box<dyn ...>` types returned by these int...
3
186
0
480dff21e8749d8cefedcfa7d3cb74de71724bc5
Alex Crichton
2021-08-06T21:27:42
fuzz: Disable more features for spectests fuzzer (#3159) The previous commit to eanble multi-memory and simd leaked into the spectest fuzzer, but to pass the spec tests we can't enable these features.
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index 5ec58035c..123a0be99 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -493,6 +493,7 @@ pub fn spectest(fuzz_config: crate::generators::Config, test: crate::generators: config.wasm_reference_types(false...
1
1
0
33c3d00f1017ac34e081a49306091e335b47998e
Alex Crichton
2021-08-06T17:43:22
Remove rss prediction from api_calls fuzzer (#3156) This functionality is now subsumed by the limiter built-in to all fuzzing stores, so there's no longer any need for it. It was also triggering arithmetic overflows in fuzzing, so instead of fixing I'm removing it!
diff --git a/crates/fuzzing/src/generators/api.rs b/crates/fuzzing/src/generators/api.rs index 3e3561ebb..c3f395c2f 100644 --- a/crates/fuzzing/src/generators/api.rs +++ b/crates/fuzzing/src/generators/api.rs @@ -15,9 +15,7 @@ //! [swarm testing]: https://www.cs.utah.edu/~regehr/papers/swarm12.pdf use arbitrary::{A...
1
10
68
45896e053349ff809c2bb1e59f2567ec05a715ce
Alex Crichton
2021-08-06T17:28:49
Decrease memory limit in fuzzing to 1gb (#3155) This should keep us under the default 2gb limit when fuzzing
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index d560de78f..a44071201 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -46,9 +46,9 @@ fn create_store(engine: &Engine) -> Store<StoreLimits> { let mut store = Store::new( &engine, Stor...
1
2
2
ee3ff526617f3acdba500673a45675772b34d916
Alex Crichton
2021-08-06T15:18:33
Refactor cranelift immediates slightly I've run up against the `Into`-vs-`From` impls a few times and figured I'd go ahead and put up a refactoring. This switches `Into` impls into `From` impls which allows using both traits instead of just the `Into` version. Additionally this removes a few small `as` casts in favor ...
diff --git a/cranelift/codegen/src/ir/immediates.rs b/cranelift/codegen/src/ir/immediates.rs index 06c65277b..3e0a237ba 100644 --- a/cranelift/codegen/src/ir/immediates.rs +++ b/cranelift/codegen/src/ir/immediates.rs @@ -6,6 +6,7 @@ use alloc::vec::Vec; use core::cmp::Ordering; +use core::convert::TryFrom; use cor...
1
25
31
3bdf6c7a487628d75ca9dcf9920ad851872573ec
Alex Crichton
2021-08-06T14:45:56
fuzz: Centralize handling instantiation errors At the same time remove some string matching in favor of checking for oom explicitly.
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index d560de78f..a06008bf9 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -13,7 +13,6 @@ pub mod dummy; use arbitrary::Arbitrary; -use dummy::dummy_linker; use log::debug; use std::sync::atomic::{AtomicUs...
1
41
77
bb85366a3bfab793de960b5be2b069760ab8a6df
Alex Crichton
2021-08-05T21:24:42
Enable simd fuzzing on oss-fuzz (#3152) * Enable simd fuzzing on oss-fuzz This commit generally enables the simd feature while fuzzing, which should affect almost all fuzzers. For fuzzers that just throw random data at the wall and see what sticks, this means that they'll now be able to throw simd-shaped data at...
diff --git a/Cargo.lock b/Cargo.lock index 9f736c8c0..59bb30fc7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3446,18 +3446,18 @@ checksum = "d7cff876b8f18eed75a66cf49b65e7f967cb354a7aa16003fb55dbfd25b44b4f" [[package]] name = "wasm-encoder" -version = "0.5.0" +version = "0.6.0" source = "registry+https://github.co...
12
110
47
214c5f862d843231be27293da2ae3f550ac5809e
Alex Crichton
2021-08-05T20:07:33
fuzz: Implement finer memory limits per-store (#3149) * fuzz: Implement finer memory limits per-store This commit implements a custom resource limiter for fuzzing. Locally I was seeing a lot of ooms while fuzzing and I believe it was generally caused from not actually having any runtime limits for wasm modules. I...
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index f2c674edf..efb90a848 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -45,18 +45,53 @@ fn log_wasm(wasm: &[u8]) { fn create_store(engine: &Engine) -> Store<StoreLimits> { let mut store = Store::new( ...
2
64
25
d8c4ac2c258dce468fe2af42e206eec24e6a23ef
Alex Crichton
2021-08-05T19:31:55
Improve output of expectation failures of the `wast` commands (#3150) This commit updates the output of failed expectations in the `wast` crate to fold in the check-is-the-value-the-same with the generate-a-nice-message. Additionally this tries to make sure that everything is aligned in the output to make it a bit ...
diff --git a/crates/wast/src/wast.rs b/crates/wast/src/wast.rs index a2fc29a3d..0308f3f61 100644 --- a/crates/wast/src/wast.rs +++ b/crates/wast/src/wast.rs @@ -1,8 +1,8 @@ use crate::spectest::link_spectest; use anyhow::{anyhow, bail, Context as _, Result}; -use core::fmt; +use std::fmt::{Display, LowerHex}; +use st...
1
267
258
9e142f8792ddb25529782800fca70f8e3fd09630
Alex Crichton
2021-08-05T18:02:44
Fix some warnings on nightly Rust (#3148) Looks like these trailing-semicolons-in-macros are likely to become a hard error in the future, so this updates to remove them as necessary.
diff --git a/cranelift/codegen/meta/src/srcgen.rs b/cranelift/codegen/meta/src/srcgen.rs index ad8db175d..0e8d4eccf 100644 --- a/cranelift/codegen/meta/src/srcgen.rs +++ b/cranelift/codegen/meta/src/srcgen.rs @@ -19,19 +19,19 @@ static SHIFTWIDTH: usize = 4; /// strings. macro_rules! fmtln { ($fmt:ident, $fmtstr...
3
6
6
4cfa031c5fa861c955b5f238b52fa44a9d4bfd06
Alex Crichton
2021-08-05T18:02:34
Implement API support for v128-globals (#3147) Found via fuzzing, and looks like these were accidentally left out along the way SIMD was taking shape.
diff --git a/cranelift/codegen/src/ir/immediates.rs b/cranelift/codegen/src/ir/immediates.rs index 9dd317d54..06c65277b 100644 --- a/cranelift/codegen/src/ir/immediates.rs +++ b/cranelift/codegen/src/ir/immediates.rs @@ -360,6 +360,12 @@ impl From<&[u8]> for V128Imm { } } +impl From<u128> for V128Imm { + fn ...
5
29
3
91d24b8448ec41a34d666d0bc26f66433675fed8
Alex Crichton
2021-08-04T16:55:52
Fix pooling tests on high-cpu-count systems (#3141) This commit fixes an issue where `cargo test` was failing pretty reliably on an 80-thread system where many of the pooling tests would fail in `mmap` to reserve address space for the linear memories allocated for a pooling allocator. Each test wants to reserve abo...
diff --git a/tests/all/wast.rs b/tests/all/wast.rs index 2fa646614..45e874da1 100644 --- a/tests/all/wast.rs +++ b/tests/all/wast.rs @@ -1,4 +1,5 @@ use std::path::Path; +use std::sync::{Condvar, Mutex}; use wasmtime::{ Config, Engine, InstanceAllocationStrategy, InstanceLimits, ModuleLimits, PoolingAllocat...
1
52
2
a33caec9be0a4e51858a6bcae5691fe5ca422833
Alex Crichton
2021-08-04T14:53:47
Bump the wasm-tools crates (#3139) * Bump the wasm-tools crates Pulls in some updates here and there, mostly for updating crates to the latest version to prepare for later memory64 work. * Update lightbeam
diff --git a/Cargo.lock b/Cargo.lock index c27436d43..9f736c8c0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -593,7 +593,7 @@ dependencies = [ "smallvec", "souper-ir", "target-lexicon", - "wast 36.0.0", + "wast 37.0.0", ] [[package]] @@ -2020,7 +2020,7 @@ dependencies = [ "peepmatic-test-operator", "peepma...
30
148
137
26c78c06ef220b8badc036a7bad17c9bb4ec94d5
Andrew Brown
2021-07-30T16:45:47
refactor: remove unused field PR #3131 fixed the failing builds by allowing this field to be dead. After looking at it further the field is not being used and can be removedi completely.
diff --git a/cranelift/codegen/meta/src/cdsl/isa.rs b/cranelift/codegen/meta/src/cdsl/isa.rs index f3984d7bd..f6ac9f249 100644 --- a/cranelift/codegen/meta/src/cdsl/isa.rs +++ b/cranelift/codegen/meta/src/cdsl/isa.rs @@ -2,7 +2,7 @@ use std::collections::HashSet; use std::iter::FromIterator; use crate::cdsl::cpu_mo...
6
4
21
4632b6a816cf9344969a83c1a4bad2640972eab9
Alex Crichton
2021-07-30T16:13:21
Fix warning on new-stable (#3131) One of the fields of `TargetIsa` isn't used in the cranelift-codegen-meta crate, but instead of refactoring to try to remove it this just adds `#[allow(dead_code)]` for now in the assumption that when the old backends go away this will probably go away as well.
diff --git a/cranelift/codegen/meta/src/cdsl/isa.rs b/cranelift/codegen/meta/src/cdsl/isa.rs index 512105d09..f3984d7bd 100644 --- a/cranelift/codegen/meta/src/cdsl/isa.rs +++ b/cranelift/codegen/meta/src/cdsl/isa.rs @@ -10,6 +10,7 @@ use crate::cdsl::xform::{TransformGroupIndex, TransformGroups}; pub(crate) struct ...
1
1
0
072d5dc9782b9d40c2dce04689e880f30049df2e
Shamil
2021-07-29T13:59:41
Fix typo in doc (#3127)
diff --git a/crates/wasmtime/src/store.rs b/crates/wasmtime/src/store.rs index 6ed3d1d50..919e6d32f 100644 --- a/crates/wasmtime/src/store.rs +++ b/crates/wasmtime/src/store.rs @@ -36,7 +36,7 @@ pub use self::data::*; /// [`Store`] it will not be deallocated until the [`Store`] itself is dropped. /// This makes [`Sto...
1
1
1
4f601edc36efd45946230933978694d9bf80890c
Johnnie Birch
2021-07-29T06:33:42
Add x64 support for remaining int-to-int extend simd instructions Adds remaming support for int to int extend simd instructions. Specifically adds support for remaining I32x4->I64x2 instructions
diff --git a/build.rs b/build.rs index 596f39caf..7569c61c9 100644 --- a/build.rs +++ b/build.rs @@ -192,7 +192,6 @@ fn x64_should_panic(testsuite: &str, testname: &str, strategy: &str) -> bool { match (testsuite, testname) { ("simd", "simd_i16x8_extadd_pairwise_i8x16") => return true, ("simd", "...
2
27
5
e3c56efd3e388324dc5566cac01c6676528f42a7
Andrew Brown
2021-07-28T22:05:46
Fix unused borrow warning `#[warn(unused_must_use)]` is on, prompting a compiler warning like: "unused borrow that must be used".
diff --git a/crates/debug/src/transform/expression.rs b/crates/debug/src/transform/expression.rs index 484b9c664..2898be76a 100644 --- a/crates/debug/src/transform/expression.rs +++ b/crates/debug/src/transform/expression.rs @@ -435,7 +435,7 @@ impl CompiledExpression { let new_to = landing...
1
1
1
5eb2dca9f199db833e144d26257a1829f5320f77
Sam Parker
2021-07-27T13:58:10
Added doc comment And removed an accidental code move. Copyright (c) 2021, Arm Limited.
diff --git a/build.rs b/build.rs index d6651d132..596f39caf 100644 --- a/build.rs +++ b/build.rs @@ -225,6 +225,7 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool { // These are new instructions that are not really implemented in any backend. ("simd", "simd_i16x8_extadd_pa...
3
35
31