Unnamed: 0
int64 0
832k
| id
float64 2.49B
32.1B
| type
stringclasses 1
value | created_at
stringlengths 19
19
| repo
stringlengths 4
112
| repo_url
stringlengths 33
141
| action
stringclasses 3
values | title
stringlengths 1
957
| labels
stringlengths 4
1.11k
| body
stringlengths 1
261k
| index
stringclasses 11
values | text_combine
stringlengths 95
261k
| label
stringclasses 2
values | text
stringlengths 96
250k
| binary_label
int64 0
1
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
163,920
| 25,896,218,195
|
IssuesEvent
|
2022-12-14 22:47:00
|
PrefectHQ/prefect
|
https://api.github.com/repos/PrefectHQ/prefect
|
closed
|
Notification for runs that do not complete after duration
|
feature needs:design status:accepted v2 api v1-parity
|
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current behavior
In Prefect 1 we use automations to notify when a flow run takes too long eg:
```
When any run from my-flow does not finish after 3600 seconds, then Slack SLA overdue.
```
This doesn't appear to be possible in Prefect 2.
### Describe the proposed behavior
Notification for runs that do not complete after duration
### Example Use
To identify runs that are stuck in running and not completing in the expected time.
### Additional context
_No response_
|
1.0
|
Notification for runs that do not complete after duration - ### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current behavior
In Prefect 1 we use automations to notify when a flow run takes too long eg:
```
When any run from my-flow does not finish after 3600 seconds, then Slack SLA overdue.
```
This doesn't appear to be possible in Prefect 2.
### Describe the proposed behavior
Notification for runs that do not complete after duration
### Example Use
To identify runs that are stuck in running and not completing in the expected time.
### Additional context
_No response_
|
design
|
notification for runs that do not complete after duration first check i added a descriptive title to this issue i used the github search to find a similar request and didn t find it i searched the prefect documentation for this feature prefect version x describe the current behavior in prefect we use automations to notify when a flow run takes too long eg when any run from my flow does not finish after seconds then slack sla overdue this doesn t appear to be possible in prefect describe the proposed behavior notification for runs that do not complete after duration example use to identify runs that are stuck in running and not completing in the expected time additional context no response
| 1
|
44,717
| 13,067,960,462
|
IssuesEvent
|
2020-07-31 02:06:58
|
scriptex/node-rest-example
|
https://api.github.com/repos/scriptex/node-rest-example
|
closed
|
CVE-2020-11023 (Medium) detected in jquery-3.2.1.min.js
|
security vulnerability
|
## CVE-2020-11023 - Medium Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>jquery-3.2.1.min.js</b></p></summary>
<p>JavaScript library for DOM operations</p>
<p>Library home page: <a href="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js">https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js</a></p>
<p>Path to dependency file: /tmp/ws-scm/node-rest-example/node_modules/superagent/docs/tail.html</p>
<p>Path to vulnerable library: /node-rest-example/node_modules/superagent/docs/tail.html</p>
<p>
Dependency Hierarchy:
- :x: **jquery-3.2.1.min.js** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/scriptex/node-rest-example/commit/274e1b91747efb5d8af5d4642655908212622953">274e1b91747efb5d8af5d4642655908212622953</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/medium_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
In jQuery versions greater than or equal to 1.0.3 and before 3.5.0, passing HTML containing <option> elements from untrusted sources - even after sanitizing it - to one of jQuery's DOM manipulation methods (i.e. .html(), .append(), and others) may execute untrusted code. This problem is patched in jQuery 3.5.0.
<p>Publish Date: 2020-04-29
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-11023>CVE-2020-11023</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>6.1</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: Required
- Scope: Changed
- Impact Metrics:
- Confidentiality Impact: Low
- Integrity Impact: Low
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023">https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023</a></p>
<p>Release Date: 2020-04-29</p>
<p>Fix Resolution: jquery - 3.5.0</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
True
|
CVE-2020-11023 (Medium) detected in jquery-3.2.1.min.js - ## CVE-2020-11023 - Medium Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>jquery-3.2.1.min.js</b></p></summary>
<p>JavaScript library for DOM operations</p>
<p>Library home page: <a href="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js">https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js</a></p>
<p>Path to dependency file: /tmp/ws-scm/node-rest-example/node_modules/superagent/docs/tail.html</p>
<p>Path to vulnerable library: /node-rest-example/node_modules/superagent/docs/tail.html</p>
<p>
Dependency Hierarchy:
- :x: **jquery-3.2.1.min.js** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/scriptex/node-rest-example/commit/274e1b91747efb5d8af5d4642655908212622953">274e1b91747efb5d8af5d4642655908212622953</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/medium_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
In jQuery versions greater than or equal to 1.0.3 and before 3.5.0, passing HTML containing <option> elements from untrusted sources - even after sanitizing it - to one of jQuery's DOM manipulation methods (i.e. .html(), .append(), and others) may execute untrusted code. This problem is patched in jQuery 3.5.0.
<p>Publish Date: 2020-04-29
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-11023>CVE-2020-11023</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>6.1</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: Required
- Scope: Changed
- Impact Metrics:
- Confidentiality Impact: Low
- Integrity Impact: Low
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023">https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023</a></p>
<p>Release Date: 2020-04-29</p>
<p>Fix Resolution: jquery - 3.5.0</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
non_design
|
cve medium detected in jquery min js cve medium severity vulnerability vulnerable library jquery min js javascript library for dom operations library home page a href path to dependency file tmp ws scm node rest example node modules superagent docs tail html path to vulnerable library node rest example node modules superagent docs tail html dependency hierarchy x jquery min js vulnerable library found in head commit a href vulnerability details in jquery versions greater than or equal to and before passing html containing elements from untrusted sources even after sanitizing it to one of jquery s dom manipulation methods i e html append and others may execute untrusted code this problem is patched in jquery publish date url a href cvss score details base score metrics exploitability metrics attack vector network attack complexity low privileges required none user interaction required scope changed impact metrics confidentiality impact low integrity impact low availability impact none for more information on scores click a href suggested fix type upgrade version origin a href release date fix resolution jquery step up your open source security game with whitesource
| 0
|
590,963
| 17,792,052,324
|
IssuesEvent
|
2021-08-31 17:21:00
|
o3de/o3de
|
https://api.github.com/repos/o3de/o3de
|
closed
|
Prefabs - Adding and removing entities from a prefab templates
|
needs-triage sig/content status/backlog triage/accepted priority/critical kind/task feature/prefabs WF2 RTE
|
[Migrated from JIRA LYN-5161]
We need to create a system for users to add and remove entities from a prefab template, while also keeping that prefab architecture in tact as intended. These functional overrides need to do the following.
1) Allow user to remove an entity by dragging out or dragging into a prefab and showing a ghosting imprint of where that prefab use to exist or that this prefab has an additional entity that is not apart of the core template.
2) Allow the user to restore a entity from a prefab that is considered a ghosted or removed from this particular variation. Maybe right click option here (restore removed entity)
3) We should find a visual way to represent this to the user that doesn't conflict with the RTE. My suggestion is finding a way to do this in the outliner. However we need to verify this work will not be throw away for because of some ongoing upgrade for the Outliner.
|
1.0
|
Prefabs - Adding and removing entities from a prefab templates - [Migrated from JIRA LYN-5161]
We need to create a system for users to add and remove entities from a prefab template, while also keeping that prefab architecture in tact as intended. These functional overrides need to do the following.
1) Allow user to remove an entity by dragging out or dragging into a prefab and showing a ghosting imprint of where that prefab use to exist or that this prefab has an additional entity that is not apart of the core template.
2) Allow the user to restore a entity from a prefab that is considered a ghosted or removed from this particular variation. Maybe right click option here (restore removed entity)
3) We should find a visual way to represent this to the user that doesn't conflict with the RTE. My suggestion is finding a way to do this in the outliner. However we need to verify this work will not be throw away for because of some ongoing upgrade for the Outliner.
|
non_design
|
prefabs adding and removing entities from a prefab templates we need to create a system for users to add and remove entities from a prefab template while also keeping that prefab architecture in tact as intended these functional overrides need to do the following allow user to remove an entity by dragging out or dragging into a prefab and showing a ghosting imprint of where that prefab use to exist or that this prefab has an additional entity that is not apart of the core template allow the user to restore a entity from a prefab that is considered a ghosted or removed from this particular variation maybe right click option here restore removed entity we should find a visual way to represent this to the user that doesn t conflict with the rte my suggestion is finding a way to do this in the outliner however we need to verify this work will not be throw away for because of some ongoing upgrade for the outliner
| 0
|
393,112
| 26,974,601,267
|
IssuesEvent
|
2023-02-09 08:36:57
|
Jaavii004/LOS-FIFA
|
https://api.github.com/repos/Jaavii004/LOS-FIFA
|
closed
|
Añadir la URL de la web en el repositorio de github
|
documentation Agregado
|
Al poner la URL en la descripción, se hace más fácil poder acceder a la web.
|
1.0
|
Añadir la URL de la web en el repositorio de github - Al poner la URL en la descripción, se hace más fácil poder acceder a la web.
|
non_design
|
añadir la url de la web en el repositorio de github al poner la url en la descripción se hace más fácil poder acceder a la web
| 0
|
140,800
| 21,214,355,208
|
IssuesEvent
|
2022-04-11 05:15:22
|
batch-dart/batch.dart
|
https://api.github.com/repos/batch-dart/batch.dart
|
closed
|
Should be able to use main thread parameters even during parallel processing
|
Feedback: feature request Type: design
|
<!-- When reporting a feature, please read this complete template and fill all the questions in order to get a better response -->
# 1. Problem to solve
<!-- Which problem would be solved with this feature? -->
Should be able to use main thread parameters even during parallel processing.
# 2. Proposal
<!-- What do you propose as a solution? Add as much information as you can! -->
The async_task package has a mechanism for passing parameters of the main thread to parallel processing, so we will examine the feasibility of using this mechanism.
# 3. More information
<!-- Do you have any other useful information about this feature report? Please write it down here -->
<!-- Possible helpful information: references to other sites/repositories -->
<!-- Are you interested in working on a PR for this? -->
|
1.0
|
Should be able to use main thread parameters even during parallel processing - <!-- When reporting a feature, please read this complete template and fill all the questions in order to get a better response -->
# 1. Problem to solve
<!-- Which problem would be solved with this feature? -->
Should be able to use main thread parameters even during parallel processing.
# 2. Proposal
<!-- What do you propose as a solution? Add as much information as you can! -->
The async_task package has a mechanism for passing parameters of the main thread to parallel processing, so we will examine the feasibility of using this mechanism.
# 3. More information
<!-- Do you have any other useful information about this feature report? Please write it down here -->
<!-- Possible helpful information: references to other sites/repositories -->
<!-- Are you interested in working on a PR for this? -->
|
design
|
should be able to use main thread parameters even during parallel processing problem to solve should be able to use main thread parameters even during parallel processing proposal the async task package has a mechanism for passing parameters of the main thread to parallel processing so we will examine the feasibility of using this mechanism more information
| 1
|
140,253
| 21,051,446,213
|
IssuesEvent
|
2022-03-31 20:55:24
|
graycoreio/daffodil
|
https://api.github.com/repos/graycoreio/daffodil
|
closed
|
[BUG] `DaffArticleComponent` UI Issues
|
bug @daffodil/design
|
<!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
# :bug: Bug report
## Current Behavior
Some article attributes and custom components need better UI and dark mode accessibility.
## Expected Behavior
- [ ] Paragraph tags within `<blockquote>` should have proper margin/padding.
- [ ] `<code>` within `<blockquote>` should display a lighter color in dark mode.
- [ ] `<pre>` should have top/bottom spacing.
- [ ] `<blockquote>` should have top/bottom spacing.
- [ ] `<code>` should not be used in heading
## Minimal reproduction of the problem with instructions
<!-- Please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem -->
## What is the motivation / use case for changing the behavior?
Clean UI for docs.
## Environment
<pre><code>
Daffodil version: X.Y.Z
Angular version: X.Y.Z
<!-- Check whether this is still an issue in the most recent Daffodil version -->
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
|
1.0
|
[BUG] `DaffArticleComponent` UI Issues - <!--
PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
-->
# :bug: Bug report
## Current Behavior
Some article attributes and custom components need better UI and dark mode accessibility.
## Expected Behavior
- [ ] Paragraph tags within `<blockquote>` should have proper margin/padding.
- [ ] `<code>` within `<blockquote>` should display a lighter color in dark mode.
- [ ] `<pre>` should have top/bottom spacing.
- [ ] `<blockquote>` should have top/bottom spacing.
- [ ] `<code>` should not be used in heading
## Minimal reproduction of the problem with instructions
<!-- Please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem -->
## What is the motivation / use case for changing the behavior?
Clean UI for docs.
## Environment
<pre><code>
Daffodil version: X.Y.Z
Angular version: X.Y.Z
<!-- Check whether this is still an issue in the most recent Daffodil version -->
For Tooling issues:
- Node version: XX <!-- run `node --version` -->
- Platform: <!-- Mac, Linux, Windows -->
Others:
<!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->
</code></pre>
|
design
|
daffarticlecomponent ui issues please help us process github issues faster by providing the following information issues missing important information may be closed without investigation bug bug report current behavior some article attributes and custom components need better ui and dark mode accessibility expected behavior paragraph tags within should have proper margin padding within should display a lighter color in dark mode should have top bottom spacing should have top bottom spacing should not be used in heading minimal reproduction of the problem with instructions what is the motivation use case for changing the behavior clean ui for docs environment daffodil version x y z angular version x y z for tooling issues node version xx platform others
| 1
|
178,588
| 29,927,815,123
|
IssuesEvent
|
2023-06-22 07:17:49
|
w3c/w3c-website
|
https://api.github.com/repos/w3c/w3c-website
|
closed
|
Font rendering glitches due to fontfaceobserver.js
|
bug design system website
|
Seen while using the standard out-of-the-box Chrome, even after repeated loads with a hot cache:
https://user-images.githubusercontent.com/213073/133676163-5f91f342-1446-4175-b879-6257865d3672.mp4
It's the `fontfaceobserver.js` that's the culprit here. Blocking requests to it, makes the UI stable _(but rendered in another font)_.
Is there a specific reason why this JS file is required to change the fonts?
|
1.0
|
Font rendering glitches due to fontfaceobserver.js - Seen while using the standard out-of-the-box Chrome, even after repeated loads with a hot cache:
https://user-images.githubusercontent.com/213073/133676163-5f91f342-1446-4175-b879-6257865d3672.mp4
It's the `fontfaceobserver.js` that's the culprit here. Blocking requests to it, makes the UI stable _(but rendered in another font)_.
Is there a specific reason why this JS file is required to change the fonts?
|
design
|
font rendering glitches due to fontfaceobserver js seen while using the standard out of the box chrome even after repeated loads with a hot cache it s the fontfaceobserver js that s the culprit here blocking requests to it makes the ui stable but rendered in another font is there a specific reason why this js file is required to change the fonts
| 1
|
84,341
| 10,518,137,353
|
IssuesEvent
|
2019-09-29 08:38:33
|
openfaas/faas
|
https://api.github.com/repos/openfaas/faas
|
closed
|
Feature request: SDK for OpenFaaS Gateway
|
area/api area/sdk area/ux design/review size/m skill/intermediate
|
<!-- Due dilligence -->
## My actions before raising this issue
- [ ] Followed the [troubleshooting guide](https://docs.openfaas.com/deployment/troubleshooting/)
- [x] Read/searched [the docs](https://docs.openfaas.com/)
- [ ] Searched [past issues](/issues)
<!--- Provide a general summary of the issue in the Title above -->
OpenFaaS has support of CLI to invoke functions and interact with OpenFaaS gateway. But there is use case that the functions need to be invoke from a Java service application. It would be great to have an officially supported OpenFaaS Java client and API interface that can be
## Expected Behaviour
<!--- If you're describing a bug, tell us what should happen -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->
This is a feature request. The OpenFaaS Java client would support the same functionalities of the OpenFaaS CLI.
## Current Behaviour
<!--- If describing a bug, tell us what happens instead of the expected behavior -->
<!--- If suggesting a change/improvement, explain the difference from current behavior -->
Currently only CLI is supported in OpenFaaS.
## Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->
There is a third-party Java client implementation that appears to be [generated from OpenFaaS http gateway via swagger.io](https://github.com/cloudatio/openfaas-client-java), but a better defined Java interface that is supported officially by OpenFaaS would be nice.
## Context
<!--- How has this issue affected you? What are you trying to accomplish? -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->
We have Java application that needs to invoke OpenFaaS functions, query Function Store, etc.. similar to what openfaas-cli does that would benefit from an official OpenFaaS Java client.
|
1.0
|
Feature request: SDK for OpenFaaS Gateway - <!-- Due dilligence -->
## My actions before raising this issue
- [ ] Followed the [troubleshooting guide](https://docs.openfaas.com/deployment/troubleshooting/)
- [x] Read/searched [the docs](https://docs.openfaas.com/)
- [ ] Searched [past issues](/issues)
<!--- Provide a general summary of the issue in the Title above -->
OpenFaaS has support of CLI to invoke functions and interact with OpenFaaS gateway. But there is use case that the functions need to be invoke from a Java service application. It would be great to have an officially supported OpenFaaS Java client and API interface that can be
## Expected Behaviour
<!--- If you're describing a bug, tell us what should happen -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->
This is a feature request. The OpenFaaS Java client would support the same functionalities of the OpenFaaS CLI.
## Current Behaviour
<!--- If describing a bug, tell us what happens instead of the expected behavior -->
<!--- If suggesting a change/improvement, explain the difference from current behavior -->
Currently only CLI is supported in OpenFaaS.
## Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->
There is a third-party Java client implementation that appears to be [generated from OpenFaaS http gateway via swagger.io](https://github.com/cloudatio/openfaas-client-java), but a better defined Java interface that is supported officially by OpenFaaS would be nice.
## Context
<!--- How has this issue affected you? What are you trying to accomplish? -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->
We have Java application that needs to invoke OpenFaaS functions, query Function Store, etc.. similar to what openfaas-cli does that would benefit from an official OpenFaaS Java client.
|
design
|
feature request sdk for openfaas gateway my actions before raising this issue followed the read searched searched issues openfaas has support of cli to invoke functions and interact with openfaas gateway but there is use case that the functions need to be invoke from a java service application it would be great to have an officially supported openfaas java client and api interface that can be expected behaviour this is a feature request the openfaas java client would support the same functionalities of the openfaas cli current behaviour currently only cli is supported in openfaas possible solution there is a third party java client implementation that appears to be but a better defined java interface that is supported officially by openfaas would be nice context we have java application that needs to invoke openfaas functions query function store etc similar to what openfaas cli does that would benefit from an official openfaas java client
| 1
|
163,587
| 25,841,240,516
|
IssuesEvent
|
2022-12-13 00:38:58
|
devssa/onde-codar-em-salvador
|
https://api.github.com/repos/devssa/onde-codar-em-salvador
|
closed
|
[PRESENCIAL] [REMOTO]Designer UI/UX na [SANAR]
|
SALVADOR JAVASCRIPT CSS3 HTML UI/UX WIREFRAME PROTOTIPAÇÃO Sketch Figma ADOBE XD ADOBE ILLUSTRATOR METODOLOGIAS ÁGEIS HELP WANTED DESIGN THINKING ZEPLIN PRINCIPLE Stale
|
<!--
==================================================
POR FAVOR, SÓ POSTE SE A VAGA FOR PARA SALVADOR E CIDADES VIZINHAS!
Use: "Desenvolvedor Front-end" ao invés de
"Front-End Developer" \o/
Exemplo: `[JAVASCRIPT] [MYSQL] [NODE.JS] Desenvolvedor Front-End na [NOME DA EMPRESA]`
==================================================
-->
## Designer UI/UX
## Local
- Salvador
## Benefícios
- Vale Transporte ou Auxílio Gasolina
- Vale Alimentação ou Refeição
- Plano de Saúde
#### Diferenciais
- Não temos Dress Code. Você pode vir vestido como quiser (respeitando sempre o outro).
- Aula de Inglês na própria Sanar. Independente do quanto você já sabe, aqui você tem a possibilidade de ter aulas toda semana com nosso teacher, pra aprimorar, aprender, praticar...
- Happy Hour Semanal. Toda semana temos um momento de descontração para nossos sanáticos.
- Sala de Descanso feita pra quem precisa relaxar e descansar um pouco ou pra aquela sonequinha depois do almoço.
- Equipamentos necessários para realizar o seu trabalho. Aqui você não precisa trazer os seus materiais. A Sanar ficará encarregada de entregar tudo que você precisa.
- Instrumentos Musicais para você mostrar seu talento pra gente.
- Jogos para você relaxar. Temos aqui ping pong e xbox.
## Requisitos
**Obrigatórios:**
- … de entendimento do problema do cliente (análise de jornada, indicadores, comportamento e fluxos);
- … de projetar wireframes e protótipos navegáveis de média e alta fidelidade;
- … de avaliar, pesquisar e mensurar soluções existentes ou não para o produto digital;
- … de interagir com um time multidisciplinar;
- … de entregar experiências consistentes entre plataformas e dispositivos;
- … de dar feedbacks e criticar muito suas próprias soluções;
- … de design thinking e design de serviços;
- … de projetar com visão macro e não somente a uma tela isolada;
- … de ferramentas de design como; Sketch, Adobe XD ou Figma;
- … razoável de outras ferramentas como; Photoshop, illustrator, Zeplin e Principle;
- … em utilizar as melhores práticas da indústria e padrões de design como; Hierarquias visuais, style Guide consistência, convenções em UI, pistas visuais, entre outros;
- … em conhecimento em padrões de criação Android e iOS;
- … em utilizar Estrutura de Grids;
- … em organização de librarys;
- … em criação de style guide;
- … em criação de flowcharts;
- … em ter conhecimento razoável de tecnologias que envolvem Frontend (ex. HTML, CSS e JS);
- … em experiência com Design system;
- … em dominar métodos ágeis de produto.
## Sanar
- Sanar em uma empresa digital e de uso criativo das mais modernas tecnologias. Queremos inovar e criar uma experiência relevante para os nossos clientes e para a comunidade de Saúde através de plataformas de educação e de acesso a diversos tipos de conteúdo.
## Como se candidatar
- LINK: https://jobs.kenoby.com/sanar/job/designer-uiux/5c9b6fef12360e0cba84c3e8
|
1.0
|
[PRESENCIAL] [REMOTO]Designer UI/UX na [SANAR] - <!--
==================================================
POR FAVOR, SÓ POSTE SE A VAGA FOR PARA SALVADOR E CIDADES VIZINHAS!
Use: "Desenvolvedor Front-end" ao invés de
"Front-End Developer" \o/
Exemplo: `[JAVASCRIPT] [MYSQL] [NODE.JS] Desenvolvedor Front-End na [NOME DA EMPRESA]`
==================================================
-->
## Designer UI/UX
## Local
- Salvador
## Benefícios
- Vale Transporte ou Auxílio Gasolina
- Vale Alimentação ou Refeição
- Plano de Saúde
#### Diferenciais
- Não temos Dress Code. Você pode vir vestido como quiser (respeitando sempre o outro).
- Aula de Inglês na própria Sanar. Independente do quanto você já sabe, aqui você tem a possibilidade de ter aulas toda semana com nosso teacher, pra aprimorar, aprender, praticar...
- Happy Hour Semanal. Toda semana temos um momento de descontração para nossos sanáticos.
- Sala de Descanso feita pra quem precisa relaxar e descansar um pouco ou pra aquela sonequinha depois do almoço.
- Equipamentos necessários para realizar o seu trabalho. Aqui você não precisa trazer os seus materiais. A Sanar ficará encarregada de entregar tudo que você precisa.
- Instrumentos Musicais para você mostrar seu talento pra gente.
- Jogos para você relaxar. Temos aqui ping pong e xbox.
## Requisitos
**Obrigatórios:**
- … de entendimento do problema do cliente (análise de jornada, indicadores, comportamento e fluxos);
- … de projetar wireframes e protótipos navegáveis de média e alta fidelidade;
- … de avaliar, pesquisar e mensurar soluções existentes ou não para o produto digital;
- … de interagir com um time multidisciplinar;
- … de entregar experiências consistentes entre plataformas e dispositivos;
- … de dar feedbacks e criticar muito suas próprias soluções;
- … de design thinking e design de serviços;
- … de projetar com visão macro e não somente a uma tela isolada;
- … de ferramentas de design como; Sketch, Adobe XD ou Figma;
- … razoável de outras ferramentas como; Photoshop, illustrator, Zeplin e Principle;
- … em utilizar as melhores práticas da indústria e padrões de design como; Hierarquias visuais, style Guide consistência, convenções em UI, pistas visuais, entre outros;
- … em conhecimento em padrões de criação Android e iOS;
- … em utilizar Estrutura de Grids;
- … em organização de librarys;
- … em criação de style guide;
- … em criação de flowcharts;
- … em ter conhecimento razoável de tecnologias que envolvem Frontend (ex. HTML, CSS e JS);
- … em experiência com Design system;
- … em dominar métodos ágeis de produto.
## Sanar
- Sanar em uma empresa digital e de uso criativo das mais modernas tecnologias. Queremos inovar e criar uma experiência relevante para os nossos clientes e para a comunidade de Saúde através de plataformas de educação e de acesso a diversos tipos de conteúdo.
## Como se candidatar
- LINK: https://jobs.kenoby.com/sanar/job/designer-uiux/5c9b6fef12360e0cba84c3e8
|
design
|
designer ui ux na por favor só poste se a vaga for para salvador e cidades vizinhas use desenvolvedor front end ao invés de front end developer o exemplo desenvolvedor front end na designer ui ux local salvador benefícios vale transporte ou auxílio gasolina vale alimentação ou refeição plano de saúde diferenciais não temos dress code você pode vir vestido como quiser respeitando sempre o outro aula de inglês na própria sanar independente do quanto você já sabe aqui você tem a possibilidade de ter aulas toda semana com nosso teacher pra aprimorar aprender praticar happy hour semanal toda semana temos um momento de descontração para nossos sanáticos sala de descanso feita pra quem precisa relaxar e descansar um pouco ou pra aquela sonequinha depois do almoço equipamentos necessários para realizar o seu trabalho aqui você não precisa trazer os seus materiais a sanar ficará encarregada de entregar tudo que você precisa instrumentos musicais para você mostrar seu talento pra gente jogos para você relaxar temos aqui ping pong e xbox requisitos obrigatórios … de entendimento do problema do cliente análise de jornada indicadores comportamento e fluxos … de projetar wireframes e protótipos navegáveis de média e alta fidelidade … de avaliar pesquisar e mensurar soluções existentes ou não para o produto digital … de interagir com um time multidisciplinar … de entregar experiências consistentes entre plataformas e dispositivos … de dar feedbacks e criticar muito suas próprias soluções … de design thinking e design de serviços … de projetar com visão macro e não somente a uma tela isolada … de ferramentas de design como sketch adobe xd ou figma … razoável de outras ferramentas como photoshop illustrator zeplin e principle … em utilizar as melhores práticas da indústria e padrões de design como hierarquias visuais style guide consistência convenções em ui pistas visuais entre outros … em conhecimento em padrões de criação android e ios … em utilizar estrutura de grids … em organização de librarys … em criação de style guide … em criação de flowcharts … em ter conhecimento razoável de tecnologias que envolvem frontend ex html css e js … em experiência com design system … em dominar métodos ágeis de produto sanar sanar em uma empresa digital e de uso criativo das mais modernas tecnologias queremos inovar e criar uma experiência relevante para os nossos clientes e para a comunidade de saúde através de plataformas de educação e de acesso a diversos tipos de conteúdo como se candidatar link
| 1
|
35,151
| 30,793,827,455
|
IssuesEvent
|
2023-07-31 18:13:29
|
microsoft/microsoft-ui-xaml
|
https://api.github.com/repos/microsoft/microsoft-ui-xaml
|
closed
|
Unit Test run crashes when calling Microsoft.UI.Xaml.Application.Start
|
area-TestInfrastructure team-Markup product-winui3 no-issue-activity
|
**Describe the bug**
I've been trying to launch a WinUI dialog from my test project for UI testing, but the app crashes (with not catchable callstack or breakpoint), when calling ` global::Microsoft.UI.Xaml.Application.Start(...)`;
**Steps to reproduce the bug**
1. Open the attached project:
[UnitTestApp.zip](https://github.com/microsoft/microsoft-ui-xaml/files/5655691/UnitTestApp.zip)
2. Verify that the application will launch with normal F5 debugging and an empty window will show.
3. In `TestInitializer.cs` line 21 where the Start call is, place a breakpoint.
4. From TestExplorer, start debugging the tests.
5. Step through the code and verify that the exact same code that worked fine when launching the app, fails when launched from test explorer.
**Expected behavior**
Window opens successfully.
**Version Info**
<!-- Please enter your WinUI NuGet package version, Windows app type (when using WinUI 3+), OS version(s), and form factor(s) -->
NuGet package version:
[Microsoft.WinUI 3.0.0-preview3.201113.0]
<!-- If you are using WinUI 3, please specify for which Windows app type you have encountered the issue. Leave blank if you didn't try that app type. -->
Windows app type:
| UWP | Win32 |
| :--------------- | :--------------- |
| <!-- Yes/No? --> | Yes |
<!-- Which Windows versions did you see the issue on? Leave blank if you didn't try that version. -->
| Windows 10 version | Saw the problem? |
| :--------------------------------- | :-------------------- |
| Insider Build (xxxxx) | <!-- Yes/No? --> |
| May 2020 Update (19041) | <!-- Yes/No? --> |
| November 2019 Update (18363) | <!-- Yes/No? --> |
| May 2019 Update (18362) | <!-- Yes/No? --> |
| October 2018 Update (17763) | <!-- Yes/No? --> |
| April 2018 Update (17134) | <!-- Yes/No? --> |
| Fall Creators Update (16299) | <!-- Yes/No? --> |
| Creators Update (15063) | <!-- Yes/No? --> |
<!-- Which device form factors did you see the issue on? Leave blank if you didn't try that device. -->
| Device form factor | Saw the problem? |
| :----------------- | :--------------- |
| Desktop | Yes |
| Xbox | <!-- Yes/No? --> |
| Surface Hub | <!-- Yes/No? --> |
| IoT | <!-- Yes/No? --> |
**Additional context**
<!-- Enter any other applicable info here -->
|
1.0
|
Unit Test run crashes when calling Microsoft.UI.Xaml.Application.Start - **Describe the bug**
I've been trying to launch a WinUI dialog from my test project for UI testing, but the app crashes (with not catchable callstack or breakpoint), when calling ` global::Microsoft.UI.Xaml.Application.Start(...)`;
**Steps to reproduce the bug**
1. Open the attached project:
[UnitTestApp.zip](https://github.com/microsoft/microsoft-ui-xaml/files/5655691/UnitTestApp.zip)
2. Verify that the application will launch with normal F5 debugging and an empty window will show.
3. In `TestInitializer.cs` line 21 where the Start call is, place a breakpoint.
4. From TestExplorer, start debugging the tests.
5. Step through the code and verify that the exact same code that worked fine when launching the app, fails when launched from test explorer.
**Expected behavior**
Window opens successfully.
**Version Info**
<!-- Please enter your WinUI NuGet package version, Windows app type (when using WinUI 3+), OS version(s), and form factor(s) -->
NuGet package version:
[Microsoft.WinUI 3.0.0-preview3.201113.0]
<!-- If you are using WinUI 3, please specify for which Windows app type you have encountered the issue. Leave blank if you didn't try that app type. -->
Windows app type:
| UWP | Win32 |
| :--------------- | :--------------- |
| <!-- Yes/No? --> | Yes |
<!-- Which Windows versions did you see the issue on? Leave blank if you didn't try that version. -->
| Windows 10 version | Saw the problem? |
| :--------------------------------- | :-------------------- |
| Insider Build (xxxxx) | <!-- Yes/No? --> |
| May 2020 Update (19041) | <!-- Yes/No? --> |
| November 2019 Update (18363) | <!-- Yes/No? --> |
| May 2019 Update (18362) | <!-- Yes/No? --> |
| October 2018 Update (17763) | <!-- Yes/No? --> |
| April 2018 Update (17134) | <!-- Yes/No? --> |
| Fall Creators Update (16299) | <!-- Yes/No? --> |
| Creators Update (15063) | <!-- Yes/No? --> |
<!-- Which device form factors did you see the issue on? Leave blank if you didn't try that device. -->
| Device form factor | Saw the problem? |
| :----------------- | :--------------- |
| Desktop | Yes |
| Xbox | <!-- Yes/No? --> |
| Surface Hub | <!-- Yes/No? --> |
| IoT | <!-- Yes/No? --> |
**Additional context**
<!-- Enter any other applicable info here -->
|
non_design
|
unit test run crashes when calling microsoft ui xaml application start describe the bug i ve been trying to launch a winui dialog from my test project for ui testing but the app crashes with not catchable callstack or breakpoint when calling global microsoft ui xaml application start steps to reproduce the bug open the attached project verify that the application will launch with normal debugging and an empty window will show in testinitializer cs line where the start call is place a breakpoint from testexplorer start debugging the tests step through the code and verify that the exact same code that worked fine when launching the app fails when launched from test explorer expected behavior window opens successfully version info nuget package version windows app type uwp yes windows version saw the problem insider build xxxxx may update november update may update october update april update fall creators update creators update device form factor saw the problem desktop yes xbox surface hub iot additional context
| 0
|
95,847
| 12,056,158,672
|
IssuesEvent
|
2020-04-15 14:04:08
|
betagouv/mon-entreprise
|
https://api.github.com/repos/betagouv/mon-entreprise
|
closed
|
Créer une page /budget
|
:art: design :mega: communication
|
Mon-entreprise étant financé par de l'argent public, il convient d'être le plus transparent possible sur les ressources allouées et la manière dont elles sont employées.
* Reprendre les données historiques consolidées par @laem dans https://github.com/betagouv/beta.gouv.fr/pull/3088
* Exporter un rapport des dépenses par grande catégorie avec notre logiciel comptable `hledger bal charges -Y -B --depth 2` (malheureusement hledger ne supporte pas encore l'export json cf. https://github.com/simonmichael/hledger/issues/689 mais la sortie texte de la CLI est facilement exploitable par un script)
* Organiser la page en deux grandes sections :
1. Ressources (mettre un texte contextuel, lien vers la convention)
2. Emploi des ressources par catégorie (avec un texte d'explication pour chaque catégorie)
* **Logiciels 💻** « Majorité des outils gratuits car site open-source, on utilise Netlify pour héberger notre site statique blah blah »
* **Déplacements 🚅** « Réseau des URSSAF dans toute la France, on organise des ateliers blah blah »
* **Développement 👨💻** « Majorité du budget, nous utilisons des dev freelances qui doivent être polyvalents blah blah »
* **Documentation 📖** « Revue spécialisées qui nous sont utiles blah blah)
* **Marges des attributaires du marché public 🏢** Faire aussi la transparence sur le montant des marges des attributaires du marché ?
Cette page devra aussi référencer la page `/nouveautés` (ce que nous avons développé grâce à ce budget) et une page `/stats` retravaillée (nos indicateurs) #811. Comme sur toutes les pages, un module permettra de récolter les retours utilisateurs.
|
1.0
|
Créer une page /budget - Mon-entreprise étant financé par de l'argent public, il convient d'être le plus transparent possible sur les ressources allouées et la manière dont elles sont employées.
* Reprendre les données historiques consolidées par @laem dans https://github.com/betagouv/beta.gouv.fr/pull/3088
* Exporter un rapport des dépenses par grande catégorie avec notre logiciel comptable `hledger bal charges -Y -B --depth 2` (malheureusement hledger ne supporte pas encore l'export json cf. https://github.com/simonmichael/hledger/issues/689 mais la sortie texte de la CLI est facilement exploitable par un script)
* Organiser la page en deux grandes sections :
1. Ressources (mettre un texte contextuel, lien vers la convention)
2. Emploi des ressources par catégorie (avec un texte d'explication pour chaque catégorie)
* **Logiciels 💻** « Majorité des outils gratuits car site open-source, on utilise Netlify pour héberger notre site statique blah blah »
* **Déplacements 🚅** « Réseau des URSSAF dans toute la France, on organise des ateliers blah blah »
* **Développement 👨💻** « Majorité du budget, nous utilisons des dev freelances qui doivent être polyvalents blah blah »
* **Documentation 📖** « Revue spécialisées qui nous sont utiles blah blah)
* **Marges des attributaires du marché public 🏢** Faire aussi la transparence sur le montant des marges des attributaires du marché ?
Cette page devra aussi référencer la page `/nouveautés` (ce que nous avons développé grâce à ce budget) et une page `/stats` retravaillée (nos indicateurs) #811. Comme sur toutes les pages, un module permettra de récolter les retours utilisateurs.
|
design
|
créer une page budget mon entreprise étant financé par de l argent public il convient d être le plus transparent possible sur les ressources allouées et la manière dont elles sont employées reprendre les données historiques consolidées par laem dans exporter un rapport des dépenses par grande catégorie avec notre logiciel comptable hledger bal charges y b depth malheureusement hledger ne supporte pas encore l export json cf mais la sortie texte de la cli est facilement exploitable par un script organiser la page en deux grandes sections ressources mettre un texte contextuel lien vers la convention emploi des ressources par catégorie avec un texte d explication pour chaque catégorie logiciels 💻 « majorité des outils gratuits car site open source on utilise netlify pour héberger notre site statique blah blah » déplacements 🚅 « réseau des urssaf dans toute la france on organise des ateliers blah blah » développement 👨💻 « majorité du budget nous utilisons des dev freelances qui doivent être polyvalents blah blah » documentation 📖 « revue spécialisées qui nous sont utiles blah blah marges des attributaires du marché public 🏢 faire aussi la transparence sur le montant des marges des attributaires du marché cette page devra aussi référencer la page nouveautés ce que nous avons développé grâce à ce budget et une page stats retravaillée nos indicateurs comme sur toutes les pages un module permettra de récolter les retours utilisateurs
| 1
|
69,585
| 8,434,706,137
|
IssuesEvent
|
2018-10-17 11:00:31
|
emfoundation/ce100-app
|
https://api.github.com/repos/emfoundation/ce100-app
|
opened
|
User profile - Add the word edit to the edit button
|
design
|
As there will only be one way to edit the content on personal profiles, we should make the edit button stand out more. To do this we should add the word 'edit' next to the pen icon.
Current design:
New design:
|
1.0
|
User profile - Add the word edit to the edit button - As there will only be one way to edit the content on personal profiles, we should make the edit button stand out more. To do this we should add the word 'edit' next to the pen icon.
Current design:
New design:
|
design
|
user profile add the word edit to the edit button as there will only be one way to edit the content on personal profiles we should make the edit button stand out more to do this we should add the word edit next to the pen icon current design new design
| 1
|
69,914
| 8,471,127,692
|
IssuesEvent
|
2018-10-24 07:32:48
|
maputnik/editor
|
https://api.github.com/repos/maputnik/editor
|
closed
|
Symbols: “Image” property low in the “Icon layout properties” section
|
design discussion good first issue mentioned in the 1st survey
|
The “Text layout properties” section begins with the “Field“ (content) property. It makes sense.
The “Icon layout properties” section begins with the “Allow overlap” property. Weird and unfriendly.
Could we move the “Image“ property to the top of the “Icon layout properties” section?
|
1.0
|
Symbols: “Image” property low in the “Icon layout properties” section - The “Text layout properties” section begins with the “Field“ (content) property. It makes sense.
The “Icon layout properties” section begins with the “Allow overlap” property. Weird and unfriendly.
Could we move the “Image“ property to the top of the “Icon layout properties” section?
|
design
|
symbols “image” property low in the “icon layout properties” section the “text layout properties” section begins with the “field“ content property it makes sense the “icon layout properties” section begins with the “allow overlap” property weird and unfriendly could we move the “image“ property to the top of the “icon layout properties” section
| 1
|
12,381
| 3,072,089,872
|
IssuesEvent
|
2015-08-19 15:20:21
|
myfossil/myfossil-theme
|
https://api.github.com/repos/myfossil/myfossil-theme
|
closed
|
Profile image upload process is unclear
|
design
|
To change a profile image a user navigates to the Profile tab, then selects "Change Profile Photo". To upload an image, the user must click "Browse", then find the image. After finding an image to upload, it is unclear that the user should click the "Upload Image" button.
|
1.0
|
Profile image upload process is unclear - To change a profile image a user navigates to the Profile tab, then selects "Change Profile Photo". To upload an image, the user must click "Browse", then find the image. After finding an image to upload, it is unclear that the user should click the "Upload Image" button.
|
design
|
profile image upload process is unclear to change a profile image a user navigates to the profile tab then selects change profile photo to upload an image the user must click browse then find the image after finding an image to upload it is unclear that the user should click the upload image button
| 1
|
11,881
| 3,023,591,126
|
IssuesEvent
|
2015-08-01 17:19:38
|
CartoDB/academy
|
https://api.github.com/repos/CartoDB/academy
|
opened
|
add line numbering for code snippets
|
design
|
the default line numbering for the {% highlight lang linenos %} don't allow easy cut and paste
|
1.0
|
add line numbering for code snippets - the default line numbering for the {% highlight lang linenos %} don't allow easy cut and paste
|
design
|
add line numbering for code snippets the default line numbering for the highlight lang linenos don t allow easy cut and paste
| 1
|
132,815
| 10,764,995,450
|
IssuesEvent
|
2019-11-01 09:50:44
|
appium/appium
|
https://api.github.com/repos/appium/appium
|
closed
|
[iOS] Appium returns wrong element attribute value
|
ThirdParty XCUITest
|
## The problem
I am trying to get elements attribute "value" value. At first, I print page source (pasting here just one element I am interested in):
```
<XCUIElementTypeSwitch type="XCUIElementTypeSwitch" value="1" name="s_settings_online_switch_value" label="Use online shopping" enabled="true" visible="true" x="349" y="385" width="51" height="32"/>
```
Here I clearly see that value=1. Next, I am calling GetAttribute method to find attributes "value" value. I get that value=0. Appium server log's shows:
```
2019-10-23 09:27:02:394 [MJSONWP (d360e76d)] Calling AppiumDriver.getAttribute() with args: ["value","32010000-0000-0000-3607-000000000000","d360e76d-af5e-4883-87c8-4c6663172511"]
2019-10-23 09:27:02:394 [XCUITest] Executing command 'getAttribute'
2019-10-23 09:27:02:396 [WD Proxy] Matched '/element/32010000-0000-0000-3607-000000000000/attribute/value' to command name 'getAttribute'
2019-10-23 09:27:02:396 [WD Proxy] Proxying [GET /element/32010000-0000-0000-3607-000000000000/attribute/value] to [GET http://localhost:8103/session/1253BD09-66C2-47A6-91DA-FC8EEB3D47E3/element/32010000-0000-0000-3607-000000000000/attribute/value] with no body
2019-10-23 09:27:03:025 [WD Proxy] Got response with status 200: {
2019-10-23 09:27:03:026 [WD Proxy] "value" : "0",
2019-10-23 09:27:03:026 [WD Proxy] "sessionId" : "1253BD09-66C2-47A6-91DA-FC8EEB3D47E3"
2019-10-23 09:27:03:026 [WD Proxy] }
2019-10-23 09:27:03:026 [MJSONWP (d360e76d)] Responding to client with driver.getAttribute() result: "0"
```
I have encountered this after updating Appium from 1.14.2 to 1.15.1.
## Environment
* Appium version (or git revision) that exhibits the issue: 1.15.1
* Last Appium version that did not exhibit the issue (if applicable): 1.14.2
* Desktop OS/version used to run Appium: macOS Mojave 10.14.6
* Node.js version (unless using Appium.app|exe): 10.16.3
* Npm or Yarn package manager: 6.9.0
* Mobile platform/version under test: iOS 11.0.3
* Real device or emulator/simulator: real device iPhone 6s+
* Appium CLI or Appium.app|exe: 1.15.1
## Code To Reproduce Issue [ Good To Have ]
Something like this:
```
var state = element.GetAttribute("value");
```
|
1.0
|
[iOS] Appium returns wrong element attribute value - ## The problem
I am trying to get elements attribute "value" value. At first, I print page source (pasting here just one element I am interested in):
```
<XCUIElementTypeSwitch type="XCUIElementTypeSwitch" value="1" name="s_settings_online_switch_value" label="Use online shopping" enabled="true" visible="true" x="349" y="385" width="51" height="32"/>
```
Here I clearly see that value=1. Next, I am calling GetAttribute method to find attributes "value" value. I get that value=0. Appium server log's shows:
```
2019-10-23 09:27:02:394 [MJSONWP (d360e76d)] Calling AppiumDriver.getAttribute() with args: ["value","32010000-0000-0000-3607-000000000000","d360e76d-af5e-4883-87c8-4c6663172511"]
2019-10-23 09:27:02:394 [XCUITest] Executing command 'getAttribute'
2019-10-23 09:27:02:396 [WD Proxy] Matched '/element/32010000-0000-0000-3607-000000000000/attribute/value' to command name 'getAttribute'
2019-10-23 09:27:02:396 [WD Proxy] Proxying [GET /element/32010000-0000-0000-3607-000000000000/attribute/value] to [GET http://localhost:8103/session/1253BD09-66C2-47A6-91DA-FC8EEB3D47E3/element/32010000-0000-0000-3607-000000000000/attribute/value] with no body
2019-10-23 09:27:03:025 [WD Proxy] Got response with status 200: {
2019-10-23 09:27:03:026 [WD Proxy] "value" : "0",
2019-10-23 09:27:03:026 [WD Proxy] "sessionId" : "1253BD09-66C2-47A6-91DA-FC8EEB3D47E3"
2019-10-23 09:27:03:026 [WD Proxy] }
2019-10-23 09:27:03:026 [MJSONWP (d360e76d)] Responding to client with driver.getAttribute() result: "0"
```
I have encountered this after updating Appium from 1.14.2 to 1.15.1.
## Environment
* Appium version (or git revision) that exhibits the issue: 1.15.1
* Last Appium version that did not exhibit the issue (if applicable): 1.14.2
* Desktop OS/version used to run Appium: macOS Mojave 10.14.6
* Node.js version (unless using Appium.app|exe): 10.16.3
* Npm or Yarn package manager: 6.9.0
* Mobile platform/version under test: iOS 11.0.3
* Real device or emulator/simulator: real device iPhone 6s+
* Appium CLI or Appium.app|exe: 1.15.1
## Code To Reproduce Issue [ Good To Have ]
Something like this:
```
var state = element.GetAttribute("value");
```
|
non_design
|
appium returns wrong element attribute value the problem i am trying to get elements attribute value value at first i print page source pasting here just one element i am interested in here i clearly see that value next i am calling getattribute method to find attributes value value i get that value appium server log s shows calling appiumdriver getattribute with args executing command getattribute matched element attribute value to command name getattribute proxying to with no body got response with status value sessionid responding to client with driver getattribute result i have encountered this after updating appium from to environment appium version or git revision that exhibits the issue last appium version that did not exhibit the issue if applicable desktop os version used to run appium macos mojave node js version unless using appium app exe npm or yarn package manager mobile platform version under test ios real device or emulator simulator real device iphone appium cli or appium app exe code to reproduce issue something like this var state element getattribute value
| 0
|
94,713
| 11,904,974,377
|
IssuesEvent
|
2020-03-30 17:45:42
|
MozillaFoundation/Design
|
https://api.github.com/repos/MozillaFoundation/Design
|
closed
|
Create Thank You Card Template for Staff Anniversaries
|
design
|
Placeholder ticket to track work for creating a Thank you card template for staff anniversaries.
Stakeholder interview with Mandy [here](https://docs.google.com/document/d/1qBGP2EXrrehJoigm1CpT3zNIR8YtVMcE5XVX32Jp4wg/edit?usp=sharing).
Mandy has mentioned that digital cards would be the priority at this point.
cc: @kristinashu
|
1.0
|
Create Thank You Card Template for Staff Anniversaries - Placeholder ticket to track work for creating a Thank you card template for staff anniversaries.
Stakeholder interview with Mandy [here](https://docs.google.com/document/d/1qBGP2EXrrehJoigm1CpT3zNIR8YtVMcE5XVX32Jp4wg/edit?usp=sharing).
Mandy has mentioned that digital cards would be the priority at this point.
cc: @kristinashu
|
design
|
create thank you card template for staff anniversaries placeholder ticket to track work for creating a thank you card template for staff anniversaries stakeholder interview with mandy mandy has mentioned that digital cards would be the priority at this point cc kristinashu
| 1
|
276,982
| 21,007,847,924
|
IssuesEvent
|
2022-03-30 01:36:06
|
ethyca/fides
|
https://api.github.com/repos/ethyca/fides
|
opened
|
Update README Quickstart to suggest a `pip install`
|
documentation
|
### Docs Update Description
Having users need both `Docker` and `Make` just to do a quick demo seems like too high of a barrier. We have the resources in the repo for people to to a direct `pip install` and go from there for a quick demo, then pointing them to the real docs for more of an in-depth setup.
### Additional context
Some people might not want to use docker or make, and our quickstart in the README might discourage those people
|
1.0
|
Update README Quickstart to suggest a `pip install` - ### Docs Update Description
Having users need both `Docker` and `Make` just to do a quick demo seems like too high of a barrier. We have the resources in the repo for people to to a direct `pip install` and go from there for a quick demo, then pointing them to the real docs for more of an in-depth setup.
### Additional context
Some people might not want to use docker or make, and our quickstart in the README might discourage those people
|
non_design
|
update readme quickstart to suggest a pip install docs update description having users need both docker and make just to do a quick demo seems like too high of a barrier we have the resources in the repo for people to to a direct pip install and go from there for a quick demo then pointing them to the real docs for more of an in depth setup additional context some people might not want to use docker or make and our quickstart in the readme might discourage those people
| 0
|
125,504
| 16,813,153,473
|
IssuesEvent
|
2021-06-17 02:18:19
|
greatnewcls/2JQ3WXOOQYAKRR6UT4A4HV35
|
https://api.github.com/repos/greatnewcls/2JQ3WXOOQYAKRR6UT4A4HV35
|
reopened
|
tWh1FoOlrKYe4I8s/Z4oJv+lop/jrQEsWVJPowQ9flpgp7Q2G+T1y2gw8nUpMv8PUK43NzpNILSZ6vZPc0DC2dzA2YkKLVf42/jPRk03TsFQ/7bDclL87voEzgNVb0Tg7lFVtXnM7cu2Fu9oxBmHDTHqY37QbJJwZ9TMRCnm4bk=
|
design
|
d4RD8Hn6d1hTtH+quPtImmvQMotDZNyD2qY1gs6rQU5VYtL3nAzj1tl6hz2zN7aiW53D4iZ6CB/vCAEa13hbpZ74XwGf4Wenis/4q9xsCVeVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTim2kFhYak/kfUDu2zBbLi5bncPiJnoIH+8IARrXeFulJPNKldr8A9uBqT4Ot4zDC49SVnrBJDZerZ5J6MgVGApr0DKLQ2Tcg9qmNYLOq0FO5InUf2W0KO4Kq3wVMm3EhVudw+Imeggf7wgBGtd4W6U+MAhATOsanukWId5fiP34u1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU6cNSPgo9uE2Xxw5g7tK020W53D4iZ6CB/vCAEa13hbpc2HcsqklyFBl+0WcSqOCv1z+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTgU7uoGWaLDG4bd0zZAKsbJbncPiJnoIH+8IARrXeFulRHuHKTxJlhsgyHd3XV+iPwwxBywgMnuT7ogs4qiGIk6qT3wMxcx7P+ds2AlmFH8kO+hMtWo0a46FvjOSbgAAC1udw+Imeggf7wgBGtd4W6VEi86wD2VPAN84fn+OQV3tsdoF/bsKLvMyFCQDFfJR2h4FBoLYnu5ft+NDEU5unm2azomRd9hTS8OxKE8/sHKHW53D4iZ6CB/vCAEa13hbpTi7D4cMWXCGWFg3pH4zxMGUHJ27bbpJqp5Yb8Qpxl3Y0Vp6k9mv0CKgRG2B1EHGpOU2cgjDFX3LOo9ubPORhDpbncPiJnoIH+8IARrXeFulLrVvExKHL5kf2qnsxe9QdbHaBf27Ci7zMhQkAxXyUdoeBQaC2J7uX7fjQxFObp5tyASs96QVIOk++uFsOZIoKludw+Imeggf7wgBGtd4W6VRy/KOoRozBGQY616cgUakwjIV+Itg/SAVTi3etVreCdFaepPZr9AioERtgdRBxqSKMvxHoHsIQDH0DEZwMdwTvpDuiFyuoWHq2R3YOxOcdq9ZXdrse1VB/vTOUDqhARlz+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTj+WFiLCBjW5Efsby3iz3H1bncPiJnoIH+8IARrXeFul1y30Xix5s8dMQeagrjs9M476548Cf85iNG7OV1SmDADTcpsePQliMfdLmaHieFGCVGKNBxWq9xClxfLTUFg6YFudw+Imeggf7wgBGtd4W6XzWqhgYqDLDKfpzBIBYUSflNWaBSpCC8IOCjL0lIMe/R4aw2axVnzM07tFPR2nzOVJapzRhIsVsqX9ws73CNCUW53D4iZ6CB/vCAEa13hbpdr1O4ym5Jc0lZiITp+Q0dHL23gsdjrCOus5s7kMD9zGHhrDZrFWfMzTu0U9HafM5SDRP6JTpX/+jKvv4Mb3XVtbncPiJnoIH+8IARrXeFulhChr42Agc5HnnuxQXXKZV1NRlFaunLzPKkl4GsOQwxhr0DKLQ2Tcg9qmNYLOq0FOrGI6u7480/HavvNNu8GCpVudw+Imeggf7wgBGtd4W6Vc8Ji3Sk2p8hRCL5ZBYt1LvBdQUxXO7NfThIrS6WXbEGvQMotDZNyD2qY1gs6rQU74hmDwcS/LoekccsDYL/6gW53D4iZ6CB/vCAEa13hbpbW8EtNMtGovSAR7nPhpt9mlxM8NfTKC2TlE5jKA/8tl03KbHj0JYjH3S5mh4nhRghP2RKEv2mBrALx1C5fK0f1bncPiJnoIH+8IARrXeFul79b88qnPUCH3A60qxAfDl5+F/iezLRZ8X0a959EaIlTRWnqT2a/QIqBEbYHUQcakZHDOTVE1kLubbsRrIkXXC76Q7ohcrqFh6tkd2DsTnHbpBeiUhjouwPJ0NgTadmxGmLPitMHMj/AD6thqlGYSmdFaepPZr9AioERtgdRBxqQ8wMUvlJUXPH8crYB2qNRbvpDuiFyuoWHq2R3YOxOcdrJQ8hbi6MwyTnwuOwdeLD3CLw888NpsEeHVpfYnnMVS0Vp6k9mv0CKgRG2B1EHGpM37Vr6F3zX0G5Ve3pcMIYRbncPiJnoIH+8IARrXeFulejBAPNz9uEZUZ6SPMsZ7aVTSj72UkaVlMY43cGW4iW1p/9bNGKl0rF/QEZxXwYuwNgKI+gQzo/T7EAHcpuWJRVudw+Imeggf7wgBGtd4W6XjnRyYx+lQlCuH2+VOV1gOS35wwhAWcYcbq/A0daSpdWn/1s0YqXSsX9ARnFfBi7Bm9Xz9QzuNWKwNyqsLl5HoW53D4iZ6CB/vCAEa13hbpeDXKZY+DQjk3w0+D+v1EK+P6gBazektn545OheglO0Gaf/WzRipdKxf0BGcV8GLsM/IwTw0WS2rinHAQNBFd/hbncPiJnoIH+8IARrXeFulOGnMSz+eIqGQ9AyxSi+YjJUdylfm5KtpMS/qyyzgED5r0DKLQ2Tcg9qmNYLOq0FOkrVT1uYIkNyEUkUuTmpm4Fudw+Imeggf7wgBGtd4W6UhN9MAfpYwKsclHG2xC6JQu1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU558AO0cY3o8mIJPEcz6yTEW53D4iZ6CB/vCAEa13hbpVXph9lf3ha1zePo5TLPwjF0Ydp/kwJ5ghu6lRZcTI0RHhrDZrFWfMzTu0U9HafM5afSj76POf4UBcGGc02KSnpbncPiJnoIH+8IARrXeFuliLraO5guPAqCfz29EmgzUawzOBLCd823QHSfq70lXetE9jj7vCUZCgg50cfZOgcnqzdyuArbrbB8rptQFCebn1udw+Imeggf7wgBGtd4W6VzADCCBT0sYJ8JeZgnScZ3mLPitMHMj/AD6thqlGYSmdFaepPZr9AioERtgdRBxqRspj1KRvBgcuCJvvmlAw88vpDuiFyuoWHq2R3YOxOcdobImS9kUCXkPAlUhCpg1rkzqQYr+bJEbu6+XU4YCjNS03KbHj0JYjH3S5mh4nhRggEkZUKkp+5p96yATOXtLb5bncPiJnoIH+8IARrXeFulbGccVUMSGhetqyFHM8mtrU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOY1vdXhN8JTO8IhLBFnT+lludw+Imeggf7wgBGtd4W6U3H7IIktH07NMeNMCpsMpau1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU6mcm0eybLiX5d1idwHsbUOW53D4iZ6CB/vCAEa13hbpVPxaIQef2ZZIE53fI8aRhWPUlZ6wSQ2Xq2eSejIFRgKa9Ayi0Nk3IPapjWCzqtBTvmHZviczKPspfakEqnSbRdbncPiJnoIH+8IARrXeFulMxSGi/R7r1qPzo1SqQOHaI9SVnrBJDZerZ5J6MgVGApr0DKLQ2Tcg9qmNYLOq0FOfeis5BrwcUMa7HXClQTQWVudw+Imeggf7wgBGtd4W6UcIjbe6ooZwF1FCva0l+UzwjIV+Itg/SAVTi3etVreCdFaepPZr9AioERtgdRBxqRRtave5qzgGYlNHPnC6fWXvpDuiFyuoWHq2R3YOxOcdqXvZdM4vY8p0RcpmsuisHidLUkrTh40kyxG5wbazFk0HhrDZrFWfMzTu0U9HafM5RfjahhQH5hsijMXX7FYmT5bncPiJnoIH+8IARrXeFulRfVV9f6ca2UtqqQ97uQmwU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOUv37/x4LVi13Lr4QGBuIxVudw+Imeggf7wgBGtd4W6U8yCF8NiKr1skP/anD+u/Wj1JWesEkNl6tnknoyBUYCmvQMotDZNyD2qY1gs6rQU5iYQyp3zHQx5mv97rcwSeaW53D4iZ6CB/vCAEa13hbpd7hHSqNodhUFsn5+zbh+2a7U6PhlNz6FStlVim3wUD0a9Ayi0Nk3IPapjWCzqtBTlRFlccy0G1NC8CK2VqjMZdbncPiJnoIH+8IARrXeFul9sdldiuMidnI8CS/UQyorqx1U7uuLuF3Y5drzcHKJSa/Gk52SghhPyffxzxrOx9oJQZQzKBErQWJ0M+5P8nvzb6Q7ohcrqFh6tkd2DsTnHaV0us05V49NKgREbmhG1AZJCndXqiqME5vlEGBCPxG19Nymx49CWIx90uZoeJ4UYLVg6kzrQxIKem0s5iD+kyrW53D4iZ6CB/vCAEa13hbpSL9FovhMD1mqfhEutzjVWCVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTpU3qOejzMwLHJDnOHZqfSBbncPiJnoIH+8IARrXeFuly6PRY7yF25WIsHo9VyYJJZUdylfm5KtpMS/qyyzgED5r0DKLQ2Tcg9qmNYLOq0FOz1wbzB3GfiUSJrLP/6XLW1udw+Imeggf7wgBGtd4W6VcBdXnxiK1SiRe64lG7jPFs9zxHMSM3+mU/TuYBvBhJR4aw2axVnzM07tFPR2nzOWgalOrUlnINETW85MHc1lAW53D4iZ6CB/vCAEa13hbpSBJqIIQaVoRilpNEYRkKGVPwojUTrjGXEpXHjjboFbea9Ayi0Nk3IPapjWCzqtBTu0+7s3MXMn1aksGXKcQn5lbncPiJnoIH+8IARrXeFulptamwxQU85FNNVH0+nYgUU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOnb69e0OSnB1Xt9Nfwt/7f1udw+Imeggf7wgBGtd4W6VjPwx98kU6KWeCGuj5bAsdc/mn2zl0jaDAnw122r3xf2vQMotDZNyD2qY1gs6rQU5LCW/vP3lNPQ02iEH1iTj8W53D4iZ6CB/vCAEa13hbpRgpo10Kc3M/wBLXR4OKuGmVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTjuKtxRsRQkBBT7Bt8RLiSxbncPiJnoIH+8IARrXeFulKnvYcaogJ06VFTmtgZOf7E/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOjfuSBX+ES1AVGRDREkkaDVudw+Imeggf7wgBGtd4W6Xhfd+4rFD+5acvz3Cl4z25lR3KV+bkq2kxL+rLLOAQPmvQMotDZNyD2qY1gs6rQU71KRCPUUV7ZifOZGxg9cNPW53D4iZ6CB/vCAEa13hbpVfqdKptWawgXZIWnzIXZxAddqY+OPs1ZLzoQYGGLQv2PNvP2eEQ25Yk+mUjhXHj3e5MfXc0Z/F7lEumBY0moclbncPiJnoIH+8IARrXeFul9piLB1vjzi+/BkCDoEy6MB1yUxogzt18K2ZQbFkMxMjoLNf1YOPpI8RTJVigoBchINVqz7mRVbISt8CL31wNQVudw+Imeggf7wgBGtd4W6W74i5flDH3xRnKmEA8aoChlR3KV+bkq2kxL+rLLOAQPmvQMotDZNyD2qY1gs6rQU7xbObUIZm1MHjuG3wUWuCgW53D4iZ6CB/vCAEa13hbpepFruTUqhTqy9FQ8K4LuOaHb3PcN0MDOmWStBtDaXcjP7H16UJ9Gh9J6RmQkQZNAWtR7ZS5fKGOU5arXIQEyTtbncPiJnoIH+8IARrXeFuliwaBFt55jJwjq37pEAuOVyUpn10VP/TKo7muABAyVL8eBQaC2J7uX7fjQxFObp5tTWSe0f5PNqIpuKEUvil7vludw+Imeggf7wgBGtd4W6X7w+XY6EMS4yanpgwENVJqT8KI1E64xlxKVx4426BW3mvQMotDZNyD2qY1gs6rQU4wvxjUP6JWLhZ8UplNk3QVW53D4iZ6CB/vCAEa13hbpf337FTfdaQtA2391ETa3iZz+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTrAh1Q2m9pyrPTP1/DIPj+lbncPiJnoIH+8IARrXeFula3Dxw+V6F0VPE58M4MKowW6U4Yk13gVhgE1Z9o/M3+YBg58RFdIu4YfWuFUY3w2h195vm7teh1UFZkp8RG21Y1udw+Imeggf7wgBGtd4W6Vy+4FURINpdAFaoKm5WhABu1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU5xZIixD8anJC+MPRJQugfOW53D4iZ6CB/vCAEa13hbpXR3T0JJjxJffUgY6cw3+5Nm1eKS9v5vzShkaO5oxlEZkxhKn+1pCFtftktRZw7cRGDea8z2qtB2lj4bVW5lLbNbncPiJnoIH+8IARrXeFulnGJ2l6JTSnEU4B90r7nghMIvDzzw2mwR4dWl9iecxVLRWnqT2a/QIqBEbYHUQcakG7Vf/bwzUHfdOxEpyEwbdL6Q7ohcrqFh6tkd2DsTnHYxIQEYD962x4Wj2bnXS6FXxvXiIxD1DRhxl3eWROZiLbgl9d1lHlyRUE11Lt0/V8frM+p7GgQRhhvkyK0erZ0XW53D4iZ6CB/vCAEa13hbpd/i7yGtqG6y8m1EKbgZCgJ2k8zKRcjEHy3Y7vIV2AMBHhrDZrFWfMzTu0U9HafM5Zb8pvcEReHOrUlKi5OeA95bncPiJnoIH+8IARrXeFulS7Q55WqPAkWj5gseJR1Uo3aTzMpFyMQfLdju8hXYAwEeGsNmsVZ8zNO7RT0dp8zlvKBP/uOX+Eq23iGzP6mrnFudw+Imeggf7wgBGtd4W6W/nAAgY0BVVq1fnbOftFuFECsdIX+OD3W1Z7gZGFYpEh4aw2axVnzM07tFPR2nzOXRjhCRSxbmPSA0x2U07viRW53D4iZ6CB/vCAEa13hbpfgAD9YUefYAI6e0pbY3WXclKZ9dFT/0yqO5rgAQMlS/HgUGgtie7l+340MRTm6ebfmaPkXuUNT1ohoOYaXG889bncPiJnoIH+8IARrXeFul1Pj+cnIqDWDuocxY42lGUU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOSQupBz2H6hlP6qAKDWqSSludw+Imeggf7wgBGtd4W6W9My7W0n/tfy/BbOZ9aKwnBgUan6ULeOXvukPZGb4heNFaepPZr9AioERtgdRBxqTTZ7zRe8Q4McvD/0XwtGetW53D4iZ6CB/vCAEa13hbpcAgsG4VXhmnvJiZ9hOrnVre+3ZXQKr7pKBvi8R/gdExwb2teCfyYU2W859CwKyWF7BAdlryp4NVVDqh86fsSKBbncPiJnoIH+8IARrXeFulWncdGNFqDS/UkQ67KhkBOKKqdqmON8i0tLod/xlvXS9r0DKLQ2Tcg9qmNYLOq0FO8IXhSn+xS2bDUiz15xYjbFudw+Imeggf7wgBGtd4W6WFIVQavBsfNDX1DWOnFxIic/mn2zl0jaDAnw122r3xf2vQMotDZNyD2qY1gs6rQU5xrfREcSKC1vuT3yJuvU7uW53D4iZ6CB/vCAEa13hbpb1zJXlETN1F+F6jsg9BxT8bAcyXeJfhBd1kFMK6Wz2Aq7MKbKPI8bo8LIGV8nQmBA==
|
1.0
|
tWh1FoOlrKYe4I8s/Z4oJv+lop/jrQEsWVJPowQ9flpgp7Q2G+T1y2gw8nUpMv8PUK43NzpNILSZ6vZPc0DC2dzA2YkKLVf42/jPRk03TsFQ/7bDclL87voEzgNVb0Tg7lFVtXnM7cu2Fu9oxBmHDTHqY37QbJJwZ9TMRCnm4bk= - d4RD8Hn6d1hTtH+quPtImmvQMotDZNyD2qY1gs6rQU5VYtL3nAzj1tl6hz2zN7aiW53D4iZ6CB/vCAEa13hbpZ74XwGf4Wenis/4q9xsCVeVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTim2kFhYak/kfUDu2zBbLi5bncPiJnoIH+8IARrXeFulJPNKldr8A9uBqT4Ot4zDC49SVnrBJDZerZ5J6MgVGApr0DKLQ2Tcg9qmNYLOq0FO5InUf2W0KO4Kq3wVMm3EhVudw+Imeggf7wgBGtd4W6U+MAhATOsanukWId5fiP34u1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU6cNSPgo9uE2Xxw5g7tK020W53D4iZ6CB/vCAEa13hbpc2HcsqklyFBl+0WcSqOCv1z+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTgU7uoGWaLDG4bd0zZAKsbJbncPiJnoIH+8IARrXeFulRHuHKTxJlhsgyHd3XV+iPwwxBywgMnuT7ogs4qiGIk6qT3wMxcx7P+ds2AlmFH8kO+hMtWo0a46FvjOSbgAAC1udw+Imeggf7wgBGtd4W6VEi86wD2VPAN84fn+OQV3tsdoF/bsKLvMyFCQDFfJR2h4FBoLYnu5ft+NDEU5unm2azomRd9hTS8OxKE8/sHKHW53D4iZ6CB/vCAEa13hbpTi7D4cMWXCGWFg3pH4zxMGUHJ27bbpJqp5Yb8Qpxl3Y0Vp6k9mv0CKgRG2B1EHGpOU2cgjDFX3LOo9ubPORhDpbncPiJnoIH+8IARrXeFulLrVvExKHL5kf2qnsxe9QdbHaBf27Ci7zMhQkAxXyUdoeBQaC2J7uX7fjQxFObp5tyASs96QVIOk++uFsOZIoKludw+Imeggf7wgBGtd4W6VRy/KOoRozBGQY616cgUakwjIV+Itg/SAVTi3etVreCdFaepPZr9AioERtgdRBxqSKMvxHoHsIQDH0DEZwMdwTvpDuiFyuoWHq2R3YOxOcdq9ZXdrse1VB/vTOUDqhARlz+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTj+WFiLCBjW5Efsby3iz3H1bncPiJnoIH+8IARrXeFul1y30Xix5s8dMQeagrjs9M476548Cf85iNG7OV1SmDADTcpsePQliMfdLmaHieFGCVGKNBxWq9xClxfLTUFg6YFudw+Imeggf7wgBGtd4W6XzWqhgYqDLDKfpzBIBYUSflNWaBSpCC8IOCjL0lIMe/R4aw2axVnzM07tFPR2nzOVJapzRhIsVsqX9ws73CNCUW53D4iZ6CB/vCAEa13hbpdr1O4ym5Jc0lZiITp+Q0dHL23gsdjrCOus5s7kMD9zGHhrDZrFWfMzTu0U9HafM5SDRP6JTpX/+jKvv4Mb3XVtbncPiJnoIH+8IARrXeFulhChr42Agc5HnnuxQXXKZV1NRlFaunLzPKkl4GsOQwxhr0DKLQ2Tcg9qmNYLOq0FOrGI6u7480/HavvNNu8GCpVudw+Imeggf7wgBGtd4W6Vc8Ji3Sk2p8hRCL5ZBYt1LvBdQUxXO7NfThIrS6WXbEGvQMotDZNyD2qY1gs6rQU74hmDwcS/LoekccsDYL/6gW53D4iZ6CB/vCAEa13hbpbW8EtNMtGovSAR7nPhpt9mlxM8NfTKC2TlE5jKA/8tl03KbHj0JYjH3S5mh4nhRghP2RKEv2mBrALx1C5fK0f1bncPiJnoIH+8IARrXeFul79b88qnPUCH3A60qxAfDl5+F/iezLRZ8X0a959EaIlTRWnqT2a/QIqBEbYHUQcakZHDOTVE1kLubbsRrIkXXC76Q7ohcrqFh6tkd2DsTnHbpBeiUhjouwPJ0NgTadmxGmLPitMHMj/AD6thqlGYSmdFaepPZr9AioERtgdRBxqQ8wMUvlJUXPH8crYB2qNRbvpDuiFyuoWHq2R3YOxOcdrJQ8hbi6MwyTnwuOwdeLD3CLw888NpsEeHVpfYnnMVS0Vp6k9mv0CKgRG2B1EHGpM37Vr6F3zX0G5Ve3pcMIYRbncPiJnoIH+8IARrXeFulejBAPNz9uEZUZ6SPMsZ7aVTSj72UkaVlMY43cGW4iW1p/9bNGKl0rF/QEZxXwYuwNgKI+gQzo/T7EAHcpuWJRVudw+Imeggf7wgBGtd4W6XjnRyYx+lQlCuH2+VOV1gOS35wwhAWcYcbq/A0daSpdWn/1s0YqXSsX9ARnFfBi7Bm9Xz9QzuNWKwNyqsLl5HoW53D4iZ6CB/vCAEa13hbpeDXKZY+DQjk3w0+D+v1EK+P6gBazektn545OheglO0Gaf/WzRipdKxf0BGcV8GLsM/IwTw0WS2rinHAQNBFd/hbncPiJnoIH+8IARrXeFulOGnMSz+eIqGQ9AyxSi+YjJUdylfm5KtpMS/qyyzgED5r0DKLQ2Tcg9qmNYLOq0FOkrVT1uYIkNyEUkUuTmpm4Fudw+Imeggf7wgBGtd4W6UhN9MAfpYwKsclHG2xC6JQu1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU558AO0cY3o8mIJPEcz6yTEW53D4iZ6CB/vCAEa13hbpVXph9lf3ha1zePo5TLPwjF0Ydp/kwJ5ghu6lRZcTI0RHhrDZrFWfMzTu0U9HafM5afSj76POf4UBcGGc02KSnpbncPiJnoIH+8IARrXeFuliLraO5guPAqCfz29EmgzUawzOBLCd823QHSfq70lXetE9jj7vCUZCgg50cfZOgcnqzdyuArbrbB8rptQFCebn1udw+Imeggf7wgBGtd4W6VzADCCBT0sYJ8JeZgnScZ3mLPitMHMj/AD6thqlGYSmdFaepPZr9AioERtgdRBxqRspj1KRvBgcuCJvvmlAw88vpDuiFyuoWHq2R3YOxOcdobImS9kUCXkPAlUhCpg1rkzqQYr+bJEbu6+XU4YCjNS03KbHj0JYjH3S5mh4nhRggEkZUKkp+5p96yATOXtLb5bncPiJnoIH+8IARrXeFulbGccVUMSGhetqyFHM8mtrU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOY1vdXhN8JTO8IhLBFnT+lludw+Imeggf7wgBGtd4W6U3H7IIktH07NMeNMCpsMpau1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU6mcm0eybLiX5d1idwHsbUOW53D4iZ6CB/vCAEa13hbpVPxaIQef2ZZIE53fI8aRhWPUlZ6wSQ2Xq2eSejIFRgKa9Ayi0Nk3IPapjWCzqtBTvmHZviczKPspfakEqnSbRdbncPiJnoIH+8IARrXeFulMxSGi/R7r1qPzo1SqQOHaI9SVnrBJDZerZ5J6MgVGApr0DKLQ2Tcg9qmNYLOq0FOfeis5BrwcUMa7HXClQTQWVudw+Imeggf7wgBGtd4W6UcIjbe6ooZwF1FCva0l+UzwjIV+Itg/SAVTi3etVreCdFaepPZr9AioERtgdRBxqRRtave5qzgGYlNHPnC6fWXvpDuiFyuoWHq2R3YOxOcdqXvZdM4vY8p0RcpmsuisHidLUkrTh40kyxG5wbazFk0HhrDZrFWfMzTu0U9HafM5RfjahhQH5hsijMXX7FYmT5bncPiJnoIH+8IARrXeFulRfVV9f6ca2UtqqQ97uQmwU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOUv37/x4LVi13Lr4QGBuIxVudw+Imeggf7wgBGtd4W6U8yCF8NiKr1skP/anD+u/Wj1JWesEkNl6tnknoyBUYCmvQMotDZNyD2qY1gs6rQU5iYQyp3zHQx5mv97rcwSeaW53D4iZ6CB/vCAEa13hbpd7hHSqNodhUFsn5+zbh+2a7U6PhlNz6FStlVim3wUD0a9Ayi0Nk3IPapjWCzqtBTlRFlccy0G1NC8CK2VqjMZdbncPiJnoIH+8IARrXeFul9sdldiuMidnI8CS/UQyorqx1U7uuLuF3Y5drzcHKJSa/Gk52SghhPyffxzxrOx9oJQZQzKBErQWJ0M+5P8nvzb6Q7ohcrqFh6tkd2DsTnHaV0us05V49NKgREbmhG1AZJCndXqiqME5vlEGBCPxG19Nymx49CWIx90uZoeJ4UYLVg6kzrQxIKem0s5iD+kyrW53D4iZ6CB/vCAEa13hbpSL9FovhMD1mqfhEutzjVWCVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTpU3qOejzMwLHJDnOHZqfSBbncPiJnoIH+8IARrXeFuly6PRY7yF25WIsHo9VyYJJZUdylfm5KtpMS/qyyzgED5r0DKLQ2Tcg9qmNYLOq0FOz1wbzB3GfiUSJrLP/6XLW1udw+Imeggf7wgBGtd4W6VcBdXnxiK1SiRe64lG7jPFs9zxHMSM3+mU/TuYBvBhJR4aw2axVnzM07tFPR2nzOWgalOrUlnINETW85MHc1lAW53D4iZ6CB/vCAEa13hbpSBJqIIQaVoRilpNEYRkKGVPwojUTrjGXEpXHjjboFbea9Ayi0Nk3IPapjWCzqtBTu0+7s3MXMn1aksGXKcQn5lbncPiJnoIH+8IARrXeFulptamwxQU85FNNVH0+nYgUU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOnb69e0OSnB1Xt9Nfwt/7f1udw+Imeggf7wgBGtd4W6VjPwx98kU6KWeCGuj5bAsdc/mn2zl0jaDAnw122r3xf2vQMotDZNyD2qY1gs6rQU5LCW/vP3lNPQ02iEH1iTj8W53D4iZ6CB/vCAEa13hbpRgpo10Kc3M/wBLXR4OKuGmVHcpX5uSraTEv6sss4BA+a9Ayi0Nk3IPapjWCzqtBTjuKtxRsRQkBBT7Bt8RLiSxbncPiJnoIH+8IARrXeFulKnvYcaogJ06VFTmtgZOf7E/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOjfuSBX+ES1AVGRDREkkaDVudw+Imeggf7wgBGtd4W6Xhfd+4rFD+5acvz3Cl4z25lR3KV+bkq2kxL+rLLOAQPmvQMotDZNyD2qY1gs6rQU71KRCPUUV7ZifOZGxg9cNPW53D4iZ6CB/vCAEa13hbpVfqdKptWawgXZIWnzIXZxAddqY+OPs1ZLzoQYGGLQv2PNvP2eEQ25Yk+mUjhXHj3e5MfXc0Z/F7lEumBY0moclbncPiJnoIH+8IARrXeFul9piLB1vjzi+/BkCDoEy6MB1yUxogzt18K2ZQbFkMxMjoLNf1YOPpI8RTJVigoBchINVqz7mRVbISt8CL31wNQVudw+Imeggf7wgBGtd4W6W74i5flDH3xRnKmEA8aoChlR3KV+bkq2kxL+rLLOAQPmvQMotDZNyD2qY1gs6rQU7xbObUIZm1MHjuG3wUWuCgW53D4iZ6CB/vCAEa13hbpepFruTUqhTqy9FQ8K4LuOaHb3PcN0MDOmWStBtDaXcjP7H16UJ9Gh9J6RmQkQZNAWtR7ZS5fKGOU5arXIQEyTtbncPiJnoIH+8IARrXeFuliwaBFt55jJwjq37pEAuOVyUpn10VP/TKo7muABAyVL8eBQaC2J7uX7fjQxFObp5tTWSe0f5PNqIpuKEUvil7vludw+Imeggf7wgBGtd4W6X7w+XY6EMS4yanpgwENVJqT8KI1E64xlxKVx4426BW3mvQMotDZNyD2qY1gs6rQU4wvxjUP6JWLhZ8UplNk3QVW53D4iZ6CB/vCAEa13hbpf337FTfdaQtA2391ETa3iZz+afbOXSNoMCfDXbavfF/a9Ayi0Nk3IPapjWCzqtBTrAh1Q2m9pyrPTP1/DIPj+lbncPiJnoIH+8IARrXeFula3Dxw+V6F0VPE58M4MKowW6U4Yk13gVhgE1Z9o/M3+YBg58RFdIu4YfWuFUY3w2h195vm7teh1UFZkp8RG21Y1udw+Imeggf7wgBGtd4W6Vy+4FURINpdAFaoKm5WhABu1Oj4ZTc+hUrZVYpt8FA9GvQMotDZNyD2qY1gs6rQU5xZIixD8anJC+MPRJQugfOW53D4iZ6CB/vCAEa13hbpXR3T0JJjxJffUgY6cw3+5Nm1eKS9v5vzShkaO5oxlEZkxhKn+1pCFtftktRZw7cRGDea8z2qtB2lj4bVW5lLbNbncPiJnoIH+8IARrXeFulnGJ2l6JTSnEU4B90r7nghMIvDzzw2mwR4dWl9iecxVLRWnqT2a/QIqBEbYHUQcakG7Vf/bwzUHfdOxEpyEwbdL6Q7ohcrqFh6tkd2DsTnHYxIQEYD962x4Wj2bnXS6FXxvXiIxD1DRhxl3eWROZiLbgl9d1lHlyRUE11Lt0/V8frM+p7GgQRhhvkyK0erZ0XW53D4iZ6CB/vCAEa13hbpd/i7yGtqG6y8m1EKbgZCgJ2k8zKRcjEHy3Y7vIV2AMBHhrDZrFWfMzTu0U9HafM5Zb8pvcEReHOrUlKi5OeA95bncPiJnoIH+8IARrXeFulS7Q55WqPAkWj5gseJR1Uo3aTzMpFyMQfLdju8hXYAwEeGsNmsVZ8zNO7RT0dp8zlvKBP/uOX+Eq23iGzP6mrnFudw+Imeggf7wgBGtd4W6W/nAAgY0BVVq1fnbOftFuFECsdIX+OD3W1Z7gZGFYpEh4aw2axVnzM07tFPR2nzOXRjhCRSxbmPSA0x2U07viRW53D4iZ6CB/vCAEa13hbpfgAD9YUefYAI6e0pbY3WXclKZ9dFT/0yqO5rgAQMlS/HgUGgtie7l+340MRTm6ebfmaPkXuUNT1ohoOYaXG889bncPiJnoIH+8IARrXeFul1Pj+cnIqDWDuocxY42lGUU/CiNROuMZcSlceONugVt5r0DKLQ2Tcg9qmNYLOq0FOSQupBz2H6hlP6qAKDWqSSludw+Imeggf7wgBGtd4W6W9My7W0n/tfy/BbOZ9aKwnBgUan6ULeOXvukPZGb4heNFaepPZr9AioERtgdRBxqTTZ7zRe8Q4McvD/0XwtGetW53D4iZ6CB/vCAEa13hbpcAgsG4VXhmnvJiZ9hOrnVre+3ZXQKr7pKBvi8R/gdExwb2teCfyYU2W859CwKyWF7BAdlryp4NVVDqh86fsSKBbncPiJnoIH+8IARrXeFulWncdGNFqDS/UkQ67KhkBOKKqdqmON8i0tLod/xlvXS9r0DKLQ2Tcg9qmNYLOq0FO8IXhSn+xS2bDUiz15xYjbFudw+Imeggf7wgBGtd4W6WFIVQavBsfNDX1DWOnFxIic/mn2zl0jaDAnw122r3xf2vQMotDZNyD2qY1gs6rQU5xrfREcSKC1vuT3yJuvU7uW53D4iZ6CB/vCAEa13hbpb1zJXlETN1F+F6jsg9BxT8bAcyXeJfhBd1kFMK6Wz2Aq7MKbKPI8bo8LIGV8nQmBA==
|
design
|
lop afboxsnomcfdxbavff ufsoziokludw itg vtoudqharlz afboxsnomcfdxbavff loekccsdyl f qezxxwyuwngki gqzo d hbncpijnoih lludw uzwjiv itg and u zbh mu nyguu afboxsnomcfdxbavff dipj lbncpijnoih uox tfy
| 1
|
118,054
| 15,217,865,478
|
IssuesEvent
|
2021-02-17 17:06:31
|
wellcomecollection/wellcomecollection.org
|
https://api.github.com/repos/wellcomecollection/wellcomecollection.org
|
closed
|
Visual refinements to available online label
|
Project: collections access catalogue 📚 improvement ✨ needs:design
|
As part of the new search interface, an available online label has been added to search results that are, er, available online. This is great, but I think it could benefit from a tiny bit of visual refinement.
Example search with some, but not all, available online:
https://wellcomecollection.org/works?query=letters&workType=k
And filtered to only available online:
https://wellcomecollection.org/works?query=letters&workType=k&items.locations.type=DigitalLocation
As is stands currently, the label is the same size as the more important text that it sits beside. It's also on a grey background, which was intended only for the wireframe.
My suggestion is to change the size to `font-size-6` (ie `14px`) and change the background to `cream`.
This is still slightly different from the wireframes, but without making the text even smaller (as it is in the wireframes), the suggested all caps is a bit overbearing and I don't want to push to add a smaller text size to Cardigan right now.
@GarethOrmerod / @DominiqueMarshall to confirm.
|
1.0
|
Visual refinements to available online label - As part of the new search interface, an available online label has been added to search results that are, er, available online. This is great, but I think it could benefit from a tiny bit of visual refinement.
Example search with some, but not all, available online:
https://wellcomecollection.org/works?query=letters&workType=k
And filtered to only available online:
https://wellcomecollection.org/works?query=letters&workType=k&items.locations.type=DigitalLocation
As is stands currently, the label is the same size as the more important text that it sits beside. It's also on a grey background, which was intended only for the wireframe.
My suggestion is to change the size to `font-size-6` (ie `14px`) and change the background to `cream`.
This is still slightly different from the wireframes, but without making the text even smaller (as it is in the wireframes), the suggested all caps is a bit overbearing and I don't want to push to add a smaller text size to Cardigan right now.
@GarethOrmerod / @DominiqueMarshall to confirm.
|
design
|
visual refinements to available online label as part of the new search interface an available online label has been added to search results that are er available online this is great but i think it could benefit from a tiny bit of visual refinement example search with some but not all available online and filtered to only available online as is stands currently the label is the same size as the more important text that it sits beside it s also on a grey background which was intended only for the wireframe my suggestion is to change the size to font size ie and change the background to cream this is still slightly different from the wireframes but without making the text even smaller as it is in the wireframes the suggested all caps is a bit overbearing and i don t want to push to add a smaller text size to cardigan right now garethormerod dominiquemarshall to confirm
| 1
|
5,959
| 7,452,030,655
|
IssuesEvent
|
2018-03-29 06:42:39
|
Microsoft/vscode-cpptools
|
https://api.github.com/repos/Microsoft/vscode-cpptools
|
opened
|
Compiler default includes/defines aren't used with compileCommands if compilerPath isn't set on Windows
|
Language Service bug
|
The bug was found right after we shipped 0.16.0 (it exists in 0.16.0-insiders2 too).
The workaround is to set the compilerPath (it's supposed to try the one in the compile_commands.json command first).
Doesn't repro on Linux/Mac.
|
1.0
|
Compiler default includes/defines aren't used with compileCommands if compilerPath isn't set on Windows - The bug was found right after we shipped 0.16.0 (it exists in 0.16.0-insiders2 too).
The workaround is to set the compilerPath (it's supposed to try the one in the compile_commands.json command first).
Doesn't repro on Linux/Mac.
|
non_design
|
compiler default includes defines aren t used with compilecommands if compilerpath isn t set on windows the bug was found right after we shipped it exists in too the workaround is to set the compilerpath it s supposed to try the one in the compile commands json command first doesn t repro on linux mac
| 0
|
317,806
| 23,690,229,078
|
IssuesEvent
|
2022-08-29 10:05:52
|
actions/cache
|
https://api.github.com/repos/actions/cache
|
closed
|
docs: caching node_modules vs cache directory
|
documentation
|
The docs guides to cache `.npm` or `$(yarn cache dir)` for nodejs.
[Node - npm](https://github.com/actions/cache/blob/main/examples.md#node---npm)
[Node - Yarn](https://github.com/actions/cache/blob/main/examples.md#node---yarn)
This lets people _feel_ it the "RIGHT" way to cache node dependencies, without clearly explaining whether caching `node_modules` directly is not recommended.
I want to know 1) if this is a wrong impression or not and 2) why.
Thanks!
|
1.0
|
docs: caching node_modules vs cache directory - The docs guides to cache `.npm` or `$(yarn cache dir)` for nodejs.
[Node - npm](https://github.com/actions/cache/blob/main/examples.md#node---npm)
[Node - Yarn](https://github.com/actions/cache/blob/main/examples.md#node---yarn)
This lets people _feel_ it the "RIGHT" way to cache node dependencies, without clearly explaining whether caching `node_modules` directly is not recommended.
I want to know 1) if this is a wrong impression or not and 2) why.
Thanks!
|
non_design
|
docs caching node modules vs cache directory the docs guides to cache npm or yarn cache dir for nodejs this lets people feel it the right way to cache node dependencies without clearly explaining whether caching node modules directly is not recommended i want to know if this is a wrong impression or not and why thanks
| 0
|
90,854
| 11,439,252,289
|
IssuesEvent
|
2020-02-05 06:41:02
|
department-of-veterans-affairs/caseflow
|
https://api.github.com/repos/department-of-veterans-affairs/caseflow
|
closed
|
Motion to Vacate | Research and Testing with VLJs
|
BVA caseflow-queue design 💅 foxtrot priority-medium size-bear 🐻
|
We have done a round of research/testing with VLJs and now we have to do another round to collect information on some unknowns and validation on our designs.
## To-Dos
- [x] Get discussion guide prepared with relevant designs and open questions
- [x] Decide on speaking with same VLJs or different, both?
- [x] Schedule sessions
- [x] Conduct sessions
- [x] Extract info from sessions
- [x] Organize and share insights
### Open Questions
- What are the key differences in Withdraw v. Dismiss? Are the ruling letters different?
- Clarify differences of the 2 types of Vacates, what the process will look like in carrying those 2 types out in Caseflow?
-
### Prototype to test with
https://www.figma.com/proto/GCRmxv1kWxPgLV8ipgD5RJ/VLJ-Flow-with-Actual-Screens?node-id=0%3A229&viewport=103%2C231%2C0.09255273640155792&scaling=min-zoom
#### Note
- Bring in an engineer and LP and Jim for research with VLJ especially for Grant: 2 types of grants
#### Related
- #11723
- #11724
|
1.0
|
Motion to Vacate | Research and Testing with VLJs - We have done a round of research/testing with VLJs and now we have to do another round to collect information on some unknowns and validation on our designs.
## To-Dos
- [x] Get discussion guide prepared with relevant designs and open questions
- [x] Decide on speaking with same VLJs or different, both?
- [x] Schedule sessions
- [x] Conduct sessions
- [x] Extract info from sessions
- [x] Organize and share insights
### Open Questions
- What are the key differences in Withdraw v. Dismiss? Are the ruling letters different?
- Clarify differences of the 2 types of Vacates, what the process will look like in carrying those 2 types out in Caseflow?
-
### Prototype to test with
https://www.figma.com/proto/GCRmxv1kWxPgLV8ipgD5RJ/VLJ-Flow-with-Actual-Screens?node-id=0%3A229&viewport=103%2C231%2C0.09255273640155792&scaling=min-zoom
#### Note
- Bring in an engineer and LP and Jim for research with VLJ especially for Grant: 2 types of grants
#### Related
- #11723
- #11724
|
design
|
motion to vacate research and testing with vljs we have done a round of research testing with vljs and now we have to do another round to collect information on some unknowns and validation on our designs to dos get discussion guide prepared with relevant designs and open questions decide on speaking with same vljs or different both schedule sessions conduct sessions extract info from sessions organize and share insights open questions what are the key differences in withdraw v dismiss are the ruling letters different clarify differences of the types of vacates what the process will look like in carrying those types out in caseflow prototype to test with note bring in an engineer and lp and jim for research with vlj especially for grant types of grants related
| 1
|
13,846
| 3,202,242,643
|
IssuesEvent
|
2015-10-02 13:02:01
|
owncloud/client
|
https://api.github.com/repos/owncloud/client
|
closed
|
No way of changing between HTTP and HTTPS.
|
Design & UX Enhancement
|
Hi,
It should be easier to change the security back and fourth between HTTP and HTTPS.
I recently got a cert for my server and I am unable to change the setting to a secure connection.
There should therefore be a checkbox, or something in the settings window.
Is there a certain reason why there already isn't like it's complex to change or something?
|
1.0
|
No way of changing between HTTP and HTTPS. - Hi,
It should be easier to change the security back and fourth between HTTP and HTTPS.
I recently got a cert for my server and I am unable to change the setting to a secure connection.
There should therefore be a checkbox, or something in the settings window.
Is there a certain reason why there already isn't like it's complex to change or something?
|
design
|
no way of changing between http and https hi it should be easier to change the security back and fourth between http and https i recently got a cert for my server and i am unable to change the setting to a secure connection there should therefore be a checkbox or something in the settings window is there a certain reason why there already isn t like it s complex to change or something
| 1
|
143,444
| 22,047,968,260
|
IssuesEvent
|
2022-05-30 05:24:19
|
Alice52/Alice52
|
https://api.github.com/repos/Alice52/Alice52
|
closed
|
[design pattern] singleton
|
documentation doing common design
|
## subject
1. 单例模式
## appliable
1. N/A
## theory
1. N/A
---
## reference
1. [link](https://blog.csdn.net/cselmu9/article/details/51366946)
|
1.0
|
[design pattern] singleton - ## subject
1. 单例模式
## appliable
1. N/A
## theory
1. N/A
---
## reference
1. [link](https://blog.csdn.net/cselmu9/article/details/51366946)
|
design
|
singleton subject 单例模式 appliable n a theory n a reference
| 1
|
410,843
| 27,804,888,218
|
IssuesEvent
|
2023-03-17 18:54:45
|
acclab-mx/dppd-violencia-contra-las-mujeres
|
https://api.github.com/repos/acclab-mx/dppd-violencia-contra-las-mujeres
|
closed
|
Mejorar README
|
documentation hacktoberfest
|
# Problemáticas
1. En el README no nos indica la manera de organizar los datos, solo nos indica que son lo que necesitamos. Esto podría retrasar o incluso negar contribuciones que alguien quiera hacer.
2. No es tan claro qué es o cómo se implementa DPPD.
3. Hay algunos scripts que no tienen número, ¿Qué se hace con ellos? ¿Se ejecutan o solo son de apoyo?
4. En el README actual dice que hay 8 OUTPUTS pero en la carpeta de Drive solo veo 6.
# Posible Soluciones
1. Después de resolver #1, poner la organización de carpetas con un diagrama de árbol tal y como lo hice en el Issue para que sea más claro cómo correr los scripts. También, modificar los scripts para que corran con los datos en esta estructura, sin necesidad de que el usuario corrija las rutas.
2. Mejorar el README de tal manera que exista una pequeña y super breve introducción de uno o dos párrafos, de qué es DPPD y más o menos como funciona, así como poner fuentes de dónde obtener más información.
3. Especificar qué son estos scripts
4. Tal vez agregar una carpeta llamada `Example Outputs` donde estén guardadas screen shots de las salidas de este proyecto para que así se puedan comparar con las del usuario o usuaria.
|
1.0
|
Mejorar README - # Problemáticas
1. En el README no nos indica la manera de organizar los datos, solo nos indica que son lo que necesitamos. Esto podría retrasar o incluso negar contribuciones que alguien quiera hacer.
2. No es tan claro qué es o cómo se implementa DPPD.
3. Hay algunos scripts que no tienen número, ¿Qué se hace con ellos? ¿Se ejecutan o solo son de apoyo?
4. En el README actual dice que hay 8 OUTPUTS pero en la carpeta de Drive solo veo 6.
# Posible Soluciones
1. Después de resolver #1, poner la organización de carpetas con un diagrama de árbol tal y como lo hice en el Issue para que sea más claro cómo correr los scripts. También, modificar los scripts para que corran con los datos en esta estructura, sin necesidad de que el usuario corrija las rutas.
2. Mejorar el README de tal manera que exista una pequeña y super breve introducción de uno o dos párrafos, de qué es DPPD y más o menos como funciona, así como poner fuentes de dónde obtener más información.
3. Especificar qué son estos scripts
4. Tal vez agregar una carpeta llamada `Example Outputs` donde estén guardadas screen shots de las salidas de este proyecto para que así se puedan comparar con las del usuario o usuaria.
|
non_design
|
mejorar readme problemáticas en el readme no nos indica la manera de organizar los datos solo nos indica que son lo que necesitamos esto podría retrasar o incluso negar contribuciones que alguien quiera hacer no es tan claro qué es o cómo se implementa dppd hay algunos scripts que no tienen número ¿qué se hace con ellos ¿se ejecutan o solo son de apoyo en el readme actual dice que hay outputs pero en la carpeta de drive solo veo posible soluciones después de resolver poner la organización de carpetas con un diagrama de árbol tal y como lo hice en el issue para que sea más claro cómo correr los scripts también modificar los scripts para que corran con los datos en esta estructura sin necesidad de que el usuario corrija las rutas mejorar el readme de tal manera que exista una pequeña y super breve introducción de uno o dos párrafos de qué es dppd y más o menos como funciona así como poner fuentes de dónde obtener más información especificar qué son estos scripts tal vez agregar una carpeta llamada example outputs donde estén guardadas screen shots de las salidas de este proyecto para que así se puedan comparar con las del usuario o usuaria
| 0
|
175,004
| 27,771,845,572
|
IssuesEvent
|
2023-03-16 14:54:48
|
elan-ev/tobira
|
https://api.github.com/repos/elan-ev/tobira
|
opened
|
Rethink what items to include in the user menu
|
area:design area:usability
|
Currently we have "my content", "Upload video" (and always "logout", but thats not part of this discussion -- it stays there of course). "My content" links to the management dashboard. #727 will add "my page". It's unclear why "upload video" is linked there, but not "record video" (with studio). Or "my videos". So we should think about this again and find a more consistent solution.
|
1.0
|
Rethink what items to include in the user menu - Currently we have "my content", "Upload video" (and always "logout", but thats not part of this discussion -- it stays there of course). "My content" links to the management dashboard. #727 will add "my page". It's unclear why "upload video" is linked there, but not "record video" (with studio). Or "my videos". So we should think about this again and find a more consistent solution.
|
design
|
rethink what items to include in the user menu currently we have my content upload video and always logout but thats not part of this discussion it stays there of course my content links to the management dashboard will add my page it s unclear why upload video is linked there but not record video with studio or my videos so we should think about this again and find a more consistent solution
| 1
|
168,202
| 26,615,063,257
|
IssuesEvent
|
2023-01-24 06:00:21
|
Agoric/agoric-sdk
|
https://api.github.com/repos/Agoric/agoric-sdk
|
closed
|
swingstore: replace kvStore.getKeys with getNext
|
enhancement SwingSet needs-design
|
## What is the Problem Being Solved?
Currently the swing-store `kvStore` API includes a `getKeys()` function, which is specified to return a JavaScript `IterableIterator` (i.e. it is defined by `function* getKeys(start, end)`, where the `*` means it is a generator function, so you get back an Iterable, and can do `for (let key of kvStore.getKeys(start, end)) { .. }`).
That happens to align with the LMDB API, but is a bit awkward if we want to replace LMDB with SQLite (#3087). And it implies a whole bunch of stuff about retaining an iterator's state across intervening queries for entirely unrelated ranges of keys. And we have some wrappers around our kvStore, like the one that provides `crankBuffer`, which maintain this signature even though they're merging data from different places.
Our *syscall* interface, on the other hand, provides `syscall.vatstoreGetAfter(priorKey, lowerBound, upperBound)`, to avoid exposing a language-specific feature like `Iterable` across the data-only syscall boundary.
I'm thinking it would be better to switch both to a `getNext()` API, in which you provide the previous key and an optional `maxKey`. This looks a lot like `vatstoreGetAfter` but slightly simpler, without the `lowerBound` argument (I think you can make all the same queries without it). This maps cleanly onto a SQL query.
Consumers who need one can build their own iterator around `getNext()` pretty easily. I have a sketch on a branch which includes a sample iterator-building function.
## Description of the Design
`kvStore.getNext(previousKey, maxKey=undefined) -> key or undefined`
## Security Considerations
Not many. The kernel continues to get full access to the kvStore. Kernel code which imposes limits on vat-side access (e.g. to only keys that begin with `${vatID}.vs.` must continue to do so, either by setting `maxKey` low enough, and/or looking at the return value of `getNext()` and replacing it with `undefined` if the key is beyond the correct region.
## Test Plan
Unit tests
|
1.0
|
swingstore: replace kvStore.getKeys with getNext - ## What is the Problem Being Solved?
Currently the swing-store `kvStore` API includes a `getKeys()` function, which is specified to return a JavaScript `IterableIterator` (i.e. it is defined by `function* getKeys(start, end)`, where the `*` means it is a generator function, so you get back an Iterable, and can do `for (let key of kvStore.getKeys(start, end)) { .. }`).
That happens to align with the LMDB API, but is a bit awkward if we want to replace LMDB with SQLite (#3087). And it implies a whole bunch of stuff about retaining an iterator's state across intervening queries for entirely unrelated ranges of keys. And we have some wrappers around our kvStore, like the one that provides `crankBuffer`, which maintain this signature even though they're merging data from different places.
Our *syscall* interface, on the other hand, provides `syscall.vatstoreGetAfter(priorKey, lowerBound, upperBound)`, to avoid exposing a language-specific feature like `Iterable` across the data-only syscall boundary.
I'm thinking it would be better to switch both to a `getNext()` API, in which you provide the previous key and an optional `maxKey`. This looks a lot like `vatstoreGetAfter` but slightly simpler, without the `lowerBound` argument (I think you can make all the same queries without it). This maps cleanly onto a SQL query.
Consumers who need one can build their own iterator around `getNext()` pretty easily. I have a sketch on a branch which includes a sample iterator-building function.
## Description of the Design
`kvStore.getNext(previousKey, maxKey=undefined) -> key or undefined`
## Security Considerations
Not many. The kernel continues to get full access to the kvStore. Kernel code which imposes limits on vat-side access (e.g. to only keys that begin with `${vatID}.vs.` must continue to do so, either by setting `maxKey` low enough, and/or looking at the return value of `getNext()` and replacing it with `undefined` if the key is beyond the correct region.
## Test Plan
Unit tests
|
design
|
swingstore replace kvstore getkeys with getnext what is the problem being solved currently the swing store kvstore api includes a getkeys function which is specified to return a javascript iterableiterator i e it is defined by function getkeys start end where the means it is a generator function so you get back an iterable and can do for let key of kvstore getkeys start end that happens to align with the lmdb api but is a bit awkward if we want to replace lmdb with sqlite and it implies a whole bunch of stuff about retaining an iterator s state across intervening queries for entirely unrelated ranges of keys and we have some wrappers around our kvstore like the one that provides crankbuffer which maintain this signature even though they re merging data from different places our syscall interface on the other hand provides syscall vatstoregetafter priorkey lowerbound upperbound to avoid exposing a language specific feature like iterable across the data only syscall boundary i m thinking it would be better to switch both to a getnext api in which you provide the previous key and an optional maxkey this looks a lot like vatstoregetafter but slightly simpler without the lowerbound argument i think you can make all the same queries without it this maps cleanly onto a sql query consumers who need one can build their own iterator around getnext pretty easily i have a sketch on a branch which includes a sample iterator building function description of the design kvstore getnext previouskey maxkey undefined key or undefined security considerations not many the kernel continues to get full access to the kvstore kernel code which imposes limits on vat side access e g to only keys that begin with vatid vs must continue to do so either by setting maxkey low enough and or looking at the return value of getnext and replacing it with undefined if the key is beyond the correct region test plan unit tests
| 1
|
172,914
| 21,074,582,320
|
IssuesEvent
|
2022-04-02 01:14:53
|
Killy85/game_ai_trainer
|
https://api.github.com/repos/Killy85/game_ai_trainer
|
opened
|
CVE-2022-24758 (High) detected in notebook-5.7.8-py2.py3-none-any.whl
|
security vulnerability
|
## CVE-2022-24758 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>notebook-5.7.8-py2.py3-none-any.whl</b></p></summary>
<p>A web-based notebook environment for interactive computing</p>
<p>Library home page: <a href="https://files.pythonhosted.org/packages/f6/36/89ebfffc9dd8c8dbd81c1ffb53e3d4233ee666414c143959477cb07cc5f5/notebook-5.7.8-py2.py3-none-any.whl">https://files.pythonhosted.org/packages/f6/36/89ebfffc9dd8c8dbd81c1ffb53e3d4233ee666414c143959477cb07cc5f5/notebook-5.7.8-py2.py3-none-any.whl</a></p>
<p>Path to dependency file: /game_ai_trainer/requirements.txt</p>
<p>Path to vulnerable library: /teSource-ArchiveExtractor_da03aa19-8c81-4d9c-9496-c373589d1ea2/20190506071543_44724/20190506071259_depth_0/62/notebook-5.7.8-py2.py3-none-any/notebook</p>
<p>
Dependency Hierarchy:
- :x: **notebook-5.7.8-py2.py3-none-any.whl** (Vulnerable Library)
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
The Jupyter notebook is a web-based notebook environment for interactive computing. Prior to version 6.4.9, unauthorized actors can access sensitive information from server logs. Anytime a 5xx error is triggered, the auth cookie and other header values are recorded in Jupyter server logs by default. Considering these logs do not require root access, an attacker can monitor these logs, steal sensitive auth/cookie information, and gain access to the Jupyter server. Jupyter notebook version 6.4.x contains a patch for this issue. There are currently no known workarounds.
<p>Publish Date: 2022-03-31
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2022-24758>CVE-2022-24758</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>7.5</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: None
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://github.com/jupyter/notebook/security/advisories/GHSA-m87f-39q9-6f55">https://github.com/jupyter/notebook/security/advisories/GHSA-m87f-39q9-6f55</a></p>
<p>Release Date: 2022-03-31</p>
<p>Fix Resolution: notebook - 6.4.10</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
True
|
CVE-2022-24758 (High) detected in notebook-5.7.8-py2.py3-none-any.whl - ## CVE-2022-24758 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>notebook-5.7.8-py2.py3-none-any.whl</b></p></summary>
<p>A web-based notebook environment for interactive computing</p>
<p>Library home page: <a href="https://files.pythonhosted.org/packages/f6/36/89ebfffc9dd8c8dbd81c1ffb53e3d4233ee666414c143959477cb07cc5f5/notebook-5.7.8-py2.py3-none-any.whl">https://files.pythonhosted.org/packages/f6/36/89ebfffc9dd8c8dbd81c1ffb53e3d4233ee666414c143959477cb07cc5f5/notebook-5.7.8-py2.py3-none-any.whl</a></p>
<p>Path to dependency file: /game_ai_trainer/requirements.txt</p>
<p>Path to vulnerable library: /teSource-ArchiveExtractor_da03aa19-8c81-4d9c-9496-c373589d1ea2/20190506071543_44724/20190506071259_depth_0/62/notebook-5.7.8-py2.py3-none-any/notebook</p>
<p>
Dependency Hierarchy:
- :x: **notebook-5.7.8-py2.py3-none-any.whl** (Vulnerable Library)
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
The Jupyter notebook is a web-based notebook environment for interactive computing. Prior to version 6.4.9, unauthorized actors can access sensitive information from server logs. Anytime a 5xx error is triggered, the auth cookie and other header values are recorded in Jupyter server logs by default. Considering these logs do not require root access, an attacker can monitor these logs, steal sensitive auth/cookie information, and gain access to the Jupyter server. Jupyter notebook version 6.4.x contains a patch for this issue. There are currently no known workarounds.
<p>Publish Date: 2022-03-31
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2022-24758>CVE-2022-24758</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>7.5</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: None
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://github.com/jupyter/notebook/security/advisories/GHSA-m87f-39q9-6f55">https://github.com/jupyter/notebook/security/advisories/GHSA-m87f-39q9-6f55</a></p>
<p>Release Date: 2022-03-31</p>
<p>Fix Resolution: notebook - 6.4.10</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
non_design
|
cve high detected in notebook none any whl cve high severity vulnerability vulnerable library notebook none any whl a web based notebook environment for interactive computing library home page a href path to dependency file game ai trainer requirements txt path to vulnerable library tesource archiveextractor depth notebook none any notebook dependency hierarchy x notebook none any whl vulnerable library vulnerability details the jupyter notebook is a web based notebook environment for interactive computing prior to version unauthorized actors can access sensitive information from server logs anytime a error is triggered the auth cookie and other header values are recorded in jupyter server logs by default considering these logs do not require root access an attacker can monitor these logs steal sensitive auth cookie information and gain access to the jupyter server jupyter notebook version x contains a patch for this issue there are currently no known workarounds publish date url a href cvss score details base score metrics exploitability metrics attack vector network attack complexity low privileges required none user interaction none scope unchanged impact metrics confidentiality impact high integrity impact none availability impact none for more information on scores click a href suggested fix type upgrade version origin a href release date fix resolution notebook step up your open source security game with whitesource
| 0
|
266,739
| 23,256,646,356
|
IssuesEvent
|
2022-08-04 09:50:49
|
cobbler/cobbler
|
https://api.github.com/repos/cobbler/cobbler
|
closed
|
Tests: Add for ACL module
|
enhancement tests
|
### Is your feature request related to a problem?
During the work of #3213 I discovered that the module has not tests. Thus let's add some.
### Provide a detailed description of the proposed feature
Have explicit coverage for the module.
### Alternatives you've considered
None
### Additional information
None
|
1.0
|
Tests: Add for ACL module - ### Is your feature request related to a problem?
During the work of #3213 I discovered that the module has not tests. Thus let's add some.
### Provide a detailed description of the proposed feature
Have explicit coverage for the module.
### Alternatives you've considered
None
### Additional information
None
|
non_design
|
tests add for acl module is your feature request related to a problem during the work of i discovered that the module has not tests thus let s add some provide a detailed description of the proposed feature have explicit coverage for the module alternatives you ve considered none additional information none
| 0
|
49,200
| 20,670,780,981
|
IssuesEvent
|
2022-03-10 01:44:58
|
graphprotocol/indexer
|
https://api.github.com/repos/graphprotocol/indexer
|
closed
|
Indexer-service IE023
|
indexer-service statechannels status: investigating
|
I don't really know what caused this. It only happened on one service node.
`
{"level":50,"time":1607034027451,"pid":1,"hostname":"be5ea890f632","name":"IndexerService","indexer":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","operator":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","indexer":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","operator":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","component":"Server","body":{"query":"{ indexingStatuses { subgraph } }"},"headers":{"host":"loadbalancer","connection":"close","content-length":"45","x-real-ip":"172.26.0.1","x-forwarded-for":"172.26.0.1","x-forwarded-proto":"https","x-forwarded-ssl":"on","x-forwarded-port":"443","content-type":"application/json","accept":"*/*","user-agent":"node-fetch/1.0 (+https://github.com/bitinn/node-fetch)","accept-encoding":"gzip,deflate"},"err":{"type":"IndexerError","message":"Failed to handle state channel message","stack":"IndexerError: Failed to handle state channel message\n at Object.indexerError (/opt/indexer/packages/indexer-common/dist/errors.js:91:12)\n at /opt/indexer/packages/indexer-service/dist/server/index.js:261:42\n at Generator.throw (<anonymous>)\n at rejected (/opt/indexer/packages/indexer-service/dist/server/index.js:6:65)","code":"IE023","explanation":"https://github.com/graphprotocol/indexer/blob/master/docs/errors.md#ie023","cause":{"type":"Error","message":"Invalid message","stack":"Error: Invalid message\n at Object.validateMessage (/opt/indexer/node_modules/@statechannels/wire-format/lib/src/validator.js:29:15)\n at Object.validatePayload (/opt/indexer/node_modules/@statechannels/wallet-core/lib/src/serde/wire-format/deserialize.js:15:26)\n at SingleThreadedWallet.pushMessage (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/wallet.js:275:43)\n at /opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/multi-threaded-wallet/worker.js:36:209\n at timeAsync (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/metrics.js:58:22)\n at /opt/indexer/node_modules/@statechannels/server-wallet/lib/src/metrics.js:45:70\n at MessagePort.<anonymous> (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/multi-threaded-wallet/worker.js:36:175)\n at MessagePort.emit (events.js:321:20)\n at MessagePort.onmessage (internal/worker/io.js:78:8)"}},"msg":"Failed to handle state channel message"}
`
|
1.0
|
Indexer-service IE023 - I don't really know what caused this. It only happened on one service node.
`
{"level":50,"time":1607034027451,"pid":1,"hostname":"be5ea890f632","name":"IndexerService","indexer":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","operator":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","indexer":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","operator":"0x0F6Feb3BA20c56E94CfbCD98339E99bcE629D912","component":"Server","body":{"query":"{ indexingStatuses { subgraph } }"},"headers":{"host":"loadbalancer","connection":"close","content-length":"45","x-real-ip":"172.26.0.1","x-forwarded-for":"172.26.0.1","x-forwarded-proto":"https","x-forwarded-ssl":"on","x-forwarded-port":"443","content-type":"application/json","accept":"*/*","user-agent":"node-fetch/1.0 (+https://github.com/bitinn/node-fetch)","accept-encoding":"gzip,deflate"},"err":{"type":"IndexerError","message":"Failed to handle state channel message","stack":"IndexerError: Failed to handle state channel message\n at Object.indexerError (/opt/indexer/packages/indexer-common/dist/errors.js:91:12)\n at /opt/indexer/packages/indexer-service/dist/server/index.js:261:42\n at Generator.throw (<anonymous>)\n at rejected (/opt/indexer/packages/indexer-service/dist/server/index.js:6:65)","code":"IE023","explanation":"https://github.com/graphprotocol/indexer/blob/master/docs/errors.md#ie023","cause":{"type":"Error","message":"Invalid message","stack":"Error: Invalid message\n at Object.validateMessage (/opt/indexer/node_modules/@statechannels/wire-format/lib/src/validator.js:29:15)\n at Object.validatePayload (/opt/indexer/node_modules/@statechannels/wallet-core/lib/src/serde/wire-format/deserialize.js:15:26)\n at SingleThreadedWallet.pushMessage (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/wallet.js:275:43)\n at /opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/multi-threaded-wallet/worker.js:36:209\n at timeAsync (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/metrics.js:58:22)\n at /opt/indexer/node_modules/@statechannels/server-wallet/lib/src/metrics.js:45:70\n at MessagePort.<anonymous> (/opt/indexer/node_modules/@statechannels/server-wallet/lib/src/wallet/multi-threaded-wallet/worker.js:36:175)\n at MessagePort.emit (events.js:321:20)\n at MessagePort.onmessage (internal/worker/io.js:78:8)"}},"msg":"Failed to handle state channel message"}
`
|
non_design
|
indexer service i don t really know what caused this it only happened on one service node level time pid hostname name indexerservice indexer operator indexer operator component server body query indexingstatuses subgraph headers host loadbalancer connection close content length x real ip x forwarded for x forwarded proto https x forwarded ssl on x forwarded port content type application json accept user agent node fetch to handle state channel message stack indexererror failed to handle state channel message n at object indexererror opt indexer packages indexer common dist errors js n at opt indexer packages indexer service dist server index js n at generator throw n at rejected opt indexer packages indexer service dist server index js code explanation message stack error invalid message n at object validatemessage opt indexer node modules statechannels wire format lib src validator js n at object validatepayload opt indexer node modules statechannels wallet core lib src serde wire format deserialize js n at singlethreadedwallet pushmessage opt indexer node modules statechannels server wallet lib src wallet wallet js n at opt indexer node modules statechannels server wallet lib src wallet multi threaded wallet worker js n at timeasync opt indexer node modules statechannels server wallet lib src metrics js n at opt indexer node modules statechannels server wallet lib src metrics js n at messageport opt indexer node modules statechannels server wallet lib src wallet multi threaded wallet worker js n at messageport emit events js n at messageport onmessage internal worker io js msg failed to handle state channel message
| 0
|
8,480
| 2,872,340,103
|
IssuesEvent
|
2015-06-08 11:14:54
|
cla-assistant/cla-assistant
|
https://api.github.com/repos/cla-assistant/cla-assistant
|
closed
|
wording
|
design
|
We're happy to get some help with the wording:
- Pop Up "Contributors who signed a CLA" --> List of contributors?
|
1.0
|
wording - We're happy to get some help with the wording:
- Pop Up "Contributors who signed a CLA" --> List of contributors?
|
design
|
wording we re happy to get some help with the wording pop up contributors who signed a cla list of contributors
| 1
|
50,292
| 6,346,337,306
|
IssuesEvent
|
2017-07-28 01:42:04
|
httpwg/http-extensions
|
https://api.github.com/repos/httpwg/http-extensions
|
closed
|
Enabling O(1) removal from digest
|
cache-digest design
|
Current spec is using Golomb-coded sets as the algorithm to create digests.
While they show great space-efficiency, Golomb-coded sets do not enable O(1) removal from the digest, which means from a browser implementation perspective, the browser would have to calculate the hash for each host upon connection creation.
That poses a couple of issues from an implementation perspective:
* Calculating the hash on each connection establishment may be expensive. That part seems inherent to the algorithm and not likely to be optimized away.
* Calculating the hash requires per-host indexing. That part is just a limitation of many current cache implementations.
A cache digest algorithm that enables O(1) removal (as well as addition) to the digest would enable us to move away from those limitations:
* Browsers can calculate a per-host digest once, then keep updating it as resources are added to the cache as well as when resources are removed from the cache. No need for per-host indexing.
- In order to do that, browsers would need to persist digests along with the cache
* Upon connection establishment, the browser can just send the ready-made digest to the server. Win!
During the HTTPWS, counting bloom filters were mentioned as an O(1) removal algorithm, but they are extremely inefficient when it comes to space. (~4 times bigger than bloom filters)
Turns out, [Cuckoo filters](https://www.cs.cmu.edu/~binfan/papers/login_cuckoofilter.pdf) enable O(1) removal while being more space efficient than bloom filters. While they are slightly bigger than Golomb-coded sets based digests, the cheaper runtime costs can make up for that deficiency.
/cc @kazuho @mnot @cbentzel @mcmanus
|
1.0
|
Enabling O(1) removal from digest - Current spec is using Golomb-coded sets as the algorithm to create digests.
While they show great space-efficiency, Golomb-coded sets do not enable O(1) removal from the digest, which means from a browser implementation perspective, the browser would have to calculate the hash for each host upon connection creation.
That poses a couple of issues from an implementation perspective:
* Calculating the hash on each connection establishment may be expensive. That part seems inherent to the algorithm and not likely to be optimized away.
* Calculating the hash requires per-host indexing. That part is just a limitation of many current cache implementations.
A cache digest algorithm that enables O(1) removal (as well as addition) to the digest would enable us to move away from those limitations:
* Browsers can calculate a per-host digest once, then keep updating it as resources are added to the cache as well as when resources are removed from the cache. No need for per-host indexing.
- In order to do that, browsers would need to persist digests along with the cache
* Upon connection establishment, the browser can just send the ready-made digest to the server. Win!
During the HTTPWS, counting bloom filters were mentioned as an O(1) removal algorithm, but they are extremely inefficient when it comes to space. (~4 times bigger than bloom filters)
Turns out, [Cuckoo filters](https://www.cs.cmu.edu/~binfan/papers/login_cuckoofilter.pdf) enable O(1) removal while being more space efficient than bloom filters. While they are slightly bigger than Golomb-coded sets based digests, the cheaper runtime costs can make up for that deficiency.
/cc @kazuho @mnot @cbentzel @mcmanus
|
design
|
enabling o removal from digest current spec is using golomb coded sets as the algorithm to create digests while they show great space efficiency golomb coded sets do not enable o removal from the digest which means from a browser implementation perspective the browser would have to calculate the hash for each host upon connection creation that poses a couple of issues from an implementation perspective calculating the hash on each connection establishment may be expensive that part seems inherent to the algorithm and not likely to be optimized away calculating the hash requires per host indexing that part is just a limitation of many current cache implementations a cache digest algorithm that enables o removal as well as addition to the digest would enable us to move away from those limitations browsers can calculate a per host digest once then keep updating it as resources are added to the cache as well as when resources are removed from the cache no need for per host indexing in order to do that browsers would need to persist digests along with the cache upon connection establishment the browser can just send the ready made digest to the server win during the httpws counting bloom filters were mentioned as an o removal algorithm but they are extremely inefficient when it comes to space times bigger than bloom filters turns out enable o removal while being more space efficient than bloom filters while they are slightly bigger than golomb coded sets based digests the cheaper runtime costs can make up for that deficiency cc kazuho mnot cbentzel mcmanus
| 1
|
48,760
| 13,397,972,821
|
IssuesEvent
|
2020-09-03 12:29:02
|
GNS3/gns3-web-ui
|
https://api.github.com/repos/GNS3/gns3-web-ui
|
closed
|
CVE-2020-7720 (High) detected in node-forge-0.9.0.tgz
|
security vulnerability
|
## CVE-2020-7720 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>node-forge-0.9.0.tgz</b></p></summary>
<p>JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.</p>
<p>Library home page: <a href="https://registry.npmjs.org/node-forge/-/node-forge-0.9.0.tgz">https://registry.npmjs.org/node-forge/-/node-forge-0.9.0.tgz</a></p>
<p>Path to dependency file: /tmp/ws-scm/gns3-web-ui/package.json</p>
<p>Path to vulnerable library: /tmp/ws-scm/gns3-web-ui/node_modules/node-forge/package.json</p>
<p>
Dependency Hierarchy:
- build-angular-0.1000.8.tgz (Root Library)
- webpack-dev-server-3.11.0.tgz
- selfsigned-1.10.7.tgz
- :x: **node-forge-0.9.0.tgz** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/GNS3/gns3-web-ui/commit/94ce514cfe47c68feb6bc88815f9e0c753380d3f">94ce514cfe47c68feb6bc88815f9e0c753380d3f</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
All versions of package node-forge are vulnerable to Prototype Pollution via the util.setPath function.
<p>Publish Date: 2020-07-21
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-7720>CVE-2020-7720</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>9.8</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: High
- Availability Impact: High
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<!-- <REMEDIATE>{"isOpenPROnVulnerability":false,"isPackageBased":true,"isDefaultBranch":true,"packages":[{"packageType":"javascript/Node.js","packageName":"node-forge","packageVersion":"0.9.0","isTransitiveDependency":true,"dependencyTree":"@angular-devkit/build-angular:0.1000.8;webpack-dev-server:3.11.0;selfsigned:1.10.7;node-forge:0.9.0","isMinimumFixVersionAvailable":false}],"vulnerabilityIdentifier":"CVE-2020-7720","vulnerabilityDetails":"All versions of package node-forge are vulnerable to Prototype Pollution via the util.setPath function.","vulnerabilityUrl":"https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-7720","cvss3Severity":"high","cvss3Score":"9.8","cvss3Metrics":{"A":"High","AC":"Low","PR":"None","S":"Unchanged","C":"High","UI":"None","AV":"Network","I":"High"},"extraData":{}}</REMEDIATE> -->
|
True
|
CVE-2020-7720 (High) detected in node-forge-0.9.0.tgz - ## CVE-2020-7720 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>node-forge-0.9.0.tgz</b></p></summary>
<p>JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.</p>
<p>Library home page: <a href="https://registry.npmjs.org/node-forge/-/node-forge-0.9.0.tgz">https://registry.npmjs.org/node-forge/-/node-forge-0.9.0.tgz</a></p>
<p>Path to dependency file: /tmp/ws-scm/gns3-web-ui/package.json</p>
<p>Path to vulnerable library: /tmp/ws-scm/gns3-web-ui/node_modules/node-forge/package.json</p>
<p>
Dependency Hierarchy:
- build-angular-0.1000.8.tgz (Root Library)
- webpack-dev-server-3.11.0.tgz
- selfsigned-1.10.7.tgz
- :x: **node-forge-0.9.0.tgz** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/GNS3/gns3-web-ui/commit/94ce514cfe47c68feb6bc88815f9e0c753380d3f">94ce514cfe47c68feb6bc88815f9e0c753380d3f</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
All versions of package node-forge are vulnerable to Prototype Pollution via the util.setPath function.
<p>Publish Date: 2020-07-21
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-7720>CVE-2020-7720</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>9.8</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: High
- Availability Impact: High
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<!-- <REMEDIATE>{"isOpenPROnVulnerability":false,"isPackageBased":true,"isDefaultBranch":true,"packages":[{"packageType":"javascript/Node.js","packageName":"node-forge","packageVersion":"0.9.0","isTransitiveDependency":true,"dependencyTree":"@angular-devkit/build-angular:0.1000.8;webpack-dev-server:3.11.0;selfsigned:1.10.7;node-forge:0.9.0","isMinimumFixVersionAvailable":false}],"vulnerabilityIdentifier":"CVE-2020-7720","vulnerabilityDetails":"All versions of package node-forge are vulnerable to Prototype Pollution via the util.setPath function.","vulnerabilityUrl":"https://vuln.whitesourcesoftware.com/vulnerability/CVE-2020-7720","cvss3Severity":"high","cvss3Score":"9.8","cvss3Metrics":{"A":"High","AC":"Low","PR":"None","S":"Unchanged","C":"High","UI":"None","AV":"Network","I":"High"},"extraData":{}}</REMEDIATE> -->
|
non_design
|
cve high detected in node forge tgz cve high severity vulnerability vulnerable library node forge tgz javascript implementations of network transports cryptography ciphers pki message digests and various utilities library home page a href path to dependency file tmp ws scm web ui package json path to vulnerable library tmp ws scm web ui node modules node forge package json dependency hierarchy build angular tgz root library webpack dev server tgz selfsigned tgz x node forge tgz vulnerable library found in head commit a href vulnerability details all versions of package node forge are vulnerable to prototype pollution via the util setpath function publish date url a href cvss score details base score metrics exploitability metrics attack vector network attack complexity low privileges required none user interaction none scope unchanged impact metrics confidentiality impact high integrity impact high availability impact high for more information on scores click a href isopenpronvulnerability false ispackagebased true isdefaultbranch true packages vulnerabilityidentifier cve vulnerabilitydetails all versions of package node forge are vulnerable to prototype pollution via the util setpath function vulnerabilityurl
| 0
|
102,161
| 12,748,353,501
|
IssuesEvent
|
2020-06-26 19:55:58
|
COVID19Tracking/website
|
https://api.github.com/repos/COVID19Tracking/website
|
closed
|
Clean up blog author footer
|
DESIGN
|
The author bios and photos at the end of blog posts are in need of a refresh:
- [x] bottom spacing
- [x] align the text and author bio / ~~use the new grid~~
|
1.0
|
Clean up blog author footer - The author bios and photos at the end of blog posts are in need of a refresh:
- [x] bottom spacing
- [x] align the text and author bio / ~~use the new grid~~
|
design
|
clean up blog author footer the author bios and photos at the end of blog posts are in need of a refresh bottom spacing align the text and author bio use the new grid
| 1
|
63,600
| 7,733,218,187
|
IssuesEvent
|
2018-05-26 08:46:30
|
rsbmatt/OSBuddy
|
https://api.github.com/repos/rsbmatt/OSBuddy
|
closed
|
Clue Scroll : 01 degrees 30 minutes north 20 degrees 01 minutes east.
|
res-by design
|
# **Clue Scroll (Hard)**
# **Hint missing**
Since the overlay is going over the Fairy ring code I'd suggest a hint.
"Located on a small island that can only be accessed via fairy ring code CLP." - Wiki
|
1.0
|
Clue Scroll : 01 degrees 30 minutes north 20 degrees 01 minutes east. - # **Clue Scroll (Hard)**
# **Hint missing**
Since the overlay is going over the Fairy ring code I'd suggest a hint.
"Located on a small island that can only be accessed via fairy ring code CLP." - Wiki
|
design
|
clue scroll degrees minutes north degrees minutes east clue scroll hard hint missing since the overlay is going over the fairy ring code i d suggest a hint located on a small island that can only be accessed via fairy ring code clp wiki
| 1
|
62,363
| 7,574,380,783
|
IssuesEvent
|
2018-04-23 20:47:33
|
clairezed/ensemble
|
https://api.github.com/repos/clairezed/ensemble
|
closed
|
Points design
|
design
|
## Page event
- [x] style des alerts status event
- [ ] style du haut des pages event : place des boutons ? infos ?
## Formulaire event
- [ ] boutons bas formulaire event
- [ ] liste documents
## Vignette event
- [x] position de l'indication "participant mirador" ?
## Page user
- [ ] liste loisirs user
|
1.0
|
Points design - ## Page event
- [x] style des alerts status event
- [ ] style du haut des pages event : place des boutons ? infos ?
## Formulaire event
- [ ] boutons bas formulaire event
- [ ] liste documents
## Vignette event
- [x] position de l'indication "participant mirador" ?
## Page user
- [ ] liste loisirs user
|
design
|
points design page event style des alerts status event style du haut des pages event place des boutons infos formulaire event boutons bas formulaire event liste documents vignette event position de l indication participant mirador page user liste loisirs user
| 1
|
152,830
| 24,023,975,774
|
IssuesEvent
|
2022-09-15 09:55:07
|
Tonomy-Foundation/Tonomy-ID
|
https://api.github.com/repos/Tonomy-Foundation/Tonomy-ID
|
opened
|
Research for SSO login flows
|
design
|
This task is to research different SSO login close to meet the requirements of Tonomy ID clients
Definition of done
- [ ] Said existing SSI and identity app SSO flows are reviewed
|
1.0
|
Research for SSO login flows - This task is to research different SSO login close to meet the requirements of Tonomy ID clients
Definition of done
- [ ] Said existing SSI and identity app SSO flows are reviewed
|
design
|
research for sso login flows this task is to research different sso login close to meet the requirements of tonomy id clients definition of done said existing ssi and identity app sso flows are reviewed
| 1
|
115,290
| 14,708,756,386
|
IssuesEvent
|
2021-01-05 00:32:30
|
hsutter/708
|
https://api.github.com/repos/hsutter/708
|
closed
|
Why is mutation of out parameters restricted?
|
by design
|
My reading of section 1.1.2 (1.3.3 doesn't support this but also doesn't explicitly contradict it) is that this code is valid
```
void foo(out MyType x) {
x = MyType();
x = MyType(4); //You would (presumably) never want to do this
}
```
but this code is not
```
void foo(out MyType x) {
x = MyType();
x.data = 4; //but you might want to do this
}
```
Why is this? Why prevent modification of the out object once we know it has been assigned. It's already required that x is assigned on every path so presumably the compiler would be able to identify for a given line whether x was already assigned by that line or not.
The second example might arise if a constructor doesn't exist that puts the object into the exact state you want to return (keeping in mind the author of foo may not have or want control over the constructor of MyType).
It would seem that the solution is to write something like
```
void foo(out MyType x) {
auto x2 = MyType();
x2.data = 4;
x = std::move(x2);
}
```
I'm concerned that this doesn't express intent, doubles the amount of code the reader has to parse and the writer has to write and introduces an extra construction (which may or may not be able to be optimized away). I also worry that in the absence of the mentioned change (at the end of the notes in 1.3.1) to treat last use as move automatically the move would easily be overlooked. Moreover it just seems like an unnecessary restriction on what the user can do. Intuitively I think of an out parameter as like a local variable which is ```=uninitialized```.
|
1.0
|
Why is mutation of out parameters restricted? - My reading of section 1.1.2 (1.3.3 doesn't support this but also doesn't explicitly contradict it) is that this code is valid
```
void foo(out MyType x) {
x = MyType();
x = MyType(4); //You would (presumably) never want to do this
}
```
but this code is not
```
void foo(out MyType x) {
x = MyType();
x.data = 4; //but you might want to do this
}
```
Why is this? Why prevent modification of the out object once we know it has been assigned. It's already required that x is assigned on every path so presumably the compiler would be able to identify for a given line whether x was already assigned by that line or not.
The second example might arise if a constructor doesn't exist that puts the object into the exact state you want to return (keeping in mind the author of foo may not have or want control over the constructor of MyType).
It would seem that the solution is to write something like
```
void foo(out MyType x) {
auto x2 = MyType();
x2.data = 4;
x = std::move(x2);
}
```
I'm concerned that this doesn't express intent, doubles the amount of code the reader has to parse and the writer has to write and introduces an extra construction (which may or may not be able to be optimized away). I also worry that in the absence of the mentioned change (at the end of the notes in 1.3.1) to treat last use as move automatically the move would easily be overlooked. Moreover it just seems like an unnecessary restriction on what the user can do. Intuitively I think of an out parameter as like a local variable which is ```=uninitialized```.
|
design
|
why is mutation of out parameters restricted my reading of section doesn t support this but also doesn t explicitly contradict it is that this code is valid void foo out mytype x x mytype x mytype you would presumably never want to do this but this code is not void foo out mytype x x mytype x data but you might want to do this why is this why prevent modification of the out object once we know it has been assigned it s already required that x is assigned on every path so presumably the compiler would be able to identify for a given line whether x was already assigned by that line or not the second example might arise if a constructor doesn t exist that puts the object into the exact state you want to return keeping in mind the author of foo may not have or want control over the constructor of mytype it would seem that the solution is to write something like void foo out mytype x auto mytype data x std move i m concerned that this doesn t express intent doubles the amount of code the reader has to parse and the writer has to write and introduces an extra construction which may or may not be able to be optimized away i also worry that in the absence of the mentioned change at the end of the notes in to treat last use as move automatically the move would easily be overlooked moreover it just seems like an unnecessary restriction on what the user can do intuitively i think of an out parameter as like a local variable which is uninitialized
| 1
|
87,087
| 10,866,699,322
|
IssuesEvent
|
2019-11-14 21:51:46
|
mozilla/voice-web
|
https://api.github.com/repos/mozilla/voice-web
|
opened
|
Mobile version - Stats page
|
Design Priority: P0 voice-challenge
|
1.0
|
Mobile version - Stats page - https://www.dropbox.com/s/8wia34twsv739nu/Screenshot%202019-11-14%2016.50.26.png?dl=0
1.Wrong title placement
2.Text in button should be all caps
3.Missing progress bar
4. Wrong placement
@mbransn @rileyjshaw
|
design
|
mobile version stats page wrong title placement text in button should be all caps missing progress bar wrong placement mbransn rileyjshaw
| 1
|
|
70,641
| 30,700,933,772
|
IssuesEvent
|
2023-07-26 23:17:27
|
microsoft/vscode-cpptools
|
https://api.github.com/repos/microsoft/vscode-cpptools
|
opened
|
Code actions on missing includes aren't detecting system includes
|
bug Language Service regression Feature: Configuration
|
This used to work at some point with an internal build, but I'm not sure if it ever worked with a public release (i.e. the ones I tried all don't work).
The code action implementation is supposed to check if it's a system header and show different code actions.
You can set compilerPath to "" for a repro.
|
1.0
|
Code actions on missing includes aren't detecting system includes - This used to work at some point with an internal build, but I'm not sure if it ever worked with a public release (i.e. the ones I tried all don't work).
The code action implementation is supposed to check if it's a system header and show different code actions.
You can set compilerPath to "" for a repro.
|
non_design
|
code actions on missing includes aren t detecting system includes this used to work at some point with an internal build but i m not sure if it ever worked with a public release i e the ones i tried all don t work the code action implementation is supposed to check if it s a system header and show different code actions you can set compilerpath to for a repro
| 0
|
86,781
| 10,818,318,418
|
IssuesEvent
|
2019-11-08 11:46:10
|
fac18/week2-CEFG-To-do
|
https://api.github.com/repos/fac18/week2-CEFG-To-do
|
closed
|
some design remarks
|
design enhancement
|
🥳 I really like the overall feeling of your page and the colour palette you used. It is really great!
🤔From the UX perspective maybe it would make more sense to place the input above the todos list, as it represents the main functionality on the page.
Also I was wondering if using the black colour for icons in the buttons is the right way. To have a better contrast I would probably go with white.
|
1.0
|
some design remarks - 🥳 I really like the overall feeling of your page and the colour palette you used. It is really great!
🤔From the UX perspective maybe it would make more sense to place the input above the todos list, as it represents the main functionality on the page.
Also I was wondering if using the black colour for icons in the buttons is the right way. To have a better contrast I would probably go with white.
|
design
|
some design remarks 🥳 i really like the overall feeling of your page and the colour palette you used it is really great 🤔from the ux perspective maybe it would make more sense to place the input above the todos list as it represents the main functionality on the page also i was wondering if using the black colour for icons in the buttons is the right way to have a better contrast i would probably go with white
| 1
|
132,764
| 18,760,728,092
|
IssuesEvent
|
2021-11-05 16:09:03
|
carbon-design-system/carbon-for-ibm-dotcom-website
|
https://api.github.com/repos/carbon-design-system/carbon-for-ibm-dotcom-website
|
opened
|
Website [About] Team information
|
design content website
|
Once preliminary pages have been updated, we can consider additional work to build out the `About` pages to ensure they are delivering the right message about DDS, the team, what we provide and so on, as the first step of someone discovering more about this team.
Things to consider:
- [ ] include photos of team members to make the team more accessible
- [ ] include a "What's happening" section
- [ ] Add details about office hours and other ways people can engage with the team
- [ ] do we need Release history and general information on the site?
- [ ] anything that needs to be included based on any new D&UX review processes and standards?
|
1.0
|
Website [About] Team information - Once preliminary pages have been updated, we can consider additional work to build out the `About` pages to ensure they are delivering the right message about DDS, the team, what we provide and so on, as the first step of someone discovering more about this team.
Things to consider:
- [ ] include photos of team members to make the team more accessible
- [ ] include a "What's happening" section
- [ ] Add details about office hours and other ways people can engage with the team
- [ ] do we need Release history and general information on the site?
- [ ] anything that needs to be included based on any new D&UX review processes and standards?
|
design
|
website team information once preliminary pages have been updated we can consider additional work to build out the about pages to ensure they are delivering the right message about dds the team what we provide and so on as the first step of someone discovering more about this team things to consider include photos of team members to make the team more accessible include a what s happening section add details about office hours and other ways people can engage with the team do we need release history and general information on the site anything that needs to be included based on any new d ux review processes and standards
| 1
|
76,599
| 9,466,386,115
|
IssuesEvent
|
2019-04-18 04:14:44
|
Microsoft/BosqueLanguage
|
https://api.github.com/repos/Microsoft/BosqueLanguage
|
opened
|
Formalize Semantic Versioning
|
design discussion research item
|
What does it mean to bump the patch/minor/major level of a semantic version for our packages? Can we formally specify this hopefully validating later?
|
1.0
|
Formalize Semantic Versioning - What does it mean to bump the patch/minor/major level of a semantic version for our packages? Can we formally specify this hopefully validating later?
|
design
|
formalize semantic versioning what does it mean to bump the patch minor major level of a semantic version for our packages can we formally specify this hopefully validating later
| 1
|
283,155
| 24,528,045,813
|
IssuesEvent
|
2022-10-11 14:26:56
|
mozilla-mobile/focus-android
|
https://api.github.com/repos/mozilla-mobile/focus-android
|
reopened
|
Tracking UI Tests disabled with frequent ANR
|
eng:intermittent-test eng:disabled-test
|
See: https://github.com/mozilla-mobile/focus-android/issues/7344
The following tests were frequently hitting ANRs in the Client on Firebase:
`notificationEraseAndOpenButtonTest`
`noNetworkConnectionErrorPageTest`
`removeAllExceptionURLTest`
`addURLToTPExceptionsListTest`
`removeOneExceptionURLTest`
`testCustomTabUI`
`emailLinkTest`
|
2.0
|
Tracking UI Tests disabled with frequent ANR - See: https://github.com/mozilla-mobile/focus-android/issues/7344
The following tests were frequently hitting ANRs in the Client on Firebase:
`notificationEraseAndOpenButtonTest`
`noNetworkConnectionErrorPageTest`
`removeAllExceptionURLTest`
`addURLToTPExceptionsListTest`
`removeOneExceptionURLTest`
`testCustomTabUI`
`emailLinkTest`
|
non_design
|
tracking ui tests disabled with frequent anr see the following tests were frequently hitting anrs in the client on firebase notificationeraseandopenbuttontest nonetworkconnectionerrorpagetest removeallexceptionurltest addurltotpexceptionslisttest removeoneexceptionurltest testcustomtabui emaillinktest
| 0
|
151,083
| 19,648,447,939
|
IssuesEvent
|
2022-01-10 01:45:00
|
turkdevops/quasar
|
https://api.github.com/repos/turkdevops/quasar
|
opened
|
CVE-2022-0122 (Medium) detected in node-forge-0.10.0.tgz
|
security vulnerability
|
## CVE-2022-0122 - Medium Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>node-forge-0.10.0.tgz</b></p></summary>
<p>JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.</p>
<p>Library home page: <a href="https://registry.npmjs.org/node-forge/-/node-forge-0.10.0.tgz">https://registry.npmjs.org/node-forge/-/node-forge-0.10.0.tgz</a></p>
<p>Path to dependency file: /cli/package.json</p>
<p>Path to vulnerable library: /cli/node_modules/node-forge/package.json,/app/node_modules/node-forge/package.json,/ui/node_modules/node-forge/package.json,/docs/node_modules/node-forge/package.json</p>
<p>
Dependency Hierarchy:
- webpack-dev-server-3.11.0.tgz (Root Library)
- selfsigned-1.10.11.tgz
- :x: **node-forge-0.10.0.tgz** (Vulnerable Library)
<p>Found in base branch: <b>dev</b></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/medium_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
forge is vulnerable to URL Redirection to Untrusted Site
<p>Publish Date: 2022-01-06
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2022-0122>CVE-2022-0122</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>5.3</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: None
- Integrity Impact: Low
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://huntr.dev/bounties/41852c50-3c6d-4703-8c55-4db27164a4ae/">https://huntr.dev/bounties/41852c50-3c6d-4703-8c55-4db27164a4ae/</a></p>
<p>Release Date: 2022-01-06</p>
<p>Fix Resolution: forge - v1.0.0</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
True
|
CVE-2022-0122 (Medium) detected in node-forge-0.10.0.tgz - ## CVE-2022-0122 - Medium Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>node-forge-0.10.0.tgz</b></p></summary>
<p>JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.</p>
<p>Library home page: <a href="https://registry.npmjs.org/node-forge/-/node-forge-0.10.0.tgz">https://registry.npmjs.org/node-forge/-/node-forge-0.10.0.tgz</a></p>
<p>Path to dependency file: /cli/package.json</p>
<p>Path to vulnerable library: /cli/node_modules/node-forge/package.json,/app/node_modules/node-forge/package.json,/ui/node_modules/node-forge/package.json,/docs/node_modules/node-forge/package.json</p>
<p>
Dependency Hierarchy:
- webpack-dev-server-3.11.0.tgz (Root Library)
- selfsigned-1.10.11.tgz
- :x: **node-forge-0.10.0.tgz** (Vulnerable Library)
<p>Found in base branch: <b>dev</b></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/medium_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
forge is vulnerable to URL Redirection to Untrusted Site
<p>Publish Date: 2022-01-06
<p>URL: <a href=https://vuln.whitesourcesoftware.com/vulnerability/CVE-2022-0122>CVE-2022-0122</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>5.3</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: None
- Integrity Impact: Low
- Availability Impact: None
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://huntr.dev/bounties/41852c50-3c6d-4703-8c55-4db27164a4ae/">https://huntr.dev/bounties/41852c50-3c6d-4703-8c55-4db27164a4ae/</a></p>
<p>Release Date: 2022-01-06</p>
<p>Fix Resolution: forge - v1.0.0</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
non_design
|
cve medium detected in node forge tgz cve medium severity vulnerability vulnerable library node forge tgz javascript implementations of network transports cryptography ciphers pki message digests and various utilities library home page a href path to dependency file cli package json path to vulnerable library cli node modules node forge package json app node modules node forge package json ui node modules node forge package json docs node modules node forge package json dependency hierarchy webpack dev server tgz root library selfsigned tgz x node forge tgz vulnerable library found in base branch dev vulnerability details forge is vulnerable to url redirection to untrusted site publish date url a href cvss score details base score metrics exploitability metrics attack vector network attack complexity low privileges required none user interaction none scope unchanged impact metrics confidentiality impact none integrity impact low availability impact none for more information on scores click a href suggested fix type upgrade version origin a href release date fix resolution forge step up your open source security game with whitesource
| 0
|
157,771
| 24,724,868,665
|
IssuesEvent
|
2022-10-20 13:25:22
|
Decathlon/vitamin-web
|
https://api.github.com/repos/Decathlon/vitamin-web
|
closed
|
fix: remove showcase of `tooltip` on icon
|
documentation 📝 enhancement 🚀 CSS 🎨 design request 🙌
|
<!--
Before submitting an issue, please consult our [documentation](https://decathlon.design).
Please make sure you are posting an issue pertaining to the Decathlon Design System.
Note that before opening an issue, you can chat maintainer of this project on channel
#vitamin-web in [Decathlon Design System's Slack(https://join.slack.com/t/decathlon-design/shared_invite/zt-ou0n9qas-n_oamDSVUIqvLqNO1LETJg).
If you want to know how to contribute to this project, you can check our CONTRIBUTING file:
https://github.com/Decathlon/vitamin-web/blob/main/CONTRIBUTING.md
If a section isn't adapted for your request, please remove it to avoid any unnecessary section.
Thanks!
-->
**Is your request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
According to [the MDN web docs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role) : "The tooltip is not the appropriate role for the more information "i" icon, ⓘ. A tooltip is directly associated with the owning element. The ⓘ isn't 'described by' detailed information; the tool or control is."
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
- Remove the examples with an icon only, or replace them with a clear described information.
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
|
1.0
|
fix: remove showcase of `tooltip` on icon - <!--
Before submitting an issue, please consult our [documentation](https://decathlon.design).
Please make sure you are posting an issue pertaining to the Decathlon Design System.
Note that before opening an issue, you can chat maintainer of this project on channel
#vitamin-web in [Decathlon Design System's Slack(https://join.slack.com/t/decathlon-design/shared_invite/zt-ou0n9qas-n_oamDSVUIqvLqNO1LETJg).
If you want to know how to contribute to this project, you can check our CONTRIBUTING file:
https://github.com/Decathlon/vitamin-web/blob/main/CONTRIBUTING.md
If a section isn't adapted for your request, please remove it to avoid any unnecessary section.
Thanks!
-->
**Is your request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
According to [the MDN web docs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role) : "The tooltip is not the appropriate role for the more information "i" icon, ⓘ. A tooltip is directly associated with the owning element. The ⓘ isn't 'described by' detailed information; the tool or control is."
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
- Remove the examples with an icon only, or replace them with a clear described information.
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
|
design
|
fix remove showcase of tooltip on icon before submitting an issue please consult our please make sure you are posting an issue pertaining to the decathlon design system note that before opening an issue you can chat maintainer of this project on channel vitamin web in decathlon design system s slack if you want to know how to contribute to this project you can check our contributing file if a section isn t adapted for your request please remove it to avoid any unnecessary section thanks is your request related to a problem please describe according to the tooltip is not the appropriate role for the more information i icon ⓘ a tooltip is directly associated with the owning element the ⓘ isn t described by detailed information the tool or control is describe the solution you d like remove the examples with an icon only or replace them with a clear described information additional context
| 1
|
388,880
| 11,493,980,695
|
IssuesEvent
|
2020-02-12 00:20:52
|
Sage-Bionetworks/dccvalidator
|
https://api.github.com/repos/Sage-Bionetworks/dccvalidator
|
closed
|
Make manifest file optional
|
bug high priority
|
By restricting the manifest file type that can be uploaded (.tsv, .txt),the app requires the inclusion of a manifest file.
End users may want to validate the metadata files independently.
|
1.0
|
Make manifest file optional - By restricting the manifest file type that can be uploaded (.tsv, .txt),the app requires the inclusion of a manifest file.
End users may want to validate the metadata files independently.
|
non_design
|
make manifest file optional by restricting the manifest file type that can be uploaded tsv txt the app requires the inclusion of a manifest file end users may want to validate the metadata files independently
| 0
|
11,570
| 3,506,828,638
|
IssuesEvent
|
2016-01-08 09:43:14
|
ropensci/webchem
|
https://api.github.com/repos/ropensci/webchem
|
closed
|
Add examples to all fnx for bulk processing
|
Documentation Next CRAN release
|
e.g.
```r
require(webchem)
compounds <- c('Triclosan', 'Formaldehyde')
# query all compounds, return first hit (-> named vector)
sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas', first = TRUE))
# query all compounds, return all hits (-> named list)
sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas'))
# format as data.frame
ll <- sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas'))
data.frame(compound = rep(names(ll), sapply(ll, length)),
cas = unlist(ll))
```
- [x] allanwood
- [x] chemspider
- [x] cir
- [x] cts
- [x] etox
- [x] pan
- [x] physprop
- [x] ppdb
- [x] pubchem
- [x] chemid
- [x] wikidata
|
1.0
|
Add examples to all fnx for bulk processing - e.g.
```r
require(webchem)
compounds <- c('Triclosan', 'Formaldehyde')
# query all compounds, return first hit (-> named vector)
sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas', first = TRUE))
# query all compounds, return all hits (-> named list)
sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas'))
# format as data.frame
ll <- sapply(compounds,
function(x) cir_query(identifier = x , representation = 'cas'))
data.frame(compound = rep(names(ll), sapply(ll, length)),
cas = unlist(ll))
```
- [x] allanwood
- [x] chemspider
- [x] cir
- [x] cts
- [x] etox
- [x] pan
- [x] physprop
- [x] ppdb
- [x] pubchem
- [x] chemid
- [x] wikidata
|
non_design
|
add examples to all fnx for bulk processing e g r require webchem compounds c triclosan formaldehyde query all compounds return first hit named vector sapply compounds function x cir query identifier x representation cas first true query all compounds return all hits named list sapply compounds function x cir query identifier x representation cas format as data frame ll sapply compounds function x cir query identifier x representation cas data frame compound rep names ll sapply ll length cas unlist ll allanwood chemspider cir cts etox pan physprop ppdb pubchem chemid wikidata
| 0
|
182,062
| 30,788,795,761
|
IssuesEvent
|
2023-07-31 14:49:57
|
kedro-org/kedro-viz
|
https://api.github.com/repos/kedro-org/kedro-viz
|
closed
|
Collaborative experiment tracking v3.0 - Sharing user modifications
|
Issue: Feature Request Design: Research
|
## Description
Currently, any modifications made by the user, such as changing the title, bookmarking, or adding notes, are not uploaded to the cloud storage. These modifications are local to the user's session_store on their local machine.
The purpose of this design ticket is to explore the best approach for enabling collaboration among users in modifying experiment metadata, including bookmarks, titles, and notes.
Some examples of different scenarios to consider include:
- Different users may want to bookmark different experiments. One possible solution is to provide two bookmark sections: "My Bookmarks" and "Shared Bookmarks" to accommodate individual preferences.
- Users may become confused if an experiment's title is changed by another user without their knowledge. For example, they may be searching for an experiment they named, only to find that another user has renamed it.
There are other potential scenarios. So this ticket is to figure those and find an optimal solution.
## Checklist
- [x] Include labels so that we can categorise your feature request
|
1.0
|
Collaborative experiment tracking v3.0 - Sharing user modifications - ## Description
Currently, any modifications made by the user, such as changing the title, bookmarking, or adding notes, are not uploaded to the cloud storage. These modifications are local to the user's session_store on their local machine.
The purpose of this design ticket is to explore the best approach for enabling collaboration among users in modifying experiment metadata, including bookmarks, titles, and notes.
Some examples of different scenarios to consider include:
- Different users may want to bookmark different experiments. One possible solution is to provide two bookmark sections: "My Bookmarks" and "Shared Bookmarks" to accommodate individual preferences.
- Users may become confused if an experiment's title is changed by another user without their knowledge. For example, they may be searching for an experiment they named, only to find that another user has renamed it.
There are other potential scenarios. So this ticket is to figure those and find an optimal solution.
## Checklist
- [x] Include labels so that we can categorise your feature request
|
design
|
collaborative experiment tracking sharing user modifications description currently any modifications made by the user such as changing the title bookmarking or adding notes are not uploaded to the cloud storage these modifications are local to the user s session store on their local machine the purpose of this design ticket is to explore the best approach for enabling collaboration among users in modifying experiment metadata including bookmarks titles and notes some examples of different scenarios to consider include different users may want to bookmark different experiments one possible solution is to provide two bookmark sections my bookmarks and shared bookmarks to accommodate individual preferences users may become confused if an experiment s title is changed by another user without their knowledge for example they may be searching for an experiment they named only to find that another user has renamed it there are other potential scenarios so this ticket is to figure those and find an optimal solution checklist include labels so that we can categorise your feature request
| 1
|
150,947
| 23,739,079,150
|
IssuesEvent
|
2022-08-31 10:44:32
|
stores-cedcommerce/Lucy-Store-Design
|
https://api.github.com/repos/stores-cedcommerce/Lucy-Store-Design
|
opened
|
The handle needed to be update on the collection page.
|
Header section Desktop Design / UI / UX
|
**Actual result:**
The handle needed to be update on the collection page.
https://bellabrina-boutique.myshopify.com/collections/pants-1
https://bellabrina-boutique.myshopify.com/collections/shoes-1
https://bellabrina-boutique.myshopify.com/collections/accessories-1
**Expected result:**
The handle needed to be updated
|
1.0
|
The handle needed to be update on the collection page. - **Actual result:**
The handle needed to be update on the collection page.
https://bellabrina-boutique.myshopify.com/collections/pants-1
https://bellabrina-boutique.myshopify.com/collections/shoes-1
https://bellabrina-boutique.myshopify.com/collections/accessories-1
**Expected result:**
The handle needed to be updated
|
design
|
the handle needed to be update on the collection page actual result the handle needed to be update on the collection page expected result the handle needed to be updated
| 1
|
121,900
| 16,050,185,845
|
IssuesEvent
|
2021-04-22 18:08:20
|
hackforla/food-oasis
|
https://api.github.com/repos/hackforla/food-oasis
|
reopened
|
Espanol modal pop-up Site Survey
|
design: ui/ux dev: back-end dev: front-end
|
As a Latino food seeker, I want to cast my vote to have the site display in Spanish so that I can find resources in my native language.
Acceptance Criteria
Desktop/Mobile
- On the (Homepage and organization listings) need to display “View site in Espanol” button. This button would display to any user.
- Once the button is clicked it needs to pop up a modal window.
- Need to display this text to display in the modal "Estamos trabajando en una versión en español del sitio. Gracias por tu interés Sigue revisando."
- We need the user to be able to close the pop-up.
- We only want to display this button to the users that have visited the site but have not clicked on it.
- Need once a user clicks it, we need to track that user_id for that event attribute and then don't display that button again to that user on any page again.
- Need to capture results with “UTM” string for Google Analytics or an event with an attribute for Stormly.
See Wireframe
|
1.0
|
Espanol modal pop-up Site Survey - As a Latino food seeker, I want to cast my vote to have the site display in Spanish so that I can find resources in my native language.
Acceptance Criteria
Desktop/Mobile
- On the (Homepage and organization listings) need to display “View site in Espanol” button. This button would display to any user.
- Once the button is clicked it needs to pop up a modal window.
- Need to display this text to display in the modal "Estamos trabajando en una versión en español del sitio. Gracias por tu interés Sigue revisando."
- We need the user to be able to close the pop-up.
- We only want to display this button to the users that have visited the site but have not clicked on it.
- Need once a user clicks it, we need to track that user_id for that event attribute and then don't display that button again to that user on any page again.
- Need to capture results with “UTM” string for Google Analytics or an event with an attribute for Stormly.
See Wireframe
|
design
|
espanol modal pop up site survey as a latino food seeker i want to cast my vote to have the site display in spanish so that i can find resources in my native language acceptance criteria desktop mobile on the homepage and organization listings need to display “view site in espanol” button this button would display to any user once the button is clicked it needs to pop up a modal window need to display this text to display in the modal estamos trabajando en una versión en español del sitio gracias por tu interés sigue revisando we need the user to be able to close the pop up we only want to display this button to the users that have visited the site but have not clicked on it need once a user clicks it we need to track that user id for that event attribute and then don t display that button again to that user on any page again need to capture results with “utm” string for google analytics or an event with an attribute for stormly see wireframe
| 1
|
83,104
| 10,320,927,196
|
IssuesEvent
|
2019-08-30 22:22:32
|
liquidata-inc/dolt
|
https://api.github.com/repos/liquidata-inc/dolt
|
opened
|
Throw error when primary key is wrong in `rm-row`
|
documentation
|
When running `rm-row` we should inform the user that they have an error in their primary key. When the key is wrong:
```[oscarbatori:mta(master)] >> dolt table rm-row capital_dashboard_agencies project_number,project_number,plan_revision 'D501CB08','Capital Plan 2005 - 2009',"200504"
No row with pk equal to (0,"Capital Plan 2005 - 2009",1,null_value,3,"200504") was found.
Removed 0 rows```
|
1.0
|
Throw error when primary key is wrong in `rm-row` - When running `rm-row` we should inform the user that they have an error in their primary key. When the key is wrong:
```[oscarbatori:mta(master)] >> dolt table rm-row capital_dashboard_agencies project_number,project_number,plan_revision 'D501CB08','Capital Plan 2005 - 2009',"200504"
No row with pk equal to (0,"Capital Plan 2005 - 2009",1,null_value,3,"200504") was found.
Removed 0 rows```
|
non_design
|
throw error when primary key is wrong in rm row when running rm row we should inform the user that they have an error in their primary key when the key is wrong dolt table rm row capital dashboard agencies project number project number plan revision capital plan no row with pk equal to capital plan null value was found removed rows
| 0
|
153,747
| 24,183,319,799
|
IssuesEvent
|
2022-09-23 10:59:11
|
nextcloud/contacts
|
https://api.github.com/repos/nextcloud/contacts
|
opened
|
List header in left sidebar are not allowed with list content
|
bug design feature: contacts design review
|
### Describe the bug
The title/header of a list should have the same left margin as the text on the list items themselves.
**Example:** The string "Groups" should be horizontally aligned with the group name "my group".
### Steps to reproduce
1. Open the Contacts app.
2. Create a group.
3. Observe the group list and its header.
### Expected behavior
The group names and the header should be aligned horizontally.
### Actual behavior
The group names and their header are not aligned.
### Contact version
main
### Operating system
_No response_
### PHP engine version
_No response_
### Web server
_No response_
### Database
_No response_
### Additional info
_No response_
|
2.0
|
List header in left sidebar are not allowed with list content - ### Describe the bug
The title/header of a list should have the same left margin as the text on the list items themselves.
**Example:** The string "Groups" should be horizontally aligned with the group name "my group".
### Steps to reproduce
1. Open the Contacts app.
2. Create a group.
3. Observe the group list and its header.
### Expected behavior
The group names and the header should be aligned horizontally.
### Actual behavior
The group names and their header are not aligned.
### Contact version
main
### Operating system
_No response_
### PHP engine version
_No response_
### Web server
_No response_
### Database
_No response_
### Additional info
_No response_
|
design
|
list header in left sidebar are not allowed with list content describe the bug the title header of a list should have the same left margin as the text on the list items themselves example the string groups should be horizontally aligned with the group name my group steps to reproduce open the contacts app create a group observe the group list and its header expected behavior the group names and the header should be aligned horizontally actual behavior the group names and their header are not aligned contact version main operating system no response php engine version no response web server no response database no response additional info no response
| 1
|
508,037
| 14,688,816,632
|
IssuesEvent
|
2021-01-02 05:28:33
|
r2dliu/dolphin
|
https://api.github.com/repos/r2dliu/dolphin
|
closed
|
Refactor SlippiGame.h and .cpp
|
Low Priority wontfix
|
C++17 supports std::byte, which should be used wherever possible for clarity and safety.
std::filesystem::path and std::filesystem::u8path should be used instead of strings and wstrings.
Some branching logic will be required because std::filesystem::path does not support utf8 characters by default until c++20.
|
1.0
|
Refactor SlippiGame.h and .cpp - C++17 supports std::byte, which should be used wherever possible for clarity and safety.
std::filesystem::path and std::filesystem::u8path should be used instead of strings and wstrings.
Some branching logic will be required because std::filesystem::path does not support utf8 characters by default until c++20.
|
non_design
|
refactor slippigame h and cpp c supports std byte which should be used wherever possible for clarity and safety std filesystem path and std filesystem should be used instead of strings and wstrings some branching logic will be required because std filesystem path does not support characters by default until c
| 0
|
84,846
| 10,568,292,263
|
IssuesEvent
|
2019-10-06 11:58:56
|
Raw-Machine-Games/vile-four
|
https://api.github.com/repos/Raw-Machine-Games/vile-four
|
closed
|
Learn Inkscape
|
Design Education
|
Learn basics of Inkscape - how to use basic operations, primitives, create easy sketches and so on.
|
1.0
|
Learn Inkscape - Learn basics of Inkscape - how to use basic operations, primitives, create easy sketches and so on.
|
design
|
learn inkscape learn basics of inkscape how to use basic operations primitives create easy sketches and so on
| 1
|
372,211
| 11,010,944,342
|
IssuesEvent
|
2019-12-04 15:27:32
|
mozilla-iam/mozilla-aws-cli
|
https://api.github.com/repos/mozilla-iam/mozilla-aws-cli
|
closed
|
STS AssumeRoleWithWebIdentity call doesn't check the response from AWS for ExpiredTokenException
|
Priority: high Type: bug
|
It looks like AWS doesn't always respect the `exp` expiration in the ID Token and will sometimes respond with `ExpiredTokenException` early. I've opened a support case to find out why this is.
We should check for this though and act gracefully and fetch a new ID token
```
<ErrorResponse xmlns="https://sts.amazonaws.com/doc/2011-06-15/">
<Error>
<Type>Sender</Type>
<Code>ExpiredTokenException</Code>
<Message>Token too old: 441398</Message>
</Error>
<RequestId>1fd1964b-1544-11ea-ba37-99c3c1dede42</RequestId>
</ErrorResponse>
```
This also causes the hang described in #100
|
1.0
|
STS AssumeRoleWithWebIdentity call doesn't check the response from AWS for ExpiredTokenException - It looks like AWS doesn't always respect the `exp` expiration in the ID Token and will sometimes respond with `ExpiredTokenException` early. I've opened a support case to find out why this is.
We should check for this though and act gracefully and fetch a new ID token
```
<ErrorResponse xmlns="https://sts.amazonaws.com/doc/2011-06-15/">
<Error>
<Type>Sender</Type>
<Code>ExpiredTokenException</Code>
<Message>Token too old: 441398</Message>
</Error>
<RequestId>1fd1964b-1544-11ea-ba37-99c3c1dede42</RequestId>
</ErrorResponse>
```
This also causes the hang described in #100
|
non_design
|
sts assumerolewithwebidentity call doesn t check the response from aws for expiredtokenexception it looks like aws doesn t always respect the exp expiration in the id token and will sometimes respond with expiredtokenexception early i ve opened a support case to find out why this is we should check for this though and act gracefully and fetch a new id token errorresponse xmlns sender expiredtokenexception token too old this also causes the hang described in
| 0
|
151,613
| 23,848,580,258
|
IssuesEvent
|
2022-09-06 15:49:13
|
wellcomecollection/wellcomecollection.org
|
https://api.github.com/repos/wellcomecollection/wellcomecollection.org
|
opened
|
Explore alternatives to the current image gallery design for stories
|
needs: design epic: stories optimisation
|
The current image gallery component works pretty well when embedded in a larger page (e.g. an exhibition), but isn't ideal for a standalone story.
We should explore alternative designs.
|
1.0
|
Explore alternatives to the current image gallery design for stories - The current image gallery component works pretty well when embedded in a larger page (e.g. an exhibition), but isn't ideal for a standalone story.
We should explore alternative designs.
|
design
|
explore alternatives to the current image gallery design for stories the current image gallery component works pretty well when embedded in a larger page e g an exhibition but isn t ideal for a standalone story we should explore alternative designs
| 1
|
477,462
| 13,762,871,656
|
IssuesEvent
|
2020-10-07 09:43:55
|
AY2021S1-CS2103T-T13-1/tp
|
https://api.github.com/repos/AY2021S1-CS2103T-T13-1/tp
|
closed
|
Implement Delete Visits by date Command
|
Implementation priority.High
|
This command allows to delete the visits with dates that are before or equals the date of input. example of command:
deleteVisits d/2020-09-12
|
1.0
|
Implement Delete Visits by date Command - This command allows to delete the visits with dates that are before or equals the date of input. example of command:
deleteVisits d/2020-09-12
|
non_design
|
implement delete visits by date command this command allows to delete the visits with dates that are before or equals the date of input example of command deletevisits d
| 0
|
101,369
| 12,678,718,850
|
IssuesEvent
|
2020-06-19 10:17:32
|
PostHog/posthog.com
|
https://api.github.com/repos/PostHog/posthog.com
|
closed
|
Social media and readme design
|
design
|
# Context
We are currently reworking our branding. Three main areas (1) website, requires web designer to be hired (2) blog headers (3) social media presence.
The reason for prioritizing (3) is that we can get started now ahead of a web designer joining us to work through the website, which will become the next task. We could move onto (2) with a tiny bit of help from our own engineering team. (1) is bottlenecked.
# Social media
- [ ] [Twitter](https://twitter.com/PostHogHQ) is an easy one to start, and generates quite a lot of traffic. Could also go in as our personal account backgrounds too.
- [ ] LinkedIn Header background. This will go on the [main company page](https://www.linkedin.com/company/posthog/). Could also go in as our personal account backgrounds too.
We can make both of the above *identical* for right now to get the quickest benefit. We can, when we feel like it, make them each different and set up Facebook later.
The above all have very specific size guidelines so images fit appropriately.
# [Readme](https://github.com/PostHog/posthog)
This gets a ton of traffic and is very important to us.
It mustn't feel cluttered.
I'd suggest we use the new logo and have that centred at the top.
We could have a couple of tiny images partway through, but it needs to remain cool rather than cluttered.
- [ ] When you start this task, ping James and I'll set you up with a practise readme that is private for you to experiment with
# Blog post headers
- [ ] There is a technical task to enable a header above blog posts - one of our developers could do this very quickly
- [ ] We should get the $3M raise post header into production because that is still generating traffic
- [ ] We will do our next post next week, so we should pick a topic and get a header image in
- [ ] We should also create a "social media preview" image too that will work appropriately. Whenever a link is shared on Twitter / Slack / Facebook / wherever, you can tag a certain image as being the "preview image". We need to be able to produce that very quickly - ie just a smaller or cropped version of the main header.
|
1.0
|
Social media and readme design - # Context
We are currently reworking our branding. Three main areas (1) website, requires web designer to be hired (2) blog headers (3) social media presence.
The reason for prioritizing (3) is that we can get started now ahead of a web designer joining us to work through the website, which will become the next task. We could move onto (2) with a tiny bit of help from our own engineering team. (1) is bottlenecked.
# Social media
- [ ] [Twitter](https://twitter.com/PostHogHQ) is an easy one to start, and generates quite a lot of traffic. Could also go in as our personal account backgrounds too.
- [ ] LinkedIn Header background. This will go on the [main company page](https://www.linkedin.com/company/posthog/). Could also go in as our personal account backgrounds too.
We can make both of the above *identical* for right now to get the quickest benefit. We can, when we feel like it, make them each different and set up Facebook later.
The above all have very specific size guidelines so images fit appropriately.
# [Readme](https://github.com/PostHog/posthog)
This gets a ton of traffic and is very important to us.
It mustn't feel cluttered.
I'd suggest we use the new logo and have that centred at the top.
We could have a couple of tiny images partway through, but it needs to remain cool rather than cluttered.
- [ ] When you start this task, ping James and I'll set you up with a practise readme that is private for you to experiment with
# Blog post headers
- [ ] There is a technical task to enable a header above blog posts - one of our developers could do this very quickly
- [ ] We should get the $3M raise post header into production because that is still generating traffic
- [ ] We will do our next post next week, so we should pick a topic and get a header image in
- [ ] We should also create a "social media preview" image too that will work appropriately. Whenever a link is shared on Twitter / Slack / Facebook / wherever, you can tag a certain image as being the "preview image". We need to be able to produce that very quickly - ie just a smaller or cropped version of the main header.
|
design
|
social media and readme design context we are currently reworking our branding three main areas website requires web designer to be hired blog headers social media presence the reason for prioritizing is that we can get started now ahead of a web designer joining us to work through the website which will become the next task we could move onto with a tiny bit of help from our own engineering team is bottlenecked social media is an easy one to start and generates quite a lot of traffic could also go in as our personal account backgrounds too linkedin header background this will go on the could also go in as our personal account backgrounds too we can make both of the above identical for right now to get the quickest benefit we can when we feel like it make them each different and set up facebook later the above all have very specific size guidelines so images fit appropriately this gets a ton of traffic and is very important to us it mustn t feel cluttered i d suggest we use the new logo and have that centred at the top we could have a couple of tiny images partway through but it needs to remain cool rather than cluttered when you start this task ping james and i ll set you up with a practise readme that is private for you to experiment with blog post headers there is a technical task to enable a header above blog posts one of our developers could do this very quickly we should get the raise post header into production because that is still generating traffic we will do our next post next week so we should pick a topic and get a header image in we should also create a social media preview image too that will work appropriately whenever a link is shared on twitter slack facebook wherever you can tag a certain image as being the preview image we need to be able to produce that very quickly ie just a smaller or cropped version of the main header
| 1
|
93,966
| 11,838,517,610
|
IssuesEvent
|
2020-03-23 15:46:20
|
microsoft/msbuild
|
https://api.github.com/repos/microsoft/msbuild
|
opened
|
Microsoft.Common.tasks cleanup
|
Needs Design
|
`Microsoft.Common.tasks` has every built-in MSBuild task duplicated between sections, one of which is
https://github.com/microsoft/msbuild/blob/3453beee039fb6f5ccc54ac783ebeced31fec472/src/Tasks/Microsoft.Common.tasks#L9-L14
I don't think we need to have back compat with dev11 any more, and `$(AssemblyVersion)` should never be empty with MSBuild as built from this repo.
I'm not 100% sure of the impact of just deleting all the 4.0 references; that needs to be considered.
We _cannot_ delete the 3.5 references like
https://github.com/microsoft/msbuild/blob/3453beee039fb6f5ccc54ac783ebeced31fec472/src/Tasks/Microsoft.Common.tasks#L39
They're needed for asset compat on old projects. But they should be conditioned out on .NET Core, which they currently are not.
|
1.0
|
Microsoft.Common.tasks cleanup - `Microsoft.Common.tasks` has every built-in MSBuild task duplicated between sections, one of which is
https://github.com/microsoft/msbuild/blob/3453beee039fb6f5ccc54ac783ebeced31fec472/src/Tasks/Microsoft.Common.tasks#L9-L14
I don't think we need to have back compat with dev11 any more, and `$(AssemblyVersion)` should never be empty with MSBuild as built from this repo.
I'm not 100% sure of the impact of just deleting all the 4.0 references; that needs to be considered.
We _cannot_ delete the 3.5 references like
https://github.com/microsoft/msbuild/blob/3453beee039fb6f5ccc54ac783ebeced31fec472/src/Tasks/Microsoft.Common.tasks#L39
They're needed for asset compat on old projects. But they should be conditioned out on .NET Core, which they currently are not.
|
design
|
microsoft common tasks cleanup microsoft common tasks has every built in msbuild task duplicated between sections one of which is i don t think we need to have back compat with any more and assemblyversion should never be empty with msbuild as built from this repo i m not sure of the impact of just deleting all the references that needs to be considered we cannot delete the references like they re needed for asset compat on old projects but they should be conditioned out on net core which they currently are not
| 1
|
131,941
| 18,444,411,165
|
IssuesEvent
|
2021-10-14 22:44:16
|
microsoft/fast
|
https://api.github.com/repos/microsoft/fast
|
closed
|
Providing and resolving styles in FASTElement
|
closed:by-design improvement area:fast-element
|
**Describe the bug; what happened?**
If you provide styles in `customElement` as well as respond to `resolveStyles`, only the latter are applied without warning or error. Looking at the code it looks like it only tries to apply resolved styles if provided styles are null.
**What are the steps to reproduce the issue?**
```ts
import { FASTElement, customElement, css, html } from "@microsoft/fast-element";
const template = html<TestStyles>`<div class="abc">
<p>Hello</p>
</div>`;
const styles = css`
.abc {
background-color: green;
font-weight: bold;
}
`;
@customElement({
name: "test-styles",
template,
})
export class TestStyles extends FASTElement {
resolveStyles() {
return css`
:host {
background-color: blue;
}
`;
}
}
```
**What behavior did you expect?**
Well, at first I expected only the styles passed to `customElement` to apply because I was coming back to the code and forgot about the `resolvedStyles`. Once I realized I looked at the code to try to understand the intent in this scenario, and it seemed like styles provided at the element took priority.
It might be good if they were merged. I would liked to keep the bulk of the styles in the recommended way, and provide a few that require custom code in resolved. Maybe that's too hard to merge though, so maybe I could inject the provided styles into the resolved. At the very least a warning or error in the console would have helped me realize my mistake much quicker.
|
1.0
|
Providing and resolving styles in FASTElement - **Describe the bug; what happened?**
If you provide styles in `customElement` as well as respond to `resolveStyles`, only the latter are applied without warning or error. Looking at the code it looks like it only tries to apply resolved styles if provided styles are null.
**What are the steps to reproduce the issue?**
```ts
import { FASTElement, customElement, css, html } from "@microsoft/fast-element";
const template = html<TestStyles>`<div class="abc">
<p>Hello</p>
</div>`;
const styles = css`
.abc {
background-color: green;
font-weight: bold;
}
`;
@customElement({
name: "test-styles",
template,
})
export class TestStyles extends FASTElement {
resolveStyles() {
return css`
:host {
background-color: blue;
}
`;
}
}
```
**What behavior did you expect?**
Well, at first I expected only the styles passed to `customElement` to apply because I was coming back to the code and forgot about the `resolvedStyles`. Once I realized I looked at the code to try to understand the intent in this scenario, and it seemed like styles provided at the element took priority.
It might be good if they were merged. I would liked to keep the bulk of the styles in the recommended way, and provide a few that require custom code in resolved. Maybe that's too hard to merge though, so maybe I could inject the provided styles into the resolved. At the very least a warning or error in the console would have helped me realize my mistake much quicker.
|
design
|
providing and resolving styles in fastelement describe the bug what happened if you provide styles in customelement as well as respond to resolvestyles only the latter are applied without warning or error looking at the code it looks like it only tries to apply resolved styles if provided styles are null what are the steps to reproduce the issue ts import fastelement customelement css html from microsoft fast element const template html hello const styles css abc background color green font weight bold customelement name test styles template export class teststyles extends fastelement resolvestyles return css host background color blue what behavior did you expect well at first i expected only the styles passed to customelement to apply because i was coming back to the code and forgot about the resolvedstyles once i realized i looked at the code to try to understand the intent in this scenario and it seemed like styles provided at the element took priority it might be good if they were merged i would liked to keep the bulk of the styles in the recommended way and provide a few that require custom code in resolved maybe that s too hard to merge though so maybe i could inject the provided styles into the resolved at the very least a warning or error in the console would have helped me realize my mistake much quicker
| 1
|
71,497
| 13,669,105,405
|
IssuesEvent
|
2020-09-29 00:57:50
|
phetsims/collision-lab
|
https://api.github.com/repos/phetsims/collision-lab
|
closed
|
Code Review
|
dev:code-review
|
Collision lab is ready for code review.
# PhET Code-Review Checklist (a.k.a "CRC")
* Mark failed items with ❌
* Call attention to items with ⚠️
* Mark items that are not applicable with "N/A"
## GitHub Issues
The following standard GitHub issues should exist. If any of these issues is missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.
GitHub issues should exist that document:
- [ ] results of memory testing for `brands=phet` (#147)
- [ ] performance testing and sign-off (#157)
- [ ] (#142) review of pointer areas
- [ ] credits (will not be completed until after RC testing) (#145)
## **Build and Run Checks**
If any of these items fail, pause code review.
- [x] Does the sim build without warnings or errors?
- [x] Does the html file size seem reasonable, compared to other similar sims?
- [x] Does the sim start up? (unbuilt and built versions)
- [x] Does the sim experience any assertion failures? (run with query parameter `ea`)
- [x] Does the sim pass a scenery fuzz test? (run with query parameters `fuzz&ea`)
- [x] Does the sim behave correctly when listener order is shuffled? (run with query parameters `ea&shuffleListeners` and `ea&shuffleListeners&fuzz`)
- [x] Does the sim use `Map`? If so, make sure that it still works well in IE11 as not all `Map` functions are supported there.
- [x] Does the sim output any deprecation warnings? Run with `?deprecationWarnings`. Do not use deprecated methods in new code.
## **Memory Leaks**
- [x] Does a heap comparison using Chrome Developer Tools indicate a memory leak? (Describing this process is beyond the scope of this document.) Test on a version built using `grunt --minify.mangle=false`. Compare to testing results done by the responsible developer.
- [x] For each common-code component (sun, scenery-phet, vegas, …) that opaquely registers observers or listeners, is
there a call to that component’s `dispose` function, or is it obvious why it isn't necessary, or is there documentation
about why `dispose` isn't called? An example of why no call to `dispose` is needed is if the component is used in
a `ScreenView` that would never be removed from the scene graph.
- [x] Are there leaks due to registering observers or listeners? The following guidelines should be followed unless
there it is obviously no need to unlink, or documentation (in-line or in the implementation nodes)added about why
following them is not necessary. Unlink is not needed for Properties contained in classes that are never disposed of,
such as primary model and view classes that exist for the duration of the sim.
- [x] AXON: `Property.link` is accompanied by `Property.unlink`.
- [x] AXON: Creation of `DerivedProperty` is accompanied by `dispose`.
- [x] AXON: Creation of `Multilink` is accompanied by `dispose`.
- [x] AXON: Creation of `Emitter` is accompanied by `dispose`, and/or `Emitter.addListener` is accompanied by `Emitter.removeListener`.
- [x] TANDEM: PhET-iO instrumented `PhetioObject` instances should be disposed.
- [x] Do all types that require a `dispose` function have one? This should expose a public `dispose` function that calls `this.disposeMyType()`, where `disposeMyType` is a private function declared in the constructor. `MyType` should exactly match the filename.
## **Performance**
- [x] Play with sim, identify any obvious performance issues. Examples: animation that slows down with large numbers of objects; animation that pauses or "hitches" during garbage collection.
- [x] If the sim uses WebGL, does it have a fallback? Does the fallback perform reasonably well? (run with query parameter `webgl=false`)
## **Usability**
- [x] Are UI components sufficiently responsive? (especially continuous UI components, such as sliders)
- [x] Are pointer areas optimized, especially for touch? (run with query parameter `showPointerAreas`)
- [x] Do pointer areas overlap? (run with query parameter `showPointerAreas`) Overlap may be OK in some cases, depending on the z-ordering (if the front-most object is supposed to occlude pointer areas) and whether objects can be moved.
## **Internationalization**
- [x] Are there any strings that are not internationalized, and does the sim layout gracefully handle internationalized strings that are shorter than the English strings? (run with query parameter `stringTest=X`. You should see nothing but 'X' strings.)
- [x] Does the sim layout gracefully handle internationalized strings that are longer than the English strings? (run with query parameters `stringTest=double` and `stringTest=long`)
- [x] Does the sim stay on the sim page (doesn't redirect to an external page) when running with the query parameter
`stringTest=xss`? This test passes if sim does not redirect, OK if sim crashes or fails to fully start. Only test on one
desktop platform. For PhET-iO sims, additionally test `?stringTest=xss` in Studio to make sure i18n strings didn't leak
to phetioDocumentation, see https://github.com/phetsims/phet-io/issues/1377
- [x] Avoid using concatenation to create strings that will be visible in the user interface. Use `StringUtils.fillIn` and a string pattern to ensure that strings are properly localized.
- [x] Use named placeholders (e.g. `"{{value}} {{units}}"`) instead of numbered placeholders (e.g. `"{0} {1}"`).
- [x] Make sure the string keys are all perfect, because they are difficult to change after 1.0.0 is published. Guidelines for string keys are:
(1) Strings keys should generally match their values. E.g.:
```js
"helloWorld": {
value: "Hello World!"
},
"quadraticTerms": {
value: "Quadratic Terms"
}
```
(2) If a string key would be exceptionally long, use a key name that is an abbreviated form of the string value, or that captures the purpose/essence of the value. E.g.:
```js
// key is abbreviated
"iWentToTheStore": {
value: "I went to the store to get milk, eggs, butter, and sugar."
},
// key is based on purpose
"describeTheScreen": {
value: "The Play Area is a small room. The Control Panel has buttons, a checkbox, and radio buttons to change conditions in the room."
}
```
(3) If string key names would collide, use your judgment to disambiguate. E.g.:
```js
"simplifyTitle": {
value: "Simplify!"
},
"simplifyCheckbox": {
value: "simplify"
}
```
(4) String keys for screen names should have the general form `"screen.{{screenName}}"`. E.g.:
```js
"screen.explore": {
"value": "Explore"
},
```
(5) String patterns that contain placeholders (e.g. `"My name is {{first}} {{last}}"`) should use keys that are unlikely to conflict with strings that might be needed in the future. For example, for `"{{price}}"` consider using key `"pricePattern"` instead of `"price"`, if you think there might be a future need for a `"price"` string.
- [x] If the sim was already released, make sure none of the original string keys have changed. If they have changed, make sure any changes have a good reason and have been discussed with @jbphet.
## **Repository Structure**
- [x] The repository name should correspond to the sim title. For example, if the sim title is "Wave Interference", then the repository name should be "wave-interference".
- [x] Are all required files and directories present?
For a sim repository named “my-repo”, the general structure should look like this (where assets/, images/, mipmaps/ or sounds/ may be omitted if the sim doesn’t have those types of resource files).
```js
my-repo/
assets/
doc/
images/
*see annotation
model.md
implementation-notes.md
images/
license.json
js/
(see section below)
mipmaps/
license.json
sound/
license.json
dependencies.json
.gitignore
my-repo_en.html
my-repo-strings_en.json
Gruntfile.js
LICENSE
package.json
README.md
```
*Any images used in model.md or implementation-notes.md should be added here. Images specific to aiding with documentation do not need their own license.
- [x] Verify that the same image file is not present in both images/ and mipmaps/. If you need a mipmap, use it for all occurrences of the image.
- [x] Is the js/ directory properly structured?
All JavaScript source should be in the js/ directory. There should be a subdirectory for each screen (this also applies for single-screen sims, where the subdirectory matches the repo name). For a multi-screen sim, code shared by 2 or more screens should be in a js/common/ subdirectory. Model and view code should be in model/ and view/ subdirectories for each screen and common/. For example, for a sim with screens “Introduction” and “Lab”, the general directory structure should look like this:
```js
my-repo/
js/
common/
model/
view/
introduction/
model/
view/
lab/
model/
view/
my-repo-config.js
my-repo-main.js
myRepo.js
```
- [x] Do filenames use an appropriate prefix? Some filenames may be prefixed with the repository name, e.g. `MolarityConstants.js` in molarity. If the repository name is long, the developer may choose to abbreviate the repository name, e.g. `EEConstants.js` in expression-exchange. If the abbreviation is already used by another respository, then the full name must be used. For example, if the "EE" abbreviation is already used by expression-exchange, then it should not be used in equality-explorer. Whichever convention is used, it should be used consistently within a repository - don't mix abbreviations and full names.
- [x] Is there a file in assets/ for every resource file in sound/ and images/? Note that there is *not necessarily* a 1:1 correspondence between asset and resource files; for example, several related images may be in the same .ai file. Check license.json for possible documentation of why some reesources might not have a corresponding asset file.
- [x] Was the README.md generated by `grunt published-README` or `grunt unpublished-README`?
- [x] Does package.json refer to any dependencies that are not used by the sim?
- [x] Is the LICENSE file correct? (Generally GPL v3 for sims and MIT for common code, see [this thread](https://github.com/phetsims/tasks/issues/875#issuecomment-312168646) for additional information).
- [x] Does .gitignore match the one in simula-rasa?
- [x] In GitHub, verify that all non-release branches have an associated issue that describes their purpose.
- [x] Are there any GitHub branches that are no longer needed and should be deleted?
- [x] Does `model.md` adequately describe the model, in terms appropriate for teachers?
- [x] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers?
- [x] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used). Query parameters that are public-facing should be identified using `public: true` in the schema.
## **Coding Conventions**
This section deals with PhET coding conventions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] Is the code formatted according to PhET conventions? See [phet-idea-code-style.xml](https://github.com/phetsims/phet-info/blob/master/ide/idea/phet-idea-codestyle.xml) for IntelliJ IDEA code style.
- [x] Names (types, variables, properties, Properties, functions,...) should be sufficiently descriptive and specific, and should avoid non-standard abbreviations. For example:
```js
const numPart = 100; // incorrect
const numberOfParticles = 100; // correct
const width = 150; // incorrect
const beakerWidth = 150; // correct
```
- [x] Verify that [Best Practices for Modules](https://github.com/phetsims/phet-info/blob/master/doc/best-practices-for-modules.md) are followed.
- [x] For constructors, use parameters for things that don’t have a default. Use options for things that have a default value. This improves readability at the call site, especially when the number of parameters is large. It also eliminates order dependency that is required by using parameters.
For example, this constructor uses parameters for everything. At the call site, the semantics of the arguments are difficult to determine without consulting the constructor.
```js
class BallNode extends Node {
/**
* @param {Ball} ball - model element
* @param {Property.<boolean>} visibleProperty - is the ball visible?
* @param {Color|string} fill - fill color
* @param {Color|string} stroke - stroke color
* @param {number} lineWidth - width of the stroke
*/
constructor( ball, visibleProperty, fill, stroke, lineWidth ){
// ...
}
}
// Call site
const ballNode = new BallNode( ball, visibleProperty, 'blue', 'black', 2 );
```
Here’s the same constructor with an appropriate use of options. The call site is easier to read, and the order of options is flexible.
```js
class BallNode extends Node {
/**
* @param {Ball} ball - model element
* @param {Property.<boolean>} visibleProperty - is the ball visible?
* @param {Object} [options]
*/
constructor( ball, visibleProperty, options ) {
options = merge( {
fill: 'white', // {Color|string} fill color
stroke: 'black', // {Color|string} stroke color
lineWidth: 1 // {number} width of the stroke
}, options );
// ...
}
}
// Call site
const ballNode = new BallNode( ball, visibleProperty, {
fill: 'blue',
stroke: 'black',
lineWidth: 2
} );
```
- [x] When options are passed through one constructor to another, a "nested options" pattern should be used. This helps to avoid duplicating option names and/or accidentally overwriting options for different components that use the same option names. Make sure to use PHET_CORE/merge instead of `_.extend` or `_.merge`. `merge` will automatically recurse to keys named `*Options` and extend those as well.
Example:
```js
class ParticleBoxNode extends Node {
/**
* @param {ParticleBox} particleBox - model element
* @param {Property.<boolean>} visibleProperty - are the box and its contents visible?
* @param {Object} [options]
*/
constructor( particleBox, visibleProperty, options ) {
options = merge( {
fill: 'white', // {Color|string} fill color
stroke: 'black', // {Color|string} stroke color
lineWidth: 1, // {number} width of the stroke
particleNodeOptions: {
fill: 'red',
stroke: 'gray',
lineWidth: 0.5
},
}, options );
// add particle
this.addChild( new ParticleNode( particleBox.particle, options.particleNodeOptions ) );
...
}
}
```
A possible exception to this guideline is when the constructor API is improved by hiding the implementation details, i.e. not revealing that a sub-component exists. In that case, it may make sense to use new top-level options. This is left to developer and reviewer discretion.
For more information on the history and thought process around the "nested options" pattern, please see https://github.com/phetsims/tasks/issues/730.
- [x] If references are needed to the enclosing object, such as for a closure, `self` should be defined, but it should only be used in closures. The `self` variable should not be defined unless it is needed in a closure. Example:
```js
const self = this;
someProperty.link( function(){
self.doSomething();
} );
this.doSomethingElse();
```
- [x] Generally, lines should not exceed 120 columns. Break up long statements, expressions, or comments into multiple
lines to optimize readability. It is OK for require statements or other structured patterns to exceed 120 columns.
Use your judgment!
- [x] Use `class` and `extends` for defining classes and implementing inheritance. `PHET_CORE/inherit` was a pre-ES6 implementation of inheritance that is specific to PhET and has been supplanted by `class` and `extends`. `inherit` should
not be used in new code.
- [x] Functions should be invoked using the dot operator rather than the bracket operator. For more details, please see https://github.com/phetsims/gravity-and-orbits/issues/9. For example:
```js
// avoid
this[ isFaceSmile ? 'smile' : 'frown' ]();
// OK
isFaceSmile ? this.smile() : this.frown();
// OK
if ( isFaceSmile ) {
this.smile();
}
else {
this.frown();
}
```
- [x] It is not uncommon to use conditional shorthand and short circuiting for invocation. Use parentheses to maximize readability.
```js
( expression ) && statement;
( expression ) ? statement1 : statement2;
( foo && bar ) ? fooBar() : fooCat();
( foo && bar ) && fooBar();
( foo && !(bar && fooBar)) && nowIAmConfused();
this.fill = ( foo && bar ) ? 'red' : 'blue';
```
If the expression is only one item, the parentheses can be omitted. This is the most common use case.
```js
assert && assert( happy, 'Why aren\'t you happy?' );
happy && smile();
const thoughts = happy ? 'I am happy' : 'I am not happy :(';
```
- [x] Naming for Property values: All `AXON/Property` instances should be declared with the suffix `Property`. For example, if a visible property is added, it should have the name `visibleProperty` instead of simply `visible`. This will help to avoid confusion with non-Property definitions.
- [x] Properties should use type-specific subclasses where appropriate (.e.g BooleanProperty, NumberProperty, StringProperty) or provide documentation as to why they are not.
- [x] Are `Validator` validation options (`valueType`, `validValues`, etc...) utilized? These are supported in a number of core types like `Emitter` and `Property`. Is their presence or lack thereof properly documented?
- [x] Files should be named like `CapitalizedCamelCasing.js` when returning a constructor, or `lowerCaseCamelCasing.js` when returning a non-constructor function or singleton. When returning a constructor or singleton, the constructor name should match the filename.
- [x] Assertions should be used appropriately and consistently. Type checking should not just be done in code comments. Use `Array.isArray` to type check an array.
- [x] If you need to namespace an inner class, use `{{namespace}}.register`, and include a comment about why the inner class needs to be namespaced. Use the form `'{{outerClassname}}.{{innerClassname}}'` for the key. For example:
```js
import myNamespace from '...';
class SlotMachineNode extends Node {
constructor( ... ) {
this.leverNode = new LeverNode(...);
...
}
...
}
myNamespace.register( 'SlotMachineNode', SlotMachineNode );
class LeverNode extends Node {
...
}
// It was useful to be able to instantiate this in the console for testing, and we may need to do so in the future.
myNamespace.register( 'SlotMachineNode.LeverNode', LeverNode );
return SlotMachineNode;
```
- [x] Putting unused parameters in callbacks is up to developer discretion, as long they are correct wrt to the actual callback signature.
For example, both of these are acceptable:
```js
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active, color ) => {
// some algorithm that uses style and active
} );
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active ) => {
// some algorithm that uses style and active
} );
```
This is not acceptable, because the 3rd parameter is incorrect.
```js
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active, lineWidth ) => {
// some algorithm that uses style and active
} );
```
### Documentation
This section deals with PhET documention conventions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] All classes, methods and properties are documented.
- [x] Documentation at the top of .js files should provide an overview of purpose, responsibilies, and (where useful) examples of API use. If the file contains a subclass definition, it should indicate what functionality it adds to the superclass.
- [x] The HTML5/CSS3/JavaScript source code must be reasonably well documented. This is difficult to specify precisely, but the idea is that someone who is moderately experienced with HTML5/CSS3/JavaScript can quickly understand the general function of the source code as well as the overall flow of the code by reading through the comments. For an example of the type of documentation that is required, please see the example-sim repository.
- [x] Differentiate between `Property` and "property" in comments. They are different things. `Property` is a type in AXON; property is any value associated with a JavaScript object. Often "field" can be used in exchange for "property" which can help with clarity.
- [x] Classes that mix in traits or mixin should use the `@mixes MyType` annotation.
- [x] Line comments should generally be preceded by a blank line. For example:
```js
// Randomly choose an existing crystal to possibly bond to
const crystal = this.crystals.get( _.random( this.crystals.length - 1 ) );
// Find a good configuration to have the particles move toward
const targetConfiguration = this.getTargetConfiguration( crystal );
```
- [x] When documenting conditionals (if/else statements), follow these guidlines:
1. Comments above the first `if` in a conditional should be about the entire conditional, not just the if block.
2. Comments should not break up sections of the conditional.
3. If a comment is needed to describe a single block of the conditional, then add that comment just inside the block (no space between the `if`/`else if`/`else` and the comment), with a space below it as to not be confused with a comment about logic below.
```js
// Comment about the reason to split on peppers were pickled.
if( peterPiperPickedAJarOfPickledPeppers ){
// if we want to explain what this `if` statement is about
peterAlsoHasBrine();
}
else {
// documentation about why we have no peppers. This is about the next line of code, and not the "else as a whole block."
peterHasNoPeppers();
}
```
- [x] Line comments should have whitespace between the `//` and the first letter of the line comment. See the preceding example.
- [x] Do the `@author` annotations seem correct?
- [x] ES5 (`inherit`) constructors should be annotated with `@constructor`. ES6 (`class`) constructors should _not_ be annotated with `@constructor`.
- [x] Constructor and function documentation. Parameter types and names should be clearly specified for each constructor and function using `@param` annotations. The description for each parameter should follow a hyphen. Primitive types should use lower case. For example:
```js
/**
* The PhetDeveloper is responsible for creating code for simulations and documenting their code thoroughly.
*/
class PhetDeveloper {
/**
* @param {string} name - full name
* @param {number} age - age, in years
* @param {boolean} isEmployee - whether this developer is an employee of CU
* @param {function} callback - called immediate after coffee is consumed
* @param {Property.<number>} hoursProperty - cumulative hours worked
* @param {string[]} friendNames - names of friends
* @param {Object} [options]
*/
constructor( name, age, isEmployee, callback, hoursProperty, friendNames, options ) {
...
}
...
}
```
- [x] For most functions, the same form as above should be used, with a `@returns` annotation which identifies the return type and the meaning of the returned value. Functions should also document any side effects. For extremely simple functions that are just a few lines of simple code, an abbreviated line-comment can be used, for example: `// Computes {Number} distance based on {Foo} foo.`
- [x] Abstract methods (normally implemented with an error) should be marked with `@abstract` jsdoc.
#### Type Expressions
This section deals with PhET conventions for type expressions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] Type expressions should conform approximately to [Google Closure Compiler](https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler) syntax. PhET stretches the syntax in many cases (beyond the scope of this document to describe).
- [x] Prefer the most basic/restrictive type expression when defining APIs. For example, if a client only needs to know that a parameter is `{Node}`, don’t describe the parameter as `{Rectangle}`.
- [x] All method parameters should have type expressions. For example `@param {number} width`.
- [x] In sim-specific code, options and fields should have type expressions when their type is not obvious from the context. “Obvious” typically means that the value type is clearly shown in the righthand-side of the definition. E.g. `const width = 42` clear shows that `width` is `{number}`. E.g. `const checkbox = new Checkbox(…)` clearly shows that `checkbox` is `{Checkbox}`. If the type is obvious from the context, the developer may still provide a type expression at his/her discretion. Examples:
```js
// @public {GameState} the current state of the game
this.gameState = this.computeGameState();
// @public (read-only) the width of the container
this.containerWidth = 150;
// @private the checkbox used to show particles
this.particlesVisibleCheckbox = new Checkbox(...);
```
- [x] In common code repositories all options and fields should have type expressions, regardless of their visibility, and regardless whether their type is obvious from the context. If the same examples from above appeared in common code:
```js
// @public {GameState} the current state of the game
this.gameState = this.computeGameState();
// @public (read-only) {number} the width of the container
this.containerWidth = 150;
// @private {Checkbox} the checkbox used to show particles
this.particlesVisibleCheckbox = new Checkbox(...);
```
- [x] Type expressions for Enumeration values should be annotated as instances of that Enumeration, see examples in https://github.com/phetsims/phet-core/blob/master/js/Enumeration.js for more.
```js
/**
* @param {LeftOrRight} - whichHand
*/
function getHand( whichHand ){
if( whichHand === LeftOrRight.LEFT ){
return new LeftHand();
}
else if( whichHand === LeftOrRight.RIGHT ){
return new RightHand();
}
}
```
- [x] Type expressions for functions have a variety of possibilities, increasing in complexity depending on the case. In general note that `{function}` is not enough information. Here are some better options:
1. The most basic option it to use Google Closure Type syntax, for more info see https://github.com/google/closure-compiler/wiki/Types-in-the-Closure-Type-System. This specifies the param/return types, but nothing more. Here are some examples:
* `@param {function()} noParamsAndNoReturnValue`
* `@param {function(number)} giveMeNumberAndReturnNothing`
* `@param {function(number, number):Vector2} getVector2`
* `@param {function(new:Node)} createNode - a function that takes the Node constructor`
2. When needing to be a bit more specific, add a name to parameters of the function. Sometimes this is all that is needed for clarity on what the param does:
* `@param {function(model:MyModel, length:number, name:string): Node} getLengthNode`
* `@param {function(aSelfExplanatoryNameForAString:string): Node} getStringNode`
3. If (2) isn't enough, use English to explain the parameters and return values. This is easy because they are named, and can be easily mentioned:
* `@param {function(model:MyModel, length:number, name:string): Node} getLengthNode - returns the length Node that you have always wanted, name is the name of the source of your aspirations, length is a special number according to the following 24 criteria. . .`
4. If needing more complexity, or using jsdoc rendering tools (like PhET-iO documentation does), you must use a JSDoc compatible format, not (2) or (3), and you may need to use the more complicated solution. See JSDoc docs for more info. Here is an example of a named callback:
```js
/**
* @name mySpecialCallback
* Converts a string to a number
* @param {string}
* @returns {number}
*/
/**
* @param {mySpecialCallback} callback
*/
x = function( callback) { callback( 'still chocolate' ) };
```
- [x] Type expressions for anonymous Objects have a variety of possibilities, increasing in complexity depending on the case.
1. When the documentation is close by, then {Object} is still acceptable. This mainly applies to options and similar patterns:
* `@param {Object} [options] // this is great because of the extend call 5 lines down`
2. When using an `Object` with specific properties, name them and their types like so:
* `@param {name:string, address:{street:string}, returnNode:function(number):Node, [shoeSize:number]} personalData // note that shoeSize is optional here`
3. When you need a bit more explanation, keep the same type expression as (2), but feel free to outline specifics in English after the param name.
```
@ param {name:string, address:{street:string}, returnNode:function(number):Node, [shoeSize:number]} personalData - use english after to explain pieces of this
(if needed, outline properties on their own lines)
name is something
address is something else
returnNode does this thing
```
4. Not all objects have named keys like (2) and (3). Here is how to document dictionary-like `Object`s, where each key is some type, and the value is another type. For key value pairs use this:
* `{Object.<string, number>}` Where keys are strings, and values are numbers.
* `{Object.<phetioID:string, count:number>}` - naming each of these can help identify them too. Feel free to explain in English after the type expression if needed.
5. If things are too complicated for the above cases, use a `*Def.js` file (especially is used in more than one file), or a `@typedef` declaration right above the jsdoc that uses the typedef.
- [x] Look for cases where the use of type expressions involving Property subclasses are incorrect. Because of the structure of the `Property` class hierarchy, specifying type-specific Properties (`{BooleanProperty}`, `{NumberProperty}`,...) may be incorrect, because it precludes values of type `{DerivedProperty}` and `{DynamicProperty}`. Similarly, use of `{DerivedProperty}` and `{DynamicProperty}` precludes values of (e.g.) `{BooleanProperty}`. Especially in common code, using `{Property,<TYPE>}` is typically correct, unless some specific feature of the `Property` subclass is required. For example, `{Property.<boolean>}` instead of `{BooleanProperty}`.
#### Visibility Annotations
This section deals with PhET conventions for visibility annotations. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
Because JavaScript lacks visibility modifiers (public, protected, private), PhET uses JSdoc visibility annotations to document the intent of the programmer, and define the public API. Visibility annotations are required for anything that JavaScript makes public. Information about these annotations can be found here. (Note that other documentation systems like the Google Closure Compiler use slightly different syntax in some cases. Where there are differences, JSDoc is authoritative. For example, use `Array.<Object>` or `Object[]` instead of `Array<Object>`). PhET guidelines for visibility annotations are as follows:
- [x] Use `@public` for anything that is intended to be part of the public API.
- [x] Use `@protected` for anything that is intended for use by subtypes.
- [x] Use `@private` for anything that is NOT intended to be part of the public or protected API.
- [x] Put qualifiers in parenthesis after the annotation, for example:
* To qualify that something is read-only, use `@public (read-only)`. This indicates that the given Property (AND its value) should not be changed by outside code (e.g. a Property should not have its value changed)
* To qualify that something is public to a specific repository, use (for example) `@public (scenery-internal)`
* For something made public solely for a11y, use `@public (a11y)`
* For something made public solely for phet-io, use `@public (phet-io)`
* Separate multiple qualifiers with commas. For example: `@public (scenery-internal, read-only)`
- [x] For JSDoc-style comments, the annotation should appear in context like this:
```js
/**
* Creates the icon for the "Energy" screen, a cartoonish bar graph.
* @returns {Node}
* @public
*/
```
- [x] For Line comments, the annotation can appear like this:
```js
// @public {function(listener:function)} - Adds a listener
addListener: function( listener ) { /*...*/ }
```
- [x] Verify that every JavaScript property and function has a visibility annotation. Here are some helpful regular expressions to search for these declarations as PhET uses them.
* Regex for property assignment like `x.y = something`: `[\w]+\.[\w]+\s=`
* Regex for function declarations: `[\w]+: function\(`
## **Math Libraries**
- [x] `DOT/Utils.toFixed` or `DOT/Utils.toFixedNumber` should be used instead of `toFixed`. JavaScript's `toFixed` is notoriously buggy. Behavior differs depending on browser, because the spec doesn't specify whether to round or floor.
## IE11
- [x] IE is no longer supported. With that in mind remove IE-specific workarounds
## **Organization, Readability, and Maintainability**
- [x] Does the organization and structure of the code make sense? Do the model and view contain types that you would expect (or guess!) by looking at the sim? Do the names of things correspond to the names that you see in the user interface?
- [x] Are appropriate design patterns used? See [phet-software-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md). If new or inappropriate patterns are identified, create an issue.
- [x] Is inheritance used where appropriate? Does the type hierarchy make sense?
- [x] Is composition favored over inheritance where appropriate? See https://en.wikipedia.org/wiki/Composition_over_inheritance.
- [x] Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions)
- [x] Is there too much unnecessary decoupling? (e.g. by passing all of the properties of an object independently instead of passing the object itself)?
- [x] Are the source files reasonable in size? Scrutinize large files with too many responsibilities - can responsibilities be broken into smaller delegates?
- [x] Are any significant chunks of code duplicated? This will be checked manually as well as with https://github.com/danielstjules/jsinspect or `grunt find-duplicates`
- [x] Is there anything that should be generalized and migrated to common code?
- [x] Are there any `TODO` or `FIXME` or `REVIEW` comments in the code? They should be addressed or promoted to GitHub issues.
- [x] Are there any [magic numbers](https://en.wikipedia.org/wiki/Magic_number_(programming)) that should be factored out as constants and documented?
- [x] Are there any constants that are duplicated in multiple files that should be factored out into a `{{REPO}}Constants.js` file?
- [x] Does the implementation rely on any specific constant values that are likely to change in the future? Identify constants that might be changed in the future. (Use your judgement about which constants are likely candidates.) Does changing the values of these constants break the sim? For example, see https://github.com/phetsims/plinko-probability/issues/84.
- [x] Is [PhetColorScheme](https://github.com/phetsims/scenery-phet/blob/master/js/PhetColorScheme.js) used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in `PhetColorScheme`. Identify any colors that might be worth adding to `PhetColorScheme`.
- [x] Are all dependent Properties modeled as `DerivedProperty` instead of `Property`?
- [x] All dynamics should be called from Sim.step(dt), do not use window.setTimeout or window.setInterval. This will help support Legends of Learning and PhET-iO.
## **Accessibility**
This section may be omitted if the sim has not been instrumented for a11y.
- [ ] Does the sim pass an accessibility fuzz test? (run with query parameters `fuzzBoard&ea`)
- [ ] Run the accessible HTML through an [HTML validator](https://validator.w3.org/nu/#textarea), does the HTML pass?
- [ ] Are accessibility features integrated well into the code. They should be added in a maintainable way, even if that requires upfront refactoring.
- [ ] Are accessible design patterns used, see [accessible-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/accessible-design-patterns.md)
- [ ] Does resetting the simulation also reset the entire PDOM?
- [ ] Is `Node.accessibleOrder` used appropriately to maintain visual and PDOM layout balance?
- [ ] Make sure accessibility strings aren't being adjusted with ascii specific javascript methods like `toUpperCase()`. Remember that one day these strings will be translatable
- [ ] Make sure for accessibility strings that all end of sentence periods do not have a leading space before it. Some screen readers will read these as "dot." This can occur often when a clause is conditionally added.
## **PhET-iO**
This section may be omitted if the sim has not been instrumented for PhET-iO.
- [ ] Does instrumentation follow the conventions described in [PhET-iO Instrumentation Guide](https://github.com/phetsims/phet-io/blob/master/doc/phet-io-instrumentation-guide.md)?
This could be an extensive bullet. At the very least, be sure to know what amount of instrumentation this sim
supports. Describing this further goes beyond the scope of this document.
- [ ] PhET-iO instantiates different objects and wires up listeners that are not present in the PhET-branded simulation.
It needs to be tested separately for memory leaks. To help isolate the nature of the memory leak, this test should
be run separately from the PhET brand memory leak test. Test with a colorized Data Stream, and Studio (easily
accessed from phetmarks). Compare to testing results done by the responsible developer and previous releases.
- [ ] Make sure unused `PhetioObject` instances are disposed, which unregisters their tandems.
- [ ] Make sure JOIST `dt` values are used instead of `Date.now()` or other Date functions. Perhaps try
`phet.joist.elapsedTime`. Though this has already been mentioned, it is necessary for reproducible playback via input
events and deserves a comment in this PhET-iO section.
- [ ] Are random numbers using `phet.joist.random`, and all doing so after modules are declared (non-statically)? For
example, the following methods (and perhaps others) should not be used: `Math.random`, `_.shuffle`, `_.sample`, `_.random`.
This also deserves re-iteration due to its effect on record/playback for PhET-iO.
- [ ] Like JSON, keys for `undefined` values are omitted when serializing objects across frames. Consider this when
determining whether `toStateObject` should use `null` or `undefined` values.
- [ ] PhET prefers to use the term "position" to refer to the physical (x,y) position of objects. This applies to both
brands, but is more important for the PhET-iO API. See https://github.com/phetsims/phet-info/issues/126
|
1.0
|
Code Review - Collision lab is ready for code review.
# PhET Code-Review Checklist (a.k.a "CRC")
* Mark failed items with ❌
* Call attention to items with ⚠️
* Mark items that are not applicable with "N/A"
## GitHub Issues
The following standard GitHub issues should exist. If any of these issues is missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.
GitHub issues should exist that document:
- [ ] results of memory testing for `brands=phet` (#147)
- [ ] performance testing and sign-off (#157)
- [ ] (#142) review of pointer areas
- [ ] credits (will not be completed until after RC testing) (#145)
## **Build and Run Checks**
If any of these items fail, pause code review.
- [x] Does the sim build without warnings or errors?
- [x] Does the html file size seem reasonable, compared to other similar sims?
- [x] Does the sim start up? (unbuilt and built versions)
- [x] Does the sim experience any assertion failures? (run with query parameter `ea`)
- [x] Does the sim pass a scenery fuzz test? (run with query parameters `fuzz&ea`)
- [x] Does the sim behave correctly when listener order is shuffled? (run with query parameters `ea&shuffleListeners` and `ea&shuffleListeners&fuzz`)
- [x] Does the sim use `Map`? If so, make sure that it still works well in IE11 as not all `Map` functions are supported there.
- [x] Does the sim output any deprecation warnings? Run with `?deprecationWarnings`. Do not use deprecated methods in new code.
## **Memory Leaks**
- [x] Does a heap comparison using Chrome Developer Tools indicate a memory leak? (Describing this process is beyond the scope of this document.) Test on a version built using `grunt --minify.mangle=false`. Compare to testing results done by the responsible developer.
- [x] For each common-code component (sun, scenery-phet, vegas, …) that opaquely registers observers or listeners, is
there a call to that component’s `dispose` function, or is it obvious why it isn't necessary, or is there documentation
about why `dispose` isn't called? An example of why no call to `dispose` is needed is if the component is used in
a `ScreenView` that would never be removed from the scene graph.
- [x] Are there leaks due to registering observers or listeners? The following guidelines should be followed unless
there it is obviously no need to unlink, or documentation (in-line or in the implementation nodes)added about why
following them is not necessary. Unlink is not needed for Properties contained in classes that are never disposed of,
such as primary model and view classes that exist for the duration of the sim.
- [x] AXON: `Property.link` is accompanied by `Property.unlink`.
- [x] AXON: Creation of `DerivedProperty` is accompanied by `dispose`.
- [x] AXON: Creation of `Multilink` is accompanied by `dispose`.
- [x] AXON: Creation of `Emitter` is accompanied by `dispose`, and/or `Emitter.addListener` is accompanied by `Emitter.removeListener`.
- [x] TANDEM: PhET-iO instrumented `PhetioObject` instances should be disposed.
- [x] Do all types that require a `dispose` function have one? This should expose a public `dispose` function that calls `this.disposeMyType()`, where `disposeMyType` is a private function declared in the constructor. `MyType` should exactly match the filename.
## **Performance**
- [x] Play with sim, identify any obvious performance issues. Examples: animation that slows down with large numbers of objects; animation that pauses or "hitches" during garbage collection.
- [x] If the sim uses WebGL, does it have a fallback? Does the fallback perform reasonably well? (run with query parameter `webgl=false`)
## **Usability**
- [x] Are UI components sufficiently responsive? (especially continuous UI components, such as sliders)
- [x] Are pointer areas optimized, especially for touch? (run with query parameter `showPointerAreas`)
- [x] Do pointer areas overlap? (run with query parameter `showPointerAreas`) Overlap may be OK in some cases, depending on the z-ordering (if the front-most object is supposed to occlude pointer areas) and whether objects can be moved.
## **Internationalization**
- [x] Are there any strings that are not internationalized, and does the sim layout gracefully handle internationalized strings that are shorter than the English strings? (run with query parameter `stringTest=X`. You should see nothing but 'X' strings.)
- [x] Does the sim layout gracefully handle internationalized strings that are longer than the English strings? (run with query parameters `stringTest=double` and `stringTest=long`)
- [x] Does the sim stay on the sim page (doesn't redirect to an external page) when running with the query parameter
`stringTest=xss`? This test passes if sim does not redirect, OK if sim crashes or fails to fully start. Only test on one
desktop platform. For PhET-iO sims, additionally test `?stringTest=xss` in Studio to make sure i18n strings didn't leak
to phetioDocumentation, see https://github.com/phetsims/phet-io/issues/1377
- [x] Avoid using concatenation to create strings that will be visible in the user interface. Use `StringUtils.fillIn` and a string pattern to ensure that strings are properly localized.
- [x] Use named placeholders (e.g. `"{{value}} {{units}}"`) instead of numbered placeholders (e.g. `"{0} {1}"`).
- [x] Make sure the string keys are all perfect, because they are difficult to change after 1.0.0 is published. Guidelines for string keys are:
(1) Strings keys should generally match their values. E.g.:
```js
"helloWorld": {
value: "Hello World!"
},
"quadraticTerms": {
value: "Quadratic Terms"
}
```
(2) If a string key would be exceptionally long, use a key name that is an abbreviated form of the string value, or that captures the purpose/essence of the value. E.g.:
```js
// key is abbreviated
"iWentToTheStore": {
value: "I went to the store to get milk, eggs, butter, and sugar."
},
// key is based on purpose
"describeTheScreen": {
value: "The Play Area is a small room. The Control Panel has buttons, a checkbox, and radio buttons to change conditions in the room."
}
```
(3) If string key names would collide, use your judgment to disambiguate. E.g.:
```js
"simplifyTitle": {
value: "Simplify!"
},
"simplifyCheckbox": {
value: "simplify"
}
```
(4) String keys for screen names should have the general form `"screen.{{screenName}}"`. E.g.:
```js
"screen.explore": {
"value": "Explore"
},
```
(5) String patterns that contain placeholders (e.g. `"My name is {{first}} {{last}}"`) should use keys that are unlikely to conflict with strings that might be needed in the future. For example, for `"{{price}}"` consider using key `"pricePattern"` instead of `"price"`, if you think there might be a future need for a `"price"` string.
- [x] If the sim was already released, make sure none of the original string keys have changed. If they have changed, make sure any changes have a good reason and have been discussed with @jbphet.
## **Repository Structure**
- [x] The repository name should correspond to the sim title. For example, if the sim title is "Wave Interference", then the repository name should be "wave-interference".
- [x] Are all required files and directories present?
For a sim repository named “my-repo”, the general structure should look like this (where assets/, images/, mipmaps/ or sounds/ may be omitted if the sim doesn’t have those types of resource files).
```js
my-repo/
assets/
doc/
images/
*see annotation
model.md
implementation-notes.md
images/
license.json
js/
(see section below)
mipmaps/
license.json
sound/
license.json
dependencies.json
.gitignore
my-repo_en.html
my-repo-strings_en.json
Gruntfile.js
LICENSE
package.json
README.md
```
*Any images used in model.md or implementation-notes.md should be added here. Images specific to aiding with documentation do not need their own license.
- [x] Verify that the same image file is not present in both images/ and mipmaps/. If you need a mipmap, use it for all occurrences of the image.
- [x] Is the js/ directory properly structured?
All JavaScript source should be in the js/ directory. There should be a subdirectory for each screen (this also applies for single-screen sims, where the subdirectory matches the repo name). For a multi-screen sim, code shared by 2 or more screens should be in a js/common/ subdirectory. Model and view code should be in model/ and view/ subdirectories for each screen and common/. For example, for a sim with screens “Introduction” and “Lab”, the general directory structure should look like this:
```js
my-repo/
js/
common/
model/
view/
introduction/
model/
view/
lab/
model/
view/
my-repo-config.js
my-repo-main.js
myRepo.js
```
- [x] Do filenames use an appropriate prefix? Some filenames may be prefixed with the repository name, e.g. `MolarityConstants.js` in molarity. If the repository name is long, the developer may choose to abbreviate the repository name, e.g. `EEConstants.js` in expression-exchange. If the abbreviation is already used by another respository, then the full name must be used. For example, if the "EE" abbreviation is already used by expression-exchange, then it should not be used in equality-explorer. Whichever convention is used, it should be used consistently within a repository - don't mix abbreviations and full names.
- [x] Is there a file in assets/ for every resource file in sound/ and images/? Note that there is *not necessarily* a 1:1 correspondence between asset and resource files; for example, several related images may be in the same .ai file. Check license.json for possible documentation of why some reesources might not have a corresponding asset file.
- [x] Was the README.md generated by `grunt published-README` or `grunt unpublished-README`?
- [x] Does package.json refer to any dependencies that are not used by the sim?
- [x] Is the LICENSE file correct? (Generally GPL v3 for sims and MIT for common code, see [this thread](https://github.com/phetsims/tasks/issues/875#issuecomment-312168646) for additional information).
- [x] Does .gitignore match the one in simula-rasa?
- [x] In GitHub, verify that all non-release branches have an associated issue that describes their purpose.
- [x] Are there any GitHub branches that are no longer needed and should be deleted?
- [x] Does `model.md` adequately describe the model, in terms appropriate for teachers?
- [x] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers?
- [x] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used). Query parameters that are public-facing should be identified using `public: true` in the schema.
## **Coding Conventions**
This section deals with PhET coding conventions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] Is the code formatted according to PhET conventions? See [phet-idea-code-style.xml](https://github.com/phetsims/phet-info/blob/master/ide/idea/phet-idea-codestyle.xml) for IntelliJ IDEA code style.
- [x] Names (types, variables, properties, Properties, functions,...) should be sufficiently descriptive and specific, and should avoid non-standard abbreviations. For example:
```js
const numPart = 100; // incorrect
const numberOfParticles = 100; // correct
const width = 150; // incorrect
const beakerWidth = 150; // correct
```
- [x] Verify that [Best Practices for Modules](https://github.com/phetsims/phet-info/blob/master/doc/best-practices-for-modules.md) are followed.
- [x] For constructors, use parameters for things that don’t have a default. Use options for things that have a default value. This improves readability at the call site, especially when the number of parameters is large. It also eliminates order dependency that is required by using parameters.
For example, this constructor uses parameters for everything. At the call site, the semantics of the arguments are difficult to determine without consulting the constructor.
```js
class BallNode extends Node {
/**
* @param {Ball} ball - model element
* @param {Property.<boolean>} visibleProperty - is the ball visible?
* @param {Color|string} fill - fill color
* @param {Color|string} stroke - stroke color
* @param {number} lineWidth - width of the stroke
*/
constructor( ball, visibleProperty, fill, stroke, lineWidth ){
// ...
}
}
// Call site
const ballNode = new BallNode( ball, visibleProperty, 'blue', 'black', 2 );
```
Here’s the same constructor with an appropriate use of options. The call site is easier to read, and the order of options is flexible.
```js
class BallNode extends Node {
/**
* @param {Ball} ball - model element
* @param {Property.<boolean>} visibleProperty - is the ball visible?
* @param {Object} [options]
*/
constructor( ball, visibleProperty, options ) {
options = merge( {
fill: 'white', // {Color|string} fill color
stroke: 'black', // {Color|string} stroke color
lineWidth: 1 // {number} width of the stroke
}, options );
// ...
}
}
// Call site
const ballNode = new BallNode( ball, visibleProperty, {
fill: 'blue',
stroke: 'black',
lineWidth: 2
} );
```
- [x] When options are passed through one constructor to another, a "nested options" pattern should be used. This helps to avoid duplicating option names and/or accidentally overwriting options for different components that use the same option names. Make sure to use PHET_CORE/merge instead of `_.extend` or `_.merge`. `merge` will automatically recurse to keys named `*Options` and extend those as well.
Example:
```js
class ParticleBoxNode extends Node {
/**
* @param {ParticleBox} particleBox - model element
* @param {Property.<boolean>} visibleProperty - are the box and its contents visible?
* @param {Object} [options]
*/
constructor( particleBox, visibleProperty, options ) {
options = merge( {
fill: 'white', // {Color|string} fill color
stroke: 'black', // {Color|string} stroke color
lineWidth: 1, // {number} width of the stroke
particleNodeOptions: {
fill: 'red',
stroke: 'gray',
lineWidth: 0.5
},
}, options );
// add particle
this.addChild( new ParticleNode( particleBox.particle, options.particleNodeOptions ) );
...
}
}
```
A possible exception to this guideline is when the constructor API is improved by hiding the implementation details, i.e. not revealing that a sub-component exists. In that case, it may make sense to use new top-level options. This is left to developer and reviewer discretion.
For more information on the history and thought process around the "nested options" pattern, please see https://github.com/phetsims/tasks/issues/730.
- [x] If references are needed to the enclosing object, such as for a closure, `self` should be defined, but it should only be used in closures. The `self` variable should not be defined unless it is needed in a closure. Example:
```js
const self = this;
someProperty.link( function(){
self.doSomething();
} );
this.doSomethingElse();
```
- [x] Generally, lines should not exceed 120 columns. Break up long statements, expressions, or comments into multiple
lines to optimize readability. It is OK for require statements or other structured patterns to exceed 120 columns.
Use your judgment!
- [x] Use `class` and `extends` for defining classes and implementing inheritance. `PHET_CORE/inherit` was a pre-ES6 implementation of inheritance that is specific to PhET and has been supplanted by `class` and `extends`. `inherit` should
not be used in new code.
- [x] Functions should be invoked using the dot operator rather than the bracket operator. For more details, please see https://github.com/phetsims/gravity-and-orbits/issues/9. For example:
```js
// avoid
this[ isFaceSmile ? 'smile' : 'frown' ]();
// OK
isFaceSmile ? this.smile() : this.frown();
// OK
if ( isFaceSmile ) {
this.smile();
}
else {
this.frown();
}
```
- [x] It is not uncommon to use conditional shorthand and short circuiting for invocation. Use parentheses to maximize readability.
```js
( expression ) && statement;
( expression ) ? statement1 : statement2;
( foo && bar ) ? fooBar() : fooCat();
( foo && bar ) && fooBar();
( foo && !(bar && fooBar)) && nowIAmConfused();
this.fill = ( foo && bar ) ? 'red' : 'blue';
```
If the expression is only one item, the parentheses can be omitted. This is the most common use case.
```js
assert && assert( happy, 'Why aren\'t you happy?' );
happy && smile();
const thoughts = happy ? 'I am happy' : 'I am not happy :(';
```
- [x] Naming for Property values: All `AXON/Property` instances should be declared with the suffix `Property`. For example, if a visible property is added, it should have the name `visibleProperty` instead of simply `visible`. This will help to avoid confusion with non-Property definitions.
- [x] Properties should use type-specific subclasses where appropriate (.e.g BooleanProperty, NumberProperty, StringProperty) or provide documentation as to why they are not.
- [x] Are `Validator` validation options (`valueType`, `validValues`, etc...) utilized? These are supported in a number of core types like `Emitter` and `Property`. Is their presence or lack thereof properly documented?
- [x] Files should be named like `CapitalizedCamelCasing.js` when returning a constructor, or `lowerCaseCamelCasing.js` when returning a non-constructor function or singleton. When returning a constructor or singleton, the constructor name should match the filename.
- [x] Assertions should be used appropriately and consistently. Type checking should not just be done in code comments. Use `Array.isArray` to type check an array.
- [x] If you need to namespace an inner class, use `{{namespace}}.register`, and include a comment about why the inner class needs to be namespaced. Use the form `'{{outerClassname}}.{{innerClassname}}'` for the key. For example:
```js
import myNamespace from '...';
class SlotMachineNode extends Node {
constructor( ... ) {
this.leverNode = new LeverNode(...);
...
}
...
}
myNamespace.register( 'SlotMachineNode', SlotMachineNode );
class LeverNode extends Node {
...
}
// It was useful to be able to instantiate this in the console for testing, and we may need to do so in the future.
myNamespace.register( 'SlotMachineNode.LeverNode', LeverNode );
return SlotMachineNode;
```
- [x] Putting unused parameters in callbacks is up to developer discretion, as long they are correct wrt to the actual callback signature.
For example, both of these are acceptable:
```js
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active, color ) => {
// some algorithm that uses style and active
} );
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active ) => {
// some algorithm that uses style and active
} );
```
This is not acceptable, because the 3rd parameter is incorrect.
```js
Property.multilink(
[ styleProperty, activeProperty, colorProperty ],
( style, active, lineWidth ) => {
// some algorithm that uses style and active
} );
```
### Documentation
This section deals with PhET documention conventions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] All classes, methods and properties are documented.
- [x] Documentation at the top of .js files should provide an overview of purpose, responsibilies, and (where useful) examples of API use. If the file contains a subclass definition, it should indicate what functionality it adds to the superclass.
- [x] The HTML5/CSS3/JavaScript source code must be reasonably well documented. This is difficult to specify precisely, but the idea is that someone who is moderately experienced with HTML5/CSS3/JavaScript can quickly understand the general function of the source code as well as the overall flow of the code by reading through the comments. For an example of the type of documentation that is required, please see the example-sim repository.
- [x] Differentiate between `Property` and "property" in comments. They are different things. `Property` is a type in AXON; property is any value associated with a JavaScript object. Often "field" can be used in exchange for "property" which can help with clarity.
- [x] Classes that mix in traits or mixin should use the `@mixes MyType` annotation.
- [x] Line comments should generally be preceded by a blank line. For example:
```js
// Randomly choose an existing crystal to possibly bond to
const crystal = this.crystals.get( _.random( this.crystals.length - 1 ) );
// Find a good configuration to have the particles move toward
const targetConfiguration = this.getTargetConfiguration( crystal );
```
- [x] When documenting conditionals (if/else statements), follow these guidlines:
1. Comments above the first `if` in a conditional should be about the entire conditional, not just the if block.
2. Comments should not break up sections of the conditional.
3. If a comment is needed to describe a single block of the conditional, then add that comment just inside the block (no space between the `if`/`else if`/`else` and the comment), with a space below it as to not be confused with a comment about logic below.
```js
// Comment about the reason to split on peppers were pickled.
if( peterPiperPickedAJarOfPickledPeppers ){
// if we want to explain what this `if` statement is about
peterAlsoHasBrine();
}
else {
// documentation about why we have no peppers. This is about the next line of code, and not the "else as a whole block."
peterHasNoPeppers();
}
```
- [x] Line comments should have whitespace between the `//` and the first letter of the line comment. See the preceding example.
- [x] Do the `@author` annotations seem correct?
- [x] ES5 (`inherit`) constructors should be annotated with `@constructor`. ES6 (`class`) constructors should _not_ be annotated with `@constructor`.
- [x] Constructor and function documentation. Parameter types and names should be clearly specified for each constructor and function using `@param` annotations. The description for each parameter should follow a hyphen. Primitive types should use lower case. For example:
```js
/**
* The PhetDeveloper is responsible for creating code for simulations and documenting their code thoroughly.
*/
class PhetDeveloper {
/**
* @param {string} name - full name
* @param {number} age - age, in years
* @param {boolean} isEmployee - whether this developer is an employee of CU
* @param {function} callback - called immediate after coffee is consumed
* @param {Property.<number>} hoursProperty - cumulative hours worked
* @param {string[]} friendNames - names of friends
* @param {Object} [options]
*/
constructor( name, age, isEmployee, callback, hoursProperty, friendNames, options ) {
...
}
...
}
```
- [x] For most functions, the same form as above should be used, with a `@returns` annotation which identifies the return type and the meaning of the returned value. Functions should also document any side effects. For extremely simple functions that are just a few lines of simple code, an abbreviated line-comment can be used, for example: `// Computes {Number} distance based on {Foo} foo.`
- [x] Abstract methods (normally implemented with an error) should be marked with `@abstract` jsdoc.
#### Type Expressions
This section deals with PhET conventions for type expressions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
- [x] Type expressions should conform approximately to [Google Closure Compiler](https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler) syntax. PhET stretches the syntax in many cases (beyond the scope of this document to describe).
- [x] Prefer the most basic/restrictive type expression when defining APIs. For example, if a client only needs to know that a parameter is `{Node}`, don’t describe the parameter as `{Rectangle}`.
- [x] All method parameters should have type expressions. For example `@param {number} width`.
- [x] In sim-specific code, options and fields should have type expressions when their type is not obvious from the context. “Obvious” typically means that the value type is clearly shown in the righthand-side of the definition. E.g. `const width = 42` clear shows that `width` is `{number}`. E.g. `const checkbox = new Checkbox(…)` clearly shows that `checkbox` is `{Checkbox}`. If the type is obvious from the context, the developer may still provide a type expression at his/her discretion. Examples:
```js
// @public {GameState} the current state of the game
this.gameState = this.computeGameState();
// @public (read-only) the width of the container
this.containerWidth = 150;
// @private the checkbox used to show particles
this.particlesVisibleCheckbox = new Checkbox(...);
```
- [x] In common code repositories all options and fields should have type expressions, regardless of their visibility, and regardless whether their type is obvious from the context. If the same examples from above appeared in common code:
```js
// @public {GameState} the current state of the game
this.gameState = this.computeGameState();
// @public (read-only) {number} the width of the container
this.containerWidth = 150;
// @private {Checkbox} the checkbox used to show particles
this.particlesVisibleCheckbox = new Checkbox(...);
```
- [x] Type expressions for Enumeration values should be annotated as instances of that Enumeration, see examples in https://github.com/phetsims/phet-core/blob/master/js/Enumeration.js for more.
```js
/**
* @param {LeftOrRight} - whichHand
*/
function getHand( whichHand ){
if( whichHand === LeftOrRight.LEFT ){
return new LeftHand();
}
else if( whichHand === LeftOrRight.RIGHT ){
return new RightHand();
}
}
```
- [x] Type expressions for functions have a variety of possibilities, increasing in complexity depending on the case. In general note that `{function}` is not enough information. Here are some better options:
1. The most basic option it to use Google Closure Type syntax, for more info see https://github.com/google/closure-compiler/wiki/Types-in-the-Closure-Type-System. This specifies the param/return types, but nothing more. Here are some examples:
* `@param {function()} noParamsAndNoReturnValue`
* `@param {function(number)} giveMeNumberAndReturnNothing`
* `@param {function(number, number):Vector2} getVector2`
* `@param {function(new:Node)} createNode - a function that takes the Node constructor`
2. When needing to be a bit more specific, add a name to parameters of the function. Sometimes this is all that is needed for clarity on what the param does:
* `@param {function(model:MyModel, length:number, name:string): Node} getLengthNode`
* `@param {function(aSelfExplanatoryNameForAString:string): Node} getStringNode`
3. If (2) isn't enough, use English to explain the parameters and return values. This is easy because they are named, and can be easily mentioned:
* `@param {function(model:MyModel, length:number, name:string): Node} getLengthNode - returns the length Node that you have always wanted, name is the name of the source of your aspirations, length is a special number according to the following 24 criteria. . .`
4. If needing more complexity, or using jsdoc rendering tools (like PhET-iO documentation does), you must use a JSDoc compatible format, not (2) or (3), and you may need to use the more complicated solution. See JSDoc docs for more info. Here is an example of a named callback:
```js
/**
* @name mySpecialCallback
* Converts a string to a number
* @param {string}
* @returns {number}
*/
/**
* @param {mySpecialCallback} callback
*/
x = function( callback) { callback( 'still chocolate' ) };
```
- [x] Type expressions for anonymous Objects have a variety of possibilities, increasing in complexity depending on the case.
1. When the documentation is close by, then {Object} is still acceptable. This mainly applies to options and similar patterns:
* `@param {Object} [options] // this is great because of the extend call 5 lines down`
2. When using an `Object` with specific properties, name them and their types like so:
* `@param {name:string, address:{street:string}, returnNode:function(number):Node, [shoeSize:number]} personalData // note that shoeSize is optional here`
3. When you need a bit more explanation, keep the same type expression as (2), but feel free to outline specifics in English after the param name.
```
@ param {name:string, address:{street:string}, returnNode:function(number):Node, [shoeSize:number]} personalData - use english after to explain pieces of this
(if needed, outline properties on their own lines)
name is something
address is something else
returnNode does this thing
```
4. Not all objects have named keys like (2) and (3). Here is how to document dictionary-like `Object`s, where each key is some type, and the value is another type. For key value pairs use this:
* `{Object.<string, number>}` Where keys are strings, and values are numbers.
* `{Object.<phetioID:string, count:number>}` - naming each of these can help identify them too. Feel free to explain in English after the type expression if needed.
5. If things are too complicated for the above cases, use a `*Def.js` file (especially is used in more than one file), or a `@typedef` declaration right above the jsdoc that uses the typedef.
- [x] Look for cases where the use of type expressions involving Property subclasses are incorrect. Because of the structure of the `Property` class hierarchy, specifying type-specific Properties (`{BooleanProperty}`, `{NumberProperty}`,...) may be incorrect, because it precludes values of type `{DerivedProperty}` and `{DynamicProperty}`. Similarly, use of `{DerivedProperty}` and `{DynamicProperty}` precludes values of (e.g.) `{BooleanProperty}`. Especially in common code, using `{Property,<TYPE>}` is typically correct, unless some specific feature of the `Property` subclass is required. For example, `{Property.<boolean>}` instead of `{BooleanProperty}`.
#### Visibility Annotations
This section deals with PhET conventions for visibility annotations. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.
Because JavaScript lacks visibility modifiers (public, protected, private), PhET uses JSdoc visibility annotations to document the intent of the programmer, and define the public API. Visibility annotations are required for anything that JavaScript makes public. Information about these annotations can be found here. (Note that other documentation systems like the Google Closure Compiler use slightly different syntax in some cases. Where there are differences, JSDoc is authoritative. For example, use `Array.<Object>` or `Object[]` instead of `Array<Object>`). PhET guidelines for visibility annotations are as follows:
- [x] Use `@public` for anything that is intended to be part of the public API.
- [x] Use `@protected` for anything that is intended for use by subtypes.
- [x] Use `@private` for anything that is NOT intended to be part of the public or protected API.
- [x] Put qualifiers in parenthesis after the annotation, for example:
* To qualify that something is read-only, use `@public (read-only)`. This indicates that the given Property (AND its value) should not be changed by outside code (e.g. a Property should not have its value changed)
* To qualify that something is public to a specific repository, use (for example) `@public (scenery-internal)`
* For something made public solely for a11y, use `@public (a11y)`
* For something made public solely for phet-io, use `@public (phet-io)`
* Separate multiple qualifiers with commas. For example: `@public (scenery-internal, read-only)`
- [x] For JSDoc-style comments, the annotation should appear in context like this:
```js
/**
* Creates the icon for the "Energy" screen, a cartoonish bar graph.
* @returns {Node}
* @public
*/
```
- [x] For Line comments, the annotation can appear like this:
```js
// @public {function(listener:function)} - Adds a listener
addListener: function( listener ) { /*...*/ }
```
- [x] Verify that every JavaScript property and function has a visibility annotation. Here are some helpful regular expressions to search for these declarations as PhET uses them.
* Regex for property assignment like `x.y = something`: `[\w]+\.[\w]+\s=`
* Regex for function declarations: `[\w]+: function\(`
## **Math Libraries**
- [x] `DOT/Utils.toFixed` or `DOT/Utils.toFixedNumber` should be used instead of `toFixed`. JavaScript's `toFixed` is notoriously buggy. Behavior differs depending on browser, because the spec doesn't specify whether to round or floor.
## IE11
- [x] IE is no longer supported. With that in mind remove IE-specific workarounds
## **Organization, Readability, and Maintainability**
- [x] Does the organization and structure of the code make sense? Do the model and view contain types that you would expect (or guess!) by looking at the sim? Do the names of things correspond to the names that you see in the user interface?
- [x] Are appropriate design patterns used? See [phet-software-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md). If new or inappropriate patterns are identified, create an issue.
- [x] Is inheritance used where appropriate? Does the type hierarchy make sense?
- [x] Is composition favored over inheritance where appropriate? See https://en.wikipedia.org/wiki/Composition_over_inheritance.
- [x] Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions)
- [x] Is there too much unnecessary decoupling? (e.g. by passing all of the properties of an object independently instead of passing the object itself)?
- [x] Are the source files reasonable in size? Scrutinize large files with too many responsibilities - can responsibilities be broken into smaller delegates?
- [x] Are any significant chunks of code duplicated? This will be checked manually as well as with https://github.com/danielstjules/jsinspect or `grunt find-duplicates`
- [x] Is there anything that should be generalized and migrated to common code?
- [x] Are there any `TODO` or `FIXME` or `REVIEW` comments in the code? They should be addressed or promoted to GitHub issues.
- [x] Are there any [magic numbers](https://en.wikipedia.org/wiki/Magic_number_(programming)) that should be factored out as constants and documented?
- [x] Are there any constants that are duplicated in multiple files that should be factored out into a `{{REPO}}Constants.js` file?
- [x] Does the implementation rely on any specific constant values that are likely to change in the future? Identify constants that might be changed in the future. (Use your judgement about which constants are likely candidates.) Does changing the values of these constants break the sim? For example, see https://github.com/phetsims/plinko-probability/issues/84.
- [x] Is [PhetColorScheme](https://github.com/phetsims/scenery-phet/blob/master/js/PhetColorScheme.js) used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in `PhetColorScheme`. Identify any colors that might be worth adding to `PhetColorScheme`.
- [x] Are all dependent Properties modeled as `DerivedProperty` instead of `Property`?
- [x] All dynamics should be called from Sim.step(dt), do not use window.setTimeout or window.setInterval. This will help support Legends of Learning and PhET-iO.
## **Accessibility**
This section may be omitted if the sim has not been instrumented for a11y.
- [ ] Does the sim pass an accessibility fuzz test? (run with query parameters `fuzzBoard&ea`)
- [ ] Run the accessible HTML through an [HTML validator](https://validator.w3.org/nu/#textarea), does the HTML pass?
- [ ] Are accessibility features integrated well into the code. They should be added in a maintainable way, even if that requires upfront refactoring.
- [ ] Are accessible design patterns used, see [accessible-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/accessible-design-patterns.md)
- [ ] Does resetting the simulation also reset the entire PDOM?
- [ ] Is `Node.accessibleOrder` used appropriately to maintain visual and PDOM layout balance?
- [ ] Make sure accessibility strings aren't being adjusted with ascii specific javascript methods like `toUpperCase()`. Remember that one day these strings will be translatable
- [ ] Make sure for accessibility strings that all end of sentence periods do not have a leading space before it. Some screen readers will read these as "dot." This can occur often when a clause is conditionally added.
## **PhET-iO**
This section may be omitted if the sim has not been instrumented for PhET-iO.
- [ ] Does instrumentation follow the conventions described in [PhET-iO Instrumentation Guide](https://github.com/phetsims/phet-io/blob/master/doc/phet-io-instrumentation-guide.md)?
This could be an extensive bullet. At the very least, be sure to know what amount of instrumentation this sim
supports. Describing this further goes beyond the scope of this document.
- [ ] PhET-iO instantiates different objects and wires up listeners that are not present in the PhET-branded simulation.
It needs to be tested separately for memory leaks. To help isolate the nature of the memory leak, this test should
be run separately from the PhET brand memory leak test. Test with a colorized Data Stream, and Studio (easily
accessed from phetmarks). Compare to testing results done by the responsible developer and previous releases.
- [ ] Make sure unused `PhetioObject` instances are disposed, which unregisters their tandems.
- [ ] Make sure JOIST `dt` values are used instead of `Date.now()` or other Date functions. Perhaps try
`phet.joist.elapsedTime`. Though this has already been mentioned, it is necessary for reproducible playback via input
events and deserves a comment in this PhET-iO section.
- [ ] Are random numbers using `phet.joist.random`, and all doing so after modules are declared (non-statically)? For
example, the following methods (and perhaps others) should not be used: `Math.random`, `_.shuffle`, `_.sample`, `_.random`.
This also deserves re-iteration due to its effect on record/playback for PhET-iO.
- [ ] Like JSON, keys for `undefined` values are omitted when serializing objects across frames. Consider this when
determining whether `toStateObject` should use `null` or `undefined` values.
- [ ] PhET prefers to use the term "position" to refer to the physical (x,y) position of objects. This applies to both
brands, but is more important for the PhET-iO API. See https://github.com/phetsims/phet-info/issues/126
|
non_design
|
code review collision lab is ready for code review phet code review checklist a k a crc mark failed items with ❌ call attention to items with ⚠️ mark items that are not applicable with n a github issues the following standard github issues should exist if any of these issues is missing or have not been completed pause code review until the issues have been created and addressed by the responsible dev github issues should exist that document results of memory testing for brands phet performance testing and sign off review of pointer areas credits will not be completed until after rc testing build and run checks if any of these items fail pause code review does the sim build without warnings or errors does the html file size seem reasonable compared to other similar sims does the sim start up unbuilt and built versions does the sim experience any assertion failures run with query parameter ea does the sim pass a scenery fuzz test run with query parameters fuzz ea does the sim behave correctly when listener order is shuffled run with query parameters ea shufflelisteners and ea shufflelisteners fuzz does the sim use map if so make sure that it still works well in as not all map functions are supported there does the sim output any deprecation warnings run with deprecationwarnings do not use deprecated methods in new code memory leaks does a heap comparison using chrome developer tools indicate a memory leak describing this process is beyond the scope of this document test on a version built using grunt minify mangle false compare to testing results done by the responsible developer for each common code component sun scenery phet vegas … that opaquely registers observers or listeners is there a call to that component’s dispose function or is it obvious why it isn t necessary or is there documentation about why dispose isn t called an example of why no call to dispose is needed is if the component is used in a screenview that would never be removed from the scene graph are there leaks due to registering observers or listeners the following guidelines should be followed unless there it is obviously no need to unlink or documentation in line or in the implementation nodes added about why following them is not necessary unlink is not needed for properties contained in classes that are never disposed of such as primary model and view classes that exist for the duration of the sim axon property link is accompanied by property unlink axon creation of derivedproperty is accompanied by dispose axon creation of multilink is accompanied by dispose axon creation of emitter is accompanied by dispose and or emitter addlistener is accompanied by emitter removelistener tandem phet io instrumented phetioobject instances should be disposed do all types that require a dispose function have one this should expose a public dispose function that calls this disposemytype where disposemytype is a private function declared in the constructor mytype should exactly match the filename performance play with sim identify any obvious performance issues examples animation that slows down with large numbers of objects animation that pauses or hitches during garbage collection if the sim uses webgl does it have a fallback does the fallback perform reasonably well run with query parameter webgl false usability are ui components sufficiently responsive especially continuous ui components such as sliders are pointer areas optimized especially for touch run with query parameter showpointerareas do pointer areas overlap run with query parameter showpointerareas overlap may be ok in some cases depending on the z ordering if the front most object is supposed to occlude pointer areas and whether objects can be moved internationalization are there any strings that are not internationalized and does the sim layout gracefully handle internationalized strings that are shorter than the english strings run with query parameter stringtest x you should see nothing but x strings does the sim layout gracefully handle internationalized strings that are longer than the english strings run with query parameters stringtest double and stringtest long does the sim stay on the sim page doesn t redirect to an external page when running with the query parameter stringtest xss this test passes if sim does not redirect ok if sim crashes or fails to fully start only test on one desktop platform for phet io sims additionally test stringtest xss in studio to make sure strings didn t leak to phetiodocumentation see avoid using concatenation to create strings that will be visible in the user interface use stringutils fillin and a string pattern to ensure that strings are properly localized use named placeholders e g value units instead of numbered placeholders e g make sure the string keys are all perfect because they are difficult to change after is published guidelines for string keys are strings keys should generally match their values e g js helloworld value hello world quadraticterms value quadratic terms if a string key would be exceptionally long use a key name that is an abbreviated form of the string value or that captures the purpose essence of the value e g js key is abbreviated iwenttothestore value i went to the store to get milk eggs butter and sugar key is based on purpose describethescreen value the play area is a small room the control panel has buttons a checkbox and radio buttons to change conditions in the room if string key names would collide use your judgment to disambiguate e g js simplifytitle value simplify simplifycheckbox value simplify string keys for screen names should have the general form screen screenname e g js screen explore value explore string patterns that contain placeholders e g my name is first last should use keys that are unlikely to conflict with strings that might be needed in the future for example for price consider using key pricepattern instead of price if you think there might be a future need for a price string if the sim was already released make sure none of the original string keys have changed if they have changed make sure any changes have a good reason and have been discussed with jbphet repository structure the repository name should correspond to the sim title for example if the sim title is wave interference then the repository name should be wave interference are all required files and directories present for a sim repository named “my repo” the general structure should look like this where assets images mipmaps or sounds may be omitted if the sim doesn’t have those types of resource files js my repo assets doc images see annotation model md implementation notes md images license json js see section below mipmaps license json sound license json dependencies json gitignore my repo en html my repo strings en json gruntfile js license package json readme md any images used in model md or implementation notes md should be added here images specific to aiding with documentation do not need their own license verify that the same image file is not present in both images and mipmaps if you need a mipmap use it for all occurrences of the image is the js directory properly structured all javascript source should be in the js directory there should be a subdirectory for each screen this also applies for single screen sims where the subdirectory matches the repo name for a multi screen sim code shared by or more screens should be in a js common subdirectory model and view code should be in model and view subdirectories for each screen and common for example for a sim with screens “introduction” and “lab” the general directory structure should look like this js my repo js common model view introduction model view lab model view my repo config js my repo main js myrepo js do filenames use an appropriate prefix some filenames may be prefixed with the repository name e g molarityconstants js in molarity if the repository name is long the developer may choose to abbreviate the repository name e g eeconstants js in expression exchange if the abbreviation is already used by another respository then the full name must be used for example if the ee abbreviation is already used by expression exchange then it should not be used in equality explorer whichever convention is used it should be used consistently within a repository don t mix abbreviations and full names is there a file in assets for every resource file in sound and images note that there is not necessarily a correspondence between asset and resource files for example several related images may be in the same ai file check license json for possible documentation of why some reesources might not have a corresponding asset file was the readme md generated by grunt published readme or grunt unpublished readme does package json refer to any dependencies that are not used by the sim is the license file correct generally gpl for sims and mit for common code see for additional information does gitignore match the one in simula rasa in github verify that all non release branches have an associated issue that describes their purpose are there any github branches that are no longer needed and should be deleted does model md adequately describe the model in terms appropriate for teachers does implementation notes md adequately describe the implementation with an overview that will be useful to future maintainers sim specific query parameters if any should be identified and documented in one js file in js common or js if there is no common the js file should be named prefix queryparameters js for example arithmeticqueryparameters js for the aritmetic repository or fbqueryparameters js for function builder where the fb prefix is used query parameters that are public facing should be identified using public true in the schema coding conventions this section deals with phet coding conventions you do not need to exhaustively check every item in this section nor do you necessarily need to check these items one at a time the goal is to determine whether the code generally meets phet standards is the code formatted according to phet conventions see for intellij idea code style names types variables properties properties functions should be sufficiently descriptive and specific and should avoid non standard abbreviations for example js const numpart incorrect const numberofparticles correct const width incorrect const beakerwidth correct verify that are followed for constructors use parameters for things that don’t have a default use options for things that have a default value this improves readability at the call site especially when the number of parameters is large it also eliminates order dependency that is required by using parameters for example this constructor uses parameters for everything at the call site the semantics of the arguments are difficult to determine without consulting the constructor js class ballnode extends node param ball ball model element param property visibleproperty is the ball visible param color string fill fill color param color string stroke stroke color param number linewidth width of the stroke constructor ball visibleproperty fill stroke linewidth call site const ballnode new ballnode ball visibleproperty blue black here’s the same constructor with an appropriate use of options the call site is easier to read and the order of options is flexible js class ballnode extends node param ball ball model element param property visibleproperty is the ball visible param object constructor ball visibleproperty options options merge fill white color string fill color stroke black color string stroke color linewidth number width of the stroke options call site const ballnode new ballnode ball visibleproperty fill blue stroke black linewidth when options are passed through one constructor to another a nested options pattern should be used this helps to avoid duplicating option names and or accidentally overwriting options for different components that use the same option names make sure to use phet core merge instead of extend or merge merge will automatically recurse to keys named options and extend those as well example js class particleboxnode extends node param particlebox particlebox model element param property visibleproperty are the box and its contents visible param object constructor particlebox visibleproperty options options merge fill white color string fill color stroke black color string stroke color linewidth number width of the stroke particlenodeoptions fill red stroke gray linewidth options add particle this addchild new particlenode particlebox particle options particlenodeoptions a possible exception to this guideline is when the constructor api is improved by hiding the implementation details i e not revealing that a sub component exists in that case it may make sense to use new top level options this is left to developer and reviewer discretion for more information on the history and thought process around the nested options pattern please see if references are needed to the enclosing object such as for a closure self should be defined but it should only be used in closures the self variable should not be defined unless it is needed in a closure example js const self this someproperty link function self dosomething this dosomethingelse generally lines should not exceed columns break up long statements expressions or comments into multiple lines to optimize readability it is ok for require statements or other structured patterns to exceed columns use your judgment use class and extends for defining classes and implementing inheritance phet core inherit was a pre implementation of inheritance that is specific to phet and has been supplanted by class and extends inherit should not be used in new code functions should be invoked using the dot operator rather than the bracket operator for more details please see for example js avoid this ok isfacesmile this smile this frown ok if isfacesmile this smile else this frown it is not uncommon to use conditional shorthand and short circuiting for invocation use parentheses to maximize readability js expression statement expression foo bar foobar foocat foo bar foobar foo bar foobar nowiamconfused this fill foo bar red blue if the expression is only one item the parentheses can be omitted this is the most common use case js assert assert happy why aren t you happy happy smile const thoughts happy i am happy i am not happy naming for property values all axon property instances should be declared with the suffix property for example if a visible property is added it should have the name visibleproperty instead of simply visible this will help to avoid confusion with non property definitions properties should use type specific subclasses where appropriate e g booleanproperty numberproperty stringproperty or provide documentation as to why they are not are validator validation options valuetype validvalues etc utilized these are supported in a number of core types like emitter and property is their presence or lack thereof properly documented files should be named like capitalizedcamelcasing js when returning a constructor or lowercasecamelcasing js when returning a non constructor function or singleton when returning a constructor or singleton the constructor name should match the filename assertions should be used appropriately and consistently type checking should not just be done in code comments use array isarray to type check an array if you need to namespace an inner class use namespace register and include a comment about why the inner class needs to be namespaced use the form outerclassname innerclassname for the key for example js import mynamespace from class slotmachinenode extends node constructor this levernode new levernode mynamespace register slotmachinenode slotmachinenode class levernode extends node it was useful to be able to instantiate this in the console for testing and we may need to do so in the future mynamespace register slotmachinenode levernode levernode return slotmachinenode putting unused parameters in callbacks is up to developer discretion as long they are correct wrt to the actual callback signature for example both of these are acceptable js property multilink style active color some algorithm that uses style and active property multilink style active some algorithm that uses style and active this is not acceptable because the parameter is incorrect js property multilink style active linewidth some algorithm that uses style and active documentation this section deals with phet documention conventions you do not need to exhaustively check every item in this section nor do you necessarily need to check these items one at a time the goal is to determine whether the code generally meets phet standards all classes methods and properties are documented documentation at the top of js files should provide an overview of purpose responsibilies and where useful examples of api use if the file contains a subclass definition it should indicate what functionality it adds to the superclass the javascript source code must be reasonably well documented this is difficult to specify precisely but the idea is that someone who is moderately experienced with javascript can quickly understand the general function of the source code as well as the overall flow of the code by reading through the comments for an example of the type of documentation that is required please see the example sim repository differentiate between property and property in comments they are different things property is a type in axon property is any value associated with a javascript object often field can be used in exchange for property which can help with clarity classes that mix in traits or mixin should use the mixes mytype annotation line comments should generally be preceded by a blank line for example js randomly choose an existing crystal to possibly bond to const crystal this crystals get random this crystals length find a good configuration to have the particles move toward const targetconfiguration this gettargetconfiguration crystal when documenting conditionals if else statements follow these guidlines comments above the first if in a conditional should be about the entire conditional not just the if block comments should not break up sections of the conditional if a comment is needed to describe a single block of the conditional then add that comment just inside the block no space between the if else if else and the comment with a space below it as to not be confused with a comment about logic below js comment about the reason to split on peppers were pickled if peterpiperpickedajarofpickledpeppers if we want to explain what this if statement is about peteralsohasbrine else documentation about why we have no peppers this is about the next line of code and not the else as a whole block peterhasnopeppers line comments should have whitespace between the and the first letter of the line comment see the preceding example do the author annotations seem correct inherit constructors should be annotated with constructor class constructors should not be annotated with constructor constructor and function documentation parameter types and names should be clearly specified for each constructor and function using param annotations the description for each parameter should follow a hyphen primitive types should use lower case for example js the phetdeveloper is responsible for creating code for simulations and documenting their code thoroughly class phetdeveloper param string name full name param number age age in years param boolean isemployee whether this developer is an employee of cu param function callback called immediate after coffee is consumed param property hoursproperty cumulative hours worked param string friendnames names of friends param object constructor name age isemployee callback hoursproperty friendnames options for most functions the same form as above should be used with a returns annotation which identifies the return type and the meaning of the returned value functions should also document any side effects for extremely simple functions that are just a few lines of simple code an abbreviated line comment can be used for example computes number distance based on foo foo abstract methods normally implemented with an error should be marked with abstract jsdoc type expressions this section deals with phet conventions for type expressions you do not need to exhaustively check every item in this section nor do you necessarily need to check these items one at a time the goal is to determine whether the code generally meets phet standards type expressions should conform approximately to syntax phet stretches the syntax in many cases beyond the scope of this document to describe prefer the most basic restrictive type expression when defining apis for example if a client only needs to know that a parameter is node don’t describe the parameter as rectangle all method parameters should have type expressions for example param number width in sim specific code options and fields should have type expressions when their type is not obvious from the context “obvious” typically means that the value type is clearly shown in the righthand side of the definition e g const width clear shows that width is number e g const checkbox new checkbox … clearly shows that checkbox is checkbox if the type is obvious from the context the developer may still provide a type expression at his her discretion examples js public gamestate the current state of the game this gamestate this computegamestate public read only the width of the container this containerwidth private the checkbox used to show particles this particlesvisiblecheckbox new checkbox in common code repositories all options and fields should have type expressions regardless of their visibility and regardless whether their type is obvious from the context if the same examples from above appeared in common code js public gamestate the current state of the game this gamestate this computegamestate public read only number the width of the container this containerwidth private checkbox the checkbox used to show particles this particlesvisiblecheckbox new checkbox type expressions for enumeration values should be annotated as instances of that enumeration see examples in for more js param leftorright whichhand function gethand whichhand if whichhand leftorright left return new lefthand else if whichhand leftorright right return new righthand type expressions for functions have a variety of possibilities increasing in complexity depending on the case in general note that function is not enough information here are some better options the most basic option it to use google closure type syntax for more info see this specifies the param return types but nothing more here are some examples param function noparamsandnoreturnvalue param function number givemenumberandreturnnothing param function number number param function new node createnode a function that takes the node constructor when needing to be a bit more specific add a name to parameters of the function sometimes this is all that is needed for clarity on what the param does param function model mymodel length number name string node getlengthnode param function aselfexplanatorynameforastring string node getstringnode if isn t enough use english to explain the parameters and return values this is easy because they are named and can be easily mentioned param function model mymodel length number name string node getlengthnode returns the length node that you have always wanted name is the name of the source of your aspirations length is a special number according to the following criteria if needing more complexity or using jsdoc rendering tools like phet io documentation does you must use a jsdoc compatible format not or and you may need to use the more complicated solution see jsdoc docs for more info here is an example of a named callback js name myspecialcallback converts a string to a number param string returns number param myspecialcallback callback x function callback callback still chocolate type expressions for anonymous objects have a variety of possibilities increasing in complexity depending on the case when the documentation is close by then object is still acceptable this mainly applies to options and similar patterns param object this is great because of the extend call lines down when using an object with specific properties name them and their types like so param name string address street string returnnode function number node personaldata note that shoesize is optional here when you need a bit more explanation keep the same type expression as but feel free to outline specifics in english after the param name param name string address street string returnnode function number node personaldata use english after to explain pieces of this if needed outline properties on their own lines name is something address is something else returnnode does this thing not all objects have named keys like and here is how to document dictionary like object s where each key is some type and the value is another type for key value pairs use this object where keys are strings and values are numbers object naming each of these can help identify them too feel free to explain in english after the type expression if needed if things are too complicated for the above cases use a def js file especially is used in more than one file or a typedef declaration right above the jsdoc that uses the typedef look for cases where the use of type expressions involving property subclasses are incorrect because of the structure of the property class hierarchy specifying type specific properties booleanproperty numberproperty may be incorrect because it precludes values of type derivedproperty and dynamicproperty similarly use of derivedproperty and dynamicproperty precludes values of e g booleanproperty especially in common code using property is typically correct unless some specific feature of the property subclass is required for example property instead of booleanproperty visibility annotations this section deals with phet conventions for visibility annotations you do not need to exhaustively check every item in this section nor do you necessarily need to check these items one at a time the goal is to determine whether the code generally meets phet standards because javascript lacks visibility modifiers public protected private phet uses jsdoc visibility annotations to document the intent of the programmer and define the public api visibility annotations are required for anything that javascript makes public information about these annotations can be found here note that other documentation systems like the google closure compiler use slightly different syntax in some cases where there are differences jsdoc is authoritative for example use array or object instead of array phet guidelines for visibility annotations are as follows use public for anything that is intended to be part of the public api use protected for anything that is intended for use by subtypes use private for anything that is not intended to be part of the public or protected api put qualifiers in parenthesis after the annotation for example to qualify that something is read only use public read only this indicates that the given property and its value should not be changed by outside code e g a property should not have its value changed to qualify that something is public to a specific repository use for example public scenery internal for something made public solely for use public for something made public solely for phet io use public phet io separate multiple qualifiers with commas for example public scenery internal read only for jsdoc style comments the annotation should appear in context like this js creates the icon for the energy screen a cartoonish bar graph returns node public for line comments the annotation can appear like this js public function listener function adds a listener addlistener function listener verify that every javascript property and function has a visibility annotation here are some helpful regular expressions to search for these declarations as phet uses them regex for property assignment like x y something s regex for function declarations function math libraries dot utils tofixed or dot utils tofixednumber should be used instead of tofixed javascript s tofixed is notoriously buggy behavior differs depending on browser because the spec doesn t specify whether to round or floor ie is no longer supported with that in mind remove ie specific workarounds organization readability and maintainability does the organization and structure of the code make sense do the model and view contain types that you would expect or guess by looking at the sim do the names of things correspond to the names that you see in the user interface are appropriate design patterns used see if new or inappropriate patterns are identified create an issue is inheritance used where appropriate does the type hierarchy make sense is composition favored over inheritance where appropriate see is there any unnecessary coupling e g by passing large objects to constructors or exposing unnecessary properties functions is there too much unnecessary decoupling e g by passing all of the properties of an object independently instead of passing the object itself are the source files reasonable in size scrutinize large files with too many responsibilities can responsibilities be broken into smaller delegates are any significant chunks of code duplicated this will be checked manually as well as with or grunt find duplicates is there anything that should be generalized and migrated to common code are there any todo or fixme or review comments in the code they should be addressed or promoted to github issues are there any that should be factored out as constants and documented are there any constants that are duplicated in multiple files that should be factored out into a repo constants js file does the implementation rely on any specific constant values that are likely to change in the future identify constants that might be changed in the future use your judgement about which constants are likely candidates does changing the values of these constants break the sim for example see is used where appropriate verify that the sim is not inventing creating its own colors for things that have been standardized in phetcolorscheme identify any colors that might be worth adding to phetcolorscheme are all dependent properties modeled as derivedproperty instead of property all dynamics should be called from sim step dt do not use window settimeout or window setinterval this will help support legends of learning and phet io accessibility this section may be omitted if the sim has not been instrumented for does the sim pass an accessibility fuzz test run with query parameters fuzzboard ea run the accessible html through an does the html pass are accessibility features integrated well into the code they should be added in a maintainable way even if that requires upfront refactoring are accessible design patterns used see does resetting the simulation also reset the entire pdom is node accessibleorder used appropriately to maintain visual and pdom layout balance make sure accessibility strings aren t being adjusted with ascii specific javascript methods like touppercase remember that one day these strings will be translatable make sure for accessibility strings that all end of sentence periods do not have a leading space before it some screen readers will read these as dot this can occur often when a clause is conditionally added phet io this section may be omitted if the sim has not been instrumented for phet io does instrumentation follow the conventions described in this could be an extensive bullet at the very least be sure to know what amount of instrumentation this sim supports describing this further goes beyond the scope of this document phet io instantiates different objects and wires up listeners that are not present in the phet branded simulation it needs to be tested separately for memory leaks to help isolate the nature of the memory leak this test should be run separately from the phet brand memory leak test test with a colorized data stream and studio easily accessed from phetmarks compare to testing results done by the responsible developer and previous releases make sure unused phetioobject instances are disposed which unregisters their tandems make sure joist dt values are used instead of date now or other date functions perhaps try phet joist elapsedtime though this has already been mentioned it is necessary for reproducible playback via input events and deserves a comment in this phet io section are random numbers using phet joist random and all doing so after modules are declared non statically for example the following methods and perhaps others should not be used math random shuffle sample random this also deserves re iteration due to its effect on record playback for phet io like json keys for undefined values are omitted when serializing objects across frames consider this when determining whether tostateobject should use null or undefined values phet prefers to use the term position to refer to the physical x y position of objects this applies to both brands but is more important for the phet io api see
| 0
|
129,092
| 27,394,347,713
|
IssuesEvent
|
2023-02-28 18:28:24
|
appsmithorg/appsmith
|
https://api.github.com/repos/appsmithorg/appsmith
|
closed
|
[Bug]: JSObjects | Sync methods | Not run consistently when Page is cloned
|
Bug Needs Triaging JS Objects FE Coders Pod
|
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Description
https://user-images.githubusercontent.com/91450662/220246222-e7e51a81-c78a-4bea-af88-ee39e89562ef.mov
### Steps To Reproduce
1. D&D a Input Widget & map it to JSObject sync method
2. Clone the Page
3. **Observe JS sync method is run on alternate times**
4. **Expected: JS Object sync method should run all the time successfully**
### Public Sample App
_No response_
### Issue video log
_No response_
### Version
Cloud/Release v1.9.8
|
1.0
|
[Bug]: JSObjects | Sync methods | Not run consistently when Page is cloned - ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Description
https://user-images.githubusercontent.com/91450662/220246222-e7e51a81-c78a-4bea-af88-ee39e89562ef.mov
### Steps To Reproduce
1. D&D a Input Widget & map it to JSObject sync method
2. Clone the Page
3. **Observe JS sync method is run on alternate times**
4. **Expected: JS Object sync method should run all the time successfully**
### Public Sample App
_No response_
### Issue video log
_No response_
### Version
Cloud/Release v1.9.8
|
non_design
|
jsobjects sync methods not run consistently when page is cloned is there an existing issue for this i have searched the existing issues description steps to reproduce d d a input widget map it to jsobject sync method clone the page observe js sync method is run on alternate times expected js object sync method should run all the time successfully public sample app no response issue video log no response version cloud release
| 0
|
116,203
| 14,933,516,553
|
IssuesEvent
|
2021-01-25 09:19:25
|
hazelcast/frontend-shared
|
https://api.github.com/repos/hazelcast/frontend-shared
|
closed
|
[UI core library] IconButton
|
design
|
@pawelklasa could you paste here a link to the design once it is ready? Assigning it to you for now
We need states for:
- default
- focused
- hovered
- active
- disabled
|
1.0
|
[UI core library] IconButton - @pawelklasa could you paste here a link to the design once it is ready? Assigning it to you for now
We need states for:
- default
- focused
- hovered
- active
- disabled
|
design
|
iconbutton pawelklasa could you paste here a link to the design once it is ready assigning it to you for now we need states for default focused hovered active disabled
| 1
|
766,850
| 26,901,706,906
|
IssuesEvent
|
2023-02-06 16:04:28
|
status-im/status-desktop
|
https://api.github.com/repos/status-im/status-desktop
|
closed
|
Chat: Message history in db not displayed in UI after restart
|
bug Chat priority 1: high E:Bugfixes
|
# Bug Report
## Description
Occasionally on restart 1 or more chats will load without history. For example, for the UI Team chat 1717 messages are shown in the database but only the last one loaded in the UI.
## Steps to reproduce
Restart 0.10.0 RC3 and evaluate chats known to have history.
#### Expected behavior
Message history available in the db loads
#### Actual behavior
Message history does not load and 1 or more restarts is required to access it.
### Additional Information
- Status desktop version: 0.10RC3
- Operating System: Mac
|
1.0
|
Chat: Message history in db not displayed in UI after restart - # Bug Report
## Description
Occasionally on restart 1 or more chats will load without history. For example, for the UI Team chat 1717 messages are shown in the database but only the last one loaded in the UI.
## Steps to reproduce
Restart 0.10.0 RC3 and evaluate chats known to have history.
#### Expected behavior
Message history available in the db loads
#### Actual behavior
Message history does not load and 1 or more restarts is required to access it.
### Additional Information
- Status desktop version: 0.10RC3
- Operating System: Mac
|
non_design
|
chat message history in db not displayed in ui after restart bug report description occasionally on restart or more chats will load without history for example for the ui team chat messages are shown in the database but only the last one loaded in the ui steps to reproduce restart and evaluate chats known to have history expected behavior message history available in the db loads actual behavior message history does not load and or more restarts is required to access it additional information status desktop version operating system mac
| 0
|
62,946
| 7,659,173,820
|
IssuesEvent
|
2018-05-11 04:51:01
|
christopherdavis1/Wavefully
|
https://api.github.com/repos/christopherdavis1/Wavefully
|
opened
|
Add the wave animation
|
new design
|
LOTTIEEEEEEEEEEE, boy!
**_Note:_** This feature may need more design work as well.
|
1.0
|
Add the wave animation - LOTTIEEEEEEEEEEE, boy!
**_Note:_** This feature may need more design work as well.
|
design
|
add the wave animation lottieeeeeeeeeee boy note this feature may need more design work as well
| 1
|
430,939
| 12,468,137,033
|
IssuesEvent
|
2020-05-28 18:18:43
|
reactioncommerce/reaction
|
https://api.github.com/repos/reactioncommerce/reaction
|
closed
|
flatRateFulfillmentMethods graphql query does not match the shipping schema
|
bug help wanted priority medium severity medium verified reproducible
|
<!--
Issue tracker is **ONLY** used for reporting bugs. NO NEW FEATURE REQUESTS ACCEPTED. For new features, add an issue in our [Request Feature Request](https://github.com/reactioncommerce/reaction-feature-requests) repository.
Are you looking for help with getting started on Reaction? Please visit our [Reaction documentation](https://docs.reactioncommerce.com/reaction-docs/trunk/getting-started-developing-with-reaction).
Prerequisites
* [ ] Are you running the latest version?
* [ ] Are you able to consistently reproduce the issue?
* [ ] Did you search the issue queue for existing issue? [Search issues](https://github.com/reactioncommerce/reaction/issues)
-->
## Issue Description
<!--
Providing a clear description of the issue will enable a developer to quickly reproduce and understand the issue. Please provide a detailed description including images, animation and/or videos. For client issues, include browser console errors, for server issues please add terminal output and stac
<img width="270" alt="Screenshot 2020-04-29 at 1 33 01 PM" src="https://user-images.githubusercontent.com/58454138/80563572-f65a0200-8a1d-11ea-84b9-971384b23f80.png">
k traces.
-->
<img width="839" alt="Screenshot 2020-04-29 at 1 34 41 PM" src="https://user-images.githubusercontent.com/58454138/80563642-302b0880-8a1e-11ea-9f2f-456c7ab8b55a.png">
## Possible Solution
<!--
Not obligatory, but suggest a fix/reason for the bug
-->
change the schema of graphql ? or mongo ?
### Versions
<!--
(run `npm run version --silent` from your reaction directory)
-->
3.4.0
|
1.0
|
flatRateFulfillmentMethods graphql query does not match the shipping schema - <!--
Issue tracker is **ONLY** used for reporting bugs. NO NEW FEATURE REQUESTS ACCEPTED. For new features, add an issue in our [Request Feature Request](https://github.com/reactioncommerce/reaction-feature-requests) repository.
Are you looking for help with getting started on Reaction? Please visit our [Reaction documentation](https://docs.reactioncommerce.com/reaction-docs/trunk/getting-started-developing-with-reaction).
Prerequisites
* [ ] Are you running the latest version?
* [ ] Are you able to consistently reproduce the issue?
* [ ] Did you search the issue queue for existing issue? [Search issues](https://github.com/reactioncommerce/reaction/issues)
-->
## Issue Description
<!--
Providing a clear description of the issue will enable a developer to quickly reproduce and understand the issue. Please provide a detailed description including images, animation and/or videos. For client issues, include browser console errors, for server issues please add terminal output and stac
<img width="270" alt="Screenshot 2020-04-29 at 1 33 01 PM" src="https://user-images.githubusercontent.com/58454138/80563572-f65a0200-8a1d-11ea-84b9-971384b23f80.png">
k traces.
-->
<img width="839" alt="Screenshot 2020-04-29 at 1 34 41 PM" src="https://user-images.githubusercontent.com/58454138/80563642-302b0880-8a1e-11ea-9f2f-456c7ab8b55a.png">
## Possible Solution
<!--
Not obligatory, but suggest a fix/reason for the bug
-->
change the schema of graphql ? or mongo ?
### Versions
<!--
(run `npm run version --silent` from your reaction directory)
-->
3.4.0
|
non_design
|
flatratefulfillmentmethods graphql query does not match the shipping schema issue tracker is only used for reporting bugs no new feature requests accepted for new features add an issue in our repository are you looking for help with getting started on reaction please visit our prerequisites are you running the latest version are you able to consistently reproduce the issue did you search the issue queue for existing issue issue description providing a clear description of the issue will enable a developer to quickly reproduce and understand the issue please provide a detailed description including images animation and or videos for client issues include browser console errors for server issues please add terminal output and stac img width alt screenshot at pm src k traces img width alt screenshot at pm src possible solution not obligatory but suggest a fix reason for the bug change the schema of graphql or mongo versions run npm run version silent from your reaction directory
| 0
|
142,499
| 21,778,257,509
|
IssuesEvent
|
2022-05-13 15:49:39
|
CMSgov/eAPD
|
https://api.github.com/repos/CMSgov/eAPD
|
closed
|
Document all example boxes in system
|
design Small
|
We should go ahead and document all the example boxes, in context, that are in the system.
It should be determined if the content contained within is actually an example, or if it's help text.
This would be in preparation for a content review of the example boxes where we would determine if we'd move the help text elsewhere, reduce the help text, create an example if it's really needed, or leave the example as is if it's the correct information.
In this stage, we would also determine if we wanted to use something standard from the design system as the example box, vs the custom box that appears now.
### This task is done when...
- [x] A page is created in Figma that documents all of the example boxes and whether they are examples or help text
- [x] A new task is written to represent the content work that will be needed (to be prioritized after the release training and comms have been completed - including officers hours and FAQ)
|
1.0
|
Document all example boxes in system - We should go ahead and document all the example boxes, in context, that are in the system.
It should be determined if the content contained within is actually an example, or if it's help text.
This would be in preparation for a content review of the example boxes where we would determine if we'd move the help text elsewhere, reduce the help text, create an example if it's really needed, or leave the example as is if it's the correct information.
In this stage, we would also determine if we wanted to use something standard from the design system as the example box, vs the custom box that appears now.
### This task is done when...
- [x] A page is created in Figma that documents all of the example boxes and whether they are examples or help text
- [x] A new task is written to represent the content work that will be needed (to be prioritized after the release training and comms have been completed - including officers hours and FAQ)
|
design
|
document all example boxes in system we should go ahead and document all the example boxes in context that are in the system it should be determined if the content contained within is actually an example or if it s help text this would be in preparation for a content review of the example boxes where we would determine if we d move the help text elsewhere reduce the help text create an example if it s really needed or leave the example as is if it s the correct information in this stage we would also determine if we wanted to use something standard from the design system as the example box vs the custom box that appears now this task is done when a page is created in figma that documents all of the example boxes and whether they are examples or help text a new task is written to represent the content work that will be needed to be prioritized after the release training and comms have been completed including officers hours and faq
| 1
|
40,292
| 5,198,872,389
|
IssuesEvent
|
2017-01-23 19:19:58
|
brave/browser-laptop
|
https://api.github.com/repos/brave/browser-laptop
|
closed
|
Separate input and select styles using Aphrodite
|
design refactoring/aphrodite
|
The goal for this issue would be to separate input and select styles (which are currently coupled together). [Per our style guidelines](https://github.com/brave/browser-laptop/blob/master/docs/style.md), solving this issue would involve rolling the input and select elements into an Aphrodite component.
- [x] Text entry field (editable)
- [x] Text entry field (focus outline)
- [x] Text entry field (locked/fixed value)
- [x] drop-down menu style
- [x] preferred drop down arrow style
- [x] flatten out the orange button
- [x] update about:styles
Here are some spec images:
## Text entry field (editable)
## Text entry field (focus outline)
(use a 2 px radius, and "@statsBlue: #0796fa;")
## Text entry field (locked/fixed value)
(use variable color for fill: @veryLightGray: rgb(250, 250, 250); )
## drop-down menu style
## preferred drop down arrow style
We can switch to a different FA triangle
## and this will flatten out the orange button
|
1.0
|
Separate input and select styles using Aphrodite - The goal for this issue would be to separate input and select styles (which are currently coupled together). [Per our style guidelines](https://github.com/brave/browser-laptop/blob/master/docs/style.md), solving this issue would involve rolling the input and select elements into an Aphrodite component.
- [x] Text entry field (editable)
- [x] Text entry field (focus outline)
- [x] Text entry field (locked/fixed value)
- [x] drop-down menu style
- [x] preferred drop down arrow style
- [x] flatten out the orange button
- [x] update about:styles
Here are some spec images:
## Text entry field (editable)
## Text entry field (focus outline)
(use a 2 px radius, and "@statsBlue: #0796fa;")
## Text entry field (locked/fixed value)
(use variable color for fill: @veryLightGray: rgb(250, 250, 250); )
## drop-down menu style
## preferred drop down arrow style
We can switch to a different FA triangle
## and this will flatten out the orange button
|
design
|
separate input and select styles using aphrodite the goal for this issue would be to separate input and select styles which are currently coupled together solving this issue would involve rolling the input and select elements into an aphrodite component text entry field editable text entry field focus outline text entry field locked fixed value drop down menu style preferred drop down arrow style flatten out the orange button update about styles here are some spec images text entry field editable text entry field focus outline use a px radius and statsblue text entry field locked fixed value use variable color for fill verylightgray rgb drop down menu style preferred drop down arrow style we can switch to a different fa triangle and this will flatten out the orange button
| 1
|
211,241
| 7,199,548,950
|
IssuesEvent
|
2018-02-05 16:15:49
|
opencollective/opencollective
|
https://api.github.com/repos/opencollective/opencollective
|
closed
|
user is getting json error when creating a collective
|
bug priority
|
from opencollective.com/apply
choosing 'movement' 'open source' or 'other'
browsers
firefox 58.0.1 (64-bit)
Chrome
|
1.0
|
user is getting json error when creating a collective - from opencollective.com/apply
choosing 'movement' 'open source' or 'other'
browsers
firefox 58.0.1 (64-bit)
Chrome
|
non_design
|
user is getting json error when creating a collective from opencollective com apply choosing movement open source or other browsers firefox bit chrome
| 0
|
273,155
| 20,774,456,764
|
IssuesEvent
|
2022-03-16 09:11:23
|
jasonivey/mmotd
|
https://api.github.com/repos/jasonivey/mmotd
|
opened
|
Add instructions for making changes to the Output Template
|
documentation feature: extension
|
Create two more working Output Template `json` files within the `config` directory.
* One which will produce output (almost) identical to what `neofetch` produces.
* The second `json` file should be able to produce output (almost) identical to what `screenFetch` produces.
This will be done in hopes that it makes the transition to `mmod` even easier and provide an opportunity to dig into the Output Template `json` file
|
1.0
|
Add instructions for making changes to the Output Template - Create two more working Output Template `json` files within the `config` directory.
* One which will produce output (almost) identical to what `neofetch` produces.
* The second `json` file should be able to produce output (almost) identical to what `screenFetch` produces.
This will be done in hopes that it makes the transition to `mmod` even easier and provide an opportunity to dig into the Output Template `json` file
|
non_design
|
add instructions for making changes to the output template create two more working output template json files within the config directory one which will produce output almost identical to what neofetch produces the second json file should be able to produce output almost identical to what screenfetch produces this will be done in hopes that it makes the transition to mmod even easier and provide an opportunity to dig into the output template json file
| 0
|
137,370
| 20,119,295,515
|
IssuesEvent
|
2022-02-07 23:27:31
|
FreeCAD/FreeCAD
|
https://api.github.com/repos/FreeCAD/FreeCAD
|
closed
|
PartDesign Hole Depth Dimension should provide the option not to take the angled drill point type into account
|
🚜 PartDesign Feature
|
Issue imported from https://tracker.freecad.org/view.php?id=3818
* **Reporter:** LAROBERTE
* **Date submitted:** 2/5/2019
* **FreeCAD version:** 0.18
* **Category:** Feature
* **Status:** resolved
* **Tags:**
# Original report text
In the PartDesign Hole feature, the Depth Dimension option controls the overall depth of a blind hole. When the Drill point option is set to Angled, the dimension includes the conical end point generated by the Angled drill point option.
There should be an option to set the depth dimension so that it does not include the conical end point, to comply with some standards.
http://euro.branly.free.fr/ISI/Construction/Dessin/filet/filets.htm
http://joho.p.free.fr/EC/COURS%20DOC/FILETAGE/REPRESENTATION/Cotation%20des%20filetages.pdf
# Other bug information
* **Priority:** normal
* **Severity:** minor
* **Category:** Feature
* **Updated:** 2/6/2021
# Discussion from Mantis ticket
### Comment by Kunda1 2019-02-06 03:00
LAROBERTE Did you mean Path Workbench ?
Have you opened a forum thread to discuss this ? (per our guidelines at the top of the page)
CC sliptonic
---
### Comment by LAROBERTE 2019-02-06 08:18
Hello
I do not speak English, it is very difficult for me to open and follow a discussion, I am obliged to translate everything, it is long and tedious.
I looked in the forum if someone was talking about it, but I did not find anything.
The problem is not a bug, but rather an error in the standards of rating, surely very easy to solve, that's why I intervened.
---
### Comment by Kunda1 2019-02-08 21:48
mlampert care to weigh in ?
---
### Comment by mlampert 2019-02-08 22:14
I have never seen this dialog before - where does it come from?
---
### Comment by Kunda1 2019-02-10 00:46
LAROBERTE please provide instructions on how to reproduce the bug
---
### Comment by LAROBERTE 2019-02-10 05:16
Ok
I take care of it, but I do not work until Tuesday
thank you for considering my post.
---
### Comment by normandc 2019-02-10 19:02
Bug was wrongly reported in "FreeCAD (all projects)" instead of PartDesign.
Changed bug severity from major to minor.
I cannot reproduce the issue. For me, if I set the hole depth to 10mm with angled drill point, the 10mm value includes the drill point. Please provide your FreeCAD info as explained in the enormous yellow banner that you could not possibly miss.
I'm switching this report's status to feedback required.
OS: Ubuntu 18.04.2 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15816 (Git)
Build type: Release
Branch: master
Hash: 7ee0e4d43909ec688299b8498b240cccf8362c47
Python version: 2.7.15rc1
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/Canada (fr_CA)
---
### Comment by normandc 2019-02-10 19:05
Okay, I think I understand the issue now. You actually want the hole depth NOT TO take the conical end into account.
This would be a feature request then, because in commercial software I use, both possibilities are offered (depth with or without the conical drill point).
---
### Comment by LAROBERTE 2019-02-10 22:41
hello, the downhole cone should never be included in the hole depth, it is only the consequence of the shape of the drill bit. The depth of a hole should take into account only the part with the correct diameter. see the two links of my first post.
if you want to add a feature, you should be able to choose the thread depth and drilling depth. Drilling and always deeper than the threading so as not to break the tools. the angle of the drilling cone is 120 degrees, the angle of the thread is 90 degrees. I do not have freecad until Tuesday, I promise you to make a correct post as soon as possible.
it's not very important for 3D printing, but it's very important for mechanical machining
---
### Comment by normandc 2019-02-10 23:51
[quote=LAROBERTE]the downhole cone should never be included in the hole depth[/quote]
I disagree. At work, plenty of time I really, really needed to define the total depth of a blind hole including the drill tip, so it would not punch through the material or would leave minimal thickness. Doing it your way would require guesswork or calculation.
As I said, Solid Edge (a commercial mid-range CAD package) offers ***both*** options. FreeCAD should do the same.
Your other arguments about thread depth and drilling depth are of course to the point. But the Hole feature cannot currently display a modelled thread, and the TechDraw workbench cannot extract hole information nor display it; so implementing this at this time would not really be useful. With 0.18 nearing release I doubt that we will see this implemented before release, which is why I set the target version to 0.19. Unfortunately, there is no longer a developer dedicated to the PartDesign workbench.
---
### Comment by LAROBERTE 2019-02-11 01:13
I agree with you, which is why my first post did not mention a request to add a function. I know that Freecad is evolving, but in the current state of things, the most important is the useful depth of the hole, which is the current standard in technical drawing. if you feel that the cone depth is half a diameter, you will have no problem and it is very easy with a 3D software to see if the cone of the bottom of the hole passes through.
Of course, if the drill cone is a problem, nothing prevents you from making a hole with a flat bottom with a suitable tool.
very cordially
---
### Comment by LAROBERTE 2019-02-12 17:21
Hello
For years, technicians have been working to develop international standards for technical drawing.
If you want freecad to become one of the software that can also be used by professionals, you have to respect them.
The Hole function of freecad is for the moment only the draft, I am sure, of a practical and complete intuitive function. You can add as many functions as you want, but basic functions and their default values must comply with existing standards.
I am willing to participate on a forum to help develop Freecad, this particular function, but I opened this post only to correct this glaring error which will only cause the development of other functions or options for the materialization of the threads of freecad.
I'm not sure if the translation is understandable, I'm really sorry I do not write English directly.
I leave attached sketches that will be more meaningful than me.
Very sincerely
OS: W10 lasted version or UBUNTU 18.10 with virtual box 5.2.26 r128414 (Qt5.6.2)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15806 (Git) or 0.17
Build type: Release
Locale: French/Fr
---
### Comment by LAROBERTE 2019-02-14 14:05
thank you
---
### Comment by uwestoehr 2020-12-01 13:29
Thanks for the report. We are currently fixing all known hole dialog issues, see this forum thread: https://forum.freecadweb.org/viewtopic.php?p=453371#p453371
Should your requested option be the default or not?
---
### Comment by Kunda1 2020-12-03 18:40
LAROBERTE please reply
---
### Comment by uwestoehr 2020-12-13 01:22
> Should your requested option be the default or not?
I checked and asked colleagues, it is indeed the common rule not to take the drill angle into account. Here are some more documents stating the same as the French ones the bug reporter linked:
https://www.technisches-zeichnen.net/technisches-zeichnen/grundkurs-03/gewinde-bemassen.php
https://www.joshuanava.biz/engineering-3/draughting-conventions-associated-with-threads.html
So I will add this option and make it default.
---
### Comment by uwestoehr 2020-12-13 05:21
> So I will add this option and make it default.
Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/4134
---
### Comment by uwestoehr 2021-01-31 00:43
Fixed: commit 7306ed28 ; PR https://github.com/FreeCAD/FreeCAD/pull/4134
|
1.0
|
PartDesign Hole Depth Dimension should provide the option not to take the angled drill point type into account - Issue imported from https://tracker.freecad.org/view.php?id=3818
* **Reporter:** LAROBERTE
* **Date submitted:** 2/5/2019
* **FreeCAD version:** 0.18
* **Category:** Feature
* **Status:** resolved
* **Tags:**
# Original report text
In the PartDesign Hole feature, the Depth Dimension option controls the overall depth of a blind hole. When the Drill point option is set to Angled, the dimension includes the conical end point generated by the Angled drill point option.
There should be an option to set the depth dimension so that it does not include the conical end point, to comply with some standards.
http://euro.branly.free.fr/ISI/Construction/Dessin/filet/filets.htm
http://joho.p.free.fr/EC/COURS%20DOC/FILETAGE/REPRESENTATION/Cotation%20des%20filetages.pdf
# Other bug information
* **Priority:** normal
* **Severity:** minor
* **Category:** Feature
* **Updated:** 2/6/2021
# Discussion from Mantis ticket
### Comment by Kunda1 2019-02-06 03:00
LAROBERTE Did you mean Path Workbench ?
Have you opened a forum thread to discuss this ? (per our guidelines at the top of the page)
CC sliptonic
---
### Comment by LAROBERTE 2019-02-06 08:18
Hello
I do not speak English, it is very difficult for me to open and follow a discussion, I am obliged to translate everything, it is long and tedious.
I looked in the forum if someone was talking about it, but I did not find anything.
The problem is not a bug, but rather an error in the standards of rating, surely very easy to solve, that's why I intervened.
---
### Comment by Kunda1 2019-02-08 21:48
mlampert care to weigh in ?
---
### Comment by mlampert 2019-02-08 22:14
I have never seen this dialog before - where does it come from?
---
### Comment by Kunda1 2019-02-10 00:46
LAROBERTE please provide instructions on how to reproduce the bug
---
### Comment by LAROBERTE 2019-02-10 05:16
Ok
I take care of it, but I do not work until Tuesday
thank you for considering my post.
---
### Comment by normandc 2019-02-10 19:02
Bug was wrongly reported in "FreeCAD (all projects)" instead of PartDesign.
Changed bug severity from major to minor.
I cannot reproduce the issue. For me, if I set the hole depth to 10mm with angled drill point, the 10mm value includes the drill point. Please provide your FreeCAD info as explained in the enormous yellow banner that you could not possibly miss.
I'm switching this report's status to feedback required.
OS: Ubuntu 18.04.2 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15816 (Git)
Build type: Release
Branch: master
Hash: 7ee0e4d43909ec688299b8498b240cccf8362c47
Python version: 2.7.15rc1
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/Canada (fr_CA)
---
### Comment by normandc 2019-02-10 19:05
Okay, I think I understand the issue now. You actually want the hole depth NOT TO take the conical end into account.
This would be a feature request then, because in commercial software I use, both possibilities are offered (depth with or without the conical drill point).
---
### Comment by LAROBERTE 2019-02-10 22:41
hello, the downhole cone should never be included in the hole depth, it is only the consequence of the shape of the drill bit. The depth of a hole should take into account only the part with the correct diameter. see the two links of my first post.
if you want to add a feature, you should be able to choose the thread depth and drilling depth. Drilling and always deeper than the threading so as not to break the tools. the angle of the drilling cone is 120 degrees, the angle of the thread is 90 degrees. I do not have freecad until Tuesday, I promise you to make a correct post as soon as possible.
it's not very important for 3D printing, but it's very important for mechanical machining
---
### Comment by normandc 2019-02-10 23:51
[quote=LAROBERTE]the downhole cone should never be included in the hole depth[/quote]
I disagree. At work, plenty of time I really, really needed to define the total depth of a blind hole including the drill tip, so it would not punch through the material or would leave minimal thickness. Doing it your way would require guesswork or calculation.
As I said, Solid Edge (a commercial mid-range CAD package) offers ***both*** options. FreeCAD should do the same.
Your other arguments about thread depth and drilling depth are of course to the point. But the Hole feature cannot currently display a modelled thread, and the TechDraw workbench cannot extract hole information nor display it; so implementing this at this time would not really be useful. With 0.18 nearing release I doubt that we will see this implemented before release, which is why I set the target version to 0.19. Unfortunately, there is no longer a developer dedicated to the PartDesign workbench.
---
### Comment by LAROBERTE 2019-02-11 01:13
I agree with you, which is why my first post did not mention a request to add a function. I know that Freecad is evolving, but in the current state of things, the most important is the useful depth of the hole, which is the current standard in technical drawing. if you feel that the cone depth is half a diameter, you will have no problem and it is very easy with a 3D software to see if the cone of the bottom of the hole passes through.
Of course, if the drill cone is a problem, nothing prevents you from making a hole with a flat bottom with a suitable tool.
very cordially
---
### Comment by LAROBERTE 2019-02-12 17:21
Hello
For years, technicians have been working to develop international standards for technical drawing.
If you want freecad to become one of the software that can also be used by professionals, you have to respect them.
The Hole function of freecad is for the moment only the draft, I am sure, of a practical and complete intuitive function. You can add as many functions as you want, but basic functions and their default values must comply with existing standards.
I am willing to participate on a forum to help develop Freecad, this particular function, but I opened this post only to correct this glaring error which will only cause the development of other functions or options for the materialization of the threads of freecad.
I'm not sure if the translation is understandable, I'm really sorry I do not write English directly.
I leave attached sketches that will be more meaningful than me.
Very sincerely
OS: W10 lasted version or UBUNTU 18.10 with virtual box 5.2.26 r128414 (Qt5.6.2)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15806 (Git) or 0.17
Build type: Release
Locale: French/Fr
---
### Comment by LAROBERTE 2019-02-14 14:05
thank you
---
### Comment by uwestoehr 2020-12-01 13:29
Thanks for the report. We are currently fixing all known hole dialog issues, see this forum thread: https://forum.freecadweb.org/viewtopic.php?p=453371#p453371
Should your requested option be the default or not?
---
### Comment by Kunda1 2020-12-03 18:40
LAROBERTE please reply
---
### Comment by uwestoehr 2020-12-13 01:22
> Should your requested option be the default or not?
I checked and asked colleagues, it is indeed the common rule not to take the drill angle into account. Here are some more documents stating the same as the French ones the bug reporter linked:
https://www.technisches-zeichnen.net/technisches-zeichnen/grundkurs-03/gewinde-bemassen.php
https://www.joshuanava.biz/engineering-3/draughting-conventions-associated-with-threads.html
So I will add this option and make it default.
---
### Comment by uwestoehr 2020-12-13 05:21
> So I will add this option and make it default.
Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/4134
---
### Comment by uwestoehr 2021-01-31 00:43
Fixed: commit 7306ed28 ; PR https://github.com/FreeCAD/FreeCAD/pull/4134
|
design
|
partdesign hole depth dimension should provide the option not to take the angled drill point type into account issue imported from reporter laroberte date submitted freecad version category feature status resolved tags original report text in the partdesign hole feature the depth dimension option controls the overall depth of a blind hole when the drill point option is set to angled the dimension includes the conical end point generated by the angled drill point option there should be an option to set the depth dimension so that it does not include the conical end point to comply with some standards other bug information priority normal severity minor category feature updated discussion from mantis ticket comment by laroberte did you mean path workbench have you opened a forum thread to discuss this per our guidelines at the top of the page cc sliptonic comment by laroberte hello i do not speak english it is very difficult for me to open and follow a discussion i am obliged to translate everything it is long and tedious i looked in the forum if someone was talking about it but i did not find anything the problem is not a bug but rather an error in the standards of rating surely very easy to solve that s why i intervened comment by mlampert care to weigh in comment by mlampert i have never seen this dialog before where does it come from comment by laroberte please provide instructions on how to reproduce the bug comment by laroberte ok i take care of it but i do not work until tuesday thank you for considering my post comment by normandc bug was wrongly reported in freecad all projects instead of partdesign changed bug severity from major to minor i cannot reproduce the issue for me if i set the hole depth to with angled drill point the value includes the drill point please provide your freecad info as explained in the enormous yellow banner that you could not possibly miss i m switching this report s status to feedback required os ubuntu lts word size of os bit word size of freecad bit version git build type release branch master hash python version qt version coin version occ version locale french canada fr ca comment by normandc okay i think i understand the issue now you actually want the hole depth not to take the conical end into account this would be a feature request then because in commercial software i use both possibilities are offered depth with or without the conical drill point comment by laroberte hello the downhole cone should never be included in the hole depth it is only the consequence of the shape of the drill bit the depth of a hole should take into account only the part with the correct diameter see the two links of my first post if you want to add a feature you should be able to choose the thread depth and drilling depth drilling and always deeper than the threading so as not to break the tools the angle of the drilling cone is degrees the angle of the thread is degrees i do not have freecad until tuesday i promise you to make a correct post as soon as possible it s not very important for printing but it s very important for mechanical machining comment by normandc the downhole cone should never be included in the hole depth i disagree at work plenty of time i really really needed to define the total depth of a blind hole including the drill tip so it would not punch through the material or would leave minimal thickness doing it your way would require guesswork or calculation as i said solid edge a commercial mid range cad package offers both options freecad should do the same your other arguments about thread depth and drilling depth are of course to the point but the hole feature cannot currently display a modelled thread and the techdraw workbench cannot extract hole information nor display it so implementing this at this time would not really be useful with nearing release i doubt that we will see this implemented before release which is why i set the target version to unfortunately there is no longer a developer dedicated to the partdesign workbench comment by laroberte i agree with you which is why my first post did not mention a request to add a function i know that freecad is evolving but in the current state of things the most important is the useful depth of the hole which is the current standard in technical drawing if you feel that the cone depth is half a diameter you will have no problem and it is very easy with a software to see if the cone of the bottom of the hole passes through of course if the drill cone is a problem nothing prevents you from making a hole with a flat bottom with a suitable tool very cordially comment by laroberte hello for years technicians have been working to develop international standards for technical drawing if you want freecad to become one of the software that can also be used by professionals you have to respect them the hole function of freecad is for the moment only the draft i am sure of a practical and complete intuitive function you can add as many functions as you want but basic functions and their default values must comply with existing standards i am willing to participate on a forum to help develop freecad this particular function but i opened this post only to correct this glaring error which will only cause the development of other functions or options for the materialization of the threads of freecad i m not sure if the translation is understandable i m really sorry i do not write english directly i leave attached sketches that will be more meaningful than me very sincerely os lasted version or ubuntu with virtual box word size of os bit word size of freecad bit version git or build type release locale french fr comment by laroberte thank you comment by uwestoehr thanks for the report we are currently fixing all known hole dialog issues see this forum thread should your requested option be the default or not comment by laroberte please reply comment by uwestoehr should your requested option be the default or not i checked and asked colleagues it is indeed the common rule not to take the drill angle into account here are some more documents stating the same as the french ones the bug reporter linked so i will add this option and make it default comment by uwestoehr so i will add this option and make it default here is the pr comment by uwestoehr fixed commit pr
| 1
|
57,755
| 7,094,187,610
|
IssuesEvent
|
2018-01-13 00:27:45
|
adamdriscoll/poshprotools
|
https://api.github.com/repos/adamdriscoll/poshprotools
|
closed
|
MaskedTextBox Error
|
bug forms-designer
|
> when I set the PasswordChar property to * the code behind throws an error. If add ‘*’ in the code behind it is good till it rebuilds.
|
1.0
|
MaskedTextBox Error - > when I set the PasswordChar property to * the code behind throws an error. If add ‘*’ in the code behind it is good till it rebuilds.
|
design
|
maskedtextbox error when i set the passwordchar property to the code behind throws an error if add ‘ ’ in the code behind it is good till it rebuilds
| 1
|
575,086
| 17,023,922,617
|
IssuesEvent
|
2021-07-03 04:34:33
|
tomhughes/trac-tickets
|
https://api.github.com/repos/tomhughes/trac-tickets
|
closed
|
novice: ip banned 73.204.150.31
|
Component: nominatim Priority: trivial Resolution: fixed Type: task
|
**[Submitted to the original trac issue database at 6.16pm, Friday, 26th June 2015]**
Please unlock my ip. I didn't get a chance to put the sleep(1) in before I got banned. I am developing a program to geocode addresses and I am currently just testing.
ajonen@mailcan.com
|
1.0
|
novice: ip banned 73.204.150.31 - **[Submitted to the original trac issue database at 6.16pm, Friday, 26th June 2015]**
Please unlock my ip. I didn't get a chance to put the sleep(1) in before I got banned. I am developing a program to geocode addresses and I am currently just testing.
ajonen@mailcan.com
|
non_design
|
novice ip banned please unlock my ip i didn t get a chance to put the sleep in before i got banned i am developing a program to geocode addresses and i am currently just testing ajonen mailcan com
| 0
|
84,718
| 24,396,393,701
|
IssuesEvent
|
2022-10-04 19:41:23
|
ICPI/Engagements
|
https://api.github.com/repos/ICPI/Engagements
|
closed
|
ICPI Onboarding June 2022 Checklist
|
Type: Capacity Building
|
- [x] - Registration form closes 5/11
- [x] - Compile registration information and Leads review by 5/13 @kunnicak @HoustonJamie
- [x] - Leads finalize names (if needed) on 5/16 @HoustonJamie
- [x] - Finalize [agenda ](https://pepfar.sharepoint.com/:b:/r/sites/ICPI/Shared%20Documents/Trainings/ICPI%20Onboarding%20Training%20(June%202022)/Facilitator%20Materials/ICPI%20Onboarding%20Training_June%202022_Agenda.pdf?csf=1&web=1&e=95QukN)by 5/13 @kkale25
- [x] - Finalize confirmation email by 5/13 @kunnicak
- [x] - Hide HSS session from PVA by 5/17 @kunnicak @myang511
- [x] - F/u with HSS group for updated session content @HoustonJamie @KateWilkinsMPH
- [x] - Confirmation email to participants goes out on @5/17 @kunnicak to send
- [x] - Enroll attendees in PVA 5/17 @kunnicak @myang511
- [x] - Send out training save the dates to participants no later than 5/20 @kunnicak
- [x] - Send out invite for Kick-off meeting with ICPI staff for Wednesday 5/18 at 12PM EST @kunnicak
- [x] - Draft materials for Welcome Meeting + Kick off meeting @kkale25
- [x] - Send out Welcome Meeting invite to participants, ICPI Leads, and TC for Thursday 5/19 at 12PM EST @kunnicak
- [x] - Send out Tech Office Hours invite (proposing 1.5 hours) for Tuesday 5/31 at 8AM EST @kunnicak
- [x] - Send out session-specific save the dates for ICPI Staff no later than 5/20 @kunnicak
- [x] - Create sharepoint folder for training no later than 5/13 @kunnicak
- [x] - Get Run of Show links from TechChange before 5/18
- [x] - Run of Shows due 5/26 by POCs
- [ ] - TechChange to create link PDFs week of 5/30
- [x] - Do sharepoint link checks beforehand to make sure they all work week of 5/30 @HoustonJamie @kunnicak
- [x] - Update training surveys week of 5/30 @kkale25
|
1.0
|
ICPI Onboarding June 2022 Checklist - - [x] - Registration form closes 5/11
- [x] - Compile registration information and Leads review by 5/13 @kunnicak @HoustonJamie
- [x] - Leads finalize names (if needed) on 5/16 @HoustonJamie
- [x] - Finalize [agenda ](https://pepfar.sharepoint.com/:b:/r/sites/ICPI/Shared%20Documents/Trainings/ICPI%20Onboarding%20Training%20(June%202022)/Facilitator%20Materials/ICPI%20Onboarding%20Training_June%202022_Agenda.pdf?csf=1&web=1&e=95QukN)by 5/13 @kkale25
- [x] - Finalize confirmation email by 5/13 @kunnicak
- [x] - Hide HSS session from PVA by 5/17 @kunnicak @myang511
- [x] - F/u with HSS group for updated session content @HoustonJamie @KateWilkinsMPH
- [x] - Confirmation email to participants goes out on @5/17 @kunnicak to send
- [x] - Enroll attendees in PVA 5/17 @kunnicak @myang511
- [x] - Send out training save the dates to participants no later than 5/20 @kunnicak
- [x] - Send out invite for Kick-off meeting with ICPI staff for Wednesday 5/18 at 12PM EST @kunnicak
- [x] - Draft materials for Welcome Meeting + Kick off meeting @kkale25
- [x] - Send out Welcome Meeting invite to participants, ICPI Leads, and TC for Thursday 5/19 at 12PM EST @kunnicak
- [x] - Send out Tech Office Hours invite (proposing 1.5 hours) for Tuesday 5/31 at 8AM EST @kunnicak
- [x] - Send out session-specific save the dates for ICPI Staff no later than 5/20 @kunnicak
- [x] - Create sharepoint folder for training no later than 5/13 @kunnicak
- [x] - Get Run of Show links from TechChange before 5/18
- [x] - Run of Shows due 5/26 by POCs
- [ ] - TechChange to create link PDFs week of 5/30
- [x] - Do sharepoint link checks beforehand to make sure they all work week of 5/30 @HoustonJamie @kunnicak
- [x] - Update training surveys week of 5/30 @kkale25
|
non_design
|
icpi onboarding june checklist registration form closes compile registration information and leads review by kunnicak houstonjamie leads finalize names if needed on houstonjamie finalize finalize confirmation email by kunnicak hide hss session from pva by kunnicak f u with hss group for updated session content houstonjamie katewilkinsmph confirmation email to participants goes out on kunnicak to send enroll attendees in pva kunnicak send out training save the dates to participants no later than kunnicak send out invite for kick off meeting with icpi staff for wednesday at est kunnicak draft materials for welcome meeting kick off meeting send out welcome meeting invite to participants icpi leads and tc for thursday at est kunnicak send out tech office hours invite proposing hours for tuesday at est kunnicak send out session specific save the dates for icpi staff no later than kunnicak create sharepoint folder for training no later than kunnicak get run of show links from techchange before run of shows due by pocs techchange to create link pdfs week of do sharepoint link checks beforehand to make sure they all work week of houstonjamie kunnicak update training surveys week of
| 0
|
21,315
| 2,637,771,805
|
IssuesEvent
|
2015-03-10 15:10:35
|
NREL/EnergyPlus
|
https://api.github.com/repos/NREL/EnergyPlus
|
closed
|
FluidCooler:TwoSpeed fatal error with Low Speed Nominal Capacity=autocalculate
|
EnergyPlus Priority S1 - High
|
Helpdesk ticket 10205
FluidCooler:TwoSpeed but with a problem. It shows "Low Speed Nominal Capacity" input value is invalid (see below).
************* Beginning System Sizing Calculations
************* Beginning Plant Sizing Calculations
** Severe ** FluidCooler:TwoSpeed = "FLUID COOLER", invalid data for "Low Speed Nominal Capacity", entered value <= 0.0, but must be > 0 for Performance Input Method= "NOMINALCAPACITY".
** Fatal ** Errors found in getting fluid cooler input.
Checked the getinput routine and this error message needs to be skipped if the value is auotosize/autocalculate.
|
1.0
|
FluidCooler:TwoSpeed fatal error with Low Speed Nominal Capacity=autocalculate - Helpdesk ticket 10205
FluidCooler:TwoSpeed but with a problem. It shows "Low Speed Nominal Capacity" input value is invalid (see below).
************* Beginning System Sizing Calculations
************* Beginning Plant Sizing Calculations
** Severe ** FluidCooler:TwoSpeed = "FLUID COOLER", invalid data for "Low Speed Nominal Capacity", entered value <= 0.0, but must be > 0 for Performance Input Method= "NOMINALCAPACITY".
** Fatal ** Errors found in getting fluid cooler input.
Checked the getinput routine and this error message needs to be skipped if the value is auotosize/autocalculate.
|
non_design
|
fluidcooler twospeed fatal error with low speed nominal capacity autocalculate helpdesk ticket fluidcooler twospeed but with a problem it shows low speed nominal capacity input value is invalid see below beginning system sizing calculations beginning plant sizing calculations severe fluidcooler twospeed fluid cooler invalid data for low speed nominal capacity entered value for performance input method nominalcapacity fatal errors found in getting fluid cooler input checked the getinput routine and this error message needs to be skipped if the value is auotosize autocalculate
| 0
|
105,882
| 13,226,802,427
|
IssuesEvent
|
2020-08-18 01:05:53
|
jupytercalpoly/jupyterlab-tabular-data-editor
|
https://api.github.com/repos/jupytercalpoly/jupyterlab-tabular-data-editor
|
closed
|
Pointer cursor for ghost row/column
|
design
|
The cursor when hovering over a ghost row/column should be the pointer cursor. The resize handle cursor shouldn't appear over a ghost row/column.
|
1.0
|
Pointer cursor for ghost row/column - The cursor when hovering over a ghost row/column should be the pointer cursor. The resize handle cursor shouldn't appear over a ghost row/column.
|
design
|
pointer cursor for ghost row column the cursor when hovering over a ghost row column should be the pointer cursor the resize handle cursor shouldn t appear over a ghost row column
| 1
|
42,866
| 5,541,701,729
|
IssuesEvent
|
2017-03-22 13:32:00
|
weaveworks/scope
|
https://api.github.com/repos/weaveworks/scope
|
opened
|
Rotate dynamoDB tables to improve provisioned capacity utilisation
|
component/scope needs-design performance
|
As mentioned in weaveworks/service-conf#1157, the collector was being throttled at around ~100 capacity units even though 400 were provisioned. Apparently the likely cause of this that the table has grown so big it has split into many shards, and since we don't have perfect distribution of keys we are being throttled at a fraction of our provisioned capacity - this problem will keep getting worse. A possible solution is to rotate the table in a similar fashion to Cortex.
|
1.0
|
Rotate dynamoDB tables to improve provisioned capacity utilisation - As mentioned in weaveworks/service-conf#1157, the collector was being throttled at around ~100 capacity units even though 400 were provisioned. Apparently the likely cause of this that the table has grown so big it has split into many shards, and since we don't have perfect distribution of keys we are being throttled at a fraction of our provisioned capacity - this problem will keep getting worse. A possible solution is to rotate the table in a similar fashion to Cortex.
|
design
|
rotate dynamodb tables to improve provisioned capacity utilisation as mentioned in weaveworks service conf the collector was being throttled at around capacity units even though were provisioned apparently the likely cause of this that the table has grown so big it has split into many shards and since we don t have perfect distribution of keys we are being throttled at a fraction of our provisioned capacity this problem will keep getting worse a possible solution is to rotate the table in a similar fashion to cortex
| 1
|
626,222
| 19,804,087,359
|
IssuesEvent
|
2022-01-19 03:19:28
|
vincetiu8/zombie-game
|
https://api.github.com/repos/vincetiu8/zombie-game
|
closed
|
Make option for health bars to fade away
|
type/enhancement area/map size/xs priority/none
|
After #42 is finished, we should have an option on the health bar script to make it fade away if it hasn't taken damage in a while. Perhaps the fade can start a bit after the object last took damage. This will prevent screen clutter with health bars if we have a lot of damageable objects in one area. This feature should be optional though, and probably doesn't require its own subclass. Just a serialized boolean.
|
1.0
|
Make option for health bars to fade away - After #42 is finished, we should have an option on the health bar script to make it fade away if it hasn't taken damage in a while. Perhaps the fade can start a bit after the object last took damage. This will prevent screen clutter with health bars if we have a lot of damageable objects in one area. This feature should be optional though, and probably doesn't require its own subclass. Just a serialized boolean.
|
non_design
|
make option for health bars to fade away after is finished we should have an option on the health bar script to make it fade away if it hasn t taken damage in a while perhaps the fade can start a bit after the object last took damage this will prevent screen clutter with health bars if we have a lot of damageable objects in one area this feature should be optional though and probably doesn t require its own subclass just a serialized boolean
| 0
|
429,597
| 12,426,274,251
|
IssuesEvent
|
2020-05-24 20:20:48
|
mozilla/addons-code-manager
|
https://api.github.com/repos/mozilla/addons-code-manager
|
closed
|
Quick way to jump to the first file with changes
|
component: compare page priority: p3 state: stale type: feature
|
When looking at the compare view, it is great to see the manifest first to see what the add-on is about. My next step after is going to the first file with changes. Right now (and also in the old file viewer), I had to scroll all the way up, open all the folders on the way down to the first file with changes.
If there was a keyboard shortcut, or a button, or anything else that would allow me to jump to that first file, it would be great!
|
1.0
|
Quick way to jump to the first file with changes - When looking at the compare view, it is great to see the manifest first to see what the add-on is about. My next step after is going to the first file with changes. Right now (and also in the old file viewer), I had to scroll all the way up, open all the folders on the way down to the first file with changes.
If there was a keyboard shortcut, or a button, or anything else that would allow me to jump to that first file, it would be great!
|
non_design
|
quick way to jump to the first file with changes when looking at the compare view it is great to see the manifest first to see what the add on is about my next step after is going to the first file with changes right now and also in the old file viewer i had to scroll all the way up open all the folders on the way down to the first file with changes if there was a keyboard shortcut or a button or anything else that would allow me to jump to that first file it would be great
| 0
|
334,863
| 29,993,883,835
|
IssuesEvent
|
2023-06-26 02:40:28
|
apecloud/kubeblocks
|
https://api.github.com/repos/apecloud/kubeblocks
|
closed
|
[Improvement] refine kubeblocks describe-config and add some test case
|
kind/enhancement test
|
Is your improvement request related to a problem? Please describe.
add some test cases and Examples for `kbcli kubeblocks describe-config`
If this is a new function, please describe the motivation and goals.
A clear and concise description of why you want to happen, link the design doc if possible
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or fuctions you've considered.
Additional context
Add any other context or screenshots about the improvement request here.
|
1.0
|
[Improvement] refine kubeblocks describe-config and add some test case - Is your improvement request related to a problem? Please describe.
add some test cases and Examples for `kbcli kubeblocks describe-config`
If this is a new function, please describe the motivation and goals.
A clear and concise description of why you want to happen, link the design doc if possible
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or fuctions you've considered.
Additional context
Add any other context or screenshots about the improvement request here.
|
non_design
|
refine kubeblocks describe config and add some test case is your improvement request related to a problem please describe add some test cases and examples for kbcli kubeblocks describe config if this is a new function please describe the motivation and goals a clear and concise description of why you want to happen link the design doc if possible describe the solution you d like a clear and concise description of what you want to happen describe alternatives you ve considered a clear and concise description of any alternative solutions or fuctions you ve considered additional context add any other context or screenshots about the improvement request here
| 0
|
84,555
| 7,926,167,871
|
IssuesEvent
|
2018-07-06 00:14:06
|
JamesShuttler/ChocolateBricks
|
https://api.github.com/repos/JamesShuttler/ChocolateBricks
|
opened
|
Introduce unit, integration and functional tests to web interface
|
testing
|
While I prefer following a TDD approach, I am going to defer testing of the web interface and add them retrospectively after the first couple of features.
One reason for this is that while unit tests are trivial to implement, integration tests make more sense once physical dependencies such as databases have been settled upon; currently a choice has not yet been made.
Similarly functional, end-to-end tests of the UI itself are brittle and sensitive to change so shall be added once the UI has been stabilised to some degree.
|
1.0
|
Introduce unit, integration and functional tests to web interface - While I prefer following a TDD approach, I am going to defer testing of the web interface and add them retrospectively after the first couple of features.
One reason for this is that while unit tests are trivial to implement, integration tests make more sense once physical dependencies such as databases have been settled upon; currently a choice has not yet been made.
Similarly functional, end-to-end tests of the UI itself are brittle and sensitive to change so shall be added once the UI has been stabilised to some degree.
|
non_design
|
introduce unit integration and functional tests to web interface while i prefer following a tdd approach i am going to defer testing of the web interface and add them retrospectively after the first couple of features one reason for this is that while unit tests are trivial to implement integration tests make more sense once physical dependencies such as databases have been settled upon currently a choice has not yet been made similarly functional end to end tests of the ui itself are brittle and sensitive to change so shall be added once the ui has been stabilised to some degree
| 0
|
100,601
| 30,735,479,432
|
IssuesEvent
|
2023-07-28 07:16:20
|
nature-of-code/noc-book-2023
|
https://api.github.com/repos/nature-of-code/noc-book-2023
|
opened
|
pseudo code design in website and PDF
|
design PDF build
|
In need of design treatment for pseudocode (the pink boxes in the screenshot) , or make it into a callout box, to separate them more from the copy. Both website and pdf!
In Notion, Chapter 6:
<img width="788" alt="Screenshot 2023-07-28 at 3 12 19 PM" src="https://github.com/nature-of-code/noc-book-2023/assets/90000947/99adcbfb-3ec1-4625-8b68-fc62655554ca">
|
1.0
|
pseudo code design in website and PDF - In need of design treatment for pseudocode (the pink boxes in the screenshot) , or make it into a callout box, to separate them more from the copy. Both website and pdf!
In Notion, Chapter 6:
<img width="788" alt="Screenshot 2023-07-28 at 3 12 19 PM" src="https://github.com/nature-of-code/noc-book-2023/assets/90000947/99adcbfb-3ec1-4625-8b68-fc62655554ca">
|
non_design
|
pseudo code design in website and pdf in need of design treatment for pseudocode the pink boxes in the screenshot or make it into a callout box to separate them more from the copy both website and pdf in notion chapter img width alt screenshot at pm src
| 0
|
18,211
| 3,378,107,391
|
IssuesEvent
|
2015-11-25 09:08:51
|
owncloud/client
|
https://api.github.com/repos/owncloud/client
|
closed
|
Move Desktop Activity Log to a New Button, Sync Log
|
Design & UX enhancement - proposed gold-ticket
|
As a user, I want the Activity tab on a new button in the General tab, and a new activity tab with a true activity feed from the server activity feed API
Acceptance Criteria:
- A new button takes the current activity log and moves it to the general tab under “Advanced”, and adds a new button label “File Transfer Log” - including re size able columns and items already in the activity tab.
- The new activity feed tab looks the same as the current activity tab and is called “Activity”
- The activity feed from the server is listed here in reverse chronological order
- When online, server is queried for updates from the activity feed every 30 seconds.
- When a new file or folder is shared with a user, the activity will show that file or folder. The next important thing is to augment the pure activity stream for that file with a notification that the file or folder has been synced with the client. For example:
MTRichards has shared file awesomesauce.txt with you
awesomesauce.txt has been synced to the desktop
OR
MTRichards has shared file awesomesauce.txt with you
awesomesauce.txt has been not synced to the desktop for you due to your selective sync settings
OR
MTRichards has shared folder “cooltextmessages” with you
cooltextmessages has been synced to the desktop
- Clearly it is possible to have a file or folder not syncing, and to have updates to those files. The activity stream durifully reports
- If no new activities are available on the server, the desktop client sleeps for another 30 seconds
- When the activity feed has been offline for a point in time, it downloads the last 24 hours of activity, see next as this value can be adjusted– but does not download the same activity alerts more than once.
- An option on the desktop client allows a user to set the expiration for the activity feed, the default is set to 24 hours – this is available on the activity tab at the bottom
- The desktop client activity feed follows the same rules set in the personal page on the server
- If the activity feed is not enabled on the server, a message says “The administrator has disabled activity stream for this server”
Advanced:
- The activity feed includes a type ahead filter so users can see search for activity on specific files
|
1.0
|
Move Desktop Activity Log to a New Button, Sync Log - As a user, I want the Activity tab on a new button in the General tab, and a new activity tab with a true activity feed from the server activity feed API
Acceptance Criteria:
- A new button takes the current activity log and moves it to the general tab under “Advanced”, and adds a new button label “File Transfer Log” - including re size able columns and items already in the activity tab.
- The new activity feed tab looks the same as the current activity tab and is called “Activity”
- The activity feed from the server is listed here in reverse chronological order
- When online, server is queried for updates from the activity feed every 30 seconds.
- When a new file or folder is shared with a user, the activity will show that file or folder. The next important thing is to augment the pure activity stream for that file with a notification that the file or folder has been synced with the client. For example:
MTRichards has shared file awesomesauce.txt with you
awesomesauce.txt has been synced to the desktop
OR
MTRichards has shared file awesomesauce.txt with you
awesomesauce.txt has been not synced to the desktop for you due to your selective sync settings
OR
MTRichards has shared folder “cooltextmessages” with you
cooltextmessages has been synced to the desktop
- Clearly it is possible to have a file or folder not syncing, and to have updates to those files. The activity stream durifully reports
- If no new activities are available on the server, the desktop client sleeps for another 30 seconds
- When the activity feed has been offline for a point in time, it downloads the last 24 hours of activity, see next as this value can be adjusted– but does not download the same activity alerts more than once.
- An option on the desktop client allows a user to set the expiration for the activity feed, the default is set to 24 hours – this is available on the activity tab at the bottom
- The desktop client activity feed follows the same rules set in the personal page on the server
- If the activity feed is not enabled on the server, a message says “The administrator has disabled activity stream for this server”
Advanced:
- The activity feed includes a type ahead filter so users can see search for activity on specific files
|
design
|
move desktop activity log to a new button sync log as a user i want the activity tab on a new button in the general tab and a new activity tab with a true activity feed from the server activity feed api acceptance criteria a new button takes the current activity log and moves it to the general tab under “advanced” and adds a new button label “file transfer log” including re size able columns and items already in the activity tab the new activity feed tab looks the same as the current activity tab and is called “activity” the activity feed from the server is listed here in reverse chronological order when online server is queried for updates from the activity feed every seconds when a new file or folder is shared with a user the activity will show that file or folder the next important thing is to augment the pure activity stream for that file with a notification that the file or folder has been synced with the client for example mtrichards has shared file awesomesauce txt with you awesomesauce txt has been synced to the desktop or mtrichards has shared file awesomesauce txt with you awesomesauce txt has been not synced to the desktop for you due to your selective sync settings or mtrichards has shared folder “cooltextmessages” with you cooltextmessages has been synced to the desktop clearly it is possible to have a file or folder not syncing and to have updates to those files the activity stream durifully reports if no new activities are available on the server the desktop client sleeps for another seconds when the activity feed has been offline for a point in time it downloads the last hours of activity see next as this value can be adjusted– but does not download the same activity alerts more than once an option on the desktop client allows a user to set the expiration for the activity feed the default is set to hours – this is available on the activity tab at the bottom the desktop client activity feed follows the same rules set in the personal page on the server if the activity feed is not enabled on the server a message says “the administrator has disabled activity stream for this server” advanced the activity feed includes a type ahead filter so users can see search for activity on specific files
| 1
|
72,717
| 8,767,795,608
|
IssuesEvent
|
2018-12-17 20:53:36
|
LLK/scratch-gui
|
https://api.github.com/repos/LLK/scratch-gui
|
closed
|
Thumbnails for all-white sprites should be visible
|
design
|
### Expected Behavior
It should be possible to see the shape of a sprite's costume in the thumbnail somehow, even if it is all white.
In Scratch 2.0, thumbnail images for sprites that have all-white costumes are given gray outlines so you can see their shape. Also, the selected state of the thumbnail turns the background the gray:
<img width="160" alt="screen shot 2017-07-18 at 10 15 44 am" src="https://user-images.githubusercontent.com/567844/28324528-a07db3bc-6ba9-11e7-951f-e1b7ff831220.png">
<img width="161" alt="screen shot 2017-07-18 at 10 15 25 am" src="https://user-images.githubusercontent.com/567844/28324536-a537a3ae-6ba9-11e7-924e-018886d9d011.png">
### Actual Behavior
Sprite thumbnails have white backgrounds:
<img width="155" alt="screen shot 2017-07-18 at 10 15 36 am" src="https://user-images.githubusercontent.com/567844/28324685-f8f09712-6ba9-11e7-9027-5bc147f739b9.png">
### Steps to reproduce
Visit https://llk.github.io/scratch-gui/#163165382
|
1.0
|
Thumbnails for all-white sprites should be visible - ### Expected Behavior
It should be possible to see the shape of a sprite's costume in the thumbnail somehow, even if it is all white.
In Scratch 2.0, thumbnail images for sprites that have all-white costumes are given gray outlines so you can see their shape. Also, the selected state of the thumbnail turns the background the gray:
<img width="160" alt="screen shot 2017-07-18 at 10 15 44 am" src="https://user-images.githubusercontent.com/567844/28324528-a07db3bc-6ba9-11e7-951f-e1b7ff831220.png">
<img width="161" alt="screen shot 2017-07-18 at 10 15 25 am" src="https://user-images.githubusercontent.com/567844/28324536-a537a3ae-6ba9-11e7-924e-018886d9d011.png">
### Actual Behavior
Sprite thumbnails have white backgrounds:
<img width="155" alt="screen shot 2017-07-18 at 10 15 36 am" src="https://user-images.githubusercontent.com/567844/28324685-f8f09712-6ba9-11e7-9027-5bc147f739b9.png">
### Steps to reproduce
Visit https://llk.github.io/scratch-gui/#163165382
|
design
|
thumbnails for all white sprites should be visible expected behavior it should be possible to see the shape of a sprite s costume in the thumbnail somehow even if it is all white in scratch thumbnail images for sprites that have all white costumes are given gray outlines so you can see their shape also the selected state of the thumbnail turns the background the gray img width alt screen shot at am src img width alt screen shot at am src actual behavior sprite thumbnails have white backgrounds img width alt screen shot at am src steps to reproduce visit
| 1
|
664,021
| 22,218,255,147
|
IssuesEvent
|
2022-06-08 05:30:52
|
JesusAntonioGP/github-issue-template
|
https://api.github.com/repos/JesusAntonioGP/github-issue-template
|
opened
|
1 Validation Issue /38 Warnings on Index
|
bug Priority 2 Severity 2
|
**Describe the bug**
Using jigsaw HTML validator, 1 error was identified. First error "Parse Error =#000000, offx=1, offy=0)"
**To Reproduce**
Steps to reproduce the behavior:
1. Go to https://jigsaw.w3.org/css-validator/
2. Paste in https://jesusantoniogp.github.io/github-issue-template/
3. See 1 error, and 28 warnings listed by the validator.
**Expected behavior**
Should no longer pull up any errors or warnings.
**Screenshots**
The errors can be viewed here: https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fjesusantoniogp.github.io%2Fgithub-issue-template%2F&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en
**Desktop (please complete the following information):**
NA
**Smartphone (please complete the following information):**
NA
**Additional context**
Use this validator in the future to avoid further issues.
|
1.0
|
1 Validation Issue /38 Warnings on Index - **Describe the bug**
Using jigsaw HTML validator, 1 error was identified. First error "Parse Error =#000000, offx=1, offy=0)"
**To Reproduce**
Steps to reproduce the behavior:
1. Go to https://jigsaw.w3.org/css-validator/
2. Paste in https://jesusantoniogp.github.io/github-issue-template/
3. See 1 error, and 28 warnings listed by the validator.
**Expected behavior**
Should no longer pull up any errors or warnings.
**Screenshots**
The errors can be viewed here: https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fjesusantoniogp.github.io%2Fgithub-issue-template%2F&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en
**Desktop (please complete the following information):**
NA
**Smartphone (please complete the following information):**
NA
**Additional context**
Use this validator in the future to avoid further issues.
|
non_design
|
validation issue warnings on index describe the bug using jigsaw html validator error was identified first error parse error offx offy to reproduce steps to reproduce the behavior go to paste in see error and warnings listed by the validator expected behavior should no longer pull up any errors or warnings screenshots the errors can be viewed here desktop please complete the following information na smartphone please complete the following information na additional context use this validator in the future to avoid further issues
| 0
|
740,163
| 25,738,483,117
|
IssuesEvent
|
2022-12-08 03:27:46
|
brave/brave-browser
|
https://api.github.com/repos/brave/brave-browser
|
closed
|
Ads on YouTube Search
|
feature/shields/adblock priority/P2 OS/Desktop
|
## Description
Noticing ads while searching for videos in YouTube
## Steps to Reproduce
1. Visit www.youtube.com
2. Search for Brave
3. See an ad for Brave
## Actual result:
## Expected result:
No Ad should be shown
## Brave version (brave://version info)
<html>
<body>
<!--StartFragment-->
Brave | 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit)
-- | --
Revision | 9f2101830b56fd2ea1408287f6c74e253ebcb7c6-refs/branch-heads/5249@{#797}
OS | Windows 10 Version 21H2 (Build 19044.2130)
<!--EndFragment-->
</body>
</html>
## Version/Channel Information:
<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? N.A.
- Can you reproduce this issue with the nightly channel? N.A.
|
1.0
|
Ads on YouTube Search - ## Description
Noticing ads while searching for videos in YouTube
## Steps to Reproduce
1. Visit www.youtube.com
2. Search for Brave
3. See an ad for Brave
## Actual result:
## Expected result:
No Ad should be shown
## Brave version (brave://version info)
<html>
<body>
<!--StartFragment-->
Brave | 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit)
-- | --
Revision | 9f2101830b56fd2ea1408287f6c74e253ebcb7c6-refs/branch-heads/5249@{#797}
OS | Windows 10 Version 21H2 (Build 19044.2130)
<!--EndFragment-->
</body>
</html>
## Version/Channel Information:
<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? N.A.
- Can you reproduce this issue with the nightly channel? N.A.
|
non_design
|
ads on youtube search description noticing ads while searching for videos in youtube steps to reproduce visit search for brave see an ad for brave actual result expected result no ad should be shown brave version brave version info brave chromium official build bit revision refs branch heads os windows version build version channel information can you reproduce this issue with the current release yes can you reproduce this issue with the beta channel n a can you reproduce this issue with the nightly channel n a
| 0
|
91,686
| 11,566,553,884
|
IssuesEvent
|
2020-02-20 12:44:15
|
ktorio/ktor
|
https://api.github.com/repos/ktorio/ktor
|
opened
|
[Evolution] Ktor locations nested classes
|
design
|
**Subsystem**
ktor-locations
**Description**
We are going to develop and expand ktor Locations (Type-Safe routing https://ktor.io/servers/features/locations.html). One of the directions to improve is Kotlin Multiplatform. The most obvious way of migration to MPP is to use kotlinx.serialization in locations. Due to the limited reflection capabilities of non-JVM targets, there are things that not so easy to implement. On the other hand, there are questionable features that may lead to issues. One of the problematic features is nested location classes and nested location objects.
What we are thinking of to change:
- a nested location class should always have a property of the outer class or object
- nested objects in objects are not allowed
The motivation for the first point is the fact that a location class nested to another, makes no sense without the ability to refer to the outer class. Consider the following example:
```kotlin
@Location("/api/{version}")
class Api(val version: Int) {
@Location("/user/{id}")
class User(val id: String, val api: Api = Api(1)) {
// here API presence looks required,
// otherwise, there is no way to find a version value
// so now we demand the api parameter to exist
}
}
```
The other point is that one can't just move a nested class outside without additional manual changes:
```kotlin
@Location("/root")
class Outer {
@Location("/child")
class Child // it is tied to /root/child path
}
@Location("/child")
class Child // this is tied to just /child
@Location("/child2")
class Child2(val outer: Outer) // -> /root/child2
```
The cause of the second change is that objects should be symmetric with classes, and one can't add a constructor property to an object. The unfortunate consequence is that one can't write like this anymore:
```kotlin
@Location("/api")
object Api {
@Location("/info")
object Info
}
```
Should be migrated to the following:
```kotlin
@Location("/api")
object Api {
@Location("/info")
class Info(val api: Api = Api)
// the api parameter is required, weird isn't it
}
```
|
1.0
|
[Evolution] Ktor locations nested classes - **Subsystem**
ktor-locations
**Description**
We are going to develop and expand ktor Locations (Type-Safe routing https://ktor.io/servers/features/locations.html). One of the directions to improve is Kotlin Multiplatform. The most obvious way of migration to MPP is to use kotlinx.serialization in locations. Due to the limited reflection capabilities of non-JVM targets, there are things that not so easy to implement. On the other hand, there are questionable features that may lead to issues. One of the problematic features is nested location classes and nested location objects.
What we are thinking of to change:
- a nested location class should always have a property of the outer class or object
- nested objects in objects are not allowed
The motivation for the first point is the fact that a location class nested to another, makes no sense without the ability to refer to the outer class. Consider the following example:
```kotlin
@Location("/api/{version}")
class Api(val version: Int) {
@Location("/user/{id}")
class User(val id: String, val api: Api = Api(1)) {
// here API presence looks required,
// otherwise, there is no way to find a version value
// so now we demand the api parameter to exist
}
}
```
The other point is that one can't just move a nested class outside without additional manual changes:
```kotlin
@Location("/root")
class Outer {
@Location("/child")
class Child // it is tied to /root/child path
}
@Location("/child")
class Child // this is tied to just /child
@Location("/child2")
class Child2(val outer: Outer) // -> /root/child2
```
The cause of the second change is that objects should be symmetric with classes, and one can't add a constructor property to an object. The unfortunate consequence is that one can't write like this anymore:
```kotlin
@Location("/api")
object Api {
@Location("/info")
object Info
}
```
Should be migrated to the following:
```kotlin
@Location("/api")
object Api {
@Location("/info")
class Info(val api: Api = Api)
// the api parameter is required, weird isn't it
}
```
|
design
|
ktor locations nested classes subsystem ktor locations description we are going to develop and expand ktor locations type safe routing one of the directions to improve is kotlin multiplatform the most obvious way of migration to mpp is to use kotlinx serialization in locations due to the limited reflection capabilities of non jvm targets there are things that not so easy to implement on the other hand there are questionable features that may lead to issues one of the problematic features is nested location classes and nested location objects what we are thinking of to change a nested location class should always have a property of the outer class or object nested objects in objects are not allowed the motivation for the first point is the fact that a location class nested to another makes no sense without the ability to refer to the outer class consider the following example kotlin location api version class api val version int location user id class user val id string val api api api here api presence looks required otherwise there is no way to find a version value so now we demand the api parameter to exist the other point is that one can t just move a nested class outside without additional manual changes kotlin location root class outer location child class child it is tied to root child path location child class child this is tied to just child location class val outer outer root the cause of the second change is that objects should be symmetric with classes and one can t add a constructor property to an object the unfortunate consequence is that one can t write like this anymore kotlin location api object api location info object info should be migrated to the following kotlin location api object api location info class info val api api api the api parameter is required weird isn t it
| 1
|
103,865
| 12,977,348,429
|
IssuesEvent
|
2020-07-21 20:29:07
|
laterpay/revenue-generator
|
https://api.github.com/repos/laterpay/revenue-generator
|
closed
|
Increase Margins around Number of Posts per Month
|
Design Feedback
|
# Description
Let’s increase the margins beside the titles to improve readability. The icons’ proportions look a bit bigger than expected. Check https://zpl.io/agJpevM
|
1.0
|
Increase Margins around Number of Posts per Month - # Description
Let’s increase the margins beside the titles to improve readability. The icons’ proportions look a bit bigger than expected. Check https://zpl.io/agJpevM
|
design
|
increase margins around number of posts per month description let’s increase the margins beside the titles to improve readability the icons’ proportions look a bit bigger than expected check
| 1
|
180,002
| 6,642,123,633
|
IssuesEvent
|
2017-09-27 05:40:43
|
openebs/openebs
|
https://api.github.com/repos/openebs/openebs
|
closed
|
Add a commit message template to suggest a coherent style of commit messages.
|
kind/enhancement priority/2 Size/S
|
Commit messages should be uniform across the project, representing one community. But having to type the same thing all over again is kinda hard, so we'd like to have some superpowers from **git**.
Read along
- https://robots.thoughtbot.com/better-commit-messages-with-a-gitmessage-template
See some commit message and suggest some templates.
|
1.0
|
Add a commit message template to suggest a coherent style of commit messages. - Commit messages should be uniform across the project, representing one community. But having to type the same thing all over again is kinda hard, so we'd like to have some superpowers from **git**.
Read along
- https://robots.thoughtbot.com/better-commit-messages-with-a-gitmessage-template
See some commit message and suggest some templates.
|
non_design
|
add a commit message template to suggest a coherent style of commit messages commit messages should be uniform across the project representing one community but having to type the same thing all over again is kinda hard so we d like to have some superpowers from git read along see some commit message and suggest some templates
| 0
|
154,958
| 12,234,990,141
|
IssuesEvent
|
2020-05-04 14:15:14
|
WoWManiaUK/Blackwing-Lair
|
https://api.github.com/repos/WoWManiaUK/Blackwing-Lair
|
opened
|
[NPC][FIRELANDS] Unstable Magma
|
Confirmed By Tester Dungeon/Raid Later Patch
|
**Links:**
https://www.wowhead.com/npc=53901/unstable-magma#abilities
from WoWHead or our Armory
**What is happening:**
When npc is attacked it doesnt use damage spells
**What should happen:**
When attacked it should cast it spells to damage players.
All is in the link
**Is it crashing the server?:**
No
**Other Information:**
|
1.0
|
[NPC][FIRELANDS] Unstable Magma - **Links:**
https://www.wowhead.com/npc=53901/unstable-magma#abilities
from WoWHead or our Armory
**What is happening:**
When npc is attacked it doesnt use damage spells
**What should happen:**
When attacked it should cast it spells to damage players.
All is in the link
**Is it crashing the server?:**
No
**Other Information:**
|
non_design
|
unstable magma links from wowhead or our armory what is happening when npc is attacked it doesnt use damage spells what should happen when attacked it should cast it spells to damage players all is in the link is it crashing the server no other information
| 0
|
9,457
| 24,610,682,506
|
IssuesEvent
|
2022-10-14 21:03:19
|
Azure/azure-sdk
|
https://api.github.com/repos/Azure/azure-sdk
|
opened
|
Change Request: Add dependent azure library info for Telemetry policy
|
architecture board-review
|
## The Basics
* Which design guideline is affected?
The Telemetry policy guideline: https://azure.github.io/azure-sdk/general_azurecore.html
* Which target languages are affected?
All languages
* Describe the change:
In the Telemetry format `[<application_id> ]azsdk-<sdk_language>-<package_name>/<package_version> <platform_info>`
We need to consider the Telemetry information appended from dependent libraries. For example, if we re-wrote `AzCopy` in javaScript using the library `AzLib` depending on `Azure Blob Storage client library`, what would the format be?
## Details
For the [Telemetry policy format](https://azure.github.io/azure-sdk/general_azurecore.html#telemetry-policy)
`[<application_id> ]azsdk-<sdk_language>-<package_name>/<package_version> <platform_info>`
how does the policy handle the scenario that there are multiple azure library being used? Especially in the case that one library is built based on an underlying service azure library.
For example, our **[ACS UI Chat Composite](https://github.com/Azure/communication-ui-library-ios/tree/feature/chat/AzureCommunicationUI/sdk)** is built based on **[Chat SDK](https://github.com/Azure/azure-sdk-for-ios/blob/main/sdk/core/AzureCore/Source/Pipeline/Policies/UserAgentPolicy.swift)**. The **ChatComposite** has no access to Telemetry implementation details and would only pass `application_id` to [ChatSDK API](https://azure.github.io/azure-sdk-for-ios/AzureCore/Structs/TelemetryOptions.html#/s:9AzureCore16TelemetryOptionsV13applicationIdSSSgvp) for logging purpose.
The ChatSDK telemetry info example in user_Agent could be
<application_id> azsdk-js-azure-communication-chat/1.1.0 core-rest-pipeline/1.3.0 OS/Win32
However we want to post our ChatComposite info to the Telemetry. And the only accessible parameter [application_id](https://azure.github.io/azure-sdk-for-ios/AzureCore/Structs/TelemetryOptions.html#/s:9AzureCore16TelemetryOptionsV13applicationIdSSSgvp) should be reserved for our Chat composite customers.
In this scenario, how should the dependent library pass it own telemetry information to the underlying service SDK and let service SDK log the additional telemetry information?
Should the service SDK has additional public API to accept those Telemetry info? Something similar to CallingSDK doing, having additional tags API for Telemetry. And the dependent libraries pass their info through the tags?
Please post any thought you have. And reach to @JoshuaLai (Josh Lai) or @jimchou-dev (Jim Chou) for any question you have.
Thanks
|
1.0
|
Change Request: Add dependent azure library info for Telemetry policy - ## The Basics
* Which design guideline is affected?
The Telemetry policy guideline: https://azure.github.io/azure-sdk/general_azurecore.html
* Which target languages are affected?
All languages
* Describe the change:
In the Telemetry format `[<application_id> ]azsdk-<sdk_language>-<package_name>/<package_version> <platform_info>`
We need to consider the Telemetry information appended from dependent libraries. For example, if we re-wrote `AzCopy` in javaScript using the library `AzLib` depending on `Azure Blob Storage client library`, what would the format be?
## Details
For the [Telemetry policy format](https://azure.github.io/azure-sdk/general_azurecore.html#telemetry-policy)
`[<application_id> ]azsdk-<sdk_language>-<package_name>/<package_version> <platform_info>`
how does the policy handle the scenario that there are multiple azure library being used? Especially in the case that one library is built based on an underlying service azure library.
For example, our **[ACS UI Chat Composite](https://github.com/Azure/communication-ui-library-ios/tree/feature/chat/AzureCommunicationUI/sdk)** is built based on **[Chat SDK](https://github.com/Azure/azure-sdk-for-ios/blob/main/sdk/core/AzureCore/Source/Pipeline/Policies/UserAgentPolicy.swift)**. The **ChatComposite** has no access to Telemetry implementation details and would only pass `application_id` to [ChatSDK API](https://azure.github.io/azure-sdk-for-ios/AzureCore/Structs/TelemetryOptions.html#/s:9AzureCore16TelemetryOptionsV13applicationIdSSSgvp) for logging purpose.
The ChatSDK telemetry info example in user_Agent could be
<application_id> azsdk-js-azure-communication-chat/1.1.0 core-rest-pipeline/1.3.0 OS/Win32
However we want to post our ChatComposite info to the Telemetry. And the only accessible parameter [application_id](https://azure.github.io/azure-sdk-for-ios/AzureCore/Structs/TelemetryOptions.html#/s:9AzureCore16TelemetryOptionsV13applicationIdSSSgvp) should be reserved for our Chat composite customers.
In this scenario, how should the dependent library pass it own telemetry information to the underlying service SDK and let service SDK log the additional telemetry information?
Should the service SDK has additional public API to accept those Telemetry info? Something similar to CallingSDK doing, having additional tags API for Telemetry. And the dependent libraries pass their info through the tags?
Please post any thought you have. And reach to @JoshuaLai (Josh Lai) or @jimchou-dev (Jim Chou) for any question you have.
Thanks
|
non_design
|
change request add dependent azure library info for telemetry policy the basics which design guideline is affected the telemetry policy guideline which target languages are affected all languages describe the change in the telemetry format azsdk we need to consider the telemetry information appended from dependent libraries for example if we re wrote azcopy in javascript using the library azlib depending on azure blob storage client library what would the format be details for the azsdk how does the policy handle the scenario that there are multiple azure library being used especially in the case that one library is built based on an underlying service azure library for example our is built based on the chatcomposite has no access to telemetry implementation details and would only pass application id to for logging purpose the chatsdk telemetry info example in user agent could be azsdk js azure communication chat core rest pipeline os however we want to post our chatcomposite info to the telemetry and the only accessible parameter should be reserved for our chat composite customers in this scenario how should the dependent library pass it own telemetry information to the underlying service sdk and let service sdk log the additional telemetry information should the service sdk has additional public api to accept those telemetry info something similar to callingsdk doing having additional tags api for telemetry and the dependent libraries pass their info through the tags please post any thought you have and reach to joshualai josh lai or jimchou dev jim chou for any question you have thanks
| 0
|
68,081
| 14,900,371,694
|
IssuesEvent
|
2021-01-21 15:20:50
|
xcp-ng/xcp
|
https://api.github.com/repos/xcp-ng/xcp
|
closed
|
PCI passthrough issues
|
bug :bug: reported_upstream security
|
Cf https://xcp-ng.org/forum/topic/4001/passthough-on-8-2-hangs-on-vm-reboot-and-stops-other-vms-passthough-devices-working
Steps to fix the problem:
1. Reproduce it internally
2. Port Xen from 8.1 into 8.2, test and see if it still a problem (or vice-versa)
3. If Xen is the issue, open a thread on xen-devel. If not investigate the dom0
|
True
|
PCI passthrough issues - Cf https://xcp-ng.org/forum/topic/4001/passthough-on-8-2-hangs-on-vm-reboot-and-stops-other-vms-passthough-devices-working
Steps to fix the problem:
1. Reproduce it internally
2. Port Xen from 8.1 into 8.2, test and see if it still a problem (or vice-versa)
3. If Xen is the issue, open a thread on xen-devel. If not investigate the dom0
|
non_design
|
pci passthrough issues cf steps to fix the problem reproduce it internally port xen from into test and see if it still a problem or vice versa if xen is the issue open a thread on xen devel if not investigate the
| 0
|
177,242
| 28,376,257,782
|
IssuesEvent
|
2023-04-12 21:07:02
|
scribe-org/Scribe-iOS
|
https://api.github.com/repos/scribe-org/Scribe-iOS
|
closed
|
Bold and underline installation menu steps
|
good first issue help wanted design -next release-
|
### Terms
- [X] I have searched [open and closed design issues](https://github.com/scribe-org/Scribe-iOS/issues?q=is%3Aissue+label%3Adesign)
- [X] I agree to follow Scribe-iOS' [Code of Conduct](https://github.com/scribe-org/Scribe-iOS/blob/main/.github/CODE_OF_CONDUCT.md)
### Description
A comment about the installation steps on the app screen recently was that they could be a bit more explicit for the pages that user needs to go through to get to the keyboard installation part of settings. Sadly a direct link isn't possible on iOS 🤦♂️ Specifically "In General do..." could be read as "In general do...", i.e. not conveying that they should go to `General`. Furthermore `General` and `Scribe` are parts of the menu, but are not in the arrow path and including them would make the directions too long.
A solution to this is in the [Figma designs for the new app screen](https://www.figma.com/file/c8945w2iyoPYVhsqW7vRn6/scribe_public_designs?node-id=405%3A393&t=17W65PMkSRsVDO5p-1). The part for the installation directions could be done right now :) We just want the words for `Open Settings` and each menu step to be bolded and underlined.
These changes would occur in [ENAppText.swift](https://github.com/scribe-org/Scribe-iOS/blob/main/Scribe/AppTexts/English/ENAppText.swift) and the corresponding parts of [DEAppText.swift](https://github.com/scribe-org/Scribe-iOS/blob/main/Scribe/AppTexts/German/DEAppText.swift).
### Contribution
Happy to work on this myself or support someone with interest 😊 Would be great to get it finished before the next release, but no rush if someone wants to try and will take their time :)
|
1.0
|
Bold and underline installation menu steps - ### Terms
- [X] I have searched [open and closed design issues](https://github.com/scribe-org/Scribe-iOS/issues?q=is%3Aissue+label%3Adesign)
- [X] I agree to follow Scribe-iOS' [Code of Conduct](https://github.com/scribe-org/Scribe-iOS/blob/main/.github/CODE_OF_CONDUCT.md)
### Description
A comment about the installation steps on the app screen recently was that they could be a bit more explicit for the pages that user needs to go through to get to the keyboard installation part of settings. Sadly a direct link isn't possible on iOS 🤦♂️ Specifically "In General do..." could be read as "In general do...", i.e. not conveying that they should go to `General`. Furthermore `General` and `Scribe` are parts of the menu, but are not in the arrow path and including them would make the directions too long.
A solution to this is in the [Figma designs for the new app screen](https://www.figma.com/file/c8945w2iyoPYVhsqW7vRn6/scribe_public_designs?node-id=405%3A393&t=17W65PMkSRsVDO5p-1). The part for the installation directions could be done right now :) We just want the words for `Open Settings` and each menu step to be bolded and underlined.
These changes would occur in [ENAppText.swift](https://github.com/scribe-org/Scribe-iOS/blob/main/Scribe/AppTexts/English/ENAppText.swift) and the corresponding parts of [DEAppText.swift](https://github.com/scribe-org/Scribe-iOS/blob/main/Scribe/AppTexts/German/DEAppText.swift).
### Contribution
Happy to work on this myself or support someone with interest 😊 Would be great to get it finished before the next release, but no rush if someone wants to try and will take their time :)
|
design
|
bold and underline installation menu steps terms i have searched i agree to follow scribe ios description a comment about the installation steps on the app screen recently was that they could be a bit more explicit for the pages that user needs to go through to get to the keyboard installation part of settings sadly a direct link isn t possible on ios 🤦♂️ specifically in general do could be read as in general do i e not conveying that they should go to general furthermore general and scribe are parts of the menu but are not in the arrow path and including them would make the directions too long a solution to this is in the the part for the installation directions could be done right now we just want the words for open settings and each menu step to be bolded and underlined these changes would occur in and the corresponding parts of contribution happy to work on this myself or support someone with interest 😊 would be great to get it finished before the next release but no rush if someone wants to try and will take their time
| 1
|
286,142
| 31,275,178,768
|
IssuesEvent
|
2023-08-22 05:30:02
|
VictorHuu/PetFosterSystem
|
https://api.github.com/repos/VictorHuu/PetFosterSystem
|
opened
|
Fix code scanning alert - SQL query built from user-controlled sources
|
security
|
<!-- Warning: The suggested title contains the alert rule name. This can expose security information. -->
Tracking issue for:
- [ ] https://github.com/VictorHuu/PetFosterSystem/security/code-scanning/5
|
True
|
Fix code scanning alert - SQL query built from user-controlled sources - <!-- Warning: The suggested title contains the alert rule name. This can expose security information. -->
Tracking issue for:
- [ ] https://github.com/VictorHuu/PetFosterSystem/security/code-scanning/5
|
non_design
|
fix code scanning alert sql query built from user controlled sources tracking issue for
| 0
|
38,743
| 5,003,264,137
|
IssuesEvent
|
2016-12-11 20:34:30
|
adventurerscodex/adventurerscodex
|
https://api.github.com/repos/adventurerscodex/adventurerscodex
|
closed
|
Add: Envioronment Encounter
|
difficulty/complex severity/blocking release type/UI-design
|
### Module(s) Effected
DM Tools
### Description
- Image
- Send to players (later implementation)
- Weather
- Send to players (later implementation)
- Terrain
- Description/Notes
|
1.0
|
Add: Envioronment Encounter - ### Module(s) Effected
DM Tools
### Description
- Image
- Send to players (later implementation)
- Weather
- Send to players (later implementation)
- Terrain
- Description/Notes
|
design
|
add envioronment encounter module s effected dm tools description image send to players later implementation weather send to players later implementation terrain description notes
| 1
|
21,418
| 17,037,053,618
|
IssuesEvent
|
2021-07-05 08:33:44
|
textpattern/textpattern
|
https://api.github.com/repos/textpattern/textpattern
|
opened
|
Missing gTxt for `?event=admin&step=author_list&search_method=login&crit=username`
|
admin-side localization / i10n / i18n / textpacks usability / UI / UX
|
I think there's a missing gTxt for the above. If not, then it probably needs one, since it's not very clear what the '(1)' means in this case.
|
True
|
Missing gTxt for `?event=admin&step=author_list&search_method=login&crit=username` - 
I think there's a missing gTxt for the above. If not, then it probably needs one, since it's not very clear what the '(1)' means in this case.
|
non_design
|
missing gtxt for event admin step author list search method login crit username i think there s a missing gtxt for the above if not then it probably needs one since it s not very clear what the means in this case
| 0
|
138,149
| 20,361,862,077
|
IssuesEvent
|
2022-02-20 20:00:34
|
USACE/cumulus
|
https://api.github.com/repos/USACE/cumulus
|
closed
|
News Feed / Blog Concept
|
design
|
* New Product Added, analysis on existing product, etc.
* Operational notices for Cumulus service
* Etc
|
1.0
|
News Feed / Blog Concept - * New Product Added, analysis on existing product, etc.
* Operational notices for Cumulus service
* Etc
|
design
|
news feed blog concept new product added analysis on existing product etc operational notices for cumulus service etc
| 1
|
22,331
| 10,742,228,768
|
IssuesEvent
|
2019-10-29 22:01:19
|
bananayong/if-build-project
|
https://api.github.com/repos/bananayong/if-build-project
|
closed
|
CVE-2019-14379 (High) detected in jackson-databind-2.9.9.jar
|
security vulnerability wontfix
|
## CVE-2019-14379 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>jackson-databind-2.9.9.jar</b></p></summary>
<p>General data-binding functionality for Jackson: works on core streaming API</p>
<p>Library home page: <a href="http://github.com/FasterXML/jackson">http://github.com/FasterXML/jackson</a></p>
<p>Path to dependency file: /if-build-project/project-server/pom.xml</p>
<p>Path to vulnerable library: /root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.9.9/jackson-databind-2.9.9.jar,/root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.9.9/jackson-databind-2.9.9.jar</p>
<p>
Dependency Hierarchy:
- project-server-0.1.0-SNAPSHOT.jar (Root Library)
- jackson-module-afterburner-2.9.9.jar
- :x: **jackson-databind-2.9.9.jar** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/bananayong/if-build-project/commit/6a1e9f98ae405c78fe34adeafe92dab4572e85f2">6a1e9f98ae405c78fe34adeafe92dab4572e85f2</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
SubTypeValidator.java in FasterXML jackson-databind before 2.9.9.2 mishandles default typing when ehcache is used, leading to remote code execution.
<p>Publish Date: 2019-07-29
<p>URL: <a href=https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379>CVE-2019-14379</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>9.8</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: High
- Availability Impact: High
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379">https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379</a></p>
<p>Release Date: 2019-07-29</p>
<p>Fix Resolution: 2.9.9.2</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
True
|
CVE-2019-14379 (High) detected in jackson-databind-2.9.9.jar - ## CVE-2019-14379 - High Severity Vulnerability
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/vulnerability_details.png' width=19 height=20> Vulnerable Library - <b>jackson-databind-2.9.9.jar</b></p></summary>
<p>General data-binding functionality for Jackson: works on core streaming API</p>
<p>Library home page: <a href="http://github.com/FasterXML/jackson">http://github.com/FasterXML/jackson</a></p>
<p>Path to dependency file: /if-build-project/project-server/pom.xml</p>
<p>Path to vulnerable library: /root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.9.9/jackson-databind-2.9.9.jar,/root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.9.9/jackson-databind-2.9.9.jar</p>
<p>
Dependency Hierarchy:
- project-server-0.1.0-SNAPSHOT.jar (Root Library)
- jackson-module-afterburner-2.9.9.jar
- :x: **jackson-databind-2.9.9.jar** (Vulnerable Library)
<p>Found in HEAD commit: <a href="https://github.com/bananayong/if-build-project/commit/6a1e9f98ae405c78fe34adeafe92dab4572e85f2">6a1e9f98ae405c78fe34adeafe92dab4572e85f2</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/high_vul.png' width=19 height=20> Vulnerability Details</summary>
<p>
SubTypeValidator.java in FasterXML jackson-databind before 2.9.9.2 mishandles default typing when ehcache is used, leading to remote code execution.
<p>Publish Date: 2019-07-29
<p>URL: <a href=https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379>CVE-2019-14379</a></p>
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/cvss3.png' width=19 height=20> CVSS 3 Score Details (<b>9.8</b>)</summary>
<p>
Base Score Metrics:
- Exploitability Metrics:
- Attack Vector: Network
- Attack Complexity: Low
- Privileges Required: None
- User Interaction: None
- Scope: Unchanged
- Impact Metrics:
- Confidentiality Impact: High
- Integrity Impact: High
- Availability Impact: High
</p>
For more information on CVSS3 Scores, click <a href="https://www.first.org/cvss/calculator/3.0">here</a>.
</p>
</details>
<p></p>
<details><summary><img src='https://whitesource-resources.whitesourcesoftware.com/suggested_fix.png' width=19 height=20> Suggested Fix</summary>
<p>
<p>Type: Upgrade version</p>
<p>Origin: <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379">https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-14379</a></p>
<p>Release Date: 2019-07-29</p>
<p>Fix Resolution: 2.9.9.2</p>
</p>
</details>
<p></p>
***
Step up your Open Source Security Game with WhiteSource [here](https://www.whitesourcesoftware.com/full_solution_bolt_github)
|
non_design
|
cve high detected in jackson databind jar cve high severity vulnerability vulnerable library jackson databind jar general data binding functionality for jackson works on core streaming api library home page a href path to dependency file if build project project server pom xml path to vulnerable library root repository com fasterxml jackson core jackson databind jackson databind jar root repository com fasterxml jackson core jackson databind jackson databind jar dependency hierarchy project server snapshot jar root library jackson module afterburner jar x jackson databind jar vulnerable library found in head commit a href vulnerability details subtypevalidator java in fasterxml jackson databind before mishandles default typing when ehcache is used leading to remote code execution publish date url a href cvss score details base score metrics exploitability metrics attack vector network attack complexity low privileges required none user interaction none scope unchanged impact metrics confidentiality impact high integrity impact high availability impact high for more information on scores click a href suggested fix type upgrade version origin a href release date fix resolution step up your open source security game with whitesource
| 0
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.