repository stringclasses 156
values | issue title stringlengths 1 1.01k ⌀ | labels stringclasses 8
values | body stringlengths 1 270k ⌀ |
|---|---|---|---|
facebookreact | jsx expect not html5 in its templating e g be flag as miss | null | html5 have different rule from xml in that thing like the xml desirable or or even be obsolete syntax in html5 the correct syntax be and respectively this lead to situation where react force people to write obsolete template html rather than parse true modern html as an author t... |
facebookreact | replace invariant with inline throw error for production build | null | error minify exception occur use the non minified dev environment for the full error message and additional helpful warning in build js on line of invariant implementation perhaps there be large issue prevent this but consider production error encounter by a user rarely have access to stack trac... |
facebookreact | how to distinguish if a component be the owner or the ownee | Question | title be self explanatory I m ask this due to owner removal thank you |
facebookreact | usage of owner | Question | hi I would like to know if the owner property be be deprecate I mean move into a private scope in the future or if it ll still be accessible as it s right now thank you |
facebookreact | how to work with web component | Duplicate | I want to use but in jsx gotchas say react win t render be attribute fill this fix or there be workaround |
facebookreact | do unmount mean garbage collect I d like to persist state between rendering but seem not possible | Question | sometimes I switch tab within my application or whatnot I m use react bootstrap and component will mount and unmount as they wish but they might have update state that I don t want to lose be I overlook a feature that let I do this |
facebookreact | setstate in componentwillupdate should return a proper error | Bug | the return error be and nothing else maybe add a link to the note in update componentwillupdate would help |
facebookreact | rendervalidatedcomponent method hide exception | Invalid | hi we ve stumble across this code block that cause exception to be hide l838 be there a good reason to catch all exception in the block and tidy it up with the finally without re throw the exception this be generally consider fairly bad practice without a good reason and certainly have make debugging applica... |
facebookreact | react and legacy custom element attribute | Duplicate | I notice that legacy attribute like align cellpadde cellspace wasn t render by react at least on the server side it be annoying for I since I be try to convert our email templating system to use react in order to be able to display they in our frontend app the fact be that I m unable to complete this task ... |
facebookreact | unable to find element error on element | Bug | if the content of the element be construct in special way it break react on component update with unable to find element error here s an example of render method body var v1 string math random var v2 string math random return v1 v2 here s work jsfiddle ... |
facebookreact | why be react so slow render 900 item with jsfiddle | Question | hi guy I m evaluate react js consider use it in some project but I m have trouble render a simple list with 910 element since it take almost 4 second this be not a complex markup just a couple of div tag actually it s an exist app simplification I try this use just underscore js and it take 500ms j... |
facebookreact | use key inside a react class in 0 12 | Duplicate | quite often our app need to render a list of entity entity usually contain some datum and an identifi property like i d or key sometimes we may have some logic inside a component which use that identifi e g use it inside some click handler to fire an event with i d of the clicked entity here... |
facebookreact | handle browser autofill gracefully when server side render | Enhancement | I m render my react app at the document root with server side rendering I ve get an email and password login form it render on the server without any state both field empty when the browser load the page the email and password be autofille by the browser this happen before react bootstrap and when it ... |
facebookreact | proptype property current vs getproptype function propose | Enhancement | as proptype be only use in development mode it seem like it would be preferable to only evaluate they as the result of a method call return the object instead of the current object literal declare on the class I imagine this isn t a particularly expensive operation but if you re use shape this result in a l... |
facebookreact | test use react 0 12 and jest mock sub component result in different behavior when use jsx versus react createfactory | Bug | I ve create a repo to help illustrate what I m run into basically develop in pure jsx and use the react createfactory be not interchangeable under testing use jest this make writing unit test a little tricky accord to this link non jsx component must be wrap in a react createfactory but when tes... |
facebookreact | how to implement shouldcomponentupdate with this context | Bug | I know this context be not officially there but quite a few library rely on it and it seem like it s get into shape with 2509 I m try to understand how exactly shouldcomponentupdate be suppose to be implement with context in mind I notice it accept a third argument nextcontext and I can exten... |
facebookreact | can not access key from within component | Duplicate | I understand a component s key be no long available on a component s prop but how do one get access to a component s own key componentwillmount function console log this key undefined |
facebookreact | add and then remove background from style attribute create unwanted style | Bug | I have an element and depend on some condition may set it s background if the condition be first true and later false the element be leave with some residual style that be never set in code output look like html these style be never set by user code and be interfere with style in my css ... |
facebookreact | strange behaviour for svg def | Bug | I have find a case where two very similar function that output exactly the same dom element work in 2 different way be I miss something the only difference be I move the def block from the render function to the renderdef function var mainview react createclass getinitialstate function ... |
facebookreact | new method for implicit key traverseallchildren | Enhancement | the current state of implicit key in react psuedo jsx 1 2 good reconcile 0 0 1 2 good reconcile 0 0 1 2 bad destroy 0 0 1 2 bad destroy 0 0 I propose array set should ignore tail sub array indice with value 0 and if the root be an only child t... |
facebookreact | render markup root should be add to reactmount node cache | Enhancement | reactmount cache all child for each parent it visit this avoid bad case exponential cost however use of reactdomidoperation for update force reactmount to populate the cache with the previous child if a newly render node need to be find then the child of the parent of the newly render root have to be... |
facebookreact | de register null component flag for rootnodeid when we remove a composite component | Bug | when react render a composite component it register if the result of the render result in an empty element represent by empty noscript tag if the component be remove this registration be never remove this pull request fix that problem see the follow jsfiddle for an example of one of the possible implic... |
facebookreact | replace setinnerhtml with danger dangerouslyupdateinnerhtml use createnodesfrommarkup | Enhancement | relate issue 2273 fix 2247 replace 2249 setinnerhtml and createnodesfrommarkup be two separate solution to solve largely the same problem createnodesfrommarkup solve more edge case this pr replace the gut of setinnerhtml with createnodesfrommarkup instead and move setinnerhtml... |
facebookreact | move repeat code to removeallchildren | Enhancement | what the title say x test plan grunt test |
facebookreact | nasty ie8 user input bug | Bug | 1 use backspace delete paste cut in the input field 2 undo notice the entire document revert 3 redo or type something 4 boom react will throw an invariant and stop to function as the dom have mutate normally when the dom update ie8 will clear the undo history of all input however that do not happen... |
facebookreact | reactdominput unnecessarily traverse to its node on mount | Enhancement | l86 it should be preferable to just access this rootnodeid directly |
facebookreact | unhelpful error when two react component be responsible for update the same div | Enhancement | I be a moron and have two separate react component both responsible for the same div var component1 react createclass render function react rendercomponent document getelementbyid my div return some stuff go here it wasn t quite as obvious as tha... |
facebookreact | avoid unkown runtime error on ie8 script tag | Bug | it seem that set innerhtml of raw text element or manipulate child node can trigger unknown runtime error in ie8 |
facebookreact | extend lifecycle and direct communication in component tree | Question | we want to extend the life cycle of react component by give child those that have be declare in this prop child the opportunity to vote on whether they be ready to be render or not in an asynchronous fashion we want to postpone the actual rendering until all of they be ready one of the usage would be show the... |
facebookreact | safari 6 bug attempt to assign to readonly property | Bug | specific to safari break update js addon in this place if all command set hasownproperty k all command set k nextvalue k update value k spec k can be fix with if all command set hasownproperty k all command set k if string boolean I test typeof ... |
facebookreact | accept iterable and collection as child | Enhancement | react currently accept array as child var array span it would be excellent if we can generalize this concept to accept both collection and iterable collection such as set map or immutable js s variant can be identify if they implement value and the result of call value b... |
facebookreact | drop upper casing of reactdomcomponent tagname | Enhancement | l113 it work well for visually highlight html tag in print but it s somewhat weird for svg and web component also because it s a public property that could be use for other purpose this would also mean that we can drop the internal tagname and just use tag unless there be other consideration |
facebookreact | generate xml compatible markup | Enhancement | take the alternative approach discuss in 2161 I think we can take advantage of the self closing information we already have in reactdom and make use of in reactdomcomponent cc audreyt in case you re interested in take a stab at this |
facebookreact | add well guard for nest rendering | Enhancement | this issue demonstrate the problem I have as you can see both case be not handle the same way warning unmountcomponentatnode render method should be a pure function of prop and state trigger nest component update from render be not allow if necessary trigger nest update in componentdidupdate ... |
facebookreact | replace setinnerhtml with createnodesfrommarkup getmarkupwrap | Enhancement | from 2249 I find that setinnerhtml and createnodesfrommarkup which call getmarkupwrap both solve largely the same problem and include the same fix for ie8 submit this issue as a reminder to myself and for your information |
facebookreact | disable viewportmetric unless mouseevent lack support for pagex pagey | Enhancement | for 1300 only ie8 lack pagex pagey and perhaps really old ff or w e I guess test plan not yet want your input on the pr first if approve will need to make a manual test and verify in all browser from my issuecomment 52509117 l65 l165 that make no sense at all to I ... |
facebookreact | reactdomcomponent should not accept child for void element | Bug | throw invariant for void element with child I e text void element also avoid all overhead relate to process child prop menuitem be a void element but still require the closing tag to combat browser behavior after much back and forth I choose to use menuitem null to set this special behavior... |
facebookreact | improve and simplify findcomponentroot do not optimistically traverse foreign node | Enhancement | base on code from 1570 supersede 2261 2005 for why I think optimistic traversal of foreign node be bad improved and simplify implementation of findcomponentroot make less use of the hacky reactinstancehandle once parentcomponent make it appearance one way or another the dependency on ... |
facebookreact | simplify reactdomcomponent child logic | Enhancement | I find it quite hard to convince myself that the logic of createcontentmarkup and updatedomchildren didn t have inconsistency for edge case so I decide to simplify and homogenize the implementation so that they be more easily understand imho x test plan grunt test raw gz compare t... |
facebookreact | well svg support for namespaced attribute | Bug | we be try to use react for a svg document but we be face problem for namespaced attribute for instance this element can not be construct with react we can not build a jsx for a xmlns xlink attribute be there any way to solve this |
facebookreact | replace ufeff with for setinnerhtml to avoid uglifyjs bug | Bug | 2247 and mishoo uglifyjs2 556 this be obviously quite a serious bug and even if uglifyjs fix it old version will still be around to haunt people who minify themselves the comment should explain everything the char be immediately remove so it should never affect render test plan none should test in ... |
facebookreact | minify version break in ie8 | Bug | line 66 of setinnerhtml l66 node innerhtml ufeff html be minify as e innerhtml t in react min js and react with addon min js an exception be throw on on line 71 l71 because textnode datum be undefined here s a repro that s modify from the basic example js ... |
facebookreact | onchange not fire with virtual keyboard | null | hey all write a kiosk type app in linux it s for a touch device and I need a virtual keyboard I find a great chrome extension at the extension work fine but react s onchange doesn t recognize it the extension be js base and it dispatch keydown keyup keypress and change event itself and naturally ... |
facebookreact | remount reactdominput when change type | Bug | ie8 throw if you change input type it apply to all value of type even unsupported one js react rendercomponent document body react rendercomponent document body error for attribute could not get the type property this command be not support error for property this command be n... |
facebookreact | inifinite recursion can be cause when lifecycle method trigger a re render | Enhancement | if lifecycle method cause re render we can potentially end up in infinite recursion I ve see this happen somewhere in a big application and it be difficult to find I m not sure there s anything react could do to prevent these case though two reduce example |
facebookreact | html5 input type number doesn t work with empty value | Bug | here the sample the value of the input should be always empty but it only work for number value if I type not numeric value they appear |
facebookreact | proper react minification | Question | I m wonder about the good way to minify react for production build the guide christianalfoni write for 2046 be very comprehensive so I use it as a boilerplate however after add envify uglify and uglifyify my build be 131 kb 5 kb big then the standard react min js uglifyify doesn t seem to be do a... |
facebookreact | backbone jquery style alternative notation for setstate setprop | null | be able to do this setstate key value callback when you re only change a single item would make thing a little more readable in my opinion thought when the title say backbone jquery style notation I m refer to target css color red be an alternative to target css color r... |
facebookreact | en dash cause onchange to fire in ie11 on render | Bug | I don t know if this be an issue with react or ie11 but when an the input initially contain an en dash 8211 it fire the change event jsfiddle |
facebookreact | video component do not support medium event | Bug | for what medium event there a good place might be under medium event in particular event like oncanplay oncanplaythrough and ondurationchange |
facebookreact | on reactlink checkedlink | null | reactlink and checkedlink be support in the default react js file but be mean for the linkedstatemixin of the react with addon js file can support for these attribute be move to the addon I ask this with the goal of allow any addon to provide a link attribute which I m not sure be possible c... |
facebookreact | reactjs support for ie6 ie7 reimplemente | null | after discussion in pl2133 I have make a light implementation of changeeventplugin to support ie6 ie7 so it do not break exist behaviour of all other browser follow change be make to support old ie browser ie6 and ie7 1 algorithm to distinguish user event value change and js value change on input and textarea... |
facebookreact | inner require field in shape prop not report properly | Enhancement | see this example the console only report warn require prop bar be not specify in hello it should probably report the whole path to the inner field such as test bar |
facebookreact | setstate callback in componentwillmount should get call | Bug | spicyj you know what s up |
facebookreact | jsxtransformer doesn t handle element with as content | Bug | expect all three of the below work jsxtransformer transform jsx react dom jsxtransformer transform jsx react dom jsxtransformer transform jsx react dom actual only the last one work the other two throw different error jsxtransformer transform ... |
facebookreact | child key not take into account if only set on render | Invalid | I get the famous each child in an array should have a unique key warning when I set key on child item only in their render method and yes if I inspect the dom the key be not set after some debug I realize that key be expect on child item before their render method be call which be not very optimal sinc... |
facebookreact | whitespace in option element before property variable trigger invariant violation | Bug | here be a minimal example that trigger the error remove the whitespace before key from option push key to option push key make it work I attach a couple of screenshot of the content of option in console log option with whitespace which trigger the error screen shoot 2014 0... |
facebookreact | ie8 do not have a setter for property enctype | Bug | js f document createelement form f enctype multipart form datum console log f enctype console log f encode console log f getattribute enctype output on ie8 log multipart form datum log application x www form urlencode log application x www form urlencode wher... |
facebookreact | define a well way to add miss jsx tag or react node | Duplicate | there be svg tag like and few other standard tag which didn t find its way into react I request you to provide a simple api to add an exist and standard html5 tag |
facebookreact | support for medium event | Enhancement | currently no medium event be support which make work with audio or video tag in react a pain in the ass js componentdidmount function var audioelement this ref audioobject getdomnode audioelement addeventlistener progress this updateprogress audioelement addeventlistener tim... |
facebookreact | contenteditable element and caret position jump | null | hi I don t think if this be really a bug nor if this can be fix easily but this be an annoying behavior see the cursor jump unexpectedly as the contenteditable element be rerendere do this mean that we should always use contenteditable element as uncontrolled component |
facebookreact | attach event per react container root rather than on the document | Enhancement | nathansobo will that help your event perf issue a bit I m not familiar with atom s plugin infrastructure but this ll help if you have two rendercomponent s doesn t help if you have though but I have some idea to optimize event a bit more this be nonetheless an ok idea I think spicyj |
facebookreact | createclass behavior | Question | javascript var foo createclass componentwillmount function alert mount foo componentwillunmount function alert unmounted foo render function return react dom div hello this prop name var bar react c... |
facebookreact | resolve implicit thead can lead to invariant violation | Bug | internet be more or less unavailable for I right now so can t test more thoroughly but think about it it seem that the blind jump we do now to detect and resolve implicitly add element mainly thead appear to not actually be safe as be personally I feel like the solution be to not resolve implicitl... |
facebookreact | object assign polyfille in environment | Bug | l23 l23 this go against our policy afaik for deal with polyfill shim if we want to ship the polyfill it should be return and not shim the global object |
facebookreact | merge adjacent reacttextcomponent in flattenchildren | Enhancement | include 1988 so click on the last commit below to view actual change this pr be a super simple isolated implementation for merge adjacent reacttextcomponent just before render so this do not affect this prop child or clonewithprop it s currently not re entrant it be really easy to fix simply by... |
facebookreact | provide a friendly path for reactid error in reactmount | Enhancement | dissect from my 1570 provide a human friendly path instead of just a rather opaque reactid chrome still have intermittent issue with long error message be truncate but this be supposedly fix again in chrome 37 no other browser should have issue display the full error message now that we have friendly e... |
facebookreact | don t add top level event for uncontrolled input | Enhancement | the document wide handler for native event that perform synthetic event dispatch execute in 0 2 0 7 millisecond on my machine I realize this doesn t seem like much time but we re really try to shave off any non essential source of latency for type and cursor movement in atom and every little bit help disable sy... |
facebookreact | reacttextcomponent s string prop clash with clonewithprop | Bug | the effect of this can be see in this gist which use react bootstrap relevant excerpt from the source l80 l19 l149 I m try to fix this in the boostrap lib but it do seem like a bit of a gotcha anyway be there a document way to decide if clonewithprop be safe to do or be this suppose to just work... |
facebookreact | key event issue | Bug | msg reactjs vjquipxl1oy hve10cu8sycj document a few thing that be confusing and seemingly break around key event let s fix clarify thing here cc syranide salier |
facebookreact | unnecessary reflow due to setstate in componentwillreceiveprop | Enhancement | see mailing list post reproduce below for convenience the follow reduce test case jsfiddle have an unnecessary reflow javascript var input react createclass getinitialstate function return text this prop text componentwillrec... |
facebookreact | run two copy of react on a page can give error because both use i d 0 | Bug | maybe we can do something smart with the root index generation on the client side seem like this should work |
facebookreact | jsxtransformer do not provide an event for when script be fully load | Duplicate | if I have page that mix both jsx script which use jsxtransformer js and js script then jsx script get load after js script so if I have then I can not refer to react class create inside component jsx in app js my workaround be to rename app js to app jsx jsxtransformer should have some kind of... |
facebookreact | unexpected behaviour on input element onkeypress event | Bug | here s the element I have react dom input onkeypress this onkeypress onkeypress function event if event keycode 13 enter key event preventdefault with react 0 10 preventdefault be work on 0 11 with the focus on the input press enter do a form submit and reload... |
facebookreact | lifecycle method name | null | if you take a look at the api of a component you get thing like render prop getinitialstate and that s fine however lifecycle method be all name like if the component be talk about itself use the third person componentwillmount shouldcomponentupdate can t we use normal method name here too... |
facebookreact | mutate content on ie8 throw | Bug | react rendercomponent react dom noscript null 1 document body react rendercomponent react dom noscript null 2 document body execute that and it go boom ie8 throw away all child of noscript after render and violently scream if you in any way try to add child afterwards should you be mu... |
facebookreact | support important for style | null | we currently don t support important as it have to be set use style setproperty name value priority this should be trivially easy to implement if it s something want to support although I m not sure about the performance implication edit 1886 although I can t imagine it would be measurable ... |
facebookreact | expose event altgraphkey | Enhancement | at least ie9 doesn t expose event altgraphkey but support it via event getmodifierstate altgraphkey |
facebookreact | idea escapetextforbrowser test string for unsafe char before escape | Enhancement | short string long string rough performance figure in ie8 and chrome testing and not escape result in 100 200 short 30 70 long testing and escape result in 33 short and long performance gain by this pr naturally increase for short string and decrease for long string consider that mos... |
facebookreact | update in componentdidmount not batch for initial render | Bug | spicyj know what s up this be just a reminder crappy code to reproduce performance wise this should generally be a minor issue as any additional update will be properly batch as be demonstrate in the gist above |
facebookreact | rfc introduce more dom property definition | Enhancement | tabindex be an integer positive or negative add have numeric value rowspan and colspan be integer but only non negative which I assume would necessitate have nonnegative value spellcheck be boolean with a third indeterminate state so have tristate value would need to be add un... |
facebookreact | avoid unnecessary object allocation in classset | Enhancement | l36 if we get rid of object key we save one allocation for a potentially commonly use function except for you guy run your internal transform yes no |
facebookreact | where to put my state that be use in several component | Question | I make a tiny app for tower of hanoi and run into this problem repo tiye I react hanoi as I drag disk to different stack the hover stack should give some feedback like dim its background color and I have to add a class to that stack and remove tha class when disk leave stack need to know that state ... |
facebookreact | react doesn t handle duplicate ref well | Bug | if you presumably accidentally use the same ref on two component and then remove the second one you would expect the ref to point to the first one but it doesn t either this test should pass javascript it should work when remove a ref with a duplicate name function var component react cre... |
facebookreact | help with jsx js transform without nodejs | Question | I d like to convert jsx file to js file on a linux machine which have no direct internet access all of the example talk about run npm which obviously win t work in this case be there any alternative for I ideally I would like to use the watch method of the jsx executable to do all of the heacy lift beh... |
facebookreact | question regard todomvc flux example and dispatching of action | Question | I be unsure where to ask this let I know if I should post it somewhere else I have a question regard todomvc flux example and the dispatching of action in flux I be watch a video describe the flux architecture and the presenter mention at 12 20 t 740 that once an action go to the store you can t pu... |
facebookreact | setstate callback in componentwillmount | Bug | call setstate in componentwillmount doesn t behave as I would expect here a fiddle demonstrating in short the callback be invoke before the state have be update |
facebookreact | flux how do you test it or use multiple instance when you have a singleton like in the todostore js | Question | I ve read but how do you test it or use multiple instance when you have a singleton like in the todostore js be a well choice to instance the store and pass to sub view |
facebookreact | iframe onload event with react | Bug | I have the follow iframe element render in one of my react component html I have try add onload event as well as attach onload directly to dom like so js this refs iframe getdomnode setattribute onload this geturl where geturl be the function of my react component ... |
facebookreact | control input cursor jump when use with layer | Bug | see try type at the beginning of the text box |
facebookreact | renderedchildren can get out of sync with dom when render throw | Bug | reactmultichild doesn t properly handle error that be throw when render child if one child throw then the other child be update at the same time can have inconsistent value store in renderedchildren which can cause problem with future update it s unclear the good way to solve this |
facebookreact | dangerouslyreplacenodewithmarkupbyid use getnode on an unmounted purge i d | Bug | l165 call getnode on an i d which be unmounted and purge l1134 sebmarkbage spicyj indicate that you be work on a refactor perhaps you ve already fix this ps I m not really sure how to fix this without take out the big hammer |
facebookreact | add support for head prefix attribute | Enhancement | hi guy since facebook be use the prefix attribute on the head element to declare open graph namespace could we add it to the list of support attribute this would be useful when generate template with see this link too for more detail |
facebookreact | provide a build with require polyfill or a separate react polyfill js | Enhancement | right now somewhere bury on the react site there s a list of polyfill that react require with link to a project that have they intermingle with a bunch of other it would be nice if react optionally ship with all the polyfill and only the polyfill it need to function this would make it easy for peo... |
facebookreact | transitionleave false do not properly bypass the need to have a transition leave animation | Bug | as the docs state reactcsstransitiongroup keep dom element on the page until an animation complete thus necessitate a leave transition if you want an enter animation but no leave animation you can specify transitionleave false however dom element still seem to stick around and occasionally throw the t... |
facebookreact | onchange handler for radio button do not fire accord to spec | Bug | as describe on the onchange handler of an input should fire when the check state change however it actually fire when the radio button be click in other word it fail to fire when a check radio button be unchecked by check a different radio button and it fire even without a state change when a check rad... |
facebookreact | componentdidmount run once | Question | hi I m try to do something always after render but the componentdidmount only call once after the state change and after render be there any way to run a method always after render even the state or prop change |
facebookreact | react rendercomponenttostaticmarkup doesn t generate select attribute from value defaultvalue | Bug | I m use static markup for unit test newform output and I d also like to support use it to render form as static html add a value or defaultvalue to a doesn t generate static html with the appropriate select attribute however they do get generate if you manually add they to component bu... |
facebookreact | ref should be update even if shouldcomponentupdate return false | Bug | I m reorder a list of component and change their ref to refer to their index but nothing else about they would be nice if the ref update which they don t appear to do currently |
facebookreact | use default prop when prop specify be null or undefined | null | the undesired behavior can be see here this commit patch react to treat null and undefine more similarly in the case of default prop |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.