repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
facebookreact
make react createclass warn throw if mixin contain undefined value
Enhancement
code below could be a result of a typo in a mixin name or an attempt to use a mixin from a module which have no module export by a mistakte var component react createclass mixin undefined it would be nice if react can warn throw on such condition
facebookreact
react track scroll position internally and force synchronous layout
Enhancement
react add a scroll listener that track and cache the scroll position I assume for some undocumented internal purpose additionally the scroll listener force a synchronous layout see screenshot this seem wasteful especially consider that the value track be never expose in the api what be the scroll liste...
facebookreact
rendercomponenttostaticmarkup vs rendercomponenttostre
Question
please give an example which show the difference of rendercomponenttostaticmarkup vs rendercomponenttostre
facebookreact
error invariant violation reactmount two valid but unequal node with the same datum reactid
Bug
tl dr fix load polymer js first issuecomment 38501176 probably relate to 1107 when a select or input type checkbox be render inside an unwrapped polymer element s child node the follow error be throw error invariant violation reactmount two valid but unequal node with ...
facebookreact
react shouldn t bind wheel or touch event to the document
Enhancement
react bind touchmove touchstart touchend touchcancel and wheel handler to the document when the user try to scroll the browser need to execute these event handler to ensure event preventdefault be not call this mean scrolling will stall while javascript be execute chrome have a fast path that check whet...
facebookreact
noscript content cause invariant violation
Bug
when use server render put an in a seem to invariably cause an invariant violation it can t find the image I believe this be because to the js enable browser the noscript content look like cdata this can be work around by use dangerouslysetinnerhtml to actually set the content to an html stri...
facebookreact
switch from dangerouslysetinnerhtml to child
Bug
I trip on a strange error when in one state a component use html to specify child from render markdown and in another state it use child component for interactive content itself with some inner html I reduce the testcase down to this
facebookreact
mobilesafariclickeventplugin require touch event to be initialize
Bug
event do not trigger when node do not have cursor pointer style on it here you have an example
facebookreact
react child onlychild throw on text child
null
text child be a string so isvalidcomponent fail would it make sense for it to accept a string frankly I m confused by this api
facebookreact
unmounte react node
Question
I m try to unmount a react js node with this rootnodeid handleclick function react unmountcomponentatnode this rootnodeid but it return false the handleclick be fire when I click on an element and should unmount the root node I ve try this as well react unmou...
facebookreact
be send state of current component as a parameter to another external method possible
Question
submit
facebookreact
ignore whitespace in the container element when reuse markup
Bug
at the moment if there s any whitespace around a pre render component inside it s container the html win t be reuse this be because getreactrootelementincontainer use node firstchild which will return a text node instead of an element node in this case for example this html win t be reuse ...
facebookreact
batch of external event
Duplicate
react batch all component update if they become dirty during an event callback event be also batch however this be not expose for use with external event such as settimeout addeventhandler ajax reply non react dom event or any other event and it seem only natural that it should extend to those too...
facebookreact
cursor jump to end of control input
Invalid
when an input element be control by a model the cursor will jump to the end of the line on every change this make it impossible to edit text that be not at the end of the input a quick demo var exampleapplication react createclass render function var model this...
facebookreact
unit testing react backbone without phantom js
Question
this be closely relate to 455 but not entirely the same I m curious how one d go around to testing browserifie backbone react app it appear that react doesn t play well with phantomj so I m look for alternative jsdom be next on the list and I m look for suggestion how to properly handle this ...
facebookreact
feature test during start up instead
Enhancement
could for instance be simplify to the below code and even if many of these test be to be do during start up the effect should be immeasureable by comparison even ie8 can manage to create 250 000 element a second and it seem like we could simplify the code slightly by do it like this since we still use ...
facebookreact
gh page docs switch between jsx and js
Duplicate
would it be possible to have a button on the website example that compile or switch jsx to js example I m happy use straight js and more likely to adopt one new thing for an experiment than two there be probably other in the same boat
facebookreact
iframe s reinitialise when move down within a group of component
Bug
when move a component with an iframe down within a group of component it reinitialise the iframe the iframe only reinitialise when move down move upward seem to work fine example
facebookreact
only run test build from file that exist in src
Bug
right now we run any test we find in build module which include test still sit around from previous build that don t currently exist in src cc subtlegradient spicyj
facebookreact
detect vendor prefix for css numeric value detection
Bug
if we add support for flex in 836 we need to support vendor prefix as well right now we just hard code the list of property and check the object l24 to see if we should allow a numeric value unchanged flex will need to support check vendor prefix value so I think we should change our lookup we...
facebookreact
support flex css property well
Bug
fir it s unitless I ve see a hack where the value be be specify as 1 to make it pass the isnan check and skip our adding of px further flex be actually a shorthand property so we should support the expansion into the right property
facebookreact
well error for bad setstate argument and mergehelper
Enhancement
fix 820
facebookreact
wishlist integrate stateful routing
Enhancement
here s my idea please let I know if it s any good route in a single page app basically just represent state or prop depend on your perspective and no one do state well than react which make I think that react will be awesome at route management I ve take a stab at make a single page app in react u...
facebookreact
make reactmarkupchecksum canreusemarkup injectable to save byte
Enhancement
original description by petehunt right now even if you aren t use server render you re pay the price of adler32 bytes down the wire we should instead make this injectable
facebookreact
set target property explicitly for enter leave
Bug
fix 785
facebookreact
d3 js example use react
Question
not sure if this be the right place to ask but be there any example of use react to render a visualization create in d3 js it seem like react s virtual dom could really speed up animation and transition use in visualization like the force direct graph d3 js just draw svg so as long as react can manipulate s...
facebookreact
check for selection on keyup instead of defer
Enhancement
this be essentially what we do for the change event in ie8 and ie9 already
facebookreact
dev vs env production
Question
be there a reason why these two coexist beside the fact that the latter seem to be introduce recently
facebookreact
source map support for jsx binary
Enhancement
would be nice
facebookreact
add onmouseover and onmouseout event
Enhancement
fix 340 test plan port danielstock s jsfiddle link in the issue to react and the hover effect work properly
facebookreact
set currenttarget on synthetic event
Bug
fix 658 fix 659
facebookreact
can not specify default select option for
Invalid
js jsx react dom var multipleselect react createclass render function return a b c react rendercomponent document body expect option a b and c be select by default but they be not
facebookreact
fix scrollleft scrolltop warning in late chrome
Bug
chrome give the warning body scrollleft be deprecate in strict mode please use documentelement scrollleft if in strict mode and body scrollleft only if in quirk mode body scrolltop be deprecate in strict mode please use documentelement scrolltop if in strict mode and body scrolltop only if i...
facebookreact
grunt test webdriver saucelab ios error error response status 13
Bug
grunt verbose debug 9 stack test webdriver saucelab ios run webdriver jasmine saucelabs ios6 1 webdriver jasmine task d task source user aylott project facebook react gruntfile js verify property webdriver jasmine saucelabs ios6 1 exist in config ok file no file desiredca...
facebookreact
immutableobject should tolerate array at deep level and prevent mutation on they fail in safari
Bug
not ok 382 util test immutableobject test immutableobject should tolerate array at deep level and prevent mutation on they dev l3829
facebookreact
onscroll doesn t work in ie8
Bug
here s an example no jsfiddle because that s break in ie8
facebookreact
jsx tool return zero on error
Bug
I m use the jsx tool in an automate build system and I want to check for error compile jsx file but instead of return a non zero error code the jsx command just write everything to stderr and exit with a zero error code what be even bad stderr be use when the build be successfull as well force I to parse it s...
facebookreact
honor instance identity the key prop for the root component
Bug
when the key prop of a component change between render pass react be expect to unmount the previous instance and mount a new one during reconciliation however when say component be the root I e whose dom parent be the mount point the same component instance be use this jsfiddle demonstrate how a stat...
facebookreact
jsx enable lazy subtree execution
Enhancement
in html certain tag stop the html5 parser from parse child e g
facebookreact
make grunt test output less noisy
Enhancement
the json format be great for sauce but not so great for run test manually in the console
facebookreact
warn event returnvalue be deprecate
Duplicate
event returnvalue be use at follow place l82 so get this warning at chrome version 31 0 1650 48 event returnvalue be deprecate please use the standard event preventdefault instead react js 11173 you may notice that same issue be report at so kindly update code to avoid this w...
facebookreact
getelementsbyclassname doesn t exist in ie8
Bug
reactmount should destroy a react root upon request typeerror object doesn t support property or method getelementsbyclassname
facebookreact
can not provide a valuelink and a value or onchange event if you want to use value or onchange you probably don t want to use valuelink
Bug
file test undefine assertlink invariant violation can not provide a valuelink and a value or onchange event if you want to use value or onchange you probably don t want to use valuelink undefined getvalue invariant violation can not provide a valuelink and a value or onchange event if ...
facebookreact
reactdominput should support reactlink in ie
Bug
reactdominput should support reactlink expect 0 to be 1 typeerror unable to get property 0 of undefined or null reference
facebookreact
reactdominput should not set a value for submit button unnecessarily fail in ie
Bug
reactdominput should not set a value for submit button unnecessarily expect true to be false
facebookreact
reactdominput should properly control a value of number 0 fail in ie
Bug
reactdominput should properly control a value of number 0 expect giraffe to be 0
facebookreact
error invalid target element for this operation ie9
Bug
render react component at document should be able to get root component i d for document node error invalid target element for this operation render react component at document should be able to unmount component from document node error invalid target element for this operation render react compon...
facebookreact
window dev should not be compile to window true
Bug
this throw a syntax error in ie8 build module util test immutableobject test js 62 javascript var testprod function message testfunc temporarily enter production mode window true false it message testfunc window true true I m not sure which code ...
facebookreact
give a button with no text on it
Bug
image pretty sure this can be fix by replace with null in reactdominput js 58 l58 but I ll check and make sure
facebookreact
script async and defer property
Enhancement
helpful for full page render
facebookreact
exception raise when pass number to prop
Invalid
hello react two number be pass to prop but with exception raise uncaught error parse error line 10 xjs value should be either an expression or a quote xjs text
facebookreact
react throw when render some html tag inside window 8 app
Bug
when use react in a javascript base windows 8 app some html tag will cause an error to be throw during mount for example an audio tag as show here cause the follow error 0x800c001c javascript runtime error unable to add dynamic content a script attempt to inject dynamic content or element previ...
facebookreact
allow namespacing in ref
null
it ll be great if one could namespace reference to backing instance return from render silly example javascript var editor react createclass componentdidmount function if this ref hasownproperty syntax for var lang in this refs syntax var editor this ref synta...
facebookreact
use the right document in iframe selection event
Bug
we use document directly a bunch where that might not be the right thing if the event be occur in an iframe we should do it right split from 373
facebookreact
jade
Question
all my dom code be write in jade any easy way to use jade in react
facebookreact
listen for event at mount point not top level
Enhancement
any event that occur on the page regardless of if it s on a dom subtree manage by react go through react s event subsystem it would be great if we instead listen at the mount point and any child document in e g iframe instead of at the top of the page
facebookreact
use mutationobserver instead of mutation event
Bug
we currently listen for domcharacterdatamodified I think only so that we can make onchange work with contenteditable apparently this can be expensive so we should look into replace it with a mutation observer obviously the api will be different and observer get batch so we may have to build some abstra...
facebookreact
nowrap doesn t work table cell
null
I be create horizontal scrolling webpage I m use table with nowrap as hack of not calculate width of screen every time it seem react ignore nowrap be there any work around
facebookreact
create sourcemap for the build
Enhancement
browserify sort of allow you to do this but it put they inline in the same file which be far from ideal we should consider work with the browserify team and make it possible to build the map outside of the bundle or do something else might be able to extract sourcemap out might have to stop use browserify...
facebookreact
send npm package to build site as well
Enhancement
have the browser package but we ve have request for the npm package as well
facebookreact
input be uneditable if the value attribute be present
Question
see here if an element be render with its value attribute already present set the input seem to be uneditable I think it might have be something in handlechange but I m not sure hopefully I m not just misuse jsx thank
facebookreact
existence of componentdidmount throw error while invoke findcomponentroot
Question
scenario I be try to use react to dynamically replace a tbody tag with my app s content in addition I need to use a componentdidmount callback to handle some custom event bind problem as soon as the componentdidmount callback be add to react createclass react throw the follow err...
facebookreact
standardize prop dom attribute process
Bug
right now we have some inconsistency which require cognitive load with the exception of dangerouslysetinnerhtml I don t think there s ever any reason not to allow any sort of type as a prop in the dom otherwise false should put false in the dom foo bar should put object object ...
facebookreact
make onchange work for contenteditable
Enhancement
apparently it doesn t but it would be pretty awesome if it do we already listen for domcharacterdatamodified so I don t think it should be too terrible tangentially it would be great to stop use mutation event and switch over to observer let s not do that here though unless it dovetail really nicely int...
facebookreact
react should support content security policy
Enhancement
react be currently incompatible with site that enable a content security policy uncaught evalerror refuse to evaluate a string as javascript because unsafe eval be not an allow source of script in the follow content security policy directive default src self 1 from some quick testing there app...
facebookreact
rowspan attribute do not appear in dom
Bug
do not set rowspan in the dom component js render function return this prop column map this rendercolumnlabel this prop column map this rendercolumncontrol output html can this be my first pr
facebookreact
consider warn when use the wrong case for an html attribute
Enhancement
like if you do the current behavior be opaque and sort of confuse for people
facebookreact
defaultvalue for select not work
Bug
value work as expect
facebookreact
radio button not work correctly
Bug
js render function return a b expect behavior would be for a to stay check when b be click but it s not the case jsfiddle similarly here a modify version that work on every subsequent click on b but not the first time if this help set a...
facebookreact
compute property
Enhancement
one thing I ve want a couple of time in react be have compute property something vaguely like ember s compute property fullname function var firstname this get firstname var lastname this get lastname return firstname lastname property firstname lastn...
facebookreact
docblock parse fail with r n
Bug
or so I ve be tell
facebookreact
set sibling state
Question
how to set state for sibling suppose if I have list item a b c d when I click a setstate select true then I wanna make other sibling b c d setstate select false be it possible
facebookreact
some lifecycle method be break
Bug
look like batch break a couple of our lifecycle method componentwillreceiveprop shouldcomponentupdate both of these get pass in nextprop and have access to this prop also state however nextprop be set to this prop before call these method so no comparison can be do master 0 4 ...
facebookreact
oncontextmenu event
Enhancement
this event doesn t exist yet
facebookreact
allow html attribute name in react dom jsx
null
the ease of start from exist mock html be a great feature of jsx however there be a few case where the html attribute be not exactly the same as the dom property name the one that catch I be while this do not raise an error the colspan attribute be silently ignore the property name must be ...
facebookreact
parse error for html entity in nest jsx
Bug
the html entity in the following cause a syntaxerror unexpected token in both current master and react 0 3 jsx react dom var mylist a b c fail with entity below react rendercomponent mylist map function i d return i d ...
facebookreact
maybe make sure we work with all trigger event
null
this come up on irc last night somebody be work have trouble test react while use trigger to test an event handler state change trigger do use synthetic event not syntheticevent s but they claim to do good effort at match real dom event the problem in this case be that the code be use t...
facebookreact
setstate and other parameter format
Enhancement
currently accidentally use this setstate title car throw an unhelpful merge core failure error would be nice to either throw a well error or accept this format same go for setprop etc
facebookreact
pass rootnode for componentwillunmount
Enhancement
just like for componentdidmount and other
facebookreact
this h3 foo instead of verbose react dom h3 null foo
null
if all react dom method be create aliase on react component instance we could use such beautiful concise coffeescript syntax
facebookreact
fix test when use phantomjs 1 9 1 1
Bug
there s an eacce error because the phantomjs binary be not executable in the late version of the phantomjs package
facebookreact
enable mock of require module during test
Enhancement
the most recurrent source of disagreement between test result within facebook and those give by grunt test be that facebook have a more consistent strategy for mock module that be not currently under test when I implement the phantomjs test harness for this open source repository for the sake of experiment and...
facebookreact
export createdomcomponentclass
null
on irc today someone be miss a tag in reactdom should we export createdomcomponent as an escape hatch
facebookreact
address emfile too many open file error for clean grunt test run
Bug
cc jeffmo
facebookreact
come up with a convention for force bin jsx rebuild without manually clear module cache
Enhancement
cc petehunt zpao
facebookreact
add a demo use coffee file to implement a react component
Enhancement
cc petehunt
facebookreact
bin jsx should not relativize require module ids unless relativize be pass
Enhancement
inspire by issuecomment 19143496 this will reduce the number of assumption impose by bin jsx considerably we should still use relativize for our grunt task but that s our poison to pick cc petehunt zpao
facebookreact
allow namespacing in component name in jsx
Enhancement
23 07 balpert can we add to jsx 23 07 jwalke I like that you choose the dot 23 07 jwalke keep it javascript first 23 07 balpert yes 23 08 balpert translate colon to dot would be absurd 23 08 balpert in my opinion 23 08 jwalke so you could have var mycomponentspackage ...
facebookreact
work with compile to js language like coffeescript
Enhancement
jsx be nice but those use compile to js language have to change the transpiler to connect to the jsx compiler be there any chance of add alternative dom syntax to jsx so it do not break every compile to js language something gettext style would be nice so in addition to var hellomessage react crea...
vuejsvue
vue 2 7 stricttemplate error
Bug
pnpm run type check src app vue 12 6 error ts2559 type onclick any have no property in common with type readonly omit never 12 find 1 error in src app vue 12 helloworld vue vue this error come ...
vuejsvue
exact modifier fail to generate render function
Bug
version 2 6 14 reproduction link 3cbutton 20 40keydown ctrl shift alt meta exact 3d 22console log 24event 22 3eclick 3c 2fbutton 3e step to reproduce use v on with ctrl shift alt meta exact modifier what be expect add event listener successfully what ...
vuejsvue
new slot syntax doesn t work the same way as old syntax in some case
Bug
version 2 6 14 reproduction link step to reproduce 1 clone the repo 2 run npm run serve 3 change the value in the text input what be expect preview update with both old and new slot syntax here l4 what be actually happen preview update wi...
vuejsvue
v if not patch component scope slot correctly
Bug
version 2 6 14 reproduction link step to reproduce click between a and b work click between a and c work click between b and c doesn t work what be expect the scope slot should update what be actually happen the scope slot doesn t upda...
vuejsvue
style display be incorrect when reuse the elm
Bug
version 2 6 11 reproduction link step to reproduce click change what be expect el style display be flex what be actually happen el style display be
vuejsvue
once modifier on input event prevent v model from update value on input element
Bug
version 2 6 11 reproduction link step to reproduce type some text in the input field what be expect the input handler be execute and the value in the input be update what be actually happen the input handler be execute but the first update to the model be ...
vuejsvue
ssr miss class and style attribute with async component
Bug
version 2 6 11 reproduction link step to reproduce run what be expect html what be actually happen html there be some workaround for this issue avoid async component via manual register the component in a pl...
vuejsvue
strange ssr behavior in v for loop with if else and v text
Bug
version 2 6 11 reproduction link step to reproduce run server open localhost 8080 problem be in component textwrapper vue file I ve use some vue ssr template and remove almost everything unneede same error as before what be expect ssr and client side version b...
vuejsvue
scopedslot be empty until render
Bug
version 2 6 11 reproduction link step to reproduce open the console what be expect scopedcomponent beforemount true to be log what be actually happen scopedcomponent beforemount false this be discover in vuetify issuecomment 705058227 ...
vuejsvue
safari doesn t see frame inside vue app
Bug
version 2 6 11 reproduction link step to reproduce in safari click different link to load iframe what be expect all iframe should load what be actually happen the one render inside vue doesn t load
vuejsvue
vue ssr v html on dynamic component hydration warn
Bug
version 2 6 11 reproduction link the reproduction be update to use vue ssr without nuxt step to reproduce dynamic vue vue app vue vue what be expect the expect behavior be for there to be no hydration warn when the ssr and client markup be identic...