repository stringclasses 156 values | issue title stringlengths 1 1.01k ⌀ | labels stringclasses 8 values | body stringlengths 1 270k ⌀ |
|---|---|---|---|
openzipkinzipkin | update sidebar and header design | Enhancement | remove sidebar and update header design before 2020 08 09 2 04 13 after 2020 08 15 18 06 20 2020 08 15 18 06 20 |
openzipkinzipkin | support build zipkin on arm64 | Enhancement | hi team I be interested in add arm64 support to zipkin there be an elasticsearch binary for x86 64 get download in the run clause of the dockerfile in zipkin docker storage elasticsearch7 dockerfile the binary be available for aarch64 as well I try replace the binary with aarch64 but build fail for zipkin cassandra 2 21 5 docker image please find my arm64 job here here be the failure log 2020 08 05 06 53 00 414 main warn zipkin2 storage cassandra v1 cassandrastorageextension couldn t connect to docker image openzipkin zipkin cassandra 2 21 5 assumption fail all host s try for query fail try 127 0 0 1 9042 com datastax driver core exception transportexception 127 0 0 1 9042 can not connect I have check in the docker hub that zipkin cassandra be only available for linux amd64 I be suspect that the further issue I be get in the arm64 build be due to zipkin cassandra docker image unavailable for arm64 error httpcalltest wrongscheme 224 expect throwable message not an ssl tls record 485454502f312e31203430302042616420526571756573740d0a636f6e74656e742d747970653a20746578742f706c61696e3b20636861727365743d7574662d380d0a636f6e74656e742d6c656e6774683a2033310d0a7365727665723a2041726d657269612f302e39392e380d0a646174653a205468752c203330204a756c20323032302031353a35323a333720474d540d0a0d0a3430302042616420526571756573740a4465636f646572206661696c757265 to contain openssl internal but do not it would be really helpful if zipkin cassandra docker image become available for linux arm64 platform as well please share your opinion on this |
openzipkinzipkin | all I need to know be can we secure zipkin s ui use username and password if yes how | Enhancement | how to secure zipkin s ui |
openzipkinzipkin | add docker build for multi arch I e amd64 arm64 arm v7 | Enhancement | please first look at exist issue to see if the feature have be request before if you don t find anything tell we what problem you re try to solve often a solution already exist don t send pull request to implement new feature without first get our support sometimes we leave feature out on purpose to keep the project small feature the available deployment target be change low cost low power arm architecture be become more and more prevalent dockerhub support these other architecture through different tag and build image multi arch build be also possible an example dockerfile be post below as well as the command to build the various image with docker edge this solution unfortunately require the layer capability of spring boot 2 3 and might not be consistent with the zipkin server current build practice rational this be not in zipkin per se however it provide more flexible deployment target for the server itself example scenario as an application developer when I want to build deploy and monitor application on an arm architecture I e rpi k8s cluster then I want to deploy the zipkin server image to k8s run on a rpi cluster prior art n a dockerfile locate in zipkin server txt from adoptopenjdk openjdk11 as builder workdir application arg jar file target zipkin server 2 21 6 snapshot exec jar copy jar file application jar run java djarmode layertools jar application jar extract from adoptopenjdk openjdk11 workdir application copy from builder application dependency copy from builder application spring boot loader copy from builder application snapshot dependency copy from builder application application entrypoint java org springframework boot loader jarlauncher build command bash cd zipkin server docker buildx build t openzipkin zipkin server late platform linux amd64 linux arm64 linux arm v7 push |
openzipkinzipkin | zipkin server log for elasticsearch error | Enhancement | feature zipkin server include a es http log set to configure log for zipkin server s http request to elasticsearch the setting can be set to basic header body by default the logging be not enable the feature request be to add a new log level that only log error with communicate with elasticsearch and to make it the default value so error logging be enable by default rational by default zipkin server do not log an error with communicate with elasticsearch this feature request would change that example scenario this feature would be use whenever there s an issue with zipkin communicate with elasticsearch in order to find out what the root cause be |
openzipkinzipkin | ui search optimize | Bug | describe the bug 1 how to change the sort condition in the ui for the first time to the default new default be long I want to see the late log 2 switch to try lens ui multiple query the late record can not be query you have to refresh the page to query the late record but the query condition disappear after the page be refresh but default search ui be not disappear 3 so I hope that the query condition be the default page and the log detailed display will use try lens ui |
openzipkinzipkin | javascript console warning fail prop type invalid prop valueref supply to durationcondition | Bug | if you click servicename then choose a duration the follow console log happen warn fail prop type invalid prop valueref supply to durationcondition in durationcondition at globalsearchconditionvalue jsx 111 in globalsearchconditionvalue at globalsearchcondition jsx 132 in div create by forwardref paper in forwardref paper create by withstyle forwardref paper in withstyle forwardref paper at globalsearchcondition jsx 124 in globalsearchcondition at globalsearchconditionlist jsx 94 in div create by style muibox in style muibox at globalsearchconditionlist jsx 93 in div create by style muibox in style muibox at globalsearchconditionlist jsx 79 in div create by style muibox in style muibox at globalsearchconditionlist jsx 72 in globalsearchconditionlist at globalsearch jsx 55 in div create by style muibox in style muibox at globalsearch jsx 54 in div create by style muibox in style muibox at globalsearch jsx 46 in globalsearch create by context consumer in withrouter globalsearch at discoverpage jsx 272 in div create by style muibox in style muibox at discoverpage jsx 270 in discoverpagecontent at discoverpage jsx 323 in discoverpageimpl create by context consumer in withrouter discoverpageimpl create by connectfunction in connectfunction create by context consumer in route at app jsx 51 in main create by style muibox in style muibox at layout jsx 132 in div create by style muibox in style muibox at layout jsx 85 in layout at app jsx 50 in router create by browserrouter in browserrouter at app jsx 49 in i18nprovider at app jsx 48 in provider at app jsx 46 in themeprovider at app jsx 43 in muipickersutilsprovider at app jsx 42 in uiconfig at app jsx 41 in suspense at app jsx 40 in app at src index tsx 21 |
openzipkinzipkin | javascript console warn each child in a list should have a unique key prop | Bug | warn each child in a list should have a unique key prop check the render method of globalsearchconditionlist see for more information in style muibox at globalsearchconditionlist jsx 93 in globalsearchconditionlist at globalsearch jsx 55 in div create by style muibox in style muibox at globalsearch jsx 54 in div create by style muibox in style muibox at globalsearch jsx 46 in globalsearch create by context consumer in withrouter globalsearch at discoverpage jsx 272 in div create by style muibox in style muibox at discoverpage jsx 270 in discoverpagecontent at discoverpage jsx 323 in discoverpageimpl create by context consumer in withrouter discoverpageimpl create by connectfunction in connectfunction create by context consumer in route at app jsx 51 in main create by style muibox in style muibox at layout jsx 132 in div create by style muibox in style muibox at layout jsx 85 in layout at app jsx 50 in router create by browserrouter in browserrouter at app jsx 49 in i18nprovider at app jsx 48 in provider at app jsx 46 in themeprovider at app jsx 43 in muipickersutilsprovider at app jsx 42 in uiconfig at app jsx 41 in suspense at app jsx 40 in app at src index tsx 21 |
openzipkinzipkin | remove plural library to restore chinese support in len | Bug | fix |
openzipkinzipkin | howdy excuse I do zipkin support rocketmq | Duplicate | howdy excuse I do zipkin support rocketmq look forward to you reply thank you very much |
openzipkinzipkin | zipkin ui show blank page if endpoint servicename be empty | Duplicate | zipkin ui show blank page if we use an empty service name how to reproduce set an empty string for zipkin newendpoint function zipkin newendpoint 127 0 0 1 8080 chrome console output react dom production min js 209 typeerror can not read property map of undefined at tracestablerow jsx 141 maybe we can null check in this line l142 |
openzipkinzipkin | zipkin slim complain noclassdeffounderror when set up es credential file | Bug | describe the bug when set up es credential file to enable credential file for zipkin slim a java lang noclassdeffounderror com google common util concurrent threadfactorybuilder be raise the exception be from l166 which leverage guava threadfactorybuilder to build a thread factory for credential file refresher I find that s because guava be exclude from slim l510 there seem two path to fix it 1 remove threadfactorybuilder to get rid of guava dependency 1 add guava back to slim I prefer the first approach adriancole wdyt |
openzipkinzipkin | standard init linux go 211 exec user process cause exec format error | Bug | describe the bug when pull the image openzipkin zipkin 2 21 1 to our kubernete machine I m get the follow error standard init linux go 211 exec user process cause exec format error here be the uname a linux zipkin 5f956c997d njn8c 4 19 56 1 el7 x86 64 1 smp we d jun 26 23 17 23 utc 2019 x86 64 x86 64 x86 64 gnu linux here be the output of describe the pod mirror name host name namespace change to make this generic event type reason age from message normal schedule default scheduler successfully assign my namespace zipkin 7f86b97487 xcblh to my machine com normal generate 16 appcertfetcher application certificate generate normal pull 16 kubelet my machine com pull image my mirror com openzipkin zipkin 2 21 1 normal pull 10 kubelet my machine com successfully pull image my mirror com openzipkin zipkin 2 21 1 normal create 9s x2 over 10 kubelet my machine com create container zipkin normal pull 9s kubelet my machine com container image my mirror com openzipkin zipkin 2 21 1 already present on machine normal start 8s x2 over 10 kubelet my machine com start container zipkin warn backoff 7s x2 over 8s kubelet my machine com back off restart fail container step to reproduce attempt to pull the image openzipkin zipkin 2 21 1 image pull successfully but then result in the above error message when it attempt to start expect behaviour I would expect the image to start up successfully in this environment I m unclear why these machine be give this error consistently the error do not appear to be tie to this specific version of zipkin |
openzipkinzipkin | zipkin lens ui search bar add criterion bug | Bug | describe the bug zipkin version 2 21 1 url browser chrome microsoft edge es version 7 6 2 how to run curl ssl bash s es index shard 1 es index replicas 0 es timeout 20000 storage type elasticsearch es host java jar zipkin jar zipkin ui basepath ui zipkin when I search trace by servicename use zipkin ui I can not add any criterion in search bar once I type some thing then click add button or search button the criterion delete somehow automate maybe this cause by I be use a high version of es step to reproduce expect behaviour please let I know how to fix it |
openzipkinzipkin | support unverifie elasticsearch ssl connection | Bug | hello I want to link zipkin with kafka as collector and elasticsearch as storage I deploy zipkin on kubenete and use the last image image openzipkin zipkin late here be the deployment file spec container name zipkin image openzipkin zipkin late port containerport 9411 protocol tcp env name kafka bootstrap server value 192 14 20 1 9091 name storage type value elasticsearch name es host value name es index value zipkin distribute trace name es username value elasicuser name es password value elasicpass kafka collector work well without problem but elastisearch do not work here be zipkin s health status down zipkin status down detail elasticsearchstorage initialendpoint index zipkin distribute trace status down detail error java lang illegalstateexception couldn t connect any of endpoint elastic k8s cloud com 443 ipaddr 192 14 20 2 weight 1000 kafkacollector bootstrapserver 192 14 20 1 9091 topic zipkin status up do I have to modify the variable know that the elastisearch host use self sign ssl be there a way to disable ssl validation thank you |
openzipkinzipkin | enhance ux of searchbar and make code simple and more streamlined | Enhancement | resolve 3007 I think the current search bar have the follow problem because it use external library such as react select the design and keyboard operation be not fully control by lens side the implementation be more complex than it need to be the design be also a bit confusing especially lookback and limit it be hard to make unit test because its implementation be too complex so I decide to reimplement it from scratch this pr will accomplish the following independence from difficult to control external library code will be simple and the code line will be few become testable ui will probably be easy to understand it will be more extensible customizable in the future because it do not depend on external library typescriptize search bar gif lookback lookback searchbar searchbar |
openzipkinzipkin | miss localendpoint crash len | Bug | describe the bug I run into some admittedly bad datum that can crash recent version of lens json traceid 0b3ba16a811130ed parentid 0b3ba16a811130ed i d 37c9d5cfc985592b kind server name get timestamp 1587434790009238 duration 10803 remoteendpoint ipv4 127 0 0 1 port 64529 tag http method get http path api mvc controller class backend share true traceid 0b3ba16a811130ed parentid 0b3ba16a811130ed i d 37c9d5cfc985592b kind client name get timestamp 1587434789956001 duration 74362 tag http method get http path api traceid 0b3ba16a811130ed i d 0b3ba16a811130ed kind server name get timestamp 1587434789934510 duration 103410 remoteendpoint ipv6 1 port 64528 tag http method get http path mvc controller class frontend screenshot 2020 04 21 at 10 06 51 am step to reproduce you can post this datum and click search expect behaviour shouldn t crash |
openzipkinzipkin | fix 3052 | Bug | fix 3052 as point out 3052 when something be put to the input of datetimepicker it will often barf so disable input and force user to enter the date time use a calendar dialog probably this be well ux |
openzipkinzipkin | fix 3058 | Bug | fix 3058 |
openzipkinzipkin | use typescript for dependency page | Enhancement | I think the entire code in lens should be rewrite in typescript as typescript greatly improve the maintainability of the code but that s too much of a change so we ll start it off on the dependency page as a first step dependency page be the simple page in lens also some of the logic and css wasn t very good so I fix that too dependency |
openzipkinzipkin | long service name should be wrap | Bug | similar to log against classic ui lens could wrap long service name where need see the gif with an example of a really long service name include below for test convenience long text traceid 77047bf9cf04ed5d i d 77047bf9cf04ed5d name get timestamp 1484722951945904 duration 156470 annotation timestamp 1484722951945904 value sr endpoint servicename com alipay sofa tracer demo facade rpccallservice okay we can go a bit far to see how lens cope with this timestamp 1484722952102374 value ss endpoint servicename com alipay sofa tracer demo facade rpccallservice okay we can go a bit far to see how lens cope with this traceid 77047bf9cf04ed5d i d 40ef4e93ab3b1507 name get parentid 77047bf9cf04ed5d annotation timestamp 1484722952100852 value cs endpoint servicename com alipay sofa tracer demo facade rpccallservice okay we can go a bit far to see how lens cope with this |
openzipkinzipkin | allow config to disable the lens ui dependency page | Enhancement | the dependency page only work in a production cassandra es deployment when accompany with a specific aggregation job since not all customer deploy such a job or even need it it would be nice if we can disable the lens ui dependency page through zipkin configuration |
openzipkinzipkin | download json via ui | Enhancement | we find it useful to have the json button in the lens ui also to download the raw datum for a trace |
openzipkinzipkin | lens get wobbly | Bug | in firefox ubuntu there seem to be some instability in the layout when you mouseover on the right most search criterion gif explain it much well wobbly |
openzipkinzipkin | order service name in dependency page | Enhancement | similar to 2204 the list of service name in the dependency page could be order make for a nicer ux |
openzipkinzipkin | flickering list of trace in chrome | Bug | describe the bug in chrome only after a search the list of trace flicker it occur only for maximised window but very annoying step to reproduce open zipkin in a maximised chrome window select a service which contain some trace search the list of trace start flicker |
openzipkinzipkin | error while try to use openzipkin with elastic search engine | Bug | hi I be try to start an open zipkin stack with docker and elastic search as data storage engine I be use openzipkin zipkin elasticsearch7 image for start elasticsearch7 however start the container fail and in the log section there be this error elasticsearch bin elasticsearch elasticsearch bin elasticsearch env line 113 syntax error unexpected word expect |
openzipkinzipkin | ephemeral credential support e g hashicorp vault | Enhancement | feature some company require the usage of ephemeral credential for storage resource as for instance hashicorp vault provide it would be great if we can add the ability to watch a credential file for item like username password token etc and allow update to these while zipkin be run and try to connect to storage solution like elasticsearch and cassandra rational not support ephemeral credential be a blocker for some company to approve usage of zipkin in production example scenario prior art similar effort have be make in skywalke secret management file of elasticsearch authentication |
openzipkinzipkin | lens hover over download json button could show rest url to fetch trace | Enhancement | feature when hover over the download json button it seem intuitive to show the full link to the trace ie in the browser status bar just as if you would hover over a normal href rational I could not remember the location of the swagger api definition at I want to fetch a trace use curl jq so I look at the download button hope to find the rest url there |
openzipkinzipkin | pagination on the result page break | Bug | hello I just update to 2 20 2 and when do a search I get the following on the top instead of the number of result pagination 0 plural one result other result |
openzipkinzipkin | zipkin ui logsurl do not support multiple occurrence of traceid | Bug | describe the bug I be try to link kibana in zipkin ui lens the button be show correctly traceid be not replace in the url I try with simple url with multiple occurence of traceid it be able to replace the first occurence of traceid step to reproduce zipkin ui logs url discover g filter refreshinterval pause t value 0 time from now 7d to now a column source filter state store appstate meta alia n disabled f index ca487de6 0028 4e74 b14b 65eddbcf1f5a key trace i d negate f param query traceid type phrase value traceid query match trace i d query traceid type phrase index ca487de6 0028 4e74 b14b 65eddbcf1f5a interval auto query language kuery query sort timestamp desc expect behaviour zipkin ui should able to replace multiple occurence of traceid |
openzipkinzipkin | scribecollector can t save span to es | Bug | I collect span from hbase with htrace and try save it to es but fail it be ok when I use memory as the storage stack info look like below can not store span 19ba72f97acc30e1 38f05b503270feec 19ba72f97acc30e1 e9e49ea88d070cb3 19ba72f97acc30e1 a5258adac1aaa5f0 due to runtimeexception attempt to make a blocking request from an event loop either use doenqueue or run this in a separate thread java lang runtimeexception attempt to make a blocking request from an event loop either use doenqueue or run this in a separate thread at zipkin2 elasticsearch internal client httpcall doexecute httpcall java 161 zipkin storage elasticsearch 2 20 1 jar at zipkin2 call base execute call java 380 zipkin 2 20 1 jar at zipkin2 elasticsearch elasticsearchversion get elasticsearchversion java 30 zipkin storage elasticsearch 2 20 1 jar at zipkin2 elasticsearch elasticsearchstorage versionspecifictemplate elasticsearchstorage java 324 zipkin storage elasticsearch 2 20 1 jar at zipkin2 elasticsearch elasticsearchstorage doensureindextemplate elasticsearchstorage java 313 zipkin storage elasticsearch 2 20 1 jar at zipkin2 elasticsearch elasticsearchstorage ensureindextemplate elasticsearchstorage java 304 zipkin storage elasticsearch 2 20 1 jar at zipkin2 elasticsearch elasticsearchstorage spanconsumer elasticsearchstorage java 230 zipkin storage elasticsearch 2 20 1 jar at zipkin2 collector collector store collector java 201 zipkin collector 2 20 1 jar at zipkin2 collector collector storespan run collector java 230 zipkin collector 2 20 1 jar at zipkin2 collector collector lambda 774 1183337655 execute unknown source zipkin collector 2 20 1 jar at zipkin2 collector collector accept collector java 136 zipkin collector 2 20 1 jar at zipkin2 collector collector accept collector java 109 zipkin collector 2 20 1 jar at zipkin2 collector scribe scribespanconsumer log scribespanconsumer java 62 zipkin collector scribe 2 20 1 jar at zipkin2 collector scribe generate scribe asyncprocessor log start scribe java 234 zipkin collector scribe 2 20 1 jar at zipkin2 collector scribe generate scribe asyncprocessor log start scribe java 177 zipkin collector scribe 2 20 1 jar at com linecorp armeria server thrift thriftcallservice invokeasynchronously thriftcallservice java 168 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thriftcallservice invoke thriftcallservice java 151 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thriftcallservice serve thriftcallservice java 132 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thriftcallservice serve thriftcallservice java 52 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thttpservice invoke thttpservice java 666 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thttpservice decodeandinvoke thttpservice java 641 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thttpservice lambda serve 3 thttpservice java 490 armeria thrift 0 98 4 jar at com linecorp armeria server thrift thttpservice lambda 771 648332244 apply unknown source armeria thrift 0 98 4 jar at java util concurrent completablefuture unihandle completablefuture java 822 1 8 0 40 at java util concurrent completablefuture unihandlestage completablefuture java 834 1 8 0 40 at java util concurrent completablefuture handle completablefuture java 2147 1 8 0 40 at com linecorp armeria server thrift thttpservice serve thttpservice java 476 armeria thrift 0 98 4 jar at zipkin2 collector scribe scribeinboundhandler maybereadpayload scribeinboundhandler java 141 zipkin collector scribe 2 20 1 jar at zipkin2 collector scribe scribeinboundhandler channelread scribeinboundhandler java 95 zipkin collector scribe 2 20 1 jar at io netty channel abstractchannelhandlercontext invokechannelread abstractchannelhandlercontext java 377 netty transport 4 1 46 final jar 4 1 46 final at io netty channel abstractchannelhandlercontext invokechannelread abstractchannelhandlercontext java 363 netty transport 4 1 46 final jar 4 1 46 final at io netty channel abstractchannelhandlercontext firechannelread abstractchannelhandlercontext java 355 netty transport 4 1 46 final jar 4 1 46 final at io netty channel defaultchannelpipeline headcontext channelread defaultchannelpipeline java 1410 netty transport 4 1 46 final jar 4 1 46 final at io netty channel abstractchannelhandlercontext invokechannelread abstractchannelhandlercontext java 377 netty transport 4 1 46 final jar 4 1 46 final at io netty channel abstractchannelhandlercontext invokechannelread abstractchannelhandlercontext java 363 netty transport 4 1 46 final jar 4 1 46 final at io netty channel defaultchannelpipeline firechannelread defaultchannelpipeline java 919 netty transport 4 1 46 final jar 4 1 46 final at io netty channel epoll abstractepollstreamchannel epollstreamunsafe epollinready abstractepollstreamchannel java 792 netty transport native epoll 4 1 46 final linux x86 64 jar 4 1 46 final at io netty channel epoll epolleventloop processready epolleventloop java 475 netty transport native epoll 4 1 46 final linux x86 64 jar 4 1 46 final at io netty channel epoll epolleventloop run epolleventloop java 378 netty transport native epoll 4 1 46 final linux x86 64 jar 4 1 46 final at io netty util concurrent singlethreadeventexecutor 4 run singlethreadeventexecutor java 989 netty common 4 1 46 final jar 4 1 46 final at io netty util internal threadexecutormap 2 run threadexecutormap java 74 netty common 4 1 46 final jar 4 1 46 final at io netty util concurrent fastthreadlocalrunnable run fastthreadlocalrunnable java 30 netty common 4 1 46 final jar 4 1 46 final at java lang thread run thread java 745 1 8 0 40 |
openzipkinzipkin | disable index template creation at startup | Enhancement | the es index template be create during server startup site like netflix have customize the template and prefer manage the template outside the server runtime we would like if the template creation can be control via a property adriancole |
openzipkinzipkin | should lens fan out query to the archive zipkin | Enhancement | 3018 add the archive button which allow someone to post the current trace to an archive server one idea around permalink be to use a proxy behind the ui to query multiple source when you know the archive be zipkin however this be more infrastructure mchandramouli suggest zipkin lens can search both live and archive cluster beyond live cluster time range so archived trace can appear in the same ui issuecomment 597733334 it be possible that the archive be write only for example a zipkin clone or apm endpoint that doesn t support our api however an option request could let we know that it be unlikely we ll know what timerange be valid on the other source as the archive could be just another wide scope service and we don t even know the reason for archival be time relate however we can consider impact of do this cor we have permissive cross origin setting so a default zipkin service will accept cross origin request lens could query two zipkin service conflict it be possible two service have the same datum but we could prefer the archive on conflict performance the browser will get multiple query back and that would double the bandwith on overlap some tuning or configuration might be need to say when to use the archive on the latter if we do end up with a standard tag query archive would be as easy as look for the tag zipkin archive or whatever it end up name as this would be a cheap way to reduce volatility on normal query |
openzipkinzipkin | ui doesn t display span in proper way | Bug | describe the bug I have 3 simple apis write in python the request start from api 01 which call api 02 then api 02 call api 03 all information about traceid and parentid be correct mean that api 01 be a parent of api 02 and api 02 be a parent of api 03 the issue come in zipkin ui it display api 02 and api 03 span as if they all be child of api 01 as you can see in the follow image api 03 seem to be a direct child to api 01 and have no relation to api 02 image however api 03 be api 02 s child please see the relate json traceid e5ffdf91f32ca45d parentid b38b0404e8118915 i d b19a748b13e973a3 kind client name do stuff api 03 timestamp 1583497210542015 duration 2002423 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 traceid e5ffdf91f32ca45d parentid b38b0404e8118915 i d b19a748b13e973a3 kind server name do stuff api 03 timestamp 1583497210542015 duration 2002423 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 share true traceid e5ffdf91f32ca45d parentid 41e575d16a685997 i d b38b0404e8118915 kind server name index api 03 timestamp 1583497210541946 duration 2002675 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 share true traceid e5ffdf91f32ca45d parentid e3082f5b15a58fa0 i d 41e575d16a685997 kind client name call api 03 timestamp 1583497210533419 duration 2026676 localendpoint servicename api 02 ipv4 192 168 16 5 port 5000 traceid e5ffdf91f32ca45d parentid e3082f5b15a58fa0 i d 41e575d16a685997 kind server name call api 03 timestamp 1583497210533419 duration 2026677 localendpoint servicename api 02 ipv4 192 168 16 5 port 5000 share true traceid e5ffdf91f32ca45d parentid f1f81ebfd8fb02b9 i d e3082f5b15a58fa0 kind server name index api 02 timestamp 1583497210533321 duration 2026935 localendpoint servicename api 02 ipv4 192 168 16 5 port 5000 share true traceid e5ffdf91f32ca45d parentid 5a7c1fe0e7f25c2f i d f1f81ebfd8fb02b9 kind client name call api 02 timestamp 1583497210527233 duration 2045923 localendpoint servicename api 01 ipv4 192 168 16 4 port 5000 traceid e5ffdf91f32ca45d parentid 5a7c1fe0e7f25c2f i d f1f81ebfd8fb02b9 kind server name call api 02 timestamp 1583497210527233 duration 2045924 localendpoint servicename api 01 ipv4 192 168 16 4 port 5000 share true traceid e5ffdf91f32ca45d i d 5a7c1fe0e7f25c2f kind server name index api 01 timestamp 1583497210527150 duration 2046149 localendpoint servicename api 01 ipv4 192 168 16 4 port 5000 step to reproduce I upload the apis code here run docker compose up on your browser visit api 01 zipkin url the code be provide bellow expect behaviour I expect that api 03 be list completely under api 02 span like in the follow image image this image be produce by edit in the json and re upload it again to zipkin the only change be to change i d b38b0404e8118915 kind from server to client traceid e5ffdf91f32ca45d parentid b38b0404e8118915 i d b19a748b13e973a3 kind client name do stuff api 03 timestamp 1583497210542015 duration 2002423 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 traceid e5ffdf91f32ca45d parentid b38b0404e8118915 i d b19a748b13e973a3 kind server name do stuff api 03 timestamp 1583497210542015 duration 2002423 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 share true traceid e5ffdf91f32ca45d parentid 41e575d16a685997 i d b38b0404e8118915 kind client here be the only change form server to client name index api 03 timestamp 1583497210541946 duration 2002675 localendpoint servicename api 03 ipv4 192 168 16 2 port 5000 share true traceid e5ffdf91f32ca45d parentid e3082f5b15a58fa0 i d 41e575d16a685997 kind client name call api 03 timestamp 1583497210533419 duration 2026676 localendpoint servicename api 02 ipv4 192 168 16 5 port 5000 code default handler def default handler encode span body encode span return request post datum body header content type application x thrift api 01 zipkin span service name api 01 span name call api 02 def call api 02 header create http header for new span request get header header return ok app route def index with zipkin span service name api 01 span name index api 01 transport handler default handler port 5000 sample rate 100 call api 02 return ok 200 api 02 zipkin span service name api 02 span name call api 03 def call api 03 header create http header for new span request get header header return ok app route def index with zipkin span service name api 02 zipkin attrs zipkinattrs trace i d request header x b3 traceid span i d request header x b3 spanid parent span i d request header x b3 parentspanid flag request header x b3 flag be sample request header x b3 sample span name index api 02 transport handler default handler port 5000 sample rate 100 call api 03 return ok 200 api 03 zipkin span service name api 03 span name do stuff api 03 def do stuff time sleep 2 return ok app route def index with zipkin span service name api 03 zipkin attrs zipkinattrs trace i d request header x b3 traceid span i d request header x b3 spanid parent span i d request header x b3 parentspanid flag request header x b3 flag be sample request header x b3 sample span name index api 03 transport handler default handler port 5000 sample rate 100 do stuff return ok 200 |
openzipkinzipkin | redesign lens search bar for more usability | Enhancement | relate 2485 the current search bar seem a bit confusing to use I want to give the user enough explanation and make the design a little easy to use I draw a simple wireframe searchbar |
openzipkinzipkin | use a mutable empty map instead of collection emptymap | Enhancement | l759 tag builder tag null collection emptymap new linkedhashmap builder tag the empty map be immutable and make it difficult to add a tag to a already create span this will be helpful with performance otherwise have to turn it in to builder and back to a span when this type be use in the stream processing pipeline adriancole |
openzipkinzipkin | lens doesn t show the service name if any span in the trace be miss | Bug | describe the bug some of my trace render just fine but some of they render without service name the span name and timing bar be fine but the service name and the hierarchy doesn t show step to reproduce load this trace expect behaviour I can see the service name |
openzipkinzipkin | lens do not respect search enable false | Bug | describe the bug when I set search enable false I expect lens search bar to be disable instead right now I can still try to write a search but all the dropdown be empty since there be no index and ideally I d like to have the same banner as in the old ui that say that search be disabled and to input the traceid in the top right textbox step to reproduce run zipkin with search enable false |
openzipkinzipkin | can not open trace in a new tab | Bug | describe the bug in the late version of lens I m unable to open the search result in a new tab if I cmd click on a trace it still open it in the current window and if I right click there s no open in new tab option step to reproduce search for anything and try to open any of the result trace in a new tab |
openzipkinzipkin | lens ui fail to list trace | Bug | describe the bug lens ui show no trace while the standard ui do step to reproduce step to reproduce the behavior open a project that generate trace execute late zipkin docker run d p 9411 9411 openzipkin zipkin late go to default ui and list they you will see your trace standard the xhr request be request url click lens ui and click the magnifying glass icon to list all your trace without modify any of the default filter you will see that no trace be list lens ui the xhr request be request url note this last xhr request do not return any trace expect behaviour trace be list the same way in both uis |
openzipkinzipkin | miss public logo asset require by zipke ui | Bug | describe the bug screenshot 2020 02 26 at 11 14 10 public asset be not available in zipkin server step to reproduce step to reproduce the behavior docker run d p 9411 9411 openzipkin zipkin late you will see that the logo be miss in the ui expect behaviour logo be available in the server and the ui can load it |
openzipkinzipkin | a question about span basic datum | Question | I suspect there be a problem with the report datum zipkin should generate two span in one service node one be the server and the other be the client now some node only have client datum but no server datum be there error reporting for such span datum I think the correct datum be a node a client and a server be my understanding correct |
openzipkinzipkin | warn zipkin2 server internal bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception nulle be open | Question | describe the bug warn zipkin2 server internal bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception nulle be open step to reproduce sometimes this be an exception after request the webpage page 503 error I don t know it s reason expect behaviour solve it |
openzipkinzipkin | on the calculation of zipkin dependency | Question | traceid df3e4c4d2750fb1e i d df3e4c4d2750fb1e kind client name realnamerelation selectbyreplyidandstatus timestamp 1579597468311016 duration 4072 localendpoint servicename grpc client ipv4 10 11 traceid df3e4c4d2750fb1e i d df3e4c4d2750fb1e kind server name realnamerelation selectbyreplyidandstatus timestamp 1579597468311004 duration 3137 localendpoint servicename grpc server ipv4 10 12 share true this be a trance record of span and I want to know how they calculate dependency dependence there be some part of the source code that I don t quite understand so I come to ask for help I try to convert the process of compute depencency into sql computing doris clickhouse I encounter some problem in the process of read the source code I be confused about some calculation and have no way to start select child parent count 1 sum error as callcount from select traceid name localendpoint servicenameas child remoteendpoint servicename as parent tag errora error from test where kind server or kind consumer union all select traceid name localendpoint servicenameas parent remoteendpoint servicename as child tag errora error from test where kind client or kind producer as span group by parent child this be the sql I try to write there be no doubt that there be a problem normally it should be child client parent server callcount x errorcount y with this sql I can t find the remoteservice so child client parent null callcount x errorcount y child server parent null callcount x errorcount y I hope I can get your help thank you |
openzipkinzipkin | object should not be use for the type of tag http url | Question | image because the field type be object elasticsearch can not query it as a conditional line you need to change the object type to nest |
openzipkinzipkin | fix orphan span bug | Bug | fix an obvious bug point out in 2922 mainly change the calculation method of showntree previously span i d be use to calculate the span s parent child relationship and expand collapse button be implement use that parent child relationship this create the orphan span problem point out in 2922 because orphan span don t have parent child relationship use span id please see here orphan span be simply append to the root span l272 l276 this pr use span index to calculate parent child relationship instead of span ids p s tracesummary component be fairly complex so I want to create custom hook and improve readability but I m not do it now to minimize pr before before orphan after after orphan |
openzipkinzipkin | unexpected error handling request | Question | today zipkin online have the follow problem at present it be suspect that the access client write too fast but the sampling rate be only 0 1 about 5k min the ui interface be particularly slow read the log and report an error as follow what be this armeria bag for I can t find out why I report this mistake 2020 01 07 16 19 57 359 warn 1 ng task 1 1307 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria client responsetimeoutexception null at com linecorp armeria client responsetimeoutexception get responsetimeoutexception java 36 armeria 0 97 0 jar at com linecorp armeria client httpresponsedecoder httpresponsewrapper run httpresponsedecoder java 197 armeria 0 97 0 jar at io netty util concurrent promisetask runtask promisetask java 98 netty common 4 1 43 final jar 4 1 43 final at io netty util concurrent scheduledfuturetask run scheduledfuturetask java 150 netty common 4 1 43 final jar 4 1 43 final at io netty util concurrent abstracteventexecutor safeexecute abstracteventexecutor java 163 netty common 4 1 43 final jar 4 1 43 final at io netty util concurrent singlethreadeventexecutor runalltask singlethreadeventexecutor java 510 netty common 4 1 43 final jar 4 1 43 final at io netty channel epoll epolleventloop run epolleventloop java 413 netty transport native epoll 4 1 43 final linux x86 64 jar 4 1 43 final at io netty util concurrent singlethreadeventexecutor 6 run singlethreadeventexecutor java 1050 netty common 4 1 43 final jar 4 1 43 final at io netty util internal threadexecutormap 2 run threadexecutormap java 74 netty common 4 1 43 final jar 4 1 43 final at io netty util concurrent fastthreadlocalrunnable run fastthreadlocalrunnable java 30 netty common 4 1 43 final jar 4 1 43 final at java lang thread run thread java 748 1 8 0 151 2020 01 07 16 19 57 363 warn 1 ng task 1 1307 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 20 51 282 warn 1 rker epoll 2 14 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 20 55 870 warn 1 ng task 1 1307 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 22 21 003 warn 1 rker epoll 2 17 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 22 21 369 warn 1 ng task 1 1337 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 27 03 984 warn 1 rker epoll 2 28 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null 2020 01 07 16 27 04 537 warn 1 ng task 1 1508 z s i bodyisexceptionmessage unexpected error handling request com linecorp armeria common closedsessionexception null |
openzipkinzipkin | spring boot2 1 11 upgrade to spring boot2 2 2 stucke when server setup | Question | when spring cloud greenwich upgrade to spring cloud hoxton the main tread get stuck issuecomment 568636879 there be a sample relate issue |
openzipkinzipkin | release url allocate with createobjecturl use revokeobjecturl | Enhancement | probably blob uri which be allocate with createobjecturl will not be collect by gc we should revoke this explicitly |
openzipkinzipkin | how to handle trace normal function invocation | Question | be it possible to trace normal function invocation in zipkin trace under same trace |
openzipkinzipkin | basic permission authentication | Question | hello god be there any build in ui login permission setting |
openzipkinzipkin | loading indicator to discover page | Enhancement | summary if user store a large amount of datum the datum fetch time will be long in this case if the loading indicator be not display the user may simply think that there be no datum on zipkin server this be a very big ux issue we should fix it as soon as possible screenshot loading service loading trace |
openzipkinzipkin | lens ui not show service name after late redesign | Bug | after 2736 the lens ui doesn t show the service name for any of our trace to reproduce run lens locally and load zipkin lens testdata yelp json cc tacigar |
openzipkinzipkin | add download view json button in lens ui | Enhancement | feature the regular ui have a download view json button which show you the json representation of the current trace lens doesn t have such thing rational it s super useful when debug ui issue and it s also one of the only way to share trace in a ticket unless you want to manually curl the trace endpoint |
openzipkinzipkin | env variable to make lens the default ui | Enhancement | lens have be around for more than a year now and a lot of development have go into it before remove the old ui we should make it possible to have lens as default ui most people at my company have never click the try lens button afaik while we do this we should also add the button to go back to the default ui if people have any issue with lens though |
openzipkinzipkin | redesign dependency page | Enhancement | summary mainly I do the follow two thing in this pr detach dependency from discoverpage refactor dependencies code detail detach dependency from discoverpage dependency be currently embed in the discover page as follow at first glance this design seem to share globalsearch between trace search and dependency search actually however dependency search use only lookback search criterion I think this would be very confusing to user and I think that the topology view consider here should be place where dependency be now therefore I want to detach dependency from discoverpage refactor dependency code currently the code of dependency be the old and bad code in lens I want to refactor it screenshot |
openzipkinzipkin | fix appbar s tab and search bar overlap issue | Bug | before after drolando thank you for your report |
openzipkinzipkin | how to pass es credential to zipkin when use storage type as es | Question | this issue tracker be not for question if you want to ask how to do something or to understand why something isn t work the way you expect it to please use gitter or stack overflow how to pass es credential to zipkin when use storage type as es I have try es username and es password and also as can you please help |
openzipkinzipkin | zipkin ui lens new download huge datum from tag | Enhancement | hi the new zipkin ui lens truncate the datum tag we need all datum from any tag to analyze incident I think be useful a button link as download for tag to get all datum from tag or modal window as old version feature download truncate datum from tag or modal window as old version rational analyze incident example scenario captura de pantalla 2019 10 17 a la s 4 57 55 p m |
openzipkinzipkin | es health check should block on schema creation | Bug | there s a race condition where a post could leak prior to elasticsearch storage s schema be fully initialize it lead to query error like this java lang illegalstateexception response for aggregation fail error root cause type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead type search phase execution exception reason all shard fail phase query group true fail shard shard 0 index zipkin span 2019 09 26 node htub5z 6rp2garm ckcj6q reason type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead cause by type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead cause by type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead status 400 at zipkin2 elasticsearch internal client httpcall parseresponse httpcall java 151 zipkin storage elasticsearch 2 14 2 jar at zipkin2 elasticsearch internal client httpcall doexecute httpcall java 78 zipkin storage elasticsearch 2 14 2 jar notably this be possible when there be multiple collector nodes basically the index template could be in the process of be apply on one node while the other check and that let a post through which be now not index properly the reason be that the health check doesn t initialize the index template such as we do in cassandra the fix be easy but for those who need a workaround now hit api v2 autocompletekey instead as eventhough it return a constant no perf impact it do the init logic need first ensure index template thank basvanbeek for notice this cc openzipkin elasticsearch |
openzipkinzipkin | skip to store the zipkin 400 error from trace table | Question | hello all be there any way to skip wipe out 400 error from zipkin mysql database what be the table name for this its cause the some issue so right now there be a stack overflow and you can t see any trace need the mysql database table that have the trace to be wipe clean thank you in advance |
openzipkinzipkin | no log | Question | tldr despite log level zipkin2 trace I get no log the server be launch with java jar zipkin server 2 16 2 exec jar log level zipkin2 trace as describe in the standard output display some log during zipkin server startup but after that nothing then I feed the server with trace and successfully display they in the lens ui but the standard outup do not display any additional log |
openzipkinzipkin | http collector log not work at least zipkin 2 16 2 | Question | do this bash curl ssl bash s java jar zipkin jar log level zipkin2 debug then do this bash cd zipkin lens testdata curl x post s localhost 9411 api v2 span h content type application json d netflix json v notice no log in the console zipkin2 collector collector should log eventhough it use java log as we have intend to setup the log manager in zipkin server zipkinserver thank fbeaufume for report |
openzipkinzipkin | directly support endpoint we use in support vs implicit redirect to spring boot actuator | Help Wanted | in former version we mount health and prometheus at root I think start with spring boot 2 or armeria I forget which we redirect instead of forward dual mount these path I think this dependency be unnecessary and require we to use one of the hefty part of spring boot for routine work actuator actuator have a lot of slow path and be itself bulky and ultimately build on servlet layer if instead we mount the require urls prometheus info and health directly we have flexibility in term of certain dependency and to increase our startup time as well memory usage so I prefer we directly mount the follow health info prometheus cc openzipkin core |
openzipkinzipkin | defer processing of trace in list view | Bug | driesdeproost notice that if you have retrieve 1000 trace possibly even hundred where a trace have a few hundred span the list view render slowly vs before this be almost certainly due to pre emptive construction of trace tree I think we can defer this and make performance pop even well than before lens |
openzipkinzipkin | zipkin storage elasticsearch not supoort es7 | Question | zipkin storage elasticsearch not supoort es7 |
openzipkinzipkin | health check message be quite useless on tls error | Bug | if you point https at a plain text endpoint the health check response useless curl s localhost 9411 health status down zipkin status down detail elasticsearchstorage initialendpoint index zipkin status down detail error java util concurrent rejectedexecutionexception reject execution null there s a very understandable reason in the log the sort of thing we want to see especially on failure 2019 08 24 08 56 32 870 warn 49402 worker nio 2 4 c l a c httpclientpipelineconfigurator i d 0xaed0f172 l 127 0 0 1 62203 r localhost 127 0 0 1 9200 tls handshake fail javax net ssl sslhandshakeexception error 100000f7 ssl routine openssl internal wrong version number at io netty handler ssl referencecountedopensslengine sslreaderrorresult referencecountedopensslengine java 1224 netty handler 4 1 39 final jar 4 1 39 final at io netty handler ssl referencecountedopensslengine unwrap referencecountedopensslengine java 1185 netty handler 4 1 39 final jar 4 1 39 final at io netty handler ssl referencecountedopensslengine unwrap referencecountedopensslengine java 1256 netty handler 4 1 39 final jar 4 1 39 final at io netty handler ssl referencecountedopensslengine unwrap referencecountedopensslengine java 1299 netty handler 4 1 39 final jar 4 1 39 final I ll try to sort this out cc anuraaga trustin |
openzipkinzipkin | howto elasticsearch with custom ssl setup | Question | mark this as a question for now we have someone on gitter stanltam twitter ask about how to use custom tls configuration for the client side of elasticsearch I know this exist for the server side but I m not sure if we read custom tls or not if we fall back to system property or something else l35 l49 ex I would expect possibly some custom tls object use here l75 hold back a patch release for now just in case we have to change code to make it possible to connect to es with customize tls cc trustin anuraaga |
openzipkinzipkin | option to index hourly in to elasticsearch | Duplicate | in order to reduce search scope for small time range and increase query performance have an option to index hourly will be helpful the zipkin server annotation query be convert to a es aggregation query to list trace ids and then the span be fetch recently with our scale I notice the query timeout and have hourly index might speed thing up it s a quick win to gain some performance this way |
openzipkinzipkin | add zipkin collector abc enable conditional property to enable collector | Enhancement | feature add conditional property to enable collector similar to scribe http or grpc rational currently most message collector be enable base on env variable define e g kafka collector enable when kafka bootstrap server be define example scenario while develop a kafka base storage I would like to reuse variable name kafka xxx without force user to enable kafka collector be not probable for this to happen when rabbitmq or activemq be use as collector but might be good to standardize the same property to enable collector as we do with zipkin storage type prior art http scribe |
openzipkinzipkin | I want to access zipkin ui via https do zipkin ui support that | Question | this issue tracker be not for question if you want to ask how to do something or to understand why something isn t work the way you expect it to please use gitter or stack overflow |
openzipkinzipkin | consider if jdk 9 release flag obviate animal sniffer | Help Wanted | from shakuzen also I know we use animalsniffer but upgrade to jdk9 present the opportunity to use the new release compiler arg instead where the compiler can enforce that java api be not use beyond the specified version this doesn t need to happen in this pull request though ref someone can try this and see if it work or if it require some hard to setup thing like library contain 1 6 apis and thing |
openzipkinzipkin | any plan to support postgresql | Duplicate | please first look at exist issue to see if the feature have be request before if you don t find anything tell we what problem you re try to solve often a solution already exist don t send pull request to implement new feature without first get our support sometimes we leave feature out on purpose to keep the project small feature description of the feature rational why this feature should be in zipkin example scenario when will this be use by operator prior art link to prior art more link |
openzipkinzipkin | enhance unit test for app component | Enhancement | change add react testing library for testing update unit test for component which be under src component app directory refactor some component just a little add classname library to write classname concisely test coverage before after so far we have only use enzyme for testing framework but there be little documentation on testing component with react hook enzyme and I ve have several experience where the enzyme react hook test didn t work as expect on the other hand as far as I know there be many material use react testing library hook and react testing library be simple and do not have so many feature but seem to work good so I come to the conclusion that it would be good to use both enzyme and react testing library in hybrid afaik it seem that material ui be take the same method this pr be the beginning of that attempt |
openzipkinzipkin | redesign trace timeline | Enhancement | resolve 2672 resolve 2525 resolve 2195 |
openzipkinzipkin | port dependency linker to javascript | Enhancement | this should allow integration include single trace aggregate aggregate across the result of the current query right now this be a direct and complete port of the java code however we could do more later once this be integrate here be some option include reference to each span in the dependency link ex trace span i d key so that you can jump directly to the row full path trace future ex instead of parent child complete path from root to each leaf see 2701 see 2622 see 2230 |
openzipkinzipkin | redesign trace page traceviewer page | Enhancement | this pr change several thing integrate traceviewer page component and trace page component display root span information on the top left of the trace page traceviewer page improve error message design fix 2673 integrate traceviewer page component and trace page component trace page component and traceviewer page component be previously separate component but these two component have many thing in common so I integrate they display root span information on the top left of the trace page traceviewer page previously trace i d be display at the top left of the page but root span information more important to human than trace i d before after improve loading error message design before after |
openzipkinzipkin | consider not use rejectedexecutionexception | Help Wanted | right now we be in a position where we use rejectedexecutionexception as a signal to back off this be simple in elasticsearch as we originate all exception directly when we be use another library many have exception type that be indicative of a rejection either client side some health check go red or server side a push back base on a pool or queue that s too busy not everyone know the use case of exception for example it might be easy to miss that an exception s direct message result in 500 error and our own health check wrapping can obfuscate that if we meddle with the original message render it difficult to help third party who come to we for support moreover it may not be obvious that when a run queue be full it affect also the read side this mean browser request and the message we see from chrome debug still need to be useful when we consider common text of message about a rejection we can neither guess a format nor a remedy for example if a health check be temporarily down it isn t necessarily the case that enable throttling will resolve it however to the degree it buffer and the problem be temporary it can prevent more span from drop than necessary otoh throttle isn t a universal answer either while elastic be famous for fall over during a flurry of request many site be use kafka which doesn t necessarily imply a flurry of request moreover driver like cassandra have internal queueing mechanism this doesn t mean our throttling feature be harmful just that it isn t a universal answer and certainly would be disingenuous to wildcard suggest in in error message instead of say what exactly happen people who be literally view zipkin s log and be sensitive to see something twice might take note and feel the need to somehow change the message but I personally think that be work against ourselves for example the people who have to answer support question may not even have access to the stack trace which might if you see it be one layer big than before by prevent we from see the actual message we can t help let s not do that if there be a fundamental feeling about how a wrap message must be different then it can not hurt our team in order to satisfy the itch my suggestion then would be to change the exception mechanism still allow rejectedexecutionexception when originate message but rather than waste time argue format of wrap message possibly hurt ourselves in the process change to a registry for example the storage throttle component could source a list injection supply by each storage configuration module give a bean of type rejectionclassifi this have one disadvantage in so far that the spring config live far away than the library do the storage however it could be a good approach to handle the classification concern of retryable exception and in a way that doesn t damage the volunteer ability to support the server |
openzipkinzipkin | don t show minimap when trace fit on screen | Enhancement | it be redundant to see minimap when you can already see whole trace ex screenshot 2019 07 31 at 11 57 37 am |
openzipkinzipkin | release post request soon | Help Wanted | the below trace you can see we could release the request soon on bad case first request while this be a first request problem if there be storage error delay could be routine until they resolve implicitly lookup of elasticsearch endpoint from aw lazy index template where all template weren t there finally do the post screenshot 2019 07 31 at 11 57 37 am look at collector java there s a little bit of lie when we have a first request it be true that we be swap callback however the method store block when lazy instantiating we could probably add an executor to collector that can be use to avoid this blocking so that the function can return soon release the http post from the client in order to ensure caller be not block we swap callback when we get to the storage phase of this process here we create a callback whose sole purpose be classify later error on this bundle of span in the same log category this allow people to only turn on debug log in one place callback logonerrorcallback storespanscallback sampledspan try store sampledspan logonerrorcallback callback onsuccess null release the callback give to the collector catch runtimeexception error e while unexpected invoke the storage command could raise an error synchronously when that s the case we wouldn t have invoke callback onsuccess so we need to handle the error here handlestorageerror span e callback |
openzipkinzipkin | revive scatter chart | Enhancement | relate fix 2636 I know there be the pro and con about scatter chart I want to get feedback cc narayaruna |
openzipkinzipkin | avoid fetch trace when the search criterion be not change | Enhancement | in the previous implementation fetch processing be perform each time the search page be open even if the search criterion be the same this implementation degrade ux significantly because fetch processing be slow we should avoid fetch trace when the search criterion be not change this pr do so relate 2685 if we do not avoid unnecessary fetch the page transition of search page see detail back button search page ux will be the bad |
openzipkinzipkin | fix lookbackcondition s warning | Bug | because I mistakenly set key prop to menuitem component the follow warning have happen react dom development js 61bb 506 warning encounter two child with the same key 1h key should be unique so that component maintain their identity across update non unique key may cause child to be duplicate and or omit the behavior be unsupported and could change in a future version in ul create by forwardref list in forwardref list create by withstyle forwardref list in withstyle forwardref list create by forwardref menulist in forwardref menulist create by forwardref menu in div create by forwardref paper in forwardref paper create by withstyle forwardref paper in withstyle forwardref paper create by transition in transition create by forwardref grow in forwardref grow create by withtheme forwardref grow in withtheme forwardref grow create by trapfocus in trapfocus create by modal in div create by modal in forwardref portal create by modal in modal create by forwardref modal in forwardref modal create by withtheme forwardref modal in withtheme forwardref modal create by forwardref popover in forwardref popover create by withstyle forwardref popover in withstyle forwardref popover create by forwardref menu in forwardref menu create by withstyle forwardref menu in withstyle forwardref menu create by lookbackcondition in div create by style muibox in style muibox create by lookbackcondition in lookbackcondition create by globalsearch in div create by style muibox in style muibox create by globalsearch in globalsearch create by context consumer in withrouter globalsearch create by discoverpage in discoverpage create by context consumer in withrouter discoverpage create by context consumer in route create by app in main create by style muibox in style muibox create by layout in div create by style muibox in style muibox create by layout in layout create by app in router create by browserrouter in browserrouter create by app in provider create by app in themeprovider create by app in muipickersutilsprovider create by app in app this pr fix this |
openzipkinzipkin | remove span detail table if empty | Enhancement | fix 2617 thank you jorgheyman |
openzipkinzipkin | add rootserviceandspanname function | Enhancement | I want to show root span information in search result list in discover page in 2656 so I need a function which calculate the root span from span node tree I try to implement it but I do not know if this implementation be correct wdyt adriancole |
openzipkinzipkin | redesign service badge in len | Enhancement | service badge be these this design be ugly and this component be not extensible we must update this design as soon as possible before improve other component new service badge base clickable clickable clickable deletable deletable this pr may fix 2504 too |
openzipkinzipkin | remove trace preview feature | Enhancement | many may recall we have a trace preview feature in the search result screen this I believe be an idea borrow from jaeger as discuss with tacigar this be probably not a worthwhile feature for example it appear to solve the trace comparison use case but it doesn t for example it be unlikely you will have two trace near each other in the result and even if you do the scrolling up and down wildly through expand trace thing isn t that effective moreover there s recent work in the ui to share datum between the trace list and the trace view page which obviate network call in other word as long as navigation such as back work properly there s no reason to overload the screen especially for performance reason this should buy back code and complexity for well purpose for example right now no screen be ideal for compare multiple trace however we could build a compare screen and let people select into it cc openzipkin ui narayaruna |
openzipkinzipkin | improve performance of trace page | Enhancement | calculate trace summary asynchronously reuse result of api v2 trace api call in the individual trace page if can |
openzipkinzipkin | add traceid search box to lens individual trace page | Enhancement | I really like the addition of the search by traceid and upload button directly navigate to a trace via a traceid be a workflow that I use a lot image one thing that I do miss be be able to switch to another trace once I ve already load a trace can we include the above option on the individual trace page |
openzipkinzipkin | lens to support collapse expand all | Enhancement | the original zipkin ui have button to collapse or expand all node collapse all node can be especially helpful to drill down into problematic issue on large trace at the very least I think this feature should be include in zipkin lens original ui image while we re on the topic though I think an even cool feature would be to collapse expand all node under a specific node in the tree perhaps this could be accomplish from a context menu when right clicking on the current button next to a span |
openzipkinzipkin | change endts when enter key or search button be click | Bug | fix 2364 |
openzipkinzipkin | add git hash to actuator info | Enhancement | right now we have the version in actuator info build from property substitution in maven iirc we should see about git hash because especially test jitpack from within docker it be annoying as heck to try to heuristically tell what you be actually run cc anuraaga abesto |
openzipkinzipkin | switch self trace to rate limit so we can enable for storage | Enhancement | right now we don t self trace storage because it can amplify write however this win t be the case if we sample at a rate say 1 per second let s use brave s new sampler because particularly new storage impls be very hard to troubleshoot without trace cc anuraaga |
openzipkinzipkin | fix an bug that can not scroll on the trace page | Bug | this be a little bug before before scroll after after scroll |
openzipkinzipkin | fix bug that fetch trace with old condition | Bug | summary after add condition in search bar and push enter key I notice that the condition be not apply to parameter of the fetching this pr fix this before servicename condition be not add to the address bar of browser after push enter key before after servicename condition be add after content fix the above bug remove unnecessary statement optimize a bit use usecallback to handlekeydown |
openzipkinzipkin | redesign trace search page | Enhancement | redesign trace search page by use material ui component remove trace preview feature please see 2685 support the feature of filtering by service name improve whole design old design new design fix 2685 fix 2635 |
openzipkinzipkin | apache pulsar collector and reporter | Duplicate | feature pulsar be a highly scalable low latency message platform run on commodity hardware it provide simple pub sub semantic over topic hope zipkin can use pulsar as collector and reporter in this way user who only use pulsar but not kafka do not need to maintain kafka anymore I d be happy to do that if the community agree |
openzipkinzipkin | es index replicas ignore | Invalid | describe the bug es index replicas environment variable have no effect when create an index step to reproduce set es index replicas to 0 start zipkin and send a trace to that instance use es http log body we can see that this setting be be ignore 2019 06 27 12 37 22 360 info 1 orker epoll 2 1 z e elasticsearchstorage get http 1 1 2019 06 27 12 37 22 361 info 1 orker epoll 2 1 z e elasticsearchstorage host ota zipkin 2019 06 27 12 37 22 361 info 1 orker epoll 2 1 z e elasticsearchstorage connection keep alive 2019 06 27 12 37 22 361 info 1 orker epoll 2 1 z e elasticsearchstorage accept encode gzip 2019 06 27 12 37 22 361 info 1 orker epoll 2 1 z e elasticsearchstorage user agent okhttp 3 14 2 2019 06 27 12 37 22 361 info 1 orker epoll 2 1 z e elasticsearchstorage end get 2019 06 27 12 37 22 363 info 1 orker epoll 2 1 z e elasticsearchstorage 200 ok 2ms 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage date thu 27 jun 2019 12 37 22 gmt 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage content type application json charset utf 8 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage content length 927 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage connection keep alive 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage access control allow origin 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage 2019 06 27 12 37 22 364 info 1 orker epoll 2 1 z e elasticsearchstorage zipkin hat span template order 0 index pattern zipkin hat span setting index mapper dynamic false request cache enable true number of shard 5 number of replicas 1 mapping span source exclude q dynamic template string mapping norm false ignore above 256 type keyword match mapping type string match property traceid norm false type keyword duration type long remoteendpoint dynamic false type object property servicename norm false type keyword localendpoint dynamic false type object property servicename norm false type keyword q norm false type keyword timestamp millis format epoch millis type date name norm false type keyword annotation enable false tag enable false alias 2019 06 27 12 37 22 370 info 1 orker epoll 2 1 z e elasticsearchstorage 200 ok 2ms 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage date thu 27 jun 2019 12 37 22 gmt 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage content type application json charset utf 8 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage content length 393 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage connection keep alive 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage access control allow origin 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage 2019 06 27 12 37 22 371 info 1 orker epoll 2 1 z e elasticsearchstorage zipkin hat autocomplete template order 0 index pattern zipkin hat autocomplete setting index mapper dynamic false request cache enable true number of shard 5 number of replicas 1 mapping autocomplete enable true property tagvalue norm false type keyword tagkey norm false type keyword alias expect behaviour zipkin use number of replicas 0 when create index in es |
openzipkinzipkin | avoid special character in the rabbitmq consumer tag | Bug | I can not find any definition of consumer tag naming constraint however it appear that the be a problem see domain consumer tag fix 2590 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.