repository stringclasses 156 values | issue title stringlengths 1 1.01k ⌀ | labels stringclasses 8 values | body stringlengths 1 270k ⌀ |
|---|---|---|---|
openzipkinzipkin | call server to client not visible on dependency tree | Question | opening as issue previously open by mistake as question zipkin 2 12 9 I prepare 2 short test for zipkin2 internal dependencylinker for well understanding what I mean in both case link server client1 be miss be there something wrong with my entry datum or test test public void shouldserverclientremotecallswithserverdescendantbuildlink list trace aslist span2 a null a kind client client0 null false span2 a a b kind server server client0 false span2 a b c kind client client1 null false span2 a c d kind server server1 client1 false assertthat new dependencylinker puttrace trace link contain dependencylink newbuild parent client0 child server callcount 1l build dependencylink newbuild parent server child client1 callcount 1l build dependencylink newbuild parent client1 child server1 callcount 1l build test public void shouldserverclientremotecallswithclientdescendantbuildlink list trace aslist span2 a null a kind client client0 null false span2 a a b kind server server client0 false span2 a b c kind client client1 null false span2 a c d kind client client2 null false assertthat new dependencylinker puttrace trace link contain dependencylink newbuild parent client0 child server callcount 1l build dependencylink newbuild parent server child client1 callcount 1l build dependencylink newbuild parent client1 child client2 callcount 1l build |
openzipkinzipkin | can zipkin provide the function of collect some specific request trace | Question | now zipkin provide the sampler but sometimes I want to collect some specific request trace by configuration file for example in springboot application property I configurate the service interface like com xxx xxservice 1 0 execute and last zipkin will read the configuration file s service interface and only collect the trace info of the service interface com xxx xxservice 1 0 execute can I do the exention of this function |
openzipkinzipkin | zipkin issue with mariadb integration | Question | describe the bug zipkin integrate with mariadb create duplicate index we have zipkin server integrate with mariadb of late we find mariadb be slow in respond call from zipkin ui be take long than usual time we think it could be because of datum after close investigation we find out that multiple index on table zipkin span index look like below trace i d high trace i d high 2 trace i d high 2 trace i d high 15 since it be create multiple index cpu usage be very high and do lot of io operation hence delay even a simple query step to reproduce step to reproduce the behavior below be my pom detail to reproduce the issue 2 4 6 2 4 6 dalston release 1 5 14 release io zipkin java zipkin zipkin main version io zipkin java zipkin server zipkin server version io zipkin java zipkin autoconfigure ui zipkin server version runtime it also look like every time we restart zipkin server index be grow in number expect behaviour zipkin server shouldn t create multiple duplicate index |
openzipkinzipkin | zipkin brave rpc | Question | brave dubbo brave instrumentation dubbo rpc xxx jar dubbo onreturn brave instrumentation dubbo rpc xxx jar tracingfilter futurefuture rpccontext getfuture if future instanceof futureadapter deferfinish true futureadapter future getfuture setcallback new finishspancallback span zpkin span callback callback span lock |
openzipkinzipkin | request method post not support | Question | I use spring boot starter parent 2 1 2 release and zipkin autoconfigure ui zipkin server 2 12 0 to make zipkin server I don t use official jar because I need to add a layer to intercept at the server so that the send link reach our service then my zipkin client be use spring cloud starter zipkin 2 0 0 rc2 when the client send to the server log be test2019 06 09 18 01 26 879 warn 134340 xnio 1 task 1 w s m s defaulthandlerexceptionresolver resolve org springframework web httprequestmethodnotsupportedexception request method post not support I see the request be post api v2 span and zipkinhttpcollector java be not change |
openzipkinzipkin | call server to client not visible on dependency tree | Question | zipkin 2 12 9 I prepare 2 short test for zipkin2 internal dependencylinker for well understanding what I mean in both case link server client1 be miss be there something wrong with my entry datum or test test public void shouldserverclientremotecallswithserverdescendantbuildlink list trace aslist span2 a null a kind client client0 null false span2 a a b kind server server client0 false span2 a b c kind client client1 null false span2 a c d kind server server1 client1 false assertthat new dependencylinker puttrace trace link contain dependencylink newbuild parent client0 child server callcount 1l build dependencylink newbuild parent server child client1 callcount 1l build dependencylink newbuild parent client1 child server1 callcount 1l build test public void shouldserverclientremotecallswithclientdescendantbuildlink list trace aslist span2 a null a kind client client0 null false span2 a a b kind server server client0 false span2 a b c kind client client1 null false span2 a c d kind client client2 null false assertthat new dependencylinker puttrace trace link contain dependencylink newbuild parent client0 child server callcount 1l build dependencylink newbuild parent server child client1 callcount 1l build dependencylink newbuild parent client1 child client2 callcount 1l build |
openzipkinzipkin | not all client to client relation take into account in dependency tree | Question | describe the bug zipkin 2 12 9 some relation between client service be not visible on the graph step to reproduce we come across two problem when analyze dependency the first one when component a within service 1 call component b still within service 1 and then component b call component c in service 2 it turn out that only relation b c be visible I find in zipkin2 internal dependencylinker a condition cause this problem line 70 when process link to a client span we prefer the server s name if we have no child span we proceed to use the name the client choose if kind client equal kind current child isempty continue it look like it s do on purpose but I do not understand why why do we want to skip client span which might possess some child when I comment out that suspicious condition the dependency graph be almost correct I be say almost because I spot another thing when client span a call client span b and they have the same service name the link be not build imho it might be visible on the graph as a node with a link to itself I find in zipkin2 internal dependencylinker there be code probably prevent this kind of relation line 127 if kind kind client servicename null remoteancestorname equal servicename zipkin sample span txt expect behaviour the dependency diagram include all relation |
openzipkinzipkin | zipkin 2 14 0 can not run on the elasticsearch 7 0 0 | Question | describe the bug my environment be zipkin version 2 14 0 elasticsearch version 7 0 0 when open zipkin web browser print error can not load span name server error internal server error error can not load service name server error internal server error zipkin s error log be as follow 2019 05 24 09 04 15 279 warn 1 king task 1 37 c l a i a defaultexceptionhandler i d 0x909d4eb0 l 172 30 23 132 9411 r 172 30 23 136 50786 h1c zipkin d955589cf 9zlbb 9411 zipkin api v2 service get unhandled exception from an annotated service java lang illegalstateexception over capacity at zipkin2 elasticsearch internal client httpcall doexecute httpcall java 79 zipkin storage elasticsearch 2 14 0 jar 2 14 0 at zipkin2 call base execute call java 382 zipkin 2 14 0 jar 2 14 0 at zipkin2 server internal brave tracedcall execute tracedcall java 40 class at zipkin2 server internal zipkinqueryapiv2 getservicename zipkinqueryapiv2 java 86 class at jdk internal reflect nativemethodaccessorimpl invoke0 native method at jdk internal reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 at jdk internal reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 at java lang reflect method invoke method java 566 at com linecorp armeria internal annotation annotatedhttpservice invoke annotatedhttpservice java 258 armeria 0 85 0 jar at com linecorp armeria internal annotation annotatedhttpservice lambda serve0 3 annotatedhttpservice java 245 armeria 0 85 0 jar at java util concurrent completablefuture uniapply tryfire completablefuture java 642 at java util concurrent completablefuture completion run completablefuture java 478 at com linecorp armeria common abstractrequestcontext lambda makecontextaware 1 abstractrequestcontext java 69 armeria 0 85 0 jar at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1128 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 628 at io netty util concurrent fastthreadlocalrunnable run fastthreadlocalrunnable java 30 netty common 4 1 34 final jar 4 1 34 final at java lang thread run thread java 834 |
openzipkinzipkin | user friendly span duration on reload | Enhancement | feature user friendly span duration on reload rational right now if you set a minimum duration in let s say second and then reload the search bar convert second into microsecond e g 5s into 5000000ms I believe searchbar should be as friendly as possible |
openzipkinzipkin | zipkin server can not work in idea but when I use java jar zipkin jar in window cmd it work | Question | image start log in idea power by spring boot v2 1 5 release 2019 05 23 11 29 51 915 info 12864 main z s zipkinserver start zipkinserver on yy shengr with pid 12864 d ideaproject incubator zipkin zipkin server target class start by ruansheng in d ideaproject incubator zipkin 2019 05 23 11 29 51 918 info 12864 main z s zipkinserver the follow profile be active share 2019 05 23 11 29 53 394 info 12864 main c l a c flag com linecorp armeria verboseexception false default 2019 05 23 11 29 53 395 info 12864 main c l a c flag com linecorp armeria verbosesocketexception false default 2019 05 23 11 29 53 395 info 12864 main c l a c flag com linecorp armeria verboseresponse false default 2019 05 23 11 29 53 398 info 12864 main c l a c flag com linecorp armeria useepoll false default 2019 05 23 11 29 53 497 info 12864 main c l a c flag com linecorp armeria useopenssl true default 2019 05 23 11 29 53 497 info 12864 main c l a c flag com linecorp armeria dumpopensslinfo false default 2019 05 23 11 29 53 497 info 12864 main c l a c flag com linecorp armeria maxnumconnection 2147483647 default 2019 05 23 11 29 53 497 info 12864 main c l a c flag com linecorp armeria numcommonworker 24 default 2019 05 23 11 29 53 497 info 12864 main c l a c flag com linecorp armeria numcommonblockingtaskthread 200 default 2019 05 23 11 29 53 498 info 12864 main c l a c flag com linecorp armeria defaultmaxrequestlength 10485760 default 2019 05 23 11 29 53 498 info 12864 main c l a c flag com linecorp armeria defaultmaxresponselength 10485760 default 2019 05 23 11 29 53 498 info 12864 main c l a c flag com linecorp armeria defaultrequesttimeoutmillis 10000 default 2019 05 23 11 29 53 498 info 12864 main c l a c flag com linecorp armeria defaultresponsetimeoutmillis 15000 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaultconnecttimeoutmillis 3200 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaultwritetimeoutmillis 1000 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaultserveridletimeoutmillis 15000 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaultclientidletimeoutmillis 10000 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaulthttp2initialconnectionwindowsize 1048576 default 2019 05 23 11 29 53 499 info 12864 main c l a c flag com linecorp armeria defaulthttp2initialstreamwindowsize 1048576 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp2maxframesize 16384 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp2maxstreamsperconnection 2147483647 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp2maxheaderlistsize 8192 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp1maxinitiallinelength 4096 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp1maxheadersize 8192 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaulthttp1maxchunksize 8192 default 2019 05 23 11 29 53 500 info 12864 main c l a c flag com linecorp armeria defaultusehttp2preface true default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria defaultusehttp1pipelining false default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria defaultbackoffspec exponential 200 10000 jitter 0 2 default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria defaultmaxtotalattempt 10 default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria routecache maximumsize 4096 default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria compositeservicecache maximumsize 256 default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria parsedpathcache maximumsize 4096 default 2019 05 23 11 29 53 501 info 12864 main c l a c flag com linecorp armeria headervaluecache maximumsize 4096 default 2019 05 23 11 29 53 502 info 12864 main c l a c flag com linecorp armeria cachedheader authority scheme method accept encode content type default 2019 05 23 11 29 53 504 info 12864 main c l a c flag com linecorp armeria annotatedserviceexceptionverbosity unhandle default 2019 05 23 11 29 53 505 info 12864 main c l a c flag dev epoll not available java lang illegalstateexception only support on linux 2019 05 23 11 29 53 506 info 12864 main c l a c flag use openssl boringssl 0x1010007f 2019 05 23 11 29 53 737 info 12864 main c l a s d docstringextractor use com linecorp armeria thrift jsondir meta inf armeria thrift 2019 05 23 11 29 53 843 info 12864 main c l a c u systeminfo hostname yy shengr from hostname command 2019 05 23 11 29 56 268 info 12864 oss http 9411 c l a s server serve http at 0 0 0 0 0 0 0 0 9411 2019 05 23 11 29 56 269 info 12864 main c l a s armeriaautoconfiguration armeria server start at port 0 0 0 0 0 0 0 0 9411 serverport 0 0 0 0 0 0 0 0 9411 http 2019 05 23 11 29 56 349 info 12864 main c d d core datastax java driver 3 7 1 for apache cassandra 2019 05 23 11 29 56 358 info 12864 main c d d c guavacompatibility detect guava 19 in the classpath use modern compatibility layer 2019 05 23 11 29 56 515 info 12864 main c d d c native could not load jnr c library native system call through this library will not be available set this logg level to debug to see the full stack trace 2019 05 23 11 29 56 515 info 12864 main c d d c clockfactory use java lang system clock to generate timestamp 2019 05 23 11 29 56 624 info 12864 main z s zipkinserver start zipkinserver in 5 357 second jvm run for 7 945 when I send http request zipkin server have error 2019 05 23 11 30 27 472 warn 12864 worker nio 2 4 c l a I a annotatedhttpservice i d 0x714eec3f l 0 0 0 0 0 0 0 0 9411 r 127 0 0 1 45389 h1c yy shengr 9411 api v2 span post unexpected exception from an exception handler zipkin2 server internal bodyisexceptionmessage java lang nullpointerexception text at java util object requirenonnull object java 228 1 8 0 191 at com linecorp armeria common httpdata of httpdata java 120 armeria 0 86 0 jar at com linecorp armeria common httpresponse of httpresponse java 133 armeria 0 86 0 jar at zipkin2 server internal bodyisexceptionmessage handleexception zipkinhttpcollector java 244 class at com linecorp armeria internal annotation annotatedhttpservice compositeexceptionhandlerfunction handleexception annotatedhttpservice java 488 armeria 0 86 0 jar at com linecorp armeria internal annotation annotatedhttpservice exceptionfilteredhttpresponse beforeerror annotatedhttpservice java 415 armeria 0 86 0 jar at com linecorp armeria common stream filteredstreammessage filteringsubscriber onerror filteredstreammessage java 206 armeria 0 86 0 jar at com linecorp armeria common stream abstractstreammessage closeevent notifysubscriber abstractstreammessage java 330 armeria 0 86 0 jar at com linecorp armeria common stream deferredstreammessage abort deferredstreammessage java 281 armeria 0 86 0 jar at com linecorp armeria common stream filteredstreammessage abort filteredstreammessage java 171 armeria 0 86 0 jar at com linecorp armeria common stream deferredstreammessage abort deferredstreammessage java 278 armeria 0 86 0 jar at com linecorp armeria common stream filteredstreammessage abort filteredstreammessage java 171 armeria 0 86 0 jar at com linecorp armeria common stream filteredstreammessage abort filteredstreammessage java 171 armeria 0 86 0 jar at com linecorp armeria server httpserverhandler lambda cleanup 2 httpserverhandler java 238 armeria 0 86 0 jar at java util identityhashmap foreach identityhashmap java 1354 1 8 0 191 at com linecorp armeria server httpserverhandler cleanup httpserverhandler java 233 armeria 0 86 0 jar at io netty util concurrent promisetask runnableadapter call promisetask java 38 netty common 4 1 34 final jar 4 1 34 final at io netty util concurrent scheduledfuturetask run scheduledfuturetask java 127 netty common 4 1 34 final jar 4 1 34 final at io netty util concurrent abstracteventexecutor safeexecute abstracteventexecutor java 163 netty common 4 1 34 final jar 4 1 34 final at io netty util concurrent singlethreadeventexecutor runalltask singlethreadeventexecutor java 404 netty common 4 1 34 final jar 4 1 34 final at io netty channel nio nioeventloop run nioeventloop java 495 netty transport 4 1 34 final jar 4 1 34 final at io netty util concurrent singlethreadeventexecutor 5 run singlethreadeventexecutor java 905 netty common 4 1 34 final jar 4 1 34 final at io netty util concurrent fastthreadlocalrunnable run fastthreadlocalrunnable java 30 netty common 4 1 34 final jar 4 1 34 final at java lang thread run thread java 748 1 8 0 191 image when I use java jar zipkin jar in window it work image |
openzipkinzipkin | lens trace viewer seem bust | Bug | try to load a trace json and get this same trace doesn t break in zipkin classic |
openzipkinzipkin | opentelemetry | Question | I m probably a bit late to the party but I just stumble across opentelemetry opentracing and opencensus effort to merge their project and bundle their power I know zipkin doesn t have anything to do with both or not anymore at least if I understand correctly but see as opentelemetry s goal be mainly to reduce the number of instrumentation standard to one I m wonder where zipkin stand in all of this be in my opinion the most widespread of the currently exist project have that extensive list of support language and framework |
openzipkinzipkin | customize zipkin ui basepath but 404 | Question | describe the bug I try to use zipkin ui basepath to customize the basepath of the ui but access 404 step to reproduce 1 start zipkin server with zipkin ui basepath myzipkin 2 visit on browser but the browser redirect the location to and show zipkin investigate system behavior when I try to visit it still display 404 not find expect behaviour visit redirect to and correct display |
openzipkinzipkin | lens trace lookup criterion appear chop off | Bug | image this be on chrome firefox 60 esr do not have the issue |
openzipkinzipkin | be able to handle large trace in ui | Duplicate | currently both lens and zipkin classic uis do not handle large trace gracefully see also and pagination have be suggest several time 2240 but from a ui perspective it s not clear how this would be represent I think that a drill down mode could be more helpful here a natural way to investigate a trace be by click your way through the part that take up the most time until you get to the leaf span |
openzipkinzipkin | what be set index mapper dynamic be remove after version 6 0 0 mean | Duplicate | when I try start zipkin and elasticsearch the terminal throw exception java lang illegalstateexception response for update template fail error root cause type illegal argument exception reason set index mapper dynamic be remove after version 6 0 0 type illegal argument exception reason set index mapper dynamic be remove after version 6 0 0 status 400 at zipkin2 elasticsearch internal client httpcall parseresponse httpcall java 151 zipkin storage elasticsearch 2 12 9 jar at zipkin2 elasticsearch internal client httpcall execute httpcall java 79 zipkin storage elasticsearch 2 12 9 jar at zipkin2 elasticsearch ensureindextemplate apply ensureindextemplate java 42 zipkin storage elasticsearch 2 12 9 jar at zipkin2 elasticsearch elasticsearchstorage ensureindextemplate elasticsearchstorage java 351 zipkin storage elasticsearch 2 12 9 jar at zipkin2 elasticsearch autovalue elasticsearchstorage ensureindextemplate autovalue elasticsearchstorage java 31 zipkin storage elasticsearch 2 12 9 jar at zipkin2 elasticsearch elasticsearchstorage spanstore elasticsearchstorage java 248 zipkin storage elasticsearch 2 12 9 jar at zipkin2 server internal zipkinqueryapiv2 getservicename zipkinqueryapiv2 java 79 class at sun reflect nativemethodaccessorimpl invoke0 native method 1 8 0 202 at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 1 8 0 202 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 1 8 0 202 at java lang reflect method invoke method java 498 1 8 0 202 at com linecorp armeria internal annotation annotatedhttpservice invoke annotatedhttpservice java 254 armeria 0 83 0 jar at com linecorp armeria internal annotation annotatedhttpservice lambda serve0 3 annotatedhttpservice java 241 armeria 0 83 0 jar at java util concurrent completablefuture uniapply completablefuture java 602 1 8 0 202 at java util concurrent completablefuture uniapply tryfire completablefuture java 577 1 8 0 202 at java util concurrent completablefuture completion run completablefuture java 442 1 8 0 202 at com linecorp armeria common abstractrequestcontext lambda makecontextaware 1 abstractrequestcontext java 69 armeria 0 83 0 jar at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1149 1 8 0 202 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 624 1 8 0 202 at io netty util concurrent fastthreadlocalrunnable run fastthreadlocalrunnable java 30 netty common 4 1 34 final jar 4 1 34 final at java lang thread run thread java 748 1 8 0 202 |
openzipkinzipkin | nacos zipkin | Question | nacos zipkin |
openzipkinzipkin | dependency graph filtering | Enhancement | change the dropdown select on the dependency graph filtering to recreate the graph with one level up and down from the select service 2535 |
openzipkinzipkin | improve minitimeline | Enhancement | relate 2503 have a threshold for when to use mini map there be only1 span not show mini timeline there be 2 14 span mini timeline s height be num of span 5px there be more span height be 75px add slider to improve ux before after |
openzipkinzipkin | break link on the official site | Duplicate | there be break link on datum model page I m look for api documentation but it s 404 default post span |
openzipkinzipkin | validate run lens under a reverse proxy | Enhancement | implement reverse proxy configuration where zipkin be mount alongside other service this be address by an env variable zipkin ui basepath describe below path prefix place into the tag in the ui html useful when run behind a reverse proxy default zipkin we need to read that variable from config json in lens then pe wdittmer abesto to verify later unless one of they want to help implement |
openzipkinzipkin | show id in len | Enhancement | showid close 2507 |
openzipkinzipkin | improve span view header size and content in len | Enhancement | feature when we click on the span detail view dropdown now we have a little bit redundancy in information and the visualization bold big size seem not neccessary proposal highlight the click span instead and remove the span name header redis evalsha in the image |
openzipkinzipkin | trace summary should have documentation tool tip | Duplicate | right now we summarize trace in the list screen but we don t say what be important about the service x span count precedence or anything else some documentation could help people understand what be go on and help we get feedback on whether the summary information be useful or not |
openzipkinzipkin | go to trace in lens should work after you hit enter | Enhancement | when you paste a trace i d people expect to hit enter but this doesn t bring the trace up |
openzipkinzipkin | support show id in len | Enhancement | right now classic ui have the ability to show the span ids without look at the json because this have be request many time we should support that use case here even if the ui element be different screen shoot 2019 04 18 at 4 12 45 pm most recently discuss in 1947 |
openzipkinzipkin | match path pattern of classic ui | Enhancement | the current ui be anchor to trail slash and if request go to zipkin without a trail slash there will be a redirect this redirect lose the query parameter of the search rather than write a custom redirect handler that carry over query parameter on redirect this match the expect path and thus obviate a redirect in the first place |
openzipkinzipkin | service color choice can be too close | Enhancement | not sure the answer but maybe a distance between color code could be helpful in service color choice ex these two be almost the same color screen shoot 2019 04 18 at 3 09 46 pm |
openzipkinzipkin | have a threshold for when to use mini map | Enhancement | when a trace be small the minimap probably doesn t need to exist screen shoot 2019 04 18 at 3 05 29 pm |
openzipkinzipkin | zipkin fail to startup | Question | I fetch the late release server version 2 12 8 use java jar zipkin server 2 12 8 exec jar and I get the follow error application fail to start description fail to bind property under armeria port 0 protocol 0 to com linecorp armeria common sessionprotocol property armeria port 0 protocol 0 value http origin class path resource zipkin server share yml 163 11 reason 4 action update your application s configuration how should I do |
openzipkinzipkin | implement log button in len | Enhancement | this be the description of the zipkin ui readme note that in lens we could implement the pattern differently I recall someone ask to have property besides traceid available for example localendpoint servicename how do I find log associate with a particular trace since zipkin provide a correlation i d the trace i d it s a good pattern to add it in your log if you use zipkin it s very likely that you have distribute log sytem also and a way to query your log e g elk stack one convenient way to switch from a trace to its log be to get a button which directly link a trace to its log this feature can be activate by set the property zipkin ui log url or its corresponding environment variable kibana 3 zipkin ui logs url traceid kibana 4 or new zipkin ui logs url discover a index filebeat query language lucene query traceid this assume that the log data be store under the filebeat index pattern replace this with the correct pattern if need and it use the default timerange of 15 minute change it to 24 hour by add g refreshinterval display off pause f value 0 time from now 24h mode quick to now to the url for example where traceid will be contextually replace by the trace i d if this feature be activate you ll see on the trace detail page an additional button name log log button |
openzipkinzipkin | support i18n in len | Enhancement | feature support i18n in lens rational zipkin ui have the same feature so I think lens should have that feature prior art zipkin ui |
openzipkinzipkin | make hover effect in lens well | Enhancement | make hover effect in lens well for well ux before before hover after after hover |
openzipkinzipkin | more visibility of the timing in span | Help Wanted | feature more visibility of the timing in span rational currently it be not too intuitive to find the trace duration in the new ui it get lose together with the number of span label since the number of span in a trace be not as important as the latency I suggest we give more visibility to the time before image after image ping tacigar |
openzipkinzipkin | add dependency analyze button to search bar | Enhancement | to reuse search bar I want to add dependency analyze button to search bar and move the current search button like the follow adriancole what do you think |
openzipkinzipkin | response time percentile | Question | feature aggregate span to produce and display percentile e g p50 p90 p99 p99 9 etc for execution time of span rational so it be possible to view a summary of execution time rather than only be able to find and view individual span example scenario the feature could work as follow 1 use zipkin ui to search for span base on name and or tag 1 the ui show percentile for the 10 span 1 change the search limit from 10 span to 1 000 span 1 the ui show percentile for the 1 000 span prior art gatling include percentile in it s perf test report |
openzipkinzipkin | settag to string | Question | I be try to send some information via zipkin span use set tag like hostname application port environment etc how to convert these value as string use settag can someone help I on this |
openzipkinzipkin | basic auth setup for the new armeria http collector endpoint | Question | feature add authentication and autorisation control on http rest api and uis this be a continuation of 782 specific to add basic auth example integration instruction rational trace may content sensitive information not everyone should be able to see avoid inappropriate span in storage control who s allow to push span over http api I admit security be a complicated topic the mvp for I would be file base basic auth example scenario do canary testing give access to zipkin to a subset of user protect zipkin server against attack or bad usage prior art zipkin doesn t support https yet which be a requirement spring security |
openzipkinzipkin | I want to know whether it be good to relay trace on mq consumer | Question | as be know zipkin be a call chain tracing system however our engineer propose to trace mq consumer and this encourage I to re think the rationality one call chain should be the chain from service to the end of mq rather than the consumer the mq consumer should restart its own new trace chain image that if we trace all mq consumer which may be massive it will stain the call chain and make it unfriendly for read what do you think adriancole |
openzipkinzipkin | no more detailed operation mode | Question | hello the zipkin not support on maven can I only use docker and java jar |
openzipkinzipkin | be it possible to update duration | Question | if I have already send a cs cr or sr cs with a duration be it possible to overwrite what s currently there this seem to work fine if the first duration I send be 0 then I can still update it in the future but if the first duration I send be anything else I can t seem to overwrite it with a new duration any help be appreciate thank |
openzipkinzipkin | interruptedexception in kafkaconsumer fail to close coordinator | Enhancement | describe the bug when the kafkacollectorworker stop 2019 03 18t10 41 24 962 error org apache kafka client consumer kafkaconsumer consumer clientid consumer 1 groupid zipkin fail to close coordinator org apache kafka common error interruptexception java lang interruptedexception at org apache kafka client consumer internal abstractcoordinator closeheartbeatthread abstractcoordinator java 380 kafka client 2 0 1 jar at org apache kafka client consumer internal abstractcoordinator close abstractcoordinator java 777 kafka client 2 0 1 jar at org apache kafka client consumer internal consumercoordinator close consumercoordinator java 590 kafka client 2 0 1 jar at org apache kafka client consumer kafkaconsumer close kafkaconsumer java 2140 kafka client 2 0 1 jar at org apache kafka client consumer kafkaconsumer close kafkaconsumer java 2108 kafka client 2 0 1 jar at org apache kafka client consumer kafkaconsumer close kafkaconsumer java 2059 kafka client 2 0 1 jar at zipkin2 collector kafka kafkacollectorworker run kafkacollectorworker java 106 zipkin collector kafka 2 12 5 jar at zipkin2 collector kafka kafkacollector lazykafkaworker lambda guardfailure 0 kafkacollector java 252 zipkin collector kafka 2 12 5 jar at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1149 1 8 0 202 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 624 1 8 0 202 at java lang thread run thread java 748 1 8 0 202 cause by java lang interruptedexception at java lang object wait native method 1 8 0 202 at java lang thread join thread java 1252 1 8 0 202 at java lang thread join thread java 1326 1 8 0 202 at org apache kafka client consumer internal abstractcoordinator closeheartbeatthread abstractcoordinator java 377 kafka client 2 0 1 jar 10 more step to reproduce 1 run zipkin server with kafka collector 2 stop the service expect behaviour properly close kafkaconsumer to avoid error stacktrace allow clean consumer group rebalance because consumer leave group properly avoir lose message on stop all poll message should be process before stop the worker |
openzipkinzipkin | support upload trace in zipkin lens ui | Enhancement | relate 2350 history 2424 |
openzipkinzipkin | fix component that resize timeline column | Bug | these don t work I fix they |
openzipkinzipkin | fix piechart no space bug | Bug | 2425 delete legend that display service name because it put pressure on pie chart these legend be not necessary because similar information be on the top before after |
openzipkinzipkin | client only trace will not show of there be server side trace in zipkin ui | Question | so I have the following 1 zipkin js spa application let s call this service a write in vue which will intercept api call to backend and instrument it with an axio plugin basically it will intercept any api request and add zipkin instrumentation var instrumentation new zipkin instrumentation httpclient option const zipkinconfig instrumentation recordrequest config config url config method this be the payload send from service a to zipkin api duration 3332000 i d 292135f69ada510c kind client localendpoint servicename service a name get tag http path customer 1 timestamp 1552275283625000 traceid 292135f69ada510c 2 spring boot application with spring cloud sleuth zipkin with an api endpoint let call this service aaa both of they be point to zipkin instance the problem be 1 if both the client and server send span datum to zipkin what I get in zipkin ui will be only bar of backend span only service aaa I expect there will be parent span show from zipkin js and a child span show from backend but that s not what happen here 2 but if I intentionally do not send spring boot backend span to zipkin for example by use false zipkin host in my spring boot config the span bar in zipkin ui will show this be the json show in zipkin ui show json button for no 1 note that the traceid of different request of course will be different but let s just assume it s the same to show my point otherwise it s the same format traceid 292135f69ada510c i d 292135f69ada510c kind client name get timestamp 1552275283625000 duration 3332000 localendpoint servicename service a tag http path customer 1 http status code 200 result transformrequest and this be for no 2 traceid 292135f69ada510c i d 292135f69ada510c kind server name get customer i d timestamp 1552275283634060 duration 10276 localendpoint servicename aaa ipv4 172 17 0 1 remoteendpoint ipv6 1 port 39274 tag http method get http path customer 1 mvc controller class applicationctrlr mvc controller method testauth share true traceid 292135f69ada510c i d 292135f69ada510c kind client name get timestamp 1552275283625000 duration 3332000 localendpoint servicename service a tag http path customer 1 http status code 200 result transformrequest this make I assume that if only client span be be send then zipkin will display but if there be also server side span zipkin ui will only display server side span be this the intend behaviour how can I also show client side span in zipkin ui when there be server side span note that I also try the same in jaeger and it show the result that I expect I e parent span for service a and child span for service aaa thank |
openzipkinzipkin | add bytebuffer version to bytesdecoder | Enhancement | feature description of the feature currently bytesdecoder only support operate on byte it could define similar method that work on bytebuffer rational why this feature should be in zipkin as zipkin be migrate to use netty via armeria and look into add grpc ingestion optimization become possible that use netty s bytebuf which be a manually allocate buffer use bytebuf more would reduce garbage and probably increase throughput of zipkin server and this can be do by make method that accept bytebuffer example scenario when will this be use by operator zipkin server would use it when ingest span implementation would look like json currently use bytearrayinputstream while there be no bytebufferinputstream in the jdk for some reason it would be trivial to add one like this and the rest of the business logic would be unchanged 6603018 though it would also be worth consider move from gson to jackson in my experience I ve get well performance from the latter and it would natively support work on bytebuffer just for reference here be some code that use jackson s incremental parser l65 thrift currently use bytebuffer wrap as it already operate on bytebuffer there be basically no work involve proto use lot of manual operation on byte would need the most logic rewrite my recommendation would be go ahead and convert to bytebuffer and use bytebuffer wrap for the byte path adriancole do this seem like a reasonable idea |
openzipkinzipkin | fix some lens ui bug | Bug | service name be now alphabetically sort the api seem to return they out of order so let s sort they just to be sure add missing space between span count and the span word timestamp in the span detail view now have microsecond precision moment js doesn t support that so I have to append the last 3 digit of the timestamp to the human readable string css be weird apparently it s enough to set white space normal to make long text wrap correctly in the span detail view I also test with a single very long word and if that doesn t fit in the screen it get split automatically |
openzipkinzipkin | add integration test for message linking and fix mysql impl | Bug | other storage option be document orient so weren t subject to field constraint this fix the field cherry pick from mysql which be need to link message span this add the miss integration test which only ensure datum be there the complete logic test be dependencylinkert thank mbrade for report |
openzipkinzipkin | metric doesn t increment for kafka | Bug | possibly because of the two kafka config the kafka section of the metric endpoint doesn t increment while it do on actuator prometheus |
openzipkinzipkin | can I change embed web contaner form undertow to tomcat for collector module | Question | 1 my team want to embed the collector server into our application server then add some controller before the span receiver maybe the zipkin2 server internal zipkinhttpcollector handlerequest we don t familiar with undertow be there any solution 2 can we change the default web container from undertow to tomcat just to the conllector server |
openzipkinzipkin | support upload trace in zipkin lens ui | Enhancement | 2350 traceviewer 1 traceviewer 2 |
openzipkinzipkin | zipkin ui not show correctly in some condition | Bug | I be use the zipkin server 2 12 default default my chrome version default the ui seem ok if the zipkin server version be 2 6 1 here be the json datum default tag asyncthread false companyid 260 currentthread thread http nio 8090 exec 9 5 main envcode dev graygroup null logtype 3 nscode ones2 6 prod orm mybatis query sql select count 1 from n select n promotion i d as activity i d n promotion prom title as title n promotion prom type as prom type n promotion front promotion type as front promotion type n promotion start time as start time n promotion end time as end time n if n promotion status 4 n if n promotion start time now n 2 n if n promotion end time now n 5 n promotion status n n n promotion status n as status n promotion remark as remark n promotion create username as create username n promotion create time as create time n promotion be delete as be delete n promotion company i d as company i d n promotion create merchant i d as create merchant i d n promotion create merchant name as create merchant name n promotion activity type as activity type n promotion merchant type as merchant type n promotion prom platform as prom platform n promotion pay type as pay type n promotion rule desc as rule desc n promotion limit rule type as limit rule type n promotion create userid as create userid n from n promotion n where 1 1 n n n and n n n promotion activity type 1 n n n n and n n exist select 1 from promotion merchant where promotion i d promotion merchant promotion i d n and promotion merchant be delete 0 and merchant type 1 and promotion merchant merchant i d in n n 3 n n 1902200000000062 n n 2076093200000000 n n n n n n n or n not exist select 1 from promotion merchant where promotion i d promotion merchant promotion i d and promotion merchant be delete 0 and n promotion create userid 19021512440476 and promotion activity type 1 n n n or promotion activity type 2 n n n n n n n n n n n n union all n select n patch groupon theme i d as activity i d n patch groupon theme activity title as title n patch groupon theme prom type as prom type n patch groupon theme front promotion type as front promotion type n patch groupon theme eff start date as start time n patch groupon theme eff end date as end time n if n n patch groupon theme status 4 n n if n n patch groupon theme eff start date now n n 2 n if n n patch groupon theme eff end date now n n 5 n patch groupon theme status n n n patch groupon theme status n as status n patch groupon theme remark as remark n patch groupon theme create username as create username n patch groupon theme create time as create time n patch groupon theme be delete as be delete n patch groupon theme company i d as company i d n patch groupon theme create merchant i d as create merchant i d n patch groupon theme create merchant name as create merchant name n patch groupon theme activity type as activity type n patch groupon theme merchant type as merchant type n patch groupon theme prom platform as prom platform n null as pay type n patch groupon theme description as rule desc n null as limit rule type n patch groupon theme create userid as create userid n from n patch groupon theme n where 1 1 n n n n and n n n exist n n select 1 from patch groupon stock lmt pgsl where n pgsl company i d 260 and pgsl ref patch groupon theme patch groupon theme i d and pgsl be delete 0 n and pgsl merchant i d in n n 3 n n 1902200000000062 n n 2076093200000000 n n or n n n n not exist select 1 from patch groupon stock lmt pgsl where pgsl company i d 260 and n pgsl ref patch groupon theme patch groupon theme i d and pgsl be delete 0 n and patch groupon theme create userid 19021512440476 n n n n union all n select n cut price theme i d as activity i d n cut price theme activity title as title n cut price theme front promotion type as prom type n cut price theme front promotion type as front promotion type n cut price theme start time as start time n cut price theme end time as end time n if n cut price theme status 4 n if n n cut price theme start time now n n 2 n if n n cut price theme end time now n n 5 n cut price theme status n n n cut price theme status n as status n cut price theme remark as remark n cut price theme create username as create username n cut price theme create time as create time n cut price theme be delete as be delete n cut price theme company i d as company i d n cut price theme create merchant i d as create merchant i d n cut price theme create merchant name as create merchant name n cut price theme activity type as activity type n cut price theme merchant type as merchant type n cut price theme prom platform as prom platform n null as pay type n cut price theme description as rule desc n null as limit rule type n cut price theme create userid as create userid n from n cut price theme n where 1 1 n n n and n n n exist n n select 1 from cut price mp cpm where n cpm company i d 260 and cpm ref theme i d cut price theme i d and cpm be delete 0 n and cpm merchant i d in n n 3 n n 1902200000000062 n n 2076093200000000 n n or n n n n not exist select 1 from cut price mp cpm where cpm company i d 260 and cpm be delete 0 n and cpm ref theme i d cut price theme i d n and cut price theme create userid 19021512440476 n n n union all n select n lottery theme i d as activity i d n lottery theme activity name as title n lottery theme front promotion type as prom type n lottery theme front promotion type as front promotion type n lottery theme eff start time as start time n lottery theme eff end time as end time n if n lottery theme status 4 n if n n lottery theme eff start time now n n 2 n if n n lottery theme eff end time now n n 5 n lottery theme status n n n lottery theme status n as status n lottery theme remark as remark n lottery theme create username as create username n lottery theme create time as create time n lottery theme be delete as be delete n lottery theme company i d as company i d n lottery theme create merchant i d as create merchant i d n lottery theme create merchant name as create merchant name n null as activity type n null as merchant type n null as prom platform n null as pay type n lottery theme activity desc as rule desc n null as limit rule type n lottery theme create userid as create userid n from n lottery theme n where 1 1 n n n union all n select n free order activity i d as activity i d n free order activity name as title n free order activity front promotion type as prom type n free order activity front promotion type as front promotion type n free order activity start time as start time n free order activity end time as end time n if n n free order activity status 4 n n if n n free order activity start time now n n 2 n if n n free order activity end time now n n 5 n free order activity status n n n free order activity status n as status n free order activity remark as remark n free order activity create username as create username n free order activity create time as create time n free order activity be delete as be delete n free order activity company i d as company i d n free order activity create merchant i d as create merchant i d n free order activity create merchant name as create merchant name n null as activity type n null as merchant type n null as prom platform n null as pay type n free order activity description as rule desc n null as limit rule type n free order activity create userid as create userid n from n free order activity n where 1 1 n n n n union all n select n referral code theme i d as activity i d n referral code theme name as title n referral code theme front promotion type as prom type n referral code theme front promotion type as front promotion type n referral code theme start time as start time n referral code theme end time as end time n if n referral code theme status 4 n if n n referral code theme start time now n n 2 n if n referral code theme end time now n 5 n referral code theme status n n n referral code theme status n as status n referral code theme remark as remark n referral code theme create username as create username n referral code theme create time as create time n referral code theme be delete as be delete n referral code theme company i d as company i d n referral code theme create merchant i d as create merchant i d n referral code theme create merchant name as create merchant name n null as activity type n null as merchant type n referral code theme prom platform as prom platform n null as pay type n referral code theme description as rule desc n null as limit rule type n referral code theme create userid as create userid n from referral code theme n n n n n union all n select n coupon theme i d as activity i d n coupon theme theme title as title n coupon theme prom type as prom type n coupon theme front promotion type as front promotion type n coupon theme start time as start time n coupon theme end time as end time n if n coupon theme status 4 n if n n coupon theme start time now n n 2 n if n coupon theme end time now n 5 n coupon theme status n n n coupon theme status n as status n coupon theme remark as remark n coupon theme create username as create username n coupon theme create time as create time n coupon theme be delete as be delete n coupon theme company i d as company i d n coupon theme create merchant i d as create merchant i d n coupon theme create merchant name as create merchant name n null as activity type n null as merchant type n coupon theme theme type as prom platform n null as pay type n coupon theme theme desc as rule desc n null as limit rule type n coupon theme create userid as create userid n from n coupon theme n where 1 1 n n n and n n n exist n n select from mkt use rule mkr where n mkr company i d 260 and mkr ref type 0 and mkr theme ref coupon theme i d and mkr be delete 0 n and mkr rule type 1 and mkr limit ref in n n 3 n n 1902200000000062 n n 2076093200000000 n n or n n not exist select 1 from mkt use rule mkr where mkr company i d 260 and mkr ref type 0 and n mkr theme ref coupon theme i d and mkr be delete 0 and mkr rule type 1 n and coupon theme theme type 11 and coupon theme create userid 19021512440476 n or n coupon theme theme type 0 n n n n n n n as a n where 1 1 and be delete 0 and company i d 260 n n n n n n and n a prom type 1 query statement i d com odianyun basic dao promotion promotionextdao querypromotionactivitycount zknamespace p2d6 d please check it |
openzipkinzipkin | zipkin lens tag value doesn t wrap | Bug | in zipkin lens if your tag have a very long value which be large than the window the string doesn t wrap it do in the old ui and it just get cut off |
openzipkinzipkin | refactor timeline component | Enhancement | the code of timeline component be dirty so I refactore they use bem notation for css rename some variable |
openzipkinzipkin | refactor prop type | Enhancement | collect the definition of proptype in various file into one file and use they fix type bug of limit condition component |
openzipkinzipkin | fix css bug of limit condition and lookback condition component in zipkin len | Bug | I find some css bug in limit condition and lookback condition component before after |
openzipkinzipkin | update to datastax cassandra driver v4 | Enhancement | we should probably try the beta of datastax cassandra driver v4 in case there be problem around topic such as trace or cruft we can remove cc openzipkin cassandra see 952 for discussion about move to v3 |
openzipkinzipkin | suggest use of zipkin lens when run a standard server | Enhancement | this add a try lens ui button to the classic ui when run in the standard build which can server both asset tree at once this be control by suggest lens env variable set to true by default those simply host zipkin ui asset will not be impact this work via a normal browser cookie if someone want to stop use lens then close their browser and reload the page switcheroo this button can be disable by set zipkin ui suggest lens false thank for tip by kaiyzen bsideup while the approach here be dirty one nice thing be that it leave no permanent trace in publish asset etc all the control can be remove with no change to user in the next month or two when transition complete cc openzipkin ui fix 2402 |
openzipkinzipkin | allow switching between zipkin lens and prior ui during transition phase | Enhancement | feature allow zipkin end user to switch between zipkin lens and the historic ui rational we be transition between the two uis and it would be a nice user experience if individual user can switch between the two currently only operator can decide which ui be use for all user of that deployment at startup if user can switch this give they the choice of which ui to use when and notably allow early adopter tester of zipkin lens while provide a fallback between when any issue be find and when a release be make with it fix in zipkin lens example scenario power user want to try the late and great ui for zipkin without force all user to try it at once or all the time prior art adriancole may have find a way to hack this together |
openzipkinzipkin | zipkin ui not show correctly in some condition | null | default pay attention to the red area it seem zipkin ui show a long value not correctly when the long value be more then 16 bit the correct value be 1292520862062216190l the wrong show value be 1292520862062216200 the zipkin server version be 2 6 1 any solution about it or use a high version of zipkin server thank |
openzipkinzipkin | show different tag value when client and server differ | Bug | this do the minimal need to show that there be different value for the same tag between a client and a server future work could be consider to answer who send what value in the mean time user can inspect the json button when this occur fix 2390 before different value be swallow screen shoot 2019 02 17 at 11 31 02 am screen shoot 2019 02 17 at 11 31 15 am after different value be display screen shoot 2019 02 17 at 11 27 56 am screen shoot 2019 02 17 at 11 27 42 am |
openzipkinzipkin | fix a css bug of search bar in len | Bug | before after |
openzipkinzipkin | if client and server side have a same tag name should it be display server side tag value | Bug | client side hapi demo and server side soa demo server have same tag name serviceid servicename but tag value be not same tag value be 0010100001 hapi demo and 0010100003 soa demo service and now display client tag value shoulde it display server side tag value trace json trace zip image |
openzipkinzipkin | show both client and server timing | Enhancement | relate 2365 how to implement if the span s annotation contain client start and client finish and server start and server finish use they for render the span bar instead of span leave and span width example1 before after example2 before after cc drolando |
openzipkinzipkin | reuse search bar for dependency page | Enhancement | current dependency page be redundant because it have two condition form we should unite they x simplify route logic add search button and analyze dependency button to search bar add tooltip to these button improve key handling if enter key be hit in the search page search trace if enter key be hit in the dependency page analyze dependency |
openzipkinzipkin | use react numeric input for limit condition | Bug | limitcondition component do not work in firefox I could fix it but I though that I should use third party library I try two follow library rc input number react numeric input I opt for react numeric input because it be easy to customize the style after limit condition |
openzipkinzipkin | do not try to create rabbitmq queue if one already exist | Bug | rabbitmq may be manage by a team that will create queue with additional configuration beyond the default value the rabbitmqcollector would use before the collector would fail to start because it unconditionally try declare a queue but one with the same name and different configuration already exist this also clean up the channel use to check and maybe create the queue which use to stick around even though it would never be use again fix 2068 |
openzipkinzipkin | add link of github twitter gitter to sidebar | Enhancement | this be an experimental pr if you don t like this please close this pr before after |
openzipkinzipkin | fix autocompletetag bug for elasticsearch | Bug | if the type of tagvalue be text it will be splitte with some character hyphen space etc when aggregate so I use keyword type for tagvalue example if I post the follow trace datum tag instanceid hello zipkin world previous response for api v2 autocompletevalue key instanceid hello world zipkin current this pr response for api v2 autocompletevalue key instanceid hello zipkin world |
openzipkinzipkin | support search open a trace by traceid in len | Enhancement | relate 2352 |
openzipkinzipkin | zipkin elasticsearch storage fail to put index template | Invalid | describe the bug start zipkin with elasticsearch storage and elasticsearch 6 5 4 step to reproduce start zipkin v2 12 0 with elasticsearch 6 5 4 as storage there be a problem during index template configuration 2019 01 28 15 47 17 210 debug 412 pool 2 thread 1 z c k kafkacollector can not store span 02a7641b97d0a41e 8fcbe13bb5f55469 due to illegalstateexception response for update template fail error root cause type parse exception reason fail to parse content to map type parse exception reason fail to parse content to map cause by type json parse exception reason unexpected character z code 122 be expect comma to separate object entry n at source org elasticsearch transport netty4 bytebufstreaminput 676d081c line 2 column 24 status 400 java lang illegalstateexception response for update template fail error root cause type parse exception reason fail to parse content to map type parse exception reason fail to parse content to map cause by type json parse exception reason unexpected character z code 122 be expect comma to separate object entry n at source org elasticsearch transport netty4 bytebufstreaminput 676d081c line 2 column 24 status 400 at zipkin2 elasticsearch internal client httpcall parseresponse httpcall java 151 zipkin storage elasticsearch 2 12 0 jar at zipkin2 elasticsearch internal client httpcall execute httpcall java 79 zipkin storage elasticsearch 2 12 0 jar at zipkin2 elasticsearch ensureindextemplate apply ensureindextemplate java 42 zipkin storage elasticsearch 2 12 0 jar at zipkin2 elasticsearch elasticsearchstorage ensureindextemplate elasticsearchstorage java 351 zipkin storage elasticsearch 2 12 0 jar at zipkin2 elasticsearch autovalue elasticsearchstorage ensureindextemplate autovalue elasticsearchstorage java 31 zipkin storage elasticsearch 2 12 0 jar at zipkin2 elasticsearch elasticsearchstorage spanconsumer elasticsearchstorage java 260 zipkin storage elasticsearch 2 12 0 jar at zipkin2 collector collector record collector java 150 zipkin collector 2 12 0 jar at zipkin2 collector collector accept collector java 110 zipkin collector 2 12 0 jar at zipkin2 collector collector acceptspans collector java 140 zipkin collector 2 12 0 jar at zipkin2 collector collector acceptspans collector java 127 zipkin collector 2 12 0 jar at zipkin2 collector kafka kafkacollectorworker run kafkacollectorworker java 101 zipkin collector kafka 2 12 0 jar at zipkin2 collector kafka kafkacollector lazykafkaworker lambda guardfailure 0 kafkacollector java 252 zipkin collector kafka 2 12 0 jar at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1142 1 8 0 121 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 617 1 8 0 121 at java lang thread run thread java 745 1 8 0 121 expect behaviour index template properly configure |
openzipkinzipkin | zipkin lens show both client and server timing in rpc span | Enhancement | this be something we talk about a while ago but decide that it be too hard to do until we move to svg rendering filing here for reference so we don t forget right now the blue bar for rpc span show client timing it start at the client ts and end after the client duration to check how much the network delay be and how long the server actually take you have to click on it and manually check the timestamp it d be nice if that bar be actually compose of 2 different bar a dark blue one that still represent client timing like now and an overlap light bar that show server timing that way you can see the network delay just by look at the trace view I don t know how hard it be to implement in css though tacigar zeagord |
openzipkinzipkin | endts remain unchanged in zipkin len | Help Wanted | describe the bug endts seem to remain unchanged until refresh the page entirely f5 so new trace wouldn t come when click the lens icon image if this behavior be intentional it would be nice to provide a refresh button step to reproduce enable zipkin lens click change search criterion or go to dependency page and back to search page click again expect behaviour I d like to update trace without reload the page |
openzipkinzipkin | ui window location create an invalid url | Bug | when you execute a search the window location change from zipkin to zipkin without slash which result in a 404 if you execute that |
openzipkinzipkin | the http mapping url for api v2 span | Question | I notice that when span send from zipkin it will post one http request to zipkin server endpoint api v2 span but I can not find any mapping path with post method from zipkin server log I be not sure if that be expect behavior or not 2019 01 23 08 40 16 457 info 1 main s w s m m a requestmappinghandlermapping map api v2 service method get onto public org springframework http responseentity zipkin2 server internal zipkinqueryapiv2 getservicename throw java io ioexception 2019 01 23 08 40 16 467 info 1 main s w s m m a requestmappinghandlermapping map api v2 trace traceidhex method get produce application json onto public java lang string zipkin2 server internal zipkinqueryapiv2 gettrace java lang string org springframework web context request webrequ throw java io ioexception 2019 01 23 08 40 16 468 info 1 main s w s m m a requestmappinghandlermapping map api v2 span method get onto public org springframework http responseentity zipkin2 server internal zipkinqueryapiv2 getspanname java lang string throw java io ioexception 2019 01 23 08 40 16 469 info 1 main s w s m m a requestmappinghandlermapping map api v2 trace method get produce application json onto public java lang string zipkin2 server internal zipkinqueryapiv2 gettrace java lang string java lang string java lang string java lang long java lang long java lang long java lang long int throw java io ioexception 2019 01 23 08 40 16 473 info 1 main s w s m m a requestmappinghandlermapping map metric method get onto public com fasterxml jackson databind node objectnode zipkin2 server internal metricshealthcontroller fetchmetricsfrommicrometer |
openzipkinzipkin | persistent cross site script xss zipkin ui | Bug | describe the bug zipkin client side sanitization library only escape annotation value tag property for xss attack but fail to do the same for localendpoint servicename remoteendpoint servicename this allow an attacker to store persistent xss payload into span information store in persistent cassandra store I also suspect that traceid i d may be vulnerable to the same attack but currently other check while insertion return can not decode span which avoid xss via those parameter the exception be throw on manipulate traceid i d l118 l141 step to reproduce step to reproduce the behavior malicious datum span curl s h content type application json d traceid ab5aa5e5661c95a8 i d bad160f0fd2d9a99 name timestamp 1546646352588 duration 6650 annotation timestamp 1546646352588 value test 1 endpoint servicename unknown ipv4 192 168 182 54 timestamp 1546646352588 value annotation 2 endpoint servicename unknown ipv4 192 168 182 54 timestamp 1546646352588 value test 3 endpoint servicename unknown ipv4 192 168 182 54 localendpoint servicename mobile gateway ipv4 172 17 0 255 remoteendpoint ipv4 110 170 201 178 port 39308 tag http method option http path mobile gateway content personal v post api v2 span http 1 1 host localhost user agent curl 7 54 0 accept content type application json content length 1088 expect 100 continue http 1 1 100 continue we be completely uploaded and fine http 1 1 202 accept server applehttpserver 7534b10f date mon 07 jan 2019 19 27 51 gmt content length 0 connection keep alive vary origin x b3 traceid a9530e599ade603d x plb respond instance plbproxy001 usnkq06d pie apple com x plb respond upstream 17 147 52 245 31152 x plb upstream response 202 strict transport security max age 31536000 js stacktrace payload trace console trace 3 ab5aa5e5661c95a8 1 7 o jquery js 111 p jquery js 5762 append jquery js 5898 t defaultvalue tag property l5 l18 I be wonder if someone can help I find where can I introduce a similar fix I be new to js and ui development so any help and pointer will be much appreciated thank addde some snapshot of the problem |
openzipkinzipkin | feature request logz io storage option | Enhancement | logz io be an elastic search base monitoring service we would like to contribute by add logz io storage option along with cassandra elastic search and the rest be that something you would be willing to merge in |
openzipkinzipkin | change theme of dependency page | Enhancement | relate 2321 |
openzipkinzipkin | zipkinmysqlstorageautoconfiguration find 2 instance of bean applicationtaskexecutor | Question | when zipkin server start I get this error application fail to start description parameter 0 of method storage in zipkin2 autoconfigure storage mysql zipkinmysqlstorageautoconfiguration require a single bean but 2 be find applicationtaskexecutor define by method applicationtaskexecutor in class path resource org springframework boot autoconfigure task taskexecutionautoconfiguration class taskscheduler define in null action consider mark one of the bean as primary update the consumer to accept multiple bean or use qualifier to identify the bean that should be consume zipkin server 2 11 12 with mysql autoconfigure use spring boot 2 1 2 release spring cloud greenwich rc2 |
openzipkinzipkin | support search open a trace by i d in len | Enhancement | in the old ui there s a textbox where you can enter the traceid and open directly that trace we should add it also to zipkin len |
openzipkinzipkin | return service only one but from the trace you can find more service | Question | 62c30501 7a06 4beb 80b2 0e04bdc5ebc0 |
openzipkinzipkin | use the client remote service name instead of the client local service name | Enhancement | if I have a span like below with no server span the ui will display the service name as sample but this make no sense as it be a call into mysql from sample kind client name query timestamp 1547069325788000 duration 10000 localendpoint servicename sample ipv4 127 0 0 1 port 12345 remoteendpoint servicename mysql ipv4 10 0 0 0 port 12345 annotation timestamp 1547069325788000 value cs timestamp 1547069325798000 value cr this pr make the ui use the client remote service name instead of the client local service name if no server local service name exist I believe this fix the leaf span issue mention in 2274 |
openzipkinzipkin | zipkin2 late with elasticserch 5 6 12 and query error | Question | describe the bug I debug the zipkin2 and use es as the storage when query it s error below be the stacetrace cause by java lang illegalstateexception response for aggregation fail error root cause type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead type search phase execution exception reason all shard fail phase query group true fail shard shard 0 index zipkin span 2019 01 04 node lb6dkkbatyuoy2rbosww5w reason type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead status 400 at zipkin2 elasticsearch internal client httpcall parseresponse httpcall java 151 class at zipkin2 elasticsearch internal client httpcall execute httpcall java 79 class at zipkin2 call flatmappe doexecute call java 276 class at zipkin2 call base execute call java 379 class at zipkin2 call mapping doexecute call java 237 class at zipkin2 call base execute call java 379 class at zipkin2 call mapping doexecute call java 237 class at zipkin2 call base execute call java 379 class at zipkin2 server internal zipkinqueryapiv2 gettrace zipkinqueryapiv2 java 123 class at sun reflect nativemethodaccessorimpl invoke0 native method 1 8 0 151 at sun reflect nativemethodaccessorimpl invoke nativemethodaccessorimpl java 62 1 8 0 151 at sun reflect delegatingmethodaccessorimpl invoke delegatingmethodaccessorimpl java 43 1 8 0 151 at java lang reflect method invoke method java 498 1 8 0 151 at org springframework web method support invocablehandlermethod doinvoke invocablehandlermethod java 189 spring web 5 1 3 release jar 5 1 3 release at org springframework web method support invocablehandlermethod invokeforrequest invocablehandlermethod java 138 spring web 5 1 3 release jar 5 1 3 release at org springframework web servlet mvc method annotation servletinvocablehandlermethod invokeandhandle servletinvocablehandlermethod java 102 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet mvc method annotation requestmappinghandleradapter invokehandlermethod requestmappinghandleradapter java 895 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet mvc method annotation requestmappinghandleradapter handleinternal requestmappinghandleradapter java 800 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet mvc method abstracthandlermethodadapter handle abstracthandlermethodadapter java 87 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet dispatcherservlet dodispatch dispatcherservlet java 1038 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet dispatcherservlet doservice dispatcherservlet java 942 spring webmvc 5 1 3 release jar 5 1 3 release at org springframework web servlet frameworkservlet processrequest frameworkservlet java 1005 spring webmvc 5 1 3 release jar 5 1 3 release 84 more step to reproduce use two zipkin demo to produce the datum and use the zipkin api v2 trace api to query expect behaviour |
openzipkinzipkin | 2 11 represent service name in the ui and dependency graph differently than before | Question | the 2 10 docker image work fine 2 11 or new break nesting and also the service graph I m run the follow 2 10 docker run rm it p 9411 9411 openzipkin zipkin 2 10 2 11 docker run rm it p 9411 9411 openzipkin zipkin 2 11 2 10 work 2 10 2 11 break nest 2 11 the follow code be use net core 2 1 use microsoft extension dependencyinjection use microsoft extension log use system use system collection generic use system linq use system threading use system threading task use zipkin4net use zipkin4net middleware use zipkin4net tracer zipkin use zipkin4net transport http namespace tracingt class program static readonly datetime startdatetime static readonly long starttick static program startdatetime datetime utcnow starttick system diagnostic stopwatch gettimestamp static async task main string args use var service new servicecollection addlogge builder builder addconsole adddebug buildserviceprovider tracemanager samplingrate 1 var loggerfactory service getrequiredservice var logger new tracinglogger loggerfactory trace var sender new httpzipkinsender application json var serializer new jsonspanserializer var tracer new zipkintracer sender serializer tracemanager registertracer tracer tracemanager start logg timing var uistart utcnow var gatewaystart uistart addmillisecond 10 var gatewaycallauthstart gatewaystart addmillisecond 10 var gatewaycallprofilestart gatewaystart addmillisecond 20 var authstart gatewaycallauthstart addmillisecond 10 var authend authstart addmillisecond 500 var gatewaycallauthend authend addmillisecond 10 var profilestart gatewaycallprofilestart addmillisecond 10 var profileend profilestart addmillisecond 100 var gatewaycallprofileend profileend addmillisecond 10 var gatewayend new datetime math max gatewaycallauthend tick gatewaycallprofileend tick datetimekind utc addmillisecond 10 var uiend gatewayend addmillisecond 10 ui call gateway var uitrace trace create uitrace record annotation servicename client uitrace record annotation rpc get user uitrace record annotation clientsend uistart uitrace record annotation clientrecv uiend gateway var gatewaytrace uitrace child gatewaytrace record annotation servicename api gateway gatewaytrace record annotation rpc get user gatewaytrace record annotation serverrecv gatewaystart gatewaytrace record annotation serversend gatewayend gateway call auth var gatewaycallauthtrace gatewaytrace child gatewaycallauthtrace record annotation servicename auth service gatewaycallauthtrace record annotation rpc get permission gatewaycallauthtrace record annotation clientsend gatewaycallauthstart gatewaycallauthtrace record annotation clientrecv gatewaycallauthend gateway call profile var gatewaycallprofiletrace gatewaytrace child gatewaycallprofiletrace record annotation servicename api gateway gatewaycallprofiletrace record annotation rpc get profile gatewaycallprofiletrace record annotation clientsend gatewaycallprofilestart gatewaycallprofiletrace record annotation clientrecv gatewaycallprofileend auth service var authtrace gatewaycallauthtrace child authtrace record annotation servicename auth service authtrace record annotation rpc get permission authtrace record annotation serverrecv authstart authtrace record annotation serversend authend profile service var profiletrace gatewaycallprofiletrace child profiletrace record annotation servicename profile service profiletrace record annotation rpc get profile profiletrace record annotation serverrecv profilestart profiletrace record annotation serversend profileend wait for key to close program console readkey true tracemanager stop tracemanager cleartracer static datetime utcnow startdatetime addtick system diagnostic stopwatch gettimestamp starttick see issue on client for more info |
openzipkinzipkin | storage elasticsearch why all the e port must be the same | Enhancement | read the doc to see this you can alternatively supply a list of http base url this list be use to recover from failure note that all port must be the same and the scheme must be http not https that mean isn t supprte if need this to be improve I can give a pr |
openzipkinzipkin | css error zipkin ui not fit box detail trace | Duplicate | hi css style error in trace detail for version major 0 13 0 huge string not fit in the box |
openzipkinzipkin | zipkin api do not work | Question | zipkin server 2 10 1 when I call api v2 trace it return timestamp 2018 12 20t06 12 35 399 0000 status 500 error internal server error message request processing fail nest exception be java lang illegalstateexception response for aggregation fail error root cause type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead type search phase execution exception reason all shard fail phase query group true fail shard shard 0 index zipkin span 2018 12 20 node rmzo69v0qzusghxl0kusba reason type illegal argument exception reason fielddata be disabled on text field by default set fielddata true on traceid in order to load fielddata in memory by uninverte the invert index note that this can however use significant memory alternatively use a keyword field instead status 400 path api v2 trace |
openzipkinzipkin | lens blank page after plus button | Bug | describe the bug when you click on the plus button when the span be expand it go to a black screen step to reproduce 1 expand a span with detail that have child 1 click the plus button on the left while the span detail be show js stack app 01a4167 min js 41 typeerror can not read property length of undefined at app 01a4167 min js 25 at array map at t value app 01a4167 min js 25 at ta app 01a4167 min js 41 at la app 01a4167 min js 41 at fo app 01a4167 min js 41 at ho app 01a4167 min js 41 at xo app 01a4167 min js 41 at will app 01a4167 min js 41 at vo app 01a4167 min js 41 app 01a4167 min js 25 uncaught typeerror can not read property length of undefined at app 01a4167 min js 25 at array map at t value app 01a4167 min js 25 at ta app 01a4167 min js 41 at la app 01a4167 min js 41 at fo app 01a4167 min js 41 at ho app 01a4167 min js 41 at xo app 01a4167 min js 41 at will app 01a4167 min js 41 at vo app 01a4167 min js 41 |
openzipkinzipkin | make search component for lens | Enhancement | relate 2323 |
openzipkinzipkin | make search component for lens | Enhancement | feature create a more convenient search component for lens rational make it easy for user to search for trace example scenario when user search for trace prior art |
openzipkinzipkin | make zipkin lens use the same or similar color scheme to the previous ui | Enhancement | we ve have a number of informal feedback that people like the old color scheme let s switch zipkin lens to something that be less shocking |
openzipkinzipkin | update a preprocessing logic to be apply to trace | Enhancement | currently zipkin lens reuse the zipkin ui s preprocesse logic to be apply to trace this pr update the preprocessing logic of zipkin lens with the late zipkin ui s logic however some change have be make accord to linter s warning and some processing have also be change |
openzipkinzipkin | move zipkin lens over from | Enhancement | current status we have some step leave before we can merge into master however you can test now by check out the zipkin lens branch server package with lens the lens ui be bundle into the default zipkin server if you want to try you can build locally building locally then pass the argument zipkin ui source root classpath zipkin lens to enable lens ex bash mvnw dlicense skip true dskiptest also make pl zipkin server clean install java jar zipkin server target zipkin server exec jar zipkin ui source root classpath zipkin lens todo x remove code of conduct contribute detail as they be inherit from the main project x clarify if we can replace the license header with the normal one as they will later be rewrite with apache one anyway x integration with spring boot x add ci integration for zipkin len |
openzipkinzipkin | improve performance of our trace detail page | Enhancement | I think we be probably not do thing in the most efficient way I m hope maybe someone like ghermeto could review some of our code for opportunity for improvement or even well improve it goal would be to ensure fast rendering of trace with 1k span look at zipkin ui testdata for example notably the follow file would be helpful to get some performance advice on and especially some thought on tooling to ensure we know how well they be do zipkin ui js component datum skew js zipkin ui js component datum spancleaner js zipkin ui js component datum spannode js zipkin ui js component ui tracesummary js zipkin ui js component ui tracetomustache js cc openzipkin ui |
openzipkinzipkin | use spannode to generate the trace tree for the detail screen | Enhancement | there s still more work to do but this remove some redundant tree walk code |
openzipkinzipkin | don t pop out span detail | Enhancement | discuss with atlassian and they say pop out of span detail be not nice compare to a sidebar which open leave when you click a span the reason be that the pop out lose your place in the trace the trace detail screen should optimize for find the place so pop out work against that iotw consider replace pop out with sidebar or something else |
openzipkinzipkin | fix suffix s | Bug | thank shakuzen for report |
openzipkinzipkin | align json button right and delete dead json button style | Bug | thank for drolando for the tip I also notice an orphan style and remove it as it be confuse I |
openzipkinzipkin | validate the duration filter | Enhancement | from drolando it d be nice to validate in js the duration filter in the search page if I try to filter for trace long than 1 m I just get back a confusing error error execute query bad request it d be nice to show a popup say we only support we ms and s |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.