repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
OData/odata.net | OData | 106,306,687 | 336 | null | [
{
"action": "opened",
"author": "LaylaLiu",
"comment_id": null,
"datetime": 1442223874000,
"masked_author": "username_0",
"text": "Model:\r\n \r\n <ComplexType Name=\"BaseComplexType\" Abstract=\"true\">\r\n <Property Name=\"AnyP\" Type=\"Edm.String\" />\r\n </ComplexType>\r\n <ComplexType Name=\"Address\" BaseType=\"Service1.Models.BaseComplexType\">\r\n <Property Name=\"Street\" Type=\"Edm.String\" />\r\n </ComplexType>\r\n <ComplexType Name=\"HomeAddress\" BaseType=\"Service1.Models.Address\">\r\n <Property Name=\"City\" Type=\"Edm.String\" />\r\n </ComplexType>\r\n <EntityType Name=\"Customer\">\r\n <Key>\r\n <PropertyRef Name=\"Id\" />\r\n </Key>\r\n <Property Name=\"Id\" Type=\"Edm.Int32\" Nullable=\"false\" />\r\n <Property Name=\"Name\" Type=\"Edm.String\" />\r\n <Property Name=\"CompanyAddress\" Type=\"Service1.Models.Address\" />\r\n <Property Name=\"HomeAddress\" Type=\"Service1.Models.HomeAddress\" />\r\n </EntityType>\r\n <Function Name=\"AbstractNonP\" IsBound=\"true\">\r\n <Parameter Name=\"bindingParameter\" Type=\"Collection(Service1.Models.Customer)\" />\r\n <ReturnType Type=\"Collection(Service1.Models.BaseComplexType)\" />\r\n </Function>\r\n <EntityContainer Name=\"Container\">\r\n <EntitySet Name=\"Customers\" EntityType=\"Service1.Models.Customer\" />\r\n </EntityContainer>\r\n\r\nThen if the context url in actually reponse playload of function `AbstractNonP` is like `metadata#Collection(Service1.Models.Address)`. Client failes to materialize the payloads.\r\n\r\n {\r\n\t\t \"@odata.context\":\"http://localhost:13689/odata/$metadata#Collection(Service1.Models.Address)\",\"value\":[\r\n\t\t {\r\n\t\t \"AnyP\":null,\"Street\":\"Zero Way\"\r\n\t\t },{\r\n\t\t \"AnyP\":null,\"Street\":\"One Way\"\r\n\t\t },{\r\n\t\t \"AnyP\":null,\"Street\":\"Two Way\"\r\n\t\t },{\r\n\t\t \"AnyP\":null,\"Street\":\"Three Way\"\r\n\t\t }\r\n\t\t ]\r\n\t\t}",
"title": "OData Client failes to materialize a collection of dervied complex type into a collection of base complex type.",
"type": "issue"
},
{
"action": "closed",
"author": "LaylaLiu",
"comment_id": null,
"datetime": 1458030888000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "LaylaLiu",
"comment_id": 196718566,
"datetime": 1458030888000,
"masked_author": "username_0",
"text": "Fixed by commit 883f5a687bdabbf1d86f7c67c29359fa4bc82c3f",
"title": null,
"type": "comment"
}
] | 1 | 3 | 1,810 | false | false | 1,810 | false |
automicus/PyISY | automicus | 203,984,458 | 26 | null | [
{
"action": "opened",
"author": "Nuramori",
"comment_id": null,
"datetime": 1485775485000,
"masked_author": "username_0",
"text": "When trying to start an instance, I get the following:\r\n\r\n isy = PyISY.ISY(ADDR, PORT, USER, PASS)\r\n File \"/usr/local/lib/python2.7/dist-packages/PyISY/ISY.py\", line 84, in __init __\r\n self.nodes = Nodes(self, xml=self.conn.getNodes())\r\n File \"/usr/local/lib/python2.7/dist-packages/PyISY/Nodes/__init__.py\", line 73 , in __init__\r\n self.parse(xml)\r\n File \"/usr/local/lib/python2.7/dist-packages/PyISY/Nodes/__init__.py\", line 21 1, in parse\r\n if 'uom' in nprop[0].attributes:\r\n File \"/usr/lib/python2.7/xml/dom/minidom.py\", line 522, in __getitem__\r\n return self._attrs[attname_or_tuple]\r\nKeyError: 0",
"title": "Error initializing.",
"type": "issue"
},
{
"action": "closed",
"author": "shbatm",
"comment_id": null,
"datetime": 1599570542000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 842 | false | false | 842 | false |
tangrams/eraser-map | tangrams | 108,761,901 | 41 | null | [
{
"action": "opened",
"author": "sensescape",
"comment_id": null,
"datetime": 1443480463000,
"masked_author": "username_0",
"text": "<img width=\"626\" alt=\"screen shot 2015-09-28 at 3 46 01 pm\" src=\"https://cloud.githubusercontent.com/assets/466585/10151020/3e644e42-65f8-11e5-97ca-67047e701ac4.png\">\r\n![Uploading Screen Shot 2015-09-28 at 3.46.11 PM.png…]()",
"title": "z5 city labels are sparse",
"type": "issue"
},
{
"action": "created",
"author": "nvkelso",
"comment_id": 144550942,
"datetime": 1443649429000,
"masked_author": "username_1",
"text": "This looks better in Skin and Bones, let's rebase against that.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nvkelso",
"comment_id": null,
"datetime": 1444800614000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "nvkelso",
"comment_id": 147939121,
"datetime": 1444800614000,
"masked_author": "username_1",
"text": "This was rebased.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 304 | false | false | 304 | false |
bndr/pipreqs | null | 71,485,268 | 7 | {
"number": 7,
"repo": "pipreqs",
"user_login": "bndr"
} | [
{
"action": "opened",
"author": "cclauss",
"comment_id": null,
"datetime": 1430199362000,
"masked_author": "username_0",
"text": "str.partition() has nice advantages over str.split():\r\n\r\n```python\r\nto_append = item if \".\" not in item else item.split(\".\")[0]\r\n# is equivalent to...\r\nto_append = item.partition(\".\")[0]\r\n```\r\n\r\nAlso tightened up generate_requirements_file() to send all data in a single write() operation",
"title": "str.partition() simplifies the logic, thighten up write()",
"type": "issue"
}
] | 2 | 2 | 570 | false | true | 288 | false |
inklabs/kommerce-core | inklabs | 94,402,071 | 5 | null | [
{
"action": "opened",
"author": "pdt256",
"comment_id": null,
"datetime": 1436565578000,
"masked_author": "username_0",
"text": "At the present time, Services are are returning View objects. Originally this was desired in order to not expose Entities that had the ability to change state or produce database queries through lazy loaded proxies.\r\n\r\n**[Service\\Product::find()](https://github.com/inklabs/kommerce-core/blob/0dd4836a50b71c4c9bf99b6a27436a5b55623f82/src/Service/Product.php#L59)**\r\n```php\r\n public function find($id)\r\n {\r\n $product = $this->productRepository->find($id);\r\n if ($product === null) {\r\n return null;\r\n }\r\n return $product->getView()\r\n ->withAllData($this->pricing)\r\n ->export();\r\n }\r\n```\r\n\r\nThis results in tests that are much more difficult to manage in case of null objects. This extra test gets duplicated throughout the codebase.\r\n\r\n**[test\\Service\\ProductTest::testFindMissing()](https://github.com/inklabs/kommerce-core/blob/0dd4836a50b71c4c9bf99b6a27436a5b55623f82/tests/Service/ProductTest.php#L65)**\r\n```php\r\n public function testFind()\r\n {\r\n $product = $this->productService->find(1);\r\n $this->assertTrue($product instanceof View\\Product);\r\n }\r\n public function testFindMissing()\r\n {\r\n $this->productRepository->setReturnValue(null);\r\n $product = $this->productService->find(1);\r\n $this->assertSame(null, $product);\r\n }\r\n```\r\n\r\n---\r\n\r\nReturning just the Entity will clean up the tests and make for a simpler Service Layer.\r\n\r\n**Service\\Product::find():**\r\n```php\r\n public function find($id)\r\n {\r\n return $this->productRepository->find($id);\r\n }\r\n```\r\n\r\n**test\\Service\\ProductTest::testFind()**\r\n```php\r\n public function testFind()\r\n {\r\n $product = $this->productService->find(1);\r\n $this->assertTrue($product instanceof Entity\\Product);\r\n }\r\n```",
"title": "Services should return Entities, not Views",
"type": "issue"
},
{
"action": "created",
"author": "pdt256",
"comment_id": 120539299,
"datetime": 1436565941000,
"masked_author": "username_0",
"text": "In addition, we remove the dependency on Lib\\Pricing in the Services.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "pdt256",
"comment_id": null,
"datetime": 1437450165000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 1,883 | false | false | 1,883 | false |
IQSS/dataverse | IQSS | 37,478,906 | 639 | null | [
{
"action": "opened",
"author": "eaquigley",
"comment_id": null,
"datetime": 1404920396000,
"masked_author": "username_0",
"text": "---\n\n\nAuthor Name: **Kevin Condon** (@username_1)\nOriginal Redmine Issue: 4086, https://redmine.hmdc.harvard.edu/issues/4086\nOriginal Date: 2014-06-06\nOriginal Assignee: Gustavo Durand\n\n---\n\n\r\nThis was requested by a dv admin, Janina:\r\n\r\nAllow a user to download all files from a dataverse at once, see RT#179817\r\n\r\ndo you know if there is a way to download all of the files in our Dataverse at once?",
"title": "File Download: Allow user to download all files from a dataverse at once.",
"type": "issue"
},
{
"action": "created",
"author": "kcondon",
"comment_id": 94515954,
"datetime": 1429550878000,
"masked_author": "username_1",
"text": "Under the Download button, the UI currently says, All files from this dataset, but it is grayed out. \r\nA user was asking whether this was broken, see RT #196683, also Liz added a ticket to allow selecting all files at once for download: #1988",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raprasad",
"comment_id": 125275158,
"datetime": 1438017067000,
"masked_author": "username_2",
"text": "Based on # of files + sizes, can there be a quick estimate of whether:\r\n- This can be done fairly fast (in seconds) for that user\r\n- Goes into a queue\r\n - User sees message saying to expect an email + dv notification for when the download is ready.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sbarbosadataverse",
"comment_id": 197536269,
"datetime": 1458160419000,
"masked_author": "username_3",
"text": "@scolapasta \r\nThis was requested by Harvard GSD just today and had to be passed to Kevin.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kcondon",
"comment_id": 217917690,
"datetime": 1462811841000,
"masked_author": "username_1",
"text": "Will bring up at GIRT to see whether it is realistic to pursue this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "donsizemore",
"comment_id": 292267286,
"datetime": 1491503580000,
"masked_author": "username_4",
"text": "Feature request (which might better belong in a separate issue?):\r\n\r\nThu-Mai often needs to download all files from a dataset in their original format. I'm looking into scripting this through the Native and Data Access APIs, but a GUI option for archivists would be extremely helpful.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pdurbin",
"comment_id": 292290954,
"datetime": 1491507572000,
"masked_author": "username_5",
"text": "@username_4 yeah, a separate issue might be nice. What you and Thu-Main want is actually a smaller \"user story\" since it's limited to a single dataset. This issue is about a whole dataverse, which might contain sub-dataverses (which might contain sub-dataverses).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pdurbin",
"comment_id": 301594959,
"datetime": 1494880117000,
"masked_author": "username_5",
"text": "@username_4 this issue came up today. Weren't you saying in IRC that you cooked up a script? Want us to take a look? 😄",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pdurbin",
"comment_id": 301596153,
"datetime": 1494880376000,
"masked_author": "username_5",
"text": "\"all mine does is download all files in a given dataset in original format writing out the original filename, but it could be smartly rewritten and extended\" -- @username_4 at http://irclog.iq.harvard.edu/dataverse/2017-04-07#i_51359",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pdurbin",
"comment_id": 426857456,
"datetime": 1538617178000,
"masked_author": "username_5",
"text": "When we tried to estimate #4529 about downloading all file based on a persistent ID (DOI or Handle) we decided against implementing that feature due to concerns over performance problems: https://github.com/IQSS/dataverse/issues/4529#issuecomment-385772705\r\n\r\nThis issue represents even more load on the server so by the same logic we wouldn't implement this either.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "djbrooke",
"comment_id": null,
"datetime": 1565965127000,
"masked_author": "username_6",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "djbrooke",
"comment_id": 522025460,
"datetime": 1565965127000,
"masked_author": "username_6",
"text": "I'm going to close this for now. For the performance concerns, we could possibly revisit after implementing Lambda functions (#6093) that would take zipping datasets off the application server, or if we decide to pre-zip and store content in support of #6085. We'd need to take non-S3 installations into consideration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mankoff",
"comment_id": 638525614,
"datetime": 1591229649000,
"masked_author": "username_7",
"text": "Hello. I'm interested in this feature (and commented recently on a related issue). I have a question after reading this thread: \r\n\r\nWhy is zipping required? \r\n\r\nBased on my (limited, ancient) webserver admin experience, if the dataset is exposed as a folder, the individual files could be downloaded with wget. Compression can happen on-the-fly (and only by certain filetype?) by the webserver (e.g. Apache), or no compression at all, and the Dataverse does not need to bulk-zip everything before the download begins.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pdurbin",
"comment_id": 639114748,
"datetime": 1591304563000,
"masked_author": "username_5",
"text": "@username_7 I appreciate your out of the box thinking! Thanks for commenting on #4529 and #6505 as well! Let's move the conversation to one of those issues since they're still open. Alternatively, you're welcome to open a dedicated issue about this idea.",
"title": null,
"type": "comment"
}
] | 8 | 14 | 3,399 | false | false | 3,399 | true |
jgthms/bulma | null | 145,354,489 | 159 | null | [
{
"action": "opened",
"author": "danieliancu",
"comment_id": null,
"datetime": 1459588779000,
"masked_author": "username_0",
"text": "https://jsfiddle.net/7ovL7odh/",
"title": "icon does not scale with input size",
"type": "issue"
},
{
"action": "closed",
"author": "jgthms",
"comment_id": null,
"datetime": 1459597926000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jgthms",
"comment_id": 204700246,
"datetime": 1459597926000,
"masked_author": "username_1",
"text": "You need to use a `<span class=\"icon\">` container.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "danieliancu",
"comment_id": 204806090,
"datetime": 1459631841000,
"masked_author": "username_0",
"text": "Still not working as expected https://jsfiddle.net/7ovL7odh/2/",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "jgthms",
"comment_id": null,
"datetime": 1459674988000,
"masked_author": "username_1",
"text": "https://jsfiddle.net/7ovL7odh/1/",
"title": "icon does not scale with input size",
"type": "issue"
},
{
"action": "created",
"author": "jgthms",
"comment_id": 204923199,
"datetime": 1459674988000,
"masked_author": "username_1",
"text": "Ah yeah, I haven't pushed that fix yet.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jgthms",
"comment_id": 208010998,
"datetime": 1460305739000,
"masked_author": "username_1",
"text": "Should be fixed",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jgthms",
"comment_id": null,
"datetime": 1460305739000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "danieliancu",
"comment_id": 208017996,
"datetime": 1460308105000,
"masked_author": "username_0",
"text": "Still not working with the latest version `0.0.18`.\r\nhttps://jsfiddle.net/7ovL7odh/6/",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "jgthms",
"comment_id": null,
"datetime": 1460317852000,
"masked_author": "username_1",
"text": "https://jsfiddle.net/7ovL7odh/1/",
"title": "icon does not scale with input size",
"type": "issue"
},
{
"action": "created",
"author": "jgthms",
"comment_id": 208050965,
"datetime": 1460317852000,
"masked_author": "username_1",
"text": "Ah I'm stupid. I fixed something else... Ok, I'll fix that for `0.0.19`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "danieliancu",
"comment_id": 208064957,
"datetime": 1460320861000,
"masked_author": "username_0",
"text": "@username_1 No problem.\r\n\r\nYou're doing an awesome job with Bulma!\r\nFeels like a breath of fresh air!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jgthms",
"comment_id": null,
"datetime": 1462346941000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jgthms",
"comment_id": 216765862,
"datetime": 1462346941000,
"masked_author": "username_1",
"text": "This if fixed I believe? http://bulma.io/documentation/elements/form/",
"title": null,
"type": "comment"
}
] | 2 | 14 | 582 | false | false | 582 | true |
mikepenz/MaterialDrawer | null | 233,565,896 | 1,888 | null | [
{
"action": "opened",
"author": "fgagneten",
"comment_id": null,
"datetime": 1496663629000,
"masked_author": "username_0",
"text": "I want to get the identifier of the current user.\r\nI have:\r\n\r\n .withOnAccountHeaderListener(new AccountHeader.OnAccountHeaderListener() {\r\n @Override\r\n public boolean onProfileChanged(View view, IProfile profile, boolean current) {\r\n if (profile instanceof IDrawerItem && profile.getIdentifier() == R.id.logout) {\r\n //\r\n // Here I want to get the identifier of the current user logged in\r\n //\r\n }\r\n return false;\r\n }\r\n })\r\n .build();\r\n\r\nWhen the user click logout I want to get the current user identifier so I can remove it from my storage.\r\nThanks a lot!",
"title": "Get current user identifier onProfileChanged",
"type": "issue"
},
{
"action": "created",
"author": "mikepenz",
"comment_id": 306176464,
"datetime": 1496665992000,
"masked_author": "username_1",
"text": "@username_0 simply keep track of the profileChange events. You can easily store the current user somewhere in a variable on your side. the new current user would already be changed at the time when the event is fired",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mikepenz",
"comment_id": null,
"datetime": 1496692520000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mikepenz",
"comment_id": 306285976,
"datetime": 1496692521000,
"masked_author": "username_1",
"text": "```java\r\n.withOnAccountHeaderListener(new AccountHeader.OnAccountHeaderListener() {\r\n long previousSelectedIdentifier = -1L;\r\n @Override\r\n public boolean onProfileChanged(View view, IProfile profile, boolean current) {\r\n if (profile instanceof IDrawerItem && profile.getIdentifier() == R.id.logout) {\r\n //\r\n // Here I want to get the identifier of the current user logged in\r\n //\r\n } else {\r\n previousSelectedIdentifier = profile.getIdentifier();\r\n }\r\n return false;\r\n }\r\n })\r\n```\r\n\r\nsomething like that would already work. you have to anyways also set the initial profile so this should also fire the listener and set the previous identifier",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,991 | false | false | 1,991 | true |
julienXX/terminal-notifier | null | 229,242,616 | 216 | null | [
{
"action": "opened",
"author": "nhooyr",
"comment_id": null,
"datetime": 1494999337000,
"masked_author": "username_0",
"text": "# Please check everything that applies to your issue:\r\n- [x] I looked in closed issues and it has not already been answered\r\n- [ ] My issue appeared with a terminal-notifier update\r\n- [ ] I'm using a tool that uses terminal-notifier (guard-notifier, node-notifier...)\r\n\r\n# To help us debug your issue please include:\r\n- the macOS version you use macOS 10.12.5\r\n- terminal-notifier version 1.8\r\n- how did you install terminal-notifier (binary download, homebrew, ruby gem...)? homebrew\r\n- step-by-step reproduction instructions\r\n\r\n```\r\n$ terminal-notifier -sender com.apple.Terminal -message foobar\r\n```\r\n\r\nThe notification will not popup on the side of the screen, but if you swipe to the Notification Center, you will see it.\r\n\r\nIf you add the `-activate` flag, you will see the notification:\r\n```\r\n$ terminal-notifier -sender com.apple.Terminal -activate com.apple.Terminal -message foobar\r\n```",
"title": "notification does not show if -sender com.apple.Terminal",
"type": "issue"
},
{
"action": "created",
"author": "julienXX",
"comment_id": 302075554,
"datetime": 1495024365000,
"masked_author": "username_1",
"text": "Thanks for the repport, I'll investigate.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "julienXX",
"comment_id": 307624386,
"datetime": 1497181973000,
"masked_author": "username_1",
"text": "What's weird is that if you use Safari or Finder for sender the notification shows up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "luckman212",
"comment_id": 341706550,
"datetime": 1509716563000,
"masked_author": "username_2",
"text": "I have the exact same issue, except with \"Preview.app\" (bundle ID=`com.apple.Preview`)\r\n\r\nThis is w/ version 2.0.0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "franciscolourenco",
"comment_id": 379567308,
"datetime": 1523208684000,
"masked_author": "username_3",
"text": "I have the same, but only when attached to tmux with `-sender com.googlecode.iterm2`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeynotjoe",
"comment_id": 389291478,
"datetime": 1526413803000,
"masked_author": "username_4",
"text": "I am having a very similar issue. I'm attempting to call terminal-notifier as a subprocess in a lua script, it shows up in the sidebar, but doesn't pop up on the screen.\tIf I run the same code in terminal, it _does_ pop up on the screen (and show up in the sidebar, of course). I'm on terminal-notifier 2.0.0, macOS 10.13.4.\r\n\r\n```\r\nterminal-notifier -title iina -subtitle subtitle_contents -message message_contents -sender com.colliderli.iina\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nhooyr",
"comment_id": 410126616,
"datetime": 1533263816000,
"masked_author": "username_0",
"text": "I can't reproduce this anymore. I get the notification now. On latest macOS stable.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nhooyr",
"comment_id": 410134441,
"datetime": 1533267149000,
"masked_author": "username_0",
"text": "Ah it only shows up if you aren't focused on the terminal. E.g. if you run `sleep 2; terminal-notifier ...` and focus safari for example in between, the notification will arrive.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "julienXX",
"comment_id": null,
"datetime": 1533284271000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "nthapaliya",
"comment_id": 616864111,
"datetime": 1587425473000,
"masked_author": "username_5",
"text": "This is still an issue. When the -sender is the same as the active window, the notification goes to the sidebar but doesn't pop up on screen.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "julienXX",
"comment_id": 636945959,
"datetime": 1591027430000,
"masked_author": "username_1",
"text": "I'm afraid I can't fix that, I don't see anything in the Apple API that would allow me to do that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Feuermurmel",
"comment_id": 975591701,
"datetime": 1637591735000,
"masked_author": "username_6",
"text": "This totally makes sense. I see two options (non-exclusive):\r\n\r\n- Add this to section _Caveats_ in the readme.\r\n- Print a warning to the console if this case can easily be detected. (would have saved me some time because I tested in Terminal.app with different bundle IDs and noticed that _only_ com.apple.Terminal wasn't working…)\r\n\r\nOtherwise totally great software, thanks! <3",
"title": null,
"type": "comment"
}
] | 7 | 12 | 2,550 | false | false | 2,550 | false |
vapor/fluent | vapor | 232,687,020 | 267 | null | [
{
"action": "opened",
"author": "LoganWright",
"comment_id": null,
"datetime": 1496262722000,
"masked_author": "username_0",
"text": "A use case here w/ tech empower benchmarks or other read-only databases:\r\n\r\nhttps://github.com/username_2/FrameworkBenchmarks/tree/vapor-2/frameworks/Swift/vapor\r\n\r\nNeed a way to opt out of metadata table, see `Database+Preparation.swift`",
"title": "A way to opt-out of metadata for existing dbs w/o write permissions",
"type": "issue"
},
{
"action": "created",
"author": "tanner0101",
"comment_id": 305803602,
"datetime": 1496413498000,
"masked_author": "username_1",
"text": "I'll look into this soon so that we can make it into the Techempower benchmark",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kimdv",
"comment_id": 306430827,
"datetime": 1496740997000,
"masked_author": "username_2",
"text": "Poke to me when it is done, so I can continue on the benchmark 💯",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tanner0101",
"comment_id": null,
"datetime": 1496761182000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tanner0101",
"comment_id": 306514763,
"datetime": 1496761386000,
"masked_author": "username_1",
"text": "@username_2 this was fixed in https://github.com/vapor/fluent-provider/releases/tag/1.1.0. Setting the `migrationEntityName` to `null` in the `fluent.json` file (as it appears you already have) should cause the preparations to be skipped. Let me know if you need any additional help.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kimdv",
"comment_id": 306765137,
"datetime": 1496834266000,
"masked_author": "username_2",
"text": "@username_1 \r\n\r\nIt seems that Fluent still tries to create a table called `Fluent`?\r\n\r\n```\r\nSetup vapor: Production mode enabled, disabling informational logs.\r\nSetup vapor: fatal error: Error raised at top level: MySQL Error: CREATE command denied to user 'benchmarkdbuser'@'localhost' for table 'fluent'\r\nSetup vapor: \r\nSetup vapor: Identifier: MySQL.MySQLError.1142 (tableaccessDeniedError)\r\nSetup vapor: \r\nSetup vapor: Vapor's documentation talks about this: \r\nSetup vapor: - https://dev.mysql.com/doc/refman/5.7/en/error-messages-client.html\r\nSetup vapor: - https://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html: file /home/buildnode/disk2/workspace/oss-swift-3.1-package-linux-ubuntu-14_04/swift/stdlib/public/core/ErrorType.swift, line 188\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tanner0101",
"comment_id": 307395125,
"datetime": 1497016477000,
"masked_author": "username_1",
"text": "@username_2 are you sure you have Fluent Provider 1.1.0? \r\n\r\nIn the tests I've run the following query:\r\n\r\n```swift\r\n let tables = try drop.assertDatabase().raw(\"SELECT * FROM sqlite_master WHERE type='table';\")\r\n print(tables)\r\n```\r\n\r\nAnd it returned an empty set. No tables created. \r\n\r\nMaybe try explicitly setting the entity name to null on the config object before passing it to the droplet?\r\n\r\n```swift\r\ntry config.set(\"fluent.migrationEntityName\", Node.null)\r\n```",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,896 | false | false | 1,896 | true |
yscoder/hexo-theme-indigo | null | 165,485,431 | 56 | null | [
{
"action": "opened",
"author": "AllenChow",
"comment_id": null,
"datetime": 1468477661000,
"masked_author": "username_0",
"text": "tags文件夹的md已经加了type的\r\n\r\ntype: \"tags\"\r\n\r\n我已经加了一个标签，但是tag生成的页面没有任何标签，是空白的页面，求大神解答",
"title": "标签页面空白",
"type": "issue"
},
{
"action": "created",
"author": "yscoder",
"comment_id": 232586381,
"datetime": 1468481633000,
"masked_author": "username_1",
"text": "看看 `package.json` 中的版本号， 0.4.x 开始，标签页的配置做了更改，改为 `layout: tags`。\r\n\r\n[更新日志](https://github.com/username_1/hexo-theme-indigo/wiki/%E6%9B%B4%E6%96%B0%E6%97%A5%E5%BF%97#041)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xuby0615",
"comment_id": 232612644,
"datetime": 1468488064000,
"masked_author": "username_2",
"text": "2| var posts = [];\r\n 3| page.posts.each(function(post){\r\n 4| posts.push(post);\r\nCannot read property 'each' of undefined`\r\n这个错误，要怎么解决？？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AllenChow",
"comment_id": 232623559,
"datetime": 1468491000000,
"masked_author": "username_0",
"text": "加了可以了。不过还有个问题，不知道为什么标签页面的标题下面会有时间显示，我看你的博客都是直接显示标题和子标题的。这个是我的标签站点。http://www.coderchow.com/tags/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yscoder",
"comment_id": 232695096,
"datetime": 1468509193000,
"masked_author": "username_1",
"text": "添加 `noDate: true`，没有日期时就显示子标题了。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AllenChow",
"comment_id": 232713686,
"datetime": 1468512774000,
"masked_author": "username_0",
"text": "可以了，万分感谢🙏",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "AllenChow",
"comment_id": null,
"datetime": 1468512774000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "yzytmac",
"comment_id": 467327863,
"datetime": 1551166263000,
"masked_author": "username_3",
"text": "牛逼,谢谢了,我也是换了layout:tags才解决",
"title": null,
"type": "comment"
}
] | 4 | 8 | 562 | false | false | 562 | true |
azavea/pwd-waterworks-revealed | azavea | 105,406,476 | 154 | {
"number": 154,
"repo": "pwd-waterworks-revealed",
"user_login": "azavea"
} | [
{
"action": "opened",
"author": "lliss",
"comment_id": null,
"datetime": 1441726219000,
"masked_author": "username_0",
"text": "When a playing video has ended, we should move to the next card in the deck.\r\nThis is done by wiring a slideLeft event to trigger on the video end event.\r\n\r\nConnects #150 \r\n\r\nTo test:\r\n * Visit the zone that has the video.\r\n * Allow video to play through.\r\n * Ensure the next slide reveals when the video stops.",
"title": "When video ends move to next card.",
"type": "issue"
},
{
"action": "created",
"author": "caseypt",
"comment_id": 138611186,
"datetime": 1441728107000,
"masked_author": "username_1",
"text": "+1. Tested. Found a bug where if you let the video play through, then reenter the zone and try to play the video again it doesn't work. It's happening on `master`, so it's not a result of these changes. I'll open an issue unless you have a hunch as to how to solve it here.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lliss",
"comment_id": 138692320,
"datetime": 1441744701000,
"masked_author": "username_0",
"text": "@username_1 Chrome or Firefox?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caseypt",
"comment_id": 138692636,
"datetime": 1441744768000,
"masked_author": "username_1",
"text": "Chrome.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 618 | false | false | 618 | true |
GoogleCloudPlatform/google-cloud-python | GoogleCloudPlatform | 210,258,713 | 3,070 | null | [
{
"action": "opened",
"author": "supertom",
"comment_id": null,
"datetime": 1488053625000,
"masked_author": "username_0",
"text": "Hi Folks,\r\n\r\nI don't see that the credentials I pass into the Spanner Client are being used for the [InstanceAdminClient](https://github.com/GoogleCloudPlatform/google-cloud-python/blob/f4cb0eeea38606e90c86391e559526d9bffbd4b0/spanner/google/cloud/spanner/client.py#L156) or [DatabaseAdminClient](https://github.com/GoogleCloudPlatform/google-cloud-python/blob/f4cb0eeea38606e90c86391e559526d9bffbd4b0/spanner/google/cloud/spanner/client.py#L166) instantiations. I'm chasing a downstream bug and will fill in details soon, but from what I see, defaultcredentials are assumed to be used when using those APIs, whereas it should use the provided credentials object.\r\n\r\n1. OS type and version\r\nCentOS\r\n2. Python version and virtual environment information `python --version`\r\nPython 2.7.9\r\n3. google-cloud-python version `pip show google-cloud`, `pip show google-<service>` or `pip freeze`\r\n\r\n```\r\ngapic-google-cloud-spanner-admin-database-v1==0.15.0\r\ngapic-google-cloud-spanner-admin-instance-v1==0.15.0\r\ngapic-google-cloud-spanner-v1==0.15.0\r\ngoogle-auth==0.8.0\r\ngoogle-auth-httplib2==0.0.2\r\ngoogle-cloud-core==0.23.1\r\ngoogle-cloud-spanner==0.23.1\r\ngoogle-compute-engine==2.3.2\r\ngoogle-gax==0.15.6\r\ngoogleapis-common-protos==1.5.2\r\ngrpc-google-iam-v1==0.11.1\r\ngrpcio==1.1.3\r\n```\r\n4. Stacktrace if available\r\n5. Steps to reproduce\r\n* Create credentials with a service account. Make sure default credentials will fail.\r\n* Try to interact with an instance.\r\n\r\n6. Code example\r\n```\r\nimport google.auth.credentials\r\nfrom google.cloud import spanner\r\nfrom google.oauth2 import service_account\r\nSPANNER_ADMIN_SCOPE = 'https://www.googleapis.com/auth/spanner.admin'\r\nJSON_KEY='/home/me/keys/demo-ansible.json'\r\n\r\ncredentials = service_account.Credentials.from_service_account_file(\r\n JSON_KEY)\r\nscopes = [ SPANNER_ADMIN_SCOPE ]\r\ncredentials = credentials.with_scopes(scopes)\r\n# credentials = google.auth.credentials.with_scopes_if_required(credentials, scopes)\r\nsc = spanner.Client(project='my-project, credentials=credentials)\r\n\r\ni = sc.instance('my-instance', configuration_name='regionally-us-central1')\r\nI.exists()\r\n```\r\n\r\nI checked these sites before filing:\r\n- https://github.com/GoogleCloudPlatform/google-cloud-python/issues\r\n- http://stackoverflow.com/questions/tagged/google-cloud-python",
"title": "[Spanner] credentials object not passed into InstanceAdminAPI",
"type": "issue"
},
{
"action": "created",
"author": "lukesneeringer",
"comment_id": 283147046,
"datetime": 1488312405000,
"masked_author": "username_1",
"text": "Thanks for raising this issue. It looks like a bug; we will look into it soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tseaver",
"comment_id": 297133607,
"datetime": 1493147220000,
"masked_author": "username_2",
"text": "On this now.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tseaver",
"comment_id": null,
"datetime": 1493149630000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 2,395 | false | false | 2,395 | false |
deepchem/deepchem | deepchem | 289,326,294 | 1,025 | null | [
{
"action": "opened",
"author": "Dgelemi",
"comment_id": null,
"datetime": 1516206111000,
"masked_author": "username_0",
"text": "Not an issue, but a paper on using graph as molecule descriptor and some model comparison:\r\nAdaptive Graph Convolutional Neural Networks, https://arxiv.org/pdf/1801.03226.pdf , code is not public",
"title": "Another graph input approach",
"type": "issue"
},
{
"action": "created",
"author": "lilleswing",
"comment_id": 358386887,
"datetime": 1516211561000,
"masked_author": "username_1",
"text": "1. The comparison is not to moleculenet GraphConv despite citing our paper. Instead it is to \r\n```bash\r\n[Bruna et al. 2013] Bruna, J.; Zaremba, W.; Szlam, A.; and\r\nLeCun, Y. 2013. Spectral networks and locally connected\r\nnetworks on graphs. arXiv preprint arXiv:1312.6203.\r\n```\r\n\r\n\r\n\r\n\r\n2. I have already implemented A version of adaptive Laplacian Graph Transformations here\r\nhttps://github.com/deepchem/deepchem/blob/master/deepchem/models/tensorgraph/models/graph_models.py#L500\r\nhttps://arxiv.org/abs/1703.00792\r\nIt might be a good starting place for someone wanting to implement the method described in this paper.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dgelemi",
"comment_id": 359892757,
"datetime": 1516733696000,
"masked_author": "username_0",
"text": "thanks for the info 👍",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Dgelemi",
"comment_id": null,
"datetime": 1516733696000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 1,088 | false | false | 1,088 | false |
python-visualization/folium | python-visualization | 277,507,296 | 781 | null | [
{
"action": "opened",
"author": "Alcampopiano",
"comment_id": null,
"datetime": 1511896978000,
"masked_author": "username_0",
"text": "Hi guys,\r\n\r\nHopefully an easy one. I'm making a few changes to the html once the map is saved to a file. Is there a way to access the html directly, without using m.save()?",
"title": "access the map's html, without saving the file",
"type": "issue"
},
{
"action": "created",
"author": "Conengmo",
"comment_id": 347660835,
"datetime": 1511902587000,
"masked_author": "username_1",
"text": "I was wondering this myself as well. I think I found out how, by following the parent classes from `Map` to `LegacyMap` and then `MacroElement` and `Element` in Branca. That last one has the `save()` method you want to imitate.\r\nYou can call `get_root()` on the `Map` object and get the `Figure` object that is created in the initialization of `Map`. On that you can call `render()` to create the complete html:\r\n`m = folium.Map()`\r\n`html_string = m.get_root().render()`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Alcampopiano",
"comment_id": 347885442,
"datetime": 1511967453000,
"masked_author": "username_0",
"text": "Hi Frank. Thanks for digging into this. What I am trying to do is to be able to make changes to the map's HTML, but still display it so that it will show up in the notebook when it's exported as HTML.\r\n\r\nWhen I use iPython like so,\r\n`display(HTML('<iframe src=' + myMap.html + ' width=100% height=1000></iframe>'))`\r\n\r\nThe resulting map is not fully embedded/portable in the HTML notebook (it can't be sent to colleagues). \r\n\r\nSo basically, is there a way to be able to make changes to the map's HTML, but still have it fully embedded in the notebook when it's exported as HTML? \r\n\r\nSincerely,\r\nAl",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Alcampopiano",
"comment_id": 347927763,
"datetime": 1511975131000,
"masked_author": "username_0",
"text": "@username_2 That will display the map with base64 encoding, which is great, but I am trying to make adjustments (\"hacks\") to the HTML string first, and then have it get rendered with base64 encoding.\r\n\r\nSo for example, as @username_1 suggested, if I wanted to force a heat map to stay on top of a choropleth, I could append some HTML to the main HTML that Folium creates, as follows:\r\n\r\n`html_data=html_data + '<style>.leaflet-heatmap-layer{z-index:300 !important}</style>'`\r\n\r\nThe question now is how to display this new map, with base64 encoding, so that the map is nice and portable.\r\n\r\nI've tried converting my altered HTML to base64, prior to displaying it by using,\r\n```\r\nimport base64\r\nb64 = base64.b64encode(html_data.encode())\r\n```\r\nBut that just shows a blank page. \r\nAny ideas?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Conengmo",
"comment_id": 348157497,
"datetime": 1512040136000,
"masked_author": "username_1",
"text": "I tested two ways to do this with this example map:\r\n\r\n```import folium\r\nm = folium.Map(location=[45.372, -121.6972], zoom_start=12, tiles='Stamen Terrain')\r\nfolium.Marker(location=[45.3288, -121.6625], popup='Mt. Hood Meadows').add_to(m)\r\nLayerControl(collapsed=False).add_to(m)\r\nm.save('_map.html') \r\n```\r\n\r\nA dirty way to do it is to replicate the `_render_html_()` method in wrapper class. That way you can do anything with the output of `m.get_root().render()` before putting it in an iframe with a `_render_html_()` function.\r\n\r\n```import base64\r\nclass MapWrapper:\r\n def __init__(self, m):\r\n self.html = m.get_root().render()\r\n \r\n def add_html(self, html_string):\r\n self.html += html_string\r\n\r\n def _repr_html_(self):\r\n # Copied from folium.element.Figure\r\n html = \"data:text/html;charset=utf-8;base64,\" + base64.b64encode(self.html.encode('utf8')).decode('utf8')\r\n iframe = (\r\n '<div style=\"width:100%;\">'\r\n '<div style=\"position:relative;width:100%;height:0;padding-bottom:60%;\">'\r\n '<iframe src=\"{html}\" style=\"position:absolute;width:100%;height:100%;left:0;top:0;'\r\n 'border:none !important;\" '\r\n 'allowfullscreen webkitallowfullscreen mozallowfullscreen>'\r\n '</iframe>'\r\n '</div></div>').format\r\n return iframe(html=html)\r\n \r\nmapper = MapWrapper(m)\r\nmapper.add_html(('<style>.leaflet-popup-content{color:#FF0000 !important}'\r\n '.leaflet-control{color:#00FF00}</style>'))\r\nmapper\r\n```\r\n\r\nA probably better way is to make a class that inherits from Branca's `MacroElement` class. You can add this to a map object. Maybe this is something to add to Branca/Folium?\r\n\r\n```import branca.element\r\nimport jinja2\r\nclass Styling(branca.element.MacroElement):\r\n def __init__(self, style):\r\n super(Styling, self).__init__()\r\n self._name = 'styling'\r\n self.style_statements = style\r\n self._template = jinja2.Template(\"\"\"\r\n {% macro header(this, kwargs) %}\r\n <style>{{ this.style_statements }}</style>\r\n {% endmacro %}\r\n \"\"\")\r\n\r\nStyling(('.leaflet-popup-content-wrapper{color:#FF0000 !important}'\r\n '.leaflet-control{color:#00FF00}')).add_to(m)\r\nm\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Conengmo",
"comment_id": 348174560,
"datetime": 1512044914000,
"masked_author": "username_1",
"text": "I found a much easier way in #370: \r\n```\r\nstyle_statement = '<style>.leaflet-control{color:#00FF00}</style>'\r\nm.get_root().html.add_child(folium.Element(style_statement))\r\nm\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fitoprincipe",
"comment_id": 348214722,
"datetime": 1512054299000,
"masked_author": "username_2",
"text": "I am following along, shouldn't style go in head tag? like\r\n\r\n``` python\r\nstyle_statement = '<style>.leaflet-control{color:#00FF00}</style>'\r\nm.get_root().header.add_child(folium.Element(style_statement))\r\nm\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Alcampopiano",
"comment_id": 348234284,
"datetime": 1512057913000,
"masked_author": "username_0",
"text": "@username_1 Frank this is fantastic!\r\n\r\nThe \"dirty\" way you described allows me to do everything I need. Specifically I am hacking two things:\r\n\r\n1) Force a heat map to be on top of a choropleth via:\r\n`<style>.leaflet-heatmap-layer{z-index:300 !important}</style>`\r\n\r\n2) Force the layer control checkboxes for my heatmaps to be unchecked by default. To do this I use some regular expression to remove the \".add_to(map)\" that occurs when the heatmap is created. This keeps the checkbox unchecked when the map is loaded:\r\n\r\n``` \r\nhtml_string = re.sub(r\"gradient.*\\s*}\\).*\\s*.*;\", 'gradient: {\"0.1\": \"white\", \"0.5\": \"black\", \"1\": \"white\"}})', html_string)\r\n```\r\n\r\nI realise that this is heavy handed, but it works. Importantly, when exporting the notebook as HTML, the maps still need to be working when I send the file to someone else. Thanks to your help, this seems to be working consistently in Firefox with maps that are ~3MB in size. In Chrome, the maps only show up if they are very basic (like the test example above). I'm sure there is an explanation for that though, which I will investigate. \r\n\r\nI am using Folium maps to analyze how census data relates to specific schools. I think that is important work, and you have helped to make it possible. \r\n\r\nThanks again,\r\nAllan",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Conengmo",
"comment_id": 348444454,
"datetime": 1512120079000,
"masked_author": "username_1",
"text": "Glad to help Allen. By the way, your second point is something I encountered as well. I made a PR for it (#772) so maybe we'll see it in a next version.\r\n\r\n@username_2 you're right, it should be in header. Thanks for the learning.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Alcampopiano",
"comment_id": null,
"datetime": 1512134294000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ocefpaf",
"comment_id": 349592926,
"datetime": 1512554814000,
"masked_author": "username_3",
"text": "```\r\nstyle_statement = '<style>.leaflet-control{color:#00FF00}</style>'\r\nm.get_root().html.add_child(folium.Element(style_statement))\r\nm\r\n```\r\n\r\nMaybe we should document that somewhere...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nomadcreator",
"comment_id": 380699754,
"datetime": 1523516517000,
"masked_author": "username_4",
"text": "Maybe I am asking a quite preliminary question, but how can I show this on a website, such as Django? \r\n\"m\" won't show anything when I do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Conengmo",
"comment_id": 380711301,
"datetime": 1523519428000,
"masked_author": "username_1",
"text": "You mean the entire map? If you render the `Figure` object above your `Map` object you get the full html page. Like this:\r\n\r\n```\r\nm = folium.Map()\r\nhtml_string = m.get_root().render()\r\n```\r\n\r\nI once made Flask app that just returns the html, I believe it was something like this.\r\n```\r\nflask.render_template_string(html_string)\r\n```\r\n\r\nAlternatively, you can try the `_repr_html_()` method that is used to display maps in Jupyter Notebooks. It outputs html that contains the map in an iframe, so you'd have to include it in your own template. I haven't tried this before.\r\n```\r\nm = folium.Map()\r\nhtml_string = m._repr_html_()\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nomadcreator",
"comment_id": 380714152,
"datetime": 1523520091000,
"masked_author": "username_4",
"text": "Thank you. Will try Jupyter Notebooks one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GrazingScientist",
"comment_id": 400930688,
"datetime": 1530168534000,
"masked_author": "username_5",
"text": "html_string = m.get_root().render()\r\n\r\nThis did the trick for me, returning the HTML as string. Awesome!",
"title": null,
"type": "comment"
}
] | 6 | 15 | 7,288 | false | false | 7,288 | true |
t4t5/react-native-router | null | 97,240,549 | 51 | null | [
{
"action": "opened",
"author": "RWOverdijk",
"comment_id": null,
"datetime": 1437844873000,
"masked_author": "username_0",
"text": "I've been playing around with this module a bit and so far it works really well. There's one thing that's bothering me though.. That's the name property. It looks like it's up to the initiator of the view to decide what the name of the view should be. For instance, on line 45 of HomePage.js in the twitter example:\r\n\r\n```javascript\r\n{\r\n goToTweet: function(tweetData) {\r\n this.props.toRoute({\r\n name: \"Tweet\",\r\n component: TweetPage,\r\n data: tweetData\r\n });\r\n }\r\n}\r\n```\r\n\r\nThe name is being defined there. What if the app has several places that initiate this? Would I have to add this all over the place? Can it be defined from within the page view itself, too?",
"title": "Defining the name of a page",
"type": "issue"
},
{
"action": "created",
"author": "allenhartwig",
"comment_id": 131143641,
"datetime": 1439565354000,
"masked_author": "username_1",
"text": "You could accomplish this like so:\r\n```js\r\n{\r\n goToTweet: function(tweetData) {\r\n var TweetPage = require('./pages/tweet')';\r\n this.props.toRoute({\r\n name: TweetPage.title,\r\n component: TweetPage.component,\r\n data: tweetData\r\n });\r\n }\r\n}\r\n```\r\nwith pages/tweet.js exporting:\r\n```js\r\nmodule.exports = {\r\n title: 'Tweet',\r\n component: myTweetComponent\r\n};\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "allenhartwig",
"comment_id": 131168280,
"datetime": 1439569541000,
"masked_author": "username_1",
"text": "Alternatively this works as well:\r\n```js\r\n{\r\n goToTweet: function(tweetData) {\r\n var TweetPage = require('./pages/tweet')';\r\n this.props.toRoute({\r\n name: TweetPage.displayName,\r\n component: TweetPage,\r\n data: tweetData\r\n });\r\n }\r\n}\r\n```\r\n\r\nJust ensure you have the displayName property defined to your desired title on within your `React.createClass`.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "RWOverdijk",
"comment_id": null,
"datetime": 1439792724000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 131693248,
"datetime": 1439792724000,
"masked_author": "username_0",
"text": "Satisfying enough. Thanks.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,478 | false | false | 1,478 | false |
HaliteChallenge/Halite | HaliteChallenge | 206,849,258 | 400 | {
"number": 400,
"repo": "Halite",
"user_login": "HaliteChallenge"
} | [
{
"action": "opened",
"author": "Janzert",
"comment_id": null,
"datetime": 1486745923000,
"masked_author": "username_0",
"text": "Add setting to stop game tasks being handed out.\r\nAdd setting to change to uniform seeding for the finals.",
"title": "Changes to manager task api for finals.",
"type": "issue"
},
{
"action": "created",
"author": "truell20",
"comment_id": 279290960,
"datetime": 1486959301000,
"masked_author": "username_1",
"text": "Kinda unneeded. We can kill the workers (after checking that no compiles are going on), then make the change.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 215 | false | false | 215 | false |
stealjs/steal-tools | stealjs | 140,401,401 | 401 | {
"number": 401,
"repo": "steal-tools",
"user_login": "stealjs"
} | [
{
"action": "opened",
"author": "m-mujica",
"comment_id": null,
"datetime": 1457803712000,
"masked_author": "username_0",
"text": "Closes #273.\r\n\r\nA nicer diff here https://github.com/stealjs/steal-tools/commit/27ddedd1de371b6774f0644de4385ba94c026f6c (can't help myself with the indentation)",
"title": "Add export to the cli.",
"type": "issue"
},
{
"action": "created",
"author": "m-mujica",
"comment_id": 198350281,
"datetime": 1458306939000,
"masked_author": "username_0",
"text": "is this what you had in mind @username_1? anything you'd add?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "matthewp",
"comment_id": 199249928,
"datetime": 1458563064000,
"masked_author": "username_1",
"text": "Looks good, thanks.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 239 | false | false | 239 | true |
bcit-ci/CodeIgniter | bcit-ci | 116,151,476 | 4,230 | null | [
{
"action": "opened",
"author": "exbit",
"comment_id": null,
"datetime": 1447174871000,
"masked_author": "username_0",
"text": "CodeIgniter develop last\r\n\r\nA PHP Error was encountered\r\nSeverity: 4096\r\nMessage: session_regenerate_id(): Failed to create session ID: user (path: tcp://127.0.0.1:6379)\r\nFilename: Session/Session.php\r\nLine Number: 625",
"title": "Redis + PHP7 session_regenerate_id()",
"type": "issue"
},
{
"action": "created",
"author": "andersonunsonst",
"comment_id": 155489661,
"datetime": 1447175362000,
"masked_author": "username_1",
"text": "https://bugs.php.net/bug.php?id=70871",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "exbit",
"comment_id": 155492153,
"datetime": 1447175665000,
"masked_author": "username_0",
"text": "Thank you",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "narfbg",
"comment_id": 155511873,
"datetime": 1447177749000,
"masked_author": "username_2",
"text": "Are you manually calling `session_regenerate_id()`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "exbit",
"comment_id": 155513079,
"datetime": 1447178027000,
"masked_author": "username_0",
"text": "no",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "narfbg",
"comment_id": 155521620,
"datetime": 1447179740000,
"masked_author": "username_2",
"text": "I hope that it's not a simple connection issue (i.e. something prevents CI from connecting to Redis), because I've left a comment on the PHP bug linked above.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "narfbg",
"comment_id": 156980655,
"datetime": 1447669447000,
"masked_author": "username_2",
"text": "Neither is a CI bug, so I'm closing this issue here.\r\n\r\nhttps://github.com/php/php-src/commit/a03786f7730e99e86113b826087e2271a2b001fc makes the failure causes more obvious, so that should help ... I don't see it mentioned in the PHP7RC5 changelog, but it is commited 2 days earlier, so it should be in there.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "narfbg",
"comment_id": null,
"datetime": 1447669447000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 8 | 784 | false | false | 784 | false |
kubernetes-client/java | kubernetes-client | 279,575,333 | 136 | null | [
{
"action": "opened",
"author": "TWood67",
"comment_id": null,
"datetime": 1512518424000,
"masked_author": "username_0",
"text": "Hi all, \r\n\r\nI'm working on a project that has this as a maven dependency. I recently found a bug which was fixed in https://github.com/kubernetes-client/java/commit/ae400e7a45c5988437ac902dcfeb0b97cb2f408c. Do you plan on pushing an updated package soon? It would be greatly appreciated!\r\n\r\nThank you!",
"title": "Maven Package with Latest",
"type": "issue"
},
{
"action": "created",
"author": "brendandburns",
"comment_id": 351607150,
"datetime": 1513226478000,
"masked_author": "username_1",
"text": "cc @lwander master of all things maven...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brendandburns",
"comment_id": 351607398,
"datetime": 1513226611000,
"masked_author": "username_1",
"text": "Duplicate of https://github.com/kubernetes-client/java/issues/138",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "brendandburns",
"comment_id": null,
"datetime": 1513226612000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 407 | false | false | 407 | false |
Crystalnix/termius-cli | Crystalnix | 244,589,242 | 77 | null | [
{
"action": "opened",
"author": "ART-008",
"comment_id": null,
"datetime": 1500622977000,
"masked_author": "username_0",
"text": "\"remote_instance\" is useless for users.",
"title": "Command \"termius tags\".",
"type": "issue"
},
{
"action": "closed",
"author": "Maxbey",
"comment_id": null,
"datetime": 1505124066000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 39 | false | false | 39 | false |
AccelerateHS/accelerate | AccelerateHS | 780,377 | 10 | null | [
{
"action": "opened",
"author": "mchakravarty",
"comment_id": null,
"datetime": 1303045881000,
"masked_author": "username_0",
"text": "",
"title": "Comprehensive support for standard Haskell classes and numeric conversions",
"type": "issue"
},
{
"action": "closed",
"author": "tmcdonell",
"comment_id": null,
"datetime": 1461510436000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
SeleniumHQ/selenium | SeleniumHQ | 202,421,307 | 3,396 | null | [
{
"action": "opened",
"author": "IgorJorobus",
"comment_id": null,
"datetime": 1485129208000,
"masked_author": "username_0",
"text": "Hi guys.\r\n\r\nProblem\r\n=====\r\n\r\n```ruby\r\nrequire 'selenium-webdriver'\r\nprofile = Selenium::WebDriver::Chrome::Profile.new('C:/Users/X/AppData/Local/Google/Chrome/User Data')\r\nwebdriver = Selenium::WebDriver.for(:chrome, profile: profile)\r\n```\r\n\r\n Previous code fails in last line with next error message and backtrace:\r\n\r\nC:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1392:in 'initialize': Permission denied @ rb_sysopen - C:/Users/Rubygor/AppData/Local/Google/Chrome/User Data/Default/Cache/data_0 (Errno::EACCES)\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1392:in 'open'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1392:in 'copy_file'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1360:in 'copy'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:472:in 'block in copy_entry'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1498:in 'wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1501:in 'block in wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'each'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1501:in 'block in wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'each'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1501:in 'block in wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'each'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1500:in 'wrap_traverse'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:469:in 'copy_entry'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:444:in 'block in cp_r'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1571:in 'block in fu_each_src_dest'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1587:in 'fu_each_src_dest0'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:1569:in 'fu_each_src_dest'\r\n\tfrom C:/Ruby23/lib/ruby/2.3.0/fileutils.rb:443:in 'cp_r'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/common/profile_helper.rb:50:in 'create_tmp_copy'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/chrome/profile.rb:67:in 'layout_on_disk'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/chrome/profile.rb:82:in 'as_json'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/chrome/bridge.rb:81:in 'create_capabilities'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/chrome/bridge.rb:40:in 'initialize'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/common/driver.rb:61:in 'new'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/common/driver.rb:61:in 'for'\r\n\tfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver.rb:82:in 'for'\r\n\r\n I have tried to run the script with admin privileges, it neither work. I'm not sure if my Chrome version has something to do with the problem, but just in case, the version installed on my PC is \"55.0.2883.87 m\". I want to use the default profile, with extensions enabled, sadly I can't achieve this due to the error shown above. I'll be looking forward for some feedback. Thanks, regards.\r\n___\r\n\r\nSystem\r\n=====\r\nOS: Windows 7 Proffesional x64\r\nProgramming Language: Ruby 2.3.1p112\r\nSelenium Version: 3.0.5\r\nBrowser: Chrome\r\nChromeDriver Version: 2.25.426923",
"title": "[Ruby] Errno::EACCES when trying to use a Chrome default profile",
"type": "issue"
},
{
"action": "closed",
"author": "AutomatedTester",
"comment_id": null,
"datetime": 1485599505000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "AutomatedTester",
"comment_id": 275840504,
"datetime": 1485599505000,
"masked_author": "username_1",
"text": "This is a question rather than an issue. Please send questions to the [selenium user group](https://groups.google.com/forum/#!forum/selenium-users)\r\n\r\n*or*\r\n\r\nPlease log chromedriver issues with the chromedriver project.\r\n\r\nhttps://sites.google.com/a/chromium.org/chromedriver/help\r\n\r\nPlease be sure to include a completely reproducible test script for them, without a way to reproduce the issue you are seeing there is no good way for them to fix the problem. A reproducible test script includes a WebDriver script and a link to the page in question. If you can not provide a link, create one using [jsfiddle.net](https://jsfiddle.net)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "IgorJorobus",
"comment_id": 275898322,
"datetime": 1485674089000,
"masked_author": "username_0",
"text": "It doesn't look like a question to me, failure is exactly here:\r\n\r\nfrom C:/Ruby23/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.0.5/lib/selenium/webdriver/common/profile_helper.rb:50:in 'create_tmp_copy'\r\n\r\n Selenium is trying to copy a file that apparently is in use, even if I have no Chrome instance running. I guess this has to be with chromedriver according to your point of view. By the way, all the code you need to reproduce the problem is there, that 3 lines, you need to replace the argument passed to Selenium::WebDriver::Chrome::Profile.new() for the corresponding according to your Chrome installation. In the meantime I'll try to make a fork of the project and see if there's another way to by-pass that copy causing conflict.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 4,812 | false | false | 4,812 | false |
grpc/grpc | grpc | 184,743,247 | 8,473 | {
"number": 8473,
"repo": "grpc",
"user_login": "grpc"
} | [
{
"action": "opened",
"author": "jspiro",
"comment_id": null,
"datetime": 1477280878000,
"masked_author": "username_0",
"text": "",
"title": "V1.0.0 dotdashpay changes",
"type": "issue"
},
{
"action": "created",
"author": "jspiro",
"comment_id": 255642425,
"datetime": 1477280921000,
"masked_author": "username_0",
"text": "This was supposed to be a private pull request.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 999 | false | true | 47 | false |
krystofspl/relplay-client | null | 225,526,702 | 1 | null | [
{
"action": "opened",
"author": "krystofspl",
"comment_id": null,
"datetime": 1493672651000,
"masked_author": "username_0",
"text": "At any time, if the main playlist contains a track more than once, when we select the track (by doubleclicking on it, clicking \"next song\" button or just listening to the playlist), the first occurence gets selected, so the playlist cycles through the songs between the occurences instead of keeping its position.\r\n\r\n**Cause**\r\nThis is caused by the way how a song is selected in the vuex store. There is no position indicator, we just look for the appropriate ID.\r\n\r\n**Fix proposal**\r\nChange the vuex actions and other code so that the position in the playlist is taken into account instead of just the song ID.\r\n\r\n**Issues**\r\nUnfortunately, this functionality has influence on many functions, so any changes need to be thoroughly tested and reviewed. I was stupid not to think of this when I designed the interface and will try to fix it ASAP.",
"title": "Playlist - when a song is present more than once, the playlist selects the first occurence",
"type": "issue"
}
] | 1 | 1 | 845 | false | false | 845 | false |
IBM-Bluemix/ibm-cloud-developer-tools | IBM-Bluemix | 260,451,890 | 19 | null | [
{
"action": "opened",
"author": "rvennam",
"comment_id": null,
"datetime": 1506384589000,
"masked_author": "username_0",
"text": "",
"title": "Unable to install in ubuntu container",
"type": "issue"
},
{
"action": "created",
"author": "kfbishop",
"comment_id": 332049702,
"datetime": 1506385174000,
"masked_author": "username_1",
"text": "@username_0 - Thanks for this. I tested the new logic yesterday on 17.04, ok.\r\n\r\nCan you please paste output of:\r\n```\r\n$ uname -v\r\n#21-Ubuntu SMP Thu Apr 6 17:04:57 UTC 2017\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rvennam",
"comment_id": 332051155,
"datetime": 1506385851000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kfbishop",
"comment_id": 332168693,
"datetime": 1506425186000,
"masked_author": "username_1",
"text": "Default ubuntu docker image is missing several critical packages, and will require non-trivial work to to get installer to run. I talked with Ram and his was ore exploratory than a defined need to have this work. I'll reinvestigate the value prop another time.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "steveclay",
"comment_id": 426750826,
"datetime": 1538592070000,
"masked_author": "username_2",
"text": "There's been no activity since the final comment over a year ago. Closing.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "steveclay",
"comment_id": null,
"datetime": 1538592071000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 513 | false | false | 513 | true |
18F/omb-eregs | 18F | 259,251,499 | 481 | null | [
{
"action": "opened",
"author": "krues8dr",
"comment_id": null,
"datetime": 1505930601000,
"masked_author": "username_0",
"text": "",
"title": "Cleanup search interface",
"type": "issue"
},
{
"action": "created",
"author": "carodew",
"comment_id": 330958447,
"datetime": 1505936317000,
"masked_author": "username_1",
"text": "some of this is related to #448",
"title": null,
"type": "comment"
}
] | 2 | 2 | 31 | false | false | 31 | false |
processing/p5.js-website | processing | 309,085,611 | 179 | {
"number": 179,
"repo": "p5.js-website",
"user_login": "processing"
} | [
{
"action": "opened",
"author": "sheamusburns",
"comment_id": null,
"datetime": 1522175803000,
"masked_author": "username_0",
"text": "Successfully works on most endpoints 👍 \r\n<img width=\"495\" alt=\"p5_js___get_started\" src=\"https://user-images.githubusercontent.com/8462408/37987272-b7cffb22-31cb-11e8-9d02-d3cf369710fa.png\">\r\n\r\nBug: Still doesn't work on the /reference endpoint. I tried digging around to see if I could figure out how that page gets assembled, but no luck. If you can give me a sense of the structure, I can go in and add the `<link>` in the proper places.\r\n\r\n<img width=\"448\" alt=\"p5_js___reference\" src=\"https://user-images.githubusercontent.com/8462408/37987416-220edbe8-31cc-11e8-94c6-a0dc3b48cc7e.png\">",
"title": "add asterisk favicon",
"type": "issue"
},
{
"action": "created",
"author": "awarua",
"comment_id": 381366305,
"datetime": 1523746244000,
"masked_author": "username_1",
"text": "@username_0 - I believe that the reference endpoint is not generated within the project, but comes from the following static html file: `/dist/reference/index.html`. So, if you add your lines to link to the favicon in there, it should show up (you'll have to put the path to the file directly).\r\n\r\n```\r\n<link rel=\"shortcut icon\" href=\"/assets/img/favicon.ico\">\r\n<link rel=\"icon\" href=\"/assets/img/favicon.ico\">\r\n```\r\n\r\n**However**, this might not be a good long-term solution. @username_2 commented on another issue #38 that the reference page is generated from the following template in the main p5.js repository https://github.com/processing/p5.js/blob/master/docs/yuidoc-p5-theme/layouts/main.handlebars\r\n\r\nSo I guess when that gets updated, any changes you make to the static reference index.html page will be lost? \r\n\r\nI'm still not very familiar with the project & don't know the history of how the reference ended as a static file. I think it has to do with the challenges of translating from the source code generated documentation. There's some discussion of that in the [README](https://github.com/processing/p5.js-website/blob/master/README.md) under the 'JSON (reference)' section.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "awarua",
"comment_id": 381373724,
"datetime": 1523756438000,
"masked_author": "username_1",
"text": "@username_0 - I have been trying more to understand how this works, and I think the right place to make the change to add the favicon to the reference pages is to the [main.handlebars](https://github.com/processing/p5.js/blob/master/docs/yuidoc-p5-theme/layouts/main.handlebars) file in the p5.js repository.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sheamusburns",
"comment_id": 381644679,
"datetime": 1523892332000,
"masked_author": "username_0",
"text": "@username_1 Thanks Jared, \r\nThat's super helpful; I was confused by that JSON reference section and didn't think to look in the P5js project for that src. You're definitely right about the main.handlebars file -- once there it was a simple fix. \r\n\r\n[PR #2786 in Processing/p5.js](https://github.com/processing/p5.js/pull/2786) should resolve the issue where the favicon doesn't load with the on the reference site.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmccart",
"comment_id": 385294324,
"datetime": 1525048116000,
"masked_author": "username_2",
"text": "thanks!",
"title": null,
"type": "comment"
}
] | 3 | 5 | 2,511 | false | false | 2,511 | true |
trilinos/ForTrilinos | trilinos | 277,141,337 | 112 | {
"number": 112,
"repo": "ForTrilinos",
"user_login": "trilinos"
} | [
{
"action": "opened",
"author": "tjfulle",
"comment_id": null,
"datetime": 1511811364000,
"masked_author": "username_0",
"text": "@username_1, get in touch with me when you are back about this PR. I imagine it'll take an 30 or so minutes from us to walk through it. There are many `TODO`s that need to get done on the swig side of things.",
"title": "WIP: TpetraMultiVector, TpetraCrsMatrix tests; Updated testing macros",
"type": "issue"
},
{
"action": "created",
"author": "aprokop",
"comment_id": 347719566,
"datetime": 1511918106000,
"masked_author": "username_1",
"text": "@username_0 Can you also please separate this PR into three different ones: one with Fortran macros update + Map changes, one with MultiVector, and one with CrsMatrix? This way, I can push my related changes to corresponding branches and merge independently.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tjfulle",
"comment_id": 347772434,
"datetime": 1511939384000,
"masked_author": "username_0",
"text": "@username_1, I've got a good solution that gets by the line length limitations and, in fact, is more general purpose. I'll test and push tomorrow morning.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tjfulle",
"comment_id": 347919952,
"datetime": 1511973662000,
"masked_author": "username_0",
"text": "This PR will be split up in to separate PRs for the Macros/Maps, CrsMatrix, and MultiVector portions",
"title": null,
"type": "comment"
}
] | 3 | 5 | 714 | false | true | 714 | true |
inuyaksa/jquery.nicescroll | null | 266,269,970 | 715 | null | [
{
"action": "opened",
"author": "kardoqadir",
"comment_id": null,
"datetime": 1508272628000,
"masked_author": "username_0",
"text": "I tried to sue lazy load on my page with nice scroll. But it created problem which is when the the images want to load the page dosen't create scroll with it. \r\nI used Lazysizes jQuery plugin\r\nhttps://github.com/aFarkas/lazysizes",
"title": "Problem with lazy load",
"type": "issue"
}
] | 1 | 1 | 229 | false | false | 229 | false |
heroku/heroku-buildpack-nodejs | heroku | 56,082,830 | 190 | null | [
{
"action": "opened",
"author": "kevinburkeshyp",
"comment_id": null,
"datetime": 1422650908000,
"masked_author": "username_0",
"text": "Our deploys are currently pretty slow (90 seconds to 3+ minutes) and I was wondering what I could do to speed it up. It would be useful if the buildpack echoed timing information for each step, so that it would be easy to compare across builds (instead of watching the console output and doing rough estimates in your head).",
"title": "Add timing information",
"type": "issue"
},
{
"action": "created",
"author": "hunterloftis",
"comment_id": 72272908,
"datetime": 1422653143000,
"masked_author": "username_1",
"text": ":+1: I love this idea - it's something we've talked about doing lower in the build system (so all output would be timestamped). Until then, I think it'd be great to do it in the node buildpack.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kevinburkeshyp",
"comment_id": 72279302,
"datetime": 1422655891000,
"masked_author": "username_0",
"text": "sweet. how do you imagine this looking? happy to help out, but if you're\r\ngonna do it go for it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hunterloftis",
"comment_id": 72283559,
"datetime": 1422657810000,
"masked_author": "username_1",
"text": "Great question... I was thinking probably a function to pipe all output through (kind of like `indent` right now). That way we could change all output lines with minimal code changes, just a new pipe at the end.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hunterloftis",
"comment_id": 72283575,
"datetime": 1422657820000,
"masked_author": "username_1",
"text": "PRs happily accepted ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kevinburkeshyp",
"comment_id": 72605057,
"datetime": 1422947600000,
"masked_author": "username_0",
"text": "That would give absolute timestamps, might be nice to have relative timestamps (this is how long this build step took) but that requires storing state. Maybe absolute is a good first pass",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hunterloftis",
"comment_id": 72964555,
"datetime": 1423093186000,
"masked_author": "username_1",
"text": "Yeah I think absolute is a good v1, although the function could certainly manage a delta as well if you wanted. (UTC timestamp +5s) or something.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "anonrig",
"comment_id": 213163511,
"datetime": 1461282850000,
"masked_author": "username_2",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edmorley",
"comment_id": 430176472,
"datetime": 1539683726000,
"masked_author": "username_3",
"text": "I have created a buildpack that prefixes each line of the build logs with timestamps, and adds an overall duration to the end of each buildpack's compile step - if it's of any use?\r\nhttps://github.com/username_3/heroku-buildpack-timestamps\r\n\r\nWe're been using it in production for 6 months now and it's helped us track down the slow parts of our multi-buildpack builds.",
"title": null,
"type": "comment"
}
] | 4 | 9 | 1,548 | false | false | 1,548 | true |
rapid7/metasploit-framework | rapid7 | 232,183,114 | 8,483 | null | [
{
"action": "opened",
"author": "Ug0Security",
"comment_id": null,
"datetime": 1496134241000,
"masked_author": "username_0",
"text": "Little issue this morning while trying the new \"is_known_pipename\"\r\n\r\nIt seems that i've (it) broke the payload selection system\r\n\r\n\r\n\r\n\r\n\r\n\r\nAs you can see proposed payloads are wrong (ms08-067 is obviously for windows and same problem is_known_pipename )\r\n\r\nI've try to update the framework, reboot the vm nothing seems to get this of this.\r\n\r\nKali 2.0 with msf fully updated i guess.",
"title": "broken payload selection system",
"type": "issue"
},
{
"action": "created",
"author": "busterb",
"comment_id": 304857618,
"datetime": 1496145897000,
"masked_author": "username_1",
"text": "Kali 2.0? Please update to Kali Rolling 2017.01 or later. Kali 2.0 has been dead for a long time.\r\n\r\nAlso, Kali Rolling do not appear to ship this exploit yet, so I'd advise just waiting until Kali packages the latest Metasploit framework release. I double-checked and cannot reproduce this issue with latest Kali or omnibus nightly package. Sounds like you might have a bit of a Frankenstein locally?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ug0Security",
"comment_id": 304860772,
"datetime": 1496146782000,
"masked_author": "username_0",
"text": "sorry for my mistake, i work on a Kali Linux 64 bit VBox 2016.2 \r\nSo msf is preinstalled and i've updated it.\r\n\r\ni've added the exploit manually from exploit-db this morning , i also tried some previous version of the exploit yesterday (copied from github) . Yesterday everthing was fine, now i've add the exploit from exploit-db the system seems to be broken\r\n\r\nFor some reason the payloads suggestion changed to another packs which are still incorrect (of course as the system seems broken on my install)\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "busterb",
"comment_id": 304862627,
"datetime": 1496147271000,
"masked_author": "username_1",
"text": "the latest version of the exploit needs a lot of library changes from metasploit to work. You can't just drop it in without carefully extracting all of the extra pieces too, which is definitely going to invalidate the warranty :). I'd recommend waiting or grabbing the latest omnibus package.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "busterb",
"comment_id": null,
"datetime": 1496147271000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "busterb",
"comment_id": 304862943,
"datetime": 1496147367000,
"masked_author": "username_1",
"text": "Also, the exploit from exploit-db trails what's in Framework by quite a bit. We can't support grabbing stuff from there after it's already in the tree.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ug0Security",
"comment_id": 304865244,
"datetime": 1496147937000,
"masked_author": "username_0",
"text": "Ok, i guess i'll go to 2017.1 meanwhile :)\r\nand i understand for the support of course.\r\n\r\nJust to share i manage to reproduce the issue on Kali Linux 32 bit VBox PAE 2016.2 but whatever, thx for fast answer",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "busterb",
"comment_id": 304871355,
"datetime": 1496149415000,
"masked_author": "username_1",
"text": "If you can give some steps I can reproduce, can certainly reopen and take a look at it. I have an up-to-date 2017.1 box with v4.14.21-dev ready to go.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ug0Security",
"comment_id": 304879574,
"datetime": 1496151255000,
"masked_author": "username_0",
"text": "Here the steps i've made this morning\r\n\r\n1- add exploit from exploit-db (https://www.exploit-db.com/exploits/42084/)\r\n2- reload_all metasploit\r\n3- use exploit/yourpath/is_known_pipename\r\n4- set payload 'TAB TAB' \r\n5- use exploit/windows/smb/ms08-067_netapi \r\n6- set payload 'TAB TAB'\r\n\r\nHere the proof on two vm with both Arch x86 and x64\r\n\r\n\r\n\r\n\r\n\r\nit seems to me that i've reproduce the issue on 2017.1 without installing new exploit just reproduce steps 3 to 6 (Solaris Exploit - Windows Payload ?)\r\n\r\n\r\n\r\nIs this the normal behaviour ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ug0Security",
"comment_id": 304882688,
"datetime": 1496151901000,
"masked_author": "username_0",
"text": "Same issue on Armitage, same steps 3 to 6 the to first are useless.\r\n\r\nIt seems that once you selected an exploit and autocomplete the payload\r\nThe next exploit you'll choose will have same payloads.\r\n\r\nTell me if you more info and if you managed to reproduce",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "busterb",
"comment_id": 305571509,
"datetime": 1496339926000,
"masked_author": "username_1",
"text": "Ah, interesting. This doesn't have anything to do with downloading from exploitdb, it seems the payload values get cached between module switches, so it shows the wrong set on the second exploit module every time.",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "busterb",
"comment_id": null,
"datetime": 1496339927000,
"masked_author": "username_1",
"text": "Little issue this morning while trying the new \"is_known_pipename\"\r\n\r\nIt seems that i've (it) broke the payload selection system\r\n\r\n\r\n\r\n\r\n\r\n\r\nAs you can see proposed payloads are wrong (ms08-067 is obviously for windows and same problem is_known_pipename )\r\n\r\nI've try to update the framework, reboot the vm nothing seems to get rid of this.\r\n\r\nKali 2.0 with msf fully updated i guess.",
"title": "broken payload selection system",
"type": "issue"
},
{
"action": "created",
"author": "shawndeckerr",
"comment_id": 307007032,
"datetime": 1496901664000,
"masked_author": "username_2",
"text": "Noticed the same issue when dealing with exploit/windows/smb/ms17_010_eternalblue as well. \r\nAfter using the eternalblue exploit, I used exploit/windows/smb/psexec but at this point, 'set payload <TAB><TAB>' (autocomplete) will only display windows/x64/ payloads. \r\nHowever, 'show payloads' will show genuinely available payloads so you could workaround with that in the interim.\r\nI'm using newly installed Kali 2017.1 with updates installed 3 days ago. Metasploit Framework version is 4.14.22-dev.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "busterb",
"comment_id": null,
"datetime": 1507239690000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 14 | 4,903 | false | false | 4,903 | false |
scipy/scipy | scipy | 74,998,151 | 4,850 | null | [
{
"action": "opened",
"author": "rgommers",
"comment_id": null,
"datetime": 1431290376000,
"masked_author": "username_0",
"text": "Use ``tools/win32/detect_cpu_extensions_wine.py``. This has gone wrong in the past, and this will be the first time in forever that we use modified BLAS/LAPACK binaries.",
"title": "check all Windows binaries for SSE instructions",
"type": "issue"
},
{
"action": "closed",
"author": "rgommers",
"comment_id": null,
"datetime": 1432389802000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "rgommers",
"comment_id": 104900669,
"datetime": 1432389802000,
"masked_author": "username_0",
"text": "Done, all looks good. So closing.",
"title": null,
"type": "comment"
}
] | 1 | 3 | 202 | false | false | 202 | false |
osmdroid/osmdroid | osmdroid | 196,892,321 | 500 | null | [
{
"action": "opened",
"author": "Raptorel",
"comment_id": null,
"datetime": 1482314698000,
"masked_author": "username_0",
"text": "How do I solve this?",
"title": "Importing osmdroid-master as a project",
"type": "issue"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268505321,
"datetime": 1482321372000,
"masked_author": "username_1",
"text": "You probably need to add \"Google APIs:23\". It's a separate item in the sdk manager. We only use as an bridge. I think that the number of users using it is very low",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268511466,
"datetime": 1482323386000,
"masked_author": "username_0",
"text": "I did that. It wasn't installed by default, so I installed it using the SDK Manager. It still gives the same error. In fact, I installed everything that had to do with \"Google\" in the 23 API.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268595070,
"datetime": 1482343132000,
"masked_author": "username_1",
"text": "Try to build from the command line first with gradlew...\r\nso `gradlew install`\r\n\r\nAlso check your ANDROID_HOME environment variable. Can you build any other android projects? What os are you running?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268707060,
"datetime": 1482375879000,
"masked_author": "username_1",
"text": "is the problem with android studio, intellij or gradle?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268752195,
"datetime": 1482397450000,
"masked_author": "username_0",
"text": "The problem is with Android Studio, and it's a really weird problem, if you ask me. Let me try today to play around with it a bit more and see what I can come up with.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stoanarrr",
"comment_id": 268754436,
"datetime": 1482398184000,
"masked_author": "username_2",
"text": "Hi I've had the same problem with Android Studio.\r\n\r\nChanging \r\ncompileSdkVersion 'Google Inc.:Google APIs:23'\r\nbuildToolsVersion \"23.0.3\"\r\n\r\nto\r\ncompileSdkVersion 23\r\nbuildToolsVersion '23.0.3'\r\n\r\nin the build.gradle files in [https://github.com/osmdroid/osmdroid/blob/master/osmdroid-third-party/build.gradle](url) and [https://github.com/osmdroid/osmdroid/blob/master/GoogleWrapperSample/build.gradle](url) solved the problem for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268754692,
"datetime": 1482398267000,
"masked_author": "username_0",
"text": "Good to know, I need to check if that works here as well (also thanks for pointing out the actual location of these files)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268756613,
"datetime": 1482398888000,
"masked_author": "username_0",
"text": "I have obviously installed Build Tools revision 23.0.3, and even checked on the SDK manager to see if they're installed. But the problem persists. Any ideas?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268785219,
"datetime": 1482407819000,
"masked_author": "username_1",
"text": "I bet you have two copies of the sdk installed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268793812,
"datetime": 1482411222000,
"masked_author": "username_0",
"text": "Well, even if I had 20 copies of the SDK installed, as long as Android Studio points to the right one, it should work. The project should care about the SDK that Android Studio is pointing to, and should be agnostic about anything else in my computer. \r\n\r\nBut I can't have more than one SDKs since I just installed Android Studio and the JDK with its default settings, and that's it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raptorel",
"comment_id": 268794433,
"datetime": 1482411470000,
"masked_author": "username_0",
"text": "OK so I restarted Android Studio and there are no errors now (with the modifications that username_2 talked about in his post).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268916180,
"datetime": 1482450703000,
"masked_author": "username_1",
"text": "right my point was that you could have more than one and whatever android studio/gradle local.properties is set to may not have the Google Apis . You're best off using the standalone sdk manager the \"Google APIs\" v23, the build tools 23.0.3 and i'm pretty sure you also need \"Google Play Services\". I also have the \"Android Support Repository\" and the \"Google Repository\" (both listed under \"Extras\" installed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyhunter99",
"comment_id": 268923623,
"datetime": 1482454960000,
"masked_author": "username_1",
"text": "reopen if you continue to run into troubles. i have publish permissions now so expect more frequent releases",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "spyhunter99",
"comment_id": null,
"datetime": 1482454960000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 15 | 2,584 | false | false | 2,584 | true |
tgriesser/bookshelf | null | 59,352,919 | 641 | null | [
{
"action": "opened",
"author": "aitorllj93",
"comment_id": null,
"datetime": 1425149390000,
"masked_author": "username_0",
"text": "Hi!\r\n\r\nI'm trying to create a Users-Followers Relationship with Bookshelf but I can't achieve it :(\r\n\r\nCould you ilustrate me with a simple sample?\r\n\r\n\r\nThanks for your time :)",
"title": "Users-Followers Relation Sample",
"type": "issue"
},
{
"action": "closed",
"author": "bendrucker",
"comment_id": null,
"datetime": 1425150793000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "bendrucker",
"comment_id": 76540785,
"datetime": 1425150793000,
"masked_author": "username_1",
"text": "Hey @username_0, \r\n\r\nWe tend to be pretty open about things on the issue tracker, but something as generic as a database schema is something better suited for Stack Overflow.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 350 | false | false | 350 | true |
palantir/plottable | palantir | 62,559,395 | 1,746 | {
"number": 1746,
"repo": "plottable",
"user_login": "palantir"
} | [
{
"action": "opened",
"author": "rcchen",
"comment_id": null,
"datetime": 1426642746000,
"masked_author": "username_0",
"text": "ErrorBarPot shows nice error bars. It is meant to be merged with other plots as needed.\r\n\r\n\r\n\r\nJSFiddle: http://jsfiddle.net/Ltayarx4/\r\n\r\nFixes #1379",
"title": "[ErrorBarPlot] Implement ErrorBarPlot",
"type": "issue"
},
{
"action": "created",
"author": "rcchen",
"comment_id": 83184863,
"datetime": 1426713792000,
"masked_author": "username_0",
"text": "Functional fixes. Naming change still needs to be applied. In addition, tests still need to be added. Need to think about how these tests will be structured.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bluong",
"comment_id": 83773023,
"datetime": 1426801912000,
"masked_author": "username_1",
"text": "Bias against making comments on the individual comments on the commit.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bluong",
"comment_id": 90467259,
"datetime": 1428396350000,
"masked_author": "username_1",
"text": "How are the error ticks configurable?\r\n\r\nAlso, while this looks like a solid PR, one thing to think about moving forward is that remember that we are utilizing project here only more heavily. I think this mostly looks fine currently, but please consider what happens if we were to modify project.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rcchen",
"comment_id": 90982658,
"datetime": 1428514420000,
"masked_author": "username_0",
"text": "The ticks are broadly configurable by leveraging CSS at the moment; the lower/top bars are currently initialized to a length of 20px.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bluong",
"comment_id": 91020099,
"datetime": 1428523483000,
"masked_author": "username_1",
"text": "I'm mainly curious about how to change the length of the ticks. 20px may not be the correct number. Everything looks fine I think? except this idea of having the tick length be static at 20px",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bluong",
"comment_id": 91384652,
"datetime": 1428624324000,
"masked_author": "username_1",
"text": "Just the few issues",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "crmorford",
"comment_id": 95731254,
"datetime": 1429826482000,
"masked_author": "username_2",
"text": "BUG\r\nhttp://jsfiddle.net/Ltayarx4/4/\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rcchen",
"comment_id": 96003639,
"datetime": 1429896407000,
"masked_author": "username_0",
"text": "Temporarily closing due to Post API Refactor.",
"title": null,
"type": "comment"
}
] | 3 | 9 | 1,350 | false | false | 1,350 | false |
NCIEVS/nci-protege5 | null | 176,034,686 | 24 | null | [
{
"action": "opened",
"author": "bdionne",
"comment_id": null,
"datetime": 1473434192000,
"masked_author": "username_0",
"text": "The merge panel follows the design of split/clone, with the `from` on the left and the `to` on the right.\r\n\r\nAdditionally the labels `Merge From` and `Merge To` are not as clear as the original `Retiring concept` and `Surviving Concept`",
"title": "Merge panels and labels are awkward",
"type": "issue"
},
{
"action": "closed",
"author": "rmehri",
"comment_id": null,
"datetime": 1481492186000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "rmehri",
"comment_id": 266309846,
"datetime": 1481492186000,
"masked_author": "username_1",
"text": "I have retested and validated the fix in \"tag -110\" successfully. This issue can be closed. Please attached zip file for video to play for more details. \r\nThanks,\r\nReza\r\n[Merge Panel.zip](https://github.com/NCIEVS/nci-protege5/files/644814/Merge.Panel.zip)",
"title": null,
"type": "comment"
}
] | 2 | 3 | 493 | false | false | 493 | false |
PerfectMemory/mongoid-multitenancy | PerfectMemory | 86,629,890 | 16 | null | [
{
"action": "opened",
"author": "joel",
"comment_id": null,
"datetime": 1433862227000,
"masked_author": "username_0",
"text": "Consider 2 clients `client_instance_one` and `client_instance_two` , Article have tenant with optional option for keep possibility to create Article without tenant.\r\n\r\n```\r\nclass Article\r\n include Mongoid::Document\r\n include Mongoid::Multitenancy::Document\r\n\r\n tenant(:client, optional: true)\r\n\r\n field :title, :type => String\r\nend\r\n```\r\n\r\nCreate 1 Article belong to first client like your example in the README\r\n```\r\nMongoid::Multitenancy.with_tenant(client_instance) do\r\n article = Article.new(:title => 'New article 1')\r\n article.save # => <#Article _id: 50ca04b86c82bfc125000044, title: 'New blog', client_id: nil>\r\n\r\n # tenant needs to be set manually\r\n article.tenant = client_instance_one\r\n article.save # => <#Article _id: 50ca04b86c82bfc125000044, title: 'New blog', client_id: 50ca04b86c82bfc125000025>\r\nend\r\n```\r\n\r\nWe have following expected behavior \r\n```\r\nMongoid::Multitenancy.current_tenant = client_instance_one\r\nArticle.all.map(&:title) # => ['New article 1']\r\n```\r\n\r\nCreate a new article without tenant\r\n```\r\nMongoid::Multitenancy.current_tenant = nil\r\narticle = Article.new(:title => 'New article 2')\r\narticle.save\r\nArticle.all.map(&:title) # => ['New article 1', 'New article 2']\r\n```\r\n\r\nFirst tenant list this articles\r\n```\r\nMongoid::Multitenancy.current_tenant = client_instance_one\r\nArticle.all.map(&:title) # => ['New article 1', 'New article 2']\r\n```\r\n\r\nThis is strange behavior for me, but can be ok so far. We will assign a tenant to the second article\r\n```\r\nMongoid::Multitenancy.current_tenant = client_instance_two\r\narticle.tenant = client_instance_two\r\narticle.save\r\nArticle.all.map(&:title) # => ['New article 2']\r\n```\r\nbut still visible with the scope of previous client\r\n```\r\nMongoid::Multitenancy.current_tenant = client_instance_one\r\nArticle.all.map(&:title) # => ['New article 1', 'New article 2']\r\n```\r\nThis is really what we are excepted? With this behavior it's impossible to delegate later the assignment of resource like creation of user and scoping them after for avoid patch of devise for example...",
"title": "Avoid Devise patching",
"type": "issue"
},
{
"action": "created",
"author": "joel",
"comment_id": 110402509,
"datetime": 1433863694000,
"masked_author": "username_0",
"text": "Obviously this works : \r\n\r\n``` \r\nMongoid::Multitenancy.current_tenant = client_instance_one\r\nArticle.where(client: Mongoid::Multitenancy.current_tenant).map(&:name)\r\n# => ['New article 1']\r\n``` \r\n\r\nBut we need to add a new scope outside of your gem....",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joel",
"comment_id": 110445256,
"datetime": 1433872291000,
"masked_author": "username_0",
"text": "We can add our expected behavior with the following scope : \r\n`scope :authorized, ->{ where(client: Mongoid::Multitenancy.current_tenant) }` but I think is a missing part here",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abrisse",
"comment_id": 120441259,
"datetime": 1436543196000,
"masked_author": "username_1",
"text": "@username_0 : using `optional: true`when declaring the tenant association means that the article does not necessarily belongs to a specific tenant and therefore is *shared* among all the tenants.\r\n\r\nSo when you execute:\r\n\r\n```ruby\r\nMongoid::Multitenancy.current_tenant = nil\r\narticle = Article.new(:title => 'New article 2')\r\narticle.save\r\nArticle.all.map(&:title) # => ['New article 1', 'New article 2']\r\n```\r\n\r\nArticle.all returns all the articles the current tenant has access to, ie both articles.\r\n\r\nConcerning the second part, `article.tenant = client_instance_two` cannot work since the tenant field is `client`. So it should be instead `article.client = client_instance_two. If you do that, `Article.all.map(&:title)` will only return `['New article 1']` as expected.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "abrisse",
"comment_id": null,
"datetime": 1436543235000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 3,248 | false | false | 3,248 | true |
travis-ci/apt-package-whitelist | travis-ci | 102,236,364 | 924 | null | [
{
"action": "opened",
"author": "pipermerriam",
"comment_id": null,
"datetime": 1440104524000,
"masked_author": "username_0",
"text": "Hoping to get `go-ethereum` on the whitelist.\r\n\r\nLink to documentation on apt-get installation.\r\n\r\nhttps://github.com/ethereum/go-ethereum/wiki/Installation-Instructions-for-Ubuntu",
"title": "APT whitelist request for go-ethereum",
"type": "issue"
}
] | 2 | 2 | 587 | false | true | 180 | false |
mrdoob/three.js | null | 217,588,578 | 11,077 | null | [
{
"action": "opened",
"author": "AngelTsTsvetkov",
"comment_id": null,
"datetime": 1490712968000,
"masked_author": "username_0",
"text": "When rotate some object after pan using OrbitControls.js or TrackballControls.js. The result is not expected except if object is in the middle of the screen.",
"title": "rotation after pan is not correct",
"type": "issue"
},
{
"action": "created",
"author": "WestLangley",
"comment_id": 289798848,
"datetime": 1490713296000,
"masked_author": "username_1",
"text": "`OrbitControls` and `TrackballControls` rotate and pan the _camera_ -- not the object.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AngelTsTsvetkov",
"comment_id": 289801917,
"datetime": 1490713871000,
"masked_author": "username_0",
"text": "so there is no easy way to rotate object (by standard way) after pan?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WestLangley",
"comment_id": 289811111,
"datetime": 1490715536000,
"masked_author": "username_1",
"text": "See https://threejs.org/examples/misc_controls_transform.html, for example.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "WestLangley",
"comment_id": null,
"datetime": 1490715537000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "AngelTsTsvetkov",
"comment_id": 289824994,
"datetime": 1490718190000,
"masked_author": "username_0",
"text": "in all examples, there are no simple way to rotate and move object ...",
"title": null,
"type": "comment"
}
] | 2 | 6 | 457 | false | false | 457 | false |
louischatriot/nedb | null | 242,725,039 | 520 | null | [
{
"action": "opened",
"author": "Bratkartoffl",
"comment_id": null,
"datetime": 1499956991000,
"masked_author": "username_0",
"text": "Is there a way to easily sync neDB database (large) to the cloud?",
"title": "Sync nedb to cloud (aws or azure)",
"type": "issue"
},
{
"action": "created",
"author": "JamesMGreene",
"comment_id": 322637571,
"datetime": 1502847381000,
"masked_author": "username_1",
"text": "What would be your receiving end on the cloud side?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adjustit",
"comment_id": 323909544,
"datetime": 1503372676000,
"masked_author": "username_2",
"text": "Are you wanting to sync the actual DB in its entirety and have a reference store on the cloud, or do you only need representation of the data? In the latter case, it sounds like your best bet would be have a periodical process that runs and submits via an API service that the server can interpret.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 414 | false | false | 414 | false |
appleseedhq/appleseed | appleseedhq | 241,526,750 | 1,517 | null | [
{
"action": "opened",
"author": "dictoon",
"comment_id": null,
"datetime": 1499608888000,
"masked_author": "username_0",
"text": "",
"title": "Saving project crashes if source project files have been deleted",
"type": "issue"
},
{
"action": "created",
"author": "Idloj",
"comment_id": 375952363,
"datetime": 1521964505000,
"masked_author": "username_1",
"text": "Can you detail how to reproduce it? Here's what I've done:\r\n\r\n1. Create a new project and save it under some name\r\n2. Delete the project file\r\n3. Save the project again\r\n\r\nIt didn't crash.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dictoon",
"comment_id": null,
"datetime": 1521972879000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dictoon",
"comment_id": 375959302,
"datetime": 1521972879000,
"masked_author": "username_0",
"text": "To be honest, I don't recall exactly what the problem was. I should have included detailed repro steps but I was too lazy apparently. I'll close this ticket. We can open it again or create a new ticket if/when we figure it out.\r\n\r\nThanks for looking into it!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 446 | false | false | 446 | false |
RedPRL/sml-redprl | RedPRL | 246,539,778 | 300 | null | [
{
"action": "opened",
"author": "jonsterling",
"comment_id": null,
"datetime": 1501355608000,
"masked_author": "username_0",
"text": "Lean has a cool feature where not only can you embed terms into scripts in the usual way (analogous to our `exact` tactic), but you can also start scripting in the middle of a term.\r\n\r\nFor a long time, I thought that this wouldn't be possible, but now I see a way to do it. It may be a little tricky to get it just right with respect to binding, though.\r\n\r\nAnother thing I have been considering that may make it easier to do what I am describing is to get rid of the distinction between *hypotheses qua names* and *hypotheses qua variables*. I originally thought that this was crucial, but now I think that there may be a way to use only variables here without it getting too bad.",
"title": "Support embedding scripts into terms (!)",
"type": "issue"
},
{
"action": "created",
"author": "jonsterling",
"comment_id": 318854368,
"datetime": 1501357443000,
"masked_author": "username_0",
"text": "I am envisioning a mode-of-use where you can write scripts like this:\r\n\r\n```\r\n `(lam [x] ,{let <a,b> = x. `(pair b a)})\r\n```\r\n\r\nIn the above example, the backtick means \"switch to `term` mode\", and the comma means \"switch to `tactic/refinement` mode\". These can be interleaved as much as you want.\r\n\r\nThe idea is that when proving a well-formedness judgment `M in A`, if `M` is an \"antiquoted\" tactic expression, then we will have a rule that switches to proving `A true` using that tactic. The behavior of the backtick would remain the same as it is now.\r\n\r\nThis way we can get the best of both worlds between refinement and explicit term writing. And this will also allow us to put holes in terms!\r\n\r\n(This is predicated on #301)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonsterling",
"comment_id": 318854536,
"datetime": 1501357599000,
"masked_author": "username_0",
"text": "Actually, this might not work as-designed. The issue is that we don't want these scripts to be in the realizers that are extracted. So, somehow we would have to have the membership judgments spit out extracts too, which represent the 'elaborated'/extracted form of their inputs. This is related to #208.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jonsterling",
"comment_id": null,
"datetime": 1507222606000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 4 | 1,716 | false | false | 1,716 | false |
react-toolbox/react-toolbox | react-toolbox | 164,905,807 | 632 | {
"number": 632,
"repo": "react-toolbox",
"user_login": "react-toolbox"
} | [
{
"action": "opened",
"author": "randycoulman",
"comment_id": null,
"datetime": 1468262553000,
"masked_author": "username_0",
"text": "The `cardTitle` theme for the root `CardTitle` component was not documented.\n\nI also made the wording for `title` and `subtitle` more consistent.",
"title": "Document CardTitle's cardTitle theme",
"type": "issue"
},
{
"action": "created",
"author": "javivelasco",
"comment_id": 234770786,
"datetime": 1469357808000,
"masked_author": "username_1",
"text": "Great!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 151 | false | false | 151 | false |
kuzzleio/kuzzle | kuzzleio | 198,659,472 | 608 | {
"number": 608,
"repo": "kuzzle",
"user_login": "kuzzleio"
} | [
{
"action": "opened",
"author": "stafyniaksacha",
"comment_id": null,
"datetime": 1483520707000,
"masked_author": "username_0",
"text": "## Changes related to CLI:\r\n\r\n* CLI Requests sent to Kuzzle are done now through protocol identifier `cli`\r\n* On CLI action, kuzzle fire brefore/after event (eg `cli:beforeCreateFirstAdmin`) \r\n* `adminExists` and `createFirstAdmin` CLI actions call internal actions through `funnelController` to trigger all related events",
"title": "CLI createFirstAdmin Refactor",
"type": "issue"
},
{
"action": "created",
"author": "scottinet",
"comment_id": 270369645,
"datetime": 1483536398000,
"masked_author": "username_1",
"text": "Shouldn't this be merged on `master` first as a hotfix and then backported to `develop`?",
"title": null,
"type": "comment"
}
] | 3 | 3 | 410 | false | true | 410 | false |
stephenbaidu/android-place-picker | null | 85,511,423 | 4 | null | [
{
"action": "opened",
"author": "stripathi669",
"comment_id": null,
"datetime": 1433503739000,
"masked_author": "username_0",
"text": "Sometimes while typing the text of the address, I get following error and the app crashes:\r\n\r\n ArrayIndexOutOfBoundsException (@AutocompleteTask:doInBackground:86) {AsyncTask #2}",
"title": "Array Index Out of bounds Exception",
"type": "issue"
},
{
"action": "created",
"author": "stephenbaidu",
"comment_id": 109264101,
"datetime": 1433503900000,
"masked_author": "username_1",
"text": "Okay, I will look into it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stephenbaidu",
"comment_id": 111153656,
"datetime": 1434032704000,
"masked_author": "username_1",
"text": "I cannot seem to be able to replicate the error. But I suspect it is as a result of the description not having a comma in it. Hence, below is a fix, please let me know if this works for you.\r\n\r\n```\r\ntry {\r\n // Create a JSON object hierarchy from the results\r\n JSONObject jsonObj = new JSONObject(jsonResults.toString());\r\n JSONArray predsJsonArray = jsonObj.getJSONArray(\"predictions\");\r\n\r\n // Extract the Place descriptions from the results\r\n resultList = new ArrayList<PlaceInfo>(predsJsonArray.length());\r\n for (int i = 0; i < predsJsonArray.length(); i++) {\r\n JSONObject place = predsJsonArray.getJSONObject(i);\r\n String id = place.getString(\"place_id\");\r\n String[] descriptions = place.getString(\"description\").split(\", \", 2);\r\n String name = descriptions[0];\r\n String description = (descriptions.length > 1)? descriptions[1] : \"\";\r\n\r\n resultList.add(new PlaceInfo(id, name, description));\r\n }\r\n} catch (JSONException e) {\r\n Log.e(LOG_TAG, \"Cannot process JSON results\", e);\r\n} catch (Exception e) {\r\n Log.e(LOG_TAG, \"Exception\", e);\r\n}\r\n```\r\n\r\nI also added a generic exception block to prevent the app from crashing in case of other unknown exceptions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stripathi669",
"comment_id": 111184427,
"datetime": 1434038482000,
"masked_author": "username_0",
"text": "I have done the same thing on my end.\r\n\r\nBy the way, what other features should I expect in next release on Maven ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stephenbaidu",
"comment_id": 111314780,
"datetime": 1434069376000,
"masked_author": "username_1",
"text": "Well, I do not really have much in mind. Am still thinking about the request you made #3 though. Feel free to suggest features you would like to see.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stripathi669",
"comment_id": 114554162,
"datetime": 1435074584000,
"masked_author": "username_0",
"text": "One more issue that I could see was that in the search view, the rows didn't wrap the place name if the name length was more than screen's.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "giorgiobasile",
"comment_id": 160938270,
"datetime": 1448968624000,
"masked_author": "username_2",
"text": "Hi, I'm importing your library as gradle dependency, but unfortunately you fix in the AutocompleteTask class doesn't appear (I'm talking about the generic Exception catch). Could you please fix it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stephenbaidu",
"comment_id": 165206217,
"datetime": 1450291060000,
"masked_author": "username_1",
"text": "@username_2 Have been trying to reproduce the error but could not. Just realised I have not pushed the update to jcenter. Will do that soon and sorry for the delay.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stephenbaidu",
"comment_id": 165213847,
"datetime": 1450292765000,
"masked_author": "username_1",
"text": "@username_2 Please use the new version `1.1`. Closing this issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "stephenbaidu",
"comment_id": null,
"datetime": 1450292768000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 10 | 2,269 | false | false | 2,269 | true |
raml-org/raml-js-parser-2 | raml-org | 254,745,016 | 787 | null | [
{
"action": "opened",
"author": "nescalante",
"comment_id": null,
"datetime": 1504298027000,
"masked_author": "username_0",
"text": "when doing a `require('raml-1-parser')` with webpack, its throwing:\r\n\r\n```\r\n ./node_modules/ts-structure-parser/dist/fsUtils.js\r\nModule not found: Error: Can't resolve 'fs' in '/my-lib/node_modules/ts-structure-parser/dist'\r\n @ ./node_modules/ts-structure-parser/dist/fsUtils.js 4:9-22\r\n @ ./node_modules/ts-structure-parser/dist/tsStructureParser.js\r\n @ ./node_modules/ts-structure-parser/dist/index.js\r\n @ ./node_modules/raml-definition-system/dist/tsStruct2Def.js\r\n @ ./node_modules/raml-definition-system/dist/definitionSystem.js\r\n @ ./node_modules/raml-1-parser/dist/index.js\r\n @ myCode\r\n```\r\n\r\nthats because `fs` is not browser compatible, and only available via browserify transforms\r\n\r\nyou should either provide a valid version of this parser for the browser, or if not possible as a fallback provide the bundled js file included into the npm package so it can be used without having to clone the repo and run npm tasks",
"title": "Cannot require with webpack",
"type": "issue"
},
{
"action": "created",
"author": "nescalante",
"comment_id": 326698869,
"datetime": 1504305832000,
"masked_author": "username_0",
"text": "consider https://github.com/raml-org/raml-js-parser-2/pull/788",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sichvoge",
"comment_id": 326733850,
"datetime": 1504345154000,
"masked_author": "username_1",
"text": "I don't understand why that is a problem since the parser is used in MuleSoft's API designer which runs clearly inside the browser. \r\n\r\nSo what's the problem exactly since it seems there is a version. Did you try the guide [here](https://github.com/raml-org/raml-js-parser-2#creating-standalone-browser-package)?\r\n\r\nI also think that the browser version is always attached to the release. @username_2 can you advise, please!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ddenisenko",
"comment_id": 326735475,
"datetime": 1504347542000,
"masked_author": "username_2",
"text": "Browser version for each release is attached as ZIP archive. Browser version is also available in NPM here: https://www.npmjs.com/package/raml-1-parser-browser\r\n\r\nIf you want to build the version manually, you can either run the script `generateBrowserVersion`, or, if you want to pack it as a part of your own package, add an alias for `fs` to your webpack config pointing to `web-tools/modules/emptyFS.js`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ddenisenko",
"comment_id": null,
"datetime": 1507109043000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ddenisenko",
"comment_id": 334099094,
"datetime": 1507109043000,
"masked_author": "username_2",
"text": "Closing due to the timeout. Please reopen if still actual.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nescalante",
"comment_id": 334181589,
"datetime": 1507128717000,
"masked_author": "username_0",
"text": "RAML Parser is still not working with webpack, reopen since webpack is a popular tool in the community and taking it out from RAML Parser is complicating it for developers adopting it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "agustinlg",
"comment_id": 334211629,
"datetime": 1507134258000,
"masked_author": "username_3",
"text": "Agree that it would be an improvement if this works out of the box (or at least explicitly documented)\r\n\r\nIt did work on the designer but with Denis help, I thinks this was what we needed to add:\r\n\r\n```\r\n resolve: {\r\n alias: {\r\n fs: path.resolve(projectRootPath, \"./node_modules/raml-1-parser/web-tools/modules/emptyFS.js\")\r\n }\r\n },\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nescalante",
"comment_id": 334219556,
"datetime": 1507135905000,
"masked_author": "username_0",
"text": "thats fine for me, would be good to have that documented in the readme",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ddenisenko",
"comment_id": 334507665,
"datetime": 1507218500000,
"masked_author": "username_2",
"text": "It is unclear for me how exactly you want it to work.\r\n\r\nI see two different use-cases:\r\n\r\nThe first one is when you want need browser version to import the parser directly into html.\r\nThere are the following methods to do it:\r\n\r\n1) RAML Parser packaged with webpack and having bower descriptor is attached to each parser release.\r\n\r\n2) RAML Parser packaged with webpack is published as `raml-1-parser-browser` bower package.\r\n\r\n3) RAML Parser packaged with webpack is published as NPM `raml-1-parser-browser` package.\r\n\r\n4) There is a script to build browser version and an instruction of how to launch it in readme.\r\n\r\nThe second use case is when you want to package both your own code and the original code of RAML parser, then you need to create your own webpack configuration, which makes sense, I think. \r\n\r\nAnd in this case you need your own webpack configuration to take into account that browser version of RAML parser needs to have `fs` replaced with the stub, as was stated earlier in my answer:\r\n```\r\nIf you want to build the version manually, you can either run the script generateBrowserVersion, or, \r\nif you want to pack it as a part of your own package, add an alias for fs to your webpack config pointing to web-tools/modules/emptyFS.js\r\n```\r\nAugustin posted the sample of such an addition.\r\nI agree that this might be added to readme, but, please, take into account that you are the second user (if this is the option you need) that encounters this use case.\r\n\r\nAlso note that you can try to use any of the packages mentioned above (in example, npm browser package) to pack it with your own code, never tried that myself.\r\n\r\nPlease let me know what you think.",
"title": null,
"type": "comment"
}
] | 4 | 10 | 4,159 | false | false | 4,159 | true |
elastic/apm-server | elastic | 252,255,788 | 92 | {
"number": 92,
"repo": "apm-server",
"user_login": "elastic"
} | [
{
"action": "opened",
"author": "ruflin",
"comment_id": null,
"datetime": 1503489376000,
"masked_author": "username_0",
"text": "Important Changes / Additions:\r\n* Add support for cloud id. See https://github.com/elastic/beats/pull/4964 for more details. This could simplify the onboard for users that use apm-server with the Cloud in the future.\r\n* Be able to overwrite index pattern in the index template. See https://github.com/elastic/beats/pull/4769 for more details. This allows to clean up our system tests.",
"title": "Update beats to bd6981d",
"type": "issue"
},
{
"action": "created",
"author": "ruflin",
"comment_id": 324547849,
"datetime": 1503556921000,
"masked_author": "username_0",
"text": "@simitt For updating _beats: Yes\r\n\r\nOur use case for overwriting the index pattern name is for testing. On the beats side especially for logging people create their own templates. But in general it's only expert users that do this and I would not expect it to happen on the apm-server side at first.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 683 | false | false | 683 | false |
jneen/rouge | null | 62,704,011 | 249 | {
"number": 249,
"repo": "rouge",
"user_login": "jneen"
} | [
{
"action": "opened",
"author": "meganemura",
"comment_id": null,
"datetime": 1426687984000,
"masked_author": "username_0",
"text": "Fix forgotten change in 1c5899e6eb418d9c10cbb2191c82aa521ab7f2c5.",
"title": "fix forgotten change",
"type": "issue"
},
{
"action": "created",
"author": "jneen",
"comment_id": 83058871,
"datetime": 1426698335000,
"masked_author": "username_1",
"text": "thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 72 | false | false | 72 | false |
KeenRivals/bestmotherfucking.website | null | 210,067,956 | 15 | {
"number": 15,
"repo": "bestmotherfucking.website",
"user_login": "KeenRivals"
} | [
{
"action": "opened",
"author": "DeeprajPandey",
"comment_id": null,
"datetime": 1487947963000,
"masked_author": "username_0",
"text": "Put the style tag in the end. Why should the user wait for the content while the CSS loads?",
"title": "Change position of style tags",
"type": "issue"
},
{
"action": "created",
"author": "KeenRivals",
"comment_id": 282323984,
"datetime": 1487951151000,
"masked_author": "username_1",
"text": "What is the benefit of doing this? Couldn't it result in a flash of un-styled content in *extremely* slow connections?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FrancosLab",
"comment_id": 287530876,
"datetime": 1489830623000,
"masked_author": "username_2",
"text": "Better yet, move to inline styles.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Wolf480pl",
"comment_id": 287629921,
"datetime": 1489942260000,
"masked_author": "username_3",
"text": "I think that was the point.\r\n\r\nIt's a motherfucking website.\r\nThe main purpose is the user being able to read the content.\r\nIf they have an extremely slow connection, or the connection drops after a certain point, I think it's better to show more content without style than less content but with style.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sweepyoface",
"comment_id": 290689777,
"datetime": 1490960274000,
"masked_author": "username_4",
"text": "You don't load HTML in bits, you either get it all, or nothing. It's best practice to have stylesheets in the `<head` tag. A better alternative is to just embed the stylesheet with `<link>` tags",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KeenRivals",
"comment_id": 290691894,
"datetime": 1490960990000,
"masked_author": "username_1",
"text": "I agree that it's best practice to keep the styles in the ``<head>``. Putting ``<style>`` and ``<script>`` at the bottom of ``<body>`` has always felt like a hack for sites serving bloated styles and scripts.",
"title": null,
"type": "comment"
}
] | 5 | 6 | 947 | false | false | 947 | false |
apache/commons-lang | apache | 128,379,192 | 122 | {
"number": 122,
"repo": "commons-lang",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "NickManley",
"comment_id": null,
"datetime": 1453621110000,
"masked_author": "username_0",
"text": "",
"title": "Add method to DiffBuilder to allow appending from a DiffResult.",
"type": "issue"
},
{
"action": "created",
"author": "PascalSchumacher",
"comment_id": 217722232,
"datetime": 1462716435000,
"masked_author": "username_1",
"text": "@username_0 Thanks for the pull request.\r\n\r\nIt would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira/browse/LANG/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PascalSchumacher",
"comment_id": 220404644,
"datetime": 1463680935000,
"masked_author": "username_1",
"text": "@username_0 Sorry I closed the wrong pull request. I meant to close #121 instead of this one.\r\n\r\nCan you please reopen this one and close #121?\r\n\r\nThanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PascalSchumacher",
"comment_id": 220405242,
"datetime": 1463681070000,
"masked_author": "username_1",
"text": "Issue to track this enhancement: https://issues.apache.org/jira/browse/LANG-1233",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NickManley",
"comment_id": 220787760,
"datetime": 1463848876000,
"masked_author": "username_0",
"text": "I don't see any place on GitHub to reopen it once closed. I might need to make another pull request.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PascalSchumacher",
"comment_id": 220791899,
"datetime": 1463853557000,
"masked_author": "username_1",
"text": "Thanks for opening a new pull request :) and sorry again :(.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PascalSchumacher",
"comment_id": 220845360,
"datetime": 1463938773000,
"masked_author": "username_1",
"text": "Thanks! :+1:",
"title": null,
"type": "comment"
}
] | 2 | 7 | 628 | false | false | 628 | true |
docker-library/ghost | docker-library | 254,181,801 | 86 | null | [
{
"action": "opened",
"author": "uname-yang",
"comment_id": null,
"datetime": 1504143169000,
"masked_author": "username_0",
"text": "I found the url in docker are static. `http://localhost:2368`.\r\n\r\n```\r\nsu-exec node ghost config --ip 0.0.0.0 --port 2368 --no-prompt --db sqlite3 --url http://localhost:2368 --dbpath \"$GHOST_CONTENT/data/ghost.db\";\r\n```\r\nWhen we click some <a> tag in html, it will redirect to 'http://localhost:2368'.\r\n\r\nBut in host server, we need to change it to hostname, such as 'www.xxx.com'.\r\nAnd there is not configurable.",
"title": "URL in Dockerfile are not configurable.",
"type": "issue"
},
{
"action": "created",
"author": "tianon",
"comment_id": 326172734,
"datetime": 1504146987000,
"masked_author": "username_1",
"text": "Use \"-e url=...\" to change that value at runtime.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tianon",
"comment_id": null,
"datetime": 1504147055000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tianon",
"comment_id": 326172902,
"datetime": 1504147055000,
"masked_author": "username_1",
"text": "See also https://github.com/docker-library/ghost/issues/77.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tianon",
"comment_id": 420775118,
"datetime": 1536781835000,
"masked_author": "username_1",
"text": "FYI, I've filed https://github.com/docker-library/docs/pull/1306 to help clarify this. :+1:",
"title": null,
"type": "comment"
}
] | 2 | 5 | 725 | false | false | 725 | false |
apache/orc | apache | 201,736,060 | 84 | {
"number": 84,
"repo": "orc",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "omalley",
"comment_id": null,
"datetime": 1484787449000,
"masked_author": "username_0",
"text": "…tten\r\n\r\nduring merge. (username_0)",
"title": "ORC-132. Implement a merge file method and fix the number of rows wri…",
"type": "issue"
},
{
"action": "created",
"author": "omalley",
"comment_id": 273867668,
"datetime": 1484852782000,
"masked_author": "username_0",
"text": "The new version of the patch:\r\n* uses the maximum buffer size of the input files rather than reject them.\r\n* uses List rather than Path[] as the input parameter\r\n* tests that the buffer size is updated correctly\r\n* renames the testGoodMerge to testMerge since it tests both good and bad merges",
"title": null,
"type": "comment"
}
] | 1 | 2 | 325 | false | false | 325 | true |
paypal/downshift | paypal | 281,829,425 | 282 | {
"number": 282,
"repo": "downshift",
"user_login": "paypal"
} | [
{
"action": "opened",
"author": "jlongster",
"comment_id": null,
"datetime": 1513185412000,
"masked_author": "username_0",
"text": "Fixes #281. \r\n\r\nAs I dug into this I realized that it would be nicer to consolidate the code for scrolling to an item so it behaves exactly the same whether or not you are controlling the prop. This will reduce bugs between those use cases.\r\n\r\nThe way to do this is to always scroll within `componentDidUpdate`. The only problem is that this makes it harder to control scrolling; my first attempt added an option to `setHighlightedIndex` to avoid scrolling, and since that's called directly from `onMouseEvent` we can pass that information. But in `componentDidUpdate` we have no idea why it's changing. However this is always the case in the controlled prop scenario anyway, so we have to accept it.\r\n\r\nThe only solution is an ugly setTimeout which tells the system to not scroll it at all. This nicely fixes the problem entirely; it'll never scroll it if you are moving the cursor around or scrolling yourself and makes it feel a lot better. Note that this also changes the uncontrolled prop scenario: if you hover over an element at the bottom of the list, **it will no longer scroll down** to show it fully in view. This is better behavior in my opinion though as I'd never expect it to move around under me just by hovering.\r\n\r\nThis does not fix #240, as it's a different issue caused by a similar `onMouseEnter` event. A similar fix could be adopted there where it sets a timeout to tell the system to avoid any `onMouseEnter` events after key up/down.\r\n\r\n**Checklist**:\r\n\r\n* [ ] Documentation NA\r\n* [x] Tests\r\n* [x] Ready to be merged\r\n <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [x] Added myself to contributors table",
"title": "Consolidate scrolling of the list when highlighted index changes and never scroll from a `onMouseEnter` event (fixes #281)",
"type": "issue"
},
{
"action": "created",
"author": "kentcdodds",
"comment_id": 352211339,
"datetime": 1513457860000,
"masked_author": "username_1",
"text": "Ok! I've written a test for it and I'm much happier with this now that I can see the test. Makes a lot of sense. Thank you very much for the contribution :clap:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kentcdodds",
"comment_id": 352211599,
"datetime": 1513458136000,
"masked_author": "username_1",
"text": "Thanks so much for your help @username_0! I've added you as a collaborator on the project. Please make sure that you review the `other/MAINTAINING.md` and `CONTRIBUTING.md` files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using [the contributor covenant](http://contributor-covenant.org/)). You might also want to [watch the repo](https://help.github.com/articles/watching-repositories/) to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)",
"title": null,
"type": "comment"
}
] | 3 | 4 | 2,512 | false | true | 2,512 | true |
whatwg/html | whatwg | 166,449,669 | 1,575 | null | [
{
"action": "opened",
"author": "isiahmeadows",
"comment_id": null,
"datetime": 1468966364000,
"masked_author": "username_0",
"text": "I personally find it a little unintuitive that `contenteditable` doesn't accept `\"contenteditable\"` as an alias for `\"true\"` to support the HTML5 shorthand, especially when the empty string also is one. I find `\"false\"` to be relatively uncommon, since usually, it's not common to include non-editable children within a `contenteditable` region.\r\n\r\nAnd apparently, [it's](https://web.archive.org/web/20160402053734/http://www.tutorialspoint.com/html/html_attributes_reference.htm) [been](https://stackoverflow.com/questions/8775782/setting-false-value-vs-removing-an-attribute) [tripping](https://stackoverflow.com/questions/9201471/how-to-add-boolean-attribute-using-javascript) [up](https://stackoverflow.com/questions/27662410/html-5-toggling-the-contenteditable-attribute-with-javascript) [many](https://stackoverflow.com/questions/33356151/javascript-boolean-true-turns-false-false-does-not-turn-true) [people](https://github.com/kangax/html-minifier/issues/63#issuecomment-18634984), since it's a ternary where one of the three is exceptionally rare in practice.",
"title": "Is there a particular reason why `contenteditable` shouldn't accept the shorthand?",
"type": "issue"
},
{
"action": "created",
"author": "tabatkins",
"comment_id": 233786698,
"datetime": 1468967537000,
"masked_author": "username_1",
"text": "I suspect this is the mistaken assumption that boolean attributes expand to have their name as their value? @username_0, this doesn't happen; `<div foo>` \"expands\" to `<div foo=\"\">`.\r\n\r\n(This misapprehension derives from the *original* explanation for boolean attributes, which is that SGML allowed you to omit the attribute **name** if the value was enumerated and unique among all enumerated attributes allowed on the element, and a number of attributes had a value with the same name as the attribute to help support that.)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "isiahmeadows",
"comment_id": null,
"datetime": 1468995570000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "isiahmeadows",
"comment_id": 233849084,
"datetime": 1468995570000,
"masked_author": "username_0",
"text": "@domenic I was referring to `foo` in `<div foo>`.\r\n\r\n@username_1 Never mind then...that also explains why I had that misconception.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,727 | false | false | 1,727 | true |
xonsh/xonsh | xonsh | 210,295,485 | 2,264 | null | [
{
"action": "opened",
"author": "harukaeru",
"comment_id": null,
"datetime": 1488094809000,
"masked_author": "username_0",
"text": "I found it if the library does not installed, `history replay` does not work by diving in source code.\r\n\r\n\r\nSince there is no explanation about `pygments` or `style` in the document(`http://xon.sh/tutorial_hist.html`), I want you to add the sentences about that.",
"title": "`history play` does not work when not installed `pygments`",
"type": "issue"
},
{
"action": "created",
"author": "gforsyth",
"comment_id": 282554375,
"datetime": 1488114158000,
"masked_author": "username_1",
"text": "Thanks for reporting @username_0!\r\n\r\nI can reproduce this error, here's a full traceback:\r\n\r\n```console\r\nhistory replay -o ~/new.json /home/gil/.local/share/xonsh\r\n............... /xonsh-8e015a67-ae61-48c8-b551-f59e7180df5f.json\r\nxonsh: To log full traceback to a file set: $XONSH_TRACEBACK_LOGFILE = <filename>\r\nTraceback (most recent call last):\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/proc.py\", line 1333, in run\r\n r = self.f(self.args, sp_stdin, sp_stdout, sp_stderr, spec)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/proc.py\", line 1175, in proxy_four\r\n return f(args, stdin, stdout, stderr)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/history/main.py\", line 338, in history_main\r\n xrp.replay_main_action(hist, ns, stdout=stdout, stderr=stderr)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/replay.py\", line 111, in replay_main_action\r\n hist = replayer.replay(merge_envs=ns.merge_envs, target=ns.target)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/replay.py\", line 52, in replay\r\n new_env = self._merge_envs(merge_envs, re_env)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/replay.py\", line 76, in _merge_envs\r\n new_env = Env(**new_env)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/environ.py\", line 789, in __init__\r\n self[key] = val\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/environ.py\", line 945, in __setitem__\r\n val = ensurer.convert(val)\r\n File \"/home/gil/miniconda3/lib/python3.5/site-packages/xonsh/tools.py\", line 1562, in intensify_colors_on_win_setter\r\n delattr(builtins.__xonsh_shell__.shell.styler, 'style_name')\r\nAttributeError: 'NoneType' object has no attribute 'style_name'\r\n```\r\n\r\nIt's curious that I'm hitting a windows-specific ensurer.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "scopatz",
"comment_id": null,
"datetime": 1488227387000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 2,246 | false | false | 2,246 | true |
tvdzwan/hyperion | null | 49,907,851 | 202 | null | [
{
"action": "opened",
"author": "Batmanan",
"comment_id": null,
"datetime": 1416845414000,
"masked_author": "username_0",
"text": "I'm having issues with my Fushicai frame grabber and just need some clarification on my setup.\r\n\r\nMy setup is for multiple HDMI sources so I am using a HDMI splitter and HDMI2AV convertor with a Rpi model B running Rasbian. With this setup I am unable to get my framegrabber to take screenshots or work with my TV. I am pretty sure I have tried everythung and it is still not working. So i just want to check something so i know what i should be aiming for.\r\n\r\nWith this setup up would I be correct in thinking that if my framegrabber is working correctly if i plug in another TV using a HDMI cable from the Rpi to the TV I should see whatever is on my source input? For example my Blu-ray player / laptop / sky box? Or will the display output from the Rpi be XMBC?\r\n\r\nPlease help?",
"title": "Correct Amblight Setup",
"type": "issue"
},
{
"action": "created",
"author": "tpmodding",
"comment_id": 191441136,
"datetime": 1456954235000,
"masked_author": "username_1",
"text": "@username_0 still need help?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brindosch",
"comment_id": 193513394,
"datetime": 1457394971000,
"masked_author": "username_2",
"text": "Closed due to age. Please open a new one, if problems still exists.\r\nThank you",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "brindosch",
"comment_id": null,
"datetime": 1457394971000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 886 | false | false | 886 | true |
palantir/http-remoting | palantir | 229,178,676 | 429 | {
"number": 429,
"repo": "http-remoting",
"user_login": "palantir"
} | [
{
"action": "opened",
"author": "avisbal",
"comment_id": null,
"datetime": 1494971231000,
"masked_author": "username_0",
"text": "@uschi2000 / @schlosna - here is one approach of how we can add userId metadata to zipkin trace logs so we can filter on them in the Zipkin UI.\r\n\r\n#### Proposed changes\r\n - `Span` now has a `Map<String,String>` field that is used to store contextual information on spans via zipkin `BinaryAnnotation`s\r\n - `TraceEnrichingFilter` stores userId metadata on the spans it creates\r\n\r\n#### Followup changes\r\n - Add configuration to enable/disable trace logging on a per user basis\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/http-remoting/429)\r\n<!-- Reviewable:end -->",
"title": "support adding metadata to spans at completion",
"type": "issue"
},
{
"action": "created",
"author": "avisbal",
"comment_id": 302195110,
"datetime": 1495047399000,
"masked_author": "username_0",
"text": "@schlosna / @uschi2000 - this is ready for review",
"title": null,
"type": "comment"
}
] | 1 | 2 | 753 | false | false | 753 | false |
quantopian/zipline | quantopian | 229,421,759 | 1,794 | {
"number": 1794,
"repo": "zipline",
"user_login": "quantopian"
} | [
{
"action": "opened",
"author": "Peque",
"comment_id": null,
"datetime": 1495039875000,
"masked_author": "username_0",
"text": "The current docstring does not match the function parameters.",
"title": "Fix docstring in TradingEnvironment class",
"type": "issue"
},
{
"action": "created",
"author": "Peque",
"comment_id": 302159776,
"datetime": 1495041266000,
"masked_author": "username_0",
"text": "Tests are failing due to Yahoo not responding when calling `get_benchmark_returns()` (the page seems down).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ssanderson",
"comment_id": 302161301,
"datetime": 1495041477000,
"masked_author": "username_1",
"text": "@username_0 thanks for the fix. Agreed that the failures aren't related to this change. We're working on fixing the yahoo-related failures.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 590 | false | true | 304 | true |
oduwsdl/oduwsdl.github.io | oduwsdl | 236,992,045 | 4 | null | [
{
"action": "opened",
"author": "machawk1",
"comment_id": null,
"datetime": 1497899530000,
"masked_author": "username_0",
"text": "https://github.com/oduwsdl/oduwsdl.github.io/blob/master/_bibtexs/ainsworth-a.html is an odd franken-file containing some surfaced metadata and the raw bibtex content embedded in HTML. This produces a large barrier of entry in terms of other WS-DLers submitting new entries via a PR. Can you utilize the native .bib format as raw file then extract the contents as needed by the build system as metadata?",
"title": "Move to using raw .bib files for publications page",
"type": "issue"
},
{
"action": "created",
"author": "machawk1",
"comment_id": 309538370,
"datetime": 1497899590000,
"masked_author": "username_0",
"text": "Also, the bibtex field in the entries in the YAML at https://github.com/oduwsdl/oduwsdl.github.io/blob/master/_data/pubs.yml direct to an HTML file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "N0taN3rd",
"comment_id": 309604528,
"datetime": 1497916235000,
"masked_author": "username_1",
"text": "This was an design choice\r\n``_config.yml``\r\n```yaml\r\ncollections:\r\n bibtexs:\r\n output: true\r\n permalink: /:collection/:name\r\n```\r\nJekyll has this feature call '[collections](https://jekyllrb.com/docs/collections/)' which allows for 'collections' of things not pages or posts to be rendered.\r\nSince the field output: true is set jekyll will generate actual html on deployment rather than dynamically (makes archiving our page easier :stuck_out_tongue_winking_eye:). \r\nThe current manner by which they are stored does not need to change and how others add to this collection is flexible. \r\n\r\n### All bibtex pages could can be html or md but require this jekyll markup at the bare minimum\r\n```md\r\n---\r\nlayout: post\r\ntitle: 'Impact of URI Canonicalization on Memento Count'\r\ndescription: Mat Kelly, Lulwah M. Alkwai, Sawood Alam, Michael L. Nelson, Michele C. Weigle, and Herbert Van de Sompel\r\nbib: kelly-c.bib\r\n---\r\n```\r\nand then only include \r\n```html\r\n<h1>kelly-countingMementos2017</h1>\r\n<h3>Summary</h3>\r\n<p>Mat Kelly, Lulwah M. Alkwai, Sawood Alam, Michael L. Nelson, Michele C. Weigle, and Herbert Van de Sompel, \"Impact of URI Canonicalization on Memento Count,\" In <em>Proceedings of the 16th ACM/IEEE-CS Joint Conference on Digital Libraries</em>. June 2017, To Appear.\r\n<a id=\"kelly-countingMementos2017Bib\" name=\"kelly-countingMementos2017Bib\"></a>\r\n</p>\r\n</div>\r\n<h3>Bibtex entry</h3>\r\n```\r\nor \r\n```md\r\n# bib-key\r\n### Summary\r\n<authors, name, where accepted/present text>\r\n```\r\nAnd the ``.bib`` file could be placed in a sub directory ``_bibtexs/bib`` or right beside the user created content and internally add a specific __layouts for BibTeX \r\n\r\n### Or bibtex pages are only .md\r\n```md\r\n---\r\nlayout: bibtex\r\ntitle: 'Impact of URI Canonicalization on Memento Count'\r\ndescription: Mat Kelly, Lulwah M. Alkwai, Sawood Alam, Michael L. Nelson, Michele C. Weigle, and Herbert Van de Sompel\r\nbibKey: kelly-countingMementos2017\r\nsummary: Mat Kelly, Lulwah M. Alkwai, Sawood Alam, Michael L. Nelson, Michele C. Weigle, and Herbert Van de Sompel, \"Impact of URI Canonicalization on Memento Count\"\r\nwhere: In Proceedings of the 16th ACM/IEEE-CS Joint Conference on Digital Libraries\r\ndatetime: June 2017, To Appear\r\n.....etc etc\r\n---\r\n@INPROCEEDINGS { kelly-countingMementos2017,\r\n AUTHOR = { Mat Kelly, Lulwah M. Alkwai, Sawood Alam, Michael L. Nelson, Michele C. Weigle, and Herbert Van de Sompel },\r\n TITLE = { Impact of URI Canonicalization on Memento Count },\r\n BOOKTITLE = { Proceedings of the 16th ACM/IEEE-CS Joint Conference on Digital Libraries },\r\n SERIES = { JCDL '17 },\r\n YEAR = { 2017 },\r\n MONTH = { jun },\r\n NOTE = { To Appear },\r\n}\r\n```` \r\n\r\nIf it is just the raw bibtex someone whould have to create a parser or run pre commit hooks to render the raw bibtex for us. \r\nGithub pages does not allow plugins which would do this automatically.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "machawk1",
"comment_id": 309605217,
"datetime": 1497916522000,
"masked_author": "username_0",
"text": "Everything between the '---' seems redundant and potentially inconsistent with the bibtex info below. A hook may be the way to go for the sake of interoperability.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "phonedude",
"comment_id": null,
"datetime": 1618239026000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "phonedude",
"comment_id": 817876965,
"datetime": 1618239026000,
"masked_author": "username_2",
"text": "Closing this since we're moving away from manually maintained pub lists.",
"title": null,
"type": "comment"
}
] | 3 | 6 | 3,673 | false | false | 3,673 | false |
18F/hub | 18F | 104,506,052 | 402 | null | [
{
"action": "opened",
"author": "melodykramer",
"comment_id": null,
"datetime": 1441207278000,
"masked_author": "username_0",
"text": "Goal: To not have to update every page on the Hub every time a person leaves\r\n\r\nIdea: Keep metadata that maps individuals to roles, and use that metadata to generate text.\r\n\r\n\r\nCapturing conversation from Slack: \r\n\r\nSo something like this:\r\n```walrus:\r\n name: username_2\r\n full_name: Mike Bland\r\n```\r\nAnd then the template would actually have: `[{{ site.data.contacts.walrus.full_name }}]({{ site.baseurl }}/team/{{ site.data.contacts.walrus.name }})`\r\n\r\nWe could make it easier by creating a plugin that’ll expand the entry into a link automatically, so you’d just have to write `{% contact_link walrus %}`.",
"title": "Add metadata that maps individuals to roles, and use that metadata to generate text.",
"type": "issue"
},
{
"action": "created",
"author": "kategarklavs",
"comment_id": 137135529,
"datetime": 1441208068000,
"masked_author": "username_1",
"text": "I love this idea. Along similar lines, @username_3 and I found, in the course of our wg-content research, that lots of folks aren't familiar with the content resources that are available. We'd love to be able to create a content \"directory\" of sorts — a searchable directory of content folk that lists each person's skills/preferences/aptitudes/current projects. Seems like this might intersect nicely with the current tagging initiative ... \r\n\r\ncc @username_0 @username_2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 137136296,
"datetime": 1441208197000,
"masked_author": "username_2",
"text": "@username_1 Something like this?\r\n\r\nhttps://hub.18f.gov/skills/\r\nhttps://hub.18f.gov/interests/\r\n\r\nExcept perhaps where the skills and interests themselves are categorized?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 137136773,
"datetime": 1441208288000,
"masked_author": "username_2",
"text": "Oh, also, I'd built in the concept of \"departments\" early on, but it just hasn't gotten much attention:\r\n\r\nhttps://hub.18f.gov/departments/\r\n\r\nThey're also still in the [Team API](https://team-api.18f.gov/public/api/). Happy to start fleshing out those concepts, either here or in [18F/team_api](https://github.com/18F/team_api).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kategarklavs",
"comment_id": 137140487,
"datetime": 1441208973000,
"masked_author": "username_1",
"text": "@username_2 Yes! That looks great (and I'd be happy to help out, in what ways I can, with the fleshing out of these concepts — let me know if you need content assistance).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "emileighoutlaw",
"comment_id": 137142081,
"datetime": 1441209259000,
"masked_author": "username_3",
"text": "I think this would be a great place to put content!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "melodykramer",
"comment_id": 139346427,
"datetime": 1441911792000,
"masked_author": "username_0",
"text": "A perfect example for why we need this: https://github.com/18F/hub/blob/master/_pages/qa/it-service.md",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ultrasaurus",
"comment_id": 142776090,
"datetime": 1443057532000,
"masked_author": "username_4",
"text": "@dhcole did a bunch of integration work this spring with Midas... is there any way we can leverage that? The idea was that we could use bio, title, skills and interests from the Midas profile since it is easy for people to edit there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 142776946,
"datetime": 1443057709000,
"masked_author": "username_2",
"text": "Yes, I've been meaning to import Midas data into the Team API. Just haven't gotten around to it yet.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "melodykramer",
"comment_id": 142963646,
"datetime": 1443108587000,
"masked_author": "username_0",
"text": "@username_2 Do you know how far out on the roadmap this is? We're designing pages for the Hub that could really use this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 142968361,
"datetime": 1443109420000,
"masked_author": "username_2",
"text": "We can start getting it together now. Create a `_data/roles.yml` file that could look something like this:\r\n\r\n```yaml\r\nops_contact: batemapf\r\ntalent_contact: jamie\r\nonboarding_contact: melody\r\n```\r\n\r\nAnd so on. Then in the pages, we can start using `{{ site.data.roles.onboarding_contact }}` and so on. When the day comes we switch this over to importing from the Team API, the pages themselves shouldn't need any updates.\r\n\r\nPlaying around with the local data file in this way may also help us try out a few ideas before committing it to the Team API.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nicoleslaw",
"comment_id": 185427619,
"datetime": 1455746553000,
"masked_author": "username_5",
"text": "@username_2 @mtorres253 Is this still in progress?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 185461921,
"datetime": 1455752726000,
"masked_author": "username_2",
"text": "In the sense that we haven't actually started working on it, yes, still in progress. :smiley: I'd imagine it would be a relatively small task to add it to the Team API, then perhaps a slightly larger task to integrate it into the Handbook. We should scope and prioritize it at the next planning meeting.",
"title": null,
"type": "comment"
}
] | 6 | 13 | 3,256 | false | false | 3,256 | true |
meteor/meteor | meteor | 56,435,194 | 3,632 | null | [
{
"action": "opened",
"author": "lorensr",
"comment_id": null,
"datetime": 1422996685000,
"masked_author": "username_0",
"text": "Let devs know that if `error.reason is 'Email already exists.'`, they should tell the user that either they've already created an account, in which case they can try logging in, or someone else has signed up using their email, and they can recover the account by resetting the password.\r\n\r\nhttp://docs.meteor.com/#/full/accounts_createuser",
"title": "Document recommended createUser error handling",
"type": "issue"
},
{
"action": "created",
"author": "glasser",
"comment_id": 72748092,
"datetime": 1423002040000,
"masked_author": "username_1",
"text": "Thanks for the docs feature request! You might be interested in reading our [feature request guidelines](https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#feature-requests).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "abernix",
"comment_id": null,
"datetime": 1463732360000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "abernix",
"comment_id": 220544414,
"datetime": 1463732360000,
"masked_author": "username_2",
"text": ":smile:",
"title": null,
"type": "comment"
}
] | 3 | 4 | 530 | false | false | 530 | false |
Wintergatan/Midi-to-laser-cutter | Wintergatan | 225,265,187 | 9 | null | [
{
"action": "opened",
"author": "whitebird",
"comment_id": null,
"datetime": 1493480646000,
"masked_author": "username_0",
"text": "Currently I mocked up this layout:\r\n\r\nThoughts?",
"title": "Layout preview",
"type": "issue"
},
{
"action": "created",
"author": "Pierstoval",
"comment_id": 304604470,
"datetime": 1496046591000,
"masked_author": "username_1",
"text": "Maybe have a little SVG schema describing the workspace. It doesn't need to be updated with input values, but at least having a picture with all measurements values visible might help people understand how these values are used on a _real_ laser cutting machine",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Pierstoval",
"comment_id": 304729506,
"datetime": 1496091473000,
"masked_author": "username_1",
"text": "If you're saying that only line color, workspace size and file format are related to laser cutter, then maybe add a specific fieldset \"Laser cutter settings\" to know there's a difference between midi-to-laser output & machine config.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whitebird",
"comment_id": 305153231,
"datetime": 1496227179000,
"masked_author": "username_0",
"text": "Good idea, I then propose to move all settings to below the preview together with a heading so it's clear that it's for the laser cutter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whitebird",
"comment_id": 319082799,
"datetime": 1501511155000,
"masked_author": "username_0",
"text": "Has been migrated to https://github.com/Wintergatan/MIDIPunch/issues/1",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "whitebird",
"comment_id": null,
"datetime": 1501511156000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 863 | false | false | 863 | false |
mattlewis92/angular-calendar | null | 297,269,781 | 464 | null | [
{
"action": "opened",
"author": "LordShiroe",
"comment_id": null,
"datetime": 1518647641000,
"masked_author": "username_0",
"text": "<!---\r\n\r\nFAQ (please read!):\r\n\r\nProblems with build tooling? Please check the examples folder first: https://github.com/username_1/angular-calendar/tree/master/build-tool-examples\r\n\r\nStyling not appearing? Make sure you're including node_modules/angular-calendar/css/angular-calendar.css\r\n\r\nNeed an example of how to do something? Check the demo page, it probably has you covered: https://username_1.github.io/angular-calendar/demos/\r\n\r\nNeed a full list of all API options? Check the docs for each component:\r\nhttps://username_1.github.io/angular-calendar/docs/components/CalendarMonthViewComponent.html\r\nhttps://username_1.github.io/angular-calendar/docs/components/CalendarWeekViewComponent.html\r\nhttps://username_1.github.io/angular-calendar/docs/components/CalendarDayViewComponent.html\r\n\r\nPlease note that issues that ignore this template will be closed without notice!\r\n\r\n-->\r\n\r\n## I'm submitting a ...\r\n<!-- Check one of the following options with \"x\" -->\r\n<pre>\r\n[x] Bug report <!-- Please search github for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Support request => Please do not submit a support request here, please ask on https://stackoverflow.com/\r\n</pre>\r\n\r\n### Bug description / Feature request\r\n<!-- Please describe the bug you're experiencing here, or for feature requests a clear explanation of what you're trying to achieve and your use case -->\r\nAfter I update angular and angular-calendar to the current versions the locales stop working throwing the following error\r\n<pre>ERROR Error: Missing locale data for the locale \"es\".\r\n at findLocaleData (common.js:1500)\r\n at getLocaleId (common.js:1109)\r\n at getNamedFormat (common.js:3704)\r\n at formatDate (common.js:3665)\r\n at DatePipe.transform (common.js:4455)\r\n at CalendarDateFormatter.CalendarAngularDateFormatter.monthViewColumnHeader (angular-calendar.js:391)\r\n at CalendarDatePipe.transform (angular-calendar.js:523)\r\n at checkAndUpdatePureExpressionInline (core.js:13183)\r\n at checkAndUpdateNodeInline (core.js:13893)\r\n at checkAndUpdateNode (core.js:13832)</pre>\r\n### Minimal reproduction of the problem with instructions\r\n<!-- For bugs only, a link to minimally working plunker that reproduces the issue (you can fork a starter from any of the demos) -->\r\nI manage to reproduce the error [here!](https://plnkr.co/edit/IUZ08QMoHsWRU7KqFtyQ)\r\n### Versions\r\n\r\nAngular: 5.2.5\r\n\r\nCalendar library: 0.23.6\r\n\r\nBrowser name and version: Tested in Chromium 64.0.3282.119 and Firefox 58.0.2",
"title": "Missing locale data for the locale \"es\"",
"type": "issue"
},
{
"action": "closed",
"author": "mattlewis92",
"comment_id": null,
"datetime": 1518685100000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mattlewis92",
"comment_id": 365863089,
"datetime": 1518685100000,
"masked_author": "username_1",
"text": "Please see the breaking changes in the changelog when upgrading: https://github.com/username_1/angular-calendar/blob/master/CHANGELOG.md#breaking-changes",
"title": null,
"type": "comment"
}
] | 2 | 3 | 2,677 | false | false | 2,677 | true |
mcspring/phantompdf | null | 252,684,383 | 7 | {
"number": 7,
"repo": "phantompdf",
"user_login": "mcspring"
} | [
{
"action": "opened",
"author": "apanzerj",
"comment_id": null,
"datetime": 1503598030000,
"masked_author": "username_0",
"text": "Gem updates too!",
"title": "update outdated gems",
"type": "issue"
},
{
"action": "created",
"author": "apanzerj",
"comment_id": 324712782,
"datetime": 1503598046000,
"masked_author": "username_0",
"text": "@username_2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "greysteil",
"comment_id": 324842193,
"datetime": 1503645214000,
"masked_author": "username_1",
"text": "Would you guys be up for automatically creating dependency update PRs? I wrote [Dependabot](https://dependabot.com) to do that, and it's used by quite a few gems now, including [pry-byebug](https://github.com/deivid-rodriguez/pry-byebug/pulls?q=is%3Apr+is%3Aclosed). It'll make sure your gemspec always covers the latest versions, too. Might save you a bit of time?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "apanzerj",
"comment_id": 334232716,
"datetime": 1507138651000,
"masked_author": "username_0",
"text": "I think this is dead... so I'm moving on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mcspring",
"comment_id": 334320068,
"datetime": 1507160484000,
"masked_author": "username_2",
"text": "Sorry for missing your PR，can you reopen it and again？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "apanzerj",
"comment_id": 334512069,
"datetime": 1507219369000,
"masked_author": "username_0",
"text": "It's reopened and better than ever :-D\n\nOn Wed, Oct 4, 2017 at 4:41 PM, Mc.Spring <notifications@github.com> wrote:\n\n> Sorry for missing your PR，can you reopen it and again？\n>\n>\n>",
"title": null,
"type": "comment"
}
] | 3 | 6 | 664 | false | false | 664 | true |
emqtt/emqttd | emqtt | 202,496,343 | 881 | null | [
{
"action": "opened",
"author": "tomazbracic",
"comment_id": null,
"datetime": 1485167339000,
"masked_author": "username_0",
"text": "#### Environment\r\n\r\n- OS: Linux - Ubuntu\r\n- Erlang/OTP: \r\n- EMQ: 2.0\r\n\r\n#### Description\r\n\r\nTrying to use shared subscription. But it doesn't work. Messages are shown on all subscribers. All the messages. I've tried with both ... -t ‘$queue/topic’ and -t ‘$share/group/topic’\r\n\r\n\r\nBest",
"title": "shared subscription - doesn't work",
"type": "issue"
},
{
"action": "created",
"author": "huangdan",
"comment_id": 288598360,
"datetime": 1490235830000,
"masked_author": "username_1",
"text": "Two ways to create a shared subscription:\r\n\r\n1. $queue prefix:\r\n\r\n```\r\nmosquitto_sub -t '$queue/topic'\r\nmosquitto_pub -t topic -m hello\r\n```\r\n2. $share/\\<group\\>/ prefix:\r\n```\r\nmosquitto_sub -t '$share/group/topic'\r\nmosquitto_pub -t topic -m hello\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "huangdan",
"comment_id": null,
"datetime": 1490235853000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dbonino",
"comment_id": 400943839,
"datetime": 1530171936000,
"masked_author": "username_2",
"text": "Sorry to say, but we are still experiencing the same issue:\r\n\r\nmessages are published in QoS 2 to a certain topic, e.g., /observations/ and a set of 2 subscribers use the shared topic subscription: $share/substrial//observations/ in QoS 2.\r\nMessages are delivered to both clients as if they were \"isolated\" clients (all clients see all messages)\r\n\r\nSame behavior using $queue subscriptions.\r\n\r\nAny suggestion / improvements on this?",
"title": null,
"type": "comment"
}
] | 3 | 4 | 971 | false | false | 971 | false |
chocolatey/choco-wiki | chocolatey | 188,171,805 | 40 | {
"number": 40,
"repo": "choco-wiki",
"user_login": "chocolatey"
} | [
{
"action": "opened",
"author": "galeksandrp",
"comment_id": null,
"datetime": 1478670770000,
"masked_author": "username_0",
"text": "Ketarin 1.8.7.0 binary or either compiled from\r\nhttps://cdburnerxp.se/downloads/sourcecode/Ketarin.tar.gz\r\nhttp://scm.flyspray.org/repos/ketarin/\r\nhttps://github.com/svn2github/ketarin\r\nsupport sf urls\r\n```sh\r\nhttp(s)://sourceforge.net/projects/.../files/latest/download\r\nhttp(s)://downloads.sourceforge.net/projects/.../...\r\nhttp(s)://prdownloads.sourceforge.net/projects/.../...\r\n```\r\nisn't it?",
"title": "Ketarin and Sourceforge",
"type": "issue"
},
{
"action": "created",
"author": "ferventcoder",
"comment_id": 260185568,
"datetime": 1479042926000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 403 | false | false | 403 | false |
fluentribbon/Fluent.Ribbon | fluentribbon | 218,920,483 | 420 | null | [
{
"action": "opened",
"author": "Yumeryu",
"comment_id": null,
"datetime": 1491223257000,
"masked_author": "username_0",
"text": "Goal:\r\nWhen selected item changed by combo box or by code (ie from other button actions.), make RibbonTabItem \"show and selected\" or \"disappear and select home tab\".\r\n\r\nIssues: \r\nWhen selected item changes, ContextualGroups appears but RibbonTabItem is not selected, even the ContextualGroups' Visibility binding is based on the boolean value which RibbonTabItem's IsSelected bind to.\r\n\r\nSample project included, by clicking the 3 buttons on screen, you can see the ContextualGroups reacting different.\r\n\r\nThanks in advance.\r\n\r\n[WpfApplication1.zip](https://github.com/fluentribbon/Fluent.Ribbon/files/890026/WpfApplication1.zip)\r\n\r\n---\r\n### Environment\r\n\r\n- Fluent.Ribbon __latest code\r\n- Theme __?__ (not needed in version 5.0 and upwards)\r\n- Windows __10__\r\n- .NET Framework __4.5__",
"title": "ContextualGroups and RibbonTabItem's Visibility and IsSelected controlled by code.",
"type": "issue"
},
{
"action": "created",
"author": "Yumeryu",
"comment_id": 292480997,
"datetime": 1491555385000,
"masked_author": "username_0",
"text": "Any chance this can be looked at please? Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batzen",
"comment_id": 292701303,
"datetime": 1491636800000,
"masked_author": "username_1",
"text": "I am always trying to look at issues as fast as I can.\r\nPlease do not try to pressure me. My regular reaction to pressure here is to ignore the people causing it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batzen",
"comment_id": 292702473,
"datetime": 1491638519000,
"masked_author": "username_1",
"text": "This issue is two sided. I can lessen the negative effects a bit, but it's mainly caused by your code.\r\n\r\nProblem:\r\nYou set the bindings for your `IsSelected...Tab` to `OneWay` which will never completely work out using the ribbon because your code is not the only party having to change `IsSelected` on `RibbonTabItem`. You have to use `TwoWay` to allow the `Ribbon` to also change those properties. Otherwise the binding breaks as soon as your code and the ribbon disagree on the current value of the property.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Yumeryu",
"comment_id": 293206045,
"datetime": 1491903675000,
"masked_author": "username_0",
"text": "@username_1\r\n\r\nI do apologize for that, didn't mean to pressure you in any way. \r\n\r\nThanks for your reply, I am converting my project, which is using MS ribbon, to Fluent Ribbon, MS Ribbon works with one way, so I didn't realize the issue is actually caused by that. \r\n\r\nI've moved on to something else for a few days, but I will come back to try what you suggested, thanks again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batzen",
"comment_id": 299635694,
"datetime": 1494072559000,
"masked_author": "username_1",
"text": "@username_0 ping",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batzen",
"comment_id": 302214932,
"datetime": 1495051186000,
"masked_author": "username_1",
"text": "@username_0 ping",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batzen",
"comment_id": 306299015,
"datetime": 1496695279000,
"masked_author": "username_1",
"text": "@username_0 ping",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "batzen",
"comment_id": null,
"datetime": 1500029837000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 9 | 1,922 | false | false | 1,922 | true |
apache/incubator-superset | apache | 303,694,838 | 4,580 | null | [
{
"action": "opened",
"author": "JaeGerW2016",
"comment_id": null,
"datetime": 1520559739000,
"masked_author": "username_0",
"text": "Invalid identifier on visualize After a SQL query \r\nthen I View Query and copy it to SQL Editor\r\nThe doubt is: the same sql can be queried in the SQL editor, in the visualize invalid identifier error",
"title": "Invalid identifier on visualize After a SQL query",
"type": "issue"
},
{
"action": "created",
"author": "xrmx",
"comment_id": 372101217,
"datetime": 1520760304000,
"masked_author": "username_1",
"text": "Please add all the missing information from the issue template.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 525 | false | true | 263 | false |
Clancey/SimpleAuth | null | 209,847,073 | 28 | null | [
{
"action": "opened",
"author": "trevoriancox",
"comment_id": null,
"datetime": 1487875103000,
"masked_author": "username_0",
"text": "In samples/Sample.Droid/MainActivity.cs, the string \"native\" is provided in the client secret field to the GoogleApi constructor.\r\n\r\nThis results in an \"invalid_client\" error on iOS. The value that works is null. A secret is not applicable to a native application.",
"title": "Sample has invalid and unneeded client secret",
"type": "issue"
},
{
"action": "created",
"author": "Clancey",
"comment_id": 282112486,
"datetime": 1487882005000,
"masked_author": "username_1",
"text": "Well null still isn't correct, since some people will be using web authentication not pure native implementations. I added another constructor that doesn't require the client secret to avoid confusion.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Clancey",
"comment_id": null,
"datetime": 1487882005000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "trevoriancox",
"comment_id": 282156441,
"datetime": 1487892776000,
"masked_author": "username_0",
"text": "@username_1 You are fast! That was a huge help... all the issues I had fixed and avail via nuget, nice!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 566 | false | false | 566 | true |
babel/babel | babel | 107,777,470 | 2,416 | null | [
{
"action": "opened",
"author": "mattkime",
"comment_id": null,
"datetime": 1442947774000,
"masked_author": "username_0",
"text": "i'm working with an existing codebase with a large number of javascript files and we'd like to start using es6 module definitions. all our modules use \"define()\" statements as we're using AMD/ requirejs. when the AMD module formatter comes across these files it simply wraps them in an additional define statement - not good. ideally it would recognize the define statement and do nothing. this way all our existing code can go through the same babel setup without concern for the contents of the file.",
"title": "AMD module formatter shouldn't supply 'define' invocation if file already contains one",
"type": "issue"
},
{
"action": "created",
"author": "thejameskyle",
"comment_id": 142496545,
"datetime": 1442985593000,
"masked_author": "username_1",
"text": "That's out of scope for the AMD formatter. You can write your own Babel plugin to do that though. See: http://babeljs.io/docs/advanced/plugins/",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "thejameskyle",
"comment_id": null,
"datetime": 1442985593000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mattkime",
"comment_id": 142580921,
"datetime": 1443010296000,
"masked_author": "username_0",
"text": "@username_1 could you explain why its out of scope?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "loganfsmyth",
"comment_id": 142651564,
"datetime": 1443024927000,
"masked_author": "username_2",
"text": "@username_0 Babel expects all files to be ES6 modules. It isn't Babel's responsibility to try to deduce whether you were already using some other module system. By passing `amd` you are asking for a wrapper, the fact that you've already got a wrapper in there isn't something Babel is aware of or needs to be aware of.\r\n\r\nIt's also not clear what the expected behavior in the general case would be, do we have to somehow merge the two separate declarations? As @username_1 said, it should be pretty simple to write your own plugin to recognize the wrapper and I assume in your case it would be empty if you've got a manual wrapper in there, so you could delete the wrapper.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thejameskyle",
"comment_id": 142661993,
"datetime": 1443027462000,
"masked_author": "username_1",
"text": "@username_2 is exactly right, besides nested AMD wrappers is technically valid so I'm not sure how we'd decide what the rules are for deduping them. Only you know enough about how your project is structured to make that call.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mattkime",
"comment_id": 142669978,
"datetime": 1443028803000,
"masked_author": "username_0",
"text": "big thanks for the detailed explanations.",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,638 | false | false | 1,638 | true |
taye/interact.js | null | 166,054,672 | 403 | null | [
{
"action": "opened",
"author": "acoquoin",
"comment_id": null,
"datetime": 1468834389000,
"masked_author": "username_0",
"text": "Hello :)\r\n\r\nThank for interact.js, it's an amazing script :).\r\nBut i have a small issue, it is in any way, possibility to change the _holdDuration ?\r\n\r\n600ms is to long for our product manager.\r\n\r\nThanks in advance :)",
"title": "Configure _holdDuration",
"type": "issue"
},
{
"action": "created",
"author": "taye",
"comment_id": 238857482,
"datetime": 1470833675000,
"masked_author": "username_1",
"text": "With v1.2.6, you can do\r\n\r\n```javascript\r\ninteract.debug().defaultOptions._holdDuration = timeInMilliseconds;\r\n```\r\n\r\nWith the latest unstable version, there's no simple way. If you're using browserify, you can `require('interact.js/src/defaultOptions')._holdDuration = timeInMilliseconds;`\r\n\r\nI hope to add a better way to do this.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "taye",
"comment_id": null,
"datetime": 1472314180000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 549 | false | false | 549 | false |
alexmingoia/koa-router | null | 111,702,206 | 193 | null | [
{
"action": "opened",
"author": "dschinkel",
"comment_id": null,
"datetime": 1444941389000,
"masked_author": "username_0",
"text": "So I'm trying to create a route that'll take /people/locationId:12345\r\n\r\nI'm not creating a route for something like people/10/locations/20 which would look like this:\r\n\r\n/people/:id/locations/:id\r\n\r\nso how would I be able to do the first. The purpose of it is to allow people to specify filtering on fields right in the URI as opposed to something like /people?locationId:12345",
"title": "How to Specify params in the URI via Name",
"type": "issue"
},
{
"action": "created",
"author": "alexmingoia",
"comment_id": 159699949,
"datetime": 1448477546000,
"masked_author": "username_1",
"text": "Koa-router used the [path-to-regexp](https://github.com/pillarjs/path-to-regexp) module to translate path patterns into regular expressions.\r\n\r\nThe pattern string you want is `/people/:locationId(locationId:\\\\d+)`. That matches `/people/locationId:12345` and populates `ctx.params.locationId` with `locationId:12345`.\r\n\r\nAs far as I know, you cannot get just `12345` out of the parameter value without middleware. I would recommend creating your own query parsing middleware mounted to the router using `router.use()` that inspects `ctx.params.locationId` and removes the `locationId:` prefix from the value for subsequent middleware.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "alexmingoia",
"comment_id": null,
"datetime": 1448481656000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,013 | false | false | 1,013 | false |
vaadin/flow | vaadin | 268,670,613 | 2,779 | null | [
{
"action": "opened",
"author": "caalador",
"comment_id": null,
"datetime": 1509006513000,
"masked_author": "username_0",
"text": "",
"title": "When creating an application I want to have a defined way/place of creating language files.",
"type": "issue"
},
{
"action": "created",
"author": "pleku",
"comment_id": 339951493,
"datetime": 1509105452000,
"masked_author": "username_1",
"text": "Decided that this is just about making a demo and tutorial on how to create an app that supports multiple locales like english and klingon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caalador",
"comment_id": 342456372,
"datetime": 1510054573000,
"masked_author": "username_0",
"text": "Sorry to say I'm not putting the Klingon in as it's to a big part english and I couldn't get the font to work.\r\nI replaced it with Japanese which is almost the same.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "pleku",
"comment_id": null,
"datetime": 1510928034000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 304 | false | false | 304 | false |
node-red/node-red-dashboard | node-red | 166,528,583 | 33 | null | [
{
"action": "opened",
"author": "jpwsutton",
"comment_id": null,
"datetime": 1469003975000,
"masked_author": "username_0",
"text": "Following the instructions in the readme currently don't work because node-red-dashboard is not published on npmjs: https://www.npmjs.com/package/node-red-dashboard (404)\r\n\r\nIs this because it's not considered ready for the general community to use? If so, maybe a note on the readme might be quite useful.",
"title": "node-red-dashboard is not published on npmjs",
"type": "issue"
},
{
"action": "closed",
"author": "knolleary",
"comment_id": null,
"datetime": 1469004023000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "knolleary",
"comment_id": 233887472,
"datetime": 1469004023000,
"masked_author": "username_1",
"text": "Please see the very first line of the readme",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpwsutton",
"comment_id": 233889869,
"datetime": 1469004476000,
"masked_author": "username_0",
"text": "Apologies, Looks like I need some coffee!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 391 | false | false | 391 | false |
mrkn/mxnet.rb | null | 296,059,207 | 7 | null | [
{
"action": "opened",
"author": "mrkn",
"comment_id": null,
"datetime": 1518225152000,
"masked_author": "username_0",
"text": "I didn't have lists of MXNet features to be implemented in mxnet.rb.\r\nBut I think we need such lists to make contributions easier.",
"title": "Making the lists of features to be implemented",
"type": "issue"
},
{
"action": "created",
"author": "grandmasterspoc",
"comment_id": 395825119,
"datetime": 1528477622000,
"masked_author": "username_1",
"text": "Where would this list be? I want to contribute",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mrkn",
"comment_id": 396115001,
"datetime": 1528688924000,
"masked_author": "username_0",
"text": "@username_1 Thank you for your attention to this project.\r\nI'm making such lists. Wait a moment.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mrkn",
"comment_id": 396180689,
"datetime": 1528709294000,
"masked_author": "username_0",
"text": "I'm making feature matrix in this Google Spreadsheet.\r\nhttps://docs.google.com/spreadsheets/d/1ZEnzkHNzCYEmAey5Hac8hgI3mA-QRAN-ToqGJcRitEQ/edit?usp=sharing",
"title": null,
"type": "comment"
}
] | 2 | 4 | 433 | false | false | 433 | true |
Cimpress-MCP/git2consul | Cimpress-MCP | 95,162,713 | 25 | null | [
{
"action": "opened",
"author": "petemounce",
"comment_id": null,
"datetime": 1436957381000,
"masked_author": "username_0",
"text": "We run a multi-tenant system. It would be really handy to be able to \"mount\" repositories at particular points within the K/V storage, so that one tenant is isolated from another. We plan to have several repositories within each tenant for logically distinct segments of configuration (eg, application-settings, infra-settings, secrets), to end up with something like\r\n\r\n```\r\n/kv\r\n /environment\r\n /shared-app1\r\n /shared-app2\r\n /tenant1\r\n /application\r\n /app1\r\n /app2\r\n /infrastructure\r\n /secrets\r\n```\r\n\r\nDriven by git2consul configuration that might look similar to this:\r\n```json\r\n{\r\n \"version\": \"1.0\",\r\n \"repos\" : [\r\n {\r\n \"name\" : \"shared-app1\",\r\n \"mount_path\": \"tenant1/application\"\r\n \"url\" : \"https://my-settings.com/shared-app1\",\r\n \"branches\" : [\"dev\"],\r\n \"hooks\": [{\r\n \"type\" : \"polling\",\r\n \"interval\" : \"1\"\r\n }]\r\n }\r\n ]\r\n}\r\n```",
"title": "\"Mount\" a repo at a particular point within K/V storage",
"type": "issue"
},
{
"action": "created",
"author": "ryanbreen",
"comment_id": 121602885,
"datetime": 1436963780000,
"masked_author": "username_1",
"text": "Yeah, that's a minimal change, and I could see how helpful it would be as an organizational principle. I'll take a look.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petemounce",
"comment_id": 121921155,
"datetime": 1437042553000,
"masked_author": "username_0",
"text": "Thanks! I hope it was clear in the original text, but on re-reading it I'm not sure - I'd particularly like the ability to mount repos at arbitary depths of the K/V store - at which point g2c would need to recursively create the structure above a particular mount point if it didn't exist.\r\n\r\nWe're migrating from config files to consul, and so consequently not all of our apps and tenants will move at once. Therefore, as they migrate, we'll have ... gaps ... in the structure until it fills itself in.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ryanbreen",
"comment_id": 121952290,
"datetime": 1437052426000,
"masked_author": "username_1",
"text": "Yep, it was clear. I'm pretty sure Consul doesn't care about intermediate directories in the KV namespace, so setting an arbitrary depth parent should just work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petemounce",
"comment_id": 121955360,
"datetime": 1437053343000,
"masked_author": "username_0",
"text": "Ah, wonderful. Thanks :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ryanbreen",
"comment_id": 122136999,
"datetime": 1437093129000,
"masked_author": "username_1",
"text": "I think GH-26 implements this. I'll push a new build if this looks good.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ryanbreen",
"comment_id": null,
"datetime": 1437150293000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ryanbreen",
"comment_id": 122332655,
"datetime": 1437150293000,
"masked_author": "username_1",
"text": "This has been published as v0.10.0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petemounce",
"comment_id": 122414635,
"datetime": 1437166849000,
"masked_author": "username_0",
"text": "Thanks!\n\nI saw a tiny thing; your example in the readme starts with a /, but your\ntest forbids that.\n\n--\nSent from my phone. Please excuse typos and brevity, but never text speak.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ryanbreen",
"comment_id": 122421526,
"datetime": 1437168098000,
"masked_author": "username_1",
"text": "Great catch! Fixed.",
"title": null,
"type": "comment"
}
] | 2 | 10 | 2,029 | false | false | 2,029 | false |
hydroshare/hydroshare | hydroshare | 86,720,697 | 480 | null | [
{
"action": "opened",
"author": "Castronova",
"comment_id": null,
"datetime": 1433880794000,
"masked_author": "username_0",
"text": "In the latest version of HydroShare (hydroshare.org) users can rate comments, but are unable to rate resources. Users should have the ability to rate (or +1) individual resources.",
"title": "Resource Rating Functionality Missing",
"type": "issue"
},
{
"action": "created",
"author": "hyi",
"comment_id": 110496566,
"datetime": 1433882118000,
"masked_author": "username_1",
"text": "This issue is a regression resulting from three lines being dropped off from genericresource.html which was probably caused by merging somewhere along the way. Have added them back and tested on my local 446-feature branch. The lines added can be seen here: https://github.com/hydroshare/hydroshare/commit/4793dba060a58ff3079dff3995c4c52766afe42d. I am including this fix in my 446-feature branch which is slated as a potential hot fix for NFIE release. If vetted by the team for a NFIE hot fix release, this fix will be included together with on-demand bagging implementation for large resource metadata update performance improvement.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hyi",
"comment_id": 114915511,
"datetime": 1435160399000,
"masked_author": "username_1",
"text": "Ready for testing on park.hydroshare.org",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dtarb",
"comment_id": 118668522,
"datetime": 1436131588000,
"masked_author": "username_2",
"text": "Tested and appears to be working correctly on both park and www (via the hotfix I assume).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dtarb",
"comment_id": null,
"datetime": 1436131588000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 946 | false | false | 946 | false |
hypriot/image-builder-rpi | hypriot | 244,895,503 | 179 | {
"number": 179,
"repo": "image-builder-rpi",
"user_login": "hypriot"
} | [
{
"action": "opened",
"author": "firecyberice",
"comment_id": null,
"datetime": 1500796748000,
"masked_author": "username_0",
"text": "",
"title": "Add 20-generate-uuid at firstboot",
"type": "issue"
},
{
"action": "created",
"author": "firecyberice",
"comment_id": 333649137,
"datetime": 1506974756000,
"masked_author": "username_0",
"text": "ping @dieterreuter",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DieterReuter",
"comment_id": 333664362,
"datetime": 1506978182000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 2 | 3 | 22 | false | false | 22 | false |
AASJournals/AASTeX60 | AASJournals | 246,896,522 | 52 | null | [
{
"action": "opened",
"author": "kadrlica",
"comment_id": null,
"datetime": 1501538197000,
"masked_author": "username_0",
"text": "@username_2 suggests shrinking the width and center the abstract like emulateapj (e.g. https://www.sharelatex.com/templates/journals/emulateapj). This was originally proposed in #38, but is better kept in a separate issue.\r\n\r\n@username_1 was this slated for [v6.3](https://github.com/AASJournals/AASTeX60/milestone/2)?",
"title": "Shrink abstract width?",
"type": "issue"
},
{
"action": "created",
"author": "augustfly",
"comment_id": 319237988,
"datetime": 1501549254000,
"masked_author": "username_1",
"text": "thanks for pulling this out into a separate issue, @username_0 . \r\n\r\nit should be [v6.2](https://github.com/AASJournals/AASTeX60/milestone/1) (turns out that relabeling a milestone after you can't count isn't a seamless as I would have thought).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmccully",
"comment_id": 329992629,
"datetime": 1505593348000,
"masked_author": "username_2",
"text": "Thanks for opening this issue @username_0. Any word on this? I'm afraid I don't really even know where to start to address this myself.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pcubillos",
"comment_id": 331807701,
"datetime": 1506326969000,
"masked_author": "username_3",
"text": "Hi all, this hack worked for me (taken from aastex v6.0):\r\n```\r\n\\def\\abstractname{ABSTRACT}\r\n\\long\\def\\frontmatter@abstractheading{%\r\n \\begingroup\r\n \\centering\r\n \\abstractname\r\n \\vskip 1mm\r\n \\par\r\n \\endgroup\r\n % :::: HACK: set width of abstract ::::\r\n \\everypar{\\rightskip=0.5in\\leftskip=\\rightskip}\\par\r\n}%\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kadrlica",
"comment_id": 333941689,
"datetime": 1507056530000,
"masked_author": "username_0",
"text": "Thanks @username_3! I've created a pull requested based off of your hack from aastex v6.0. @username_2 you might be interested in this. @username_1 any word on when v6.2 is due?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmccully",
"comment_id": 334532217,
"datetime": 1507223782000,
"masked_author": "username_2",
"text": "Thanks @username_0. I am indeed using the newest version. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gregschwarz",
"comment_id": null,
"datetime": 1519417263000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 7 | 1,244 | false | false | 1,244 | true |
Zeex/sampgdk | null | 72,445,385 | 141 | {
"number": 141,
"repo": "sampgdk",
"user_login": "Zeex"
} | [
{
"action": "opened",
"author": "ikkentim",
"comment_id": null,
"datetime": 1430491135000,
"masked_author": "username_0",
"text": "I had built the project without any errors, yet I found out I had made some errors in a_actor.idl, then realized I hadn't found them before because I didn't add a_actor.idl to the make file \r\n:fearful: \r\n\r\nFixed all errors introduced in the previous pull request in this pull request.",
"title": "Fixed a syntax error in a_actor.idl introduced in the previous commit, added a_actor.idl to CMakeLists.txt",
"type": "issue"
},
{
"action": "created",
"author": "ikkentim",
"comment_id": 98152304,
"datetime": 1430493006000,
"masked_author": "username_0",
"text": "I also forgot to add the INVALID_ACTOR_ID constant :(",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Zeex",
"comment_id": 98171987,
"datetime": 1430497632000,
"masked_author": "username_1",
"text": "Wow, I didn't even notice you had a bad syntax there, I guess I'd make a terrible code reviewer. \r\n\r\nCould you also please move a_actors.inc to the beginning of the list in CMakeLists.txt while you're at it, to keep the files in alphabetical order?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ikkentim",
"comment_id": 98176427,
"datetime": 1430499116000,
"masked_author": "username_0",
"text": "Will do when I'm at my computer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Zeex",
"comment_id": 98197359,
"datetime": 1430504635000,
"masked_author": "username_1",
"text": "No worries, I can do that myself. Thanks again.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 664 | false | false | 664 | false |
nanoframework/Home | nanoframework | 311,655,896 | 303 | null | [
{
"action": "opened",
"author": "piwi1263",
"comment_id": null,
"datetime": 1522941683000,
"masked_author": "username_0",
"text": "## Details about Problem\r\nAfter the deployment of used assemblies of the application, those assemblies do almost always have the version of the application and not the assembly itself.\r\n\r\n## Detailed repro steps so we can see the same problem\r\n\r\n1. Add one package or more to your application, deploy to target and view in device explorer in the list of assemblies. You'll see the assemblies all are set to 1.0.0.0 only if the application version is set manually this version changes. The assembliy versions do stay on 1.0.0.0 although they are (mostly) of different versions.",
"title": "Incorrect version of assemblies during deploy",
"type": "issue"
},
{
"action": "created",
"author": "piwi1263",
"comment_id": 379469954,
"datetime": 1523108307000,
"masked_author": "username_0",
"text": "So why can't the extension pick up this info since it is display during deploy time and debug time and put in the output window ... if I understand this correctly we 'just' have to parse the packages.config file:\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josesimoes",
"comment_id": 379668708,
"datetime": 1523261057000,
"masked_author": "username_1",
"text": "What is showing in the assemblies list is coming from the device which has no idea what is packages.config.\r\nAs I've tried to explain the device is parsing the deployed assembly version with the custmary version info with format MAJOR.MINOR,REVISION and returns that. In case we need more than that, that return format has to be changed and the parsing too.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piwi1263",
"comment_id": 381431505,
"datetime": 1523820425000,
"masked_author": "username_0",
"text": "I could be wrong but when lauching in debug the output window state this version info, as it seems coming from the nf extension. So my idea is when the info is avail there, why can't the info be picked up at deploy time. \r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piwi1263",
"comment_id": 381433748,
"datetime": 1523822464000,
"masked_author": "username_0",
"text": "Ok, I've looked a bit deeper and I get your point as you stated above the version information is probably directly retrieved from the assemblies and the ones I've looked at are on 1.0.0.0. Closing this issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "piwi1263",
"comment_id": null,
"datetime": 1523822464000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 1,802 | false | false | 1,802 | false |
jchadwick/NuGet.Packer | null | 148,758,300 | 3 | null | [
{
"action": "opened",
"author": "sylvainlavoie",
"comment_id": null,
"datetime": 1460751519000,
"masked_author": "username_0",
"text": "in uGet.Packer.targets the path to Nuget.exe is defined to \r\n<NuGetToolsPath>$(SolutionDir)packages\\NuGet.CommandLine.3.3.0\\tools</NuGetToolsPath>\r\n\r\nHowever if a nuget.config file change the default location of the packages, the path can be wrong.\r\n\r\n<config>\r\n <add key=\"repositoryPath\" value=\"..\\..\\..\\Depends\\packages\" />\r\n </config>\r\n\r\nMaybe the solution should be in Nuget.CommandLine to define a property for is location",
"title": "NuGetToolsPath is hard coded and can be wrong",
"type": "issue"
},
{
"action": "created",
"author": "jchadwick",
"comment_id": 210629449,
"datetime": 1460751841000,
"masked_author": "username_1",
"text": "Agreed. Unfortunately, I don't own Nuget.CommandLine. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sylvainlavoie",
"comment_id": 211447341,
"datetime": 1460995517000,
"masked_author": "username_0",
"text": "you may also fix it in you package.\r\n<!-- NuGet command -->\r\n <NugetPackageRoot Condition=\" '$(NugetPackageRoot)'=='' \">$(MSBuildThisFileDirectory)..\\..\\</NugetPackageRoot>\r\n <NuGetToolsPath Condition=\" '$(NuGetToolsPath)'=='' \">$(NugetPackageRoot)NuGet.CommandLine.3.3.0\\tools</NuGetToolsPath>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jchadwick",
"comment_id": 211492975,
"datetime": 1461001174000,
"masked_author": "username_1",
"text": "Ah, I see where you're going now! That change looks great. Care to send a PR? :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sylvainlavoie",
"comment_id": 211501395,
"datetime": 1461002031000,
"masked_author": "username_0",
"text": "PR ?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jchadwick",
"comment_id": null,
"datetime": 1470623987000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 876 | false | false | 876 | false |
EdinburghGenomics/Reporting-App | EdinburghGenomics | 179,188,933 | 59 | null | [
{
"action": "opened",
"author": "mwhamgenomics",
"comment_id": null,
"datetime": 1474884758000,
"masked_author": "username_0",
"text": "When navigating to the Charts page on Safari, the following Javascript error occurs:\r\n`TypeError: undefined is not a function (evaluating 'Array.from(new Set(runs))')`\r\n\r\nThere is also no tab title or version number on the charts page - this would be fixed by going through the template rendering function defined in `reporting_app.__init__`, rather than `fl.render_template`.",
"title": "TypeError from charts.js on Safari",
"type": "issue"
},
{
"action": "created",
"author": "mwhamgenomics",
"comment_id": 249536384,
"datetime": 1474886322000,
"masked_author": "username_0",
"text": "Update: The problem is `Array.from`, which is supported on Safari 9, but not on Opera or Internet Explorer. Should just be able to fix the tab title/version number, and then this can be closed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tcezard",
"comment_id": 259656198,
"datetime": 1478773972000,
"masked_author": "username_1",
"text": "This has been fixed",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tcezard",
"comment_id": null,
"datetime": 1478773972000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 588 | false | false | 588 | false |
smtpd/qpsmtpd | smtpd | 58,775,984 | 234 | {
"number": 234,
"repo": "qpsmtpd",
"user_login": "smtpd"
} | [
{
"action": "opened",
"author": "jaredj",
"comment_id": null,
"datetime": 1424800346000,
"masked_author": "username_0",
"text": "",
"title": "Add perms test to Qpsmtpd::DB::File::DBM::dir()",
"type": "issue"
},
{
"action": "created",
"author": "jaredj",
"comment_id": 75985080,
"datetime": 1424879570000,
"masked_author": "username_0",
"text": "This is ready except for the question of what to do when one of the default 'candidate directory' locations exists but is not writeable. We currently skip such a directory with no warning. It has been suggested to warn on this condition, however because of the (perhaps convoluted) way that we search for valid directories, this could lead to problems:\r\n\r\n1. static directories /dir1/ and /dir2/ are being searched\r\n2. /dir1/ has been unwriteable for months, so /dir2/greylist.dbm is being used\r\n3. the admin notices a warning about /dir1/ being unwriteable, and \"fixes\" it with a chmod\r\n4. the greylist plugin begins ignoring /dir2/greylist.dbm, creating a fresh new database in /dir1/, and suddenly greylisting a bunch of new systems and potentially causing mail flow interruption",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "msimerson",
"comment_id": 77898343,
"datetime": 1425921295000,
"masked_author": "username_1",
"text": "Then warn of that possibility. Not warning about existing (possibly used) dirs and letting the sysadmin do something more intelligent than you can automate is **likely** the type of silent error that's could lead to the scenario you describe.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaredj",
"comment_id": 77899774,
"datetime": 1425921729000,
"masked_author": "username_0",
"text": "I think I can come up with something.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaredj",
"comment_id": 77980101,
"datetime": 1425951231000,
"masked_author": "username_0",
"text": "Something seems to be broken with Coveralls preventing Travis from functioning correctly. This does pass manual travis, though",
"title": null,
"type": "comment"
}
] | 3 | 10 | 2,629 | false | true | 1,190 | false |
Sitefinity/feather | Sitefinity | 70,429,398 | 1,443 | null | [
{
"action": "opened",
"author": "dzhenko",
"comment_id": null,
"datetime": 1429800019000,
"masked_author": "username_0",
"text": "",
"title": "Blog post: Add documentation about blog post widget.",
"type": "issue"
},
{
"action": "created",
"author": "ElenaGaneva",
"comment_id": 95854349,
"datetime": 1429865034000,
"masked_author": "username_1",
"text": "https://github.com/Sitefinity/feather-docs/wiki/Blog-post-widget",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mariushm",
"comment_id": null,
"datetime": 1447317159000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 64 | false | false | 64 | false |
saltstack/salt | saltstack | 56,593,033 | 20,401 | {
"number": 20401,
"repo": "salt",
"user_login": "saltstack"
} | [
{
"action": "opened",
"author": "jacksontj",
"comment_id": null,
"datetime": 1423086627000,
"masked_author": "username_0",
"text": "",
"title": "Misc backports to 2015.2",
"type": "issue"
},
{
"action": "created",
"author": "jacksontj",
"comment_id": 73076965,
"datetime": 1423153822000,
"masked_author": "username_0",
"text": "@rallytime test failure is unrelated, can we get this merged in? I just want to make sure its in before the release is cut-- since these are stability fixes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cachedout",
"comment_id": 73088275,
"datetime": 1423157216000,
"masked_author": "username_1",
"text": "Merged! Thanks as always. :]",
"title": null,
"type": "comment"
}
] | 2 | 3 | 185 | false | false | 185 | false |
packpack/packpack | packpack | 188,092,529 | 9 | null | [
{
"action": "opened",
"author": "rtsisyk",
"comment_id": null,
"datetime": 1478636149000,
"masked_author": "username_0",
"text": "Probably `sudo -E -u $USER \\$@\";` in generated userwrapper.sh overwrites HOME variable.",
"title": "warning: failed to open configuration file '/root/.dpkg.cfg' for reading: Permission denied",
"type": "issue"
},
{
"action": "created",
"author": "gdevenyi",
"comment_id": 259268037,
"datetime": 1478641188000,
"masked_author": "username_1",
"text": "Related?\r\n\r\n```\r\nwarning: unable to access '/root/.config/git/attributes': Permission denied\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "benoit-pierre",
"comment_id": 259270020,
"datetime": 1478641676000,
"masked_author": "username_2",
"text": "I get some similar issues when using snapcraft, this can be fixed by adding `-H` to the sudo command line:\r\n```diff\r\ndiff --git i/packpack w/packpack\r\nindex 21bf514..163650b 100755\r\n--- i/packpack\r\n+++ w/packpack\r\n@@ -87,7 +87,7 @@ echo \"sudo useradd -u $(id -u) $USER\";\r\n echo \"sudo usermod -a -G sudo $USER 2>/dev/null || :\";\r\n echo \"sudo usermod -a -G wheel $USER 2>/dev/null || :\";\r\n echo \"sudo usermod -a -G adm $USER 2>/dev/null || :\";\r\n-echo \"sudo -E -u $USER \\$@\";\r\n+echo \"sudo -E -H -u $USER \\$@\";\r\n ) > ${BUILDDIR}/userwrapper.sh\r\n chmod a+x ${BUILDDIR}/userwrapper.sh\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rtsisyk",
"comment_id": null,
"datetime": 1478807754000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 768 | false | false | 768 | false |
tflearn/tflearn | tflearn | 186,187,778 | 425 | null | [
{
"action": "opened",
"author": "bcarpenter-pub",
"comment_id": null,
"datetime": 1477880158000,
"masked_author": "username_0",
"text": "It appears as the upscore layer is intended to upscore a feature map. Similiar to how the Deconv and Bilinear keral works in Caffe.\r\n\r\nhttp://caffe.berkeleyvision.org/doxygen/classcaffe_1_1BilinearFiller.html\r\n\r\nTheir implementation mentions that the usage of Deconv (i.e. conv2d_transpose + bilinear kernel) should be the same as performing the following on an input image\r\n\r\n```\r\nimport skimage.transform\r\nplt.imshow(skimage.transform.rescale(image[:,:,0], 2, mode='constant', cval=0))\r\n```\r\n\r\nIf the upscore implementation is intended to behave in a similar way, it does not. Passing an image through this layer to upsample to twice the size results in noise.\r\n\r\nThe reason for this is that for an input with C_i channels, output with C_o channels, and stride of S, the layer creates a kernel of size [S,S,C_i,C_o]\r\n\r\nThis successfully works with tensorflows conv2d_transpose function, however as a result the kernal does not bi-linear filter each channel of the input to create an output, instead it sums over all channels of the input to create one of the output channels. \r\n\r\nIn order to make this layer work properly, the input object should be unpacked along the channels dimension. Each channel should be conv2d_transposed with a kernel of size [S,S,1, 1] and then the resulting maps should be packed back into an output of size [B H W C_o]\r\n\r\n** Note **\r\n\r\nThis is not a very elegant solution due to the unpacking and packing, but it is unclear how to get this functionality out of the tf.conv2d_transpose function.",
"title": "Upscore implementation may not perform as intended.",
"type": "issue"
},
{
"action": "created",
"author": "bcarpenter-pub",
"comment_id": 257413862,
"datetime": 1477946365000,
"masked_author": "username_0",
"text": "actually, i realize I am wrong. The current implementation is correct as it is being used with the tensorflow conv2d_transpose which does a convolution across all channels. The current creation of the filiter accounts for this as to only enable per channel upsampling. Good job all! :D",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bcarpenter-pub",
"comment_id": null,
"datetime": 1477946365000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 1,818 | false | false | 1,818 | false |
blazer82/meteor-casperjs | null | 53,985,130 | 6 | null | [
{
"action": "opened",
"author": "laosb",
"comment_id": null,
"datetime": 1420962741000,
"masked_author": "username_0",
"text": "\r\nNo time..... It seems a bug...",
"title": "Time is not recorded in velocity:html-reporter",
"type": "issue"
},
{
"action": "created",
"author": "logankoester",
"comment_id": 69493004,
"datetime": 1420979651000,
"masked_author": "username_1",
"text": "Same here.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 151 | false | false | 151 | false |
armon/statsite | null | 67,569,634 | 123 | null | [
{
"action": "opened",
"author": "filippog",
"comment_id": null,
"datetime": 1428663762000,
"masked_author": "username_0",
"text": "hi,\r\nlooks like `str2double` doesn't support parsing numbers in scientific notation, e.g. diamond would send metrics like this `diskspace._var.byte_used:7.72529e+11|g` and gets parsed to `7.72529`",
"title": "support parsing scientific notation doubles",
"type": "issue"
},
{
"action": "created",
"author": "armon",
"comment_id": 91624349,
"datetime": 1428685900000,
"masked_author": "username_1",
"text": "Is this a format statsd supports? I didn't realize this was valid input",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "filippog",
"comment_id": 91634838,
"datetime": 1428688076000,
"masked_author": "username_0",
"text": "I think so, yeah:\r\n\r\n```\r\n gauges: \r\n { 'diskspace._var.byte_used': 772529000000,\r\n```\r\nalso\r\n```\r\n { 'diskspace.ar.bytesed': 1.72529e-9,\r\n```\r\n\r\nboth `1.23e-4` and `1.23e-04` seem recognized and case doesn't matter like `strtod`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "armon",
"comment_id": 91642217,
"datetime": 1428689799000,
"masked_author": "username_1",
"text": "Interesting. I found that strtod introduced a large performance penalty in the parser, so maybe I will just add an unlikely path to detect the `e` and jump out to strtod.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "filippog",
"comment_id": 92304060,
"datetime": 1428921658000,
"masked_author": "username_0",
"text": "sth like in #124 ?\r\n\r\nrelated to this, what would be a good way to test static functions with check? `#include 'conn_handler.c'` comes to mind but then conditionally include `conn_handler.h` inside to avoid the double definition?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theatrus",
"comment_id": 96132470,
"datetime": 1429939292000,
"masked_author": "username_2",
"text": "Curious under what circumstances you had worse performance with strtod - all of my testing has shown a 15% penalty to str2double.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "armon",
"comment_id": 101444847,
"datetime": 1431470021000,
"masked_author": "username_1",
"text": "Fixed by #124. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "armon",
"comment_id": null,
"datetime": 1431470021000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 8 | 1,050 | false | false | 1,050 | false |
dercoder/omnipay-paysafecard | null | 134,992,731 | 2 | null | [
{
"action": "opened",
"author": "MHaendel",
"comment_id": null,
"datetime": 1455921442000,
"masked_author": "username_0",
"text": "Could someone please add it, as its a required by paysafecard.",
"title": "Add Support for Notify",
"type": "issue"
},
{
"action": "created",
"author": "dercoder",
"comment_id": 186509758,
"datetime": 1455944045000,
"masked_author": "username_1",
"text": "Please explain this \"function\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MHaendel",
"comment_id": 187129562,
"datetime": 1456140242000,
"masked_author": "username_0",
"text": "Paysafecards sends a callback to the okUrl, it should execute getSerialNumbers and if it aint captured, executeDebit. This gateway is missing support, due to the lack of support of callbacks by omnipay until recently.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dercoder",
"comment_id": 187223450,
"datetime": 1456153811000,
"masked_author": "username_1",
"text": "Use \"completePurchase\" also for okUrl. This should work.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dercoder",
"comment_id": null,
"datetime": 1465396326000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 365 | false | false | 365 | false |
appium/appium | appium | 47,682,947 | 3,964 | {
"number": 3964,
"repo": "appium",
"user_login": "appium"
} | [
{
"action": "opened",
"author": "sebv",
"comment_id": null,
"datetime": 1415083301000,
"masked_author": "username_0",
"text": "Goes round `Invalid message _rpc_applicationUpdated` error by killing/restarting proxy process.\r\n\r\n@jlipps is it ok to add that, (Still needs documenting)",
"title": "ios-webkit-debug-proxy launcher",
"type": "issue"
},
{
"action": "created",
"author": "MJanach",
"comment_id": 85228520,
"datetime": 1427149059000,
"masked_author": "username_1",
"text": "I'm getting a similar error to the one this fix was designed for (I think). But I'm on Appium 1.3.6. I am facing the same error mentioned here: https://discuss.appium.io/t/safari-on-ios-ios-webkit-debug-crashing-when-safarilauncher-launches-safari/1208",
"title": null,
"type": "comment"
}
] | 2 | 2 | 408 | false | false | 408 | false |
MetacoSA/NBitcoin | MetacoSA | 49,004,934 | 39 | null | [
{
"action": "opened",
"author": "dthorpe",
"comment_id": null,
"datetime": 1416159156000,
"masked_author": "username_0",
"text": "Why does TransactionBuilder.BuildTransaction call itself recursively after the change amount has been determined? The recursive call repeats the coin selection process, but (should) always arrive at the same result (same coin selection) as the first call.",
"title": "Recursive BuildTransaction for change",
"type": "issue"
},
{
"action": "created",
"author": "NicolasDorier",
"comment_id": 135370450,
"datetime": 1440670086000,
"masked_author": "username_1",
"text": "@username_0 do I close it ? it is gathering dust :p",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dthorpe",
"comment_id": 135502457,
"datetime": 1440697078000,
"masked_author": "username_0",
"text": "It still seems redundant. In debugging through that fn, I've never seen it make any decisions that weren't already decided in the caller. But, my code may not cover all the cases that fn is intended to cover.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NicolasDorier",
"comment_id": 242616550,
"datetime": 1472181007000,
"masked_author": "username_1",
"text": "Closing it, was opened 2 years ago, and not really an issue. :p",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "NicolasDorier",
"comment_id": null,
"datetime": 1472181007000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 576 | false | false | 576 | true |
stkb/Rewrap | null | 275,510,547 | 55 | null | [
{
"action": "opened",
"author": "mmorearty",
"comment_id": null,
"datetime": 1511214585000,
"masked_author": "username_0",
"text": "As described [here](https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#supported-by-a-limited-number-of-editors), editorconfig supports `max_line_length`. It would be nice if Reflow had the ability to use that to determine max line length.",
"title": "Feature request: support for editorconfig max_line_length",
"type": "issue"
},
{
"action": "created",
"author": "stkb",
"comment_id": 346892303,
"datetime": 1511555131000,
"masked_author": "username_1",
"text": "Hi, sorry I didn't get a notification for this, for whatever reason.\r\n\r\nYes that should be possible. Are you using the VSCode or the Visual Studio version?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mmorearty",
"comment_id": 346919898,
"datetime": 1511587052000,
"masked_author": "username_0",
"text": "I’m on the VSCode version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stkb",
"comment_id": 346963009,
"datetime": 1511640513000,
"masked_author": "username_1",
"text": "Thanks. The reason I ask is because I wonder whether it would be better to ask for an extra feature from the [editorConfig extension](https://github.com/editorconfig/editorconfig-vscode) that takes the `max_line_length` value and creates an `editor.rulers` setting in the workspace `settings.json` file. The ruler would then be a helpful guide in the editor and Rewrap can already use rulers anyway.\r\n\r\nI see there was a already an issue in editorconfig/editorconfig-vscode#53 but although the editor.rulers solution was mentioned there it wasn't really discussed; it was mostly about soft-wrapping.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,042 | false | false | 1,042 | false |
redcanaryco/cb-response-surveyor | redcanaryco | 170,221,255 | 1 | {
"number": 1,
"repo": "cb-response-surveyor",
"user_login": "redcanaryco"
} | [
{
"action": "opened",
"author": "MHaggis",
"comment_id": null,
"datetime": 1470762853000,
"masked_author": "username_0",
"text": "Adding multiple definition files for:\r\nAnonymizers\r\nbittorrent\r\ncracks_keygens\r\ncritical_processes\r\nbitcoin miners\r\nproxies, intercepts\r\nscreensaver bypass\r\nsysinternals suite",
"title": "New definition files",
"type": "issue"
},
{
"action": "created",
"author": "redcanary-it",
"comment_id": 238835912,
"datetime": 1470827336000,
"masked_author": "username_1",
"text": "In general, do we want to get into the business of maintaining past and\nfuture hashes for some of these items? I believe that I understand why\nthey're present, but given that these are survey definitions as opposed to\ndetection criteria, I think that we may be signing up for unnecessary\nmaintenance.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "redcanary-it",
"comment_id": 239368042,
"datetime": 1470981960000,
"masked_author": "username_1",
"text": "It occurred to me that you might not get emails from Github when I reply to\nthese. I've no idea how that works.\n\nAnyway, see below :)\n\nOn Wed, Aug 10, 2016, 7:08 AM Keith McCammon <keith@redcanary.com> wrote:\n\n> In general, do we want to get into the business of maintaining past and\n> future hashes for some of these items? I believe that I understand why\n> they're present, but given that these are survey definitions as opposed to\n> detection criteria, I think that we may be signing up for unnecessary\n> maintenance.\n>\n>\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MHaggis",
"comment_id": 240715914,
"datetime": 1471525333000,
"masked_author": "username_0",
"text": "Correct. Makes sense to start now without MD5's before we get too deep and unable to manage. \r\nRemoved MD5's.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MHaggis",
"comment_id": 241103272,
"datetime": 1471632615000,
"masked_author": "username_0",
"text": "Two new definition files added:\r\nNetwork sniffers\r\nNetwork scanners",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "keithmccammon",
"comment_id": 244191005,
"datetime": 1472759261000,
"masked_author": "username_2",
"text": "This is a test comment. Ignore.",
"title": null,
"type": "comment"
}
] | 3 | 6 | 1,208 | false | false | 1,208 | false |
klinker41/android-chips | null | 48,722,304 | 3 | null | [
{
"action": "opened",
"author": "srcreigh",
"comment_id": null,
"datetime": 1415931777000,
"masked_author": "username_0",
"text": "Hi, it doesn't seem like `android-chips` would need any ProGuard configuration. Can you confirm this? Thanks!",
"title": "ProGuard configuration",
"type": "issue"
},
{
"action": "created",
"author": "MariusVolkhart",
"comment_id": 125239012,
"datetime": 1438009508000,
"masked_author": "username_1",
"text": "@username_0 we've not had to modify our proguard config and it's working fine for us so far",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "klinker24",
"comment_id": null,
"datetime": 1477601038000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "klinker24",
"comment_id": 256763524,
"datetime": 1477601062000,
"masked_author": "username_2",
"text": "ProGuard config won't be necessary, no.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 237 | false | false | 237 | true |
Wizcorp/phonegap-facebook-plugin | Wizcorp | 127,221,821 | 1,211 | {
"number": 1211,
"repo": "phonegap-facebook-plugin",
"user_login": "Wizcorp"
} | [
{
"action": "opened",
"author": "jeffplourde",
"comment_id": null,
"datetime": 1453121937000,
"masked_author": "username_0",
"text": "per 4.0.0 [API Changes](https://github.com/apache/cordova-ios/blob/master/guides/API%20changes%20in%204.0.md#upgrade-notes-1) document",
"title": "Cordova iOS 4.0.x compatibility",
"type": "issue"
},
{
"action": "created",
"author": "mcelligottnick",
"comment_id": 179726057,
"datetime": 1454577504000,
"masked_author": "username_1",
"text": "+1 tested and works.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EddyVerbruggen",
"comment_id": 180010851,
"datetime": 1454613723000,
"masked_author": "username_2",
"text": "Yep, looks good!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrewb273",
"comment_id": 203715362,
"datetime": 1459389667000,
"masked_author": "username_3",
"text": "Can this not be simplified, as per: https://github.com/Wizcorp/phonegap-facebook-plugin/issues/1222#issuecomment-203714705 ?",
"title": null,
"type": "comment"
}
] | 4 | 4 | 294 | false | false | 294 | false |
bootstrap-vue/bootstrap-vue | bootstrap-vue | 223,793,473 | 276 | null | [
{
"action": "opened",
"author": "kollors",
"comment_id": null,
"datetime": 1493034696000,
"masked_author": "username_0",
"text": "When I copy example (https://jsfiddle.net/username_3/bofh9aaa) locally, it does not work on bootstrap 4.0.0-alpha.6 and bootstrap-vue 0.14.0. I get only a blackout of body.",
"title": "Modal window does not work",
"type": "issue"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 296777124,
"datetime": 1493057698000,
"masked_author": "username_1",
"text": "There might have been some changes to the new V4-alpha-6 classes.\r\n\r\nI will check on this later today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 296781630,
"datetime": 1493058440000,
"masked_author": "username_2",
"text": "It seems that you do soomething wrong, as jsfiddle uses bootstrap 4.0.0-alpha.6 and bootstrap-vue 0.14.0. So there's cannot be any new classes or whatever.\r\nShow your failing files please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 296783103,
"datetime": 1493058775000,
"masked_author": "username_1",
"text": "@username_2, true, I just checked that the original fiddle is working with V4-alpha-6",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kollors",
"comment_id": 296908724,
"datetime": 1493096750000,
"masked_author": "username_0",
"text": "**package.json**\r\n```javascript\r\n{\r\n \"name\": \"vue-seed\",\r\n \"version\": \"0.0.1\",\r\n \"scripts\": {\r\n \"build\": \"NODE_ENV=production webpack --progress\",\r\n \"postinstall\": \"bower i -F && typings i\",\r\n \"server:development\": \"HOST=$(hostname -I | grep -o '[0-9.]*' | head -1) npm run server:localhost\",\r\n \"server:localhost\": \"webpack-dev-server --progress\",\r\n \"start\": \"npm run server:localhost\",\r\n \"update\": \"ncu -a --packageFile package.json && ncu -a -m bower --packageFile bower.json\"\r\n },\r\n \"dependencies\": {\r\n \"bootstrap\": \"^4.0.0-alpha.6\",\r\n \"bootstrap-vue\": \"^0.14.0\",\r\n \"font-awesome\": \"^4.7.0\",\r\n \"jquery\": \"^3.2.1\",\r\n \"jquery-ui-dist\": \"^1.12.1\",\r\n \"socket.io-client\": \"^1.7.3\",\r\n \"vue\": \"^2.2.6\",\r\n \"vue-resource\": \"^1.3.1\",\r\n \"vue-router\": \"^2.5.1\",\r\n \"vuex\": \"^2.3.1\"\r\n },\r\n \"devDependencies\": {\r\n \"babel-core\": \"^6.24.1\",\r\n \"babel-loader\": \"^7.0.0\",\r\n \"babel-plugin-transform-class-properties\": \"^6.24.1\",\r\n \"babel-plugin-transform-flow-strip-types\": \"^6.22.0\",\r\n \"babel-plugin-transform-runtime\": \"^6.23.0\",\r\n \"babel-preset-env\": \"^1.4.0\",\r\n \"babel-preset-stage-3\": \"^6.24.1\",\r\n \"copy-webpack-plugin\": \"^4.0.1\",\r\n \"css-loader\": \"^0.28.0\",\r\n \"debug\": \"^2.6.4\",\r\n \"extract-text-webpack-plugin\": \"^2.1.0\",\r\n \"file-loader\": \"^0.11.1\",\r\n \"html-loader\": \"^0.4.5\",\r\n \"html-webpack-plugin\": \"^2.28.0\",\r\n \"node-sass\": \"^4.5.2\",\r\n \"postcss\": \"^5.2.17\",\r\n \"postcss-cssnext\": \"^2.10.0\",\r\n \"postcss-loader\": \"^1.3.3\",\r\n \"rimraf\": \"^2.6.1\",\r\n \"sass-loader\": \"^6.0.3\",\r\n \"style-loader\": \"^0.16.1\",\r\n \"url-loader\": \"^0.5.8\",\r\n \"vue-loader\": \"^11.3.4\",\r\n \"vue-template-compiler\": \"^2.2.6\",\r\n \"webpack\": \"^2.4.1\",\r\n \"webpack-dev-server\": \"^2.4.4\"\r\n }\r\n}\r\n```\r\n**index.html**\r\n```html\r\n<!doctype html>\r\n<html lang=\"ru\">\r\n<head>\r\n <meta charset=\"UTF-8\">\r\n <meta name=\"viewport\" content=\"width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0\">\r\n <meta http-equiv=\"X-UA-Compatible\" content=\"ie=edge\">\r\n <title>vue-seed</title>\r\n <link rel=\"icon\" data-href=\"favicon.png\" type=\"image/x-icon\">\r\n <base href=\"/\">\r\n</head>\r\n<body>\r\n<div id=\"app\">\r\n <b-btn @click=\"$root.$emit('show::modal','modal1')\">Launch demo modal</b-btn>\r\n\r\n <!-- Main UI -->\r\n <div class=\"mt-3 mb-3\">\r\n Submitted Names:\r\n <ul>\r\n <li v-for=\"n in names\">{{n}}</li>\r\n </ul>\r\n </div>\r\n\r\n <!-- Modal Component -->\r\n <b-modal id=\"modal1\" title=\"Submit your name\" @ok=\"submit\" @shown=\"clearName\">\r\n\r\n <form @submit.stop.prevent=\"submit\">\r\n <b-form-input type=\"text\" placeholder=\"Enter your name\" v-model=\"name\"></b-form-input>\r\n </form>\r\n\r\n </b-modal>\r\n</div>\r\n<!--<router-view id=\"app\"></router-view>-->\r\n</body>\r\n</html>\r\n```\r\n**index.js**\r\n```javascript\r\nVue.use(BootstrapVue/*, VueResource, VueRouter, Vuex*/);\r\n\r\nwindow.app = new Vue({\r\n el: '#app',\r\n data: {\r\n name: '',\r\n names: []\r\n },\r\n methods: {\r\n clearName() {\r\n this.name = '';\r\n },\r\n submit() {\r\n if (!this.name) {\r\n alert('Please enter your name');\r\n return e.cancel();\r\n }\r\n\r\n this.names.push(this.name);\r\n this.name = '';\r\n }\r\n }\r\n});\r\n```\r\n**vendor.js**\r\n```javascript\r\nrequire('jquery');\r\nrequire('jquery-ui-dist/jquery-ui');\r\nrequire('bootstrap');\r\n\r\nwindow.Vue = require('vue');\r\n/*window.VueRouter = require('vue-router/dist/vue-router');\r\nwindow.VueResource = require('vue-resource');\r\nwindow.Vuex = require('vuex');*/\r\nwindow.BootstrapVue = require('bootstrap-vue');\r\n\r\nwindow.requireAll = requireContext => requireContext.keys().map(requireContext);\r\nwindow.io = require('socket.io-client/dist/socket.io');\r\nwindow.compose = (...fns) => value => fns.reduce((v, fn) => fn(v), value);\r\n\r\nrequire('./vendor.scss');\r\n```\r\n\r\n**vendor.scss**\r\n```css\r\n@import '~jquery-ui-dist/jquery-ui.theme.css';\r\n@import '~bootstrap/scss/bootstrap';\r\n@import '~bootstrap-vue/dist/bootstrap-vue.css';\r\n@import '~font-awesome/css/font-awesome.css';\r\n```\r\n\r\n**webpack.confog.json**\r\n```javascript\r\nprocess.env.NODE_ENV = process.env.NODE_ENV || 'development';\r\nprocess.env.HOST = process.env.HOST || 'localhost';\r\nprocess.env.PORT = process.env.PORT || '8001';\r\n\r\nconst path = require('path');\r\nconst rimraf = require('rimraf');\r\n\r\nconst CommonsChunkPlugin = require('webpack/lib/optimize/CommonsChunkPlugin');\r\nconst HtmlWebpackPlugin = require('html-webpack-plugin');\r\nconst CopyWebpackPlugin = require('copy-webpack-plugin');\r\nconst ExtractTextPlugin = require('extract-text-webpack-plugin');\r\nconst ProvidePlugin = require('webpack/lib/ProvidePlugin');\r\nconst DefinePlugin = require('webpack/lib/DefinePlugin');\r\nconst UglifyJsPlugin = require('webpack/lib/optimize/UglifyJsPlugin');\r\n\r\nconst paths = {\r\n context: path.join(__dirname, 'sources'),\r\n dist: path.join(__dirname, 'dist'),\r\n static: path.join(__dirname, 'static')\r\n};\r\n\r\nconst devHash = process.env.NODE_ENV == 'development' ? '.[hash]' : '';\r\n\r\nconst webpackConfig = {\r\n context: paths.context,\r\n entry: {\r\n vendor: './vendor',\r\n app: './app'\r\n },\r\n output: {\r\n path: paths.dist,\r\n publicPath: '/',\r\n filename: path.join('assets', `[name]${devHash}.bundle.js`),\r\n chunkFilename: path.join('assets', `[name]${devHash}.chunk.js`)\r\n },\r\n resolve: {\r\n modules: ['bower_components', 'node_modules'],\r\n descriptionFiles: ['bower.json', 'package.json'],\r\n extensions: ['.js', '.json', '.vue'],\r\n alias: {\r\n vue: 'vue/dist/vue.js'\r\n }\r\n },\r\n module: {\r\n exprContextCritical: false,\r\n rules: [\r\n {\r\n test: /\\.js$/,\r\n exclude: /(bower_components|node_modules)/,\r\n loader: 'babel-loader'\r\n },\r\n {\r\n test: /\\.html$/,\r\n loader: 'html-loader'\r\n },\r\n {\r\n test: /\\.vue$/,\r\n loader: 'vue-loader'\r\n },\r\n {\r\n test: /\\.css$/,\r\n loader: ExtractTextPlugin.extract({\r\n fallback: 'style-loader',\r\n use: 'css-loader!postcss-loader'\r\n })\r\n },\r\n {\r\n test: /\\.s[ac]ss$/,\r\n loader: ExtractTextPlugin.extract({\r\n fallback: 'style-loader',\r\n use: 'css-loader!postcss-loader!sass-loader'\r\n })\r\n },\r\n {\r\n test: /\\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico)([?]?.*)$/,\r\n loader: 'url-loader',\r\n options: {\r\n limit: '100000', // > 100kb -> file\r\n name: path.join('assets', `[name]${devHash}.[ext]`)\r\n }\r\n }\r\n ]\r\n },\r\n plugins: [\r\n {\r\n apply: compiler => (rimraf.sync(compiler.options.output.path))\r\n },\r\n new CommonsChunkPlugin({\r\n name: ['app', 'vendor'],\r\n minChunks: 2\r\n }),\r\n new HtmlWebpackPlugin({\r\n template: path.join(paths.context, 'index.html')\r\n }),\r\n new CopyWebpackPlugin([{\r\n from: paths.static\r\n }]),\r\n new ExtractTextPlugin({\r\n filename: path.join('assets', `[name]${devHash}.bundle.css`),\r\n allChunks: true\r\n }),\r\n new ProvidePlugin({\r\n jQuery: 'jquery',\r\n Tether: 'tether'\r\n }),\r\n new DefinePlugin({\r\n 'process.env': JSON.stringify(process.env)\r\n })\r\n ]\r\n};\r\n\r\nif (process.env.NODE_ENV == 'development') {\r\n webpackConfig.devServer = {\r\n contentBase: paths.dist,\r\n host: process.env.HOST,\r\n port: parseInt(process.env.PORT),\r\n stats: 'minimal',\r\n historyApiFallback: true\r\n };\r\n\r\n webpackConfig.devtool = 'source-map';\r\n webpackConfig.watch = true;\r\n}\r\n\r\nif (process.env.NODE_ENV == 'production') {\r\n webpackConfig.plugins.push(new UglifyJsPlugin({\r\n compress: {\r\n warnings: false,\r\n drop_console: true\r\n }\r\n }));\r\n}\r\n\r\nmodule.exports = webpackConfig;\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 296926376,
"datetime": 1493101554000,
"masked_author": "username_2",
"text": "Can't build your proj.. seems im lacking of a folder struct :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 296929564,
"datetime": 1493102382000,
"masked_author": "username_2",
"text": "try to remove jquery and bootstrap importing. they don't needed with vue+bootstrap-vue",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pi0",
"comment_id": 296933533,
"datetime": 1493103533000,
"masked_author": "username_3",
"text": "Also it seems no js file in included in `index.html`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nerdalertdk",
"comment_id": 297248228,
"datetime": 1493186959000,
"masked_author": "username_4",
"text": "Yes, its not me that's crazy\r\nFound out the display is set to none for .modal\r\n\r\nif i unclick it in Chrome inspecter i shows.\r\n\r\n\r\n\r\n\r\n```\r\n.modal {\r\n position: fixed;\r\n top: 0;\r\n right: 0;\r\n bottom: 0;\r\n left: 0;\r\n z-index: 1050;\r\n display: none;\r\n overflow: hidden;\r\n outline: 0;\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 297252149,
"datetime": 1493188061000,
"masked_author": "username_2",
"text": "it's strange, because this must be fixed by `.modal{display:block}` rule in `bootstrap-vue/dist/bootstrap-vue.css`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pi0",
"comment_id": 297258607,
"datetime": 1493190081000,
"masked_author": "username_3",
"text": "@username_4 Can you please create and share us a repo which can be used to reproduce that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nerdalertdk",
"comment_id": 297419449,
"datetime": 1493215596000,
"masked_author": "username_4",
"text": "Hi\r\n\r\nSince I use Coreui as style framework I don't thinit will help, fixed it by add .modal .show { display:block;}\r\n\r\nSo think it bootstrap related since both this and coreui have the bug",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 297767401,
"datetime": 1493310371000,
"masked_author": "username_2",
"text": "@username_0 , once more, if you don't need of the original Bootstrap js in your project, try to remove it and check the issue, please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 298074823,
"datetime": 1493404629000,
"masked_author": "username_5",
"text": "Having the same issue. Not sure why the lib's `.modal{display:block;}` css is loading after the bootstrap css despite importing it last. I just fixed it by adding the d-block in yet another bunch of css that was loaded after bs & bs-vue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 298079651,
"datetime": 1493405804000,
"masked_author": "username_5",
"text": "P.S. Mad props for removing the jQuery + Tether dependencies native to bootstrap!!!!! Got so excited when I read that. \n\nMany people may be coming from my position--normal bootstrap app, then add Vue, then add bootstrap-vue. This might be a good documentation addition: migrating plain bootstrap app to bootstrap-vue. Sounds like a short section (just remove bootstrap.js and it's dependencies if you're not using them, and add css), but could save some little gotchas and potential non-issues.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pi0",
"comment_id": 298080888,
"datetime": 1493406143000,
"masked_author": "username_3",
"text": "@username_5 Happy hearing problem fixed :) If you can add some notes about that in `docs/setup.md` \r\n file we can add it to docs helping others :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 298082955,
"datetime": 1493406699000,
"masked_author": "username_5",
"text": "I'll check it out and submit a PR!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 298083942,
"datetime": 1493406975000,
"masked_author": "username_5",
"text": "It looks like you're referring to the GitHub pages repository. House is that built? Plain html?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pi0",
"comment_id": 298084315,
"datetime": 1493407079000,
"masked_author": "username_3",
"text": "@username_5 Docs are written in Markdown (https://github.com/bootstrap-vue/bootstrap-vue/blob/master/docs/SETUP.md) and will be rendered/published to gh-pages.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 298085823,
"datetime": 1493407507000,
"masked_author": "username_5",
"text": "Sweet! I'm on my phone at the moment, so it can be hard to tell. Thanks again for the awesome lib!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kollors",
"comment_id": 298148515,
"datetime": 1493443812000,
"masked_author": "username_0",
"text": "Yes, it all worked after I replacedbootstrap/scss/bootstrap on bootstrap/dist/css/bootstrap.css. Original bootstrap.js, Tether and jQuery is left",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300013527,
"datetime": 1494284078000,
"masked_author": "username_1",
"text": "So is everything working correctly now?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kollors",
"comment_id": 300081889,
"datetime": 1494314285000,
"masked_author": "username_0",
"text": "Only if you include bootstrap.css, not bootstrap.scss",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300219853,
"datetime": 1494346943000,
"masked_author": "username_5",
"text": "I second that. I'm pulling in the bootstrap scss file *before* I pull in the bootstrap-vue css, and I have to manually add the same `.modal { display: block; }` rule again. Perhaps that is a webpack loader issue—when mixing scss and css together the order may not be guaranteed or configurable (or most likely I don't have the correct webpack config to load in the right order).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300243101,
"datetime": 1494351290000,
"masked_author": "username_1",
"text": "Maybe if the modal CSS in the `modal.vue` component used scoped CSS? which would ensure that the display block applied to the modal?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300246868,
"datetime": 1494352022000,
"masked_author": "username_5",
"text": "That actually seems like a smart move to avoid collisions for any `.modal` stylings.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300248249,
"datetime": 1494352287000,
"masked_author": "username_1",
"text": "Scoped CSS does have it's shortcomings (doesn't always fix everything), but it might work in this case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300248993,
"datetime": 1494352437000,
"masked_author": "username_5",
"text": "I'm certainly no expert on css, but I know that our offending css rule here is a flat class. Scoped css should offer enough specificity to create a sure override.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300249281,
"datetime": 1494352495000,
"masked_author": "username_1",
"text": "OR... rather than using `v-show` to show/hide the modal, we switch to `v-if` to avoid the `style=\"display: block;\"` / `style=\"display: none;\"` being applied/removed from the modal",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300251002,
"datetime": 1494352827000,
"masked_author": "username_5",
"text": "That might be nice. If the modal is never called into commission, it doesn't add any weight to your dom. I'm in favor of a lazy-injected modal.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300252796,
"datetime": 1494353174000,
"masked_author": "username_1",
"text": "Actually the current `modal.vue` component is using scoped CSS.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300256112,
"datetime": 1494353848000,
"masked_author": "username_5",
"text": "Weird that I see none of the data-<hash> attributes on anything. I'm using v0.15.5, and I see it in the lib components file. Does it get stripped out at build, or is this some kind of plugin bug with Vue? I see no scoped attrs or selectors on the css.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300257986,
"datetime": 1494354221000,
"masked_author": "username_1",
"text": "Hmmmm not sure.\r\n\r\nAfter looking at the official bootstrap .modal, they are setting the style attribute to either `display none` or `display block`.\r\n\r\nMaybe `style` should be a `v-bind` with a computed style value, rather than using v-if to control display.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300258991,
"datetime": 1494354417000,
"masked_author": "username_5",
"text": "I've never used Rollup before, but this could be stripping off vue's css scoping: https://github.com/bootstrap-vue/bootstrap-vue/blob/master/build/rollup.config.js#L28-L30",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300260205,
"datetime": 1494354665000,
"masked_author": "username_5",
"text": "Well, tried removing those lines, and that didn't do a thing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300260320,
"datetime": 1494354688000,
"masked_author": "username_1",
"text": "Just made a modification to my copy of modal, which reactively sets the style to either `display: none` or `display: block`, rather than using `v-show`.\r\n\r\nI think this might fix the issues.\r\n\r\nhttps://github.com/username_1/bootstrap-vue/blob/modal-style/lib/components/modal.vue",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300261985,
"datetime": 1494355056000,
"masked_author": "username_5",
"text": "Looks like you guys are using css modules rather than the \"simulated\" scoped css that uses data attributes. I'm admittedly of css modules, but I would argue that it doesn't seem to play into other build systems as a component right now. Or maybe I just have no idea how to make use of css modules the way the lib is built.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300269243,
"datetime": 1494356594000,
"masked_author": "username_1",
"text": "I'm not sure if hte change I porposed in https://github.com/username_1/bootstrap-vue/blob/modal-style/lib/components/modal.vue will break the transitioning or not.\r\n\r\nWill try a mockup.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300283494,
"datetime": 1494359872000,
"masked_author": "username_1",
"text": "I've done a mockup, but switched to setting the display style using transition events, and it appears to work.\r\n\r\nhttps://jsfiddle.net/pyk5efjd/\r\n\r\nI think the style part of the component can have the `.modal { display: block;}` removed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 300297886,
"datetime": 1494363184000,
"masked_author": "username_5",
"text": "Yeah, that part shows it's just getting overwritten.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 300298538,
"datetime": 1494363333000,
"masked_author": "username_1",
"text": "Although the fade transition doesn't work as smooth.\r\n\r\nI have tried using v-if (lazy loading), but it interrupts the transition bit (and I bet for more complex modals if would be worse).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 301923453,
"datetime": 1494970698000,
"masked_author": "username_5",
"text": "P.S. When I bundle bootstrap-vue from `lib/index.js`, all the scoped css works with the data-v attributes. When I use the `.esm` version, I do not get scoped css.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302323395,
"datetime": 1495092341000,
"masked_author": "username_5",
"text": "```\r\n\r\nAnd here are the methods added:\r\n```vue\r\nhandleBeforeEnter() {\r\n console.log('before-enter');\r\n this.$emit('before-enter', this);\r\n},\r\nhandleAfterEnter() {\r\n console.log('after-enter');\r\n this.focusFirst();\r\n this.$emit('after-enter', this);\r\n},\r\nhandleBeforeLeave() {\r\n console.log('before-leave');\r\n this.$emit('before-leave', this);\r\n},\r\nhandleAfterLeave() {\r\n console.log('after-leave');\r\n this.$emit('after-leave', this);\r\n}\r\n```\r\n\r\nAnd here is the weirdness I see:\r\n\r\n\r\nThe events are correctly timed, but I can't figure out why they fire twice. I checked my own code to show and hide the modal, but there are no duplications there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302432177,
"datetime": 1495119941000,
"masked_author": "username_1",
"text": "@username_5 could this duplicate logging be because you are emitting the same event back onto the component (i.e. `this.$emit`)?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302434635,
"datetime": 1495120424000,
"masked_author": "username_5",
"text": "That was my first thought, but I switched the event names to use an arbitrary prefix and I still saw duplication.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302436483,
"datetime": 1495120796000,
"masked_author": "username_5",
"text": "If the duplication isn't a byproduct of my own mistake, I feel it could likely be a bug in either the modal component (some kind of nextTick call maybe that halts the transition?) or in the transition-group eventing. I've searched for other instances of this, and I see some people get caught by children of an element also firing transition events. Maybe Vue hasn't or doesn't consolidate the transition events to the whole group.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302441817,
"datetime": 1495121603000,
"masked_author": "username_1",
"text": "You might want to test the `transition-group` duplicate by making simple Vue.js fiddle with two components, one that has two transitions inside, and one that has just a single transition inside and see if the duplicates are emitted when the `transition-group` only contains a single transition item.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302450733,
"datetime": 1495123316000,
"masked_author": "username_5",
"text": "That's a good idea. I'll cook something up and post a link.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302472397,
"datetime": 1495126950000,
"masked_author": "username_5",
"text": "This is an ugly test, but you can play with this: https://jsfiddle.net/vtoy09cy/2/\r\n\r\nEach transition element emits discrete transition hook events. One event per transition element! Is this expected behavior for Vue? It seems to contradict the group nature of this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302473380,
"datetime": 1495127072000,
"masked_author": "username_1",
"text": "Hmm yeah, maybe an issue should be opened with Vue.js?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302474101,
"datetime": 1495127135000,
"masked_author": "username_5",
"text": "That's what I'm thinking. I'll post the issue link here.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302477412,
"datetime": 1495127516000,
"masked_author": "username_1",
"text": "I suppose one workaround might be to have counter for each event, and don't do anything until is reaches 2 (then reset the counter back to 0 once it hits 2). But this would be kind of ugly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302477775,
"datetime": 1495127569000,
"masked_author": "username_5",
"text": "Filed this transition group issue in the vuejs repository here: https://github.com/vuejs/vue/issues/5701",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302478232,
"datetime": 1495127638000,
"masked_author": "username_5",
"text": "Agreed. That just feels like a hack. Then **_you_** have to keep track in your head how many transition elements to count. That could easily get out of sync as tweaks are made.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302482151,
"datetime": 1495128209000,
"masked_author": "username_1",
"text": "And one caveat with css based transition hooks for IE9:\r\nhttps://github.com/vuejs/vue/issues/5525#issuecomment-297597977\r\n\r\nPersonally I am only supporting IE10 and up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302483510,
"datetime": 1495128486000,
"masked_author": "username_1",
"text": "Looks like an event for each transition in a group is ht intended behaviour https://github.com/vuejs/vue/issues/5701",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302483681,
"datetime": 1495128527000,
"masked_author": "username_5",
"text": "Yeah, I believe that choosing Vue.js means you aren't playing the backwards compat game—since they already cut support for IE8",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302483951,
"datetime": 1495128588000,
"masked_author": "username_5",
"text": "Yeah, intended behavior. I figured the events needed to be discrete for manipulation. I'm hoping the genius of You recommends a good event aggregation pattern.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302484497,
"datetime": 1495128718000,
"masked_author": "username_1",
"text": "The only other thing I can think of is debouncing/throttling the transition handlers for the duration of the longest transition duration. :(",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302484653,
"datetime": 1495128756000,
"masked_author": "username_5",
"text": "I've played that game before. My suggestion is not to even go down that road!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302487580,
"datetime": 1495129474000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302488646,
"datetime": 1495129722000,
"masked_author": "username_5",
"text": "Think like so: every transition element needs a unique key, so prefix it with `trans-` or whatever. Then loop like so:\r\n\r\n```js\r\nimport Vue from 'vue'\r\nconst transitionRegex = /^trans-.+/\r\n\r\n{\r\n computed: {\r\n numTransitionEls() {\r\n return this.$children.filter(node => node instanceof Vue && transitionRegex.test(node.$vnode.key)).length\r\n }\r\n }\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302489463,
"datetime": 1495129924000,
"masked_author": "username_5",
"text": "Yeah, it gets way more tricky when you dive in. The vm's child will be the transition-group. Manually is probably the easiest thing you can do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 302490098,
"datetime": 1495130071000,
"masked_author": "username_5",
"text": "There's some good stuff inside the transition group at `transitionGroupVM.$options._renderChildren`, but best to respect those props as private.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 302491360,
"datetime": 1495130373000,
"masked_author": "username_1",
"text": "Yeah, the only private prop you should trust is `this.__vue__`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 304562636,
"datetime": 1496026812000,
"masked_author": "username_1",
"text": "The original might be due to scoped CSS and certain bundlers not \"scoping\" the CSS.\r\n\r\nMaybe if we add a new class to the component and CSS (say `.b-modal`), to \"scope\" the CSS display property.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "riker09",
"comment_id": 305414284,
"datetime": 1496302668000,
"masked_author": "username_6",
"text": "Hello there. I recently made it back from my parent time (Elternzeit) which was basically a two month break from work. I used version 0.9.x before and modals were working fine. Now I updated this library on my project and modals don't work anymore? Is there a workaround yet?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 305481835,
"datetime": 1496320997000,
"masked_author": "username_5",
"text": "@username_6, I think the thing that is still broken is CSS for the `.modal` display property. The rollup bundling doesn't seem to respect the `scoped` attribute for me. Are you getting the backdrop working on show, but no modal content? If so, add this to your CSS (that's loaded _after_ bootstrap):\r\n\r\n```css\r\n.modal { display: block; }\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 310583109,
"datetime": 1498199168000,
"masked_author": "username_1",
"text": "@username_2 @username_5 @username_3 \r\n\r\nJust thinking... rather than using `v-show` on modal, what about using `:style=` to set `display` to `none` or `block`, which might negate the need for the scoped CSS?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 310590245,
"datetime": 1498201887000,
"masked_author": "username_2",
"text": "v-show or v-if - allow to use native Vue transitions. \r\nIf we set style directly, then we must implement custom transitions.\r\nSuch solution was at the beginning of the modal component.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 310590631,
"datetime": 1498201996000,
"masked_author": "username_1",
"text": "Ah, I wasn't sure about that. good to know.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 310590806,
"datetime": 1498202057000,
"masked_author": "username_2",
"text": "i think, what if we will change display to block not at the <style>, but at some code point (dynamically)?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 310591127,
"datetime": 1498202168000,
"masked_author": "username_1",
"text": "Hmmm.... that might work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 312462554,
"datetime": 1498954276000,
"masked_author": "username_1",
"text": "@username_0 are you still having this issue with the latest release (v0.17.2)?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sushain97",
"comment_id": 312731918,
"datetime": 1499115228000,
"masked_author": "username_7",
"text": "I'm experiencing this issue with v0.17.1.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 313231238,
"datetime": 1499289890000,
"masked_author": "username_5",
"text": "I don't believe the slide from top transition is built into the component due to using Vue transitions. It might be possible, but I believe the complication is Vue's show directive uses inline `display: none`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 313231549,
"datetime": 1499289969000,
"masked_author": "username_5",
"text": "Perhaps I can look into the rollup plugin responsible for bundling the CSS. It isn't currently respecting the scoping.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mosinve",
"comment_id": 313280851,
"datetime": 1499309330000,
"masked_author": "username_2",
"text": "Slide from top transition is a default behavior from BS4.\r\nVue v-show uses **inline** `display:none` to hide element, and just remove it to show. \r\nOtherwise at BS4 **inline** style `display:none` used to hide modal, and **inline** `display:block` used to show with class `.show`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexsasharegan",
"comment_id": 313541360,
"datetime": 1499381771000,
"masked_author": "username_5",
"text": "Looks like the current version of the `rollup-plugin-vue` now supports generating the pseudo-scoped css. I would wager the issues around `.modal {display: block;}` should now be gone due to the scoping specificity.\r\n\r\nI'm going to close this as the problem _should_ be solved, and this issue is overcrowded and stale. If your problem persists, please upgrade to the latest version of bootstrap-vue `v0.18.0`. If your problem still persists, please open a new issue with any updated details.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "alexsasharegan",
"comment_id": null,
"datetime": 1499381771000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "riker09",
"comment_id": 318055721,
"datetime": 1501076375000,
"masked_author": "username_6",
"text": "I just wanted to confirm that updating to 0.18.0 fixed the issue, my modals are working again. yay!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mariusa",
"comment_id": 326793336,
"datetime": 1504429808000,
"masked_author": "username_8",
"text": "Got the same issue with 1.0.0-beta.7, fixed by adding\r\n.modal.show { display:block; }",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lakshyabatman",
"comment_id": 633219348,
"datetime": 1590321024000,
"masked_author": "username_9",
"text": "Hello, I'm facing the same issue with the 2.13 version.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tmorehouse",
"comment_id": 633243913,
"datetime": 1590332450000,
"masked_author": "username_1",
"text": "@username_9 Make sure you are including BootstrapVue's custom SCSS/CSS after Bootstrap's SCSS.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lakshyabatman",
"comment_id": 633530074,
"datetime": 1590406792000,
"masked_author": "username_9",
"text": "Both Scss files are in order and placed on the global style sheet. @username_1",
"title": null,
"type": "comment"
}
] | 10 | 85 | 22,229 | false | false | 22,229 | true |
finnkuusisto/TinySound | null | 121,082,721 | 24 | null | [
{
"action": "opened",
"author": "finnkuusisto",
"comment_id": null,
"datetime": 1449603592000,
"masked_author": "username_0",
"text": "A user suggested that TinySound be added to the Maven central repository.",
"title": "Add to Maven central repository",
"type": "issue"
},
{
"action": "created",
"author": "leif81",
"comment_id": 168080125,
"datetime": 1451512386000,
"masked_author": "username_1",
"text": ":+1: \r\n\r\nMaven'izing the project (writing a `pom.xml`) is probably the easiest way to get it into central from my experience.\r\n\r\nAs far as dependencies go, the libs folder contains three jars which can be found in central already so that it should be a relatively easy thing to do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NicklasMCHD",
"comment_id": 346095598,
"datetime": 1511284288000,
"masked_author": "username_2",
"text": "Hi\r\nIt is an amasing library. And one of the few that is so simple. Getting it into maven central would be a big help for anyone trying to use the library.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 509 | false | false | 509 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.