repo
stringlengths
7
67
org
stringlengths
2
32
issue_id
int64
780k
941M
issue_number
int64
1
134k
pull_request
dict
events
list
user_count
int64
1
77
event_count
int64
1
192
text_size
int64
0
329k
bot_issue
bool
1 class
modified_by_bot
bool
2 classes
text_size_no_bots
int64
0
279k
modified_usernames
bool
2 classes
testfairy/ti.testfairy
testfairy
221,981,417
8
null
[ { "action": "opened", "author": "alphakilo45", "comment_id": null, "datetime": 1492302590000, "masked_author": "username_0", "text": "When I attempt to run install.sh and then attempt to package the Android Module, I get build errors (attached)\r\n[build_error.txt](https://github.com/testfairy/ti.testfairy/files/923996/build_error.txt)", "title": "Getting build errors using Ti SDK 6.0.3", "type": "issue" }, { "action": "created", "author": "vijaysharm", "comment_id": 294898105, "datetime": 1492532416000, "masked_author": "username_1", "text": "Hi @username_0, you might be missing some environment variables. See how we setup our environment in the `.travis` file. You can also download v2.1.1 from the releases page here\r\nhttps://github.com/testfairy/ti.testfairy/releases/tag/2.1.1", "title": null, "type": "comment" }, { "action": "closed", "author": "vijaysharm", "comment_id": null, "datetime": 1492532418000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
441
false
false
441
true
caskdata/cdap
caskdata
55,100,818
1,077
{ "number": 1077, "repo": "cdap", "user_login": "caskdata" }
[ { "action": "opened", "author": "jwang47", "comment_id": null, "datetime": 1421888584000, "masked_author": "username_0", "text": "", "title": "CDAP-1230: HTTP endpoint to get effective configuration", "type": "issue" }, { "action": "created", "author": "nitinmotgi", "comment_id": 70954826, "datetime": 1421889309000, "masked_author": "username_1", "text": "I had a version that I didn't merge and it was JSON response. The idea was that this API would be used in the CDAP Console. Can we `format=json|xml` if both formats are needed. Don't know the use-case for needing xml.", "title": null, "type": "comment" }, { "action": "created", "author": "jwang47", "comment_id": 70955387, "datetime": 1421889593000, "masked_author": "username_0", "text": "From the comments, looks like we want to expose HConf and CConf, and also allow for both json and xml formats.", "title": null, "type": "comment" }, { "action": "created", "author": "nitinmotgi", "comment_id": 70955709, "datetime": 1421889773000, "masked_author": "username_1", "text": "@username_0 it would also be good to have additional information about where the configuration was up picked from - Was it from cdap-default.xml or cdap-site.xml. That information is available +ve.", "title": null, "type": "comment" }, { "action": "created", "author": "nitinmotgi", "comment_id": 70955736, "datetime": 1421889790000, "masked_author": "username_1", "text": "@username_0 why do we need xml ?", "title": null, "type": "comment" }, { "action": "created", "author": "poornachandra", "comment_id": 70956020, "datetime": 1421889934000, "masked_author": "username_2", "text": "@username_1 If we want to duplicate configuration from a cluster to another, then it is easy if we have it in XML format.", "title": null, "type": "comment" }, { "action": "created", "author": "poornachandra", "comment_id": 70978291, "datetime": 1421909012000, "masked_author": "username_2", "text": "@username_0 `Configuration` class itself has methods to generate XML - `writeXml`. See if you can make use of it.\r\n\r\nAlso, if possible can you add the `ConfigHandler` to all HTTP system services like Transaction Manager, Explore, etc.?", "title": null, "type": "comment" }, { "action": "created", "author": "jwang47", "comment_id": 71102814, "datetime": 1421962235000, "masked_author": "username_0", "text": "Build running https://builds.cask.co/browse/CDAP-DUT594-1", "title": null, "type": "comment" }, { "action": "created", "author": "jwang47", "comment_id": 71135405, "datetime": 1421978054000, "masked_author": "username_0", "text": "https://builds.cask.co/browse/CDAP-DUT594-4", "title": null, "type": "comment" }, { "action": "created", "author": "anew", "comment_id": 71136783, "datetime": 1421979088000, "masked_author": "username_3", "text": "LGTM", "title": null, "type": "comment" } ]
4
10
1,007
false
false
1,007
true
DIYgod/APlayer
null
154,501,450
44
null
[ { "action": "opened", "author": "kamboP", "comment_id": null, "datetime": 1463064436000, "masked_author": "username_0", "text": "Hello,\r\nI like this player and I want to use it as a radio player, can i do that?!\r\n\r\nThank you", "title": "Can I use it as a radio player and how?", "type": "issue" }, { "action": "created", "author": "DIYgod", "comment_id": 218796683, "datetime": 1463067546000, "masked_author": "username_1", "text": "Sorry, I've never done it before.", "title": null, "type": "comment" }, { "action": "closed", "author": "DIYgod", "comment_id": null, "datetime": 1463153162000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
128
false
false
128
false
TerryZ/SelectPage
null
265,949,440
23
null
[ { "action": "opened", "author": "doocal", "comment_id": null, "datetime": 1508197451000, "masked_author": "username_0", "text": "官方的示例:\r\n1、点下选择什么也不选。鼠标点一下页面其它地方。此时输入框默认就选种了一个,应该为空。\r\n2、默认获得焦点的控件,圆角成了方角。\r\n3、输入框有图标的,如果选择的文字超过输入框,图标和文档重叠,应该将图标的距离空出来。", "title": "点开关闭就被默认选种了,这个不好。", "type": "issue" }, { "action": "created", "author": "TerryZ", "comment_id": 337087899, "datetime": 1508202710000, "masked_author": "username_1", "text": "感谢提出意见建议\r\n1.可以根据autoSelectFirst来关闭\r\n2.有意做成这样效果\r\n3.好建议,会尝试解决", "title": null, "type": "comment" }, { "action": "closed", "author": "TerryZ", "comment_id": null, "datetime": 1509885426000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "TerryZ", "comment_id": 341969947, "datetime": 1509885426000, "masked_author": "username_1", "text": "第三点问题,`v2.14` 版本增加了 `dropButton: false` 参数来设置下拉按钮是否显示,对于文字内容会跟清空图标、下拉图标重叠的问题,尽可以优先将输入框的宽度增加", "title": null, "type": "comment" } ]
2
4
267
false
false
267
false
pvlib/pvlib-python
pvlib
273,534,854
396
null
[ { "action": "opened", "author": "wholmgren", "comment_id": null, "datetime": 1510598520000, "masked_author": "username_0", "text": "We should consider adding an implementation of the GTI DIRINT model described in Marion 2015:\r\n\r\nhttps://www.sciencedirect.com/science/article/pii/S0038092X15005757\r\n\r\nIn short, the GTI DIRINT model converts plane of array irradiance to DNI, DHI, and GHI.\r\n\r\nI have a partial implementation that I've been sitting on for a few months. I'll try to get it into a PR soon.", "title": "Add GTI DIRINT model", "type": "issue" }, { "action": "created", "author": "jforbess", "comment_id": 348253948, "datetime": 1512061519000, "masked_author": "username_1", "text": "Trying to implement this myself for a quick and dirty prototype. Any hint as to whether the iteration can be performed over the entire time series of POA or whether each time stamp has to be iterated? I am torn on how to evaluate the min D if evaluating over the entire timeseries at once.", "title": null, "type": "comment" }, { "action": "created", "author": "wholmgren", "comment_id": 348259238, "datetime": 1512062629000, "masked_author": "username_0", "text": "Real quick... here's my implementation: \r\n\r\nhttps://github.com/username_0/pvlib-python/blob/gtidirint/pvlib/irradiance.py#L1408\r\n\r\nOff the top of my head I don't remember. I'll try to come back to this in the next few days.", "title": null, "type": "comment" }, { "action": "created", "author": "cwhanse", "comment_id": 348259854, "datetime": 1512062744000, "masked_author": "username_2", "text": "The iteration removes the error introduced by approximating GHI/cos(zenith) by GTI/cos(AOI). The difference lies in the diffuse sky and ground irradiance received by a horizontal vs. tilted module. It appears that Bill applies iteration separately for each hourly value (Fig 2 in his paper), which I think is appropriate, because AOI changes with time.\r\n\r\nI believe also that the convergence method in his paper could be improved, but I haven't got an alternate method to propose.", "title": null, "type": "comment" }, { "action": "created", "author": "adriesse", "comment_id": 348279060, "datetime": 1512066797000, "masked_author": "username_3", "text": "I'm sure you could do the iteration in parallel. You would then have the same number of iterations for each time step, and your termination condition would have to be based on all time steps. \r\n\r\nI have no experience with this algorithm, but suspect that if you just iterate a small fixed number of times you would be adequate, or you could keep going until the biggest error for the year falls below some threshold. Probably still way faster than looping through hour by hour.", "title": null, "type": "comment" }, { "action": "closed", "author": "cwhanse", "comment_id": null, "datetime": 1535379293000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
4
6
1,841
false
false
1,841
true
peatio/peatio-opensource
peatio
295,509,850
711
null
[ { "action": "opened", "author": "dutchakdev", "comment_id": null, "datetime": 1518096162000, "masked_author": "username_0", "text": "", "title": "why some repositories has been removed?", "type": "issue" }, { "action": "created", "author": "prototypensx", "comment_id": 364235299, "datetime": 1518121021000, "masked_author": "username_1", "text": "Looks like they don't want anyone else taking a bite out of their profit anymore..", "title": null, "type": "comment" }, { "action": "created", "author": "gyazbek", "comment_id": 364254899, "datetime": 1518125504000, "masked_author": "username_2", "text": "I wouldn't jump to any conclusions just yet. Repo names changed early in the morning and now are back to what it was. Perhaps just some basic reorg?", "title": null, "type": "comment" }, { "action": "created", "author": "nleo", "comment_id": 364845580, "datetime": 1518420379000, "masked_author": "username_3", "text": "@muhammednagy did you check rubykube/peatio fork? Why did you not forked from them? Why you fork will be better (or in which cases differ) from rubykube/peatio?", "title": null, "type": "comment" }, { "action": "created", "author": "frezeq0", "comment_id": 369322626, "datetime": 1519840063000, "masked_author": "username_4", "text": "bittrex opensource: https://github.com/username_4/bittrex-opensource", "title": null, "type": "comment" }, { "action": "created", "author": "frezeq00", "comment_id": 369402779, "datetime": 1519856259000, "masked_author": "username_5", "text": "bittrex opensource: https://github.com/pkdcryptos/username_4_bittrex-opensource", "title": null, "type": "comment" } ]
6
6
531
false
false
531
true
tc39/proposal-global
tc39
197,829,033
20
null
[ { "action": "opened", "author": "evilpie", "comment_id": null, "datetime": 1482920034000, "masked_author": "username_0", "text": "See [bug 1325907 ](https://bugzilla.mozilla.org/show_bug.cgi?id=1325907). Just the existence of `global` flickr.com. This seems to be caused by code in the popular moment/moment library.", "title": "global is not webcompatible", "type": "issue" }, { "action": "created", "author": "ljharb", "comment_id": 269515432, "datetime": 1482948336000, "masked_author": "username_1", "text": "The referenced code - https://github.com/moment/moment/blob/94ad539f965689289af54b6493abca0a65ab4ce6/moment.js#L15 - should work identically with `global`, unless the file is naively concatenated such that it's in strict mode, such that top-level `this` isn't the global object.\r\n\r\nIs that what Flickr is doing? If so, lots of things might be broken by their build process :-/", "title": null, "type": "comment" }, { "action": "created", "author": "ziyunfei", "comment_id": 269581738, "datetime": 1482987192000, "masked_author": "username_2", "text": "The moment.js code is warped in a YUI module:\r\n```\r\nYUI.add(\"moment\", function(e, t) {\r\n alert(this === global) // false \r\n}, \"@VERSION@\")\r\n```\r\n![image](https://cloud.githubusercontent.com/assets/1276859/21536938/a5864d66-cdc4-11e6-95f0-c245aaee875c.png)", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 269584446, "datetime": 1482989979000, "masked_author": "username_1", "text": "In that case, moment should not be wrapping YUI, since that would break in node.\r\n\r\nI realize this doesn't change the web compatibility issue - but it does highlight the incorrect assumptions that were made when wrapping `moment`.\r\n\r\n@username_0 are there any other reports? I feel like we should be able to evangelize to Yahoo and get them to update Flickr, and similarly, update `moment` via a PR, which would remove the web compat breakage.", "title": null, "type": "comment" }, { "action": "created", "author": "ziyunfei", "comment_id": 269586160, "datetime": 1482991599000, "masked_author": "username_2", "text": "The `typeof global` checking had already been removed from new versions of moment.js.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 269599780, "datetime": 1483001678000, "masked_author": "username_1", "text": "Given that, it sounds like we just need to get Flickr/Yahoo to update the version of `moment` that it's using, and the problem goes away. @username_0, if this happens, would we be able to try this again in Firefox?", "title": null, "type": "comment" }, { "action": "created", "author": "jswalden", "comment_id": 269708043, "datetime": 1483053047000, "masked_author": "username_3", "text": "Unless I'm misreading the code (entirely possible), https://github.com/tc39/proposal-global/issues/20#issuecomment-269586160 looks wrong to me. Flickr's moment.js code is identical to that on trunk, and that's been on trunk since https://github.com/moment/moment/commit/1601cb1dd7b14277ba8b00cb2ece3ce637923080 two years ago. The seeming difference between\r\n\r\n (typeof global !== 'undefined' && (typeof window === 'undefined' || window === global.window)) ? global : this\r\n\r\nand\r\n\r\n typeof global == \"undefined\" || typeof window != \"undefined\" && window !== global.window ? this : global\r\n\r\nis purely the result of minifying: applying de Morgan's Laws and removing parentheses that aren't necessary by language precedence order.\r\n\r\nThe issue here is purely that Flickr's embedding moment.js code, that uses `this` presuming it's the global object, in a context where `this` is not the global object.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 269719387, "datetime": 1483061391000, "masked_author": "username_1", "text": "@username_3 thanks, I think your conclusion is correct.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 269856139, "datetime": 1483174217000, "masked_author": "username_1", "text": "Another example has popped up in Firefox: [bug 1326032](https://bugzilla.mozilla.org/show_bug.cgi?id=1326032)", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 270414451, "datetime": 1483547169000, "masked_author": "username_4", "text": "This is all very sad. Sounds like we can't go with the name `global` for a long time. I'd be very hesitant to put this in V8 given the evidence already collected from Firefox.", "title": null, "type": "comment" }, { "action": "created", "author": "miketaylr", "comment_id": 271646615, "datetime": 1484070656000, "masked_author": "username_5", "text": "Also, JIRA, in https://bugzilla.mozilla.org/show_bug.cgi?id=1328218 (due to moment.js).", "title": null, "type": "comment" }, { "action": "created", "author": "evilpie", "comment_id": 271647175, "datetime": 1484070778000, "masked_author": "username_0", "text": "I should mention we removed `global` from Nightly again.", "title": null, "type": "comment" }, { "action": "created", "author": "nt1m", "comment_id": 271736586, "datetime": 1484092661000, "masked_author": "username_6", "text": "@username_0 : I agree with https://bugzilla.mozilla.org/show_bug.cgi?id=1317422#c18\r\nCan't we have it for strict contexts? That would limit the amount of pages affected if any", "title": null, "type": "comment" }, { "action": "created", "author": "evilpie", "comment_id": 271738813, "datetime": 1484093490000, "masked_author": "username_0", "text": "I don't think so. Consider two scripts included in HTML, they can have different strictness, but they still have the same global object, with the \"global\" on it.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 271806415, "datetime": 1484122899000, "masked_author": "username_1", "text": "We might be able to add it in Modules, but adding it in strict mode wouldn't work - you may forget that a Script can have `function sloppy() {} function strict() { 'use strict'; }` - `global` isn't a keyword, so it can't have contextual meaning, and it'd be really weird for a string pragma to bring something into scope.", "title": null, "type": "comment" }, { "action": "created", "author": "rjgotten", "comment_id": 271815810, "datetime": 1484125756000, "masked_author": "username_7", "text": "You are misreading the code. Those lines are not at all there in trunk, i.e., in https://github.com/moment/moment/blob/master/moment.js\r\n\r\nThey're there in [version 2.0.9](https://github.com/moment/moment/blob/2.9.0/moment.js) which was tagged 2015-01-02, but were removed when [version 2.10.2](https://github.com/moment/moment/blob/2.10.2/moment.js) which was tagged 2015-04-09, introduced a UMD wrapper.\r\n\r\nSo yes; this would be resolved by Yahoo, Flickr, etc. updating their codebase.", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 271897596, "datetime": 1484148353000, "masked_author": "username_4", "text": "@username_1 Modules have the same global object as non-modules. You'd add this in the global lexical tier? That would be a new one. Is there anything else we might want to add this way? Adding it only in modules would give this feature significantly diminished utility as well.\r\n\r\nWhat if we named this 'self'? Have we seen evidence that that would break the Node world?", "title": null, "type": "comment" }, { "action": "created", "author": "targos", "comment_id": 271901006, "datetime": 1484149043000, "masked_author": "username_8", "text": "I can try to add `self` to Node and see if CITGM breaks.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 271921429, "datetime": 1484153047000, "masked_author": "username_1", "text": "@username_4 I won't be continuing the proposal if it's named `self` - @username_8, if that is easy that would be helpful, but only to disqualify it.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 271923166, "datetime": 1484153387000, "masked_author": "username_1", "text": "Regardless I won't be actually pursuing \"add it only in Modules\", I agree the utility would be greatly reduced.\r\n\r\nThe proper solution here is either to come up with a web-compatible top-level name that has \"global\" in it, or to namespace it under a new or existing web-compatible top-level name.", "title": null, "type": "comment" }, { "action": "created", "author": "michaelficarra", "comment_id": 271942204, "datetime": 1484157359000, "masked_author": "username_9", "text": "It looks like we have reason to introduce `System.global` after all.", "title": null, "type": "comment" }, { "action": "created", "author": "leobalter", "comment_id": 271971069, "datetime": 1484163330000, "masked_author": "username_10", "text": "If we want to avoid a namespace my suggestion is to pursue something not perfect but less likely to break web compat as `__global__`, or even `$$global`. It hurts my eyes, but it's still a single name binding with a safer approach avoiding namespace.", "title": null, "type": "comment" }, { "action": "created", "author": "jakub-g", "comment_id": 271989840, "datetime": 1484167731000, "masked_author": "username_11", "text": "`__global__` seems rather safe IMO, and in line with stuff like`__proto__`. Though indeed it looks ugly.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 272005976, "datetime": 1484171321000, "masked_author": "username_1", "text": "@username_8 it looked like the CIGTM run failed a bunch of the jobs?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 272006131, "datetime": 1484171352000, "masked_author": "username_1", "text": "@username_10 `System.global` is far more elegant than `__global__` or `$$global`, though, and a namespace of any kind allows for us to use \"global\" untainted by legacy characters.", "title": null, "type": "comment" }, { "action": "created", "author": "kdzwinel", "comment_id": 272012336, "datetime": 1484172790000, "masked_author": "username_12", "text": "FYI [Safari Technology Preview 21](https://webkit.org/blog/7265/release-notes-for-safari-technology-preview-21/) was just released and it features support for the `global` property. flickr.com doesn't work, but JIRA (v6.2) seems to be working fine for me.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 272013012, "datetime": 1484172938000, "masked_author": "username_1", "text": "@username_12 can you comment on the [firefox bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1328218) related to jira? It should be broken in both places if this is indeed the cause.", "title": null, "type": "comment" }, { "action": "created", "author": "miketaylr", "comment_id": 272111241, "datetime": 1484212127000, "masked_author": "username_5", "text": "And backed out: https://bugs.webkit.org/show_bug.cgi?id=166915", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 272117199, "datetime": 1484213850000, "masked_author": "username_1", "text": "(Turns out it requires a newer Jira version to get the failure)", "title": null, "type": "comment" }, { "action": "created", "author": "andyearnshaw", "comment_id": 319902538, "datetime": 1501748605000, "masked_author": "username_13", "text": "Is it feasible to continue with `global`, but have vendors apply a patch to the offending moment.js scripts? For instance, if they could recognise the script and introduce a scope layer at the top level of the script where `global` is undefined? From what I understand, moment.js was the only reported incompatibility, so this seems like it may be worth trying to \"un-stall\" this feature.\r\n\r\nI realise there's no precedent for this when introducing a new global property, but I know that vendors have patched some JS scripts before.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 319905382, "datetime": 1501749354000, "masked_author": "username_1", "text": "@username_13 browsers have indicated that it's not feasible. (I'm also not aware of browsers ever \"patching\" code on websites in the way you're indicating, do you have any links?)", "title": null, "type": "comment" }, { "action": "created", "author": "andyearnshaw", "comment_id": 319908953, "datetime": 1501750277000, "masked_author": "username_13", "text": "...but this isn't really the same thing.", "title": null, "type": "comment" }, { "action": "created", "author": "michaelficarra", "comment_id": 319995861, "datetime": 1501772527000, "masked_author": "username_9", "text": "I mean, if all of the offending scripts have the same hash, the browser could just replace them with a compatible but fixed version. All browsers already have a mechanism for hashing scripts if they support CSP or SRI. Seems worth suggesting to implementors.", "title": null, "type": "comment" }, { "action": "created", "author": "mgol", "comment_id": 320013164, "datetime": 1501775989000, "masked_author": "username_14", "text": "@username_9 That won't work for people using bundlers like Webpack or Browserify or if they minify themselves etc.", "title": null, "type": "comment" }, { "action": "created", "author": "miketaylr", "comment_id": 320013776, "datetime": 1501776112000, "masked_author": "username_5", "text": "That won't work for the simple reason that browsers don't want to be in the business of being a CDN for up to date JS lib versions.", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 320016069, "datetime": 1501776597000, "masked_author": "username_4", "text": "Different browsers will have different policies here, but as a way of rolling out a new feature, I think this is pretty safely a dead end.", "title": null, "type": "comment" }, { "action": "created", "author": "syg", "comment_id": 331955143, "datetime": 1506360832000, "masked_author": "username_15", "text": "Did we ever bikeshed new names and agree on the next name for browsers to play whack-a-mole with?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 331960178, "datetime": 1506361838000, "masked_author": "username_1", "text": "Not yet. Mainly we need a browser to volunteer to try one, and I can pick from the bikeshed list.", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 331961191, "datetime": 1506362047000, "masked_author": "username_4", "text": "@username_1 I think if you go and pick something, and get agreement from everybody that it'd be a good name if it works, then browsers might be more excited to try it; it can be hard to preemptively volunteer to ship in the absence of an agreed-on proposal.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 331990679, "datetime": 1506368628000, "masked_author": "username_1", "text": "Sounds good; I'll get some consensus this week and settle on our next attempt.", "title": null, "type": "comment" }, { "action": "created", "author": "hax", "comment_id": 345647717, "datetime": 1511172157000, "masked_author": "username_16", "text": "Any update?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 345714406, "datetime": 1511188740000, "masked_author": "username_1", "text": "No update yet.", "title": null, "type": "comment" }, { "action": "created", "author": "JakeChampion", "comment_id": 351032863, "datetime": 1513080421000, "masked_author": "username_17", "text": "How about we use `System.global`?", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 351071693, "datetime": 1513089883000, "masked_author": "username_4", "text": "We don't have a System object yet. System.global has been proposed in TC39, but IIRC some committee members objected that global is a little to small to justify System itself. Plus, such a long name might not be very attractive to use.", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 353485523, "datetime": 1513899744000, "masked_author": "username_4", "text": "Due to this issue, the global proposal does not seem like it will proceed to Stage 4 in this form. Looking at this repository, I'm having trouble finding any indication outside of this bug that the name `global` is not going to be used going forward. I think it'd be best if the README.md and spec had a note mentioning this fact, and replacing `global` with a clearly unusable placeholder. @phoddie mentioned to me that Moddable has implemented this proposal, unaware of the specification status (even if it might be fine for them to ship this long term, like Node does).", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 353531578, "datetime": 1513924067000, "masked_author": "username_1", "text": "That sounds like a good idea. I'll update the readme and spec with a placeholder.\r\n\r\nModdable is a rare event; a new engine that wasn't present during the committee meetings for this proposal :-)", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 353563740, "datetime": 1513936512000, "masked_author": "username_4", "text": "Actually I think there are a lot of people who look at proposal repositories who can't come to meetings. For one, engines have multiple people working on them; there are also popular polyfills without committee representation. Proposal repositories should explain themselves well for all of them.\r\n\r\nI'd recommend writing these warnings in bigger letters and actually scratching out mentions of global. People could gloss over these notes as they are written now. Also, I wouldn't mind if this were somehow noted in the proposals repository that it is not ready.", "title": null, "type": "comment" }, { "action": "created", "author": "aciccarello", "comment_id": 353610001, "datetime": 1513953449000, "masked_author": "username_18", "text": "", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 353653635, "datetime": 1513967950000, "masked_author": "username_1", "text": "All of the 4 browsers have existing bugs filed that say to hold off implementing; there's really only two popular polyfills i know of, one's mine, and the other's author follows this repo closely.\r\n\r\nThis seems like an overabundance of caution to me; non-browsers always have to be aware of the web compatibility risk in stage 3 (perhaps the process document needs to indicate that more clearly?).", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 353666400, "datetime": 1513973016000, "masked_author": "username_4", "text": "Thanks, I appreciate the follow-on change. My experience so far with TC39 is that there are lots of people looking at these proposals, different people are going to look at different things, and it'll be helpful to some people who end up skimming your explainer here that the current status is more clear (it's not like I do a perfect job of this myself).", "title": null, "type": "comment" }, { "action": "created", "author": "sag1v", "comment_id": 362895028, "datetime": 1517738276000, "masked_author": "username_19", "text": "Do we have to choose from the already existing list (`global`, `window`, `this`, `frame`...) ?\r\nHow about `root`?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 362921884, "datetime": 1517763598000, "masked_author": "username_1", "text": "No, we don’t have to choose one from an existing list.", "title": null, "type": "comment" }, { "action": "created", "author": "Kovensky", "comment_id": 362956452, "datetime": 1517792766000, "masked_author": "username_20", "text": "In the babel slack, I at one point suggested `realm`, as you have one global object per javascript Realm; but @username_1 thinks it's too obscure if you can't tell it's \"the global\" without needing this kind of background knowledge.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 362994305, "datetime": 1517812629000, "masked_author": "username_1", "text": "I'm pretty strongly only going to go forward with an identifier that includes the word \"global\".\r\n\r\nHowever, due to web compatibility issues, the only productive suggestions are ones that accompany actual browser usage metrics.", "title": null, "type": "comment" }, { "action": "created", "author": "sag1v", "comment_id": 362997374, "datetime": 1517813926000, "masked_author": "username_19", "text": "@username_1 Is that an answer to my suggestion regarding `root` being out of the question? :)", "title": null, "type": "comment" }, { "action": "created", "author": "b-strauss", "comment_id": 365569055, "datetime": 1518606081000, "masked_author": "username_21", "text": "why not `globalObject`?\r\n\r\nhttps://developer.mozilla.org/en-US/docs/Glossary/Global_object", "title": null, "type": "comment" }, { "action": "created", "author": "andyearnshaw", "comment_id": 365666198, "datetime": 1518626271000, "masked_author": "username_13", "text": "Having the type in the name, `globalObject`, just seems too weird and ignoring existing naming conventions. For instance, we don't have `thisValue`, `parseIntFunction`, `argumentsList`, `ArrayConstructor`, etc.\r\n\r\nI liked `System.global`, but `System` was thrown out so it seems silly to add a new namespace just for `global`. How about `gIobal`? Then we can pretend that's how it was spelled all along :grin:", "title": null, "type": "comment" }, { "action": "created", "author": "b-strauss", "comment_id": 365669588, "datetime": 1518626867000, "masked_author": "username_21", "text": "`DOMStringList`, `Float32Array`, `NodeList`, `ArrayBuffer`\r\n\r\n😝", "title": null, "type": "comment" }, { "action": "created", "author": "Kovensky", "comment_id": 365800895, "datetime": 1518658440000, "masked_author": "username_20", "text": "Kind of the problem here seems to be that no name for global will be accepted other than `global`.\r\n\r\nMy self-righteousness leans more towards blaming JIRA/flickr though 😡", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 365801554, "datetime": 1518658723000, "masked_author": "username_1", "text": "I have a list of candidates, but I’d prefer not to advertise them until browsers have helped me ascertain web compat risk.\r\n\r\nThanks for your suggestions, but i doubt they’ll end up being helpful (since we probably already have the good ones on our list).", "title": null, "type": "comment" }, { "action": "created", "author": "littledan", "comment_id": 365858554, "datetime": 1518683856000, "masked_author": "username_4", "text": "@username_1 You might have trouble convincing browsers to ship your new names before getting committee and community feedback on them.", "title": null, "type": "comment" }, { "action": "created", "author": "jswalden", "comment_id": 365859382, "datetime": 1518684089000, "masked_author": "username_3", "text": "I assume his intent is to keep the candidates on the down-low until there seems plausible evidence they can be shipped, so we don't have another case where some JS library over-eagerly starts trying to monkeypatch and ends up inadvertently poisoning the well in advance of some implementation actually making the change. That is, I assume feedback will happen at some point -- just very carefully.", "title": null, "type": "comment" }, { "action": "created", "author": "andyearnshaw", "comment_id": 365883727, "datetime": 1518689993000, "masked_author": "username_13", "text": "Thanks for the update, I'm guessing `gIobal` is totally on the list but I understand if you can neither confirm nor deny 😁", "title": null, "type": "comment" }, { "action": "created", "author": "mgol", "comment_id": 365895828, "datetime": 1518692940000, "masked_author": "username_14", "text": "How about GLOBAL or Global?\n-- \nMichał Gołębiowski-Owczarek", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 365946088, "datetime": 1518705522000, "masked_author": "username_1", "text": "@username_4 the reflector already has a thread for that, where results will be discussed once i have them.", "title": null, "type": "comment" }, { "action": "created", "author": "michaelficarra", "comment_id": 365987880, "datetime": 1518713170000, "masked_author": "username_9", "text": "@username_14 `globał`?", "title": null, "type": "comment" }, { "action": "created", "author": "georgir", "comment_id": 367711749, "datetime": 1519312397000, "masked_author": "username_22", "text": "Object.global", "title": null, "type": "comment" }, { "action": "created", "author": "benwiley4000", "comment_id": 375943755, "datetime": 1521950354000, "masked_author": "username_23", "text": "\"Globalism\"", "title": null, "type": "comment" }, { "action": "created", "author": "rbuckton", "comment_id": 377590972, "datetime": 1522434657000, "masked_author": "username_24", "text": "@username_1 have you considered using a meta-property like `import.global`?", "title": null, "type": "comment" }, { "action": "created", "author": "epeters3", "comment_id": 379047057, "datetime": 1522955828000, "masked_author": "username_25", "text": "Is `globe` out of the question?", "title": null, "type": "comment" }, { "action": "created", "author": "benwiley4000", "comment_id": 379072741, "datetime": 1522961515000, "masked_author": "username_23", "text": "Perhaps there's a more diplomatic way of putting this, but has any consideration been paid to just pushing this through as-is and warning sites like Flickr and Jira to change their code, since they have plenty of highly paid developers whose job it is to respond to API changes?\r\n\r\nAll the non-`global` solutions proposed have sounded bad. Writing code which hinges on the assumption that a word - one as predictably-extant-in-the-future as `global` - would *not* exist in the web client - was inadvisable. This shouldn't be everyone's problem. Everyone else sane in the world has been writing code that merely checks if `window` exists, since there's no foreseeable future where a such-named, globally-accessible object would exist in Node.js *without* emulating a browser API.", "title": null, "type": "comment" }, { "action": "created", "author": "Kovensky", "comment_id": 379121175, "datetime": 1522977218000, "masked_author": "username_20", "text": "IIUC, the problem with Jira is not that it is a website, but that it is a web application that is sold, packaged, to corporations; and the problem is in a version of Jira that is no longer being updated.", "title": null, "type": "comment" }, { "action": "created", "author": "doodadjs", "comment_id": 379132808, "datetime": 1522982481000, "masked_author": "username_26", "text": "What about my \"application/javascript.2\" idea, i.e. having a JS2 for breaking changes ?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 379134247, "datetime": 1522983160000, "masked_author": "username_1", "text": "We won’t break the web; no consideration will be given to doing that.\r\n\r\nNo English word is more important than keeping sites working for human beings, nor will it ever be.\r\n\r\nWe will find a word that works. Relax, be patient, settle down - something palatable will end up being feasible. It’ll be ok.", "title": null, "type": "comment" }, { "action": "created", "author": "zloirock", "comment_id": 379135270, "datetime": 1522983663000, "masked_author": "username_27", "text": "@username_1 this issue was opened already 1.5 years ago. In this and related threads, we have some alternatives. Maybe makes sense to choose something instead of being patient? It's just a variable name.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 379135683, "datetime": 1522983876000, "masked_author": "username_1", "text": "There’s a balance here between forward progress, and not using up browser goodwill.\r\n\r\nWe’re waiting on telemetry from browsers; after which we will, indeed, just pick a name.", "title": null, "type": "comment" }, { "action": "created", "author": "benwiley4000", "comment_id": 379141095, "datetime": 1522986769000, "masked_author": "username_23", "text": "@username_1 if you intend to call it \"breaking the web\" then of course I can't agree with that! 😄\r\n\r\nI think your opinion is better than mine. Ultimately it probably is better practice not to overload `global` with new meaning and to come up with a new platform-independent name instead.\r\n\r\nIt's just the idea of Jira of all things blocking the progression of web, that gives me trouble sleeping at night. 😉", "title": null, "type": "comment" }, { "action": "created", "author": "rjgotten", "comment_id": 379182783, "datetime": 1523002714000, "masked_author": "username_7", "text": "Then it's not a matter of 'breaking the web' but a matter of breaking a poorly written application.\r\nTough luck for the companies that bought an old version; maybe they should consider upgrading or maybe they should demand a patch for their paid-for product.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 379267448, "datetime": 1523024290000, "masked_author": "username_1", "text": "The web consists of many things, including poorly written applications, and we won’t break users of poorly written applications either.", "title": null, "type": "comment" }, { "action": "created", "author": "Jamesernator", "comment_id": 379283175, "datetime": 1523027333000, "masked_author": "username_28", "text": "In this case I think it's fine to change the name of global as it's fairly easy to do and doesn't really matter.\r\n\r\nBut saying \"we won't break users of poorly written applications\" seems like a dangerous statement as it seems to suggest that if an application did something crazy like `if (Reflect.ownKeys(Array.prototype).length > 32) { doSomething() }` and forgot to update it if the number ever changed then the TC39 wouldn't add new Array methods ever in risk of breaking that specific site. Obviously that example probably isn't in use anywhere, but I'm sure there's fragile code that could break on similarly trivial additions to the language (*especially* new globals via `if (typeof someGlobal === 'undefined') { var someGlobal = ... }`).\r\n\r\nIt would be nice if there was a clearer definition of what is sufficiently important not to break given a proposal. e.g. Are 1000 users enough? Single bug reports in Nightly builds of browsers? Internal tools? etc", "title": null, "type": "comment" }, { "action": "created", "author": "deecewan", "comment_id": 381011418, "datetime": 1523590333000, "masked_author": "username_29", "text": "what's the threshold on this? There have got to be a million websites that have used some bad practice that will inevitably be broken by some update in the future, such as modify Array's prototype (`smoosh`).\r\n\r\nSurely there has to be a middle ground between maintaining compat and progress?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 381012258, "datetime": 1523590686000, "masked_author": "username_1", "text": "@username_29 \"progress\" isn't measured by \"keeping an arbitrary english word\"; see https://github.com/tc39/proposal-global/issues/20#issuecomment-379134247 and earlier comments.", "title": null, "type": "comment" }, { "action": "created", "author": "deecewan", "comment_id": 381015484, "datetime": 1523592205000, "masked_author": "username_29", "text": "i meant more broadly than the word that is used, but I take your point. I guess what I'm getting at is that there are going to be people who aren't actively involved in the community/don't see these announcements who will have, at one point or another, written some code that may be broken by a proposal, and those voices won't be heard.\r\n\r\nwhat's the threshold on 'number of people affected'? because it currently seems to be 'your voice matters if it's loud enough'.\r\n\r\nIf there is a better forum for this question, please direct me there.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 381023925, "datetime": 1523595476000, "masked_author": "username_1", "text": "When code is broken in a browser, hopefully someone files a bug report to that browser - that’s generally how the committee learns of the breakage. I’m not sure it’s a matter of a threshold (not that we have concrete criteria anywhere), but more a matter of evaluating any reports on a case by case basis.", "title": null, "type": "comment" }, { "action": "created", "author": "sag1v", "comment_id": 381403406, "datetime": 1523795844000, "masked_author": "username_19", "text": "Is `_global` or `_global_` is out of the question?", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 381409133, "datetime": 1523801062000, "masked_author": "username_1", "text": "@username_19 there’s precedent for `__global__` but the aesthetics of that aren’t what I’d call “likely to satisfy the committee”, nor myself.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 385104902, "datetime": 1524866394000, "masked_author": "username_1", "text": "@svdb0 at this point, it needs to be a global variable - it can't be something applicable to any object - double underscores aren't what i'd call \"aesthetically pleasing\" - a metaproperty or keyword wouldn't be replaceable by secure realm tools like caja, so it has to be an identifier.", "title": null, "type": "comment" }, { "action": "created", "author": "rjgotten", "comment_id": 385180617, "datetime": 1524926195000, "masked_author": "username_7", "text": "You're expecting average web-users to file a bug report citing a broken API?\r\nOr you're expecting developers to file a bug report with the browser, rather than the broken library?", "title": null, "type": "comment" }, { "action": "created", "author": "Licshee", "comment_id": 388695449, "datetime": 1526272954000, "masked_author": "username_30", "text": "To me, `self` sounds like a reasonable name for global object in \"JavaScript\", since it is already standardized in HTML:\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/Window/self\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/self\r\n\r\nAnd people already using `self` outside of HTML:\r\nhttps://github.com/sergeche/emmet-sublime/blob/master/emmet/bootstrap.js\r\n\r\nThe biggest problem so far is -- there are many people still using `window` even if the code is not necessary running on HTML, and it should be no more if either `self` or `global` made into standard.\r\n\r\nSo I believe the only thing we need to do is making `self` into the standard.\r\n\r\n## FAQ\r\n### Isn't `self` a terrible name?\r\nYes, but web developers already getting used with it, seconded to `window`, which is a worse choice.\r\nAnd since the standardized `self` in HTML means basically the same thing, it should not be a problem implementing into browsers.\r\n\r\n### Does it conflict with other use?\r\nI don't think so.\r\nHistorical, people tend to use `self` or `that` to \"snapshot\" `this` in current scope, the point is at any moment the code introduce a new `var self`, it has nothing to do with other `self`s outside current scope, and that's why people use `self` or `that` or something else to replace `this` when they need to pass the current `this` into a nested method.\r\nIf we make it a standard global `self` point to the global object itself, it should not cause problem, since there should be no code expects a global `self` exists or not, except in some cases developer(s) already getting used with `self` being the global object itself.\r\n\r\n### Why not `global`?\r\nhttps://nodejs.org/api/globals.html#globals_global\r\n`global` in Node.js is a completely different thing, it will cause compatibility problems -- or at least Node.js users still have to use something like `self`.\r\nAlso, as people mentioned above, some website(s) already used `global` for other purpose(s).\r\n\r\n### Wait... Doesn't it mean if we made `self` into standard, all existing code involving `self` or global object have to be rewritten?\r\nNo.\r\n1. If existing code use variables like `global` or something, a standardized `self` has nothing to do with them, and don't require changes to the code.\r\n2. If any existing code already use `self` for any purpose, the standardized `self` should simplify be overwritten, and cause no problem.\r\n3. If existing code used `self` for purpose other than an alias for global object and willing to use global object in a future version, just rename existing `self` or choose another variable name to alias the global object like how others did in case 1.\r\n4. If implementation specified behavior is involved, any name other than `self` can lead to worse situation since only `self` has known use to be alias to global object. (check what Node.js have done explained for the previous question)\r\n5. If existing code used the `global` in Node.js, then it has nothing to do with this to-be `self`, since they are two completely different being.\r\n\r\nBTW, https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/520/ shows 404 for now, what was the result?", "title": null, "type": "comment" }, { "action": "created", "author": "GreLI", "comment_id": 390389740, "datetime": 1526718918000, "masked_author": "username_31", "text": "Since `global` isn't really global, but depends on context, frames, etc, may be should it called `realm`?", "title": null, "type": "comment" }, { "action": "created", "author": "sffc", "comment_id": 397376209, "datetime": 1528997514000, "masked_author": "username_32", "text": "`window` is a noun. I like using a similar noun, like `globe` (suggested by username_25) or `universe`.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 397400035, "datetime": 1529002087000, "masked_author": "username_1", "text": "@username_32 \"the global\" is a noun too; despite originally being an adjective, like it or not it's been nouned (yes, \"noun\" has been verbed; and yes, so has \"verbed\") by the JS community.", "title": null, "type": "comment" }, { "action": "created", "author": "hollowdoor", "comment_id": 399226911, "datetime": 1529611731000, "masked_author": "username_33", "text": "I don't think 'global' is arbitrary as it matches the usage, and means what everyone's been saying since programming was a thing even in other languages. Maybe that's just my opinion. I don't know. Compat is king as well so relevant semantics could be moot. Though the same argument could be made for code base semantics being arbitrary.\r\n\r\nWhat about calling the top level 'arch', 'prime', or 'main'? I don't know if those could be considered arbitrary, but they certainly have a ring to them. I like 'arch' in particular which is also a noun, and adjective. Arch variables?\r\n\r\nA single letter would also be viable like 'g', or 'G', or perhaps 'z' the uncommon letter. 'zoo' would provide some entertainment value, and is an occasionally applicable metaphor. :)\r\n\r\nSorry for butting in this late in the game.\r\n\r\nBTW 'self' seems semantically odd to me. Is 'global' supposed to be scoped to the current frame like 'window'? 'universe' like @username_32 suggests sounds nifty.", "title": null, "type": "comment" }, { "action": "created", "author": "EthanRutherford", "comment_id": 399255461, "datetime": 1529618023000, "masked_author": "username_34", "text": "`top` seems like it would make sense (as in, the top level scope)", "title": null, "type": "comment" }, { "action": "created", "author": "dcgudeman", "comment_id": 399308900, "datetime": 1529637660000, "masked_author": "username_35", "text": "If people like `global` because it is semantically clear why not take it a step further and just call it `globalScope`", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 399322612, "datetime": 1529644295000, "masked_author": "username_1", "text": "@username_35 that's not clear; it's the global object/global `this` value, it's not a scope - the line gets blurry when you're talking about global vars, sure, but it doesn't contain scope information (you can't see `const` values as properties of that object, for example).", "title": null, "type": "comment" }, { "action": "created", "author": "dcgudeman", "comment_id": 399323746, "datetime": 1529644816000, "masked_author": "username_35", "text": "@username_1 That makes sense. So would a name like `globalObject` or `globalThis` work? Admittedly seeing the capital 'T' in `globalThis` makes me cringe, maybe `thisGlobal` would be easier to digest.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 399326453, "datetime": 1529646017000, "masked_author": "username_1", "text": "It remains to be seen what will work.\r\n\r\nSpecific suggestions aren't really helpful at this stage, though.", "title": null, "type": "comment" }, { "action": "created", "author": "hollowdoor", "comment_id": 399983455, "datetime": 1529938894000, "masked_author": "username_33", "text": "But that was weeks ago. Is that still the current stage? I hope I don't come across as impatient. I'm just interested in the process.", "title": null, "type": "comment" }, { "action": "created", "author": "leobalter", "comment_id": 399987592, "datetime": 1529939648000, "masked_author": "username_10", "text": "@username_33 There is no public update so far, and by public not even specific information I see shared within TC39.\r\n\r\nAlthough, the public agenda already show @username_1 will present something new in the next TC39 meeting, happening at the end of July.\r\n\r\nhttps://github.com/tc39/agendas/blob/master/2018/07.md\r\n\r\nI'm looking forward to it.", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 400003161, "datetime": 1529942217000, "masked_author": "username_1", "text": "@username_33 it’s taken well over a year so far, so “weeks” isn’t much :-)", "title": null, "type": "comment" }, { "action": "created", "author": "hollowdoor", "comment_id": 400142447, "datetime": 1529974680000, "masked_author": "username_33", "text": "Right on. Maybe I'm a little too excited about this particular feature. :)", "title": null, "type": "comment" }, { "action": "created", "author": "chr1se", "comment_id": 403928195, "datetime": 1531248611000, "masked_author": "username_36", "text": "**var** foo = 10;\r\n**let** foo = 20;\r\n\r\nfollowing the established 3 letter pattern, how is:\r\n**gbl** foo = 30;", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 403958385, "datetime": 1531255205000, "masked_author": "username_1", "text": "@username_36 i think you've misunderstood the entire purpose for the proposal - it doesn't deal with creating or reading global variables, it solely creates a single global variable that provides access to the global `this` value.", "title": null, "type": "comment" }, { "action": "created", "author": "chr1se", "comment_id": 404026001, "datetime": 1531276632000, "masked_author": "username_36", "text": "..oops forgive my misunderstanding & thanks for the clarification\r\ndeparting suggestions:\r\n\r\n`globals` \r\n`shell` \r\n`container`", "title": null, "type": "comment" }, { "action": "created", "author": "ljharb", "comment_id": 404072448, "datetime": 1531294200000, "masked_author": "username_1", "text": "@username_37 flickr is just the largest case; https://bugzilla.mozilla.org/show_bug.cgi?id=1326032 was on a different site. Individual sites are symptomatic of a larger problem; it can't really be papered over in that way.", "title": null, "type": "comment" }, { "action": "created", "author": "demurgos", "comment_id": 404078372, "datetime": 1531295558000, "masked_author": "username_37", "text": "@username_1 \r\nI tried to hint it with smileys and punctuation, but my suggestion was just a joke: obviously it's not a tenable solution. But thanks for calling me out and clarifying it, sorry if it wasn't very constructive. I just wanted to lighten the mood a bit between the many comments asking for progress or throwing new names.", "title": null, "type": "comment" }, { "action": "created", "author": "domenic", "comment_id": 406105948, "datetime": 1531956740000, "masked_author": "username_38", "text": "If people will forgive a bit more off-topic digression, they may enjoy perusing how a suggestion very similar to @username_37's joke actually made its way into Chrome: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_target.cc?l=252&rcl=37b6757f5f82d379b43903728641081141f94217. (And indeed, will likely make its way into web standards.)", "title": null, "type": "comment" }, { "action": "closed", "author": "ljharb", "comment_id": null, "datetime": 1536784954000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
39
109
25,848
false
false
25,848
true
pablojim/highcharts-ng
null
91,275,714
344
null
[ { "action": "opened", "author": "JoachimR", "comment_id": null, "datetime": 1435331604000, "masked_author": "username_0", "text": "This problem has been fixed before as I have seen from other issues but it still gives me troubles with version 0.0.8\r\n\r\nHave a look in your browser console when running the follwing fiddle: \r\n\r\nhttp://jsfiddle.net/35xqueef/", "title": "Data binding works fine but get error: Invalid value for <text> attribute x=\"NaN...\"", "type": "issue" }, { "action": "created", "author": "jaimeguaman", "comment_id": 141724278, "datetime": 1442712733000, "masked_author": "username_1", "text": "I think it's not a ng-highcharts problem, instead Highcharts itself or your config object with an element config property inside your graph.\r\n\r\nspecifically the problem is with your x axis title align.\r\n\r\nthis is what triggers the error\r\n```svg\r\n<text x=\"NaN\" zIndex=\"7\" text-anchor=\"undefined\" transform=\"translate(0,0)\" class=\" highcharts-xaxis-title\" style=\"color:#707070;fill:#707070;\" visibility=\"visible\" y=\"644\">S</text> \r\n```\r\n\r\nin your ng-higcharts config object you have:\r\n```javascript\r\n xAxis: {\r\n currentMin: 1,\r\n currentMax: 100,\r\n title: {\r\n text: 'S',\r\n align: \"right\"\r\n },\r\n labels: {\r\n formatter: function () {\r\n return (this.value + \" units\");\r\n }\r\n }\r\n },\r\n```\r\nI removed the `align`property and the error disappeared\r\nhttp://jsfiddle.net/v152o77a/", "title": null, "type": "comment" }, { "action": "created", "author": "JoachimR", "comment_id": 141905002, "datetime": 1442823481000, "masked_author": "username_0", "text": "thank you very much @username_1 ! \r\n\r\nI used the wrong value for align because I used the wrong documentation: http://api.highcharts.com/highcharts#title.align\r\n\r\nbut the value needs to be 'low', 'middle' or 'high' as described here: http://api.highcharts.com/highcharts#xAxis.title", "title": null, "type": "comment" }, { "action": "closed", "author": "JoachimR", "comment_id": null, "datetime": 1442823481000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
1,486
false
false
1,486
true
intellij-rust/intellij-rust
intellij-rust
225,747,361
1,194
null
[ { "action": "opened", "author": "farodin91", "comment_id": null, "datetime": 1493741996000, "masked_author": "username_0", "text": "", "title": "Prevent examples as project name", "type": "issue" }, { "action": "created", "author": "matklad", "comment_id": 298858815, "datetime": 1493802376000, "masked_author": "username_1", "text": "Why do we need this? Does Cargo fail if one names one's project \"examples\"?", "title": null, "type": "comment" }, { "action": "created", "author": "farodin91", "comment_id": 298860135, "datetime": 1493802805000, "masked_author": "username_0", "text": "Cargo fails with a base folder name \"examples\".", "title": null, "type": "comment" }, { "action": "created", "author": "matklad", "comment_id": 298860475, "datetime": 1493802924000, "masked_author": "username_1", "text": "Hm, seems to work fine here:\r\n\r\n```\r\n~/trash master*\r\nλ cargo new examples\r\n Created library `examples` project\r\n\r\n~/trash master*\r\nλ cd examples/cargo\r\n\r\n~/trash/examples master*\r\nλ ls\r\nsrc Cargo.toml\r\n\r\n~/trash/examples master*\r\nλ cargo test --all\r\n Compiling examples v0.1.0 (file:///home/user/trash/examples)\r\n Finished dev [unoptimized + debuginfo] target(s) in 0.78 secs\r\n Running target/debug/deps/examples-ab5a25f76fbb9f9e\r\n\r\nrunning 1 test\r\ntest tests::it_works ... ok\r\n\r\ntest result: ok. 1 passed; 0 failed; 0 ignored; 0 measured\r\n\r\n Doc-tests examples\r\n\r\nrunning 0 tests\r\n\r\ntest result: ok. 0 passed; 0 failed; 0 ignored; 0 measured\r\n```\r\n\r\nPerhaps this a bug in Cargo specific to your invornment, or a bug in IntelliJ-Rust? Does creating `examples` project from the command line work for you?", "title": null, "type": "comment" }, { "action": "created", "author": "farodin91", "comment_id": 298860861, "datetime": 1493803044000, "masked_author": "username_0", "text": "Interesting", "title": null, "type": "comment" }, { "action": "created", "author": "farodin91", "comment_id": 298861053, "datetime": 1493803107000, "masked_author": "username_0", "text": "I created the project with intellij-rust.", "title": null, "type": "comment" }, { "action": "created", "author": "matklad", "comment_id": 298955402, "datetime": 1493827112000, "masked_author": "username_1", "text": "Ok, I would say that it is a bug in Cargo: https://github.com/rust-lang/cargo/issues/3990.\r\n\r\nWe shouldn't duplicate this logic in IntelliJ Rust. Instead, we can show the error generated by Cargo when that issue is fixed.", "title": null, "type": "comment" }, { "action": "closed", "author": "matklad", "comment_id": null, "datetime": 1493827114000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "matklad", "comment_id": 299172762, "datetime": 1493901454000, "masked_author": "username_1", "text": "PR to fix cargo: https://github.com/rust-lang/cargo/pull/3994", "title": null, "type": "comment" } ]
2
9
1,276
false
false
1,276
false
crawl/crawl
crawl
87,861,910
63
{ "number": 63, "repo": "crawl", "user_login": "crawl" }
[ { "action": "opened", "author": "amalloy", "comment_id": null, "datetime": 1434145599000, "masked_author": "username_0", "text": "It was supposed to be NdX, but was accidentally XdN.\r\n\r\nAlso tidied up a bit by removing some repetition, and moving related\r\nvariables closer together.", "title": "Fix Ru's apocalypse damage", "type": "issue" }, { "action": "created", "author": "amalloy", "comment_id": 111638221, "datetime": 1434150575000, "masked_author": "username_0", "text": "This is a non-trivial nerf to apocalypse, by the way. EV of 16d4 is 40, whereas EV on 4d16 is 34, plus more variance. May want to consider whether that is a desirable change - maybe the existing implementation is the right amount of damage even if it wasn't intentional.", "title": null, "type": "comment" } ]
1
2
422
false
false
422
false
sourcelair/ceryx
sourcelair
133,428,069
10
null
[ { "action": "opened", "author": "parisk", "comment_id": null, "datetime": 1455366281000, "masked_author": "username_0", "text": "Ceryx should be able to be configured through an env file, which is quiet convenient.\r\n\r\nWell, this could happen in a couple of ways though. We could either promote usage of the `env_file` in the `docker-compose.yml` file, or we could provide built in support for loading environment variables from a `.env` file in the Ceryx itself.\r\n\r\nWe can chose the one that suits us better.", "title": "Add env file support", "type": "issue" }, { "action": "created", "author": "parisk", "comment_id": 315008449, "datetime": 1499934350000, "masked_author": "username_0", "text": "Closing this as we added the environment variables in the new Compose file format and they get replaced automatically with [environment interpolation](https://docs.docker.com/compose/environment-variables/) (which also works for `.env` files).", "title": null, "type": "comment" }, { "action": "closed", "author": "parisk", "comment_id": null, "datetime": 1499934352000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
3
622
false
false
622
false
conda/conda
conda
206,129,513
4,567
null
[ { "action": "opened", "author": "joelkim", "comment_id": null, "datetime": 1486543107000, "masked_author": "username_0", "text": "```\r\nCurrent conda install:\r\n\r\n platform : win-64\r\n conda version : 4.3.9\r\n conda is private : False\r\n conda-env version : 4.3.9\r\n conda-build version : 2.1.3\r\n python version : 2.7.13.final.0\r\n requests version : 2.12.4\r\n root environment : C:\\Users\\username_0\\Anaconda2 (writable)\r\n default environment : C:\\Users\\username_0\\Anaconda2\r\n envs directories : C:\\Users\\username_0\\Anaconda2\\envs\r\n package cache : C:\\Users\\username_0\\Anaconda2\\pkgs\r\n channel URLs : https://repo.continuum.io/pkgs/free/win-64\r\n https://repo.continuum.io/pkgs/free/noarch\r\n https://repo.continuum.io/pkgs/r/win-64\r\n https://repo.continuum.io/pkgs/r/noarch\r\n https://repo.continuum.io/pkgs/pro/win-64\r\n https://repo.continuum.io/pkgs/pro/noarch\r\n https://repo.continuum.io/pkgs/msys2/win-64\r\n https://repo.continuum.io/pkgs/msys2/noarch\r\n config file : None\r\n offline mode : False\r\n user-agent : conda/4.3.9 requests/2.12.4 CPython/2.7.13 Windows/10 Windows/10.0.14393\r\n```\r\n\r\nI got this error when I tried to install qt:\r\n```\r\nC:\\Code\\mojito6\\doc>conda create -n test qt\r\nFetching package metadata ...........\r\nSolving package specifications: .\r\n\r\nPackage plan for installation in environment C:\\Users\\username_0\\Anaconda2\\envs\\test:\r\n\r\nThe following NEW packages will be INSTALLED:\r\n\r\n icu: 57.1-vc9_0 [vc9]\r\n jpeg: 9b-vc9_0 [vc9]\r\n libpng: 1.6.27-vc9_0 [vc9]\r\n openssl: 1.0.2k-vc9_0 [vc9]\r\n pip: 9.0.1-py27_1\r\n python: 2.7.13-0\r\n qt: 5.6.2-vc9_3 [vc9]\r\n setuptools: 27.2.0-py27_1\r\n vs2008_runtime: 9.00.30729.5054-0\r\n wheel: 0.29.0-py27_0\r\n zlib: 1.2.8-vc9_3 [vc9]\r\n\r\nProceed ([y]/n)?\r\n\r\nERROR conda.core.link:_execute_actions(319): An error occurred while installing package 'defaults::qt-5.6.2-vc9_3'.\r\n```", "title": "ERROR conda.core.link:_execute_actions(319): An error occurred while installing package 'defaults::qt-5.6.2-vc9_3'", "type": "issue" }, { "action": "created", "author": "kalefranz", "comment_id": 278363109, "datetime": 1486568299000, "masked_author": "username_1", "text": "If this problem is reproducible for you, can you give me the output of \r\n\r\n conda create -n test qt -vvv\r\n\r\nIt'll be a lot of output. Feel free to email it to me if you want. kale@franz.io", "title": null, "type": "comment" }, { "action": "created", "author": "LiamLiuhit", "comment_id": 278558296, "datetime": 1486621572000, "masked_author": "username_2", "text": "I have the similar error too.", "title": null, "type": "comment" }, { "action": "created", "author": "joelkim", "comment_id": 278585598, "datetime": 1486631293000, "masked_author": "username_0", "text": "I found the reason. It is because non-English OS message is not encoded utf-8 (in my case, CP949)\r\n\r\nOn installation, ``subprocess``_call function is called:\r\nhttps://github.com/conda/conda/blob/33303158f070c0eda1ce0bbcb7807ddc7a4972d6/conda/gateways/subprocess.py#L62\r\n\r\nThis function calls ``ensure_text_type`` to validate standard output:\r\nhttps://github.com/conda/conda/blob/7005e366a2a7dcd19430114c4a3d30f2eb735995/conda/common/compat.py#L154\r\n\r\nThis function raises an Unicode error because subprocess' standard output include not-encoded-in-utf-8 string.\r\n\r\nBut, I have no idea why there was no problem in root environment when I installed qt.", "title": null, "type": "comment" }, { "action": "created", "author": "joelkim", "comment_id": 278591491, "datetime": 1486632911000, "masked_author": "username_0", "text": "Temporarily, I fixed this problem by modifying ``ensure_text_type`` like this:\r\n```\r\nimport chardet\r\n\r\ndef ensure_text_type(value):\r\n if isinstance(value, text_type):\r\n encoding = 'utf-8'\r\n else:\r\n encoding = chardet.detect(value).get('encoding') or 'utf-8'\r\n return value.decode(encoding) if hasattr(value, 'decode') else value\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "LiamLiuhit", "comment_id": 278600343, "datetime": 1486635242000, "masked_author": "username_2", "text": "Thank you very much! However, I'm a newcomer here, could you tell me what should I do to solve this problem, by the way? Should I just activate the user environment and run your program or download your program file into some specific root?", "title": null, "type": "comment" }, { "action": "created", "author": "joelkim", "comment_id": 278669702, "datetime": 1486652977000, "masked_author": "username_0", "text": "Open the file ~\\Anaconda2\\Lib\\site-packages\\conda\\common\\compat.py\r\nand edit like https://github.com/username_0/conda/commit/ca13fb8c3082fb7672bf1fae2dcd5e08e4a13c9d", "title": null, "type": "comment" }, { "action": "created", "author": "LiamLiuhit", "comment_id": 278853643, "datetime": 1486700221000, "masked_author": "username_2", "text": "It works! Thank you!", "title": null, "type": "comment" }, { "action": "created", "author": "kalefranz", "comment_id": 279914823, "datetime": 1487133296000, "masked_author": "username_1", "text": "Conda 4.3.12 that includes a patch for this issue has been released to conda canary. Feel free to test.\r\n\r\n conda config --add channels conda-canary\r\n conda update conda", "title": null, "type": "comment" }, { "action": "closed", "author": "kalefranz", "comment_id": null, "datetime": 1487133296000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "imhuay", "comment_id": 303062491, "datetime": 1495449097000, "masked_author": "username_3", "text": "A easy solveed method: \r\nat root env:\r\n`conda install chardet`\r\nref: http://very9s.net/post/tag/conda/", "title": null, "type": "comment" }, { "action": "created", "author": "vijju7447", "comment_id": 658695386, "datetime": 1594809861000, "masked_author": "username_4", "text": "(opencv-env) C:\\Users\\Vijju>conda create -n test qt -vvvc\r\nusage: conda-script.py create [-h] [--clone ENV] [-n ENVIRONMENT | -p PATH]\r\n [-c CHANNEL] [--use-local] [--override-channels]\r\n [--repodata-fn REPODATA_FNS]\r\n [--strict-channel-priority]\r\n [--no-channel-priority]\r\n [--no-deps | --only-deps] [--no-pin] [--copy]\r\n [--no-shortcuts] [-C] [-k] [--offline] [-d]\r\n [--json] [-q] [-v] [-y] [--download-only]\r\n [--show-channel-urls] [--file FILE]\r\n [--no-default-packages] [--dev]\r\n [package_spec [package_spec ...]]\r\nconda-script.py create: error: argument -c/--channel: expected one argument", "title": null, "type": "comment" } ]
6
13
5,131
false
true
4,944
true
apple/swift
apple
257,160,078
11,877
{ "number": 11877, "repo": "swift", "user_login": "apple" }
[ { "action": "opened", "author": "aschwaighofer", "comment_id": null, "datetime": 1505245707000, "masked_author": "username_0", "text": "And add builtins for the added runtime functions (assign-take, assign-copy).\r\n\r\nrdar://27412867\r\nSR-3376", "title": "Use array copy runtime implementation instead of the array value witnesses", "type": "issue" }, { "action": "created", "author": "aschwaighofer", "comment_id": 328964772, "datetime": 1505245728000, "masked_author": "username_0", "text": "@swift-ci Please smoke test", "title": null, "type": "comment" }, { "action": "created", "author": "aschwaighofer", "comment_id": 328967233, "datetime": 1505246289000, "masked_author": "username_0", "text": "@swift-ci Please test", "title": null, "type": "comment" }, { "action": "created", "author": "aschwaighofer", "comment_id": 328990162, "datetime": 1505251850000, "masked_author": "username_0", "text": "@swift-ci Please benchmark", "title": null, "type": "comment" }, { "action": "created", "author": "rjmccall", "comment_id": 329216231, "datetime": 1505318714000, "masked_author": "username_1", "text": "That seems like a tolerable set of regressions in exchange for dropping three value witnesses. Awesome!", "title": null, "type": "comment" }, { "action": "created", "author": "jckarter", "comment_id": 329220657, "datetime": 1505319636000, "masked_author": "username_2", "text": "Are we still able to specialize when the type of the array element being copied/moved is known?", "title": null, "type": "comment" }, { "action": "created", "author": "eeckstein", "comment_id": 329220800, "datetime": 1505319672000, "masked_author": "username_3", "text": "great work!", "title": null, "type": "comment" } ]
5
10
67,466
false
true
388
false
mvriel/phpDocumentorXP
null
72,938,862
4
null
[ { "action": "opened", "author": "mvriel", "comment_id": null, "datetime": 1430722653000, "masked_author": "username_0", "text": "With the changes in phpDocumentor we are making _severe_ BC breaking changes; especially when it comes to calling the binary, configuration and template handling.\r\n\r\nIn order to make the transition smoother for people we should add a compatibility layer that converts the old configuration file information into the new structure and allows old template formats to be loaded.\r\n\r\n- [ ] Configuration\r\n- [ ] Templates and views\r\n- [ ] Command line command?", "title": "Backwards compatibility", "type": "issue" } ]
1
1
454
false
false
454
false
NimbusAPI/Nimbus
NimbusAPI
29,260,373
60
null
[ { "action": "opened", "author": "uglybugger", "comment_id": null, "datetime": 1394629196000, "masked_author": "username_0", "text": "Some handlers need to have a set maximum number of instances. We've seen this in the wild with spinning up a pool of PhantomJS instances, for instance, as well as where third-party APIs limit incoming connections.\n\nWe need a nice way to specify how many concurrently-executing instances of a handler of a particular type should permit, as well as a sensible default.", "title": "Per-handler ability to specify maximum concurrent handler instances", "type": "issue" }, { "action": "closed", "author": "DamianMac", "comment_id": null, "datetime": 1576156649000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
366
false
false
366
false
marcuswestin/WebViewJavascriptBridge
null
119,165,206
172
{ "number": 172, "repo": "WebViewJavascriptBridge", "user_login": "marcuswestin" }
[ { "action": "opened", "author": "Hydra2050", "comment_id": null, "datetime": 1448617624000, "masked_author": "username_0", "text": "When load a page which need redirect, that will be blank.\r\nTo compare the url, don`t inject frame that js need to redirect.", "title": "Fix a webview cannot be loaded when the page need redirect.", "type": "issue" }, { "action": "created", "author": "marcuswestin", "comment_id": 176244890, "datetime": 1453996355000, "masked_author": "username_1", "text": "@lokimeyburg ditto :)", "title": null, "type": "comment" }, { "action": "created", "author": "marcuswestin", "comment_id": 176508978, "datetime": 1454030084000, "masked_author": "username_1", "text": "This was fixed in bfa50767abf.\r\n\r\nThanks @username_0!", "title": null, "type": "comment" } ]
2
3
196
false
false
196
true
SpiderLabs/net-tns
SpiderLabs
80,978,015
18
null
[ { "action": "opened", "author": "claudijd", "comment_id": null, "datetime": 1432649331000, "masked_author": "username_0", "text": "NoMethodError: undefined method `chr' for true:TrueClass\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/crypto.rb:141:in `block in create_combined_session_key_hash_11g'\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/crypto.rb:140:in `each'\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/crypto.rb:140:in `create_combined_session_key_hash_11g'\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/crypto.rb:68:in `get_11g_auth_values'\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:72:in `get_auth_request'\r\n\tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:37:in `authenticate'\r\n\tfrom (irb):5\r\n\tfrom /Users/jclaudius/.rvm/rubies/ruby-2.1.4/bin/irb:11:in `<main>'", "title": "Not detecting default credentials on Oracle 11g2", "type": "issue" }, { "action": "created", "author": "woodbusy", "comment_id": 111518044, "datetime": 1434120911000, "masked_author": "username_1", "text": "I think I remember seeing this before, but I no longer have access to an 11g R2 server. Could you add a pcap or a branch with added (failing) specs?", "title": null, "type": "comment" }, { "action": "created", "author": "claudijd", "comment_id": 112781274, "datetime": 1434544297000, "masked_author": "username_0", "text": "I just sent you a PCAP of the above activity. Sorry for the delay.", "title": null, "type": "comment" }, { "action": "created", "author": "mrakhmanov", "comment_id": 112881966, "datetime": 1434561456000, "masked_author": "username_2", "text": "The server (11g2) sends 10g style response to the client because the negotiation does not fully follow 11g2 protocol. Acting differently based upon auth_sesskey.length may help to solve this particular problem. There is a another issue: authentication code is not reached for many targets having different platform, architecture, and version different from what the client has. TTIDTY message exchange phase which happens just before AUTH does not complete successfully.", "title": null, "type": "comment" }, { "action": "created", "author": "woodbusy", "comment_id": 120536011, "datetime": 1436564392000, "masked_author": "username_1", "text": "@username_2 thanks for your wisdom. I appreciate it! I'm not surprised that there are other issues, given my limited testing environment and knowledge of TTI - DTY especially is almost a complete mystery to me. If you have any more specifics you could comment on or create issues for, that would be great.\r\n\r\n@username_0 I took @username_2's approach with the code in #20. If you (or anyone else with an 11g2 server) could try it out, that would be great.", "title": null, "type": "comment" }, { "action": "created", "author": "claudijd", "comment_id": 120966432, "datetime": 1436801048000, "masked_author": "username_0", "text": "?> tti_client.authenticate( \"test\", \"NOT_THE_PASSWORD\" )\r\n Net::TTI::Exceptions::ProtocolException: Unexpected AUTH_SESSKEY length: 32\r\n from /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:74:in `get_auth_request'\r\n from /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:37:in `authenticate'\r\n from (irb):7\r\n from /Users/jclaudius/.rvm/rubies/ruby-2.1.4/bin/irb:11:in `<main>'\r\n\r\nFWIW, I get the same error for valid (as I know them) and invalid creds. @username_2 any chance the creds changed recently from what was previously provided?", "title": null, "type": "comment" }, { "action": "created", "author": "claudijd", "comment_id": 121317677, "datetime": 1436895308000, "masked_author": "username_0", "text": "Net::TTI::Exceptions::InvalidCredentialsError: ORA-01017: invalid username/password; logon denied\r\n\r\n \tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:43:in `rescue in authenticate'\r\n \tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:31:in `authenticate'\r\n \tfrom (irb):6\r\n \tfrom /Users/jclaudius/.rvm/rubies/ruby-2.1.4/bin/irb:11:in `<main>'", "title": null, "type": "comment" }, { "action": "created", "author": "claudijd", "comment_id": 121320103, "datetime": 1436895832000, "masked_author": "username_0", "text": "Net::TTI::Exceptions::ProtocolException: Unexpected AUTH_SESSKEY length: 32\r\n \tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:74:in `get_auth_request'\r\n \tfrom /Users/jclaudius/code/net-tns/lib/net/tti/client.rb:37:in `authenticate'\r\n \tfrom (irb):6\r\n \tfrom /Users/jclaudius/.rvm/rubies/ruby-2.1.4/bin/irb:11:in `<main>'\r\n\r\nIt seems @username_2's changes are more accurate, but the specs will need to be updated to get them passing.", "title": null, "type": "comment" }, { "action": "created", "author": "claudijd", "comment_id": 121321685, "datetime": 1436896194000, "masked_author": "username_0", "text": "Additionally, we should probably also validate that we can check default creds on a range of supported Oracle DB endpoints. I'm not that familiar with Oracle versions to determine what we should test against, but open to suggestions.", "title": null, "type": "comment" }, { "action": "created", "author": "woodbusy", "comment_id": 124624132, "datetime": 1437763692000, "masked_author": "username_1", "text": "@username_0 yeah, looks like I'm bad at math (16 and 24 in the `case` should have been 32 and 48). Going forward, I think that @username_2's changes are going to be a huge improvement, so I'm going to focus on that path rather than #20.", "title": null, "type": "comment" } ]
3
10
3,676
false
false
3,676
true
conda/conda
conda
142,327,200
2,293
null
[ { "action": "opened", "author": "spala-mosxou", "comment_id": null, "datetime": 1458561677000, "masked_author": "username_0", "text": "While trying to install brian simulator with the conda install at win64 system I got the following error output:\r\n![problem](https://cloud.githubusercontent.com/assets/6384503/13918037/ed3b9f2e-ef64-11e5-8c39-92f72a704089.jpg)", "title": "Problem with conda install of package 'brian2' for win64", "type": "issue" }, { "action": "created", "author": "kalefranz", "comment_id": 299614515, "datetime": 1494044277000, "masked_author": "username_1", "text": "Code path no longer exists in recent versions of conda. Should be long-ago resolved.", "title": null, "type": "comment" }, { "action": "closed", "author": "kalefranz", "comment_id": null, "datetime": 1494044277000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
4
498
false
true
311
false
pfsense/pfsense
pfsense
238,403,861
3,768
{ "number": 3768, "repo": "pfsense", "user_login": "pfsense" }
[ { "action": "opened", "author": "PiBa-NL", "comment_id": null, "datetime": 1498422276000, "masked_author": "username_0", "text": "notices, background delivery of growl messages and combined mail messages from a queue so that in case of failure the timeout period for connecting does not impact the functionality of the calling scripts themselves\r\n\r\n1st message is delivered directly after it is queued.\r\n2nd and following messages that are send within a 10 second window are combined into 1 email\r\nwhen no emails were send for 1 minute, then the monitor script ends and a new 1st message can be delivered directly after it gets queued", "title": "notices, background delivery of growl messages and combined mail messages from a queue", "type": "issue" }, { "action": "created", "author": "PiBa-NL", "comment_id": 315186150, "datetime": 1499976007000, "masked_author": "username_0", "text": "Should improve/fix : https://redmine.pfsense.org/issues/4031 as well.", "title": null, "type": "comment" } ]
1
2
573
false
false
573
false
FreeUKGen/MyopicVicar
FreeUKGen
225,272,879
1,194
null
[ { "action": "opened", "author": "edickens", "comment_id": null, "datetime": 1493487494000, "masked_author": "username_0", "text": "", "title": "Malware?", "type": "issue" }, { "action": "created", "author": "edickens", "comment_id": 298183272, "datetime": 1493487614000, "masked_author": "username_0", "text": "Have had this from Glen (WLS)...\n\nWhen I sign into FreeREG I get a pop-up of the following:-\n\nDo you want to open or save ac.js from static-tagr.gd1.mookie1.com\n\nI have had Norton look at my computer and they have cleared anything here. It only happens on signing in or working in FreeREG and no other site.\n\nThey have suggested I contact you as they suspect the malware is based with you.\n\n\nIt does not happen to me.\n\nAdvice for Glen please.\n\n Eric", "title": null, "type": "comment" }, { "action": "created", "author": "Sherlock21", "comment_id": 298189704, "datetime": 1493494409000, "masked_author": "username_1", "text": "I have just tried to Log on to FR, Completely normal and successful. -No messages from my ISP nor my own security. ( Im on iMac and my ISP is Plusnet.)\r\n\r\nAnd logon was even faster than of late - have we put the revised structure into service on FR then?", "title": null, "type": "comment" }, { "action": "created", "author": "Captainkirkdawson", "comment_id": 298198795, "datetime": 1493505432000, "masked_author": "username_2", "text": "Eric\n\nI do not believe there are any malware issues for FreeREG\n\nAn infected computer is extremely tough to clean.\n\nIt could be from an ad which is why he sees it and no one else does. Ads\nare selected based on what the user has been interested in and his/her\nbrowsing history.\n\nK\n\nKirk Dawson\n5220 Riverside Drive\nFairmont Hot Springs, B.C.\nV0B 1L1", "title": null, "type": "comment" }, { "action": "created", "author": "PatReynolds", "comment_id": 298221777, "datetime": 1493544687000, "masked_author": "username_3", "text": "I agree with Kirk, the malware is probably coming from an advert. This is a\nknown issue (as a quick google search shows). If possible, can Glen take a\nscreenshot of the advert (s) which show when this happens? I can then\nraise the issue with Google.\n\nBest wishes,\n\nPat\n\nOn 29 April 2017 at 23:37, Kirk Dawson <notifications@github.com> wrote:\n\n> Eric\n>\n> I do not believe there are any malware issues for FreeREG\n>\n> An infected computer is extremely tough to clean.\n>\n> It could be from an ad which is why he sees it and no one else does. Ads\n> are selected based on what the user has been interested in and his/her\n> browsing history.\n>\n> K\n>\n> Kirk Dawson\n> 5220 Riverside Drive\n> Fairmont Hot Springs, B.C.\n> V0B 1L1\n>\n>", "title": null, "type": "comment" }, { "action": "created", "author": "PatReynolds", "comment_id": 298221861, "datetime": 1493544812000, "masked_author": "username_3", "text": "We haven't got the revised structure in place, but we (well, Lemon) has\nswapped out a defective disk in Saki.\n\nLemon will be doing his bit on the shard system next week (i.e. starting\ntomorrow) and Kirk has been working on it and will need a few more weeks\nbefore it's all in place.\n\nBest wishes,\n\nPat", "title": null, "type": "comment" }, { "action": "created", "author": "edickens", "comment_id": 299923360, "datetime": 1494262170000, "masked_author": "username_0", "text": "Sorted. Can be closed.", "title": null, "type": "comment" }, { "action": "closed", "author": "Captainkirkdawson", "comment_id": null, "datetime": 1494283625000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
4
8
2,102
false
false
2,102
false
ConSol/sakuli
ConSol
137,109,197
168
null
[ { "action": "opened", "author": "simonmeggle", "comment_id": null, "datetime": 1456701158000, "masked_author": "username_0", "text": "When installing Sakuli in Windows, certain settings (e.g. disabled cleartype fonts) take effect only after a reboot. Only then the example test suite will work. \r\n-> add a hint in the end of the installer that it is time to reboot now.", "title": "installer: add reboot hint ", "type": "issue" }, { "action": "closed", "author": "toschneck", "comment_id": null, "datetime": 1456761524000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
235
false
false
235
false
yob/pdf-reader
null
241,492,567
245
null
[ { "action": "opened", "author": "bcoles", "comment_id": null, "datetime": 1499563768000, "masked_author": "username_0", "text": "pdf-reader crashes with the attached malformed PDF file.\r\n\r\n[20170708204242079587195_test_652.pdf](https://github.com/username_2/pdf-reader/files/1133488/20170708204242079587195_test_652.pdf)\r\n\r\n\r\n### Crash\r\n\r\n```\r\n[*] Processing 'crashes/20170708204242079587195_test_652.pdf'\r\n/usr/local/rvm/gems/ruby-2.3.0/gems/ruby-rc4-0.1.5/lib/rc4.rb:5:in `initialize': RC4: Key supplied is blank (SyntaxError)\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:158:in `new'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:158:in `block in auth_owner_pass'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:158:in `downto'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:158:in `each'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:158:in `auth_owner_pass'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:220:in `build_standard_key'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/standard_security_handler.rb:57:in `initialize'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/object_hash.rb:295:in `new'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/object_hash.rb:295:in `build_security_handler'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader/object_hash.rb:49:in `initialize'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader.rb:116:in `new'\r\n\tfrom /usr/local/rvm/gems/ruby-2.3.0/gems/pdf-reader-2.0.0/lib/pdf/reader.rb:116:in `initialize'\r\n\tfrom ./read-pdf.rb:43:in `new'\r\n\tfrom ./read-pdf.rb:43:in `read'\r\n\tfrom ./read-pdf.rb:95:in `<main>'\r\n```\r\n\r\n\r\n### Reproduce\r\n\r\n```\r\n#!/usr/bin/env ruby\r\nrequire 'pdf-reader'\r\nrequire 'colorize'\r\n\r\n$QUIET = false\r\n\r\n#\r\n# Print status message\r\n#\r\n# @param [String] msg message to print\r\n#\r\ndef print_status(msg = '')\r\n puts '[*] '.blue + msg unless $QUIET\r\nend\r\n\r\n#\r\n# Print progress messages\r\n#\r\n# @param [String] msg message to print\r\n#\r\ndef print_good(msg = '')\r\n puts '[+] '.green + msg unless $QUIET\r\nend\r\n\r\n#\r\n# Print error message\r\n#\r\n# @param [String] msg message to print\r\n#\r\ndef print_error(msg = '')\r\n puts '[-] '.red + msg unless $QUIET\r\nend\r\n\r\n#\r\n# Read a PDF file\r\n#\r\n# @param [File] file PDF file\r\n#\r\ndef read doc\r\n print_status \"Processing '#{doc}'\"\r\n begin\r\n @fname = doc\r\n reader = PDF::Reader.new(@fname)\r\n rescue PDF::Reader::MalformedPDFError\r\n print_error \"Could not parse PDF '#{doc}': PDF is malformed\"\r\n exit 1\r\n rescue PDF::Reader::UnsupportedFeatureError \r\n print_error \"Could not parse PDF '#{doc}': PDF::Reader::UnsupportedFeatureError\"\r\n exit 1\r\n end\r\n print_good 'Processing complete'\r\n\r\n print_status \"Parsing '#{@fname}'\"\r\n begin\r\n parse reader\r\n rescue PDF::Reader::UnsupportedFeatureError\r\n print_error \"Could not parse PDF '#{doc}': PDF::Reader::UnsupportedFeatureError\"\r\n exit 1\r\n rescue PDF::Reader::MalformedPDFError => e\r\n print_error \"Could not parse PDF '#{doc}': PDF is malformed\"\r\n exit 1\r\n end\r\n print_good 'Parsing complete'\r\nend\r\n\r\n#\r\n# parse pdf\r\n#\r\ndef parse(reader)\r\n print_status \"Version: #{reader.pdf_version}\"\r\n print_status \"Info: #{reader.info}\"\r\n print_status \"Metadata: #{reader.metadata}\"\r\n print_status \"Objects: #{reader.objects}\"\r\n print_status \"Pages: #{reader.page_count}\"\r\n\r\n print_status 'Dumping PDF contents...'\r\n contents = ''\r\n reader.pages.each do |page|\r\n contents << page.text.to_s\r\n contents << page.fonts.to_s\r\n contents << page.text.to_s\r\n contents << page.raw_content.to_s\r\n end\r\n #puts contents unless $QUIET\r\nend\r\n\r\ndef usage\r\n print_status \"./read-pdf.rb <FILE>\"\r\n exit 1\r\nend\r\n\r\ndoc = ARGV[0]\r\nusage if doc.nil?\r\n\r\nif File.exist? doc\r\n read doc\r\n exit 0\r\nelse\r\n print_error \"Could not find #{doc}\"\r\n exit 1\r\nend\r\n```", "title": "Malformed PDF raises `RC4: Key supplied is blank (SyntaxError)`", "type": "issue" }, { "action": "created", "author": "bcoles", "comment_id": 313891549, "datetime": 1499563816000, "masked_author": "username_0", "text": "This issue is problematic as `SyntaxError` will not be handled by a `rescue` clause unless the author is in the bad habit of using `rescue Exception`, or happens to `rescue SyntaxError` specifically.", "title": null, "type": "comment" }, { "action": "created", "author": "ndbroadbent", "comment_id": 333383129, "datetime": 1506870544000, "masked_author": "username_1", "text": "Can this also be closed? (See: #249 and https://github.com/caiges/Ruby-RC4/pull/15)\r\n\r\nOr should pdf-reader also raise a `MalformedPDFError` in this case?", "title": null, "type": "comment" }, { "action": "created", "author": "bcoles", "comment_id": 333443408, "datetime": 1506921794000, "masked_author": "username_0", "text": "@username_1 This issue is not resolved.\r\n\r\nThe Ruby-RC4 library has been patched and no longer raises `SyntaxError`, but a new version of the gem hasn't been released (since 2012).\r\n\r\nThis issue cannot be closed until a new version of Ruby-RC4 is released, or if the Gemfile is modified to pull the dependency in directly from Github, which isn't ideal.\r\n\r\nI created PR #249 to raise `ArgumentError` rather than `SyntaxError`, but closed the PR on the assumption that the Ruby RC4 team would release a new version in a timely manner. That turns out to have been an unsafe assumption.", "title": null, "type": "comment" }, { "action": "closed", "author": "yob", "comment_id": null, "datetime": 1642027966000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
5
5,004
false
false
5,004
true
SoftwareDefinedBuildings/XBOS
SoftwareDefinedBuildings
208,516,037
12
null
[ { "action": "opened", "author": "gtfierro", "comment_id": null, "datetime": 1487355038000, "masked_author": "username_0", "text": "Spawnpoints have been going down, and we're not quite sure the cause. Need to do some testing to make sure that autoRestart is working properly\r\n\r\n- [ ] ensure deployed, problematic spawnpoints are up-to-date\r\n- [ ] ensure deployed drivers have autoRestart in the configs", "title": "Verify autoRestart work", "type": "issue" }, { "action": "created", "author": "jhkolb", "comment_id": 285835346, "datetime": 1489199672000, "masked_author": "username_1", "text": "The issue with `spawnd` itself should now be resolved. We'll want to update deployed spawnpoints, and ensuring `autoRestart` on service configs also remains to be done.", "title": null, "type": "comment" }, { "action": "created", "author": "jhkolb", "comment_id": 287887551, "datetime": 1490041749000, "masked_author": "username_1", "text": "The only potentially remaining issue is checking that all of our deployed drivers have auto-restart enabled. I believe all the drivers on Garber do.", "title": null, "type": "comment" }, { "action": "closed", "author": "gtfierro", "comment_id": null, "datetime": 1490043428000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
587
false
false
587
false
DonJayamanne/pythonVSCode
null
225,291,411
924
null
[ { "action": "opened", "author": "waleedka", "comment_id": null, "datetime": 1493507207000, "masked_author": "username_0", "text": "I'm using remote debugging (with ptvsd) to debug my Python 3.5 code running in a Docker container. For the most part it's working great, I can put breakpoints and step through the code. But I can't seem to step into library functions. The \"step into\" command works when stepping into a function defined in my source code file, but not on functions defined in a library I've imported. Further, if the library function calls into my code, the call stack shows \"Unknown Source\" (see image). \r\n\r\nI tried to add the \"DebugStdLib\" as explained [here](https://github.com/username_1/pythonVSCode/wiki/Debug-Library-Functions) but vscode complained that \"debugOptions\" is not an allowed property. I'm guessing it doesn't work with remote type of debugging?\r\n\r\n## Environment data\r\nVS Code version: 1.11.2\r\nPython Extension version: 0.6.3\r\nPython Version: 3.5.2\r\nOS and version: OSX 10.11.6\r\nOS running in the Docker container: Ubuntu 16.04\r\n\r\n![vscode](https://cloud.githubusercontent.com/assets/106472/25559702/d217aa98-2cf4-11e7-8106-dfe0be22aa03.png)\r\n\r\n## launch.json\r\n```javascript\r\n {\r\n \"name\": \"Attach (Docker)\",\r\n \"type\": \"python\",\r\n \"request\": \"attach\",\r\n // localRoot == remoteRoot. Folder in the docker container mapped to folder in host OS\r\n \"localRoot\": \"${workspaceRoot}\",\r\n \"remoteRoot\": \"${workspaceRoot}\",\r\n \"port\": 8888,\r\n \"secret\": \"my_secret\",\r\n \"host\": \"localhost\",\r\n // vscode didn't like me adding this property. Says property is not allowed\r\n //\"debugOptions\": [\r\n // \"DebugStdLib\"\r\n //]\r\n }\r\n``` \r\n\r\nAny tips to get this working? Or is this not supported in vscode?", "title": "Remote Debugging Library Functions ", "type": "issue" }, { "action": "created", "author": "DonJayamanne", "comment_id": 311943425, "datetime": 1498736954000, "masked_author": "username_1", "text": "Yes, unfortunately debugging library functions won't work at this stage. Will look into this.", "title": null, "type": "comment" }, { "action": "closed", "author": "DonJayamanne", "comment_id": null, "datetime": 1510613924000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "DonJayamanne", "comment_id": 344088046, "datetime": 1510613924000, "masked_author": "username_1", "text": "This issue was moved to Microsoft/vscode-python#111", "title": null, "type": "comment" } ]
2
4
1,897
false
false
1,897
true
antoinecarme/pyaf
null
225,419,737
48
null
[ { "action": "opened", "author": "antoinecarme", "comment_id": null, "datetime": 1493636734000, "masked_author": "username_0", "text": "PyAF has a API call lEngine.standardPlots(). It gives some classical plots (signal against forecast, residues, trends, cycles, AR)\r\n\r\nDocument the plots generated. \r\n\r\nThe REST service (issue #20 ) also gives the same plots in a png/base64 encoding, to be documented.", "title": "Add a document about plotting features of PyAF", "type": "issue" }, { "action": "created", "author": "antoinecarme", "comment_id": 298319358, "datetime": 1493636768000, "masked_author": "username_0", "text": "Also document hierarchical plots.", "title": null, "type": "comment" } ]
1
2
301
false
false
301
false
stealjs/steal
stealjs
69,457,590
402
{ "number": 402, "repo": "steal", "user_login": "stealjs" }
[ { "action": "opened", "author": "cklanac", "comment_id": null, "datetime": 1429472689000, "masked_author": "username_0", "text": "Simple typo fix \"ES6 to ES5\"", "title": "Fix typo", "type": "issue" }, { "action": "created", "author": "matthewp", "comment_id": 94457524, "datetime": 1429538191000, "masked_author": "username_1", "text": "Thanks.", "title": null, "type": "comment" } ]
2
2
35
false
false
35
false
evnaz/ENSwiftSideMenu
null
47,171,826
22
null
[ { "action": "opened", "author": "ncerezo", "comment_id": null, "datetime": 1414600791000, "masked_author": "username_0", "text": "When the screen rotates the menu does not update it's position, that leads to it to be visible if hidden and in the wrong place. It also makes it disappear if you try to hide/show it.\r\nI'm making a pull request to fix it.", "title": "Incorrect behavior when screen rotates", "type": "issue" }, { "action": "created", "author": "animaonline", "comment_id": 100643187, "datetime": 1431265370000, "masked_author": "username_1", "text": "Has this been fixed, I´m still seeing this issue.", "title": null, "type": "comment" }, { "action": "created", "author": "ncerezo", "comment_id": 100833868, "datetime": 1431337158000, "masked_author": "username_0", "text": "It was fixed, but someone later on made the updateFrame function private.\r\nYou need to call that from didRotateFromInterfaceOrientation (iOS 7) or viewWillTransitionToSize (iOS 8) from the view controllers.\r\nI'm using a subclass of UIViewController that makes the necessary calls, and then inheriting my controllers from it.\r\nHowever, the fix worked only for iOS 8, since iOS 7 will not swap height and width when on portrait mode.\r\nI'm working on a fix for both iOS 7 and iOS 8, will make the pull request soon. I'll make sure to put a big notice on updateFrame so no one will make it private again.", "title": null, "type": "comment" }, { "action": "created", "author": "ncerezo", "comment_id": 100866696, "datetime": 1431341226000, "masked_author": "username_0", "text": "I just made a pull request fixing this.", "title": null, "type": "comment" }, { "action": "created", "author": "animaonline", "comment_id": 100867755, "datetime": 1431341546000, "masked_author": "username_1", "text": "Yeah, I ended up using viewWillTransitionToSize and animateAlongsideTransition, but it still doesn't work correctly when the menu is positioned to the right.\r\n\r\nThis can be easily reproduced in the example project.", "title": null, "type": "comment" }, { "action": "created", "author": "ncerezo", "comment_id": 100869497, "datetime": 1431342255000, "masked_author": "username_0", "text": "I'm using it with the menu positioned to the right, and it works with the changes I've submitted.\r\nI've finally used viewDidLayoutSubviews, because it is a single call that works both for iOS7 and iOS8+ and because it really makes more sense, since it is a layout what is done.", "title": null, "type": "comment" }, { "action": "created", "author": "animaonline", "comment_id": 100869631, "datetime": 1431342325000, "masked_author": "username_1", "text": "In my example I had over 30 items in it, so that could be the reason.", "title": null, "type": "comment" } ]
2
7
1,469
false
false
1,469
false
SumoLogic/sumologic-python-sdk
SumoLogic
136,150,579
8
null
[ { "action": "opened", "author": "sumoway", "comment_id": null, "datetime": 1456339395000, "masked_author": "username_0", "text": "Need to look into whether and how we can change the name and if that will break anything.", "title": "rest-python-client is a more appropriate name", "type": "issue" }, { "action": "created", "author": "MelchiSalins", "comment_id": 192825628, "datetime": 1457251214000, "masked_author": "username_1", "text": "Are you suggesting the package be renamed and drop \"sumologic\" completely out of it? The immediate concern that comes to my mind is people will not find the package as easily anymore.", "title": null, "type": "comment" }, { "action": "created", "author": "sumoway", "comment_id": 193340857, "datetime": 1457369409000, "masked_author": "username_0", "text": "@username_1 it was just a thought, and you've already pointed out a problem with it, thanks!", "title": null, "type": "comment" }, { "action": "closed", "author": "sumoway", "comment_id": null, "datetime": 1457369409000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
366
false
false
366
true
fastlane/fastlane
fastlane
214,937,020
8,567
null
[ { "action": "opened", "author": "gtatgh", "comment_id": null, "datetime": 1489739351000, "masked_author": "username_0", "text": "### Issue Description\r\n\r\nI'am new to `fastlane` and I think, i have a build problem with `xcodebuild`, not `fastlane` itself. So I am trying to exort my project with `fastlane gym`, but it fails on building a _WatchKit Extension_ target. There is missing provisioning profile created by Xcode itself. This PP is not listed at Apple Dev Portal, it exists **only** local on my developer machine. This PP is generic one, also does not contains an app id. So i tried to create one by `match` and build again, but it fails. Only specific PP created by Xcode is able to build _WatchKit Extension_ target.\r\n\r\n[PP created by Xcode](http://prnt.sc/el07i0)\r\n[PP created by match](http://prnt.sc/el07nq)\r\n\r\nSo my question is it possible to add this PP created by Xcode to provisioning provile repo? And how can i do that?\r\n\r\n<details><summary>✅ Matchfile ✅</summary>\r\ngit_url \"ssh://***/ios_certificates.git\"\r\ntype \"adhoc\" # The default type, can be: appstore, adhoc or development\r\napp_identifier [\"*\", \"com.app.MyApp\"]\r\n</details>\r\n\r\n##### Complete output when running fastlane, including the stack trace and command used\r\n\r\n<details><summary>✅ fastlane log output ✅</summary>\r\n\r\n08:39 username_0:MyApp-ios-app$ fastlane gym\r\n[08:39:26]: Successfully loaded '/Users/username_0/projects/ios/apps/MyApp-ios-app/fastlane/Gymfile' 📄\r\n\r\n+---------------------+---------------------+\r\n| Detected Values from './fastlane/Gymfile' |\r\n+---------------------+---------------------+\r\n| workspace | MyApp.xcworkspace |\r\n| scheme | MyApp |\r\n| export_method | ad-hoc |\r\n| output_directory | output |\r\n| clean | true |\r\n+---------------------+---------------------+\r\n\r\n[08:39:26]: Successfully loaded '/Users/username_0/projects/ios/apps/MyApp-ios-app/fastlane/Gymfile' 📄\r\n[08:39:26]: No values defined in './fastlane/Gymfile'\r\n[08:39:27]: $ xcodebuild -list -workspace MyApp.xcworkspace\r\n[08:39:27]: $ xcodebuild clean -showBuildSettings -workspace MyApp.xcworkspace -scheme MyApp\r\n\r\n+----------------------+-------------------------+\r\n| Summary for gym 2.20.0 |\r\n+----------------------+-------------------------+\r\n| workspace | MyApp.xcworkspace |\r\n| scheme | MyApp |\r\n| export_method | ad-hoc |\r\n| output_directory | output |\r\n| clean | true |\r\n| destination | generic/platform=iOS |\r\n| output_name | MyApp |\r\n| silent | false |\r\n| use_legacy_build_api | false |\r\n| buildlog_path | ~/Library/Logs/gym |\r\n| xcode_path | /Applications/Xcode.app |\r\n+----------------------+-------------------------+\r\n\r\n[08:39:28]: $ set -o pipefail && xcodebuild -workspace MyApp.xcworkspace -scheme MyApp -destination 'generic/platform=iOS' -archivePath /Users/username_0/Library/Developer/Xcode/Archives/2017-03-17/MyApp\\ 2017-03-17\\ 08.39.28.xcarchive clean archive | tee /Users/username_0/Library/Logs/gym/MyApp-MyApp.log | xcpretty\r\n[08:39:29]: ▸ Cleaning Pods/MGSwipeTableCell [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning Pods/iToast [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning Pods/IQKeyboardManager [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning MyApp/MyAppWatch Extension [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning Pods/FMDB-iOS8.0 [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning MyApp/MyAppWatch [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning Pods/Pods-MyApp [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Cleaning MyApp/MyApp [Debug]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Clean Succeeded\r\n[08:39:29]: ▸ Building MyApp/MyAppWatch Extension [Release]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:29]: ▸ Code signing is required for product type 'WatchKit Extension' in SDK 'watchOS 3.1'\r\n[08:39:29]: ▸ Building Pods/FMDB-iOS8.0 [Release]\r\n[08:39:29]: ▸ Check Dependencies\r\n[08:39:30]: ▸ Building Pods/IQKeyboardManager [Release]\r\n[08:39:30]: ▸ Check Dependencies\r\n[08:39:30]: ▸ Building Pods/MGSwipeTableCell [Release]\r\n[08:39:30]: ▸ Check Dependencies\r\n[08:39:30]: ▸ Processing Info.plist\r\n[08:39:30]: ▸ Compiling MGSwipeButton.m\r\n[08:39:30]: ▸ Compiling MGSwipeTableCell-dummy.m\r\n[08:39:30]: ▸ Building Pods/iToast [Release]\r\n[08:39:30]: ▸ Check Dependencies\r\n[08:39:30]: ▸ Processing Info.plist\r\n[08:39:30]: ▸ Compiling iToast-dummy.m\r\n[08:39:30]: ▸ Compiling iToast.m\r\n[08:39:30]: ▸ Compiling iToast_vers.c\r\n[08:39:30]: ▸ Compiling iToast-dummy.m\r\n[08:39:30]: ▸ Compiling iToast.m\r\n[08:39:30]: ▸ Compiling iToast_vers.c\r\n[08:39:30]: ▸ ** ARCHIVE FAILED **\r\n[08:39:30]: ▸ The following build commands failed:\r\n[08:39:30]: ▸ Check dependencies\r\n[08:39:30]: ▸ (1 failure)\r\n▸ Cleaning Pods/MGSwipeTableCell [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning Pods/iToast [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning Pods/IQKeyboardManager [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning MyApp/MyAppWatch Extension [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning Pods/FMDB-iOS8.0 [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning MyApp/MyAppWatch [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning Pods/Pods-MyApp [Debug]\r\n▸ Check Dependencies\r\n▸ Cleaning MyApp/MyApp [Debug]\r\n▸ Check Dependencies\r\n▸ Clean Succeeded\r\n▸ Building MyApp/MyAppWatch Extension [Release]\r\n▸ Check Dependencies\r\n\r\nCode signing is required for product type 'WatchKit Extension' in SDK 'watchOS 3.1'\r\n\r\n\r\n▸ Building Pods/FMDB-iOS8.0 [Release]\r\n▸ Check Dependencies\r\n▸ Building Pods/IQKeyboardManager [Release]\r\n▸ Check Dependencies\r\n▸ Building Pods/MGSwipeTableCell [Release]\r\n▸ Check Dependencies\r\n▸ Processing Info.plist\r\n▸ Compiling MGSwipeButton.m\r\n▸ Compiling MGSwipeTableCell-dummy.m\r\n▸ Building Pods/iToast [Release]\r\n▸ Check Dependencies\r\n▸ Processing Info.plist\r\n▸ Compiling iToast-dummy.m\r\n▸ Compiling iToast.m\r\n▸ Compiling iToast_vers.c\r\n▸ Compiling iToast-dummy.m\r\n▸ Compiling iToast.m\r\n▸ Compiling iToast_vers.c\r\n** ARCHIVE FAILED **\r\n\r\n\r\nThe following build commands failed:\r\nCheck dependencies\r\n(1 failure)\r\n[08:39:30]: Exit status: 65\r\n[08:39:30]: 📋 For a more detailed error log, check the full log at:\r\n[08:39:30]: 📋 /Users/username_0/Library/Logs/gym/MyApp-MyApp.log\r\n[08:39:30]: Found multiple versions of Xcode in '/Applications/'\r\n[08:39:30]: Make sure you selected the right version for your project\r\n[08:39:30]: This build process was executed using '/Applications/Xcode.app'\r\n[08:39:30]: If you want to update your Xcode path, either\r\n[08:39:30]: \r\n[08:39:30]: - Specify the Xcode version in your Fastfile\r\n[08:39:30]: ▸ xcversion(version: \"8.1\") # Selects Xcode 8.1.0\r\n[08:39:30]: \r\n[08:39:30]: - Specify an absolute path to your Xcode installation in your Fastfile\r\n[08:39:30]: ▸ xcode_select \"/Applications/Xcode8.app\"\r\n[08:39:30]: \r\n[08:39:30]: - Manually update the path using\r\n[08:39:30]: ▸ sudo xcode-select -s /Applications/Xcode.app\r\n[08:39:30]: \r\n\r\n+-------------+-------------------------+\r\n| Build environment |\r\n+-------------+-------------------------+\r\n| xcode_path | /Applications/Xcode.app |\r\n| gym_version | 2.20.0 |\r\n| sdk | iPhoneOS10.2.sdk |\r\n+-------------+-------------------------+\r\n\r\n\r\n[!] Error building the application - see the log above\r\n\r\n</details>\r\n\r\n### Environment\r\n\r\n<details><summary>✅ developer machine ✅</summary>\r\nusername_0:MyApp-ios-app$ xcodebuild -showsdks\r\niOS SDKs:\r\n\tiOS 10.2 \t-sdk iphoneos10.2\r\n\r\niOS Simulator SDKs:\r\n\tSimulator - iOS 10.2 \t-sdk iphonesimulator10.2\r\n\r\nmacOS SDKs:\r\n\tmacOS 10.12 \t-sdk macosx10.12\r\n\r\ntvOS SDKs:\r\n\ttvOS 10.1 \t-sdk appletvos10.1\r\n\r\ntvOS Simulator SDKs:\r\n\tSimulator - tvOS 10.1 \t-sdk appletvsimulator10.1\r\n\r\nwatchOS SDKs:\r\n\twatchOS 3.1 \t-sdk watchos3.1\r\n\r\nwatchOS Simulator SDKs:\r\n\tSimulator - watchOS 3.1 \t-sdk watchsimulator3.1\r\n\r\nusername_0:MyApp-ios-app$ xcodebuild -version\r\nXcode 8.2\r\nBuild version 8C38\r\nusername_0:MyApp-ios-app$ uname -a\r\nDarwin mac.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64\r\n</details>\r\n\r\n<details><summary>✅ fastlane environment ✅</summary>\r\n\r\n### Stack\r\n\r\n| Key | Value |\r\n| --------------------------- | ------------------------------------------- |\r\n| OS | 10.12.3 |\r\n| Ruby | 2.4.0 |\r\n| Bundler? | false |\r\n| Git | git version 2.9.2 |\r\n| Installation Source | ~/.rbenv/versions/2.4.0/bin/fastlane |\r\n| Host | Mac OS X 10.12.3 (16D32) |\r\n| Ruby Lib Dir | ~/.rbenv/versions/2.4.0/lib |\r\n| OpenSSL Version | OpenSSL 1.0.2k 26 Jan 2017 |\r\n| Is contained | false |\r\n| Is homebrew | false |\r\n| Is installed via Fabric.app | false |\r\n| Xcode Path | /Applications/Xcode.app/Contents/Developer/ |\r\n| Xcode Version | 8.2 |\r\n\r\n\r\n### System Locale\r\n\r\n| Variable | Value | |\r\n| -------- | ----------- | - |\r\n| LANG | de_DE.UTF-8 | ✅ |\r\n| LC_ALL | | |\r\n| LANGUAGE | | |\r\n\r\n\r\n### fastlane files:\r\n\r\n<details><summary>`./fastlane/Fastfile`</summary>\r\n\r\n```ruby\r\n# Customise this file, documentation can be found here:\r\n# https://github.com/fastlane/fastlane/tree/master/fastlane/docs\r\n# All available actions: https://docs.fastlane.tools/actions\r\n# can also be listed using the `fastlane actions` command\r\n\r\n# Change the syntax highlighting to Ruby\r\n# All lines starting with a # are ignored when running `fastlane`\r\n\r\n# If you want to automatically update fastlane if a new version is available:\r\n# update_fastlane\r\n\r\n# This is the minimum version number required.\r\n# Update this, if you use features of a newer version\r\nfastlane_version \"2.19.3\"\r\n\r\ndefault_platform :ios\r\n\r\nplatform :ios do\r\n before_all do\r\n # ENV[\"SLACK_URL\"] = \"https://hooks.slack.com/services/...\"\r\n cocoapods\r\n \r\n end\r\n\r\n desc \"Runs all the tests\"\r\n lane :test do\r\n scan\r\n end\r\n\r\n desc \"Submit a new Beta Build to Apple TestFlight\"\r\n desc \"This will also make sure the profile is up to date\"\r\n lane :beta do\r\n # match(type: \"appstore\") # more information: https://codesigning.guide\r\n gym # Build your app - more options available\r\n pilot\r\n\r\n # sh \"your_script.sh\"\r\n # You can also use other beta testing services here (run `fastlane actions`)\r\n end\r\n\r\n desc \"Deploy a new version to the App Store\"\r\n lane :release do\r\n # match(type: \"appstore\")\r\n # snapshot\r\n gym # Build your app - more options available\r\n deliver(force: true)\r\n # frameit\r\n end\r\n\r\n # You can define as many lanes as you want\r\n\r\n after_all do |lane|\r\n # This block is called, only if the executed lane was successful\r\n\r\n # slack(\r\n # message: \"Successfully deployed new App Update.\"\r\n # )\r\n end\r\n\r\n error do |lane, exception|\r\n # slack(\r\n # message: exception.message,\r\n # success: false\r\n # )\r\n end\r\nend\r\n\r\n\r\n# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md\r\n# All available actions: https://docs.fastlane.tools/actions\r\n\r\n# fastlane reports which actions are used\r\n# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer\r\n```\r\n</details>\r\n\r\n<details><summary>`./fastlane/Appfile`</summary>\r\n\r\n```ruby\r\napp_identifier \"com.gigatronik.app.M-Vap\" # The bundle identifier of your app\r\napple_id \"artem.werner@gigatronik.com\" # Your Apple email address\r\n\r\nteam_id \"EB7CQ2HWFZ\" # Developer Portal Team ID\r\n\r\n# you can even provide different app identifiers, Apple IDs and team names per lane:\r\n# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md\r\n```\r\n</details>\r\n\r\n### fastlane gems\r\n\r\n| Gem | Version | Update-Status |\r\n| -------- | ------- | ------------- |\r\n| fastlane | 2.20.0 | ✅ Up-To-Date |\r\n\r\n\r\n### Loaded fastlane plugins:\r\n\r\n**No plugins Loaded**\r\n\r\n\r\n<details><summary><b>Loaded gems</b></summary>\r\n\r\n| Gem | Version |\r\n| ------------------------- | ------------ |\r\n| did_you_mean | 1.1.0 |\r\n| slack-notifier | 1.5.1 |\r\n| i18n | 0.8.1 |\r\n| thread_safe | 0.3.6 |\r\n| tzinfo | 1.2.2 |\r\n| minitest | 5.10.1 |\r\n| activesupport | 4.2.8 |\r\n| CFPropertyList | 2.3.5 |\r\n| claide | 1.0.1 |\r\n| colored | 1.2 |\r\n| nanaimo | 0.2.3 |\r\n| xcodeproj | 1.4.2 |\r\n| rouge | 1.11.1 |\r\n| xcpretty | 0.2.4 |\r\n| terminal-notifier | 1.7.1 |\r\n| unicode-display_width | 1.1.3 |\r\n| terminal-table | 1.7.3 |\r\n| plist | 3.2.0 |\r\n| public_suffix | 2.0.5 |\r\n| addressable | 2.5.0 |\r\n| multipart-post | 2.0.0 |\r\n| word_wrap | 1.0.0 |\r\n| tty-screen | 0.5.0 |\r\n| babosa | 1.0.2 |\r\n| highline | 1.7.8 |\r\n| commander | 4.4.3 |\r\n| excon | 0.55.0 |\r\n| faraday | 0.11.0 |\r\n| unf_ext | 0.0.7.2 |\r\n| unf | 0.1.4 |\r\n| domain_name | 0.5.20170223 |\r\n| http-cookie | 1.0.3 |\r\n| faraday-cookie_jar | 0.0.6 |\r\n| fastimage | 2.1.0 |\r\n| gh_inspector | 1.0.3 |\r\n| uber | 0.0.15 |\r\n| representable | 2.3.0 |\r\n| retriable | 2.1.0 |\r\n| mime-types-data | 3.2016.0521 |\r\n| mime-types | 3.1 |\r\n| hurley | 0.2 |\r\n| little-plugger | 1.1.4 |\r\n| multi_json | 1.12.1 |\r\n| logging | 2.2.0 |\r\n| jwt | 1.5.6 |\r\n| memoist | 0.15.0 |\r\n| os | 0.9.6 |\r\n| signet | 0.7.3 |\r\n| googleauth | 0.5.1 |\r\n| httpclient | 2.8.3 |\r\n| google-api-client | 0.9.28 |\r\n| json | 2.0.2 |\r\n| mini_magick | 4.5.1 |\r\n| multi_xml | 0.6.0 |\r\n| rubyzip | 1.2.1 |\r\n| security | 0.1.3 |\r\n| xcpretty-travis-formatter | 0.0.4 |\r\n| dotenv | 2.2.0 |\r\n| bundler | 1.14.6 |\r\n| faraday_middleware | 0.11.0.1 |\r\n| io-console | 0.4.6 |\r\n| openssl | 2.0.2 |\r\n</details>\r\n\r\n\r\n*generated on:* **2017-03-17**\r\n</details>", "title": "Code signing is required for product type 'WatchKit Extension' in SDK 'watchOS 3.1'", "type": "issue" }, { "action": "created", "author": "hjanuschka", "comment_id": 287299421, "datetime": 1489740642000, "masked_author": "username_1", "text": "<img width=\"1070\" alt=\"bildschirmfoto 2017-03-17 um 09 48 26\" src=\"https://cloud.githubusercontent.com/assets/2891702/24035708/efe59d52-0af6-11e7-82b9-adf2f46a59a7.png\">\r\n\r\n\r\nto find the correct env variable to use, see the output of match it comes out like this:\r\n\r\n```\r\n+---------------------+----------------------------------------------------------------------------+----------------------------------------------------------------+\r\n| Installed Provisioning Profile |\r\n+---------------------+----------------------------------------------------------------------------+----------------------------------------------------------------+\r\n| Parameter | Environment Variable | Value |\r\n+---------------------+----------------------------------------------------------------------------+----------------------------------------------------------------+\r\n| App Identifier | | krone.at-krone.at.watchkitapp.watchkitextension |\r\n| Type | | appstore |\r\n| Profile UUID | sigh_krone.at-krone.at.watchkitapp.watchkitextension_appstore | 757988e4-0f7a-4799-b98a-a0e038bdc0dc |\r\n| Profile Name | sigh_krone.at-krone.at.watchkitapp.watchkitextension_appstore_profile-name | match AppStore krone.at-krone.at.watchkitapp.watchkitextension |\r\n| Development Team ID | sigh_krone.at-krone.at.watchkitapp.watchkitextension_appstore_team-id | H2YB79SEHH |\r\n+---------------------+----------------------------------------------------------------------------+----------------------------------------------------------------+\r\n```\r\n\r\nthe `profile-name` name variable is used\r\n\r\nlet me know if this helps you.", "title": null, "type": "comment" }, { "action": "created", "author": "gtatgh", "comment_id": 287304507, "datetime": 1489742216000, "masked_author": "username_0", "text": "@username_1 Thanks, i will try it.", "title": null, "type": "comment" }, { "action": "created", "author": "zaro0508", "comment_id": 289896762, "datetime": 1490733447000, "masked_author": "username_2", "text": "I'm a bit of a fastlane newbie. I'm using fastlane ver 2.22.0 and xcode 8.2 trying to run build on Travis. I'm also trying to use match to manage profiles and certs. I believe i have all that setup correctly so I was under the impression that if you are using match you don't need to configure what @username_1 suggested above to use fastlane with \"automatic code signing\". Isn't match supposed to handle that for you? I'm getting the same codesigning error as @username_0 and the only way I got it to build is by disabling \"automatic code signing\" in all targets in my project. \r\n\r\nAlso I'm wondering where disable_automatic_code_signing and enable_automatic_code_signing are coming from in @username_1 example. I don't see those in the [fastlane docs](https://docs.fastlane.tools/actions/). I do see update_project_provisioning however there's no parameter to allow disabling automatic code signing.", "title": null, "type": "comment" }, { "action": "created", "author": "mgrebenets", "comment_id": 289923847, "datetime": 1490739988000, "masked_author": "username_3", "text": "Hi @username_2 \r\n\r\n`match` doesn't touch your Xcode project.\r\n`match` is all about provisioning you Mac OS with certificates and profiles.\r\n\r\nWhen it comes to configuring Xcode project build settings - it's all up to a developer.\r\nIt can be done either manually by following the guides, or even by trying out some plugins or other tools. I've always been doing it by hand so far, either working with build settings directly or by moving the into `xcconfig` files.", "title": null, "type": "comment" }, { "action": "created", "author": "zaro0508", "comment_id": 292698371, "datetime": 1491632504000, "masked_author": "username_2", "text": "I've got fastlane match working and I can archive/export my project on Travis *only* if I disable \"automatically manage signing\" in all my targets.\r\n\r\nI then attempted to use do the toggle \"automatic manage signing\" trick suggested by @username_1 above however when i did that I get the error \"Code signing is required for product type 'WatchKit Extension' in SDK 'watchOS 3.1'\". I did notice that when I ran disable_automatic_code_signing then looked at my xcode project the \"automatically manage signing\" was disabled but the \"Provisioning Profile\" did not get set to value. I have setup the provisioning profile in xcode to \"$(sigh_org.sagebase.BridgeAppSDKSample_appstore_profile-name)\". Is there something else that needs to be done to get this working?\r\n\r\nThis my lane:\r\n\r\n```\r\n lane :archive do |options|\r\n scheme = options[:scheme]\r\n export_method = options[:export_method]\r\n certificates # call to run match\r\n disable_automatic_code_signing(path: \"BridgeAppSDK.xcodeproj\")\r\n gym(\r\n scheme: \"#{scheme}\",\r\n clean: true,\r\n include_bitcode: true,\r\n output_directory: \"./build\",\r\n output_name: \"#{scheme}.ipa\",\r\n export_method: \"#{export_method}\",\r\n destination: \"generic/platform=iOS\",\r\n )\r\n enable_automatic_code_signing(path: \"BridgeAppSDK.xcodeproj\")\r\n end\r\n```", "title": null, "type": "comment" }, { "action": "closed", "author": "gtatgh", "comment_id": null, "datetime": 1494950003000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "gtatgh", "comment_id": 301827386, "datetime": 1494950003000, "masked_author": "username_0", "text": "If someone have the same issue, here is the solution found. I have to set developer team id explicit `DEVELOPMENT_TEAM = $(sigh_com.mycompany.myapp.watchkitapp_adhoc_team-id)\";` for **all** targets.", "title": null, "type": "comment" }, { "action": "created", "author": "AndriyGo", "comment_id": 307978536, "datetime": 1497316581000, "masked_author": "username_4", "text": "@username_1 whenever I try to use match for the .watchkitapp (not .watchkitapp.watchkitextension) I get an error saying that an app with such ID does not exist on the Dev portal...", "title": null, "type": "comment" } ]
6
10
21,252
false
true
20,994
true
leebyron/async-to-gen
null
170,617,636
4
null
[ { "action": "opened", "author": "ilkkao", "comment_id": null, "datetime": 1470912468000, "masked_author": "username_0", "text": "This fails to compile:\r\n\r\n```\r\nclass Bar extends Object {\r\n static async create(props) {\r\n return 'foo';\r\n }\r\n};\r\n```\r\n\r\nNode error\r\n\r\n```\r\n/Users/ioksanen/git/mas/test.js:3\r\n async create(props) {return __async(function*(){\r\n ^^^^^^\r\nSyntaxError: Unexpected identifier\r\n at Object.exports.runInThisContext (vm.js:76:16)\r\n```\r\n\r\nProblem seems to be `static` keyword.", "title": "Support for static methods", "type": "issue" }, { "action": "closed", "author": "leebyron", "comment_id": null, "datetime": 1470943590000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
396
false
false
396
false
kubernetes/website
kubernetes
220,397,745
3,281
null
[ { "action": "opened", "author": "paul-hammant", "comment_id": null, "datetime": 1491655638000, "masked_author": "username_0", "text": "<!-- Thanks for filing an issue! Before submitting, please fill in the following information. -->\r\n\r\n<!--Required Information-->\r\n\r\n**This is a...** \r\n<!-- choose one by changing [ ] to [x] -->\r\n- [ ] Feature Request\r\n- [*] Bug Report\r\n\r\n**Problem:**\r\n\r\n\"Kubernetes is not:\" section - first bullet - \"Kubernetes does not limit the types of applications supported. It does not ...\" \r\n\r\nThere are bullets within that bullets. Or there should be. Or the section should be rethought. The \"not/doesn't\" connotation doesn't clearly associate with those implied sub-bullets.\r\n\r\nIt is also perilously close to double-negatives in places.\r\n\r\n**Proposed Solution:**\r\n\r\nRedo section somehow.\r\n\r\n**Page to Update:**\r\nhttps://kubernetes.io/docs/concepts/overview/what-is-kubernetes/", "title": "English Issue with what-is-kubernetes.md", "type": "issue" }, { "action": "created", "author": "bgrant0607", "comment_id": 359656498, "datetime": 1516675720000, "masked_author": "username_1", "text": "I am going to revamp this page, hopefully sometime soonish.", "title": null, "type": "comment" }, { "action": "created", "author": "paul-hammant", "comment_id": 359807427, "datetime": 1516717768000, "masked_author": "username_0", "text": "Yay!", "title": null, "type": "comment" }, { "action": "closed", "author": "bgrant0607", "comment_id": null, "datetime": 1518470369000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "bgrant0607", "comment_id": 365065474, "datetime": 1518470369000, "masked_author": "username_1", "text": "I simplified this bullet in #7349, so hopefully addressed.", "title": null, "type": "comment" } ]
3
6
1,286
false
true
891
false
pnpm/pnpm
pnpm
222,705,762
707
null
[ { "action": "opened", "author": "wintercounter", "comment_id": null, "datetime": 1492601151000, "masked_author": "username_0", "text": "### pnpm version: all\r\n\r\n### Code to reproduce the issue:\r\nAdd a custom git url as package.\r\n```\r\n\"my-custom-package\": \"git+ssh://git@mygit.site/package.git#v0.1.7\",\r\n```\r\n### Expected behavior:\r\nResolves package\r\n### Actual behavior:\r\nDoes not resolve package.", "title": "Cannot resolve external git packages", "type": "issue" }, { "action": "created", "author": "zkochan", "comment_id": 296655253, "datetime": 1493038091000, "masked_author": "username_1", "text": "@username_0 could you please recheck with latest pnpm. This might have been fixed by #717. If not, add the error stack trace that will be at the end of the `pnpm-debug.log` file", "title": null, "type": "comment" }, { "action": "created", "author": "FalloutPL", "comment_id": 296994596, "datetime": 1493117856000, "masked_author": "username_2", "text": "$ pnpm -v\r\n0.65.4\r\n\r\nNot fixed:\r\n\r\nURL from our gitlab: ```git@site:project/repo.git```\r\npackage: ```\"git+ssh://git@site:project/repo.git#master\"```\r\n```\r\n err: \r\n name: \"Error\"\r\n message: \"Command failed: git ls-remote --refs ssh://git@git.pf.com.pl/:eniro-crm/ecrm-fakerjs.git master\\nGitLab: The project you were looking for could not be found.\\nfatal: Could not read from remote repository.\\n\\nPlease make sure you have the correct access rights\\nand the repository exists.\\n\"\r\n code: 128\r\n ```\r\n\r\nit changes url to:\r\n\r\n```ssh://git@site/:project/repo.git```\r\n\r\nthan \r\n\r\n```ssh://git@site/project/repo.git```\r\n\r\nso\r\n\r\nthere is unwanted ```:``` in parsed url", "title": null, "type": "comment" }, { "action": "created", "author": "wintercounter", "comment_id": 297107949, "datetime": 1493141866000, "masked_author": "username_0", "text": "Strange, for me it fixes.", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 297108545, "datetime": 1493142000000, "masked_author": "username_1", "text": "@username_2 uses some different format. I'll look into that one later", "title": null, "type": "comment" }, { "action": "created", "author": "aaronfrost", "comment_id": 300860373, "datetime": 1494523783000, "masked_author": "username_3", "text": "I have the same issue as well. It looks like when you are using an organization, that may be the problem. Also have the same issue as @username_2. Here is a screenshot of my pnpm error log\r\n![image](https://cloud.githubusercontent.com/assets/662832/25963011/14fbdfd6-363d-11e7-9c17-8616844f76ef.png)\r\n\r\nI am not depending on pnpm yet. But sounds way fast. I would love it.", "title": null, "type": "comment" }, { "action": "created", "author": "aaronfrost", "comment_id": 300862927, "datetime": 1494524280000, "masked_author": "username_3", "text": "To add some additional info... my package.json has several other git urls in it. This is the only one that it fails on. So... this tells me that it DOES work with some git urls, but not others. And as I looked at all of the git urls, that was the one difference... that this one uses a `:` before the organization name, where the others don't. So, I think it must be around that specific usage.", "title": null, "type": "comment" }, { "action": "created", "author": "aaronfrost", "comment_id": 300864884, "datetime": 1494524687000, "masked_author": "username_3", "text": "I noticed that some of our other internal git urls in the `package.json` were formatted with the `/` before the org name instead of the `:`. So I changed this one, and tried `pnpm i` again, and it worked. So... \r\n\r\n- Those who have this same issue, true that. \r\n- For those who can fix this, it seems to be around that specifically. \r\n\r\n❤️ thanks for building this. It's pretty awesome!", "title": null, "type": "comment" }, { "action": "created", "author": "moos", "comment_id": 303864401, "datetime": 1495663345000, "masked_author": "username_4", "text": "Likewise with @username_2. Similar to [yarn#513](https://github.com/yarnpkg/yarn/issues/513). We also have multiple dependencies that use the git:ssh...:user/repo format. Bummer!\r\n```bash\r\n$ pnpm -v\r\n0.68.0\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 303866184, "datetime": 1495663835000, "masked_author": "username_1", "text": "I won't have time to fix it in the near future (maybe in two weeks I can look into it but cannot guarantee).\r\n\r\nIf someone has time, I think the fix will have to go to https://github.com/pnpm/pnpm/blob/master/src/resolve/git.ts\r\n\r\nAlso, I think this issue is a regression. I think it used to work till we updated [npm-package-arg](https://www.npmjs.com/package/npm-package-arg) to version 5. So `pnpm@0.46.6` and earlier versions of pnpm might not have this issue.", "title": null, "type": "comment" }, { "action": "created", "author": "moos", "comment_id": 303867175, "datetime": 1495664087000, "masked_author": "username_4", "text": "I can take a look -- can you point me to the appropriate test file?", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 303868256, "datetime": 1495664396000, "masked_author": "username_1", "text": "Here: https://github.com/pnpm/pnpm/blob/master/test/install/fromRepo.ts", "title": null, "type": "comment" }, { "action": "created", "author": "moos", "comment_id": 303892848, "datetime": 1495673686000, "masked_author": "username_4", "text": "Indeed, it's coming from npm-package-arg. I've opened [#22](https://github.com/npm/npm-package-arg/issues/22) on them. Incidentally, it seems to happen only for non-github.com hosted repos.\r\n\r\nA quick hack would be to use `saveSpec` rather than `fetchSpec` in fromRepo.ts and strip the initial 'git+'. Let's hope that's not necessary if they response quickly.", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 306045005, "datetime": 1496588246000, "masked_author": "username_1", "text": "Seems like this was an issue in npm5 as well and they have fixed it [here](https://github.com/npm/npm-package-arg/commit/b0c02c7383cc1455827c6f364a5c75d387c2654b)\r\n\r\nYou can try `pnpm@next` to see if the issue is gone. If so, I can also update the latest version of pnpm.", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 306582863, "datetime": 1496775239000, "masked_author": "username_1", "text": "@username_4 could you check whether this is fixed in the current latest [pnpm@0.69.1](https://github.com/pnpm/pnpm/releases/tag/v0.69.1)", "title": null, "type": "comment" }, { "action": "created", "author": "zkochan", "comment_id": 308504279, "datetime": 1497461776000, "masked_author": "username_1", "text": "Great!", "title": null, "type": "comment" }, { "action": "closed", "author": "zkochan", "comment_id": null, "datetime": 1497461776000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
5
17
3,950
false
false
3,950
true
pingcap/docs-cn
pingcap
249,532,412
241
null
[ { "action": "opened", "author": "alexliu5678", "comment_id": null, "datetime": 1502423025000, "masked_author": "username_0", "text": "1: spring -jdbc template>\r\n2:mybatis\r\n这些支持吗?不用修改就可以用?", "title": "java开发有什么api,还是jdbc就可以了?spring-jdbc, mybatis?", "type": "issue" }, { "action": "created", "author": "yikeke", "comment_id": 547242338, "datetime": 1572320349000, "masked_author": "username_1", "text": "We published a new [java app development best practice article](https://pingcap.com/docs-cn/v3.0/reference/best-practices/java-app/) lately. Please refer to it for details.", "title": null, "type": "comment" }, { "action": "closed", "author": "yikeke", "comment_id": null, "datetime": 1572320355000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
225
false
false
225
false
apache/cordova-wp8
apache
66,106,762
79
{ "number": 79, "repo": "cordova-wp8", "user_login": "apache" }
[ { "action": "opened", "author": "purplecabbage", "comment_id": null, "datetime": 1428049616000, "masked_author": "username_0", "text": "Included license files, and meta.", "title": "Added Newtonsoft json dll", "type": "issue" }, { "action": "created", "author": "sgrebnov", "comment_id": 89258100, "datetime": 1428059837000, "masked_author": "username_1", "text": ":+1: lgtm", "title": null, "type": "comment" }, { "action": "created", "author": "nikhilkh", "comment_id": 99129350, "datetime": 1430842641000, "masked_author": "username_2", "text": "@username_0 - When do you plan to merge this. There is another related issue now causing WP8 mobilespec tests to crash because this has not been fixed within the platform: https://github.com/apache/cordova-plugin-file-transfer/pull/82", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99134840, "datetime": 1430843995000, "masked_author": "username_3", "text": "apache/cordova-plugin-file-transfer#82 is a \"quick fix\" that could have been included already. Looking through the references, if this fix is accepted and released, I suspect it should be possible for [cordova-plugin-file-transfer](cordova-plugin-file-transfer) to include apache/cordova-plugin-file-transfer#54.", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99137602, "datetime": 1430844504000, "masked_author": "username_0", "text": "Today. \n\n\n\n>", "title": null, "type": "comment" }, { "action": "created", "author": "kim07", "comment_id": 99206961, "datetime": 1430856692000, "masked_author": "username_4", "text": ":+1:", "title": null, "type": "comment" }, { "action": "created", "author": "vladimir-kotikov", "comment_id": 99336921, "datetime": 1430892698000, "masked_author": "username_5", "text": "So the https://github.com/apache/cordova-plugin-file-transfer/pull/72 probably should be closed then...", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99345293, "datetime": 1430895015000, "masked_author": "username_0", "text": "We need to release this first, and file-transfer plugin should declare the required version.", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99354856, "datetime": 1430897484000, "masked_author": "username_3", "text": "then...\n\nMy point that apache/cordova-plugin-file-transfer#54 was an improvement\nthat was closed and rejected since we did not expect to add the Newtonsoft\nJSON library. Now that we *do* include the Newtonsoft library, it is\n**now** possible to include apache/cordova-plugin-file-transfer#54 (in\nfavor over apache/cordova-plugin-file-transfer#72 and\napache/cordova-plugin-file-transfer#82).\n\nI hope [cordova-plugin-file-transfer](\nhttps://github.com/apache/cordova-plugin-file-transfer) will consider\napache/cordova-plugin-file-transfer#54 again.", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99365163, "datetime": 1430899227000, "masked_author": "username_0", "text": "Yeah @username_3, will have another look at apache/cordova-plugin-file-transfer/pull/54", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99371506, "datetime": 1430900097000, "masked_author": "username_3", "text": "apache/cordova-plugin-file-transfer#54\n\n:+1: thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "alsorokin", "comment_id": 99541999, "datetime": 1430932603000, "masked_author": "username_6", "text": "It looks like these changes brought new test failures on wp8:\r\nhttps://issues.apache.org/jira/browse/CB-8968", "title": null, "type": "comment" }, { "action": "created", "author": "alsorokin", "comment_id": 99542404, "datetime": 1430932717000, "masked_author": "username_6", "text": "@username_0 @goya could you please look at these failures?", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99544620, "datetime": 1430933333000, "masked_author": "username_3", "text": "@username_6 I will take a look as well. Cannot promise I will find anything.", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99611924, "datetime": 1430946827000, "masked_author": "username_3", "text": "Can someone describe how I would run these cordova-plugin-file tests for wp8?", "title": null, "type": "comment" }, { "action": "created", "author": "vladimir-kotikov", "comment_id": 99734573, "datetime": 1430979391000, "masked_author": "username_5", "text": "@username_3 follow these steps:\r\n* clone https://github.com/apache/cordova-plugin-file-transfer.git somewhere on your disk\r\n* Create a new application\r\n* Add three plugins:\r\n```\r\n cordova plugin add path-to-cloned-file-transfer-plugin\r\n cordova plugin add path-to-cloned-file-transfer-plugin/tests\r\n cordova plugin add https://github.com/apache/cordova-plugin-test-framework.git\r\n```\r\n* Update config.xml at the root of your app - change `<content src=\"index.html\">` to `<content src=\"cdvtests/index.html\">`\r\n* Run application", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99847116, "datetime": 1431001928000, "masked_author": "username_3", "text": "If we would restore the old code in `JsonHelper.Serialize` in `template/cordovalib/JSON/JsonHelper.cs` then the problem in CB-8968 goes away. Then:\r\n\r\nUsing `JsonConvert.SerializeObject` from `Newtonsoft.Json` in cordova-plugin-file *is working OK in the test*:\r\n\r\n```diff\r\n--- a/src/wp/File.cs\r\n+++ b/src/wp/File.cs\r\n@@ -22,7 +22,9 @@\r\n using System.Text;\r\n using System.Windows;\r\n using System.Windows.Resources;\r\n+\r\n using WPCordovaClassLib.Cordova.JSON;\r\n+using Newtonsoft.Json;\r\n \r\n namespace WPCordovaClassLib.Cordova.Commands\r\n {\r\n@@ -771,7 +773,7 @@ public void readAsText(string options)\r\n // JIRA: https://issues.apache.org/jira/browse/CB-8792\r\n // Need to perform additional serialization here because NativeExecution is always trying\r\n // to do JSON.parse() on command result. This leads to issue when trying to read JSON files\r\n- var resultText = JsonHelper.Serialize(text);\r\n+ var resultText = JsonConvert.SerializeObject(text);\r\n DispatchCommandResult(new PluginResult(PluginResult.Status.OK, resultText), callbackId);\r\n }\r\n catch (Exception ex)\r\n```\r\n\r\nUsing `JsonConvert.SerializeObject` from `Newtonsoft.Json` in `template/cordovalib/ScriptCallback.cs` is *working OK in the cordova-plugin-file test*:\r\n\r\n```diff\r\n--- a/template/cordovalib/ScriptCallback.cs\r\n+++ b/template/cordovalib/ScriptCallback.cs\r\n@@ -25,6 +25,8 @@\r\n using WPCordovaClassLib.Cordova.JSON;\r\n using System.Diagnostics;\r\n \r\n+using Newtonsoft.Json;\r\n+\r\n namespace WPCordovaClassLib.Cordova\r\n {\r\n /// <summary>\r\n@@ -65,7 +67,7 @@ public ScriptCallback(string function, string id, object msg, object value)\r\n this.ScriptName = function;\r\n \r\n String arg = String.Format(\"{{\\\"id\\\": {0}, \\\"msg\\\": {1}, \\\"value\\\": {2}}}\",\r\n- JsonHelper.Serialize(id), JsonHelper.Serialize(msg), JsonHelper.Serialize(value));\r\n+ JsonConvert.SerializeObject(id), JsonConvert.SerializeObject(msg), JsonConvert.SerializeObject(value));\r\n \r\n this.Args = new string[] { arg };\r\n }\r\n```\r\n\r\nUsing `JsonConvert.SerializeObject` from `Newtonsoft.Json` in `template/cordovalib/CordovaCommandCall.cs` gave me a problem with `file.spec.83` (blob test) the first time, then was passing the cordova-plugin-file tests when I tried it again (should be OK).\r\n\r\nUsing `JsonConvert.SerializeObject` from `Newtonsoft.Json` in `template/cordovalib/PluginResult.cs` gives me the errors as described in CB-8968.\r\n\r\nWondering if any other Apache Cordova or major third-party plugins would be affected as well.", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99931329, "datetime": 1431016428000, "masked_author": "username_3", "text": "The Newtonsoft JSON library does seem much easier to use and perhaps more efficient as well, but unlike the .NET JSON `DataContractJsonSerializer`, Newtonsoft does not support serialization of arbitrary types. This becomes a problem with the cordova-file-plugin when it attempts to send a PluginResult with a byte array (`byte[]`) in response to a `readAsArrayBuffer` request. This is the cause of CB-8968, and it could affect other plugins as well.\r\n\r\nI have identified two alternative solutions to fix CB-8968:\r\n\r\nI. Fix `File.cs` in cordova-plugin-file to send the `PluginResult` with a normal integer array:\r\n\r\n```diff\r\n--- a/src/wp/File.cs\r\n+++ b/src/wp/File.cs\r\n@@ -695,7 +695,10 @@ public void readAsArrayBuffer(string options)\r\n buffer = readFileBytes(filePath, startPos, endPos, isoFile);\r\n }\r\n \r\n- DispatchCommandResult(new PluginResult(PluginResult.Status.OK, buffer), callbackId);\r\n+ int[] bufferAsIntArray = new int[buffer.Length];\r\n+ for (int i=0; i<buffer.Length; ++i) bufferAsIntArray[i] = buffer[i];\r\n+\r\n+ DispatchCommandResult(new PluginResult(PluginResult.Status.OK, bufferAsIntArray), callbackId);\r\n }\r\n catch (Exception ex)\r\n {\r\n```\r\n\r\nIdea thanks to: http://stackoverflow.com/questions/15226921/how-to-serialize-byte-as-simple-json-array-and-not-as-base64-in-json-net\r\n\r\nII. In `template/cordovalib/JSON/JsonHelper.cs` add a new function such as `public static string SerializeAny(object obj)` with what used to be the contents of `JSON.JsonHelper.Serialize`, and call this function instead of `JsonConvert.SerializeObject` in `PluginResult.cs`.\r\n\r\nI am not sure which solution would have better performance. Solution II only goes through the data once, but solution II delegates the looping to the framework libraries, which *could* do the hard work in C/C++/assembly.\r\n\r\nI am happy to issue a PR for either solution. Solution I would be easiest.", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99934209, "datetime": 1431017056000, "masked_author": "username_0", "text": "I think we should go with solution 1.\r\n```\r\nint[] bytesAsIntArray = Array.ConvertAll(buffer, c => (int)c);\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99942506, "datetime": 1431019052000, "masked_author": "username_3", "text": "Array.ConvertAll did not compile on Visual Studio Express 2013, and is apparently not supported for Metro or Silverlight. Figured out how to do this using Linq:\r\n\r\n```diff\r\ndiff --git a/src/wp/File.cs b/src/wp/File.cs\r\nindex 941c9c8..085ef77 100644\r\n--- a/src/wp/File.cs\r\n+++ b/src/wp/File.cs\r\n@@ -13,6 +13,7 @@\r\n */\r\n \r\n using System;\r\n+using System.Linq;\r\n using System.Collections.Generic;\r\n using System.Diagnostics;\r\n using System.IO;\r\n@@ -695,7 +696,9 @@ public void readAsArrayBuffer(string options)\r\n buffer = readFileBytes(filePath, startPos, endPos, isoFile);\r\n }\r\n \r\n- DispatchCommandResult(new PluginResult(PluginResult.Status.OK, buffer), callbackId);\r\n+ int[] bufferAsIntArray = (from b in buffer select (int)b).ToArray();\r\n+\r\n+ DispatchCommandResult(new PluginResult(PluginResult.Status.OK, bufferAsIntArray), callbackId);\r\n }\r\n catch (Exception ex)\r\n {\r\n```\r\n\r\nPlease let me know if you want me to issue a PR.", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99943449, "datetime": 1431019338000, "masked_author": "username_0", "text": "Looks good, send away.\n\n@username_0\nrisingj.com", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 99960110, "datetime": 1431021265000, "masked_author": "username_3", "text": "Issued PR to fix CB-8968 (automatic build failed, don't think it is my fault)", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 99962513, "datetime": 1431021814000, "masked_author": "username_0", "text": "nope, all auto build systems are hooped right now because of an issue with\nCapitalized npm package names.\n\n@username_0\nrisingj.com", "title": null, "type": "comment" }, { "action": "created", "author": "nikhilkh", "comment_id": 101378234, "datetime": 1431455617000, "masked_author": "username_2", "text": "@username_0 I'm really concerned with this switch for WP8 as it is breaking in nature. It changes how the Cordova WP8 JSON APIs behave and will cause a fair number of plugins to break. All plugins that break will have to make updates to support the new WP8 platform, and hence can't be used with the older version (3.x) of the WP8 platform. \r\n\r\nI would propose we don't make this disruptive change for WP8 which is a platform with limited runway as WP8.1+ should be using the Windows platform. WP8 should ideally be on life support and not making disruptive breaking changes that affect the plugin ecosystem.\r\n\r\nWe should consider an incremental fix for file transfer and other plugins that need better support for JSON parsing instead of changing the platform itself: https://github.com/apache/cordova-plugin-file-transfer/pull/72", "title": null, "type": "comment" }, { "action": "created", "author": "purplecabbage", "comment_id": 101383321, "datetime": 1431456405000, "masked_author": "username_0", "text": "yes, it is a breaking change. That is why it is a 4.0.0 change. Plugin\nauthors need to use engine tags, and we need to make sure they work.\n\nPersonally, if I was writing a WP8.1 app, I would use cordova-wp8 and\nupgrade stuff. Having a C# wrapper around a html/js presentation will\nstill be appealing to many. I would not expect cordova-wp8 to wither and\ndie anytime soon.\n\n\n@username_0\nrisingj.com", "title": null, "type": "comment" }, { "action": "created", "author": "nikhilkh", "comment_id": 101388610, "datetime": 1431457275000, "masked_author": "username_2", "text": "If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72). I understand Newtonsoft JSON is a better API and is more efficient.\r\n\r\nAnother alternative is for WP8 to provide new set of JSON APIs based on Newtonsoft JSON - The plugins that take dependency on these new APIs will have to use the engine tag and drop support for older versions of WP8. The older APIs will remain unchanged and a lot of plugins that are no longer maintained can continue to work.", "title": null, "type": "comment" }, { "action": "created", "author": "brodybits", "comment_id": 101394601, "datetime": 1431459083000, "masked_author": "username_3", "text": "In addition, it is my understanding is that cordova-wp8 is (still) needed to support Windows Phone in PhoneGap build.", "title": null, "type": "comment" } ]
7
27
10,313
false
false
10,313
true
blackfireio/player
blackfireio
141,479,848
24
null
[ { "action": "opened", "author": "absalomedia", "comment_id": null, "datetime": 1458189938000, "masked_author": "username_0", "text": "I'm looking at Player to capture the output of AJAX based forms. I want to extract the final data based on form inputs but not actually submit the form (as it leads to a page refresh / redirect that I can't track). It's neither click() or submit() that I need.\r\n\r\nHow would I do this?", "title": "Extracting data from AJAX based forms", "type": "issue" } ]
1
1
284
false
false
284
false
codecov/example-csharp
codecov
123,155,222
6
null
[ { "action": "opened", "author": "ddur", "comment_id": null, "datetime": 1450610322000, "masked_author": "username_0", "text": "Does not work, there is no python in your sample paths", "title": "AppVeyor sample", "type": "issue" }, { "action": "created", "author": "ddur", "comment_id": 166134325, "datetime": 1450629678000, "masked_author": "username_0", "text": "AppVeyor VS 2015 environment\r\nPython sample does not work if AppVeyor fetches repository as zip archive", "title": null, "type": "comment" }, { "action": "created", "author": "ddur", "comment_id": 166148820, "datetime": 1450639733000, "masked_author": "username_0", "text": "Codecov is crap. Documentation is crap. \r\nWhen I finally got the upload, it is not shown on projects page but on special reference in build result.\r\nBadge is \"undefined\".\r\nCoveralls.io works fine on first attempt.", "title": null, "type": "comment" }, { "action": "created", "author": "RyanCopley", "comment_id": 166151408, "datetime": 1450642869000, "masked_author": "username_1", "text": "As not-a-codecov employee, you're an ass. Instead of being rude, why don't you use your thinking cap and post relevant info so that Steve can help you appropriately.", "title": null, "type": "comment" }, { "action": "created", "author": "ddur", "comment_id": 166157992, "datetime": 1450648966000, "masked_author": "username_0", "text": "All they have to do is small \"man page\" for two scripts they provide.\r\nAnd couple notes for supported AppVeyor/VS environments.\r\nSamples are great for start but incomplete.\r\n\r\nYou as user and not-a-codecov employee are the same as me ;) and you should be on my (client) side.", "title": null, "type": "comment" }, { "action": "closed", "author": "ddur", "comment_id": null, "datetime": 1450694960000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ddur", "comment_id": 166292921, "datetime": 1450700863000, "masked_author": "username_0", "text": "You are very kind and polite.\r\nI guess you do not know better. Thank you.", "title": null, "type": "comment" } ]
2
7
883
false
false
883
false
parallaxinc/BlocklyProp
parallaxinc
239,360,474
1,063
null
[ { "action": "opened", "author": "kgracey", "comment_id": null, "datetime": 1498709066000, "masked_author": "username_0", "text": "Created the following code in project 8337 http://blockly.parallax.com/blockly/editor/blocklyc.jsp?project=8337#:\r\n\r\n![image](https://user-images.githubusercontent.com/9534148/27670471-00c4b3fa-5c42-11e7-9e7f-95dac6f36b10.png)\r\n\r\nTo make it work I brought it into SImpleIDE and made the following changes noted in the comments to enumerate the instances of more than one ColorPal:\r\n\r\n`// ------ Libraries and Definitions ------\r\n#include \"simpletools.h\"\r\n#include \"ws2812.h\"\r\n \r\n#define LED_PIN 0\r\n#define LED_COUNT 3\r\n \r\n#include \"colorpal.h\"\r\n \r\n// ------ Global Variables and Objects ------\r\nws2812 * __ws2812b;\r\nint RGBleds[3];\r\n \r\ncolorPal *cpalL; // we need unique identifiers for multiple colorPals - perhaps the I/O pin number\r\ncolorPal *cpalM;\r\ncolorPal *cpalR;\r\n \r\nint cpRR = 0;\r\nint cpGG = 0;\r\nint cpBB = 0;\r\n \r\nint colorL;\r\nint colorM;\r\nint colorR;\r\n \r\n \r\n// ------ Main Program ------\r\nint main()\r\n{\r\n__ws2812b = ws2812b_open();\r\npause(1000);\r\nprint(\"hello\\n\");\r\n//while(1);\r\ncpalL = colorPal_open(17); // also generated with unique identifiers\r\npause(100);\r\ncpalM = colorPal_open(16); // also generated with unique identifiers\r\npause(100);\r\ncpalR = colorPal_open(11); // also generated with unique identifiers\r\npause(100);\r\nwhile (1)\r\n{\r\ncolorPal_getRGB(cpalL, &cpRR, &cpGG, &cpBB);\r\ncolorL = colorPalRRGGBB(cpRR, cpGG, cpBB);\r\ncolorPal_getRGB(cpalM, &cpRR, &cpGG, &cpBB);\r\ncolorM = colorPalRRGGBB(cpRR, cpGG, cpBB);\r\ncolorPal_getRGB(cpalR, &cpRR, &cpGG, &cpBB);\r\ncolorR = colorPalRRGGBB(cpRR, cpGG, cpBB);\r\nprint(\"colorL = %d, colorM = %d, colorR = %d\\r\",\r\ncolorL, colorM, colorR);\r\n//\r\nif (1 > 0 && 1 <= LED_COUNT)\r\n{\r\nRGBleds[1 - 1] = colorL;\r\n}\r\nif (2 > 0 && 2 <= LED_COUNT)\r\n{\r\nRGBleds[2 - 1] = colorM;\r\n}\r\nif (3 > 0 && 3 <= LED_COUNT)\r\n{\r\nRGBleds[3 - 1] = colorR;\r\n}\r\n//\r\npause(100);\r\nws2812_set(__ws2812b, LED_PIN, RGBleds, LED_COUNT);\r\npause(1000);\r\n}\r\n}\r\n`\r\n@username_1 can you do this?", "title": "Multiple ColorPals: change request for color line follower", "type": "issue" }, { "action": "created", "author": "MatzElectronics", "comment_id": 317854179, "datetime": 1501012695000, "masked_author": "username_1", "text": "@username_0 I am now able to this in my dev for the colorPal sensor - so now it's a big copy-paste operation for other sensors. Any preferences on which ones should be done first?", "title": null, "type": "comment" }, { "action": "created", "author": "MatzElectronics", "comment_id": 320128892, "datetime": 1501808545000, "masked_author": "username_1", "text": "This should now be available in demo for:\r\n- PROTOCOLS > Serial\r\n- RGB-LEDs\r\n- ColorPal", "title": null, "type": "comment" } ]
2
3
2,178
false
false
2,178
true
ambiata/icicle
ambiata
114,762,568
186
{ "number": 186, "repo": "icicle", "user_login": "ambiata" }
[ { "action": "opened", "author": "jystic", "comment_id": null, "datetime": 1446536050000, "masked_author": "username_0", "text": "", "title": "Strike out completed ice v1 tasks", "type": "issue" }, { "action": "created", "author": "amosr", "comment_id": 153311795, "datetime": 1446547349000, "masked_author": "username_1", "text": ":ok_woman:", "title": null, "type": "comment" }, { "action": "created", "author": "amosr", "comment_id": 153312202, "datetime": 1446547513000, "masked_author": "username_1", "text": ":no_good:", "title": null, "type": "comment" } ]
2
3
19
false
false
19
false
ElemeFE/element
ElemeFE
180,584,001
219
null
[ { "action": "opened", "author": "chagamkamalakar", "comment_id": null, "datetime": 1475482357000, "masked_author": "username_0", "text": "these components are awesome .. i want to use this components in my project, would somebody suggest me how to enable english as default for all components. that would be of great help.", "title": "how to enable english text for all components ?", "type": "issue" }, { "action": "created", "author": "chagamkamalakar", "comment_id": 251054989, "datetime": 1475484218000, "masked_author": "username_0", "text": "i got to know after looking into code , i just need to pass the values to placeholder/other respective properties. Am i right?", "title": null, "type": "comment" }, { "action": "created", "author": "Leopoldthecoder", "comment_id": 251059438, "datetime": 1475485664000, "masked_author": "username_1", "text": "@username_0 You're right.\r\nI think you won't be confused if there is an English documentation. For now the documentation is Chinese, but still you can read the demo code which sheds light on how each component is used.", "title": null, "type": "comment" }, { "action": "closed", "author": "Leopoldthecoder", "comment_id": null, "datetime": 1475485664000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "chagamkamalakar", "comment_id": 251068468, "datetime": 1475488541000, "masked_author": "username_0", "text": "thank you @username_1", "title": null, "type": "comment" } ]
2
5
559
false
false
559
true
linode/manager
linode
259,882,493
2,563
null
[ { "action": "opened", "author": "na3d", "comment_id": null, "datetime": 1506100915000, "masked_author": "username_0", "text": "Doesn't render the correct time, says things happened in the future, and so many messy things involving how time is being displayed. It looks like time rendering needs reworked from the ground up...", "title": "Fix Borked Time Display", "type": "issue" }, { "action": "created", "author": "howdiz", "comment_id": 344736907, "datetime": 1510781888000, "masked_author": "username_1", "text": "@username_0 can you please update this title to be more specific. The description could probably be clearer too. Thanks.", "title": null, "type": "comment" }, { "action": "created", "author": "na3d", "comment_id": 345014965, "datetime": 1510857035000, "masked_author": "username_0", "text": "![Screen Shot 2017-11-16 at 1.29.45 PM.png](https://waffleio-direct-uploads-production.s3.amazonaws.com/uploads/574f1638af85550e005e0ae3/125516c66e82c728ace21e0d46db978826878de9bce1b057e40fa0c57e0b76226455f56b7191a379f110224f5b5a5ecc3c4a4356bcbbd671f3e57862804e0eead53b5e73946c47faea8219ec57bb208f4c87e7bb8c19d2f42f67b6d5db1063474f4dcbed5727a19041c95df74be94852a411306ae7772431.png)\r\n![Screen Shot 2017-11-16 at 1.30.01 PM.png](https://waffleio-direct-uploads-production.s3.amazonaws.com/uploads/574f1638af85550e005e0ae3/125516c66e82c728ace21e0d46db978826878de9bce1b057e40fa0c57e0b76226455f56b7191a379f1112b4f5f5e5ecc3c4a4356bcbbd671f3e57862804e0eead53b5e73946c47faea8219ec57bb208f4c87e7bb8c19d2f42f67b6d5db1063474f4dcbed5727a19e41c95df74be94852a411306ae6742431.png)", "title": null, "type": "comment" }, { "action": "created", "author": "howdiz", "comment_id": 345381251, "datetime": 1510957153000, "masked_author": "username_1", "text": "@username_0 can you please update this title to be more specific. The description could probably be clearer too. Thanks.", "title": null, "type": "comment" }, { "action": "created", "author": "howdiz", "comment_id": 345381426, "datetime": 1510957199000, "masked_author": "username_1", "text": "@rjstires passing to @username_0 for clarification.", "title": null, "type": "comment" }, { "action": "created", "author": "na3d", "comment_id": 345382289, "datetime": 1510957459000, "masked_author": "username_0", "text": "As the screenshots show above, the Backup Window/Time of Day for scheduling backups do not match. In EST, Time of Day should be 1AM-3AM if it was rendering properly.\n\nSide Note:\nRob and I plan on working on this together so we can go over the code in more detail.", "title": null, "type": "comment" }, { "action": "created", "author": "na3d", "comment_id": 346129223, "datetime": 1511291267000, "masked_author": "username_0", "text": "[Pending API Fix]", "title": null, "type": "comment" }, { "action": "created", "author": "na3d", "comment_id": 346144436, "datetime": 1511294568000, "masked_author": "username_0", "text": "Windows are based on GMT-1", "title": null, "type": "comment" }, { "action": "closed", "author": "asauber", "comment_id": null, "datetime": 1511909518000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
9
1,547
false
false
1,547
true
tolexo/aero
tolexo
205,784,999
15
{ "number": 15, "repo": "aero", "user_login": "tolexo" }
[ { "action": "opened", "author": "mayur-tolexo", "comment_id": null, "datetime": 1486442495000, "masked_author": "username_0", "text": "", "title": "CP-1086 Log Rapid API call taking more than one sec", "type": "issue" }, { "action": "created", "author": "krishan-tolexo", "comment_id": 278890467, "datetime": 1486716882000, "masked_author": "username_1", "text": "code ok", "title": null, "type": "comment" } ]
2
2
7
false
false
7
false
VOLTTRON/volttron
VOLTTRON
250,407,943
1,444
null
[ { "action": "opened", "author": "craig8", "comment_id": null, "datetime": 1502824072000, "masked_author": "username_0", "text": "End of life for precise so we should update the .travis.yml file to only build for trusty. We should include higher versions of python e.g. 2.7.13 to see what effect that has.\r\n\r\nIn addition we need to add the databases to the build so that we test them on ci.", "title": "Upgrade .travis.yml file", "type": "issue" }, { "action": "created", "author": "bonicim", "comment_id": 634324207, "datetime": 1590533958000, "masked_author": "username_1", "text": "Since the last comment on this issue, Travis now uses Xenial as the default. Since [Python 2 is no longer supported](https://www.python.org/doc/sunset-python-2/), I recommend that the travis.yml file be configured only with 3.x and above. I will submit a PR to reflect this.", "title": null, "type": "comment" }, { "action": "created", "author": "craig8", "comment_id": 634326658, "datetime": 1590534411000, "masked_author": "username_0", "text": "See if you can use tests from 3.6-3.8 in the matrix. Also, bionic should be tested whether through a docker based test image or through the travis-ci capability. I haven't looked to see if the free tier allows bionic in non-dockerized builds", "title": null, "type": "comment" }, { "action": "created", "author": "bonicim", "comment_id": 634329007, "datetime": 1590534868000, "masked_author": "username_1", "text": "Tracking on bionic. Will look into it.", "title": null, "type": "comment" } ]
2
4
816
false
false
816
false
TheDigitalStandard/TheDigitalStandard
TheDigitalStandard
248,188,527
50
null
[ { "action": "opened", "author": "von", "comment_id": null, "datetime": 1501943819000, "masked_author": "username_0", "text": "A customer should be able to export their data from a device in a standard format to avoid lock-in. I'm primary thinking of what we would consider content (e.g. photos, fitness data) but metadata could also be considered.", "title": "Ownership: People should be able to export their data", "type": "issue" }, { "action": "created", "author": "von", "comment_id": 320447464, "datetime": 1501944102000, "masked_author": "username_0", "text": "I see now this is touched on under Privacy / Data Control, which is great, but I suggest it really belongs under Ownership as an interoperability/lock-in issue.", "title": null, "type": "comment" }, { "action": "created", "author": "taliesan", "comment_id": 326606370, "datetime": 1504278669000, "masked_author": "username_1", "text": "Putting this forward for the next review.", "title": null, "type": "comment" }, { "action": "created", "author": "KatieMcInnis", "comment_id": 326618214, "datetime": 1504281521000, "masked_author": "username_2", "text": "Thanks! Have made this a pull request #58", "title": null, "type": "comment" }, { "action": "closed", "author": "KatieMcInnis", "comment_id": null, "datetime": 1504281524000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
4
6
740
false
true
463
false
zvonicek/ImageSlideshow
null
293,458,216
225
null
[ { "action": "opened", "author": "L4grange", "comment_id": null, "datetime": 1517477170000, "masked_author": "username_0", "text": "First of all I would like to thank you for this amazing library! I'm using it throughout my app and it works great!\r\n\r\nIn my app I need to parse an HTML document and after I get all the images I set the image sources of my slideshow. However, since when loading I already have some pictures in the slide show, when calling setImageInputs(photos) my slideshow flashes for a split second. Is there a way to prevent this?\r\n\r\nMy photos array is just a Kingfisher Source array:\r\n`var photos = [KingfisherSource.init(urlString: article.imageURL, placeholder: placeholder)! ]`\r\n\r\nAny ideas are welcome!", "title": "Flashing when setting Image Sources", "type": "issue" }, { "action": "created", "author": "Iccr", "comment_id": 455055654, "datetime": 1547705858000, "masked_author": "username_1", "text": "any workaround? mine is also flashing", "title": null, "type": "comment" }, { "action": "created", "author": "ed8009", "comment_id": 749729404, "datetime": 1608664882000, "masked_author": "username_2", "text": "Same problem", "title": null, "type": "comment" } ]
3
3
644
false
false
644
false
opentok/Opentok-.NET-SDK
opentok
195,693,125
73
null
[ { "action": "opened", "author": "jeffswartz", "comment_id": null, "datetime": 1481765503000, "masked_author": "username_0", "text": "The OpenTok REST API now lets you filter by session ID when getting a list of archives: https://tokbox.com/developer/rest/#listing_archives. (You pass in a `sessionId` query parameter when calling the REST API method.) The `OpenTok.ListArchives()` methods in the OpenTok .NET server SDK does not support this session ID filter.", "title": "OpenTok.ListArchives() does not support filtering by session ID", "type": "issue" }, { "action": "closed", "author": "matt-lethargic", "comment_id": null, "datetime": 1641309825000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "matt-lethargic", "comment_id": 1004902923, "datetime": 1641309825000, "masked_author": "username_1", "text": "Closing as resolved with #143", "title": null, "type": "comment" } ]
2
3
356
false
false
356
false
HubSpot/Singularity
HubSpot
177,895,805
1,292
null
[ { "action": "opened", "author": "stevenschlansker", "comment_id": null, "datetime": 1474318614000, "masked_author": "username_0", "text": "Gotta be careful not to make the cure worse than the disease ;)\r\n\r\n![screen shot 2016-09-19 at 1 55 12 pm](https://cloud.githubusercontent.com/assets/129097/18648724/be54e6e8-7e70-11e6-9e4e-47cc2ac4e23d.png)\r\n\r\nExamples:\r\n\r\n```\r\nNew disasters detected. Data: SingularityDisastersData{stats=[SingularityDisasterDataPoint{timestamp=1474318365283, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=461280, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318355261, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=451258, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318345250, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=441247, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318335240, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=431237, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318325228, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=421225, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318315214, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=411211, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318305203, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=401200, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318295194, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=391191, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318285181, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=381178, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318275165, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=371162, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}], disasters=[SingularityDisaster{type=EXCESSIVE_TASK_LAG, active=true}, SingularityDisaster{type=LOST_SLAVES, active=false}, SingularityDisaster{type=LOST_TASKS, active=false}, SingularityDisaster{type=USER_INITIATED, active=false}], automatedActionDisabled=false}\r\n```\r\n\r\n```\r\nNew disasters detected. Data: SingularityDisastersData{stats=[SingularityDisasterDataPoint{timestamp=1474318385305, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=481302, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318375295, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=471292, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318365283, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=461280, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318355261, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=451258, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318345250, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=441247, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318335240, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=431237, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318325228, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=421225, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318315214, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=411211, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318305203, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=401200, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}, SingularityDisasterDataPoint{timestamp=1474318295194, numActiveTasks=397, numPendingTasks=18, numLateTasks=1, avgTaskLagMillis=391191, numLostTasks=0, numActiveSlaves=20, numLostSlaves=0}], disasters=[SingularityDisaster{type=EXCESSIVE_TASK_LAG, active=true}, SingularityDisaster{type=LOST_SLAVES, active=false}, SingularityDisaster{type=LOST_TASKS, active=false}, SingularityDisaster{type=USER_INITIATED, active=false}], automatedActionDisabled=false}\r\n```\r\n\r\n(It'd also be nice to get a formatted email instead of a json dump)", "title": "Singularity disaster detection itself needs rate limiting", "type": "issue" }, { "action": "created", "author": "ssalinas", "comment_id": 248124615, "datetime": 1474318726000, "masked_author": "username_1", "text": "The de-duping is already implemented in #1278 , will leave open for the email formatting though", "title": null, "type": "comment" }, { "action": "created", "author": "ssalinas", "comment_id": 248300886, "datetime": 1474378088000, "masked_author": "username_1", "text": "As a note, to disable the emails for the moment, you can use the `emails` section of the smtp configuration and set the list of recipients for `DISASTER_DETECTED` emails to an empty list instead of having it send to admins:\r\nhttps://github.com/HubSpot/Singularity/blob/master/SingularityService/src/main/java/com/hubspot/singularity/config/SMTPConfiguration.java#L102", "title": null, "type": "comment" }, { "action": "closed", "author": "ssalinas", "comment_id": null, "datetime": 1480347024000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
4
5,211
false
false
5,211
false
JedWatson/react-select
null
89,569,099
256
null
[ { "action": "opened", "author": "Andreyco", "comment_id": null, "datetime": 1434721803000, "masked_author": "username_0", "text": "Add support for `valueLink` prop, which will handle setting and getting of value. \r\nThis would serve as alternative to `value` and `onChange` props.", "title": "Add support for valueLink", "type": "issue" }, { "action": "created", "author": "appsciences", "comment_id": 121273913, "datetime": 1436886063000, "masked_author": "username_1", "text": "This can be achieved via inputProps attribute, e.g.\r\n\r\n <Select\r\n options={[\r\n ...\r\n ]}\r\n \r\n inputProps={{valueLink:this.props.getLinkState(\"fieldName\")}}\r\n />", "title": null, "type": "comment" }, { "action": "created", "author": "pindia", "comment_id": 121422211, "datetime": 1436915678000, "masked_author": "username_2", "text": "The above solution didn't work for me, I got a \"Cannot provide a valueLink and a value or onChange event\" error. (No, I didn't pass value or onChange; presumably `react-select` is automatically doing so)\r\n\r\nI ended up writing a wrapper around the component instead. It supports both the old way and `valueLink` for both single and multi selects:\r\n\r\n```jsx\r\nvar Select = require('react-select');\r\n\r\nmodule.exports.Select = React.createClass({\r\n onChange(textValue, arrayValue) {\r\n // Dispatch to caller onChange if present\r\n if(this.props.onChange)\r\n this.props.onChange(textValue, arrayValue);\r\n if(this.props.valueLink){\r\n // Multi select: grab values and send array of values to valueLink\r\n if(this.props.multi)\r\n this.props.valueLink.requestChange(_.pluck(arrayValue, 'value'));\r\n // Single select: send text value to valueLink\r\n else\r\n this.props.valueLink.requestChange(textValue);\r\n }\r\n },\r\n render() {\r\n // Prevent specific props from being passed through so we can override them\r\n var { valueLink, value, onChange, ...other } = this.props;\r\n return <Select value={value || valueLink.value} onChange={this.onChange} {...other} />\r\n }\r\n});\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "appsciences", "comment_id": 122345729, "datetime": 1437153169000, "masked_author": "username_1", "text": "Pindia, you are absolutely right, it's my mistake (didn't recompile the project when trying this). I've updated my comment.", "title": null, "type": "comment" }, { "action": "closed", "author": "jossmac", "comment_id": null, "datetime": 1535526625000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" } ]
4
5
1,690
false
false
1,690
false
VasekPurchart/Console-Errors-Bundle
null
160,192,712
2
{ "number": 2, "repo": "Console-Errors-Bundle", "user_login": "VasekPurchart" }
[ { "action": "opened", "author": "Vrtak-CZ", "comment_id": null, "datetime": 1465913780000, "masked_author": "username_0", "text": "https://github.com/symfony/yaml/blob/3.1/Inline.php#L320", "title": "Compatability with Symfony 4 - deprecated in Symfony 3.1", "type": "issue" }, { "action": "created", "author": "VasekPurchart", "comment_id": 226868464, "datetime": 1466193876000, "masked_author": "username_1", "text": "Thanks, released as [0.5.1](https://github.com/username_1/Console-Errors-Bundle/releases/tag/0.5.1).", "title": null, "type": "comment" } ]
2
2
159
false
false
159
true
VictorBjelkholm/ngProgress
null
121,040,320
100
{ "number": 100, "repo": "ngProgress", "user_login": "VictorBjelkholm" }
[ { "action": "opened", "author": "IanShoe", "comment_id": null, "datetime": 1449590899000, "masked_author": "username_0", "text": "Fixes #99", "title": "Update bower.json", "type": "issue" }, { "action": "created", "author": "MangeshPimpalkar", "comment_id": 162992040, "datetime": 1449603474000, "masked_author": "username_1", "text": "@username_0 There are multiple PRs created just for this issue.\r\nIt is pending to merge.", "title": null, "type": "comment" }, { "action": "created", "author": "IanShoe", "comment_id": 163228909, "datetime": 1449667184000, "masked_author": "username_0", "text": "Ahh I see that now. Sorry, I was in a rush and did not check other issues at all.", "title": null, "type": "comment" } ]
2
3
175
false
false
175
true
openAVproductions/openAV-Ctlra
openAVproductions
258,332,897
40
null
[ { "action": "opened", "author": "harryhaaren", "comment_id": null, "datetime": 1505681296000, "masked_author": "username_0", "text": "Refactor the accept dev callback to take a struct of callbacks, this makes it easier to add new callbacks in future, and easier to access/write to them - they're contained within a struct, instead of all manually passed along. Performance is of no concern here - this is setup / initialization path only.", "title": "Refactoring callbacks", "type": "issue" }, { "action": "closed", "author": "harryhaaren", "comment_id": null, "datetime": 1521451391000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
304
false
false
304
false
kks32/phd-thesis-template
null
223,043,028
123
null
[ { "action": "opened", "author": "malazah", "comment_id": null, "datetime": 1492689481000, "masked_author": "username_0", "text": "I am using your PhD template and trying to build a pdf copy using overleaf. I got an error message regarding some Matlab plots saved as eps in both Raster and vector folders. The message says that the extension for these graphs is not permitted. Another issue I am facing is that in tthe bibloiography capital letters for Names are all coming in pdf as small letters, eventhough in the latex document they are capitals.\r\n\r\nCheers,\r\nMohd", "title": "Dr Mohammad Al Azah", "type": "issue" }, { "action": "created", "author": "kks32", "comment_id": 295760086, "datetime": 1492698890000, "masked_author": "username_1", "text": "Is your error: `unknown graphics extension` then you need to use this package: `\\usepackage{epstopdf}`", "title": null, "type": "comment" } ]
2
2
538
false
false
538
false
divio/django-cms
divio
198,655,942
5,834
null
[ { "action": "opened", "author": "crazy-canux", "comment_id": null, "datetime": 1483519430000, "masked_author": "username_0", "text": "I follow the document here:\r\n\r\nhttp://docs.django-cms.org/en/stable/how_to/install.html#configuration-and-setup\r\n\r\nand got the exception:\r\n\r\n![capture](https://cloud.githubusercontent.com/assets/14313415/21636249/da3cd1f6-d29c-11e6-9c0c-0cf95d70ea31.PNG)\r\n\r\nthis is my virtualenv:\r\n\r\n![capture1](https://cloud.githubusercontent.com/assets/14313415/21636255/dc4f5d6a-d29c-11e6-94cd-5acda6725f90.PNG)\r\n\r\n\r\nAnyboday knows how to fix this issue?", "title": "CSRF verification failed. Request aborted.", "type": "issue" }, { "action": "closed", "author": "czpython", "comment_id": null, "datetime": 1483523751000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "czpython", "comment_id": 270334232, "datetime": 1483523751000, "masked_author": "username_1", "text": "Hello @username_0 , please make sure to submit questions within the appropriate channels on either the [User Mailing List](https://groups.google.com/forum/#!forum/django-cms), IRC (freenode#django-cms) or [Stackoverflow](http://stackoverflow.com/questions/tagged/django-cms).\r\n\r\nYou can find additional information on our [support](https://www.django-cms.org/support) page.\r\n\r\nIn this case, I believe your question is best in the [Users Mailing List](https://groups.google.com/forum/#!forum/django-cms).", "title": null, "type": "comment" } ]
2
3
945
false
false
945
true
fabric8io/gofabric8
fabric8io
206,977,876
350
null
[ { "action": "opened", "author": "samuelcstewart", "comment_id": null, "datetime": 1486817305000, "masked_author": "username_0", "text": "Hi, \r\n\r\nI have a fairly plain jane Openshift Origin cluster on GCE:\r\n\r\nOpenShift Master: v1.4.1+3f9807a\r\nKubernetes Master: v1.4.0+776c994 , \r\n\r\nUsing gofabric8 0.4.115, I'm trying to deploy platform version 2.4.24.\r\n\r\nDynamic PV's are created and bound correctly to the gogs, nexus, jenkins and registry pods but the busybox init containers fail with file permissions erorrs. Removing the init containers from the deployment config move the permissions errors to the service pods.\r\n\r\n```bash\r\n❯ oc get pvc\r\nNAME STATUS VOLUME CAPACITY ACCESSMODES AGE\r\nfabric8-docker-registry-storage Bound pvc-47c65de6-f045-11e6-9f61-42010a8a0004 5Gi RWO 1h\r\ngogs-data Bound pvc-47f498a7-f045-11e6-9f61-42010a8a0004 1Gi RWO 1h\r\njenkins-jobs Bound pvc-4813ba25-f045-11e6-9f61-42010a8a0004 1Gi RWO 1h\r\njenkins-mvn-local-repo Bound pvc-4832ceff-f045-11e6-9f61-42010a8a0004 1Gi RWX 1h\r\njenkins-workspace Bound pvc-48627c38-f045-11e6-9f61-42010a8a0004 1Gi RWO 1h\r\nnexus-storage Bound pvc-48819942-f045-11e6-9f61-42010a8a0004 1Gi RWO 1h\r\n```\r\n\r\n```bash\r\n❯ oc logs nexus-1-e1ebi -c init\r\nchmod: /sonatype-work/storage: Permission denied\r\n```", "title": "PVC permission issue: failed to \"InitContainer\" for \"init\" with RunInitContainerError: \"init container \\\"init\\\" exited with 1\"", "type": "issue" } ]
1
1
1,423
false
false
1,423
false
mikepenz/MaterialDrawer
null
140,460,548
1,090
null
[ { "action": "opened", "author": "utkarshns", "comment_id": null, "datetime": 1457854074000, "masked_author": "username_0", "text": "I want to reduce the width of the mini drawer in closed position, doing this is easy but the icons in closed state get clipped. I want to be able to adjust the draw distance from the left. \r\nThanks in advance.", "title": "[MiniDrawer, Question] Anyway I can adjust the distance of the icons from the extreme left of the screen?", "type": "issue" }, { "action": "created", "author": "mikepenz", "comment_id": 195913322, "datetime": 1457857334000, "masked_author": "username_1", "text": "@username_0 can you please add a screenshot? Or a photo describing your requirement a bit more? \r\n\r\nIf you want to modify paddings, etc from the `MiniDrawerItem` and `MiniProfileDrawerItem` you can do the following\r\n\r\nExtend the two items, or create them new (you can also copy paste them and alter their code):\r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/java/com/username_1/materialdrawer/model/MiniDrawerItem.java\r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/java/com/username_1/materialdrawer/model/MiniProfileDrawerItem.java\r\n(You want to take a closer look at this here too, required for compatiblity https://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/java/com/username_1/materialdrawer/model/MiniDrawerItem.java#L161)\r\n\r\nThen you also alter the layouts so the paddings fit your needs: \r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/res/layout/material_drawer_item_mini.xml\r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/res/layout/material_drawer_item_mini_profile.xml\r\n\r\nAnd afterwards you have to `extend` the `MiniDrawer` and overwrite the following two methods to allow you custom `MiniDrawerItem` and `MiniProfileDrawerItem` to be used:\r\n\r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/java/com/username_1/materialdrawer/MiniDrawer.java#L240\r\nhttps://github.com/username_1/MaterialDrawer/blob/develop/library/src/main/java/com/username_1/materialdrawer/MiniDrawer.java#L259", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195913938, "datetime": 1457857610000, "masked_author": "username_0", "text": "That is right, I need to adjust the padding.\r\nScreenshot: https://goo.gl/photos/Lc5Yae56wKAFx5Fh7\r\n\r\nI will look into the solutions.\r\n\r\nThanks", "title": null, "type": "comment" }, { "action": "closed", "author": "mikepenz", "comment_id": null, "datetime": 1457857705000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "mikepenz", "comment_id": 195914011, "datetime": 1457857705000, "masked_author": "username_1", "text": "@username_0 yes this will require the steps as written above. It is a bit more complicated (but possible) because the `MaterialDrawer` and all of its components focus to follow the **Material Design Guidelines**.", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195914082, "datetime": 1457857812000, "masked_author": "username_0", "text": "Yes, the guidelines are important. Perhaps I will reconsider using the defaults and sticking to the guidelines so as to provide the best user experience across all devices.", "title": null, "type": "comment" }, { "action": "created", "author": "mikepenz", "comment_id": 195914365, "datetime": 1457857955000, "masked_author": "username_1", "text": "@username_0 to exactly stick to the guideliens. You should consider using the `MiniDrawer` only on tablets, and not on phones.", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195914523, "datetime": 1457858171000, "masked_author": "username_0", "text": "@username_1 \r\nYou are quick as a bot. *claps*\r\n`MiniDrawer` was liked on phones by everyone in the team and target devices have pretty huge screens, sort of phablets.", "title": null, "type": "comment" }, { "action": "created", "author": "mikepenz", "comment_id": 195914575, "datetime": 1457858304000, "masked_author": "username_1", "text": "@username_0 who knows :D \r\n\r\nOh well then its fine :). If its on phones with huge screens it might work. Always be careful with such concepts. But as you will also make it a bit smaller (might consider just doing this on phones and not on tablets) it doesn't consume to much space from the content area", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195914666, "datetime": 1457858407000, "masked_author": "username_0", "text": "@username_1 \r\nThanks for the tips, will keep them in mind for sure.", "title": null, "type": "comment" }, { "action": "created", "author": "mikepenz", "comment_id": 195947130, "datetime": 1457871393000, "masked_author": "username_1", "text": "@username_0 just for curiosity did this problem occur on Android N? Or just on API <= 23?", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195948258, "datetime": 1457872124000, "masked_author": "username_0", "text": "Haven't tried on Android N. I have an N5, sadly google ditched us for the preview. :(", "title": null, "type": "comment" }, { "action": "created", "author": "mikepenz", "comment_id": 195948316, "datetime": 1457872210000, "masked_author": "username_1", "text": "@username_0 just had the chance to test the Android N preview on a Nexus 6 and the settings application from Google had exactly the same issue. Always jumped to top when an item was updated. Seems like the recyclerview of the support libraries has an issue here.", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 195952748, "datetime": 1457873960000, "masked_author": "username_0", "text": "@username_1 \r\nThis maybe super OT but how do I highlight the 'MiniDrawer' icon other than the first one. \r\n\r\nCase:\r\nI plan to click the closed 'MiniDrawer' icon and go to another activity with 'MiniDrawer, now in the 'SecondActivity' I would want to highlight the 'SecondActivity' icon rather than the default top most icon so it indicates the current activity in the 'MiniDrawer' also.", "title": null, "type": "comment" }, { "action": "created", "author": "mikepenz", "comment_id": 195998519, "datetime": 1457888267000, "masked_author": "username_1", "text": "@username_0 if you have improvements. I am always open for a pull request", "title": null, "type": "comment" }, { "action": "created", "author": "utkarshns", "comment_id": 196004622, "datetime": 1457889646000, "masked_author": "username_0", "text": "@username_1 \r\nIf I can, I sure as hell would bombard the lib with pull requests of improvements.\r\nI got a lot to learn and the lib lacks any bugs as such.", "title": null, "type": "comment" } ]
2
16
3,966
false
false
3,966
true
ValveSoftware/openvr
ValveSoftware
163,201,013
176
null
[ { "action": "opened", "author": "Compynerd255", "comment_id": null, "datetime": 1467302084000, "masked_author": "username_0", "text": "The [IVRSystem::GetHiddenAreaMesh](https://github.com/ValveSoftware/openvr/wiki/IVRSystem::GetHiddenAreaMesh) method is documented to return a **HiddenAreaMesh_t** that simply contains a pointer to a list of vertices and an indicated number of triangles. Could you please post more information to the wiki as to what the format of that list of vertices is (i.e. is it 3-vectors or 4-vectors, is it a triangle list or a triangle strip, does it need to be transformed or projected, can it change during program execution, etc.)?", "title": "GetHiddenAreaMesh does not specify mesh format", "type": "issue" }, { "action": "created", "author": "jrbudda", "comment_id": 230534225, "datetime": 1467737108000, "masked_author": "username_1", "text": "It's a list of 2d triangles. There should be 20 triangles reported. That's 60 vertices and 2 coordinates per vertex so 120 individual values in the format x1, y1, x2, y2, x3, y3 ... etc", "title": null, "type": "comment" }, { "action": "created", "author": "L-P", "comment_id": 339972409, "datetime": 1509111176000, "masked_author": "username_2", "text": "As this issue is the only documentation I found on the subject, let me expand\r\nit a bit:\r\n\r\nAs of today (IVRSystem_017 with a HTC Vive), `GetHiddenAreaMesh` returns 78\r\nvertices **in the [0-1] range**. (0,0) is bottom-left.\r\n\r\nThe rest can be inferred from the definition of `HiddenAreaMesh_t`.\r\nThe comments on `GetHiddenAreaMesh` does not match the definition but match the\r\nfunctionality.", "title": null, "type": "comment" }, { "action": "created", "author": "jorjic", "comment_id": 1000947240, "datetime": 1640389115000, "masked_author": "username_3", "text": "There's a C# example of converting the `HmdVector2_t pVertexData` into a Unity mesh.\r\nhttps://github.com/ValveSoftware/openvr/blob/4c85abcb7f7f1f02adaf3812018c99fc593bc341/samples/unity_teleport_sample/Assets/SteamVR/Scripts/SteamVR_Utils.cs#L390\r\n\r\nIt's also worth checking out that Ogre3D has mentioned Valve's hidden area mesh in this blogpost: \r\n[https://www.ogre3d.org/2019/09/22/improvements-in-vr-morph-animations-moving-to-github-and-ci](https://www.ogre3d.org/2019/09/22/improvements-in-vr-morph-animations-moving-to-github-and-ci)", "title": null, "type": "comment" } ]
4
4
1,642
false
false
1,642
false
googlesamples/google-services
googlesamples
123,621,187
127
null
[ { "action": "opened", "author": "nickgao1986", "comment_id": null, "datetime": 1450859846000, "masked_author": "username_0", "text": "help,How can we switch dev google-services.json to google-services.json when they exsits different flavour? We only have one goolge-services.json file in our project", "title": "How can we switch dev google-services.json to google-services.json when they exsits different flavour?", "type": "issue" }, { "action": "created", "author": "samtstern", "comment_id": 167012570, "datetime": 1450916190000, "masked_author": "username_1", "text": "Check out #54 for some information on how to use build flavors. Official documentation coming soon.\r\n\r\nSummary: the `google-services.json` contains information for all build flavors and if you put a copy of the file in each `app/src/<flavor>` directory, the plugin will be smart enough to read the right section of the file.", "title": null, "type": "comment" }, { "action": "created", "author": "samtstern", "comment_id": 167012624, "datetime": 1450916243000, "masked_author": "username_1", "text": "Note that you have to go through the developers.google.com/mobile/add flow once for each flavor. Each time the `google-services.json` file you get will contain the information from previous runs of the wizard flow, so you'll want to always only keep the most recent copy.", "title": null, "type": "comment" }, { "action": "closed", "author": "samtstern", "comment_id": null, "datetime": 1453327929000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
4
762
false
false
762
false
HealthCatalyst/Fabric.Cashmere
HealthCatalyst
292,140,038
40
null
[ { "action": "opened", "author": "andrew-frueh", "comment_id": null, "datetime": 1517076290000, "masked_author": "username_0", "text": "A modal dialog is a window that forces the user to interact with it before they can go back to using the parent application. Our Catalyst modals include a header section with a title, a content area, and a footer section with Save and Cancel buttons. The height of the header and footer should be fixed, but height and width of the overall modal should be configurable.\r\n\r\n![modaldialog](https://user-images.githubusercontent.com/22795893/35474884-c2dd0b52-0351-11e8-9617-244b732a3c83.png)", "title": "Modal Dialog", "type": "issue" }, { "action": "created", "author": "corytak", "comment_id": 363612553, "datetime": 1517962969000, "masked_author": "username_1", "text": "Currently, the Measures Manager team uses ngx-bootstrap's modal component for our modals. In order to replace this functionality, we would need the ability to\r\n\r\n- Open a modal\r\n- Return a value on close\r\n\r\nOther considerations from the style guide are about how we shouldn't allow modals to stack. Would an interface like this be too simplistic?\r\n```\r\n<hc-modal #testModal size=\"lg\">\r\n <hc-test (close)=\"onClose($event)\"></hc-test>\r\n </hc-modal>\r\n\r\n<button (click)=\"testModal.open()\"></button>\r\n```\r\nThis would force the user to style the modal property with the `hc-test` component. We could take away some of the potential user variation by doing something like this:\r\n```\r\n<hc-modal #testModal size=\"lg\" (close)=\"onClose($event)\">\r\n <hc-modal-header title=\"test\"></hc-modal-header>\r\n <hc-modal-body>Modal Body Here</hc-modal-body>\r\n <hc-modal-footer>\r\n <button hc-button color=\"tertiary\"> Cancel </button>\r\n <button hc-button color=\"primary\"> Save </button>\r\n </hc-modal-footer>\r\n </hc-modal>\r\n\r\n<button (click)=\"testModal.open()\"></button>\r\n```\r\nAnd use a modal service to handle the state and communciation between the different components. \r\n\r\nOther methods might include creating an `HCModalService` that other components can inject and use to create/interact with modal:\r\n\r\n```\r\nlet testModal = this.modalService.open(TestComponent);\r\ntestModal.close();\r\ntestModal.onClose().subscribe(res => doSomething(res));\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "jtrujill", "comment_id": 363812222, "datetime": 1518018619000, "masked_author": "username_2", "text": "I didn't really like the way that ngx-bootstrap was implemented and found that it had a lot of issues with complex layouts. I actually prefered @ng-bootstrap, which handles modals correctly by projecting it's content to as a direct child of the <body>, this avoids issues with overflow:none, and stacking issues. I also really liked the idea of putting your modal content in a component and passing that to the service NgbModal.open() instead of embedding the modal directly into the component that wants to create a modal. \r\n\r\nI can help with the content projection to the body element once I clear some components I'm currently working on.", "title": null, "type": "comment" }, { "action": "closed", "author": "corytak", "comment_id": null, "datetime": 1520462540000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
4
2,600
false
false
2,600
false
nette/forms
nette
107,498,673
94
{ "number": 94, "repo": "forms", "user_login": "nette" }
[ { "action": "opened", "author": "radekdostal", "comment_id": null, "datetime": 1442837951000, "masked_author": "username_0", "text": "", "title": "Typo.", "type": "issue" }, { "action": "created", "author": "hrach", "comment_id": 141955394, "datetime": 1442838141000, "masked_author": "username_1", "text": ":+1:", "title": null, "type": "comment" }, { "action": "created", "author": "dg", "comment_id": 141956454, "datetime": 1442838301000, "masked_author": "username_2", "text": ":100:", "title": null, "type": "comment" } ]
3
3
9
false
false
9
false
markdown-it/markdown-it
markdown-it
84,413,521
112
null
[ { "action": "opened", "author": "opennota", "comment_id": null, "datetime": 1433317004000, "masked_author": "username_0", "text": "", "title": "Code block should terminate block quote", "type": "issue" }, { "action": "created", "author": "puzrin", "comment_id": 108317114, "datetime": 1433331050000, "masked_author": "username_1", "text": "http://spec.commonmark.org/dingus/?text=%3E%20block%20quote%0A%20%20%20%20should%20be%20code\r\n\r\nInvalid. See http://spec.commonmark.org/0.19/#example-65 . \"An indented code block cannot interrupt a paragraph.\"", "title": null, "type": "comment" }, { "action": "closed", "author": "puzrin", "comment_id": null, "datetime": 1433331050000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "puzrin", "comment_id": 108318341, "datetime": 1433331150000, "masked_author": "username_1", "text": "If you wish - report clarification request to https://github.com/jgm/CommonMark/issues", "title": null, "type": "comment" } ]
2
4
295
false
false
295
false
bitrise-io/bitrise-steplib
bitrise-io
183,949,386
702
{ "number": 702, "repo": "bitrise-steplib", "user_login": "bitrise-io" }
[ { "action": "opened", "author": "radimvaculik", "comment_id": null, "datetime": 1476880552000, "masked_author": "username_0", "text": "### New Pull Request Checklist\r\n\r\n*Please mark the points which you did / accept.*\r\n\r\n- [x] I read the [Step Development Guideline](https://github.com/bitrise-io/bitrise/blob/master/_docs/step-development-guideline.md)\r\n- [x] I have a test for my Step, which can be run with `bitrise run test` (in the step's repository)\r\n- [x] I did run `bitrise run audit-this-step` (in the step's repository - note, if you don't have this workflow in your `bitrise.yml`, [you can copy it from the step template](https://github.com/bitrise-steplib/step-template/blob/master/bitrise.yml).)\r\n- [x] I read and accept the [Abandoned Step policy](https://github.com/bitrise-io/bitrise-steplib#abandoned-step-policy)", "title": "apk-info 1.0.3", "type": "issue" }, { "action": "created", "author": "radimvaculik", "comment_id": 254799839, "datetime": 1476880698000, "masked_author": "username_0", "text": "Hopefully, it will be OK now :)", "title": null, "type": "comment" } ]
1
2
726
false
false
726
false
spacetelescope/specviz
spacetelescope
293,590,058
358
null
[ { "action": "opened", "author": "drdavella", "comment_id": null, "datetime": 1517501659000, "masked_author": "username_0", "text": "Right now the requirement is expressed as `specutils==0.2.2`. This means it is not possible to build against development versions of `specutils`. This causes problems particularly when trying to use `astroconda-dev` to test rolling release builds. Could this requirement be updated to `specutils>=0.2.2`?", "title": "Allow for builds against development versions of specutils", "type": "issue" }, { "action": "created", "author": "nmearl", "comment_id": 378737242, "datetime": 1522874293000, "masked_author": "username_1", "text": "No, anything above `specutils==0.2.2` is not backwards compatible.", "title": null, "type": "comment" }, { "action": "closed", "author": "nmearl", "comment_id": null, "datetime": 1522874303000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
370
false
false
370
false
China-ls/angular-baidu-maps
null
216,348,570
1
null
[ { "action": "opened", "author": "longye321", "comment_id": null, "datetime": 1490258371000, "masked_author": "username_0", "text": "已经按照当前例子里面讲的,设置了 ui-baidu-map=\"myMap\",但返回的对象是个undefined,应该和版本没什么关系吧,代码我也看了一下,也不是很复杂", "title": "找不到百度地图的MAP对象", "type": "issue" }, { "action": "created", "author": "China-ls", "comment_id": 288915821, "datetime": 1490322349000, "masked_author": "username_1", "text": "首先我解释下这个问题可能发生的情况:\r\n 1、第一种情况,与demo.html中文件结构相同的时候,如果你使用$scope.myMap是null的情况,是由于地图未初始化完成,因为controller是会先一步初始化完成,所以安全的做法是在onMapLoaded方法被调用之后,再使用$scope.myMap对象\r\n2、当你的界面结构比较复杂的时候,而此时你是通过data-ng-include进来的界面的情况下,你的地图引用可能是被绑定到了上一层Controller的$scope对象下\r\n\r\n声明一下,这个并不需要你的$scope去声明myMap,指令会自动帮你创建这个属性,具体操作请看src/angularjs-baidu-maps.js文件中第55行里面是通过model.assign(scope, map);将当前的地图引用设置给$scope\r\n\r\n具体$parse的用法,请参考 https://docs.angularjs.org/api/ng/service/$parse \r\n具体src中第55行功能,请参考文档$parse内容中右下角最后一行对assign 的解释", "title": null, "type": "comment" }, { "action": "closed", "author": "China-ls", "comment_id": null, "datetime": 1490329225000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
577
false
false
577
false
hpcc-systems/HPCC-Platform
hpcc-systems
115,894,779
7,936
{ "number": 7936, "repo": "HPCC-Platform", "user_login": "hpcc-systems" }
[ { "action": "opened", "author": "mckellyln", "comment_id": null, "datetime": 1447081401000, "masked_author": "username_0", "text": "@username_2 please review.", "title": "HPCC-14452 CSocketEpollThread - no exception for bad file descriptor", "type": "issue" }, { "action": "created", "author": "HPCCSmoketest", "comment_id": 155094804, "datetime": 1447082670000, "masked_author": "username_1", "text": "Automated Smoketest Build: success\nInstall hpccsystems-platform-community-with-plugins_5.4.6-rc1.el6.x86_64.rpm\nHPCC Start: OK\nHPCC Stop: OK\nHPCC Uninstall: OK", "title": null, "type": "comment" }, { "action": "created", "author": "jakesmith", "comment_id": 156190407, "datetime": 1447352540000, "masked_author": "username_2", "text": "@username_0 - I think this should be split into 2 commits", "title": null, "type": "comment" }, { "action": "created", "author": "mckellyln", "comment_id": 157414697, "datetime": 1447776306000, "masked_author": "username_0", "text": "Code updated based on review. Please re-review @username_2 when you get a chance.", "title": null, "type": "comment" }, { "action": "created", "author": "HPCCSmoketest", "comment_id": 157420003, "datetime": 1447777440000, "masked_author": "username_1", "text": "Automated Smoketest Build: success\nInstall hpccsystems-platform-community-with-plugins_5.4.6-rc1.el6.x86_64.rpm\nHPCC Start: OK\nHPCC Stop: OK\nHPCC Uninstall: OK", "title": null, "type": "comment" }, { "action": "created", "author": "jakesmith", "comment_id": 157686396, "datetime": 1447846979000, "masked_author": "username_2", "text": "@username_0 - 1 v.minor comment, looks good to merge.\r\nIs there another JIRA yet for the graceful close change for reference?", "title": null, "type": "comment" }, { "action": "created", "author": "mckellyln", "comment_id": 157751971, "datetime": 1447861164000, "masked_author": "username_0", "text": "Yes, its hpcc-14536", "title": null, "type": "comment" } ]
4
8
683
false
true
623
true
nhsconnect/gpconnect
nhsconnect
226,561,683
171
null
[ { "action": "opened", "author": "briandiggle", "comment_id": null, "datetime": 1493988282000, "masked_author": "username_0", "text": "There is a constraint on the participants forming part of the [gpconnect-appointment-1](https://www.simplifier.net/GPConnect/gpconnect-appointment-1/rendered ) profiled resources that states that \"Either the type or actor on the participant MUST be specified\"\r\n\r\nThis is not shown in the DMS. Would be useful to add a statment to the Book Appointments API spec to indicate this.\r\n\r\nAlso, would it be good to augment this constraint to require where the participant is a patient, that a patient resource reference be present, rather than potentially just a type element?", "title": "Appointment Profile - Participant constraints", "type": "issue" }, { "action": "created", "author": "michaelmeasures", "comment_id": 299856755, "datetime": 1494247552000, "masked_author": "username_1", "text": "@username_0 the constraint is from the base FHIR standard and I think we need a deeper review of the usage of values in the [encounter-participant-type](http://hl7.org/fhir/DSTU2/valueset-encounter-participant-type.html#expansion) value set. As this impacts potential use-cases such as when a translator or emergency contact is needed or referrer is available etc. Note, I expect 95% of these won't be actually used by the GP CIS systems (and maybe non at all).", "title": null, "type": "comment" }, { "action": "created", "author": "briandiggle", "comment_id": 305464164, "datetime": 1496315813000, "masked_author": "username_0", "text": "Additionally, the following should be considered (previously) \r\nThe gpconnect-appointment-1 profile has the following constraint on the participant element:\r\n\"Either the type or actor on the participant MUST be specified\"\r\n\r\nMy assumption is that this constraint allows the following:\r\nType only present\r\nActor only present\r\nType AND Actor present\r\n\r\nIt would be helpful to state this more clearly", "title": null, "type": "comment" }, { "action": "created", "author": "briandiggle", "comment_id": 329445503, "datetime": 1505386051000, "masked_author": "username_0", "text": "Decision is that where there is a participant element, actor MUST be present, type is optional", "title": null, "type": "comment" }, { "action": "closed", "author": "briandiggle", "comment_id": null, "datetime": 1505821677000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
5
1,523
false
false
1,523
true
openmicroscopy/infrastructure
openmicroscopy
179,427,983
125
{ "number": 125, "repo": "infrastructure", "user_login": "openmicroscopy" }
[ { "action": "opened", "author": "manics", "comment_id": null, "datetime": 1474964912000, "masked_author": "username_0", "text": "They're both useful but profiling adds extra output which obscures the rest of the ansible-playbook output, and `pipelining` is causing problems at the moment. These should be investigated later.", "title": "Revert some performance improvement changes to ansible.cfg", "type": "issue" }, { "action": "created", "author": "aleksandra-tarkowska", "comment_id": 249899540, "datetime": 1474989978000, "masked_author": "username_1", "text": "looks good, works\r\n\r\nwithout this PR:\r\n\r\n```\r\n(reverse-i-search)`dev': ansible-playbook os-devspace.yml -e vm_name=ola-test-devspace -e vm_key_name=ola\r\n(dev_tools) MacBookPro:ansible ola$ ansible-playbook -i ~/OMERO/SYSADMIN/management_tools/ansible/devspace -u centos devspace.yml\r\n\r\nPLAY [devspace] ****************************************************************\r\n\r\nTASK [setup] *******************************************************************\r\nTuesday 27 September 2016 16:18:33 +0100 (0:00:00.051) 0:00:00.051 ***** \r\nok: [10.0.51.143]\r\n\r\nTASK [upgrade-distpackages : system packages | upgrade] ************************\r\nTuesday 27 September 2016 16:18:33 +0100 (0:00:00.896) 0:00:00.947 ***** \r\nfailed: [10.0.51.143] (item=[u'*']) => {\"failed\": true, \"item\": [\"*\"], \"module_stderr\": \"sudo: sorry, you must have a tty to run sudo\\n\", \"module_stdout\": \"\", \"msg\": \"MODULE FAILURE\", \"parsed\": false}\r\n\r\nNO MORE HOSTS LEFT *************************************************************\r\n\r\nPLAY RECAP *********************************************************************\r\n10.0.51.143 : ok=1 changed=0 unreachable=0 failed=1 \r\n\r\nTuesday 27 September 2016 16:18:34 +0100 (0:00:00.254) 0:00:01.202 ***** \r\n=============================================================================== \r\nsetup ------------------------------------------------------------------- 0.90s\r\nupgrade-distpackages : system packages | upgrade ------------------------ 0.25s\r\n```\r\n\r\nwith this PR:\r\n\r\n```\r\n(dev_tools) MacBookPro:ansible ola$ git merge username_0/ansible_cfg_revert\r\nUpdating e42c17f..65df296\r\nFast-forward\r\n ansible/ansible.cfg | 4 ++--\r\n 1 file changed, 2 insertions(+), 2 deletions(-)\r\n(dev_tools) MacBookPro:ansible ola$ ansible-playbook -i ~/OMERO/SYSADMIN/management_tools/ansible/devspace -u centos devspace.yml\r\n\r\nPLAY [devspace] ****************************************************************\r\n\r\nTASK [setup] *******************************************************************\r\nok: [10.0.51.143]\r\n\r\nTASK [upgrade-distpackages : system packages | upgrade] ************************\r\nchanged: [10.0.51.143] => (item=[u'*'])\r\n\r\nTASK [upgrade-distpackages : system | current running kernel] ******************\r\nok: [10.0.51.143]\r\n\r\nTASK [upgrade-distpackages : system | latest installed kernel] *****************\r\nok: [10.0.51.143]\r\n [WARNING]: Consider using yum, dnf or zypper module rather than running rpm\r\n\r\n\r\nTASK [upgrade-distpackages : system | check if reboot needed] ******************\r\nok: [10.0.51.143]\r\n\r\nTASK [upgrade-distpackages : debug] ********************************************\r\nok: [10.0.51.143] => {\r\n \"msg\": \"Reboot needed (kernel): Current:3.10.0-327.22.2.el7.x86_64 Latest:3.10.0-327.36.1.el7.x86_64\"\r\n}\r\n\r\nTASK [upgrade-distpackages : system | reboot] **********************************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [upgrade-distpackages : system | wait for server to reboot] ***************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [lvm-partition : storage | create logical volume] *************************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [lvm-partition : storage | format] ****************************************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [lvm-partition : storage | mount] *****************************************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [docker : upstream docker | setup repository] *****************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : upstream docker | install docker] *******************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : storage | setup lvm docker-pool] ********************************\r\nskipping: [10.0.51.143]\r\n\r\nTASK [docker : upstream docker | configure docker options] *********************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : upstream docker | copy systemd file] ****************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : upstream docker | reload systemd] *******************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : docker | enable] ************************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [docker : docker | group members] *****************************************\r\n[DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this will be a fatal error.: 'docker_groupmembers' is undefined.\r\nThis \r\nfeature will be removed in a future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.\r\nskipping: [10.0.51.143]\r\n\r\nTASK [versioncontrol-utils : system packages | install epel repo] **************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [versioncontrol-utils : system packages | basic system utils] *************\r\nchanged: [10.0.51.143] => (item=[u'git'])\r\n\r\nTASK [devspace : add user omero to docker group] *******************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : ensures /home/omero/.ssh dir exists] **************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : allow omero to ssh directly] **********************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : install python tools] *****************************************\r\nchanged: [10.0.51.143] => (item=[u'python-devel', u'python-pip'])\r\n\r\nTASK [devspace : install python packages] **************************************\r\nchanged: [10.0.51.143] => (item=pip)\r\nchanged: [10.0.51.143] => (item=pyyaml)\r\nchanged: [10.0.51.143] => (item=docker-compose)\r\n\r\nTASK [devspace : TODO install docker-py] ***************************************\r\nchanged: [10.0.51.143] => (item=docker-py==1.9.0)\r\n\r\nTASK [devspace : clone devspace] ***********************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : ensures .ssh dir exists] **************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : copy snoopy] **************************************************\r\nchanged: [10.0.51.143] => (item={u'dest': u'.ssh/config', u'srcfile': u'.ssh/config'})\r\nchanged: [10.0.51.143] => (item={u'dest': u'.ssh/username_2_github', u'srcfile': u'.ssh/username_2_github'})\r\nchanged: [10.0.51.143] => (item={u'dest': u'.ssh/username_2_github.pub', u'srcfile': u'.ssh/username_2_github.pub'})\r\nchanged: [10.0.51.143] => (item={u'dest': u'.gitconfig', u'srcfile': u'.gitconfig'})\r\n\r\nTASK [devspace : known_hosts] **************************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : chmod known_hosts] ********************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : change USER_ID] ***********************************************\r\nchanged: [10.0.51.143] => (item={u'file': u'nginx/Dockerfile'})\r\nchanged: [10.0.51.143] => (item={u'file': u'slave/Dockerfile'})\r\nchanged: [10.0.51.143] => (item={u'file': u'server/Dockerfile'})\r\nchanged: [10.0.51.143] => (item={u'file': u'web/Dockerfile'})\r\n\r\nTASK [devspace : ssl cert for jenkins] *****************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : ssl cert for nginx] *******************************************\r\nchanged: [10.0.51.143]\r\n\r\nTASK [devspace : Rrename to dev_5_2...] ****************************************\r\nchanged: [10.0.51.143]\r\n\r\nRUNNING HANDLER [docker : restart docker] **************************************\r\nchanged: [10.0.51.143]\r\n\r\nPLAY RECAP *********************************************************************\r\n10.0.51.143 : ok=30 changed=25 unreachable=0 failed=0 \r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "snoopycrimecop", "comment_id": 250055963, "datetime": 1475029889000, "masked_author": "username_2", "text": "Conflicting PR. Removed from build [MANAGEMENT_TOOLS-merge#972](https://ci.openmicroscopy.org/job/MANAGEMENT_TOOLS-merge/972/). See the [console output](https://ci.openmicroscopy.org/job/MANAGEMENT_TOOLS-merge/972/consoleText) for more details.\nPossible conflicts:\n - PR #116 username_1 'prompt for jenkins password'\n - ansible/ansible.cfg\n - PR #121 username_0 'Return non-zero error code if no hosts match'\n - ansible/ansible.cfg\n - PR #124 username_0 'Get the IDR playbooks working smoothly with multiple deployments'\n - ansible/ansible.cfg", "title": null, "type": "comment" }, { "action": "created", "author": "joshmoore", "comment_id": 250392862, "datetime": 1475134537000, "masked_author": "username_3", "text": "Merging with a few caveats:\r\n\r\n * let's leave https://github.com/openmicroscopy/infrastructure/issues/118 open and try to solve our sudo issues as soon as possible (>Oct)\r\n * I'll activate profiling locally for me, but I encourage everyone to turn it on since it clearly points to what stages are taking too long while a playbook is under development.", "title": null, "type": "comment" } ]
4
4
8,505
false
false
8,505
true
jimkyndemeyer/react-css-modules-intellij-plugin
null
240,339,752
6
null
[ { "action": "opened", "author": "anstarovoyt", "comment_id": null, "datetime": 1499154707000, "masked_author": "username_0", "text": "Hi. In our internal exception analyzer was reported the exception:\r\nhttps://gist.github.com/username_0/f982a8011cc84a2edf5d22bfb9d64c7f\r\nit seems `getCssClassNamesImportOrRequireDeclaration` the cause of the error.", "title": "SOE", "type": "issue" }, { "action": "created", "author": "jimkyndemeyer", "comment_id": 312835369, "datetime": 1499161773000, "masked_author": "username_1", "text": "Hi Andrew.\r\n\r\nThanks for reporting this.\r\n\r\nCan you provide any additional info on how to reproduce, or offer guidance with regards to fixing it?\r\n\r\nThanks,\r\nJim.", "title": null, "type": "comment" } ]
2
2
377
false
false
377
true
yury-dymov/json-api-normalizer
null
293,296,456
31
{ "number": 31, "repo": "json-api-normalizer", "user_login": "yury-dymov" }
[ { "action": "opened", "author": "kshahani", "comment_id": null, "datetime": 1517429702000, "masked_author": "username_0", "text": "JSON API spec indicates that the `data` object is optional, but `meta` and `links` can still be returned. Keep this data on the metadata object.", "title": "Keep metadata and links even if data it not returned in the response", "type": "issue" }, { "action": "created", "author": "kshahani", "comment_id": 362317718, "datetime": 1517501917000, "masked_author": "username_0", "text": "@username_1 Got a minute to review?", "title": null, "type": "comment" }, { "action": "created", "author": "yury-dymov", "comment_id": 362319920, "datetime": 1517502321000, "masked_author": "username_1", "text": "Looks good, thank you!", "title": null, "type": "comment" } ]
3
5
855
false
true
201
true
Dataman-Cloud/crane
Dataman-Cloud
177,642,550
451
null
[ { "action": "opened", "author": "ykyx", "comment_id": null, "datetime": 1474192377000, "masked_author": "username_0", "text": "", "title": "ERROR: NTP is unsynchronised, Please confirm your ntp status before continue", "type": "issue" }, { "action": "created", "author": "vitan", "comment_id": 247898704, "datetime": 1474249853000, "masked_author": "username_1", "text": "The swarm cluster is maintaining sth. against clock synchronization. You have to run\r\n`yum install -y ntp&service ntpd restart` for centos, or `apt-get install -y ntp&service ntpd start`\r\n\r\n[More detail](https://github.com/Dataman-Cloud/crane/blob/master/frontend/misc-tools/node-init.sh#L169)", "title": null, "type": "comment" }, { "action": "closed", "author": "vitan", "comment_id": null, "datetime": 1474249854000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
293
false
false
293
false
googleapis/gax-php
googleapis
193,168,625
49
{ "number": 49, "repo": "gax-php", "user_login": "googleapis" }
[ { "action": "opened", "author": "michaelbausor", "comment_id": null, "datetime": 1480698590000, "masked_author": "username_0", "text": "", "title": "Bump version to 0.5.0 for release", "type": "issue" }, { "action": "created", "author": "garrettjonesgoogle", "comment_id": 264507693, "datetime": 1480698770000, "masked_author": "username_1", "text": "I noticed that composer.json doesn't have this version number in it - is that standard for php packages, to not have the version number anywhere in the source tree?", "title": null, "type": "comment" }, { "action": "created", "author": "michaelbausor", "comment_id": 264509331, "datetime": 1480699202000, "masked_author": "username_0", "text": "Yes, my understanding is that this is normal (see e.g. [google cloud php](https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/composer.json) or [symfony](https://github.com/symfony/symfony/blob/master/composer.json) ) which don't have version numbers. The version number is fully controlled by the git tag.", "title": null, "type": "comment" }, { "action": "created", "author": "garrettjonesgoogle", "comment_id": 264509727, "datetime": 1480699299000, "masked_author": "username_1", "text": "Ok. LGTM.", "title": null, "type": "comment" } ]
3
5
495
false
true
495
false
mcsheaj/SPEasyForms
null
218,660,207
96
null
[ { "action": "opened", "author": "mcsheaj", "comment_id": null, "datetime": 1491013261000, "masked_author": "username_0", "text": "**This issue was imported from [CodePlex](http://SPEasyForms.codeplex.com/workitem/12)**\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-19 at 11:47\r\nI'm clicking \"Save\" and nothing is happening. I'm pretty sure it's because that library isn't on the site. I remember you mentioning it at SPS VA Beach, but I don't see any documentation about it.\r\n\r\n\r\n\r\n\r\nThanks!\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-19 at 11:59\r\nIt also appears that when the solution was activated, all files in the Style Library were not automatically checked in. I got them checked in, but the \"Save\" button still isn't doing anything. (And, it was the Style Library I was thinking of.\r\n It is at the root of the site collection that this sub-site is on.) Using IE 10.0.9200.17183.\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 19:32\r\nAll of the files I install during deployment are saved to the root Style Library, but the configuration files for a given site are saved in the Site Assets library (which should be at the URL <web>/SiteAssets). The library type should theoretically\r\n be Site Assets, but I believe it wouldn't matter if it were just a plain document library as long as it's url is SiteAssets (no spaces).\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 19:40\r\nJust to make sure I understand what you're seeing, when the form first loads the Save button should be quasi-transparent. Once you make a change, it should change to solid (any change, add a container, create a visibility rule, whatever). Once it is solid,\r\n if you click it, it should save the config and turn back to quasi-transparent. If you click it when it is quasi-transparent, nothing will happen.\r\n\r\n\r\n\r\nDoes any of this make sense with what you're seeing? i.e. does it start transparent, go solid on a change, and stay solid after you click it? or does it never go solid (i.e. the button always looks the same no matter what you do)? etc. There is nothing to indicate\r\n a save has occurred other than the change in the appearance of the button (and a couple of other buttons on the ribbon actually change too, generally when you have changes that need to be save or when you do a save).\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 21:20\r\nAlso, on the check-in issue, this is a known issue with sandbox solutions on SP 2010 (you didn't say, but I assume you're on 2010). The only way around it right now is to turn off 'require checkout' on the style library before you install the solution.\r\n If you've already activated the solution, the easiest fix is to disable the solution, delete the SPEasyForms directory in the Style Library, and then re-install the solution. I haven't seen this issue on 2013 or Office 365.\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-20 at 08:49\r\nIt was the SiteAssets library I was missing on the site! Would you add this into your installation instructions for others?\r\n\r\n\r\n\r\nNow that I have the library, the \"Save\" button behavior is how you mentioned above.\r\n\r\n\r\n\r\n\r\nAnd, thanks for the quick response! I'm rockin' and rollin' now!!!\r\n\r\n\r\n\r\nErin", "title": "What's the library name/type that must be on the site where the config files get saved?", "type": "issue" }, { "action": "closed", "author": "mcsheaj", "comment_id": null, "datetime": 1491013261000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "opened", "author": "mcsheaj", "comment_id": null, "datetime": 1491013261000, "masked_author": "username_0", "text": "**This issue was imported from [CodePlex](http://SPEasyForms.codeplex.com/workitem/12)**\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-19 at 11:47\r\nI'm clicking \"Save\" and nothing is happening. I'm pretty sure it's because that library isn't on the site. I remember you mentioning it at SPS VA Beach, but I don't see any documentation about it.\r\n\r\n\r\n\r\n\r\nThanks!\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-19 at 11:59\r\nIt also appears that when the solution was activated, all files in the Style Library were not automatically checked in. I got them checked in, but the \"Save\" button still isn't doing anything. (And, it was the Style Library I was thinking of.\r\n It is at the root of the site collection that this sub-site is on.) Using IE 10.0.9200.17183.\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 19:32\r\nAll of the files I install during deployment are saved to the root Style Library, but the configuration files for a given site are saved in the Site Assets library (which should be at the URL <web>/SiteAssets). The library type should theoretically\r\n be Site Assets, but I believe it wouldn't matter if it were just a plain document library as long as it's url is SiteAssets (no spaces).\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 19:40\r\nJust to make sure I understand what you're seeing, when the form first loads the Save button should be quasi-transparent. Once you make a change, it should change to solid (any change, add a container, create a visibility rule, whatever). Once it is solid,\r\n if you click it, it should save the config and turn back to quasi-transparent. If you click it when it is quasi-transparent, nothing will happen.\r\n\r\n\r\n\r\nDoes any of this make sense with what you're seeing? i.e. does it start transparent, go solid on a change, and stay solid after you click it? or does it never go solid (i.e. the button always looks the same no matter what you do)? etc. There is nothing to indicate\r\n a save has occurred other than the change in the appearance of the button (and a couple of other buttons on the ribbon actually change too, generally when you have changes that need to be save or when you do a save).\r\n\r\n**[username_0](http://www.codeplex.com/site/users/view/username_0)** wrote 2015-01-19 at 21:20\r\nAlso, on the check-in issue, this is a known issue with sandbox solutions on SP 2010 (you didn't say, but I assume you're on 2010). The only way around it right now is to turn off 'require checkout' on the style library before you install the solution.\r\n If you've already activated the solution, the easiest fix is to disable the solution, delete the SPEasyForms directory in the Style Library, and then re-install the solution. I haven't seen this issue on 2013 or Office 365.\r\n\r\n**[ebglenn](http://www.codeplex.com/site/users/view/ebglenn)** wrote 2015-01-20 at 08:49\r\nIt was the SiteAssets library I was missing on the site! Would you add this into your installation instructions for others?\r\n\r\n\r\n\r\nNow that I have the library, the \"Save\" button behavior is how you mentioned above.\r\n\r\n\r\n\r\n\r\nAnd, thanks for the quick response! I'm rockin' and rollin' now!!!\r\n\r\n\r\n\r\nErin", "title": "What's the library name/type that must be on the site where the config files get saved?", "type": "issue" } ]
1
3
6,530
false
false
6,530
true
Azure/autorest
Azure
310,635,111
2,886
null
[ { "action": "opened", "author": "dsgouda", "comment_id": null, "datetime": 1522708951000, "masked_author": "username_0", "text": "@olydis \r\nMoving from [here](https://github.com/Azure/azure-sdk-for-net/issues/4012)\r\nIt does make sense that \"Operation returned an invalid status code\" would imply that an actual \"invalid\" status code was returned (like -1) which is a bit confusing. \r\nWe could probably make these improvements in the feature for improved exceptions.", "title": "Better message for exceptions", "type": "issue" } ]
1
1
335
false
false
335
false
simplesmiler/vue-clickaway
null
216,041,136
12
null
[ { "action": "opened", "author": "sanyashvets", "comment_id": null, "datetime": 1490184684000, "masked_author": "username_0", "text": "I have a modal with `v-click-away` directive installed on it with `modalClose` event. And also I have dropdown's `<li>`, buttons with (`v-if`, `v-show` in modal) and `@click` events on it. I have no idea why, but modal fires it `modalClose` event by `click` on `li` and `buttons`. Yes, I can use `@mouseup` or `@mousedown` events instead of `@click`, but I think I have to tell u about this issue", "title": "Click close", "type": "issue" }, { "action": "created", "author": "simplesmiler", "comment_id": 290900036, "datetime": 1491028521000, "masked_author": "username_1", "text": "Hi! Thanks for the report and sorry for taking some time to answer.\r\n\r\nLike with https://github.com/username_1/vue-clickaway/issues/9, most likely your dropdown content is attached outside of the model container (e. g. attached to `<body>`). Can you provide a demo?\r\n\r\nIf that is the case, then the solution is to manually check in the away handler whether the event originated from the dropdown content.", "title": null, "type": "comment" }, { "action": "created", "author": "sanyashvets", "comment_id": 291435976, "datetime": 1491296029000, "masked_author": "username_0", "text": "`click-away` fires, if dropdown installed with `v-if` directive. In all cases. All troubles like this happens only with `v-if`", "title": null, "type": "comment" }, { "action": "created", "author": "ExileLee", "comment_id": 304376483, "datetime": 1495829133000, "masked_author": "username_2", "text": "@username_0 \r\nhave same issue..\r\n\r\nI found a simple solution\r\njust set `@click.stop`", "title": null, "type": "comment" }, { "action": "created", "author": "simplesmiler", "comment_id": 379542833, "datetime": 1523186919000, "masked_author": "username_1", "text": "Looking at this with a fresh eye, this should have already been fixed in [2.1](https://github.com/username_1/vue-clickaway/releases/tag/2.1.0).\r\nAlso, Vue 2.5 [slightly changed it's internals](https://gist.github.com/yyx990803/9bdff05e5468a60ced06c29c39114c6b#internals-change-for-nexttick) in a way that also should fix this issue.\r\n\r\nYou may only be affected by this if you are using Vue < 2.5 *and* VueClickaway < 2.1. Try updating, and if you are still being affected by this, please open a new issue with a repro.", "title": null, "type": "comment" }, { "action": "closed", "author": "simplesmiler", "comment_id": null, "datetime": 1523186919000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
6
1,534
false
false
1,534
true
bos/aeson
null
248,451,204
575
null
[ { "action": "opened", "author": "amigalemming", "comment_id": null, "datetime": 1502120487000, "masked_author": "username_0", "text": "I find the parsing of nested JSON structures in [Elm](http://package.elm-lang.org/packages/elm-lang/core/5.1.1/Json-Decode) somehow simpler than the way `aeson` goes. In Elm I start with simple `field` parsers and build them together using `liftAn` style combinators. No need to define instances. Maybe the `lens` stuff in #570 addresses this style, but it looks complicated.", "title": "Elm style JSON parsing", "type": "issue" }, { "action": "created", "author": "bergmark", "comment_id": 320706601, "datetime": 1502121978000, "masked_author": "username_1", "text": "Elm has to do it this way since there are no type classes. The disadvantage with the approach is that you essentially have to pass around the type class dictionaries manually instead of having the compiler insert them for you. With deeply nested structures this becomes cumbersome, even morey so when recursion or polymorphism comes into the picture.\r\n\r\nThe good news is that you can always translate the aeson approach to the one used in elm:\r\n```\r\nstring2Json :: String -> Value\r\nstring2Json = toJson\r\n\r\nmyString2Json :: MyString -> Value\r\nmyString2Json (MyString s) = string2Json s\r\n\r\nint2Json :: Int -> Value\r\nint2Json = toJson\r\n\r\ntuple2Json :: (a -> Value) -> (b -> Value) -> ((a, b) -> Value)\r\ntuple2Json a2Json b2Json (a,b) = toJson (a2Json a, a2json b)\r\n\r\nmyStringInt2Json = tuple2Json myString2Json int2Json\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "amigalemming", "comment_id": 320708485, "datetime": 1502122399000, "masked_author": "username_0", "text": "I meant parsing, not formatting JSON.", "title": null, "type": "comment" }, { "action": "created", "author": "Lysxia", "comment_id": 321210052, "datetime": 1502272532000, "masked_author": "username_2", "text": "+1 on this proposal.\r\n\r\nDictionaries have to be passed anyway, whether implicitly (aeson) or explicitly (Elm). However with type classes this essentially means you need to declare one type for every dictionary. So the type-class-based approach of aeson works best when types match the JSON schema closely. Extra combinators would be handy in less ideal situations; e.g. when your type is a single flat record represented in JSON by nested objects.", "title": null, "type": "comment" }, { "action": "created", "author": "phadej", "comment_id": 321212417, "datetime": 1502273146000, "masked_author": "username_3", "text": "There'is (almost) everything you need to do Elm style parsing.\r\n\r\n```haskell\r\ndata Foo = Foo\r\n { fooBool :: Bool\r\n , fooInt :: Int\r\n }\r\n\r\nboolParseJSON :: Value -> Parser Bool\r\nboolParseJSON = parseJSON\r\n\r\nintParseJSON :: Value -> Parser Int\r\nintParseJSON = parseJSON\r\n\r\nfooParseJSON :: Value -> Parser Foo\r\nfooParseJSON = withObject \"Foo\" $ \\obj -> Foo\r\n <$> explicitParseField boolParseJSON obj \"bool\"\r\n <$> explicitParseField intParseJSON obj \"int\"\r\n\r\ndecodeFoo :: LBS.ByteString -> Either Strict Foo\r\ndecodeFoo bs = eitherDecode bs >>= resultToEither . parseEither fooParseJSON\r\n where\r\n -- this could be added to `aeson`\r\n resultToEither :: Result a -> Either String a \r\n resultToEither (Success a) = Right a \r\n resultToEither (Error str) = Left str\r\n\r\n -- or/and this\r\n -- analogue of 'either'\r\n result :: (String -> r) -> (a - > r) -> Result a -> r\r\n result s _ (Success x) = s x\r\n result _ e (Error x) = e x\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "Lysxia", "comment_id": 321214068, "datetime": 1502273603000, "masked_author": "username_2", "text": "Oh, I didn't see the `explicitParseField`!", "title": null, "type": "comment" }, { "action": "created", "author": "bergmark", "comment_id": 327015503, "datetime": 1504551550000, "masked_author": "username_1", "text": "In general any type class method can be transformed into a function with explicit arguments instead of dictionaries.\r\n\r\n\r\nI think the best way to start out this process would be to create another library on top of aeson so that it can mature freely. If there are any show-stoppers for this in aeson I'd be all for fixing those.", "title": null, "type": "comment" }, { "action": "created", "author": "bergmark", "comment_id": 643716783, "datetime": 1592108768000, "masked_author": "username_1", "text": "Closing this as it doesn't need to be done in aeson itself, is someone writes a separate library for this we may at some point consider moving it into aeson proper.", "title": null, "type": "comment" }, { "action": "closed", "author": "bergmark", "comment_id": null, "datetime": 1592108768000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
4
9
3,181
false
false
3,181
false
dart-lang/sdk
dart-lang
239,108,446
30,039
null
[ { "action": "opened", "author": "lrhn", "comment_id": null, "datetime": 1498642946000, "masked_author": "username_0", "text": "We have decided to allow trailing commas in asserts (an optional comma before the end-parenthesis).\r\nDart2js needs to implement this feature.", "title": "Dart2js: Trailing comma in asserts.", "type": "issue" }, { "action": "created", "author": "natebosch", "comment_id": 417768371, "datetime": 1535744027000, "masked_author": "username_1", "text": "Its working on Dartpad - probably since it's on CFE now.", "title": null, "type": "comment" }, { "action": "closed", "author": "natebosch", "comment_id": null, "datetime": 1535744028000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
197
false
false
197
false
rubrikinc/PowerShell-Module
rubrikinc
159,264,811
20
null
[ { "action": "opened", "author": "chriswahl", "comment_id": null, "datetime": 1465418191000, "masked_author": "username_0", "text": "We already have `Get-RubrikSLA` but need a way to:\r\n\r\n1. Output that to a flat file (preferably using JSON) somewhere\r\n2. Input it into a new cmdlet, potentially named `New-RubrikSLA`\r\n\r\nIdeally, this would be handy for creating templates of a configuration, or for validating a configuration in one place and migrating it to a configuration in another place (internal to external, lab to field, etc.)", "title": "Create a way to export / import SLA domain config", "type": "issue" }, { "action": "created", "author": "Lucas-Fueyo", "comment_id": 224941604, "datetime": 1465487973000, "masked_author": "username_1", "text": "Made a merge request which enabled basic json export into the `Get-RubrikSLA` cmdlet. \r\n\r\nIn order to be able to create a \"full\" template of the SLA Domains we would still have to : \r\n- Create a `Get-RubrikReplication` and `Get-RubrikArchival` cmdlets, export their configuration using json and interpret everything through `New-RubrikSLA`. \r\n\r\nWhat would be great for the `New-RubrikSLA` would be to : \r\n- Update the SLA Domain properties if it already exists (new cmdlet to create, for example `Set-RubrikSLA`)\r\n- Prompts the user in case the Replication Target / Archival location doesn't already exist and asks for their creation.", "title": null, "type": "comment" }, { "action": "created", "author": "chriswahl", "comment_id": 224957734, "datetime": 1465491265000, "masked_author": "username_0", "text": "@username_1 Good points. I didn't even think about the creation of Archive / Replication; was assuming the admin would populate those in advance. My only concern with exporting those pieces are the secret keys / passwords for the respective targets.", "title": null, "type": "comment" }, { "action": "created", "author": "Lucas-Fueyo", "comment_id": 225111578, "datetime": 1465543435000, "masked_author": "username_1", "text": "The secret keys could indeed be a problem. The admin would have to plan this one and if he did, I guess it would nearly be easier to do the archival / replication declaration through the web GUI.", "title": null, "type": "comment" }, { "action": "created", "author": "chriswahl", "comment_id": 225909566, "datetime": 1465916349000, "masked_author": "username_0", "text": "Partially resolves #23", "title": null, "type": "comment" }, { "action": "created", "author": "chriswahl", "comment_id": 269683702, "datetime": 1483041051000, "masked_author": "username_0", "text": "The use of `Get-RubrikSLA` and `New-RubrikSLA` solves the majority of this issue. I'm purposefully leaving out the replication and archive details as those would likely change across entities (from reseller to customer or site to site) anyway.\r\n\r\nref: https://github.com/rubrikinc/PowerShell-Module/commit/9f0b5c50a14a9ed728c74a7c1115dbccefee187e", "title": null, "type": "comment" }, { "action": "closed", "author": "chriswahl", "comment_id": null, "datetime": 1483041054000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
7
1,849
false
false
1,849
true
NLog/NLog
NLog
165,272,523
1,539
null
[ { "action": "opened", "author": "sushmahonda", "comment_id": null, "datetime": 1468400829000, "masked_author": "username_0", "text": "Hello,\r\n I'm trying to logs stored in to the database.but we are getting the below InternalLogger error. Please see the below LoggingConfiguration databse using C#.\r\n2016-07-13 01:49:03.5817 Info Found 117 configuration items\r\n2016-07-13 01:49:03.6328 Info Found 117 configuration items\r\n\r\n\r\nDatabaseTarget target = new DatabaseTarget();\r\n DatabaseParameterInfo param;\r\n\r\n target.DBProvider = \"sqlserver\";\r\n target.DBHost = \".\";\r\n target.Name = \"database\";\r\n target.ConnectionString = \"Data Source=\\SQLSERVER;Initial Catalog=DatabaseName;User Id=id;Password=password;Integrated Security=True\";\r\n target.CommandText = \"exec NLog_Webservice @site_id,@request_xml,@response_xml,@servername, @datetimestamp,@session_id,@method, @username,@data1,@data2,@data3,@data4\";\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@site_id\";\r\n param.Layout = \"${gdc:item=site_id}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@request_xml\";\r\n param.Layout = \"${gdc:item=requestxml}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@response_xml\";\r\n param.Layout = \"${gdc:item=responsexml}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@servername\";\r\n param.Layout = \"${machinename}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@datetimestamp\";\r\n param.Layout = \"${date}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@session_id\";\r\n param.Layout = \"${gdc:item=sessionid}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@method\";\r\n param.Layout = \"${gdc:item=method}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@username\";\r\n param.Layout = \"${windows-identity}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@data1\";\r\n param.Layout = \"${gdc:item=data1}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@data2\";\r\n param.Layout = \"${gdc:item=data2}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@data3\";\r\n param.Layout = \"${gdc:item=data3}\";\r\n target.Parameters.Add(param);\r\n\r\n param = new DatabaseParameterInfo();\r\n param.Name = \"@data4\";\r\n param.Layout = \"${gdc:item=data4}\";\r\n target.Parameters.Add(param);\r\n InternalLogger.LogFile = \"c:\\\\log1.txt\";\r\n\r\n config.AddTarget(target.Name, target);\r\n config.LoggingRules.Add(new LoggingRule(\"tableLogegr\", LogLevel.Debug, target));\r\n\r\nplease help ASAP...\r\n\r\nThanks", "title": "LoggingConfiguration Database table logger we are getting InternalLogger error: 2016-07-13 01:49:03.5817 Info Found 117 configuration items", "type": "issue" }, { "action": "created", "author": "304NotModified", "comment_id": 232418249, "datetime": 1468429007000, "masked_author": "username_1", "text": "What is the internal error? Please use the issue template", "title": null, "type": "comment" }, { "action": "created", "author": "304NotModified", "comment_id": 234742678, "datetime": 1469310897000, "masked_author": "username_1", "text": "Hey! Could you give us some more into?", "title": null, "type": "comment" }, { "action": "created", "author": "304NotModified", "comment_id": 235397459, "datetime": 1469565468000, "masked_author": "username_1", "text": "We cannot help you without the needed info. Feel free to give some more info and then I will reopen this issue.", "title": null, "type": "comment" }, { "action": "closed", "author": "304NotModified", "comment_id": null, "datetime": 1469565469000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
5
3,474
false
false
3,474
false
k-ta-yamada/systemd_service_check
null
294,252,957
20
null
[ { "action": "opened", "author": "k-ta-yamada", "comment_id": null, "datetime": 1517795799000, "masked_author": "username_0", "text": "### systemd_service_check.sample.yml\r\n\r\n```yaml\r\nservers:\r\n - env: dev\r\n role: ap # <- add this key\r\n ip: 192.168.1.101\r\n user: root\r\n password: vagrant\r\n services: *default_services\r\n - env: dev\r\n role: db # <- add this key\r\n ip: 192.168.1.101\r\n user: root\r\n password: vagrant\r\n services: *default_services\r\n - env: stg\r\n role: ap # <- add this key\r\n ip: 192.168.1.101\r\n user: root\r\n password: vagrant\r\n services: *default_services\r\n```\r\n\r\n### Usage image\r\n\r\n```\r\n# All for `dev` environment\r\nssc chceck dev\r\n\r\n# Only for `ap` role of `dev` environment\r\nssc check dev --role ap\r\nssc check dev:ap\r\n\r\n# All for `ap` roles\r\nssc check all --role ap\r\nssc check all:ap\r\n\r\n# Only for `ap` role of `dev` and `stg` environments\r\nssc check dev stg --role ap\r\n\r\n```", "title": "add server's role settings", "type": "issue" }, { "action": "closed", "author": "k-ta-yamada", "comment_id": null, "datetime": 1518055602000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
860
false
false
860
false
cerner/terra-consumer
cerner
270,428,578
95
null
[ { "action": "opened", "author": "kafkahw", "comment_id": null, "datetime": 1509565613000, "masked_author": "username_0", "text": "# Issue Description\r\nThere are extra spacings around logo in Nav when consuming an svg file as logo. See attached screenshot.\r\n\r\n## Issue Type\r\n- [ ] Bug\r\n\r\n## Expected Behavior\r\nNo extra spacings. \r\n\r\n## Current Behavior\r\n<!-- Tell us what happens instead of the expected behavior -->\r\n<!-- Leave a comment \"N/A\" if there is no current behavior -->\r\n\r\n<!----------------------------------------------------------------------------------->\r\n<!-- If you are reporting a bug, please fill out the sections below. -->\r\n<!-- Otherwise, the sections below can be deleted. -->\r\n<!----------------------------------------------------------------------------------->\r\n\r\n## Steps to Reproduce\r\n<!-- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!-- reproduce this bug. Include code to reproduce, if relevant -->\r\n1. Pass \"https://d320j1w59ws5w0.cloudfront.net/EveryDayWell-logo.svg\" as URL to terra-consumer-nav and run the test site locally. \r\n2. Verify the issue in IE 11.\r\n\r\n\r\n## Environment\r\n<!-- Include as many relevant details about the environment you experienced the bug in -->\r\n* Component Version: terra-consumer-nav (0.2.6) and terra-consumer-layout that consumes it.\r\n* Browser Name and Version: IE 11\r\n* Operating System and version (desktop or mobile): desktop\r\n\r\n## Solution\r\nAdd `height: 100%` to img tag in this file: https://github.com/cerner/terra-consumer/blob/terra-consumer-nav%400.2.6/packages/terra-consumer-nav/src/components/nav-logo/NavLogo.scss#L19", "title": "Extra spacings around logo in terra-consumer-nav in IE11", "type": "issue" }, { "action": "created", "author": "kafkahw", "comment_id": 341218560, "datetime": 1509565629000, "masked_author": "username_0", "text": "<img width=\"1480\" alt=\"screen shot 2017-11-01 at 2 38 20 pm\" src=\"https://user-images.githubusercontent.com/2274728/32294222-86d77cdc-bf13-11e7-8357-3768f97368ed.png\">", "title": null, "type": "comment" }, { "action": "created", "author": "alex-bezek", "comment_id": 341287570, "datetime": 1509584444000, "masked_author": "username_1", "text": "Interesting, so this is only for the combination of IE 11 AND SVG?", "title": null, "type": "comment" }, { "action": "created", "author": "mhemesath", "comment_id": 341289684, "datetime": 1509585375000, "masked_author": "username_2", "text": "I believe so, yes", "title": null, "type": "comment" } ]
3
4
1,747
false
false
1,747
false
MrRoundRobin/telegram.bot
null
93,420,503
2
null
[ { "action": "opened", "author": "NickNVM", "comment_id": null, "datetime": 1436235772000, "masked_author": "username_0", "text": "Tried calling it with working IDs and always the response status code is 400 (Bad Request). Also tried my own ID, even than it's still not working.\r\n\r\nException details:\r\n\r\nSystem.Net.Http.HttpRequestException\r\nResponse status code does not indicate success: 400 (Bad Request).", "title": "api.SendTextMessage(...) not working", "type": "issue" }, { "action": "created", "author": "MrRoundRobin", "comment_id": 119117919, "datetime": 1436257635000, "masked_author": "username_1", "text": "Oh, there was a typo, which coused that...", "title": null, "type": "comment" }, { "action": "closed", "author": "MrRoundRobin", "comment_id": null, "datetime": 1436257815000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
319
false
false
319
false
softlayer/softlayer-python
softlayer
68,501,409
525
null
[ { "action": "opened", "author": "MiguelHigorre", "comment_id": null, "datetime": 1429046580000, "masked_author": "username_0", "text": "The 'slcli metadata tags' command fails, the following exception is raised when debug is set:\r\n\r\nslcli -vvv metadata tags\r\n=== REQUEST ===\r\nhttps://api.service.softlayer.com/rest/v3.1/SoftLayer_Resource_Metadata/Tags/None.json\r\n{'Content-Type': 'application/json', 'Accept-Encoding': 'gzip, deflate, compress', 'Accept': '*/*', 'User-Agent': 'softlayer-python/v4.0.0'}\r\nStarting new HTTPS connection (1): api.service.softlayer.com\r\nSetting read timeout to 5\r\n\"GET /rest/v3.1/SoftLayer_Resource_Metadata/Tags/None.json HTTP/1.1\" 404 70\r\n=== RESPONSE ===\r\nCaseInsensitiveDict({'x-client-ip': '192.168.67.116', 'content-length': '70', 'vary': 'Accept-Encoding', 'server': 'Apache', 'x-backside-transport': 'FAIL FAIL', 'connection': 'close', 'date': 'Tue, 14 Apr 2015 21:15:33 GMT', 'content-type': 'application/json'})\r\n{\"error\":\"Service does not exist\",\"code\":\"SoftLayer_Exception_Public\"}\r\n\r\nThe problem is reproduced using API SoftLayer python client version 4, using version 3 of the client to run the 'sl metadata tags' command works with no problems", "title": "'slcli metadata tags' command fails", "type": "issue" }, { "action": "created", "author": "sudorandom", "comment_id": 93067717, "datetime": 1429046694000, "masked_author": "username_1", "text": "Thanks @username_0. This is using the latest master, right?", "title": null, "type": "comment" }, { "action": "created", "author": "MiguelHigorre", "comment_id": 93068940, "datetime": 1429046888000, "masked_author": "username_0", "text": "Yep, I used latest master, I used 'pip install git+git://github.com/softlayer/softlayer-python.git' command to install the client", "title": null, "type": "comment" }, { "action": "created", "author": "sudorandom", "comment_id": 93069716, "datetime": 1429046997000, "masked_author": "username_1", "text": "I opened a PR (#526) with what I believe is a fix for this. Let me know if it works for you.", "title": null, "type": "comment" }, { "action": "created", "author": "MiguelHigorre", "comment_id": 93098836, "datetime": 1429051182000, "masked_author": "username_0", "text": "Is this fix available in your github reporsitory \"https://github.com/username_1/softlayer-api-python-client\"", "title": null, "type": "comment" }, { "action": "created", "author": "sudorandom", "comment_id": 93099487, "datetime": 1429051351000, "masked_author": "username_1", "text": "Yeah, I think you can use this command to install from the right branch:\r\n\r\n```\r\npip install 'git+git://github.com/username_1/softlayer-api-python-client.git@metadata-fix'\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "MiguelHigorre", "comment_id": 93101091, "datetime": 1429051672000, "masked_author": "username_0", "text": "The fix worked, now the 'slcli metadata tags' command works\r\n\r\nThanks.", "title": null, "type": "comment" }, { "action": "closed", "author": "sudorandom", "comment_id": null, "datetime": 1429057946000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
8
1,690
false
false
1,690
true
OpenWaterAnalytics/Stormwater-Management-Model
OpenWaterAnalytics
154,385,806
2
null
[ { "action": "opened", "author": "bemcdonnell", "comment_id": null, "datetime": 1463021429000, "masked_author": "username_0", "text": "I think it's time to dream up an Input API that will find its way into the formal distribution of SWMM. :)", "title": "Input API", "type": "issue" }, { "action": "created", "author": "bemcdonnell", "comment_id": 218914641, "datetime": 1463095825000, "masked_author": "username_0", "text": "EPANET has a toolkit API containing some good starting point ideas.\r\n\r\nhttps://github.com/OpenWaterAnalytics/EPANET/blob/master/src/toolkit.h Lines 243 and 244 reference the functions to \"set\" values for a node and a link. This could be expanded in SWMM to adjust hydrology and Ground water parameters.", "title": null, "type": "comment" }, { "action": "created", "author": "samhatchett", "comment_id": 218917468, "datetime": 1463096947000, "masked_author": "username_1", "text": "You and I must be drinking from the same well. I've been thinking about this recently too. Would be nice to brainstorm current/future needs for both softwares, maybe nail down a common set of conventions?", "title": null, "type": "comment" }, { "action": "created", "author": "bemcdonnell", "comment_id": 219045505, "datetime": 1463146773000, "masked_author": "username_0", "text": "@username_1 Good timing! \r\n\r\nSo the main SWMM InputAPI use case I foresee is for calibration - mostly oriented toward planning. However, there has been talk up here regarding parameter manipulation during simulation time (@username_2 has some thoughts on this).", "title": null, "type": "comment" }, { "action": "created", "author": "samhatchett", "comment_id": 219259613, "datetime": 1463273143000, "masked_author": "username_1", "text": "the ultimate goal on the EPANET side is to have its code split up into three different modules:\r\n- simulation\r\n- project definition I/O\r\n- simulated values I/O\r\nof course there's a fair amount of work to do. I'm working on scraping together some thoughts related to structuring of the API for creating/altering network topology - I'd be interested in your thoughts once I have a draft.", "title": null, "type": "comment" }, { "action": "created", "author": "rkertesz", "comment_id": 219548936, "datetime": 1463432994000, "masked_author": "username_2", "text": "I'll let @username_3 chime in but, while we currently can manipulate anything that is controlled in the control section (like orifices), what would be nice is intra-simulation manipulation of things that aren't exposed right now, such as a property for a pipe. This can help not only with calibration and tuning as well as controlling for variables like sediment during a long-term simulation.", "title": null, "type": "comment" }, { "action": "created", "author": "samhatchett", "comment_id": 222815627, "datetime": 1464727711000, "masked_author": "username_1", "text": "sure, what I mean is pretty simple. for maintainability and extensibility, we need to start pulling the code apart into logical units. the core of that outcome is going to be a streamlined hydraulic engine and associated structs (what i referred to as the \"project definition\"). you could also call it the \"business logic / data model\" unit. we will need to provide an API into that data model, which will be capable of programmatically constructing/ altering a hydraulic model and its associated parameters. Everything that is now done through the specification in the `inp` file format should eventually be handled by the Project API, and we can remove the dependence on the text file. It should not matter where or how the network is defined - text, json, sql, binary, protobuf... Similarly for storage/retrieval of simulation output data - there's really no reason a hydraulic analysis engine needs to ever use `fopen` - this is just a basic level of the separation of concerns.", "title": null, "type": "comment" }, { "action": "created", "author": "lmontest", "comment_id": 222844926, "datetime": 1464735058000, "masked_author": "username_3", "text": "As it relates to the work we engage regularly, we find the need to be able to manipulate an asset based on the status of the system. Ideally designing RTC algorithms that can “measure” the state of the system (flows, depths, capacities, even water quality) and adjust setpoints for pumps, orifices, weirs, etc. This means that the control rules must be able to interact during simulation time with the model. The ideal situation would allow an external program to receive hydraulic status of select assets periodically and adjust setpoints at such points in time. To that end, and in our own effort to enable such applications, we have modified SWMM to allow simulations to halt periodically, populate an output database table with hydraulic states, allow time for a program to consume such data to generate appropriate setpoints, put them in an input database table, let SWMM to consume the new setpoints, and resume the simulation. The choice of using a database for the interaction with SWMM was driven by the ease of modifying the code and enable a variety of programs to interact with the data through ODBC connectors. We have demonstrated this by building a controller in Matlab. An even nicer application would be to interface SWMM directly with a PLC. I think that porting similar functionality with a DLL API should be straightforward. The main idea remains to break SWMM out of being a modeling tool and make it available to applications such a operators training modules, real time scenario analysis, and real time control applications. Cheers!", "title": null, "type": "comment" }, { "action": "created", "author": "bemcdonnell", "comment_id": 243933749, "datetime": 1472686286000, "masked_author": "username_0", "text": "My ideas and contributions for the InputAPI live here for now:\r\n\r\nhttps://github.com/username_0/Stormwater-Management-Model/tree/InputAPI", "title": null, "type": "comment" }, { "action": "created", "author": "lrntct", "comment_id": 348803332, "datetime": 1512325594000, "masked_author": "username_4", "text": "The link is dead. Is there a page or wiki where are compiled the ideas and status?", "title": null, "type": "comment" }, { "action": "created", "author": "samhatchett", "comment_id": 348804392, "datetime": 1512326528000, "masked_author": "username_1", "text": "Private repo?", "title": null, "type": "comment" }, { "action": "created", "author": "bemcdonnell", "comment_id": 348808888, "datetime": 1512330486000, "masked_author": "username_0", "text": "@username_4, i must have removed that at some point. But truth be told; I doubt any of the ideas I had then were worthwhile :-)\r\n\r\nHere’s some stuff on the api. https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/wiki/Enhanced-API\r\n\r\nI think we should have a roadmapping meeting to talk about the future of the data model and API", "title": null, "type": "comment" }, { "action": "created", "author": "lrntct", "comment_id": 363963768, "datetime": 1518050743000, "masked_author": "username_4", "text": "One great addition would be to be able to add or remove objects from the simulation.\r\nAs of now, the objects are stored in arrays of structs. My basic C knowledge tells me that resizing an array is not a very efficient operation, so it might not be ideal to add objects one by one.\r\nOne possibility would be to change the data structure and maybe use one from C++ (std::vector?), but it will be an important change.\r\nAny thought on what could be possible in pure C?", "title": null, "type": "comment" }, { "action": "created", "author": "bemcdonnell", "comment_id": 364196250, "datetime": 1518112818000, "masked_author": "username_0", "text": "I also agree that this would be an important change. \r\n\r\nThe catch to this whole thing is going to be managing the connections. Links current index the upstream and downstream node indexes. So we are going to need to come up with a strategy to make sure as things change, the indeces still work out.\r\n\r\n@michaeltryby has been recommending the project incorporate a transactional data model. He can better explain his ideas", "title": null, "type": "comment" }, { "action": "created", "author": "samhatchett", "comment_id": 364204106, "datetime": 1518114385000, "masked_author": "username_1", "text": "we've done some similar work on EPANET -> https://github.com/OpenWaterAnalytics/EPANET/issues/43 and https://github.com/OpenWaterAnalytics/EPANET/pull/88 \r\n\r\nIn basic form, we do use a realloc - which may end up being inefficient, but the primary purpose of the addition was to expand what was possible to do with the toolkit. And once we build and profile that capability, we can then optimize. And since it was done outside the \"customary\" procedure of opening an `inp` file, it doesn't affect established use-cases performance-wise.\r\n\r\nA transactional model may make plenty of sense, but smells more like an extension than something to build into the engine API.", "title": null, "type": "comment" } ]
5
15
6,320
false
false
6,320
true
prometheus/client_python
prometheus
176,356,329
99
null
[ { "action": "opened", "author": "yosefy", "comment_id": null, "datetime": 1473680960000, "masked_author": "username_0", "text": "g.labels says: \r\nobject has no attribute 'labels'\r\n thanks", "title": "how to add labels with pushgateway example?", "type": "issue" }, { "action": "created", "author": "gbbirkisson", "comment_id": 247615263, "datetime": 1474036202000, "masked_author": "username_1", "text": "Same problem with Counter", "title": null, "type": "comment" }, { "action": "created", "author": "gbbirkisson", "comment_id": 247621611, "datetime": 1474037639000, "masked_author": "username_1", "text": "Ok, the documentation needs updating. I got labels working like this:\r\n\r\nfrom prometheus_client import Counter\r\nc = Counter('my_requests_total', 'HTTP Failures', labelnames=('method', 'endpoint'))\r\nc.labels('get', '/').inc()", "title": null, "type": "comment" }, { "action": "created", "author": "yosefy", "comment_id": 248276912, "datetime": 1474371533000, "masked_author": "username_0", "text": "yes but how do we set the value of the metrics then?\r\nwithout adding labels dir(g) gives\r\n['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_reserved_labelnames', '_samples', '_type', '_value', 'collect', 'dec', 'inc', 'set', 'set_function', 'set_to_current_time', 'time', 'track_inprogress']\r\n\r\nbut after adding labelnames it becomes\r\n['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_kwargs', '_labelnames', '_lock', '_metrics', '_name', '_samples', '_type', '_wrappedClass', 'collect', 'labels', 'remove']\r\n\r\nand doesnt have set method anymore", "title": null, "type": "comment" }, { "action": "created", "author": "brian-brazil", "comment_id": 287460160, "datetime": 1489781791000, "masked_author": "username_2", "text": "Usage questions are best asked on https://groups.google.com/forum/#!aboutgroup/prometheus-users", "title": null, "type": "comment" }, { "action": "closed", "author": "brian-brazil", "comment_id": null, "datetime": 1489781791000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
6
1,358
false
false
1,358
false
ubergeek42/weechat-android
null
48,555,569
164
null
[ { "action": "opened", "author": "ghost", "comment_id": null, "datetime": 1415822545000, "masked_author": "username_0", "text": "In landscape mode the buffer list on the left takes quite a lot of screen space. It would be nice if there was an option to toggle it (hide/show).", "title": "Feature request: Option to hide the buffer list in landscape mode", "type": "issue" }, { "action": "closed", "author": "oakkitten", "comment_id": null, "datetime": 1596643628000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "oakkitten", "comment_id": 669283741, "datetime": 1596643628000, "masked_author": "username_1", "text": "we are closing some of the issues that weren't active in a while or may be irrelevant for the latest version (1.0). if you think that this issue is still applicable, please leave a comment.", "title": null, "type": "comment" } ]
2
3
335
false
false
335
false
bitshares/bitshares-ui
bitshares
279,150,396
790
{ "number": 790, "repo": "bitshares-ui", "user_login": "bitshares" }
[ { "action": "opened", "author": "startailcoon", "comment_id": null, "datetime": 1512421775000, "masked_author": "username_0", "text": "Fixes Issue #781 \r\n- Dashboard can remove contact\r\n- Explorer/Accounts can add and remove accounts on search", "title": "Fix Issue #781 - Add/Remove Contacts", "type": "issue" }, { "action": "created", "author": "svk31", "comment_id": 349227759, "datetime": 1512461447000, "masked_author": "username_1", "text": "Nice work, although setting `linkedAccounts` in the AccountRow state is an anti-pattern, I'll change it so it uses the flux pattern of being passed to the components through props using the connect HOC.", "title": null, "type": "comment" } ]
2
2
310
false
false
310
false
Azure/app-service-announcements
Azure
251,109,792
30
null
[ { "action": "opened", "author": "cgillum", "comment_id": null, "datetime": 1503016746000, "masked_author": "username_0", "text": "This release includes a variety of changes and fixes, including some minor breaking changes. Most importantly, the Visual Studio setup experience has been significantly improved due in part to several changes included in the final release of [Visual Studio 2017 (15.3)](https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes).\r\n\r\nThe VS sample project has also been updated to highlight these major changes:\r\n\r\n* Durable Functions can be added to any Azure Functions project via [a simple NuGet package reference](https://azure.github.io/azure-functions-durable-extension/articles/installation.html).\r\n* Activity functions can now [bind to any JSON-serializeable data type](https://azure.github.io/azure-functions-durable-extension/articles/topics/bindings.html#trigger-sample-1), including primitive types.\r\n\r\nSecurity has also been improved by taking advantage of the new [System Keys feature of Azure Functions](https://github.com/Azure/azure-webjobs-sdk-script/pull/1659).\r\n\r\nMore technical details can be found in the following PR:\r\n[Updates for 0.2.2-alpha: Activity binding, System Keys, & improved Visual Studio support](https://github.com/Azure/azure-functions-durable-extension/pull/18)\r\n\r\nFor an overview and detailed documentation of Durable Functions, see our GitHub Docs page: https://azure.github.io/azure-functions-durable-extension/", "title": "New Release of Durable Functions: 0.2.2-alpha", "type": "issue" }, { "action": "created", "author": "davidebbo", "comment_id": 323237870, "datetime": 1503020714000, "masked_author": "username_1", "text": "Please use https://github.com/Azure/azure-functions-durable-extension/issues is you have any questions/issues about this announcement or durable functions in general. Thanks!", "title": null, "type": "comment" }, { "action": "closed", "author": "davidebbo", "comment_id": null, "datetime": 1506454079000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
1,537
false
false
1,537
false
tianzhuo112/VTMagic
null
250,211,368
79
null
[ { "action": "opened", "author": "hrscy", "comment_id": null, "datetime": 1502767070000, "masked_author": "username_0", "text": "![image](https://user-images.githubusercontent.com/16634163/29300822-83c21044-81aa-11e7-8f07-589129bc59f4.png)\r\n然后我返回到上一控制器,我的订单控制器确认销毁。\r\n然后我进入了一个扫面条码的控制器,和我的订单控制器没有任何联系,之后我返回,再次进入我的订单控制器,显示情况如下图:\r\n![image](https://user-images.githubusercontent.com/16634163/29300915-3c1eb23c-81ab-11e7-90c5-596d2dbc7a71.png)\r\n订单界面使用的 tableView,请问为什么会出现这种问题?", "title": "headerView 无故下移64", "type": "issue" }, { "action": "closed", "author": "hrscy", "comment_id": null, "datetime": 1505785288000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
341
false
false
341
false
rust-lang/rust
rust-lang
253,198,123
44,118
null
[ { "action": "opened", "author": "carols10cents", "comment_id": null, "datetime": 1503877086000, "masked_author": "username_0", "text": "Moving here from https://github.com/rust-lang/cargo/issues/4406 on @username_5's behalf:\r\n\r\nWhile documenting every public function of [ThreadPool](https://github.com/rust-threadpool/rust-threadpool) I had to implement `#[derive(Clone)` manually so I would be able to add an example.\r\n\r\nI assume `cargo doc` has a default template for the derive-able traits.\r\nSo I propose something like this:\r\n```rust\r\n#[derive(Clone)\r\n/// My custom doc\r\n/// ```\r\n/// let my = custom.example();\r\n/// ```\r\n#[derive(PartialEq, Eq)\r\n/// My custom doc for both traits\r\n/// ```\r\n/// let my = custom.example();\r\n/// ```\r\nstruct CustomStruct;\r\n```\r\n\r\nThe template would have to include something like \"yield\" within the code it is generating.\r\nIn this case it should generate something equal to:\r\n```rust\r\nimpl Clone for CustomStruct {\r\n /// My custom doc\r\n /// ```\r\n /// let my = custom.example();\r\n /// ```\r\n fn clone(&self) -> Self { CustomStruct }\r\n}\r\n/* similar for the other two traits */\r\nstruct CustomStruct;\r\n```\r\n\r\nWhat do you think?", "title": "Document traits from #[derive(...)]", "type": "issue" }, { "action": "created", "author": "sfackler", "comment_id": 325241247, "datetime": 1503884735000, "masked_author": "username_1", "text": "I think this'd make more sense if Rustdoc rendered impl-level documentation - There are two methods in `PartialEq`, and none in `Eq`, so it's not totally clear where the docs would go. Even Clone has `clone` and `clone_from`.", "title": null, "type": "comment" }, { "action": "created", "author": "durka", "comment_id": 325250578, "datetime": 1503890145000, "masked_author": "username_2", "text": "Nit: `///` doc comments are normally before the item they document.\r\n\r\nFurthermore, I think this would need a slightly more complex syntax. Currently,\r\n\r\n```rust\r\n/// doc 1\r\n#[attr]\r\n/// doc 2\r\nitem {}\r\n```\r\n\r\nis the same as\r\n\r\n```rust\r\n/// doc 1\r\n/// doc 2\r\n#[attr]\r\nitem {}\r\n```\r\n\r\n(this is because `/// doc` just means `#[doc=\"doc\"]`) so suddenly assigning extra meaning to the order of attributes seems weird IMO.\r\n\r\nSomething like `#[derive(Clone(doc=\"...\"))]` or `#[derive(Clone)] #[clone(doc=\"...\")]` could work, though then you have to stuff everything into a single string, which is annoying.", "title": null, "type": "comment" }, { "action": "created", "author": "steveklabnik", "comment_id": 325270004, "datetime": 1503901409000, "masked_author": "username_3", "text": "I am thinking a change of this magnitude requires an RFC, though I'm not sure.", "title": null, "type": "comment" }, { "action": "created", "author": "ollie27", "comment_id": 325397122, "datetime": 1503936285000, "masked_author": "username_4", "text": "rust-lang/rfcs#1382 could cover this.", "title": null, "type": "comment" }, { "action": "created", "author": "dns2utf8", "comment_id": 328904093, "datetime": 1505232988000, "masked_author": "username_5", "text": "One point that is important to me is, the docs should stay in the same file and near the `#[derive(X)]´", "title": null, "type": "comment" } ]
6
6
2,078
false
false
2,078
true
LeoNatan/LNPopupController
null
257,223,128
183
null
[ { "action": "opened", "author": "LeoNatan", "comment_id": null, "datetime": 1505262505000, "masked_author": "username_0", "text": "Related to #179.", "title": "iPhone X is not supported", "type": "issue" }, { "action": "created", "author": "LeoNatan", "comment_id": 329985817, "datetime": 1505585706000, "masked_author": "username_0", "text": "I think I finally stabilized the support for iPhone X as well as iOS 11 in general. The new safe area API required some tinkering, but I think I finally got it working.\r\n\r\nOne change that I had to make is how `hidesBottomBarWhenPushed` is handled. Until now, the popup bar would transition out of view together with the system bar. However, this has many complications and thus, the transition will behave differently from now on—the popup bar will animate to the bottom of the safe area of the controller. Now that I’ve tried this, it actually looks better to me, so I don’t even see it as a compromise.\r\n\r\nComing soon.", "title": null, "type": "comment" }, { "action": "created", "author": "yetdog", "comment_id": 330041847, "datetime": 1505652871000, "masked_author": "username_1", "text": "Thank you for your prompt work on this, Leo! \r\n\r\nMaybe anecdotal and not all that consequential, but I've had a bit of a different experience with iOS 11. I found that the view no longer \"corrected\" as I stated in #179 after interacting with an element in the view (button, table item etc). Instead, in iOS 11 the view simply stayed tucked up behind the status bar. Given the predictability of this, I adjusted the elements in my view to sit lower, so they do not overlap with the status bar/X notch. I also found the popup bar to be acceptable. I'll share screenshots below just for your information - thanks for fixing this! When you release the commit I'll check the differences between it and what I have now and test swapping them in to see which works better for my implementation.\r\n![ios11-1](https://user-images.githubusercontent.com/6452866/30520994-aa7cb5dc-9b6c-11e7-85d0-8698686f2ea7.png)\r\n![ios11-2](https://user-images.githubusercontent.com/6452866/30520995-aa7e81be-9b6c-11e7-85e7-f6f747bd6ee1.png)", "title": null, "type": "comment" }, { "action": "created", "author": "LeoNatan", "comment_id": 330054358, "datetime": 1505659886000, "masked_author": "username_0", "text": "There were many issues with the X and the framework. Most of that has been ironed out. Insets, margins and layout guides should now also work correctly between iOS 10 and iOS 11 (I have not tested iOS 9).", "title": null, "type": "comment" }, { "action": "created", "author": "LeoNatan", "comment_id": 330054466, "datetime": 1505659963000, "masked_author": "username_0", "text": "For best results, you will need to either use the safe area guides or top + bottom layout guides, just like how Apple recommends.", "title": null, "type": "comment" }, { "action": "closed", "author": "LeoNatan", "comment_id": null, "datetime": 1505681829000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "LeoNatan", "comment_id": 330086247, "datetime": 1505682013000, "masked_author": "username_0", "text": "Implemented. Please report any issues you may have. I have a feeling that the real issues will start pouring in when iPhone X devices are released. 😥 So I hope for a month of quiet… 😆", "title": null, "type": "comment" } ]
2
7
2,166
false
false
2,166
false
tensorflow/tensorflow
tensorflow
127,167,468
799
null
[ { "action": "opened", "author": "indiejoseph", "comment_id": null, "datetime": 1453101237000, "masked_author": "username_0", "text": "I want to build a bi-rnn model with tensorflow with LSTM cell, when i try to initialize bidirectional_rnn,\r\nit gives: `ValueError: Over-sharing: Variable BiRNN_FW/RNN/BasicLSTMCell/Linear/Matrix already exists, disallowed. Did you mean to set reuse=True in VarScope?`\r\n\r\n```\r\nimport tensorflow as tf\r\nfrom tensorflow.models.rnn import rnn, rnn_cell\r\nfrom tensorflow.python.ops.constant_op import constant\r\nimport numpy as np\r\n\r\nclass Model(object):\r\n def __init__(self, batch_size, len_word, num_chars, dim_embed, dim_hidden):\r\n self.batch_size = batch_size\r\n self.dim_embed = dim_embed\r\n self.dim_hidden = dim_hidden\r\n self.num_chars = num_chars\r\n self.len_word = len_word\r\n \r\n with tf.device(\"/cpu:0\"):\r\n self.embedding = tf.Variable(tf.random_uniform([num_chars, dim_embed], -0.1, 0.1), name='embedding')\r\n \r\n self.W_emb = tf.Variable(tf.random_uniform([dim_hidden*2, dim_embed], -0.1, 0.1), name='W_emb')\r\n self.b_emb = tf.Variable(tf.zeros([dim_embed]), name='b_emb')\r\n self.lstm_fw_cell = rnn_cell.BasicLSTMCell(dim_hidden)\r\n self.lstm_bw_cell = rnn_cell.BasicLSTMCell(dim_hidden)\r\n \r\n def build_model(self):\r\n inputs = tf.placeholder(tf.int32, [self.batch_size, self.len_word])\r\n input_length = tf.placeholder(tf.int64, [self.batch_size])\r\n lstm_state_fw = self.lstm_fw_cell.zero_state(self.batch_size, tf.float32)\r\n lstm_state_bw = self.lstm_bw_cell.zero_state(self.batch_size, tf.float32)\r\n\r\n with tf.device(\"/cpu:0\"):\r\n embedded_input = tf.nn.embedding_lookup(self.embedding, tf.transpose(inputs))\r\n\r\n brnn_output = rnn.bidirectional_rnn(\r\n self.lstm_fw_cell, self.lstm_bw_cell,\r\n tf.unpack(embedded_input),\r\n sequence_length=input_length,\r\n initial_state_fw=lstm_state_fw,\r\n initial_state_bw=lstm_state_bw,\r\n )\r\n\r\n pooled_output = tf.reduce_sum( tf.pack(brnn_output), 0 )\r\n pooled_output = pooled_output / tf.expand_dims( tf.to_float(input_length) + 1e-6, 1)\r\n final_emb = tf.nn.xw_plus_b(pooled_output, self.W_emb, self.b_emb)\r\n final_emb = tf.nn.l2_normalize(final_emb, dim=1, epsilon=1e-7)\r\n \r\n return final_emb\r\n```", "title": "Got error when initialize bidirectional rnn with LSTM cell ", "type": "issue" }, { "action": "created", "author": "salomons", "comment_id": 172797098, "datetime": 1453197255000, "masked_author": "username_1", "text": "You need to specify different varible scopes for the lstm cells. \r\n```\r\nwith tf.variable_scope('forward'):\r\n self.lstm_fw_cell = rnn_cell.BasicLSTMCell(dim_hidden) \r\nwith tf.variable_scope('backward'):\r\n self.lstm_bw_cell = rnn_cell.BasicLSTMCell(dim_hidden)\r\n```\r\nOtherwise there will be a name collision and tf will interpret this as if your intention is to share the parameters in the two cells. It will throw an exception because you haven't explicitly told it to reuse variables in the scope: `with variable_scope(name, reuse=True)`. Read the [Sharing Variables](https://www.tensorflow.org/versions/0.6.0/how_tos/variable_scope/index.html#sharing-variables) how-to guide for more information.", "title": null, "type": "comment" }, { "action": "closed", "author": "indiejoseph", "comment_id": null, "datetime": 1453223759000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "albertz", "comment_id": 269455500, "datetime": 1482919581000, "masked_author": "username_2", "text": "Note that this will not happen anymore because the variables are created inside `...Cell.__call__` and not in `...Cell.__init__`, thus it does not need a scope for the construction of the cells, and it will handle the variable scope itself inside `bidirectional_rnn` thus you don't need to scope it yourself.", "title": null, "type": "comment" }, { "action": "created", "author": "aparecidovieira", "comment_id": 300490297, "datetime": 1494424719000, "masked_author": "username_3", "text": "Im still having the same issue. Any sugestions? I have tried the approch proposed by username_1, same results. Doenst return any tuple as a result.\r\n((encoder_fw_outputs,\r\n encoder_bw_outputs),\r\n (encoder_fw_final_state,\r\n encoder_bw_final_state)) = (\r\n tf.nn.bidirectional_dynamic_rnn(cell_fw=encoder_cell,\r\n cell_bw=encoder_cell,\r\n inputs=encoder_inputs_embedded,\r\n sequence_length=encoder_inputs_length,\r\n dtype=tf.float64, time_major=True)\r\n )\r\n\r\nValueError Traceback (most recent call last)\r\n<ipython-input-141-f7ed36f14c22> in <module>()\r\n 20 inputs=encoder_inputs_embedded,\r\n 21 sequence_length=encoder_inputs_length,\r\n---> 22 dtype=tf.float32, time_major=True)\r\n 23 )\r\n 24 \r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in bidirectional_dynamic_rnn(cell_fw, cell_bw, inputs, sequence_length, initial_state_fw, initial_state_bw, dtype, parallel_iterations, swap_memory, time_major, scope)\r\n 348 initial_state=initial_state_fw, dtype=dtype,\r\n 349 parallel_iterations=parallel_iterations, swap_memory=swap_memory,\r\n--> 350 time_major=time_major, scope=fw_scope)\r\n 351 \r\n 352 # Backward direction\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in dynamic_rnn(cell, inputs, sequence_length, initial_state, dtype, parallel_iterations, swap_memory, time_major, scope)\r\n 544 swap_memory=swap_memory,\r\n 545 sequence_length=sequence_length,\r\n--> 546 dtype=dtype)\r\n 547 \r\n 548 # Outputs of _dynamic_rnn_loop are always shaped [time, batch, depth].\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in _dynamic_rnn_loop(cell, inputs, initial_state, parallel_iterations, swap_memory, sequence_length, dtype)\r\n 711 loop_vars=(time, output_ta, state),\r\n 712 parallel_iterations=parallel_iterations,\r\n--> 713 swap_memory=swap_memory)\r\n 714 \r\n 715 # Unpack final output if not using output tuples.\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.pyc in while_loop(cond, body, loop_vars, shape_invariants, parallel_iterations, back_prop, swap_memory, name)\r\n 2603 context = WhileContext(parallel_iterations, back_prop, swap_memory, name)\r\n 2604 ops.add_to_collection(ops.GraphKeys.WHILE_CONTEXT, context)\r\n-> 2605 result = context.BuildLoop(cond, body, loop_vars, shape_invariants)\r\n 2606 return result\r\n 2607 \r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.pyc in BuildLoop(self, pred, body, loop_vars, shape_invariants)\r\n 2436 self.Enter()\r\n 2437 original_body_result, exit_vars = self._BuildLoop(\r\n-> 2438 pred, body, original_loop_vars, loop_vars, shape_invariants)\r\n 2439 finally:\r\n 2440 self.Exit()\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.pyc in _BuildLoop(self, pred, body, original_loop_vars, loop_vars, shape_invariants)\r\n 2386 structure=original_loop_vars,\r\n 2387 flat_sequence=vars_for_body_with_tensor_arrays)\r\n-> 2388 body_result = body(*packed_vars_for_body)\r\n 2389 if not nest.is_sequence(body_result):\r\n 2390 body_result = [body_result]\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in _time_step(time, output_ta_t, state)\r\n 694 call_cell=call_cell,\r\n 695 state_size=state_size,\r\n--> 696 skip_conditionals=True)\r\n 697 else:\r\n 698 (output, new_state) = call_cell()\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in _rnn_step(time, sequence_length, min_sequence_length, max_sequence_length, zero_output, state, call_cell, state_size, skip_conditionals)\r\n 175 # steps. This is faster when max_seq_len is equal to the number of unrolls\r\n 176 # (which is typical for dynamic_rnn).\r\n--> 177 new_output, new_state = call_cell()\r\n 178 nest.assert_same_structure(state, new_state)\r\n 179 new_state = nest.flatten(new_state)\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/rnn.pyc in <lambda>()\r\n 682 \r\n 683 input_t = nest.pack_sequence_as(structure=inputs, flat_sequence=input_t)\r\n--> 684 call_cell = lambda: cell(input_t, state)\r\n 685 \r\n 686 if sequence_length is not None:\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/contrib/rnn/python/ops/core_rnn_cell_impl.pyc in __call__(self, inputs, state, scope)\r\n 336 # i = input_gate, j = new_input, f = forget_gate, o = output_gate\r\n 337 lstm_matrix = _linear([inputs, m_prev], 4 * self._num_units, bias=True,\r\n--> 338 scope=scope)\r\n 339 i, j, f, o = array_ops.split(\r\n 340 value=lstm_matrix, num_or_size_splits=4, axis=1)\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/contrib/rnn/python/ops/core_rnn_cell_impl.pyc in _linear(args, output_size, bias, bias_start, scope)\r\n 745 with vs.variable_scope(scope) as outer_scope:\r\n 746 weights = vs.get_variable(\r\n--> 747 \"weights\", [total_arg_size, output_size], dtype=dtype)\r\n 748 if len(args) == 1:\r\n 749 res = math_ops.matmul(args[0], weights)\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/variable_scope.pyc in get_variable(name, shape, dtype, initializer, regularizer, trainable, collections, caching_device, partitioner, validate_shape, custom_getter)\r\n 986 collections=collections, caching_device=caching_device,\r\n 987 partitioner=partitioner, validate_shape=validate_shape,\r\n--> 988 custom_getter=custom_getter)\r\n 989 get_variable_or_local_docstring = (\r\n 990 \"\"\"%s\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/variable_scope.pyc in get_variable(self, var_store, name, shape, dtype, initializer, regularizer, trainable, collections, caching_device, partitioner, validate_shape, custom_getter)\r\n 888 collections=collections, caching_device=caching_device,\r\n 889 partitioner=partitioner, validate_shape=validate_shape,\r\n--> 890 custom_getter=custom_getter)\r\n 891 \r\n 892 def _get_partitioned_variable(self,\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/variable_scope.pyc in get_variable(self, name, shape, dtype, initializer, regularizer, reuse, trainable, collections, caching_device, partitioner, validate_shape, custom_getter)\r\n 346 reuse=reuse, trainable=trainable, collections=collections,\r\n 347 caching_device=caching_device, partitioner=partitioner,\r\n--> 348 validate_shape=validate_shape)\r\n 349 \r\n 350 def _get_partitioned_variable(\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/variable_scope.pyc in _true_getter(name, shape, dtype, initializer, regularizer, reuse, trainable, collections, caching_device, partitioner, validate_shape)\r\n 331 initializer=initializer, regularizer=regularizer, reuse=reuse,\r\n 332 trainable=trainable, collections=collections,\r\n--> 333 caching_device=caching_device, validate_shape=validate_shape)\r\n 334 \r\n 335 if custom_getter is not None:\r\n\r\n/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/variable_scope.pyc in _get_single_variable(self, name, shape, dtype, initializer, regularizer, partition_info, reuse, trainable, collections, caching_device, validate_shape)\r\n 637 \" Did you mean to set reuse=True in VarScope? \"\r\n 638 \"Originally defined at:\\n\\n%s\" % (\r\n--> 639 name, \"\".join(traceback.format_list(tb))))\r\n 640 found_var = self._vars[name]\r\n 641 if not shape.is_compatible_with(found_var.get_shape()):\r\n\r\nValueError: Variable bidirectional_rnn/fw/lstm_cell/weights already exists, disallowed. Did you mean to set reuse=True in VarScope? Originally defined at:\r\n\r\n File \"/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/contrib/rnn/python/ops/core_rnn_cell_impl.py\", line 747, in _linear\r\n \"weights\", [total_arg_size, output_size], dtype=dtype)\r\n File \"/home/cesar/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/contrib/rnn/python/ops/core_rnn_cell_impl.py\", line 338, in __call__\r\n scope=scope)\r\n File \"<ipython-input-23-f4f28501e56f>\", line 24, in <module>\r\n time_major=True", "title": null, "type": "comment" } ]
4
5
12,456
false
false
12,456
true
code-dot-org/code-dot-org
code-dot-org
244,529,931
16,530
{ "number": 16530, "repo": "code-dot-org", "user_login": "code-dot-org" }
[ { "action": "opened", "author": "islemaster", "comment_id": null, "datetime": 1500595544000, "masked_author": "username_0", "text": "New `fixedWidth` and `fixedHeight` props that control the size of `BaseDialog` when using updated styles.\r\n\r\nExtracted from https://github.com/code-dot-org/code-dot-org/pull/16401.\r\n\r\nThese props only work when `useUpdatedStyles` is true.\r\n- `fixedWidth` will default to 700, the former default value.\r\n- `fixedHeight` defaults to undefined, allowing the dialog to expand vertically with its content. I've passed the previous hard-coded value of 480 in for all existing consumers.", "title": "Control BaseDialog width and height", "type": "issue" }, { "action": "created", "author": "islemaster", "comment_id": 316864615, "datetime": 1500595596000, "masked_author": "username_0", "text": "This poor class needs some more love, but wanted to get this up and running quick to minimize diff on our other PR and make available for Eric's current work.", "title": null, "type": "comment" } ]
1
2
639
false
false
639
false
colorbox/bento
null
217,287,074
86
{ "number": 86, "repo": "bento", "user_login": "colorbox" }
[ { "action": "opened", "author": "yucao24hours", "comment_id": null, "datetime": 1490629068000, "masked_author": "username_0", "text": "## やったこと\r\n\r\n現在の rubocop の設定どおりにコードを書き換えました。\r\n\r\n`rubocop` コマンドでチェックを実行して、出てきた違反を単純に機械的に消していった(違反しないようなコードに変えた)だけなので、このうえで「この書き方はやっぱりやだからこうしよう」という話をみんなでできたらいいかなと思います。\r\nコミットは違反の種類ごとに行っているので多少修正しやすくなっているはず...(コードの書き方を変えたいときには revert すればいいだけになるので)。\r\n\r\nアプリケーションの動作に直接大きな影響があるわけではない変更ばかりなので、マージするのは急ぎません。", "title": "rubocop の違反指摘が出ないようにコードを変えた", "type": "issue" }, { "action": "created", "author": "colorbox", "comment_id": 289757226, "datetime": 1490704969000, "masked_author": "username_1", "text": "[![LGTM](https://lgtm.in/p/CNdslqopq)](https://lgtm.in/i/CNdslqopq)", "title": null, "type": "comment" }, { "action": "created", "author": "colorbox", "comment_id": 289757259, "datetime": 1490704978000, "masked_author": "username_1", "text": "rebase plz 🙏", "title": null, "type": "comment" }, { "action": "created", "author": "yucao24hours", "comment_id": 289760346, "datetime": 1490705699000, "masked_author": "username_0", "text": "いちおう、ここまでで書き方についてのコンセンサスをとっておきたいという想いがあるので、 @username_2 も @username_1 も、おふたりからの 🆗 🆖 コメントもらいたいです!", "title": null, "type": "comment" }, { "action": "created", "author": "yucao24hours", "comment_id": 289760719, "datetime": 1490705786000, "masked_author": "username_0", "text": "@username_1 あと、これをマージしたら、(開発もおさまってきましたし)CI を有効にしてもらいたいです。", "title": null, "type": "comment" }, { "action": "created", "author": "colorbox", "comment_id": 289761660, "datetime": 1490706017000, "masked_author": "username_1", "text": "`rubocop`のデフォルールは賛否あるかとも思いますが、現状は問題ないっす!\r\n何か悩むところあればまた相談します。", "title": null, "type": "comment" }, { "action": "created", "author": "tkm-kj", "comment_id": 289764039, "datetime": 1490706563000, "masked_author": "username_2", "text": "rubocop落ちてたので直しました 😄 \r\nLGTMです!", "title": null, "type": "comment" }, { "action": "created", "author": "colorbox", "comment_id": 289803534, "datetime": 1490714158000, "masked_author": "username_1", "text": "TravisCIをOnにしました", "title": null, "type": "comment" } ]
3
8
628
false
false
628
true
bokeh/bokeh
bokeh
237,720,345
6,521
null
[ { "action": "opened", "author": "bryevdv", "comment_id": null, "datetime": 1498101024000, "masked_author": "username_0", "text": "The `ToolEvent` calss does not work well at all. It should be replaced with new style events from `bokeh.events` that tools can generate when appropriate. \r\n\r\nAdding this to `0.12.7` because we should try to mark all planned deprecations by `0.12.7` if possible. \r\n\r\nping @jlstevens", "title": "Deprecate ToolEvents", "type": "issue" }, { "action": "created", "author": "canavandl", "comment_id": 312316470, "datetime": 1498840960000, "masked_author": "username_1", "text": "Does it need to be replaced with an BokehEvent or just removed? ToolEvents don't seem to do any eventing, but appears to just store a list of tool geometries for SelectTool and TapTool (so we've inconsistently used it anyway)\r\n\r\nI'm not aware how commonly it's used, so perhaps we could just remove it?", "title": null, "type": "comment" }, { "action": "created", "author": "bryevdv", "comment_id": 312318858, "datetime": 1498841602000, "masked_author": "username_0", "text": "It has be *extremely* rarely publicized. I would suggest a compromise: effectively remove it entirely (i.e. don't try to \"make it work\" with new events) but make it have an `__init__` that prints a detailed and informative message about how to adapt existing usage to new events.", "title": null, "type": "comment" }, { "action": "created", "author": "bryevdv", "comment_id": 312375234, "datetime": 1498857548000, "masked_author": "username_0", "text": "It would be nice (and I don't think too hard) to add a \"Selection\" event at the same time, that all the select tools could simply report a selection geometry with. Without that, there is not quite parity.", "title": null, "type": "comment" }, { "action": "closed", "author": "bryevdv", "comment_id": null, "datetime": 1500318637000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
5
1,067
false
false
1,067
false
fgnass/node-dev
null
162,315,490
139
null
[ { "action": "opened", "author": "jonathanong", "comment_id": null, "datetime": 1466923998000, "masked_author": "username_0", "text": "would be nice if there were an API. i'd like to embed a server within a server and have the sub app automatically restart itself", "title": "API", "type": "issue" }, { "action": "created", "author": "fgnass", "comment_id": 229281165, "datetime": 1467186269000, "masked_author": "username_1", "text": "It's undocumented, but you can already do the following: \r\n\r\n```js\r\nconst nodeDev = require('node-dev');\r\nnodeDev(script, scriptArgs, nodeArgs, opts);\r\n```\r\n\r\nWould this work for you?", "title": null, "type": "comment" }, { "action": "created", "author": "jonathanong", "comment_id": 229282913, "datetime": 1467186763000, "masked_author": "username_0", "text": "yep, i just don't know what those arguments are :P", "title": null, "type": "comment" }, { "action": "created", "author": "fgnass", "comment_id": 229289635, "datetime": 1467188638000, "masked_author": "username_1", "text": "```js\r\nnodeDev(\r\n '/some/script.js', // the script to run\r\n ['--foo', '-bar'], // command line arguments to pass to the script\r\n ['--debug'], // arguments to pass to the node binary\r\n {\r\n notify: false, // whether to use desktop notifications\r\n deps: true, // whether to watch files in node_modules too\r\n allDeps: false, // whether to watch transitive deps (deps of deps) too\r\n dedupe: false, // whether to use https://github.com/thlorenz/dynamic-dedupe\r\n respawn: false, // whether to keep watching for changes after the script has exited\r\n poll: false, // whether to force polling for file changes\r\n }\r\n);\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "Sawtaytoes", "comment_id": 368391217, "datetime": 1519621518000, "masked_author": "username_2", "text": "Are those the defaults you listed?", "title": null, "type": "comment" }, { "action": "created", "author": "chhpt", "comment_id": 796713848, "datetime": 1615467126000, "masked_author": "username_3", "text": "@username_1 hi, if i use `nodeDev(script, scriptArgs, nodeArgs, opts);`, could I got some callback event when code restart?", "title": null, "type": "comment" } ]
4
6
1,170
false
false
1,170
true
learningequality/kolibri
learningequality
215,904,416
1,106
{ "number": 1106, "repo": "kolibri", "user_login": "learningequality" }
[ { "action": "opened", "author": "indirectlylit", "comment_id": null, "datetime": 1490137241000, "masked_author": "username_0", "text": "possibly a template for other plugins\r\n\r\n* move constants to top-level\r\n* rename `state` dir to `vuex`\r\n* move actions inside `vuex`", "title": "re-org files", "type": "issue" }, { "action": "created", "author": "indirectlylit", "comment_id": 288429710, "datetime": 1490195442000, "masked_author": "username_0", "text": "Updates on PR:\r\n\r\n* instead of renaming `state` to `vuex`, I went the other way and renamed `vue` to `views`. The idea here was to name them after a purpose, not a technology, which will be more meaningful to people unfamiliar with the code base\r\n* updated all other plugins to use the same conventions\r\n* also created a PRs for the external plugins:\r\n * https://github.com/fle-internal/kolibri-instant-schools-plugin/pull/34\r\n * https://github.com/learningequality/kolibri-exercise-perseus-plugin/pull/53", "title": null, "type": "comment" } ]
2
3
637
false
true
637
false
cliqz-oss/keyvi
cliqz-oss
180,853,373
131
{ "number": 131, "repo": "keyvi", "user_login": "cliqz-oss" }
[ { "action": "opened", "author": "hendrik-cliqz", "comment_id": null, "datetime": 1475575709000, "masked_author": "username_0", "text": "", "title": "add pypi variables", "type": "issue" } ]
2
2
299
false
true
0
false
SpongePowered/SpongeForge
SpongePowered
236,635,899
1,592
null
[ { "action": "opened", "author": "DarkArc", "comment_id": null, "datetime": 1497670225000, "masked_author": "username_0", "text": "**I am currently running...**\r\n```\r\n Minecraft: 1.11.2\r\n SpongeAPI: 6.1.0-SNAPSHOT-a15cc3e\r\n SpongeForge: 1.11.2-2315-6.1.0-BETA-2395\r\n Minecraft Forge: 13.20.0.2315\r\n```\r\n\r\n**Exception:**\r\n```\r\n[23:28:29] [Client thread/FATAL]: Error executing task\r\njava.util.concurrent.ExecutionException: java.lang.NullPointerException\r\n at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_131]\r\n at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_131]\r\n at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]\r\n at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1046) [bes.class:?]\r\n at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:372) [bes.class:?]\r\n at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?]\r\n at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]\r\n at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]\r\n at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]\r\n at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]\r\n at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]\r\n at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]\r\nCaused by: java.lang.NullPointerException\r\n at net.minecraft.client.network.NetHandlerPlayClient.func_147290_a(NetHandlerPlayClient.java:2024) ~[bno.class:?]\r\n at net.minecraft.network.play.server.SPacketEntityProperties.func_148833_a(SourceFile:70) ~[ik.class:?]\r\n at net.minecraft.network.play.server.SPacketEntityProperties.func_148833_a(SourceFile:15) ~[ik.class:?]\r\n at org.spongepowered.common.network.PacketUtil.onProcessPacket(PacketUtil.java:164) ~[PacketUtil.class:1.11.2-2315-6.1.0-BETA-2395]\r\n at net.minecraft.network.PacketThreadUtil$1.redirect$onProcessPacket$zjk000(SourceFile:539) ~[fo$1.class:?]\r\n at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[fo$1.class:?]\r\n at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_131]\r\n at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_131]\r\n at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]\r\n ... 9 more\r\n```", "title": "Unable to connect when SpongeForge is installed client side", "type": "issue" }, { "action": "created", "author": "EmanYm", "comment_id": 309192990, "datetime": 1497674282000, "masked_author": "username_1", "text": "I suggest removing SpongeForge from your client.\r\nProbabley don't need SpongeAPI clientside either", "title": null, "type": "comment" }, { "action": "created", "author": "Meronat", "comment_id": 309195666, "datetime": 1497678827000, "masked_author": "username_2", "text": "@username_1 SpongeForge is designed to be able to work on servers and clients just fine, it even exposes some very slight extra features. Eventually the client version will provide a lot more functionality as well.\r\n\r\nIt can be a good way to test your plugins quickly, and it is another use case plugin developers should test and plan for. There are some people who even use SpongeForge on singleplayer to add certain functionality I bet.", "title": null, "type": "comment" }, { "action": "created", "author": "EmanYm", "comment_id": 309197860, "datetime": 1497682398000, "masked_author": "username_1", "text": "Have you tried without Spongeforge installed?\r\nDid you use the forge installer?\r\nDo you have any other mods installed?", "title": null, "type": "comment" }, { "action": "created", "author": "DarkArc", "comment_id": 309219626, "datetime": 1497711100000, "masked_author": "username_0", "text": "@username_1 It's not any other mods, it's SpongeForge. I've tried with every other mods removed. \r\n\r\nI need SpongeForge client side, as my mod is one jar, for client and server, and both a mix of Sponge, and Forge, for Item/Block registration. That's non-trivial to change, and I need Sponge present, if for no other reason, than to allow classes to load properly.", "title": null, "type": "comment" }, { "action": "created", "author": "EmanYm", "comment_id": 309220326, "datetime": 1497711877000, "masked_author": "username_1", "text": "Just trying to help by running down a troubleshooting list. I will leave this for a dev to look into now.", "title": null, "type": "comment" }, { "action": "created", "author": "DarkArc", "comment_id": 309251520, "datetime": 1497750992000, "masked_author": "username_0", "text": "Started to investigate, this is the original exception, which seems to be the source of the problem:\r\n```\r\njava.util.concurrent.ExecutionException: java.lang.IllegalStateException: Server has not been initialized yet!\r\n\tat java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_131]\r\n\tat java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_131]\r\n\tat net.minecraft.util.Util.runTask(Util.java:30) [Util.class:?]\r\n\tat net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1117) [Minecraft.class:?]\r\n\tat net.minecraft.client.Minecraft.run(Minecraft.java:407) [Minecraft.class:?]\r\n\tat net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]\r\n\tat java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]\r\n\tat net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]\r\n\tat net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]\r\n\tat java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]\r\n\tat net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]\r\n\tat GradleStart.main(GradleStart.java:26) [start/:?]\r\nCaused by: java.lang.IllegalStateException: Server has not been initialized yet!\r\n\tat com.google.common.base.Preconditions.checkState(Preconditions.java:176) ~[guava-17.0.jar:?]\r\n\tat org.spongepowered.mod.SpongeModGame.getServer(SpongeModGame.java:57) ~[SpongeModGame.class:?]\r\n\tat org.spongepowered.api.Sponge.getServer(Sponge.java:240) ~[Sponge.class:?]\r\n\tat net.minecraft.world.chunk.Chunk.handler$onConstructedTracker$zmk000(Chunk.java:5023) ~[Chunk.class:?]\r\n\tat net.minecraft.world.chunk.Chunk.<init>(Chunk.java:114) ~[Chunk.class:?]\r\n\tat net.minecraft.world.chunk.EmptyChunk.<init>(EmptyChunk.java:23) ~[EmptyChunk.class:?]\r\n\tat net.minecraft.client.multiplayer.ChunkProviderClient.<init>(ChunkProviderClient.java:43) ~[ChunkProviderClient.class:?]\r\n\tat net.minecraft.client.multiplayer.WorldClient.createChunkProvider(WorldClient.java:131) ~[WorldClient.class:?]\r\n\tat net.minecraft.client.multiplayer.WorldClient.<init>(WorldClient.java:77) ~[WorldClient.class:?]\r\n\tat net.minecraft.client.network.NetHandlerPlayClient.handleJoinGame(NetHandlerPlayClient.java:309) ~[NetHandlerPlayClient.class:?]\r\n\tat net.minecraft.network.play.server.SPacketJoinGame.processPacket(SPacketJoinGame.java:89) ~[SPacketJoinGame.class:?]\r\n\tat net.minecraft.network.play.server.SPacketJoinGame.processPacket(SPacketJoinGame.java:13) ~[SPacketJoinGame.class:?]\r\n\tat org.spongepowered.common.network.PacketUtil.onProcessPacket(PacketUtil.java:164) ~[PacketUtil.class:?]\r\n\tat net.minecraft.network.PacketThreadUtil$1.redirect$onProcessPacket$zjk000(PacketThreadUtil.java:539) ~[PacketThreadUtil$1.class:?]\r\n\tat net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]\r\n\tat java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_131]\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_131]\r\n\tat net.minecraft.util.Util.runTask(Util.java:29) ~[Util.class:?]\r\n\t... 15 more\r\n```", "title": null, "type": "comment" }, { "action": "closed", "author": "DarkArc", "comment_id": null, "datetime": 1497751463000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "DarkArc", "comment_id": 309251742, "datetime": 1497751463000, "masked_author": "username_0", "text": "Fixed by https://github.com/SpongePowered/SpongeCommon/pull/1384", "title": null, "type": "comment" } ]
3
9
7,285
false
false
7,285
true
antlr/antlr4
antlr
81,465,116
882
{ "number": 882, "repo": "antlr4", "user_login": "antlr" }
[ { "action": "opened", "author": "jcbrinfo", "comment_id": null, "datetime": 1432736073000, "masked_author": "username_0", "text": "I want to contribute to the antlr/antlr4-python3 project.", "title": "Add @jcbrinfo as a contributor", "type": "issue" }, { "action": "created", "author": "ericvergnaud", "comment_id": 105928211, "datetime": 1432736298000, "masked_author": "username_1", "text": "welcome", "title": null, "type": "comment" } ]
2
2
64
false
false
64
false
xmartlabs/XLForm
xmartlabs
101,198,652
508
null
[ { "action": "opened", "author": "carbocation", "comment_id": null, "datetime": 1439664350000, "masked_author": "username_0", "text": "Is it possible to have a validator that depends on other fields in the form?\r\n\r\nFor example, if someone is looking for housing an they choose between a \"minimum value\" and a \"maximum value\", it would be nice to indicate that both of those fields are invalid if the minimum value is greater than the maximum value.", "title": "Validation checking on other fields?", "type": "issue" }, { "action": "created", "author": "mats-claassen", "comment_id": 131816492, "datetime": 1439817626000, "masked_author": "username_1", "text": "Hi,\r\nAt this moment it is not directly supported. But you could use the onChangeBlock called when the value of a row is changed to achieve something like that", "title": null, "type": "comment" }, { "action": "closed", "author": "mats-claassen", "comment_id": null, "datetime": 1449861334000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "i-am-chris", "comment_id": 303938353, "datetime": 1495695385000, "masked_author": "username_2", "text": "how do you achieve that?\r\ni have \r\n`\r\n-(void)formRowDescriptorValueHasChanged:(XLFormRowDescriptor *)rowDescriptor oldValue:(id)oldValue newValue:(id)newValue\r\n{\r\n // super implementation MUST be called\r\n [super formRowDescriptorValueHasChanged:rowDescriptor oldValue:oldValue newValue:newValue];\r\n\r\nif([rowDescriptor.tag isEqualToString:@\"f1_from\"])\r\n {\r\n //NSString * evenMoreNewValue = [[NSString alloc] initWithFormat:@\"Hi %@ !\", newvalue];\r\n \r\n //NSDate *mydate = dataVeche;\r\n NSDate *myDate = [NSDate new];\r\n NSTimeInterval secondsIn3Hours = 3 * 60 * 60;\r\n NSDate *date3hAhead = [myDate dateByAddingTimeInterval:secondsIn3Hours];\r\n NSLog(@\"data in 3 h is: %@\",date3hAhead);\r\n theNewV1 = newValue;\r\n NSLog(@\"%@\",theNewV1);\r\n }\r\nif([rowDescriptor.tag isEqualToString:@\"f1_to\"]) {\r\ntheNewV2 = [NSDate dateWithTimeInterval:3600*3 sinceDate:theNewV1];\r\n NSLog(@\"🐕🐕🐕🐕🐕 %@\",theNewV2);\r\n[self reloadFormRow:rowDescriptor]; \r\n\r\n/// HERE?? i need to set this minimum date to be ahead of the f1_from + 3h \r\n}\r\n }\r\n`", "title": null, "type": "comment" }, { "action": "created", "author": "mats-claassen", "comment_id": 304009626, "datetime": 1495718796000, "masked_author": "username_1", "text": "Hi @username_2 you can call `formRowWithTag` on your form to get that row. Then you get the value of that row and add those 3 hours.", "title": null, "type": "comment" } ]
3
5
1,701
false
false
1,701
true
Workiva/go-datastructures
Workiva
150,873,702
135
{ "number": 135, "repo": "go-datastructures", "user_login": "Workiva" }
[ { "action": "opened", "author": "alexandercampbell-wf", "comment_id": null, "datetime": 1461593396000, "masked_author": "username_0", "text": "Closes #104.\r\n\r\n- Update the README to point to alternative Set implementations which may be more suitable for different use cases.\r\n- I've also moved the TODO to the source file, where it's more relevant.\r\n\r\n@username_2 @blakewilson-wf @rosshendrickson-wf @username_1", "title": "README: update to point to alternative Set impls", "type": "issue" }, { "action": "created", "author": "brycewilson-wf", "comment_id": 214421108, "datetime": 1461600550000, "masked_author": "username_1", "text": "+1", "title": null, "type": "comment" }, { "action": "created", "author": "dustinhiatt-wf", "comment_id": 217272737, "datetime": 1462481031000, "masked_author": "username_2", "text": "+1", "title": null, "type": "comment" } ]
3
3
280
false
false
280
true
facebook/jscodeshift
facebook
236,469,180
205
null
[ { "action": "opened", "author": "namirsab", "comment_id": null, "datetime": 1497616177000, "masked_author": "username_0", "text": "### Observerd behaviour\r\nGiven this code:\r\n```js\r\ndefinitions({\r\n 'my-defs.def1': SecureDef(['right1'], (arg1, arg2) => 1, (arg1, arg2) => fromArg({ arg1 })),\r\n});\r\n```\r\n\r\nI have a transform that works in every case when te third argument of `SecureDef` is a function calling other functions, or an identifier, or whatever but **destructuring**.\r\nI get this error:\r\n\r\n`undefined does not match field \"value\": string | boolean | null | number | RegExp of type Literal`\r\n\r\nI'm not sure what that means...\r\n\r\n### Expected Behaviour\r\n* No error is thrown and the transforms works as it works for these examples:\r\n\r\n```js\r\ndefinitions({\r\n 'my-defs.def1': SecureDef(['right1'], (arg1, arg2) => 1, (arg1, arg2) => fromArg(arg1)),\r\n 'my-defs.def2': SecureDef(['right1'], (arg1) => arg1 + 1, myThirdFunction)\r\n});\r\n```\r\n\r\nThe transform is converting to something like this:\r\n\r\n```js\r\nconst def1 = createDef({\r\n name: 'my-defs.def1',\r\n security: {\r\n rights: ['right1'],\r\n extractor: (arg1, arg2) => fromArg({ arg1 }) // This is what's making it fail\r\n },\r\n run: (arg1, arg2) => 1\r\n})\r\n```", "title": "Error when using destructured parameters", "type": "issue" }, { "action": "created", "author": "namirsab", "comment_id": 309016592, "datetime": 1497617007000, "masked_author": "username_0", "text": "forget it xD it was my transform :smile:", "title": null, "type": "comment" }, { "action": "closed", "author": "namirsab", "comment_id": null, "datetime": 1497617008000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
3
1,139
false
false
1,139
false