repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
microservices/omg-cli | microservices | 343,744,714 | 39 | {
"number": 39,
"repo": "omg-cli",
"user_login": "microservices"
} | [
{
"action": "opened",
"author": "TomPed",
"comment_id": null,
"datetime": 1532370534000,
"masked_author": "username_0",
"text": "Fixes #33.",
"title": "Fixes issue with streaming containers and wrong output types",
"type": "issue"
}
] | 2 | 2 | 10 | false | true | 10 | false |
ratson/cordova-plugin-admob-free | null | 299,780,096 | 173 | null | [
{
"action": "opened",
"author": "AcShadow",
"comment_id": null,
"datetime": 1519405163000,
"masked_author": "username_0",
"text": "this is the error message returned.\r\n\r\n`{\"isTrusted\":false,\"error\":3,\"reason\":\"No Fill\",\"adType\":\"banner\"}`\r\n\r\nalso none of the ads are using testing ads. this worries me to continue testing.\r\nhere is the code:\r\n```\r\nadmob.banner.config({\r\n id: 'ca-app-pub-8770565591901781/6053273355',\r\n isTesting: true,\r\n autoShow: true,\r\n overlap: true\r\n });\r\n admob.banner.prepare();\r\n\r\ndocument.addEventListener('admob.banner.events.LOAD_FAIL',function(event){\r\n alert(\"load fail: \"+JSON.stringify(event));\r\n });\r\n document.addEventListener('admob.banner.events.LOAD',function(event){\r\n alert(\"load good\"+JSON.stringify(event));\r\n alert(JSON.stringify(admob.banner.config.id));\r\n });\r\n```\r\n\r\njust to be clear, the LOAD_FAIL event is firing every time. consistently.\r\nI am able to display interstitial ads fine but they are not testing ads even after i set the config to isTesting: true",
"title": "banner load fail, got an error message, hope someone can help",
"type": "issue"
},
{
"action": "created",
"author": "erperejildo",
"comment_id": 369923907,
"datetime": 1519998211000,
"masked_author": "username_1",
"text": "Similar issue?\r\nhttps://github.com/ratson/cordova-plugin-admob-free/issues/119",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "torelk",
"comment_id": 370169148,
"datetime": 1520101744000,
"masked_author": "username_2",
"text": "i tried some of the solutions listed on that issue but none worked. \r\nI created a new cordova android project to test with just this plugin and i was still having issues.\r\nThen on a whim i changed the id of my banner ad to your id listed in your example, it **works perfectly**....\r\nI then created a new banner ad and its **not working**. how am i creating ad units incorrectly?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AcShadow",
"comment_id": 370170096,
"datetime": 1520102536000,
"masked_author": "username_0",
"text": "i tried some of the solutions listed on that issue but none worked.\r\nI created a new cordova android project to test with just this plugin and i was still having issues.\r\nThen on a whim i changed the id of my banner ad to the id listed in your example for the banner, it works perfectly....\r\nI then created a new banner ad and its not working. how am i creating ad units incorrectly?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AcShadow",
"comment_id": 370170284,
"datetime": 1520102691000,
"masked_author": "username_0",
"text": "ok so i messed around with the settings on admob for my banner ad unit, turns out automatic refresh was causing this issue or at least somewhat related as i had it on the setting \"google optimized\" and after changing to \"disabled\" the banner ad now displays. BUT it is still not in testing mode.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AcShadow",
"comment_id": 370170605,
"datetime": 1520102985000,
"masked_author": "username_0",
"text": "Shall i close this issue to create a more accurate version?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "romit19",
"comment_id": 375581996,
"datetime": 1521794661000,
"masked_author": "username_3",
"text": "@acshadow i am also facing same issue. could you please elaborate.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "manjunath-K",
"comment_id": 417832501,
"datetime": 1535776895000,
"masked_author": "username_4",
"text": "getting same issue. I have created admob account and created ad unit, when tested getting below error.\r\n\r\n{\"isTrusted\":false,\"adNetwork\":\"AdMob\",\"adType\":\"banner\",\"adEvent\":\"onAdFailLoad\",\"error\":0,\"reason\":\"Internal error\"}\r\nwhen i tested with google test ad unit the code is working properly. not able to understand please help",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shinobirozs",
"comment_id": 448200646,
"datetime": 1545135283000,
"masked_author": "username_5",
"text": "@username_4 , I'm also experiencing the same issue on one of my apps right now. How did you fixed it? \r\n\r\n`onFailedToReceiveAd : reason:\"No Fill\"`\r\n\r\nThanks in advance.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "manjunath-K",
"comment_id": 448205594,
"datetime": 1545136479000,
"masked_author": "username_4",
"text": "Hi ShinobiRozs,\nyes, the No Fill comes when there is no ads, you don't need to do any thing\nwhen there are ads that will show, you make sure your code is correct, to\ncheck display check with google ads id's.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shinobirozs",
"comment_id": 448206425,
"datetime": 1545136662000,
"masked_author": "username_5",
"text": "@username_4, Thank you. I am really grateful to you for your prompt reply.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "osmaneser",
"comment_id": 570329177,
"datetime": 1577995938000,
"masked_author": "username_6",
"text": "aren't there are solved anybody this problem? I'm going crazy.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lucaspojo",
"comment_id": 600107712,
"datetime": 1584456002000,
"masked_author": "username_7",
"text": "Up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "carlosbeperaza",
"comment_id": 614658440,
"datetime": 1587044296000,
"masked_author": "username_8",
"text": "@username_6 any update about the problem?",
"title": null,
"type": "comment"
}
] | 9 | 14 | 3,070 | false | false | 3,070 | true |
dguenms/Dawn-of-Civilization | null | 156,858,391 | 128 | {
"number": 128,
"repo": "Dawn-of-Civilization",
"user_login": "dguenms"
} | [
{
"action": "opened",
"author": "Imperator-Knoedel",
"comment_id": null,
"datetime": 1464212974000,
"masked_author": "username_0",
"text": "Notice me and my coding skills, senpai!",
"title": "Included Imperator Knoedel's Enhanced Culture Mod",
"type": "issue"
}
] | 2 | 2 | 275 | false | true | 39 | false |
phalcon/phalcon-devtools | null | 55,970,311 | 294 | {
"number": 294,
"repo": "phalcon-devtools",
"user_login": "phalcon"
} | [
{
"action": "opened",
"author": "7thcubic",
"comment_id": null,
"datetime": 1422572281000,
"masked_author": "username_0",
"text": "",
"title": "Added migration check for column size ",
"type": "issue"
},
{
"action": "created",
"author": "rianorie",
"comment_id": 76275171,
"datetime": 1424985384000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 7 | false | false | 7 | false |
kak-tus/perltidy-more | null | 377,552,764 | 4 | null | [
{
"action": "opened",
"author": "akarelas",
"comment_id": null,
"datetime": 1541446941000,
"masked_author": "username_0",
"text": "I believe that right now this plugin only uses the .perltidyrc that exists in $HOME\r\n\r\nI would like this plugin to first use the .perltidyrc that exists in the project root directory.",
"title": "First search for .perltidy in the project root",
"type": "issue"
},
{
"action": "closed",
"author": "kak-tus",
"comment_id": null,
"datetime": 1541450002000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "kak-tus",
"comment_id": 436024928,
"datetime": 1541450012000,
"masked_author": "username_1",
"text": "Use \"perltidy-more.profile\" option and set it to \".../.perltidyrc\". Three dots is perltidy specific option to indicates that the file should be searched for starting in the current directory and working upwards. This makes it easier to have multiple projects each with their own .perltidyrc in their root directories.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akarelas",
"comment_id": 436392358,
"datetime": 1541535166000,
"masked_author": "username_0",
"text": "Can you please write this tip in the plugin page? Everybody must know this, but I think very few people know it. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kak-tus",
"comment_id": 436402810,
"datetime": 1541537250000,
"masked_author": "username_1",
"text": "I've done it here :)\r\nhttps://github.com/username_1/perltidy-more/commit/2fe58af1931fd1f1a0124dd981ead74f5b0e9c29\r\n\r\nIn readme and in configuration page\r\n",
"title": null,
"type": "comment"
}
] | 2 | 5 | 880 | false | false | 880 | true |
krzysztofzablocki/Sourcery | null | 289,255,740 | 494 | {
"number": 494,
"repo": "Sourcery",
"user_login": "krzysztofzablocki"
} | [
{
"action": "opened",
"author": "JakubMazur",
"comment_id": null,
"datetime": 1516193633000,
"masked_author": "username_0",
"text": "",
"title": "update readme installation with homebrew information",
"type": "issue"
},
{
"action": "created",
"author": "krzysztofzablocki",
"comment_id": 358295491,
"datetime": 1516193676000,
"masked_author": "username_1",
"text": "thanks for contributing :)",
"title": null,
"type": "comment"
}
] | 2 | 2 | 26 | false | false | 26 | false |
Maximus5/ConEmu | null | 288,387,801 | 1,401 | null | [
{
"action": "opened",
"author": "adamchenwei",
"comment_id": null,
"datetime": 1515912757000,
"masked_author": "username_0",
"text": "* Please do not post problems found in old builds, update first.\r\n ConEmu versions has following format `YYMMDD`, so if you are using old build,\r\n there are chances that your problem was fixed long ago.\r\n <https://conemu.github.io/en/OldBuild.html>.\r\n\r\n* Please do search first in the open <https://github.com/username_1/ConEmu/issues?q=is%3Aopen>\r\n or closed <https://github.com/username_1/ConEmu/issues?q=is%3Aclosed> issues.\r\n\r\n* Please do not try to attach or paste here large files like crash dumps, logs or xml settings.\r\n Use external hosting services like <https://conemu.github.io/en/DropBox.html>\r\n or <https://gist.github.com/>.\r\n\r\n* Please do not post here third-party problems, this is ConEmu project issue tracker.\r\n * <https://github.com/username_1/ConEmu/blob/master/.github/CONTRIBUTING.md>\r\n * <https://conemu.github.io/en/BadIssue.html>\r\n\r\n\r\n\r\n### Versions\r\n\r\nConEmu build: 161206 x64\r\nOS version: Windows 10 latest Developer Mode Enabled\r\nUsed shell version : git-bash, cmd, powershell\r\n\r\n\r\n### Problem description\r\nTrie to build a automated task step base on the existing Bash Script task was not successful\r\nI did\r\n\r\n```\r\n%ConEmuDrive%\\Git\\git-cmd.exe --no-cd --command=usr/bin/bash.exe -l -i\r\ncmd.exe -new_console:d:\"cd C:\\www && npm start\"\r\n```\r\n\r\n\r\n### Steps to reproduce\r\n\r\n1. create task copy from Bash task\r\n2. run it\r\n3. see it open two new tabs instead of running inside the Bash tab\r\n\r\n\r\n### Actual results\r\ntwo tabs, with one bash and another really just regular windows command line\r\n\r\n\r\n### Expected results\r\nopen one bash tab and running the command `cd C:\\www && npm start` in it!\r\n\r\n\r\n### Additional files\r\n\r\n\r\n[Settings](https://conemu.github.io/en/ConEmuXml.html),\r\n[screenshots](https://conemu.github.io/en/BadIssue.html#Screenshot),\r\n[logs](https://conemu.github.io/en/LogFiles.html),\r\netc.",
"title": "Not able to start new bash tab with cd into a directory and run a simple npm command",
"type": "issue"
},
{
"action": "closed",
"author": "Maximus5",
"comment_id": null,
"datetime": 1515919049000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Maximus5",
"comment_id": 357496671,
"datetime": 1515919049000,
"masked_author": "username_1",
"text": "The `-new_console:d:` doesn't support `cd` or any other commands.\r\n\r\n* [-new_console](http://conemu.github.io/en/NewConsole.html)\r\n* [Tasks](http://conemu.github.io/en/Tasks.html)\r\n\r\nI don't understand the question about languages.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adamchenwei",
"comment_id": 357511417,
"datetime": 1515935992000,
"masked_author": "username_0",
"text": "@username_1 the script, or the command that wrote in task, clearly they are not shell script no? I mean that, I dont really type all that in the command line to get into a directory, like in console I only need to do `cd C:\\www` and in this \"task\" script I have to write all that command, what language is it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Maximus5",
"comment_id": 357512184,
"datetime": 1515936741000,
"masked_author": "username_1",
"text": "Did you really read the links I posted?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adamchenwei",
"comment_id": 357512740,
"datetime": 1515937320000,
"masked_author": "username_0",
"text": "@username_1 I did and in additional, I read https://superuser.com/questions/1104567/how-can-i-find-out-the-command-line-options-for-git-bash-exe and https://stackoverflow.com/questions/19916670/how-to-launch-a-git-bash-window-with-particular-working-directory-using-a-script and they are different than what in the ConEmu instruction. Super confused, I am still not too familiar with different kind of command line languages. \r\n\r\nWould you able to instruct me on at minmum, how to open a default bash command and execute one more command after it? like `cd c:\\www && npm start`?\r\nJust tried `-c`, but still not working\r\n`%ConEmuDrive%\\Git\\git-cmd.exe --command=usr/bin/bash.exe -l -i -c \" cd C:\\www\"`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Maximus5",
"comment_id": 357514101,
"datetime": 1515938767000,
"masked_author": "username_1",
"text": "* Be precise. Read the messages tools display to you. Words \"it doesn't work\" means nothing.\r\n* Don't mix switches from different tools in one place. There is absolutely no sence to pass `cd c:\\www && npm start` into `-new_console:d:\"...\"`. ConEmu is not a bash.\r\n* Learn about paths in POSIX, `c:\\www` is illegal there! You must use `/c/www` instead.\r\n* At last, your question was answered many times, and there is [CygwinStartCmd](https://conemu.github.io/en/CygwinStartCmd.html) and [CygwinStartDir](https://conemu.github.io/en/CygwinStartDir.html). And actually, it is related to git-for-windows in much, but not to ConEmu.\r\n\r\n```\r\n%ProgramFiles%\\Git\\git-cmd.exe --command=usr/bin/bash.exe -c \"cd /c/www; pwd; npm start\"\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Maximus5",
"comment_id": 357514302,
"datetime": 1515938960000,
"masked_author": "username_1",
"text": "One more link\r\n\r\nhttps://conemu.github.io/en/GitForWindows.html",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kdelmonte",
"comment_id": 377231614,
"datetime": 1522329385000,
"masked_author": "username_2",
"text": "-cur_console:s50H:d:C:\\code\\terminus \"%ConEmuDir%\\..\\Git\\git-cmd.exe\" --no-cd --command=usr/bin/bash.exe -l -i -c \"git status && $SHELL\"\r\n```\r\n\r\nScreenshot:\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "synthnassizer",
"comment_id": 497641983,
"datetime": 1559294704000,
"masked_author": "username_3",
"text": "@username_2 this final \"...&& $SHELL \" , was what I was missing. \r\nbecause git pull would complete , bash.exe would exit and I always got a notification from ConEmu that the command finished in less than 10 seconds and I would never get a command prompt. \r\nMakes sense to add this specific task invokation in [GitForWindows](https://conemu.github.io/en/GitForWindows.html) as a new subsection \"start git for windows, run a command in bash and provide a prompt afterwards\"",
"title": null,
"type": "comment"
}
] | 4 | 10 | 4,749 | false | false | 4,749 | true |
wso2/andes | wso2 | 93,754,782 | 188 | {
"number": 188,
"repo": "andes",
"user_login": "wso2"
} | [
{
"action": "opened",
"author": "AnujaLK",
"comment_id": null,
"datetime": 1436350543000,
"masked_author": "username_0",
"text": "",
"title": "Fixed primary key violation issue in updating message id",
"type": "issue"
},
{
"action": "created",
"author": "hemikak",
"comment_id": 119543920,
"datetime": 1436354031000,
"masked_author": "username_1",
"text": "How was \"Fixed primary key violation issue in updating message id\" in this commit. Just asking.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AnujaLK",
"comment_id": 123214756,
"datetime": 1437467956000,
"masked_author": "username_0",
"text": "When adding message id, same message id can be added to list when slots are overlapped. In RDBMS slot store composite primary key of queue name and message id have been used to avoid duplicates.\r\nTherefore primary key violation exception is being thrown and can be ignored to fix the unnecessary log message console.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 411 | false | false | 411 | false |
ThirteenAG/WidescreenFixesPack | null | 374,776,621 | 558 | null | [
{
"action": "opened",
"author": "r3538987",
"comment_id": null,
"datetime": 1540747059000,
"masked_author": "username_0",
"text": "Продублирую информацию которую я написал в посте форума gtaforums. ([https://gtaforums.com/topic/547841-gtanfsmpother-widescreen-fixes-pack/?do=findComment&comment=1070508813](url)\r\n\r\nВерсия: GOG 1.4, build 1405\r\n**Выставляя FOVFactor выше стандартного, в игре появляются артефакты по краям экрана**, объекты пропадают, будто игра не считает что там видимая зона для игрока. \r\n(https://i.imgur.com/zHwtyHo.gifv / https://i.imgur.com/zHwtyHo.gif )\r\n-\r\nИ дополнительный вопрос, **масштаб интерфейса можно сделать, или это не так просто?**\r\nПрост зачастую сколько читал, внедрение нового функционала варьируется от игры к игре, где-то просто, где-то проще забить на это дело. =)",
"title": "FarCry big fov rendering issue (+feature request)",
"type": "issue"
},
{
"action": "closed",
"author": "ThirteenAG",
"comment_id": null,
"datetime": 1540889361000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "ThirteenAG",
"comment_id": null,
"datetime": 1540890256000,
"masked_author": "username_1",
"text": "Продублирую информацию которую я написал в посте форума gtaforums. \r\n-\r\nВерсия: GOG 1.4, build 1405\r\nВыставляя FOVFactor выше стандартного, в игре появляются артефакты по краям экрана, объекты пропадают, будто игра не считает что там видимая зона для игрока.\r\nПример - https://i.imgur.com/zHwtyHo.gif \r\n\r\nИ дополнительный вопрос, функционал масштаба интерфейса можно сделать, или это не так просто?\r\nПрост зачастую сколько читал, внедрение нового функционала варьируется от игры к игре, где-то просто, где-то проще забить на это дело. =)",
"title": "FarCry big fov rendering issue (+feature request)",
"type": "issue"
},
{
"action": "closed",
"author": "ThirteenAG",
"comment_id": null,
"datetime": 1540890291000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434222537,
"datetime": 1540890315000,
"masked_author": "username_1",
"text": "\r\nВроде заработало у меня.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434843620,
"datetime": 1541019183000,
"masked_author": "username_0",
"text": "Когда игрок получает урон и так далее, есть некий эффект затемнения. \r\nЭто уже нужно править игровые файлы, или также можно добиться правильного отображения через сам фикс?\r\nВыстрел рядом с ГГ - https://i.imgur.com/KEEY1sD.png\r\nВыстрел с попаданием - https://i.imgur.com/jQEhqWd.gif",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434844357,
"datetime": 1541019332000,
"masked_author": "username_1",
"text": "Я вроде исправлял такое. Это на x64 версии или x86? Или на обоих?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434845143,
"datetime": 1541019483000,
"masked_author": "username_0",
"text": "Кстати да, сейчас у меня ЕХЕ х64 1.32.\r\nПотому как с 32ух битным было много проблем (убердолгие загрузки / настройки графики работали как-то криво, эффекты кешировались и делали из игры слайдшоу)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434846097,
"datetime": 1541019671000,
"masked_author": "username_0",
"text": "Я могу поставить GOG 1.4, и глянуть что там на 32ух битном ЕХЕ.\r\n*оффтоп*Если ты работаешь с 32ух битными файлами по умолчанию, у тебя вышеперечисленных проблем небыло?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434846558,
"datetime": 1541019759000,
"masked_author": "username_1",
"text": "Ну вроде я что-то исправлял такое, но может и проглядел конечно, особо то не тестировал.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434852548,
"datetime": 1541020963000,
"masked_author": "username_0",
"text": "GOG 1.4 с файлом который качается по ссылке - dev-build.\r\n- FOVFactor = 1.3\r\nhttps://i.imgur.com/Z4w5ljH.jpg\r\nhttps://i.imgur.com/ejLCsC1.jpg / https://i.imgur.com/SHY09Yw.jpg",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434855354,
"datetime": 1541021545000,
"masked_author": "username_0",
"text": "Эффект от попадания работает правильно, да.\r\nНо вот все меню, бинокль, снайперка, с полосками. \r\n+ Это чистый 1.4, и у мну все по краям пропадает еще более выражено, нежели чем было до фикса. Будто фикс сработал наоборот.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434855937,
"datetime": 1541021674000,
"masked_author": "username_1",
"text": "Ну так и должно быть.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434856463,
"datetime": 1541021785000,
"masked_author": "username_0",
"text": "Ну бинокль и снайперка/прицелы это ладно, выглядит хорошо. \r\nНо то что катсцены и меню сжато этими самыми полосками, или и это так и задумано?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434857474,
"datetime": 1541022012000,
"masked_author": "username_1",
"text": "Видеоролики в смысле? Я же выложил широкоформатные, они должны на весь экран быть, за исключением меню.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 434859393,
"datetime": 1541022436000,
"masked_author": "username_0",
"text": "Теперь все понятно. \r\nВыходит попадания для х64 1.32 ты поправишь. \r\nА то что для 1.4 у мну эффект обратный, fov больше, зона рендера - меньше, куда копать?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 434979688,
"datetime": 1541063631000,
"masked_author": "username_1",
"text": "Это я исправил, попробуй эти версии:\r\nhttps://transfer.sh/xEa16/FarCry.WidescreenFix.asi\r\nhttps://transfer.sh/OZCRv/FarCry64.WidescreenFix.asi\r\nА вот рамки при получении урона не могу воспроизвести, работает как надо у меня.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435065534,
"datetime": 1541083953000,
"masked_author": "username_0",
"text": "32 бита\r\nОбратный эффект в 1.4, пропал. Все отлично.\r\n64 бита\r\nПолоски по краям экрана также пропали. (Потом попробовал старый asi, и там тоже все норм).\r\nМожет я тогда поймал какой редкий \"баг\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435067121,
"datetime": 1541084229000,
"masked_author": "username_0",
"text": "Мне сейчас начинает казаться что эффект попадания в ГГ с разных стволов, это разные эффекты.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435078625,
"datetime": 1541086190000,
"masked_author": "username_0",
"text": "https://youtu.be/zXoMvQHcKxk",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435109817,
"datetime": 1541091660000,
"masked_author": "username_1",
"text": "Это плохо, буду разбираться.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435144601,
"datetime": 1541097917000,
"masked_author": "username_0",
"text": "Побегал я в том месте с разными версиями.\r\nВыходит что 32бита работают нормально, полос нет.\r\nТолько на 64ех вылезает это.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435312974,
"datetime": 1541149055000,
"masked_author": "username_1",
"text": "https://transfer.sh/B8l2v/FarCry64.WidescreenFix.asi\r\nКак сейчас?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435314471,
"datetime": 1541149425000,
"masked_author": "username_1",
"text": "Разобрался в чем дело, теперь должно работать, скачай новый dev билд и проверь что все ок, я тогда перезалью на гитхаб его.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435332779,
"datetime": 1541153757000,
"masked_author": "username_0",
"text": "Да, проблема пропала, все збс.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435619411,
"datetime": 1541277837000,
"masked_author": "username_0",
"text": "https://i.imgur.com/b8QOqxg.jpg\r\nЕще заметил вот такое.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435619622,
"datetime": 1541278061000,
"masked_author": "username_1",
"text": "А что не так?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 435620018,
"datetime": 1541278403000,
"masked_author": "username_0",
"text": "Индикаторы на врагах как-то криво встают, когда они близко к краю экрана. \r\nДаже не могу так сразу и объяснить.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435620184,
"datetime": 1541278537000,
"masked_author": "username_1",
"text": "Ну такое может быть, наверно не получится исправить. Главное чтоб в центре было нормально.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 435801745,
"datetime": 1541408670000,
"masked_author": "username_1",
"text": "Посмотри вот эту версию: https://transfer.sh/QqzKv/FarCry64.WidescreenFix.asi\r\n\r\nВернул маркеры в оригинальное состояние, в принципе ничего страшного что они растянутые будут. Пофиксить нормально не получается.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 445471356,
"datetime": 1544286612000,
"masked_author": "username_1",
"text": "Вобще да, но вроде у меня работало, я там специально проверочку добавлял.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449971015,
"datetime": 1545833072000,
"masked_author": "username_2",
"text": "@username_1 First, I'm sorry for reviving this older thread, but I noticed, that in the released version there are multiple bugs, which were fixed in those links, which seems to be dead now. Plus, the Malwarebytes reports that there is a Trojan, so, can you please upload that fixed file, which fixes those bugs? The most annoying bug is the flickering one, which was one of the first ones, which was reported.\r\n\r\nAlso, it is compatible with the excellent SilentPatch? There are two same files, which are called version, dll and since those are dll files, it's very difficult to compare them, but even then, I would probably have absolutely no idea what those numbers mean. I did a bit of hex editing, so I knew how important is to have a right file, but here I have no idea which one is the best.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449974954,
"datetime": 1545834947000,
"masked_author": "username_0",
"text": "Я не уверен что мои проверки будут подходящие. \r\nТ.к. у меня игра была 1.4 от GOG'a. Но на нее я ставил Х64 патч, который в результате из х64 делает 1.32 версию. \r\nИ уже после патча запуская игру из Bin32 я получаю https://i.imgur.com/0OygY0m.png",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449975471,
"datetime": 1545835233000,
"masked_author": "username_1",
"text": "У меня вот тоже так, хотя я вроде проверял на обеих версиях, магическим образом все поломалось опять. Буду разбираться. А баг со списком заданий на x64 версии был?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449975758,
"datetime": 1545835389000,
"masked_author": "username_0",
"text": "Да, потому что я играл только в Х64. \r\nЯ тут венду обновил, и теперь еще такое вылезло. https://i.imgur.com/4nFfm7s.png Но думаю это дело уже в ОС.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449977054,
"datetime": 1545836007000,
"masked_author": "username_2",
"text": "@username_1 It is obvious, but since those glitches are there, I have to mention it, because I can't play mods like the Catalyst Aftermath since I can't see almost anything at the beginning. Plus, the last version, is from the September, so I don't get why are you mentioning it, if there is only older version. I'm using 1.4 which is the latest patch and 32bit.\r\n\r\nWell, yours is newer, but since those are DLL files, if there is just a different one, then it could have a lot of different stuff than the one from the Silent Patch.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449977635,
"datetime": 1545836278000,
"masked_author": "username_0",
"text": "Игра из Bin64, версия 1.32.\r\nASI тот что от 5ого Ноября. \r\nhttps://i.imgur.com/4nFfm7s.png\r\nhttps://i.imgur.com/GWM21f7.png\r\nhttps://i.imgur.com/oevTrT0.jpg\r\nhttps://i.imgur.com/Omzaqq6.png\r\n\r\nusername_2, both DLL's does same thing. So if whichever you choose can load ASI scripts, use it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449977830,
"datetime": 1545836356000,
"masked_author": "username_1",
"text": "It is strange, because I believe I tested both versions before reuploading and now 32 bit doesn't work properly. I know that 64 bit does. I will have to check what's going on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449978548,
"datetime": 1545836674000,
"masked_author": "username_0",
"text": "А не может быть так что какие-то изменения не закомитил\\-лись?\r\nНа сайте **Updated 54 days ago** а тут в релизах 23е Сентября.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449978676,
"datetime": 1545836744000,
"masked_author": "username_1",
"text": "Нет.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449978907,
"datetime": 1545836851000,
"masked_author": "username_2",
"text": "@username_0 Yes, I have that kind of glitches as well.\r\n\r\n@username_1 I know, but since they don't have the same size, there could be either some additional code, which doesn't need to be there.\r\n\r\nI see, and I hope that you will fix it, since the older Field of View method doesn't work properly and even with the 180 FOV Its still quite low. Plus, your method is much better than the older one.\r\n\r\n@username_0 Indeed, it seems that those fixes haven't been added to the release.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449979489,
"datetime": 1545837112000,
"masked_author": "username_0",
"text": "username_2, what glitches to be exact? because\r\nBorders on the binocular & sniper are fine. \r\nTab menu, is like that, because if author will make it correct, then you will get enemy markers misalignment when enemies are close to screen border. \r\nSame goes for crosshair in car.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449979862,
"datetime": 1545837282000,
"masked_author": "username_2",
"text": "The flickering is the most annoying one, and also the black bars in the main menu, and also in the game when I use the console. Plus, the sun is invisible, if it should be in the left or right end of the screen.\r\n\r\nThat's a pity, since the sun will stay invisible then.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449982657,
"datetime": 1545838549000,
"masked_author": "username_1",
"text": "@username_2 Try this version: https://transfer.sh/JHyKy/FarCry.WidescreenFix.asi\r\n\r\nI didn't know there's a stretched crosshair in car, and text kinda gets stretched because of that as well. I will have to find another way to fix binoculars.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449983116,
"datetime": 1545838761000,
"masked_author": "username_2",
"text": "@username_0 I haven't even used any texture pack, but I will damselfly use some HD textures, so it should work.\r\n\r\nI think it could be a very high FOV issue, but even then it shouldn't cause that.\r\n\r\n@username_1 _**Website blocked due to Trojan.**_ Can you please upload it to some other site, like Mega, Google Drive, Yandex or something like that, which doesn't have viruses? Also, that link doesn't work for me, for some odd reason.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449983495,
"datetime": 1545838934000,
"masked_author": "username_1",
"text": "Then unblock it? Why are you even use such software that marks everything as a trojan?\r\n\r\n[FarCry.WidescreenFix.asi.zip](https://github.com/username_1/WidescreenFixesPack/files/2710467/FarCry.WidescreenFix.asi.zip)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449983665,
"datetime": 1545839011000,
"masked_author": "username_2",
"text": "Since it's one of the best, and I have a license for it. Before I used the HitmanProAlert, which caused multiple heavy freezes, so the Malwarebytes at least doesn't do that.\r\n\r\nNow, I'm getting a Critical Exception error.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449983883,
"datetime": 1545839109000,
"masked_author": "username_0",
"text": "Я кста тоже получал ошибку, когда последний ASI пихал в 32битную версию. Игра запускалась, но изменения вроде не вносились.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449984470,
"datetime": 1545839377000,
"masked_author": "username_2",
"text": "I don't have that error, but the classic Far Cry 1 error which is the **Critical Exception**.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449984801,
"datetime": 1545839512000,
"masked_author": "username_1",
"text": "@username_0 ну а какой смысл так делать?\r\nhttps://www.aptech.com/questions/getting-loadlibrary-error-193-when-i-try-to-load-a-dll-with-dlibrary/\r\n\r\n@username_2 It works for me, there's almost no changes I made, so it can't crash because of something I added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449985224,
"datetime": 1545839702000,
"masked_author": "username_2",
"text": "That's weird, since no matter the mod, they all crash and even the vanilla game.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449994510,
"datetime": 1545843906000,
"masked_author": "username_2",
"text": "@username_1 So, I tried the 64bit version and that one works great, but I still have the black lines on left and right in the menu and also, in the game when I use the console. Luckily, the flickering is gone on that version and I can play that. However, for those who are using 32bit they still have that issue probably. Plus, mods like Iron Sights doesn't work, because of the missing source code (or at least it seems that's the issue).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449994788,
"datetime": 1545844023000,
"masked_author": "username_1",
"text": "Yes, I fixed that, but I'm gonna try to fix binoculars and objectives list before uploading an update.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 449994859,
"datetime": 1545844056000,
"masked_author": "username_0",
"text": "А через эти ASI скрипты можно сделать так чтобы при запуске игры заодно и разкладка клавиатуры менялась на \"не кириллицу\"?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 449995105,
"datetime": 1545844155000,
"masked_author": "username_1",
"text": "@username_0 Не знаю точно, посмотрю. Может добавлю заодно такую опцию.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 449995262,
"datetime": 1545844224000,
"masked_author": "username_2",
"text": "@username_1 That's a good to hear, and I will be waiting, since the 64bit features have been ported in one mod, which can be easily applied to most of the other mods as well, so the 32bit is a much more important.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 450155080,
"datetime": 1545918996000,
"masked_author": "username_1",
"text": "@username_0 Пофиксил маркеры, теперь не должны влиять на список заданий, не растянутые ну и не глючат.\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 450172721,
"datetime": 1545924690000,
"masked_author": "username_0",
"text": "А посоны с 32битными ЕХЕ тоже это получал? =)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 450173158,
"datetime": 1545924807000,
"masked_author": "username_1",
"text": "Да обе версии одинаковые, сейчас в dev-билде я эти баги поправил, а язык сменить не получается, так что перезалью наверно так.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 451788952,
"datetime": 1546820052000,
"masked_author": "username_1",
"text": "@username_0 \r\nВот сделал смену языка на старте, проверяй:\r\nhttps://transfer.sh/lAkTG/FarCry64.WidescreenFix.asi\r\nhttps://transfer.sh/pKuNu/FarCry.WidescreenFix.asi",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 452015942,
"datetime": 1546882509000,
"masked_author": "username_1",
"text": "Пардон, не тот регистр был написан в коде.\r\nhttps://transfer.sh/YodJa/FarCry64.WidescreenFix.asi",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 452068463,
"datetime": 1546892432000,
"masked_author": "username_0",
"text": "Ну супер. \r\nЯ думаю тут даже исправлять больше нечего. Лично у меня больше проблем нет от слова вообще.\r\nРазве что у бинокля в прицеле по краям фон прозрачный, а у снайперки черный.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 464361596,
"datetime": 1550335432000,
"masked_author": "username_0",
"text": "-\r\nБампану тему, еще вопросом. \r\nЗахотел я с одного монитора переместить окно на другой, вот только выходит так что окно как вкопанное на основном мониторе. \r\nПодвигать курсором не получается (фикс убран) чтобы рамки появились.\r\nДвигать через (WIN+SHIIFT+ >>) тоже не дает результатов. \r\nМожет есть идеи?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 500607380,
"datetime": 1560203207000,
"masked_author": "username_2",
"text": "I'm not sure, if you are working on this fixing of those bugs, but, I don't think that its necessary, since there is a way better alternative. On Moddb there is an excellent modification called _FarOut Widescreen_ _https://www.moddb.com/mods/farout-widescreen_ which is a way much better solution. It has Tent AI Fix, works with Silent Patch (which is even implemented in the exe) and it has letter boxing support as well, if you don't like a bit stretched menu.\r\n\r\nHere are some comparison screens made by the author of the modification: _https://www.moddb.com/mods/farout-widescreen/images/comparison-letterboxing#imagebox_",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 500706432,
"datetime": 1560234764000,
"masked_author": "username_1",
"text": "I'm not competing with anybody.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Marek33",
"comment_id": 500792996,
"datetime": 1560250949000,
"masked_author": "username_2",
"text": "I know and that's not a problem, but if someone else, want to use other solution, there is that option for them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 502377506,
"datetime": 1560613909000,
"masked_author": "username_0",
"text": "I think its nice, that probably username_1s work inspired that guy to make even more improved version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 502388882,
"datetime": 1560623086000,
"masked_author": "username_0",
"text": "Плюс мне кажется что последняя версия каким-то боком поломала дальность отрисовки.\r\nВверху какая-то промежуточная версия, которые ты делал правя ошибки из этой темы.\r\nВнизу, последнее что качается с сайта. \r\n[https://i.imgur.com/886AEMs.jpg](https://i.imgur.com/886AEMs.jpg)\r\n\r\n\r\nP.S. Был написал большой коммент тут https://thirteenag.github.io/wfp#comments но после того как отослал оно не сохранилось. Проблема у меня или из-за этого?\r\nError: utterances is not installed on username_1/WidescreenFixesPack \r\n(комменты когда-то работали, а потом отвалились/отключил?)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ThirteenAG",
"comment_id": 502389146,
"datetime": 1560623335000,
"masked_author": "username_1",
"text": "Да не знаю, мне честно говоря сейчас некогда этим заниматься.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r3538987",
"comment_id": 502389253,
"datetime": 1560623390000,
"masked_author": "username_0",
"text": "Хорошо, спасибо за быстрый ответ.",
"title": null,
"type": "comment"
}
] | 3 | 70 | 13,127 | false | false | 13,127 | true |
DemocracyClub/EveryElection | DemocracyClub | 364,536,908 | 413 | {
"number": 413,
"repo": "EveryElection",
"user_login": "DemocracyClub"
} | [
{
"action": "opened",
"author": "chris48s",
"comment_id": null,
"datetime": 1538062755000,
"masked_author": "username_0",
"text": "This sets our application default to inherit the target bucket's ACL and explicitly sets the ACL to public-read for election Document objects.\r\n\r\nCloses #410",
"title": "update ACL code for new django-storage behaviour",
"type": "issue"
}
] | 2 | 2 | 452 | false | true | 157 | false |
the-control-group/voyager | the-control-group | 339,777,658 | 3,387 | null | [
{
"action": "opened",
"author": "hamzataougar",
"comment_id": null,
"datetime": 1531217395000,
"masked_author": "username_0",
"text": "## Description\r\nLaravel 5.6 \r\nPHP 7.2 \r\nVotager 1.1 \r\n\r\nHey ,\r\nI got an issue while i create a new user in laravel voyager , it tells me that it s created and got a role , then right after once i want to connect with the credentials of the new user , it takes me to the index of my front-end .\r\n\r\nthis picture is for the user created :\r\n\r\n\r\nthe second one is what i get when i try to connect with the new user : \r\n\r\n \r\nif someone can help me i d thankful",
"title": "how to fix new users authentification",
"type": "issue"
},
{
"action": "created",
"author": "emptynick",
"comment_id": 403772310,
"datetime": 1531217551000,
"masked_author": "username_1",
"text": "Does the test-role have the `browse_admin` permission which is required to `browse admin`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hamzataougar",
"comment_id": 403773467,
"datetime": 1531217820000,
"masked_author": "username_0",
"text": "I guess that was the issue , how dumb ! \r\nthaank you a lot man",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hamzataougar",
"comment_id": null,
"datetime": 1531217820000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 995 | false | true | 826 | false |
apel/apel | apel | 199,850,415 | 118 | null | [
{
"action": "opened",
"author": "gregcorbett",
"comment_id": null,
"datetime": 1484061902000,
"masked_author": "username_0",
"text": "The UpdateTime of the JobRecords table is not set when messages are loaded.\r\n\r\nThis is because it is defined in `schemas/server.sql` as `UpdateTime TIMESTAMP`.\r\n\r\nWhen deployed from scratch it defaults to `UpdateTime TIMESTAMP NULL DEFAULT NULL`.\r\n\r\nAs such it not set when the Record gets created/updated\r\n\r\nIt should be set to something like: `UpdateTime TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP`",
"title": "UpdateTime in JobRecords is never set ",
"type": "issue"
},
{
"action": "closed",
"author": "tofu-rocketry",
"comment_id": null,
"datetime": 1490027505000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 430 | false | false | 430 | false |
mozilla/global-sprint | mozilla | 305,677,813 | 165 | null | [
{
"action": "opened",
"author": "mbonsma",
"comment_id": null,
"datetime": 1521139886000,
"masked_author": "username_0",
"text": "<!--- Keep everything below and click 'Submit new issue' --->\r\n\r\n**[ Project Contact ]** @username_0\r\n**[ GitHub Repo ]** https://github.com/phageParser/phageParser\r\n**[ Track ]** Openness, \r\n**[ Location ]** Toronto, Ontario (ET)\r\n\r\n### Description\r\nA project to extract CRISPR information from open genetic data.\r\n***\r\n\r\n## Want to contribute to this project during #mozsprint?\r\nJoin us at the Global Sprint, May 10-11. Leave a comment below if you're interested in contributing to this project during #mozsprint 2018!\r\n\r\n***\r\n\r\n## Note to the Project Lead :tada:\r\nCongrats, @username_0! This is your official project listing for the Mozilla Global Sprint 2018. To confirm your registration, please complete and check off the following:\r\n\r\n- [ ] Complete [Open Leadership 101](https://mozilla.teachable.com/p/open-leadership-101)\r\n- [ ] Provide a GitHub repository for work and discussion on your project in a comment\r\n - new to GitHub? Here's a [step-by-step guide on using the #mozsprint template](https://mozilla.github.io/global-sprint/project-lead-guide/templates/)\r\n- [ ] Create a README file in your project repository. This file should help newcomers understand what your project is, why it's important, and kinds of help you're looking for.\r\n- [ ] [Create file: LICENSE](http://choosealicense.com/) to give your project an open license, allowing for sharing and remixing.\r\n- [ ] Turn on your [Issue Tracker](https://mozilla.github.io/global-sprint/project-lead-guide/templates/#4-create-issues) and create at least three issues to describe each task that you need help with and how a contributor can get started on that task.\r\n- [ ] [Create a label](https://mozilla.github.io/global-sprint/project-lead-guide/templates/#5-add-a-mozsprint-label) called `mozsprint` and apply it to your issues.\r\n\r\n#### Checklist for FEATURED Projects :clipboard:\r\nTo have your project FEATURED on [Mozilla Pulse](http://mozillapulse.org/), complete the following documentation. In past Sprints, well-documented featured projects have 5 times more contributions than other projects. Details about each item and more information about how to create them are [on our Project Requirements Page](https://mozilla.github.io/global-sprint/project-lead-guide/project-requirements/).\r\n\r\n* [ ] In your README, link to the [Mozilla Community Participation Guidelines](https://www.mozilla.org/en-US/about/governance/policies/participation/) or write your own code of conduct.\r\n* [ ] Create file: CONTRIBUTING.md so others know how they can contribute. If you'd like, you can [remix this template](https://github.com/username_1/mozsprint-repo-template/blob/master/CONTRIBUTING.md)\r\n* [ ] [Fill out this form](https://www.mozillapulse.org/add) to submit your project to Mozilla Pulse. Add the tags `mozsprint` and `2018`.\r\n\r\nOnce all of the above is complete,\r\n- [ ] Leave a comment with the text `This is ready to be featured on Mozilla Pulse`. Your wrangler will review this issue and approve your project if everything looks good :balloon:\r\n\r\nIf you get stuck at any point, feel free to look at the [requirements page](https://mozilla.github.io/global-sprint/project-lead-guide/project-requirements/) and [project templates](https://mozilla.github.io/global-sprint/project-lead-guide/templates/). We're here to help you through this process.",
"title": "phageParser",
"type": "issue"
},
{
"action": "created",
"author": "acabunoc",
"comment_id": 376355074,
"datetime": 1522110328000,
"masked_author": "username_1",
"text": "Hi @username_0 ,\r\n\r\n@username_2 & @fimakeswork will be your Project Coach for the Sprint! They will review this issue and approve your entry on Mozilla Pulse if everything looks good 🎉",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 377206267,
"datetime": 1522322950000,
"masked_author": "username_2",
"text": "Hi @username_0,\r\n\r\nI've just a read through of your project documents and it seems really interesting.\r\nDo you currently have a project canvas? - when I clicked on the link it returned a 404 error.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbonsma",
"comment_id": 377232795,
"datetime": 1522329652000,
"masked_author": "username_0",
"text": "@username_2, good catch! The link was broken when we moved some folders around, I fixed it in the README. (https://github.com/phageParser/phageParser/blob/master/documentation/Open_canvas.png)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 377908001,
"datetime": 1522667140000,
"masked_author": "username_2",
"text": "Nice, clear canvas. Also, a really good read me. Just a couple more things to check off then I think you're good to be featured.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 379465046,
"datetime": 1523103249000,
"masked_author": "username_2",
"text": "Hi @username_0, how are you getting on?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbonsma",
"comment_id": 379801509,
"datetime": 1523289309000,
"masked_author": "username_0",
"text": "Hi @username_2, thanks for the check-in! I still need to go through the issues and make / edit some for the sprint, and I'm leaving Open Leadership 101 unchecked as a reminder to go through it again. I hope to be done all the checklist things in the next 1-2 weeks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 380226739,
"datetime": 1523390136000,
"masked_author": "username_2",
"text": "Hi @username_0, thanks for the update.\r\nPlease let me know if you need a hand with anything.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 382513763,
"datetime": 1524082290000,
"masked_author": "username_2",
"text": "hi @username_0 , how's it going?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbonsma",
"comment_id": 385534969,
"datetime": 1525123855000,
"masked_author": "username_0",
"text": "This is ready to be featured on Mozilla Pulse! I'll be adding / modifying more issues before next week, but I have a few ready for the sprint.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quirksahern",
"comment_id": 386563717,
"datetime": 1525430299000,
"masked_author": "username_2",
"text": "Approved",
"title": null,
"type": "comment"
}
] | 3 | 11 | 4,584 | false | false | 4,584 | true |
govau/content-guide | govau | 208,332,101 | 33 | null | [
{
"action": "opened",
"author": "joolswood",
"comment_id": null,
"datetime": 1487305453000,
"masked_author": "username_0",
"text": "## What do you need?\r\n\r\nhttps://github.com/AusDTO/gov-au-content-guide/issues/217",
"title": "Check we are using sign-in not log-in",
"type": "issue"
},
{
"action": "created",
"author": "joolswood",
"comment_id": 283860301,
"datetime": 1488514107000,
"masked_author": "username_0",
"text": "Include background from Slack https://ausdto.slack.com/archives/content-design/p1488511657001282",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joolswood",
"comment_id": 286306230,
"datetime": 1489459711000,
"masked_author": "username_0",
"text": "Added this via https://github.com/govau/content-guide/commit/5b47d23e89df567dfbf46f4205b788c3a50c1bcb",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joolswood",
"comment_id": 286956277,
"datetime": 1489639246000,
"masked_author": "username_0",
"text": "Please can you review @username_1 ?\r\n\r\n```\r\nSign in versus log in\r\n\r\nConsider using ‘sign in’ and ‘sign out’ (note, no hyphen) instead of ‘log in’ or ‘log out’ in text, links and buttons.\r\n\r\n‘Sign in’ seems to becoming a more recognisable call to action than ‘log in’. But you should test this with the user.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "libbyv",
"comment_id": 286983889,
"datetime": 1489651238000,
"masked_author": "username_1",
"text": "Yes, fine for now thx. Missing 1 ' before 'log in'",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joolswood",
"comment_id": 287222699,
"datetime": 1489706727000,
"masked_author": "username_0",
"text": "Can't see this? @username_1 \r\n\r\nI'll add in a `be` though (as in `be becoming`).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "joolswood",
"comment_id": null,
"datetime": 1489988921000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 713 | false | false | 713 | true |
spark-jobserver/spark-jobserver | spark-jobserver | 118,929,692 | 324 | {
"number": 324,
"repo": "spark-jobserver",
"user_login": "spark-jobserver"
} | [
{
"action": "opened",
"author": "apivovarov",
"comment_id": null,
"datetime": 1448488226000,
"masked_author": "username_0",
"text": "It's follow up commit for the previous commit to update spark version to 1.5.2",
"title": "Replace spark 1.5.0 with 1.5.2 in all configs and docs",
"type": "issue"
},
{
"action": "created",
"author": "velvia",
"comment_id": 159769076,
"datetime": 1448499273000,
"masked_author": "username_1",
"text": "@username_0 ah thanks, just in time.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "apivovarov",
"comment_id": 159807789,
"datetime": 1448514479000,
"masked_author": "username_0",
"text": "Can it be included to v.0.6.1?",
"title": null,
"type": "comment"
}
] | 2 | 3 | 144 | false | false | 144 | true |
markormesher/android-fab | null | 352,449,672 | 37 | null | [
{
"action": "opened",
"author": "Yakow13",
"comment_id": null,
"datetime": 1534842422000,
"masked_author": "username_0",
"text": "When using padding for FAB component, to trim its position in layout, after expanding the content cover, it's not filling the whole area. I'm not sure if this is bug, or expected behavior.\r\n\r\nFor more info, check the screenshot. The area on left is covered, the area on right is not. FAB is in the layout which is covering whole screen\r\n\r\n",
"title": "Content cover and padding/margin",
"type": "issue"
},
{
"action": "created",
"author": "Yakow13",
"comment_id": 415360416,
"datetime": 1535018203000,
"masked_author": "username_0",
"text": "I'm working with newest version, v2.3.1. \r\n\r\nHere is screenshot how does it looks like with following parameters:\r\nandroid:layout_width=\"match_parent\"\r\nandroid:layout_height=\"match_parent\"\r\nandroid:paddingEnd=\"630dp\"\r\n\r\nAm I doing something wrong, or content cover is not designed to work with padding?\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Yakow13",
"comment_id": 415424849,
"datetime": 1535032930000,
"masked_author": "username_0",
"text": "Unfortunately, usage of margin instead of padding, doesn't make any different. \r\n\r\nThanks for your time :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "markormesher",
"comment_id": 415813555,
"datetime": 1535128577000,
"masked_author": "username_1",
"text": "What we need here is to have the FAB container still take up the full width/height of the layout (to allow the content cover to use the whole screen) and specify an internal offset to push the FAB, speed-dial and content-cover around _within_ the bounds of the container.\r\n\r\nIf it's urgent you could do this yourself by accessing the individual views (https://github.com/username_1/android-fab#access-to-underlying-views) and programatically moving them, but the better option is to actually implement that internal offset in the library itself. I'll take a stab at that this weekend!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "markormesher",
"comment_id": null,
"datetime": 1535907849000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "markormesher",
"comment_id": 417944671,
"datetime": 1535907849000,
"masked_author": "username_1",
"text": "Hey @username_0. This should be possible now in v2.4.1 - you can set an internal offset from any of the four edges, so in your case you'd set `internalOffsetEnd` to be the width of the area that isn't getting covered in the screen shots above (you can do this from code or XML). The internal offset is _added_ to the default offset, so it will appear slightly inset into the left-side area (as it does right now), rather than being right on the line between them. It's implemented this way for exactly this use case, because I think that'll be the most common usage of the feature. LMK how you get on with the update version; I'll close this for now but feel free to re-open if necessary.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 2,287 | false | false | 2,287 | true |
knockout/knockout | knockout | 249,828,911 | 2,281 | null | [
{
"action": "opened",
"author": "fastfasterfastest",
"comment_id": null,
"datetime": 1502563808000,
"masked_author": "username_0",
"text": "There is a bug with the `textInput` binding when used with a textarea element under the following conditions:\r\n- html5 mode\r\n- value contains `U+000D CARRIAGE RETURN` characters\r\n\r\nThen, the `textInput` binding will update the (model) value even though the user did not change the text in the textarea element.\r\n\r\nIn this fiddle http://jsfiddle.net/username_0/938r0k13/, just tabbing through the textarea causes the model value to be updated (alternatively, click in the textarea and then click outside the textarea).\r\n\r\nThe `textInput` binding implementation currently assumes that setting the textarea element's value will return that same value when later getting the textarea element's value. However, that is not the case in html5 if the value contains `CR` characters. In html5, the value returned by `element.value` is normalized and `CR` characters are transformed, see http://www.w3.org/TR/html5/forms.html#the-textarea-element, and thus one can not assume that one gets the same value that was set.\r\n```\r\nelement.value = someValue;\r\nsomeValue === element.value;\t//not neccessarily true in html5\r\n```\r\n\r\nTo trigger the bug you have to trigger some event that causes `textInput`'s internal `updateModel` function to be called. That may not be easy in 3.4.2 but in the \"latest\"/pre-3.5.0 build it is easily done by triggering a `blur` event (the fiddle referenced above uses a pre-3.5.0 build that @username_1 made available a while ago).\r\n`textInput` binding's handling of the `blur` event was added by https://github.com/knockout/knockout/commit/11e3cb93671b69b0fb26239ad4f2d2f75d6c6cc3\r\n\r\nNote, the same issue may apply for the value binding as well, although it is not as easily exposed or triggered.\r\n\r\nLooking at the sources, textInput.js, I think a fix could look something like:\r\n```\r\nvar isHtml5 = true; //[some test]\r\nvar transformModelValueForComparisonWithElementValue = isHtml5 && (ko.utils.tagNameLower(element) === \"textarea\") ?\r\n function (modelValue) { return (modelValue.indexOf(\"\\r\") !== -1) ? modelValue.replace(/(?:\\r\\n|\\r)/g, \"\\n\") : modelValue; } :\r\n function (modelValue) { return modelValue; };\r\n\r\nvar updateView = function () {\r\n var modelValue = ko.utils.unwrapObservable(valueAccessor()),\r\n modelValueTransformed;\r\n\r\n if (modelValue === null || modelValue === undefined) {\r\n modelValue = '';\r\n }\r\n\r\n //transform modelValue so it can be compared to element.value\r\n modelValueTransformed = transformModelValueForComparisonWithElementValue(modelValue);\r\n\r\n if (elementValueBeforeEvent !== undefined && modelValueTransformed === elementValueBeforeEvent) {\r\n ko.utils.setTimeout(updateView, 4);\r\n return;\r\n }\r\n\r\n // Update the element only if the element and model are different. On some browsers, updating the value\r\n // will move the cursor to the end of the input, which would be bad while the user is typing.\r\n if (element.value !== modelValueTransformed) {\r\n previousElementValue = modelValueTransformed; // Make sure we ignore events (propertychange) that result from updating the value\r\n element.value = modelValue;\r\n }\r\n};",
"title": "textInput binding bug with textarea",
"type": "issue"
},
{
"action": "created",
"author": "mbest",
"comment_id": 322289577,
"datetime": 1502739961000,
"masked_author": "username_1",
"text": "Would this fix it? Change\r\n\r\n```\r\n if (element.value !== modelValue) {\r\n previousElementValue = modelValue; // Make sure we ignore events (propertychange) that result from updating the value\r\n element.value = modelValue;\r\n }\r\n```\r\n\r\nto\r\n\r\n```\r\n if (element.value !== modelValue) {\r\n previousElementValue = modelValue; // Make sure we ignore events (propertychange) that result from updating the value\r\n element.value = modelValue;\r\n previousElementValue = element.value; // In case the browser changes the value (see #2281)\r\n }\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brianmhunt",
"comment_id": 322293924,
"datetime": 1502741005000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fastfasterfastest",
"comment_id": 322296697,
"datetime": 1502741661000,
"masked_author": "username_0",
"text": "@username_1 I don't think so.\r\nFirst, the model value is compared to `elementValueBeforeEvent` before that as well.\r\nSecond, `previousElementValue` is compared to `element.value` in `updateModel` so it (`previousElementValue`) needs to be \"comparable\" to `element.value`, i.e. it needs to be the transformed value. If `previousElementValue` is set to the untransformed model value as you suggest, then the comparison in `updateModel` will fail when it should succeed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mbest",
"comment_id": null,
"datetime": 1507001370000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mbest",
"comment_id": 333728847,
"datetime": 1507001423000,
"masked_author": "username_1",
"text": "My method appears to work fine. Let me know if you notice otherwise.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fastfasterfastest",
"comment_id": 333949557,
"datetime": 1507058341000,
"masked_author": "username_0",
"text": "It's been a while... but if all stars are aligned then your method may work.\r\n\r\nRegarding my first point: in the code of your method there is a comparison between an untransformed value and a transformed value (`modelValue === elementValueBeforeEvent`). If that comparison does happen it will fail when it should succeed, but it is unclear if that comparison will/can actually take place or not without changing the text in the element.\r\n\r\nThe second point I made, it's been a while but, appears to be invalid. `previousElementValue` is set to a transformed value and can thus be compared with `element.value`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbest",
"comment_id": 334018418,
"datetime": 1507077369000,
"masked_author": "username_1",
"text": "I don't think the `elementValueBeforeEvent` check will be affected. For more info on why that exists, see #1334.",
"title": null,
"type": "comment"
}
] | 3 | 8 | 5,056 | false | false | 5,056 | true |
haraldk/TwelveMonkeys | null | 304,417,266 | 412 | null | [
{
"action": "opened",
"author": "davidOua",
"comment_id": null,
"datetime": 1520868138000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nI write a TIFF multi image without problem and I can add some metadata as \"software\" or \"data time\".\r\n\r\nBut I can't add Exposure time for example with a same way:\r\n`IIOMetadata metadata = new TIFFImageMetadata(Collections.<Entry>emptySet());\r\n\r\nString tiffNativeFormat = TIFFMedataFormat.SUN_NATIVE_IMAGE_METADATA_FORMAT_NAME;\r\nIIOMetadataNode tiffRoot = new IIOMetadataNode(tiffNativeFormat);\r\n\r\nIIOMetadataNode tiffIfdNode = new IIOMetadataNode(\"TIFFIFD\");\r\ntiffRoot.appendChild(tiffIfdNode);\r\n\r\ncreateTIFFFieldNode(tiffIfdNode, TIFF.TAG_SOFTWARE, TIFF.TYPE_ASCII, \"LFM 1.0\");\r\ncreateTIFFFieldNode(tiffIfdNode, TIFF.TAG_DATE_TIME, TIFF.TYPE_ASCII, strDate);\r\n\r\nIIOMetadataNode exifIfdNode = new IIOMetadataNode(\"TIFFIFD\");\r\nexifIfdNode.setAttribute(\"parentTagNumber\", String.valueOf(TIFF.TAG_EXIF_IFD));\r\ntiffIfdNode.appendChild(exifIfdNode);\r\n\r\ncreateTIFFFieldNode(exifIfdNode, EXIF.TAG_DATE_TIME_DIGITIZED, TIFF.TYPE_ASCII, strDate);\r\ncreateTIFFFieldNode(exifIfdNode, EXIF.TAG_EXPOSURE_TIME, TIFF.TYPE_RATIONAL, ((int)image.getExposureTime()) + \"/1000\");\r\n\r\nmetadata.setFromTree(tiffNativeFormat, tiffRoot);`\r\n\r\nTo try to understand, I add exposure time information with exif tool and after I read the metadata and that's what I tried to do in my code without success.\r\n\r\nWhere is my mistake?\r\n\r\nBest regards.",
"title": "How to add exposure time into TIFF multi images",
"type": "issue"
},
{
"action": "created",
"author": "haraldk",
"comment_id": 372438338,
"datetime": 1520883734000,
"masked_author": "username_1",
"text": "Hi David,\r\n\r\nI think your code is sound.\r\n\r\nUnfortunately, only a subset of the TIFF tags are currently copied from the provided metadata into the TIFF structure. These are:\r\n\r\n TIFF.TAG_COMPRESSION * (if compatible, and unless overridden in ImageWriteParam)\r\n TIFF.TAG_ORIENTATION,\r\n TIFF.TAG_DATE_TIME,\r\n TIFF.TAG_DOCUMENT_NAME,\r\n TIFF.TAG_IMAGE_DESCRIPTION,\r\n TIFF.TAG_MAKE,\r\n TIFF.TAG_MODEL,\r\n TIFF.TAG_PAGE_NAME,\r\n TIFF.TAG_PAGE_NUMBER,\r\n TIFF.TAG_ARTIST,\r\n TIFF.TAG_HOST_COMPUTER,\r\n TIFF.TAG_COPYRIGHT,\r\n TIFF.TAG_SOFTWARE *,\r\n TIFF.TAG_X_RESOLUTION *,\r\n TIFF.TAG_Y_RESOLUTION *,\r\n TIFF.TAG_RESOLUTION_UNIT *\r\n\r\n*) Will be filled with defaults, if left unspecified. \r\n\r\nIf time permits, all metadata specified will make it to the TIFF structure in future, but it's unlikely that it happens before 3.5 (unless someone have some spare time for me).\r\n\r\n\r\nBest regards,\r\n\r\n-- \r\nHarald K",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidOua",
"comment_id": 372480932,
"datetime": 1520892935000,
"masked_author": "username_0",
"text": "Spare time, maybe not but why give a hand on this problem in particular, why not.\r\n\r\nAnyway, thanks for your quick reply.\r\n\r\nDO",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "haraldk",
"comment_id": 577395088,
"datetime": 1579728640000,
"masked_author": "username_1",
"text": "Should be fixed now, as part of #490",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "haraldk",
"comment_id": null,
"datetime": 1579728642000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 2,611 | false | false | 2,611 | false |
Azure-Samples/azure-sdk-for-go-samples | Azure-Samples | 297,243,159 | 121 | null | [
{
"action": "opened",
"author": "joshgav",
"comment_id": null,
"datetime": 1518641958000,
"masked_author": "username_0",
"text": "cc @username_1",
"title": "rename cosmos -> cosmosdb",
"type": "issue"
},
{
"action": "created",
"author": "kanshiG",
"comment_id": 365834487,
"datetime": 1518674903000,
"masked_author": "username_1",
"text": "Thanks !",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "joshgav",
"comment_id": null,
"datetime": 1529525173000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 19 | false | false | 19 | true |
GoogleCloudPlatform/google-cloud-eclipse | GoogleCloudPlatform | 297,221,146 | 2,807 | {
"number": 2807,
"repo": "google-cloud-eclipse",
"user_login": "GoogleCloudPlatform"
} | [
{
"action": "opened",
"author": "elharo",
"comment_id": null,
"datetime": 1518637404000,
"masked_author": "username_0",
"text": "@username_1 Fix #2791 \r\n\r\nThis may be only an interim step until we add a version chooser, but let me know what you think:\r\n\r\n",
"title": "Expose version in preferences",
"type": "issue"
},
{
"action": "created",
"author": "briandealwis",
"comment_id": 365729489,
"datetime": 1518638886000,
"masked_author": "username_1",
"text": "Looks useful! The label should be outdented so that it doesn't look like it's specific to the local SDK.\r\n\r\nThe version doesn't update to the right value if I launch with `GOOGLE_CLOUD_SDK_HOME` set to a valid installation. The update code needs to run on initialization and on any change. The code has become rather hard to understand.\r\n<img width=\"386\" alt=\"screen shot 2018-02-14 at 3 03 50 pm\" src=\"https://user-images.githubusercontent.com/202851/36225321-4f414276-1198-11e8-815f-bb9994aef2cd.PNG\">",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elharo",
"comment_id": 365732513,
"datetime": 1518639557000,
"masked_author": "username_0",
"text": "What do you think about moving the version above the Use Local SDK checkbox?\r\nOr perhaps they should all be left-aligned since the SDK location textfield is used for both managed and non-managed SDK?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "briandealwis",
"comment_id": 365733113,
"datetime": 1518639688000,
"masked_author": "username_1",
"text": "Moving it above is a good idea. The SDK Location is really only used for the non-managed SDK.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elharo",
"comment_id": 366072463,
"datetime": 1518731263000,
"masked_author": "username_0",
"text": "PTAL @username_1",
"title": null,
"type": "comment"
}
] | 3 | 6 | 1,054 | false | true | 1,054 | true |
ligato/cn-infra | ligato | 263,101,679 | 193 | {
"number": 193,
"repo": "cn-infra",
"user_login": "ligato"
} | [
{
"action": "opened",
"author": "jozef-slezak",
"comment_id": null,
"datetime": 1507205364000,
"masked_author": "username_0",
"text": "",
"title": "ODPM-633 fix grpc plugin Stop(), etcd plugim FromExistingConnection",
"type": "issue"
}
] | 2 | 2 | 228 | false | true | 0 | false |
IBM/carbon-components | IBM | 372,602,824 | 1,313 | null | [
{
"action": "opened",
"author": "alisonjoseph",
"comment_id": null,
"datetime": 1540226972000,
"masked_author": "username_0",
"text": "Related to https://github.com/IBM/carbon-components-react/issues/1471\r\n\r\nChoose NumberInput\r\nmanually enter 16.67\r\nclick down arrow/decrement\r\nNumberInput displays 15.670000000000002",
"title": "Floating point issue in NumberInput ",
"type": "issue"
},
{
"action": "closed",
"author": "alisonjoseph",
"comment_id": null,
"datetime": 1540244069000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "alisonjoseph",
"comment_id": 431996820,
"datetime": 1540244083000,
"masked_author": "username_0",
"text": "closing as wont fix",
"title": null,
"type": "comment"
}
] | 1 | 3 | 201 | false | false | 201 | false |
goreleaser/goreleaser | goreleaser | 267,020,900 | 407 | {
"number": 407,
"repo": "goreleaser",
"user_login": "goreleaser"
} | [
{
"action": "opened",
"author": "caarlos0",
"comment_id": null,
"datetime": 1508455909000,
"masked_author": "username_0",
"text": "FPM would randomly fail to build deb and rpm packages. It apparently\r\nhappens because fpm (or some tool it uses) shares state between runs\r\n(possibly by overriding files that are going inside the archive).\r\n\r\nThe error `file changed as we read it` was happening, which is a `tar`\r\nerror.\r\n\r\nI don't know how to fix this, but, in order to make goreleaser more\r\nstable, I'll disable the concurrency here for now.\r\n\r\ncloses #333\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] `make ci` passes on my machine.",
"title": "fix: fpm fails randomly",
"type": "issue"
}
] | 3 | 3 | 853 | false | true | 698 | false |
jam1garner/Smash-Forge | null | 284,451,062 | 128 | null | [
{
"action": "opened",
"author": "TabuuForteAkugun",
"comment_id": null,
"datetime": 1514211885000,
"masked_author": "username_0",
"text": "Okay so I'm working on my Flinching Giga Bowser mod, and I am trying to continue importing edited versions of his PM animations for damage and stuff. I follow the BB2Maya method, and when I import the resulting .anim file into Forge, it import just fine except that it's missing one frame, the final one. Like, I have a 29 frame .omo from a 30 frame .anim\r\n\r\nI'm using the absolute latest commit.\r\n\r\nThanks.",
"title": "Last animation frame doesn't import.",
"type": "issue"
}
] | 1 | 1 | 407 | false | false | 407 | false |
f5devcentral/f5-sphinx-theme | f5devcentral | 319,249,836 | 75 | null | [
{
"action": "opened",
"author": "jputrino",
"comment_id": null,
"datetime": 1525192266000,
"masked_author": "username_0",
"text": "## Version\r\nall\r\n\r\n## Description\r\nWe need to move beyond the basic html/css checks we currently have and incorporate unit/functional tests. \r\n\r\nSee other open source [sphinx themes](https://sphinx-themes.org/) for guidance.\r\n\r\nTools:\r\n- [pytest](https://docs.pytest.org/en/latest/index.html)\r\n-",
"title": "Add Tests",
"type": "issue"
}
] | 1 | 1 | 295 | false | false | 295 | false |
ansible/community | ansible | 385,399,715 | 414 | {
"number": 414,
"repo": "community",
"user_login": "ansible"
} | [
{
"action": "opened",
"author": "jamescassell",
"comment_id": null,
"datetime": 1543429520000,
"masked_author": "username_0",
"text": "",
"title": "lockdown meeting: reference UTC rather than \"noon\"",
"type": "issue"
},
{
"action": "created",
"author": "jamescassell",
"comment_id": 442583785,
"datetime": 1543435079000,
"masked_author": "username_0",
"text": "Ok, didn't realize. I'm used to a policy of \"no generated files in git\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "willthames",
"comment_id": 442681682,
"datetime": 1543458098000,
"masked_author": "username_1",
"text": "And when you remove the time, remove the day too (as it's actually on Friday ;) )",
"title": null,
"type": "comment"
}
] | 2 | 3 | 152 | false | false | 152 | false |
GameFoundry/bsf | GameFoundry | 321,347,113 | 109 | {
"number": 109,
"repo": "bsf",
"user_login": "GameFoundry"
} | [
{
"action": "opened",
"author": "jonesmz",
"comment_id": null,
"datetime": 1525813598000,
"masked_author": "username_0",
"text": "… std::containers more easily",
"title": "Add all of the comparison operators to NativePtr so it can be used in…",
"type": "issue"
},
{
"action": "created",
"author": "BearishSun",
"comment_id": 387654612,
"datetime": 1525852605000,
"masked_author": "username_1",
"text": "Thanks, merged.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 44 | false | false | 44 | false |
kubernetes/kubernetes | kubernetes | 125,662,184 | 19,417 | null | [
{
"action": "opened",
"author": "bprashanth",
"comment_id": null,
"datetime": 1452276294000,
"masked_author": "username_0",
"text": "With the following stack trace (http://kubekins.dls.corp.google.com:8081/job/kubernetes-pull-build-test-e2e-gce/22564/testReport/junit/(root)/Kubernetes%20e2e%20suite/Deployment_deployment_should_support_rollover/):\r\n```\r\n--- PASS: TestForwardPorts (0.25s)\r\n=== RUN TestForwardPortsReturnsErrorWhenAllBindsFailed\r\nI0106 18:11:12.600619 7226 portforward.go:213] Forwarding from 127.0.0.1:5555 -> 5555\r\nI0106 18:11:12.601000 7226 portforward.go:213] Forwarding from [::1]:5555 -> 5555\r\nE0106 18:11:12.611874 7226 portforward.go:202] Unable to create listener: Error listen tcp4 127.0.0.1:5555: bind: address already in use\r\nE0106 18:11:12.612074 7226 portforward.go:202] Unable to create listener: Error listen tcp6 [::1]:5555: bind: address already in use\r\nW0106 18:11:12.612177 7226 portforward.go:154] Unable to listen on port 5555: All listeners failed to create with the following errors: listen tcp4 127.0.0.1:5555: bind: address already in use, listen tcp6 [::1]:5555: bind: address already in use\r\npanic: test timed out after 5m0s\r\n\r\ngoroutine 190 [running]:\r\ntesting.startAlarm.func1()\r\n\t/tmp/workdir/go/src/testing/testing.go:703 +0x16b\r\ncreated by time.goFunc\r\n\t/tmp/workdir/go/src/time/sleep.go:129 +0x6e\r\n\r\ngoroutine 1 [chan receive, 4 minutes]:\r\ntesting.RunTests(0x17f40a0, 0x1e31bc0, 0x4, 0x4, 0xc820257901)\r\n\t/tmp/workdir/go/src/testing/testing.go:562 +0xafa\r\ntesting.(*M).Run(0xc820648f10, 0x4861bf)\r\n\t/tmp/workdir/go/src/testing/testing.go:494 +0xe5\r\nmain.main()\r\n\tk8s.io/kubernetes/pkg/client/unversioned/portforward/_test/_testmain.go:60 +0x210\r\n\r\ngoroutine 17 [syscall, 4 minutes, locked to thread]:\r\nruntime.goexit()\r\n\t/tmp/workdir/go/src/runtime/asm_amd64.s:1721 +0x1\r\n\r\ngoroutine 5 [chan receive]:\r\ngithub.com/golang/glog.(*loggingT).flushDaemon(0x1e52d60)\r\n\t/workspace/kubernetes/Godeps/_workspace/src/github.com/golang/glog/glog.go:879 +0x8c\r\ncreated by github.com/golang/glog.init.1\r\n\t/workspace/kubernetes/Godeps/_workspace/src/github.com/golang/glog/glog.go:410 +0x2ba\r\n\r\ngoroutine 106 [chan send, 4 minutes]:\r\nk8s.io/kubernetes/pkg/util/httpstream/spdy.(*connection).SetIdleTimeout(0xc82013c300, 0x0)\r\n\t/workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/httpstream/spdy/connection.go:138 +0x9b\r\nk8s.io/kubernetes/pkg/kubelet/server.ServePortForward(0x7fa9a070d710, 0xc820208580, 0xc8202de000, 0x7fa9a070d748, 0xc8202ce220, 0x1598378, 0x3, 0x1599e40, 0x3, 0x0, ...)\r\n\t/workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/server/server.go:796 +0x4b6\r\nk8s.io/kubernetes/pkg/client/unversioned/portforward.fakePortForwardServer.func1(0x7fa9a070d710, 0xc820208580, 0xc8202de000)\r\n\t/workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/unversioned/portforward/portforward_test.go:253 +0x265\r\nnet/http.HandlerFunc.ServeHTTP(0xc8202566f0, 0x7fa9a070d710, 0xc820208580, 0xc8202de000)\r\n\t/tmp/workdir/go/src/net/http/server.go:1422 +0x48\r\nnet/http/httptest.(*waitGroupHandler).ServeHTTP(0xc820134260, 0x7fa9a070d710, 0xc820208580, 0xc8202de000)\r\n\t/tmp/workdir/go/src/net/http/httptest/server.go:200 +0xff\r\nnet/http.serverHandler.ServeHTTP(0xc8200e41e0, 0x7fa9a070d710, 0xc820208580, 0xc8202de000)\r\n\t/tmp/workdir/go/src/net/http/server.go:1862 +0x207\r\nnet/http.(*conn).serve(0xc8202084d0)\r\n\t/tmp/workdir/go/src/net/http/server.go:1361 +0x117d\r\ncreated by net/http.(*Server).Serve\r\n\t/tmp/workdir/go/src/net/http/server.go:1910 +0x465\r\n\r\ngoroutine 155 [semacquire, 4 minutes]:\r\nsync.runtime_Semacquire(0xc8202ec13c)\r\n\t/tmp/workdir/go/src/runtime/sema.go:43 +0x26\r\nsync.(*WaitGroup).Wait(0xc8202ec130)\r\n\t/tmp/workdir/go/src/sync/waitgroup.go:126 +0x118\r\nnet/http/httptest.(*Server).Close(0xc8202ec100)\r\n\t/tmp/workdir/go/src/net/http/httptest/server.go:168 +0x81\r\nk8s.io/kubernetes/pkg/client/unversioned/portforward.TestForwardPortsReturnsErrorWhenAllBindsFailed(0xc8201a0000)\r\n\t/workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/unversioned/portforward/portforward_test.go:393 +0x8dc\r\ntesting.tRunner(0xc8201a0000, 0x1e31c08)\r\n\t/tmp/workdir/go/src/testing/testing.go:456 +0xdd\r\ncreated by testing.RunTests\r\n\t/tmp/workdir/go/src/testing/testing.go:561 +0xaa4\r\n\r\ngoroutine 126 [chan send, 4 minutes]:\r\ngithub.com/docker/spdystream.(*Connection).shutdown(0xc820208420, 0x0)\r\n\t/workspace/kubernetes/Godeps/_workspace/src/github.com/docker/spdystream/connection.go:700 +0x335\r\ncreated by github.com/docker/spdystream.(*Connection).handleGoAwayFrame\r\n\t/workspace/kubernetes/Godeps/_workspace/src/github.com/docker/spdystream/connection.go:600 +0x24f\r\nFAIL\tk8s.io/kubernetes/pkg/client/unversioned/portforward\t300.212s\r\n```\r\n\r\n@username_1",
"title": "TestForwardPortsReturnsErrorWhenAllBindsFailed panics instead of returning error",
"type": "issue"
},
{
"action": "created",
"author": "ncdc",
"comment_id": 170089701,
"datetime": 1452279181000,
"masked_author": "username_1",
"text": "This is the same root cause as #19230",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bprashanth",
"comment_id": null,
"datetime": 1452281259000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 4,671 | false | false | 4,671 | true |
Microsoft/visualfsharp | Microsoft | 228,867,830 | 3,056 | null | [
{
"action": "opened",
"author": "TeaDrivenDev",
"comment_id": null,
"datetime": 1494888433000,
"masked_author": "username_0",
"text": "#### Repro steps\r\n\r\nProvide the steps required to reproduce the problem\r\n\r\n1. Create a `let` binding in F# code, leave the value unused\r\n2. Hover over the name with the mouse pointer\r\n\r\n#### Expected behavior\r\n\r\nThe Tooltip displays type information for the value.\r\n\r\n\r\n\r\n#### Actual behavior\r\n\r\nThe tooltip only says \"The value is unused - Show potential fixes\".\r\n\r\n\r\n\r\n#### Known workarounds\r\n\r\nSet the caret on the name, press Ctrl-K, Ctrl-I\r\n\r\n#### Related information \r\n\r\nVFT version 15.4.1.17051503",
"title": "\"The value is unused\" tooltip hides type information",
"type": "issue"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 301673831,
"datetime": 1494909741000,
"masked_author": "username_1",
"text": "@username_2 it seems tooltips are broken even in master :( @username_0 can you say in what version you saw this bug first time?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 301868752,
"datetime": 1494958408000,
"masked_author": "username_2",
"text": "I can't reproduce this on master :|\r\nI'm downloading 1503 and will try.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 301872779,
"datetime": 1494959279000,
"masked_author": "username_2",
"text": "Can't reproduce on 1503 either. @username_0 is this occurring randomly?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 301878779,
"datetime": 1494960595000,
"masked_author": "username_2",
"text": "Current master:\r\n\r\n\r\n\r\nAs can be seen, Visual Studio puts the tooltip together from various sources asynchronously. Various parts show up independently and shouldn't interfere.\r\nIf for example `getTooltipFromRange` fails or `GetItemAsync` is very late, the displayed result could be exactly as in this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 301891142,
"datetime": 1494963176000,
"masked_author": "username_0",
"text": "@username_2 No, it's consistent. I don't remember ever seeing it work as in your screenshot. The type information never shows up, even on small self-contained scripts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 301895784,
"datetime": 1494964285000,
"masked_author": "username_0",
"text": "I just checked on my other machine, and it appears to work fine there (VS 2017 Community with 17051401). It doesn't work at all on this one (VS 2017 Professional); I also suspended ReSharper (just to be sure), but that didn't change anything.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 301900109,
"datetime": 1494965285000,
"masked_author": "username_2",
"text": "@username_0 thanks for the follow-up. This is mysterious. I can't think of anything that would break this between 514 and 515.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 301908328,
"datetime": 1494967102000,
"masked_author": "username_0",
"text": "@username_2 It doesn't seem to be related to the versions; it still works fine on the other machine with 1604. So there appears to be something on that one system that prevents the tooltip from being updated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 301910854,
"datetime": 1494967659000,
"masked_author": "username_2",
"text": "@username_0 this bug happens on a particular configuration, and only when triggered with the mouse, not the keyboard, and only when there is also a \"unused value\" hint?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 301918452,
"datetime": 1494969471000,
"masked_author": "username_0",
"text": "@username_2 Yes, exactly. The system in question has now updated to 1604 as well and still shows that behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "majocha",
"comment_id": 302004108,
"datetime": 1495004585000,
"masked_author": "username_2",
"text": "Thanks, this gives me some ideas about what to look into.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 320415599,
"datetime": 1501913161000,
"masked_author": "username_3",
"text": "@username_0 Can you still reproduce this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 320443757,
"datetime": 1501939751000,
"masked_author": "username_0",
"text": "@username_3 Yes, consistently on one machine, never on the other.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 320450883,
"datetime": 1501948011000,
"masked_author": "username_3",
"text": "Hmmm. Strange, because I haven't been able to reproduce this. One guess is that the VS install on the machine it repros on is bad. Have you reinstalled or repaired on that machine since seeing this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 320465632,
"datetime": 1501961495000,
"masked_author": "username_0",
"text": "I don't think I have with VS. I have likely un- and reinstalled the F# Tools several times in that time, though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 320467750,
"datetime": 1501963896000,
"masked_author": "username_3",
"text": "If you could try reinstalling VS on that machine, that would be great. Because this is only consistent on that machine and the F# tools have been uninstalled/reinstalled there, I suspect that something went funky on the install of VS itself.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Pilchie",
"comment_id": 320731248,
"datetime": 1502127794000,
"masked_author": "username_4",
"text": "Potentially a MEF ordering issue where one thing is shown on top of the other because the order is indeterminate, and usually we get lucky?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TeaDrivenDev",
"comment_id": 320828845,
"datetime": 1502157684000,
"masked_author": "username_0",
"text": "If there's anything I can do give you any kind of additional diagnostic information as \"patient zero\", let me know.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341057876,
"datetime": 1509530201000,
"masked_author": "username_5",
"text": "I have the same issue originally reported by @username_0, but the workaround does not work for me because Ctrl+K+I also shows the warning only. I can't find a way to make the type information show. I'm running the nightly. I've included the version information and the full VS info below. \r\n\r\n\r\n\r\n\r\n<details>\r\n<summary>Full VS Version Details</summary>\r\nMicrosoft Visual Studio Professional 2017 \r\nVersion 15.4.2\r\nVisualStudio.15.Release/15.4.2+27004.2006\r\nMicrosoft .NET Framework\r\nVersion 4.6.01590\r\n\r\nInstalled Version: Professional\r\n\r\nVisual Basic 2017 00369-60000-00001-AA768\r\nMicrosoft Visual Basic 2017\r\n\r\nVisual C# 2017 00369-60000-00001-AA768\r\nMicrosoft Visual C# 2017\r\n\r\nVisual F# 4.1 00369-60000-00001-AA768\r\nMicrosoft Visual F# 4.1\r\n\r\nApplication Insights Tools for Visual Studio Package 8.9.00809.2\r\nApplication Insights Tools for Visual Studio\r\n\r\nASP.NET and Web Tools 2017 15.0.30925.0\r\nASP.NET and Web Tools 2017\r\n\r\nASP.NET Core Razor Language Services 1.0\r\nProvides languages services for ASP.NET Core Razor.\r\n\r\nASP.NET Web Frameworks and Tools 2017 5.2.50921.0\r\nFor additional information, visit https://www.asp.net/\r\n\r\nAzure App Service Tools v3.0.0 15.0.30915.0\r\nAzure App Service Tools v3.0.0\r\n\r\nCommon Azure Tools 1.10\r\nProvides common services for use by Azure Mobile Services and Microsoft Azure Tools.\r\n\r\nGhostDoc 5.4.16325.0\r\nGhostDoc automatically generates XML documentation comments.\r\n\r\nJavaScript Language Service 2.0\r\nJavaScript Language Service\r\n\r\nJavaScript Project System 2.0\r\nJavaScript Project System\r\n\r\nJetBrains ReSharper Ultimate 2017.1.2 Build 108.0.20170428.75743\r\nJetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2017 JetBrains, Inc.\r\n\r\nMicrosoft Continuous Delivery Tools for Visual Studio 0.3\r\nSimplifying the configuration of continuous build integration and continuous build delivery from within the Visual Studio IDE.\r\n\r\nMicrosoft JVM Debugger 1.0\r\nProvides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines\r\n\r\nMicrosoft MI-Based Debugger 1.0\r\nProvides support for connecting Visual Studio to MI compatible debuggers\r\n\r\nNode.js Tools 1.4.10918.1\r\nAdds support for developing and debugging Node.js apps in Visual Studio\r\n\r\nNuGet Package Manager 4.4.0\r\nNuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.\r\n\r\nSQL Server Data Tools 15.1.61707.200\r\nMicrosoft SQL Server Data Tools\r\n\r\nTestDriven.Net 4.0-beta3\r\nZero friction testing for Visual Studio\r\n\r\nTypeScript 2.3.5.0\r\nTypeScript tools for Visual Studio\r\n\r\nVisual Studio Code Debug Adapter Host Package 1.0\r\nInterop layer for hosting Visual Studio Code debug adapters in Visual Studio\r\n\r\nVsVim 2.4.1.0\r\nVsVim is a Vim emulator for Visual Studio\r\n</details>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 341058908,
"datetime": 1509530487000,
"masked_author": "username_1",
"text": "Yes, I can reproduce it every time. It's super annoying.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341070254,
"datetime": 1509532735000,
"masked_author": "username_5",
"text": "It is. I don't have any F# templates either for some reason. I'm going to try a VS repair and then a re-install if the repair does not work. I'll update with any change.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341079514,
"datetime": 1509535100000,
"masked_author": "username_5",
"text": "The tooltip and templates are now working for me. I fixed it by downloading the VS2017 installer from MSDN, running it and selecting the repair option. I then added back VsVim and the F# nightly config, updated to the latest nightly and all was working. It also worked before going back to the nightly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341382016,
"datetime": 1509619249000,
"masked_author": "username_5",
"text": "I spoke to soon. VS was very unstable after doing the repair and the F# nightly configuration. This specific issue was fixed, but VS started crashing when I tried to rename C# type members. Therefore, I re-installed Visual Studio and configured nightlies again. I now have the original issue back. I only see **The value is unused** when hovering or doing Ctrl+K Ctrl+I. In addition, VS still crashes when I try and rename a C# member. So I've swapped one issue for two! If anyone can advise me as to what I can do to help diagnose this, please let me know.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 341484372,
"datetime": 1509641131000,
"masked_author": "username_3",
"text": "cc @username_4 @jinujoseph for the issue with VS crashing with Inline Rename on C# members. That definitely doesn't seem right, and the F# nightly shouldn't be messing with that.\r\n\r\n@username_5 If you go to VS and click the \"Report a Problem\" icon in the top-right and create a new issue, the Attachments tab will have an option called \"record\". This will record a trace that you can send with the feedback tool, which will allow people to see what's going on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 341486127,
"datetime": 1509641459000,
"masked_author": "username_3",
"text": "Unfortunately, I still can't reproduce this :(\r\n\r\nUsing 15.5 Preview 2.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 341486825,
"datetime": 1509641589000,
"masked_author": "username_1",
"text": "@username_3 I forget when I saw both signature and \"value is unused\" at the same time.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341496879,
"datetime": 1509643484000,
"masked_author": "username_5",
"text": "@username_3 thanks for the guidance. I've never used that feature before!\r\n\r\nIt turns out that I don't even have to try and rename the member. I literally just have to click on the name of it and it causes a `NullReferenceException` in `Microsoft.CodeAnalysis.Workspaces`. I've recorded the steps and submitted it [over here](https://developercommunity.visualstudio.com/content/problem/143079/visual-studio-crash-when-click-on-c-interface-memb.html). \r\n\r\nIs there any easy way to flip between the nightly and the latest \"official\" version of F# for VS? I could try that and confirm if the issue is present when not on the nightly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 341503332,
"datetime": 1509644695000,
"masked_author": "username_3",
"text": "@username_5 Unfortunately, there's no way to toggle the version of the tools. If you run `VSIXInstaller.exe /u:VisualFSharp` from the Visual Studio Developer Command Prompt (admin mode not required, but I do it as admin anyways) then it will uninstall the nightly release.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 341507437,
"datetime": 1509645483000,
"masked_author": "username_5",
"text": "@username_3 The uninstall is easy enough, thanks. I uninstalled and the crash when clicking the C# member no longer happens. The R# dialog box pops up as expected. I'm not sure if this confirms it's anything to do with VFT or not...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 341513403,
"datetime": 1509646696000,
"masked_author": "username_3",
"text": "It definitely _shouldn't_, and I'd be shocked if it did. Regardless, @username_15 you may want to take a look at this as well...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RinsibleElk",
"comment_id": 342509079,
"datetime": 1510066851000,
"masked_author": "username_6",
"text": "I'm pretty late on this but regarding the original issue, I found that suspending Resharper didn't help, however disabling Resharper fully (and restarting VS) sorted it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 342517621,
"datetime": 1510068430000,
"masked_author": "username_1",
"text": "@username_6 how have you managed to disable R#? I have it installed as part of R# Ultimate.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 342518898,
"datetime": 1510068649000,
"masked_author": "username_5",
"text": "Thanks for the comment @username_6. I've just disabled ReSharper and the original issue was resolved for me too (I can see the value is unused AND the type information for the value). However, the crash on the C# member still happens.\r\n\r\n@username_1 I disabled ReSharper via Tools > Extensions and Updates > Installed > All > Resharper, then click Disable and restart.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 342539685,
"datetime": 1510072386000,
"masked_author": "username_3",
"text": "Just to make sure we're isolating variables here: does the issue go away if you restart VS _and_ have ReSharper active?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 342542062,
"datetime": 1510072780000,
"masked_author": "username_5",
"text": "@username_3 not for me. The issue remains if I restart VS *and* have R# active.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 342544096,
"datetime": 1510073104000,
"masked_author": "username_3",
"text": "Thanks! @username_7 - anyone on the JB side who might be able to see what's going on here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "auduchinok",
"comment_id": 342820710,
"datetime": 1510148542000,
"masked_author": "username_7",
"text": "@username_3 Thanks for letting me know!\r\nI've discussed the issue with a R# team member who is responsible for tooltips, we'll try to sort it out.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "auduchinok",
"comment_id": 343449101,
"datetime": 1510313186000,
"masked_author": "username_7",
"text": "Even though it happens when ReSharper is active, it looks like the bug is not caused by ReSharper itself but rather by just its presence in the Visual Studio component container.\r\nReSharper exports a class implementing `IQuickInfoSourceProvider` that may add add modify tooltips. The provider however does nothing breaking for F# files in its `AugmentQuickInfoSession`.\r\n\r\nIt looks like the actual problem is caused by `QuickInfoCommandHandlerAndSourceProvider+QuickInfoSource` that doesn't ask other providers when tooltip evaluation session (`IQuickInfoSession`) already has any element ([decompiled method](https://gist.github.com/username_7/3145e2098b64f2584fc5b6e49930ca55#file-quickinfocommandhandlerandsourceprovider-cs-L96-L97)).\r\n\r\nHow is it related? There's a sorted list of exported providers. When the ReSharper provider isn't exported `QuickInfoSource` goes before `SquiggleQuickInfoSource` in the list. When the provider is exported the order of these two is changed. Due to this the error/warning squiggle is being added before the type tooltip and then `QuickInfoSource` doesn't execute any other providers (so the type tooltip is never added).\r\n\r\nIt looks like adding `Order` attributes to these two providers in VS/Roslyn code will fix the issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "auduchinok",
"comment_id": 344373997,
"datetime": 1510688474000,
"masked_author": "username_7",
"text": "@username_3 Could someone on MS side check whether adding these attributes fixes the issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 344374358,
"datetime": 1510688546000,
"masked_author": "username_3",
"text": "Whoops, missed this. Thanks for getting this looked into, @username_7.\r\n\r\n@username_4 would you know more about this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Pilchie",
"comment_id": 344376832,
"datetime": 1510689015000,
"masked_author": "username_4",
"text": "Tagging @Jinujoseph. @Rchande probably has the most context on QuickInfo, but isn't directly working on that right now.\r\n\r\n@username_15 has also done some stuff in the Roslyn QuickInfoProvider.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 345660742,
"datetime": 1511175205000,
"masked_author": "username_8",
"text": "I too experience the same error when R# is enabled (even if suspended). Disabling the R# plugin and restarting VS fixes the issue. See #3518.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 345731692,
"datetime": 1511192070000,
"masked_author": "username_5",
"text": "FYI someone has added the crash that [I mention above](https://github.com/Microsoft/visualfsharp/issues/3056#issuecomment-341382016) and reported via VS, in the Roslyn repos https://github.com/dotnet/roslyn/issues/23279.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 345735448,
"datetime": 1511192758000,
"masked_author": "username_3",
"text": "@username_5 looks like it was migrated over from our feedback tool, since active development for Roslyn is on GitHub.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bentayloruk",
"comment_id": 345765041,
"datetime": 1511198331000,
"masked_author": "username_5",
"text": "@username_3 yes. I don't the issue on new VM with latest VS release and F# nightly, so hopefully it's sorted. Going to try and confirm by updating VS on my broken VM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349882753,
"datetime": 1512630790000,
"masked_author": "username_9",
"text": "VS 2017 with Resharper.\r\n\"The value is unused\" but no type info.\r\nResharper disabled, no change at all.\r\nHaving no type info available for variables stops me from using VS2017.\r\n\r\nCan I disable the whole Roslyn code fix feature from F#?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 349883023,
"datetime": 1512630896000,
"masked_author": "username_1",
"text": "@username_9 Are you sure you _disabled_ R#, not suspended?\r\n\r\nYou cannot disable the fix.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 349884018,
"datetime": 1512631239000,
"masked_author": "username_8",
"text": "I see that a few comments up, @username_5 reports not seeing \"the issue\". I don't know what the issue is, but just to be clear, I still experience missing tooltips when R# is enabled or suspended on VS15.5 and latest nightly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349890277,
"datetime": 1512633262000,
"masked_author": "username_9",
"text": "@username_1 you got me. I suspended it. How can I disable it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 349890494,
"datetime": 1512633340000,
"masked_author": "username_8",
"text": "@username_9 In Tools -> Extensions and updates.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349890972,
"datetime": 1512633493000,
"masked_author": "username_9",
"text": "VS2017. Resharper disabled. Still no type info. Just \"The value is unused\".\r\n\r\nAny helpful information I can provide?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 349891379,
"datetime": 1512633626000,
"masked_author": "username_1",
"text": "@username_9 go to Tools -> Extensions and updates -> ReSharper, and disable it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 349891534,
"datetime": 1512633676000,
"masked_author": "username_8",
"text": "Just to be sure that R# is disabled, open Tools -> Options and search for ReSharper. There should be no results.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349892562,
"datetime": 1512633972000,
"masked_author": "username_9",
"text": "VS2017. Resharper disabled. Another restart of VS. **Type info is there**.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349894310,
"datetime": 1512634479000,
"masked_author": "username_9",
"text": "Filed a bug report to Jetbrains/Resharper, citing this thread.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 349894497,
"datetime": 1512634532000,
"masked_author": "username_8",
"text": "@username_9 Could you post the link?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 349989113,
"datetime": 1512658202000,
"masked_author": "username_9",
"text": "@username_8, Jetbrains replied to me that @username_7 replied here above already.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 350026336,
"datetime": 1512665294000,
"masked_author": "username_3",
"text": "Just to clarify, is this _only_ when the value is unused?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 350072095,
"datetime": 1512675486000,
"masked_author": "username_8",
"text": "I'll let @username_9 answer for themselves but I seem to experience this when there's any kind of warning or error. Simply put, if there's a squiggle (or unused), then only the error is shown and nothing else unless I completely disable R# (which is a drag in a mixed F#/C# solution).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 350116401,
"datetime": 1512686318000,
"masked_author": "username_3",
"text": "I suspect that is some lower-level issue, then. @jinujoseph is this something your team can look into?\r\n\r\nIn the meantime, #4074 should make the issue with unused names a bit easier to deal with. I think it's good to have the configuration either way.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 350431463,
"datetime": 1512806581000,
"masked_author": "username_9",
"text": "@username_3 : Yes the problem occurs **only when the value really *is* unused**. This is a big problem as I use VS to write *fresh* code (partly joking here) and fresh code *very very* frequently involves unused values. A fresh function with its signature just written certainly does not yet use the values passed in. So as long as you do not use the args you are not able to examine their type. But before using them I want to check which type they have. Not possible due to this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kkkmail",
"comment_id": 358491801,
"datetime": 1516233900000,
"masked_author": "username_10",
"text": "The stuff still does not work, no matter what I tried according to descriptions above!!! The stupid workaround is to \"agree\" to prefix unused value with the underscore and then, voila!, R# miracle happens and it is possible to see the type.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 362223143,
"datetime": 1517480714000,
"masked_author": "username_8",
"text": "Any update on this? I still have to completely disable ReSharper in order for the problem to disappear, which is a bit of a letdown to be honest, because it's great for my C# code (I have mixed C#/F# solutions).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 362317092,
"datetime": 1517501800000,
"masked_author": "username_3",
"text": "No update. 15.6 will have the ability to turn off the analyzer as a workaround.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 362335410,
"datetime": 1517505021000,
"masked_author": "username_8",
"text": "Is there an issue/report anywhere else I could track?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 362341862,
"datetime": 1517506315000,
"masked_author": "username_3",
"text": "Not at the moment, no. When we have the time, we can debug the editor to determine the root cause and route to the right team (or muck about with MEF ourselves if need be). But this is not a critical issue in our eyes, so there is no timeline for when that will happen.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urbanhop",
"comment_id": 362355754,
"datetime": 1517509222000,
"masked_author": "username_9",
"text": "Just wanted to report back that with \r\n\r\nVS2017 15.5.6 \r\nVisual F# 4.1 00369-60000-00001-AA903\r\n\r\nunused variables are not reported as being unused, making the problem disappear on my side (Being able to inspect types during coding is more important to me than reminding me about unused vars). thx",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saul",
"comment_id": 362836566,
"datetime": 1517678381000,
"masked_author": "username_11",
"text": "@username_3 can we get someone from MS to take a look at this? If the Order attribute fixes this then it's a one line fix. None of the open source contributors have access to the code in question so we have our hands tied here...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 387841957,
"datetime": 1525892449000,
"masked_author": "username_8",
"text": "Any update on this? Especially considering the above comment by @username_11 that this could perhaps be a one line fix from MS if someone could just pull that string.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "realvictorprm",
"comment_id": 387961556,
"datetime": 1525932449000,
"masked_author": "username_12",
"text": "Pinging too, reshaped is quite much used so far I understood so possible bugs connected to it should be resolved.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cartermp",
"comment_id": 388076323,
"datetime": 1525963685000,
"masked_author": "username_3",
"text": "No update at this time. QuickInfo is now fully in the editor layer, so perhaps @username_13 would know more about this: https://github.com/Microsoft/visualfsharp/issues/3056#issuecomment-343449101",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "olegtk",
"comment_id": 388093968,
"datetime": 1525967081000,
"masked_author": "username_13",
"text": "That sounds like something @username_14 fixed recently (only one content item in QuickInfo).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gundermanc",
"comment_id": 388099760,
"datetime": 1525968160000,
"masked_author": "username_14",
"text": "The issue I fixed was with multiple errors. It's possible this is an IDE bug but what I suspect is happening is that you're encountering weirdness from Roslyn's 15.7 and earlier use of the quick info APIs. If this is the case, there should be no repro in the newest F# bits because IIRC you've already switched over to the new async quick info.\r\n\r\nRoslyn's quick info has generally required a couple of dozen milliseconds to compute and the previous generation of quick info APIs were synchronous, so to avoid UI delays, they built a state machine inside an IQuickInfoSource.\r\n\r\nThis state machine waits for the API to request items and if there are _item_ count is zero, then",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "realvictorprm",
"comment_id": 388104731,
"datetime": 1525969168000,
"masked_author": "username_12",
"text": "@username_8 Can you check it please with the preview 15.8?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 388129445,
"datetime": 1525974291000,
"masked_author": "username_8",
"text": "Unfortunately it's not fixed in 15.8.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "auduchinok",
"comment_id": 388130017,
"datetime": 1525974406000,
"masked_author": "username_7",
"text": "@username_14 Have you tried adding `Order` attributes to provider types as suggested in https://github.com/Microsoft/visualfsharp/issues/3056#issuecomment-343449101 so the providers order is stable?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cmeeren",
"comment_id": 388137779,
"datetime": 1525975950000,
"masked_author": "username_8",
"text": "[Repro solution.zip](https://github.com/Microsoft/visualfsharp/files/1992765/Test.zip)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gundermanc",
"comment_id": 388163550,
"datetime": 1525981417000,
"masked_author": "username_14",
"text": "Took a look at the bits in the various preview builds on my box and they don't seem to contain the change to the new quick info API yet (they still use IQuickInfoProvider instead of IAsyncQuickInfoProvider):\r\n\r\n```csharp\r\nnamespace Microsoft.VisualStudio.FSharp.Editor\r\n{\r\n\t[ExportQuickInfoProvider(\"Semantic Quick Info Provider\", \"F#\"), CompilationMapping(SourceConstructFlags.ObjectType)]\r\n\t[Serializable]\r\n\tinternal class FSharpQuickInfoProvider : IQuickInfoProvider\r\n\t{\r\n }\r\n}\r\n```\r\n\r\n@username_15 can you confirm whether or not [this change](https://github.com/Microsoft/visualfsharp/commit/a71287f96ec8709d222f13de7e67499393dec04b) has made it into any of the VS previews? I'm fairly certain it should fix this bug (see my comment above).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saul",
"comment_id": 388179486,
"datetime": 1525984982000,
"masked_author": "username_11",
"text": "@username_14 as far as I'm aware, the DLLs for the tools have the commit hash in their assembly info. You can figure out whether the DLLs you're using include that commit or not that way:\r\n\r\n\r\n\r\nIf you're using the nightlies, then obviously it will already contain that commit.\r\n\r\nIf you're using one of the previews, navigate to: `C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brettfo",
"comment_id": 388220064,
"datetime": 1525996586000,
"masked_author": "username_15",
"text": "@username_14 The async quick info changes will first appear in VS 15.8 preview 2. If you want to use them now you can [consume the nightly packages](https://blogs.msdn.microsoft.com/dotnet/2017/03/14/announcing-nightly-releases-for-the-visual-f-tools/) which are built from `master` (which has this change).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 388286910,
"datetime": 1526024423000,
"masked_author": "username_1",
"text": "15.8 preview with R#:\r\n\r\n\r\n\r\n15.8 preview with R# + VFT nightly:\r\n\r\n\r\n\r\nSo, the issue has been solved 🔥",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cartermp",
"comment_id": null,
"datetime": 1526048090000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 16 | 83 | 20,136 | false | false | 20,136 | true |
corelan/windbglib | corelan | 228,596,510 | 17 | null | [
{
"action": "opened",
"author": "b0nd",
"comment_id": null,
"datetime": 1494818057000,
"masked_author": "username_0",
"text": "Hi Peter,\r\n\r\nDoes mona plugin work for 64 bit applications loaded on 64 bit windbg?\r\n\r\nThanks",
"title": "Does it work with 64 bit apps?",
"type": "issue"
},
{
"action": "created",
"author": "corelanc0d3r",
"comment_id": 301377954,
"datetime": 1494825207000,
"masked_author": "username_1",
"text": "Hi,\r\n\r\nmona.py will load, and can list the loaded modules; but that's about the only feature that will work correctly. It will require some work to make both mona.py and windbglib compatible with x64.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "corelanc0d3r",
"comment_id": null,
"datetime": 1497687419000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 295 | false | false | 295 | false |
smartcontractkit/chainlink | smartcontractkit | 330,463,335 | 346 | {
"number": 346,
"repo": "chainlink",
"user_login": "smartcontractkit"
} | [
{
"action": "opened",
"author": "rupurt",
"comment_id": null,
"datetime": 1528412007000,
"masked_author": "username_0",
"text": "404's will be handled in a separate PR",
"title": "Fix direct routes in GUI",
"type": "issue"
}
] | 2 | 2 | 38 | false | true | 38 | false |
elastic/elasticsearch-net | elastic | 207,342,938 | 2,585 | {
"number": 2585,
"repo": "elasticsearch-net",
"user_login": "elastic"
} | [
{
"action": "opened",
"author": "gmarz",
"comment_id": null,
"datetime": 1487020939000,
"masked_author": "username_0",
"text": "",
"title": "Fix #2561 make Missing option on terms aggregation generic",
"type": "issue"
},
{
"action": "created",
"author": "Mpdreamz",
"comment_id": 279710957,
"datetime": 1487080052000,
"masked_author": "username_1",
"text": "@username_0 added a commit with a way to prevent boxing, including an integration/unit tests for the missing property sending `-1`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmarz",
"comment_id": 279716522,
"datetime": 1487081414000,
"masked_author": "username_0",
"text": "LGTM 👍 Just a minor nitpick",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmarz",
"comment_id": 279716603,
"datetime": 1487081434000,
"masked_author": "username_0",
"text": "Much better BTW :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Mpdreamz",
"comment_id": 279725409,
"datetime": 1487083360000,
"masked_author": "username_1",
"text": "rebased and amended @username_0 👍",
"title": null,
"type": "comment"
}
] | 2 | 5 | 199 | false | false | 199 | true |
josdejong/mathjs | null | 166,250,020 | 688 | null | [
{
"action": "opened",
"author": "ericman314",
"comment_id": null,
"datetime": 1468905408000,
"masked_author": "username_0",
"text": "What characters are allowed in variable names (`SymbolNode`)? I couldn't find anything in the docs.",
"title": "What are the allowed characters in variable names?",
"type": "issue"
},
{
"action": "created",
"author": "ericman314",
"comment_id": 233536008,
"datetime": 1468906214000,
"masked_author": "username_0",
"text": "After digging through `parse.js`, I have come up with the following. Please correct any inaccuracies.\r\n\r\nVariables must:\r\n* Begin with an \"alpha character\", which is:\r\n * A latin letter (upper or lower case) Ascii: a-z, A-Z\r\n * A underscore Ascii: _\r\n * A latin letter with accents Unicode: \\u00C0 - \\u02AF\r\n * A greek letter Unicode: \\u0370 - \\u03FF\r\n * A mathematical alphanumeric symbol Unicode: \\u{1D400} - \\u{1D7FF} excluding invalid code points\r\n* Contain only alpha characters (above) and digits 0-9\r\n* Not be any of the following: `mod`, `to`, `in`, `and`, `xor`, `or`, `not` (Actually it is possible to assign to some of these, but that's probably not recommended)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josdejong",
"comment_id": 234237739,
"datetime": 1469103808000,
"masked_author": "username_1",
"text": "Good point, we should describe the allowed characters to the docs. \r\n\r\nIt would also be cool to somehow provide your own `isValidCharacter` function, allowing to extend for example with a character like `²` or other sets of characters.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rafaljanicki",
"comment_id": 236536600,
"datetime": 1470044766000,
"masked_author": "username_2",
"text": "+1 for the isValidCharacter\r\n\r\nIn our case, we use variables which may start with a number, but it's not a number, but a string. Currently, the MathJS throws an \"Undefined symbol\" error.\r\n\r\nSo, we'd need either isValidCharacter function (or isValidSymbol) or a possibility to escape a symbol",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josdejong",
"comment_id": 236675020,
"datetime": 1470078185000,
"masked_author": "username_1",
"text": "hm, that won't work with the parser since a variable starting with a number, say `1foo` will be parsed as an implicit multiplication `1 * foo`. I think you will have to look into a different direction to allow symbols starting with a number. If you know the defined symbols beforehand, you could preprocess your expression with a regexp and replace them with say `_1bar` for example.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rafaljanicki",
"comment_id": 236874357,
"datetime": 1470136371000,
"masked_author": "username_2",
"text": "That's exactly what I've done for now, but I'm not happy with the solution - it requires two additional loops (per level) on the object. That's why it'd be nice to specify own parser rules, so it can be adjusted for custom cases (additionally, we don't use shorthand for 1*foo, so the feature is \"useless\" for us)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josdejong",
"comment_id": 238019166,
"datetime": 1470483319000,
"masked_author": "username_1",
"text": "Yes, it' not ideal having to do pre-processing steps like that, but this is something we can't change in the parser to fit your needs. If your needs are too different from the parser of math.js, you could consider generating your own parser, have a look at [jison](http://zaa.ch/jison/) and [peg](http://pegjs.org/).",
"title": null,
"type": "comment"
}
] | 3 | 7 | 2,392 | false | false | 2,392 | false |
emberjs/data | emberjs | 89,304,557 | 3,378 | null | [
{
"action": "opened",
"author": "sarus",
"comment_id": null,
"datetime": 1434636731000,
"masked_author": "username_0",
"text": "Just upgraded to Ember Data v1.13.0 and I'm getting the following deprecations:\r\n\r\n```\r\nDEPRECATION: The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in you adapter:application and return false.\r\n at Ember.Object.extend.shouldBackgroundReloadRecord (https://neontetra.breach/assets/vendor.js:88631:15)\r\n at ember$data$lib$system$store$$Service.extend._fetchOrResolveInternalModel (https://neontetra.breach/assets/vendor.js:99820:21)\r\n at ember$data$lib$system$store$$Service.extend._findByInternalModel (https://neontetra.breach/assets/vendor.js:99789:41)\r\n at ember$data$lib$system$store$$Service.extend.findRecord (https://neontetra.breach/assets/vendor.js:99779:21)\r\n at ember$data$lib$system$store$$Service.extend.find (https://neontetra.breach/assets/vendor.js:99675:21)\r\n```\r\n\r\nand\r\n\r\n```\r\nDEPRECATION: Your custom serializer uses the old version of the Serializer API, with `extract` hooks. Please upgrade your serializers to the new Serializer API using `normalizeResponse` hooks instead.\r\n at ember$data$lib$system$store$serializer$response$$normalizeResponseHelper (https://neontetra.breach/assets/vendor.js:93888:15)\r\n at https://neontetra.breach/assets/vendor.js:95517:25\r\n at Object.Backburner.run (https://neontetra.breach/assets/vendor.js:10776:25)\r\n```\r\n\r\nIs there a guide (available now or planned) to help with resolving these deprecations? For example my custom serializers currently override `keyForAttribute` and `serializeAttribute` but I don't know if these are part of the `extract` hooks mentioned in the deprecation (I assume they must be, hence the deprecation but previously I've had addons or things like ember inspector throw deprecations and often the deprecation stacktrace doesn't point back to my application code but stops somewhere deep within ember core or debug)\r\n\r\nSomething similar to the core ember deprecation guide found here which has been immensely useful in resolving ember deprecations (http://emberjs.com/deprecations/v1.x/). \r\n\r\nThank you!\r\n\r\n(Sorry if this exists and my google fu is just weak)",
"title": "Is there a deprecation guide for Ember Data v1.13.0?",
"type": "issue"
},
{
"action": "created",
"author": "adam-knights",
"comment_id": 113178733,
"datetime": 1434638521000,
"masked_author": "username_1",
"text": "+1 for this, my RESTSerializer is simply\r\n\r\n export default DS.RESTSerializer.extend({\r\n serializeIntoHash: function (hash, type, record, options) {\r\n Ember.merge(hash, this.serialize(record, options));\r\n }\r\n });\r\n\r\nBut I have no idea whether this deprecation effects me or the action to take to resolve it. Would be alot better if the deprecations linked to urls with code examples that would help remove the deprecations, like Ember does.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ixtli",
"comment_id": 113200287,
"datetime": 1434643017000,
"masked_author": "username_2",
"text": "I found this little bit: https://github.com/emberjs/data/blob/v1.13/packages/ember-data/lib/system/serializer.js#L28 Also the docs on the site are broken because they all link to github blob/v1.13.1/ but that tag doesn't exist.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "turtleguyy",
"comment_id": 116823030,
"datetime": 1435608361000,
"masked_author": "username_3",
"text": "+1\r\n\r\nEspecially in regards to this `Serializer extract hooks` nonsense. I've tried everything short of ritual sacrifice to get rid of this deprecation notice, with no luck.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wecc",
"comment_id": 116844599,
"datetime": 1435611412000,
"masked_author": "username_4",
"text": "A guide explaining the transition in detail is in the making and it's a bummer it has taken so long :disappointed: The ED 1.13 blog post alone took way longer than we anticipated but there was simply so much new stuff to cover.\r\n\r\nThe major steps needed to transition to the new Serializer API are outlined in the 1.13 blog post:\r\nhttp://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_transition-to-the-new-jsonserializer-and-restserializer-apis\r\n\r\nPlease feel free to ping me on the [Ember Community Slack](https://ember-community-slackin.herokuapp.com/) and I'll be happy to help you out in the meantime.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Keeo",
"comment_id": 124777447,
"datetime": 1437784464000,
"masked_author": "username_5",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fuse-mars",
"comment_id": 134407503,
"datetime": 1440457678000,
"masked_author": "username_6",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "turtleguyy",
"comment_id": 134631245,
"datetime": 1440516941000,
"masked_author": "username_3",
"text": "Like he said, definitely check out the [Ember Community Slack](https://ember-community-slackin.herokuapp.com/). The thing is a wealth of info and goodness for all things Ember.\r\n\r\n/cc @username_5 @username_6",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "workmanw",
"comment_id": 134694934,
"datetime": 1440527508000,
"masked_author": "username_7",
"text": "The downside of the slack is conversations only last a few days before reaching their 10K threshold. It's a shame that there is a lot of potential answers to questions that aren't viewable / searchable.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bmac",
"comment_id": null,
"datetime": 1450882572000,
"masked_author": "username_8",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "bmac",
"comment_id": 166916873,
"datetime": 1450882572000,
"masked_author": "username_8",
"text": "The Ember Data 1.13 blogpost is the best resource for learning how to deal with the deprecations in 1.13. http://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_transition-to-the-new-jsonserializer-and-restserializer-apis",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jreading",
"comment_id": 171782643,
"datetime": 1452806303000,
"masked_author": "username_9",
"text": "If anyone still hasn't migrated and has the `extract` hooks warning in 1.13. just set the isNewSerializerAPI to true.\r\n\r\n```js\r\n\r\nvar ApplicationSerializer = DS.RESTSerializer.extend({\r\n isNewSerializerAPI: true,\r\n...\r\n```\r\n\r\nWorked for me.",
"title": null,
"type": "comment"
}
] | 10 | 12 | 4,627 | false | false | 4,627 | true |
aws/amazon-sagemaker-examples | aws | 347,161,001 | 354 | null | [
{
"action": "opened",
"author": "tapomay",
"comment_id": null,
"datetime": 1533241400000,
"masked_author": "username_0",
"text": "The space optimization by linking scipy libs with numpy is breaking for newer versions.\r\n\r\nIssue identified in:\r\nhttps://github.com/numpy/numpy/issues/11614\r\n\r\nBroken Dockerfile:\r\nhttps://github.com/awslabs/amazon-sagemaker-examples/blob/master/advanced_functionality/scikit_bring_your_own/container/Dockerfile",
"title": "scikit_bring_your_own Dockerfile broken",
"type": "issue"
},
{
"action": "closed",
"author": "seanpmorgan",
"comment_id": null,
"datetime": 1609957215000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "seanpmorgan",
"comment_id": 755471601,
"datetime": 1609957215000,
"masked_author": "username_1",
"text": "Thanks, this was fixed in #345",
"title": null,
"type": "comment"
}
] | 2 | 3 | 340 | false | false | 340 | false |
elixir-lang/elixir | elixir-lang | 254,837,623 | 6,538 | {
"number": 6538,
"repo": "elixir",
"user_login": "elixir-lang"
} | [
{
"action": "opened",
"author": "kelvinst",
"comment_id": null,
"datetime": 1504388446000,
"masked_author": "username_0",
"text": "Closes #6374",
"title": "Warning on the use of length(x) == 0 on guards",
"type": "issue"
},
{
"action": "created",
"author": "josevalim",
"comment_id": 326789288,
"datetime": 1504424052000,
"masked_author": "username_1",
"text": "Thank you, I have added some comments!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "entertainyou",
"comment_id": 326962781,
"datetime": 1504531478000,
"masked_author": "username_2",
"text": "So for guard like \"length(x) == 1\" still has to be traverse the whole list?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 326965140,
"datetime": 1504532169000,
"masked_author": "username_0",
"text": "@username_2 I've also thought about it. It is also not a good practice, but I guess the point is that `length(x) == 0` is something people are very used to do in other languages, which aren't a bad practice, since `[]` are not lists and yes arrays. @username_1 and @username_4, is that correct?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michalmuskala",
"comment_id": 326978215,
"datetime": 1504535898000,
"masked_author": "username_3",
"text": "I started wondering if the place for this is really the compiler and not, for example, a linter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whatyouhide",
"comment_id": 326978415,
"datetime": 1504535954000,
"masked_author": "username_4",
"text": "@username_2 `length(x) == 0` is a common pattern that says \"if the list is empty\". Lists with one element can still be checked by matching on `[_]` more efficiently, but then when do we stop? Do we say that `length(x) == 2` can be optimized by doing `[_, _]`? I think `length(x) == 0` makes sense because it's simple, common, and you can replace it with `x == []` instead of pattern matching.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 326979198,
"datetime": 1504536189000,
"masked_author": "username_0",
"text": "@username_3 me too... 😕",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 327012003,
"datetime": 1504549480000,
"masked_author": "username_0",
"text": "Is there any linter on `elixir` core? Or you are talking about `credo`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whatyouhide",
"comment_id": 327020809,
"datetime": 1504554712000,
"masked_author": "username_4",
"text": "There is no linter on Elixir core except, well, the compiler warnings :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michalmuskala",
"comment_id": 327021521,
"datetime": 1504555126000,
"masked_author": "username_3",
"text": "There's also a slight change in semantics that has to be considered. `length(x) == 0` will fail on improper lists, which `x == []` will just return false. For example:\r\n\r\n```elixir\r\ndef foo(x) when length(x) == 0 or hd(x) == nil, do: :nothing\r\ndef foo(_), do: :something\r\n\r\ndef bar(x) when x == [] or hd(x) == nil, do: :nothing\r\ndef bar(x), do: :something\r\n```\r\nGives different results in some situations:\r\n```elixir\r\nfoo([nil | nil]) #=> :something\r\nbar([nil | nil]) #=> :nothing\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josevalim",
"comment_id": 327023946,
"datetime": 1504556540000,
"masked_author": "username_1",
"text": "It is definitely debatable although it is not the only place where it happens in Elixir.\r\n\r\nElixir warns if you are piping from or to an expression that does not have parens. We warn if you use a variable with underscore more than once in the same pattern. A compiler would not warn on any of those as it is valid code. Some of those may have false positives but I would say they still have improved the experience of developers with the language, removing common pitfalls and time sinks.\r\n\r\nIt is also worth mentioning that compilers do typically include linters but they typically worry with lower level details than developing-facing ones.\r\n\r\nThis is a small warning that can tell a lot on how to think and work with lists in Elixir. As with the previous warnings, there is a chance of legit usage of those functionalities, but all of those cases can be rewritten in a way that is clearer in purpose.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 327024123,
"datetime": 1504556649000,
"masked_author": "username_0",
"text": "@username_3, nice catch. Do you think someone could be using `length(x)` for this reason? Expecting this kind of behavior?\r\n\r\nAnd even tough, I guess it continues to be a bad practice anyways, if they use it expecting this kind of behavior, they should change it to something like:\r\n\r\n```elixir\r\ndef bar(x) when x == [] or hd(x) == nil or tl(x) == nil, do: :nothing\r\ndef bar(x), do: :something\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michalmuskala",
"comment_id": 327279989,
"datetime": 1504640099000,
"masked_author": "username_3",
"text": "I wouldn't expect to see that kind of code, but the behaviour is there currently. I guess a warning is fine, but that's one of the reasons why the `length` check can't be optimised by the compiler.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 327282210,
"datetime": 1504640606000,
"masked_author": "username_0",
"text": "Yep... At least not replacing them by `list == []`.\r\n\r\nThere is actually ways to optimize, creating functions like `length_equals?` that traverse the items, but just while it needs to, and imitating the behaviour of length for malformed lists. But I guess that's not the intention for now, and I don't know if we can consider it a clean solution.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michalmuskala",
"comment_id": 327288625,
"datetime": 1504642121000,
"masked_author": "username_3",
"text": "You need to traverse the whole list to be compatible with `length`, so there wouldn't be much of a difference.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 327290052,
"datetime": 1504642463000,
"masked_author": "username_0",
"text": "@username_3 you're right, sorry. :sad: Didn't noticed that the malformed list in your example was a `nil` as the tail, and to check it one should traverse the whole list anyway. Please ignore what I said.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josevalim",
"comment_id": 327576430,
"datetime": 1504723244000,
"masked_author": "username_1",
"text": "@username_0 I have pushed two commits to your branch, one that slightly improves the error message and indentation and another that fixes the test I broke. :) As soon as tests pass we will merge it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kelvinst",
"comment_id": 327602909,
"datetime": 1504729549000,
"masked_author": "username_0",
"text": "Thanks @username_1! Looks great!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "josevalim",
"comment_id": 327606089,
"datetime": 1504730329000,
"masked_author": "username_1",
"text": ":heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:",
"title": null,
"type": "comment"
}
] | 5 | 19 | 4,020 | false | false | 4,020 | true |
google/closure-library | google | 98,284,781 | 499 | {
"number": 499,
"repo": "closure-library",
"user_login": "google"
} | [
{
"action": "opened",
"author": "joeltine",
"comment_id": null,
"datetime": 1438298462000,
"masked_author": "username_0",
"text": "Fixes https://github.com/google/closure-library/issues/345",
"title": "Remove mention of __proto__ being a safe key",
"type": "issue"
},
{
"action": "created",
"author": "joeltine",
"comment_id": 126519152,
"datetime": 1438298656000,
"masked_author": "username_0",
"text": "I signed it!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 880 | false | true | 70 | false |
DenisKolodin/yew | null | 343,822,318 | 337 | null | [
{
"action": "opened",
"author": "Boscop",
"comment_id": null,
"datetime": 1532385928000,
"masked_author": "username_0",
"text": "`#[derive(Message)]` gives warning about implicitly using symbols from parent modules,\r\nbut they are **NOT** from a parent module!\r\n\r\n",
"title": "#[derive(Message)] gives warning about implicitly using symbols from parent modules",
"type": "issue"
},
{
"action": "created",
"author": "norcalli",
"comment_id": 407503609,
"datetime": 1532456357000,
"masked_author": "username_1",
"text": "I'm pretty sure you have the power to close issues. It doesn't need to be deleted.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Boscop",
"comment_id": null,
"datetime": 1532478993000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 324 | false | false | 324 | false |
OfficeDev/office-ui-fabric-react | OfficeDev | 324,989,039 | 4,928 | null | [
{
"action": "opened",
"author": "CaptainSadaf",
"comment_id": null,
"datetime": 1526922098000,
"masked_author": "username_0",
"text": "I have been working with Fabric UI and i have tried to set the 12px font size to ms-fabric class but it does not applied to all nested components.\r\n\r\nI have override the font size of ms-Command Bar by using .ms-CommandBar class and it's working.\r\nbut how i can set the 12px fontSize to all fabric components instead of 14px.\r\n\r\nDo i need to copy all fabric css classes and then override all nested level classes or is any optimal solution for that purpose?\r\n\r\nwhen i try to override the size of fabric Components then margin and padding is not working fine.",
"title": "OverRide Default Size of Fabric UI components",
"type": "issue"
},
{
"action": "created",
"author": "CaptainSadaf",
"comment_id": 391249568,
"datetime": 1527060827000,
"masked_author": "username_0",
"text": "@dzearing please would you like to help me ?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JasonGore",
"comment_id": null,
"datetime": 1534546196000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "JasonGore",
"comment_id": 414006736,
"datetime": 1534546196000,
"masked_author": "username_1",
"text": "This is a goal of #5035 so I will close this issue as a duplicate (subset) of #5035.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 685 | false | false | 685 | false |
fossasia/open-event-frontend | fossasia | 254,649,398 | 849 | null | [
{
"action": "opened",
"author": "geekyd",
"comment_id": null,
"datetime": 1504274343000,
"masked_author": "username_0",
"text": "**I'm submitting a ...** (check one with \"x\")\r\n- [ ] bug report\r\n- [x] feature request\r\n- [ ] support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/open-event-frontend\r\n\r\nParent Issue: #792",
"title": "Add file upload component",
"type": "issue"
},
{
"action": "closed",
"author": "geekyd",
"comment_id": null,
"datetime": 1505392975000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 274 | false | false | 274 | false |
Microsoft/vscode | Microsoft | 212,819,306 | 22,241 | null | [
{
"action": "opened",
"author": "rob3c",
"comment_id": null,
"datetime": 1488998291000,
"masked_author": "username_0",
"text": "Hi, please add support for environment variable replacements in JSON file schema properties.\r\n\r\nEditing JSON files with vscode and the current schema support is great when using a relative path within a project or an absolute path when one is known. However, sometimes relative/absolute paths aren't possible. I believe there's already support for them in other JSON file contexts, but it doesn't look like the schema resolver is leveraging that code. (If it is, none of the syntax variations I've tried actually worked, and some of them crashed the JSON Language Server, requiring a restart.)",
"title": "Add support for environment variable replacements in JSON schema URIs",
"type": "issue"
},
{
"action": "created",
"author": "aeschli",
"comment_id": 285175481,
"datetime": 1489008599000,
"masked_author": "username_1",
"text": "@username_0 Can you please give an example of what you mean?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rob3c",
"comment_id": 285427612,
"datetime": 1489081993000,
"masked_author": "username_0",
"text": "@username_1 Sure, thanks for looking into this!\r\n\r\nHere's an example of how I might've expected it to work already like `${workspaceRoot}` does in _launch.json_:\r\n\r\n`\"$schema\": \"${workspaceRoot}/schemas/foo.schema.json\",`\r\n\r\n\r\nAnd here's how using an environment variable might look:\r\n\r\n`\"$schema\": \"${env:MY_SCHEMA_DIR_ENV_VAR}/foo.schema.json\",`\r\n\r\nI'm on Windows and originally tried this:\r\n\r\n`\"$schema\": \"%MY_ENV_VAR%/foo.schema.json\"`\r\n\r\nand this:\r\n\r\n`\"$schema\": \"file:///%MY_ENV_VAR%/foo.schema.json\"`\r\n\r\nwhich both reported:\r\n```\r\nThe JSON Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted.\r\n```\r\nwhich forced me to restart vscode (escaping the percents didn't work either, of course). The percent notation is windows-specific anyway.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DrecDroid",
"comment_id": 330423117,
"datetime": 1505793852000,
"masked_author": "username_2",
"text": "Hi, I see this feature useful. Right know to use a schema in a deeply nested json file one have to do something like:\r\n\r\n \"$schema \": \"../../../schemas/my_schema.json\"\r\n\r\nWhen would be easier to just write:\r\n\r\n \"$schema\": \"${workspaceRoot}/schemas/my_schema.json\"",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "aeschli",
"comment_id": null,
"datetime": 1512406367000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "aeschli",
"comment_id": 349024994,
"datetime": 1512406367000,
"masked_author": "username_1",
"text": "To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.\r\nIf you disagree and feel that this issue is crucial: We're happy to listen and to reconsider.\r\nMaybe you want to give it a try yourself and provide the feature through an extension or a PR: We're happy to give advise and get you started.\r\nThanks for your understanding. Thanks for helping and happy coding!",
"title": null,
"type": "comment"
}
] | 3 | 6 | 2,265 | false | false | 2,265 | true |
NativeScript/NativeScript | NativeScript | 250,707,895 | 4,706 | null | [
{
"action": "opened",
"author": "sean-perkins",
"comment_id": null,
"datetime": 1502905846000,
"masked_author": "username_0",
"text": "### Did you verify this is a real problem by searching [Stack Overflow]\r\nYes\r\n\r\n### Tell us about the problem\r\nAfter a patch in `tns-core-modules`, webpack will fail to build. \r\n\r\n### Which platform(s) does your issue occur on?\r\niOS - most likely both\r\n\r\n### Please provide the following version numbers that your issue occurs with:\r\n- CLI: 3.1.2\r\n- Cross-platform modules: 3.1.1\r\n- Runtime(s): 3.1.0\r\n\r\n### Please tell us how to recreate the issue in as much detail as possible.\r\n1. Use the latest tns-core-modules\r\n2. Build with webpack\r\n3. See the following warning on build\r\n```\r\nWARNING in ../~/tns-core-modules/profiling/profiling.js\r\nModule not found: Error: Can't resolve '~/package.json' in '/Users/seanperkins/Documents/Projects/loop/nativescript/node_modules/tns-core-modules/profiling'\r\n @ ../~/tns-core-modules/profiling/profiling.js 102:20-45\r\n @ ../~/nativescript-angular/platform-common.js\r\n @ ../~/nativescript-angular/platform-static.js\r\n @ ./vendor.ts\r\n\r\n```\r\n4. Webpack build fails\r\n\r\n### Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.\r\n\r\nReverting the code in `profile.js` from this commit:\r\n\r\nhttps://github.com/NativeScript/NativeScript/commit/b1432679e68eed39b155f1d3ab335a56abda0010#diff-a1e9fef8fce4d5cedbe9625acd2c9d8c\r\n\r\nto:\r\nhttps://github.com/NativeScript/NativeScript/blob/08b16b3b5aec09331309c66a168071dcca3657d0/tns-core-modules/profiling/profiling.ts#L122\r\n\r\nResolves the issues. Webpack cannot understand the require statement, unless accessed from the global namespace. \r\n\r\nAlso downgrading to 3.1.0 for `tns-core-modules` resolves the issue.",
"title": "tns-core-modules 3.1.1 patch breaks webpack builds",
"type": "issue"
},
{
"action": "created",
"author": "sis0k0",
"comment_id": 322851367,
"datetime": 1502906416000,
"masked_author": "username_1",
"text": "Please, add this alias to your webpack configuration:\r\nhttps://github.com/NativeScript/nativescript-dev-webpack/blob/e4148bb57feca221fb49a15447ea52e52041d02f/templates/webpack.angular.js#L54-L56",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sis0k0",
"comment_id": 322851537,
"datetime": 1502906455000,
"masked_author": "username_1",
"text": "Also, as you mentioned this is a warning. The build must be failing for another reason.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sean-perkins",
"comment_id": 322853581,
"datetime": 1502906900000,
"masked_author": "username_0",
"text": "@username_1 Brilliant, that does resolve the build conflict, thanks! Unfortunately replacing that one line as mentioned, causes the build to pass or fail; so it does seem attributed to that change.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sean-perkins",
"comment_id": null,
"datetime": 1502907384000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 2,257 | false | true | 2,108 | true |
NervJS/taro | NervJS | 378,684,090 | 1,047 | null | [
{
"action": "opened",
"author": "tianlu1677",
"comment_id": null,
"datetime": 1541675409000,
"masked_author": "username_0",
"text": "#环境是mac, npm 6.2.0\r\n\r\n$ npm install -g @tarojs/cli\r\n```\r\nnpm WARN deprecated babel-plugin-remove-dead-code@1.3.2: use babel-plugin-minify-dead-code-elimination and babel-plugin-minify-guarded-expressions\r\nnpm ERR! code ETARGET\r\nnpm ERR! notarget No matching version found for @tarojs/transformer-wx@1.1.4\r\nnpm ERR! notarget In most cases you or one of your dependencies are requesting\r\nnpm ERR! notarget a package version that doesn't exist.\r\nnpm ERR! notarget\r\nnpm ERR! notarget It was specified as a dependency of '@tarojs/cli'\r\nnpm ERR! notarget\r\n\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR! /Users/xxx/.npm/_logs/2018-11-08T11_08_04_018Z-debug.log\r\n```",
"title": "安装最新版本报错",
"type": "issue"
},
{
"action": "created",
"author": "yuche",
"comment_id": 436959485,
"datetime": 1541675598000,
"masked_author": "username_1",
"text": "现在 npm 出现了一些问题，有些包没能成功发布，稍微网络正常我们把未发布的包全发布就能解决这个问题。\r\n\r\n现在可以先安装 `1.1.3`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "luckyadam",
"comment_id": 436965308,
"datetime": 1541676992000,
"masked_author": "username_2",
"text": "已经 OK 了，可以重新试下",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tianlu1677",
"comment_id": null,
"datetime": 1541744307000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "relaxfinger",
"comment_id": 558968223,
"datetime": 1574840297000,
"masked_author": "username_3",
"text": "安装报错，mac 10.15.1， node 12.13.1 ，npm 6.13.1\r\n\r\n命令：\r\n npm i -g @tarojs/cli\r\n\r\n结果：\r\nnpm WARN deprecated babel-plugin-remove-dead-code@1.3.2: use babel-plugin-minify-dead-code-elimination and babel-plugin-minify-guarded-expressions\r\nnpm WARN deprecated crypto@1.0.1: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.\r\nnpm WARN deprecated eslint-plugin-typescript@0.12.0: Deprecated: Use @typescript-eslint/eslint-plugin instead\r\nnpm WARN deprecated joi@14.3.1: This module has moved and is now available at @hapi/joi. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.\r\nnpm ERR! code ETARGET\r\nnpm ERR! notarget No matching version found for @tarojs/taroize@1.3.26.\r\nnpm ERR! notarget In most cases you or one of your dependencies are requesting\r\nnpm ERR! notarget a package version that doesn't exist.\r\nnpm ERR! notarget \r\nnpm ERR! notarget It was specified as a dependency of '@tarojs/cli'\r\nnpm ERR! notarget \r\n\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR! /Users/username_3/.npm/_logs/2019-11-27T07_37_25_531Z-debug.log",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Garfield550",
"comment_id": 559028943,
"datetime": 1574850687000,
"masked_author": "username_4",
"text": "1.3.26 刚出，等待 npm 源同步。",
"title": null,
"type": "comment"
}
] | 6 | 7 | 2,203 | false | true | 1,984 | true |
laravel/framework | laravel | 274,673,744 | 22,108 | {
"number": 22108,
"repo": "framework",
"user_login": "laravel"
} | [
{
"action": "opened",
"author": "VinceG",
"comment_id": null,
"datetime": 1510868505000,
"masked_author": "username_0",
"text": "Fixes #22107",
"title": "Fix Data Missing for empty string date values",
"type": "issue"
},
{
"action": "created",
"author": "taylorotwell",
"comment_id": 345083979,
"datetime": 1510871438000,
"masked_author": "username_1",
"text": "It may make more sense to just check if `empty`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VinceG",
"comment_id": 345089029,
"datetime": 1510872758000,
"masked_author": "username_0",
"text": "@username_1 That's event better. Thank You.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 104 | false | false | 104 | true |
CocoaPods/Rainforest | CocoaPods | 231,887,805 | 71 | null | [
{
"action": "opened",
"author": "paulb777",
"comment_id": null,
"datetime": 1495998554000,
"masked_author": "username_0",
"text": "After running into https://github.com/CocoaPods/Rainforest/issues/69 and subsequent issues related to ruby 2.4 and ruby 2.3, I downgraded to ruby 2.0, but I'm now failing to clone CLAide.git. Full log at this [gist](https://gist.github.com/username_0/5bc3e56f06b2b6b123b639e7c73cabd5)",
"title": "Please document the ruby/rake/etc configuration necessary run rake bootstrap",
"type": "issue"
},
{
"action": "closed",
"author": "dnkoutso",
"comment_id": null,
"datetime": 1512876816000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 282 | false | false | 282 | true |
svalinn/DAGMC-viz | svalinn | 336,017,990 | 6 | null | [
{
"action": "opened",
"author": "gonuke",
"comment_id": null,
"datetime": 1530053188000,
"masked_author": "username_0",
"text": "The bash scripts dealing with the graveyard reuse a lot of the same elements. It should be possible to refactor these into a single script with some command line options. \r\n\r\nIt's also possible that it may be easier to do it in Python.\r\n\r\nThere may also be an opportunity for tests.",
"title": "Combine graveyard related bash scripts into one",
"type": "issue"
}
] | 1 | 1 | 284 | false | false | 284 | false |
bilalq/Tranquillity-Editor | null | 90,451,909 | 15 | null | [
{
"action": "opened",
"author": "incandescentman",
"comment_id": null,
"datetime": 1435082403000,
"masked_author": "username_0",
"text": "This is incredible. However, it looks like the list of rhymes that it pulls is quite limited. \r\n\r\nIf I enter the word, \"air,\" for instance, it gives me:\r\n\r\n`kitchenware\r\nere\r\ntheir\r\nthere\r\nwhere\r\ncare\r\nbear\r\nfair\r\nhair\r\nshare\r\nchair\r\npair\r\nrare\r\nwear\r\nbare`\r\n\r\nBut there are so many common words that do not appear: billionaire, debonair, aware, despair... \r\n\r\nIs it artificially limiting the number of rhymes it shows me? Is there any way I can remove this limiter? Thanks!",
"title": "how to pull more rhymes?",
"type": "issue"
},
{
"action": "created",
"author": "bilalq",
"comment_id": 114628441,
"datetime": 1435090370000,
"masked_author": "username_1",
"text": "Hey, thanks for the interest!\r\n\r\nI've actually just started re-writing this entire thing from scratch. I'll push out a WIP branch in a couple days. \r\n\r\nRight now, it's artificially restricted to the first 15 best rhymes. I think it might make sense to expose more on demand. I could look into adding either a \"load more\" button or maybe making the rhymes and infinitely scrollable list (well, finite up to the number of rhymes we found). I'm open to other ideas as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "incandescentman",
"comment_id": 114643009,
"datetime": 1435093926000,
"masked_author": "username_0",
"text": "That would be amazing. Other ideas:\r\n\r\n1. Sort rhymes according to number of syllables in the word. This would be amazing and not too difficult\r\n2. More difficult: search by scansion\r\n\r\nThis might be way too difficult, but if you're looking to extend this, it would certainly be useful to be able to search not just by rhyme, but also by scansion/meter. (Syllable count as well as which syllable the emphasis falls on.) \r\n\r\nExample: Suppose I am looking for a word that is an anapest (a three-syllable word where the emphasis falls on the last syllable, i.e. \"apprehend\" is an anapest, \"decorate\" is not). It would be great to be able to query a scansion dictionary to be given a list of matches. \r\n\r\nA combined rhyme/scansion dictionary would be a killer app. So that if, let's say, I wanted (1) an anapest that (2) rhymes with \"hair,\" I could query that, and be given a list of anapests that rhyme with \"hair\" (e.g. \"billionaire\" \"debonair\" \"laissez-faire\") but leaves out non-anapests (e.g. \"leisurewear\"). \r\n\r\nBut I know this is complicated. For now just seeing the complete list of rhymes would be great!",
"title": null,
"type": "comment"
}
] | 2 | 3 | 2,053 | false | false | 2,053 | false |
phpspec/phpspec | phpspec | 274,834,389 | 1,178 | {
"number": 1178,
"repo": "phpspec",
"user_login": "phpspec"
} | [
{
"action": "opened",
"author": "jakzal",
"comment_id": null,
"datetime": 1510917839000,
"masked_author": "username_0",
"text": "Fixes regression introduced by #1173 to fix #1172",
"title": "Try to load all config paths until the file exists",
"type": "issue"
},
{
"action": "created",
"author": "ciaranmcnulty",
"comment_id": 345218757,
"datetime": 1510917933000,
"masked_author": "username_1",
"text": "Thanks @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "francescolaffi",
"comment_id": 345224823,
"datetime": 1510919732000,
"masked_author": "username_2",
"text": "thanks @username_1 and @username_0! that was incredibly fast 🥇",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ciaranmcnulty",
"comment_id": 345262508,
"datetime": 1510929882000,
"masked_author": "username_1",
"text": "Should be fixed in 4.2.2 - please let us know",
"title": null,
"type": "comment"
}
] | 3 | 4 | 169 | false | false | 169 | true |
dlemstra/line-bot-sdk-dotnet | null | 343,880,557 | 8 | {
"number": 8,
"repo": "line-bot-sdk-dotnet",
"user_login": "dlemstra"
} | [
{
"action": "opened",
"author": "Ben67366",
"comment_id": null,
"datetime": 1532406556000,
"masked_author": "username_0",
"text": "Changes for #2 and bug fix for carousel template.",
"title": "Issues/2 added image carousel",
"type": "issue"
}
] | 2 | 2 | 1,064 | false | true | 49 | false |
huei90/angular-validation | null | 52,216,608 | 67 | null | [
{
"action": "opened",
"author": "hyades",
"comment_id": null,
"datetime": 1418807560000,
"masked_author": "username_0",
"text": "Inside ng-required we can specify an expression. So the validation only happens the expression evaluates to `true`\r\n\r\nIs such a thing possible for validator??\r\nSomething like\r\n```html\r\n<input type=\"text\" validator=\"check === true ? required : all\"\r\n```\r\n`all` is some custom validator I declared.",
"title": "Use validator like ng-required for expressions",
"type": "issue"
},
{
"action": "closed",
"author": "huei90",
"comment_id": null,
"datetime": 1422549999000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "huei90",
"comment_id": 72058971,
"datetime": 1422550009000,
"masked_author": "username_1",
"text": "reopen this if you have other question or issue",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "huei90",
"comment_id": null,
"datetime": 1422550009000,
"masked_author": "username_1",
"text": "Inside ng-required we can specify an expression. So the validation only happens the expression evaluates to `true`\r\n\r\nIs such a thing possible for validator??\r\nSomething like\r\n```html\r\n<input type=\"text\" validator=\"check === true ? required : all\"\r\n```\r\n`all` is some custom validator I declared.",
"title": "Use validator like ng-required for expressions",
"type": "issue"
},
{
"action": "closed",
"author": "huei90",
"comment_id": null,
"datetime": 1422550011000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 639 | false | false | 639 | false |
fraywing/textAngular | null | 122,919,995 | 1,008 | null | [
{
"action": "opened",
"author": "basickarl",
"comment_id": null,
"datetime": 1450433447000,
"masked_author": "username_0",
"text": "I have the textAngular:\r\n\r\n```\r\n.ta-scroll-window > .ta-bind {\r\n border: 1px solid lightgray;\r\n border-radius: 12px;\r\n height: auto;\r\n min-height: 40px;\r\n padding: 20px 20px;\r\n outline-style: none;\r\n}\r\n.ta-scroll-window > .ta-bind:focus {\r\n border: 1px solid #000000;\r\n border-radius: 12px;\r\n outline-style: none;\r\n height: 200px;\r\n transition-duration: 2s;\r\n}\r\n```\r\n\r\nSo the text area is 40px in height until the user clicks on it which it goes to 200px, I would like this to be a smooth transition over 2 seconds. I can't seem to get textAngular to work with it properly. Currently using Chrome.",
"title": "Using textAngular with css transistions",
"type": "issue"
}
] | 1 | 1 | 630 | false | false | 630 | false |
mickhansen/dottie.js | null | 55,830,897 | 17 | null | [
{
"action": "opened",
"author": "gdbtek",
"comment_id": null,
"datetime": 1422486768000,
"masked_author": "username_0",
"text": "if a key has dot in name, how do I access to it?\r\n\r\n```\r\nvar values = {\r\n some: {\r\n 'nested.with.dot': {\r\n key: 'foobar';\r\n }\r\n }\r\n}\r\n\r\ndottie.get(values, 'some.nested.with.dot.key');\r\n```",
"title": "Question: how to access to key that has dot in names?",
"type": "issue"
},
{
"action": "created",
"author": "mickhansen",
"comment_id": 71982276,
"datetime": 1422516924000,
"masked_author": "username_1",
"text": "That's not supported right now i'm afraid.\r\nNot sure how it would work, i suppose we would need some different way of saying that these dots are literal dots and not seperators.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mickhansen",
"comment_id": 74430682,
"datetime": 1424026255000,
"masked_author": "username_1",
"text": "An alternate syntax like `dottie.get(values, ['some', 'nested.with.dot', 'key'])` could probably do the trick.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mickhansen",
"comment_id": null,
"datetime": 1424864392000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "gdbtek",
"comment_id": 76005028,
"datetime": 1424884301000,
"masked_author": "username_0",
"text": "awesome! Thanks @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "domarmstrong",
"comment_id": 224558426,
"datetime": 1465384119000,
"masked_author": "username_2",
"text": "Any chance of re-opening this as a feature request. I use dottie for fields filtering on objects, and I don't know if a user is asking for ['foo', 'bar.baz'] to be able to split it up, its down to whats in the data.\r\n\r\nUser says:\r\n```\r\n'foo.bar.baz'\r\n```\r\nData has:\r\n```\r\n{ foo: { 'bar.baz': true } }\r\n```\r\n\r\nAll I can do is just `dotties.get(data, 'foo.bar.baz')`.\r\n\r\nI guess it could be unclear if you mean:\r\n{ 'foo.bar': { 'baz': true } }\r\n{ 'foo.bar.baz': true }\r\n\r\nI'd probably declare that if { 'foo.bar.baz' } exists then that path is used.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mickhansen",
"comment_id": 224559159,
"datetime": 1465384359000,
"masked_author": "username_1",
"text": "@username_2 Please open a new issue describing your usecase in more detail with examples (i'm not quite sure i get it).\r\n\r\nThis issue was resolved by providing set/get via array",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,243 | false | false | 1,243 | true |
zooniverse/Panoptes-Front-End | zooniverse | 240,760,629 | 3,919 | {
"number": 3919,
"repo": "Panoptes-Front-End",
"user_login": "zooniverse"
} | [
{
"action": "opened",
"author": "jelliotartz",
"comment_id": null,
"datetime": 1499285050000,
"masked_author": "username_0",
"text": "Fixes #3912.\r\n\r\nDescribe your changes.\r\n- remove the `workflow-viewer` folder from lab\r\n- update `router` and `workflow` to remove link and path to viewer\r\n- the current state of the workflow visualizer is preserved on a branch: https://github.com/zooniverse/Panoptes-Front-End/tree/workflow-visualizer\r\n\r\n\r\nstaged at https://remove-workflow-vis.pfe-preview.zooniverse.org/lab/1613/workflows/2591\r\n# Review Checklist\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [x] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [x] Did you deploy a staging branch?\r\n- [ ] Did you get any type checking errors from [Babel Typecheck](https://github.com/codemix/babel-plugin-typecheck)\r\n\r\n\r\n## Optional\r\n\r\n- [ ] If it's a new component, is it in ES6? Is it clear of warnings from ESLint?\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?",
"title": "Remove workflow visualizer from project builder.",
"type": "issue"
},
{
"action": "created",
"author": "CKrawczyk",
"comment_id": 313312499,
"datetime": 1499324204000,
"masked_author": "username_1",
"text": "You also need to remove the `jsPlumb` package in 2 places: \r\n\r\nhttps://github.com/zooniverse/Panoptes-Front-End/blob/3878d7fe2c99538884d8dc269196f7acd2c76860/views/index.ejs#L76\r\n\r\nhttps://github.com/zooniverse/Panoptes-Front-End/blob/3878d7fe2c99538884d8dc269196f7acd2c76860/package.json#L15\r\n\r\nThe only reason it is `index.ejs` is before the switch to webpack `jsPlumb` did not play nice with browserfy.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "srallen",
"comment_id": 313422596,
"datetime": 1499353249000,
"masked_author": "username_2",
"text": "@username_0 make sure you run `npm uninstall` to remove the jsplumb package so that the package-lock.json file gets updated too.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jelliotartz",
"comment_id": 313428498,
"datetime": 1499354437000,
"masked_author": "username_0",
"text": "thanks @username_2!",
"title": null,
"type": "comment"
}
] | 3 | 4 | 1,712 | false | false | 1,712 | true |
Roshanjossey/first-contributions | null | 281,406,094 | 1,737 | {
"number": 1737,
"repo": "first-contributions",
"user_login": "Roshanjossey"
} | [
{
"action": "opened",
"author": "Rhaiv",
"comment_id": null,
"datetime": 1513089342000,
"masked_author": "username_0",
"text": "",
"title": "Add Rhaiv to Contributors list",
"type": "issue"
},
{
"action": "created",
"author": "Roshanjossey",
"comment_id": 351071491,
"datetime": 1513089840000,
"masked_author": "username_1",
"text": "@username_0, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.\r\nCould you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?\r\n\r\n
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 636 | false | false | 636 | true |
stryker-mutator/stryker | stryker-mutator | 274,423,583 | 463 | {
"number": 463,
"repo": "stryker",
"user_login": "stryker-mutator"
} | [
{
"action": "opened",
"author": "nicojs",
"comment_id": null,
"datetime": 1510818708000,
"masked_author": "username_0",
"text": "Use a slightly more low level api to parse typescript files so we can force typescript to set parent nodes. This is usefull for creating node mutators, as we can use information about the parent to determine what tho mutate.",
"title": "refactor(typescript): Set parent nodes",
"type": "issue"
},
{
"action": "created",
"author": "nicojs",
"comment_id": 344843056,
"datetime": 1510818829000,
"masked_author": "username_0",
"text": "@mscharley would you mind taking a look as reviewer?",
"title": null,
"type": "comment"
}
] | 1 | 2 | 276 | false | false | 276 | false |
python-tls/tls | python-tls | 235,452,862 | 139 | null | [
{
"action": "opened",
"author": "markrwilliams",
"comment_id": null,
"datetime": 1497336748000,
"masked_author": "username_0",
"text": "Not `#cryptography-dev`",
"title": "Travis notifications should go to the new IRC channel",
"type": "issue"
},
{
"action": "closed",
"author": "ashfall",
"comment_id": null,
"datetime": 1497357824000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 23 | false | false | 23 | false |
mruby/mruby | mruby | 11,578,713 | 929 | {
"number": 929,
"repo": "mruby",
"user_login": "mruby"
} | [
{
"action": "opened",
"author": "cremno",
"comment_id": null,
"datetime": 1362244570000,
"masked_author": "username_0",
"text": "``` ruby\nTime.at(-1) # => ïD$♦ ░`☻ Sat -1 -1:-1:-1 1899\nTime.at(100) - 101 # => ïD$♦ ░`☻ Sat -1 -1:-1:-1 1899\n```\n\nI added a check to mrb_time_make that'll raise an ArgumentError instead.",
"title": "mruby-time: add check to prevent invalid time",
"type": "issue"
},
{
"action": "created",
"author": "matz",
"comment_id": 840556366,
"datetime": 1620911973000,
"masked_author": "username_1",
"text": "We are still making effort to use negative `time_t` if possible, to represent my birthday time (I am an old man).",
"title": null,
"type": "comment"
}
] | 2 | 2 | 302 | false | false | 302 | false |
pingcap/tidb | pingcap | 205,806,189 | 2,603 | {
"number": 2603,
"repo": "tidb",
"user_login": "pingcap"
} | [
{
"action": "opened",
"author": "tiancaiamao",
"comment_id": null,
"datetime": 1486451612000,
"masked_author": "username_0",
"text": "reuse pattern match code in stringutil\r\n\r\n@hanfei1991 @username_1 @zimulala",
"title": "privilege/privileges: use stringutil for like pattern match",
"type": "issue"
},
{
"action": "created",
"author": "coocood",
"comment_id": 277924593,
"datetime": 1486453560000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "coocood",
"comment_id": 277935488,
"datetime": 1486457082000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 2 | 3 | 80 | false | false | 80 | true |
ianrabt/wpa | null | 371,792,074 | 9 | null | [
{
"action": "opened",
"author": "ango0512",
"comment_id": null,
"datetime": 1539919304000,
"masked_author": "username_0",
"text": "",
"title": "Create sign out button on settings page",
"type": "issue"
},
{
"action": "closed",
"author": "ianrabt",
"comment_id": null,
"datetime": 1540529244000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
aspnet/EntityFrameworkCore | aspnet | 299,812,769 | 11,049 | null | [
{
"action": "opened",
"author": "ajcvickers",
"comment_id": null,
"datetime": 1519411795000,
"masked_author": "username_0",
"text": "From VS Feedback:\r\n\r\nafter calling:\r\ncontext.Database.EnsureDeleted(); \r\n\r\napp break on error -> \r\n\"The convention invocations have reached the recursion limit. This is likely an issue in EF Core, please report it.\"",
"title": "Context.Database.EnsureDeleted(); error -> The convention invocations have reached the recursion limit. This is likely an issue in EF Core, please report it.",
"type": "issue"
},
{
"action": "created",
"author": "ajcvickers",
"comment_id": 368103627,
"datetime": 1519411847000,
"masked_author": "username_0",
"text": "Ideally include a complete code listing that we can run to reproduce the issue.\r\nAlternatively, you can provide a project/solution that we can run.\r\n\r\nBTW we're not just doing this to be mean :smile:... we get a lot traffic on this project and it takes time to attempt to reproduce an issue based on fragments of information. In addition, our attempt is often unsuccessful as the exact conditions required to hit the issue are often not explicitly included in the code provided. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we ask that folks give us a self-contained way to reproduce an issue.\r\n\r\nFor a guide on submitting good bug reports, read [Painless Bug Tracking](http://www.joelonsoftware.com/articles/fog0000000029.html). \r\n\r\n*BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.*",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ajcvickers",
"comment_id": 370010787,
"datetime": 1520015428000,
"masked_author": "username_0",
"text": "**EF Team Triage:** Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.\r\n\r\n*BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.*",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ajcvickers",
"comment_id": null,
"datetime": 1520015429000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 4 | 1,949 | false | false | 1,949 | false |
eifuentes/swae-pytorch | null | 342,876,919 | 3 | null | [
{
"action": "opened",
"author": "Audrius-St",
"comment_id": null,
"datetime": 1532032005000,
"masked_author": "username_0",
"text": "`encoded_samples` is a `<Tensor, len() = 500>` with `is_cuda: True` whereas\r\n`projections` is a `<Tensor, len() = 50>` with `is_cuda: False`\r\n\r\nSystem:\r\nPyTorch 0.4.0\r\nCUDA 9.0\r\nPython 3.6.3 Anaconda/Intel\r\nVS Code 1.25.1\r\nUbuntu Linux 18.04 x64\r\n\r\nRegards.",
"title": "CUDA issue. Exception: RuntimeError in _sliced_wasserstein_distance",
"type": "issue"
},
{
"action": "created",
"author": "eifuentes",
"comment_id": 406654397,
"datetime": 1532104313000,
"masked_author": "username_1",
"text": "thanks for logging the bug, oversight on my part, will fix soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Audrius-St",
"comment_id": 406677453,
"datetime": 1532109042000,
"masked_author": "username_0",
"text": "to try and address this issue. Attached in the following post for your consideration and review. After these change, the code now runs without error message to completion: 30 epochs.\r\n\r\nAdded an additional argument to `sliced_wasserstein_distance` to pass the device type and propagated it.\r\n\r\n```\r\ndef eval_on_batch(self, x):\r\n . . .\r\n w2 = float(self.weight_swd) * sliced_wasserstein_distance(\r\n z,\r\n self._distribution_fn,\r\n self.num_projections_,\r\n self.p_,\r\n self._device)\r\n```\r\n```\r\ndef sliced_wasserstein_distance(encoded_samples,\r\n distribution_fn=rand_cirlce2d,\r\n num_projections=50,\r\n p=2,\r\n device='cpu'):\r\n . . . \r\n z = distribution_fn(batch_size).to(device)\r\n # approximate wasserstein_distance between encoded and prior distributions\r\n # for average over each projection\r\n swd = _sliced_wasserstein_distance(\r\n encoded_samples,\r\n z,\r\n num_projections,\r\n p,\r\n device)\r\n```\r\n```\r\ndef _sliced_wasserstein_distance(encoded_samples,\r\n distribution_samples,\r\n num_projections=50,\r\n p=2,\r\n device='cpu'):\r\n . . . \r\n # generate random projections in latent space\r\n projections = rand_projections(embedding_dim, num_projections).to(device)\r\n . . .\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Audrius-St",
"comment_id": 406678302,
"datetime": 1532109197000,
"masked_author": "username_0",
"text": "```\r\nimport numpy as np\r\nimport torch\r\nimport torch.nn.functional as F\r\n\r\nfrom .distributions import rand_cirlce2d\r\n\r\n\r\ndef rand_projections(embedding_dim, num_samples=50):\r\n \"\"\"This fn generates `L` random samples from the latent space's unit sphere.\r\n\r\n Args:\r\n embedding_dim (int): embedding dimension size\r\n num_samples (int): number of random projection samples\r\n\r\n Return:\r\n torch.Tensor\r\n \"\"\"\r\n theta = [w / np.sqrt((w**2).sum())\r\n for w in np.random.normal(size=(num_samples, embedding_dim))]\r\n theta = np.asarray(theta)\r\n return torch.from_numpy(theta).type(torch.FloatTensor)\r\n\r\n\r\ndef _sliced_wasserstein_distance(encoded_samples,\r\n distribution_samples,\r\n num_projections=50,\r\n p=2,\r\n device='cpu'):\r\n \"\"\"Sliced Wasserstein Distance between encoded samples and drawn\r\n distribution samples.\r\n\r\n Args:\r\n encoded_samples (toch.Tensor): embedded training tensor samples\r\n distribution_samples (torch.Tensor): distribution training tensor\r\n samples\r\n num_projections (int): number of projectsion to approximate sliced\r\n wasserstein distance\r\n p (int): power of distance metric\r\n device: 'cuda' or 'cpu' (default 'cpu')\r\n\r\n Return:\r\n torch.Tensor\r\n \"\"\"\r\n # derive latent space dimension size from random samples drawn from a\r\n # distribution in it\r\n embedding_dim = distribution_samples.size(1)\r\n # generate random projections in latent space\r\n projections = rand_projections(embedding_dim, num_projections).to(device)\r\n # calculate projection of the encoded samples\r\n encoded_projections = encoded_samples.matmul(projections.transpose(0, 1))\r\n # calculate projection of the random distribution samples\r\n distribution_projections = (\r\n distribution_samples.matmul(projections.transpose(0, 1)))\r\n # calculate the sliced wasserstein distance by\r\n # sorting the samples per projection and\r\n # calculating the difference between the\r\n # encoded samples and drawn samples per projection\r\n wasserstein_distance = (\r\n torch.sort(encoded_projections.transpose(0, 1), dim=1)[0] -\r\n torch.sort(distribution_projections.transpose(0, 1), dim=1)[0])\r\n # distance between them (L2 by default for Wasserstein-2)\r\n wasserstein_distance_p = torch.pow(wasserstein_distance, p)\r\n # approximate wasserstein_distance for each projection\r\n return wasserstein_distance_p.mean()\r\n\r\n\r\ndef sliced_wasserstein_distance(encoded_samples,\r\n distribution_fn=rand_cirlce2d,\r\n num_projections=50,\r\n p=2,\r\n device='cpu'):\r\n \"\"\"Sliced Wasserstein Distance between encoded samples and drawn\r\n distribution samples.\r\n\r\n Args:\r\n encoded_samples (toch.Tensor): embedded training tensor samples\r\n distribution_fn (callable): callable to draw random samples\r\n num_projections (int): number of projectsion to approximate sliced\r\n Wasserstein distance\r\n p (int): power of distance metric\r\n device: 'cuda' or 'cpu' (default 'cpu')\r\n\r\n Return:\r\n torch.Tensor\r\n \"\"\"\r\n # derive batch size from encoded samples\r\n batch_size = encoded_samples.size(0)\r\n # draw samples from latent space prior distribution\r\n z = distribution_fn(batch_size).to(device)\r\n # approximate wasserstein_distance between encoded and prior distributions\r\n # for average over each projection\r\n swd = _sliced_wasserstein_distance(\r\n encoded_samples,\r\n z,\r\n num_projections,\r\n p,\r\n device)\r\n return swd\r\n\r\n\r\nclass SWAEBatchTrainer:\r\n \"\"\"Sliced Wasserstein Autoencoder Batch Trainer.\r\n\r\n Args:\r\n autoencoder (torch.nn.Module): module which implements autoencoder\r\n framework\r\n optimizer (torch.optim.Optimizer): torch optimizer\r\n distribution_fn (callable): callable to draw random samples\r\n num_projections (int): number of projectsion to approximate sliced\r\n Wasserstein distance\r\n p (int): power of distance metric\r\n weight_swd (float): weight of divergence metric compared to\r\n reconstruction in loss\r\n device (torch.Device): torch device\r\n \"\"\"\r\n def __init__(self, autoencoder, optimizer, distribution_fn,\r\n num_projections=50, p=2, weight_swd=10.0, device=None):\r\n self.model_ = autoencoder\r\n self.optimizer = optimizer\r\n self._distribution_fn = distribution_fn\r\n self.embedding_dim_ = self.model_.encoder.embedding_dim_\r\n self.num_projections_ = num_projections\r\n self.p_ = p\r\n self.weight_swd = weight_swd\r\n self._device = device if device else torch.device('cpu')\r\n\r\n def __call__(self, x):\r\n return self.eval_on_batch(x)\r\n\r\n def train_on_batch(self, x):\r\n # reset gradients\r\n self.optimizer.zero_grad()\r\n # autoencoder forward pass and loss\r\n evals = self.eval_on_batch(x)\r\n # backpropagate loss\r\n evals['loss'].backward()\r\n # update encoder and decoder parameters\r\n self.optimizer.step()\r\n return evals\r\n\r\n def test_on_batch(self, x):\r\n # reset gradients\r\n self.optimizer.zero_grad()\r\n # autoencoder forward pass and loss\r\n evals = self.eval_on_batch(x)\r\n return evals\r\n\r\n def eval_on_batch(self, x):\r\n x = x.to(self._device)\r\n recon_x, z = self.model_(x)\r\n bce = F.binary_cross_entropy(recon_x, x)\r\n l1 = F.l1_loss(recon_x, x)\r\n w2 = float(self.weight_swd) * sliced_wasserstein_distance(\r\n z,\r\n self._distribution_fn,\r\n self.num_projections_,\r\n self.p_,\r\n self._device)\r\n loss = bce + l1 + w2\r\n return {'loss': loss,\r\n 'bce': bce,\r\n 'l1': l1,\r\n 'w2': w2,\r\n 'encode': z,\r\n 'decode': recon_x}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eifuentes",
"comment_id": 407488187,
"datetime": 1532453502000,
"masked_author": "username_1",
"text": "thanks @username_0 , if you'd like feel free to put this in a pull request and i can merge it to master",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "eifuentes",
"comment_id": null,
"datetime": 1532563569000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "eifuentes",
"comment_id": 407934511,
"datetime": 1532563569000,
"masked_author": "username_1",
"text": "@username_0 merged #5, should resolve the issue. thanks again.",
"title": null,
"type": "comment"
}
] | 2 | 7 | 8,695 | false | false | 8,695 | true |
tower-rs/tower-h2 | tower-rs | 284,649,817 | 11 | null | [
{
"action": "opened",
"author": "carllerche",
"comment_id": null,
"datetime": 1514351221000,
"masked_author": "username_0",
"text": "",
"title": "Upload docs to github pages.",
"type": "issue"
},
{
"action": "created",
"author": "hawkw",
"comment_id": 354184403,
"datetime": 1514412258000,
"masked_author": "username_1",
"text": "What about referring to [docs.rs](https://docs.rs/) instead?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seanmonstar",
"comment_id": 354184865,
"datetime": 1514412511000,
"masked_author": "username_2",
"text": "Certainly, but can only be done with released versions. It's useful to have a place to look for \"master\" docs.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hawkw",
"comment_id": 354186419,
"datetime": 1514413398000,
"masked_author": "username_1",
"text": "@username_2 that's fair, good point.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 207 | false | false | 207 | true |
ianmcnally/react-currency-masked-input | null | 215,314,831 | 15 | null | [
{
"action": "opened",
"author": "rublev",
"comment_id": null,
"datetime": 1489974480000,
"masked_author": "username_0",
"text": "",
"title": "How do you add commas?",
"type": "issue"
},
{
"action": "created",
"author": "ianmcnally",
"comment_id": 288216691,
"datetime": 1490129956000,
"masked_author": "username_1",
"text": "It's not possible yet. A pull request would be most welcome. Otherwise, I can put it on the backlog.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rublev",
"comment_id": 288228501,
"datetime": 1490132600000,
"masked_author": "username_0",
"text": "@username_1 patrickkee committed some code that looks like added commas, what's wrong with this? https://github.com/username_1/react-currency-masked-input/pull/7",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ianmcnally",
"comment_id": 288871553,
"datetime": 1490305858000,
"masked_author": "username_1",
"text": "#7 was never finished (failing tests), so I never reviewed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ianmcnally",
"comment_id": 494808946,
"datetime": 1558532698000,
"masked_author": "username_1",
"text": "This was added in #41",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ianmcnally",
"comment_id": null,
"datetime": 1558532699000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 344 | false | false | 344 | true |
jameskbride/cmake-hello-world | null | 269,492,981 | 5 | {
"number": 5,
"repo": "cmake-hello-world",
"user_login": "jameskbride"
} | [
{
"action": "opened",
"author": "mariochoto",
"comment_id": null,
"datetime": 1509344579000,
"masked_author": "username_0",
"text": "",
"title": "Update HelloWorld.cpp",
"type": "issue"
},
{
"action": "created",
"author": "jameskbride",
"comment_id": 340402801,
"datetime": 1509359023000,
"masked_author": "username_1",
"text": "Hi @username_0, thanks for the PR. This project is more about what is happening with CMake than it is about the actual code. That said these Speaker files are necessary as they help to illustrate how to work with headers and cpp files in the CMake file.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 255 | false | false | 255 | true |
psu-stewardship/scholarsphere | psu-stewardship | 246,343,864 | 1,015 | null | [
{
"action": "opened",
"author": "cam156",
"comment_id": null,
"datetime": 1501247648000,
"masked_author": "username_0",
"text": "refs #703\n\n1. New collection with new batch works\nFeedback needed. Redirects to new collection but shows no works.\n1. Existing collection with new batch works\nSame as 2.\n\nThere should be feedback to the user while the items upload",
"title": "Collection feedback with batch upload",
"type": "issue"
},
{
"action": "created",
"author": "cam156",
"comment_id": 367370684,
"datetime": 1519228180000,
"masked_author": "username_0",
"text": "A redirect from the batch should include an flash message that says items are being added in the background.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cam156",
"comment_id": null,
"datetime": 1523022206000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 338 | false | false | 338 | false |
osama-raddad/FireCrasher | null | 155,109,661 | 1 | {
"number": 1,
"repo": "FireCrasher",
"user_login": "osama-raddad"
} | [
{
"action": "opened",
"author": "samerzmd",
"comment_id": null,
"datetime": 1463429049000,
"masked_author": "username_0",
"text": "",
"title": "i have just thrown an Exception XD",
"type": "issue"
},
{
"action": "created",
"author": "osama-raddad",
"comment_id": 219630151,
"datetime": 1463466364000,
"masked_author": "username_1",
"text": "thanks",
"title": null,
"type": "comment"
}
] | 2 | 2 | 6 | false | false | 6 | false |
Eonasdan/bootstrap-datetimepicker | null | 280,009,795 | 2,208 | null | [
{
"action": "opened",
"author": "martinko2009",
"comment_id": null,
"datetime": 1512625831000,
"masked_author": "username_0",
"text": "This repo is no longer actively monitor or supported. All future work is being done to https://github.com/tempusdominus/bootstrap-3\r\n\r\nwhen I select one date, then I get the date like 12/07/0000 12:00 AM, after that, I delete some words to '12' by keyboard, It became 12/01/0000 12:00 AM.\r\n\r\nyou can get the problem by [https://eonasdan.github.io/bootstrap-datetimepicker/](url)\r\n\r\nSometimes I want to input the date manually by keyboard. When I input some date to half, the component begins to transform the string to date. I hope that the component doesn't transform the date, and return this string when user input some dates which format is not fit to the format.",
"title": "when I select one date, then del some words to '12' by keyboard, It became 12/01/0000 12:00 AM",
"type": "issue"
},
{
"action": "closed",
"author": "William-H-M",
"comment_id": null,
"datetime": 1512649800000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "William-H-M",
"comment_id": 349953545,
"datetime": 1512649800000,
"masked_author": "username_1",
"text": "http://eonasdan.github.io/bootstrap-datetimepicker/Options/#keepinvalid\r\n\r\nStill if you use format with hour you WILL (**_IF_** the original format) need to somehow put an hour even if using `keepInvalid`",
"title": null,
"type": "comment"
}
] | 2 | 3 | 875 | false | false | 875 | false |
ipfs/js.ipfs.io | ipfs | 382,089,081 | 207 | null | [
{
"action": "opened",
"author": "daviddias",
"comment_id": null,
"datetime": 1542612682000,
"masked_author": "username_0",
"text": "<img width=\"590\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1211152/48692195-79deb500-ebd5-11e8-8858-0b1e14be0738.png\">",
"title": "Still using js-ipfs 0.31.7 ??",
"type": "issue"
},
{
"action": "created",
"author": "daviddias",
"comment_id": 439796717,
"datetime": 1542612714000,
"masked_author": "username_0",
"text": "Also the list of CIDs is always empty:\r\n\r\n<img width=\"560\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1211152/48692218-895dfe00-ebd5-11e8-9e1c-05422c7777b9.png\">\r\n\r\nEven after loading all the examples",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "daviddias",
"comment_id": 439796900,
"datetime": 1542612755000,
"masked_author": "username_0",
"text": "Also, just noticed:\r\n\r\n<img width=\"496\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1211152/48692247-a7c3f980-ebd5-11e8-9162-30bd6bff9c9e.png\">",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PedroMiguelSS",
"comment_id": 439854445,
"datetime": 1542625292000,
"masked_author": "username_1",
"text": "I've talked with @username_2 as this is related to [`service-worker-gateway`](https://github.com/ipfs-shipyard/service-worker-gateway). He can't check it today but he will do it tomorrow. \r\n\r\n### About the version:\r\n- He will bump it manually and check if everything's ok. \r\n\r\n### About empty CIDs list:\r\n- I've tested it on `Chrome`, by visiting [peerpad](https://js.ipfs.io/ipfs/QmXRTzu4dUFnA1nLR7ogifE1EeY2hEsVyQNkZu4CzF6g2v) and it went well for me\r\n<img width=\"1413\" alt=\"screen shot 2018-11-19 at 10 27 45\" src=\"https://user-images.githubusercontent.com/11461281/48701254-f4173580-ebe5-11e8-8734-a435abc40683.png\">\r\n\r\n- Although it has worked for me, @username_2 also said this is a known problem for him on `Firefox`. He will take a look at this problem tomorrow. \r\n\r\n### About repo size\r\n- We will check what's happening with the repo size.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasco-santos",
"comment_id": 440024320,
"datetime": 1542657895000,
"masked_author": "username_2",
"text": "So, regarding the `ipfs` version, I created a PR upgrading the dependencies [ipfs-shipyard/service-worker-gateway#31](https://github.com/ipfs-shipyard/service-worker-gateway/pull/31). @username_1 already test this in `js.ipfs.io` and it seems everything working properly. Once the next deploy occurs it will be using the latest version of `js-ipfs`.\r\n\r\nAbout the repo size, I went through the code, and it seems that `jsipfs repo stat` command leads to a `no limit` size, as you can see [js-ipfs-repo/src/index.js#L281](https://github.com/ipfs/js-ipfs-repo/blob/master/src/index.js#L281). @username_0 Should I remove that part and maintain only the repo size?\r\n\r\nFinally, regarding the list of `CIDs` that's a result of firefox using a specific process per tab (for service workers), instead of using its own like chrome and safari. I have an initial implementation for solving this issue, but I did not finish it yet. I am trying to use `indexDB` for storing that data across all the tabs, but then I was having problems with atomic operations between tabs. I will try to finish it during this week.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "daviddias",
"comment_id": 441206408,
"datetime": 1542969389000,
"masked_author": "username_0",
"text": "Got it. The UI is what is kind of weird. First the way that the numbers are displayed is super non informative and second If such limit is passed (or lack of thereof), better say not defined than 8PB",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "vasco-santos",
"comment_id": null,
"datetime": 1543589876000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 7 | 2,663 | false | false | 2,663 | true |
karma-runner/karma | karma-runner | 217,610,058 | 2,632 | null | [
{
"action": "opened",
"author": "shirakaba",
"comment_id": null,
"datetime": 1490716869000,
"masked_author": "username_0",
"text": "### Expected behaviour\r\n\r\nShould be able to import a module without an error being thrown.\r\n\r\n### Actual behaviour\r\n\r\nKarma runner reports an error: `\"TypeError: FailingModule_1.FailingModule is undefined\"`\r\n\r\n### Environment Details\r\n\r\n- Karma version (output of `karma --version`): 1.5.0\r\n\r\n```\r\nvar path = require(\"path\");\r\nvar webpackConfig = require(\"./webpack.config\");\r\n\r\nmodule.exports = function(config) {\r\n config.set({\r\n autoWatch: true,\r\n basePath: \"\",\r\n browsers: [\"Firefox\"],\r\n colors: true,\r\n files: [\"tests/*.ts\"],\r\n frameworks: [\"mocha\", \"chai\", \"sinon\"],\r\n logLevel: config.LOG_INFO,\r\n plugins: [\"karma-*\"],\r\n port: 9876,\r\n preprocessors: {\r\n \"tests/*.ts\": [\"webpack\"]\r\n },\r\n reporters: [\"mocha\"],\r\n singleRun: false,\r\n webpack: {\r\n module: webpackConfig.module,\r\n resolve: webpackConfig.resolve\r\n }\r\n });\r\n};\r\n```\r\n\r\n### Steps to reproduce the behaviour\r\n\r\n1. Create a module `FailingModule.ts` with inner classes:\r\n\r\n```\r\n// Note: changing the wording to \"export namespace\" made no difference to the error.\r\nexport module FailingModule {\r\n export class Clazz {\r\n public static dummy() : string { return \"dummy\"; }\r\n }\r\n}\r\n```\r\n\r\n2. Create a module `WorkingModule.ts` without inner classes, for comparison:\r\n\r\n```\r\nexport class WorkingClazz {\r\n public static dummy() : string { return \"dummy\"; }\r\n}\r\n```\r\n\r\n3. Import both modules in a Karma test and see that importing `WorkingModule` throws no error, yet `FailingModule` does:\r\n\r\n```\r\nimport {WorkingClazz} from \"../src/WorkingModule\"; // Karma can run this import.\r\nimport {FailingModule} from \"../src/FailingModule\"; // Karma throws error upon this import.\r\nimport Clazz = FailingModule.Clazz;\r\n\r\ndescribe(\"Run WorkingClazz & FailingModule.Clazz\", () => {\r\n it(\"Karma should run test suite without throwing an import error.\", function(){\r\n WorkingClazz.dummy();\r\n Clazz.dummy();\r\n });\r\n});\r\n```\r\n\r\nKarma can import my other classes (which are not nested inside a declared module), just fine, and such tests do pass; it's just this specific case. Am I declaring my module/imports incorrectly, or is my configuration wrong somewhere? Thanks for any help.\r\n\r\n**Note:** other supporting files like webpack configuration all transcribed on this [StackOverflow post](http://stackoverflow.com/questions/43074121/karma-typescript-webpack-module-namespace-imports-fail-but-only-during-kar).",
"title": "Karma + Typescript + Webpack: Module/namespace imports fail, but only during karma tests",
"type": "issue"
},
{
"action": "created",
"author": "maksimr",
"comment_id": 289874263,
"datetime": 1490728322000,
"masked_author": "username_1",
"text": "@username_0 looks like a problem not in **karma** itself.\r\nI think the problem in misconfiguration of webpack + typescript. \r\nTry pass full **webpackConfig** in karma.config:\r\n\r\n```js\r\nwebpack: webpackConfig\r\n```\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shirakaba",
"comment_id": 290026698,
"datetime": 1490777712000,
"masked_author": "username_0",
"text": "@username_1 Thanks for coming to help out! Unfortunately, passing the full webpackConfig produces no change in the situation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maksimr",
"comment_id": 290027661,
"datetime": 1490777946000,
"masked_author": "username_1",
"text": "@username_0 what browser(launcher) do you use?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shirakaba",
"comment_id": 290031695,
"datetime": 1490778932000,
"masked_author": "username_0",
"text": "Above is a simplified configuration, but to be exact, I use Firefox 49.0.2 (the latest version is Firefox 52 or something), with a custom launcher config to prevent it auto-updating (this is the browser I am forced to use for television-related development):\r\n\r\n browsers: [\"FirefoxDev\"],\r\n customLaunchers: {\r\n FirefoxDev: {\r\n base: 'Firefox', // I have named Firefox 49.0.2 to just 'Firefox'\r\n prefs: {\r\n 'app.update.auto' : false,\r\n 'app.update.enabled' : false,\r\n 'app.update.silent' : false,\r\n 'xpinstall.signatures.required' : false\r\n },\r\n extensions: []\r\n }\r\n }\r\n\r\nIn the past, I have tried to use Chrome, but it said \"no tests in file\", so I'm stuck using the browser that I do my development on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shirakaba",
"comment_id": 297006825,
"datetime": 1493121448000,
"masked_author": "username_0",
"text": "I've found the root of the problem, and an undesirable workaround. I'll explain the situation more clearly this time. My detailed setup for tsconfig, webpack, and karma is described – as before – in this [StackOverflow post](http://stackoverflow.com/questions/43074121/karma-typescript-webpack-module-namespace-imports-fail-but-only-during-kar) if needed, but the main steps for reproduction are as follows:\r\n\r\n# Setup\r\n\r\n### ModuleWithInnerClass.ts\r\n\r\n```\r\nexport module A {\r\n export class B {\r\n public static hello() : string { return \"hello\"; }\r\n }\r\n}\r\n```\r\n\r\n### FailureCase.ts\r\n\r\n```\r\nimport {A} from \"./ModuleWithInnerClass\";\r\nimport B = A.B; // We create an alias for the inner class. Karma fails here.\r\nB.hello();\r\n```\r\n\r\n# Problem\r\n\r\nIf no test runner is involved, this TypeScript code compiles (via `ts-loader`) and bundles (via Webpack) to produce code that runs perfectly in a browser without error.\r\n\r\nHowever, when Karma is involved, it gives the error \"TypeError: A_1.B is undefined\". Here is my Karma invocation: `/usr/local/bin/node /Applications/WebStorm.app/Contents/plugins/js-karma/js_reporter/karma-intellij/lib/intellijServer.js --karmaPackageDir=/Users/me/project/node_modules/karma --configFile=/Users/me/project/karma.conf.js\r\n`.\r\n\r\n# Workaround\r\n\r\nRemove the `import B = A.B;` aliasing line and instead write the namespace in manually: `A.B.hello()`.\r\n\r\nThis is undesirable because it requires a huge amount of refactoring and means that my code has to accommodate my test runner, rather than the other way around. What is causing Karma to be unable to import inner classes of modules, and can we fix this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "songguangyu",
"comment_id": 309372002,
"datetime": 1497860625000,
"masked_author": "username_2",
"text": "import {B} from 'C';\r\nexport default class A extends B {\r\n}\r\nCannot read property 'B' of undefined",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "devoto13",
"comment_id": null,
"datetime": 1590279207000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "devoto13",
"comment_id": 633157258,
"datetime": 1590279207000,
"masked_author": "username_3",
"text": "I'm unable to reproduce this issue using the provided reproduction. I'm using latest WebStorm and latest Firefox though. As there were a lot of changes both to Karma and to other moving parts I would assume that the issue has been fixed in the meantime. Please open a new issue with the fresh reproduction if you still experience this problem.",
"title": null,
"type": "comment"
}
] | 4 | 9 | 5,891 | false | false | 5,891 | true |
BrightcoveOS/Roku-Sample-App | BrightcoveOS | 17,666,957 | 3 | null | [
{
"action": "opened",
"author": "aaroncolon",
"comment_id": null,
"datetime": 1375748031000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI'm having some trouble side-loading this application to my Roku XD:\r\n\r\n1. I've only modified the Config.brs with my Brightcove credentials per the readme and left everything else untouched\r\n2. I've created the brightcoveplayer.zip using \"make\" (I'm on OS X)\r\n3. Upon attempting to side-load to my Roku via my browser I receive this message: \"Application Received: 238558 bytes stored. Install Failure: Compilation Failed.\"\r\n4. Additionally, after setting my ROKU_DEV_TARGET variable, I've also tried using the \"make install\" command but receive a similar message: \"Install Failure: Compilation Failed. < / font >\" (yes, the < / font > tag is included in the failure message).\r\n\r\nWhat am I missing?\r\n\r\nThanks,\r\nAaron",
"title": "Unable to side-load / install to Roku",
"type": "issue"
},
{
"action": "created",
"author": "bdeitte",
"comment_id": 97096032,
"datetime": 1430233297000,
"masked_author": "username_1",
"text": "Hi @username_0 sorry for an insanely late reply. As you may have noticed this app didn't really have an owner. I'm trying to make some fixes up this week, and you may be happy to know that things are now working here in https://github.com/username_1/Roku-Sample-App (two years later, again apologies!)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bdeitte",
"comment_id": 97532625,
"datetime": 1430332093000,
"masked_author": "username_1",
"text": "This should be fixed with https://github.com/BrightcoveOS/Roku-Sample-App/pull/8",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bdeitte",
"comment_id": null,
"datetime": 1430332093000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 1,106 | false | false | 1,106 | true |
kurtbrose/pyjks | null | 253,620,255 | 34 | null | [
{
"action": "opened",
"author": "juhtie01",
"comment_id": null,
"datetime": 1504005703000,
"masked_author": "username_0",
"text": "Our application creates JKS files using PyJKS version 17.1.0 using the following method: \r\n\r\n```\r\ndef jks_key(alias: str, chain: list, key_der: bytes, passphrase: str) -> bytes:\r\n \"\"\" generate a java keystore with an alias for the given key \"\"\"\r\n\r\n pke = jks.PrivateKeyEntry.new(alias, chain, key_der, 'rsa_raw')\r\n keystore = jks.KeyStore.new('jks', [pke])\r\n return keystore.saves(passphrase)\r\n```\r\n\r\nUp until recently the JKS files have worked well, and our Java application could read and decrypt the private key using the provided passphrase.\r\n\r\nSince the `pyasn1` module was updated to version 0.3.2 and `pyasn1-modules` to version 0.0.11, the JKS files created by the application no longer work. The passphrase can decrypt the JKS itself, but cannot decrypt the private key within it anymore.\r\n\r\nhttp://pyjks.readthedocs.io/en/latest/jks.html#jks.jks.KeyStore.saves states: \"If any of the private keys are unencrypted, they will be encrypted with the same password as the keystore.\" This statement does not seem to hold true anymore.",
"title": "Unencrypted private keys in JKS files cannot be decrypted with the JKS passphrase",
"type": "issue"
},
{
"action": "created",
"author": "voetsjoeba",
"comment_id": 325747314,
"datetime": 1504030112000,
"masked_author": "username_1",
"text": "Issue appears to be introduced between 0.3.1 and 0.3.2 of pyasn1.\r\n\r\nAt first glance, this looks like it may be a regression introduced in 0.3.2. Version 0.3.1 is the first release in the 0.3.x branch and was released only about a month ago, and has received two regression fixes so far -- the last only 3 days ago with the release of 0.3.3, and it looks like a fourth one is underway on the main branch.\r\n\r\nNaturally, I'll check if I can find anything we're doing wrong on our side. But my initial advice would be: step away from the bleeding edge, revert to 0.3.1 (which seems to be working fine) and give pyasn1 some time to work things out in 0.3.x.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "juhtie01",
"comment_id": 326959704,
"datetime": 1504530582000,
"masked_author": "username_0",
"text": "Thanks for the info! We ended up pinning pyasn1 and pyasn1-modules versions for our tool to known-working versions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mindw",
"comment_id": 331688146,
"datetime": 1506230790000,
"masked_author": "username_2",
"text": "The relevant JDK error:\r\n```\r\nkeytool -importkeystore -srckeystore bootstrap.jks -destkeystore bootstrap.p12 -deststoretype PKCS12 -srcalias bootstrap -deststorepass <PASS> -destkeypass <PASS> -srcstorepass <PASS> -srckeypass <PASS>\r\nkeytool error: java.security.UnrecoverableKeyException: excess private key\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mahmoud",
"comment_id": 342366708,
"datetime": 1510026145000,
"masked_author": "username_3",
"text": "Hey all, can anyone share code to reproduce this? Or let me know if the newest version of pyasn1 still has this issue? [There have been several releases lately](https://github.com/etingof/pyasn1/blob/master/CHANGES.rst), and I want to know if this is still an issue. If so, we can/should propagate it up the pyasn1 itself perhaps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "juhtie01",
"comment_id": 342392753,
"datetime": 1510037891000,
"masked_author": "username_0",
"text": "The code we use to generate the keystores is in the first comment. The `keytool` command to reproduce the error are in @username_2's comment just above you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "magnuswatn",
"comment_id": 350561923,
"datetime": 1512924920000,
"masked_author": "username_4",
"text": "This broke by: https://github.com/etingof/pyasn1/commit/6fa0e312ea80713983b1a3c1e4529e7452b0e0fe\r\n\r\nThe problem is that the optional attributes field in the PrivateKeyInfo is now being included without anything in it. Before:\r\n```\r\n 0:d=0 hl=4 l=1213 cons: SEQUENCE \r\n 4:d=1 hl=2 l= 1 prim: INTEGER :00\r\n 7:d=1 hl=2 l= 13 cons: SEQUENCE \r\n 9:d=2 hl=2 l= 9 prim: OBJECT :rsaEncryption\r\n 20:d=2 hl=2 l= 0 prim: NULL \r\n 22:d=1 hl=4 l=1191 prim: OCTET STRING [HEX DUMP]:308204A3...\r\n\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n 0:d=0 hl=4 l=1215 cons: SEQUENCE \r\n 4:d=1 hl=2 l= 1 prim: INTEGER :00\r\n 7:d=1 hl=2 l= 13 cons: SEQUENCE \r\n 9:d=2 hl=2 l= 9 prim: OBJECT :rsaEncryption\r\n 20:d=2 hl=2 l= 0 prim: NULL \r\n 22:d=1 hl=4 l=1191 prim: OCTET STRING [HEX DUMP]:308204A...\r\n 1217:d=1 hl=2 l= 0 cons: cont [ 0 ] \r\n```\r\n\r\nWe can fix this in our code, but it seems strange to me that we have to. I will create a bug in pyasn1 and ask if this is how it's supposed to be. If it is, then I will create a fix.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mindw",
"comment_id": 350659808,
"datetime": 1512982373000,
"masked_author": "username_2",
"text": "ref issue etingof/pyasn1#115 .",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mahmoud",
"comment_id": 352220107,
"datetime": 1513467961000,
"masked_author": "username_3",
"text": "@username_2 +1'd. Anyone here need me to cut a release with pyasn1<0.3.2 to fix a pip install or something similar?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jcdevil",
"comment_id": 396207941,
"datetime": 1528715609000,
"masked_author": "username_5",
"text": "@here : looking at https://github.com/etingof/pyasn1/issues/115, I suppose the issue should be fixed soon : right ?\r\nOtherwise... I'm indeed interested in a release with pyasn1<0.3.2 to fix ;)\r\nThx for feedback !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "magnuswatn",
"comment_id": 398200225,
"datetime": 1529356976000,
"masked_author": "username_4",
"text": "Yes, this should be fixed soon @username_5. Sorry that it has taken forever!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mahmoud",
"comment_id": null,
"datetime": 1535767205000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 6 | 12 | 4,205 | false | false | 4,205 | true |
hdgarrood/aeson-better-errors | null | 194,872,156 | 10 | null | [
{
"action": "opened",
"author": "LiamGoodacre",
"comment_id": null,
"datetime": 1481505309000,
"masked_author": "username_0",
"text": "",
"title": "Add Alternative instance for ParseT?",
"type": "issue"
},
{
"action": "created",
"author": "hdgarrood",
"comment_id": 266418579,
"datetime": 1481545339000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "LiamGoodacre",
"comment_id": 266428496,
"datetime": 1481548614000,
"masked_author": "username_0",
"text": "-- use monoid, combine errors?\r\n-- Simply take rightmost?\r\n-- Or maybe take the one with the deepest path?\r\n--\r\n-- Or, export our own (<|>) that uses a semigroup (since errors are\r\n-- 'nonempty') - that is, we don't want to allow failing with no error.\r\n\r\nGiven the reasoning of the last bit, should I try that instead?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hdgarrood",
"comment_id": 266430111,
"datetime": 1481549102000,
"masked_author": "username_1",
"text": "Ha, it was such a long time ago that I wrote that, I'd completely forgotten. Come to think of it I'm not sure how we could provide a way of combining errors, other than by returning a list of `ParseError`, and I don't think I want to do that, as it seems unnecessarily complex. Having `Alternative` would be nice but I think I'd rather provide a monomorphic `<|>` function, since there's no good definition for the `empty` class method from `Alternative`. I think my favourite approach would be to take the right side's error if both parsers error, what do you think?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hdgarrood",
"comment_id": null,
"datetime": 1481553492000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "hdgarrood",
"comment_id": 266446551,
"datetime": 1481553492000,
"masked_author": "username_1",
"text": "Resolved by #11.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 906 | false | false | 906 | false |
tflearn/tflearn | tflearn | 145,558,687 | 3 | null | [
{
"action": "opened",
"author": "LoveTube",
"comment_id": null,
"datetime": 1459731466000,
"masked_author": "username_0",
"text": "Dear,\r\n\r\nDo have a plan to support python3?",
"title": "[Request a new feature] support python3",
"type": "issue"
},
{
"action": "created",
"author": "aymericdamien",
"comment_id": 205127112,
"datetime": 1459742670000,
"masked_author": "username_1",
"text": "Yes, it is planned :) I let this thread open until it is released.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "aymericdamien",
"comment_id": null,
"datetime": 1459829518000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 109 | false | false | 109 | false |
flutter/flutter | flutter | 213,821,041 | 8,731 | {
"number": 8731,
"repo": "flutter",
"user_login": "flutter"
} | [
{
"action": "opened",
"author": "abarth",
"comment_id": null,
"datetime": 1489422264000,
"masked_author": "username_0",
"text": "These symbols were not intended to be public. Also, remove some bogus dartdocs\nfor PhysicalModeLayer.",
"title": "Make some symbols private",
"type": "issue"
},
{
"action": "created",
"author": "abarth",
"comment_id": 286160528,
"datetime": 1489422273000,
"masked_author": "username_0",
"text": "@HansMuller @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abarth",
"comment_id": 286160609,
"datetime": 1489422287000,
"masked_author": "username_0",
"text": "@xster",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Hixie",
"comment_id": 286170256,
"datetime": 1489424096000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "comment"
}
] | 2 | 4 | 255 | false | false | 255 | true |
sparkdesignsystem/spark-design-system | sparkdesignsystem | 363,244,377 | 578 | null | [
{
"action": "opened",
"author": "bobwise",
"comment_id": null,
"datetime": 1537809936000,
"masked_author": "username_0",
"text": "brenden aware of the need for this per standup on 10/12/18 - amber",
"title": "[DESIGN] Fall Footer",
"type": "issue"
},
{
"action": "closed",
"author": "afebbraro",
"comment_id": null,
"datetime": 1539965149000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 66 | false | false | 66 | false |
reutenauer/polyglossia | null | 279,939,604 | 193 | null | [
{
"action": "opened",
"author": "rl1234567890",
"comment_id": null,
"datetime": 1512601508000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nIn gloss-greek.ldf \r\n\r\n \\def\\seename{ὃρα}%\r\n\r\nshould actually be\r\n\r\n \\def\\seename{ὅρα}%\r\n\r\n(acute accent instead of grave). Thank you for your work!",
"title": "Wrong accent",
"type": "issue"
},
{
"action": "closed",
"author": "reutenauer",
"comment_id": null,
"datetime": 1563868724000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "reutenauer",
"comment_id": 514098516,
"datetime": 1563868735000,
"masked_author": "username_1",
"text": "Hence `\\alsoname` should also be changed, I suppose (to ὅρα ὡσαύτως). Thanks for the correction! This is apparently a very old error, Babel also has `\\accdasiavaria\\textomicron\\textrho\\textalpha`.\r\n\r\nI just pushed a commit with a fix.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 396 | false | false | 396 | false |
williamkapke/mongo-mock | null | 330,436,167 | 62 | {
"number": 62,
"repo": "mongo-mock",
"user_login": "williamkapke"
} | [
{
"action": "opened",
"author": "seanspradlin",
"comment_id": null,
"datetime": 1528405647000,
"masked_author": "username_0",
"text": "Proposed resolution to this issue: https://github.com/username_1/mongo-mock/issues/61",
"title": "created test and implementation of cursor.map",
"type": "issue"
},
{
"action": "created",
"author": "williamkapke",
"comment_id": 396091310,
"datetime": 1528674184000,
"masked_author": "username_1",
"text": "Great, thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 101 | false | false | 101 | true |
duncan3dc/meta-audio | null | 304,095,993 | 5 | {
"number": 5,
"repo": "meta-audio",
"user_login": "duncan3dc"
} | [
{
"action": "opened",
"author": "Gemorroj",
"comment_id": null,
"datetime": 1520708991000,
"masked_author": "username_0",
"text": "replace `/tmp` to [sys_get_temp_dir](http://php.net/sys_get_temp_dir)",
"title": "Tests",
"type": "issue"
},
{
"action": "created",
"author": "duncan3dc",
"comment_id": 372058260,
"datetime": 1520710090000,
"masked_author": "username_1",
"text": "Hi @username_0, it looks like you've got another commit in here about autoloading, please can you remove it so this PR just contains the temporary directory fix?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Gemorroj",
"comment_id": 372058588,
"datetime": 1520710311000,
"masked_author": "username_0",
"text": "oh, sorry",
"title": null,
"type": "comment"
}
] | 3 | 4 | 525 | false | true | 237 | true |
bizz84/SwiftyStoreKit | null | 279,025,767 | 312 | null | [
{
"action": "opened",
"author": "ogres",
"comment_id": null,
"datetime": 1512399620000,
"masked_author": "username_0",
"text": "### Version\r\n0.11.0\r\n\r\nHello,\r\nis there any reason why PaymentTransaction does not have transactionDate already?\r\nIf no, can we add it? its very handy to sort/filter them using this property\r\n\r\nhttps://developer.apple.com/documentation/storekit/skpaymenttransaction/1411273-transactiondate",
"title": "Expose transactionDate in PaymentTransaction",
"type": "issue"
},
{
"action": "created",
"author": "bizz84",
"comment_id": 352182240,
"datetime": 1513429378000,
"masked_author": "username_1",
"text": "@username_0 apologies for the late reply. \r\n\r\nSure, I'm happy to add it. ETA: before end of tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ogres",
"comment_id": 352184518,
"datetime": 1513431983000,
"masked_author": "username_0",
"text": "Thanks @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bizz84",
"comment_id": 353019063,
"datetime": 1513763944000,
"masked_author": "username_1",
"text": "Available in version [0.11.1](https://github.com/username_1/SwiftyStoreKit/releases/tag/0.11.1)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bizz84",
"comment_id": null,
"datetime": 1513763944000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 490 | false | false | 490 | true |
kyma-project/kyma | kyma-project | 346,645,856 | 93 | {
"number": 93,
"repo": "kyma",
"user_login": "kyma-project"
} | [
{
"action": "opened",
"author": "sayanh",
"comment_id": null,
"datetime": 1533136584000,
"masked_author": "username_0",
"text": "Confirm these statements before you submit your pull request:\r\n\r\n- [x] I have read and submitted the required [Contributor Licence Agreements](https://github.com/kyma-project/community/blob/master/CONTRIBUTING.md#agreements-and-licenses).\r\n- [x] This pull request follows the contributing guidelines, recommended Git workflow, and templates.\r\n- [x] I have tested my changes.\r\n- [x] I have updated the relevant documentation.\r\n---\r\n\r\n**Description**\r\n\r\nChanges proposed in this pull request:\r\n\r\n- Enabling alerts in VictorOps and Slack\r\n\r\n<!--\r\n**Issue link**\r\n\r\nIf you refer to a particular issue, provide its number. For example, `Resolves #123`, `Fixes #43`, or `See also #33`. -->",
"title": "Enable alerts",
"type": "issue"
},
{
"action": "created",
"author": "bszwarc",
"comment_id": 530295313,
"datetime": 1568193318000,
"masked_author": "username_1",
"text": "Alertmanager and alerting rules info was extracted to official documentation & tutorials. READMEs were updated accordingly.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 806 | false | false | 806 | false |
Homebrew/homebrew-core | Homebrew | 258,194,059 | 18,133 | {
"number": 18133,
"repo": "homebrew-core",
"user_login": "Homebrew"
} | [
{
"action": "opened",
"author": "Bo98",
"comment_id": null,
"datetime": 1505521481000,
"masked_author": "username_0",
"text": "Created with `brew bump-formula-pr`.",
"title": "premake 5.0.0-alpha12 (devel)",
"type": "issue"
},
{
"action": "created",
"author": "ilovezfs",
"comment_id": 329944352,
"datetime": 1505535753000,
"masked_author": "username_1",
"text": "Thanks for your first contribution to Homebrew, @username_0!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 90 | false | false | 90 | true |
Rapptz/discord.py | null | 216,459,006 | 519 | null | [
{
"action": "opened",
"author": "shantung",
"comment_id": null,
"datetime": 1490281171000,
"masked_author": "username_0",
"text": "idk which one is incorrect, I'm new with coding plz halp\r\n\r\nimport discord\r\nimport asyncio\r\nfrom discord.ext import commands\r\n\r\nclass Tester:\r\n \"\"\"My custom cog that does stuff!\"\"\"\r\n\r\n def __init__(self, bot):\r\n self.bot = bot\r\n\r\n @commands.command(pass_context=True)\r\n async def tester(self, ctx):\r\n\r\n author_name = ctx.message.author\r\n description = (\"Short little description with a link to\")\r\n field_name = \"Generic Name\"\r\n field_contents = \"Example contents for this field\"\r\n footer_text = \"Hi. I am a footer text. I look small when displayed.\"\r\n\r\n embed = discord.Embed(colour=0xFF0000, description=description)\r\n embed.title = \"title test\"\r\n embed.set_author(name=str(author.name), icon_url=author.avatar_url)\r\n embed.add_field(name=field_name, value=field_contents)\r\n embed.set_footer(text=footer_text)\r\n\r\n await self.bot.say(embed=embed)\r\n \r\ndef setup(bot):\r\n bot.add_cog(Tester(bot))",
"title": "Command doesn't show",
"type": "issue"
},
{
"action": "created",
"author": "NotSoSuper",
"comment_id": 288761599,
"datetime": 1490283837000,
"masked_author": "username_1",
"text": "do you actually load the cog/extension in your main bot file?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shantung",
"comment_id": 288770627,
"datetime": 1490285342000,
"masked_author": "username_0",
"text": "I loaded it, but when I run the command, it shows nothing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nitros12",
"comment_id": 288775057,
"datetime": 1490286101000,
"masked_author": "username_2",
"text": "dedent the command block by one level, it's being created inside __init__ and then thrown away, it needs to be in the class definition.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shantung",
"comment_id": 288780810,
"datetime": 1490287096000,
"masked_author": "username_0",
"text": "still, it could be loaded, but if I type the command, nothing happened\r\n\r\n```\r\nimport discord\r\nimport asyncio\r\nfrom discord.ext import commands\r\n\r\nclass Tester:\r\n \"\"\"My custom cog that does stuff!\"\"\"\r\n\r\n def __init__(self, bot):\r\n self.bot = bot\r\n\r\n @commands.command(pass_context=True)\r\n async def tesu(self, ctx):\r\n\r\n author_name = ctx.message.author\r\n description = (\"Short little description with a link to\")\r\n field_name = \"Generic Name\"\r\n field_contents = \"Example contents for this field\"\r\n footer_text = \"Hi. I am a footer text. I look small when displayed.\"\r\n\r\n embed = discord.Embed(colour=0xFF0000, description=description)\r\n embed.title = \"title test\"\r\n embed.set_author(name=str(author.name), icon_url=author.avatar_url)\r\n embed.add_field(name=field_name, value=field_contents)\r\n embed.set_footer(text=footer_text)\r\n\r\n await self.bot.say(embed=embed)\r\n \r\ndef setup(bot):\r\n bot.add_cog(Tester(bot))\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "martmists",
"comment_id": 288782543,
"datetime": 1490287417000,
"masked_author": "username_3",
"text": "Could you show a screenshot of what you're typing?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nitros12",
"comment_id": 288782729,
"datetime": 1490287451000,
"masked_author": "username_2",
"text": "Check your variable names, you declare `author_name` but then proceed to use `author`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shantung",
"comment_id": 288784118,
"datetime": 1490287714000,
"masked_author": "username_0",
"text": "OMG, I'm much obligated to you. You've saved my life thanks so much!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Rapptz",
"comment_id": null,
"datetime": 1490307290000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 9 | 2,529 | false | false | 2,529 | false |
NuCode1497/TimekeeperWPF | null | 337,308,235 | 60 | null | [
{
"action": "opened",
"author": "NuCode1497",
"comment_id": null,
"datetime": 1530466805000,
"masked_author": "username_0",
"text": "A feature that allows the user to add more time to a given InclusionZone so that, time can be automatically allocated into time that would have been unscheduled. This could be achieved by creating and including a very specific TimePattern exclusive to that Task. See: #59",
"title": "Time Extension",
"type": "issue"
}
] | 1 | 1 | 271 | false | false | 271 | false |
AdityaSidharta/AdityaSidharta.github.io | null | 237,130,211 | 5 | null | [
{
"action": "opened",
"author": "MaxKusnadi",
"comment_id": null,
"datetime": 1497947155000,
"masked_author": "username_0",
"text": "",
"title": "Kyaa adit",
"type": "issue"
},
{
"action": "closed",
"author": "AdityaSidharta",
"comment_id": null,
"datetime": 1498041113000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
mipengine/mip2-extensions | mipengine | 344,758,816 | 140 | {
"number": 140,
"repo": "mip2-extensions",
"user_login": "mipengine"
} | [
{
"action": "opened",
"author": "jennyliang220",
"comment_id": null,
"datetime": 1532596194000,
"masked_author": "username_0",
"text": "",
"title": "feat: 修改测试页面js引用",
"type": "issue"
},
{
"action": "created",
"author": "chenqiushi",
"comment_id": 408031517,
"datetime": 1532596237000,
"masked_author": "username_1",
"text": "构建成功，请点击链接获取编译代码或预览效果\n\nBuilt with commit 06335764d7d3170db5ee03462a5144842b230093\n\nhttps://deploy-preview-140--mip2-deploy-preview.netlify.com",
"title": null,
"type": "comment"
}
] | 2 | 2 | 142 | false | false | 142 | false |
antaresproject/notifications | antaresproject | 277,040,957 | 16 | null | [
{
"action": "opened",
"author": "dawid-g",
"comment_id": null,
"datetime": 1511793628000,
"masked_author": "username_0",
"text": "1. Send preview of this template: admin/notifications/2/edit\r\n2. Check mailbox\r\n\r\nResults:\r\n\r\nTemplate has tekst: \"testtekstTEKST\"\r\n\r\nEmail message which is coming to my mailbox: https://image.prntscr.com/image/5N83lKh9TS6VEkzTHMNtsw.png",
"title": "Notifications - incorrect content of messages",
"type": "issue"
},
{
"action": "created",
"author": "MarcinKozak",
"comment_id": 347489501,
"datetime": 1511867123000,
"masked_author": "username_1",
"text": "@username_0 fixed",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dawid-g",
"comment_id": null,
"datetime": 1511948075000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dawid-g",
"comment_id": 347803634,
"datetime": 1511948075000,
"masked_author": "username_0",
"text": "verified as fixed.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 269 | false | false | 269 | true |
swagger-api/swagger-codegen | swagger-api | 297,370,860 | 7,661 | null | [
{
"action": "opened",
"author": "Kappasama",
"comment_id": null,
"datetime": 1518685344000,
"masked_author": "username_0",
"text": "##### Description\r\n\r\nTrying to generate a Python client library,\r\n\r\n##### Swagger-codegen version\r\n\r\n swagger-codegen-cli.jar 2.3.1\r\n\r\n##### Steps to reproduce\r\njava -jar swagger-codegen-cli generate -i /home/my_name/PycharmProjects/api/api.json -l python -o /home/my_name/test_api\r\n\r\nUpload a result to Bitbacket git repository\r\nInstall module\r\n\r\ntest.py\r\n`\r\nimport swagger_client\r\n\r\na = swagger_client.DefaultApi()\r\n`\r\nhas error \r\n\r\nFile \"/usr/local/lib/python3.5/dist-packages/swagger_client/__init__.py\", line 19, in <module>\r\n from swagger_client.api.default_api import DefaultApi\r\n File \"/usr/local/lib/python3.5/dist-packages/swagger_client/api/__init__.py\", line 6, in <module>\r\n from swagger_client.api.default_api import DefaultApi\r\nImportError: No module named 'swagger_client.api.default_api'",
"title": "ImportError: No module named 'swagger_client.api.default_api'",
"type": "issue"
},
{
"action": "created",
"author": "fkromer",
"comment_id": 366735103,
"datetime": 1519056064000,
"masked_author": "username_1",
"text": "I have the same issue after generating a Python client library with the docker image of swagger-codegen-cli `swaggerapi/swagger-codegen-cli`.\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/__init__.py\", line 19, in <module>\r\n from swagger_client.api.datastreams_api import DatastreamsApi\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/api/__init__.py\", line 6, in <module>\r\n from swagger_client.api.datastreams_api import DatastreamsApi\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/api/datastreams_api.py\", line 21, in <module>\r\n from swagger_client.api_client import ApiClient\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/api_client.py\", line 27, in <module>\r\n import swagger_client.models\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/models/__init__.py\", line 28, in <module>\r\n from swagger_client.models.parameter import Parameter\r\n File \"/usr/local/lib/python2.7/dist-packages/swagger_client/models/parameter.py\", line 19, in <module>\r\n from swagger_client.models.errorunknown import ERRORUNKNOWN # noqa: F401,E501\r\nImportError: No module named errorunknown\r\n```",
"title": null,
"type": "comment"
}
] | 2 | 2 | 2,065 | false | false | 2,065 | false |
ox-it/sakai | ox-it | 258,491,344 | 441 | {
"number": 441,
"repo": "sakai",
"user_login": "ox-it"
} | [
{
"action": "opened",
"author": "buckett",
"comment_id": null,
"datetime": 1505743391000,
"masked_author": "username_0",
"text": "Both shibd and apache fall over badly when the entityId isn’t set with segmentation fails. This provides a more graceful fail. In this case Apache doesn’t load the shibboleth module and shied doesn’t attempt to start.",
"title": "WL-4926 Check that $ENTITYID is defined.",
"type": "issue"
},
{
"action": "created",
"author": "buckett",
"comment_id": 330232172,
"datetime": 1505743412000,
"masked_author": "username_0",
"text": "@nicholaswilson100 This fixes the error you were seeing on friday with docker-compose not starting up.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 319 | false | false | 319 | false |
sirinsidiator/ESO-LibAddonMenu | null | 172,161,723 | 62 | null | [
{
"action": "opened",
"author": "Scootworks",
"comment_id": null,
"datetime": 1471621666000,
"masked_author": "username_0",
"text": "`Too many anchors processed. Tail of anchor list:\r\nLAMIconPickerScrollContainerScrollBarThumbMunge->\r\n->\r\n->\r\n->\r\nLAMIconPickerScrollContainerScrollBarThumbMunge`\r\n\r\nTested with Phinix Poison Master -> Settings -> while clicking on icon picker symbol",
"title": "Icon Picker",
"type": "issue"
},
{
"action": "created",
"author": "sirinsidiator",
"comment_id": 245972823,
"datetime": 1473440146000,
"masked_author": "username_1",
"text": "Thanks. I'll check what's up with that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sirinsidiator",
"comment_id": 256678629,
"datetime": 1477582582000,
"masked_author": "username_1",
"text": "Doesn't seem to happen anymore, so it was most likely caused by incorrect usage of the icon picker.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sirinsidiator",
"comment_id": null,
"datetime": 1477582583000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 388 | false | false | 388 | false |
lampepfl/dotty | lampepfl | 235,798,927 | 2,750 | {
"number": 2750,
"repo": "dotty",
"user_login": "lampepfl"
} | [
{
"action": "opened",
"author": "nicolasstucki",
"comment_id": null,
"datetime": 1497428412000,
"masked_author": "username_0",
"text": "",
"title": "Add VSCode settings for the dotty project",
"type": "issue"
},
{
"action": "created",
"author": "smarter",
"comment_id": 308471729,
"datetime": 1497454839000,
"masked_author": "username_1",
"text": "I think it would break it (unless you use git update-index --assume-unchanged: http://gitready.com/intermediate/2009/02/18/temporarily-ignoring-files.html), but on the other hand, this appears to be a common things that people do, vscode itself defines settings that way: https://github.com/Microsoft/vscode/blob/master/.vscode/settings.json. So I assume that it's not common to want custom settings for one project, though someone asked for a \"settings.local.json\" before: https://github.com/Microsoft/vscode/issues/17634#issuecomment-277957930",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "smarter",
"comment_id": 308471918,
"datetime": 1497454879000,
"masked_author": "username_1",
"text": "one option would be to do as the comment I linked to suggest, have a .vscode-template automatically copied to .vscode on first run (by sbt?).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nicolasstucki",
"comment_id": 308472174,
"datetime": 1497454931000,
"masked_author": "username_0",
"text": "that could work",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nicolasstucki",
"comment_id": 309462676,
"datetime": 1497883633000,
"masked_author": "username_0",
"text": "Fixed all comments",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "felixmulder",
"comment_id": 311306966,
"datetime": 1498556284000,
"masked_author": "username_2",
"text": "@username_1 - can this go in now?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DarkDimius",
"comment_id": 314029236,
"datetime": 1499672342000,
"masked_author": "username_3",
"text": "@username_1 could you please review it today so we can get it into next milestone?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "smarter",
"comment_id": 314049843,
"datetime": 1499677788000,
"masked_author": "username_1",
"text": "Sure, but note that this only affects users of the dotty repo, it changes nothing for end users, so it doesn't really matter whether it gets in or not.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nicolasstucki",
"comment_id": 314051926,
"datetime": 1499678350000,
"masked_author": "username_0",
"text": "As @username_1 said, this is just for us. Therefore it is not a priority.",
"title": null,
"type": "comment"
}
] | 4 | 9 | 1,049 | false | false | 1,049 | true |
zalando/zalenium | zalando | 241,666,513 | 180 | null | [
{
"action": "opened",
"author": "zhenjunz",
"comment_id": null,
"datetime": 1499682209000,
"masked_author": "username_0",
"text": "Hi, I just setup one environment with zalenium, it works fine, thanks for your efforts. After starting zalenium with below command:\r\ndocker run --rm -ti --name zalenium -p 4444:4444 -p 5555:5555 -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/videos:/home/seluser/videos --privileged dosel/zalenium start --screenWidth 1920 --screenHeight 1080\r\n\r\nI can only run tests with one version of Firefox and one version of Chrome, do you have a guideline to add more versions for each browser? so testers can select specific browser version as they like?",
"title": "Support multiple browser version",
"type": "issue"
},
{
"action": "created",
"author": "diemol",
"comment_id": 314155505,
"datetime": 1499703200000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nThanks for the nice words!\r\n\r\nWell, this is something we have discussed internally and also with some people outside... Among the discussed things, we have:\r\n* How much are browsers changing between versions? If there is a breaking change, then people keep the current [docker-selenium](https://github.com/elgalu/docker-selenium) image and not update until they adapt to the changes.\r\n* How to handle the overhead to support the versions combination? For example, Selenium 3.3.1 only works with some versions of ChromeDriver and GeckoDriver, and subsequently ChromeDriver and GeckoDriver only work with some versions of Chrome and Firefox respectively. \r\n\r\nIn general we saw that in most of the situations people test with the latest version available in the images and if they needed to stay with an specific version, they keep the [docker-selenium](https://github.com/elgalu/docker-selenium) image that they need. The use case is not that common to invest all the effort needed to implement and maintain the extra logic.\r\n\r\nTo answer your question (and I hope to not disappoint :)), the current guideline is for you to handle this on your local environment. This means, for example, to test with Chrome 58 you would pull the [3.3.1-p11](https://github.com/elgalu/docker-selenium/releases/tag/3.3.1-p11) release and run your tests with it, and so on.\r\n\r\nIf you have any ideas that could help us to handle that in a simple way, please let us know, or even better, send us a pull request.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhenjunz",
"comment_id": 314273732,
"datetime": 1499727614000,
"masked_author": "username_0",
"text": "Thanks, Is that possible to run different version of zalenium on different host, in same selenium-grid environment? it means being transparent to tests, they use current UI and current 4444 api, we use different hosts to support different version of browsers.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "diemol",
"comment_id": 315044736,
"datetime": 1499943323000,
"masked_author": "username_1",
"text": "What do you mean by that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhenjunz",
"comment_id": 315252088,
"datetime": 1499998988000,
"masked_author": "username_0",
"text": "@username_1 , with Zalenium runs on multiple hosts, I just want to give testers' one hub path, for example:\r\nhttp://zalenium:4444/wd/hub\r\n\r\nHow to make Zalenium instances to join the same hub? and I have one Windows host(with selenium node installed), can I join it to the same hub either?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "diemol",
"comment_id": 315361075,
"datetime": 1500039368000,
"masked_author": "username_1",
"text": "You can do it in a normal way, Zalenium is running a standard grid so you can add new nodes that support IE or Safari. Just take into account to set the port of the node to something different from `5555`, since that is the default port for nodes but we are using it for the dashboard.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhenjunz",
"comment_id": 315722768,
"datetime": 1500288512000,
"masked_author": "username_0",
"text": "Got it. @username_1 , thanks for your help!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "diemol",
"comment_id": 315971916,
"datetime": 1500359881000,
"masked_author": "username_1",
"text": "You are welcome! \r\nI'll close this issue then. Feel free to reopen if any related problems arise, or please open a new one in case you bump into a different problem.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "diemol",
"comment_id": null,
"datetime": 1500359882000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 9 | 3,127 | false | false | 3,127 | true |
mjwheatley/cordova-plugin-android-fingerprint-auth | null | 168,791,967 | 7 | null | [
{
"action": "opened",
"author": "charlesmccann",
"comment_id": null,
"datetime": 1470108758000,
"masked_author": "username_0",
"text": "Using the example code, I modified it for my phonegap \"app\". I'm running this on my Android device (Galaxy s7). The .isAvailable() code runs fine. \r\n\r\nHowever, the .show() always calls the callback before the fingerprint has even been used. So, when cancelling, these are the 2 alerts print every time:\r\nsuccess: OK withFingerprint: undefined\r\nfail: Cancelled\r\n\r\nIs this the desired behaviour? \r\nare we to watch for specific messages to know if it is truly success or failure?\r\n\r\n\r\nFingerprintAuth.isAvailable(isAvailableSuccess, isAvailableError);\r\n\r\n```\r\n isAvailableSuccess: function(result) {\r\n console.log(\"FingerprintAuth available: \" + JSON.stringify(result));\r\n if (result.isAvailable) {\r\n FingerprintAuth.show({\r\n clientId: \"myAppName\",\r\n clientSecret: \"a_very_secret_encryption_key\"\r\n }, app.successcallback, app.failcallback);\r\n }\r\n },\r\n successcallback: function(msg) {\r\n app.showData();\r\n alert(\"success: \"+msg + \" withFingerprint:\" + msg.withFingerprint);\r\n },\r\n failcallback: function(msg) {\r\n alert(\"fail: \" + msg);\r\n },\r\n\r\n```",
"title": "callbacks always called ",
"type": "issue"
},
{
"action": "created",
"author": "PyriteParrot",
"comment_id": 237570723,
"datetime": 1470321035000,
"masked_author": "username_1",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mjwheatley",
"comment_id": 237572318,
"datetime": 1470321344000,
"masked_author": "username_2",
"text": "No that is not the desired behavior. I recently added the callback for the cancel message and in doing so I probably caused this bug. I will sort through the code and see if I can prevent the false success callback.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mjwheatley",
"comment_id": 237631589,
"datetime": 1470333333000,
"masked_author": "username_2",
"text": "published v0.0.10 to resolve this issue",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mjwheatley",
"comment_id": null,
"datetime": 1470333333000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "PyriteParrot",
"comment_id": 237740949,
"datetime": 1470364652000,
"masked_author": "username_1",
"text": "It's working correctly now. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "charlesmccann",
"comment_id": 238001207,
"datetime": 1470450458000,
"masked_author": "username_0",
"text": "Yes, thank you!",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,490 | false | false | 1,490 | false |
spadgos/sublime-jsdocs | null | 29,962,440 | 270 | null | [
{
"action": "opened",
"author": "klihelp",
"comment_id": null,
"datetime": 1395499642000,
"masked_author": "username_0",
"text": "Would be a good feature to refresh/update doc block when changing the argument name for functions. \r\nIn Sublime Text the CTRL + D shortcut is very useful for this if the function name doesn't contain the same text.\r\n\r\n```\r\n /**\r\n * Filter array by fields.\r\n * @param array $posts\r\n * @param array $args\r\n * @return array\r\n */\r\n\tpublic function get_posts_by_data_fields( $posts, $args = null ) {\r\n```",
"title": "Refresh/update doc block when changing argument name",
"type": "issue"
},
{
"action": "created",
"author": "rtucek",
"comment_id": 200885395,
"datetime": 1458833111000,
"masked_author": "username_1",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "klihelp",
"comment_id": 313076266,
"datetime": 1499253954000,
"masked_author": "username_0",
"text": "+1",
"title": null,
"type": "comment"
}
] | 2 | 3 | 429 | false | false | 429 | false |
github/gitignore | github | 59,360,485 | 1,422 | {
"number": 1422,
"repo": "gitignore",
"user_login": "github"
} | [
{
"action": "opened",
"author": "altaris",
"comment_id": null,
"datetime": 1425160600000,
"masked_author": "username_0",
"text": "",
"title": "Added gnuplot output files patterns to TeX.gitignore",
"type": "issue"
},
{
"action": "created",
"author": "arcresu",
"comment_id": 88286478,
"datetime": 1427845511000,
"masked_author": "username_1",
"text": "Thanks, but it would be great if you could comment with some documentation describing these rules so that we understand where they came from in the future. Also the PR will need updating so it can be merged. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shiftkey",
"comment_id": 175394397,
"datetime": 1453870047000,
"masked_author": "username_2",
"text": "@username_0 unfortunately this isn't mergeable currently, and there are some questions outstanding which we'd like to clarify before merging :cry:\r\n\r\nI need to clean up stale pull requests at some stage, and will close this out if I don't hear anything before Friday 26th February.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 493 | false | false | 493 | true |
opencode18/OpenNews | opencode18 | 288,824,781 | 57 | {
"number": 57,
"repo": "OpenNews",
"user_login": "opencode18"
} | [
{
"action": "opened",
"author": "ashraysinha6069",
"comment_id": null,
"datetime": 1516092118000,
"masked_author": "username_0",
"text": "https://username_0.github.io/OpenNews/",
"title": "replacing image with website logo if image is not found",
"type": "issue"
},
{
"action": "created",
"author": "aswanthkoleri",
"comment_id": 357930455,
"datetime": 1516101618000,
"masked_author": "username_1",
"text": "@username_0 Nice work ! :+1:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 76 | false | false | 76 | true |
meanbee/docker-magento2 | meanbee | 376,095,166 | 136 | null | [
{
"action": "opened",
"author": "itsazzad",
"comment_id": null,
"datetime": 1541009344000,
"masked_author": "username_0",
"text": "",
"title": "stat: cannot stat '/var/www/magento': No such file or directory",
"type": "issue"
},
{
"action": "created",
"author": "bassman2112",
"comment_id": 434950756,
"datetime": 1541055620000,
"masked_author": "username_1",
"text": "You'll need to install Magento itself using `docker-compose run cli magento-installer`\r\n\r\nRunning that while not changing anything will not install it with any data, so it will have a blank database. You can get around this by going into either `global.env` or `docker-compose` and setting `M2SETUP_USE_SAMPLE_DATA=true`",
"title": null,
"type": "comment"
}
] | 2 | 2 | 320 | false | false | 320 | false |
kpdecker/jsdiff | null | 340,262,160 | 226 | null | [
{
"action": "opened",
"author": "ithinkihaveacat",
"comment_id": null,
"datetime": 1531318572000,
"masked_author": "username_0",
"text": "I feel like a must be missing something, but what's the best way to determine if `oldObj` and `newObj` are actually equal? If there's exactly one change object?",
"title": "How to determine equality?",
"type": "issue"
},
{
"action": "created",
"author": "draperunner",
"comment_id": 583406942,
"datetime": 1581085019000,
"masked_author": "username_1",
"text": "Maybe checking `length === 1` is good enough, but I'm doing this:\r\n```\r\nconst hasStructuralChanges = diffJson(oldObj, newObj)\r\n .filter(change => change.added || change.removed)\r\n .length > 0\r\n```",
"title": null,
"type": "comment"
}
] | 2 | 2 | 370 | false | false | 370 | false |
wet-boew/wet-boew | wet-boew | 125,699,190 | 7,325 | null | [
{
"action": "opened",
"author": "neoinsight",
"comment_id": null,
"datetime": 1452288865000,
"masked_author": "username_0",
"text": "Over several rounds of usability testing, we have seen mobile phone participants scroll to the bottom of the page to look for Contacts. They try to find it everywhere except in the Hamburger menu. The fact that they are on a mobile device doesn’t change their expectation about footers at the bottom. \r\n\r\nExamples & video clip: https://youtu.be/QkI5RdRD2oU\r\nR5 P2: “I would look to the bottom for a contact”\r\nR5 P8: “For mobile, it’s just the natural thing to do, to just flick (to the bottom), because it’s fastest”\r\nR6 P18: “I’ll just look down there… (back up to top – looks at hamburger menu) ...No, that’s just the main menu, I don’t think that would be useful.”\r\n\r\nThe current design breaks with convention - most responsive sites maintain the footer in mobile widths. Thus this behaviour will not change/improve on WET sites. \r\n\r\nRecommend: Need to create a lightweight footer (for example, just the headings) or simply display the entire footer at the bottom of the mobile view. \r\nDiscussed with @username_4 and @dk-knight.",
"title": "Usability: Contacts/Footer not found in Hamburger Menu",
"type": "issue"
},
{
"action": "created",
"author": "LaurentGoderre",
"comment_id": 170134784,
"datetime": 1452288986000,
"masked_author": "username_1",
"text": "Unfortunate because on some of our page, that means a LOT of scrolling",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "neoinsight",
"comment_id": 170135948,
"datetime": 1452289324000,
"masked_author": "username_0",
"text": "@username_1 True, but they 'flick' as seen in the video.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "LaurentGoderre",
"comment_id": 170558452,
"datetime": 1452520904000,
"masked_author": "username_1",
"text": "Yeah, that's an extremely small page",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "neoinsight",
"comment_id": 170562285,
"datetime": 1452521559000,
"masked_author": "username_0",
"text": "@username_1 Good point, not saying we couldn't ALSO keep it in the hamburger menu for the 'accidental' finds that I've seen with mobile participants. But this research finding was too powerful to ignore, happened again and again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "LaurentGoderre",
"comment_id": 170564356,
"datetime": 1452521926000,
"masked_author": "username_1",
"text": "I'm not arguing not to do it but this is an argument for not having long pages",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andre-gh",
"comment_id": 170588966,
"datetime": 1452526443000,
"masked_author": "username_2",
"text": "Is there any argument for just putting it in both places? As a user I am trained to go to the footer to find contact info and only if I discover I am on an infinite scrolling page do I then check stuff like a sidebar, sidebars are mostly accessed by me for navigation. As a user, I would think it would be good to just put them in both locations.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "neoinsight",
"comment_id": 170593614,
"datetime": 1452527498000,
"masked_author": "username_0",
"text": "@username_2 No argument, see above where I said it could also stay in the main hamburger menu at least temporarily. Would want to watch analytics over time though - if it gets no use there in mobile, then it should be removed to reduce complexity and improve ease of use for the main menu items. Clutter is an enemy of usability.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hsrudnicki",
"comment_id": 182575322,
"datetime": 1455136921000,
"masked_author": "username_3",
"text": "Is the above still an issue, waiting for your consensus/a decision? Either way, please update this issue's status, whether this issue can be closed as resolved/fixed or if otherwise, thank you",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pcwsmith",
"comment_id": 182614118,
"datetime": 1455143990000,
"masked_author": "username_4",
"text": "Hey everyone, we're doing some design thinking on our side, reacting to and integrating @username_0's ... insights. In addition to the idea of putting it at the bottom of the page, we're looking at the analytics and toying with the idea of slimming down the number of links in the footer as well. More news soon!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DK-TBS",
"comment_id": 182892815,
"datetime": 1455201794000,
"masked_author": "username_5",
"text": "I wholeheartedly support the idea of keeping the footer links in *both* the bottom footer and the mobile menu. Duplication and clutter aren't great, but... we know that people look for footer links at the bottom, and we can be sure that some people have already learned to look for those in the mobile menu. The duplication shouldn't really cause any damage in the short term, and usage stats will give us a more solid answer in the long term...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "neoinsight",
"comment_id": 218804926,
"datetime": 1463069129000,
"masked_author": "username_0",
"text": "Usability testing of the new footer approach outlined in the Content and IA spec was successful - all of the 10 mobile participants found the footer on the page (items are also in the menu). Closing this issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "neoinsight",
"comment_id": null,
"datetime": 1463069129000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 6 | 13 | 3,345 | false | false | 3,345 | true |
TIYDC/tiyo-assistant | TIYDC | 199,913,481 | 50 | null | [
{
"action": "opened",
"author": "rposborne",
"comment_id": null,
"datetime": 1484076958000,
"masked_author": "username_0",
"text": "What if they don't want it?",
"title": "Provide manner to disable newline_hw",
"type": "issue"
},
{
"action": "created",
"author": "jakerella",
"comment_id": 271695453,
"datetime": 1484081787000,
"masked_author": "username_1",
"text": "So... still not sure why we need this. If they don't want it, then the buttons don't show up, right? Because the newline_hw gem is not present?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rposborne",
"comment_id": 271697275,
"datetime": 1484082224000,
"masked_author": "username_0",
"text": "Well we can get rid of this line \r\nhttps://github.com/TIYDC/tiyo-assistant/blob/master/src/scripts/client/modules/hw.js#L248",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rposborne",
"comment_id": null,
"datetime": 1486505380000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "rposborne",
"comment_id": 278158013,
"datetime": 1486505380000,
"masked_author": "username_0",
"text": "This has been addressed.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 318 | false | false | 318 | false |
bumptech/glide | bumptech | 258,382,184 | 2,406 | null | [
{
"action": "opened",
"author": "DearDaXiong",
"comment_id": null,
"datetime": 1505716980000,
"masked_author": "username_0",
"text": "in glide V3.6 , it can't find some thumbnail of local video ,but i can find thumbnails in other ways ,for excample use \"MediaMetaDataRetriever\".\r\n the following code is my key code using Glide v3.6 .\r\n--------------------------------------------------------------------------------------\r\nGlide.with(mContext)\r\n .load(videoPath)\r\n .listener(new RequestListener<String, GlideDrawable>() {\r\n @Override\r\n public boolean onException(Exception e, String model, Target<GlideDrawable> target, boolean isFirstResource) {\r\n Log.d(\"daxiong\", \"onException: e=\" + e + \" model=\" + model + \" target=\" + target + \" isFirstResource=\" + isFirstResource);\r\n\r\n return false;\r\n }\r\n\r\n @Override\r\n public boolean onResourceReady(GlideDrawable resource, String model, Target<GlideDrawable> target, boolean isFromMemoryCache, boolean isFirstResource) {\r\n return false;\r\n }\r\n })\r\n .fitCenter()\r\n .centerCrop().error(R.drawable.ic_video_default)\r\n .placeholder(R.drawable.ic_video_default)\r\n .into(holder.mIcon);\r\n--------------------------------------------------------------------------------\r\n and then ,it had an exception:\r\n09-18 14:39:19.043 12717-12717/? D/daxiong: onException: e=java.lang.StringIndexOutOfBoundsException: length=65536; regionStart=3; regionLength=-74 model=/storage/emulated/0/视频资源/不同格式视频播放/MP4格式/02.mp4 target=Target for: android.widget.ImageView{5a1d7ae V.ED..... ........ 0,0-200,200 #7f0b002d app:id/item_icon} isFirstResource=true\r\n\r\nso ,i want to know how to solve the exception.thanks!",
"title": "in glide V3.6 , it can't find some thumbnail of local video ,but i can find thumbnails in other ways ,for excample use \"MediaMetaDataRetriever\"",
"type": "issue"
},
{
"action": "created",
"author": "sjudd",
"comment_id": 330230798,
"datetime": 1505743184000,
"masked_author": "username_1",
"text": "You could try updating to 3.8. \r\n\r\nYou'll need to print the full stack trace otherwise. For a copy/pastable ``RequestListener`` see https://github.com/bumptech/glide/wiki/Debugging-and-Error-Handling#requestlistener",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DearDaXiong",
"comment_id": 330445615,
"datetime": 1505803622000,
"masked_author": "username_0",
"text": "- i'm sorry. i updated the Glide to V4.1，then, it can't solve this exception.\r\n\r\n- the following code is an exception log , i don't understand it , can you help me？\r\n\r\n`09-19 14:38:44.529 25117-25143/? D/DecodeJob: DecodeJob threw unexpectedly, isCancelled: false, stage: SOURCE\r\n java.lang.StringIndexOutOfBoundsException: length=65536; regionStart=3; regionLength=-77\r\n at java.lang.StringFactory.newStringFromBytes(StringFactory.java:69)\r\n at java.lang.StringFactory.newStringFromBytes(StringFactory.java:53)\r\n at com.mediatek.dcfdecoder.DcfDecoder.isDrmFile(DcfDecoder.java:569)\r\n at com.mediatek.dcfdecoder.DcfDecoder.decodeDrmImageIfNeeded(DcfDecoder.java:365)\r\n at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:685)\r\n at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:657)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decodeStream(Downsampler.java:485)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.getDimensions(Downsampler.java:460)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decodeFromWrappedStreams(Downsampler.java:220)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decode(Downsampler.java:204)\r\n at com.bumptech.glide.load.resource.bitmap.StreamBitmapDecoder.decode(StreamBitmapDecoder.java:60)\r\n at com.bumptech.glide.load.resource.bitmap.StreamBitmapDecoder.decode(StreamBitmapDecoder.java:17)\r\n at com.bumptech.glide.load.engine.DecodePath.decodeResourceWithList(DecodePath.java:67)\r\n at com.bumptech.glide.load.engine.DecodePath.decodeResource(DecodePath.java:52)\r\n at com.bumptech.glide.load.engine.DecodePath.decode(DecodePath.java:43)\r\n at com.bumptech.glide.load.engine.LoadPath.loadWithExceptionList(LoadPath.java:56)\r\n at com.bumptech.glide.load.engine.LoadPath.load(LoadPath.java:42)\r\n at com.bumptech.glide.load.engine.DecodeJob.runLoadPath(DecodeJob.java:482)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromFetcher(DecodeJob.java:454)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromData(DecodeJob.java:440)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromRetrievedData(DecodeJob.java:394)\r\n at com.bumptech.glide.load.engine.DecodeJob.onDataFetcherReady(DecodeJob.java:363)\r\n at com.bumptech.glide.load.engine.SourceGenerator.onDataReady(SourceGenerator.java:111)\r\n at com.bumptech.glide.load.model.MultiModelLoader$MultiFetcher.onDataReady(MultiModelLoader.java:132)\r\n at com.bumptech.glide.load.data.LocalUriFetcher.loadData(LocalUriFetcher.java:49)\r\n at com.bumptech.glide.load.model.MultiModelLoader$MultiFetcher.loadData(MultiModelLoader.java:96)\r\n at com.bumptech.glide.load.engine.SourceGenerator.startNext(SourceGenerator.java:61)\r\n at com.bumptech.glide.load.engine.DecodeJob.runGenerators(DecodeJob.java:286)\r\n at com.bumptech.glide.load.engine.DecodeJob.runWrapped(DecodeJob.java:256)\r\n at com.bumptech.glide.load.engine.DecodeJob.run(DecodeJob.java:226)\r\n at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)\r\n at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)\r\n at java.lang.Thread.run(Thread.java:761)\r\n at com.bumptech.glide.load.engine.executor.GlideExecutor$DefaultThreadFactory$1.run(GlideExecutor.java:347)\r\n09-19 14:38:44.533 25117-25143/? E/GlideExecutor: Request threw uncaught throwable\r\n java.lang.StringIndexOutOfBoundsException: length=65536; regionStart=3; regionLength=-77\r\n at java.lang.StringFactory.newStringFromBytes(StringFactory.java:69)\r\n at java.lang.StringFactory.newStringFromBytes(StringFactory.java:53)\r\n at com.mediatek.dcfdecoder.DcfDecoder.isDrmFile(DcfDecoder.java:569)\r\n at com.mediatek.dcfdecoder.DcfDecoder.decodeDrmImageIfNeeded(DcfDecoder.java:365)\r\n at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:685)\r\n at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:657)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decodeStream(Downsampler.java:485)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.getDimensions(Downsampler.java:460)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decodeFromWrappedStreams(Downsampler.java:220)\r\n at com.bumptech.glide.load.resource.bitmap.Downsampler.decode(Downsampler.java:204)\r\n at com.bumptech.glide.load.resource.bitmap.StreamBitmapDecoder.decode(StreamBitmapDecoder.java:60)\r\n at com.bumptech.glide.load.resource.bitmap.StreamBitmapDecoder.decode(StreamBitmapDecoder.java:17)\r\n at com.bumptech.glide.load.engine.DecodePath.decodeResourceWithList(DecodePath.java:67)\r\n at com.bumptech.glide.load.engine.DecodePath.decodeResource(DecodePath.java:52)\r\n at com.bumptech.glide.load.engine.DecodePath.decode(DecodePath.java:43)\r\n at com.bumptech.glide.load.engine.LoadPath.loadWithExceptionList(LoadPath.java:56)\r\n at com.bumptech.glide.load.engine.LoadPath.load(LoadPath.java:42)\r\n at com.bumptech.glide.load.engine.DecodeJob.runLoadPath(DecodeJob.java:482)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromFetcher(DecodeJob.java:454)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromData(DecodeJob.java:440)\r\n at com.bumptech.glide.load.engine.DecodeJob.decodeFromRetrievedData(DecodeJob.java:394)\r\n at com.bumptech.glide.load.engine.DecodeJob.onDataFetcherReady(DecodeJob.java:363)\r\n at com.bumptech.glide.load.engine.SourceGenerator.onDataReady(SourceGenerator.java:111)\r\n at com.bumptech.glide.load.model.MultiModelLoader$MultiFetcher.onDataReady(MultiModelLoader.java:132)\r\n at com.bumptech.glide.load.data.LocalUriFetcher.loadData(LocalUriFetcher.java:49)\r\n at com.bumptech.glide.load.model.MultiModelLoader$MultiFetcher.loadData(MultiModelLoader.java:96)\r\n at com.bumptech.glide.load.engine.SourceGenerator.startNext(SourceGenerator.java:61)\r\n at com.bumptech.glide.load.engine.DecodeJob.runGenerators(DecodeJob.java:286)\r\n at com.bumptech.glide.load.engine.DecodeJob.runWrapped(DecodeJob.java:256)\r\n at com.bumptech.glide.load.engine.DecodeJob.run(DecodeJob.java:226)\r\n at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)\r\n at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)\r\n at java.lang.Thread.run(Thread.java:761)\r\n at com.bumptech.glide.load.engine.executor.GlideExecutor$DefaultThreadFactory$1.run(GlideExecutor.java:347)\r\n09-19 14:38:44.555 25117-25117/? W/Glide: Load failed for /storage/emulated/0/视频资源/不同分辨率视频播放/480x320 1.3gp with size [200x200]\r\n class com.bumptech.glide.load.engine.GlideException: Failed to load resource\r\n09-19 14:38:44.556 25117-25117/? D/GLIDE: onException(com.bumptech.glide.load.engine.GlideException: Failed to load resource, /storage/emulated/0/视频资源/不同分辨率视频播放/480x320 1.3gp, Target for: android.widget.ImageView{6cadd48 V.ED..... ........ 0,0-200,200 #7f0d00a6 app:id/item_icon}, true)\r\n class com.bumptech.glide.load.engine.GlideException: Failed to load resource\r\n\r\n`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sjudd",
"comment_id": 330565352,
"datetime": 1505832728000,
"masked_author": "username_1",
"text": "Ugh:\r\n\r\n```\r\nat com.mediatek.dcfdecoder.DcfDecoder.isDrmFile(DcfDecoder.java:569)\r\nat com.mediatek.dcfdecoder.DcfDecoder.decodeDrmImageIfNeeded(DcfDecoder.java:365)\r\n```\r\n\r\nMediatek has added some additional logic to the framework that crashes on whatever image file you're giving them. We might be able to handle the error more gracefully though, I'll take a look.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sjudd",
"comment_id": null,
"datetime": 1505835973000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "DearDaXiong",
"comment_id": 332137135,
"datetime": 1506417170000,
"masked_author": "username_0",
"text": "dear:\r\n are you have a solution to this problem?",
"title": null,
"type": "comment"
}
] | 2 | 6 | 12,906 | false | false | 12,906 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.