repo
stringlengths
7
67
org
stringlengths
2
32
issue_id
int64
780k
941M
issue_number
int64
1
134k
pull_request
dict
events
list
user_count
int64
1
77
event_count
int64
1
192
text_size
int64
0
329k
bot_issue
bool
1 class
modified_by_bot
bool
2 classes
text_size_no_bots
int64
0
279k
modified_usernames
bool
2 classes
alphagov/govuk-puppet
alphagov
135,698,491
4,133
{ "number": 4133, "repo": "govuk-puppet", "user_login": "alphagov" }
[ { "action": "opened", "author": "bradwright", "comment_id": null, "datetime": 1456223579000, "masked_author": "username_0", "text": "To be merged after deployment#907", "title": "Add asset manager token into share sale environment", "type": "issue" }, { "action": "created", "author": "alexmuller", "comment_id": 188171185, "datetime": 1456307745000, "masked_author": "username_1", "text": "Looks right to me :+1:", "title": null, "type": "comment" } ]
2
2
55
false
false
55
false
symfony/symfony
symfony
88,760,068
15,008
null
[ { "action": "opened", "author": "webmozart", "comment_id": null, "datetime": 1434468512000, "masked_author": "username_0", "text": "As originally discussed in #11185, a default implementation should be added for `AbstractType::getName()`:\r\n\r\n* `getName()` should return the type's FQCN by default\r\n* the alias should be se4t to the class name by default in the DI config\r\n* the form name should be set to the lower-cased short name of the type by default, minus the \"type\" suffix\r\n\r\nBefore:\r\n\r\n```php\r\nclass TaskType extends AbstractType\r\n{\r\n public function getName()\r\n {\r\n return 'task';\r\n }\r\n}\r\n```\r\n\r\n```yaml\r\nservices:\r\n acme.demo.form.task:\r\n class: Acme\\DemoBundle\\Form\\TaskType\r\n tags:\r\n - { name: form.type, alias: task }\r\n```\r\n\r\n```php\r\n$form = $this->createForm(new TaskType());\r\n// or\r\n$form = $this->createForm('task');\r\n\r\necho $form->getName();\r\n// task\r\n```\r\n\r\nAfter:\r\n\r\n```php\r\nclass TaskType extends AbstractType\r\n{\r\n}\r\n```\r\n\r\n```yaml\r\nservices:\r\n acme.demo.form.task:\r\n class: Acme\\DemoBundle\\Form\\TaskType\r\n tags:\r\n - { name: form.type }\r\n```\r\n\r\n```php\r\n$form = $this->createForm(new TaskType());\r\n// or\r\n$form = $this->createForm(TaskType::class);\r\n// or\r\n$form = $this->createForm('Acme\\DemoBundle\\Form\\TaskType');\r\n\r\necho $form->getName();\r\n// task\r\n```", "title": "[Form] Add default implementation for AbstractType::getName()", "type": "issue" }, { "action": "created", "author": "iltar", "comment_id": 112478524, "datetime": 1434470164000, "masked_author": "username_1", "text": "I think this is a nice idea for services, but what about multiple services that automatically get the same alias? `\\Foo\\BarType` and `\\Baz\\BarType` would create an automatic conflict and could create problems between 3rd party bundles.", "title": null, "type": "comment" }, { "action": "created", "author": "stof", "comment_id": 112484712, "datetime": 1434471629000, "masked_author": "username_2", "text": "form names don't need to be unique (unless you try to submit them in the same request, which would be really weird). And type names will not conflict by default as the default value would be the FQCN", "title": null, "type": "comment" }, { "action": "created", "author": "iltar", "comment_id": 112550927, "datetime": 1434484697000, "masked_author": "username_1", "text": "@username_2 so the Alias would default to `TaskType::class`? That would make sense. I Misunderstood it and thought the idea was to put `task` as alias, but `task` will only be the name.", "title": null, "type": "comment" }, { "action": "created", "author": "webmozart", "comment_id": 114567610, "datetime": 1435077951000, "masked_author": "username_0", "text": "Implemented in #15079.", "title": null, "type": "comment" }, { "action": "closed", "author": "fabpot", "comment_id": null, "datetime": 1438411561000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" } ]
4
6
1,850
false
false
1,850
true
toboid/all-finished
null
324,617,761
27
{ "number": 27, "repo": "all-finished", "user_login": "toboid" }
[ { "action": "opened", "author": "toboid", "comment_id": null, "datetime": 1526723856000, "masked_author": "username_0", "text": "", "title": "chore(package): update chai to version 4.0.1", "type": "issue" } ]
2
2
285
false
true
0
false
aframevr/aframe
aframevr
307,097,229
3,480
null
[ { "action": "opened", "author": "hugobros", "comment_id": null, "datetime": 1521597137000, "masked_author": "username_0", "text": "**Description:**\r\n\r\n- A-Frame Version: 0.6.1\r\n- Platform / Device: \r\n- Reproducible Code Snippet or URL: https://glitch.com/edit/#!/laneo360-3?path=index.html:10:49\r\n\r\n¿How can i make a link to another web page with the a-link?\r\nI'm amateur and i'm really interested in knowing this, please help\r\n\r\ni already tried another alternatives but it's resulting impossible to me", "title": "I can't make a-link work ", "type": "issue" }, { "action": "created", "author": "donmccurdy", "comment_id": 374820445, "datetime": 1521600500000, "masked_author": "username_1", "text": "Please see https://aframe.io/docs/0.8.0/introduction/faq.html#can-i-add-links-to-my-scene and https://aframe.io/docs/0.8.0/components/link.html. We ask that questions and requests for help use Stack Overflow or Slack, and (to get helpful responses) you'll want to check those docs first and ask about parts you don't understand.", "title": null, "type": "comment" }, { "action": "closed", "author": "donmccurdy", "comment_id": null, "datetime": 1521600501000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
699
false
false
699
false
ausHaus/ioBroker.megadd
null
364,418,814
5
null
[ { "action": "opened", "author": "NikolayUlianov", "comment_id": null, "datetime": 1538045875000, "masked_author": "username_0", "text": "Not correctly state the humidity sensor is connected BME280\r\n![2018-09-27_09-38-17](https://user-images.githubusercontent.com/43374650/46141639-39119200-c25d-11e8-8025-365dff07a268.png)\r\n![2018-09-27_09-38-36](https://user-images.githubusercontent.com/43374650/46141640-39119200-c25d-11e8-95bd-022e4576a164.png)\r\n![2018-09-27_13-18-28](https://user-images.githubusercontent.com/43374650/46141641-39119200-c25d-11e8-8dc2-f9d6385cbfa4.png)", "title": "Not correctly state the humidity sensor is connected BME280", "type": "issue" }, { "action": "created", "author": "NikolayUlianov", "comment_id": 425051129, "datetime": 1538046517000, "masked_author": "username_0", "text": "![image](https://user-images.githubusercontent.com/43374650/46142191-d28d7380-c25e-11e8-8aeb-59752785657b.png)", "title": null, "type": "comment" }, { "action": "created", "author": "NikolayUlianov", "comment_id": 425051278, "datetime": 1538046553000, "masked_author": "username_0", "text": "![image](https://user-images.githubusercontent.com/43374650/46142212-e89b3400-c25e-11e8-8bf2-d4606e47f9b3.png)", "title": null, "type": "comment" }, { "action": "closed", "author": "ausHaus", "comment_id": null, "datetime": 1538068835000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ausHaus", "comment_id": 425173818, "datetime": 1538068835000, "masked_author": "username_1", "text": "Do not rename the ports were with this problem", "title": null, "type": "comment" }, { "action": "created", "author": "NikolayUlianov", "comment_id": 425904217, "datetime": 1538399925000, "masked_author": "username_0", "text": "The ports with the original names have been re-preserved. Nothing has changed.\r\n![image](https://user-images.githubusercontent.com/43374650/46290777-70ea4380-c595-11e8-948a-a6749a5df0be.png)\r\n![image](https://user-images.githubusercontent.com/43374650/46290816-89f2f480-c595-11e8-9e5a-69dc4e330174.png)", "title": null, "type": "comment" }, { "action": "created", "author": "NikolayUlianov", "comment_id": 425904468, "datetime": 1538399970000, "masked_author": "username_0", "text": "![image](https://user-images.githubusercontent.com/43374650/46290902-c45c9180-c595-11e8-8d84-f0372a96f93e.png)", "title": null, "type": "comment" }, { "action": "created", "author": "ausHaus", "comment_id": 427070419, "datetime": 1538668183000, "masked_author": "username_1", "text": "let's continue on the forum ioBroker https://forum.iobroker.net/viewtopic.php?f=16&t=4076", "title": null, "type": "comment" } ]
2
8
1,204
false
false
1,204
false
Microsoft/vsts-tasks
Microsoft
251,820,020
5,079
{ "number": 5079, "repo": "vsts-tasks", "user_login": "Microsoft" }
[ { "action": "opened", "author": "arunkm", "comment_id": null, "datetime": 1503368828000, "masked_author": "username_0", "text": "The api `Find-VstsMatch(*)` returns directories as well, and trying to open the directory like a file causes the task to fail.\r\nTypically users use `*.*`, which often skips directory as long as it does not contain a `.`,\r\nIn our builds we have `.` in directories (like `App.L0.Tests`)", "title": "PublishSymbols: Excluding directory matches returned Find-VstsMatch, during publish", "type": "issue" } ]
2
2
435
false
true
285
false
TheCoder4eu/BootsFaces-OSP
null
220,904,097
697
null
[ { "action": "opened", "author": "chongma", "comment_id": null, "datetime": 1491905860000, "masked_author": "username_0", "text": "`b:selectOneMenu` doesn't seem to be compatible with `f:ajax`. for example if i create an `h:selectOneMenu` like\r\n```\r\n<h:selectOneMenu value=\"#{myBean.value}\">\r\n <f:ajax render=\"@form\"/>\r\n</h:selectOneMenu>\r\n```\r\n it renders the form on change with the new value without needing tom implement a listener. if i create\r\n```\r\n<b:selectOneMenu value=\"#{myBean.value}\" update=\"@form\"/>\r\n```\r\nor\r\n```\r\n<b:selectOneMenu value=\"#{myBean.value}\" >\r\n <f:ajax render=\"@form\"/>\r\n</b:selectOneMenu>\r\n```\r\n it doesn't update the form (presumably) unless there is a listener. hope that makes sense", "title": "b:selectOneMenu f:ajax", "type": "issue" }, { "action": "created", "author": "stephanrauh", "comment_id": 293385080, "datetime": 1491941274000, "masked_author": "username_1", "text": "If there's no AJAX listener, why should the AJAX request be triggered at all?\r\n\r\nThe original JSF AJAX engine is very simplistic. It generates an AJAX request each time when it finds an `f:ajax` facet. It offers a default event in order to save you a few keystrokes.\r\n\r\nThe BootsFaces AJAX engine generates AJAX code if it finds a JavaScript attribute with the \"ajax:\" prefix. If the programmer doesn't declare such an AJAX attribute, it's their fault. We don't generate a default action. \r\n\r\nLater we added compatibility to standard JSF by reluctantly supporting `f:ajax`. We mapped them to our `onClick`etc. approach, so it's little wonder nothing happens when there's neither an actionlistener nor an action.", "title": null, "type": "comment" }, { "action": "created", "author": "stephanrauh", "comment_id": 293385230, "datetime": 1491941308000, "masked_author": "username_1", "text": "That said, I've found a \"todo\" comment indicating we should improve support for `f:ajax`:\r\n\r\n```java\r\n\t\t// TODO behaviors don't render correctly?\r\n\t\t// SR 19.09.2015: looks a bit odd, indeed. The method generateAJAXCall()\r\n\t\t// generates an onclick handler -\r\n\t\t// regardless of which event we currently deal with\r\n\t\tString script = \"\";\r\n\t\tMap<String, List<ClientBehavior>> clientBehaviors = component.getClientBehaviors();\r\n\t\tList<ClientBehavior> behaviors = clientBehaviors.get(keyClientBehavior);\r\n\t\tif (null != behaviors) {\r\n\t\t\tfor (ClientBehavior cb : behaviors) {\r\n\t\t\t\tif (cb instanceof AjaxBehavior) {\r\n\t\t\t\t\tStringBuilder s = generateAJAXCallForClientBehavior(context, (IAJAXComponent) component,\r\n\t\t\t\t\t\t\t(AjaxBehavior) cb);\r\n\t\t\t\t\tscript += s.toString() + \";\";\r\n\t\t\t\t} else if (cb.getClass().getSimpleName().equals(\"AjaxBehavior\")) {\r\n\t\t\t\t\tAjaxBehavior ab = new AjaxBehavior();\r\n\t\t\t\t\tObject disabled = readBeanAttribute(cb, \"isDisabled\");\r\n\t\t\t\t\tab.setDisabled((Boolean) disabled);\r\n\t\t\t\t\tab.setOnerror((String) readBeanAttribute(cb, \"getOnerror\"));\r\n\t\t\t\t\tab.setRender((Collection<String>) readBeanAttributeAsCollection(cb, \"getUpdate\"));\r\n\t\t\t\t\tab.setExecute((Collection<String>) readBeanAttributeAsCollection(cb, \"getProcess\"));\r\n\t\t\t\t\tab.setOnevent(keyClientBehavior);\r\n\t\t\t\t\tStringBuilder s = generateAJAXCallForClientBehavior(context, (IAJAXComponent) component, ab);\r\n\t\t\t\t\tscript += s.toString() + \";\";\r\n\t\t\t\t}\r\n\t\t\t}\r\n\t\t}\r\n\t\t// TODO end\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "stephanrauh", "comment_id": 296286996, "datetime": 1492803217000, "masked_author": "username_1", "text": "The \"todo\" method is called only under special circumstances, such as jQuery event. The regular `<f:ajax event=\"something\" />´ API works fine.", "title": null, "type": "comment" }, { "action": "created", "author": "chongma", "comment_id": 296288073, "datetime": 1492803544000, "masked_author": "username_0", "text": "Ok do you want me to test it? Might have to be tomorrow though. I basically changed a working `h:selectOneMenu` and changed to a `b:selectOneMenu` and it stopped working. Let me come back to you on this", "title": null, "type": "comment" }, { "action": "created", "author": "stephanrauh", "comment_id": 296299942, "datetime": 1492807052000, "masked_author": "username_1", "text": "Testing would be appreciated! Just remember that you need to add a `listener` to the `f:ajax` facet. Otherwise, BootsFaces won't do anything because it thinks there's nothing to do. I'm still not sure if I should fix that for the sake of compatibility, or how to deal with that.", "title": null, "type": "comment" }, { "action": "created", "author": "chongma", "comment_id": 296300453, "datetime": 1492807198000, "masked_author": "username_0", "text": "Yes i will try to test what the default behaviour is so you can decide whether or not you want to support the default of the core components", "title": null, "type": "comment" }, { "action": "created", "author": "stephanrauh", "comment_id": 296304018, "datetime": 1492808289000, "masked_author": "username_1", "text": "Great! I've also created a related issue (#717).", "title": null, "type": "comment" }, { "action": "created", "author": "chongma", "comment_id": 296358481, "datetime": 1492850782000, "masked_author": "username_0", "text": "i can confirm that updating to 1.1.0 fixes this issue", "title": null, "type": "comment" }, { "action": "closed", "author": "chongma", "comment_id": null, "datetime": 1492850787000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
10
3,613
false
false
3,613
false
openaddresses/openaddresses
openaddresses
189,483,073
2,138
{ "number": 2138, "repo": "openaddresses", "user_login": "openaddresses" }
[ { "action": "opened", "author": "iandees", "comment_id": null, "datetime": 1479238004000, "masked_author": "username_0", "text": "Jason Warzinik asked us to stop using their Esri REST endpoints for OpenAddresses. He asked to include contact information, which I will include below:\r\n\r\nBoone County, Missouri:\r\n```\r\nJason Warzinik, GISP, GIS Manager\r\nBoone County\r\n801 E. Walnut, Room 220\r\nColumbia, MO 65201-4890\r\nPhone: (573) 886-4325\r\nE-mail: jwarzinik@boonecountymo.org\r\nwww: www.showmeboone.com\r\nUSNG 15S WD 5824 1181\r\n```\r\n \r\nCity of Columbia, Missouri:\r\n```\r\nMatthew J. Gerike, PhD \r\nGeospatial Services Manager | City of Columbia, Missouri \r\nMatt.Gerike@CoMo.gov | 573.874.7304 \r\nGIS Office On Call Phone: 573.825.8036\r\n```", "title": "Skip some Missouri data sources at the request of local governments", "type": "issue" }, { "action": "created", "author": "migurski", "comment_id": 260774582, "datetime": 1479245361000, "masked_author": "username_1", "text": "Can I suggest that we cache these sources, instead of skipping them? It would have the same effect, but it might allow us to continue to experiment with new output transforms.", "title": null, "type": "comment" } ]
2
2
775
false
false
775
false
square/moshi
square
109,315,757
94
null
[ { "action": "opened", "author": "edwardaa", "comment_id": null, "datetime": 1443710991000, "masked_author": "username_0", "text": "To exclude a field from class serialization I create a [custom type adapter] (https://github.com/square/moshi#custom-type-adapters) to write all fields except it, but the class has many fields. \r\nIs there an easy way to achieve that?", "title": "Exclude fields from serialization and deserialization", "type": "issue" }, { "action": "created", "author": "swankjesse", "comment_id": 144751024, "datetime": 1443711070000, "masked_author": "username_1", "text": "Use `transient` on the field declaration.\r\n\r\n```\r\nprivate String serialized;\r\nprivate transient String not_serialized;\r\n````", "title": null, "type": "comment" }, { "action": "closed", "author": "swankjesse", "comment_id": null, "datetime": 1443711077000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "edwardaa", "comment_id": 144759393, "datetime": 1443712539000, "masked_author": "username_0", "text": "cool, thanks.", "title": null, "type": "comment" }, { "action": "created", "author": "dimsuz", "comment_id": 173528180, "datetime": 1453371933000, "masked_author": "username_2", "text": "Is there a way to make this exclusion happen at the runtime? E.g. something like Gson's [ExclusionStrategy](http://google-gson.googlecode.com/svn/trunk/gson/docs/javadocs/com/google/gson/ExclusionStrategy.html)? The reason I'm asking is because I'd like to try using Moshi with Realm database. See Realm's instructions for Gson for example (they require using ExclusionStrategy to exclude some internal fields):\r\n\r\nhttps://realm.io/docs/java/0.77.0/#other-libraries", "title": null, "type": "comment" }, { "action": "created", "author": "swankjesse", "comment_id": 173574273, "datetime": 1453384026000, "masked_author": "username_1", "text": "Not at the moment. We could support say, `@Json(include=false)` or something.", "title": null, "type": "comment" }, { "action": "created", "author": "dimsuz", "comment_id": 173575399, "datetime": 1453384358000, "masked_author": "username_2", "text": "Looks like it wouldn't solve it in this case. In the example on the above page `User` class inherits `RealmObject` class which would have some field to be excluded and this field is not accessible to library client and `RealmObject` itself is part of the library too, user has no option of annotating its fields with `@Json(include=false)`...", "title": null, "type": "comment" }, { "action": "created", "author": "swankjesse", "comment_id": 173575406, "datetime": 1453384361000, "masked_author": "username_1", "text": "I think `transient` is probably easiest. Let's stick with that.", "title": null, "type": "comment" }, { "action": "created", "author": "swankjesse", "comment_id": 173576671, "datetime": 1453384646000, "masked_author": "username_1", "text": "Your best bet is to write a JSON Adapter that converts a value to something that can be encoded. The wiki has examples.", "title": null, "type": "comment" }, { "action": "created", "author": "dimsuz", "comment_id": 173578565, "datetime": 1453385098000, "masked_author": "username_2", "text": "Yes, `transient` looks really simple and means exactly same as its documentation says :)\r\nOk, thanks, will play around.", "title": null, "type": "comment" }, { "action": "created", "author": "vanniktech", "comment_id": 199859439, "datetime": 1458659587000, "masked_author": "username_3", "text": "Would be nice if this `transient` feature could be mentioned in the README.", "title": null, "type": "comment" }, { "action": "created", "author": "swankjesse", "comment_id": 200123038, "datetime": 1458698038000, "masked_author": "username_1", "text": "Good idea @username_3. Done!", "title": null, "type": "comment" }, { "action": "created", "author": "Shyish", "comment_id": 231756127, "datetime": 1468248319000, "masked_author": "username_4", "text": "Please take into account that making a field `transient` will turn into that field not being serialized; ex: `Bundle.putSerializable(...)` won't work on that specific field.", "title": null, "type": "comment" }, { "action": "created", "author": "i-farhanp", "comment_id": 330610687, "datetime": 1505841649000, "masked_author": "username_5", "text": "anyone looking for kotlin alternative,it would be @Transient", "title": null, "type": "comment" }, { "action": "created", "author": "grennis", "comment_id": 357259910, "datetime": 1515769078000, "masked_author": "username_6", "text": "@username_5 Unfortunately @ Transient requires a backing field, so you can't do:\r\n @ Transient val something: String by lazy { ... }\r\n\r\nWhat is the proper solution to ignore a field for Kotlin?", "title": null, "type": "comment" }, { "action": "created", "author": "miPlodder", "comment_id": 412318104, "datetime": 1534048475000, "masked_author": "username_7", "text": "@username_1 How to achieve it in Kotlin ?", "title": null, "type": "comment" }, { "action": "created", "author": "micHar", "comment_id": 430754633, "datetime": 1539803852000, "masked_author": "username_8", "text": "@username_1 it would be nice if you revisited this issue, because transient is clearly not suitable for all kotlin usages.", "title": null, "type": "comment" }, { "action": "created", "author": "hzsweers", "comment_id": 430758325, "datetime": 1539804600000, "masked_author": "username_9", "text": "@username_6 could you file a separate issue with a stacktrace or small sample project that reproduces it? Sounds like something we could at least give a better exception for.", "title": null, "type": "comment" }, { "action": "created", "author": "grennis", "comment_id": 430784301, "datetime": 1539809314000, "masked_author": "username_6", "text": "@username_9 and others, I found that you CAN use lazy properties on Moshi classes with: `@delegate:Transient` (instead of `@Transient`...) So, I think it's fine.", "title": null, "type": "comment" }, { "action": "created", "author": "chimbori", "comment_id": 453578872, "datetime": 1547224897000, "masked_author": "username_10", "text": "`transient` is also used by other libraries, such as [Cupboard](https://bitbucket.org/littlerobots/cupboard) for the same purpose. With two separate annotations (one for Moshi, one for Cupboard), one could mark a field for inclusion/exclusion in JSON as well as (separately) in a database table. But with the current approach of only supporting this via `transient`, Moshi makes it hard to play well with other libraries. Ideally, each library’s builder should provide a way to opt out of special treatment for `transient` and opt into annotation-based exclusion strategies.", "title": null, "type": "comment" }, { "action": "created", "author": "grennis", "comment_id": 453591834, "datetime": 1547227306000, "masked_author": "username_6", "text": "@username_10 I agree. Transient has too many meanings in other contexts. Moshi should have its own dedicated annotation for excluding properties.", "title": null, "type": "comment" } ]
11
21
3,296
false
false
3,296
true
rails/rails
rails
200,497,007
27,662
{ "number": 27662, "repo": "rails", "user_login": "rails" }
[ { "action": "opened", "author": "nhorton", "comment_id": null, "datetime": 1484259787000, "masked_author": "username_0", "text": "Previously said the helpers were preview_photo_url and preview_photo_path, i.e. action_resource, when in fact they are resource_action. i.e. photo_preview_path. Fixed.\r\n\r\n### Summary\r\n\r\nProvide a general description of the code changes in your pull\r\nrequest... were there any bugs you had fixed? If so, mention them. If\r\nthese bugs have open GitHub issues, be sure to tag them here as well,\r\nto keep the conversation linked together.\r\n\r\n### Other Information\r\n\r\nIf there's anything else that's important and relevant to your pull\r\nrequest, mention that information here. This could include\r\nbenchmarks, or other information.\r\n\r\nIf you are updating any of the CHANGELOG files or are asked to update the\r\nCHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.\r\n\r\nFinally, if your pull request affects documentation or any non-code\r\nchanges, guidelines for those changes are [available\r\nhere](http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation)\r\n\r\nThanks for contributing to Rails!", "title": "Fixing \"Adding Member Routes\" documentation", "type": "issue" }, { "action": "created", "author": "maclover7", "comment_id": 272307497, "datetime": 1484260990000, "masked_author": "username_1", "text": "@username_0 are you sure this is the case? I created a small test script [here](https://gist.github.com/username_1/12abd2450df055ce98f8f8a766a51f24), and I'm seeing that the route helper that's created is `preview_photo_url`, not `photo_preview_url ` 😬", "title": null, "type": "comment" }, { "action": "created", "author": "nhorton", "comment_id": 272337828, "datetime": 1484271556000, "masked_author": "username_0", "text": "Wow - OK, I figured it out and it is subtle. \r\n\r\nWorks as described in docs:\r\nRails.application.routes.draw do\r\n resources :photos do\r\n member do\r\n get 'preview'\r\n end\r\n end\r\nend\r\n\r\nWorks as described in docs:\r\nRails.application.routes.draw do\r\n resources :photos do\r\n get 'preview', on: :member\r\n end\r\nend\r\n\r\nDOES NOT work as described in docs:\r\nRails.application.routes.draw do\r\n resources :photos do\r\n get 'preview'\r\n end\r\nend\r\n\r\nPer the guide: You can leave out the :on option, this will create the same member route except that the resource id value will be available in params[:photo_id] instead of params[:id].\r\n\r\nNot true. It results in transposing the resource name and action name per my change suggestion on the docs. Not sure if it is better to correct the code or the docs on this one.", "title": null, "type": "comment" }, { "action": "created", "author": "maclover7", "comment_id": 273593088, "datetime": 1484771563000, "masked_author": "username_1", "text": "@username_0 Can we fix the docs now, and then can you open up a separate issue with the possible routes bug? Thanks!", "title": null, "type": "comment" } ]
3
5
3,209
false
true
2,254
true
rcgsheffield/sheffield_hpc
rcgsheffield
205,539,182
557
null
[ { "action": "opened", "author": "willfurnass", "comment_id": null, "datetime": 1486376196000, "masked_author": "username_0", "text": "See http://condor.eps.manchester.ac.uk/case-studies-and-success-stories/ for an example of this kind of thing. \r\n\r\nSome longer case studies would be interesting too: person had a problem that looked like X, consulted RCG/RSEG, developed strategy for running in parallel, benchmarked, revised strategy, benchmarked, Y% speedup gained.", "title": "Add case studies / sucess stories section?", "type": "issue" } ]
1
1
334
false
false
334
false
andymeneely/squib
null
263,244,096
235
null
[ { "action": "opened", "author": "andymeneely", "comment_id": null, "datetime": 1507232846000, "masked_author": "username_0", "text": "I was hoping to get to this before the first release, but I think we'll work on pushing sprues out and put this in a later release.\r\n\r\nIn the usual `save_sheet` and even in things like `showcase`, you can trim a card first. This factors into your math of determining the actual size of the card, and various other things.", "title": "Make sprues support `trim` and `trim_radius`", "type": "issue" }, { "action": "closed", "author": "andymeneely", "comment_id": null, "datetime": 1510027818000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
321
false
false
321
false
dahall/TaskScheduler
null
314,365,380
502
null
[ { "action": "opened", "author": "dahall", "comment_id": null, "datetime": 1523743191000, "masked_author": "username_0", "text": "My UI contains checkboxes of days, so when user setup a weekly schedule it should create a WeeklyTrigger with checked days , how to implement this case ? \r\n\n\rOriginally posted: 2013-03-12T08:16:07", "title": "Dynamically add days to DaysOfWeek", "type": "issue" }, { "action": "created", "author": "dahall", "comment_id": 381363490, "datetime": 1523743192000, "masked_author": "username_0", "text": "You will have to step through the checkboxes and assign each one to a DaysOfTheWeek value then OR all those selected values together and assign them to the DayOfWeek property of the WeeklyTrigger. If the task already exists, you will need to retrieve it, update the trigger and the re-register it. You can see an example of this in the WeeklyTriggerUI control at [http://taskscheduler.codeplex.com/SourceControl/changeset/view/83275#1324283](http://taskscheduler.codeplex.com/SourceControl/changeset/view/83275#1324283). \r\n\n\rOriginally posted: 2013-03-12T10:41:08", "title": null, "type": "comment" }, { "action": "closed", "author": "dahall", "comment_id": null, "datetime": 1523743193000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
3
761
false
false
761
false
DirectoryLister/DirectoryLister
DirectoryLister
247,044,379
166
{ "number": 166, "repo": "DirectoryLister", "user_login": "DirectoryLister" }
[ { "action": "opened", "author": "shmshd", "comment_id": null, "datetime": 1501588476000, "masked_author": "username_0", "text": "", "title": "external resources link update", "type": "issue" }, { "action": "created", "author": "PHLAK", "comment_id": 576911117, "datetime": 1579645068000, "masked_author": "username_1", "text": "Good news, Directory Lister 3 is now in beta! View the [release announcement](https://medium.com/chriskankiewicz/directory-lister-3-beta-is-here-d821236ac911) for more info.\r\n\r\nThis means all pull requests opened against the 2.X (currently `master`) branch will now be closed. We encourage you to to download and try the Directory Lister 3 beta and open a new PR if necessary.\r\n\r\nIf you'd like to join the discussion regarding the ongoing development of Directory Lister 3 you may do so in our [community forum](https://spectrum.chat/directory-lister).", "title": null, "type": "comment" } ]
2
2
552
false
false
552
false
DAVFoundation/dav-js
DAVFoundation
362,888,540
55
null
[ { "action": "opened", "author": "TalAter", "comment_id": null, "datetime": 1537648365000, "masked_author": "username_0", "text": "## first-timers-only\r\n\r\nThis issue is tagged :octocat: **first-timers-only**. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.\r\n\r\nConsider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.\r\n\r\nFind more **first-timers-only** issues from DAV Foundation [here](https://github.com/search?q=first-timers-only+org%3ADAVFoundation+label%3A%22up-for-grabs%22&state=open&type=Issues).\r\n\r\nThank you for your help :heart:\r\n\r\n## What is this project? \r\n\r\nDAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.\r\n\r\nAs an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.\r\n\r\n### dav-js\r\n\r\nThis repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.\r\n\r\n## How you can help\r\n\r\nIn order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.\r\n\r\nHere is a good opportunity to simplify one of our tests.\r\n\r\n### The Issue\r\n\r\nIn `src/ride-hailing/NeedFilterParams.test.ts` we defined the following parameters at the beginning of the `describe()` block.\r\n\r\n```javascript\r\n const needFilterParams = new NeedFilterParams({\r\n location: {\r\n lat: 32.050382,\r\n long: 34.766149,\r\n },\r\n radius: 2000,\r\n });\r\n needFilterParams.davId = 'davId';\r\n const serializedNeedFilterParams: any = {\r\n ttl: undefined,\r\n protocol: 'ride_hailing',\r\n type: 'need_filter',\r\n area: {\r\n max: {\r\n latitude: parseFloat((32.06836666390769).toFixed(6)),\r\n longitude: parseFloat((34.78737405278662).toFixed(6)),\r\n },\r\n min: {\r\n latitude: parseFloat((32.03239380095659).toFixed(6)),\r\n longitude: parseFloat((34.74493228891106).toFixed(6)),\r\n },\r\n },\r\n davId: 'davId',\r\n };\r\n```\r\n\r\nThese parameters will need to accommodate additional unit tests. \r\n\r\nPlease update these parameters to be more dynamic by defining them to be mutable similar to `src/vessel-charging/MissionParams.test.ts`.\r\n\r\n![Parameters][parameters]\r\n\r\nAfter making your changes, run `npm run jest` to make sure our tests are passing.\r\n\r\n### Contributing to dav-js\r\n\r\n- [ ] Make sure this issue is labeled `up-for-grabs` and not labeled `claimed`, to verify no one else is working on it.\r\n- [ ] Comment in this issue that you would like to do it.\r\n- [ ] Open [dav-js GitHub page](https://github.com/DAVFoundation/dav-js) and click the ★ Star and then ⑂ Fork buttons.\r\n- [ ] Clone a copy to your local machine with `$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git`\r\n- [ ] Install dependencies by running `npm install`\r\n- [ ] **Code Code Code**\r\n- [ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with `$ git push -u origin master`\r\n- [ ] Visit your fork on GitHub.com ([https://github.com/YOUR-USER-NAME/dav-js](https://github.com/YOUR-USER-NAME/dav-js)) and create a pull request for your changes.\r\n- [ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: `#7`)\r\n- [ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.\r\n\r\n### Asking for help\r\n\r\nWe appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our [gitter channel](https://gitter.im/DAVFoundation/DAV-Contributors). We are always happy to help 😄\r\n\r\n[parameters]: https://raw.githubusercontent.com/username_2/opensource-issue-list/update/missionParams/issues/davjs/MissionParms/01_mission_params.gif \"Update Parameters\"", "title": "Update test for `src/ride-hailing/NeedFilterParams.test.ts`", "type": "issue" }, { "action": "created", "author": "sark01", "comment_id": 423802473, "datetime": 1537693901000, "masked_author": "username_1", "text": "@username_0, Can I look into this?", "title": null, "type": "comment" }, { "action": "created", "author": "TalAter", "comment_id": 423831400, "datetime": 1537722395000, "masked_author": "username_0", "text": "@username_1 go ahead!", "title": null, "type": "comment" }, { "action": "created", "author": "sark01", "comment_id": 425754054, "datetime": 1538343425000, "masked_author": "username_1", "text": "Hi @username_0, I have updated the parameters but seem to be facing some sort of a linting issue. \r\nI get the following error message:\r\n`Failed to lint: /home/username_1/Desktop/git/dav-js/src/ride-hailing/NeedFilterParams.test.ts [16, 3]: statements are not aligned.`\r\nCould you please help.", "title": null, "type": "comment" }, { "action": "created", "author": "TalAter", "comment_id": 425827615, "datetime": 1538382487000, "masked_author": "username_0", "text": "Can you upload the code of that file to a gist?", "title": null, "type": "comment" }, { "action": "created", "author": "sark01", "comment_id": 425952688, "datetime": 1538408038000, "masked_author": "username_1", "text": "Please ignore the previous commits. Thank you.", "title": null, "type": "comment" }, { "action": "closed", "author": "mariolo1985", "comment_id": null, "datetime": 1538442896000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "mariolo1985", "comment_id": 426120543, "datetime": 1538445232000, "masked_author": "username_2", "text": "Nice work on powering through those lint issues @username_1!", "title": null, "type": "comment" }, { "action": "created", "author": "debragail", "comment_id": 442988649, "datetime": 1543524709000, "masked_author": "username_3", "text": "how did you make that gif??", "title": null, "type": "comment" }, { "action": "created", "author": "TalAter", "comment_id": 443525708, "datetime": 1543772406000, "masked_author": "username_0", "text": "I usually record and edit the videos using ScreenFlow, which can export to gif. Mac only (afaik), and paid, but I love it.", "title": null, "type": "comment" } ]
4
10
5,075
false
false
5,075
true
MicrosoftDocs/azure-docs
MicrosoftDocs
372,676,676
17,362
null
[ { "action": "opened", "author": "CeciAc", "comment_id": null, "datetime": 1540238623000, "masked_author": "username_0", "text": "@nschonni commented on [Sun Oct 21 2018](https://github.com/MicrosoftDocs/azure-docs.pt-br/issues/114)\n\nThis looks to be an old copy of this repo https://github.com/Azure/azure-content-ptbr\r\nIf it is, it would be good to remove it to prevent confusion.", "title": "Old repo sitting in Azure GitHub org", "type": "issue" }, { "action": "created", "author": "amanarneja", "comment_id": 431971943, "datetime": 1540240087000, "masked_author": "username_1", "text": "@SyntaxC4 - Can you check if https://github.com/Azure/azure-content-ptbr and https://github.com/MicrosoftDocs/azure-docs.pt-br are the same and if one should be removed ?", "title": null, "type": "comment" }, { "action": "created", "author": "ishasahni1", "comment_id": 486338089, "datetime": 1556125996000, "masked_author": "username_2", "text": "@tysonn for old Azure LOc Repo there is no admin, so I can't delete these old repos.", "title": null, "type": "comment" }, { "action": "created", "author": "ishasahni1", "comment_id": 492846749, "datetime": 1557959177000, "masked_author": "username_2", "text": "@nschonni @username_0 the old repos have been deleted.", "title": null, "type": "comment" }, { "action": "closed", "author": "v-thepet", "comment_id": null, "datetime": 1566530171000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "v-thepet", "comment_id": 524156533, "datetime": 1566530171000, "masked_author": "username_3", "text": "@nschonni @username_0 per @username_2 comment, closing this issue.", "title": null, "type": "comment" } ]
4
6
618
false
false
618
true
php/php-src
php
237,950,863
2,594
{ "number": 2594, "repo": "php-src", "user_login": "php" }
[ { "action": "opened", "author": "marat1995", "comment_id": null, "datetime": 1498160130000, "masked_author": "username_0", "text": "", "title": "fix error in news", "type": "issue" }, { "action": "created", "author": "php-pulls", "comment_id": 310511157, "datetime": 1498167807000, "masked_author": "username_1", "text": "**Comment on behalf of bukka at php.net:**\n\nMerged via https://github.com/php/php-src/commit/99b611958f65b52a9e5e5494cd12ef64f0211872 . Thanks", "title": null, "type": "comment" } ]
2
2
142
false
false
142
false
JuliaLang/julia
JuliaLang
109,919,934
13,462
{ "number": 13462, "repo": "julia", "user_login": "JuliaLang" }
[ { "action": "opened", "author": "ihnorton", "comment_id": null, "datetime": 1444095622000, "masked_author": "username_0", "text": "ref #13457 and https://github.com/JuliaLang/julia/pull/13424#issuecomment-145161582", "title": "Show file:line with binding deprecation warning", "type": "issue" }, { "action": "created", "author": "Keno", "comment_id": 145726179, "datetime": 1444098465000, "masked_author": "username_1", "text": "Need to fix the test.", "title": null, "type": "comment" }, { "action": "created", "author": "tkelman", "comment_id": 146047380, "datetime": 1444179757000, "masked_author": "username_2", "text": "backported in e70f13e5cc33bd379a2150f778c563d14077eca1", "title": null, "type": "comment" }, { "action": "created", "author": "IainNZ", "comment_id": 146067924, "datetime": 1444187854000, "masked_author": "username_3", "text": "will this be in 0.4.0?", "title": null, "type": "comment" }, { "action": "created", "author": "tkelman", "comment_id": 146068358, "datetime": 1444188169000, "masked_author": "username_2", "text": "yes, unless my currently-running pkgeval results look bad and i decide to revert it", "title": null, "type": "comment" } ]
4
5
263
false
false
263
false
tizmagik/react-head
null
345,885,493
45
{ "number": 45, "repo": "react-head", "user_login": "tizmagik" }
[ { "action": "opened", "author": "zhangciwu", "comment_id": null, "datetime": 1532976211000, "masked_author": "username_0", "text": "", "title": "Simplify SSR tag removing, also fix #44", "type": "issue" }, { "action": "created", "author": "TrySound", "comment_id": 409206072, "datetime": 1533040756000, "masked_author": "username_1", "text": "I don't think this operation should happen in every `HeadTag`. We can do it once in `HeadProvider` and make it required.", "title": null, "type": "comment" }, { "action": "created", "author": "zhangciwu", "comment_id": 409211833, "datetime": 1533041972000, "masked_author": "username_0", "text": "@username_1 Yeah, let me see it.", "title": null, "type": "comment" }, { "action": "created", "author": "zhangciwu", "comment_id": 410208439, "datetime": 1533290732000, "masked_author": "username_0", "text": "Got a problem, if make `HeadProvider` required at front, there will be two scene:\r\n- `Route` inside `HeadProvider` : `HeadProvider ` will be unaware of page switching, making it's responsibility of checking duplications of tags(title, etc.) fail to work.\r\n- `HeadProvider` inside `Route` : actually not possible, cause `Route` is inside isomorphic code(like `example/src/App.js`), making `HeadProvider` inside it will cause server side `HeadProvider` fail.\r\n\r\nSo I think just don't use `HeadProvider` at front, removing SSR tags can be done just once by adding some `removedFlag` and check if before real actions. Or just put the removing procedure outside `HeadTag` class declaration, Making it invoking at import time (at front).\r\n\r\nHow do you think @username_1", "title": null, "type": "comment" }, { "action": "created", "author": "TrySound", "comment_id": 413449251, "datetime": 1534403665000, "masked_author": "username_1", "text": "Closed in favour https://github.com/tizmagik/react-head/pull/55. Thanks for your work.", "title": null, "type": "comment" } ]
2
5
997
false
false
997
true
biocore/scikit-bio
biocore
101,220,632
1,055
null
[ { "action": "opened", "author": "wasade", "comment_id": null, "datetime": 1439683221000, "masked_author": "username_0", "text": "Stubbing out the minimal to-dos \r\n\r\n- [ ] `read(a_biom_file, into=biom.Table)` should produce a `biom.Table` object\r\n- [ ] `write(a_table, format='biom', into=a_ascii_file)` should write a BIOM format v1.0.0 table\r\n- [ ] `write(a_table, format='biom', into=a_hdf5_file)` should write a BIOM format v2.1.0 table \r\n- [ ] `Table.read` and `Table.write` should work as expected", "title": "BIOM support in scikit-bio", "type": "issue" }, { "action": "closed", "author": "wasade", "comment_id": null, "datetime": 1439683276000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "wasade", "comment_id": 131470230, "datetime": 1439683276000, "masked_author": "username_0", "text": "Sorry, duplicate.", "title": null, "type": "comment" } ]
1
3
390
false
false
390
false
GijsGoudzwaard/Image-Optimizer
null
261,889,654
17
null
[ { "action": "opened", "author": "TraumaD", "comment_id": null, "datetime": 1506829706000, "masked_author": "username_0", "text": "There is a lot of blank space there even in treeview.", "title": "Minimum window size should be smaller.", "type": "issue" }, { "action": "closed", "author": "GijsGoudzwaard", "comment_id": null, "datetime": 1516273024000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "GijsGoudzwaard", "comment_id": 358611865, "datetime": 1516273024000, "masked_author": "username_1", "text": "I decided I'm not going to do this. Although you're right that there is a lot of blank space, it does beat the alternative that everything is crammed together.", "title": null, "type": "comment" } ]
2
3
212
false
false
212
false
lokal-profil/mapillary2commons
null
329,403,630
8
null
[ { "action": "opened", "author": "mikelortega", "comment_id": null, "datetime": 1528196103000, "masked_author": "username_0", "text": "Somehow I do not manage to make it work, stays in the same page.\r\nhttps://tools.wmflabs.org/mapillary-commons/mapillary2commons/\r\nIt seems the Mapillary URLs changed, but I tried with the old URL and it seems that it doesn't work either.\r\nThank you.", "title": "Does this tool work?", "type": "issue" }, { "action": "created", "author": "lokal-profil", "comment_id": 396029541, "datetime": 1528617838000, "masked_author": "username_1", "text": "I'm not in a position to check right now but @username_2 might be able to.\n\nIf its a Mapillary issue then maybe @Gyllen knows?", "title": null, "type": "comment" }, { "action": "created", "author": "Abbe98", "comment_id": 396049890, "datetime": 1528638015000, "masked_author": "username_2", "text": "@username_0 this tool is broken after a recent change on WMFLabs.\r\n\r\nTool Labs has forced a Content Security Policy on all tools so there is no way we can make client side requests to Mapillary or other third party services anymore without a backend modifying the CSP or acting as a proxy.\r\n\r\nI'm unlikely to fix this in the near future.", "title": null, "type": "comment" }, { "action": "created", "author": "strainu", "comment_id": 462541894, "datetime": 1549928778000, "masked_author": "username_3", "text": "@username_2 are you sure this is because of the CSP? The Mapillary requests seem to work OK,, the issue seems to be the fact that search.mapzen has been dead for about an year.", "title": null, "type": "comment" }, { "action": "created", "author": "Abbe98", "comment_id": 462891350, "datetime": 1549998361000, "masked_author": "username_2", "text": "@username_3 I'm pretty sure that was the case, however I will need to spend a few hour migrating code on Tool Labs this weekend anyway so I could look into this. If it's a Mapzen search thing it will be a an easy fix 😄", "title": null, "type": "comment" }, { "action": "created", "author": "lokal-profil", "comment_id": 466822102, "datetime": 1551045844000, "masked_author": "username_1", "text": "@username_2 i migrated the tool to Strech before spotting this. I've added you as a maintainer since by now this tool is more your code than mine =)", "title": null, "type": "comment" }, { "action": "created", "author": "Abbe98", "comment_id": 467321163, "datetime": 1551164676000, "masked_author": "username_2", "text": "@username_1 awesome, I will have a look at it once I find the time to finalize my own Stretch migrations.", "title": null, "type": "comment" }, { "action": "created", "author": "Abbe98", "comment_id": 467321163, "datetime": 1551164676000, "masked_author": "username_2", "text": "@username_1 awesome, I will have a look at it once I find the time to finalize my own Stretch migrations.", "title": null, "type": "comment" }, { "action": "created", "author": "matkoniecz", "comment_id": 939428982, "datetime": 1633853855000, "masked_author": "username_4", "text": "It used to work but nowadays it is broken", "title": null, "type": "comment" }, { "action": "created", "author": "lokal-profil", "comment_id": 1059014283, "datetime": 1646387946000, "masked_author": "username_1", "text": "Looks like something has changed on the Mapillary side :(", "title": null, "type": "comment" }, { "action": "closed", "author": "lokal-profil", "comment_id": null, "datetime": 1646387988000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "lokal-profil", "comment_id": 1059014814, "datetime": 1646387989000, "masked_author": "username_1", "text": "See #11", "title": null, "type": "comment" } ]
5
12
1,560
false
false
1,560
true
webrtc/samples
webrtc
282,054,913
978
null
[ { "action": "opened", "author": "vkkkumar", "comment_id": null, "datetime": 1513248037000, "masked_author": "username_0", "text": "**Browsers and versions affected**\r\nchrome 64.0.3282.22 \r\n\r\n**Steps to reproduce**\r\n1. Browse to https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/\r\n2. Open the javascript console (alt+cmd+j or ctr+shift+j) and watch for any errors\r\n3. Click the \"Gather candidates\" button\r\n4. java script error should come if not\r\n5. open appr.tc and join a new room in another tab. \r\n\r\n**Expected results**\r\nno error should be thrown\r\n\r\n**Actual results**\r\nFailed to load resource: status 403 is thrown\r\n\r\n[webrtc_internals_dump (1).txt](https://github.com/webrtc/samples/files/1558817/webrtc_internals_dump.1.txt)\r\n[javascriptlog.log](https://github.com/webrtc/samples/files/1558818/javascriptlog.log)\r\n\r\n![screenshot 2017-12-14 at 11 27 49 am](https://user-images.githubusercontent.com/34342420/33988072-6dbf47d0-e0c3-11e7-913c-e941f67e14b1.png)", "title": "Failed to load resource: status 403", "type": "issue" }, { "action": "closed", "author": "rantonysamy", "comment_id": null, "datetime": 1513248567000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "rantonysamy", "comment_id": 351676139, "datetime": 1513248567000, "masked_author": "username_1", "text": "Its a problem with the Extension associated with the browser. So \"Won't Fix\".", "title": null, "type": "comment" } ]
2
3
931
false
false
931
false
CodeforKohoku/papamama
CodeforKohoku
230,192,046
39
null
[ { "action": "opened", "author": "kakikidrop", "comment_id": null, "datetime": 1495333673000, "masked_author": "username_0", "text": "", "title": "CSV入力方法のマニュアル作成", "type": "issue" }, { "action": "closed", "author": "toon258", "comment_id": null, "datetime": 1547363202000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "toon258", "comment_id": 453807612, "datetime": 1547363202000, "masked_author": "username_1", "text": "更新フロー変更(Google App Script化)により、いったんクローズ", "title": null, "type": "comment" } ]
2
3
39
false
false
39
false
ctessum/gobra
null
287,529,556
19
{ "number": 19, "repo": "gobra", "user_login": "ctessum" }
[ { "action": "opened", "author": "khoin", "comment_id": null, "datetime": 1515608131000, "masked_author": "username_0", "text": "Related https://github.com/username_1/gobra/issues/18", "title": "Fixed missing URI encoding before sending", "type": "issue" }, { "action": "created", "author": "khoin", "comment_id": 356690206, "datetime": 1515608381000, "masked_author": "username_0", "text": "@username_1 I haven't checked this with InMap. Let me know if InMap still has issues.", "title": null, "type": "comment" }, { "action": "created", "author": "ctessum", "comment_id": 356692612, "datetime": 1515608876000, "masked_author": "username_1", "text": "Fixes #18", "title": null, "type": "comment" } ]
2
3
141
false
false
141
true
waterbearlang/waterbear
waterbearlang
109,651,663
1,206
{ "number": 1206, "repo": "waterbear", "user_login": "waterbearlang" }
[ { "action": "opened", "author": "samuel-massinon-invenia", "comment_id": null, "datetime": 1443915062000, "masked_author": "username_0", "text": "Possible fix for the undo event. I played around with it a bit so I think it's working but I would like it if someone tested it out too.\r\n\r\nThis includes the example for moving a block around. \r\n\r\nFix is here https://github.com/waterbearlang/waterbear/issues/1187", "title": "Fix for 1187", "type": "issue" }, { "action": "created", "author": "dethe", "comment_id": 145405753, "datetime": 1444005752000, "masked_author": "username_1", "text": "This works great for me. :shipit:", "title": null, "type": "comment" } ]
2
2
296
false
false
296
false
jakobjohansson/dreamer-syntax
null
261,495,916
1
null
[ { "action": "closed", "author": "jakobjohansson", "comment_id": null, "datetime": 1506676463000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
2
1,318
false
true
0
false
feedhenry-templates/welcome-app
feedhenry-templates
168,398,750
7
{ "number": 7, "repo": "welcome-app", "user_login": "feedhenry-templates" }
[ { "action": "opened", "author": "corinnekrych", "comment_id": null, "datetime": 1469821157000, "masked_author": "username_0", "text": "@username_1 mind a review?", "title": "fix preview", "type": "issue" }, { "action": "created", "author": "jcesarmobile", "comment_id": 236305457, "datetime": 1469829875000, "masked_author": "username_1", "text": "looks good", "title": null, "type": "comment" } ]
2
2
38
false
false
38
true
18F/18f.gsa.gov
18F
197,880,414
2,152
{ "number": 2152, "repo": "18f.gsa.gov", "user_login": "18F" }
[ { "action": "opened", "author": "gemfarmer", "comment_id": null, "datetime": 1482942868000, "masked_author": "username_0", "text": "This reverts commit aaf279ec515f7d45c63645b46ee7681246dc4edc.\r\n\r\n/cc @ericronne", "title": "Revert ./serve push", "type": "issue" } ]
2
2
310
false
true
79
false
haoziwlh/ftdc
null
310,418,823
1
null
[ { "action": "opened", "author": "yangguang760", "comment_id": null, "datetime": 1522654577000, "masked_author": "username_0", "text": "概览了一下代码,有些疑问,请赐教。\r\nFtdClientPool 中的pollMap以ip+port为key,以FixedChannelPool为value;则我认为,FtdClientPool 中的所有连接对brokerId及userId不敏感(FtdClientPool 中的acquire方法并未将brokerId及userId作为取连接的依据),每次发送登录,从整个pool中取一个连接,登录成功时与Spi及Session绑定。\r\n如果上述未理解错误,则目前尚无法连接多家期货公司。\r\n建议两种方案:\r\n1:取消FtdClientPool的单例机制,每期货公司创建一实例。\r\n2:在FtdClientPool获取连接的机制中加入brokerId与fixedChannelPool的对应关系。", "title": "多期货公司问题", "type": "issue" }, { "action": "created", "author": "haoziwlh", "comment_id": 377877702, "datetime": 1522655348000, "masked_author": "username_1", "text": "![image](https://user-images.githubusercontent.com/5228401/38188172-4186b07a-368d-11e8-8f49-4d316213dfdb.png)\r\n在FtdcTraderApi接口中提供了绑定的接口 实现下就可以了", "title": null, "type": "comment" }, { "action": "created", "author": "yangguang760", "comment_id": 377895359, "datetime": 1522661931000, "masked_author": "username_0", "text": "理解了,多谢!", "title": null, "type": "comment" }, { "action": "closed", "author": "yangguang760", "comment_id": null, "datetime": 1522661931000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
500
false
false
500
false
Crunch-io/crunch-cube
Crunch-io
309,093,244
38
{ "number": 38, "repo": "crunch-cube", "user_login": "Crunch-io" }
[ { "action": "opened", "author": "kwypchlo", "comment_id": null, "datetime": 1522177182000, "masked_author": "username_0", "text": "https://www.pivotaltracker.com/story/show/154613258", "title": "correct univariate_ca method", "type": "issue" } ]
2
2
355
false
true
51
false
tikonoff/staking-app
null
296,944,151
18
null
[ { "action": "opened", "author": "ryu9827", "comment_id": null, "datetime": 1518571016000, "masked_author": "username_0", "text": "https://github.com/username_1/staking-app/blob/8306bb8deebe0f554e99bf4e525ea4a3f5672397/contracts/Stake.sol#L140\r\nHere using weiPerFee to be the divisor. In the whitepaper, ETH_FEE_RATE is used to multiple ETH amount to calculate FEE tokens. \r\nWe can understand that weiPerFee is the reciprocal of ETH_FEE_RATE. But it is better for readability if we keep code logic align to the whitepaper.", "title": "keep code logic align to whitepaper for better readability", "type": "issue" }, { "action": "created", "author": "tikonoff", "comment_id": 365801791, "datetime": 1518658830000, "masked_author": "username_1", "text": "CAPITAL_LETTERS_WITH_UNDERSCORE usually means constant variable.\r\nUsing the same logic in the development and public documents is not a great idea, I believe. \r\nJust imagine, that your cars parts will be called not the \"driving wheel\" for example, but \"part number 56TH - W00000000023.123 YH\". \r\n\r\nReadability of the code means that anyone can read the code and understand conception beside that code. In this case \"feeForTheStakingInterval\" looks good I think.", "title": null, "type": "comment" }, { "action": "created", "author": "ryu9827", "comment_id": 365826736, "datetime": 1518671249000, "masked_author": "username_0", "text": "This issue is not about the names or weather it is capital letters. It is about their roles in the formula. \r\nIn the codes, weiPerFee is the divisor. By contrast, ETH_FEE_RATE is a multiplier on the whitepaper.\r\nI think it is better for understanding if both of them are divisors so we or the stakers don't worry about if the developer makes a mistake here.", "title": null, "type": "comment" }, { "action": "created", "author": "tikonoff", "comment_id": 365841585, "datetime": 1518678110000, "masked_author": "username_1", "text": "Oh, I see your point. Yes, they used different formulas in the code and in the WP. \r\nSure, it is better to keep consistency. Then it may be better to call the issue something like \"Formulas of the FEE calculations in the code and whitepaper are contradicting each other\"", "title": null, "type": "comment" } ]
2
4
1,477
false
false
1,477
true
foundeo/cfdocs
foundeo
349,365,025
897
{ "number": 897, "repo": "cfdocs", "user_login": "foundeo" }
[ { "action": "opened", "author": "KamasamaK", "comment_id": null, "datetime": 1533872245000, "masked_author": "username_0", "text": "", "title": "Add 3 deprecated K2 functions", "type": "issue" }, { "action": "created", "author": "pfreitag", "comment_id": 412630530, "datetime": 1534187453000, "masked_author": "username_1", "text": "Looks like this failed on Travis because the functions were not added to the indexes... I'll merge and correct this after merging.", "title": null, "type": "comment" }, { "action": "created", "author": "pfreitag", "comment_id": 412631825, "datetime": 1534187727000, "masked_author": "username_1", "text": "Added indexes in commit b9bc7cbabd2fcd810c781229ca83be4501575805, fixes travis.", "title": null, "type": "comment" } ]
2
3
209
false
false
209
false
girleffect/core-authentication-service
girleffect
353,296,298
170
{ "number": 170, "repo": "core-authentication-service", "user_login": "girleffect" }
[ { "action": "opened", "author": "AltusBarry", "comment_id": null, "datetime": 1535016088000, "masked_author": "username_0", "text": "", "title": "Feature/geinfra 236 geinfra 246", "type": "issue" }, { "action": "created", "author": "cobusc", "comment_id": 415400601, "datetime": 1535028184000, "masked_author": "username_1", "text": ":+1:", "title": null, "type": "comment" } ]
2
2
4
false
false
4
false
Haehnchen/idea-php-symfony2-plugin
null
360,038,583
1,229
null
[ { "action": "opened", "author": "oleg-andreyev", "comment_id": null, "datetime": 1536867742000, "masked_author": "username_0", "text": "Stacktrace\r\n<details>\r\n\r\n```\r\njava.lang.AssertionError: Already disposed: Project (Disposed) app\r\n\tat com.intellij.openapi.components.impl.ComponentManagerImpl.b(ComponentManagerImpl.java:248)\r\n\tat com.intellij.openapi.application.ReadAction.lambda$run$1(ReadAction.java:53)\r\n\tat com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:959)\r\n\tat com.intellij.openapi.application.ReadAction.compute(ReadAction.java:57)\r\n\tat com.intellij.openapi.application.ReadAction.run(ReadAction.java:53)\r\n\tat com.intellij.openapi.components.impl.ComponentManagerImpl.a(ComponentManagerImpl.java:246)\r\n\tat com.intellij.openapi.components.impl.ComponentManagerImpl.getPicoContainer(ComponentManagerImpl.java:239)\r\n\tat com.intellij.openapi.components.impl.ComponentManagerImpl.getPicoContainer(ComponentManagerImpl.java:45)\r\n\tat com.intellij.openapi.components.ServiceManager.doGetService(ServiceManager.java:42)\r\n\tat com.intellij.openapi.components.ServiceManager.getService(ServiceManager.java:30)\r\n\tat fr.adrienbrault.idea.symfony2plugin.Settings.getInstance(Settings.java:98)\r\n\tat fr.adrienbrault.idea.symfony2plugin.dic.webDeployment.ServiceContainerRemoteFileStorage.files(ServiceContainerRemoteFileStorage.java:32)\r\n\tat fr.adrienbrault.idea.symfony2plugin.webDeployment.utils.RemoteWebServerUtil.hasConfiguredRemoteFile(RemoteWebServerUtil.java:116)\r\n\tat fr.adrienbrault.idea.symfony2plugin.webDeployment.WebDeploymentProjectComponent$MyTimerTask.run(WebDeploymentProjectComponent.java:61)\r\n\tat java.util.TimerThread.mainLoop(Timer.java:555)\r\n\tat java.util.TimerThread.run(Timer.java:505)\r\n```\r\n</details>\r\n\r\nPhpStorm 2018.2.3\r\nBuild #PS-182.4323.68, built on September 13, 2018\r\nJRE: 1.8.0_152-release-1248-b8 x86_64\r\nJVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o\r\nmacOS 10.13.6", "title": "Already disposed: Project (Disposed) app", "type": "issue" }, { "action": "created", "author": "cedricziel", "comment_id": 421146527, "datetime": 1536871396000, "masked_author": "username_1", "text": "`Already disposed` errors might happen when a project is closed while loading. Not entirely sure what the `WebDeploymentProjectComponent` does - can someone explain it to me, so I can (possibly) fix it?", "title": null, "type": "comment" } ]
2
2
2,008
false
false
2,008
false
RocketChat/Rocket.Chat
RocketChat
376,428,376
12,519
null
[ { "action": "opened", "author": "aspiers", "comment_id": null, "datetime": 1541084212000, "masked_author": "username_0", "text": "### Description:\r\n\r\nThe `Shift+Escape` keyboard shortcut to mark all messages as read, clashes with Chrome's shortcut for opening the Task Manager.\r\n\r\nAFAICS this shortcut is undocumented - I discovered it purely by accident.\r\n\r\n### Steps to reproduce:\r\n\r\n1. Go to any Rocket.Chat channel page on the web client\r\n2. Press `Shift+Escape`\r\n\r\n### Expected behavior:\r\n\r\nGiven the clash, I'm not sure it's possible to have any reasonable expectation about the behaviour.\r\n\r\n### Actual behavior:\r\n\r\nSometimes it pops up a dialog asking if I really want to mark all messages in all channels as read. Other times, Chrome's Task Manager appears. I haven't yet spotted any pattern to when one occurs vs. the other.\r\n\r\n### Server Setup Information:\r\n\r\n* Version of Rocket.Chat Server: >= 0.70.0 (exact version tbc)\r\n* Operating System: SUSE Linux Enterprise Server 12 \r\n* Deployment Method: Docker (official)\r\n* Number of Running Instances: 1\r\n* DB Replicaset Oplog: disabled\r\n* Node Version: 8.9.4 (comes with the image)\r\n* MongoDB Version: ?? (can't check right now, sorry)\r\n\r\n### Additional context\r\n\r\nPreviously it was pot luck whether I would get the \"Mark all messages as read\" dialog, or the Chrome Task Manager. However our server is updated every few weeks, and with the current version I have not yet managed to get the former.", "title": "Shift+Escape mark all as read shortcut clashes with Chrome", "type": "issue" }, { "action": "closed", "author": "rodrigok", "comment_id": null, "datetime": 1541526892000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
1,329
false
false
1,329
false
Spomky-Labs/otphp
Spomky-Labs
383,979,703
123
{ "number": 123, "repo": "otphp", "user_login": "Spomky-Labs" }
[ { "action": "opened", "author": "Spomky", "comment_id": null, "datetime": 1543057203000, "masked_author": "username_0", "text": "| Q | A\r\n| ------------- | ---\r\n| Branch? | master\r\n| Bug fix? | #122 \r\n| New feature? | /no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n\r\n<!--\r\nFill in this template according to the PR you're about to submit.\r\nReplace this comment by a description of what your PR is solving.\r\n\r\nPlease consider the following requirement:\r\n* Modification of existing tests should be avoided unless deemed necessary.\r\n* You MUST never open a PR related to a security issue. Contact username_0 in private at https://gitter.im/username_0/\r\n-->", "title": "Allow both beberlei/assert v2.4 and 3.x", "type": "issue" } ]
2
2
813
false
true
542
true
elastic/stack-docker
elastic
319,395,905
36
null
[ { "action": "opened", "author": "Vannazux", "comment_id": null, "datetime": 1525230645000, "masked_author": "username_0", "text": "I receive this error when trying to put elk uo with docker compose in win 10. Could you give me a help?\r\n\r\nERROR: for elasticsearch Cannot start service elasticsearch: driver failed programming external connectivity on endpoint elasticsearch (5b874e7932a418d88bfbb81c00db9c593e38cf135fbdb9be0c4544a508f8afe0): Error starting userland proxy: mkdir /port/tcp:127.0.0.1:9200:tcp:172.26.0.2:9200: input/output error", "title": "ERROR when executing docker-compose up", "type": "issue" } ]
1
1
412
false
false
412
false
django/django
django
206,124,303
8,033
{ "number": 8033, "repo": "django", "user_login": "django" }
[ { "action": "opened", "author": "AmaliaSoucek", "comment_id": null, "datetime": 1486541287000, "masked_author": "username_0", "text": "Marked request with _mark_post_parse_error in response_for_exception\r\nif exc is RequestDataTooBig to prevent attempts to access POST data\r\nagain.", "title": "Fixed #27820 -- avoided RequestDataTooBig in response_for_exception", "type": "issue" }, { "action": "created", "author": "timgraham", "comment_id": 278717574, "datetime": 1486662397000, "masked_author": "username_1", "text": "I'm not sure if this is the best place to put the fix. Any thoughts @username_2?\r\n\r\nAlso, I wonder if a more high level test would be better instead of testing `response_for_exception()` directly (considering that HTTP handling is sometimes refactored, it might not be obvious how to adapt the test).\r\n\r\nAfter we decide on how to proceed, please send the pull request to master instead of stable/1.10.x We backport fixes to the stable branches after committing to master. Thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "edevil", "comment_id": 278721760, "datetime": 1486663239000, "masked_author": "username_2", "text": "The place for the ```_mark_post_parse_error()``` seems fine at a first glance.", "title": null, "type": "comment" }, { "action": "created", "author": "timgraham", "comment_id": 278815252, "datetime": 1486684541000, "masked_author": "username_1", "text": "Amalia, as noted on the ticket, please also fix the issue for `TooManyFields`. Thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "AmaliaSoucek", "comment_id": 278874771, "datetime": 1486711083000, "masked_author": "username_0", "text": "Thanks for the review! I'll do that!", "title": null, "type": "comment" } ]
3
5
820
false
false
820
true
web3j/web3j
web3j
357,715,676
698
null
[ { "action": "opened", "author": "elizur-cartasense", "comment_id": null, "datetime": 1536248526000, "masked_author": "username_0", "text": "I've been trying to send a message to an account by sending 0 Ethers and putting the (short) message in the data part of the transaction. but...\r\nRawTransaction.createEtherTransaction() does not provide access to the data field.\r\nI tried using RawTransaction.createTransaction() but the resulting transaction is interpreted as a contract creation on blockchain.\r\ncould you allow access to data field in RawTransaction.createEtherTransaction()?\r\n\r\nthanks", "title": "access to data member in RawTransaction.createEtherTransaction()", "type": "issue" }, { "action": "created", "author": "iikirilov", "comment_id": 438692992, "datetime": 1542207827000, "masked_author": "username_1", "text": "Does #702 resolve your issue?", "title": null, "type": "comment" }, { "action": "closed", "author": "AlexandrouR", "comment_id": null, "datetime": 1562925500000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
3
482
false
false
482
false
RedHatInsights/insights-frontend-starter-app
RedHatInsights
328,434,075
12
{ "number": 12, "repo": "insights-frontend-starter-app", "user_login": "RedHatInsights" }
[ { "action": "opened", "author": "karelhala", "comment_id": null, "datetime": 1527843145000, "masked_author": "username_0", "text": "Simple example how to write tests and config which runs jest [1] is provided, this PR also removes webpack config specific to test and introduces new env variable ANALYZE, if such variable is given user may observer bunldes [2].\r\n\r\n[1] https://facebook.github.io/jest/\r\n[2] https://www.npmjs.com/package/webpack-bundle-analyzer", "title": "Enable tests over jest", "type": "issue" }, { "action": "created", "author": "Kinlaw", "comment_id": 395851218, "datetime": 1528483083000, "masked_author": "username_1", "text": "@username_0 my bad, I let this slip and it has diverged quite a bit. Can you rebase?", "title": null, "type": "comment" }, { "action": "created", "author": "Kinlaw", "comment_id": 400311064, "datetime": 1530020175000, "masked_author": "username_1", "text": "@jharting I think I have this cleaned up. Can you take a look when you get a chance?", "title": null, "type": "comment" }, { "action": "created", "author": "karelhala", "comment_id": 400315686, "datetime": 1530020980000, "masked_author": "username_0", "text": "@username_1 looks good! I'd approve it, but I am original author of PR", "title": null, "type": "comment" }, { "action": "created", "author": "Kinlaw", "comment_id": 400661389, "datetime": 1530104086000, "masked_author": "username_1", "text": "@jharting fixed. Can you take another look?", "title": null, "type": "comment" } ]
2
5
603
false
false
603
true
buefy/buefy
buefy
341,326,502
907
{ "number": 907, "repo": "buefy", "user_login": "buefy" }
[ { "action": "opened", "author": "BlackMix", "comment_id": null, "datetime": 1531666137000, "masked_author": "username_0", "text": "looks doc.. has bug on select: 2 = 1, 3 = 2 etc\r\n+ 1 in day fix it", "title": "fix day on select date", "type": "issue" }, { "action": "created", "author": "jtommy", "comment_id": 405110441, "datetime": 1531680799000, "masked_author": "username_1", "text": "@username_0 Why? In the Date object docs:\r\ngetDate() - Get the day as a number (1-31)", "title": null, "type": "comment" }, { "action": "created", "author": "BlackMix", "comment_id": 405120738, "datetime": 1531691132000, "masked_author": "username_0", "text": "@username_1 looks on your doc and click any day", "title": null, "type": "comment" }, { "action": "created", "author": "jtommy", "comment_id": 405121237, "datetime": 1531691608000, "masked_author": "username_1", "text": "@username_0 What's your timezone ?", "title": null, "type": "comment" }, { "action": "created", "author": "BlackMix", "comment_id": 405121375, "datetime": 1531691749000, "masked_author": "username_0", "text": "@username_1 https://cdn.discordapp.com/attachments/410021276212658186/468173197238468639/bug.mp4\r\n\r\nBRT america/recife", "title": null, "type": "comment" }, { "action": "created", "author": "jtommy", "comment_id": 405122540, "datetime": 1531692882000, "masked_author": "username_1", "text": "@username_0 I cannot reproduce the issue. \r\nAre you trying in the current develop branch or in last version (current online docs) ?", "title": null, "type": "comment" }, { "action": "created", "author": "BlackMix", "comment_id": 405123403, "datetime": 1531693955000, "masked_author": "username_0", "text": "current online doc and version 0.6.6", "title": null, "type": "comment" }, { "action": "created", "author": "BlackMix", "comment_id": 405124144, "datetime": 1531694854000, "masked_author": "username_0", "text": "so let me close it and install dev version lol", "title": null, "type": "comment" } ]
3
9
549
false
true
549
true
RetailMeNotSandbox/roux
RetailMeNotSandbox
232,941,082
26
{ "number": 26, "repo": "roux", "user_login": "RetailMeNotSandbox" }
[ { "action": "opened", "author": "lzilioli", "comment_id": null, "datetime": 1496335413000, "masked_author": "username_0", "text": "This fixes #23", "title": "better check for presence of ingredient within pantry fixes #23", "type": "issue" }, { "action": "created", "author": "lawnsea", "comment_id": 305569792, "datetime": 1496339538000, "masked_author": "username_1", "text": "@username_0 this failed linting", "title": null, "type": "comment" }, { "action": "created", "author": "lzilioli", "comment_id": 305576038, "datetime": 1496340974000, "masked_author": "username_0", "text": "@username_1 fixed", "title": null, "type": "comment" } ]
3
5
622
false
true
58
true
fthomas/refined
null
164,153,232
186
null
[ { "action": "opened", "author": "fthomas", "comment_id": null, "datetime": 1467832804000, "masked_author": "username_0", "text": "Scala Exercises' lessons for refined would be cool, see see http://www.47deg.com/blog/scala-exercises-version-two#contribute-3", "title": "Scala Exercises for refined", "type": "issue" }, { "action": "created", "author": "andyscott", "comment_id": 266931259, "datetime": 1481685297000, "masked_author": "username_1", "text": "This would be a very welcomed addition to Scala Exercises!", "title": null, "type": "comment" }, { "action": "created", "author": "ysusuk", "comment_id": 314400557, "datetime": 1499768305000, "masked_author": "username_2", "text": "i made some first steps https://github.com/username_2/exercises-refined/", "title": null, "type": "comment" }, { "action": "created", "author": "fthomas", "comment_id": 314578062, "datetime": 1499808605000, "masked_author": "username_0", "text": "Awesome @username_2! Is there an easy way to run them?", "title": null, "type": "comment" }, { "action": "created", "author": "andyscott", "comment_id": 314603719, "datetime": 1499817125000, "masked_author": "username_1", "text": "/cc @raulraja see above", "title": null, "type": "comment" }, { "action": "created", "author": "ysusuk", "comment_id": 315055086, "datetime": 1499946497000, "masked_author": "username_2", "text": "@username_0 i think the easiest way is of course to run the tests=) but if you want to check the UI you'll need to build `sbt compile pushLocal` on `exercises-refined`. Then clone https://github.com/scala-exercises/scala-exercises/ and configure it for local run https://github.com/scala-exercises/scala-exercises#local-development. The configuration process takes some time, but works like a charm when you are finished!", "title": null, "type": "comment" } ]
3
6
743
false
false
743
true
golang/go
golang
319,083,969
25,192
null
[ { "action": "opened", "author": "zhyale", "comment_id": null, "datetime": 1525136064000, "masked_author": "username_0", "text": "Please answer these questions before submitting your issue. Thanks!\r\n\r\n\r\n### What version of Go are you using (`go version`)?\r\ngo1.10.1 linux/amd64\r\n\r\n### Does this issue reproduce with the latest release?\r\nYes\r\n\r\n### What operating system and processor architecture are you using (`go env`)?\r\nCentOS 7 with kernel 3.10.0-514.10.2.el7.x86_64\r\n\r\n### What did you do?\r\nI create a program to detect attack such as SQL Injection, when test case is:\r\nhttp://..../id=1%27;--\r\n\r\nand I use:\r\nr.ParseForm()\r\nparams := r.Form\r\nfmt.Println(\"params:\", params, \"count:\", len(params))\r\nfor key, values := range params {\r\n\t\tfmt.Println(\"param\", key, \":\", values)\r\n}\r\n\r\nGot:\r\nparams: map[--:[] id:[1']] count: 2\r\nparam id : [1']\r\nparam -- : []\r\n\r\n\r\n### What did you expect to see?\r\nexpect only one expression in this case:\r\nkey: id\r\nvalue: 1';--\r\n\r\n### What did you see instead?\r\nI got two key:[value] pairs.", "title": "r.Form parse error when parameter include SQL Injection test", "type": "issue" }, { "action": "created", "author": "agnivade", "comment_id": 385592902, "datetime": 1525146570000, "masked_author": "username_1", "text": "Complete repro -\r\n\r\n```go\r\npackage main\r\n\r\nimport (\r\n\t\"fmt\"\r\n\t\"net/http\"\r\n)\r\n\r\nfunc main() {\r\n\thttp.HandleFunc(\"/foo\", func(w http.ResponseWriter, req *http.Request) {\r\n\t\terr := req.ParseForm()\r\n\t\tif err != nil {\r\n\t\t\tfmt.Println(err)\r\n\t\t\tw.Write([]byte(\"error\"))\r\n\t\t\treturn\r\n\t\t}\r\n\t\tparams := req.Form\r\n\t\tfmt.Println(\"params:\", params, \"count:\", len(params))\r\n\t\tfor key, values := range params {\r\n\t\t\tfmt.Println(\"param\", key, \":\", values)\r\n\t\t}\r\n\t\tw.Write([]byte(\"OK\"))\r\n\t})\r\n\r\n\tfmt.Println(\"starting on port 9999\")\r\n\tserver := &http.Server{\r\n\t\tAddr: \":9999\",\r\n\t}\r\n\tserver.ListenAndServe()\r\n}\r\n```\r\n\r\n`curl 'http://localhost:9999/foo?id=1%27;--'`\r\n\r\n@username_4 - Is this expected ?", "title": null, "type": "comment" }, { "action": "created", "author": "fraenkel", "comment_id": 385651055, "datetime": 1525174221000, "masked_author": "username_2", "text": "Both & and ; are used to split key value pairs. The ; is optional since it allows you to provide a URL as a value with a query string.\r\nSee https://en.wikipedia.org/wiki/Query_string under Web Forms", "title": null, "type": "comment" }, { "action": "created", "author": "odeke-em", "comment_id": 385662789, "datetime": 1525178758000, "masked_author": "username_3", "text": "Hello @username_0, thank you for filing this issue and welcome to the Go project!\r\n\r\n@username_1 and @username_2 thank you for the responses too.\r\n\r\nSo I believe, the root cause of the question here is rather: `Why is a semi colon being used as a separator in url.Parse?`\r\n\r\nIf you run https://play.golang.org/p/QVz18jWspPF or inlined below:\r\n```go\r\npackage main\r\n\r\nimport (\r\n\t\"log\"\r\n\t\"net/url\"\r\n)\r\n\r\nfunc main() {\r\n\tlog.SetFlags(0)\r\n\tu, err := url.Parse(\"http://localhost:9999/foo?id=1%27;--\")\r\n\tif err != nil {\r\n\t\tlog.Fatalf(\"Failed to parse URL: %v\", err)\r\n\t}\r\n\tlog.Printf(\"%#v\\n\", u.Query())\r\n}\r\n```\r\nYou'll see the real symptom\r\n```shell\r\nurl.Values{\"--\":[]string{\"\"}, \"id\":[]string{\"1'\"}}\r\n```\r\n\r\nA W3C recommendation https://www.w3.org/TR/html401/appendix/notes.html#h-B.2.2 recommended using `;` as a separator for url-encoded params for form-data\r\n<img width=\"1276\" alt=\"screen shot 2018-05-01 at 5 08 58 am\" src=\"https://user-images.githubusercontent.com/4898263/39472383-d41e7482-4cfd-11e8-9326-d8b2a668e17a.png\">\r\n\r\nand that was what we used to add `;` as a separator, making ';' synoymous with '&' in https://golang.org/cl/4973062 https://github.com/golang/go/issues/2210#issue-51278892 \r\n\r\nHowever, unfortunately that recommendation just got superseded very recently in mid-December 2017 by https://www.w3.org/TR/2017/REC-html52-20171214/\r\n\r\nand now that points to https://url.spec.whatwg.org/#urlsearchparams\r\nin which we can see that the only separator here is '&'\r\n<img width=\"1167\" alt=\"screen shot 2018-05-01 at 5 19 53 am\" src=\"https://user-images.githubusercontent.com/4898263/39472615-51c970a2-4cff-11e8-80ec-4b1428326774.png\">\r\n\r\n\r\n\r\nNode.js doesn't seem to recognize ';' as a separator\r\n```javascript\r\nurl.parse('http://localhost:9999/foo?id=1%27;--', true);\r\nUrl {\r\n protocol: 'http:',\r\n slashes: true,\r\n auth: null,\r\n host: 'localhost:9999',\r\n port: '9999',\r\n hostname: 'localhost',\r\n hash: null,\r\n search: '?id=1%27;--',\r\n query: { id: '1\\';--' },\r\n pathname: '/foo',\r\n path: '/foo?id=1%27;--',\r\n href: 'http://localhost:9999/foo?id=1%27;--' }\r\n```\r\n\r\nand the old survey of what other languages do while technically still correct per https://github.com/golang/go/issues/2210#issuecomment-66058500, any future adoptions of the new recommendation from W3C will mean that those languages will also change their behavior.\r\n\r\nNow the big question is: this behavior has been around since 2011, changing it 7 years later might massively break code for many users. Perhaps we need a survey of the make-up and interpretation of query strings from some frontend server?\r\n\r\nAlso this perhaps will need some security considerations as well or maybe a wide scale adoption of the recommendation first?\r\n\r\nIn addition to those already paged, I will page some more folks to help pitch in thoughts about the fate of the new W3C recommendation /cc @username_19 @andybons @tombergan @agl @username_7 @username_5", "title": null, "type": "comment" }, { "action": "created", "author": "bradfitz", "comment_id": 385692432, "datetime": 1525186808000, "masked_author": "username_4", "text": "So we can't change it during Go 1.x.\r\n\r\nRepurposing this to be a Go 2.x issue.", "title": null, "type": "comment" }, { "action": "created", "author": "mikesamuel", "comment_id": 385696543, "datetime": 1525187732000, "masked_author": "username_5", "text": "+1\r\n\r\nWe might be able to get a handle on the size of potential breakage by surveying URL composition libraries to get an idea of how many sources are likely to produce URLs that are substantially different given non-crafted inputs.\r\n\r\nFor example:\r\n\r\n```go\r\n// html/template\r\nt, _ := template.New(\"T\").Parse(`<a href=\"/?a={{.}}&b=b\">`)\r\nt.Execute(&out, `foo;bar&baz`)\r\nout.String() == `<a href=\"/?a=foo%3bbar%26baz&b=b\">`\r\n\r\n// net/url\r\nurl.QueryEscape(`foo;bar&baz`) == `foo%3Bbar%26baz`\r\nurl.QueryUnescape(`foo%3Bbar%26baz`) == `foo;bar&baz`\r\n```\r\n\r\nIn vanilla JS\r\n```js\r\nencodeURIComponent(`foo;bar&baz`) == `foo%3Bbar%26baz`\r\nencodeURI(`foo;bar&baz`) == `foo;bar&baz`\r\n```\r\n\r\n----\r\n\r\nI think this is mostly a correctness and interop issue but that the security consequences are not severe.\r\n\r\nThat said, there are risks to inferring more structure than the spec allows.\r\n\r\nIf a survey finds that there are widely used url.QueryEscape / encodeURIComponent counterparts that escape `&` but do not escape `;`, and a trusted partner composes URLs thus:\r\n\r\n```\r\ngoServiceUrl = \"//example.com/?\"\r\n + \"securityIrrelevantParam=\" + laxEscapeQuery(untrustedString)\r\n + \"&importantParam=\" + laxEscapeQuery(trustedString)\r\n```\r\n\r\nthen `untrustedString` might inject a `;importantParam` which would be available as the zero-th entry in Go's query map.\r\n\r\nThe risk is pretty small as long as `laxEscapeQuery` escapes `'='` and one workaround is to consistently enforce has-exactly-one constraints.", "title": null, "type": "comment" }, { "action": "created", "author": "FiloSottile", "comment_id": 789799446, "datetime": 1614785409000, "masked_author": "username_6", "text": "It was recently pointed out that this behavior divergence can [lead to cache poisoning attacks](https://snyk.io/blog/cache-poisoning-in-popular-open-source-packages/) in reverse proxies that cache based on a subset of query parameters: if Go treats `https://example.com/?x;id=1337&id=123` as a request for ID 1337, while the cache treats it as a request for ID 123, the cache can be made to serve the wrong response.\r\n\r\nAt the risk of repeating myself, I want to point out that relying on parser alignment for security is doomed, so this will break again, and often in subtler ways that we can't fix universally. However, this is probably broken _most of the time_ now, so we should fix it.\r\n\r\nI did a quick survey of other popular languages and frameworks.\r\n\r\n* PHP used to support both but now defaults to only `&`. https://www.php.net/manual/en/ini.core.php#ini.sect.data-handling\r\n* Rails (via Rack) currently supports both, but landed a change in January following the Snyk blog post. Unclear when it will reach a release. https://github.com/rack/rack/issues/1732\r\n* Python currently supports both, but will switch in 3.10 and assigned it a CVE. https://github.com/python/cpython/pull/24297\r\n\r\nA more interesting question would be how caching proxies behave, but a lot of them are ad-hoc and hard to test. Snyk seems to think at least Varnish uses only `&`. As pointed out in https://github.com/golang/go/issues/25192#issuecomment-432369818, AWS is not only ignoring `;`, but it's unescaping it while proxying.\r\n\r\nI think the W3C and WHATWG recommendations are sort of red herrings: they are about `x-www-form-urlencoded`, not URL queries. On the other hand, the entire reason anyone supported `;` is that it was more convenient to use for `x-www-form-urlencoded` forms, as it did not require escaping `&` in HTML.\r\n\r\nGiven Rails and Python are waiting for the next scheduled release to fix this, we will too, and ship the fix in Go 1.17. It would be too harsh of a behavior change for too vague of a security benefit to land in a security release anyway.\r\n\r\nThis is technically a backwards compatibility promise violation, but I am invoking the security exception. More broadly, we should think whether the thing we want to provide compatibility with is \"the exact self-contained behavior of the library when it was introduced\" or \"correctly interoperate with the current ecosystem\". Realistically, we are already doing more of the latter with crypto/tls and crypto/x509, because doing the exact same thing as 5 years ago would be useless and insecure. HTTP and web specifications are similarly living and evolving, and we should figure out what our policy about that is.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 789933519, "datetime": 1614793941000, "masked_author": "username_7", "text": "It seems kind of backward that every single HTTP server implementation in the world is being charged with coping with a decision made by a few proxies. If they don't think ; is special, then they could easily force it not to be special by escaping the ; as they pass it through. (AWS doing the opposite of that is even more mind-boggling.)\r\n\r\nCan we find some way to make this change less silent? I worry about people updating to Go 1.17 and having their servers misbehave but with no idea why. Maybe a logging print for each request that ignores ; as separator, limited to one per second or something like that?\r\n\r\nIt also seems like a hard requirement to be able to opt back in to the old behavior. Users with client apps sending ; that don't have the misfortune of being behind nginx will not like being forced to rewrite and redeploy their apps just to get Go 1.17.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 795873543, "datetime": 1615400992000, "masked_author": "username_7", "text": "Adding to the minutes. It's getting a bit late to make a change in Go 1.17 so we should try to converge on a plan soon.\r\n\r\n@bigluck, if you still use the AWS API Gateway, does it still _unescape_ semicolons? Or does anyone else know?", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 795876917, "datetime": 1615401137000, "masked_author": "username_7", "text": "@username_19 found private mail saying that https://angular.io/api/common/http/HttpUrlEncodingCodec did not escape semicolons at least in 2019, leading to confusion as well. Does anyone know if that is still the case?\r\n\r\nAnd does anyone know of any clients that _do_ use semicolons for separators and would break if we stopped recognizing them?", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 796858310, "datetime": 1615479607000, "masked_author": "username_7", "text": "This is good advice. It boils down to \"Make sure your server and your cache proxy agree about how to split query arguments.\" The simplest, most guaranteed way to do this is to have the proxy rewrite the query to be unambiguous.\r\n\r\n### 4. Go servers behind nginx are _not_ affected by default.\r\n\r\nThe nginx docs say the [default proxy cache key](http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_key) is `$scheme$proxy_host$request_uri`. That does _not_ interpret the query parameters at all, so it has no problem with semicolons versus ampersands. \r\n\r\nThe way to get into trouble is to use a key like `$arg_x` which extracts the `x` parameter from the query string and does so without considering semicolons (the code is ngx\\_http\\_arg called from ngx\\_http\\_variable\\_argument in the nginx code base; there is no configuration to allow semicolons). Go users, and Python users, and Ruby users, and many others, _cannot_ sync the nginx behavior and their server's behavior while also using query parameter cache keys. But again, these keys are not used by default. Only users who use these keys need to make a change.\r\n\r\n### 5. A potential non-breaking Go change.\r\n\r\nTo not break users, we could add a url.AllowQuerySemicolon function that controls whether ParseQuery accepts semicolons. It can default to true, but users who want to use nginx's query argument cache keys would call AllowQuerySemicolon(false) to bring the Go implementation in line with nginx's.\r\n\r\nIt is not clear to me that we have enough justification to take the next step of changing the default and breaking users, all for the very few users who are using nginx _and_ setting a custom cache key using query argument parameters.\r\nAgain, **this does not affect all Go programs sitting behind nginx**. It only affects those who set a custom proxy_cache_key and use a `$arg_xxx` form.\r\n\r\nIn the long term, it still seems like nginx should rewrite the query strings to escape semicolons in requests that are consulting the proxy cache and using query parameter argument keys, ensuring that nginx's understanding of the request URL matches the server's, 100% of the time, no matter what the server is.", "title": null, "type": "comment" }, { "action": "created", "author": "FiloSottile", "comment_id": 801105145, "datetime": 1615989675000, "masked_author": "username_6", "text": "I think focusing on nginx is optimistic. nginx happens to be a popular reverse proxy that exhibits this behavior, but I doubt it's the only one. We should check Cloudflare, Fastly, Akamai, AWS, GCP, Azure, Varnish, F5, and Apache, off the top of my head. If they all need to change, then changing the server frameworks is not \"changing the thing in a lot of places instead of in one place\" (which I generally agree with as an argument).\r\n\r\nAt that point, I think it becomes a matter of what's more expected and predictable. The HTML 4 spec is hardly authoritative for URL query strings in HTTP, so we just don't have an easy reference here. As of today, I found the `;` surprising. If I were to write or audit a regex-based cache key, I would not have flagged the lack of semicolon support, nor would I have requested that the regex be wired into the rewriting engine (which is usually not possible). Now that Python, PHP, and Rails are switching to the better-known behavior, the situation will get worse over time, not better. In five years, we'll be the odd one out, and it will be hard to convince all new reverse proxies to do query string mangling to support Go's bizarre URL parsing.\r\n\r\nIf you are not convinced, I think we should check with all those other reverse proxy vendors before declining this proposal.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 806015076, "datetime": 1616606647000, "masked_author": "username_7", "text": "It sounds like the argument is that \"Go should break all the semicolon users because all the others are too\". \r\nAnd maybe that's true. What we don't really know is how many semicolon users there are.\r\n\r\nAgain, this does not happen in reverse proxies out of the box, only when you start trying to distinguish by query \r\nparameters.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 806056155, "datetime": 1616610246000, "masked_author": "username_7", "text": "Twitter threads gathering info:\r\nhttps://twitter.com/username_4/status/1374774763059482624\r\nhttps://twitter.com/username_6/status/1374777816139628545", "title": null, "type": "comment" }, { "action": "created", "author": "joneskoo", "comment_id": 806194586, "datetime": 1616620922000, "masked_author": "username_8", "text": "Many on the Twitter threads confusing this with semicolons in path section. That’s not what we’re talking about here, right?\r\n\r\nnot in scope:\r\n`https://example.com/a;b=c;foo=42`\r\n\r\nIn scope:\r\n`https://example.com/a?b=c;foo=42`\r\n\r\nnotably JSESSIONID mentioned a few times.\r\n\r\nhttps://play.golang.org/p/OUVtI15HkU3", "title": null, "type": "comment" }, { "action": "created", "author": "AGWA", "comment_id": 806252940, "datetime": 1616629226000, "masked_author": "username_9", "text": "I'm a semicolon user. I like the ergonomic benefits from not having to escape `&` in HTML.\r\n\r\nThe backwards compatibility break for this would be really nasty. Unlike removing TLS ciphers or support for common name, this won't result in a predictable error. Instead the program will behave differently, and a log message is cold comfort if the program has already taken some undesirable action based on misinterpreting a query string. The bar for such a compatibility break should be very high, and I don't think this proposal should qualify. Parsing URLs is a minefield and [practically every implementation does something differently](https://www.blackhat.com/docs/us-17/thursday/us-17-Tsai-A-New-Era-Of-SSRF-Exploiting-URL-Parser-In-Trending-Programming-Languages.pdf). Any proxy server which relies on parsing query strings in the same manner as their backends is insecure, and removing semicolon separators from Go doesn't change that.\r\n\r\nTo provide an example of how futile this effort is, nginx's query string parser ([`ngx_http_arg`](https://github.com/nginx/nginx/blob/2e94c81b0bf1d8e695d9afd074c79520aa03081a/src/http/ngx_http_parse.c#L2120)) differs from Go's in the following three additional ways:\r\n\r\n|nginx behavior|Example|Go value for `id`|nginx value for `id`|\r\n| --- | --- | --- | --- |\r\n|Keys are case-insensitive|`iD=1&id=2`|`2`|`1`|\r\n|Keys are not unescaped|`%69d=1&id=2`|`1`|`2`|\r\n|Keys without equal signs are not supported|`id&id=1`|(empty)|`1`|\r\n\r\nConsequentially, this proposal would not help nginx users at all, and I would not be surprised if other reverse proxies also deviated from Go in at least one of the above ways.\r\n\r\nI realize that there aren't many semicolon users (@username_6's Twitter poll has been bouncing between 1.5%-2%), but it strikes me as pretty inequitable to force us to deal with a change in application behavior whose only purpose is to try to paper over other people's risky behavior.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 806255755, "datetime": 1616629753000, "masked_author": "username_7", "text": "@username_8, you are correct: semicolons before a ? are unrelated to this issue.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 806256347, "datetime": 1616629863000, "masked_author": "username_7", "text": "@username_9, indeed. A major problem with this change is that it will be a reason users can't easily update to a newer version of Go, which will increase our support burden as users lag behind. By itself, it may not seem like much to break a small fraction of the user base, but over time that kind of thing adds up. \r\n\r\nThanks very much for the additional nginx examples. I think these support the idea that any kind of proxy caching that tries to strip \"unnecessary\" parts of the URL really needs to canonicalize the URL to enforce its interpretation before passing the query along. That is, there may be a real problem here, but the fix is being applied in the wrong place. Even if we \"fixed\" Go to match nginx in all these cases, it would still not match other caching proxies.\r\n\r\nAgain, this does not happen in reverse proxies out of the box, only when you start trying to filter \"unimportant\" parts of the query string. It's starting to sound like you should basically never do that, and reverse proxies should remove that feature entirely.", "title": null, "type": "comment" }, { "action": "created", "author": "FiloSottile", "comment_id": 806317544, "datetime": 1616639688000, "masked_author": "username_6", "text": "This is not practical, alas. Not for any reason I like, to be clear: it's mostly tracking parameters. But they are very much a thing and \"don't get to your business goals because parser alignment is impossible (and anyway we don't like your practices)\" is not a winning argument.\r\n\r\nTaking a step back, it sounds like there are two ways out of this as an ecosystem:\r\n\r\n1. we convince all reverse proxies to change the semantics of cache keys so that they rewrite the upstream URL to a canonicalized representation, on the argument that it's safer and more robust, and that they should mitigate our exclusive off-spec behavior\r\n2. we converge on the specified behavior, filing issues with reverse proxies that depart from the spec on the argument that they are off-spec and introducing a vulnerability\r\n\r\nI am not a fan of (2) at all, but (1) doesn't sound like it will happen, and this format is unusually simple and well-specified, so it might just be possible to match the spec.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 808423395, "datetime": 1616782522000, "masked_author": "username_7", "text": "I still can't escape the feeling this is all security theater, especially given what @username_9 pointed out.\r\nThe suggestion is to break existing Go users (we don't know how many, but greater than zero).\r\nAnd the benefit is ... unclear beyond speculation about possibly being one step in a much longer path involving many players toward converging on shared behavior.\r\n\r\nI just don't yet see how the benefits outweigh the costs.\r\n\r\nAlso the linked WHATWG spec is about JavaScript behavior specifically.\r\n(The rest of the spec is not, but the parsing of the query is only relevant to constructing a JavaScript object.)\r\n\r\nI'm sorry for being a pain about this, but breaking users is a big deal and we need to be sure it is worth it.\r\nAnd that evidence is absent so far. Starting from the very beginning with Snyk's sloppy blog post, there have been too many fuzzy claims that look different when you get up close and really examine them.", "title": null, "type": "comment" }, { "action": "created", "author": "slrz", "comment_id": 808827170, "datetime": 1616893928000, "masked_author": "username_10", "text": "If other implementations go ahead with this change it will probably cause existing users to move away from their semicolon usage. Let enough time pass and it might be rare enough for Go to follow without annoying too many users.\r\n\r\nNow, leaning back and watching while others take flak for breaking users may not be the nicest thing to do **if** the change in question is absolutely necessary for the ecosystem's continued health. In this case though, I think it's appropriate given that Python, Rails and friends don't have a strong commitment to compatibility in the first place (unlike Go) and the proposed change doesn't seem all that urgent to me.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 819703826, "datetime": 1618422363000, "masked_author": "username_7", "text": "It will probably annoy the same number as it would today.", "title": null, "type": "comment" }, { "action": "created", "author": "beoran", "comment_id": 820166005, "datetime": 1618469592000, "masked_author": "username_11", "text": "The simplest backwards compatible option is to add a url.AllowQuerySemicolon(bool) function, as username_7 suggested. Not to +1, but what is there /against/ that suggestion? Whether it should default to true or false is debatable, but either way, letting the Go users have a knob to keep backwards compatibility seems desirable.", "title": null, "type": "comment" }, { "action": "created", "author": "Mouvedia", "comment_id": 820345973, "datetime": 1618485589000, "masked_author": "username_12", "text": "1. option default to true\r\n2. option default to false\r\n3. deprecation notice\r\n4. removal", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 824216147, "datetime": 1619024471000, "masked_author": "username_7", "text": "Filippo and I spent an hour discussing this. The problem today is a “superset” attack, where Go sees a superset of the values that the proxy does for:\r\n\r\n\turl?x=y;id=evil&id=good\r\n\r\nIn this case, the proxy thinks the id is good but Go thinks the id is evil, resulting in the evil entry being cached as good.\r\n\r\nGo's current parser also leads to a “subset” situation, where Go sees a subset of the values that the proxy does. In particular, Go rejects (drops) keys and values % followed by non-two-hex-digits, but the most common code paths don't check the error, so in\r\n\r\n\turl?id=evil%&id=good\r\n\r\nGo sees good while other implementations may see both evil% and good. We are unaware of any attack on this “subset” situation.\r\n\r\nBecause of that, we propose to do the following.\r\n\r\n1. Make url.ParseQuery split on & but then reject key=value pairs containing semicolons.\r\n2. Make package http log about ParseQuery errors mentioning the semicolon problem.\r\n\r\nThe effect will be to make the semicolon-preceded or -terminated pairs disappear, turning the superset attack into a subset situation. Because we are unaware of any subset-based attack, this is an improvement.\r\n\r\nThe log message should make clear what is going on for users who are confused about no longer seeing certain key-value pairs in their apps.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 828655795, "datetime": 1619632260000, "masked_author": "username_7", "text": "Since there seem to be no objections to the proposal in the previous comment, I am going to mark this likely accept. The final acceptance won't happen until after the freeze, but we still would like to get this in for Go 1.17 for security reasons.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 828668252, "datetime": 1619633333000, "masked_author": "username_7", "text": "Based on the discussion above, this proposal seems like a **[likely accept](https://golang.org/s/proposal-status#likely-accept)**.\n— username_7 for the proposal review group", "title": null, "type": "comment" }, { "action": "created", "author": "antichris", "comment_id": 829409214, "datetime": 1619714251000, "masked_author": "username_13", "text": "`;` is the more reasonable choice and (unrealistic as it sounds, especially when everyone's been using `&amp;`s out of pure force of habit for decades now and some are even actually moving to drop `;` support entirely) should actually be the preferred separator. So, if the idea is to drop the support for splitting on semicolons *unconditionally*, I'm against it.\r\n\r\nIt's not like Go can flip the webdev world now, dominated by javascript kiddies and wordpress \"engineers\", but we can at least keep the saner choice an opt-in for those who can appreciate (and properly set their infrastructure up around) it. In other words, what https://github.com/golang/go/issues/25192#issuecomment-820166005 said, just really do default to `false`.", "title": null, "type": "comment" }, { "action": "created", "author": "FiloSottile", "comment_id": 829425741, "datetime": 1619715014000, "masked_author": "username_6", "text": "@username_13, this remark is not consistent with the [Gopher values](https://golang.org/conduct). The Javascript world built many things, and enabled even more people to build things. We want Go to be a tool that works with that ecosystem, and to be welcoming of people that come from that community.\r\n\r\nThe only technical argument in favor of using semicolons is that it's easier to insert them in manually composed HTML. If you have more please do contribute them. Ecosystem consistency is also a technical argument, and that's what we are weighting it against here.\r\n\r\nKnobs are extra complexity, but if you have a proposal for where to insert that knob we'll listen and weight it against the benefit. `url.AllowQuerySemicolon(bool)` is not an option, because package-global state would lead to conflicts between libraries that expect and set the value to be different.", "title": null, "type": "comment" }, { "action": "created", "author": "andrius4669", "comment_id": 830121041, "datetime": 1619791687000, "masked_author": "username_14", "text": "somehow people are forgetting that it's often not necessary at all to escape `&` in case of url parameter usage, because the usual `&x=y` has very little chance to match `&<something>;` sequence for character references, unless parameter key contains `;` AND character reference is actually meaningful AND it's not escaped for some reason (url.QueryEscape does escape `;`).", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 832863192, "datetime": 1620234617000, "masked_author": "username_7", "text": "@username_9's handler converter is nice for opt-in use. I filed #45973 for that.", "title": null, "type": "comment" }, { "action": "created", "author": "rsc", "comment_id": 832911228, "datetime": 1620239157000, "masked_author": "username_7", "text": "No change in consensus, so **[accepted](https://golang.org/s/proposal-status#accepted)**. 🎉\nThis issue now tracks the work of implementing the proposal.\n— username_7 for the proposal review group", "title": null, "type": "comment" }, { "action": "created", "author": "FiloSottile", "comment_id": 856071516, "datetime": 1623082256000, "masked_author": "username_6", "text": "I'd like to request a freeze exception for this fix. We deemed it not a backportable security fix (also because of the potential for disruption and the limited real-world impact), but it's conceivable that it could have security value for some applications, so we'd like not to wait for Go 1.18.\r\n\r\nRuss, should we also land AllowQuerySemicolons (#45973) during the freeze? I'm leaning towards yes.\r\n\r\n/cc @golang/release @username_7", "title": null, "type": "comment" }, { "action": "created", "author": "dmitshur", "comment_id": 856217202, "datetime": 1623096183000, "masked_author": "username_15", "text": "Thank you for making this freeze exception request. It is approved.", "title": null, "type": "comment" }, { "action": "created", "author": "yktoo", "comment_id": 992276264, "datetime": 1639388193000, "masked_author": "username_16", "text": "With the change https://golang.org/cl/325697 in place our servers now produce lots of log lines like\r\n\r\n```log\r\n2021/12/13 08:44:51 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 08:44:51 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 08:57:37 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 09:11:37 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 09:19:30 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n```\r\n\r\nThis is really not helpful, and since it's a web server, anyone can flood you with requests with a `;`. Can this be switched off somehow?", "title": null, "type": "comment" }, { "action": "created", "author": "antichris", "comment_id": 992302703, "datetime": 1639390060000, "masked_author": "username_13", "text": "@username_16 Have you looked into using [`AllowQuerySemicolons`] or writing your own middleware to replace all semicolons with URL escapes? Alternatively, you could join the convo at #50034 or give it a thumbs-up if it is relevant to your case.\r\n\r\n[`AllowQuerySemicolons`]: https://pkg.go.dev/net/http#AllowQuerySemicolons\r\n\"AllowQuerySemicolons - http package - net/http - pkg.go.dev\"", "title": null, "type": "comment" }, { "action": "created", "author": "seankhliao", "comment_id": 992309838, "datetime": 1639390536000, "masked_author": "username_17", "text": "`http.Server` takes a `*log.Logger`, you can filter it out there if you want.", "title": null, "type": "comment" }, { "action": "created", "author": "yktoo", "comment_id": 992312585, "datetime": 1639390712000, "masked_author": "username_16", "text": "Thanks @username_13, #49399/#50034 describe my concerns exactly. @username_17 yes log filtering seems the only workaround at the moment, albeit very ugly.", "title": null, "type": "comment" }, { "action": "created", "author": "shinny-chengzhi", "comment_id": 1058799374, "datetime": 1646365726000, "masked_author": "username_18", "text": "I have been caught this by surprise and want to restore the old behavior. But it's unclear to me how to do this while supporting both 1.17&pre-1.17 since calling ```AllowQuerySemicolons``` will result in build error in 1.16.", "title": null, "type": "comment" }, { "action": "created", "author": "ianlancetaylor", "comment_id": 1058808146, "datetime": 1646367008000, "masked_author": "username_19", "text": "@username_18 You can use a build tag to compile code differently for go1.16 and go1.17.\r\n\r\nhttps://pkg.go.dev/cmd/go#hdr-Build_constraints", "title": null, "type": "comment" }, { "action": "created", "author": "shinny-chengzhi", "comment_id": 1060124321, "datetime": 1646619819000, "masked_author": "username_18", "text": "@username_19 Thanks, that will do it.", "title": null, "type": "comment" } ]
21
43
27,468
false
true
27,365
true
locationtech/geotrellis
locationtech
309,909,220
2,605
null
[ { "action": "opened", "author": "lossyrob", "comment_id": null, "datetime": 1522358798000, "masked_author": "username_0", "text": "We'll need to pass in a resample option for COGLayerWriter methods, so that the pyramid method knows how to properly resample to overviews.", "title": "Implement resample options for COGLayerWriter", "type": "issue" }, { "action": "closed", "author": "pomadchin", "comment_id": null, "datetime": 1525190741000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
139
false
false
139
false
Soltis13/GroupProject2
null
354,132,514
45
{ "number": 45, "repo": "GroupProject2", "user_login": "Soltis13" }
[ { "action": "opened", "author": "EpicureanHeron", "comment_id": null, "datetime": 1535320656000, "masked_author": "username_0", "text": "Added on check to T's branch.", "title": "T branch4 jft", "type": "issue" }, { "action": "created", "author": "tsimnujhawj", "comment_id": 416075647, "datetime": 1535320814000, "masked_author": "username_1", "text": "We did it!", "title": null, "type": "comment" } ]
2
2
39
false
false
39
false
ljharb/is-equal
null
319,927,425
46
null
[ { "action": "created", "author": "ljharb", "comment_id": 386336688, "datetime": 1525361522000, "masked_author": "username_0", "text": "No.", "title": null, "type": "comment" }, { "action": "closed", "author": "ljharb", "comment_id": null, "datetime": 1525361523000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
3
2,110
false
true
3
false
mapbox/mapbox-gl-native
mapbox
326,188,997
12,002
null
[ { "action": "opened", "author": "olsisaqe", "comment_id": null, "datetime": 1527177779000, "masked_author": "username_0", "text": "<!--\r\nHello and thanks for contributing! To help us diagnose your problem quickly, please:\r\n\r\n - Include a minimal demonstration of the bug, including code, logs, and screenshots.\r\n - Ensure you can reproduce the bug using the latest release.\r\n - Only post to report a bug or request a feature; direct all other questions to: https://stackoverflow.com/questions/tagged/mapbox\r\n-->\r\n\r\n**Platform:** Android\r\n**Mapbox SDK version:**\r\n```\r\n// Mapbox\r\n mapboxMapSdk : '6.1.1',\r\n mapboxTurf : '3.1.0',\r\n mapboxGeoJson : '3.1.0',\r\n mapboxPluginBuilding : '0.3.0',\r\n mapboxPluginLocationLayer: '0.5.2',\r\n mapboxPluginMarkerCluster: '0.3.0',\r\n mapboxPluginPlaces : '0.4.0',\r\n mapboxPluginLocalization : '0.3.0',\r\n mapboxPluginTraffic : '0.6.0',\r\n```\r\n\r\n### Steps to trigger behavior\r\n\r\n 1. Open Demo App\r\n 2. Go to `Show a user's location`\r\n\r\n### Expected behavior\r\nZoom to current user location as it is stated in: `LocationPluginActivity`\r\n\r\n```\r\n @Override\r\n public void onLocationChanged(Location location) {\r\n if (location != null) {\r\n setCameraPosition(location);\r\n locationEngine.removeLocationEngineListener(this);\r\n }\r\n }\r\n```\r\n### Actual behavior\r\nYou will notice the location is not shown correctly since the icon is displayed at 0,0\r\n![image](https://user-images.githubusercontent.com/5824180/40497288-23a3dbd8-5f7c-11e8-91fb-5dc29a1f6e52.png)", "title": "Users Location Not showing with latest demo", "type": "issue" }, { "action": "created", "author": "olsisaqe", "comment_id": 391984592, "datetime": 1527237744000, "masked_author": "username_0", "text": "Also i think the location icon is bigger than `14 dp` specified here: https://github.com/mapbox/mapbox-plugins-android/blob/752c368aec643d408a538283545bf539849fc04f/plugin-locationlayer/src/main/res/drawable/mapbox_user_icon.xml#L3", "title": null, "type": "comment" }, { "action": "closed", "author": "tobrun", "comment_id": null, "datetime": 1527240828000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "tobrun", "comment_id": 391998104, "datetime": 1527240828000, "masked_author": "username_1", "text": "Thank you for the report @username_0, this repo is used to report issues related to the Mapbox Maps SDK for Android and the underlying render engine. For issues that are related to plugins, please report them [here](https://github.com/mapbox/mapbox-plugins-android).", "title": null, "type": "comment" }, { "action": "created", "author": "olsisaqe", "comment_id": 392002403, "datetime": 1527241832000, "masked_author": "username_0", "text": "thanks @username_1 . Following [here](https://github.com/mapbox/mapbox-plugins-android/issues/540)", "title": null, "type": "comment" } ]
2
5
2,106
false
false
2,106
true
grpc/grpc-java
grpc
69,642,643
317
null
[ { "action": "opened", "author": "dconnelly", "comment_id": null, "datetime": 1429552014000, "masked_author": "username_0", "text": "We recently ran into an issue with one of our services where sending large responses results in transport errors being logged as well as eventual transport failure. I managed to reproduce this behavior in integration test largeUnary as well. When running a single iteration of largeUnary the test passes although connection errors are logged:\r\n```\r\nApr 20, 2015 10:43:45 AM io.grpc.transport.netty.NettyServerHandler onConnectionError\r\nWARNING: Connection Error\r\nio.netty.handler.codec.http2.Http2Exception: Stream does not exist 3\r\n\tat io.netty.handler.codec.http2.Http2Exception.connectionError(Http2Exception.java:58)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2Connection.requireStream(DefaultHttp2Connection.java:110)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onWindowUpdateRead(DefaultHttp2ConnectionDecoder.java:486)\r\n\tat io.netty.handler.codec.http2.Http2InboundFrameLogger$1.onWindowUpdateRead(Http2InboundFrameLogger.java:124)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2FrameReader.readWindowUpdateFrame(DefaultHttp2FrameReader.java:560)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2FrameReader.processPayloadState(DefaultHttp2FrameReader.java:247)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2FrameReader.readFrame(DefaultHttp2FrameReader.java:130)\r\n\tat io.netty.handler.codec.http2.Http2InboundFrameLogger.readFrame(Http2InboundFrameLogger.java:39)\r\n\tat io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder.decodeFrame(DefaultHttp2ConnectionDecoder.java:99)\r\n\tat io.netty.handler.codec.http2.Http2ConnectionHandler$FrameDecoder.decode(Http2ConnectionHandler.java:291)\r\n\tat io.netty.handler.codec.http2.Http2ConnectionHandler.decode(Http2ConnectionHandler.java:332)\r\n\tat io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:327)\r\n\tat io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:230)\r\n\tat io.netty.channel.ChannelHandlerInvokerUtil.invokeChannelReadNow(ChannelHandlerInvokerUtil.java:83)\r\n\tat io.netty.channel.DefaultChannelHandlerInvoker.invokeChannelRead(DefaultChannelHandlerInvoker.java:153)\r\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:157)\r\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:946)\r\n\tat io.netty.channel.local.LocalChannel.finishPeerRead(LocalChannel.java:329)\r\n\tat io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:45)\r\n\tat io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:315)\r\n\tat io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:322)\r\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:356)\r\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:703)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\r\n\tat java.lang.Thread.run(Thread.java:745)\r\n```\r\n\r\nHowever, running largeUnary in a simple loop causes transport failure after a few iterations. This happens with both netty and okhttp client variants, as well as with netty local channel. \r\n\r\nOther details:\r\n```\r\n$ uname -a\r\nDarwin eno.local 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64\r\n$ java -version\r\njava version \"1.8.0_40\"\r\nJava(TM) SE Runtime Environment (build 1.8.0_40-b25)\r\nJava HotSpot(TM) 64-Bit Server VM (build 25.40-b25, mixed mode)\r\n```\r\n- David", "title": "Integration test largeUnary failing", "type": "issue" }, { "action": "created", "author": "ejona86", "comment_id": 94537712, "datetime": 1429555693000, "masked_author": "username_1", "text": "This looks similar to https://github.com/netty/netty/issues/3643, https://github.com/netty/netty/issues/2861. HTTP/2 in Netty recently removed tracking of recently-closed streams because it was consuming a lot of memory. This and many similar bugs show issues with the current handling of missing streams or the need to re-introduce that history (but an alternative approach that uses less memory).\r\n\r\nFor the time being, using gRPC (and the associated Netty) from before f920bad is probably the best approach. We hope to have the issue resolved soon™.", "title": null, "type": "comment" }, { "action": "created", "author": "nmittler", "comment_id": 97168525, "datetime": 1430247059000, "masked_author": "username_2", "text": "I believe this should be fixed as of 3ecbd04", "title": null, "type": "comment" }, { "action": "closed", "author": "nmittler", "comment_id": null, "datetime": 1430247059000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
4
4,162
false
false
4,162
false
halide/Halide
halide
369,326,764
3,350
null
[ { "action": "opened", "author": "shoaibkamil", "comment_id": null, "datetime": 1539296198000, "masked_author": "username_0", "text": "I'm seeing warnings like:\r\n```\r\nParallel for loop over some_func.some_var has extent one. Can't do one piece of work in parallel.\r\n```\r\neven when the loop has extent greater than 1.", "title": "Spurious warnings about parallelizing a loop with extent 1", "type": "issue" }, { "action": "closed", "author": "shoaibkamil", "comment_id": null, "datetime": 1539704280000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "shoaibkamil", "comment_id": 430286546, "datetime": 1539704280000, "masked_author": "username_0", "text": "These are being caused by parallelization/rfactor and generally are due to producers with updates being computed inside consumers.", "title": null, "type": "comment" } ]
1
3
311
false
false
311
false
vaadin/flow
vaadin
319,863,265
4,062
null
[ { "action": "opened", "author": "Artur-", "comment_id": null, "datetime": 1525342865000, "masked_author": "username_0", "text": "Using something like\r\n```\r\n\t@ClientCallable\r\n\tpublic void markCompleted(Todo clientTodo, boolean completed) {\r\n```\r\n\r\nfrom JS, you have e.g.\r\n```\r\nthis.$server.markCompleted(item, completed)\r\n```\r\nwhere in the JS world, it typically does not matter if `completed` is `false` or `undefined`. With Flow however, you will get\r\n\"INTERNAL ERROR\"\r\nif it's undefined because of\r\n```\r\n[qtp813364097-161] ERROR com.vaadin.flow.server.DefaultErrorHandler - \r\njava.lang.IllegalArgumentException: Null values are not allowed for primitive types but a 'null' value was received for parameter 1 which refers to primitive type 'boolean' in the method 'markCompleted' defined in the class '...'\r\n```", "title": "Convert null to false for @ClientCallable booleans", "type": "issue" }, { "action": "created", "author": "Legioth", "comment_id": 386253359, "datetime": 1525343636000, "masked_author": "username_1", "text": "A good question is whether we should have special logic for `null` (and `undefined`), or whether we should follow the full set of JS type coercion rules (i.e. converting basically everything except `\"\"`, `0`, and `NaN` into `true`).\r\n\r\nAnother question is whether similar conversions should also be applied for e.g. `int` or `double` parameters.", "title": null, "type": "comment" }, { "action": "closed", "author": "mshabarov", "comment_id": null, "datetime": 1633093367000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
4
4
1,146
false
true
1,028
false
workcraft/workcraft
workcraft
235,886,843
702
{ "number": 702, "repo": "workcraft", "user_login": "workcraft" }
[ { "action": "opened", "author": "allegroCoder", "comment_id": null, "datetime": 1497448350000, "masked_author": "username_0", "text": "", "title": "Fst package name changed from task to tasks", "type": "issue" } ]
2
2
269
false
true
0
false
pujiaxin33/JXPagingView
null
368,525,873
10
null
[ { "action": "opened", "author": "JW-chenjingwei", "comment_id": null, "datetime": 1539156085000, "masked_author": "username_0", "text": "_listViewArray 可以用vc1.view, vc2.view ...想各个分页内容由各自的控制器管理,需要怎么设置?", "title": "listView可以用VC做容器吗?", "type": "issue" }, { "action": "created", "author": "pujiaxin33", "comment_id": 428472648, "datetime": 1539157733000, "masked_author": "username_1", "text": "只能直接放view,你可以把VC.view的class给改成遵从了JXPagingViewListViewDelegate代理的自定义view,在loadView里面修改", "title": null, "type": "comment" }, { "action": "closed", "author": "pujiaxin33", "comment_id": null, "datetime": 1539157734000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "pujiaxin33", "comment_id": 449311164, "datetime": 1545381236000, "masked_author": "username_1", "text": "你好最新1.0.0版本已经支持列表用VC做容器,而且不至于VC,只要遵从`JXPagerViewListViewDelegate`协议的类都可以当做列表容器。", "title": null, "type": "comment" } ]
2
4
228
false
false
228
false
rbonghi/XRobot
null
57,354,718
6
null
[ { "action": "opened", "author": "rbonghi", "comment_id": null, "datetime": 1423678656000, "masked_author": "username_0", "text": "Complete cover jetson and add hole for air refresh\r\n\r\n-[ ] complete cover\r\n-[ ] Holve for fan", "title": "Complete cover Jetson", "type": "issue" }, { "action": "created", "author": "rbonghi", "comment_id": 74218677, "datetime": 1423815021000, "masked_author": "username_0", "text": "Added diagonal cover d174c39883a7d8f078c8adf9bd44e523e3d87798", "title": null, "type": "comment" }, { "action": "created", "author": "rbonghi", "comment_id": 74264073, "datetime": 1423838879000, "masked_author": "username_0", "text": "Test Cover with hole for fan\r\n![Cover and Fan](https://github.com/username_0/XRobot/blob/master/images/Xbot-Fan.PNG)", "title": null, "type": "comment" }, { "action": "created", "author": "rbonghi", "comment_id": 78018240, "datetime": 1425978811000, "masked_author": "username_0", "text": "Solved without fan hole", "title": null, "type": "comment" }, { "action": "closed", "author": "rbonghi", "comment_id": null, "datetime": 1425978811000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
5
290
false
false
290
true
ShamylZakariya/StickyHeaders
null
166,257,846
17
null
[ { "action": "opened", "author": "xiang9311", "comment_id": null, "datetime": 1468909920000, "masked_author": "username_0", "text": "when i use this layout\r\n`<android.support.v4.widget.SwipeRefreshLayout\r\n android:id=\"@+id/swipe_refresh_layout\"\r\n android:layout_width=\"match_parent\"\r\n android:layout_height=\"match_parent\"\r\n android:layout_below=\"@+id/top_line\"\r\n android:background=\"@color/gray_background\">\r\n\r\n <android.support.v7.widget.RecyclerView\r\n android:id=\"@+id/rv_study_list\"\r\n android:layout_width=\"match_parent\"\r\n android:layout_height=\"match_parent\">\r\n\r\n </android.support.v7.widget.RecyclerView>\r\n\r\n </android.support.v4.widget.SwipeRefreshLayout>`\r\ni can not swipe to refresh.", "title": "When use with SwipeRefreshLayout, cannot swipe to refresh", "type": "issue" }, { "action": "closed", "author": "xiang9311", "comment_id": null, "datetime": 1469065268000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "xiang9311", "comment_id": 234134015, "datetime": 1469065268000, "masked_author": "username_0", "text": "it is my fault....\r\ni forget to setrefresh(false)", "title": null, "type": "comment" } ]
1
3
692
false
false
692
false
alibaba/pouch
alibaba
310,334,908
1,024
{ "number": 1024, "repo": "pouch", "user_login": "alibaba" }
[ { "action": "opened", "author": "Dewey-Ding", "comment_id": null, "datetime": 1522599110000, "masked_author": "username_0", "text": "### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews", "title": "test:add container update test", "type": "issue" }, { "action": "created", "author": "allencloud", "comment_id": 377842389, "datetime": 1522637618000, "masked_author": "username_1", "text": "LGTM", "title": null, "type": "comment" } ]
3
3
110
false
true
110
false
etix/mirrorbits
null
394,756,983
88
null
[ { "action": "opened", "author": "manno", "comment_id": null, "datetime": 1546054446000, "masked_author": "username_0", "text": "I'm trying to build mirrorbits, but run into an error. Doesn't matter if I do it on Ubuntu or in Docker:\r\n\r\n```\r\nStep 6/9 : RUN mkdir /srv/repo /var/log/mirrorbits && cd /go/src/github.com/etix/mirrorbits && make install PREFIX=/usr\r\n ---> Running in 2d3cca9f4a75\r\ngo get github.com/kardianos/govendor\r\nPackage systemd was not found in the pkg-config search path.\r\nPerhaps you should add the directory containing `systemd.pc'\r\nto the PKG_CONFIG_PATH environment variable\r\nNo package 'systemd' found\r\ngovendor sync github.com/etix/mirrorbits\r\ngo get -u github.com/golang/protobuf/protoc-gen-go\r\nprotoc -I rpc rpc/rpc.proto --go_out=plugins=grpc:rpc\r\ngo build -ldflags \"-X github.com/etix/mirrorbits/core.VERSION=v0.5.1-2-gd6949fe -X github.com/etix/mirrorbits/core.BUILD=d6949fe-mm-upgrade-2018 -X github.com/etix/mirrorbits/config.TEMPLATES_PATH=/usr/share/mirrorbits\" -o bin/mirrorbits .\r\n# github.com/etix/mirrorbits/rpc\r\nrpc/rpc.pb.go:25:11: undefined: \"github.com/etix/mirrorbits/vendor/github.com/golang/protobuf/proto\".ProtoPackageIsVersion3\r\nmake: *** [build] Error 2\r\nMakefile:37: recipe for target 'build' failed\r\nThe command '/bin/sh -c mkdir /srv/repo /var/log/mirrorbits && cd /go/src/github.com/etix/mirrorbits && make install PREFIX=/usr' returned a non-zero code: 2\r\n```", "title": "Unable to compile", "type": "issue" }, { "action": "created", "author": "derchrisuk", "comment_id": 452003465, "datetime": 1546880271000, "masked_author": "username_1", "text": "Try this.\r\nEdit the Makefile, and modify the protoc section as follows:\r\n\r\n```\r\nprotoc:\r\n go get -u github.com/golang/protobuf/protoc-gen-go\r\n git -C ${GOPATH}/src/github.com/golang/protobuf checkout v1.2.0\r\n go install github.com/golang/protobuf/protoc-gen-go\r\n protoc -I rpc rpc/rpc.proto --go_out=plugins=grpc:rpc\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "theel0ja", "comment_id": 452877081, "datetime": 1547069794000, "masked_author": "username_2", "text": "I had to change the spaces in it to tabs.", "title": null, "type": "comment" }, { "action": "created", "author": "manno", "comment_id": 452919886, "datetime": 1547078781000, "masked_author": "username_0", "text": "Also the make target didn't work for me the second time, because `go get -u` didn't like the checkout.", "title": null, "type": "comment" }, { "action": "created", "author": "the-maldridge", "comment_id": 455035957, "datetime": 1547698283000, "masked_author": "username_3", "text": "The provided solution doesn't seem to have fixed my build. I still get a number of errors like this:\r\n\r\n```\r\nrpc.proto:65:5: \"google.protobuf.Timestamp\" is not defined.\r\n\r\n```", "title": null, "type": "comment" } ]
4
5
1,957
false
false
1,957
false
MicrosoftDocs/botbuilder-docs-sdk-typescript
MicrosoftDocs
361,903,066
4
{ "number": 4, "repo": "botbuilder-docs-sdk-typescript", "user_login": "MicrosoftDocs" }
[ { "action": "opened", "author": "dend", "comment_id": null, "datetime": 1537386885000, "masked_author": "username_0", "text": "", "title": "Update config", "type": "issue" }, { "action": "created", "author": "opbld30", "comment_id": 422937221, "datetime": 1537386977000, "masked_author": "username_1", "text": "### :white_check_mark: Validation status: passed\r\n\r\n\r\nFile | Status | Preview URL | Details\r\n---- | ------ | ----------- | -------\r\n[botbuilder-typescript/docfx.json](https://github.com/MicrosoftDocs/botbuilder-docs-sdk-typescript/blob/master/botbuilder-typescript/docfx.json) | :white_check_mark:Succeeded | |\r\n\r\nFor more details, please refer to the [build report](https://opbuildstorageprod.blob.core.windows.net/report/2018%5C9%5C19%5Cf151deb0-77e7-035e-3c07-d23dfd8c42bc%5CPullRequest%5C201809191954476602-4%5Cworkflow_report.html?sv=2015-02-21&sr=b&sig=OrIp1k4ibqE1kteLYkUNV5NH4fz5DbsxjNupOplxObI%3D&st=2018-09-19T19%3A51%3A16Z&se=2018-10-20T19%3A56%3A16Z&sp=r).\r\n\r\n**Note:** If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.", "title": null, "type": "comment" } ]
2
2
838
false
false
838
false
facebookresearch/faiss
facebookresearch
339,373,526
515
null
[ { "action": "opened", "author": "universewill", "comment_id": null, "datetime": 1531128711000, "masked_author": "username_0", "text": "My code is something like this. The search function can do well in test() function, but it encounters core dumped error outside the test() fucntion.\r\n\r\nMy system is ubuntu 16.04, python3.6, with faiss-cpu installed using conda.\r\nIt seems to be weird.\r\n\r\n```\r\ndef test():\r\n nlist=100\r\n nprobe =8\r\n codebook = np.random.random((1000, 128)).astype('float32')\r\n quantizer = faiss.IndexFlatL2(128)\r\n index_128 = faiss.IndexIVFFlat(quantizer, 128, 100, faiss.METRIC_L2)\r\n index_128.train(codebook)\r\n index_128.add(codebook)\r\n index_128.nprobe = nprobe\r\n print(index_128.search(codebook[101:102],k=20))\r\n return index_128\r\n\r\nif __name__ == '__main__':\r\n\r\n index_128 =test()\r\n print('test la ...')\r\n codebook = np.random.random((1000, 128)).astype('float32')\r\n print(index_128.search(codebook[101:102],k=20))\r\n```", "title": "weird behavior of faiss python api", "type": "issue" }, { "action": "created", "author": "Enet4", "comment_id": 403434612, "datetime": 1531132292000, "masked_author": "username_1", "text": "This seems like the same issue described in the FAQ: [Crashes in pure Python code](https://github.com/facebookresearch/faiss/wiki/Troubleshooting#crashes-in-pure-python-code). Since the IVF flat index also comprises a quantizer, you need to either keep a reference to `quantizer` or instruct the index to own it.", "title": null, "type": "comment" } ]
2
2
1,163
false
false
1,163
false
mercadopago/sdk-php
mercadopago
370,652,684
136
null
[ { "action": "opened", "author": "lucianoghione", "comment_id": null, "datetime": 1539701513000, "masked_author": "username_0", "text": "Hola, \r\n\r\nEstoy integrado pero cuando una persona se (adhiere/da de baja) el débito automático (pagos recurrentes/suscripciones) ya no se envían las notificaciones a mi IPN. \r\nSolamente cuando un usuario paga la suscripción si se envía la notificación. Pero no cuando se adhiere/da de baja. \r\n\r\nEsto sucede en entorno de producción y también probe con usuarios de prueba en el entorno de pruebas y pasa lo mismo.\r\n\r\nNo son problemas en mi código ni nada por el estilo porque hasta hace unas semanas funcionaba perfectamente.\r\n\r\nEspero una pronta respuesta,\r\nSaludos.", "title": "No se envian más notificaciones de suscripción al IPN ", "type": "issue" }, { "action": "created", "author": "sgarofalo808", "comment_id": 431844757, "datetime": 1540216979000, "masked_author": "username_1", "text": "Buenas, estoy exactamente con el mismo inconveniente.\r\nLuciano tuviste alguna novedad al respecto?", "title": null, "type": "comment" }, { "action": "created", "author": "lucianoghione", "comment_id": 431849834, "datetime": 1540218100000, "masked_author": "username_0", "text": "Hola,\r\nHasta ahora he intentado comunicarme via el formulario de soporte, pero aún no he tenido respuesta, si en algún momento tengo alguna novedad, te aviso.\r\n\r\nSaludos", "title": null, "type": "comment" }, { "action": "created", "author": "knifesk", "comment_id": 432277237, "datetime": 1540305944000, "masked_author": "username_2", "text": "+1", "title": null, "type": "comment" }, { "action": "created", "author": "joelibaceta", "comment_id": 432429536, "datetime": 1540330602000, "masked_author": "username_3", "text": "@username_2 @asobralr @username_0 efectivamente es un problema detectado y se esta trabajando en resolverlo.", "title": null, "type": "comment" }, { "action": "created", "author": "sgarofalo808", "comment_id": 436592013, "datetime": 1541589674000, "masked_author": "username_1", "text": "Hola gente, alguna novedad con esto? Hace un mes que esta este problema y me sigue ocurriendo!", "title": null, "type": "comment" }, { "action": "created", "author": "lucianoghione", "comment_id": 436600539, "datetime": 1541591927000, "masked_author": "username_0", "text": "Hola @username_1, aún no hay novedades del asunto, realmente espero que se solucione pronto porque es algo bastante grave, te recomiendo como solución provisoria (es lo que yo hice) generarte de alguna manera algún curl request o similar al IPN cada vez que se haga alguna solicitud de suscripción, por ejemplo en tu url de retorno que pusiste en la preferencia. Se que no es una manera elegante de manejarlo y tampoco contempla el caso de que un usuario se de de baja a la suscripción desde su cuenta de Mercado Pago pero es lo que se me ocurrió hacer hasta que solucionen el problema.\r\n\r\n@username_3 Alguna novedad?\r\n\r\nSaludos!", "title": null, "type": "comment" }, { "action": "created", "author": "knifesk", "comment_id": 436618682, "datetime": 1541596510000, "masked_author": "username_2", "text": "Yo hice en Postman un request para solventar el problema momentáneamente... \r\nLo envio con POST a mi URL de IPN\r\n```json\r\n{\r\n\t\"resource\" : \"https://api.mercadolibre.com/preapproval/<id_suscripcion>\",\r\n\t\"topic\" : \"preapproval\"\r\n}\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "knifesk", "comment_id": 436714779, "datetime": 1541612960000, "masked_author": "username_2", "text": "El problema es que ahora las suscripciones ni siquiera cambian a estado por cobrar.. tengo una nueva suscripcion en estado \"pendiente\" que no me figua en el listado de suscripciones y no puedo ver a no ser que ingrese a la URL `https://www.mercadopago.com.ar/subscriptions/detail?id=<id_suscripcion>&plan_id=`", "title": null, "type": "comment" }, { "action": "created", "author": "lucianoghione", "comment_id": 436729041, "datetime": 1541615417000, "masked_author": "username_0", "text": "@username_2 No se si te sirve de consuelo, pero recién al ver tu mensaje hice una prueba en producción de intentar adherirme al débito con una tarjeta VISA y se puso en estado \"Por cobrar\". Ante cualquier cambio/nuevo error/novedad, por favor avisen asi nos vamos ayudando entre nosotros.", "title": null, "type": "comment" }, { "action": "created", "author": "eric-garcia-movile", "comment_id": 437204326, "datetime": 1541722640000, "masked_author": "username_4", "text": "Hola! Me pasa exactamente lo mismo, pero no solo con suscripciones.\r\nTambién en el basic checkout.\r\nA ustedes solo les pasa con las notificaciones de suscripciones?", "title": null, "type": "comment" }, { "action": "created", "author": "joelibaceta", "comment_id": 437382835, "datetime": 1541775194000, "masked_author": "username_3", "text": "Este es un canal destinado a reportar incidencias sobre el SDK Legacy de PHP, para consultas técnicas deben dirigirse al canal oficial de soporte http://www.mercadopago.com.ar/developers/es/support procedo a cerrar el issue ya que lo reportado corresponde a un bug en otro componente.", "title": null, "type": "comment" }, { "action": "closed", "author": "joelibaceta", "comment_id": null, "datetime": 1541775197000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "sgarofalo808", "comment_id": 437391723, "datetime": 1541776861000, "masked_author": "username_1", "text": "@username_3 Disculpa, el otro dia lo marcaste como bug, y ahora es una consulta tecnica?\r\nHay multiples usuarios reportando lo mismo, es obvio que rompieron algo que venia andando bien del lado de MercadoPago", "title": null, "type": "comment" }, { "action": "created", "author": "joelibaceta", "comment_id": 437397687, "datetime": 1541777938000, "masked_author": "username_3", "text": "@username_1 efectivamente, un issue se marca como bug cuando el equipo puede reproducir el error, posteriormente se identifica si corresponde a un problema del SDK ( Se envían parámetros incorrectos o hay un bug de código ), en este caso el proceso de diagnostico tuvo como resultado que este issue no esta relacionado a un problema del SDK alojado en este repositorio sino en el motor de notificaciones. \r\n\r\nPor eso sugerimos comunicarse con el canal apropiado en el cual se están gestionando los casos relacionados a este problema, este canal esta destinado únicamente a la discusión sobre el SDK de PHP legacy", "title": null, "type": "comment" }, { "action": "created", "author": "sgarofalo808", "comment_id": 437401396, "datetime": 1541778615000, "masked_author": "username_1", "text": "Alguien sabe si updatear a dx-php (https://github.com/mercadopago/dx-php) arregla el problema?\r\nT\r\nengo 0 fe en contactar a soporte, tardan una semana en contestar y hace dias me dijeron que este problema estaba resuelto, que claramente no lo esta.", "title": null, "type": "comment" }, { "action": "created", "author": "joelibaceta", "comment_id": 437402127, "datetime": 1541778752000, "masked_author": "username_3", "text": "@username_1 Como comente en la parte superior, para este caso especifico el bug de notificaciones no esta relacionado a un incidente en el SDK sino a un bug del motor de notificaciones interno, para preguntas de problemas de este tipo y/o problemas genéricas que escapan al scope de los sdks esta el canal de soporte.", "title": null, "type": "comment" } ]
5
17
4,336
false
false
4,336
true
canjs/canjs
canjs
157,152,360
2,405
null
[ { "action": "opened", "author": "taai", "comment_id": null, "datetime": 1464336516000, "masked_author": "username_0", "text": "This is what I want:\r\n\r\n```\r\n{{#each schools 'school'}}\r\n\t{{#each school.students 'student'}}\r\n\t\t<p>{{student.name}} is in school {{school.name}}</p>\r\n\t{{/each}}\r\n{{/each}}\r\n```\r\n\r\nThe second (optional) argument for the ```#each``` helper should be the name of variable which would hold the item of the list. I think I have seen this in some other frameworks, so this is nothing new.\r\n\r\nBecause this is how I can control the access to each object specifically, otherways I couldn't access, in this case, the \"school name\" from inside of \"students\" loop, because they have the same attribute name – \"name\".\r\n\r\nAs I did read the stache helpers code, it should be easy to implement just like the ```@index``` and ```@key``` variables.\r\nhttps://github.com/canjs/canjs/blob/master/view/stache/mustache_helpers.js#L30\r\n\r\nFor now I'm making a helper for my own needs, but I would like to see the same in canJS out of the box. I can also program this myself and make a pull request, only if you are willing to accept it.\r\n\r\nBy the way, is there a better way to communicate with you than in Freenode IRC channel? When I go there, there are just few people who probably are away from keyboard anyway...", "title": "foreach (itemList as item) in stache", "type": "issue" }, { "action": "closed", "author": "justinbmeyer", "comment_id": null, "datetime": 1464355094000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "justinbmeyer", "comment_id": 222143763, "datetime": 1464355094000, "masked_author": "username_1", "text": "Yes. no one uses freenode anymore. We are all on: https://gitter.im/canjs/canjs\r\n\r\nClosing for a similar previous issue https://github.com/canjs/can-stache/issues/16", "title": null, "type": "comment" }, { "action": "created", "author": "taai", "comment_id": 222181172, "datetime": 1464363828000, "masked_author": "username_0", "text": "@username_1 Alright... Do you accept that it is needed? Do you want me to implement this and make a pull request? Which branch should I use as a base for changes – \"master\"?", "title": null, "type": "comment" }, { "action": "created", "author": "justinbmeyer", "comment_id": 222186964, "datetime": 1464365182000, "masked_author": "username_1", "text": "Yes, I think @username_2 might be looking at it too. \r\n\r\nAll features are going to be added in 3.0, so that `can-stache` repo is the place to make changes.", "title": null, "type": "comment" }, { "action": "created", "author": "pYr0x", "comment_id": 222241926, "datetime": 1464379741000, "masked_author": "username_2", "text": "@username_0 if you have a working solution with also a test we will accept yours...", "title": null, "type": "comment" }, { "action": "created", "author": "taai", "comment_id": 222258841, "datetime": 1464385054000, "masked_author": "username_0", "text": "@username_2 Please have a look at my pull request! I hope that's that simple and I'm not misunderstanding anything...", "title": null, "type": "comment" }, { "action": "created", "author": "taai", "comment_id": 222261327, "datetime": 1464385922000, "masked_author": "username_0", "text": "@username_2 By the way, in the pull request it did the Travis CI test and it failed... But that's not because of my code. It fails randomly this test:\r\nhttps://github.com/canjs/can-stache/blob/master/test/stache-test.js#L2901\r\nIf you run tests again, it should pass the tests... I suspect it has something to do with ```setTimeout```. Maybe the second ```setTimeout``` should be called from inside of the first ```setTimeout```, because browsers doesn't guarantee the execution order of callbacks set with ```setTimeout```? Proof:\r\n\r\n- https://nodejs.org/api/timers.html#timers_settimeout_callback_delay_arg\r\n- http://stackoverflow.com/questions/1776239/are-equal-timeouts-executed-in-order-in-javascript/1776684#1776684", "title": null, "type": "comment" }, { "action": "created", "author": "pYr0x", "comment_id": 222273557, "datetime": 1464391414000, "masked_author": "username_2", "text": "@username_0 can you try to wrap the second timeout in the first one?", "title": null, "type": "comment" } ]
3
9
2,651
false
false
2,651
true
angular/angular-phonecat
angular
207,534,796
399
null
[ { "action": "opened", "author": "ekim1394", "comment_id": null, "datetime": 1487083462000, "masked_author": "username_0", "text": "Trying to run the tutorial on AngularJS.\r\n\r\nI have the latest version of node.js and npm installed.", "title": "Failed at the angular-phonecat@0.0.0 start script 'http-server ./app -a localhost -p 8000 -c-1", "type": "issue" }, { "action": "created", "author": "gkalpak", "comment_id": 279931020, "datetime": 1487141336000, "masked_author": "username_1", "text": "We can't help much without more info. For example, what is the exact error message?", "title": null, "type": "comment" }, { "action": "created", "author": "adrBoy", "comment_id": 280237221, "datetime": 1487223895000, "masked_author": "username_2", "text": "The web server is configured to use port 8000. If the port is already in use (for example by another instance of a running web server) you will get an EADDRINUSE error. Make sure the port is available, before running npm start.", "title": null, "type": "comment" }, { "action": "created", "author": "lazyManLearn", "comment_id": 285844922, "datetime": 1489210684000, "masked_author": "username_3", "text": "change port", "title": null, "type": "comment" }, { "action": "closed", "author": "gkalpak", "comment_id": null, "datetime": 1489310961000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
4
5
420
false
false
420
false
census-instrumentation/opencensus-java
census-instrumentation
249,520,047
498
{ "number": 498, "repo": "opencensus-java", "user_login": "census-instrumentation" }
[ { "action": "opened", "author": "sebright", "comment_id": null, "datetime": 1502415676000, "masked_author": "username_0", "text": "This PR adds methods for getting the current TagContext and setting the TagContext in a scope. It also adds convenience methods for creating a builder from the current tags and setting the scoped tags with a builder.\r\n\r\nThe new methods correspond to methods for working with the current span. (There are some differences, because the TagContext doesn't need to be started, and it doesn't have a parent-child relationship.)\r\n\r\nTagging | Tracing\r\n-------------------------------------------------------------------|------------------------------------------------------\r\n`TagContexts.getCurrentTagContext()` | `Tracer.getCurrentSpan()`\r\n`TagContexts.withTagContext(TagContext tags)` | `Tracer.withSpan(Span span)`\r\n`TagContexts.currentBuilder()` | `Tracer.spanBuilder(String spanName)`\r\n`TagContextBuilder.buildScoped()` | `SpanBuilder.startScopedSpan()`\r\n\r\nExisting methods that don't use the current context:\r\n\r\nTagging | Tracing\r\n--------------------------------------------------------|------------------------------------------------------\r\n`TagContexts.emptyBuilder()` and `TagContexts.toBuilder(TagContext tags)` | `Tracer.spanBuilderWithExplicitParent(String spanName, @Nullable Span parent)`\r\n`TagContextBuilder.build()` | `SpanBuilder.startSpan()`\r\n\r\n/cc @username_1", "title": "Add methods for interacting with the current TagContext.", "type": "issue" }, { "action": "created", "author": "adriancole", "comment_id": 321958184, "datetime": 1502514533000, "masked_author": "username_1", "text": "Dunno about the currentBuilder and buildScoped.. tag context doesnt have a\nlifecycle like a span. Do we really need these methods? How worse would it\nbe if there was only a scoping method?", "title": null, "type": "comment" }, { "action": "created", "author": "sebright", "comment_id": 321996174, "datetime": 1502560515000, "masked_author": "username_0", "text": "@username_1 `currentBuilder` and `buildScoped` are just convenience methods. My goal was to make it no harder to update the current TagContext than to create a new TagContext, since using the current context is the expected use case. I wanted to shorten the code required to update tags and also make it harder to accidentally clear the existing tags.\r\n\r\nWith the convenience methods, a user can update the tags with\r\n\r\n```java\r\ntry (Scope scope = tagContexts.currentBuilder().set(KEY, VALUE).buildScoped()) {\r\n ...\r\n}\r\n```\r\n\r\ninstead of\r\n\r\n```java\r\ntry (Scope scope =\r\n tagContexts.withTagContext(\r\n tagContexts.toBuilder(tagContexts.getCurrentTagContext()).set(KEY, VALUE).build())) {\r\n ...\r\n}\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "adriancole", "comment_id": 322018269, "datetime": 1502592377000, "masked_author": "username_1", "text": "Thanks for giving an example of this. I see your point!", "title": null, "type": "comment" }, { "action": "created", "author": "sebright", "comment_id": 325053285, "datetime": 1503702587000, "masked_author": "username_0", "text": "Thanks!", "title": null, "type": "comment" } ]
3
6
2,460
false
true
2,460
true
namespace-ee/react-calendar-timeline
namespace-ee
334,696,780
340
null
[ { "action": "opened", "author": "mcMickJuice", "comment_id": null, "datetime": 1529624549000, "masked_author": "username_0", "text": "**Describe the bug**\r\nAll examples are broken. interact.js is not defined\r\n\r\n**To Reproduce**\r\nGo to any of the codesandboxes in the examples section\r\n\r\nhttps://codesandbox.io/s/lyjr9p0119\r\n\r\n**Expected behavior**\r\nExamples should just work. Need to update examples to use interactjs.", "title": "Example codesandboxes are broken.", "type": "issue" }, { "action": "created", "author": "mcMickJuice", "comment_id": 401428918, "datetime": 1530295108000, "masked_author": "username_0", "text": "Fixed", "title": null, "type": "comment" }, { "action": "closed", "author": "mcMickJuice", "comment_id": null, "datetime": 1530295108000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
3
290
false
false
290
false
zalando-incubator/mate
zalando-incubator
199,195,335
49
{ "number": 49, "repo": "mate", "user_login": "zalando-incubator" }
[ { "action": "opened", "author": "linki", "comment_id": null, "datetime": 1483708905000, "masked_author": "username_0", "text": "I'm going to tag the latest release with `v0.4.0` because of the support of multiple IPs for the Google consumer. I'll tag the merge commit once merged, if no objections.\r\n\r\n/cc @ideahitme", "title": "update documented version to v0.4.0", "type": "issue" }, { "action": "created", "author": "Raffo", "comment_id": 270902911, "datetime": 1483709182000, "masked_author": "username_1", "text": "👍", "title": null, "type": "comment" } ]
2
2
189
false
false
189
false
facebookresearch/ParlAI
facebookresearch
303,426,601
618
null
[ { "action": "opened", "author": "fikrisyad", "comment_id": null, "datetime": 1520504261000, "masked_author": "username_0", "text": "I tried to use the dataset of Personalizing Dialogue Agents paper, but I couldn't figure how to parse the data.\r\nCan someone please help me?", "title": "How to parse personachat dataset", "type": "issue" }, { "action": "created", "author": "jaseweston", "comment_id": 371498658, "datetime": 1520518537000, "masked_author": "username_1", "text": "In ParlAI you can look at this dataset like any other dataset with:\r\n\r\npython examples/display_data.py -t personachat\r\n\r\nThis downloads the data and displays it on screen, so you can follow that code..", "title": null, "type": "comment" }, { "action": "created", "author": "fikrisyad", "comment_id": 371745073, "datetime": 1520583734000, "masked_author": "username_0", "text": "great, thank you!", "title": null, "type": "comment" }, { "action": "closed", "author": "fikrisyad", "comment_id": null, "datetime": 1520583738000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
358
false
false
358
false
Qo2770/Algorithms
null
369,651,659
2
null
[ { "action": "opened", "author": "Qo2770", "comment_id": null, "datetime": 1539367025000, "masked_author": "username_0", "text": "*This issue was created by [Maintainers Wanted](https://maintainerswanted.com)* :nerd_face: \n\n\n*Support us by leaving a star on [Github](https://github.com/flxwu/maintainerswanted.com)!* :star2: \n\n\n## Algorithms is searching for new Maintainers! :man_technologist: :mailbox_with_mail:\n\nDo you use Algorithms personally or at work and would like this project to be further developed and improved?\n\n\nOr are you already a contributor and ready to take the next step to becoming a maintainer?\n\nIf you are interested, comment here below on this issue! :point_down::raised_hands:", "title": "Algorithms is searching for Maintainers!", "type": "issue" }, { "action": "closed", "author": "Qo2770", "comment_id": null, "datetime": 1540837842000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
573
false
false
573
false
ericlagergren/decimal
null
288,105,217
63
null
[ { "action": "opened", "author": "shabbyrobe", "comment_id": null, "datetime": 1515760371000, "masked_author": "username_0", "text": "In my application, I need Go OperatingMode to be the default for all calculations. It's very verbose to establish and easy to forget to properly set contexts. Is it possible to add a more convenient way to set the default to be Go?", "title": "More convenient way to default to Go OperatingMode?", "type": "issue" }, { "action": "created", "author": "ericlagergren", "comment_id": 357305767, "datetime": 1515779174000, "masked_author": "username_1", "text": "I'm not sure. The only \"zero-touch\" way that would make the default be `Go` would be setting a global variable (like `var DefaultOperatingMode = Go`) that people could modify inside `init()`. But that'd require me to add more runtime checks. I'm not a fan of globals nor of more runtime checks than necessary.\r\n\r\nA common format I use when using this library is\r\n\r\n```\r\nvar ctx = decimal.Big{\r\n Precision: 19,\r\n Traps: ^decimal.Condition(0),\r\n ...\r\n}\r\n\r\n// avg sets z to the average of the list, a.\r\nfunc avg(z, a ...*decimal.Big) *decimal.Big {\r\n for _, v := range a {\r\n ctx.Add(z, z, a)\r\n }\r\n var n decimal.Big\r\n return ctx.Quo(z, z, n.SetUint64(uint64(len(a))))\r\n}\r\n```\r\n\r\nOr, alternatively, when I don't want to use the `ctx.Add( ... )` form, I'll do something like\r\n\r\n```\r\nfunc d() *decimal.Big {\r\n return decimal.WithContext(decimal.Context{OperatingMode: Go})\r\n}\r\nfoo := d()\r\n...\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "shabbyrobe", "comment_id": 357404630, "datetime": 1515812019000, "masked_author": "username_0", "text": "Yeah that global was my first thought too, then I started thinking through the horror that could unleash. Being able to modify the behaviour of dependencies that rely in the default being GDA could create some really nasty surprises, which is precisely what I'm trying to avoid! :)\r\n\r\nSo the main reason why I'm favouring the Go operating mode is that it's about 20% faster (and I'm doing about a jillion calculations so that really 20% really helps), and the other reasons are that the docs say that operations are lossless and because I'd prefer my app blow up on NaN.\r\n\r\nSo I guess the problem I have is that if I forget even once to do `decimal.WithContext(decimal.Context{OperatingMode: Go})`, I've created a subtle condition where precision could be lost or NaNs could slip through, compromising my whole data pipeline potentially without me knowing.\r\n\r\nI'm not sure any of this is right, it's just what I gleaned from reading the docs and code and experimenting with the lib.", "title": null, "type": "comment" }, { "action": "created", "author": "ericlagergren", "comment_id": 357406560, "datetime": 1515814436000, "masked_author": "username_1", "text": "This is a reason why I added methods to `Context`—if you always commit to using the `ctx.Mul( ... )` form you'll be fine. Other libraries require you to use that form, but I like choices so I added both. :-)", "title": null, "type": "comment" }, { "action": "created", "author": "ericlagergren", "comment_id": 359213786, "datetime": 1516494945000, "masked_author": "username_1", "text": "hey, just wondering if you're fine with me closing this issue.", "title": null, "type": "comment" }, { "action": "created", "author": "ericlagergren", "comment_id": 359308635, "datetime": 1516588189000, "masked_author": "username_1", "text": "Feel free to ping me if you've any more questions!", "title": null, "type": "comment" }, { "action": "closed", "author": "ericlagergren", "comment_id": null, "datetime": 1516588189000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "shabbyrobe", "comment_id": 359328231, "datetime": 1516598575000, "masked_author": "username_0", "text": "Sorry for not getting back to you sooner, and thank you for the detailed reply. I'll see how I go with the `ctx.Mul()` form. It could well be enough; as long as it's easy to visually identify wrong use and right use, the way is then paved for writing an automated checker. Would you mind if I commented here again if I run into issues?", "title": null, "type": "comment" }, { "action": "created", "author": "ericlagergren", "comment_id": 359329218, "datetime": 1516599100000, "masked_author": "username_1", "text": "You’re more than welcome to! (Though, if it’s a different question create a separate issue.) My email’s public as well, but I’d kinda prefer to keep things on GitHub if possible so others can benefit from the Q&A.\n\nI like to use the issues as a TODO list of sorts, so I like to close stuff out when I’m finished so I don’t accidentally forget about it.\n\n>", "title": null, "type": "comment" } ]
2
9
3,144
false
false
3,144
false
pimutils/khal
pimutils
163,286,958
456
{ "number": 456, "repo": "khal", "user_login": "pimutils" }
[ { "action": "opened", "author": "youngmoney", "comment_id": null, "datetime": 1467328479000, "masked_author": "username_0", "text": "simple fix for #455\n\ncomment on style/name/etc", "title": "add end-necessary to event.format", "type": "issue" }, { "action": "created", "author": "geier", "comment_id": 230362176, "datetime": 1467673471000, "masked_author": "username_1", "text": "good for now, only some docs please. And you might want to remove the idiotic defaultdict I put in there (or I will later, no rush).", "title": null, "type": "comment" }, { "action": "created", "author": "youngmoney", "comment_id": 230363318, "datetime": 1467674810000, "masked_author": "username_0", "text": "I've added documentation, as a side note I dont thing the defaultdict is\n\"idiotic\", It is certainly fine to have it there as incorrect format strings\nwill not error, but instead just be empty strings", "title": null, "type": "comment" }, { "action": "created", "author": "geier", "comment_id": 230587523, "datetime": 1467749201000, "masked_author": "username_1", "text": "I'm unsure, the problem is, you might not notice typos, or, as happened to me in one of our last conversations, I thought `{end-necessary}` would already exist, but was just bugged.", "title": null, "type": "comment" }, { "action": "created", "author": "youngmoney", "comment_id": 230678733, "datetime": 1467785256000, "masked_author": "username_0", "text": "I'll fix this in day format #457", "title": null, "type": "comment" } ]
2
5
590
false
false
590
false
marian-nmt/marian
marian-nmt
286,400,859
149
null
[ { "action": "opened", "author": "elmines", "comment_id": null, "datetime": 1515185286000, "masked_author": "username_0", "text": "I am attempting to compile Marian on a CentOS Linux server with the following modules loaded:\r\n\r\nCurrently Loaded Modules:\r\n 1) **cmake/3.10.1** 2) **cuda/8.0.44** 3) ofed/4.1-1.0.2.0 4) openmpi/2.1.1-gnu-pmi2 5) **boost/1.58.0** 6) autogen/5.11.1 7) **gcc/5.4.0**\r\n\r\nI understand Marian has these following dependencies:\r\nCMake 3.5.1\r\nGCC/G++ 5.4\r\nBoost 1.58\r\nCUDA 8.0\r\n\r\nWould my use of newer versions of CMake and Cuda be causing the issue? Here is the output when I run `cmake ..`\r\n\r\n-- The C compiler identification is GNU 5.4.0\r\n-- The CXX compiler identification is GNU 5.4.0\r\n-- Check for working C compiler: /opt/asn/apps/gcc_5.4.0/bin/cc\r\n-- Check for working C compiler: /opt/asn/apps/gcc_5.4.0/bin/cc -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Detecting C compile features\r\n-- Detecting C compile features - done\r\n-- Check for working CXX compiler: /opt/asn/apps/gcc_5.4.0/bin/c++\r\n-- Check for working CXX compiler: /opt/asn/apps/gcc_5.4.0/bin/c++ -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- Detecting CXX compile features\r\n-- Detecting CXX compile features - done\r\n-- Looking for pthread.h\r\n-- Looking for pthread.h - found\r\n-- Looking for pthread_create\r\n-- Looking for pthread_create - not found\r\n-- Looking for pthread_create in pthreads\r\n-- Looking for pthread_create in pthreads - not found\r\n-- Looking for pthread_create in pthread\r\n-- Looking for pthread_create in pthread - found\r\n-- Found Threads: TRUE\r\n-- Found CUDA: /opt/asn/apps/cuda_8.0.44 (found version \"8.0\")\r\n-- Compiling with CUDA support\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n CMakeLists.txt:75 (find_package)\r\n\r\n\r\n-- Could NOT find Boost\r\nCMake Error at CMakeLists.txt:93 (message):\r\n Cannot find Boost libraries. Terminating.\r\n\r\n\r\n-- Found PythonLibs: /usr/lib64/libpython2.7.so (found suitable version \"2.7.5\", minimum required is \"2.7\")\r\n-- Found Python\r\n-- Found ZLIB: /usr/lib64/libz.so (found version \"1.2.7\")\r\n-- Found Git: /usr/bin/git (found version \"1.8.3.1\")\r\n-- Git version: d3fb526\r\n-- Could NOT find SparseHash (missing: SPARSEHASH_INCLUDE_DIR)\r\n-- Project name: marian\r\n-- Project version: v1.0.0+d3fb526\r\n-- Found CUDA: /opt/asn/apps/cuda_8.0.44 (found suitable version \"8.0\", minimum required is \"8.0\")\r\n-- Not Found Tcmalloc\r\nCMake Warning at src/marian/CMakeLists.txt:57 (message):\r\n Cannot find TCMalloc library. Continuing.\r\n\r\n\r\n-- Found Python\r\n-- Found OpenSSL: /usr/lib64/libcrypto.so (found version \"1.0.2k\")\r\n-- Found OpenSSL\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\nCMake Warning at /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:567 (message):\r\n Imported targets and dependency information not available for Boost version\r\n (all versions older than 1.33)\r\nCall Stack (most recent call first):\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\r\n /mnt/homeapps/apps/uv/apps/cmake_3.10.1/share/cmake-3.10/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\r\n src/marian/CMakeLists.txt:90 (find_package)\r\n\r\n\r\n-- Could NOT find Boost\r\nCMake Error at src/marian/CMakeLists.txt:95 (message):\r\n Cannot find Boost libraries. Terminating.\r\n\r\n\r\n-- Found Doxygen: /usr/bin/doxygen (found version \"1.8.5\") found components: doxygen dot\r\n-- Configuring incomplete, errors occurred!\r\nSee also \"/home/ualelm/marian/build/CMakeFiles/CMakeOutput.log\".\r\nSee also \"/home/ualelm/marian/build/CMakeFiles/CMakeError.log\".", "title": "Boost Not Found During Compilation", "type": "issue" }, { "action": "created", "author": "emjotde", "comment_id": 357477890, "datetime": 1515888655000, "masked_author": "username_1", "text": "Where are your boost libraries located?", "title": null, "type": "comment" }, { "action": "created", "author": "elmines", "comment_id": 357483433, "datetime": 1515896391000, "masked_author": "username_0", "text": "The libraries are found in /opt/asn/apps/boost_1.58.0/lib. I have verified that this directory has been added to both my LD_LIBRARY_PATH and LIBRARY_PATH environment variables.", "title": null, "type": "comment" }, { "action": "created", "author": "emjotde", "comment_id": 357485161, "datetime": 1515899123000, "masked_author": "username_1", "text": "I believe CMake does not check there. Try\r\n``\r\ncmake .. -DCMAKE_BUILD_TYPE=Release -DBOOST_DIR=/opt/asn/apps/boost_1.58.0\r\n``", "title": null, "type": "comment" }, { "action": "created", "author": "elmines", "comment_id": 357548409, "datetime": 1515969252000, "masked_author": "username_0", "text": "At the moment, the same error occurs even with those command line options. I am currently investigating FindBoost.cmake to find out why it says the Boost version is older than 1.33.", "title": null, "type": "comment" }, { "action": "created", "author": "elmines", "comment_id": 357566309, "datetime": 1515982620000, "masked_author": "username_0", "text": "It appears I had to do something similar to what you suggested, but I had to use a different CMake variable:\r\n`cmake .. -DCMAKE_BUILD_TYPE=Release -DBOOST_ROOT=/opt/asn/apps/boost_1.58.0`\r\n\r\nWith that command, the compilation worked flawlessly. Thank you for your help; I do greatly appreciate it. Since the issue is resolved, I will close the thread.", "title": null, "type": "comment" }, { "action": "closed", "author": "elmines", "comment_id": null, "datetime": 1515982621000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "emjotde", "comment_id": 358046749, "datetime": 1516125010000, "masked_author": "username_1", "text": "For reference:\r\nhttps://github.com/marian-nmt/marian-dev/wiki/Compiling-Marian-with-custom-Boost", "title": null, "type": "comment" }, { "action": "created", "author": "elmines", "comment_id": 358050038, "datetime": 1516125587000, "masked_author": "username_0", "text": "Thank you, and I apologize for not carefully looking through the Wiki in the first place.", "title": null, "type": "comment" }, { "action": "created", "author": "emjotde", "comment_id": 358050361, "datetime": 1516125637000, "masked_author": "username_1", "text": "This wasn't direct at you actually. More as a reference for future searches.", "title": null, "type": "comment" } ]
2
10
12,793
false
false
12,793
false
patrys/vscode-code-outline
null
326,237,361
136
null
[ { "action": "opened", "author": "egabrum", "comment_id": null, "datetime": 1527186202000, "masked_author": "username_0", "text": "(At least in Python) the outline shows everything that is imported in the from\r\n`from xxx import yyy, zzz`\r\nThis creates a lot of useless noise in the outline.\r\nIs there a way to not show these imports?", "title": "Hide imports (Python)", "type": "issue" }, { "action": "created", "author": "patrys", "comment_id": 392047428, "datetime": 1527252491000, "masked_author": "username_1", "text": "Code Outline knows nothing about the programming language so it does not know which lines are imports. It displays all symbols as reported by the language-specific extension (in this case the Python extension maintained by Microsoft). I am planning to include folding regions when they become accessible to extensions so there's a chance of the Python extension either not reporting imports at all or grouping them into a folding region that would eventually group them in the symbol tree.", "title": null, "type": "comment" }, { "action": "created", "author": "egabrum", "comment_id": 392113206, "datetime": 1527266111000, "masked_author": "username_0", "text": "Too bad. Thanks for looking into this.", "title": null, "type": "comment" }, { "action": "closed", "author": "patrys", "comment_id": null, "datetime": 1527332486000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
4
729
false
false
729
false
OpenTouryoProject/OpenTouryo
OpenTouryoProject
251,466,351
252
null
[ { "action": "opened", "author": "daisukenishino", "comment_id": null, "datetime": 1503204473000, "masked_author": "username_0", "text": "# Requirement\r\n- Implement ServiceForSb and JsonControllerand consume it from UWP and SPA sample.\r\n- In this case, use B and D layers of WSServerSample that is used in other WSClientSample.", "title": "Maintenance of the client samples", "type": "issue" }, { "action": "closed", "author": "daisukenishino2", "comment_id": null, "datetime": 1504080336000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
189
false
false
189
false
apache/cordova-docs
apache
376,341,032
900
null
[ { "action": "opened", "author": "Kezzel", "comment_id": null, "datetime": 1541069092000, "masked_author": "username_0", "text": "**Issue Type**\r\n[x ] Bug\r\n[ ] Feature Request\r\n\r\n**Priority**\r\n[ ] Minor <!-- very specific or only affects a few people -->\r\n[ x] Major <!-- important and impacts many people -->\r\n[ ] Critical <!-- Bugs (not features) that block the main function of a component and affect a large number of people -->\r\n[ ] Blocker <!-- Catastrophic bugs that prevent projects from building or cause basic projects to crash immediately -->\r\n\r\n**Environment**\r\n* OS: iOS\r\n* Xcode 9.4.1\r\n\r\n**Description**\r\nThe documentation for iOS platform guideline, states to use codeSignIdentity \"Iphone Developer\" for both debug and release.\r\nThis baffled me a long time and I finally ended up figuring out that it ought to be \"Iphone Distribution\" when signing a release. \r\nI am not a wizz and may have misunderstood some of the documentation, however I think it would be beneficial to a lot of users if this part was at least clarified:-)", "title": "CodeSignIdentity in iOS platform guide not correct", "type": "issue" }, { "action": "created", "author": "dpogue", "comment_id": 435054635, "datetime": 1541081911000, "masked_author": "username_1", "text": "When using automatic signing for iOS (which we try to encourage), you do need to use \"iPhone Developer\" for both debug and release.\r\n\r\nIf you're doing manual signing, you should be able to leave `codeSignIdentity` out of build.json entirely, and instead specify the `provisioningProfile` as a UUID. If you don't override it, we use \"iPhone Distribution\" for signing release builds.", "title": null, "type": "comment" }, { "action": "closed", "author": "dpogue", "comment_id": null, "datetime": 1541081926000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
1,292
false
false
1,292
false
apache/spark
apache
350,609,331
22,108
{ "number": 22108, "repo": "spark", "user_login": "apache" }
[ { "action": "opened", "author": "dilipbiswal", "comment_id": null, "datetime": 1534283109000, "masked_author": "username_0", "text": "## What changes were proposed in this pull request?\r\nAdd RewriteCorrelatedScalarSubquery in the list of nonExcludableRules since its used to transform correlated scalar subqueries to joins.\r\n\r\n## How was this patch tested?\r\nAdded test in OptimizerRuleExclusionSuite", "title": "[SPARK-25092][SQL][FOLLOWUP] Add RewriteCorrelatedScalarSubquery in list of nonExcludableRules", "type": "issue" }, { "action": "created", "author": "dilipbiswal", "comment_id": 413026689, "datetime": 1534283147000, "masked_author": "username_0", "text": "@username_1 We missed to add this rule. Please let me know what you think.", "title": null, "type": "comment" }, { "action": "created", "author": "gatorsmile", "comment_id": 413708394, "datetime": 1534460109000, "masked_author": "username_1", "text": "Thanks! Merged to master.", "title": null, "type": "comment" } ]
4
9
1,382
false
true
364
true
rust-lang/rust
rust-lang
296,083,912
48,118
{ "number": 48118, "repo": "rust", "user_login": "rust-lang" }
[ { "action": "opened", "author": "onur", "comment_id": null, "datetime": 1518250658000, "masked_author": "username_0", "text": "Beta backport of #48013", "title": "[beta] Use time crate in bootstrap dist instead of date", "type": "issue" }, { "action": "created", "author": "pietroalbini", "comment_id": 364641927, "datetime": 1518258674000, "masked_author": "username_1", "text": "The bot failed to assign a reviewer... @username_2?", "title": null, "type": "comment" }, { "action": "created", "author": "alexcrichton", "comment_id": 364658973, "datetime": 1518273078000, "masked_author": "username_2", "text": "@username_3: r+ p=1", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364658976, "datetime": 1518273079000, "masked_author": "username_3", "text": ":pushpin: Commit 0895099 has been approved by `username_2`\n\n<!-- @username_3 r=username_2 0895099f4a477aed3266d969d43a20de4d1b0b7a -->", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364678418, "datetime": 1518287194000, "masked_author": "username_3", "text": ":hourglass: Testing commit 0895099f4a477aed3266d969d43a20de4d1b0b7a with merge fa56e087a5e971f9372d5023e91abeb2be91080c...", "title": null, "type": "comment" }, { "action": "created", "author": "kennytm", "comment_id": 364685340, "datetime": 1518292544000, "masked_author": "username_4", "text": "Heh, no space left on device?\r\n\r\n```\r\n\u001b[0Ktravis_time:start:stage0-fabricate\r\n\u001b[0KBuilding stage0 tool fabricate (x86_64-unknown-linux-gnu)\r\n[01:15:43] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m same-file v0.1.3\r\n[01:15:43] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m yaml-rust v0.3.5\r\n[01:15:43] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m pkg-config v0.3.9\r\n[01:15:43] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m miniz-sys v0.1.10\r\n[01:15:44] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m filetime v0.1.14\r\n[01:15:44] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m xattr v0.1.11\r\n[01:15:45] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m walkdir v1.0.7\r\n[01:15:51] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m tar v0.4.14\r\n[01:15:51] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m lzma-sys v0.1.9\r\n[01:15:51] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m clap v2.29.0\r\n[01:15:51] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m flate2 v1.0.1\r\n[01:16:24] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m xz2 v0.1.3\r\n[01:17:06] \u001b[m\u001b[m\u001b[32m\u001b[1m Compiling\u001b[m installer v0.0.0 (file:///checkout/src/tools/rust-installer)\r\n[01:17:11] \u001b[m\u001b[m\u001b[32m\u001b[1m Finished\u001b[m release [optimized] target(s) in 87.85 secs\r\n[01:17:11] travis_fold:end:stage0-fabricate\r\n\u001b[0K\r\n[01:17:11] travis_time:end:stage0-fabricate:start=1518291862965457303,finish=1518291951467994290,duration=88502536987\r\n\u001b[0K\r\n[01:17:11] Error: failed to generate installer\r\n[01:17:11] Caused by: failed to copy '/checkout/obj/build/tmp/dist/rust-docs-beta-x86_64-unknown-linux-musl-image/share/doc/rust/html/alloc/slice/struct.Chunks.html' to '/checkout/obj/build/tmp/dist/rust-docs-beta-x86_64-unknown-linux-musl/rust-docs/share/doc/rust/html/alloc/slice/struct.Chunks.html'\r\n[01:17:11] Caused by: No space left on device (os error 28)\r\n```\r\n\r\nThe disk usage report, 14 GB used by `run-pass` alone\r\n\r\n```\r\n14874920\t./obj/build/x86_64-unknown-linux-gnu/test/run-pass\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "Mark-Simulacrum", "comment_id": 364688442, "datetime": 1518294141000, "masked_author": "username_5", "text": "I'm going to retry, I have a hard time believing this is actually constantly true because of this patch... @username_3 retry", "title": null, "type": "comment" }, { "action": "created", "author": "kennytm", "comment_id": 364688853, "datetime": 1518294346000, "masked_author": "username_4", "text": "@username_5 The size is 10 GB six months ago, so it is likely a very old problem. We can patch compiletest to delete those generated *.err/*.out dump if the test is successful.", "title": null, "type": "comment" }, { "action": "created", "author": "Mark-Simulacrum", "comment_id": 364690913, "datetime": 1518295746000, "masked_author": "username_5", "text": "Well, sure, and we probably should just not keep any artifacts around on CI that aren't going to be used, but I would somewhat expect this PR not to alter whether we fail or succeed.", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364701620, "datetime": 1518302420000, "masked_author": "username_3", "text": ":hourglass: Testing commit 0895099f4a477aed3266d969d43a20de4d1b0b7a with merge c625ea3c88b436c1fd5716ec55b289718a89fc31...", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364705830, "datetime": 1518306614000, "masked_author": "username_3", "text": ":broken_heart: Test failed - [status-travis](https://travis-ci.org/rust-lang/rust/builds/339978754?utm_source=github_status&utm_medium=notification)", "title": null, "type": "comment" }, { "action": "created", "author": "Mark-Simulacrum", "comment_id": 364706984, "datetime": 1518307703000, "masked_author": "username_5", "text": "Well, I guess it looks like we're going to have trouble landing this without some space-saving patches...\r\n\r\n```\r\n[01:07:11] travis_fold:end:stage0-fabricate\r\n\u001b[0K\r\n[01:07:11] travis_time:end:stage0-fabricate:start=1518306511032822992,finish=1518306587761868217,duration=76729045225\r\n\u001b[0K\r\n[01:07:12] Error: failed to generate installer\r\n[01:07:12] Caused by: failed to write .xz\r\n[01:07:12] Caused by: No space left on device (os error 28)\r\n[01:07:12] \r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "kennytm", "comment_id": 364727254, "datetime": 1518331400000, "masked_author": "username_4", "text": "@username_0 Could you try to ignore the `rustc-rust-log.rs` test:\r\n\r\n```diff\r\ndiff --git a/src/test/run-pass/rustc-rust-log.rs b/src/test/run-pass/rustc-rust-log.rs\r\nindex 629387d4cb..a0e04beaa9 100644\r\n--- a/src/test/run-pass/rustc-rust-log.rs\r\n+++ b/src/test/run-pass/rustc-rust-log.rs\r\n@@ -9,5 +9,6 @@\r\n // except according to those terms.\r\n \r\n // rustc-env:RUST_LOG=debug\r\n+// ignore-musl - workaround to avoid consuming all CI storage, see #48118\r\n```\r\n\r\nI bet 90% of the space usage comes from this test.", "title": null, "type": "comment" }, { "action": "created", "author": "onur", "comment_id": 364732087, "datetime": 1518336703000, "masked_author": "username_0", "text": "Done @username_4", "title": null, "type": "comment" }, { "action": "created", "author": "kennytm", "comment_id": 364732805, "datetime": 1518337423000, "masked_author": "username_4", "text": "@username_3 r=username_2", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364732806, "datetime": 1518337423000, "masked_author": "username_3", "text": ":pushpin: Commit 309e0d6 has been approved by `username_2`\n\n<!-- @username_3 r=username_2 309e0d60b806b1534beac2ab231bc2fd3e2f817c -->", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364739869, "datetime": 1518344181000, "masked_author": "username_3", "text": ":hourglass: Testing commit 309e0d60b806b1534beac2ab231bc2fd3e2f817c with merge fc74e576a09f533d7a49072eec9e744a13a92e95...", "title": null, "type": "comment" }, { "action": "created", "author": "bors", "comment_id": 364744430, "datetime": 1518348610000, "masked_author": "username_3", "text": ":broken_heart: Test failed - [status-travis](https://travis-ci.org/rust-lang/rust/builds/340088074?utm_source=github_status&utm_medium=notification)", "title": null, "type": "comment" }, { "action": "created", "author": "kennytm", "comment_id": 364745654, "datetime": 1518349785000, "masked_author": "username_4", "text": "Guess we're wrong, `run-pass` is still consuming 14 GB storage 😞", "title": null, "type": "comment" }, { "action": "created", "author": "Mark-Simulacrum", "comment_id": 364773217, "datetime": 1518372629000, "masked_author": "username_5", "text": "going to close this in favor of the general beta backport PR (#48146)", "title": null, "type": "comment" } ]
6
20
4,376
false
false
4,376
true
sh1r0/caffe-android-demo
null
209,644,848
55
null
[ { "action": "opened", "author": "gjtjx", "comment_id": null, "datetime": 1487816937000, "masked_author": "username_0", "text": "my cmake version is 3.4.0 ,build successed and the lib is libcaffe.so libcaffe.so.1.0.0-rc3 libcaffe_jni.so libproto.a,when run on snapdragon 652,error \"libcaffe.so.1.0.0-rc3\" not found,needs chmod 777?\r\nand why you build lib just have libcaffe.so libcaffe_jni.so ?any suggest?", "title": " dlopen(\"/data/app/com.sh1r0.caffe_android_demo_1_garbage-1/lib/arm64/libcaffe_jni.so\", RTLD_LAZY) failed: dlopen failed: could not load library \"libcaffe.so.1.0.0-rc3\" needed by \"/data/app/com.sh1r0.caffe_android_demo_1_garbage-1/lib/arm64/libcaffe_jni.so\"; caused by library \"libcaffe.so.1.0.0-rc3\" not found", "type": "issue" }, { "action": "created", "author": "sh1r0", "comment_id": 282938151, "datetime": 1488255690000, "masked_author": "username_1", "text": "This project is for demonstrating how to use [caffe-android-lib](https://github.com/username_1/caffe-android-lib) which means that building caffe executable is not the main focus.", "title": null, "type": "comment" }, { "action": "closed", "author": "sh1r0", "comment_id": null, "datetime": 1489482608000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
453
false
false
453
true
veelenga/awesome-crystal
null
256,474,251
209
{ "number": 209, "repo": "awesome-crystal", "user_login": "veelenga" }
[ { "action": "opened", "author": "vladfaust", "comment_id": null, "datetime": 1505001596000, "masked_author": "username_0", "text": "", "title": "Add soundmemes.cr", "type": "issue" }, { "action": "created", "author": "veelenga", "comment_id": 404602740, "datetime": 1531419274000, "masked_author": "username_1", "text": "@username_0 repo is not available anymore. Should we remove it from the list ?", "title": null, "type": "comment" }, { "action": "created", "author": "vladfaust", "comment_id": 404604350, "datetime": 1531419595000, "masked_author": "username_0", "text": "Yep, I decided to close the source. I don't mind removing it *but* it's still a Crystal project", "title": null, "type": "comment" } ]
2
3
172
false
false
172
true
agateau/doxyqml
null
311,596,552
32
null
[ { "action": "opened", "author": "jelazi", "comment_id": null, "datetime": 1522932578000, "masked_author": "username_0", "text": "My doxygen write File \"C:\\Python36\\build\\lib\\doxyqml\\doxyqml.py\", line 9, in \r\n from . import qmlparser ImportError: cannot import name 'qmlparser\r\nis any solution?", "title": "doxyqml error", "type": "issue" }, { "action": "created", "author": "agateau", "comment_id": 379567013, "datetime": 1523208426000, "masked_author": "username_1", "text": "Looks odd, how have you installed doxyqml? Did you use the setup.py script?", "title": null, "type": "comment" }, { "action": "created", "author": "jelazi", "comment_id": 379733606, "datetime": 1523276705000, "masked_author": "username_0", "text": "Yes, I use setup.py \r\npython c:\\Users\\.. ...\\doxyqml-master\\setup.py install\r\nInstall is correct\r\n\r\nrunning install\r\nrunning build\r\nrunning build_py\r\ncopying doxyqml\\doxyqml.py -> build\\lib\\doxyqml\r\ncopying doxyqml\\lexer.py -> build\\lib\\doxyqml\r\ncopying doxyqml\\qmlclass.py -> build\\lib\\doxyqml\r\ncopying doxyqml\\qmlparser.py -> build\\lib\\doxyqml\r\ncopying doxyqml\\__init__.py -> build\\lib\\doxyqml\r\nrunning build_scripts\r\nrunning install_lib\r\nrunning install_scripts\r\nrunning install_egg_info\r\nRemoving C:\\Python36\\Lib\\site-packages\\doxyqml-0.3.0-py3.6.egg-info\r\nWriting C:\\Python36\\Lib\\site-packages\\doxyqml-0.3.0-py3.6.egg-info\r\n\r\nNext I added the .qml extension to the FILTER_PATTERNS,FILE_PATTERNS,EXTENSION_MAPPING. \r\nWhen I run doxygen I have this output in qml files:Parsing file C:/Users... ...apcontroltesting/StreamerControlButton.qml...\r\nPreprocessing C:/Users... ...apcontroltesting/StreamerGrid.qml...\r\nTraceback (most recent call last):\r\n File \"C:\\Python36\\build\\lib\\doxyqml\\doxyqml.py\", line 9, in \r\n from . import qmlparser\r\nImportError: cannot import name 'qmlparser'", "title": null, "type": "comment" }, { "action": "created", "author": "agateau", "comment_id": 381332843, "datetime": 1523715990000, "masked_author": "username_1", "text": "I am not sure what is happening here. First I thought it could be an issue related to Python 3.6, but I just added 3.6 to the list of Python versions tested by Travis (see #34) and it works, so it's not that. \r\n\r\nCan you try to open doxyqml.py and replace line 9 to read `from doxyqml import qmlparser` instead of `from . import qmlparser`?", "title": null, "type": "comment" }, { "action": "created", "author": "RandomDudeTwo", "comment_id": 388329250, "datetime": 1526035486000, "masked_author": "username_2", "text": "Workaround:\r\nrun the Doxygen Gui or cmd (to run doxygen command) with Administrator Privileges", "title": null, "type": "comment" }, { "action": "created", "author": "sanjaymjoshi", "comment_id": 388420015, "datetime": 1526057239000, "masked_author": "username_3", "text": "Here is another potential fix that has worked for me:\r\n\r\nIn doxyqml.py, replace\r\n`from . import qmlparser\r\nfrom .lexer import Lexer, LexerError\r\nfrom .qmlclass import QmlClass`\r\nwith \r\n`from os import path\r\nsys.path.append( path.dirname( path.dirname( path.abspath(__file__) ) ) )\r\nimport qmlparser\r\nfrom lexer import Lexer, LexerError\r\nfrom qmlclass import QmlClass`\r\n\r\nThen do similar changes in lexer.py, qmlclass.py, and qmlparser.py.", "title": null, "type": "comment" }, { "action": "created", "author": "sanjaymjoshi", "comment_id": 390429817, "datetime": 1526760906000, "masked_author": "username_3", "text": "I tried the code from above, but now the functional test is failing. Any ideas?", "title": null, "type": "comment" }, { "action": "created", "author": "Illurian", "comment_id": 409566328, "datetime": 1533128451000, "masked_author": "username_4", "text": "Hi, i have installed Doxygen and use it whitout problem. THen i tried to add DoxyQml to it, installing python 37 and last version of pip. I configure doxygen as indicated but when i launch it, i got this error \"Traceback (most recent call last):\r\n File \"C:\\Python37\\Lib\\site-packages\\doxyqml\\doxyqml.py\", line 9, in \r\n from . import qmlparser\r\nImportError: cannot import name 'qmlparser' from '__main__' (C:\\Python37\\Lib\\site-packages\\doxyqml\\doxyqml.py)\"\r\nSO actually i cann't use doxygen for QML. Can you help me?", "title": null, "type": "comment" }, { "action": "created", "author": "mpaperno", "comment_id": 411239031, "datetime": 1533685988000, "masked_author": "username_5", "text": "Same problem here.... default install (via both pip or setup.py) gets \r\n` cannot import name 'qmlparser' from '__main__' (E:\\Python3\\Lib\\site-packages\\doxyqml\\doxyqml.py)`\r\n\r\nI tried both the workaround ideas mentioned here, and both avoid the import errors, but when used from Doxygen both end with:\r\n`doxyqml: error: the following arguments are required: qml_file` (even with full admin privs everywhere).\r\n\r\nUsing the workaround by @username_2 I can successfully run doxyqml.py directly from a command line. This suggests some Doxy misconfig, but I've set it all up according to the README. \r\n\r\nMy Doxygen is v1.8.14. I'm using the full path the doxyqml in my FILTER_PATTERNS: \r\n`*.qml=E:\\Python3\\Lib\\site-packages\\doxyqml\\doxyqml.py`\r\n\r\nFinally solved the \"missing arguments\" issue by using a simple .bat file as the target for Doxy filter:\r\n\r\n`doxyqml.bat`:\r\n```\r\n@E:\\Python3\\python E:\\Python3\\Lib\\site-packages\\doxyqml\\doxyqml.py %1\r\n```\r\n\r\nFILTER_PATTERNS: `*.qml=E:\\Python3\\Lib\\site-packages\\doxyqml\\doxyqml.bat`\r\n\r\nHave no clue why this works but invoking `doxyqml.py` directly doesn't. But at least now my QML is documented... yay! Thanks @username_1 for the converter!", "title": null, "type": "comment" }, { "action": "created", "author": "Illurian", "comment_id": 413495300, "datetime": 1534414480000, "masked_author": "username_4", "text": "Tried this new version from the fix-windows branch and, if i use FILE_PATTERNS = *.qml, i get : \r\n'doxyqml' isn't recognize as an internal command.\r\nAnd if i use *.qml=C:\\Python37\\Lib\\site-packages\\doxyqml\\doxyqml.py i get : \r\nPreprocessing C:/Users/rcampred/Documents/Dynamo/src/30_Dynamo0/dynamo-bin/bin/x64/DTest/dynamoCore/utils/inspector/qml/tst_inspector.qml...\r\nTraceback (most recent call last):\r\n File \"C:\\Python37\\Lib\\site-packages\\doxyqml\\doxyqml.py\", line 9, in \r\n from . import qmlparser\r\nImportError: cannot import name 'qmlparser' from '__main__' (C:\\Python37\\Lib\\site-packages\\doxyqml\\doxyqml.py)\r\nParsing file C:/Users/rcampred/Documents/Dynamo/src/30_Dynamo0/dynamo-bin/bin/x64/DTest/dynamoCore/utils/inspector/qml/tst_inspector.qml...\r\n\r\nSo it's seems that the problem still exist.", "title": null, "type": "comment" }, { "action": "created", "author": "mpaperno", "comment_id": 413499116, "datetime": 1534415348000, "masked_author": "username_5", "text": "Check the updated notes in the [README](https://github.com/username_1/doxyqml/pull/44/commits/4e32db7dadad8e2ae1eea278744ab3d9b91b2969). \r\n\r\nYou need to _either_ have `C:\\Python37\\Scripts` in your `PATH` environment variable and use:\r\n\r\n`FILTER_PATTERNS = *.qml=doxyqml` \r\n\r\n_or_ use the (new) full path to the script:\r\n\r\n`FILTER_PATTERNS = *.qml=C:\\Python37\\Scripts\\doxyqml`\r\n\r\nAlso make sure you run the new `setup.py` to get the script in the right place to begin with (in the Python `Scripts` folder). It is actually called `doxyqml.exe` now. Sounds like your second attempt was still trying to use the old version.", "title": null, "type": "comment" }, { "action": "created", "author": "Illurian", "comment_id": 413539650, "datetime": 1534424975000, "masked_author": "username_4", "text": "After giving him doxyqml.exe, it work!\r\nBut i had to unninstall python and reinstall it to correctly remove the old version of doxyqml, else doxyqml.exe call the old setup.py.\r\nAlso i unninstall python becaus i'm bad with it and when i use the uninstall command, python said it cann't do that, so i prefer totaly remove python and reinstal it.\r\nAnyway thank you, now it work for me!", "title": null, "type": "comment" }, { "action": "closed", "author": "agateau", "comment_id": null, "datetime": 1535298600000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
6
13
5,800
false
false
5,800
true
cloudflare/lua-aho-corasick
cloudflare
312,387,984
11
{ "number": 11, "repo": "lua-aho-corasick", "user_login": "cloudflare" }
[ { "action": "opened", "author": "dkg", "comment_id": null, "datetime": 1523247563000, "masked_author": "username_0", "text": "* do not try to set PREFIX more than once.\r\n * if PREFIX has been externally set, accept it.\r\n * use CPPFLAGS during compilation, if externally set.\r\n * use LDFLAGS during linking, if externally set.", "title": "Clean up Makefile", "type": "issue" }, { "action": "created", "author": "jdesgats", "comment_id": 379684685, "datetime": 1523264643000, "masked_author": "username_1", "text": "Sounds good, thanks :+1:", "title": null, "type": "comment" } ]
2
2
223
false
false
223
false
hazelcast/hazelcast-reference-manual
hazelcast
345,209,963
557
{ "number": 557, "repo": "hazelcast-reference-manual", "user_login": "hazelcast" }
[ { "action": "opened", "author": "taburet", "comment_id": null, "datetime": 1532695022000, "masked_author": "username_0", "text": "Depends on https://github.com/hazelcast/hazelcast/pull/13359", "title": "Provide documentation on index statistics", "type": "issue" }, { "action": "created", "author": "olukas", "comment_id": 408805618, "datetime": 1532943375000, "masked_author": "username_1", "text": "@username_0 What do you think about idea to add some sentence, small section or just warning that those stats are for local map and also give users some clue how to count them for whole map? I believe it would be useful. \r\n\r\nBesides that, current docs in this PR looks good to me, thanks for it.", "title": null, "type": "comment" }, { "action": "created", "author": "taburet", "comment_id": 410193761, "datetime": 1533287247000, "masked_author": "username_0", "text": "@username_1 there already exists a small section about that: http://docs.hazelcast.org/docs/latest-dev/manual/html-single/index.html#getting-member-statistics, but I will add the information about your idea with the weighted stats calculation to the index stats section, are you ok with this?", "title": null, "type": "comment" }, { "action": "created", "author": "olukas", "comment_id": 410206658, "datetime": 1533290322000, "masked_author": "username_1", "text": "@username_0 yes, part with weighted stats calculation seems perfect now, thanks! The last objection is missing `customers.addIndex(\"name\", true);` in example as I mentioned above. Once it will be fixed then this PR is ok for me.", "title": null, "type": "comment" } ]
2
4
865
false
false
865
true
formulahendry/vscode-code-runner
null
217,325,588
98
null
[ { "action": "opened", "author": "axefrog", "comment_id": null, "datetime": 1490637425000, "masked_author": "username_0", "text": "```\r\n[Running] ts-node \"d:\\dropbox\\work\\dev\\yreuq.js\\temp-zadfghcabp.typescript\"\r\nd:\\dropbox\\work\\dev\\yreuq.js\\temp-zadfghcabp.typescript:1\r\n(function (exports, require, module, __filename, __dirname) { function isPathEqual(a: number[], b: number[]): boolean {\r\n ^\r\nSyntaxError: Unexpected token :\r\n at createScript (vm.js:53:10)\r\n at Object.runInThisContext (vm.js:95:10)\r\n at Module._compile (module.js:543:28)\r\n at Object.Module._extensions..js (module.js:580:10)\r\n at Module.load (module.js:488:32)\r\n at tryModuleLoad (module.js:447:12)\r\n at Function.Module._load (module.js:439:3)\r\n at Function.Module.runMain (module.js:605:10)\r\n at Object.<anonymous> (C:\\Users\\axefr\\AppData\\Roaming\\npm\\node_modules\\ts-node\\src\\_bin.ts:177:12)\r\n at Module._compile (module.js:571:32)\r\n\r\n[Done] exited with code=1 in 1.977 seconds\r\n```", "title": "TypeScript not compiling", "type": "issue" }, { "action": "created", "author": "formulahendry", "comment_id": 289646889, "datetime": 1490669317000, "masked_author": "username_1", "text": "`temp-zadfghcabp.typescript`: Do you intend to select a piece of code snippet to run?", "title": null, "type": "comment" }, { "action": "created", "author": "axefrog", "comment_id": 289647936, "datetime": 1490669769000, "masked_author": "username_0", "text": "I just made an untitled file (unsaved in a tab), set the language to typescript, pasted some code in, then pressed CTRL+SHIFT+N to run it. Do I need to select it as well?", "title": null, "type": "comment" }, { "action": "created", "author": "formulahendry", "comment_id": 289650476, "datetime": 1490670856000, "masked_author": "username_1", "text": "Got it. So did you try to run the same code (with `ts-node`) in the terminal?", "title": null, "type": "comment" }, { "action": "created", "author": "philmueller", "comment_id": 324402883, "datetime": 1503508584000, "masked_author": "username_2", "text": "@username_0: The reason is that the automatically generated temporary file for your unsaved code (`tempCodeRunnerFile.typescript`) doesn't end with \".ts\", so ts-node seems to interpret it as JavaScript instead of TypeScript. As a workaround, you can save the file with \".ts\" ending or add the following to your user settings:\r\n\r\n```\r\n\"code-runner.languageIdToFileExtensionMap\": {\r\n \"typescript\": \".ts\"\r\n}\r\n```\r\n@username_1: I've created a corresponding pull request to apply the correct file ending to the default configuration (#166).", "title": null, "type": "comment" }, { "action": "closed", "author": "formulahendry", "comment_id": null, "datetime": 1503534813000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "formulahendry", "comment_id": 324499455, "datetime": 1503534840000, "masked_author": "username_1", "text": "That's cool. Thanks @username_2 !", "title": null, "type": "comment" } ]
3
7
1,840
false
false
1,840
true
maxigs/formvalidation-rails
null
110,054,439
2
null
[ { "action": "opened", "author": "simkessy", "comment_id": null, "datetime": 1444151103000, "masked_author": "username_0", "text": "This is the version I'm seeing: v0.6.2-dev, built on 2015-03-13 8:15:45 AM", "title": "Would it be possible to get an update to version 7?", "type": "issue" }, { "action": "created", "author": "maxigs", "comment_id": 148170608, "datetime": 1444851362000, "masked_author": "username_1", "text": "Hi, sorry for the late answer but i'm pretty swamped at the moment. I'll have a look a.s.a.p. but can't make any promise when i'll get around to upgrading it. \r\nIf you are in a rush feel free to send a pull request and ill upgrade the gem (or you can also use a git-repo via bundler directly), normally the upgrade should be rather easy, just replacing the js files with the latest.", "title": null, "type": "comment" }, { "action": "created", "author": "simkessy", "comment_id": 148178670, "datetime": 1444852723000, "masked_author": "username_0", "text": "Turns out it's not free anymore so I'm not sure how that would work. It's fine though. This version is working perfectly good anyways. Thx.", "title": null, "type": "comment" }, { "action": "created", "author": "maxigs", "comment_id": 148180392, "datetime": 1444853184000, "masked_author": "username_1", "text": "The Version 6.x was also NOT free for commercial usage (see the license part in the readme) , open source does not mean it's always free to use in any way ;)", "title": null, "type": "comment" }, { "action": "closed", "author": "simkessy", "comment_id": null, "datetime": 1452716695000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
5
752
false
false
752
false
inhabitedtype/angstrom
inhabitedtype
233,880,086
79
null
[ { "action": "opened", "author": "igstan", "comment_id": null, "datetime": 1496753206000, "masked_author": "username_0", "text": "What is it meant by **unbounded** lookahead? For example, the following snippet outputs `result: a,a,a`, instead of what I would have expected to be `result: a,b,c`:\r\n\r\n```ocaml\r\nopen Angstrom\r\n\r\nlet parser =\r\n peek_char_fail >>= fun a ->\r\n peek_char_fail >>= fun b ->\r\n peek_char_fail >>= fun c ->\r\n [a; b; c] |> List.map Char.escaped |> String.concat \",\" |> return\r\n\r\nlet () =\r\n let result = parse_only parser (`String \"abc\") in\r\n match result with\r\n | Ok s -> print_endline (\"success: \" ^ s)\r\n | Error e -> print_endline (\"failure: \" ^ e)\r\n```", "title": "Unbounded lookahead", "type": "issue" }, { "action": "created", "author": "seliopou", "comment_id": 311242362, "datetime": 1498533908000, "masked_author": "username_1", "text": "Unbounded lookahead in the context of the library's documentation that there is no limit on the backtracking that a parser can utilize to arrive at a successful parse. In other words, the alternative operator `<|>` can be used without restriction, with the caveat that using it with parsers that don't consume any input may lead to an infinite loop.\r\n\r\nYour use of `peek_char_fail` behaves like it does because that parser doesn't advance the input; sequential calls will produce the same result. If you'd like to get the next three characters then you could use the `take 3` parser and use bind to access the result. If the characters returned by the parse are not to your satisfaction then you can use the `fail` parser together with the `<|>` operator to define an alternative parse.", "title": null, "type": "comment" }, { "action": "created", "author": "igstan", "comment_id": 311261140, "datetime": 1498543195000, "masked_author": "username_0", "text": "Thank you. `take 3`, `fail` and `<|>` will probably work for my case.", "title": null, "type": "comment" }, { "action": "closed", "author": "igstan", "comment_id": null, "datetime": 1498543202000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
4
1,411
false
false
1,411
false
Godzil/Crunchy
null
222,585,424
25
null
[ { "action": "opened", "author": "Gorklax", "comment_id": null, "datetime": 1492562935000, "masked_author": "username_0", "text": "This is a super minor complaint, but the only issue I've been running into is how the program numbers the episodes. When it moves to a new season, the season number changes, but the episode number continues in series. For example it will go from S01E12 to S02E13 rather than S02E01. This becomes problematic for media apps like plex as it is not able to correctly identify the episode.", "title": "Change episode numbering pattern", "type": "issue" }, { "action": "created", "author": "JySzE", "comment_id": 298473641, "datetime": 1493687690000, "masked_author": "username_1", "text": "Look up filebot portable it can batch rename them. Portable version is free so make sure to find that one, i always use it after downloading with crunchy and plex detects it perfect after. Make sure you disable local assets in the server library settings so it doesnt use local metadata.", "title": null, "type": "comment" }, { "action": "created", "author": "JySzE", "comment_id": 298473730, "datetime": 1493687729000, "masked_author": "username_1", "text": "plex loves to ignore file names and only looks at meta data if local assets is left on.", "title": null, "type": "comment" }, { "action": "created", "author": "Godzil", "comment_id": 298563369, "datetime": 1493715291000, "masked_author": "username_2", "text": "Unfortunately the season/episode number are the value retrieved from CR, it is not computed by Crunchy, I have plan for that but it is a non urgent change as there are possibility to use external tools to renumber.\r\n\r\nIt is CR that need to received this issue unfortunately, their numbering scheme is not consistent with tool like tvdb, or maybe tvdb provide incorrect data, which is also possible.\r\n\r\nFrom what I understand, CR try to use the anime official numbering scheme for the Anime where tvdb use a pseudo standardised system.", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345157745, "datetime": 1510900432000, "masked_author": "username_3", "text": "@username_2 I have a problem with this series: it has 3 episode have the same name, and crunchy can not download the second part always like this: \r\n![Uploading image.png…]\r\nIt will not automatically change the name but always show fetching video ... and did nothing.\r\nThis is the link for it: http://www.crunchyroll.com/the-ancient-magus-bride\r\nit has 2: s01e01,\r\n2: s02e02,\r\n2: s03e03\r\nCan you please help?", "title": null, "type": "comment" }, { "action": "created", "author": "UnattendedFlight", "comment_id": 345210277, "datetime": 1510915650000, "masked_author": "username_4", "text": "@username_3 Please edit your comment and blur out or crop out your username and password. People might abuse this information.\r\n\r\nTo your problem, I recently downloaded Ancient Magus' Bride without problems, it added a \"-1\" suffix to any episode similar to existing on the drive.\r\n\r\nI'm not really qualified to tell you how to fix this problem, but a workaround would be to move already downloaded files to a subfolder before the new set of episodes will download. It wont re-download them unless you remove them from the .crpersistent file..", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345412799, "datetime": 1510973007000, "masked_author": "username_3", "text": "@username_4 thank you, that is exactly the problem.\r\nDo you know how to save file as .mp4?", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345432193, "datetime": 1510999733000, "masked_author": "username_3", "text": "@username_4 can you please recheck for me with this show : `http://www.crunchyroll.com/jojos-bizarre-adventure`\r\nI can just download until s01e26 while it has about 77 ep (but the name is duplicated), I never download this before.\r\nAnd also this one: `http://www.crunchyroll.com/boruto-naruto-next-generations`\r\nI've deleted all boruto on the .crpersistent but it can not download.\r\n![image](https://user-images.githubusercontent.com/33084800/32979189-23490dc0-cc83-11e7-9a3f-8a1b92aee523.png)", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345432623, "datetime": 1511000283000, "masked_author": "username_3", "text": "And also this one, i can not download, this is the error\r\n![image](https://user-images.githubusercontent.com/33084800/32979259-679dac32-cc84-11e7-82ea-7fe3795c7ef1.png)\r\nthis is the link: `http://www.crunchyroll.com/children-of-ether`", "title": null, "type": "comment" }, { "action": "created", "author": "Godzil", "comment_id": 345437606, "datetime": 1511006303000, "masked_author": "username_2", "text": "Children of Ether as it is currently on CR is NOT a serie but just an anime. Crunchy, because of how CR is made right now don't detect movies/ONA you have to use a direct link to download the movie:\r\n\r\nUse the form \r\n\r\n@http://www.url/to/movie\r\n\r\nSo go to the page with the movie, copy the link from it and add an \"@\" in front when pasting to the command line", "title": null, "type": "comment" }, { "action": "created", "author": "Godzil", "comment_id": 345437652, "datetime": 1511006352000, "masked_author": "username_2", "text": "For the fact that some show are using the same season number, please complain to CR, Crunchy does not invent the number, they are retreived from CR. (see #51)", "title": null, "type": "comment" }, { "action": "created", "author": "UnattendedFlight", "comment_id": 345452852, "datetime": 1511022106000, "masked_author": "username_4", "text": "", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345588741, "datetime": 1511152010000, "masked_author": "username_3", "text": "@username_2 thank you, it works when I put '@' before the movie link.", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345588854, "datetime": 1511152074000, "masked_author": "username_3", "text": "@username_4 can you please tell me how can i setup so that crunchy can run follow this structure\r\n`--> E:\\COMIC\\0001\r\n-- |--> JoJo's Bizarre Adventure\r\n-- |-- |--> 01-26 Episodes.\r\n-- |--> JoJo's Bizarre Adventure Re-Edited\r\n-- |-- |--> 01-03 Episodes\r\n-- |--> JoJo's Bizarre Adventure: Stardust Crusaders\r\n-- |-- |--> 01-24 Episodes\r\n-- |--> JoJo's Bizarre Adventure: Stardust Crusaders - Battle in Egypt\r\n-- |-- |--> 25-48 Episodes\r\n-- |--> JoJo's Bizarre Adventure: Diamond is Unbreakable\r\n-- |-- |--> 01-39 Episodes`\r\nor i have to do it manually when it stop working?\r\nthis problem also happen with this link `http://www.crunchyroll.com/naruto-shippuden`", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345612111, "datetime": 1511162785000, "masked_author": "username_3", "text": "@username_2 Hi there, can you please check, do i have any problem with this syntax or something because Crunchy doesn't download this movie always show fetching video.... as below\r\n![image](https://user-images.githubusercontent.com/33084800/33006891-bc71e9d2-cdfe-11e7-8145-f7a897a0b42b.png)\r\nThis is the link: `http://www.crunchyroll.com/the-ancient-magus-bride/episode-7-talk-of-the-devil-and-he-is-sure-to-appear-749411`", "title": null, "type": "comment" }, { "action": "created", "author": "UnattendedFlight", "comment_id": 345619491, "datetime": 1511165259000, "masked_author": "username_4", "text": "@username_3 Crunchy will not follow that structure, crunchy is only a tool to download. (yet in a convenient way. Props to username_2 for continuing to maintain it!) You have to setup whatever folder structure as you go yourself. \r\n\r\nAs to the \"faulty syntax\", it seems to be correct. So as long as it's downloading, what's the problem?", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345642330, "datetime": 1511170940000, "masked_author": "username_3", "text": "@unattendedFight The problem is if I setup a structure folder like that, I am afraid that cruchy will redownload the same EP, I mean it will download from 1-17 again and stop, it will not download the ep which haven’t been downloaded before. Do you get my point? Sorry for my bad english\r\nAbout “faulty syntax”: I just can not download this EP and it happens when I download other ep or whole serries, so I think may be that happens becauce of my slow internet connection. So that would be great if this software can show the internet connection speed, i think so.", "title": null, "type": "comment" }, { "action": "created", "author": "UnattendedFlight", "comment_id": 345653773, "datetime": 1511173472000, "masked_author": "username_4", "text": "@username_3 Try making a backup of the '.crpersistent' and the backup one and deleting them. Try your commands again. The files will be located in your output folder.", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345885184, "datetime": 1511227149000, "masked_author": "username_3", "text": "@username_4 I've deleted them, but it still doesn't work.\r\nStill Fetching video for a very long time.\r\nI don't know exactly what is the problem, but i don't think the problem is my internet connection because it all good, may be not because of crunchy because you said you can still download video.\r\nInfact I can just download the .ass file and the video doesn't work.\r\nPlease help", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 345890483, "datetime": 1511229035000, "masked_author": "username_3", "text": "@username_4 It's Working now, it take 31 mins to download a video 24 mins, maybe because of my internet connection.\r\n![image](https://user-images.githubusercontent.com/33084800/33050738-06b07e92-ce99-11e7-8bfb-87145bc1db48.png)", "title": null, "type": "comment" }, { "action": "created", "author": "UnattendedFlight", "comment_id": 345950896, "datetime": 1511252595000, "masked_author": "username_4", "text": "@username_3 More likely that your computer was taking a heavy load, causing ffmpeg to work slowly, I've experience that myself, taking 40 minutes for a 24min episode when my server was under heavy traffic/load. Glad it worked out.", "title": null, "type": "comment" }, { "action": "created", "author": "skthanu", "comment_id": 346738478, "datetime": 1511496038000, "masked_author": "username_3", "text": "@username_4 Yes, thank you alot for helping me out.", "title": null, "type": "comment" }, { "action": "created", "author": "Godzil", "comment_id": 410505517, "datetime": 1533458924000, "masked_author": "username_2", "text": "There as been recent changes that should solve most of the seen issues there.\r\nPlease open a new issue if any of theses still appear.", "title": null, "type": "comment" }, { "action": "closed", "author": "Godzil", "comment_id": null, "datetime": 1533458924000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
5
24
6,824
false
false
6,824
true
readium/readium-sdk
readium
172,054,629
255
null
[ { "action": "opened", "author": "xieweizhi", "comment_id": null, "datetime": 1471582702000, "masked_author": "username_0", "text": "Is there a way to do this in iOS ?", "title": "How to know when user click a hightlight?", "type": "issue" }, { "action": "created", "author": "danielweck", "comment_id": 241430473, "datetime": 1471876113000, "masked_author": "username_1", "text": "see https://github.com/readium/readium-js-viewer/blob/develop/src/js/EpubReader.js#L1105\r\n\r\n\r\n readium.reader.plugins.highlights.on(\"annotationClicked\", function(type, idref, cfi, id) {\r\n console.debug(\"ANNOTATION CLICK: \" + id);\r\n \r\n });", "title": null, "type": "comment" }, { "action": "closed", "author": "danielweck", "comment_id": null, "datetime": 1471876114000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "danielweck", "comment_id": 241431324, "datetime": 1471876264000, "masked_author": "username_1", "text": "oh, and remember to enable the highlighter plugin in your build configuration:\r\nhttps://github.com/readium/readium-shared-js/blob/develop/plugins/plugins.cson#L3", "title": null, "type": "comment" } ]
2
4
479
false
false
479
false
Team254/cheesy-arena
Team254
367,988,552
68
{ "number": 68, "repo": "cheesy-arena", "user_login": "Team254" }
[ { "action": "opened", "author": "ejordan376", "comment_id": null, "datetime": 1539041756000, "masked_author": "username_0", "text": "Here is Cheesy Arena compiled on windows 10. with the latest version of go.", "title": "2018 for windows", "type": "issue" }, { "action": "created", "author": "patfair", "comment_id": 428066358, "datetime": 1539063508000, "masked_author": "username_1", "text": "Thanks! Uploaded as a release instead of merging into the Git repo.", "title": null, "type": "comment" } ]
2
2
142
false
false
142
false
janishar/PlaceHolderView
null
265,487,000
59
null
[ { "action": "opened", "author": "vikas-github", "comment_id": null, "datetime": 1507982939000, "masked_author": "username_0", "text": "I have implemented the tinder like stacked view everything is working perfectly but profile images are not visible. Also @drawable is not reconizable, I created vector asset for heart and cancel buttons gives error of \"couldnt resolve resource\".", "title": "Profile images are not showing and @drawable is unrecognizable", "type": "issue" }, { "action": "created", "author": "janishar", "comment_id": 336787327, "datetime": 1508133271000, "masked_author": "username_1", "text": "@username_0 \r\nCan you share the code where you are using `@drawable` because it's not available in PlaceHolderView. \r\nHow you added the image in the `@Resolve` annotated method?\r\n`couldn't resolve resource` could be something to do with the vector image itself.", "title": null, "type": "comment" }, { "action": "created", "author": "vikas-github", "comment_id": 337462040, "datetime": 1508303400000, "masked_author": "username_0", "text": "Thanks for the response. The drawable issue is resolved now. But the profile image is still not showing.\r\nHere is the code in @Resolve annoted method, `Glide.with(mContext).load(\"http://kelompokdua.hol.es/pic/Appetizer/juice.jpg\").into(profileImageView);` Just for testing purpose I'm adding image from hard-coded link string", "title": null, "type": "comment" }, { "action": "created", "author": "janishar", "comment_id": 338492963, "datetime": 1508692037000, "masked_author": "username_1", "text": "@username_0 I checked it should work. \r\nTake this example:\r\nhttps://github.com/username_1/Tutorials/blob/master/TinderSwipe/app/src/main/java/test/mindorks/swipe/tinderswipe/TinderCard.java\r\n\r\nReplace with:\r\n```java\r\n@Resolve\r\n private void onResolved(){\r\n Glide.with(mContext).load(\"http://kelompokdua.hol.es/pic/Appetizer/juice.jpg\")\r\n .bitmapTransform(new RoundedCornersTransformation(mContext, Utils.dpToPx(7), 0,\r\n RoundedCornersTransformation.CornerType.TOP))\r\n .into(profileImageView);\r\n nameAgeTxt.setText(mProfile.getName() + \", \" + mProfile.getAge());\r\n locationNameTxt.setText(mProfile.getLocation());\r\n }\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "vikas-github", "comment_id": 348681539, "datetime": 1512208755000, "masked_author": "username_0", "text": "Thanks its working", "title": null, "type": "comment" }, { "action": "closed", "author": "vikas-github", "comment_id": null, "datetime": 1512208755000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
6
1,553
false
false
1,553
true
aws/amazon-freertos
aws
412,212,247
324
null
[ { "action": "opened", "author": "marjon-halter", "comment_id": null, "datetime": 1550629058000, "masked_author": "username_0", "text": "Enabled the TCP Echo project.\r\nSetup my laptop to be on the same subnet as the ESP32-WROVER board.\r\nInstalled xinetd to get an echo server running.\r\n\r\nConfigured the TCP Echo project to:\r\n1. Connect to AP\r\n2. Send echo messages.\r\n3. Disconnect from AP\r\n4. Sleep for a fixed time.\r\n5. Wake up.\r\n6. Repeat.\r\n\r\n**System information**\r\n- Hardware: Espressif Demo board for ESP32-WROVER\r\n- IDE used:Eclipse\r\n- Operating System [Linux]\r\n- Version of Amazon FreeRTOS (run ``git describe --tags`` to find it): v1.4.6-61-gf0c0efc7\r\n- Project [TCP Echo] with addition of code to disconnect from AP, sleep and reconnect to AP on wakeup.\r\n\r\n**Expected behavior**\r\nExpect the TCP stack to handle the error returned by wifi driver and recover.\r\n\r\n**Screenshots or console output**\r\n```cpp\r\n--- idf_monitor on /dev/ttyUSB0 115200 ---\r\n--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---\r\nets Jun 8 2016 00:22:57\r\n\r\nrst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)\r\nflash read err, 1000\r\nets_main.c 371 \r\nets Jun 8 2016 00:22:57\r\n\r\nrst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)\r\nconfigsip: 0, SPIWP:0xee\r\nclk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00\r\nmode:DIO, clock div:2\r\nload:0x3fff0018,len:4\r\nload:0x3fff001c,len:6312\r\nload:0x40078000,len:11264\r\nho 0 tail 12 room 4\r\nload:0x40080000,len:6008\r\n0x40080000: _iram_start at /home/marjon/workspace/amazon-freertos/lib/FreeRTOS/portable/ThirdParty/GCC/Xtensa_ESP32/xtensa_vectors.S:1685\r\n\r\nentry 0x4008032c\r\n0x4008032c: _KernelExceptionVector at ??:?\r\n\r\nI (31) boot: ESP-IDF v3.1.1-18-g607d2ce34 2nd stage bootloader\r\nI (31) boot: compile time 14:23:45\r\nI (31) boot: Enabling RNG early entropy source...\r\nI (37) boot: SPI Speed : 40MHz\r\nI (41) boot: SPI Mode : DIO\r\nI (45) boot: SPI Flash Size : 16MB\r\nI (49) boot: Partition Table:\r\nI (52) boot: ## Label Usage Type ST Offset Length\r\nI (60) boot: 0 nvs WiFi data 01 02 00010000 00006000\r\nI (67) boot: 1 otadata OTA data 01 00 00016000 00002000\r\nI (75) boot: 2 phy_init RF data 01 01 00018000 00001000\r\nI (82) boot: 3 ota_0 OTA app 00 10 00020000 00177000\r\nI (90) boot: 4 ota_1 OTA app 00 11 001a0000 00177000\r\nI (97) boot: 5 storage WiFi data 01 02 00317000 00010000\r\nI (105) boot: End of partition table\r\nE (109) boot: ota data partition invalid and no factory, will try all partitions\r\nI (117) esp_image: segment 0: paddr=0x00020020 vaddr=0x3f400020 size=0x14160 ( 82272) map\r\nI (155) esp_image: segment 1: paddr=0x00034188 vaddr=0x3ffc0000 size=0x02bf8 ( 11256) load\r\nI (159) esp_image: segment 2: paddr=0x00036d88 vaddr=0x3ffc2bf8 size=0x00000 ( 0) load\r\nI (161) esp_image: segment 3: paddr=0x00036d90 vaddr=0x40080000 size=0x00400 ( 1024) load\r\n0x40080000: _iram_start at /home/marjon/workspace/amazon-freertos/lib/FreeRTOS/portable/ThirdParty/GCC/Xtensa_ESP32/xtensa_vectors.S:1685\r\n\r\nI (171) esp_image: segment 4: paddr=0x00037198 vaddr=0x40080400 size=0x08e78 ( 36472) load\r\nI (194) esp_image: segment 5: paddr=0x00040018 vaddr=0x400d0018 size=0x75a28 (481832) map\r\n0x400d0018: _stext at ??:?\r\n\r\nI (363) esp_image: segment 6: paddr=0x000b5a48 vaddr=0x40089278 size=0x06eb4 ( 28340) load\r\n0x40089278: coex_arbit_clean_overtime_until at ??:?\r\n\r\nI (376) esp_image: segment 7: paddr=0x000bc904 vaddr=0x400c0000 size=0x00000 ( 0) load\r\nI (376) esp_image: segment 8: paddr=0x000bc90c vaddr=0x50000000 size=0x00000 ( 0) load\r\nI (392) boot: Loaded app from partition at offset 0x20000\r\nI (392) boot: ota rollback check done\r\nI (393) boot: Disabling RNG early entropy source...\r\nI (398) cpu_start: Pro cpu up.\r\nI (402) cpu_start: Single core mode\r\nI (407) heap_init: Initializing. RAM available for dynamic allocation:\r\nI (413) heap_init: At 3FFAFF10 len 000000F0 (0 KiB): DRAM\r\nI (419) heap_init: At 3FFD2248 len 0000DDB8 (55 KiB): DRAM\r\nI (425) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM\r\nI (432) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM\r\nI (438) heap_init: At 4009012C len 0000FED4 (63 KiB): IRAM\r\nI (444) cpu_start: Pro cpu start user code\r\nI (127) cpu_start: Starting scheduler on PRO CPU.\r\nI (208) wifi: wifi driver task: 3ffda368, prio:23, stack:3584, core=0\r\nI (208) wifi: wifi firmware version: 8f35e40\r\nI (208) wifi: config NVS flash: enabled\r\nI (208) wifi: config nano formating: disabled\r\nI (208) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE\r\nI (218) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE\r\nI (238) wifi: Init dynamic tx buffer num: 32\r\nI (238) wifi: Init data frame dynamic rx buffer num: 5\r\nI (238) wifi: Init management frame dynamic rx buffer num: 5\r\nI (248) wifi: Init static rx buffer size: 1600\r\nI (248) wifi: Init static rx buffer num: 5\r\nI (258) wifi: Init dynamic rx buffer num: 5\r\n0 9 [main] WiFi module initialized. Connecting to AP <accesspoint>...\r\nW (268) phy_init: failed to load RF calibration data (0x1102), falling back to full calibration\r\nI (438) phy: phy_version: 4000, b6198fa, Sep 3 2018, 15:11:06, 0, 2\r\nI (478) wifi: mode : sta (30:ae:a4:cf:0c:64)\r\nI (478) WIFI: SYSTEM_EVENT_STA_START\r\nI (848) wifi: n:3 0, o:1 0, ap:255 255, sta:3 0, prof:1\r\nI (1828) wifi: state: init -> auth (b0)\r\nI (1838) wifi: state: auth -> assoc (0)\r\nI (1848) wifi: state: assoc -> run (10)\r\nI (1858) wifi: connected with <accesspoint>, channel 3\r\nI (1858) wifi: pm start, type: 1\r\n\r\nI (1858) WIFI: SYSTEM_EVENT_STA_CONNECTED\r\n1 420 [IP-task] vDHCPProcess: offer a0201dfip\r\nI (4388) event: sta ip: 10.2.1.223, mask: 255.255.252.0, gw: 10.2.1.1\r\nI (4388) WIFI: SYSTEM_EVENT_STA_GOT_IP\r\n2 422 [IP-task] vDHCPProcess: offer a0201dfip\r\n3 423 [main] WiFi Connected to AP. Creating tasks which use network...\r\n4 423 [main] ERROR: Failed to provision certificate -1 \r\n5 424 [main] Write certificate...\r\n6 424 [main] ERROR: Failed to provision certificate 7 \r\n7 425 [main] ERROR: Failed to provision private key 7 \r\nI (4418) wifi: state: run -> init (0)\r\nI (4418) wifi: pm stop, total sleep time: 2101247 us / 2560729 us\r\n\r\nI (4428) wifi: n:3 0, o:3 0, ap:255 255, sta:3 0, prof:1\r\nI (4438) WIFI: SYSTEM_EVENT_STA_DISCONNECTED: 8\r\n8 425 [Echo0] WiFi module initialized. Connecting to AP <accesspoint>...\r\nI (4558) wifi: n:3 0, o:3 0, ap:255 255, sta:3 0, prof:1\r\nI (5538) wifi: state: init -> auth (b0)\r\nI (5548) wifi: state: auth -> assoc (0)\r\nI (5558) wifi: state: assoc -> run (10)\r\nI (5578) wifi: connected with <accesspoint>, channel 3\r\nI (5578) wifi: pm start, type: 1\r\n\r\nI (5578) WIFI: SYSTEM_EVENT_STA_CONNECTED\r\n9 733 [IP-task] vDHCPProcess: offer a0201dfip\r\nI (7518) event: sta ip: 10.2.1.223, mask: 255.255.252.0, gw: 10.2.1.1\r\nI (7518) WIFI: SYSTEM_EVENT_STA_GOT_IP\r\n10 735 [IP-task] vDHCPProcess: offer a0201dfip\r\n11 735 [Echo0] WiFi Connected to AP. Creating tasks which use network...\r\n12 735 [Echo0] Connecting to echo server\r\n13 936 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\nI (9678) wifi: state: run -> init (0)\r\nI (9678) wifi: pm stop, total sleep time: 2865884 us / 4092174 us\r\n\r\nI (9678) wifi: n:3 0, o:3 0, ap:255 255, sta:3 0, prof:1\r\nI (9678) WIFI: SYSTEM_EVENT_STA_DISCONNECTED: 8\r\n14 951 [Echo0] Connecting to echo server\r\n15 1451 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\n16 1466 [Echo0] Connecting to echo server\r\nE (15678) NetInterface: Failed to tx buffer 0x3ffdd522, len 42, err -16\r\n17 1751 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\n18 1766 [Echo0] Connecting to echo server\r\nE (18678) NetInterface: Failed to tx buffer 0x3ffdd522, len 42, err -16\r\n19 2051 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\n20 2066 [Echo0] Connecting to echo server\r\nE (21678) NetInterface: Failed to tx buffer 0x3ffdd522, len 42, err -16\r\n21 2351 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\n```\r\n\r\n**To reproduce**\r\nSteps to reproduce the behavior:\r\nSee description on top of this ticket.\r\n\r\n**Additional context**\r\nAdd any other context about the problem here.\r\n\r\nThank you!", "title": "NetInterface: Failed to tx buffer ..., err -16", "type": "issue" }, { "action": "created", "author": "aggarg", "comment_id": 465813497, "datetime": 1550709351000, "masked_author": "username_1", "text": "Looking at the logs, it seems that it is failing to provision the certificate and key.\r\n\r\n```\r\n4 423 [main] ERROR: Failed to provision certificate -1 \r\n5 424 [main] Write certificate...\r\n6 424 [main] ERROR: Failed to provision certificate 7 \r\n7 425 [main] ERROR: Failed to provision private key 7 \r\n```\r\n\r\nWould you please double check that you have set ```keyCLIENT_CERTIFICATE_PEM``` and ```keyCLIENT_PRIVATE_KEY_PEM``` in ```aws_clientcredential_keys.h```? The correct formatting should look something like this:\r\n\r\n```\r\n#define keyCLIENT_CERTIFICATE_PEM \\\r\n\"-----BEGIN CERTIFICATE-----\\n\" \\\r\n\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\n\" \\\r\n\"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\\n\" \\\r\n\"cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc\\n\" \\\r\n\"dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd\\n\" \\\r\n\"eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee\\n\" \\\r\n\"ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff\\n\" \\\r\n\"gggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg\\n\" \\\r\n\"hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh\\n\" \\\r\n\"iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii\\n\" \\\r\n\"jjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjj\\n\" \\\r\n\"kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk\\n\" \\\r\n\"llllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll\\n\" \\\r\n\"mmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm\\n\" \\\r\n\"nnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnn\\n\" \\\r\n\"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo\\n\" \\\r\n\"pppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppp\\n\" \\\r\n\"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\n\" \\\r\n\"rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr\\n\" \\\r\n\"-----END CERTIFICATE-----\\n\"\r\n```\r\n\r\n```\r\n#define keyCLIENT_PRIVATE_KEY_PEM \\\r\n\"-----BEGIN RSA PRIVATE KEY-----\\n\" \\\r\n\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\n\" \\\r\n\"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\\n\" \\\r\n\"cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc\\n\" \\\r\n\"dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd\\n\" \\\r\n\"eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee\\n\" \\\r\n\"ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff\\n\" \\\r\n\"gggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg\\n\" \\\r\n\"hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh\\n\" \\\r\n\"iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii\\n\" \\\r\n\"jjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjj\\n\" \\\r\n\"kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk\\n\" \\\r\n\"llllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll\\n\" \\\r\n\"mmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm\\n\" \\\r\n\"nnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnn\\n\" \\\r\n\"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo\\n\" \\\r\n\"pppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppp\\n\" \\\r\n\"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\n\" \\\r\n\"rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr\\n\" \\\r\n\"ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss\\n\" \\\r\n\"tttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt\\n\" \\\r\n\"uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu\\n\" \\\r\n\"vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv\\n\" \\\r\n\"wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww\\n\" \\\r\n\"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\\n\" \\\r\n\"yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy\\n\" \\\r\n\"-----END RSA PRIVATE KEY-----\\n\"\r\n```\r\n\r\nThanks.", "title": null, "type": "comment" }, { "action": "created", "author": "marjon-halter", "comment_id": 465814316, "datetime": 1550709591000, "masked_author": "username_0", "text": "Fair comment, but I was just testing connecting to the access point and doing a TCP echo to a local echo server (my laptop). I doubt it will need the AWS client keys for that task?", "title": null, "type": "comment" }, { "action": "created", "author": "aggarg", "comment_id": 465816088, "datetime": 1550710109000, "masked_author": "username_1", "text": "Yes you are right. I am setting it up to see what might be going wrong.\r\n\r\nThe other thing that you might try meanwhile is to check that the laptop's firewall is not blocking the incoming connection as you are failing to connect:\r\n\r\n```\r\n12 735 [Echo0] Connecting to echo server\r\n13 936 [Echo0] Echo demo failed to connect to echo server 10.2.2.248.\r\n```\r\n\r\nWould you mind sharing your changes to the TCP Echo demo so that I can replicate the same scenario.\r\n\r\nThank you for your patience.", "title": null, "type": "comment" }, { "action": "created", "author": "marjon-halter", "comment_id": 465816617, "datetime": 1550710287000, "masked_author": "username_0", "text": "Is there a private place I can share the file changes?", "title": null, "type": "comment" }, { "action": "created", "author": "marjon-halter", "comment_id": 465838153, "datetime": 1550716516000, "masked_author": "username_0", "text": "https://github.com/username_0/amazon-freertos --> tcp_echo_demo. It would not repeat it so quickly now, but it still happens eventually. The bug is intermittent. The wifi driver has to NOT yet transition from assoc->run, but the IP stack is already sending data out to the wifi driver.\r\ni.e.\r\n`I (5538) wifi: state: init -> auth (b0)`\r\n`I (5548) wifi: state: auth -> assoc (0)`\r\n`I (5558) wifi: state: assoc -> run (10)`\r\n`I (5578) wifi: connected with <accesspoint>, channel 3`\r\n`I (5578) wifi: pm start, type: 1`", "title": null, "type": "comment" }, { "action": "closed", "author": "qiutongs", "comment_id": null, "datetime": 1553188923000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
7
13,218
false
false
13,218
true
evrencoskun/TableView
null
331,522,470
132
null
[ { "action": "opened", "author": "farzadkamali20", "comment_id": null, "datetime": 1528798050000, "masked_author": "username_0", "text": "hi friend,\r\nin TableViewListener we access to cellview and can access to CellViewHolder.\r\n\r\nCell cell = (Cell) mTableView.getAdapter().getCellItem(column,row);\r\n if (cellView instanceof CheckBoxCellViewHolder ) {\r\n if (((CheckBoxCellViewHolder) cellView).checkBox.isChecked()) {\r\n ((CheckBoxCellViewHolder) cellView).checkBox.setChecked(false);\r\n cell.setbData(false);\r\n } else {\r\n ((CheckBoxCellViewHolder) cellView).checkBox.setChecked(true);\r\n cell.setbData(true);\r\n }\r\n }\r\n\r\nbut i want access to CheckBoxViewHolder and set checkbox to true or false in activity(no in TableViewListener ).\r\n\r\ni use this code : \r\n for (int i = 0; i < tableView.getChildCount(); i++) {\r\n**tableView.getCellLayoutManager().getCellViewHolder(3, i)).checkBox.setChecked(false);**\r\n}\r\n\r\nbut not worked properly when scroll table and error : \r\n\r\n 'android.widget.CheckBox com.example.farzad.charge.tableview.CheckBoxCellViewHolder.checkBox' on a null object reference", "title": "how to access cellViewHolder", "type": "issue" }, { "action": "created", "author": "evrencoskun", "comment_id": 396549008, "datetime": 1528800854000, "masked_author": "username_1", "text": "You shouldn't change the checkbox state like the way you do. You should just change the model value and update the item like \r\n\r\nFor example;\r\nlet's say your cell item has an instance like `mChecked`;\r\n\r\n```java\r\nclass Cell{\r\n...\r\npublic int mChecked;\r\n...\r\n}\r\n```\r\n\r\nwhen it's binding, it'll show the model data like you do.\r\n\r\n\r\n```java\r\nCheckBoxViewHolder {\r\n..\r\npublic void setCell(Cell cell){\r\n boolean checked = cell.getData() == 1;\r\n mCheckBox.setState(checked);\r\n}\r\n..\r\n}\r\n```\r\n\r\nSo, how can you change any checkbox state? \r\n\r\nyou just need to update the model of the cell item using \r\n`changeCellItem(int columnPosition, int rowPosition, YourCellModel cellModel)` function of the TableViewAdapter\r\n\r\n```java\r\nint row = 4;\r\nint column = 2;\r\n// get Cell item \r\nCell cellModel = tableViewAdapter.getCellItem(column , row );\r\n// Update the state o the checkbox\r\ncellModel .mChecked = 1;\r\n// Notify the TableView for changing process.\r\ntableViewAdapter.changeCellItem(column , row , cellModel); \r\n```", "title": null, "type": "comment" }, { "action": "closed", "author": "farzadkamali20", "comment_id": null, "datetime": 1528807109000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
3
2,065
false
false
2,065
false
handsontable/react-handsontable
handsontable
363,867,366
107
null
[ { "action": "opened", "author": "nimesha95", "comment_id": null, "datetime": 1537940873000, "masked_author": "username_0", "text": "Hi, \r\nHow can i access the data row (or tree) when given a row index of a updated cell.\r\nCurrently i'm accessing the row index of updated cell by using 'afterChange' function. Is there a way to access the data of the whole tree (or atleast updated row)\r\n(I cannot directly access the props data by row id because i'm using nested view)", "title": "Get the row data in nested view", "type": "issue" }, { "action": "created", "author": "AMBudnik", "comment_id": 425393681, "datetime": 1538130482000, "masked_author": "username_1", "text": "Hi @username_0 \r\n\r\nsure, you can and it is the best way.\r\n\r\nHere is a working demo https://jsfiddle.net/handsoncode/d1x42rvf/", "title": null, "type": "comment" }, { "action": "closed", "author": "nimesha95", "comment_id": null, "datetime": 1538989642000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
3
460
false
false
460
true
go-gitea/gitea
go-gitea
316,492,222
3,828
null
[ { "action": "opened", "author": "kolaente", "comment_id": null, "datetime": 1524317573000, "masked_author": "username_0", "text": "IMHO we shouldn't use the term \"Company name\" here, as we don't primarily target companies.\r\n\r\n![bildschirmfoto von 2018-04-21 15-31-03](https://user-images.githubusercontent.com/13721712/39084648-282bcda4-4579-11e8-92aa-7de0e2fd8f2d.png)", "title": "Change \"company name\" in installation", "type": "issue" }, { "action": "created", "author": "lafriks", "comment_id": 383297532, "datetime": 1524319144000, "masked_author": "username_1", "text": "Why not, small company is also company ;)", "title": null, "type": "comment" }, { "action": "created", "author": "lunny", "comment_id": 383346902, "datetime": 1524359612000, "masked_author": "username_2", "text": "We can use organization install company since the customer maybe a person, a company or an organization and etc.", "title": null, "type": "comment" }, { "action": "created", "author": "kolaente", "comment_id": 383411456, "datetime": 1524430345000, "masked_author": "username_0", "text": "This sounds like a good idea to me.", "title": null, "type": "comment" }, { "action": "created", "author": "techknowlogick", "comment_id": 387944768, "datetime": 1525924594000, "masked_author": "username_3", "text": "Just created #3935 which updates text to suggested text", "title": null, "type": "comment" }, { "action": "closed", "author": "lunny", "comment_id": null, "datetime": 1525935530000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
4
6
481
false
false
481
false
uisautomation/iar-frontend
uisautomation
296,752,148
52
{ "number": 52, "repo": "iar-frontend", "user_login": "uisautomation" }
[ { "action": "opened", "author": "joeadams04", "comment_id": null, "datetime": 1518531420000, "masked_author": "username_0", "text": "Buttons in both headers are changed to white to contrast with the primary coloured Appbar.\r\nCancel button in the edit view is no longer raised.", "title": "Change button colour in headers", "type": "issue" }, { "action": "created", "author": "abrahammartin", "comment_id": 365286864, "datetime": 1518532988000, "masked_author": "username_1", "text": "Closes #13", "title": null, "type": "comment" } ]
3
3
153
false
true
153
false
dvajs/dva
dvajs
258,441,929
1,231
null
[ { "action": "opened", "author": "dingyanqiang", "comment_id": null, "datetime": 1505732840000, "masked_author": "username_0", "text": "### 期望目标,目标文件大小应该为减去dll.js的内容。\r\n### 实际效果,build:dll应用前后目标文件大小一样\r\n### build:dll问题\r\n``` javascript\r\ndllPlugin: {\r\n exclude: [\"babel-runtime\", \"roadhog\"],\r\n include: [\"dva/router\", \"dva/saga\", \"dva/fetch\"]\r\n}\r\n```\r\n### npm run build:dll 打包出的roadhog.dll.js\r\n### npm run build (文件大小和不用dll一样大)\r\n* \r\n```javascript\r\n\"scripts\": {\r\n \"start\": \"roadhog server\",\r\n \"build\": \"roadhog build\",\r\n \"build:dll\": \"roadhog buildDll\",\r\n \"lint\": \"eslint --ext .js src test\"\r\n }\r\n\r\n dllPlugin: {\r\n exclude: [\"babel-runtime\", \"roadhog\"],\r\n include: [\"dva/router\", \"dva/saga\", \"dva/fetch\"]\r\n }\r\n```\r\n```\r\n 159.93 KB dist/index.js\r\n 120.35 KB dist/zhanling.js\r\n 8.25 KB dist/index.css\r\n 5.01 KB dist/zhanling.css\r\n\r\n```", "title": "dva 1.2.x版本 dll应用无效", "type": "issue" }, { "action": "created", "author": "sorrycc", "comment_id": 330235726, "datetime": 1505743982000, "masked_author": "username_1", "text": "roadhog 里的 dll 只对 server 有效。", "title": null, "type": "comment" }, { "action": "closed", "author": "sorrycc", "comment_id": null, "datetime": 1505743982000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "dingyanqiang", "comment_id": 330263977, "datetime": 1505749286000, "masked_author": "username_0", "text": "", "title": null, "type": "comment" }, { "action": "created", "author": "dingyanqiang", "comment_id": 330264317, "datetime": 1505749356000, "masked_author": "username_0", "text": "", "title": null, "type": "comment" }, { "action": "created", "author": "sorrycc", "comment_id": 330398916, "datetime": 1505783482000, "masked_author": "username_1", "text": "不用是啥版本,dll 目前只在 server 里有效。", "title": null, "type": "comment" }, { "action": "created", "author": "dingyanqiang", "comment_id": 330410799, "datetime": 1505788409000, "masked_author": "username_0", "text": "OK", "title": null, "type": "comment" } ]
2
7
786
false
false
786
false
RealyUniqueName/StablexUI
null
160,330,096
232
null
[ { "action": "opened", "author": "krupin-maxim", "comment_id": null, "datetime": 1465960608000, "masked_author": "username_0", "text": "I have a project with complicated ui in xml-files. Number of xml-files is over than 130. Now compile time is over than 40 seconds. Can I optimize it?", "title": " Slow build with number of xml-files over than 130", "type": "issue" }, { "action": "created", "author": "RealyUniqueName", "comment_id": 243526342, "datetime": 1472580151000, "masked_author": "username_1", "text": "Sorry, i somehow missed this issue.\r\nIf it is still relevant, you can try comiplation server: https://haxe.org/manual/cr-completion-server.html", "title": null, "type": "comment" } ]
2
2
292
false
false
292
false
MylesIsCool/ViaVersion
null
342,568,051
874
null
[ { "action": "opened", "author": "ConnorFranta", "comment_id": null, "datetime": 1531971653000, "masked_author": "username_0", "text": "### What is the output link of /viaversion dump? \r\nhttps://dump.viaversion.com/efcd53867b76cc2b825ebe5518cc54d57dc9bc17b397d1f075a96d269847fb4c\r\n\r\n### Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)\r\nNo bungee\r\nViaVersion 1.4.0-DEV\r\nViaRewind-1.3.10\r\nviabackwards-all-2.3.1\r\n\r\n### How does this error happen? login? Using an item? \r\nItem frames facing:\r\n- North, normal place and break\r\n![image](https://user-images.githubusercontent.com/26499948/42920312-edc6d6ee-8ae3-11e8-8f8d-31962e7b9434.png)\r\n\r\n- East, can't place or break, even at an angle\r\n![image](https://user-images.githubusercontent.com/26499948/42920216-9077c4ee-8ae3-11e8-9e58-bebb64c29772.png)\r\n\r\n- South, normal place and break\r\n![image](https://user-images.githubusercontent.com/26499948/42920264-ba7bd42e-8ae3-11e8-878c-1fd3ff603116.png)\r\n\r\n- West, need to stand at an angle to place/break\r\n![image](https://user-images.githubusercontent.com/26499948/42920291-d7694152-8ae3-11e8-9977-d4bdbf3cc904.png)\r\n\r\n\r\n### Is there an error in the console? Use pastebin.com. Is there a kick message?\r\nNone", "title": "Item frame hit boxes are in wrong locations", "type": "issue" }, { "action": "closed", "author": "Matsv", "comment_id": null, "datetime": 1531994058000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "Matsv", "comment_id": 406221985, "datetime": 1531994071000, "masked_author": "username_1", "text": "Thanks for reporting!\r\n\r\nThis issue will be fixed in the next version or the latest devbuild (:", "title": null, "type": "comment" } ]
2
3
1,233
false
false
1,233
false
shirasagi/shirasagi
shirasagi
139,154,416
850
null
[ { "action": "opened", "author": "sunny4381", "comment_id": null, "datetime": 1457402996000, "masked_author": "username_0", "text": "再現手順:\r\n\r\n1. 複数のファイルをアップロードする。\r\n2. どれか一つを選択する。\r\n3. 一覧上部にある「削除」ボタンをクリックする。\r\n4. 全件削除される。", "title": "アップローダーでファイルが全件削除されてしまう。", "type": "issue" }, { "action": "closed", "author": "itowtips", "comment_id": null, "datetime": 1457581491000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
85
false
false
85
false
helm/charts
helm
378,919,241
9,129
{ "number": 9129, "repo": "charts", "user_login": "helm" }
[ { "action": "opened", "author": "unguiculus", "comment_id": null, "datetime": 1541711617000, "masked_author": "username_0", "text": "", "title": "Just a test for CI issues", "type": "issue" } ]
2
2
747
false
true
0
false
GMLC-TDC/HELICS-src
GMLC-TDC
292,191,410
125
null
[ { "action": "opened", "author": "kdheepak", "comment_id": null, "datetime": 1517132046000, "masked_author": "username_0", "text": "", "title": "Make HELICS brew installable", "type": "issue" }, { "action": "created", "author": "kdheepak", "comment_id": 361050282, "datetime": 1517132497000, "masked_author": "username_0", "text": "Currently, the following script works to install HELICS on a Mac.\r\n\r\n```bash\r\nbrew install https://raw.githubusercontent.com/GMLC-TDC/HELICS-src/develop/scripts/brew/helics.rb\r\n```\r\n\r\n\r\n<img width=\"1146\" alt=\"screen shot 2018-01-28 at 2 40 07 am\" src=\"https://user-images.githubusercontent.com/1813121/35480839-b363e820-03d4-11e8-8810-1a55a8541d20.png\">\r\n\r\nThis will not install `helics_broker`, `helics_player` or `helics_recorder` to the PATH. It will create the binaries in `/usr/local/Cellar/helics/1.0.0/bin`. It also currently does not install the Python extension. These are improvements to be made.", "title": null, "type": "comment" }, { "action": "created", "author": "phlptp", "comment_id": 361305323, "datetime": 1517243940000, "masked_author": "username_1", "text": "Just out of curiosity what would we have to do to have something like\r\n```\r\nbrew install helics\r\n``` \r\nor\r\n```\r\nbrew install helics-python\r\n```\r\nactually work\r\n\r\nand this is pretty cool!", "title": null, "type": "comment" }, { "action": "created", "author": "phlptp", "comment_id": 361674173, "datetime": 1517334172000, "masked_author": "username_1", "text": "I don't think we want this in the very near future, but what would be involved in getting this into the standard brew libraries so you wouldn't have to enter the tap command first?", "title": null, "type": "comment" }, { "action": "created", "author": "kdheepak", "comment_id": 361683292, "datetime": 1517335894000, "masked_author": "username_0", "text": "This is what brew recommends as criteria for [Acceptable Formulae](https://github.com/Homebrew/brew/blob/master/docs/Acceptable-Formulae.md) that go into the core. I think we maintain our tap and once we have enough users you can make a PR to the core. The tap is a completely acceptable way to do this. I've installed a lot of packages from taps.", "title": null, "type": "comment" }, { "action": "created", "author": "kdheepak", "comment_id": 361687490, "datetime": 1517336701000, "masked_author": "username_0", "text": "Users can use the following to install and build the Python extension\r\n\r\n```bash\r\nbrew install helics --with-python --with-python-include-dir=$(python3-config --prefix)/include/python3.6m/\r\n```\r\n\r\nFull instructions will be found in the install instructions documentation page.", "title": null, "type": "comment" }, { "action": "closed", "author": "kdheepak", "comment_id": null, "datetime": 1517336708000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "kdheepak", "comment_id": 361687854, "datetime": 1517336771000, "masked_author": "username_0", "text": "This also adds `helics_broker`, `helics_player` and `helics_recorder` to the PATH.", "title": null, "type": "comment" }, { "action": "created", "author": "kdheepak", "comment_id": 361981418, "datetime": 1517414973000, "masked_author": "username_0", "text": "Documentation for this has been updated and is located [here](https://gmlc-tdc.github.io/HELICS-src/installation/mac.html).", "title": null, "type": "comment" } ]
2
9
1,800
false
false
1,800
false
vektah/gqlparser
null
340,909,024
32
{ "number": 32, "repo": "gqlparser", "user_login": "vektah" }
[ { "action": "opened", "author": "vvakame", "comment_id": null, "datetime": 1531466353000, "masked_author": "username_0", "text": "off topic: I saw `OverlappingFieldsCanBeMerged` rule, It's tooooo heavy. 😅", "title": "implement PossibleFragmentSpreads validator", "type": "issue" }, { "action": "created", "author": "vektah", "comment_id": 404985332, "datetime": 1531528526000, "masked_author": "username_1", "text": "![image](https://user-images.githubusercontent.com/2247982/42718907-723d7ebe-8751-11e8-810c-58a549a6a2f3.png)\r\n\r\nDid you see https://gitter.im/gqlgen/parser?", "title": null, "type": "comment" } ]
3
3
538
false
true
231
false