repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
philcockfield/storybook-host | null | 281,201,023 | 30 | {
"number": 30,
"repo": "storybook-host",
"user_login": "philcockfield"
} | [
{
"action": "opened",
"author": "brentmclark",
"comment_id": null,
"datetime": 1513034171000,
"masked_author": "username_0",
"text": "This quick change removes the `normalize.css` file so that it does not interfere with custom CSS imported into `storybook`\r\nSee https://github.com/username_3/storybook-host/issues/14\r\n\r\nA brief test at my desk reveals that removing normalize shifts the overall container to be a little bit wider, but was otherwise not a noticeable change. Anecdotal, I know, but clearly it is not critical to the success of the addon.",
"title": "Remove normalize.css",
"type": "issue"
},
{
"action": "created",
"author": "pcardune",
"comment_id": 362135672,
"datetime": 1517451080000,
"masked_author": "username_1",
"text": "What are you thoughts on this @username_3? I too would like to see this go in because it breaks [the StoryShots addon](https://github.com/storybooks/storybook/tree/master/addons/storyshots)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Josh-a-e",
"comment_id": 392470372,
"datetime": 1527498977000,
"masked_author": "username_2",
"text": "Any chances of getting this merged in?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philcockfield",
"comment_id": 392601374,
"datetime": 1527540574000,
"masked_author": "username_3",
"text": "OK, yeah - there are a couple of mods I want to make to this before merging. I'll get onto that now. Thanks @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philcockfield",
"comment_id": 395594970,
"datetime": 1528413309000,
"masked_author": "username_3",
"text": "Hey chaps! \r\n\r\nSee version `5.0.0` release on NPM that has `normalize.js` removed. Lemme know how this works for you?\r\n\r\nThanks!",
"title": null,
"type": "comment"
}
] | 4 | 5 | 904 | false | false | 904 | true |
jekyll/jekyll-import | jekyll | 285,734,946 | 337 | null | [
{
"action": "opened",
"author": "inwardmovement",
"comment_id": null,
"datetime": 1514996366000,
"masked_author": "username_0",
"text": "I installed Jekyll on Windows the recommended way (using bash Ubuntu), and when trying to install jekyll-import I a have this error (exerpts) :\r\n\r\n```\r\nERROR: Error installing jekyll-import:\r\nERROR: Failed to build gem native extension.\r\nzlib is missing; necessary for building libxml2\r\nCould not create Makefile due to some reason, probably lack of necessary\r\nlibraries and/or headers.\r\n```\r\n\r\nAre there special steps to make it work on Windows?",
"title": "Error installing jekyll-import",
"type": "issue"
},
{
"action": "created",
"author": "DirtyF",
"comment_id": 355839088,
"datetime": 1515346959000,
"masked_author": "username_1",
"text": "/cc @jekyll/windows",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "SuriyaaKudoIsc",
"comment_id": 355840989,
"datetime": 1515348678000,
"masked_author": "username_2",
"text": "You should run `sudo apt-get install zlib1g-dev` in Windows Bash Ubuntu.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "inwardmovement",
"comment_id": 355971707,
"datetime": 1515419546000,
"masked_author": "username_0",
"text": "Thanks, it seem to work!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "inwardmovement",
"comment_id": null,
"datetime": 1515419553000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 562 | false | false | 562 | false |
kbase/narrative | kbase | 176,974,569 | 748 | {
"number": 748,
"repo": "narrative",
"user_login": "kbase"
} | [
{
"action": "opened",
"author": "thomasoniii",
"comment_id": null,
"datetime": 1473875355000,
"masked_author": "username_0",
"text": "Just a new chaplin pointer, which contains newer ontology dictionary and translation widgets to use tabs when in the narrative interface, as opposed to boxes as on the landing pages.",
"title": "Ontology widgets update",
"type": "issue"
},
{
"action": "created",
"author": "briehl",
"comment_id": 247103307,
"datetime": 1473876320000,
"masked_author": "username_1",
"text": "👍",
"title": null,
"type": "comment"
}
] | 2 | 2 | 183 | false | false | 183 | false |
abersailbot/Kitty | abersailbot | 262,365,033 | 7 | null | [
{
"action": "opened",
"author": "naturesyouth",
"comment_id": null,
"datetime": 1507023793000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/JSpringett\"><img src=\"https://avatars3.githubusercontent.com/u/325530?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [JSpringett](https://github.com/JSpringett)**\n_Wednesday Nov 23, 2016 at 14:21 GMT_\n_Originally opened as https://github.com/abersailbot/kitty-hardware/issues/7_\n\n----\n\nWhat batteries? How many? How is the PI supplied? How is the rest of the system supplied?",
"title": "Investigate power source",
"type": "issue"
},
{
"action": "created",
"author": "naturesyouth",
"comment_id": 333792254,
"datetime": 1507023794000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/Danyc0\"><img src=\"https://avatars2.githubusercontent.com/u/2716831?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [Danyc0](https://github.com/Danyc0)**\n_Wednesday Nov 23, 2016 at 21:00 GMT_\n\n----\n\nThe black batteries in kitty are 4*7.2v NiMh (but much higher capacity than those in Dewi, hence why they're so much heavier and slightly bigger). They're in series for the computers to run the RoWind at the right voltage, but in parallel for the servos to give them enough current capacity. (All recalled from 3 year old memories, so take with a pinch of salt)",
"title": null,
"type": "comment"
},
{
"action": "opened",
"author": "naturesyouth",
"comment_id": null,
"datetime": 1507023794000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/JSpringett\"><img src=\"https://avatars3.githubusercontent.com/u/325530?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [JSpringett](https://github.com/JSpringett)**\n_Wednesday Nov 23, 2016 at 14:21 GMT_\n_Originally opened as https://github.com/abersailbot/kitty-hardware/issues/7_\n\n----\n\nWhat batteries? How many? How is the PI supplied? How is the rest of the system supplied?",
"title": "Investigate power source",
"type": "issue"
},
{
"action": "created",
"author": "naturesyouth",
"comment_id": 333792257,
"datetime": 1507023795000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/JSpringett\"><img src=\"https://avatars3.githubusercontent.com/u/325530?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [JSpringett](https://github.com/JSpringett)**\n_Wednesday Nov 23, 2016 at 21:02 GMT_\n\n----\n\nCheers Dan",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "naturesyouth",
"comment_id": 333792260,
"datetime": 1507023796000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/Danyc0\"><img src=\"https://avatars2.githubusercontent.com/u/2716831?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [Danyc0](https://github.com/Danyc0)**\n_Thursday Nov 24, 2016 at 01:12 GMT_\n\n----\n\nIt might be worth switching to having both sets in parallel and using a boost converter to get the voltage needed for the RoWind. This was originally discounted because of the inefficiencies in boost regulators as compared to buck regs, but now, thanks to us having a working PCB (Captain Morgan), it opens lots of doors with regards to very efficient boost regulators. This would allow us to better standardise electronics between the boats (with a Do Not Populate on the boost reg for boats which don't have a RoWind).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "naturesyouth",
"comment_id": 333792264,
"datetime": 1507023797000,
"masked_author": "username_0",
"text": "<a href=\"https://github.com/username_0\"><img src=\"https://avatars2.githubusercontent.com/u/7346586?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [username_0](https://github.com/username_0)**\n_Thursday Nov 24, 2016 at 01:15 GMT_\n\n----\n\ni would be tempted to populated it anyway, that way all the boats are spares for other boats, increasing the available redundancy while at a competition, it can always be disabled through software to save power.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "naturesyouth",
"comment_id": null,
"datetime": 1508935613000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 7 | 3,011 | false | false | 3,011 | true |
databricks/spark-redshift | databricks | 357,124,726 | 408 | null | [
{
"action": "opened",
"author": "GoogleAppEngine",
"comment_id": null,
"datetime": 1536136946000,
"masked_author": "username_0",
"text": "\"com.databricks\" %% \"spark-redshift\" % \"3.0.0-preview1\" ,\r\n \"com.amazonaws\" % \"aws-java-sdk\" % \"1.11.397\" is used in my project,\r\n\r\nLine 140 of com.databricks.spark.redshift.Utils.scala `rule.getStatus == BucketLifecycleConfiguration.ENABLED && key.startsWith(rule.getPrefix)` throws NullPointerException because com.amazonaws.services.s3.model.BucketLifecycleConfiguration.Rule.getPrefix returns null,\r\nthis method is deprecated, please use Rule.getLifecycleFilter to get the prefix\r\n\r\nhere is the log\r\n18/09/05 16:15:16 WARN Utils$: An error occurred while trying to read the S3 bucket lifecycle configuration\r\njava.lang.NullPointerException\r\n\tat java.lang.String.startsWith(String.java:1405)\r\n\tat java.lang.String.startsWith(String.java:1434)\r\n\tat com.databricks.spark.redshift.Utils$$anonfun$5.apply(Utils.scala:140)\r\n\tat com.databricks.spark.redshift.Utils$$anonfun$5.apply(Utils.scala:136)\r\n\tat scala.collection.Iterator$class.exists(Iterator.scala:919)\r\n\tat scala.collection.AbstractIterator.exists(Iterator.scala:1336)\r\n\tat scala.collection.IterableLike$class.exists(IterableLike.scala:77)\r\n\tat scala.collection.AbstractIterable.exists(Iterable.scala:54)\r\n\tat com.databricks.spark.redshift.Utils$.checkThatBucketHasObjectLifecycleConfiguration(Utils.scala:136)\r\n\tat com.databricks.spark.redshift.RedshiftRelation.buildScan(RedshiftRelation.scala:106)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$$anonfun$11.apply(DataSourceStrategy.scala:336)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$$anonfun$11.apply(DataSourceStrategy.scala:336)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$$anonfun$pruneFilterProject$1.apply(DataSourceStrategy.scala:384)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$$anonfun$pruneFilterProject$1.apply(DataSourceStrategy.scala:383)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$.pruneFilterProjectRaw(DataSourceStrategy.scala:475)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$.pruneFilterProject(DataSourceStrategy.scala:379)\r\n\tat org.apache.spark.sql.execution.datasources.DataSourceStrategy$.apply(DataSourceStrategy.scala:332)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:62)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$1.apply(QueryPlanner.scala:62)\r\n\tat scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:439)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.Iterator$class.foreach(Iterator.scala:893)\r\n\tat scala.collection.AbstractIterator.foreach(Iterator.scala:1336)\r\n\tat scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157)\r\n\tat scala.collection.AbstractIterator.foldLeft(Iterator.scala:1336)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:74)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:66)\r\n\tat scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.Iterator$class.foreach(Iterator.scala:893)\r\n\tat scala.collection.AbstractIterator.foreach(Iterator.scala:1336)\r\n\tat scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157)\r\n\tat scala.collection.AbstractIterator.foldLeft(Iterator.scala:1336)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:74)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:66)\r\n\tat scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.Iterator$class.foreach(Iterator.scala:893)\r\n\tat scala.collection.AbstractIterator.foreach(Iterator.scala:1336)\r\n\tat scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157)\r\n\tat scala.collection.AbstractIterator.foldLeft(Iterator.scala:1336)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:74)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:66)\r\n\tat scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:77)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2$$anonfun$apply$2.apply(QueryPlanner.scala:74)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:157)\r\n\tat scala.collection.Iterator$class.foreach(Iterator.scala:893)\r\n\tat scala.collection.AbstractIterator.foreach(Iterator.scala:1336)\r\n\tat scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:157)\r\n\tat scala.collection.AbstractIterator.foldLeft(Iterator.scala:1336)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:74)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner$$anonfun$2.apply(QueryPlanner.scala:66)\r\n\tat scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)\r\n\tat scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)\r\n\tat org.apache.spark.sql.catalyst.planning.QueryPlanner.plan(QueryPlanner.scala:92)\r\n\tat org.apache.spark.sql.execution.QueryExecution.sparkPlan$lzycompute(QueryExecution.scala:79)\r\n\tat org.apache.spark.sql.execution.QueryExecution.sparkPlan(QueryExecution.scala:75)\r\n\tat org.apache.spark.sql.execution.QueryExecution.executedPlan$lzycompute(QueryExecution.scala:84)\r\n\tat org.apache.spark.sql.execution.QueryExecution.executedPlan(QueryExecution.scala:84)\r\n\tat org.apache.spark.sql.Dataset.withCallback(Dataset.scala:2774)\r\n\tat org.apache.spark.sql.Dataset.count(Dataset.scala:2404)",
"title": "NullPointerException occurd while trying to read the S3 bucket lifecycle configuration",
"type": "issue"
},
{
"action": "created",
"author": "aymkhalil",
"comment_id": 420387305,
"datetime": 1536692908000,
"masked_author": "username_1",
"text": "+1",
"title": null,
"type": "comment"
}
] | 2 | 2 | 7,608 | false | false | 7,608 | false |
Talend/tdi-studio-se | Talend | 203,406,989 | 953 | {
"number": 953,
"repo": "tdi-studio-se",
"user_login": "Talend"
} | [
{
"action": "opened",
"author": "dmuliyil",
"comment_id": null,
"datetime": 1485445952000,
"masked_author": "username_0",
"text": "",
"title": "[TESB-18799]rename cCXF component to cSOAP",
"type": "issue"
},
{
"action": "created",
"author": "yanbasic",
"comment_id": 277178299,
"datetime": 1486105176000,
"masked_author": "username_1",
"text": "It's OK to merge.\r\n\r\nYi",
"title": null,
"type": "comment"
}
] | 2 | 2 | 23 | false | false | 23 | false |
giantswarm/apiextensions | giantswarm | 286,281,895 | 38 | {
"number": 38,
"repo": "apiextensions",
"user_login": "giantswarm"
} | [
{
"action": "opened",
"author": "r7vme",
"comment_id": null,
"datetime": 1515157014000,
"masked_author": "username_0",
"text": "This fixes issue with glide for aws-operator. There are some broken dependencies, when apiextensions has kubernetes-1.8.2 branch.\r\n \r\n\r\nCI already red in `clientset` branch :/",
"title": "bump dependencies to kubernetes-1.8.5",
"type": "issue"
},
{
"action": "created",
"author": "r7vme",
"comment_id": 355558417,
"datetime": 1515160063000,
"masked_author": "username_0",
"text": "It's just vendor, i'm merging this as right now `glide update` is broken for aws-operator.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "r7vme",
"comment_id": 355578457,
"datetime": 1515165257000,
"masked_author": "username_0",
"text": "Rolled back these changes as they did not help for my problem",
"title": null,
"type": "comment"
}
] | 1 | 3 | 326 | false | false | 326 | false |
PrestaShop/autoupgrade | PrestaShop | 217,619,855 | 59 | {
"number": 59,
"repo": "autoupgrade",
"user_login": "PrestaShop"
} | [
{
"action": "opened",
"author": "xBorderie",
"comment_id": null,
"datetime": 1490718868000,
"masked_author": "username_0",
"text": "",
"title": "Adds missing % to %status%.",
"type": "issue"
},
{
"action": "created",
"author": "maximebiloe",
"comment_id": 290001226,
"datetime": 1490770807000,
"masked_author": "username_1",
"text": "To be merged for `1.7.2` because of string freeze",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlexEven",
"comment_id": 304831483,
"datetime": 1496138273000,
"masked_author": "username_2",
"text": "FYI I have other wording changes coming (soon) for the autoupgrade module.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 123 | false | false | 123 | false |
apollographql/apollo | apollographql | 394,852,434 | 296 | {
"number": 296,
"repo": "apollo",
"user_login": "apollographql"
} | [
{
"action": "opened",
"author": "smolinari",
"comment_id": null,
"datetime": 1546154372000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nEither I was in some lala land and wasn't following this tutorial properly at first, or someone did some changes (which I haven't looked to see if is true or not). At any rate. It's not in the bad shape I thought it was. So, the updates are only minimal.\r\n\r\nScott",
"title": "Update queries.md",
"type": "issue"
},
{
"action": "created",
"author": "evans",
"comment_id": 455297309,
"datetime": 1547752771000,
"masked_author": "username_1",
"text": "@username_0 Woot! Thank you",
"title": null,
"type": "comment"
}
] | 2 | 2 | 296 | false | false | 296 | true |
AguaClara/CEE4540_Master | AguaClara | 331,255,405 | 18 | null | [
{
"action": "opened",
"author": "IanCullings",
"comment_id": null,
"datetime": 1528733596000,
"masked_author": "username_0",
"text": "Here are a bunch of areas I thought could be edited on my initial read through:\r\n* When listing the assumptions for the Bernoulli equation, you state that \"friction by viscous forces must be negligible\" but never define exactly what that means. Consider adding a sentence or two to define that and explain generally when that is true or not\r\n* Under the energy equation where you include terms for energy gain/loss from pumps and turbines, does that mean only pumps and turbines, or any system that adds or removes energy from the fluid mechanically? Consider elaborating on that slightly\r\n* Consider adding a diagram showing friction and shear in the major losses section\r\n* Define laminar and turbulent flow regimes before major losses section\r\n* You use the continuity equation many times throughout, but never really define or explain why it is valid\r\n* In the orifice section, you state that the equation is for a horizontal orifice, but the picture you use to explain it shows a vertical orifice.\r\n\r\nFeel free to ask me for clarifications!",
"title": "Suggested edits for Fluid Review",
"type": "issue"
},
{
"action": "created",
"author": "juanchon998",
"comment_id": 396573073,
"datetime": 1528806839000,
"masked_author": "username_1",
"text": "Thanks for the comments Ian, they're all great suggestions that I will incorporate later today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "juanchon998",
"comment_id": 396573185,
"datetime": 1528806866000,
"masked_author": "username_1",
"text": "Please keep leaving detailed issues like this as you read through more documents, they're incredibly helpful!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isakaminsky",
"comment_id": 396696295,
"datetime": 1528829629000,
"masked_author": "username_2",
"text": "*introduce variable for head earlier maybe?\r\n*introduce control volumes and streamlines",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ananya-gangadhar",
"comment_id": 397388713,
"datetime": 1528999914000,
"masked_author": "username_3",
"text": "- For Laminar and Turbulent Flow, specify the approximate value/range of the Reynold's number for each type of flow in the second paragraph\r\n\r\n- Streamlines and Control Volumes, second paragraph: \"Imagine\" instead of \"image\"?\r\n\r\n- First image in Streamlines and Control Volumes doesn't load",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "IanCullings",
"comment_id": 398415999,
"datetime": 1529417983000,
"masked_author": "username_0",
"text": "@username_1 more suggestions after another readthrough:\r\n* Is this textbook aimed just for Cornell students or for anyone interested in AguaClara plant design? If you're aiming for the latter, I would remove references to CEE 3310 and replace with \"your fluid mechanics course\" or something similar\r\n* I'm getting an error with the latex equation in the head loss trick section, above the words \"We now get\"",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "juanchon998",
"comment_id": null,
"datetime": 1529701640000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "juanchon998",
"comment_id": 399582365,
"datetime": 1529701640000,
"masked_author": "username_1",
"text": "Kamino closed and cloned this issue to AguaClara/Textbook",
"title": null,
"type": "comment"
}
] | 4 | 8 | 2,095 | false | false | 2,095 | true |
alibaba/canal | alibaba | 333,566,662 | 702 | null | [
{
"action": "opened",
"author": "uniorder",
"comment_id": null,
"datetime": 1529396528000,
"masked_author": "username_0",
"text": "`connector.subscribe(\"databaseName.tableName\");`\r\n这段代码我指定了filter，可还是能够收到所有表的binlog数据，请问是不是为哪里配置有问题？",
"title": "指定Filter不起作用，还是能够获取到全库的监听数据。",
"type": "issue"
},
{
"action": "created",
"author": "agapple",
"comment_id": 398958990,
"datetime": 1529549195000,
"masked_author": "username_1",
"text": "搜索一下历史issue",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "threedays163",
"comment_id": 400560123,
"datetime": 1530081642000,
"masked_author": "username_2",
"text": "才能用。\".\"在正则中代表任意字符。“\\.”含义才是点，由于单个反斜杠代表转义，因此也需要被转义，所以就变成上面那个样子了",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "agapple",
"comment_id": 409159714,
"datetime": 1533029866000,
"masked_author": "username_1",
"text": "看一下 FAQ : https://github.com/alibaba/canal/wiki/FAQ",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "agapple",
"comment_id": null,
"datetime": 1533029867000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 222 | false | false | 222 | false |
amalgam8/amalgam8 | amalgam8 | 198,838,675 | 456 | {
"number": 456,
"repo": "amalgam8",
"user_login": "amalgam8"
} | [
{
"action": "opened",
"author": "craigyam",
"comment_id": null,
"datetime": 1483572859000,
"masked_author": "username_0",
"text": "The -i buildflag tries to install dependencies into the pkg directory.\r\nThis requires root auth. The flag is not necessary when building the\r\ncli for other OSes.",
"title": "Remove the buildflags from the non-native cli build command.",
"type": "issue"
},
{
"action": "created",
"author": "rshriram",
"comment_id": 270946988,
"datetime": 1483721370000,
"masked_author": "username_1",
"text": "Please don't merge this yet. The changes are much more than just the CLI",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rshriram",
"comment_id": 270953903,
"datetime": 1483723094000,
"masked_author": "username_1",
"text": "Refer to PR #461 for a more comprehensive fix.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 279 | false | false | 279 | false |
prismicio/php-kit | prismicio | 69,033,028 | 106 | {
"number": 106,
"repo": "php-kit",
"user_login": "prismicio"
} | [
{
"action": "opened",
"author": "tremby",
"comment_id": null,
"datetime": 1429228684000,
"masked_author": "username_0",
"text": "The link resolver is now passed to the HTML serializer, as the third parameter. This allows HTML serializers to be a little more flexible and reusable.\n\nThe type of the HTML serializer is now explicitly described as \"callable\", since this shows that it can be not only a lambda but also any other kind of callable like a string function name, an array of class name and method or object and method or an object which implements the __invoke method.\n\nThe HTML serializer is now passed to the method which turns spans within blocks into HTML as well as the method which turns blocks into HTML. This allows finer control.\n\nHowever, since internally blocks and spans are currently turned into HTML quite differently (blocks with string manipulation and spans with the DOM) an implementation of HTML serializer needs to handle each type differently. In particular, it must return a string of HTML if the $element passed to it is an instance of BlockInterface and a DOMElement if $element is an instance of SpanInterface. As before, it can also return null to skip this element and defer to the built-in serialization routines.\n\nSome documentation has been added to this effect.",
"title": "Allow HTML serializer to also work on spans within blocks",
"type": "issue"
},
{
"action": "created",
"author": "tremby",
"comment_id": 93865034,
"datetime": 1429228921000,
"masked_author": "username_0",
"text": "Obviously it's not ideal that the HTML serializer needs to work in two different ways. One solution would be to change over to using DOM across the board to build HTML. If that sounds good I may find some time to implement it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 101845222,
"datetime": 1431558742000,
"masked_author": "username_0",
"text": "Any word?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 102326789,
"datetime": 1431680499000,
"masked_author": "username_1",
"text": "Hi Bart,\r\n\r\nYes, we need to have the HTMLSerializer work with spans too. That's how it works in other kits. I've recently made a few bug fixes to the way serialization works in the PHP kit, so I need to adapt the fix to have spans support in the HTML Serializer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 103477311,
"datetime": 1432040585000,
"masked_author": "username_1",
"text": "That's fixed in 1.5.8 - thank you for your help!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 103664078,
"datetime": 1432068597000,
"masked_author": "username_0",
"text": "I guess I didn't stress it before, but one of the important things in this PR was that the link resolver was passed to the HTML serializer. I just made a new PR for that, #108.\r\n\r\nI'm surprised you moved away from using the DOM, since you're potentially introducing non-escaping errors. For instance if a special character eg < or \" is in a label, it won't be escaped and could cause problems. (Or an ampersand, though most browsers will handle these ok.)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 103798583,
"datetime": 1432107982000,
"masked_author": "username_1",
"text": "Hi,\r\n\r\nThe DOM code wasn't really rock-solid in the sense that generating the HTML for StructuredText (in particular the spans from their position) is tricky if you consider they can be nested. While the DOM gives the guarantee that the generated HTML is valid, it doesn't guarantee that it is functionally correct, e.g. doesn't skip a span.\r\n\r\nOverall as you can see in the code the algorithm is a bit complex, and it's easier to maintain if we have roughly the same algorithm in all languages.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 103799995,
"datetime": 1432108398000,
"masked_author": "username_0",
"text": "Can you show me an example of where it didn't work? Is there a new test\ncase which the old code failed, for example? I'd like to see where I went\nwrong. I thought I covered the case of nested spans.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 103803223,
"datetime": 1432109216000,
"masked_author": "username_1",
"text": "We had cases where the spans positions got out of sync, depending on how your spans were organized..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 103803409,
"datetime": 1432109245000,
"masked_author": "username_1",
"text": "It wasn't your pull request, but the code we had in our repository that was using DOM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 103803653,
"datetime": 1432109339000,
"masked_author": "username_0",
"text": "Yes, I wrote that code, or at least the original version of it. Can you\ngive an example case?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 103805541,
"datetime": 1432109996000,
"masked_author": "username_1",
"text": "I believe it was on this content: http://pastebin.com/vyg2ixhs",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 103809809,
"datetime": 1432111304000,
"masked_author": "username_0",
"text": "Thanks; I'll post-mortem my code tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tremby",
"comment_id": 104043050,
"datetime": 1432156904000,
"masked_author": "username_0",
"text": "Actually, you broke it in https://github.com/prismicio/php-kit/commit/1e52533d880f705a3ba06c0a26e8c03b1629b41d -- spans lined up perfectly before that commit, in the JSON you linked, and not after.\r\n\r\nIn that commit you reused some of my DOM code but made one subtle error: you changed a call to `htmlspecialchars` (old line https://github.com/prismicio/php-kit/commit/1e52533d880f705a3ba06c0a26e8c03b1629b41d#diff-afb4af17c86cb37f05bd052b76265f67L345) to `htmlentities` (new line https://github.com/prismicio/php-kit/commit/1e52533d880f705a3ba06c0a26e8c03b1629b41d#diff-afb4af17c86cb37f05bd052b76265f67R317).\r\n\r\nWhen you escape more than the bare minimum (`htmlspecialchars` escapes much less by default than `htmlentities`) and pass into `createElement`, it automatically makes not just one textNode inside as the rest of my code was expecting, but also an entity reference node for each entity. My code didn't support looking through these. I should have clarified that in the original code or, better, explicitly made and inserted the text nodes (since doing it that way the escaping is automatic).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erwan",
"comment_id": 104165277,
"datetime": 1432193546000,
"masked_author": "username_1",
"text": "Thank you for finding where the bug came from!",
"title": null,
"type": "comment"
}
] | 2 | 15 | 4,396 | false | false | 4,396 | false |
strongloop/v4.loopback.io | strongloop | 381,296,106 | 56 | null | [
{
"action": "opened",
"author": "dhmlau",
"comment_id": null,
"datetime": 1542308334000,
"masked_author": "username_0",
"text": "## Description / Steps to reproduce / Feature proposal\r\n[API Test and Monitor](http://ibm.biz/apitest) has launched. To be part of the API lifecycle story, @jjtang1 recommended to the reference of Test and Monitor in the LB4 web site.\r\n\r\n### Acceptance Criteria\r\n- [ ] Add a new navbar item called `Test Your APIs` with url http://ibm.biz/apitest\r\n - need to get all the pages in v4.loopback.io repo updated because we're replicating the navbar in every page.",
"title": "Add API Test and Monitor on navbar",
"type": "issue"
}
] | 1 | 1 | 462 | false | false | 462 | false |
4ian/GDevelop | null | 359,266,147 | 634 | {
"number": 634,
"repo": "GDevelop",
"user_login": "4ian"
} | [
{
"action": "opened",
"author": "blurymind",
"comment_id": null,
"datetime": 1536710265000,
"masked_author": "username_0",
"text": "This new command allows gdevelop's newIde to automatically scan the game project folder for new resources and if they havent been added to the resource list, add them. \r\n\r\nIt is of course optional and it does not in any way negate gdevelop's current design.\r\n\r\nIt is useful in some cases :)\r\n",
"title": "Add ability to scan for image resources",
"type": "issue"
},
{
"action": "created",
"author": "4ian",
"comment_id": 420561317,
"datetime": 1536741304000,
"masked_author": "username_1",
"text": "Good job on making this, I will check this :)\r\n\r\nFor the button position, I think we could have it as a toolbar option. In fact in GD4, there was a button in the ribbon (using this image https://github.com/username_1/GDevelop/blob/master/Binaries/Output/Release_Windows/res/ribbon_default/deleteunknown32.png) that was used to scan the project and delete useless resources.\r\n(Would be interesting to have this feature later too in GD5, it's a matter of calling `gd.ProjectResourcesAdder.getAllUselessImages` and then showing a dialog to let the user check/uncheck the images to be really removed).\r\nI think it could be interested to have the \"scan project for files\" button in the toolbar too. The only thing is that we don't have an icon for this, but we could mix the [search icon](https://github.com/username_1/GDevelop/blob/master/Binaries/Output/Release_Windows/res/ribbon_default/search32.png) with the [image icon](https://github.com/username_1/GDevelop/blob/master/Binaries/Output/Release_Windows/res/ribbon_default/image32.png) (the search would be small and on the bottom-right corner).\r\n\r\nI mention this because this feature is a bit the opposite of this one, so would be great for the user to have both. We can also have both in the context menu if you're not convinced that the toolbar is a good position.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 420617624,
"datetime": 1536752511000,
"masked_author": "username_1",
"text": "I'm not sure about this, you would have to add this to every single exporter? Also I think this is something that should be done before export.\r\n\r\nExport dialog is done for export, and option related to this, but I think resource management should stay in the Resources Editor.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 420620620,
"datetime": 1536753254000,
"masked_author": "username_0",
"text": "Ah ok. I will add it to the resource manager first of course :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 420621955,
"datetime": 1536753559000,
"masked_author": "username_1",
"text": "Let's start by a first inside the resource manager, then we'll see later if we can improve the export dialog to add an optional \"Export configuration\" or \"Export settings\" dialog, where you can choose to check this automatic optimization and others (like minification of the code in the feature, etc...).\r\n\r\nI think this will need a new dialog so that's why I'm telling it can be done later :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 420622309,
"datetime": 1536753638000,
"masked_author": "username_0",
"text": "Good point. :) I will go for the lower hanging fruits.\r\nMinify option would be quite nice to have. I wonder what the impact on performance would be after we add those :}",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 420622728,
"datetime": 1536753734000,
"masked_author": "username_1",
"text": "Performance won't change a lot - though minification could help a bit but nothing noticeable (at least on desktop).\r\nFor games that are on websites, this will help reduce their size, which can be very important though for avoiding players waiting too long/abandoning after a few seconds of loading.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 420623061,
"datetime": 1536753806000,
"masked_author": "username_0",
"text": "Mobile games on the app stores also have a limit of 50mb file size I think. Not sure if it was increased in recent years",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 420831272,
"datetime": 1536794812000,
"masked_author": "username_0",
"text": "I need some more time to add relative path names to piskel saving and it is almost ready :) \r\nWill try to finish it tomorrow. The code in piskel can do with some clean up",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 420965600,
"datetime": 1536835693000,
"masked_author": "username_0",
"text": "Hi @username_1 any idea how to call ProjectResourcesAdder with js?\r\nI can see its in the gd class",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 420992396,
"datetime": 1536842499000,
"masked_author": "username_1",
"text": "Yep, it's because if some parameter is missing when calling one method of GDJS, very bad thing will happen (memory corruption basically, crash at best, silent error then crash later at worst). In case of doubt you can double check in the file that I've linked what are the arguments :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 421102663,
"datetime": 1536862617000,
"masked_author": "username_0",
"text": "@username_1 thank you for the link :)\r\nI pushed the fix commits. It's ready for review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 421166545,
"datetime": 1536875919000,
"masked_author": "username_0",
"text": "Thank you @username_1 .All changes now applied :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 421173406,
"datetime": 1536877887000,
"masked_author": "username_0",
"text": "@username_1 I tried to log into it a few days ago and it gave me 2 builds per day and the prices :) \r\nI think I had it for a while, but something happened\r\n\r\nThank you for taking the time to review and explain some things. I learn something new every time :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 421174834,
"datetime": 1536878324000,
"masked_author": "username_1",
"text": "Are you using username_0 at gmail ? This should have a GDevelop Pro subscription.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 421176572,
"datetime": 1536878870000,
"masked_author": "username_0",
"text": "@username_1 I am.. this is strange. It's showing it as pro now. \r\nSome times maybe it doesn't sign in properly?\r\nNot sure what happened before :) \r\n\r\nIn any case, thank you for the pro account. Gdevelop is awesome!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 421176825,
"datetime": 1536878956000,
"masked_author": "username_1",
"text": "It's possible that the authentication expires after some time, so you weren't logged anymore. Would have to check Firebase (which is used to handle authentication) documentation about this :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blurymind",
"comment_id": 421178139,
"datetime": 1536879401000,
"masked_author": "username_0",
"text": "I think it happened after I signed in. But you are right about authentication expiring. It did expire and when I logged back in the pro was lost for a bit. I haven't tested the export extensively yet, but intend to :D \r\n\r\nWas thinking of trying android export with @Wend1go 's recent sensor extension",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "4ian",
"comment_id": 421260922,
"datetime": 1536910997000,
"masked_author": "username_1",
"text": "Sure, give it a try! :) I still have improvements to do like fullscreen on Android",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zatsme",
"comment_id": 421263108,
"datetime": 1536911550000,
"masked_author": "username_2",
"text": "Are you doing anything with sound on android? If I have sound in preview at the volume I like and then export, it's distorted and loud on android. I'm not needing to export to android right now, but this needs looking at I think.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zatsme",
"comment_id": 421276042,
"datetime": 1536914566000,
"masked_author": "username_2",
"text": "I'd thought it was a known issue... I'll try to experiment when I can but I'd be surprised if its just me 😳",
"title": null,
"type": "comment"
}
] | 3 | 21 | 5,154 | false | false | 5,154 | true |
shader-slang/slang | shader-slang | 287,224,323 | 360 | null | [
{
"action": "opened",
"author": "csyonghe",
"comment_id": null,
"datetime": 1515530642000,
"masked_author": "username_0",
"text": "```\r\nstruct S<T>{}\r\n\r\nvoid f<T>(S<T> s);\r\nvoid main()\r\n{\r\n f(S<T>());\r\n}\r\n```",
"title": "Deduce generic type argument from a argument of generic type",
"type": "issue"
},
{
"action": "created",
"author": "tfoleyNV",
"comment_id": 356689045,
"datetime": 1515608121000,
"masked_author": "username_1",
"text": "Would be nice to tackle this and #354 at the same time.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 135 | false | false | 135 | false |
lucas-clemente/quic-go | null | 348,282,660 | 1,470 | {
"number": 1470,
"repo": "quic-go",
"user_login": "lucas-clemente"
} | [
{
"action": "opened",
"author": "marten-seemann",
"comment_id": null,
"datetime": 1533641789000,
"masked_author": "username_0",
"text": "Fixes #1452. Depends on #1468.",
"title": "use retransmissions as TLP packets",
"type": "issue"
}
] | 2 | 2 | 30 | false | true | 30 | false |
istornz/iPokeGo | null | 173,842,691 | 293 | null | [
{
"action": "opened",
"author": "lemupuffy",
"comment_id": null,
"datetime": 1472496157000,
"masked_author": "username_0",
"text": "Updated to the new version and cant see any pokemon.",
"title": "Updated to new version, cant see any pokemon",
"type": "issue"
},
{
"action": "created",
"author": "istornz",
"comment_id": 243222143,
"datetime": 1472497428000,
"masked_author": "username_1",
"text": "What is your version ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lemupuffy",
"comment_id": 243241568,
"datetime": 1472501687000,
"masked_author": "username_0",
"text": "Go app 2.0, iphone 5 ios 9.0.2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lemupuffy",
"comment_id": 243309770,
"datetime": 1472521710000,
"masked_author": "username_0",
"text": "Go radar app is 2.0 iphone 5 running ios 9.0.2\n\nSent from my iPhone\n\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "istornz",
"comment_id": 243389823,
"datetime": 1472550649000,
"masked_author": "username_1",
"text": "@szlyrhjm GO Radar is not my app. \r\nPlease contact : https://twitter.com/miniroo321",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "istornz",
"comment_id": null,
"datetime": 1472550650000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 257 | false | false | 257 | false |
Ogeon/palette | null | 354,818,044 | 116 | null | [
{
"action": "opened",
"author": "Ogeon",
"comment_id": null,
"datetime": 1535475235000,
"masked_author": "username_0",
"text": "The README.md files are supposed to be linked to the one in the project root, but something has made the link disappear from git, somehow, so now they are out of sync. This should be fixed.",
"title": "Fix the readme symlinks",
"type": "issue"
}
] | 2 | 2 | 189 | false | true | 189 | false |
mbj4668/pyang | null | 352,940,814 | 421 | {
"number": 421,
"repo": "pyang",
"user_login": "mbj4668"
} | [
{
"action": "opened",
"author": "yang-catalog",
"comment_id": null,
"datetime": 1534942393000,
"masked_author": "username_0",
"text": "",
"title": "Improve YANG parsing for xPaths (when, must) substatements",
"type": "issue"
},
{
"action": "created",
"author": "mbj4668",
"comment_id": 415022644,
"datetime": 1534942716000,
"masked_author": "username_1",
"text": "This looks very useful. Could you also add test cases that demonstrate / test these new capabilities?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yang-catalog",
"comment_id": 420289760,
"datetime": 1536675315000,
"masked_author": "username_0",
"text": "hi, @username_1 could you please let me know what kind of error is that in the travis? I have no idea how to fix that. thank you in advance.\r\n\r\nMiroslav K.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbj4668",
"comment_id": 420291527,
"datetime": 1536675639000,
"masked_author": "username_1",
"text": "It checks that the test doesn't leave any temporary files behind, I think.\n\n$ git ls-files . --exclude-standard --others | tee \"$TMP\"\ntest/test_xpath/temp.txt\n\nBTW. in all error strings etc, \"xpath\" should be spelled \"XPath\". That's\nthe official name. No \"Xpath\", \"XPATH\" or \"xPath\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yang-catalog",
"comment_id": 420306939,
"datetime": 1536678296000,
"masked_author": "username_0",
"text": "Ok got it thx",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbj4668",
"comment_id": 420633390,
"datetime": 1536756089000,
"masked_author": "username_1",
"text": "I just realized that you treat a missing node as a XPATH_SYNTAX_ERROR. This is unfortunate, and not really correct. It is strictly speaking not an error to refer to a non-existing node. It would be best to define a new error, perhaps XPATH_MISSING_NODE for these. By default, XPATH_MISSING_NODE should be a warning, not an error. By separating these thing in our code, we give the user more flexibility.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yang-catalog",
"comment_id": 420921029,
"datetime": 1536826111000,
"masked_author": "username_0",
"text": "Done",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbj4668",
"comment_id": 421053102,
"datetime": 1536853309000,
"masked_author": "username_1",
"text": "After merging, I fixed the code to align with the 80 characters line length convention, and cleaned the test case a bit.\r\n\r\nBut I'm not happy about the XPATH_MISSING_NODE text; it used to say:\r\nietf-netconf-notifications@2012-02-06.yang:286: warning: XPath node ../confirm-event != 'timeout' is missing\r\n\r\nit now says:\r\n\r\nietf-netconf-notifications@2012-02-06.yang:286: warning: XPath for \"../confirm-event != 'timeout'\" does not exist\r\n\r\nwhich is also not good. it should say:\r\nThe node ../confirm-event is nout found\r\n\r\nor soemthinh similar. Is this something you can look at?",
"title": null,
"type": "comment"
}
] | 3 | 9 | 1,837 | false | true | 1,546 | true |
norcross/gravity-tooltips | null | 53,462,379 | 15 | null | [
{
"action": "opened",
"author": "thepofo",
"comment_id": null,
"datetime": 1420501055000,
"masked_author": "username_0",
"text": "When using the file upload field, the span including the tooltip icon is placed inside the ginput_container, even inside the multifile upload div. See screenshot\r\n\r\n\r\n\r\nThis is how it is done using the other fields.\r\n\r\n\r\nThat way positioning the icon next to the label is impossible",
"title": "Misplacement of the tooltip when using file upload fields",
"type": "issue"
},
{
"action": "created",
"author": "osakagreg",
"comment_id": 121064029,
"datetime": 1436822638000,
"masked_author": "username_1",
"text": "Try this... Edit lib/front.php\r\n\r\nfind: static function render_tooltip_single( $content, $tooltip ) {\r\n\r\nand replace the line:\r\n\r\n\t\treturn GF_Tooltips::str_replace_limit( '</div>', '</div>' . $icon, $content );\r\n\r\nwith:\r\n\r\n return GF_Tooltips::str_replace_limit( '</label>', '</label>' . $icon, $content );\r\n\r\nI downloaded this today (7/13/2015) and had the same problem, Making this modification (above) corrected it. I haven't looked through the code enough to see if it generates problems elsewhere, but so far so good.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "norcross",
"comment_id": 122597639,
"datetime": 1437254399000,
"masked_author": "username_2",
"text": "I'm actually overhauling this to use a pure CSS method, with a lot better control over filtering and layout, so keep an eye on it. otherwise you can patch your version if need be.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "norcross",
"comment_id": 122663826,
"datetime": 1437315098000,
"masked_author": "username_2",
"text": "closing this for now. the new output is showing up correctly in my testing, so it may be fixed or possibly an issue with how your output is done. in addition, you can now filter the field on a per-form or per-field basis",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "norcross",
"comment_id": null,
"datetime": 1437315098000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 1,497 | false | false | 1,497 | false |
babel/babel | babel | 334,527,838 | 8,207 | {
"number": 8207,
"repo": "babel",
"user_login": "babel"
} | [
{
"action": "opened",
"author": "zwhitchcox",
"comment_id": null,
"datetime": 1529592344000,
"masked_author": "username_0",
"text": "| Q | A <!--(Can use an emoji 👍) -->\r\n| ------------------------ | ---\r\n| Fixed Issues? | No Issue Created\r\n| Patch: Bug Fix? | No\r\n| Major: Breaking Change? | No\r\n| Minor: New Feature? | Yes\r\n| Tests Added + Pass? | Yes\r\n| Documentation PR | No\r\n| Any Dependency Changes? | Yes\r\n| License | MIT\r\n\r\nThis is a preset for the popular state management library mobx.",
"title": "add babel-preset-mobx",
"type": "issue"
},
{
"action": "created",
"author": "zwhitchcox",
"comment_id": 399140230,
"datetime": 1529594173000,
"masked_author": "username_0",
"text": "I was thinking to signify its compatibility with the current version, like `babel-preset-react`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zwhitchcox",
"comment_id": 399223873,
"datetime": 1529611043000,
"masked_author": "username_0",
"text": "Oh ok, my mistake, I will just put it in a separate repo",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zwhitchcox",
"comment_id": 399452883,
"datetime": 1529676126000,
"masked_author": "username_0",
"text": "So, quick question...if I am making this in another repo, do I need the @ sign to show that it's babel 7? Like should I change the name at all, or just push to my current repo with the new version, even though it will break the previous versions?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "existentialism",
"comment_id": 399454222,
"datetime": 1529676377000,
"masked_author": "username_1",
"text": "@username_0 nope, the `@babel/*` just means it belongs to our organization.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 914 | false | false | 914 | true |
z00k/vkbotphp | null | 59,292,651 | 1 | null | [
{
"action": "opened",
"author": "MetaDone",
"comment_id": null,
"datetime": 1425070326000,
"masked_author": "username_0",
"text": "в файле /autoupdate.php 58 и следующие строки - в моменте получения сообщения прописано http://bot.mew.su/, из-за чего при установке называет себя Ларисой",
"title": "вынесите пожалуйста в конфиг адрес бота",
"type": "issue"
},
{
"action": "created",
"author": "z00k",
"comment_id": 76554727,
"datetime": 1425164499000,
"masked_author": "username_1",
"text": "Скорее всего вы не вписали ID своего бота из-за чего он и думает, что он - Лариса.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "z00k",
"comment_id": 76554815,
"datetime": 1425164540000,
"masked_author": "username_1",
"text": "config.sample.php -> 14 строка",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MetaDone",
"comment_id": 76679113,
"datetime": 1425287641000,
"masked_author": "username_0",
"text": "autoupdate.php\r\n $mes = file_get_contents('http://bot.mew.su/sp.php?session=' . $row['chatid'] . '&text=' . urlencode($vkmessage));\r\nвот здесь привязка к http://bot.mew.su/, про нее говорил. После того как переписал адреса в файле на адрес, где лежит мой бот, все корректно заработало",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arnidan",
"comment_id": 76680057,
"datetime": 1425288096000,
"masked_author": "username_2",
"text": "Я потиху переделываю. Потому что автор, скорее всего, несильно знаком с PHP",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "z00k",
"comment_id": 78056376,
"datetime": 1425995525000,
"masked_author": "username_1",
"text": "Ждите в новой версии массу исправлений и поддержку antigate.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "z00k",
"comment_id": null,
"datetime": 1425995525000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 7 | 685 | false | false | 685 | false |
teamhephy/controller | teamhephy | 306,970,751 | 28 | null | [
{
"action": "opened",
"author": "Cryptophobia",
"comment_id": null,
"datetime": 1521567806000,
"masked_author": "username_0",
"text": "_From @rvadim on March 7, 2017 7:36_\n\nHello,\r\nthank you for you work.\r\nWe have a problem with zero downtime deployment in deis 2, due to http://stackoverflow.com/questions/40545581/do-kubernetes-pods-still-receive-requests-after-receiving-sigterm\r\nI tested it with gatling on different applications(pull, config:set etc) and get 5 - 100 errors (502) under 100 RPS\r\nWe workaround this issue in native k8s interface with preStop hook /bin/sh -c \"sleep 5\", but i don't know how to fix this in deis controller, due to for example images with golang binary from scratch don't have any shell.\r\nHave anyone an idea how to fix this?\r\n\r\nAdditional info:\r\n- https://kubernetes.io/docs/user-guide/pods/#termination-of-pods\r\n\r\nThank you.\n\n_Copied from original issue: deis/controller#1254_",
"title": "Some portion of failed requests (502) during application deployment (regression since deis 1.x)",
"type": "issue"
}
] | 1 | 1 | 777 | false | false | 777 | false |
quarkusio/quarkus | quarkusio | 421,050,741 | 1,487 | null | [
{
"action": "opened",
"author": "dmlloyd",
"comment_id": null,
"datetime": 1552573679000,
"masked_author": "username_0",
"text": "Substrate VM uses named semaphores as a concurrency control primitive in its C helper for signal handling. This means that our native images will fail to start in that environment.\r\n\r\nI suggested to use unnamed semaphores but these are not supported on Darwin. Another idea is to use pthread mutexes or similar.\r\n\r\nTo workaround we'd have to rip out our signal handlers and also disable the couple of signal handlers that Substrate introduces. We might want a build option to do this.",
"title": "Quarkus native images will not run in AWS",
"type": "issue"
},
{
"action": "created",
"author": "dmlloyd",
"comment_id": 472885035,
"datetime": 1552573747000,
"masked_author": "username_0",
"text": "See also: https://github.com/oracle/graal/issues/841 https://github.com/oracle/graal/blob/master/substratevm/src/com.oracle.svm.native.libchelper/src/cSunMiscSignal.c#L113",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drissamri",
"comment_id": 479209683,
"datetime": 1554240304000,
"masked_author": "username_1",
"text": "Since that issue is fixed, is there any chance AWS Lambda support will happen soon @username_0?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmlloyd",
"comment_id": 479216796,
"datetime": 1554241407000,
"masked_author": "username_0",
"text": "Once GraalVM RC15 is released, then that should solve this. But I think @username_2 has AWS Lambda more or less functional at this point either way.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drissamri",
"comment_id": 479230380,
"datetime": 1554243571000,
"masked_author": "username_1",
"text": "Any idea where I can find the working example? I'd like to demo this at our company asap to get people experimenting 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "evanchooly",
"comment_id": 479272490,
"datetime": 1554251785000,
"masked_author": "username_2",
"text": "I have a working implementation. I filed PR #1822 today. There's an unexpected failing test in there I'll have to track down tomorrow morning. I have a working example in a git repo on my drive. I'll clean it up and push it to github tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gsmet",
"comment_id": 553562639,
"datetime": 1573673507000,
"masked_author": "username_3",
"text": "I think this has been fixed already.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gsmet",
"comment_id": null,
"datetime": 1573673507000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 8 | 1,300 | false | false | 1,300 | true |
posativ/isso | null | 204,944,527 | 303 | {
"number": 303,
"repo": "isso",
"user_login": "posativ"
} | [
{
"action": "opened",
"author": "MorrisJobke",
"comment_id": null,
"datetime": 1486057080000,
"masked_author": "username_0",
"text": "Before:\r\n\r\n<img width=\"674\" alt=\"bildschirmfoto 2017-02-02 um 11 35 12\" src=\"https://cloud.githubusercontent.com/assets/245432/22560944/fea11650-e93b-11e6-8853-bd854a0764bf.png\">\r\n\r\nAfter:\r\n\r\n<img width=\"698\" alt=\"bildschirmfoto 2017-02-02 um 11 34 51\" src=\"https://cloud.githubusercontent.com/assets/245432/22560951/03ad2404-e93c-11e6-9409-1f4e49499015.png\">\r\n\r\ncc @username_2",
"title": "Highlight links by underline in comments",
"type": "issue"
},
{
"action": "created",
"author": "mdosch",
"comment_id": 277434522,
"datetime": 1486204643000,
"masked_author": "username_1",
"text": "Actually for me links are properly highlighted according to my blogs css.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MorrisJobke",
"comment_id": 277486953,
"datetime": 1486252512000,
"masked_author": "username_0",
"text": "@username_1 this pull request only specifies the rule to only be applied to the header (vor 2 Monaten) and allows an easier theming according the other styles that are loaded on the page. So actually it doesn't add a rule for underline but removes the one that overwrites the default rule for links",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "posativ",
"comment_id": 278266730,
"datetime": 1486543572000,
"masked_author": "username_2",
"text": "Looks good to me. Thanks!",
"title": null,
"type": "comment"
}
] | 3 | 4 | 886 | false | false | 886 | true |
iscoe/dragonfly | iscoe | 381,660,631 | 15 | {
"number": 15,
"repo": "dragonfly",
"user_login": "iscoe"
} | [
{
"action": "opened",
"author": "cabishop",
"comment_id": null,
"datetime": 1542384204000,
"masked_author": "username_0",
"text": "",
"title": "Multi token update",
"type": "issue"
},
{
"action": "created",
"author": "cash",
"comment_id": 444627407,
"datetime": 1544040432000,
"masked_author": "username_1",
"text": "You aren't using semi-colons at the end of your lines. While JavaScript can infer where the semi-colons should go so they are not strictly required, leaving them out can lead to odd bugs. I prefer to use them.\r\n\r\nHere is an example:\r\n```JavaScript\r\nconst a = 1\r\nconst b = 2\r\nconst c = a + b\r\n(a + b).toString()\r\n```\r\n\r\nThat results in an error because JavaScript thinks the 3rd line is `const c = a + b(a + b).toString()`",
"title": null,
"type": "comment"
}
] | 2 | 2 | 421 | false | false | 421 | false |
ManageIQ/ui-components | ManageIQ | 286,333,603 | 228 | {
"number": 228,
"repo": "ui-components",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "eclarizio",
"comment_id": null,
"datetime": 1515168976000,
"masked_author": "username_0",
"text": "The problem is that when creating or editing dialogs, if you add a new field, the field is not saved before the associations are created, and so there is no id to send up. Therefore we have to send up the name and have the backend handle the association creation by name instead.\r\n\r\nThis will need to be combined with [this main repo PR](https://github.com/ManageIQ/manageiq/pull/16753) in order to fully fix the bug.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1518942\r\n\r\n@miq-bot add_label gaprindashvili/yes, bug\r\n\r\n@romanblanco @username_1 Please review",
"title": "Use '.name' instead of '.id' for refresh field list",
"type": "issue"
},
{
"action": "created",
"author": "himdel",
"comment_id": 355597037,
"datetime": 1515169376000,
"masked_author": "username_1",
"text": "All those `<dialog-editor-modal-field-template...>` need a closing tag..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "himdel",
"comment_id": 355597577,
"datetime": 1515169494000,
"masked_author": "username_1",
"text": "Nice DRYing up :+1: \r\nLooks like what actually changes is..\r\n\r\n```diff\r\n-ng-options=\"dynamicField.id as dynamicField.label for dynamicField in vm.modalData.dynamicFieldList\"\r\n+ng-options=\"dynamicField.name as dynamicField.label for dynamicField in vm.modalData.dynamicFieldList\"\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "himdel",
"comment_id": 356288149,
"datetime": 1515505635000,
"masked_author": "username_1",
"text": "@miq-bot add_label gaprindashvili/backported\r\n@miq-bot remove_label gaprindashvili/yes\r\n\r\nThis was released in manageiq-ui-components 1.0.5, backported to gaprindashvili via ManageIQ/manageiq-ui-classic#3203 .",
"title": null,
"type": "comment"
}
] | 3 | 6 | 1,628 | false | true | 1,120 | true |
alpheios-project/components | alpheios-project | 385,796,332 | 296 | {
"number": 296,
"repo": "components",
"user_login": "alpheios-project"
} | [
{
"action": "opened",
"author": "kirlat",
"comment_id": null,
"datetime": 1543506114000,
"masked_author": "username_0",
"text": "This is a companion request for alpheios-project/webextension#173",
"title": "Support for frames in Safari",
"type": "issue"
}
] | 2 | 2 | 2,281 | false | true | 65 | false |
dask/dask-jobqueue | dask | 363,073,069 | 159 | null | [
{
"action": "opened",
"author": "guillaumeeb",
"comment_id": null,
"datetime": 1537781804000,
"masked_author": "username_0",
"text": "I think that the online documentation we provide needs some refactoring:\r\n\r\n- Split the index landing page that is too big into smaller content.\r\n- Change the toctree, add some captions, maybe the classical _Getting started_, _Configuration_, _Develp_\r\n- Optionnaly use a standard `source` subdirectory instead of all files in the doc folder ?",
"title": "Reorganize online documentation",
"type": "issue"
},
{
"action": "created",
"author": "mrocklin",
"comment_id": 423945153,
"datetime": 1537788783000,
"masked_author": "username_1",
"text": "Sounds good to me",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "guillaumeeb",
"comment_id": null,
"datetime": 1539680195000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 360 | false | false | 360 | false |
OrchardCMS/Orchard | OrchardCMS | 68,175,395 | 1,126 | null | [
{
"action": "closed",
"author": "bleroy",
"comment_id": null,
"datetime": 1428953598000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 254 | false | true | 0 | false |
cppit/jucipp | cppit | 177,111,921 | 288 | {
"number": 288,
"repo": "jucipp",
"user_login": "cppit"
} | [
{
"action": "opened",
"author": "eidheim",
"comment_id": null,
"datetime": 1473925884000,
"masked_author": "username_0",
"text": "* Added filename and branch to status bar at bottom\r\n* Added colors to diagnostics; number of warnings, errors and fix-its\r\n* Cleanup of status processing\r\n\r\nNeed feedback on the changes before merge.",
"title": "Status bar",
"type": "issue"
},
{
"action": "created",
"author": "eidheim",
"comment_id": 247261778,
"datetime": 1473926179000,
"masked_author": "username_0",
"text": "Have to mention that the decisions of the placements of the various items in the status bar was made to make the items take up minimal area, and avoiding that the items move around. The items should not overlap even when debugging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "d3rrial",
"comment_id": 247281099,
"datetime": 1473931899000,
"masked_author": "username_1",
"text": "Works perfectly for me and looks good. I'm still not a fan of the line:col indicator at the back, but it also makes sense to be there (I mostly dislike it for visual reasons).\r\nI have not been able to test it on windows, but it works great on Arch Linux. I especially like the branch indicator and that it changes immediately when a new branch is checked out.\r\n\r\nI'll test on Windows in a few hours. Thank you! :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eidheim",
"comment_id": 247286766,
"datetime": 1473933496000,
"masked_author": "username_0",
"text": "Great:) I agree with the line:line_offset, though the alternatives are either to have the file name move around, or take up extra area (where the filename would move around if one is working on files with a large number of lines/line offsets). I think the current solution is the best, though none of alternatives are perfect. \r\n\r\nI was surprised by the branch indicator myself, and that the diff on the views are getting updated when one switch branches:) Also added a warning when switching branches (if the current file is different) to make this solution part of a normal work flow. The final step, is your PR where one can reload the file:)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eidheim",
"comment_id": 247306134,
"datetime": 1473939893000,
"masked_author": "username_0",
"text": "Just made the diagnostics status an overlay too, so that it never moves around.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,568 | false | false | 1,568 | false |
Grisu-NOE/mobile-app | Grisu-NOE | 142,275,069 | 108 | null | [
{
"action": "opened",
"author": "ajgassner",
"comment_id": null,
"datetime": 1458545243000,
"masked_author": "username_0",
"text": "",
"title": "Display messages icon only when extended incident data is enabled",
"type": "issue"
},
{
"action": "created",
"author": "ajgassner",
"comment_id": 199349592,
"datetime": 1458575381000,
"masked_author": "username_0",
"text": "Please restrict the loading of the data, it's not needed if there is no valid token.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChESch",
"comment_id": 199370714,
"datetime": 1458578396000,
"masked_author": "username_1",
"text": "Have you done that with \"Meine Einstatzhistorie\"? If yes, in which file?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ajgassner",
"comment_id": 242813841,
"datetime": 1472236009000,
"masked_author": "username_0",
"text": "see my commits to this ticket. you only solved the UI part, but we can improve performance when we also check for the setting in the load logic",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ajgassner",
"comment_id": 242818398,
"datetime": 1472237025000,
"masked_author": "username_0",
"text": "Fixed",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ajgassner",
"comment_id": null,
"datetime": 1472237025000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 304 | false | false | 304 | false |
jetstack/tarmak | jetstack | 297,161,517 | 114 | {
"number": 114,
"repo": "tarmak",
"user_login": "jetstack"
} | [
{
"action": "opened",
"author": "simonswine",
"comment_id": null,
"datetime": 1518625936000,
"masked_author": "username_0",
"text": "Updates dependencies and overrides a few transitive dependencies through\r\ngo-dockerclient. Fixes #99\r\n\r\n```release-note\r\nNONE\r\n```",
"title": "Sirupes logrus lowercase",
"type": "issue"
}
] | 3 | 5 | 2,693 | false | true | 130 | false |
sympy/sympy | sympy | 368,345,705 | 15,366 | {
"number": 15366,
"repo": "sympy",
"user_login": "sympy"
} | [
{
"action": "opened",
"author": "iamprayush",
"comment_id": null,
"datetime": 1539110790000,
"masked_author": "username_0",
"text": "<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\nFixes #15327\r\n\r\n#### Brief description of what is fixed or changed\r\nAdded outputs to all the plots using matplotlib plot directive\r\n\r\n#### Other comments\r\nThis should be enough to close the issue.\r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. The bot will check your release notes\r\nautomatically to see if they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* plotting\r\n * Added outputs to all plotting examples in the sphinx docs.\r\n<!-- END RELEASE NOTES -->",
"title": "Added outputs for all plot examples",
"type": "issue"
},
{
"action": "created",
"author": "iamprayush",
"comment_id": 428307074,
"datetime": 1539110936000,
"masked_author": "username_0",
"text": "These are the outputs that I received:\r\n\r\n\r\n\r\n\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iamprayush",
"comment_id": 428307261,
"datetime": 1539110969000,
"masked_author": "username_0",
"text": "@username_1 will this be enough to close the issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "moorepants",
"comment_id": 428316398,
"datetime": 1539112580000,
"masked_author": "username_1",
"text": "Maybe not. I think more work for the beam examples is still needed, among potential other places in the docs that use plots.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "moorepants",
"comment_id": 428321025,
"datetime": 1539113459000,
"masked_author": "username_1",
"text": "They are already there: https://docs.sympy.org/dev/modules/plotting.html\r\n\r\nYes, you will be added to the authors list on the next release.",
"title": null,
"type": "comment"
}
] | 3 | 6 | 4,059 | false | true | 2,173 | true |
Bareflank/hypervisor | Bareflank | 179,949,545 | 228 | null | [
{
"action": "opened",
"author": "connojd",
"comment_id": null,
"datetime": 1475122915000,
"masked_author": "username_0",
"text": "We need to change\r\n```cpp\r\nif ((pending_debug_exceptions & 0xFFFFFFFFFFFF2FF0) != 0)\r\n```\r\nto \r\n```cpp\r\nif ((pending_debug_exceptions & 0xFFFFFFFFFFFEAFF0) != 0)\r\n```\r\nSection 26.3.1.5 (first item under Pending debug exceptions) states the reserved bits are 63:17, 15, 13, and 11:4.",
"title": "Change mask in check_guest_pending_debug_exceptions_reserved",
"type": "issue"
},
{
"action": "created",
"author": "connojd",
"comment_id": 262453180,
"datetime": 1479888339000,
"masked_author": "username_0",
"text": "Fixed in #343",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "connojd",
"comment_id": null,
"datetime": 1479888339000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 295 | false | false | 295 | false |
spatie/laravel-newsletter | spatie | 239,258,861 | 90 | {
"number": 90,
"repo": "laravel-newsletter",
"user_login": "spatie"
} | [
{
"action": "opened",
"author": "Yugis",
"comment_id": null,
"datetime": 1498675548000,
"masked_author": "username_0",
"text": "Removed an extra word \"will\" on line 48.",
"title": "Update README.md",
"type": "issue"
},
{
"action": "created",
"author": "freekmurze",
"comment_id": 311758808,
"datetime": 1498677122000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 47 | false | false | 47 | false |
google/j2objc | google | 277,395,042 | 914 | null | [
{
"action": "opened",
"author": "sarsonj",
"comment_id": null,
"datetime": 1511877699000,
"masked_author": "username_0",
"text": "Hi,\r\nafter upgrade to j2objc 2.x I have problem with stopping of code on breakpoints. When I use symbolic breakpoint to stop on exeption, the xCode stops running and shows Java source code, as expected. But when setting normal breakpoint, the code never stops. It worked with older j2objc (1.x).\r\n\r\nThanks,\r\n\r\nJindrich",
"title": "Breakpoint is not catch in the xCode",
"type": "issue"
},
{
"action": "created",
"author": "tomball",
"comment_id": 347938993,
"datetime": 1511977405000,
"masked_author": "username_1",
"text": "I'm not sure exactly what you mean by a normal breakpoint, but I just rebuilt the [J2Reversi](https://github.com/username_1/j2objc-sample-reversi) example with [j2objc-2.0.5](https://github.com/google/j2objc/releases/tag/2.0.5), and after clicking on a Java source line to set the breakpoint, it stopped in the debugger at that line.\r\n\r\nXcode's debugger (lldb) has very simple support for source debugging (like gdb): if #line preprocessor directives are added to the source file used to build the .o file, then they take precedence over the generated file's path. So when J2Reversi's Score.java file is translated with -g on my system, the Score.m file has source debugging lines in it:\r\n```\r\n...\r\n#line 1 \"/Users/tball/src/j2objc-sample-reversi/Classes/Othello/Engine/Score.java\"\r\n...\r\n#line 36\r\n+ (jint)GetOpponentWithInt:(jint)player {\r\n...\r\n#line 58\r\n- (void)ScoreSubtractWithInt:(jint)player\r\n withInt:(jint)amount {\r\n...\r\n```\r\n#line directives contain the absolute path of the original source file (directives without paths reuse the last specified path). So there are only two ways the j2objc translator (or any other source generator) can do this incorrectly:\r\n\r\n1. The path is wrong: breakpoints aren't hit, since there's no code associated with a bad path.\r\n1. The line number is wrong: breakpoints hit on the wrong line, stepping is also off.\r\n\r\nIt sounds like you are seeing the first problem. Please rebuild your project, check that the problem still exists, then open a j2objc-generated .m file along with its original source (for Xcode projects, I use \"find ~/Library/Developer/Xcode/DerivedData/_projectname_* -name '*.m'\" to locate generated files). Copy the Java file's path, then verify it exists with the ls command. If not, then the build rule creating the generated file is the problem. Also check that the line numbers match for any methods where breakpoints aren't stopping.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sarsonj",
"comment_id": null,
"datetime": 1523312218000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 2,236 | false | false | 2,236 | true |
Impactstory/citeas-webapp | Impactstory | 284,903,513 | 3 | null | [
{
"action": "opened",
"author": "katrinleinweber",
"comment_id": null,
"datetime": 1514463475000,
"masked_author": "username_0",
"text": "Hello! Besides the [few default styles](https://github.com/Impactstory/citeas-api/commit/60a3daf2df31bd4dcd4267a1493c4675c486f763#diff-30d35786cfd776b1f92066d4c51b3c36R80) will it be possible to use more or even any that are on https://www.zotero.org/styles or https://github.com/citation-style-language/styles?",
"title": "more citation styles",
"type": "issue"
},
{
"action": "created",
"author": "hpiwowar",
"comment_id": 354291447,
"datetime": 1514469065000,
"masked_author": "username_1",
"text": "Thanks for the request! \r\n\r\nIt'd be easy to add in a few if you have favourites we are missing! Let me know the filenames from https://github.com/citation-style-language/styles\r\n\r\nIt's harder to made it handle any arbitrary one from the list. Are you building something that would need that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "katrinleinweber",
"comment_id": 354292578,
"datetime": 1514469546000,
"masked_author": "username_0",
"text": "Sorry, about #2. I was on a bad connection and updating that accidental submit with the above text didn't work.\r\n\r\nNo, I'm not building anything on top of CiteAs, just noticed that the list of style options was limited and hard-coded. Would it be useful to your project to expediently add a few more styles? I imagine that a user would instead appreciate a search box to quickly find the style they want. That search box could feed off [styles](https://github.com/citation-style-language/styles). Additionally maybe even with fuzzy-matching.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hpiwowar",
"comment_id": 354294788,
"datetime": 1514470563000,
"masked_author": "username_1",
"text": "Thanks! Yeah, agreed it would be cool to get any style. It makes it the apps built on the API a bit slower though, because there are too many formats to return all the results in the API for all the citation formats, so the app would have to call the API with the specific format once the user picked it from the drop down. \r\n\r\nWe've opted to go with the short-list for now, but are definitely interested in hearing from anyone who needs it to work differently!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hpiwowar",
"comment_id": null,
"datetime": 1514470564000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "katrinleinweber",
"comment_id": 354302091,
"datetime": 1514473518000,
"masked_author": "username_0",
"text": "Yeah, that doesn't scale... Thanks for explaining :-)\r\n\r\nIs it a longer-term goal to avoid duplicating the citation data in the JSON dataset that your API returns, and do the style-based rendering citation in the user's browser?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hpiwowar",
"comment_id": 355087825,
"datetime": 1515004003000,
"masked_author": "username_1",
"text": "Sorry for the slow response. I can see reasons why that might be good in\nsome ways but no, that isn't a goal at the moment :)\nHeather\n\n--\nHeather Piwowar\ncofounder of Impactstory <http://impactstory.org/>: share the full story of\nyour research impact.\n working from Vancouver, Canada\n@researchremix <http://twitter.com/#!/researchremix> and @Impactstory\n<https://twitter.com/ImpactStory>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "katrinleinweber",
"comment_id": 355643247,
"datetime": 1515180428000,
"masked_author": "username_0",
"text": "OK, FYI only then: Zenodo [has](https://github.com/zenodo/zenodo/blob/master/zenodo/modules/records/templates/zenodo_records/box/share.html#L36) [something](https://github.com/zenodo/zenodo/blob/master/zenodo/modules/theme/static/scss/record.scss#L132) [similar](https://github.com/zenodo/zenodo/tree/master/zenodo/modules/records/templates/zenodo_records/record_detail.html#L121) (\"Invenio CSL\"). Not sure where they are fetching the styles from, though.",
"title": null,
"type": "comment"
}
] | 2 | 8 | 2,682 | false | false | 2,682 | false |
Microsoft/vscode-css-languageservice | Microsoft | 208,160,678 | 23 | {
"number": 23,
"repo": "vscode-css-languageservice",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "katainaka0503",
"comment_id": null,
"datetime": 1487260211000,
"masked_author": "username_0",
"text": "Related to Microsoft/vscode#20738.",
"title": "Change sort order using splittedByHyphenCount",
"type": "issue"
},
{
"action": "created",
"author": "aeschli",
"comment_id": 291796751,
"datetime": 1491382349000,
"masked_author": "username_1",
"text": "Sorry I don't want push this PR. To me your suggested change is too specific to your problem and will cause behaviour that is unpredictable users.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 180 | false | false | 180 | false |
cordova-plugin-camera-preview/cordova-plugin-camera-preview | cordova-plugin-camera-preview | 218,796,197 | 254 | null | [
{
"action": "opened",
"author": "SVANNER",
"comment_id": null,
"datetime": 1491169577000,
"masked_author": "username_0",
"text": "I have tested the switchCamera function on 2 Android devices:\r\n\r\n**Galaxy SIV - GT-I9505 - Android Version 5.0.1**\r\nThis freeze the camera preview. \r\n\r\n**KLIVER AG301 - Android 6.0**\r\nWorks perfectly \r\n\r\nHope this can help for next build(s) of the plugin.\r\n\r\nKind regards.",
"title": "switchCamera freeze camera preview",
"type": "issue"
},
{
"action": "created",
"author": "SVANNER",
"comment_id": 291777450,
"datetime": 1491377252000,
"masked_author": "username_0",
"text": "Issue fixed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "SVANNER",
"comment_id": null,
"datetime": 1491377272000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 285 | false | false | 285 | false |
google/grr | google | 287,163,138 | 561 | null | [
{
"action": "opened",
"author": "coonsmatthew",
"comment_id": null,
"datetime": 1515517756000,
"masked_author": "username_0",
"text": "Hello all,",
"title": "Python hack kills GRR client",
"type": "issue"
},
{
"action": "closed",
"author": "coonsmatthew",
"comment_id": null,
"datetime": 1515518192000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "coonsmatthew",
"comment_id": null,
"datetime": 1515522240000,
"masked_author": "username_0",
"text": "Hello all,",
"title": "Python hack kills GRR client",
"type": "issue"
},
{
"action": "created",
"author": "mlkm",
"comment_id": 356560653,
"datetime": 1515579906000,
"masked_author": "username_1",
"text": "It looks like this GRR client consumed a large amount of time or memory and committed a suicide.\r\nDoes rpm -Va return immediately when you run it without GRR, manually in a terminal?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "coonsmatthew",
"comment_id": 357026401,
"datetime": 1515697075000,
"masked_author": "username_0",
"text": "There are quite a few number of lines on the specific server that we're running it on. \r\n\r\nDoes the GRR client not like to run commands that take a while to execute? \r\n\r\nRunning RPM -Va took around 10 minutes on the system.\r\n\r\nPerhaps it would be better to have it run the command and disconnect it from the console, but save the results to a file? \r\n\r\nSomething like this perhaps? \r\n\r\n```\r\nimport commands\r\nstatus, output = commands.getstatusoutput(\"rpm -Va > /tmp/rpm_verify_results &\")\r\nmagic_return_str = \"RPM Verify executed successfully\"\r\n```\r\n\r\nAt least that way you could keep refreshing the /tmp/ directory until the results are there....Or would that not work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "grrrrrrrrr",
"comment_id": 357181873,
"datetime": 1515747867000,
"masked_author": "username_2",
"text": "We have used hacks like https://pastebin.com/ZfcEKp0x before that call Progress periodically so the the client doesn't get terminated due to timeout. It's not pretty but it works..",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "grrrrrrrrr",
"comment_id": null,
"datetime": 1516127634000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "grrrrrrrrr",
"comment_id": 358060686,
"datetime": 1516127634000,
"masked_author": "username_2",
"text": "I'll close this issue, feel free to reopen if you still encounter any issues.",
"title": null,
"type": "comment"
}
] | 3 | 8 | 1,129 | false | false | 1,129 | false |
habitat-sh/core-plans | habitat-sh | 309,906,750 | 1,299 | null | [
{
"action": "opened",
"author": "rsertelon",
"comment_id": null,
"datetime": 1522358859000,
"masked_author": "username_0",
"text": "Source url responds 404",
"title": "[jre9] Package does not build anymore",
"type": "issue"
},
{
"action": "closed",
"author": "nellshamrell",
"comment_id": null,
"datetime": 1522797429000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 23 | false | false | 23 | false |
opentraveldata/opentraveldata | opentraveldata | 346,932,182 | 94 | null | [
{
"action": "opened",
"author": "deepak0000",
"comment_id": null,
"datetime": 1533202241000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI notice that MRB- Muara Bungo Airport is missing from your optd_por_public.csv file.\r\nWiki link for reference - https://en.wikipedia.org/wiki/Muara_Bungo_Airport\r\n\r\nBest,\r\nDeepak",
"title": "Please add MRB- Muara Bungo Airport to the optd_por_public.csv file",
"type": "issue"
},
{
"action": "created",
"author": "denisarnaud",
"comment_id": 409945036,
"datetime": 1533219919000,
"masked_author": "username_1",
"text": "Hi Deepak,\r\n\r\nthanks for your contribution!\r\n\r\nPlease note that MRB designates [Eastern West Virginia Regional Airport, West Virginia (WV), United States (US)](http://www.geonames.org/4804783/eastern-west-virginia-regional-airport.html), not the Muara Bungo Airport, Indonesia (ID), as you can check on [IATA](https://www.iata.org/publications/Pages/code-search.aspx).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "denisarnaud",
"comment_id": null,
"datetime": 1533219919000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 557 | false | false | 557 | false |
Kitware/itk-vtk-viewer | Kitware | 349,227,790 | 99 | null | [
{
"action": "opened",
"author": "thewtex",
"comment_id": null,
"datetime": 1533837060000,
"masked_author": "username_0",
"text": "",
"title": "Rotate 3D view after initialization until mouse click by default",
"type": "issue"
},
{
"action": "closed",
"author": "thewtex",
"comment_id": null,
"datetime": 1561339870000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "thewtex",
"comment_id": 504809216,
"datetime": 1561340206000,
"masked_author": "username_0",
"text": ":tada: This issue has been resolved in version 7.4.0 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/itk-vtk-viewer)\n- [GitHub release](https://github.com/Kitware/itk-vtk-viewer/releases/tag/v7.4.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 1 | 3 | 357 | false | false | 357 | false |
servo/core-graphics-rs | servo | 186,093,684 | 61 | {
"number": 61,
"repo": "core-graphics-rs",
"user_login": "servo"
} | [
{
"action": "opened",
"author": "jrmuizel",
"comment_id": null,
"datetime": 1477766044000,
"masked_author": "username_0",
"text": "<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/core-graphics-rs/61)\n<!-- Reviewable:end -->",
"title": "Add kCGBitmapByteOrder constants",
"type": "issue"
},
{
"action": "created",
"author": "jdm",
"comment_id": 257115488,
"datetime": 1477774404000,
"masked_author": "username_1",
"text": "@bors-servo: r+",
"title": null,
"type": "comment"
}
] | 3 | 4 | 451 | false | true | 238 | false |
awslabs/amazon-kinesis-producer | awslabs | 211,246,719 | 94 | {
"number": 94,
"repo": "amazon-kinesis-producer",
"user_login": "awslabs"
} | [
{
"action": "opened",
"author": "skidder",
"comment_id": null,
"datetime": 1488412419000,
"masked_author": "username_0",
"text": "Fixes #93",
"title": "Wrap process.waitFor() in a try-finally that calls shutdown",
"type": "issue"
},
{
"action": "created",
"author": "pfifer",
"comment_id": 298990330,
"datetime": 1493834907000,
"masked_author": "username_1",
"text": "Please confirm that we can use, modify, copy, and redistribute this contribution. \r\n\r\nThanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pfifer",
"comment_id": 298990859,
"datetime": 1493835025000,
"masked_author": "username_1",
"text": "Thanks for submitting the PR.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "skidder",
"comment_id": 299071159,
"datetime": 1493857369000,
"masked_author": "username_0",
"text": "Yes, you can use, modify, copy, and redistribute this contribution.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "skidder",
"comment_id": 299071194,
"datetime": 1493857385000,
"masked_author": "username_0",
"text": "Yes, you can use, modify, copy, and redistribute this contribution.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pfifer",
"comment_id": 299475588,
"datetime": 1493993596000,
"masked_author": "username_1",
"text": "@username_0 Did you mean to respond on #92 as well? Can you please add the same message on there.\r\n\r\nThanks",
"title": null,
"type": "comment"
}
] | 2 | 6 | 369 | false | false | 369 | true |
sqlkata/querybuilder | sqlkata | 353,060,828 | 128 | null | [
{
"action": "opened",
"author": "avlcodemonkey",
"comment_id": null,
"datetime": 1534960641000,
"masked_author": "username_0",
"text": "Is there a way to do a raw join, like WhereRaw? I'd like to be able to add a join specifying the entire predicate for the join instead of the exact columns to join on. \r\n\r\nInstead of:\r\n`var query = new Query(\"Posts\").Join(\"Authors\", \"Authors.Id\", \"Posts.AuthorId\");`\r\nDo this:\r\n`var query = new Query(\"Posts\").JoinRaw(\"Authors\", \"Authors.Id = Posts.AuthorId\");`",
"title": "Raw Option for Joins?",
"type": "issue"
},
{
"action": "created",
"author": "ahmad-moussawi",
"comment_id": 415299120,
"datetime": 1535003342000,
"masked_author": "username_1",
"text": "yes you can use the same `WhereRaw` in the lambda overload\r\n\r\n```cs\r\nquery.Join(\"Table\", j => j.WhereRaw(\"\"));\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "avlcodemonkey",
"comment_id": null,
"datetime": 1535029457000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "avlcodemonkey",
"comment_id": 415406586,
"datetime": 1535029457000,
"masked_author": "username_0",
"text": "Excellent. I'll give that a try. Thanks.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 521 | false | false | 521 | false |
joemccann/dillinger | null | 173,614,712 | 565 | null | [
{
"action": "opened",
"author": "bnb",
"comment_id": null,
"datetime": 1472330787000,
"masked_author": "username_0",
"text": "Adding Import/Export for the Slack File API would be 👍. Slack is insanely more progressive than Google Drive in terms of Markdown, and would be way easier to use in a team.\r\n\r\nIt appears the different File API methods are here: https://api.slack.com/methods",
"title": "[Feature Request] Add Slack File API Import/Export",
"type": "issue"
}
] | 1 | 1 | 257 | false | false | 257 | false |
docker-library/php | docker-library | 228,928,592 | 435 | null | [
{
"action": "opened",
"author": "mcnilz",
"comment_id": null,
"datetime": 1494916444000,
"masked_author": "username_0",
"text": "Yesterday we experienced many apache/php errors after upgrading to the newest image. The logs showed memory errors like ``mmap() failed``. We found out that turning off pcre jit with ``pcre.jit=0`` in ``php.ini`` is a workaround.",
"title": "php:7.0-apache pcre jit possibly broken ",
"type": "issue"
},
{
"action": "created",
"author": "zherczeg",
"comment_id": 302913239,
"datetime": 1495338408000,
"masked_author": "username_1",
"text": "Usually this happens on Security Enhanced Linux if you use the basic executable allocator.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FireLizard",
"comment_id": 315755043,
"datetime": 1500298030000,
"masked_author": "username_2",
"text": "Same issue on MacOS ...\r\n\r\nMac: MacOS Sierra 10.12.5\r\nDocker: Version 17.06.0-ce-mac19 (18663)\r\n\r\nFound the workaround on [stackoverflow](https://stackoverflow.com/questions/35889130/apache-crashes-with-munmap-chunk-invalid-pointer-after-update-to-php7-on-jess#39535288), too.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tianon",
"comment_id": null,
"datetime": 1513987107000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tianon",
"comment_id": 353692521,
"datetime": 1513987107000,
"masked_author": "username_3",
"text": "Sorry for the delay!\r\n\r\nAs of https://github.com/docker-library/php/pull/526, we're back to using PHP's bundled copy of `libpcre` in the default PHP-provided configuration (except on s390x, where JIT is not supported at all).\r\n\r\nGiven that, I'm inclined to consider this an upstream bug, and would suggest coming up with a reasonably simple reproducer, and filing an issue with upstream. Sorry!\r\n\r\nIn the meantime, it sounds like the simple workaround for folks affected by this is to simply add `pcre.jit=0` in `php.ini`, as noted above. :+1:",
"title": null,
"type": "comment"
}
] | 4 | 5 | 1,139 | false | false | 1,139 | false |
angular/material2 | angular | 335,073,951 | 11,897 | null | [
{
"action": "opened",
"author": "denek01",
"comment_id": null,
"datetime": 1529735418000,
"masked_author": "username_0",
"text": "#### Bug, feature request, or proposal:\r\n\r\nI need a container html element for the draggable events and tbody is not in the mat-table. When we add, no data comes.\r\n<div mat-tbody> <---------- we need this.\r\n <div mat-row> </div>\r\n</div>",
"title": "mat-table must have tbody we need it writing code not just in the output",
"type": "issue"
},
{
"action": "created",
"author": "josephperrott",
"comment_id": 400017509,
"datetime": 1529944914000,
"masked_author": "username_1",
"text": "Closing this issue as it does not follow the issue template. Please file a new issue that follows the template, which gives the team the information needed to investigate",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "josephperrott",
"comment_id": null,
"datetime": 1529944914000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 768 | false | true | 408 | false |
liyaodong/atom2yasnippets | null | 298,108,712 | 1 | null | [
{
"action": "opened",
"author": "MooersLab",
"comment_id": null,
"datetime": 1518980475000,
"masked_author": "username_0",
"text": "I am using MacOSX 13 High Sierra.\r\nI updated Node.js and installed atom2yasnippets.\r\nI can print the help but that is it.\r\n\r\nI have tried the following commands \r\n\r\natom2yas -u \"file:///Users/blaine/software/yasnippets/subi.cson\" -o ./dist\r\n\r\natom2yas -u file:///Users/blaine/software/yasnippets/subi.cson-o file///Users/blaine/software/yasnippets/dist/\r\n\r\natom2yas -u /Users/blaine/software/yasnippets/subi.cson -o /Users/blaine/software/yasnippets/dist\r\n\r\natom2yas -u rawCSONAtomSnippetURL -o ./dist\r\n\r\nAll of the above give the error message:\r\n\r\n(node:40501) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: only absolute urls are supported\r\n\r\n\r\nHere is the content of the cson file:\r\n\r\n'.text.tex, latex.ing, comment.line.percentage.tex, meta.no-spellcheck':\r\n 'subsection with label and index':\r\n prefix: 'subi'\r\n body: '''\r\n \\\\subsection{${1:subsection name}} % (fold)\r\n \\\\label{sub:${1:subsection name}}\r\n \\\\index{${1:subsection name}}\r\n ${2:Start here}\r\n % subsection ${1:subsection name} (end)$0\r\n '''",
"title": "not working",
"type": "issue"
},
{
"action": "created",
"author": "liyaodong",
"comment_id": 367537554,
"datetime": 1519263203000,
"masked_author": "username_1",
"text": "Hi @username_0 \r\n\r\nIt's time to try `atom2yas -u https://raw.githubusercontent.com/bryceosterhaus/atom-jest-snippets/master/snippets/custom.json -o ./dist` on your local. the command only support the cson url on remote http/https server. maybe you can upload your local cson file to gist and get a raw content url. I will update the readme file to clarify this. \r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "liyaodong",
"comment_id": null,
"datetime": 1519263210000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "MooersLab",
"comment_id": 367764624,
"datetime": 1519321988000,
"masked_author": "username_0",
"text": "Thank you! Your example code worked for me.\n\nThe ability to apply atom2yasnippets to a directory of atom snippets would\nbe very useful.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cloudnine",
"comment_id": 533829621,
"datetime": 1569099423000,
"masked_author": "username_2",
"text": "Hi,\r\nI am using windows 10 wsl \r\nI updated Node.js, npm, and installed atom2yasnippets.\r\n\r\natom2yas -u https://github.com/dsandstrom/atom-css-snippets/blob/master/snippets/css-snippets.cson -o ./dist\r\n\r\nIt works, and runs anyway the index.js but maybe has problems parsing the source?\r\n\r\n```\r\nerron when parse https://github.com/dsandstrom/atom-css-snippets/blob/master/snippets/css-snippets.cson as CSON file\r\n(node:2329) UnhandledPromiseRejectionWarning: Error: [stdin]:31:96: error: missing / (unclosed regex)\r\n <title>atom-css-snippets/css-snippets.cson at master · dsandstrom/atom-css-snippets · GitHub</title>\r\n ^\r\n at parseCSON (/usr/local/lib/node_modules/atom2yasnippets/index.js:32:15)\r\n at <anonymous>:null:null\r\n at process._tickCallback (internal/process/next_tick.js:188:7)\r\n\r\n(node:2329) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)\r\n(node:2329) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.\r\n```\r\n\r\nAny suggestions?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cloudnine",
"comment_id": 533829804,
"datetime": 1569099619000,
"masked_author": "username_2",
"text": "Same result with another source. \r\n\r\nerron \"GitHub</title>\" .",
"title": null,
"type": "comment"
}
] | 3 | 6 | 3,027 | false | false | 3,027 | true |
EOSIO/eos | EOSIO | 374,993,540 | 6,176 | null | [
{
"action": "opened",
"author": "helloxiell",
"comment_id": null,
"datetime": 1540816355000,
"masked_author": "username_0",
"text": "permissions:\r\n owner 1: 1 EOS6C3iqHU1h85rir88sWRcbvdbLvTcuHrhQmejyZpyfXvQzDub49\r\n active 1: 1 EOS6C3iqHU1h85rir88sWRcbvdbLvTcuHrhQmejyZpyfXvQzDub49\r\n```",
"title": "'unable to find key' when I call push transaction use RPC",
"type": "issue"
},
{
"action": "created",
"author": "jgiszczak",
"comment_id": 434048695,
"datetime": 1540841618000,
"masked_author": "username_1",
"text": "The key in question is the entry in a table, not an encryption key.\r\n\r\nGoing by the account names you are using, you are attempting this transfer on a private testnet. Be sure you have completed bootstrapping your testnet, including installing the `eosio.token` contract, and creating and issuing an EOS token. If you did not customize your core symbol during the build to EOS, create and issue the SYS token and revise your test transaction to transfer `\"1.0000 SYS\"` instead of `\"1.0000 EOS\"`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xxxxll",
"comment_id": 434145393,
"datetime": 1540865155000,
"masked_author": "username_2",
"text": "@username_1 Thanks. the key is should be `\"1.0000 SYS\"` not `\"1.0000 EOS\"`.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "xxxxll",
"comment_id": null,
"datetime": 1540865203000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 746 | false | false | 746 | true |
Gazuntype/graphQL-client-unity | null | 373,129,216 | 2 | null | [
{
"action": "opened",
"author": "edgar-abadines",
"comment_id": null,
"datetime": 1540317931000,
"masked_author": "username_0",
"text": "The current Unity AWS drivers don't support AppSync. Any plans to enable graphQL-client-unity to access AWS graphql?",
"title": "graphql via AWS Appsync",
"type": "issue"
},
{
"action": "created",
"author": "Gazuntype",
"comment_id": 438266279,
"datetime": 1542115857000,
"masked_author": "username_1",
"text": "I don't have much knowledge about AWS AppSync. But you should already be able to use graphQL-client-unity to communicate with their graphQL server.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Gazuntype",
"comment_id": null,
"datetime": 1542440256000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 264 | false | false | 264 | false |
Naruyoko/many-to-do-less-you-have-to | null | 318,709,953 | 7 | null | [
{
"action": "opened",
"author": "LoganDungeon",
"comment_id": null,
"datetime": 1525001655000,
"masked_author": "username_0",
"text": "Since the last Update the screen is constantly twitching around. And there seems no way to fix it. Even zooming in or out doesn't do anything",
"title": "Screen twitching",
"type": "issue"
},
{
"action": "created",
"author": "Naruyoko",
"comment_id": 385266377,
"datetime": 1525022131000,
"masked_author": "username_1",
"text": "Is it twitching up and down or shaking?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Naruyoko",
"comment_id": 385277834,
"datetime": 1525032530000,
"masked_author": "username_1",
"text": "Also, how much have you progressed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Naruyoko",
"comment_id": 386099293,
"datetime": 1525290627000,
"masked_author": "username_1",
"text": "That is an effect. Added disable shaking option! It is under the buttons in Unit Conversion tab.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Naruyoko",
"comment_id": null,
"datetime": 1525450455000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 311 | false | false | 311 | false |
SeldonIO/seldon-core | SeldonIO | 397,050,641 | 373 | {
"number": 373,
"repo": "seldon-core",
"user_login": "SeldonIO"
} | [
{
"action": "opened",
"author": "ro7m",
"comment_id": null,
"datetime": 1546975479000,
"masked_author": "username_0",
"text": "Adding test case for SeldonDeploymentWatcher.\r\n@username_1",
"title": "Adding test case for SeldonDeploymentWatcher",
"type": "issue"
},
{
"action": "created",
"author": "ro7m",
"comment_id": 452781459,
"datetime": 1547055028000,
"masked_author": "username_0",
"text": "@username_1 i choose something which does not match the SeldonDeployment to mimic a failure scenario",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 452786011,
"datetime": 1547055801000,
"masked_author": "username_1",
"text": "I think the issue is actually this test is failing: testModifiedSeldonMLDeploymentsForMultiNamespaceCluster",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ro7m",
"comment_id": 452793230,
"datetime": 1547056847000,
"masked_author": "username_0",
"text": "fixed that",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 452796025,
"datetime": 1547057279000,
"masked_author": "username_1",
"text": "Great. Thanks for the contribution!",
"title": null,
"type": "comment"
}
] | 2 | 5 | 313 | false | false | 313 | true |
hazelcast/hazelcast | hazelcast | 98,745,705 | 5,847 | {
"number": 5847,
"repo": "hazelcast",
"user_login": "hazelcast"
} | [
{
"action": "opened",
"author": "jerrinot",
"comment_id": null,
"datetime": 1438609395000,
"masked_author": "username_0",
"text": "NotEquals predicate does not use index even when its attribute is indexed.\r\n\r\nThe `NotEqualsPredicate` has very low selectivity hence the full-map scan is better in vast majority of cases. Moreover the Index implementation is inefficient for `ComparisonType.NOT_EQUAL` as it's traversing the whole index anyway.\r\n\r\nThe same approach is used by most relation databases - a planner is usually not even trying to estimate cost of indexed access to evaluate NOT_EQUALS predicate and is simply doing a full table scan.",
"title": "NotEquals Predicate does not use index",
"type": "issue"
},
{
"action": "created",
"author": "ajermakovics",
"comment_id": 127624583,
"datetime": 1438697355000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pveentjer",
"comment_id": 129189543,
"datetime": 1439128745000,
"masked_author": "username_2",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 3 | 3 | 521 | false | false | 521 | false |
KaneCheshire/HapticGenerator | null | 281,704,158 | 1 | null | [
{
"action": "opened",
"author": "KaneCheshire",
"comment_id": null,
"datetime": 1513162193000,
"masked_author": "username_0",
"text": "Could have an argument in the function which defaults to `false`:\r\n\r\n`function generateHaptic(prepareForReuse: Bool = false)`\r\n\r\nUsage:\r\n\r\n`selection.generateHaptic()`\r\n`selection.generateHaptic(prepareForReuse: true)`",
"title": "Add option to automatically prepare for reuse when calling `generateHaptic`",
"type": "issue"
},
{
"action": "created",
"author": "KaneCheshire",
"comment_id": 357237018,
"datetime": 1515763409000,
"masked_author": "username_0",
"text": "Now available in 2.1.0",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "KaneCheshire",
"comment_id": null,
"datetime": 1515763409000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 240 | false | false | 240 | false |
kubernetes/test-infra | kubernetes | 329,634,338 | 8,265 | {
"number": 8265,
"repo": "test-infra",
"user_login": "kubernetes"
} | [
{
"action": "opened",
"author": "ravisantoshgudimetla",
"comment_id": null,
"datetime": 1528234635000,
"masked_author": "username_0",
"text": "This is for adding pod preemption to test suite since it graduated to beta. \r\nNot sure if I missing anything.\r\n\r\n/cc @bsalamat",
"title": "Config updated for pod preemption",
"type": "issue"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394869577,
"datetime": 1528234826000,
"masked_author": "username_1",
"text": "add an entry to prow/config.yaml as well",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394876923,
"datetime": 1528236663000,
"masked_author": "username_1",
"text": "/approve\r\n\r\npunt to your sig to lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 394877295,
"datetime": 1528236761000,
"masked_author": "username_0",
"text": "Thanks @username_1 for the review and approval :).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 394895670,
"datetime": 1528242460000,
"masked_author": "username_0",
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394895866,
"datetime": 1528242528000,
"masked_author": "username_1",
"text": "cc @BenTheElder \r\n\r\nhttps://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/8265/pull-test-infra-lint/2909/ looks like a cache issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 395149668,
"datetime": 1528306087000,
"masked_author": "username_1",
"text": "/lgtm\r\n/hold",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395196321,
"datetime": 1528315544000,
"masked_author": "username_0",
"text": "@username_1 Thanks for review. Any specific reason for putting it on hold, is it because of code-freeze?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 395210245,
"datetime": 1528318434000,
"masked_author": "username_1",
"text": "@username_0 because I added a non-blocking comment, feel free to address it or ignore it and `/hold cancel`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395232107,
"datetime": 1528323545000,
"masked_author": "username_0",
"text": "Thanks @username_1 - I will address it later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395232133,
"datetime": 1528323552000,
"masked_author": "username_0",
"text": "/hold cancel",
"title": null,
"type": "comment"
}
] | 3 | 22 | 14,784 | false | true | 704 | true |
maschel/RoombaJSSC | null | 265,617,623 | 1 | {
"number": 1,
"repo": "RoombaJSSC",
"user_login": "maschel"
} | [
{
"action": "opened",
"author": "rfenters95",
"comment_id": null,
"datetime": 1508113167000,
"masked_author": "username_0",
"text": "",
"title": "fixed relative max values",
"type": "issue"
},
{
"action": "created",
"author": "rfenters95",
"comment_id": 337656542,
"datetime": 1508345721000,
"masked_author": "username_0",
"text": "Sorry about the [fixed relative max values commit](https://github.com/maschel/RoombaJSSC/pull/1/commits/63355c24562bb91308eb2fca20325590d54ae41f), it was inadvertently included with the new `leds` method commit. These changes were the applied when I was debugging an issue with the power parameter in the original `leds` method where the CLEAN/Power button (as shown in the figure below) was not lighting up, which is the case on an older Roomba I've used previously. I have since realized that the Roomba I'm using now considers the power led to be a battery icon led near the `Troubleshooting Light` (as shown in the figure below). Therefore, I have removed these changes in the latest commit.\r\n\r\n<img width=\"272\" alt=\"screen shot 2017-10-18 at 12 13 24 pm\" src=\"https://user-images.githubusercontent.com/12780053/31729725-db01182a-b3fd-11e7-99c4-99195e61497a.png\">",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,156 | false | true | 867 | false |
parcel-bundler/parcel | parcel-bundler | 333,526,638 | 1,580 | null | [
{
"action": "opened",
"author": "YvanYeo",
"comment_id": null,
"datetime": 1529387092000,
"masked_author": "username_0",
"text": "# 🐛 bug report\r\n\r\nI tried to use dynamic imports to extract common code in entries. However the common part is not extracted in last entry\r\n\r\n## 🎛 Configuration (.babelrc, package.json, cli command)\r\n\r\nnpm script\r\n```\r\nparcel ./**/*.html\r\n```\r\nfile structure\r\n```\r\n├─js\r\n│ vendor.js\r\n│\r\n└─pages\r\n │ index.html\r\n │\r\n ├─index\r\n │ main.js\r\n │ main.scss\r\n │\r\n └─page1\r\n index.html\r\n main.js\r\n main.scss\r\n```\r\n\r\n\r\nvendor.js\r\n```js\r\nimport('vue')\r\n```\r\nindex/main.js & page1/main.js\r\n```js\r\nimport '../../js/vendor'\r\nimport Vue from 'vue'\r\n```\r\n\r\n## 🤔 Expected Behavior\r\n\r\ncode in vendor.js should be extract to a separate file\r\n\r\n## 😯 Current Behavior\r\n\r\nthis content in vue.runtime.esm.bfd22634.js is still in main.7805af3c.js, but not in main.63f097bf.js\r\n```\r\ndist\\main.7805af3c.js 64.57 KB 1.62s\r\ndist\\vue.runtime.esm.bfd22634.js 62.84 KB 1.55s\r\ndist\\main.63f097bf.js 2.67 KB 1.83s\r\ndist\\index.html 408 B 17ms\r\ndist\\page1\\index.html 408 B 718ms\r\ndist\\main.47f3b71e.map 0 B 5ms\r\ndist\\main.e40d4a5e.css 0 B 1.23s\r\ndist\\vue.runtime.esm.bfd22634.map 0 B 59ms\r\ndist\\main.4bc44005.map 0 B 57ms\r\ndist\\main.e40d4a5e.css 0 B 1.24s\r\n```\r\n## 🌍 Your Environment\r\n\r\n| Software | Version(s) |\r\n| ---------------- | ---------- |\r\n| Parcel | 1.9.1 |\r\n| Node | 10.3.0 |\r\n| npm/Yarn | 1.7.0 |\r\n| Operating System | windows10 |",
"title": "Code duplicated when using dynamic imports in multiple entries",
"type": "issue"
},
{
"action": "created",
"author": "mischnic",
"comment_id": 451771460,
"datetime": 1546806020000,
"masked_author": "username_1",
"text": "Very similar to #885 ?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mischnic",
"comment_id": null,
"datetime": 1561104870000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mischnic",
"comment_id": 504336205,
"datetime": 1561104870000,
"masked_author": "username_1",
"text": "Parcel doesn't do any automatic codesplitting if you don't use dynamic imports. Otherwise, please follow #885.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,744 | false | false | 1,744 | false |
googleads/videojs-ima | googleads | 208,847,631 | 335 | null | [
{
"action": "opened",
"author": "lucascharrierpulpix",
"comment_id": null,
"datetime": 1487588561000,
"masked_author": "username_0",
"text": "I know I could add an overlay, but I'll prefer no too.",
"title": "On mobile unable to scroll when touch event starts from over the video",
"type": "issue"
},
{
"action": "created",
"author": "shawnbuso",
"comment_id": 281750626,
"datetime": 1487786580000,
"masked_author": "username_1",
"text": "I believe this is an issue with the IMA SDK, not just this plugin, but will have to investigate further. Thanks for the report!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dtapuska",
"comment_id": 282088237,
"datetime": 1487876711000,
"masked_author": "username_2",
"text": "Unable to scroll seems odd due to this intervention. Is there a URI that reproduces this? (I'm not familiar with videojs-ima at all but am looking at it from Chrome's touch handling perspective as I'm a chromium author)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shawnbuso",
"comment_id": 284518883,
"datetime": 1488831437000,
"masked_author": "username_1",
"text": "You can repro with vanilla IMA SDK (no video.js pluign) here: http://googleads.github.io/googleads-ima-html5. If you zoom in a bit you can scroll vertically - it works when you tap outside the ad, but not when you start your tap inside the ad.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shawnbuso",
"comment_id": 353105823,
"datetime": 1513786120000,
"masked_author": "username_1",
"text": "Testing with 1.0, this appears to be resolved. If you're still seeing the issue with the updated plugin let me know.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "shawnbuso",
"comment_id": null,
"datetime": 1513786120000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 759 | false | false | 759 | false |
ged-lab/khmer | ged-lab | 16,933,252 | 81 | null | [
{
"action": "opened",
"author": "mr-c",
"comment_id": null,
"datetime": 1374169295000,
"masked_author": "username_0",
"text": "There should be a single and consistent file naming scheme and is user overridable.\r\n\r\nBeing able to specify the output file name is a requirement for building pipelines in iPlant's DiscoveryEnvironment.\r\n\r\nKnown offenders: \r\nload-graph.py appends a .ht to the filename specifed (???)\r\n\r\n(Others as I find them again)",
"title": "Inconsistent and incomplete output filename handling",
"type": "issue"
},
{
"action": "created",
"author": "ctb",
"comment_id": 70406100,
"datetime": 1421583529000,
"masked_author": "username_1",
"text": "A few more thoughts here, to throw against the wall --\r\n\r\n1. -o could override all other options, and be an aggregate of all output.\r\n\r\n2. for multi-file input, we should stop building filenames like '.keep.abundfilt.foo.bar.baz' and start building filenames like '.keep.abundfilt.fq.gz' where we specify fq/gz.\r\n\r\n3. -d (or something) could specify output _directory_ in case of the above; right now it is always '.', but could be overridable.\r\n\r\n4. For FASTA/FASTQ, in general only one file should ever be output for each input. This means 'broken paired' format, I think.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 891 | false | false | 891 | false |
ZeusWPI/gamification | ZeusWPI | 341,242,232 | 103 | null | [
{
"action": "opened",
"author": "iasoon",
"comment_id": null,
"datetime": 1531580337000,
"masked_author": "username_0",
"text": "NOW HOW AM I SUPPOSED TO BEAT SILOX?????",
"title": "Gamification selectively ignores my commits",
"type": "issue"
},
{
"action": "created",
"author": "Silox",
"comment_id": 405029288,
"datetime": 1531580943000,
"masked_author": "username_1",
"text": "You're not",
"title": null,
"type": "comment"
}
] | 2 | 2 | 50 | false | false | 50 | false |
date-fns/date-fns | date-fns | 390,704,641 | 1,017 | null | [
{
"action": "opened",
"author": "SagaTious",
"comment_id": null,
"datetime": 1544711498000,
"masked_author": "username_0",
"text": "I don't know if there are more wrong typings, but I just wanted to switch from moment to date-fns and the first two functions I tried to use were already unusable in my Typescript environment.\r\n\r\n**isValid()**\r\nAccording to docs:\r\n````\r\nisValid(date: any, options: Options): boolean\r\n````\r\ntypings.d.ts:\r\n````\r\nisValid(date: Date): boolean\r\n````\r\n\r\n**parse()**\r\nAccording to docs:\r\n````\r\nparse(argument: string, formatString: string, baseDate: Date | string | number, options: Options): Date\r\n````\r\ntypings.d.ts:\r\n````\r\nparse(argument: Date | string | number, options?: { additionalDigits?: 0 | 1 | 2 }): Date\r\n````",
"title": "Typings of isValid and parse are wrong",
"type": "issue"
},
{
"action": "created",
"author": "leshakoss",
"comment_id": 446989038,
"datetime": 1544711616000,
"masked_author": "username_1",
"text": "@username_0 could you please provide us with version of date-fns installed? It looks like you're looking at docs of v2 and typings of v1.x.x",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kossnocorp",
"comment_id": 446989073,
"datetime": 1544711622000,
"masked_author": "username_2",
"text": "You're looking docs and typings for different versions. First ones are for v2 the seconds are for v1.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kossnocorp",
"comment_id": null,
"datetime": 1544711623000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 855 | false | false | 855 | true |
twosigma/beakerx | twosigma | 311,029,872 | 7,121 | {
"number": 7121,
"repo": "beakerx",
"user_login": "twosigma"
} | [
{
"action": "opened",
"author": "jpallas",
"comment_id": null,
"datetime": 1522797089000,
"masked_author": "username_0",
"text": "Fix for #7100. This includes a line that is missing from the Spark retrofit of SI-9881.",
"title": "Scala import fix",
"type": "issue"
},
{
"action": "created",
"author": "scottdraves",
"comment_id": 379139782,
"datetime": 1522985994000,
"masked_author": "username_1",
"text": "https://github.com/apache/spark/pull/19846/files",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "scottdraves",
"comment_id": 379139853,
"datetime": 1522986036000,
"masked_author": "username_1",
"text": "thanks will check this out.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 163 | false | false | 163 | false |
GoogleContainerTools/jib | GoogleContainerTools | 343,957,843 | 699 | null | [
{
"action": "opened",
"author": "qiankunli",
"comment_id": null,
"datetime": 1532424760000,
"masked_author": "username_0",
"text": "I tried to run a springboot project with jib-maven-plugin, the detail as follows:\r\n\r\n\"from\" image dockerfile\r\n\r\n```\r\nFROM alpine:latest\r\n\r\nENV JAVA_VERSION_MAJOR=8 \\\r\n JAVA_VERSION_MINOR=65 \\\r\n JAVA_HOME=/usr/local/jdk \\\r\n PATH=${PATH}:/usr/local/jdk/bin \\\r\n GLIBC_VERSION=2.23-r3 \\\r\n LANG=C.UTF-8\r\n```\r\njib-maven-plugin\r\n\r\n```\r\n<plugin>\r\n\t<groupId>com.google.cloud.tools</groupId>\r\n\t<artifactId>jib-maven-plugin</artifactId>\r\n\t<version>0.9.7</version>\r\n\t<configuration>\r\n\t\t<allowInsecureRegistries>true</allowInsecureRegistries>\r\n\t\t<from>\r\n\t\t\t<image>harbor.test.xx.com/test/jdk8</image>\r\n\t\t</from>\r\n\t\t<to>\r\n\t\t\t<image>harbor.test.xx.com/test/jib-springboot-demo</image>\r\n\t\t</to>\r\n\t\t<container>\r\n\t\t <mainClass>com.xx.springboot.demo.DockerSpringbootDemoApplication</mainClass>\r\n\t\t</container>\r\n\t</configuration>\r\n</plugin>\r\n```\r\n\r\n`docker inspect harbor.test.xx.com/test/jib-springboot-demo` output\r\n\r\n```\r\n\"Config\": {\r\n \"Hostname\": \"\",\r\n \"Domainname\": \"\",\r\n \"User\": \"\",\r\n \"AttachStdin\": false,\r\n \"AttachStdout\": false,\r\n \"AttachStderr\": false,\r\n \"Tty\": false,\r\n \"OpenStdin\": false,\r\n \"StdinOnce\": false,\r\n \"Env\": [],\r\n \"Cmd\": [],\r\n \"Image\": \"\",\r\n \"Volumes\": null,\r\n \"WorkingDir\": \"\",\r\n \"Entrypoint\": [\r\n \"java\",\r\n \"-cp\",\r\n \"/app/libs/*:/app/resources/:/app/classes/\",\r\n \"com.ximalaya.springboot.demo.DockerSpringbootDemoApplication\"\r\n ],\r\n \"OnBuild\": null,\r\n \"Labels\": null\r\n },\r\n```\r\n\r\n`docker run -d -P harbor.test.xx.com/test/jib-springboot-demo` output\r\n\r\ndocker: Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused \"exec: \\\"java\\\": executable file not found in $PATH\".",
"title": "jib may can not be extends environments from \"from\" image",
"type": "issue"
},
{
"action": "created",
"author": "coollog",
"comment_id": 407424299,
"datetime": 1532442095000,
"masked_author": "username_1",
"text": "Hi @username_0 , thanks for reporting this! This is a known issue that we are addressing in #595.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TadCordle",
"comment_id": 407885584,
"datetime": 1532550685000,
"masked_author": "username_2",
"text": "Since we're already tracking this in a different issue, I'm going to close this one for now. Feel free to keep talking here or in #595.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "TadCordle",
"comment_id": null,
"datetime": 1532550685000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "chanseokoh",
"comment_id": 410265006,
"datetime": 1533305287000,
"masked_author": "username_3",
"text": "@username_0 this now works in 0.9.8: https://github.com/GoogleContainerTools/jib/issues/595#issuecomment-410264838",
"title": null,
"type": "comment"
}
] | 4 | 5 | 2,255 | false | false | 2,255 | true |
aspnet/AspNetCore | aspnet | 388,446,001 | 4,484 | {
"number": 4484,
"repo": "AspNetCore",
"user_login": "aspnet"
} | [
{
"action": "opened",
"author": "jkotalik",
"comment_id": null,
"datetime": 1544139954000,
"masked_author": "username_0",
"text": "Note, Antiforgery isn't in the Mvc directory due to a plethora of Directory.Build.props inheritance issues. Will do the final move once MVC uses ProjectReference.",
"title": "[2.1] Make Antiforgery, ResponseCaching, StaticFiles, and Cors use project ref",
"type": "issue"
},
{
"action": "created",
"author": "jkotalik",
"comment_id": 445379010,
"datetime": 1544219983000,
"masked_author": "username_0",
"text": "🆙 📅",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "natemcmaster",
"comment_id": 445381443,
"datetime": 1544220627000,
"masked_author": "username_1",
"text": "If we don't already have one, let's open an issue for this flaky test failure:\r\n\r\n```\r\nMicrosoft.AspNetCore.Server.HttpSys.FunctionalTests.ResponseCachingTests.Caching_SendFileWithFullContentLength_Cached\r\nAssert.Equal() Failure\r\n ↓ (pos 0)\r\nExpected: 1\r\nActual: 2\r\n ↑ (pos 0)\r\n```\r\n\r\ncc @Tratcher",
"title": null,
"type": "comment"
}
] | 2 | 3 | 482 | false | false | 482 | false |
BabylonJS/Babylon.js | BabylonJS | 316,909,853 | 4,187 | null | [
{
"action": "opened",
"author": "TrevorDev",
"comment_id": null,
"datetime": 1524504750000,
"masked_author": "username_0",
"text": "Loading webvr works in edge and firefox. Chrome recently claims this is now supported: https://www.androidpolice.com/2018/04/20/chrome-66-adds-experimental-support-oculus-rift-htc-vive-windows-mixed-reality-vr-headsets/ \r\n\r\nHowever it fails to load in babylon playgrounds https://playground.babylonjs.com/#6HQTPR",
"title": "WebVR not working in chrome for Mixed reality headsets",
"type": "issue"
},
{
"action": "created",
"author": "TrevorDev",
"comment_id": 386844832,
"datetime": 1525566738000,
"masked_author": "username_0",
"text": "It looks like there are still issues in chrome's webVR. The gamepadconnected does not seem to work with Vive causing issues in Babylon and AFrame examples: https://aframe.io/examples/showcase/tracked-controllers/ not initializing controllers.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "deltakosh",
"comment_id": null,
"datetime": 1528390824000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "deltakosh",
"comment_id": 395493074,
"datetime": 1528390824000,
"masked_author": "username_1",
"text": "Closing as Won't fix because it seems to be a bug in Chrome",
"title": null,
"type": "comment"
}
] | 2 | 4 | 613 | false | false | 613 | false |
acceptbitcoincash/acceptbitcoincash | acceptbitcoincash | 307,092,955 | 728 | null | [
{
"action": "opened",
"author": "accept-bitcoin-cash",
"comment_id": null,
"datetime": 1521595080000,
"masked_author": "username_0",
"text": "Requesting to add 'BitGild' to the 'precious metals' category. \n\nDetails follow: \n```yml \n- name: BitGild\n url: https://www.bitgild.com/\n img: \n twitter: Bitgildcom\n facebook: bitgild\n bch: Yes\n btc: Yes\n othercrypto: Yes\n```\n\n\nResources for adding this merchant:\nLogo Provided:\n\n\n[Link to BitGild](https://www.bitgild.com/)\nIf needed, try the twitter handles profile image: [twitter.com/Bitgildcom](https://twitter.com/Bitgildcom)\nIf needed, try the facebook handles profile image: [fb.com/bitgild](https://fb.com/bitgild)\n\n\n- Verify site is legitimate and safe to list.\n- Correct data in form if any is innacurate.\n\nIf everything looks okay, Add it to the site:\n- Assign to yourself when you begin work.\n- Download and resize the image and put it into the proper img folder.\n- Add listing alphabetically to proper .yml file.\n- Commit changes mentioning this issue number with 'closes #[ISSUE NUMBER HERE]'.",
"title": "Add 'BitGild' to the 'precious metals' category",
"type": "issue"
},
{
"action": "closed",
"author": "t0p0lin0",
"comment_id": null,
"datetime": 1521601241000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 986 | false | false | 986 | false |
cmusphinx/pocketsphinx-android-demo | cmusphinx | 283,227,940 | 47 | {
"number": 47,
"repo": "pocketsphinx-android-demo",
"user_login": "cmusphinx"
} | [
{
"action": "opened",
"author": "cesine",
"comment_id": null,
"datetime": 1513690079000,
"masked_author": "username_0",
"text": "To help make sure the demo builds if folks submit prs, to use it you have to: \r\n\r\n- Turn on travis for the `pocketsphinx-android-demo` repo https://travis-ci.org/profile/cmusphinx\r\n\r\n\r\nHow this was tested:\r\n\r\nhttps://travis-ci.org/username_0/pocketsphinx-android-demo/builds/318559284\r\n\r\n<img width=\"896\" alt=\"screen shot 2017-12-19 at 1 28 57 pm\" src=\"https://user-images.githubusercontent.com/196199/34159280-9a5d4886-e4c0-11e7-905a-2d15e531ffe2.png\">",
"title": "Added continuous integration",
"type": "issue"
},
{
"action": "created",
"author": "nshmyrev",
"comment_id": 357099657,
"datetime": 1515714737000,
"masked_author": "username_1",
"text": "Looks cool, thank you!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 472 | false | false | 472 | true |
Igalia/meta-webkit | Igalia | 409,913,810 | 69 | {
"number": 69,
"repo": "meta-webkit",
"user_login": "Igalia"
} | [
{
"action": "opened",
"author": "philn",
"comment_id": null,
"datetime": 1550078294000,
"masked_author": "username_0",
"text": "",
"title": "recipes-qt: Add a sample QtWPE mini browser application",
"type": "issue"
},
{
"action": "created",
"author": "psaavedra",
"comment_id": 463549925,
"datetime": 1550135401000,
"masked_author": "username_1",
"text": "This change doesn't affects to the test build preset: https://gitlab.com/saavedra.pablo/meta-perf-browser/pipelines/47476825\r\n\r\nI wonder if I should to create a additional one to build a QT image.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philn",
"comment_id": 463566201,
"datetime": 1550138335000,
"masked_author": "username_0",
"text": "Sounds like a good idea :)\r\n- it will work only with a git snaphot or the upcoming 2.24 wpewebkit release\r\n- enable qtwpe in wpewebkit's config\r\n- in your image add these packages:\r\n```\r\nIMAGE_INSTALL_append = \" wpewebkit-qtwpe-qml-plugin qt-wpe-simple-browser\"\r\n\r\nIMAGE_INSTALL_append = \" qtbase-dev qtbase-mkspecs qtbase-plugins qtbase-staticdev qttranslations-qtbase \\\r\n qtdeclarative-dev qtdeclarative-mkspecs qtdeclarative-qmlplugins qtdeclarative-tools qtdeclarative-staticdev \\\r\n qtimageformats-dev qtimageformats-plugins \\\r\n qtscript-dev qtscript-mkspecs \\\r\n qtsvg-dev qtsvg-mkspecs qtsvg-plugins \\\r\n qttools-dev qttools-mkspecs qttools-staticdev qttools-tools \\\r\n qtwayland-dev qtwayland-mkspecs qtwayland-plugins qtwayland-tools \\\r\n qtquickcontrols2 qtquickcontrols2-dev qtquickcontrols2-mkspecs\"\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "psaavedra",
"comment_id": 466923857,
"datetime": 1551084857000,
"masked_author": "username_1",
"text": "Added in the pipeline for trunk: https://gitlab.com/saavedra.pablo/meta-perf-browser/commit/e18e11182101640b3c5b0312d73d3783b83d4a51\r\n\r\nFirst build: https://gitlab.com/saavedra.pablo/meta-perf-browser/-/jobs/166887931",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "psaavedra",
"comment_id": 467143853,
"datetime": 1551122255000,
"masked_author": "username_1",
"text": "Success: https://gitlab.com/saavedra.pablo/meta-perf-browser/-/jobs/166952447",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,323 | false | false | 1,323 | false |
plone/plone-react | plone | 334,587,392 | 179 | {
"number": 179,
"repo": "plone-react",
"user_login": "plone"
} | [
{
"action": "opened",
"author": "nileshgulia1",
"comment_id": null,
"datetime": 1529602008000,
"masked_author": "username_0",
"text": "Some modification of `paths` configs to resolve paths from templates.",
"title": "modified paths",
"type": "issue"
}
] | 2 | 2 | 365 | false | true | 70 | false |
conan-community/conan-mingw-installer | conan-community | 330,360,593 | 21 | {
"number": 21,
"repo": "conan-mingw-installer",
"user_login": "conan-community"
} | [
{
"action": "opened",
"author": "ericLemanissier",
"comment_id": null,
"datetime": 1528391269000,
"masked_author": "username_0",
"text": "Currently, the recipe uses arch_build to choose between 32bits and 64bits of the recipe, but it actually depends on the target.\r\nThe bug can be seen here https://ci.appveyor.com/project/username_0/conan-mingw-installer/build/1.0.12#L792 : the recipe searches for a x86_64 mingw package whereas the settings are arch=x86, and it fails because there is no x86_64 with dwarf exception.\r\nThis PR uses the host_target instead, because what matters here is the platform on which the final program will run (neither the platform used for downloading mingw, nor the platform used to compile the final program)\r\n\r\n#fixes conan-community/community#18",
"title": "fix x86 target",
"type": "issue"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 395700331,
"datetime": 1528448973000,
"masked_author": "username_0",
"text": "I have no idea why the appveyor build failed. It just stopped without error message. The same happened on my fork, but at another step in the build: https://ci.appveyor.com/project/username_0/conan-mingw-installer/build/1.0.14",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "danimtb",
"comment_id": 395709102,
"datetime": 1528450934000,
"masked_author": "username_1",
"text": "hi @username_0 \r\n\r\nThanks for your PR. I understand the issue and I think it is quite particular of MinGW.\r\nHowever, I think there is no need to specify in the settings `os_target` as this is already the setting `os`.\r\n\r\nHave you tried just declaring `os` and `arch` with the rest of changes you made?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 395709505,
"datetime": 1528451026000,
"masked_author": "username_0",
"text": "I just did extensive tests on my computer, and it really works (including tests) in various configuration when I use only os and arch settings, and not the _target alternatives. I'll push the amended commits in few minutes",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 395780926,
"datetime": 1528468625000,
"masked_author": "username_0",
"text": "after several retries, I managed to get passed network errors, but build still failed because \"Build exceeded allowed resource quotas. Fix your build to consume less resources or contact AppVeyor support to request quotas increase.\". \r\nSo I added a commit to clear the build folder during package steps, so it should divide by 2 the disk space.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 395817401,
"datetime": 1528475884000,
"masked_author": "username_0",
"text": "once again, the build failed because of poor network connection to sourceforge, but it passed on my fork : https://ci.appveyor.com/project/username_0/conan-mingw-installer/build/1.0.25\r\n@username_2 what do you think about it ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lasote",
"comment_id": 396024500,
"datetime": 1528612290000,
"masked_author": "username_2",
"text": "Relaunching CI",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lasote",
"comment_id": 396024733,
"datetime": 1528612604000,
"masked_author": "username_2",
"text": "Is it possible to run mingw in an x86 machine?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 396034109,
"datetime": 1528622460000,
"masked_author": "username_0",
"text": "Yes, and it probably works without this PR.the problem is when you build consumer package on 64bits and you want to target 32bits: without this PR it takes 64 bits toolchain, but only 32bits toolchain is able to produce usable 32bits binaries",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericLemanissier",
"comment_id": 397540526,
"datetime": 1529048524000,
"masked_author": "username_0",
"text": "@username_2 what do you think of the PR ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lasote",
"comment_id": 397559818,
"datetime": 1529053345000,
"masked_author": "username_2",
"text": "Sorry, I forgot about it. I'm still a little worried about breaking something to the x86 users, but let's see how it goes.",
"title": null,
"type": "comment"
}
] | 3 | 11 | 2,437 | false | false | 2,437 | true |
kubeflow/examples | kubeflow | 378,979,277 | 318 | null | [
{
"action": "opened",
"author": "jlewi",
"comment_id": null,
"datetime": 1541724653000,
"masked_author": "username_0",
"text": "After running synchronous training for a while the ps (really the workers) started crashing with.\r\n\r\n```\r\n2018-11-07T23:51:00Z tensorflow \"code\": 429,\r\n2018-11-07T23:51:00Z tensorflow \"message\": \"The total number of changes to the object code-search-demo/models/20181107-dist-sync-gpu/model.ckpt-8000_temp_aa3d8a'\r\n2018-11-07T23:51:00Z tensorflow \t when uploading gs://code-search-demo/models/20181107-dist-sync-gpu/model.ckpt-8000_temp_aa3d8a9093914456acccf5aea627e82e/\r\n2018-11-07T23:51:01Z tensorflow 2018-11-07 23:51:01.577393: I tensorflow/core/platform/cloud/retrying_utils.cc:77] The operation failed and will be automatically retried in 1.49778 seconds (attempt 1 out of 10), caused by: Unavailable: Upload to gs://code-search-dem\r\no/models/20181107-dist-sync-gpu/model.ckpt-8000_temp_aa3d8a9093914456acccf5aea627e82e/ failed, caused by: Not found: Error executing an HTTP request: HTTP response code 410 with body '{\r\n2018-11-07T23:51:01Z tensorflow \"error\": {\r\n2018-11-07T23:51:01Z tensorflow \"errors\": [\r\n2018-11-07T23:51:01Z tensorflow {\r\n2018-11-07T23:51:01Z tensorflow \"domain\": \"usageLimits\",\r\n2018-11-07T23:51:01Z tensorflow \"reason\": \"rateLimitExceeded\",\r\n2018-11-07T23:51:01Z tensorflow \"message\": \"The total number of changes to the object code-search-demo/models/20181107-dist-sync-gpu/model.ckpt-8000_temp_aa3d8a9093914456acccf5aea627e82e/ exceeds the rate limit. Please reduce the rate of create, update, and dele\r\nte requests.\"\r\n2018-11-07T23:51:01Z tensorflow }\r\n2018-11-07T23:51:01Z tensorflow ],\r\n```\r\n\r\nThe chief then exited with\r\n\r\n```\r\n2018-11-08T17:22:51Z tensorflow INFO:tensorflow:An error was raised. This may be due to a preemption in a connected worker or parameter server. The current session will be closed and a new session will be created. Error: Socket closed\r\n```\r\n\r\nHere are the logs\r\n\r\n[demo-trainer-11-07-dist-sync-gpu-chief-0.log.txt](https://github.com/kubeflow/examples/files/2564182/demo-trainer-11-07-dist-sync-gpu-chief-0.log.txt)\r\n[demo-trainer-11-07-dist-sync-gpu-ps-0.log.txt](https://github.com/kubeflow/examples/files/2564184/demo-trainer-11-07-dist-sync-gpu-ps-0.log.txt)\r\n[demo-trainer-11-07-dist-sync-gpu-ps-1.log.txt](https://github.com/kubeflow/examples/files/2564185/demo-trainer-11-07-dist-sync-gpu-ps-1.log.txt)\r\n\r\nA couple questions come to mind \r\n\r\n1. Why are the ps trying to write the checkpoint files? Shouldn't it be the chief that writes the check point files? Is something misconfigured with distributed training?\r\n\r\n1. Why did the TFJob exit rather than restarting? Was the chief exit code set correctly?",
"title": "[code_search] synchronous training crashes; \"The total number of changes to the object exceeds the rate limit\"",
"type": "issue"
},
{
"action": "created",
"author": "jlewi",
"comment_id": 437211669,
"datetime": 1541725043000,
"masked_author": "username_0",
"text": "Here are the events for the TFJob.\r\n\r\n[events.txt](https://github.com/kubeflow/examples/files/2564205/events.txt)\r\n\r\nThe events indicated the PS exited and then it looks like the job failed. This looks like a bug. At a minimum why didn't we emit an event about the chief pod?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jlewi",
"comment_id": 437211893,
"datetime": 1541725128000,
"masked_author": "username_0",
"text": "[demo-trainer-11-07-dist-sync-gpu-chief-0.events.txt](https://github.com/kubeflow/examples/files/2564208/demo-trainer-11-07-dist-sync-gpu-chief-0.events.txt)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jlewi",
"comment_id": 437370082,
"datetime": 1541772566000,
"masked_author": "username_0",
"text": "@username_1 Do you know off hand whether its the chief that writes the checkpoints in the case of synchronous training?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jlewi",
"comment_id": 437372368,
"datetime": 1541773070000,
"masked_author": "username_0",
"text": "It looks like if \"Chief\" is specified in the job spec; T2T thinks its an async job and changes the RunConfig\r\nhttps://github.com/tensorflow/tensor2tensor/blob/091373cd5eade2f108ad0fd8a209df3a5cf76598/tensor2tensor/utils/trainer_lib.py#L132\r\n\r\nHere's the job spec\r\n[demo-trainer-11-07-dist-sync-gpu.yaml.txt](https://github.com/kubeflow/examples/files/2566169/demo-trainer-11-07-dist-sync-gpu.yaml.txt)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cwbeitel",
"comment_id": 437439667,
"datetime": 1541785745000,
"masked_author": "username_1",
"text": "@username_0 I tried repeating what worked for me previously and I got the same master error you are seeing about a gRPC failure, here are my logs and configs:\r\n\r\nMaster config: https://gist.github.com/username_1/7a6404ad1639af57518cfbf0432def8f\r\nMaster logs: https://gist.github.com/username_1/0b65d9234e66198c11e99ea84bf65779\r\n\r\nPS/worker conifg: https://gist.github.com/username_1/234036082f70fb1254a390535f6a510a\r\nPS/worker logs: https://gist.github.com/username_1/67669a314bcd0761d97a2665958b0e62\r\n\r\nThis is interesting because (1) it failed much sooner than yours, and (2) it failed when it hadn't been before with the only change I know of being from transformer_tiny to transformer_base hparams. You could verify something similar happens for you by running a job with 2 workers and still with tarnsformer_base as well as a job with transformer_tiny. I'm guessing the issue relates in part to model size which should in turn mean more data transmitted (and perhaps more write operations) at some point in the chain.\r\n\r\nBut I don't know why the PS are attempting to write anything. Perhaps only gradients are communicated over gRPC and model parameters are written to disk by workers and aggregated by master at checkpoint writing time?\r\n\r\nAlso what tf logging verbosity are you using? Some of your extra log info is probably coming from using more recent versions of tf and t2t.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cwbeitel",
"comment_id": 438024096,
"datetime": 1542055858000,
"masked_author": "username_1",
"text": "@username_0 In the worst case we could just have training nodes write checkpoints to NFS and use a separate process for syncing checkpoints to GCS, perhaps only those that have finished being written (i.e. not those with _temp... or whatever in the checkpoint name).",
"title": null,
"type": "comment"
}
] | 3 | 9 | 5,439 | false | true | 5,267 | true |
apache/cordova-cli | apache | 393,471,259 | 393 | null | [
{
"action": "opened",
"author": "bucktechnologies",
"comment_id": null,
"datetime": 1545401345000,
"masked_author": "username_0",
"text": "I am trying to run cordova command on my command line, but any comand i execute, the cordova process hungs forever and does not execute successfully for example, i am trying to build my cordova app for android, when i i type \r\n`cordova run android --target=127.0.0.1:5000 --verbose` \r\ni get the following report\r\n` No scripts found for hook \"before_run\".\r\nNo scripts found for hook \"before_prepare\".\r\nChecking config.xml and package.json for saved platforms that haven't been added to the project\r\nConfig.xml and package.json platforms are the same. No pkg.json modification.\r\nPackage.json and config.xml platforms are different. Updating config.xml with most current list of platforms.\r\nPlatformApi successfully found for platform android\r\nAndroid Studio project detected\r\nChecking config.xml for saved plugins that haven't been added to the project\r\nChecking for any plugins added to the project that have not been installed in android platform\r\nNo differences found between plugins added to project and installed in android platform. Continuing...\r\nGenerating platform-specific config.xml from defaults for android at C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\app\\src\\main\\res\\xml\\config.xml\r\nMerging project's config.xml into platform-specific android config.xml\r\nMerging and updating files from [www, platforms\\android\\platform_www] to platforms\\android\\app\\src\\main\\assets\\www\r\nWrote out android application name \"Campus E-Notice\" to C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\app\\src\\main\\res\\values\\strings.xml\r\nandroid-versionCode not found in config.xml. Generating a code based on version in config.xml (1.0.0): 10000\r\nWrote out Android package name \"co.bucktechnology.co\" to C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\app\\src\\main\\java\\co\\bucktechnology\\co\\MainActivity.java\r\nThis app does not have launcher icons defined\r\nThis app does not have splash screens defined\r\nUpdating resource files at platforms\\android\r\nPrepared android project successfully\r\nNo scripts found for hook \"after_prepare\".\r\nANDROID_HOME=D:\\android\\sdk\r\nJAVA_HOME=C:\\Program Files\\Java\\jdk1.8.0_111\r\nstudio\r\nSubproject Path: CordovaLib\r\nSubproject Path: app\r\nRunning command: cmd \"/s /c \"C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\gradlew.bat cdvBuildDebug -b C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\build.gradle -Dorg.gradle.daemon=true -Dorg.gradle.jvmargs=-Xmx2048m\"\"\r\nStarting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details\r\npublishNonDefault is deprecated and has no effect anymore. All variants are now published.\r\nObserved package id 'add-ons;addon-google_apis-google-24' in inconsistent location 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24-1' (Expected 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24')\r\nAlready observed package id 'add-ons;addon-google_apis-google-24' in 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24'. Skipping duplicate at 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24-1'\r\nObserved package id 'add-ons;addon-google_apis-google-24' in inconsistent location 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24-1' (Expected 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24')\r\nAlready observed package id 'add-ons;addon-google_apis-google-24' in 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24'. Skipping duplicate at 'D:\\android\\sdk\\add-ons\\addon-google_apis-google-24-1'\r\nThe Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.\r\n at build_9308avscpha59jkwt518ezcf1.run(C:\\Users\\HP-15\\Campus-Enotice-Android\\platforms\\android\\app\\build.gradle:150)\r\nConfiguration 'compile' in project ':app' is deprecated. Use 'implementation' instead.\r\nCould not find google-services.json while looking in [src/nullnull/debug, src/debug/nullnull, src/nullnull, src/debug, src/nullnullDebug]\r\nregisterResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)\r\nCould not find google-services.json while looking in [src/nullnull/release, src/release/nullnull, src/nullnull, src/release, src/nullnullRelease]\r\nregisterResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)\r\n:CordovaLib:preBuild UP-TO-DATE\r\n:CordovaLib:preDebugBuild UP-TO-DATE\r\n:CordovaLib:compileDebugAidl UP-TO-DATE\r\n:CordovaLib:compileDebugRenderscript UP-TO-DATE\r\n:CordovaLib:checkDebugManifest UP-TO-DATE\r\n:CordovaLib:generateDebugBuildConfig UP-TO-DATE\r\n:CordovaLib:prepareLintJar UP-TO-DATE\r\n:CordovaLib:generateDebugResValues UP-TO-DATE\r\n:CordovaLib:generateDebugResources UP-TO-DATE\r\n:CordovaLib:packageDebugResources UP-TO-DATE\r\n:CordovaLib:platformAttrExtractor\r\n:CordovaLib:processDebugManifest UP-TO-DATE\r\n:CordovaLib:javaPreCompileDebug UP-TO-DATE\r\n:CordovaLib:processDebugJavaRes NO-SOURCE\r\n:app:preBuild UP-TO-DATE\r\n:app:preDebugBuild `\r\n\r\nAnd it stays like this for hours without executing further.\r\nWhat is its that am doing wrong? Am using npm version 6.4.1 and cordova version 8.1.2",
"title": "Cordova cammands doesn't execute properly rather it hangs forever",
"type": "issue"
},
{
"action": "created",
"author": "janpio",
"comment_id": 449402818,
"datetime": 1545402634000,
"masked_author": "username_1",
"text": "Does `cordova run android` work for a new project created with `cordova create`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449403819,
"datetime": 1545402884000,
"masked_author": "username_0",
"text": "anything i type with cordova, just hangs.... for example when i type `cordova create example.co` i get\r\n`Creating a new cordova project.\r\n\r\n`\r\nthat is it... its still loading",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "janpio",
"comment_id": 449404116,
"datetime": 1545402954000,
"masked_author": "username_1",
"text": "`cordova -v`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449406602,
"datetime": 1545403540000,
"masked_author": "username_0",
"text": "when i run `cordova -v -verbose` i get `8.1.2 (cordova-lib@8.1.1)` that is it, it doesnt terminate the process after.\r\nam using windows, so my CMD is using memory",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449409284,
"datetime": 1545404177000,
"masked_author": "username_0",
"text": "this is a view of what i get [https://jmp.sh/v/ubuY6paaRG5AkqDEGYDR](https://jmp.sh/v/ubuY6paaRG5AkqDEGYDR)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "janpio",
"comment_id": 449409506,
"datetime": 1545404227000,
"masked_author": "username_1",
"text": "What is using those other 22% of CPU? Something blocking file access maybe?\r\nHow long did you wait?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "janpio",
"comment_id": 449409553,
"datetime": 1545404238000,
"masked_author": "username_1",
"text": "Does `cordova info` work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449411853,
"datetime": 1545404794000,
"masked_author": "username_0",
"text": "google chrome and steam applications. and currents i am still waiting for the saving android@~7.1.4 into config.xml file... to finish",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449413421,
"datetime": 1545405189000,
"masked_author": "username_0",
"text": "yes it works but as i said, after they run, they don't terminate and just there hanging",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449415874,
"datetime": 1545405730000,
"masked_author": "username_0",
"text": "i get this when i run `cordova info`\r\n\r\n`Collecting Data...\r\n\r\n\r\nNode version: v10.14.2\r\n\r\nCordova version: 8.1.1\r\n\r\nConfig.xml file:\r\n\r\n<?xml version='1.0' encoding='utf-8'?>\r\n<widget id=\"io.cordova.hellocordova\" version=\"1.0.0\" xmlns=\"http://www.w3.org/ns/widgets\" xmlns:cdv=\"http://cordova.apache.org/ns/1.0\">\r\n <name>HelloCordova</name>\r\n <description>\r\n A sample Apache Cordova application that responds to the deviceready event.\r\n </description>\r\n <author email=\"dev@cordova.apache.org\" href=\"http://cordova.io\">\r\n Apache Cordova Team\r\n </author>\r\n <content src=\"index.html\" />\r\n <plugin name=\"cordova-plugin-whitelist\" spec=\"1\" />\r\n <access origin=\"*\" />\r\n <allow-intent href=\"http://*/*\" />\r\n <allow-intent href=\"https://*/*\" />\r\n <allow-intent href=\"tel:*\" />\r\n <allow-intent href=\"sms:*\" />\r\n <allow-intent href=\"mailto:*\" />\r\n <allow-intent href=\"geo:*\" />\r\n <platform name=\"android\">\r\n <allow-intent href=\"market:*\" />\r\n </platform>\r\n <platform name=\"ios\">\r\n <allow-intent href=\"itms:*\" />\r\n <allow-intent href=\"itms-apps:*\" />\r\n </platform>\r\n <engine name=\"android\" spec=\"~7.1.4\" />\r\n</widget>\r\n\r\n\r\nPlugins:\r\n\r\ncordova-plugin-whitelist\r\n\r\nError retrieving Android platform information:\r\nAndroid SDK is not set up properly. Make sure that the Android SDK 'tools' and 'platform-tools' directories are in the PATH variable.\r\n\r\nError: cmd: Command failed with exit code 1 Error output:\r\n'android' is not recognized as an internal or external command,\r\noperable program or batch file.`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bucktechnologies",
"comment_id": 449567713,
"datetime": 1545482887000,
"masked_author": "username_0",
"text": "It was an internet connection issue, my ISP blocked my google services temporarily hence causing the gradle service not to download the new and updated files... so anytime I run Cordova, it looks to continue with the downloading process, which causes the command line to hang. After I got a proper connection to Google services, everything was executed perfectly.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bucktechnologies",
"comment_id": null,
"datetime": 1545482947000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jfoclpf",
"comment_id": 679358240,
"datetime": 1598302121000,
"masked_author": "username_2",
"text": "@username_0 can you tell us exactly what services were not available (urls or domains)? I'm having the same issue. I think it has to do with gradle, but I am unable to debug it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jfoclpf",
"comment_id": 679359176,
"datetime": 1598302244000,
"masked_author": "username_2",
"text": "NO, in my case, was something different, the gradle was locked. I had do delete the lock file. \r\n\r\n```\r\nfind ~/.gradle -type f -name \"*.lock\" -delete\r\n```",
"title": null,
"type": "comment"
}
] | 3 | 15 | 8,199 | false | false | 8,199 | true |
laravel/framework | laravel | 260,245,950 | 21,380 | {
"number": 21380,
"repo": "framework",
"user_login": "laravel"
} | [
{
"action": "opened",
"author": "edoger",
"comment_id": null,
"datetime": 1506339825000,
"masked_author": "username_0",
"text": "This can wrap a non-array value into an associative array.",
"title": "Extend the Arr::wrap() method.",
"type": "issue"
},
{
"action": "created",
"author": "deleugpn",
"comment_id": 331858916,
"datetime": 1506340684000,
"masked_author": "username_1",
"text": "maybe a separate method called `wrapAnything` would be a better option than the optional parameter?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edoger",
"comment_id": 331866482,
"datetime": 1506342737000,
"masked_author": "username_0",
"text": "@username_1 I think this is more in line with semantics. What do you think?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "taylorotwell",
"comment_id": 331868617,
"datetime": 1506343298000,
"masked_author": "username_2",
"text": "No plans to change this right now.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 266 | false | false | 266 | true |
joelburget/react-haskell | null | 98,414,011 | 22 | null | [
{
"action": "opened",
"author": "bergey",
"comment_id": null,
"datetime": 1438356732000,
"masked_author": "username_0",
"text": "It looks as though `ReactNode` admits a `Functor` instance, which would use `LocalNode` but pick the `insig -> sig` function at the use site, rather than a type-based default. Is there a reason this instance is not provided? Would you accept a PR?\r\n\r\nThe `Functor` laws aren't exactly obeyed, because you can count how many times `fmap` has been applied. I'm not sure this matters, since the constructors aren't exported. I'd be fine with some `sigMap` though, with the same type but without the laws.",
"title": "Functor instance for ReactNode",
"type": "issue"
},
{
"action": "created",
"author": "joelburget",
"comment_id": 126832027,
"datetime": 1438384207000,
"masked_author": "username_1",
"text": "Absolutely.\r\n\r\nLet's start with `sigMap`, since, as you say, the laws are not followed. After that, will think about making a `Functor` instance.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "joelburget",
"comment_id": null,
"datetime": 1438485468000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 650 | false | false | 650 | false |
rust-lang/rust | rust-lang | 319,422,506 | 50,386 | null | [
{
"action": "opened",
"author": "hanyuwei70",
"comment_id": null,
"datetime": 1525241940000,
"masked_author": "username_0",
"text": "When the BOM is presented in the input stream, `String` object should strip it and do not output BOM.",
"title": "std::string::String should strip UTF BOM",
"type": "issue"
},
{
"action": "created",
"author": "alexcrichton",
"comment_id": 386035142,
"datetime": 1525277867000,
"masked_author": "username_1",
"text": "I would agree, yeah, that this is likely an RFC topic rather than an issue or a PR",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "SimonSapin",
"comment_id": 386035566,
"datetime": 1525277945000,
"masked_author": "username_2",
"text": "It’s not clear what is being proposed. Which APIs exactly should strip?\r\n\r\nAnd more importantly, why? I tend to think of these standard library API as low-level primitives, and feel that BOM removal would tend to belong more in a higher library that might for example also support multiple encodings and detect the presence of a BOM to help pick one. And even then, maybe not always. https://docs.rs/encoding_rs/0.7.2/encoding_rs/struct.Decoder.html#impl has different methods for different use cases, only some of them remove a BOM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "BurntSushi",
"comment_id": 386056665,
"datetime": 1525282110000,
"masked_author": "username_3",
"text": "I also agree this requires an RFC and side with @username_2 on this. I think we would need exceptional motivation to do this.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "steveklabnik",
"comment_id": null,
"datetime": 1525291571000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "steveklabnik",
"comment_id": 386103928,
"datetime": 1525291571000,
"masked_author": "username_4",
"text": "Thanks all! @username_0 please pursue one of them if you think you can address these comments: https://github.com/rust-lang/rfcs",
"title": null,
"type": "comment"
}
] | 5 | 6 | 969 | false | false | 969 | true |
dart-lang/sdk | dart-lang | 406,636,119 | 35,857 | null | [
{
"action": "opened",
"author": "praveen-francium",
"comment_id": null,
"datetime": 1549344559000,
"masked_author": "username_0",
"text": "Analyzer Feedback from IntelliJ\r\n\r\n## Version information\r\n\r\n- `IDEA IC-183.5429.30`\r\n- `2.1.0-dev.9.4`\r\n- `IC-183.5429.30, JRE 1.8.0_152-release-1343-b26x64 JetBrains s.r.o, OS Linux(amd64) v4.15.0-43-generic, screens 1920x1080`\r\n\r\n## Exception\r\n```\r\nDart analysis server, SDK version 2.1.0-dev.9.4, server version 1.21.1, FATAL error: Failed to handle request: {id: 567, method: edit.getFixes, params: {file: /home/praveen/workspace/mortgage_agent_app/lib/scopped_models/user_model.dart, offset: 6534}, clientRequestTime: 1549342837911}\r\ntype 'MixinDeclarationImpl' is not a subtype of type 'ClassDeclaration'\r\n#0 FixProcessor._addFix_undefinedMethod_create (package:analysis_server/src/services/correction/fix_internal.dart:3315:9)\r\n<asynchronous suspension>\r\n#1 FixProcessor.compute (package:analysis_server/src/services/correction/fix_internal.dart:535:13)\r\n<asynchronous suspension>\r\n#2 DefaultFixContributor.internalComputeFixes (package:analysis_server/src/services/correction/fix_internal.dart:89:41)\r\n<asynchronous suspension>\r\n#3 EditDomainHandler._computeServerErrorFixes (package:analysis_server/src/edit/edit_domain.dart:580:49)\r\n<asynchronous suspension>\r\n#4 EditDomainHandler.getFixes (package:analysis_server/src/edit/edit_domain.dart:252:32)\r\n<asynchronous suspension>\r\n#5 EditDomainHandler.handleRequest (package:analysis_server/src/edit/edit_domain.dart:360:9)\r\n#6 AnalysisServer.handleRequest.<anonymous closure>.<anonymous closure> (package:analysis_server/src/analysis_server.dart:645:45)\r\n#7 _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:258:15)\r\n#8 AnalysisServer.handleRequest.<anonymous closure> (package:analysis_server/src/analysis_server.dart:641:50)\r\n#9 _rootRun (dart:async/zone.dart:1124:13)\r\n#10 _CustomZone.run (dart:async/zone.dart:1021:19)\r\n#11 _runZoned (dart:async/zone.dart:1516:10)\r\n#12 runZoned (dart:async/zone.dart:1500:12)\r\n#13 AnalysisServer.handleRequest (package:analysis_server/src/analysis_server.dart:640:5)\r\n#14 ByteStreamServerChannel._readRequest.<anonymous closure> (package:analysis_server/src/channel/byte_stream_channel.dart:174:16)\r\n#15 _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:258:15)\r\n#16 ByteStreamServerChannel._readRequest (package:analysis_server/src/channel/byte_stream_channel.dart:165:47)\r\n#17 ByteStreamServerChannel.listen.<anonymous closure> (package:analysis_server/src/channel/byte_stream_channel.dart:110:26)\r\n#18 _rootRunUnary (dart:async/zone.dart:1132:38)\r\n#19 _CustomZone.runUnary (dart:async/zone.dart:1029:19)\r\n#20 _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)\r\n#21 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)\r\n#22 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)\r\n#23 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:68:11)\r\n#24 _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11)\r\n#25 _StringAdapterSink.add (dart:convert/string_conversion.dart:268:11)\r\n#26 _LineSplitterSink._addLines (dart:convert/line_splitter.dart:154:13)\r\n#27 _LineSplitterSink.addSlice (dart:convert/line_splitter.dart:129:5)\r\n#28 StringConversionSinkMixin.add (dart:convert/string_conversion.dart:189:5)\r\n#29 _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:120:24)\r\n#30 _rootRunUnary (dart:async/zone.dart:1132:38)\r\n#31 _CustomZone.runUnary (dart:async/zone.dart:1029:19)\r\n#32 _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)\r\n#33 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)\r\n#34 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)\r\n#35 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:68:11)\r\n#36 _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11)\r\n#37 _StringAdapterSink.add (dart:convert/string_conversion.dart:268:11)\r\n#38 _StringAdapterSink.addSlice (dart:convert/string_conversion.dart:273:7)\r\n#39 _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:348:20)\r\n#40 _Utf8ConversionSink.add (dart:convert/string_conversion.dart:341:5)\r\n#41 _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:86:18)\r\n#42 _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:120:24)\r\n#43 _rootRunUnary (dart:async/zone.dart:1132:38)\r\n#44 _CustomZone.runUnary (dart:async/zone.dart:1029:19)\r\n#45 _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)\r\n#46 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)\r\n#47 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)\r\n#48 _SyncStreamController._sendData (dart:async/stream_controller.dart:763:19)\r\n#49 _StreamController._add (dart:async/stream_controller.dart:639:7)\r\n#50 _StreamController.add (dart:async/stream_controller.dart:585:5)\r\n#51 _Socket._onData (dart:io/runtime/binsocket_patch.dart:1721:41)\r\n#52 _rootRunUnary (dart:async/zone.dart:1136:13)\r\n#53 _CustomZone.runUnary (dart:async/zone.dart:1029:19)\r\n#54 _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)\r\n#55 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)\r\n#56 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)\r\n#57 _SyncStreamController._sendData (dart:async/stream_controller.dart:763:19)\r\n#58 _StreamController._add (dart:async/stream_controller.dart:639:7)\r\n#59 _StreamController.add (dart:async/stream_controller.dart:585:5)\r\n#60 new _RawSocket.<anonymous closure> (dart:io/runtime/binsocket_patch.dart:1283:33)\r\n#61 _NativeSocket.issueReadEvent.issue (dart:io/runtime/binsocket_patch.dart:826:14)\r\n#62 _microtaskLoop (dart:async/schedule_microtask.dart:41:21)\r\n#63 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)\r\n#64 _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13)\r\n#65 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5)\r\n```\r\n\r\nFor additional log information, please append the contents of\r\nfile:///tmp/report.txt.",
"title": "FixProcessor: type 'MixinDeclarationImpl' is not a subtype of type 'ClassDeclaration'",
"type": "issue"
},
{
"action": "closed",
"author": "stereotype441",
"comment_id": null,
"datetime": 1549649247000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "stereotype441",
"comment_id": 461893097,
"datetime": 1549649247000,
"masked_author": "username_1",
"text": "This was fixed by @scheglov in 2784473939b664efa46863ad85147745447ba796.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 6,400 | false | false | 6,400 | false |
scikit-learn/scikit-learn | scikit-learn | 277,690,121 | 10,216 | null | [
{
"action": "opened",
"author": "jnothman",
"comment_id": null,
"datetime": 1511949049000,
"masked_author": "username_0",
"text": "export_graphviz currently has [code that checks](https://github.com/scikit-learn/scikit-learn/blob/4bba21659c68d65b4555ea86751aac1fab9fd8e4/sklearn/tree/export.py#L461) if it's operating on a Tree instance or an estimator with a `tree_` attribute, but also [has](https://github.com/scikit-learn/scikit-learn/blob/4bba21659c68d65b4555ea86751aac1fab9fd8e4/sklearn/tree/export.py#L392) [code](https://github.com/scikit-learn/scikit-learn/blob/4bba21659c68d65b4555ea86751aac1fab9fd8e4/sklearn/tree/export.py#L424) that forces it to only operate on an estimator. One or the other of these should change. Either we force it to be an estimator, or we test that it's okay to be a Tree!",
"title": "export_graphviz should work with a sklearn.tree._tree.Tree",
"type": "issue"
},
{
"action": "created",
"author": "mabelvj",
"comment_id": 347840087,
"datetime": 1511956921000,
"masked_author": "username_1",
"text": "Could I try this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mabelvj",
"comment_id": 347840458,
"datetime": 1511957020000,
"masked_author": "username_1",
"text": "Could I try this? Whenever they decide what's the best option.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 347988377,
"datetime": 1511987813000,
"masked_author": "username_0",
"text": "I don't have a strong preference for either option. Neither will break\nbackwards compatibility and we could always add Tree support later.\ncurrently all our ensembles are ensembles of tree classifiers/regressors, I\nthink, not of trees themselves. @username_2 might have an opinion as the\nincumbent tree expert.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glemaitre",
"comment_id": 348008819,
"datetime": 1511992373000,
"masked_author": "username_2",
"text": "I would say estimator. However, I need to go trough #1046 to understand why the code is currently as it is. I keep inform soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glemaitre",
"comment_id": 348010658,
"datetime": 1511992765000,
"masked_author": "username_2",
"text": "`estimators_` in GradienBoosting are `DecisionTreeRegressor` and not `Tree` anymore. So IMO, there is needs to support anymore `Tree` directly. I would agree with @amueller comment mentioning that tree_.Tree is an internal thing and that we could keep the user away from it, now that this is possible.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 348024225,
"datetime": 1511996056000,
"masked_author": "username_0",
"text": "_tree.Tree is not quite an internal thing, IMO. It's needed in some\napplications, and it's accessible through a public attribute.\n\nStill, I'm happy to not support it here.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jnothman",
"comment_id": null,
"datetime": 1512354501000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 8 | 1,664 | false | false | 1,664 | true |
labd/commercetools-go-sdk | labd | 355,155,103 | 16 | {
"number": 16,
"repo": "commercetools-go-sdk",
"user_login": "labd"
} | [
{
"action": "opened",
"author": "jberghoef",
"comment_id": null,
"datetime": 1535548520000,
"masked_author": "username_0",
"text": "",
"title": "Update go 1.11 module files and update travisci to use 1.11",
"type": "issue"
}
] | 2 | 2 | 0 | false | true | 0 | false |
MerEComm/AdminPanel | MerEComm | 335,097,709 | 4 | null | [
{
"action": "opened",
"author": "merzido",
"comment_id": null,
"datetime": 1529757838000,
"masked_author": "username_0",
"text": "",
"title": "Admin - Attribute Management ",
"type": "issue"
},
{
"action": "created",
"author": "merzido",
"comment_id": 399728549,
"datetime": 1529815281000,
"masked_author": "username_0",
"text": "Attributes management to be same as of Category Management",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "merzido",
"comment_id": 401038813,
"datetime": 1530193320000,
"masked_author": "username_0",
"text": "- Attr Master name to be changed to Attributes Management \r\n-Attr Master Delete not working\r\n- Attrid ID to be displayed \r\n- Check Box for Bulk Action\r\n- View Button on each row",
"title": null,
"type": "comment"
}
] | 1 | 3 | 238 | false | false | 238 | false |
andyleap/microformats | null | 79,015,267 | 1 | null | [
{
"action": "opened",
"author": "barnabywalters",
"comment_id": null,
"datetime": 1432218005000,
"masked_author": "username_0",
"text": "E.g. given the input URL `https://example.org` and this HTML:\r\n\r\n```html\r\n<span class=\"h-card\"><img src=\"/photo.png\" /> Barnaby</span>\r\n```\r\n\r\nthe expected output is for the URL in the photo property to be `https://example.org/photo.png`, but currently it is just `/photo.png`",
"title": "Implied photo URLs are not resolved against the document URL",
"type": "issue"
},
{
"action": "closed",
"author": "andyleap",
"comment_id": null,
"datetime": 1432218208000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 276 | false | false | 276 | false |
Azure/azure-sdk-for-python | Azure | 156,924,305 | 612 | null | [
{
"action": "opened",
"author": "trondhindenes",
"comment_id": null,
"datetime": 1464248902000,
"masked_author": "username_0",
"text": "When installing using pip install azure --pre, I'm not getting a version number from the azure module:\r\nazure.mgmt.compute.VERSION\r\n\r\nThis breaks a ton of dependencies, please fix!",
"title": "Version doesn't report number",
"type": "issue"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 221950584,
"datetime": 1464286381000,
"masked_author": "username_1",
"text": "Hello,\r\n\r\nThe version number was not accurate before and did not reflect the current package version, it was an internal version number not relevant to the content.\r\nCould you explain why it's breaking something in your case?\r\n\r\nThank you,",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 221952888,
"datetime": 1464286896000,
"masked_author": "username_0",
"text": "The AzureRM modules for Ansible (which were written by MSFT @devigned and some others) perform a version check. That version check seems to fail for newer versions of the module. I haven't dug too deep, but I feel we need all the consistency we can get, especially with the python modules changing left and right atm.\r\n\r\nhttps://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/azure_rm_common.py#L78",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 221982480,
"datetime": 1464293901000,
"masked_author": "username_1",
"text": "Actually the current Ansible plugin can not work with the RC4, I made the PR to fix the plugin:\r\nhttps://github.com/ansible/azurerm/pull/12\r\nhttps://github.com/ansible/ansible-modules-extras/pull/2319",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 222502679,
"datetime": 1464618043000,
"masked_author": "username_0",
"text": "Thanks, but we still need to be able to check the installed version thru code. The python module doesn't seem to honor the __version__ attribute, so how are we supposed to do that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 223076409,
"datetime": 1464804310000,
"masked_author": "username_0",
"text": "@username_1 so what's the plan going forwad? How can I from within my python code check the installed version of the python module for azure?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 223357132,
"datetime": 1464887310000,
"masked_author": "username_1",
"text": "You can't currently :(\r\nI talked with @username_2 at the PyCon, it seems that you can maybe disable this for now, and I will add a `__version__` attribute in the next release.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 223358165,
"datetime": 1464887541000,
"masked_author": "username_0",
"text": "wow, you guys certainly don't make it easy for us. Thanks for adding __version__ back.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 223358592,
"datetime": 1464887634000,
"masked_author": "username_0",
"text": "btw, it would be really great if the new `__version__` attribute would follow standard versioning formatting, like every other python module in the world does.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 223375489,
"datetime": 1464891185000,
"masked_author": "username_1",
"text": "@username_0 \"don't make it easy\"? :(\r\nAt the second I published the RC4, I was doing the PR to the Ansible repo with the new code. I didn't know that you were using the version attribute, since the content was false I didn't realize that someone could use it (my mistake). I answered to you as fast as possible, considering the PyCon. I went to the Ansible booth at the PyCon to discuss this point with you. I tell you that I will add the `__version__` attribute in the next release as a priority.\r\nAnd yes, I will follow semantic versioning in the attribute.as the rest of the world does, I know the rest of the world does. Again, this version attribute was not \"finished\" and our plan was to make it clean for the stable release.\r\nWhy do you think I'm not cooperative with you? What do you want more?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trondhindenes",
"comment_id": 223379526,
"datetime": 1464891999000,
"masked_author": "username_0",
"text": "My apologies, that was unnecessary.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 228218057,
"datetime": 1466725405000,
"masked_author": "username_1",
"text": "Hi @username_0 \r\n\r\nThe releases 2.0.0RC5 / 0.30.0rc5 are released with the `__version__` attribute ready to use. Sorry again for the inconvenience caused by this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nitzmahone",
"comment_id": 228219298,
"datetime": 1466725899000,
"masked_author": "username_2",
"text": "@username_1 Thanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lmazuel",
"comment_id": null,
"datetime": 1467070522000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 14 | 2,798 | false | false | 2,798 | true |
sqlcipher/android-database-sqlcipher | sqlcipher | 173,250,351 | 256 | null | [
{
"action": "opened",
"author": "JulioV",
"comment_id": null,
"datetime": 1472142548000,
"masked_author": "username_0",
"text": "I can't decrypt a database created in Android on Linux. I'm using this command:\r\n\r\n`PRAGMA key='abcde';ATTACH DATABASE '/home/julio/Desktop/aware.db' AS plaintext KEY '';`\r\n\r\nbut I get: Error: file is encrypted or is not a database.\r\n\r\nMy app is working OK so I assume the database is accessible. I'm using the latest version of Android SQLCipher (compile 'net.zetetic:android-database-sqlcipher:3.5.3@aar') and version 3.11.0 of SQLCipher for Linux (Ubuntu 15.04). I ran PRAGMA cipher_version on the Android app and I got 3.4.0. I ran the test suite for Android and all 53 tests passed.\r\n \r\nIn my android java class I'm importing:\r\n```\r\nimport net.sqlcipher.database.SQLiteDatabase;\r\nimport net.sqlcipher.database.SQLiteDatabase.CursorFactory;\r\nimport net.sqlcipher.database.SQLiteOpenHelper;\r\n```\r\nBefore trying the newest Android version I was using an old one. I can't pinpoint which one exactly but it was from when we needed to import icudt46l.zip to assets, commons-codec, guava and sqlcipher.jar to gradle and the .so libraries to the JNI folders.",
"title": "FIle is encrypted or is not a database",
"type": "issue"
},
{
"action": "created",
"author": "sjlombardo",
"comment_id": 242795975,
"datetime": 1472231910000,
"masked_author": "username_1",
"text": "@username_0 - What do you get back when you run PRAGMA cipher_version on the linux build? \r\n\r\nAre there any other non-default runtime pragmas being used on Android when creating the database, e.g. PRAGMA kdf_iter or PRAGMA cipher_use_hmac?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JulioV",
"comment_id": 243375913,
"datetime": 1472547346000,
"masked_author": "username_0",
"text": "cipher_version on the linux build is 3.4.0. I'm not sure about the other pragmas, if there is something I would need to configure manually I would say no since I use the default options:\r\n\r\n`SQLiteDatabase.openOrCreateDatabase(database_file.getPath(), \"abcde\",null,null);`\r\n\r\nI will try to delete all the old SQLCipher libraries and files.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sjlombardo",
"comment_id": 243453481,
"datetime": 1472566591000,
"masked_author": "username_1",
"text": "@username_0 the two should be compatible. Could you generate a sample database that doesn't contain any sensitive data for us to look at?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JulioV",
"comment_id": 243715747,
"datetime": 1472637190000,
"masked_author": "username_0",
"text": "Sure, here it is: https://ufile.io/ceedb",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sjlombardo",
"comment_id": 244210221,
"datetime": 1472763479000,
"masked_author": "username_1",
"text": "@username_0 I was just able to open that database using the SQLCipher 3.4.0 command line tool with the given password. Can you post the full log of how you are building and opening the file on linux?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JulioV",
"comment_id": 244556400,
"datetime": 1472920594000,
"masked_author": "username_0",
"text": "First I clone SQLCipher:\r\n```\r\ngit clone https://github.com/sqlcipher/sqlcipher.git\r\n```\r\nThen I configure it\r\n```\r\n./configure --enable-tempstore=yes CFLAGS=\"-DSQLITE_HAS_CODEC\" \\\r\n LDFLAGS=\"-lcrypto\"\r\n```\r\nThis is the output: http://pastebin.com/nCKPaJUT\r\n\r\nThen I make it:\r\n```\r\nmake\r\n```\r\nThis is the output: http://pastebin.com/fkmJBhw3\r\n\r\nI execute it:\r\n```\r\n./sqlcipher\r\n```\r\nthen when the sqlite> command line opens I do:\r\n```\r\nPRAGMA key='abcde';ATTACH DATABASE '/home/julio/Desktop/battery.db' AS plaintext KEY '';\r\n```\r\nand I get: Error: file is encrypted or is not a database",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sjlombardo",
"comment_id": 245088519,
"datetime": 1473195365000,
"masked_author": "username_1",
"text": "If battery.db is the encrypted database, you need to open it like this\r\n\r\n```\r\n./sqlcipher /home/julio/Desktop/battery.db\r\nsqlite> PRAGMA KEY = 'abcde';\r\nsqlite> SELECT * FROM battery;\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sjlombardo",
"comment_id": null,
"datetime": 1473195365000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 9 | 2,778 | false | false | 2,778 | true |
neuropsychology/psycho.R | neuropsychology | 310,054,371 | 42 | {
"number": 42,
"repo": "psycho.R",
"user_login": "neuropsychology"
} | [
{
"action": "opened",
"author": "DominiqueMakowski",
"comment_id": null,
"datetime": 1522412902000,
"masked_author": "username_0",
"text": "initial PR",
"title": "0 1 7",
"type": "issue"
}
] | 2 | 2 | 10 | false | true | 10 | false |
taylorthurlow/panda-motd | null | 372,353,310 | 17 | {
"number": 17,
"repo": "panda-motd",
"user_login": "taylorthurlow"
} | [
{
"action": "opened",
"author": "filalex77",
"comment_id": null,
"datetime": 1540153557000,
"masked_author": "username_0",
"text": "I believe that `taylorjthurlow.com` is now expired, so tests would fail. It would be wise to disable them until we can do something with it.",
"title": "Temporarily disable a spec because of expired cert",
"type": "issue"
},
{
"action": "created",
"author": "taylorthurlow",
"comment_id": 433734313,
"datetime": 1540755052000,
"masked_author": "username_1",
"text": "This commit was lost accidentally in fixing the merge issues with PR #16. I cherry-picked this commit and placed it at the top of develop: d4b58420fe9a94583df17bba261777b83e143108",
"title": null,
"type": "comment"
}
] | 2 | 2 | 319 | false | false | 319 | false |
containerd/containerd | containerd | 334,653,725 | 2,413 | {
"number": 2413,
"repo": "containerd",
"user_login": "containerd"
} | [
{
"action": "opened",
"author": "dmcgowan",
"comment_id": null,
"datetime": 1529614441000,
"masked_author": "username_0",
"text": "This creates the release file for 1.1.1-rc.2 and updates the version.\r\n\r\nThe vendor change is included and the only change for this release. This fixes a startup panic when starting up containerd on a filesystem which does not have d_type support.\r\n\r\nNote: this is vendoring against the cri release branch rather than a tag. For the final release the tag will be made in cri and used here.",
"title": "Prepare 1.1.1-rc.2",
"type": "issue"
},
{
"action": "created",
"author": "dmcgowan",
"comment_id": 400793601,
"datetime": 1530125990000,
"masked_author": "username_0",
"text": "Arm updated, and rebased",
"title": null,
"type": "comment"
}
] | 2 | 3 | 413 | false | true | 413 | false |
mui-org/material-ui | mui-org | 299,524,080 | 10,414 | {
"number": 10414,
"repo": "material-ui",
"user_login": "mui-org"
} | [
{
"action": "opened",
"author": "CharlesStover",
"comment_id": null,
"datetime": 1519336810000,
"masked_author": "username_0",
"text": "Added functional anchorEl support for Popover (resolves #10411)",
"title": "Added functional anchorEl support for Popover",
"type": "issue"
},
{
"action": "created",
"author": "CharlesStover",
"comment_id": 367862551,
"datetime": 1519343437000,
"masked_author": "username_0",
"text": "I'm not sure what it's asking to be changed about this.\r\nI see \"no nested ternary operators,\" but I'd rather not guess-and-check with 12 commits as to how exactly it wasn't it formatted. I apparently don't have the same linting rules in my editor.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbrookes",
"comment_id": 367871411,
"datetime": 1519346319000,
"masked_author": "username_1",
"text": "Not meaning to be facetious, but the error is pretty self explanatory. You have a ternary that contains a ternary. I was originally going to comment on it until I saw that eslint picked it up. \r\n\r\nIf you're unsure what an eslint rule means though, googling it is usually helpful. In this case: https://eslint.org/docs/rules/no-nested-ternary\r\n\r\nIf your editor doesn't support eslint (most do!), you can run it manually with `yarn eslint` (or `npm run eslint`). Better still `yarn eslint:fix` will fix many formatting issues for you automatically; and some editors (hello WebStorm!) have that built in too.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CharlesStover",
"comment_id": 368043308,
"datetime": 1519400211000,
"masked_author": "username_0",
"text": "It isn't so much that I don't know what the error means, but that without it being replicated in my editor, I didn't feel the best option was to commit 12 times until I happened to provide the solution it wanted. I can come up with possible solutions to the errors, but ultimately I currently have valid code being rejected; my fixes will be valid code, so I have no reason to believe they won't be rejected. I will attempt to fix them, but as I don't know positively what `test_browser` or `prettier` is asking of me, it may take a few attempts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbrookes",
"comment_id": 368054460,
"datetime": 1519402157000,
"masked_author": "username_1",
"text": "@username_0 If you read the rest of my reply, you might find some answers.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CharlesStover",
"comment_id": 368062883,
"datetime": 1519403841000,
"masked_author": "username_0",
"text": "Sorry, but your reply did not tell me anything I did not already know.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,608 | false | false | 1,608 | true |
silverstripe/silverstripe-framework | silverstripe | 135,638,170 | 5,082 | {
"number": 5082,
"repo": "silverstripe-framework",
"user_login": "silverstripe"
} | [
{
"action": "opened",
"author": "scott1702",
"comment_id": null,
"datetime": 1456204721000,
"masked_author": "username_0",
"text": "Fixes this https://github.com/silverstripe/silverstripe-framework/issues/5012\r\n\r\n@UndefinedOffset",
"title": "Fix incorrect height on main nav after toggle",
"type": "issue"
},
{
"action": "created",
"author": "tractorcow",
"comment_id": 187914804,
"datetime": 1456262460000,
"masked_author": "username_1",
"text": "We aren't porting back non-critical bugfixes to 3.1 sorry. Please raise on 3.2.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dhensby",
"comment_id": 198985053,
"datetime": 1458499139000,
"masked_author": "username_2",
"text": "Did this get raised on 3.2?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "scott1702",
"comment_id": 199061603,
"datetime": 1458517987000,
"masked_author": "username_0",
"text": "@username_2 Yep, https://github.com/silverstripe/silverstripe-framework/pull/5135",
"title": null,
"type": "comment"
}
] | 3 | 4 | 281 | false | false | 281 | true |
philipromeo/github-slideshow | null | 365,941,958 | 1 | null | [
{
"action": "closed",
"author": "philipromeo",
"comment_id": null,
"datetime": 1538494460000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 6,889 | false | true | 0 | false |
littleweaver/django-brambling | littleweaver | 60,097,121 | 394 | null | [
{
"action": "opened",
"author": "harrislapiroff",
"comment_id": null,
"datetime": 1425645635000,
"masked_author": "username_0",
"text": "Certain items do not require attendee assignment and might be confusing if they have to be assigned.\r\n\r\nFor instance a family camp might have different cabin types/sizes available for payment. In this case it would not make sense, when registering as a family, to assign the cabin to one particular member and could cause confusion as to whether all the family members have housing.\r\n\r\n(This also brings up the question of what type of item a \"cabin\" might be classified as, which should maybe be another issue.)",
"title": "Items that do not require attendee assignment",
"type": "issue"
},
{
"action": "created",
"author": "melinath",
"comment_id": 90821769,
"datetime": 1428475573000,
"masked_author": "username_1",
"text": "Just ran into a new use case for this - donations to scholarship funds. (Also, FYI - I'm guessing we'll drop the categories as part of #68, since all we actually use them for is making sure a pass is purchased and that's probably going out the window.)",
"title": null,
"type": "comment"
}
] | 2 | 2 | 764 | false | false | 764 | false |
o1egl/paseto | null | 374,747,181 | 11 | {
"number": 11,
"repo": "paseto",
"user_login": "o1egl"
} | [
{
"action": "opened",
"author": "o1egl",
"comment_id": null,
"datetime": 1540728696000,
"masked_author": "username_0",
"text": "",
"title": "Add go 1.11 and gomod support",
"type": "issue"
}
] | 2 | 2 | 585 | false | true | 0 | false |
tpope/heroku-fucking-console | null | 11,559,435 | 2 | null | [
{
"action": "opened",
"author": "kybernetyk",
"comment_id": null,
"datetime": 1362167996000,
"masked_author": "username_0",
"text": "I'm impressed.",
"title": "You're so edgy!",
"type": "issue"
},
{
"action": "created",
"author": "mib32",
"comment_id": 309526275,
"datetime": 1497896997000,
"masked_author": "username_1",
"text": "Were you high while doing this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tpope",
"comment_id": 309540112,
"datetime": 1497899862000,
"masked_author": "username_2",
"text": "Only on my own ego.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 64 | false | false | 64 | false |
samueldeng/alfred-keepass | null | 325,035,091 | 8 | null | [
{
"action": "opened",
"author": "vabatta",
"comment_id": null,
"datetime": 1526931671000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nfirst of all great job! Just moved into Alfred and this was my first workflow I wanted to import. Then I got inspired and I made few code changes to add a bit of functionality.\r\nAvailable at my forked repo [here](https://github.com/username_0/alfred-keepass/tree/master).\r\n\r\n@samueldeng If you want, I can make a pull request to merge it, as you wish.",
"title": "Updated version",
"type": "issue"
},
{
"action": "created",
"author": "zeltak",
"comment_id": 437585788,
"datetime": 1541858369000,
"masked_author": "username_1",
"text": "@username_0 This is Epic\r\n\r\nthx so much for your fork it worked so great! are you going to continue development?\r\nThere is no place to add \"issues\" in your fork?\r\nfor example, would be great to have an option to \"launch\" in macpass to open the entry in macpass\r\n\r\nthx again!\r\n\r\nZ",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "vabatta",
"comment_id": null,
"datetime": 1554595415000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "vabatta",
"comment_id": null,
"datetime": 1554595424000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nfirst of all great job! Just moved into Alfred and this was my first workflow I wanted to import. Then I got inspired and I made few code changes to add a bit of functionality.\r\nAvailable at my forked repo [here](https://github.com/username_0/alfred-keepass/tree/master).\r\n\r\n@samueldeng If you want, I can make a pull request to merge it, as you wish.",
"title": "Updated version",
"type": "issue"
}
] | 2 | 4 | 986 | false | false | 986 | true |
jr0d/mercury | null | 295,198,661 | 77 | {
"number": 77,
"repo": "mercury",
"user_login": "jr0d"
} | [
{
"action": "opened",
"author": "xzased",
"comment_id": null,
"datetime": 1518020184000,
"masked_author": "username_0",
"text": "",
"title": "MRC-13: Simple http boot service.",
"type": "issue"
},
{
"action": "created",
"author": "jfwood",
"comment_id": 363832467,
"datetime": 1518022079000,
"masked_author": "username_1",
"text": "@username_0 can you add a title and description to this PR? Good for 'newbies' like me, good for history/release notes, and good for PCI audit foo later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jfwood",
"comment_id": 363834290,
"datetime": 1518022396000,
"masked_author": "username_1",
"text": "@username_0 is this setting up a boot service relative to target servers? If so, does this replace the Power Broker's out of band reboot action, such as here [1]? Also if so, @jr0d could this lead to the in-band 'graceful' reboot service you mentioned the other day (rather than needing build another service running in the DMZ)?\r\n\r\n[1] https://powerbroker.kickstart.rackspace.com/#devices__core_device_id__core_power_reset_post",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xzased",
"comment_id": 363851333,
"datetime": 1518025617000,
"masked_author": "username_0",
"text": "@hussamd @username_1 agreed on adding sufficient logging information. I'll add examples in the description.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xzased",
"comment_id": 363869177,
"datetime": 1518029115000,
"masked_author": "username_0",
"text": "@username_1 Added description, please let me know if you would like me to include other details.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 768 | false | false | 768 | true |
prometheus/alertmanager | prometheus | 285,509,666 | 1,177 | null | [
{
"action": "opened",
"author": "jamtur01",
"comment_id": null,
"datetime": 1514919603000,
"masked_author": "username_0",
"text": "Run:\r\n\r\n```bash\r\namtool --alertmanager.url=http://localhost:9093 silence -o json > silence.json\r\n```\r\n\r\nContents of `silence.json`\r\n\r\n```json\r\n[{\"id\":\"0430a422-3463-42cd-b48b-d6ca2dea6cfb\",\"matchers\":[{\"name\":\"severity\",\"value\":\"critical\",\"isRegex\":false}],\"startsAt\":\"2018-01-02T18:36:22.012871381Z\",\"endsAt\":\"2018-01-02T21:29:53.922Z\",\"updatedAt\":\"2018-01-02T18:36:22.012882047Z\",\"createdBy\":\"Werner Heisenberg\",\"comment\":\"Silence is a virtue\",\"status\":{\"state\":\"active\"}}]\r\n```\r\n\r\nTry to re-import:\r\n\r\n```bash\r\namtool --alertmanager.url=http://localhost:9093 silence import silence.json\r\nError: [bad_data] bad matcher format\r\n```\r\n\r\nExpected the import to work...\r\n\r\nversion:\r\n\r\n```\r\nalertmanager, version 0.12.0 (branch: HEAD, revision: fc33cc78036f82ef8d4734c197a96f7cb6c952a3)\r\n build user: root@c9169eb10d06\r\n build date: 20171215-14:14:51\r\n go version: go1.9.2\r\n```\r\n\r\nalertmanager logs:\r\n\r\n```\r\nlevel=error ts=2018-01-02T18:58:24.285561981Z caller=api.go:780 msg=\"API error\" err=\"bad_data: bad matcher format\"\r\n```",
"title": "[amtool] Import of silences not working",
"type": "issue"
},
{
"action": "created",
"author": "stuartnelson3",
"comment_id": 355919453,
"datetime": 1515404329000,
"masked_author": "username_1",
"text": "I wasn't able to reproduce this unfortunately. I used the contents of your `silence.json` (updating the times), and it worked. I also did the whole process of creating a silence, exporting it, wiping the data, and then importing it.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jamtur01",
"comment_id": null,
"datetime": 1515420943000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jamtur01",
"comment_id": 355977681,
"datetime": 1515420943000,
"masked_author": "username_0",
"text": "Okay - I'll try to see if I can narrow down why it might be impacting me. I'll re-open if I can replicate it with further information.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,410 | false | false | 1,410 | false |
NIteshx2/UltimateSecurityCam | null | 381,056,443 | 4 | null | [
{
"action": "opened",
"author": "NIteshx2",
"comment_id": null,
"datetime": 1542271643000,
"masked_author": "username_0",
"text": "",
"title": "Create setup.py",
"type": "issue"
},
{
"action": "created",
"author": "ragnarokatz",
"comment_id": 540207965,
"datetime": 1570656463000,
"masked_author": "username_1",
"text": "@username_0 I would like to give this issue a try please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ragnarokatz",
"comment_id": 540211476,
"datetime": 1570657003000,
"masked_author": "username_1",
"text": "reference PR #21",
"title": null,
"type": "comment"
}
] | 2 | 3 | 71 | false | false | 71 | true |
remkop/picocli | null | 354,113,786 | 454 | null | [
{
"action": "opened",
"author": "idanarye",
"comment_id": null,
"datetime": 1535305607000,
"masked_author": "username_0",
"text": "I came here looking for a solution for a problem similar to #358 - the need for a syntax for lists of multi-field entries - but had a different solution in mind. These solutions are not mutually exclusive, so I elected to open a new ticket for it.\r\n\r\nMy idea is to have repeatable subcommands. So - if we take the example from #358 - `print` will be the main command and have, say, `file` as a subcommand. We will write it like so:\r\n\r\n```bash\r\nprint --paper A4 \\\r\n file --name A.pdf \\\r\n file --name B.pdf --count 3 \\\r\n file --name C.pdf --count 3 --rotate left \\\r\n file D.pdf \\\r\n file E.pdf --rotate right\r\n```\r\n\r\nThis will create 6 `CommandLine` objects:\r\n\r\n* PrintCommand(paper = \"A4\")\r\n* FileCommand(name = \"A.pdf\", count = <default>, rotate = <default>)\r\n* FileCommand(name = \"B.pdf\", count = 3, rotate = <default>)\r\n* FileCommand(name = \"C.pdf\", count = 3, rotate = \"left\")\r\n* FileCommand(name = \"D.pdf\", count = <default>, rotate = <default>)\r\n* FileCommand(name = \"E.pdf\", count = <default>, rotate = \"right\")\r\n\r\nA bit more verbose than @username_1's original syntax (since you need to specify the options for each file) but much more readable IMHO.\r\n\r\nI tried to do it by making `file` a subcommand of itself:\r\n```java\r\nCommandLine printCommand = new CommandLine(new PrintCommand());\r\nCommandLine fileCommand = new CommandLine(new FileCommand());\r\nprintCommand.addSubcommand(fileCommand);\r\nfileCommand.addSubcommand(fileCommand);\r\n```\r\n\r\nAnd it did parse that command line - but it was always using the same `FileCommand` object so I only got `E.pdf`'s parameters. Maybe if a `CommandLine` could receive a factory for objects, and construct a new one for each subcommand it parses?",
"title": "Allow repeatable subcommands?",
"type": "issue"
},
{
"action": "created",
"author": "kravemir",
"comment_id": 416056825,
"datetime": 1535306268000,
"masked_author": "username_1",
"text": "It's exactly, what was suggested later on, in comment: https://github.com/username_2/picocli/issues/358#issuecomment-381321986 :-) \r\n\r\nThe idea is `@CompositeParameters`, which is a bit similar to `@Mixin`. The `@CompositeParameters` can contain parameters and options, and can be used a repeatable part of command.\r\n\r\nAnyway, I'm up for implementation of such solution. The `print` was just an example, the real use-case is image manipulation/transformation tool.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 416079288,
"datetime": 1535324447000,
"masked_author": "username_2",
"text": "@username_0 I can see there is definitely a need for improvement in this area.\n\nI’m not sure yet about repeatable subcommands; I feel the hierarchy is important in a number of ways (incl. usage help and autocompletion), and worry that would be lost if subcommands could work at any level. \n\nI will focus on #358 first. \n\nAbout your example, have you tried passing in `FileCommand.class` instead of `new FileCommand()`? I believe (away from PC) that picocli will instantiate the class and use the instance as the user object for the `CommandLine`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idanarye",
"comment_id": 416166606,
"datetime": 1535361355000,
"masked_author": "username_0",
"text": "Didn't work. Picocli did initiate a class instance from the `Class` object - but it only did so once.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 416252950,
"datetime": 1535381458000,
"masked_author": "username_2",
"text": "@username_0 There is a lot of merit to your suggestion. If composite options (and composite positional parameters) are implemented with commands under the hood, all the parsing logic can be reused pretty much as is.\r\n\r\nI'm still thinking about:\r\n* what should the annotations API look like (currently thinking a `@Composite` annotation on the bean class that defines the `@Parameters` elements)\r\n* what should the programmatic API look like (currently thinking `ArgSpec` _has a_ `CommandSpec` attribute for composite options and composite positional parameters, which is `null` for non-composite options - it does not feel right to model this as an _is a_ relationship)\r\n* usage help: what should the usage help for a composite option/positional parameter look like (difference from a normal option)? What changes in the `CommandLine.Help` API are needed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 416264820,
"datetime": 1535383559000,
"masked_author": "username_2",
"text": "I realized that composite `ArgSpecs` having a `CommandSpec.Builder` is a better model, especially if the builder takes just the _class_ of the composite bean in the builder constructor. Then `builder.build()` creates a new `CommandSpec` and a new composite instance each time the composite option (or composite positional parameter) is specified on the command line. The builder would act like the factory you mentioned earlier.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "remkop",
"comment_id": null,
"datetime": 1553945014000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "remkop",
"comment_id": 478236778,
"datetime": 1553945014000,
"masked_author": "username_2",
"text": "Picocli 4.0.0-alpha-1 has been released which includes support for repeating composite groups.\r\nSee https://picocli.info/#_argument_groups for details. \r\n\r\nI believe this should should meet the requirements of the original use case.\r\n\r\n_Please try this and provide feedback. We can still make changes._\r\n\r\n_What do you think of the annotations API? What about the programmatic API? Does it work as expected? Are the input validation error messages correct and clear? Is the documentation clear and complete? Anything you want to change or improve? Any other feedback?_",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "remkop",
"comment_id": null,
"datetime": 1553989922000,
"masked_author": "username_2",
"text": "I came here looking for a solution for a problem similar to #358 - the need for a syntax for lists of multi-field entries - but had a different solution in mind. These solutions are not mutually exclusive, so I elected to open a new ticket for it.\r\n\r\nMy idea is to have repeatable subcommands. So - if we take the example from #358 - `print` will be the main command and have, say, `file` as a subcommand. We will write it like so:\r\n\r\n```bash\r\nprint --paper A4 \\\r\n file A.pdf \\\r\n file B.pdf --count 3 \\\r\n file C.pdf --count 3 --rotate left \\\r\n file D.pdf \\\r\n file E.pdf --rotate right\r\n```\r\n\r\nThis will create 6 `CommandLine` objects:\r\n\r\n* PrintCommand(paper = \"A4\")\r\n* FileCommand(name = \"A.pdf\", count = <default>, rotate = <default>)\r\n* FileCommand(name = \"B.pdf\", count = 3, rotate = <default>)\r\n* FileCommand(name = \"C.pdf\", count = 3, rotate = \"left\")\r\n* FileCommand(name = \"D.pdf\", count = <default>, rotate = <default>)\r\n* FileCommand(name = \"E.pdf\", count = <default>, rotate = \"right\")\r\n\r\nA bit more verbose than @username_1's original syntax (since you need to specify the options for each file) but much more readable IMHO.\r\n\r\nI tried to do it by making `file` a subcommand of itself:\r\n```java\r\nCommandLine printCommand = new CommandLine(new PrintCommand());\r\nCommandLine fileCommand = new CommandLine(new FileCommand());\r\nprintCommand.addSubcommand(fileCommand);\r\nfileCommand.addSubcommand(fileCommand);\r\n```\r\n\r\nAnd it did parse that command line - but it was always using the same `FileCommand` object so I only got `E.pdf`'s parameters. Maybe if a `CommandLine` could receive a factory for objects, and construct a new one for each subcommand it parses?",
"title": "Allow repeatable subcommands?",
"type": "issue"
},
{
"action": "created",
"author": "remkop",
"comment_id": 478301250,
"datetime": 1553992460000,
"masked_author": "username_2",
"text": "Reopened as repeatable subcommands may have use cases not covered by repeatable argument groups. #635 may be an example.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hanslovsky",
"comment_id": 478338356,
"datetime": 1554036146000,
"masked_author": "username_3",
"text": "I just tried and I can add sub-commands with double-dash syntax, so that would be a feasible solution for me, as well. I could even have a sub-command with repeatable argument groups and that would be a working solution already, e.g. instead of\r\n```\r\ncommand sub-command --opt1=a --opt2=a sub-command --opt1=b --opt2=b\r\n```\r\nI would have something like this (I made `sub-commands` plural to stress the fact that it can add multiples):\r\n```\r\ncommand sub-commands --opt1=a --opt2=a --opt1=b --opt2=b\r\n```\r\nwhere `opt1` and `opt2` are part of an `ArgGroup`. This is a little less intuitive than multiple repetitions of `sub-command` but it should be a viable workaround.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 484560341,
"datetime": 1555601089000,
"masked_author": "username_2",
"text": "To support repeating subcommands it may make sense to give commands a `multiplicity` attribute. \n\nThis multiplicity indicates how many times the subcommand ca be specified. The default would be `\"0..1\"`, meaning that by default, a subcommand is optional but can be specified at most once. \n\nIf a subcommand can be specified multiple times, it should be defined something like the below:\n\n\n```\n@Command (multiplicity =\"0..*\")\nclass MyCommand {}\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 492879269,
"datetime": 1557969331000,
"masked_author": "username_2",
"text": "This is proving to be a popular feature: see [this stackoverflow question](https://stackoverflow.com/questions/56148593/can-picocli-subcommands-have-options-with-the-same-name).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 501754007,
"datetime": 1560439869000,
"masked_author": "username_2",
"text": "TBD: after doing some prototyping:\r\n* API: how should applications enable this? `@Command(repeatable = true)`? `@Command(siblings = true)`?\r\n* What are the exact requirements? Do we want to allow end users to specify either subcommands or the current command or do we also want to allow sibling commands?\r\n\r\nWhat is clear is that to support this, the `ParseResult` class needs another method `subcommands()` that returns the list of subcommands that were matched for the current command.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 501772780,
"datetime": 1560442634000,
"masked_author": "username_2",
"text": "I am thinking to shelve this feature until the requirements are more clear.\r\n\r\nThe example in #635 and the description of this ticket are the only use cases so far., and they can be addressed with composite repeating groups (although the verb \"add\" in #635 suggests that a subcommand would be a better fit than than a repeating option group).\r\n\r\nAll, if you have ideas, suggestions, requirements: please comment here!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lakemove",
"comment_id": 558464108,
"datetime": 1574745420000,
"masked_author": "username_4",
"text": "To add 1 possible usecase :\r\n```\r\neodcli \\\r\n import --db=jdbc:oracle:local --user=sa --sql=\"select * from data\" \\\r\n report --out /tmp/report.csv \\\r\n email --recipients Jay@gmail.com \r\n```\r\n\r\nchain several subcommands together : read db , generate report and send email notification.\r\njvm is too expensive to use pipe.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 559335537,
"datetime": 1574914837000,
"masked_author": "username_2",
"text": "For reference: \r\nAs mentioned in https://github.com/username_2/picocli/issues/870, the python Click library uses [command chaining](https://click.palletsprojects.com/en/7.x/commands/) and the command group callback feature to accomplish repeated subcommands.\r\n\r\nThe parser side of things is not difficult to implement, but I am still thinking about what API to use to expose this functionality. Currently thinking to add a `multiplicity` range to the `@Command` annotation, similar to [multiplicity](https://picocli.info/apidocs/picocli/CommandLine.ArgGroup.html#multiplicity--) in `@ArgGroup`.\r\n\r\n```java\r\n@Command(name = \"main\", subcommands = { ListCommand.class })\r\npublic class Main implements Runnable {\r\n public void run() { }\r\n\r\n public static void main(String[] args) {\r\n CommandLine cmd = new CommandLine(new Main());\r\n int exitCode = cmd.execute(\"add\", \"add\", \"add\", \"list\");\r\n }\r\n\r\n @Command(name = \"add\", multiplicity = \"0..*\")\r\n int add() {\r\n return 0;\r\n }\r\n}\r\n\r\n@Command(name = \"list\") // default multiplicity = \"0..1\"\r\nclass ListCommand implements Runnable {\r\n public void run() { }\r\n}\r\n```\r\n\r\nThis is easy to understand, easy to code, and can be picked up by the annotation processor to auto-generate documentation in the future.\r\n\r\nOne disadvantage is that by defining multiplicity on the subcommand, it cannot be re-used with a different multiplicity when added to a different parent command. If there is a need for such flexibility it could potentially be addressed with a programmatic API like `CommandLine.addSubcommand(Object command, Range multiplicity)`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 575528390,
"datetime": 1579249988000,
"masked_author": "username_2",
"text": "After thinking some more, I now believe that my earlier thinking to use `multiplicity` is the wrong way (or at least insufficient) to model this.\r\n\r\nThe current model (a hierarchy of subcommands) can be represented by a _directed rooted tree_:\r\n\r\n\r\nThis ticket proposes that we additionally also allow sibling subcommands to be repeated. This is a property of the parent command node, not of the subcommand node.\r\n\r\nWhen a parent command has this property, its subcommands form a fully connected graph (a _complete digraph_):\r\n\r\n\r\n\r\nThis makes me think it is more \"correct\" to model this as a property of the parent command.\r\n\r\nIn coding terms, we can add a `subcommandsRepeatable` attribute to the `@Command` annotation. That would allow applications to make the subcommands of specific commands \"repeatable\". For example:\r\n\r\n```java\r\n@Command(name=\"A\", subcommands = {B.class, C.class, D.class}, subcommandsRepeatable = true)\r\nclass A {}\r\n\r\n@Command(name=\"B\", subcommands = {E.class, F.class, G.class}, subcommandsRepeatable = true)\r\nclass B {}\r\n```\r\n\r\nThe above command definitions would allow user input like this:\r\n\r\n```\r\nA B B C D B E F G E E F F\r\n```\r\n\r\nBut it is not allowed to specify a child command followed by its parent command:\r\n\r\n```\r\n# incorrect: cannot move _up_ the hierarchy\r\nA B E B\r\n```\r\n\r\nThis attribute is not inherited by subcommands; each subcommand must explicitly specify whether its sub-subcommands are repeatable or not.\r\n\r\nSome ideas for naming:\r\n\r\n* `subcommandsRepeatable`\r\n* `subcommandsConnected`\r\n* `subcommandsCompleteDigraph`\r\n\r\n### Limitations\r\n\r\nThis model has some limitations:\r\n\r\n* it is not possible to restrict the number of repetitions\r\n* the \"repeatable\" attribute applies to all subcommands. Some applications may want to only make _some_ subcommands repeatable and exclude other subcommands. \r\n\r\nIf these limitations later turn out to be really problematic, it should be possible to address them with additional attributes. One idea is to introduce a `multiplicity` range attribute that a subcommand would use to define how often it can be repeated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 576792017,
"datetime": 1579627887000,
"masked_author": "username_2",
"text": "@username_0, @username_1, @username_3, @username_4, a first cut of support for repeatable subcommands has landed in master. Please give it a try and let me know what you think.\r\n\r\nUsage:\r\n```java\r\n@Command(name=\"A\",\r\n subcommandsRepeatable = true,\r\n subcommands = {B.class, C.class, D.class})\r\nclass A {}\r\n\r\n@Command(name=\"B\",\r\n subcommandsRepeatable = true,\r\n subcommands = {E.class, F.class, G.class})\r\nclass B {}\r\n\r\n@Command(name=\"C\") class C {}\r\n@Command(name=\"D\") class D {}\r\n@Command(name=\"E\") class E {}\r\n@Command(name=\"F\") class F {}\r\n@Command(name=\"G\") class G {}\r\n```\r\n\r\nThis allows input like this:\r\n\r\n```\r\nA B B C D B E F G E E F F\r\n```\r\n\r\nWhich is parsed like this:\r\n\r\n```\r\nA\r\n|\r\n+--B\r\n+--B\r\n+--C\r\n+--D\r\n+--B\r\n |\r\n +--E\r\n +--F\r\n +--G\r\n +--E\r\n +--E\r\n +--F\r\n +--F\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 579546010,
"datetime": 1580259821000,
"masked_author": "username_2",
"text": "## Status update\r\n\r\nI believe the implementation is now complete. I added tests and updated the documentation.\r\n\r\nRemaining work is just doc tweaking; I will reorder the sections under Subcommands a little.\r\nWhen this is done I will close this ticket. \r\n\r\n## How you can help\r\n\r\nIf you are interested in repeating subcommands, you may have a use case that you want to try this on. You can test by checking out the latest master and building with:\r\n\r\n```\r\ngradlew clean publishToMavenLocal\r\n```\r\n\r\nThat should publish `picocli-4.2.0-SNAPSHOT` to your local .m2 Maven cache. You can then try this in a project that uses the `info.picocli:picocli:4.2.0-SNAPSHOT` dependency.\r\n\r\nFeedback welcome!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "remkop",
"comment_id": null,
"datetime": 1580310656000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "hanslovsky",
"comment_id": 579830980,
"datetime": 1580314099000,
"masked_author": "username_3",
"text": "This looks cool! Haven't really gotten to try this yet but I prepared a [`kscript`](https://github.com/holgerbrandl/kscript) from your example above which may be helpful for quick prototyping:\r\n```kotlin\r\n#!/usr/bin/env kscript\r\n\r\n@file:DependsOn(\"info.picocli:picocli:4.2.0-SNAPSHOT\")\r\n\r\nimport picocli.CommandLine\r\nimport picocli.CommandLine.Command\r\n\r\n@Command(name=\"A\",\r\n subcommandsRepeatable = true,\r\n subcommands = [B::class, C::class, D::class])\r\nclass A\r\n\r\n@Command(name=\"B\",\r\n subcommandsRepeatable = true,\r\n subcommands = [E::class, F::class, G::class])\r\nclass B\r\n\r\n@Command(name=\"C\") class C {}\r\n@Command(name=\"D\") class D {}\r\n@Command(name=\"E\") class E {}\r\n@Command(name=\"F\") class F {}\r\n@Command(name=\"G\") class G {}\r\n\r\nval a = A()\r\nval cl = CommandLine(a)\r\nval parseRsult = cl.parseArgs(*args)\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hanslovsky",
"comment_id": 579852132,
"datetime": 1580316667000,
"masked_author": "username_3",
"text": "I tried a repeatable subcommand with a `String` `CommandLine.Option`. If the option has `arity=\"1\"`, then everything works as expected but if the `arity=\"*\"` then the repeated specification of the subcommand will be interpreted as an option. This is an ill-defined problem by itself and I understand that the ambiguity has to be resolved arbitrarily, i.e. parse everything as a value for the option with `arity=\"*\"`. Is this the intented behavior? The alternative would be for the sub-command know any other sub-command names but I can see that this can get messy quickly. As an alternative solution, is there an argument to indicate that subcommand is completet, e.g. `--`.\r\n\r\nThis is my example:\r\n```kotlin\r\n#!/usr/bin/env kscript\r\n\r\n@file:DependsOn(\"info.picocli:picocli:4.2.0-SNAPSHOT\")\r\n\r\nimport java.util.concurrent.Callable\r\n\r\nimport picocli.CommandLine\r\nimport picocli.CommandLine.Command\r\nimport picocli.CommandLine.Option\r\nimport picocli.CommandLine.Parameters\r\n\r\n@Command(name=\"MainCmd\",\r\n subcommandsRepeatable = true,\r\n subcommands = [Container::class])\r\nclass MainCmd : Callable<Int> {\r\n @Option(names=[\"--help\", \"-h\"], usageHelp=true)\r\n var helpRequested: Boolean = false\r\n\r\n override fun call(): Int {\r\n return 0\r\n }\r\n}\r\n\r\n@Command(name=\"--with-container\")\r\nclass Container : Callable<Int> {\r\n @Parameters(arity=\"1\")\r\n lateinit var path: String\r\n\r\n @Option(names=[\"--dataset\", \"-d\"], arity=\"*\")\r\n var datasets: Array<String>? = null\r\n \r\n @Option(names=[\"--help\", \"-h\"], usageHelp=true)\r\n var helpRequested: Boolean = false\r\n\r\n override fun call(): Int {\r\n println(this)\r\n return 0\r\n }\r\n\r\n override fun toString() = ContainerData(path, datasets?.toList()).toString()\r\n}\r\n\r\ndata class ContainerData(val path: String, val datasets: List<String>?)\r\n\r\nval mainCmd = MainCmd()\r\nval cl = CommandLine(mainCmd)\r\nval exitCode = cl.execute(*args)\r\n```\r\nThis results in:\r\n```\r\n$ ./test-repeatable-subcommands.kts --with-container abc --dataset a --with-container xyz --dataset x\r\nContainerData(path=abc, datasets=[a, --with-container, xyz, x])\r\n```\r\n\r\nIf I change the arity of `Container.datasets` to`\"1\"`, this is the output (which is what I would like to see):\r\n```\r\n$ ./test-repeatable-subcommands.kts --with-container abc --dataset a --with-container xyz --dataset x\r\nContainerData(path=abc, datasets=[a])\r\nContainerData(path=xyz, datasets=[x])\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idanarye",
"comment_id": 579888295,
"datetime": 1580321546000,
"masked_author": "username_0",
"text": "I need this for the plotting feature in a data collection app I ~~should be~~ am writing. Each plot has:\r\n\r\n* One or more axes.\r\n* Zero or more filters - which are sliders/combos that can be played with in the GUI.\r\n* One or more formulas - which are the values that I show in the plot.\r\n\r\nEven though my app is still WIP I don't want to make it depend on a snapshot (I can ~~procrastinate~~ wait until you officially release 4.2.0) so I copied the data classes to a new repository and wrote a CLI just for creating and printing them: https://github.com/username_0/test-picocli-repeatable-subcommands.\r\n\r\nWhat I did is create a parent `CommandLine` that contains the `PlotEntry` object, and repeatable subcommands that axes, filters and formulas to it. This allows me to write single commands that create complete plot entries:\r\n\r\n```bash\r\njava -jar build/libs/shadow.jar my-plot \\\r\n axis Year sample.year \\\r\n axis Height sample.year -u centimeters \\\r\n filter Age 'sample.year - person.birthYear' -u years -t NUMERIC_RANGE \\\r\n filter Gender person.gender -t TEXTUAL_SINGLE \\\r\n formula Salary sample.salary --symbol $ -u USD -S LOGARITHMIC \\\r\n formula Happyness 'sample.pizzaEaten + sample.beerConsumed' --symbol ':-)'\r\n```\r\n\r\nThe only drawback of this approach is that I need to some more processing after `CommandLine.execute()` to handle the result command - could be nice if I could make picocli execute some method on the parent command after all its subcommands have finished.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 580064316,
"datetime": 1580353958000,
"masked_author": "username_2",
"text": "@username_3 Thanks for raising the arity issue! That was a bug. \r\nI pushed a fix to master. \r\n\r\nI also added `repeatable-subcmds-example.kts` to `picocli-examples/src/main/kotlin/picocli/examples/kotlin` based on your example script.\r\n\r\nI tested the fix in Java but I was unable to run your script from IntelliJ (`error: invalid argument: --with-container`). Can you try again with the latest master?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 580066741,
"datetime": 1580354734000,
"masked_author": "username_2",
"text": "@username_0, the simplest way to invoke a method on the top-level command object that I can think of would be to call it from the `main` method in your program.\r\n\r\nSomething like this:\r\n\r\n```java\r\n@Command(name = \"topcmd\", subcommandsRepeatable = true)\r\nclass TopCmd implements Runnable {\r\n public void run() {\r\n System.out.println(\"topcmd called\");\r\n }\r\n\r\n @Command\r\n void axis(@Parameters(index = \"0\") String str, @Parameters(index=\"1\") File f) {\r\n System.out.println(\"axis command called\");\r\n }\r\n\r\n @Command\r\n void filter(@Option(names = \"-u\") String u, @Option(names=\"-t\") String t) {\r\n System.out.println(\"filter command called\");\r\n }\r\n\r\n /* ... */\r\n public void postProcessing() {\r\n System.out.println(\"...and we're done!\");\r\n }\r\n\r\n public static void main(String... args) {\r\n args = \"axis Year a.year axis Height b.year filter -u=x -t=y filter -t=tt\".split(\" \");\r\n\r\n TopCmd top = new TopCmd();\r\n int exitCode = new CommandLine(top).execute(args);\r\n top.postProcessing(); // execute some method on the parent command after all its subcommands have finished.\r\n }\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hanslovsky",
"comment_id": 580268814,
"datetime": 1580393170000,
"masked_author": "username_3",
"text": "@username_2 I pulled the most recent master and tested my script and now it works as expected. Thank you for the quick fix.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idanarye",
"comment_id": 580295675,
"datetime": 1580396637000,
"masked_author": "username_0",
"text": "It gets a bit trickier when you want to have multiple \"real\" subcommands and the ones you want to do postprocessing on are not the root ones, but it's [still doable](https://github.com/username_0/test-picocli-repeatable-subcommands/commit/863269ad8825c6c6a8c0d38d82d2e0589676abe8).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 580557181,
"datetime": 1580438509000,
"masked_author": "username_2",
"text": "@username_0 I see what you mean now.\r\n\r\nPicocli can help find the parent command of the executed subcommands. All that is required is that we make the command methods (or the `Callable` for a `@Command`-annotated class) return something, like an `int`, for example. (This is a natural thing to do anyway if your application needs to control the command's [exit code](https://picocli.info/#_generating_an_exit_code).)\r\n\r\nThat allows you to use the `ParseResult::asCommandLineList` and `CommandLine::getExecutionResult` methods to find the parent: the parent will have a `null` execution result, but the executed subcommands will have a non-`null` execution result. For example:\r\n\r\n```java\r\n// all commands now return an int\r\n@Command(name = \"topcmd\", subcommandsRepeatable = true)\r\nstatic class TopCmd implements Callable<Integer> {\r\n public Integer call() {\r\n System.out.println(\"topcmd called\");\r\n return 0;\r\n }\r\n\r\n @Command\r\n int axis(@Parameters(index = \"0\") String str, @Parameters(index=\"1\") File f) {\r\n System.out.println(\"axis command called\");\r\n return 0;\r\n }\r\n\r\n @Command\r\n int filter(@Option(names = \"-u\") String u, @Option(names=\"-t\") String t) {\r\n System.out.println(\"filter command called\");\r\n return 0;\r\n }\r\n\r\n /* ... */\r\n public void postProcessing() {\r\n System.out.println(\"...and we're done!\");\r\n }\r\n\r\n public static void main(String... args) {\r\n args = \"axis Year a.year axis Height b.year filter -u=x -t=y filter -t=tt\".split(\" \");\r\n\r\n CommandLine cmd = new CommandLine(new TopCmd());\r\n int exitCode = cmd.execute(args);\r\n\r\n // Given that all commands return something,\r\n // we can use the CommandLine::getExecutionResult method \r\n // to find the parent command of the subcommands that were executed.\r\n List<CommandLine> matched = cmd.getParseResult().asCommandLineList();\r\n CommandLine parent = null;\r\n for (CommandLine commandLine : matched) {\r\n if (commandLine.getExecutionResult() == null) { // this command was not executed\r\n parent = commandLine;\r\n } else {\r\n break; // we found the first subcommand that was executed\r\n }\r\n }\r\n System.out.println(\"The parent of the executed subcommands is: \" + parent.getCommandName());\r\n\r\n // execute some method on the parent command\r\n if (parent.getCommand() instanceof TopCmd) {\r\n TopCmd top = parent.getCommand();\r\n top.postProcessing();\r\n }\r\n }\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idanarye",
"comment_id": 580721758,
"datetime": 1580475195000,
"masked_author": "username_0",
"text": "Why return a meaningless integer, when I return a value for the top command to process instead?\r\n\r\nI ended up with something like this:\r\n\r\n```java\r\n\tCommandLine cli = new CommandLine(new App());\r\n\tcli\r\n\t .addSubcommand(\"add\", new PlotCommandAdd())\r\n\t .addSubcommand(\"show\", new PlotCommandShow())\r\n\t .execute(args);\r\n\tSubcommandPostprocessing postprocessingTarget = null;\r\n\tLinkedList<Object> postprocessingArgs = null;\r\n\tfor (CommandLine cmd : cli.getParseResult().asCommandLineList()) {\r\n\t if (cmd.getCommand() instanceof SubcommandPostprocessing) {\r\n\t\tif (postprocessingTarget != null) {\r\n\t\t postprocessingTarget.postProcess(postprocessingArgs);\r\n\t\t}\r\n\t\tpostprocessingTarget = cmd.getCommand();\r\n\t\tpostprocessingArgs = new LinkedList<>();\r\n\t } else if (postprocessingArgs != null) {\r\n\t\tObject executionResult = cmd.getExecutionResult();\r\n\t\tif (executionResult != null) {\r\n\t\t postprocessingArgs.add(executionResult);\r\n\t\t}\r\n\t }\r\n\t}\r\n\tif (postprocessingTarget != null) {\r\n\t postprocessingTarget.postProcess(postprocessingArgs);\r\n\t}\r\n```\r\n\r\nI added the execute-and-switch part in the middle of the loop hoping I can run multiple top level commands:\r\n```bash\r\njava -jar build/libs/shadow.jar \\\r\n add my-plot \\\r\n axis Year sample.year \\\r\n axis Height sample.year -u centimeters \\\r\n filter Age 'sample.year - person.birthYear' -u years -t NUMERIC_RANGE \\\r\n filter Gender person.gender -t TEXTUAL_SINGLE \\\r\n formula Salary sample.salary --symbol $ -u USD -S LOGARITHMIC \\\r\n formula Happyness 'sample.pizzaEaten + sample.beerConsumed' --symbol ':-)' \\\r\n show \\\r\n axis Year sample.year \\\r\n axis Height sample.year -u centimeters \\\r\n filter Age 'sample.year - person.birthYear' -u years -t NUMERIC_RANGE \\\r\n filter Gender person.gender -t TEXTUAL_SINGLE \\\r\n formula Salary sample.salary --symbol $ -u USD -S LOGARITHMIC \\\r\n formula Happyness 'sample.pizzaEaten + sample.beerConsumed' --symbol ':-)'\r\n```\r\n\r\nBut this doesn't work. Should picocli recognize that `show` is not a subcommand of `add` and pop the command stack to check if it's another top level command?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 580972877,
"datetime": 1580519253000,
"masked_author": "username_2",
"text": "At the moment, it is not possible to go _up_ the hierarchy with repeatable subcommands.\r\nI've added a note to that effect in the documentation (build/docs/html5/index.html#_repeatable_subcommands).\r\nI think repeatable subcommands can be confusing, so for now I'd like to keep it simple.\r\nThoughts?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idanarye",
"comment_id": 580974092,
"datetime": 1580519885000,
"masked_author": "username_0",
"text": "I'm already abusing them enough as is, so I'm not going to request any farther complications.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "remkop",
"comment_id": 584993617,
"datetime": 1581475819000,
"masked_author": "username_2",
"text": "@username_0, @username_1, @username_3, @username_4, All,\r\n\r\n[picocli 4.2.0](https://github.com/username_2/picocli/releases/tag/v4.2.0) has been released, including [this feature](https://picocli.info/#_repeatable_subcommands). Enjoy!",
"title": null,
"type": "comment"
}
] | 5 | 33 | 26,688 | false | false | 26,688 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.