repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ovhemert/pino-stackdriver | null | 430,552,924 | 6 | null | [
{
"action": "opened",
"author": "derhuerst",
"comment_id": null,
"datetime": 1554742056000,
"masked_author": "username_0",
"text": "I'd like to use pino with Stackdriver-compatible logging. In many Google Cloud environments, `stdout` will appear in Stackdriver automatically, so **I only need the output in the right format**. This would match a major design decision behind pino: That the logging process shouldn't care about the transport.",
"title": "separate formatting from API calls",
"type": "issue"
}
] | 1 | 1 | 309 | false | false | 309 | false |
sean-beard/photo-grapher | null | 453,624,057 | 2 | {
"number": 2,
"repo": "photo-grapher",
"user_login": "sean-beard"
} | [
{
"action": "created",
"author": "sean-beard",
"comment_id": 499980674,
"datetime": 1559930208000,
"masked_author": "username_0",
"text": "@dependabot rebase",
"title": null,
"type": "comment"
}
] | 2 | 2 | 3,455 | false | true | 18 | false |
graphicore/specimenTools | null | 211,323,901 | 21 | null | [
{
"action": "opened",
"author": "kontur",
"comment_id": null,
"datetime": 1488444081000,
"masked_author": "username_0",
"text": "The call to `Object.freeze`(https://github.com/username_1/specimenTools/blob/master/lib/services/OTFeatureInfo.js#L775) is causing an Javascript error in iOS 8.1.\r\n\r\nThe code checks if obj is indeed of type 'object', but for this case it seems to be 'undefined' when it reaches this line.\r\n\r\nI'm not entirely sure what is going on in this part of the code, so I thought I run this by you first.",
"title": "iOS 8.1 Javascript error in OTFeatureInfo.js",
"type": "issue"
},
{
"action": "created",
"author": "graphicore",
"comment_id": 283672766,
"datetime": 1488466054000,
"masked_author": "username_1",
"text": "This looks like a strange bug in the iOS JS. The `obj`can't change within this function. Have you tried to searching for a bug in wherever iOS 8.1 Javascript is managed. iOS 8.1 JavaScript, what is this Mobile Safari?\r\n\r\nWe could `try ... catch` the call and just go without freezing there. It's more like an API measure to make it explicit that the data in the module shouldn't be changed, maybe even a bit paranoid. If we don't freeze on systems we develop on, it's not changing anything.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "graphicore",
"comment_id": 284309433,
"datetime": 1488779789000,
"masked_author": "username_1",
"text": "Thinking about this, it could well be that `Object.freeze` is not defined in old browsers.\r\n\r\nThe error would be something like \"undefined is not a function\" or \"TypeError: Object.freeze is not a function.\" the message depends on the js interpreter.\r\n\r\nIf so:\r\n\r\n```js\r\nfunction deepFreeze(obj) {\r\n var k;\r\n if(!Object.freeze) return;\r\n if(typeof obj !== 'object') return;\r\n for(k in obj)\r\n deepFreeze(obj[k]);\r\n Object.freeze(obj);\r\n}\r\n```\r\n\r\nthis should do the trick. Could you try this out?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kontur",
"comment_id": 290994512,
"datetime": 1491147820000,
"masked_author": "username_0",
"text": "Funnily enough this fails not because Object.freeze is not defined (it seems to be) nor because the obj passed in would not be a an object (at least according to typeof). Very odd.\r\n\r\nWith a try-catch it can be made to _not break_, as per: https://github.com/username_0/specimenTools/commit/753d5b2d01dafb67b9c8a82168aa7660607cce52\r\n\r\nHowever, I get another javascript error that seems to also appear only on that outdated iOS version. [Here](https://github.com/username_1/specimenTools/blob/master/lib/services/FontsData.js#L188) the error is `undefined is not a function`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "graphicore",
"comment_id": 290995028,
"datetime": 1491148349000,
"masked_author": "username_1",
"text": "In this case [`codePointAt`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt) is probably not defined. It's a newer replacement for [`charCodeAt`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charCodeAt)\r\n\r\nThere's a [Polyfill](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt#Polyfill) though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kontur",
"comment_id": 292744839,
"datetime": 1491684724000,
"masked_author": "username_0",
"text": "That seems to do the trick, no more iOS 8 errors at least on the test pages. I couldn't find any other places that have included a polyfill, so in this instance I included at inside the FontsData.js. I have my changes in [this branch](https://github.com/username_0/specimenTools/tree/ios-8-1-fix)",
"title": null,
"type": "comment"
}
] | 2 | 6 | 2,726 | false | false | 2,726 | true |
vearch/vearch | vearch | 552,611,688 | 90 | null | [
{
"action": "opened",
"author": "xqtbox",
"comment_id": null,
"datetime": 1579579375000,
"masked_author": "username_0",
"text": "两台机器怎么配置master、router、ps？",
"title": "两台机器怎么配置master、router、ps？",
"type": "issue"
},
{
"action": "created",
"author": "zzypeak",
"comment_id": 576596130,
"datetime": 1579599290000,
"masked_author": "username_1",
"text": "参考vearch/tools/deployment/demo/config.toml",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xqtbox",
"comment_id": 576970744,
"datetime": 1579657767000,
"masked_author": "username_0",
"text": "你好 ，请问 ：\r\n1. 我有两台机器，这两台机器能同时都作为master、router、ps。组成几个集群吗？（就是2个master、2个router、2个ps）\r\n2. 如果这两台机器组成一个集群，一台宕机，另外一台还能工作吗？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ansjsun",
"comment_id": 576971408,
"datetime": 1579657957000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ansjsun",
"comment_id": null,
"datetime": 1580562011000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 183 | false | false | 183 | false |
satackey/tomakako-gdrive-auto-share | null | 626,696,920 | 70 | {
"number": 70,
"repo": "tomakako-gdrive-auto-share",
"user_login": "satackey"
} | [
{
"action": "created",
"author": "satackey",
"comment_id": 637888755,
"datetime": 1591145116000,
"masked_author": "username_0",
"text": "@dependabot rebase",
"title": null,
"type": "comment"
}
] | 2 | 3 | 6,707 | false | true | 18 | false |
segmentio/terraform-docs | segmentio | 572,975,209 | 211 | null | [
{
"action": "opened",
"author": "raymondbutcher",
"comment_id": null,
"datetime": 1582920104000,
"masked_author": "username_0",
"text": "### Prerequisites\r\n\r\nPut an `x` into the box that applies:\r\n\r\n- [x] This issue describes a bug.\r\n- [ ] This issue describes a feature request.\r\n\r\nFor more information, see the [Contributing Guidelines](https://github.com/segmentio/terraform-docs/tree/master/CONTRIBUTING.md).\r\n\r\n### Description\r\n\r\nIn [this repository](https://github.com/username_0/terraform-aws-lambda-builder) I have used terraform-docs to generate the inputs and outputs in the main README.md.\r\n\r\nI have a variable defined like this:\r\n\r\n```\r\nvariable \"vpc_config\" {\r\n description = \"Provide this to allow your function to access your VPC.\"\r\n type = object({\r\n security_group_ids = list(string)\r\n subnet_ids = list(string)\r\n })\r\n default = null\r\n}\r\n```\r\n\r\nThe `type` gets rendered in HTML as a `<pre>` element and it is too wide. It causes the table to become too wide for the page and you need to scroll horizontally to see the last column.\r\n\r\nUsing regular backticks would make it render as `<code>` which wraps over multiple lines in GitHub and doesn't cause the table to become too wide. It would however need a comma to separate some of the lines to make sense. \r\n\r\n#### Actual Behavior\r\n\r\nIt outputs this:\r\n\r\n```\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | <pre>object({<br> security_group_ids = list(string)<br> subnet_ids = list(string)<br> })</pre> | n/a | yes |\r\n```\r\n\r\n| Name | Description | Type | Default | Required |\r\n|------|-------------|------|---------|:-----:|\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | <pre>object({<br> security_group_ids = list(string)<br> subnet_ids = list(string)<br> })</pre> | n/a | yes |\r\n\r\nThe table is too big for the page and it requires horizontal scrolling to see all columns.\r\n\r\n#### Expected Behavior\r\n\r\nI want it to render nicely on GitHub and not require horizontal scrolling.\r\n\r\nI think something like this would be better:\r\n\r\n```\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | `object({ security_group_ids = list(string), subnet_ids = list(string) })` | n/a | yes |\r\n```\r\n\r\n| Name | Description | Type | Default | Required |\r\n|------|-------------|------|---------|:-----:|\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | `object({ security_group_ids = list(string), subnet_ids = list(string) })` | n/a | yes |\r\n\r\n### Version\r\n\r\n`0.8.1`",
"title": "Horizontal scrolling in GitHub due to complex types",
"type": "issue"
},
{
"action": "created",
"author": "khos2ow",
"comment_id": 597133751,
"datetime": 1583852413000,
"masked_author": "username_1",
"text": "Apologies for late response. This is unfortunately how markdown tables are being rendered and on top of that different markdown engines behave completely differently when rendering table. There was a whole discussion around it in #138 too. And to be honest having a horizontal scrollbar on a complex table is not that bad IMO, because it's _complex_ anyway.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raymondbutcher",
"comment_id": 597204694,
"datetime": 1583860283000,
"masked_author": "username_0",
"text": "No problem!\r\n\r\nI get that we're at the mercy of different rendering engines and websites, but I think it is worth trying to get GitHub to render it nicely. It is the home of many (I guess most) Terraform modules.\r\n\r\nCould we make `<pre>` vs <code>`</code> an option?\r\n\r\nA more difficult but perhaps better technique could be nested tables, for example:\r\n\r\n| Name | Description | Type | Default | Required |\r\n|------|-------------|------|---------|:-----:|\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | <table><tr><th colspan=\"2\">object</th></tr><tr><td>`security_group_ids`</td><td>`list(string)`</td></tr><tr><td>`subnet_ids`</td><td>`list(string)`</td></tr></table> | n/a | yes |\r\n\r\nI say more difficult because I don't know if all complex types would translate very well into a nested table. I don't know. I think <code>`</code> would be fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "khos2ow",
"comment_id": 597249290,
"datetime": 1583865711000,
"masked_author": "username_1",
"text": "I personally don't like the ``` ` ``` approach because it would feel a little bit weird, after all it was a multi-line text which will end up in a wrapped one-line code, but I'm gonna look to see how hard would it be to add an optional (disabled by default) flag for this.\r\n\r\n| Name | Description | Type | Default | Required |\r\n|----------|----------------|---------|-----------|--------------|\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | `object({ security_group_ids = list(string), subnet_ids = list(string) })` | n/a | yes |\r\n| vpc\\_config | Provide this to allow your function to access your VPC. | <pre>object({<br> security_group_ids = list(string)<br> subnet_ids = list(string)<br> })</pre> | n/a | yes |\r\n\r\nAnother point is that currently without any code change you still can achieve oneliner ``` ` ``` approach if you use the following:\r\n\r\n```\r\nvariable \"vpc_config\" {\r\n description = \"Provide this to allow your function to access your VPC.\"\r\n type = object({ security_group_ids = list(string) subnet_ids = list(string) })\r\n default = null\r\n}\r\n```\r\n\r\nAlso +1 on the proposed nested types, I'm definitely gonna explore that, but then again, it still won't solve the horizontal scrollbar.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 4,908 | false | false | 4,908 | true |
aws/aws-iot-device-sdk-embedded-C | aws | 703,820,253 | 1,290 | {
"number": 1290,
"repo": "aws-iot-device-sdk-embedded-C",
"user_login": "aws"
} | [
{
"action": "opened",
"author": "yourslab",
"comment_id": null,
"datetime": 1600368022000,
"masked_author": "username_0",
"text": "Fix broken link to AWS IoT Account Setup in README\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.",
"title": "Fix broken link to AWS IoT Account Setup in README",
"type": "issue"
}
] | 2 | 2 | 161 | false | true | 161 | false |
alessiolovetere88/github-slideshow | null | 676,013,865 | 3 | {
"number": 3,
"repo": "github-slideshow",
"user_login": "alessiolovetere88"
} | [
{
"action": "opened",
"author": "alessiolovetere88",
"comment_id": null,
"datetime": 1597053425000,
"masked_author": "username_0",
"text": "add new file",
"title": "add alessiolovetere88's file",
"type": "issue"
}
] | 2 | 2 | 1,794 | false | true | 12 | false |
timoast/signac | null | 664,884,712 | 183 | null | [
{
"action": "opened",
"author": "chent5",
"comment_id": null,
"datetime": 1595559820000,
"masked_author": "username_0",
"text": "Thanks a lot for developing this very useful package. I have a question about the IntegrateData() function.\r\n\r\nIn the analysis of scATAC data (), weight.reduction = sci[['lsi']] and preserve.order = TRUE as below:\r\nhttps://satijalab.org/signac/articles/integration.html\r\nintegrated <- IntegrateData(\r\n anchorset = anchors,\r\n weight.reduction = sci[['lsi']],\r\n dims = 2:30,\r\n preserve.order = TRUE\r\n)\r\n\r\nHowever, in the analysis of scRNA data, the above two arguments are using default parameters: weight.reduction = NULL and preserve.order = F.\r\nhttps://satijalab.org/seurat/v3.2/integration.html\r\npancreas.integrated <- IntegrateData(anchorset = pancreas.anchors, dims = 1:30)\r\n\r\nAre there any specific reasons for changing these parameters when analyzing scATAC data? Does it make sense if I used the default settings in scATAC analysis?\r\n\r\nThanks a lot for your explanation in advance!",
"title": "About IntegrateData() function",
"type": "issue"
},
{
"action": "created",
"author": "timoast",
"comment_id": 663627320,
"datetime": 1595608700000,
"masked_author": "username_1",
"text": "As described in the documentation, `weight.reduction` controls what dimension reduction is used for weighting anchors. If NULL (the default), PCA is run on the query and the PCA space is used for weighting anchors. This is not what we want for scATAC-seq data, instead you should use the LSI space, which is why you need to pass either `weight.reduction=\"lsi\"` or the LSI dimreduc object itself.\r\n\r\nThe `preserve.order` argument (again, this is explained in the docs) controls whether objects are reordered based on a sample tree or they are integrated in the order that they are supplied in the list of objects given to `FindIntegrationAnchors`. In the case where you are integrating only 2 objects, they will be reordered so that the larger object is the reference unless `preserve.order=TRUE`.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "timoast",
"comment_id": null,
"datetime": 1595608700000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,688 | false | false | 1,688 | false |
apache/skywalking | apache | 457,300,967 | 2,896 | {
"number": 2896,
"repo": "skywalking",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "Arugal",
"comment_id": null,
"datetime": 1560842111000,
"masked_author": "username_0",
"text": "Please answer these questions before submitting pull request\r\n\r\n- Why submit this pull request?\r\n- [x] Bug fix\r\n- [ ] New feature provided\r\n- [ ] Improve performance",
"title": "fix code comment",
"type": "issue"
},
{
"action": "created",
"author": "Arugal",
"comment_id": 502981453,
"datetime": 1560842606000,
"masked_author": "username_0",
"text": "LGTM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wu-sheng",
"comment_id": 502981983,
"datetime": 1560842708000,
"masked_author": "username_1",
"text": "Why do you comment this to yourself?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Arugal",
"comment_id": 502983405,
"datetime": 1560842980000,
"masked_author": "username_0",
"text": "Seeing Good catch reminds me of LGTM.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 243 | false | false | 243 | false |
amark/gun | null | 469,747,036 | 773 | null | [
{
"action": "opened",
"author": "TensorTom",
"comment_id": null,
"datetime": 1563453627000,
"masked_author": "username_0",
"text": "@username_0 Using have you tried gun.get('peers').get('alias').set(alias)\r\nkeeps it unique\r\nreally unique\r\ntoo unique\r\nJachen Duschletta\r\n@username_1\r\n17:30\r\nOkay, using above just generates disconnected nodes\r\nif done wrong\r\n\r\n_\r\njy7rg53xw5PDf1U\"user1\"\r\njy7rg6yufCTGbpf\"user2\"\r\njy7rg8sofJTjBQi\"user3\"\r\njy7rgnicrVkrQIU\"user3\"\r\n\r\n.set currently non-unique\r\nwarrants a github issue\r\n\r\n",
"title": "Using set() creates disconnected nodes.",
"type": "issue"
},
{
"action": "created",
"author": "TensorTom",
"comment_id": 512800642,
"datetime": 1563454117000,
"masked_author": "username_0",
"text": "I have tried every which way I can think and set does not deduplicate.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dletta",
"comment_id": 512801548,
"datetime": 1563454288000,
"masked_author": "username_1",
"text": "The disconnect happens when you accidentally do a put and then start a set. The real issue is that it’s not a mathematical set (objects get duplicated in the set)",
"title": null,
"type": "comment"
}
] | 2 | 3 | 656 | false | false | 656 | true |
baggepinnen/Hyperopt.jl | null | 521,481,935 | 4 | null | [
{
"action": "opened",
"author": "oxinabox",
"comment_id": null,
"datetime": 1573556724000,
"masked_author": "username_0",
"text": "Its long been my opinion (with little supporting evedance) that hyper-parameter optimization \r\nis just a special case of heuristic global optimization.\r\nThe world that simulated anealling, particle swarm optimization, and genetic algorithms dominate have been in for ages.\r\n\r\nFor lower dimentions bayes-opt is likely much better,\r\nbut once you start getting to dozens, or hundreds of hyper-parrameters,\r\nit seems worth exploring these gradient free methods.\r\n\r\nHow hard is it to use gradient-free methods from Optim or BlackBackOptim with this?",
"title": "Integration of BlackBoxOptim / Gradient-Free Optim methods?",
"type": "issue"
},
{
"action": "created",
"author": "baggepinnen",
"comment_id": 552871301,
"datetime": 1573561413000,
"masked_author": "username_1",
"text": "I support your thesis, hyperopt is essentially global optimization. This package is mostly written to supply the macro, which facilitates a nice syntax that makes it easy to slap optimization of hyperparameters onto already existing code (I'm often a cowboy coder). Internally, the interface is far from optimally designed, as I initially did not intend to support much more than random search (random search is a very strong and hard-to-beat baseline). I have since added a number of methods without fundamentally redesigning the internals. Thus unfortunately makes it a bit awkward to add support for new methods 😔",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oxinabox",
"comment_id": 552871687,
"datetime": 1573561491000,
"masked_author": "username_0",
"text": "we can just leave this open til that day.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,202 | false | false | 1,202 | false |
lakinduakash/linux-wifi-hotspot | null | 598,576,993 | 41 | {
"number": 41,
"repo": "linux-wifi-hotspot",
"user_login": "lakinduakash"
} | [
{
"action": "opened",
"author": "fabricio-godoi",
"comment_id": null,
"datetime": 1586727604000,
"masked_author": "username_0",
"text": "As mentioned in #10 I create a .desktop that is able to run the application.\r\nI'm not a artist, so I download the icon from a opensource website and put the disclaimer to it.\r\n\r\nTested the install/uninstall procedure in Manjaro KDE and PopOS Gnome.",
"title": "feat(.desktop): include script to create system shortcut",
"type": "issue"
},
{
"action": "created",
"author": "lakinduakash",
"comment_id": 612769638,
"datetime": 1586758814000,
"masked_author": "username_1",
"text": "Hi, nice work.\r\nLet me add few suggestions.\r\n- Can you create a folder called `src/desktop` and move `.desktop` file and icon to that folder\r\n- Then move `install` and `uninstall` instructions you added to [CMakeLists.txt](https://github.com/username_1/linux-wifi-hotspot/blob/master/src/CMakeLists.txtl) under `install_build` and `uninstall_build`. \r\n\r\nEx:\r\n```Makefile\r\nCOMMAND install -Dm644 ${CMAKE_SOURCE_DIR}/desktop/hotspot.png $ENV{DESTDIR}/share/doc/create_ap/hotspot.png\r\n\r\nCOMMAND install -Dm644 ${CMAKE_SOURCE_DIR}/desktop/wifihotspot.desktop $ENV{DESTDIR}/share/applications/wifihotspot.desktop\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabricio-godoi",
"comment_id": 613672906,
"datetime": 1586897203000,
"masked_author": "username_0",
"text": "I added the sugestion changes to the project. I hope this got better now :smile:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lakinduakash",
"comment_id": 615304123,
"datetime": 1587136765000,
"masked_author": "username_1",
"text": "Great. Thanks. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lakinduakash",
"comment_id": 617448743,
"datetime": 1587508568000,
"masked_author": "username_1",
"text": "closes #10",
"title": null,
"type": "comment"
}
] | 2 | 5 | 970 | false | false | 970 | true |
date-fns/date-fns | date-fns | 599,110,967 | 1,712 | null | [
{
"action": "opened",
"author": "MontoyaAndres",
"comment_id": null,
"datetime": 1586809062000,
"masked_author": "username_0",
"text": "I'm using the function `format` to pass this date `2020-04-14T17:30:00.000Z` to the right format I'm using.\r\n\r\nThe database throws me this date, in ISO style `2020-04-14T17:30:00.000Z`, which is using this format to save it on the DB: \r\n\r\n`yyyy-MM-dd'T'HH:mm:ss.sss'Z'`\r\n\r\nIf I want to show this date on the browser, I use this function:\r\n\r\n```\r\nexport function formatDate(date: string) {\r\n return format(new Date(date), \"EEEE d MMM, h:mm aaaa\");\r\n}\r\n```\r\n\r\nIt passes this `2020-04-14T17:30:00.000Z` to this `Tuesday 14 Apr, 5:30 p.m.` Which is right, it's what I want. This works perfectly on Windows and Android. But in IOS or Mac, the date `2020-04-14T17:30:00.000Z` is converted to `Tuesday 14 Apr, 12:30 p.m.`. Why happens this?\r\n\r\nThanks!",
"title": "Date wrong on Iphone / Mac",
"type": "issue"
},
{
"action": "created",
"author": "dkozickis",
"comment_id": 622315341,
"datetime": 1588324787000,
"masked_author": "username_1",
"text": "Are the timezones same on all of your devices?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 622391899,
"datetime": 1588340276000,
"masked_author": "username_0",
"text": "I just get the date through the database, like for example:\r\n\r\n2020-04-14T17:30:00.000Z\r\n\r\nAnd I just concert it, using the function that I show before...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dkozickis",
"comment_id": 622508797,
"datetime": 1588358124000,
"masked_author": "username_1",
"text": "That’s correct.\r\n\r\nBut you are initializing “new Date” on different clients, and when initialized this Date object gets time zone of the client where it was initialized. \r\n\r\nHence the question - are time zones the same?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 622533545,
"datetime": 1588362047000,
"masked_author": "username_0",
"text": "Oh I got it, no, in my case I'm from Colombia and the client is from Mexico, the client has the Mac and iPhone and he has that error",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 622533836,
"datetime": 1588362093000,
"masked_author": "username_0",
"text": "But the date it's static, I mean, it's always 2020-04-14T17:30:00.000Z the country affects something?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dkozickis",
"comment_id": 622993718,
"datetime": 1588443332000,
"masked_author": "username_1",
"text": "See the “Z” at the end of date time strong means that this date time is in +0000 time zone.\r\n\r\n1730Z is 1730 in GMT+0000, but is 2030 in GMT+0300. When you call `new Date` with this date, JS sees that there is a reference to time zone in the date time string and “converts” the provided date time to local time zone.\r\n\r\n\r\nTry adding `X` (time zone) to the end of your format string, e.g. `EEEE d MMM, h:mm aaaa X` and see if output is different for you and your client.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 624675362,
"datetime": 1588774504000,
"masked_author": "username_0",
"text": "I tried adding `EEEE d MMM, h:mm aaaa X` and the output is `Tuesday 14 Apr, 5:30 p.m. -05` in all the devices... What that `-05` mean?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 624701330,
"datetime": 1588777203000,
"masked_author": "username_0",
"text": "One thing that I forgot to mention. It's when I call this method:\r\n\r\n```\r\nexport function formatDate(date: string) {\r\n return format(new Date(date), \"EEEE d MMM, h:mm aaaa\");\r\n}\r\n```\r\n\r\nI call this function like this: `formatDate(date.replace(\"Z\", \"\"))` I remove the Z at the end because it gives me another date... Maybe the problem is how I save the date on ISO format...\r\n\r\nThis is because when the user opens the input of type=\"datetime-local\" I take the value returned from the input and I format it to ISO like this:\r\n\r\n````\r\nimport { format } from \"date-fns\";\r\n\r\nconst awsDateFormat = \"yyyy-MM-dd'T'HH:mm:ss.sss'Z'\";\r\n\r\nexport const formatDate = (date: string) =>\r\n format(new Date(date), awsDateFormat);\r\n```\r\n\r\nAnd the value returned from the variable `formatDate ` I save it to the db and then I do what I mentioned before... Maybe am I doing something wrong when I save the date when the user add it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MontoyaAndres",
"comment_id": 624775527,
"datetime": 1588785145000,
"masked_author": "username_0",
"text": "Yeah, I was saving the date wrongly to the db... Sorry about that :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "MontoyaAndres",
"comment_id": null,
"datetime": 1588785146000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dkozickis",
"comment_id": 624802141,
"datetime": 1588788220000,
"masked_author": "username_1",
"text": "No prob :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RobSchilderr",
"comment_id": 1071004567,
"datetime": 1647532275000,
"masked_author": "username_2",
"text": "saved my life",
"title": null,
"type": "comment"
}
] | 3 | 13 | 3,004 | false | false | 3,004 | false |
gophish/gophish | gophish | 581,703,424 | 1,786 | {
"number": 1786,
"repo": "gophish",
"user_login": "gophish"
} | [
{
"action": "opened",
"author": "PaulSec",
"comment_id": null,
"datetime": 1584283735000,
"masked_author": "username_0",
"text": "Hi!\r\n\r\nI updated the Ansible role to reflect: \r\n- changes on the `config.json` file\r\n- make sure that ufw is installed on the remote machine before any operations\r\n- generate a SSL certificate on the fly to serve the app\r\n- use the Ansible capabilities module instead of some shell-fu\r\n- created a gophish service which runs out of the box\r\n\r\nHave a great day!",
"title": "Updated the Ansible role",
"type": "issue"
},
{
"action": "created",
"author": "PaulSec",
"comment_id": 599740660,
"datetime": 1584390027000,
"masked_author": "username_0",
"text": "Btw, just so you know, I also added a nginx to serve as a reverse proxy and made the CN (for the certificate + nginx) a variable that you can change in `vars/main.yml`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PaulSec",
"comment_id": 599995523,
"datetime": 1584441052000,
"masked_author": "username_0",
"text": "Moreover, I updated the role so that it spins up a nginx as a reverse proxy for the gophish server. \r\nThe admin panel will only available on localhost.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jordan-wright",
"comment_id": 600338474,
"datetime": 1584485449000,
"masked_author": "username_1",
"text": "Sounds great! I’ll give this a shot ASAP and will merge if everything checks out.\n\nThanks for all the help on this!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jordan-wright",
"comment_id": 600405579,
"datetime": 1584501946000,
"masked_author": "username_1",
"text": "This is the error I'm getting on a fresh Debian install:\r\n\r\n```\r\nroot@gophish:/home/jordan# service gophish status\r\n● gophish.service - gophish\r\n Loaded: loaded (/etc/systemd/system/gophish.service; enabled; vendor preset: enabled)\r\n Active: failed (Result: exit-code) since Tue 2020-03-17 22:18:12 CDT; 3min 5s ago\r\n Process: 461 ExecStart=/home/jordan/gophish_deploy/gophish (code=exited, status=1/FAILURE)\r\n Main PID: 461 (code=exited, status=1/FAILURE)\r\n\r\nMar 17 22:18:11 gophish systemd[1]: Started gophish.\r\nMar 17 22:18:12 gophish gophish[461]: time=\"2020-03-17T22:18:12-05:00\" level=warning msg=\"No contact address has been configured.\"\r\nMar 17 22:18:12 gophish gophish[461]: time=\"2020-03-17T22:18:12-05:00\" level=warning msg=\"Please consider adding a contact_address entry in your config.json\"\r\nMar 17 22:18:12 gophish gophish[461]: goose: no migrations to run. current version: 20200116000000\r\nMar 17 22:18:12 gophish gophish[461]: time=\"2020-03-17T22:18:12-05:00\" level=info msg=\"Starting admin server at https://127.0.0.1:3333\"\r\nMar 17 22:18:12 gophish gophish[461]: time=\"2020-03-17T22:18:12-05:00\" level=fatal msg=\"open /etc/ssl/private/gophish.pem: permission denied\"\r\nMar 17 22:18:12 gophish systemd[1]: gophish.service: Main process exited, code=exited, status=1/FAILURE\r\nMar 17 22:18:12 gophish systemd[1]: gophish.service: Unit entered failed state.\r\nMar 17 22:18:12 gophish systemd[1]: gophish.service: Failed with result 'exit-code'.\r\n```\r\n\r\nThe error appears to be stemming from the fact that I'm using an unprivileged user, which is trying to access `/etc/ssl/private` which is locked down:\r\n\r\n```\r\njordan@gophish:~$ ls -alh /etc/ssl/\r\ntotal 52K\r\ndrwxr-xr-x 6 root root 4.0K Mar 17 22:15 .\r\ndrwxr-xr-x 81 root root 4.0K Mar 17 22:19 ..\r\ndrwxr-xr-x 2 root root 20K Mar 17 22:16 certs\r\ndrwxr-xr-x 2 root root 4.0K Mar 17 22:16 crt\r\ndrwxr-xr-x 2 root root 4.0K Mar 17 22:16 csr\r\n-rw-r--r-- 1 root root 11K Nov 28 2018 openssl.cnf\r\ndrwx--x--- 2 root ssl-cert 4.0K Mar 17 22:16 private\r\n```\r\n\r\nPerhaps it makes sense for us to ensure that the `{{ gophish_user }}` is in the `ssl-cert` group?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jordan-wright",
"comment_id": 600405830,
"datetime": 1584502011000,
"masked_author": "username_1",
"text": "Oops! Accidentally closed this out and reopened. My bad!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PaulSec",
"comment_id": 601921941,
"datetime": 1584740413000,
"masked_author": "username_0",
"text": "You are totally right Jordan. I changed that to make sure that the user is in the `ssl-cert` group using: \r\n\r\n```yaml\r\n- name: adding existing user '{{ gophish_user }}' to group ssl-cert\r\n user:\r\n name: '{{ gophish_user }}'\r\n groups: ssl-cert\r\n append: yes\r\n```\r\n\r\nThanks again for the review! I tested it on a vanilla Debian 10.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jordan-wright",
"comment_id": 602247306,
"datetime": 1584899747000,
"masked_author": "username_1",
"text": "Looks like this works great. Thanks @username_0!",
"title": null,
"type": "comment"
}
] | 2 | 8 | 3,381 | false | false | 3,381 | true |
JuliaRegistries/General | JuliaRegistries | 636,343,329 | 16,156 | {
"number": 16156,
"repo": "General",
"user_login": "JuliaRegistries"
} | [
{
"action": "opened",
"author": "JuliaRegistrator",
"comment_id": null,
"datetime": 1591802791000,
"masked_author": "username_0",
"text": "- Registering package: VIDA\n- Repository: https://github.com/username_1/VIDA.jl\n- Created by: @username_1\n- Version: v0.2.0\n- Commit: 317e7143d5300c0b8c6d6a307eade02433a3cbbf\n- Git reference: master",
"title": "New package: VIDA v0.2.0",
"type": "issue"
},
{
"action": "created",
"author": "ptiede",
"comment_id": 645609746,
"datetime": 1592426075000,
"masked_author": "username_1",
"text": "Hi,\r\n\r\nSorry, I am new to the whole package registration stuff. What else did I need to do to get this registered? Should I rename the package and resubmit? Also, I have made some extensive changes to the package after this pull request was added, does something need to be added?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oxinabox",
"comment_id": 647786002,
"datetime": 1592862455000,
"masked_author": "username_2",
"text": "the version you register will be the version that gets registered.\r\nSo your changes since then will be included if you rename and reregister",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DilumAluthge",
"comment_id": 648786651,
"datetime": 1593001320000,
"masked_author": "username_3",
"text": "Closing in favor of #16854",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fredrikekre",
"comment_id": 648792685,
"datetime": 1593002103000,
"masked_author": "username_4",
"text": "@username_1 Just to clarify; If you want the package to be named VIDA I see no problem with that, but perhaps you prefer the other name?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ptiede",
"comment_id": 648834094,
"datetime": 1593006742000,
"masked_author": "username_1",
"text": "Oh I would actually prefer the original name. Should I just resubmit with the original VIDA.jl name?",
"title": null,
"type": "comment"
}
] | 5 | 6 | 868 | false | false | 868 | true |
MuseOfAllTrades/github-slideshow | null | 615,829,721 | 1 | null | [
{
"action": "closed",
"author": "MuseOfAllTrades",
"comment_id": null,
"datetime": 1589274299000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 6,819 | false | true | 0 | false |
genny-project/prj_genny | genny-project | 559,478,645 | 467 | {
"number": 467,
"repo": "prj_genny",
"user_login": "genny-project"
} | [
{
"action": "opened",
"author": "c7yrus",
"comment_id": null,
"datetime": 1580790018000,
"masked_author": "username_0",
"text": "This push handles the showName of image of profile picture in the header frame",
"title": "2020 01 20 profile picture icon",
"type": "issue"
},
{
"action": "created",
"author": "adamcrow64",
"comment_id": 581736359,
"datetime": 1580790123000,
"masked_author": "username_1",
"text": "Can one of the admins verify this patch?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 118 | false | false | 118 | false |
microsoft/onnxruntime | microsoft | 529,023,903 | 2,489 | {
"number": 2489,
"repo": "onnxruntime",
"user_login": "microsoft"
} | [
{
"action": "opened",
"author": "tiagoshibata",
"comment_id": null,
"datetime": 1574810258000,
"masked_author": "username_0",
"text": "**Description**: a file named `cppwinrt.h` was present in cmake\\external\\wil\\include\\wil\\cppwinrt.h and winml\\lib\\Common\\inc\\cppwinrt.h , and the build could fail depending on include path precedence. As a fix, I'm renaming winml\\lib\\Common\\inc\\cppwinrt.h.",
"title": "Rename ambiguous header",
"type": "issue"
},
{
"action": "created",
"author": "tiagoshibata",
"comment_id": 558860211,
"datetime": 1574810652000,
"masked_author": "username_0",
"text": "Also, it's not a matter of simply changing the include directory order in CMake. The order passed to CL.exe is already correct, but the compiler has funny rules for searching for included files:\r\n\r\n```\r\nIf specified using a #include directive in double-quote form, it first\r\nsearches local directories. The search begins in the same directory as\r\nthe file that contains the #include statement. If this fails to find\r\nthe file, it searches in the directories of the currently opened include\r\nfiles, in the reverse order in which they were opened. The search begins\r\nin the directory of the parent include file and continues upward through\r\nthe directories of any grandparent include files.\r\n```\r\n\r\n(From https://docs.microsoft.com/en-us/cpp/build/reference/i-additional-include-directories?view=vs-2019)\r\n\r\nI'd rather rename it and be done with it than have to think about the ordering of the currently opened include files 😃",
"title": null,
"type": "comment"
}
] | 1 | 2 | 1,180 | false | false | 1,180 | false |
ajihyf/pixi-dom | null | 417,997,073 | 13 | null | [
{
"action": "closed",
"author": "ajihyf",
"comment_id": null,
"datetime": 1557760741000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 27 | 8,819 | false | true | 0 | false |
eBay/go-ovn | eBay | 650,837,338 | 90 | {
"number": 90,
"repo": "go-ovn",
"user_login": "eBay"
} | [
{
"action": "opened",
"author": "jxiaobin",
"comment_id": null,
"datetime": 1593844198000,
"masked_author": "username_0",
"text": "allow client to delete static route by uuid",
"title": "delete static route by uuid",
"type": "issue"
},
{
"action": "created",
"author": "vtolstov",
"comment_id": 653816568,
"datetime": 1593899593000,
"masked_author": "username_1",
"text": "LGTM for me, @hzhou8 what you think?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 79 | false | false | 79 | false |
olcay67/github-slideshow | null | 611,297,873 | 1 | null | [
{
"action": "closed",
"author": "olcay67",
"comment_id": null,
"datetime": 1588463525000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "olcay67",
"comment_id": null,
"datetime": 1588463530000,
"masked_author": "username_0",
"text": "# :wave: Welcome to GitHub Learning Lab's \"Introduction to GitHub\"\n\nTo get started, I’ll guide you through some important first steps in coding and collaborating on GitHub.\n\n:point_down: _This arrow means you can expand the window! Click on them throughout the course to find more information._\n<details><summary>What is GitHub?</summary>\n<hr>\n\n## What is GitHub?\n\nI'm glad you asked! Many people come to GitHub because they want to contribute to open source <sup>[:book:](https://help.github.com/articles/github-glossary/#open-source)</sup> projects, or they're invited by teammates or classmates who use it for their projects. Why do people use GitHub for these projects?\n\n**At its heart, GitHub is a collaboration platform.**\n\nFrom software to legal documents, you can count on GitHub to help you do your best work with the collaboration and security tools your team needs. With GitHub, you can keep projects completely private, invite the world to collaborate, and streamline every step of your project.\n\n**GitHub is also a powerful version control tool.**\n\nGitHub uses Git <sup>[:book:](https://help.github.com/articles/github-glossary/#git)</sup>, the most popular open source version control software, to track every contribution and contributor <sup>[:book:](https://help.github.com/articles/github-glossary/#contributor)</sup> to your project--so you know exactly where every line of code came from.\n\n**GitHub helps people do much more.**\n\nGitHub is used to build some of the most advanced technologies in the world. Whether you're visualizing data or building a new game, there's a whole community and set of tools on GitHub that can get you to the next step. This course starts with the basics, but we'll dig into the rest later!\n\n:tv: [Video: What is GitHub?](https://www.youtube.com/watch?v=w3jLJU7DT5E)\n<hr>\n</details><br>\n\n<details><summary>Exploring a GitHub repository</summary>\n<hr>\n\n## Exploring a GitHub repository\n\n:tv: [Video: Exploring a repository](https://www.youtube.com/watch?v=R8OAwrcMlRw)\n\n### More features\n\nThe video covered some of the most commonly-used features. Here are a few other items you can find in GitHub repositories:\n\n- Project boards: Create Kanban-style task tracking board within GitHub\n- Wiki: Create and store relevant project documentation\n- Insights: View a drop-down menu that contains links to analytics tools for your repository including:\n - Pulse: Find information about the work that has been completed and the work that’s in-progress in this project dashboard\n - Graphs: Graphs provide a more granular view of the repository activity including who contributed to the repository, who forked it, and when they completed the work\n\n### Special Files\n\nIn the video you learned about a special file called the README.md. Here are a few other special files you can add to your repositories:\n\n- CONTRIBUTING.md: The `CONTRIBUTING.md` is used to describe the process for contributing to the repository. A link to the `CONTRIBUTING.md` file is shown anytime someone creates a new issue or pull request.\n- ISSUE_TEMPLATE.md: The `ISSUE_TEMPLATE.md` is another file you can use to pre-populate the body of an issue. For example, if you always need the same types of information for bug reports, include it in the issue template, and every new issue will be opened with your recommended starter text.\n\n<hr>\n</details>\n\n### Using issues\n\nThis is an issue <sup>[:book:](https://help.github.com/articles/github-glossary/#issue)</sup>: a place where you can have conversations about bugs in your code, code review, and just about anything else.\n\nIssue titles are like email subject lines. They tell your collaborators what the issue is about at a glance. For example, the title of this issue is Getting Started with GitHub.\n\n\n<details><summary>Using GitHub Issues</summary>\n\n## Using GitHub issues\n\nIssues are used to discuss ideas, enhancements, tasks, and bugs. They make collaboration easier by:\n\n- Providing everyone (even future team members) with the complete story in one place\n- Allowing you to cross-link to other issues and pull requests <sup>[:book:](https://help.github.com/articles/github-glossary/#pull-request)</sup>\n- Creating a single, comprehensive record of how and why you made certain decisions\n- Allowing you to easily pull the right people and teams into a conversation with @-mentions\n\n:tv: [Video: Using issues](https://www.youtube.com/watch?v=Zhj46r5D0nQ)\n\n<hr>\n</details>\n\n<details><summary>Managing notifications</summary>\n<hr>\n\n## Managing notifications\n\n:tv: [Video: Watching, notifications, stars, and explore](https://www.youtube.com/watch?v=ocQldxF7fMY)\n\nOnce you've commented on an issue or pull request, you'll start receiving email notifications when there's activity in the thread. \n\n### How to silence or unmute specific conversations\n\n1. Go to the issue or pull request\n2. Under _\"Notifications\"_, click the **Unsubscribe** button on the right to silence notifications or **Subscribe** to unmute them\n\nYou'll see a short description that explains your current notification status.\n\n### How to customize notifications in Settings\n\n1. Click your profile icon\n2. Click **Settings**\n3. Click **Notifications** from the menu on the left and [adjust your notification preferences](https://help.github.com/articles/managing-notification-delivery-methods/)\n\n### Repository notification options\n\n* **Watch**: You'll receive a notification when a new issue, pull request or comment is posted, and when an issue is closed or a pull request is merged \n* **Not watching**: You'll no longer receive notifications unless you're @-mentioned\n* **Ignore**: You'll no longer receive any notifications from the repository\n\n### How to review notifications for the repositories you're watching\n\n1. Click your profile icon\n2. Click **Settings**\n3. Click **Notification** from the menu on the left\n4. Click on the [repositories you’re watching](https://github.com/watching) link\n5. Select the **Watching** tab\n6. Click the **Unwatch** button to disable notifications, or **Watch** to enable them\n\n<hr>\n</details>\n\n<hr>\n<h3 align=\"center\">Keep reading below to find your first task</h3>",
"title": "Getting Started with GitHub",
"type": "issue"
}
] | 2 | 4 | 12,290 | false | true | 6,145 | false |
tonumikk/github-slideshow | null | 550,917,373 | 3 | {
"number": 3,
"repo": "github-slideshow",
"user_login": "tonumikk"
} | [
{
"action": "opened",
"author": "tonumikk",
"comment_id": null,
"datetime": 1579192049000,
"masked_author": "username_0",
"text": "Add Tonu Mikk's slide",
"title": "Create 0000-01-02-tonumikk.md",
"type": "issue"
}
] | 2 | 2 | 1,610 | false | true | 21 | false |
EGI-Foundation/documentation | EGI-Foundation | 586,984,895 | 33 | {
"number": 33,
"repo": "documentation",
"user_login": "EGI-Foundation"
} | [
{
"action": "opened",
"author": "andrea-manzi",
"comment_id": null,
"datetime": 1585058726000,
"masked_author": "username_0",
"text": "<!--\r\nA good PR should describe what benefit this brings to the repository.\r\nIdeally, there is an existing issue which the PR address.\r\n-->\r\n\r\n# Summary \r\n Add dependencies installation instructions and how to build\r\n\r\n----\r\n<!-- Add the related issue here, e.g. #6 -->\r\n #19",
"title": " Add dependencies installation instructions and how to build",
"type": "issue"
},
{
"action": "created",
"author": "andrea-manzi",
"comment_id": 603286577,
"datetime": 1585061685000,
"masked_author": "username_0",
"text": "thanks, I applied your changes!",
"title": null,
"type": "comment"
}
] | 1 | 2 | 306 | false | false | 306 | false |
cincheo/jsweet | cincheo | 458,558,341 | 530 | null | [
{
"action": "opened",
"author": "jmstark",
"comment_id": null,
"datetime": 1561024588000,
"masked_author": "username_0",
"text": "Hi!\r\nAssume I have the following classes and interfaces in Java (each class/interface in its own source file):\r\n```\r\nabstract class AA {\r\n public enum EA { EA1 };\r\n}\r\nclass A implements IA {}\r\ninterface IA implements IB {}\r\ninterface IB {\r\n default void m() {\r\n System.out.println(EA.EA1);\r\n }\r\n}\r\n```\r\nThis roughly translates to this TS:\r\n```\r\nexport class A implements IA {\r\n void m() {\r\n System.out.println(AA.EA.EA1);\r\n }\r\nexport interface IA extends IB {}\r\nexport interface IB {\r\n m(): void;\r\n}\r\nexport abstract class AA {}\r\nexport namespace AA {\r\n export enum EA {\r\n EA1\r\n }\r\n}\r\n```\r\n\r\nThe important thing is that the default method `m()` gets transpiled into `A` and `EA.A1` is accessed via `AA.EA.A1`, BUT A.ts does not include the neccessary header and thus the compiler complains that it does not know `AA`. Any idea on why that is?\r\n\r\nThanks in advance for any help and for this interesting peace of software!",
"title": "header missing for default method accessing superclass enum",
"type": "issue"
},
{
"action": "created",
"author": "jmstark",
"comment_id": 504021670,
"datetime": 1561036585000,
"masked_author": "username_0",
"text": "I have pushed a fix that so far works for my code but I suspect that this is not the correct place to insert headers nor that it works for all cases.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lgrignon",
"comment_id": null,
"datetime": 1562048631000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,088 | false | false | 1,088 | false |
nushell/nushell | nushell | 486,523,720 | 514 | null | [
{
"action": "opened",
"author": "cdhunt",
"comment_id": null,
"datetime": 1567014752000,
"masked_author": "username_0",
"text": "I'm testing this pipeline.\r\n\r\n`powershell -c \"ps | convertto-json\" | from-json`\r\n\r\nThe PowerShell PS command returns a lot more process information, but the shell just hangs. There's no process activity for `nu.exe` or `Windows Command Processor`. The shell is unresponsive.\r\n\r\nJust the external command, `powershell -c \"ps | convertto-json\"` works as expected and spits out json to the screen.",
"title": "Piping external to internal hangs",
"type": "issue"
},
{
"action": "created",
"author": "wycats",
"comment_id": 525941319,
"datetime": 1567030014000,
"masked_author": "username_1",
"text": "Yikes! Seems bad.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathandturner",
"comment_id": 525958565,
"datetime": 1567034303000,
"masked_author": "username_2",
"text": "I've seen this with some invocations of the Azure `az` command and keyvault combinations. I wonder if there's a timeout we could introduce and/or tune so that at least something comes back to the user with a warning that the operation couldn't be finished successfully",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 526345625,
"datetime": 1567110029000,
"masked_author": "username_0",
"text": "I've encountered this again while using `from-json`.\r\n\r\n`docker images --format \"{{json .}}\" | from-json`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 526347831,
"datetime": 1567110387000,
"masked_author": "username_0",
"text": "I tried `docker images | split-column \" \"` and it hung until I hit `^C`. Then rendered as expected.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathandturner",
"comment_id": 526385359,
"datetime": 1567117628000,
"masked_author": "username_2",
"text": "@username_0 - out of curiosity, are the `docker` hangs on Windows too?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 526399185,
"datetime": 1567121684000,
"masked_author": "username_0",
"text": "Yes. All on Windows 10.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 526416809,
"datetime": 1567127742000,
"masked_author": "username_3",
"text": "@username_0 can you try `docker images --format \"{{json .}}\" | from-json --objects` ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 526439991,
"datetime": 1567135059000,
"masked_author": "username_3",
"text": "Possibly related to #489",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 526572604,
"datetime": 1567165947000,
"masked_author": "username_0",
"text": "I get `error: Unimplemented: passing flags is not supported yet.`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rrichardson",
"comment_id": 530141426,
"datetime": 1568153702000,
"masked_author": "username_4",
"text": "^C\r\nthread 'main' panicked at 'index out of bounds: the len is 2 but the index is 2', /rustc/9eae1fc0ea9b00341b8fe191582c4decb5cb86a3/src/libcore/slice/mod.rs:2715:10\r\nstack backtrace:\r\n 0: backtrace::backtrace::libunwind::trace\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88\r\n 1: backtrace::backtrace::trace_unsynchronized\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66\r\n 2: std::sys_common::backtrace::_print\r\n at src/libstd/sys_common/backtrace.rs:47\r\n 3: std::sys_common::backtrace::print\r\n at src/libstd/sys_common/backtrace.rs:36\r\n 4: std::panicking::default_hook::{{closure}}\r\n at src/libstd/panicking.rs:200\r\n 5: std::panicking::default_hook\r\n at src/libstd/panicking.rs:214\r\n 6: std::panicking::rust_panic_with_hook\r\n at src/libstd/panicking.rs:477\r\n 7: std::panicking::continue_panic_fmt\r\n at src/libstd/panicking.rs:384\r\n 8: rust_begin_unwind\r\n at src/libstd/panicking.rs:311\r\n 9: core::panicking::panic_fmt\r\n at src/libcore/panicking.rs:85\r\n 10: core::panicking::panic_bounds_check\r\n at src/libcore/panicking.rs:61\r\n 11: nu::format::table::TableView::from_list\r\n 12: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 13: <futures_util::stream::collect::Collect<St,C> as core::future::future::Future>::poll\r\n 14: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 15: std::future::poll_with_tls_context\r\n 16: nu::cli::cli::{{closure}}\r\n 17: std::thread::local::LocalKey<T>::with\r\n 18: nu::main\r\n 19: std::rt::lang_start::{{closure}}\r\n 20: std::rt::lang_start_internal::{{closure}}\r\n at src/libstd/rt.rs:49\r\n 21: std::panicking::try::do_call\r\n at src/libstd/panicking.rs:296\r\n 22: __rust_maybe_catch_panic\r\n at src/libpanic_unwind/lib.rs:80\r\n 23: std::panicking::try\r\n at src/libstd/panicking.rs:275\r\n 24: std::panic::catch_unwind\r\n at src/libstd/panic.rs:394\r\n 25: std::rt::lang_start_internal\r\n at src/libstd/rt.rs:48\r\n 26: main\r\n 27: __libc_start_main\r\n 28: _start\r\nnote: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 530150357,
"datetime": 1568155862000,
"masked_author": "username_3",
"text": "`--objects` was introduced after the release you are using. Try building from master and it should work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 530150714,
"datetime": 1568155950000,
"masked_author": "username_3",
"text": "Thanks!\r\n\r\nCan you try `kubectl logs mysvc | from-json --objects | debug` and paste the output? It looks like it does the parsing correctly but it's failing when displaying the table (the pipeline ends implicitly with `autoview`)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rrichardson",
"comment_id": 530154157,
"datetime": 1568156871000,
"masked_author": "username_4",
"text": "``` \r\nfrom-json --objects | debug\r\n```\r\n\r\n```\r\n^CTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"> mm-server@0.0.1 start /home/node/app\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"> npm run migrate up && node src/index.js\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"> mm-server@0.0.1 migrate /home/node/app\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"> node-pg-migrate --config-file database.json \\\"up\\\"\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"WARNING\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"NODE_ENV value of \\\r\n'production\\' did not match any deployment config file names.\")) }} }) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"WARNING\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"See https://github.\r\ncom/lorenwest/node-config/wiki/Strict-Mode\")) }} }) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"No migrations to run!\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"Migrations complete!\")) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"level\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data\r\n: BigUint { data: [30] } })) }, \"time\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [478974102, 365] } })) }, \"pid\": Tagged { tag: Tag { origi\r\nn: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [43] } })) }, \"hostname\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"me\r\ntal-manager-6f8756975-fnq7t\")) }, \"msg\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"Server listening at http://0.0.0.0:7654\")) }, \"v\": Tagged { tag: Tag { origin: None, span: Span\r\n{ start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [1] } })) }} }) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"level\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data\r\n: BigUint { data: [30] } })) }, \"time\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [478990977, 365] } })) }, \"pid\": Tagged { tag: Tag { origi\r\nn: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [43] } })) }, \"hostname\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"me\r\ntal-manager-6f8756975-fnq7t\")) }, \"reqId\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [1] } })) }, \"req\": Tagged { tag: Tag { origin: None, s\r\npan: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"method\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"OPTIONS\")) }, \"url\": Tagged { tag: Tag { origin: None,\r\nspan: Span { start: 45, end: 54 } }, item: Primitive(String(\"/api/v1/cluster/4\")) }, \"hostname\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"api.app.rick0i.dev.superhub.io\")) }, \"re\r\nmoteAddress\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"10.2.0.27\")) }, \"remotePort\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(Bi\r\ngInt { sign: Plus, data: BigUint { data: [45236] } })) }} }) }, \"msg\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"incoming request\")) }, \"v\": Tagged { tag: Tag { origin: None, span\r\n: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [1] } })) }} }) }\r\nTagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Object(Dictionary { entries: {\"level\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data\r\n: BigUint { data: [30] } })) }, \"time\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [478990982, 365] } })) }, \"pid\": Tagged { tag: Tag { origi\r\nn: None, span: Span { start: 45, end: 54 } }, item: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [43] } })) }, \"hostname\": Tagged { tag: Tag { origin: None, span: Span { start: 45, end: 54 } }, item: Primitive(String(\"me\r\n...\r\nitem: Primitive(Int(BigInt { sign: Plus, data: BigUint { data: [1] } })) }} }) }\r\nthread 'main' panicked at 'index out of bounds: the len is 2 but the index is 2', /rustc/9eae1fc0ea9b00341b8fe191582c4decb5cb86a3/src/libcore/slice/mod.rs:2715:10\r\nstack backtrace:\r\n 0: backtrace::backtrace::libunwind::trace\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88\r\n 1: backtrace::backtrace::trace_unsynchronized\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66\r\n 2: std::sys_common::backtrace::_print\r\n at src/libstd/sys_common/backtrace.rs:47\r\n 3: std::sys_common::backtrace::print\r\n at src/libstd/sys_common/backtrace.rs:36\r\n 4: std::panicking::default_hook::{{closure}}\r\n at src/libstd/panicking.rs:200\r\n 5: std::panicking::default_hook\r\n at src/libstd/panicking.rs:214\r\n 6: std::panicking::rust_panic_with_hook\r\n at src/libstd/panicking.rs:477\r\n 7: std::panicking::continue_panic_fmt\r\n at src/libstd/panicking.rs:384\r\n 8: rust_begin_unwind\r\n at src/libstd/panicking.rs:311\r\n 9: core::panicking::panic_fmt\r\n at src/libcore/panicking.rs:85\r\n 10: core::panicking::panic_bounds_check\r\n at src/libcore/panicking.rs:61\r\n 11: nu::format::table::TableView::from_list\r\n 12: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 13: <futures_util::stream::collect::Collect<St,C> as core::future::future::Future>::poll\r\n 14: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 15: std::future::poll_with_tls_context\r\n 16: nu::cli::cli::{{closure}}\r\n 17: std::thread::local::LocalKey<T>::with\r\n 18: nu::main\r\n 19: std::rt::lang_start::{{closure}}\r\n 20: std::rt::lang_start_internal::{{closure}}\r\n at src/libstd/rt.rs:49\r\n 21: std::panicking::try::do_call\r\n at src/libstd/panicking.rs:296\r\n 22: __rust_maybe_catch_panic\r\n at src/libpanic_unwind/lib.rs:80\r\n 23: std::panicking::try\r\n at src/libstd/panicking.rs:275\r\n 24: std::panic::catch_unwind\r\n at src/libstd/panic.rs:394\r\n 25: std::rt::lang_start_internal\r\n at src/libstd/rt.rs:48\r\n 26: main\r\n 27: __libc_start_main\r\n 28: _start\r\nnote: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rrichardson",
"comment_id": 530154804,
"datetime": 1568157053000,
"masked_author": "username_4",
"text": "interestingly... \r\n```\r\nkubectl logs mysvc | from-json --objects | save foo.json\r\n```\r\n\r\nIt hangs, but it doesn't error.. I still hit ctrl-c... but there is no panic or backtrace, and foo.json is populated with what appears to be the expected data, including strings containing the invalid json",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 530156106,
"datetime": 1568157434000,
"masked_author": "username_3",
"text": "@username_4 How about now `> open foo.json` ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rrichardson",
"comment_id": 530165399,
"datetime": 1568160206000,
"masked_author": "username_4",
"text": "thread 'main' panicked at 'index out of bounds: the len is 2 but the index is 2', /rustc/9eae1fc0ea9b00341b8fe191582c4decb5cb86a3/src/libcore/slice/mod.rs:2715:10\r\nstack backtrace:\r\n 0: backtrace::backtrace::libunwind::trace\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88\r\n 1: backtrace::backtrace::trace_unsynchronized\r\n at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66\r\n 2: std::sys_common::backtrace::_print\r\n at src/libstd/sys_common/backtrace.rs:47\r\n 3: std::sys_common::backtrace::print\r\n at src/libstd/sys_common/backtrace.rs:36\r\n 4: std::panicking::default_hook::{{closure}}\r\n at src/libstd/panicking.rs:200\r\n 5: std::panicking::default_hook\r\n at src/libstd/panicking.rs:214\r\n 6: std::panicking::rust_panic_with_hook\r\n at src/libstd/panicking.rs:477\r\n 7: std::panicking::continue_panic_fmt\r\n at src/libstd/panicking.rs:384\r\n 8: rust_begin_unwind\r\n at src/libstd/panicking.rs:311\r\n 9: core::panicking::panic_fmt\r\n at src/libcore/panicking.rs:85\r\n 10: core::panicking::panic_bounds_check\r\n at src/libcore/panicking.rs:61\r\n 11: nu::format::table::TableView::from_list\r\n 12: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 13: <futures_util::stream::collect::Collect<St,C> as core::future::future::Future>::poll\r\n 14: <futures_async_stream::stream::GenStream<G,T> as futures_core::stream::Stream>::poll_next\r\n 15: std::future::poll_with_tls_context\r\n 16: nu::cli::cli::{{closure}}\r\n 17: std::thread::local::LocalKey<T>::with\r\n 18: nu::main\r\n 19: std::rt::lang_start::{{closure}}\r\n 20: std::rt::lang_start_internal::{{closure}}\r\n at src/libstd/rt.rs:49\r\n 21: std::panicking::try::do_call\r\n at src/libstd/panicking.rs:296\r\n 22: __rust_maybe_catch_panic\r\n at src/libpanic_unwind/lib.rs:80\r\n 23: std::panicking::try\r\n at src/libstd/panicking.rs:275\r\n 24: std::panic::catch_unwind\r\n at src/libstd/panic.rs:394\r\n 25: std::rt::lang_start_internal\r\n at src/libstd/rt.rs:48\r\n 26: main\r\n 27: __libc_start_main\r\n 28: _start\r\nnote: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "androbtech",
"comment_id": 530167411,
"datetime": 1568160878000,
"masked_author": "username_3",
"text": "@username_4 Thanks. The problem could be in the parsing of json in that case (and potentially the culprit of the hanging issue)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathandturner",
"comment_id": 531347134,
"datetime": 1568399961000,
"masked_author": "username_2",
"text": "@username_0 - I just landed a fix that should help with the hangs you were seeing. I've tested it on Linux, and I'm hoping the same fix helps Windows also.\r\n\r\nIf you can, would you be able to checkout the latest Nu from master, build it, and try your example again?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 531388622,
"datetime": 1568408234000,
"masked_author": "username_0",
"text": "I'm working on a Rustlang Windows container to run the build.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 531979536,
"datetime": 1568672178000,
"masked_author": "username_0",
"text": "I give up. I can't find a way to get `vs-buildtools` installed to provide `link.exe`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathandturner",
"comment_id": 532078839,
"datetime": 1568701491000,
"masked_author": "username_2",
"text": "@username_0 thanks for trying. I've never built a Windows container.\r\n\r\nWe're you using a container for your original report?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickolay",
"comment_id": 532113455,
"datetime": 1568708090000,
"masked_author": "username_5",
"text": "FWIW, I experienced the same problem on Windows, and the fix did help: the command from the first comment no longer hands (though the powershell command itself takes a while to finish).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cdhunt",
"comment_id": 532197131,
"datetime": 1568723081000,
"masked_author": "username_0",
"text": "@username_2 No. I was originally using the 0.2.0 release on my workstation. I just don't want to pollute my workstation with the Rust toolchain to run a single build and from what I've read several people have a problem getting `link.exe` without containers being involved. However, that's all really a Rust issue and not Nu. Sounds like @username_5 verified it so I think you can close this out.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathandturner",
"comment_id": 532297876,
"datetime": 1568737787000,
"masked_author": "username_2",
"text": "Sounds good. (and thanks @username_5 for verifying)\r\n\r\nWe should be rolling out the next release in a couple weeks, which will include this fix.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jonathandturner",
"comment_id": null,
"datetime": 1568737787000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 6 | 26 | 15,672 | false | false | 15,672 | true |
JanGorman/Bling | null | 557,258,262 | 30 | {
"number": 30,
"repo": "Bling",
"user_login": "JanGorman"
} | [
{
"action": "created",
"author": "JanGorman",
"comment_id": 580099163,
"datetime": 1580364684000,
"masked_author": "username_0",
"text": "@dependabot merge",
"title": null,
"type": "comment"
}
] | 3 | 3 | 9,345 | false | true | 17 | false |
react-navigation/react-navigation | react-navigation | 317,200,008 | 4,050 | null | [
{
"action": "opened",
"author": "dblachut-adb",
"comment_id": null,
"datetime": 1524572397000,
"masked_author": "username_0",
"text": "### Current Behavior\r\n```\r\nTabNavigator({\r\n A: { screen: A },\r\n B: { screen: B },\r\n C: { screen: C },\r\n D: { screen: D },\r\n E: { screen: E },\r\n}, {\r\n initialRouteName: \"B\",\r\n animationEnabled: true,\r\n swipeEnabled: false,\r\n navigationOptions: {\r\n tabBarVisible: false,\r\n },\r\n lazy: true,\r\n },\r\n);\r\n\r\n```\r\nWhen the app starts and the `B` screen is displayed after using `navigation.navigate(D)` during the screen transition animation the white `C` screen is displayed for a split of a second. This is due to `C` not being loaded yet as I am using `lazy: false` flag.\r\n\r\n### Expected Behavior\r\nIt would be nice if the screen would transition from `B` to `D` directly without showing screens that are located between them. Please note that this still may be problematic if used with `lazy: false` - when e.g. screen `C` would differ much from `B` and `D` the user could still observe the transition and it may not be desired is case the app is using its own navigation bar.\r\n\r\n### How to reproduce\r\nUse the screen configuration I have provided.\r\n\r\n### Your Environment\r\n\r\n| software | version\r\n| ---------------- | -------\r\n| react-navigation | 1.5.11\r\n| react-native | 0.55.3\r\n| node | v9.2.0\r\n| npm | 5.5.1",
"title": "Transition between not loaded screens in TabNavigator displays white page during animation",
"type": "issue"
},
{
"action": "created",
"author": "brentvatne",
"comment_id": 384479006,
"datetime": 1524704206000,
"masked_author": "username_1",
"text": "hi there. the example you pasted is not runnable. please create a full example on https://snack.expo.io/ so we can run it and see what you mean.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dblachut-adb",
"comment_id": 384531340,
"datetime": 1524725095000,
"masked_author": "username_0",
"text": "Hello, thank for the reply. Are you sure that description in words is not enough in this case? I guess I will try to prepare it later on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dblachut-adb",
"comment_id": 384904480,
"datetime": 1524818154000,
"masked_author": "username_0",
"text": "@username_1 Okay :+1:, I have updated the issue, please take a look.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dblachut-adb",
"comment_id": 388039416,
"datetime": 1525955413000,
"masked_author": "username_0",
"text": "@username_1 could you please take off the \"needs repro\" flag?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brentvatne",
"comment_id": 392223602,
"datetime": 1527296635000,
"masked_author": "username_1",
"text": "thanks for updating it. this issue isn't really valid anymore because in 2.0 we removed `animationEnabled` on tab navigator. this isn't a common use case and we aren't interested in supporting it, if you'd like to implement this behavior you can create your own custom navigator to do so. you can simply fork one of the existing tab navigators and make the appropriate changes to do so. I'm sorry I don't have a better answer for you :(",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "brentvatne",
"comment_id": null,
"datetime": 1527296635000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dblachut-adb",
"comment_id": 392435238,
"datetime": 1527490143000,
"masked_author": "username_0",
"text": "No problem, thanks for taking a look and a detailed explanation!",
"title": null,
"type": "comment"
}
] | 2 | 8 | 2,172 | false | false | 2,172 | true |
axa-group/nlp.js | axa-group | 535,549,840 | 340 | {
"number": 340,
"repo": "nlp.js",
"user_login": "axa-group"
} | [
{
"action": "opened",
"author": "jesus-seijas-sp",
"comment_id": null,
"datetime": 1575963366000,
"masked_author": "username_0",
"text": "# Pull Request Template\r\n\r\n## PR Checklist\r\n\r\n- [X] I have run `npm test` locally and all tests are passing.\r\n- [ ] I have added/updated tests for any new behavior.\r\n- [ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]\r\n\r\n## PR Description\r\n\r\nAllowing files to be retrieved online",
"title": "feat: fs request",
"type": "issue"
}
] | 2 | 2 | 1,741 | false | true | 377 | false |
yajra/laravel-datatables | null | 393,344,421 | 1,941 | null | [
{
"action": "opened",
"author": "timothymarois",
"comment_id": null,
"datetime": 1545376329000,
"masked_author": "username_0",
"text": "I bet this has been asked a lot,\r\n\r\nbut I can not **sort the columns based on the raw fields/values**, it always sorts based on the edited column which is bad in the sense you can throw a lot of garbage inside the output of edited columns, yet you do not want to sort that nonsense. Like Html. \r\n\r\nI am also talking about Collection sorting, not database sorting. \r\n\r\nUsing `$table->order()` still just works with the edited columns.",
"title": "Collections: Sorting by raw field not edited column",
"type": "issue"
},
{
"action": "created",
"author": "ridwantanjung",
"comment_id": 619147843,
"datetime": 1587749393000,
"masked_author": "username_1",
"text": "why is it still no answer? did you find a solution @username_0 ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ridwantanjung",
"comment_id": 619148078,
"datetime": 1587749421000,
"masked_author": "username_1",
"text": "why is it still no answer? did you found a solution @username_0 ?",
"title": null,
"type": "comment"
}
] | 2 | 3 | 568 | false | false | 568 | true |
rapidsai/cuxfilter | rapidsai | 394,342,491 | 3 | null | [
{
"action": "opened",
"author": "archenroot",
"comment_id": null,
"datetime": 1545902777000,
"masked_author": "username_0",
"text": "So imagine I have multi gpu cluster (GPU node count > 1), I can see few general scenarios (there could be more):\r\n\r\n1. Multiple user sessions can share the cuDF, and they execute same operations on load\r\n\r\n2. Multiple user sessions can share the cuDF, but they execute different operations\r\n\r\n3. Multiple user sessions have different cuDF, they execute same operations (either the functions are generic, or the data model is the same)\r\n\r\n4. Multiple user sessions have different cuDF, they execute completely different operations\r\n\r\nQ: How is cuxfilter ready for such scenarios? Is there some generic managment construct?\r\nQ: How can I assign just some GPUs in cluster?\r\nQ: Are aggregations (as per demo histogram) persisted in GPU memory and therefore accessible, or they are just returned to user and result is forgotten and again recalculated on next request?\r\n\r\nIts really cool, because this can really boost real time aggregations or larger dataset aggregations.",
"title": "[question] GPU session data management within GPU cluster",
"type": "issue"
},
{
"action": "created",
"author": "exactlyallan",
"comment_id": 450432159,
"datetime": 1546033431000,
"masked_author": "username_1",
"text": "@username_0 Good questions - we've briefly played around with some scenarios. The short answer is because the current cuDF is only single node, the datasets large enough to utilize GPU acceleration were already pushing the limits of single GPU memory size with a single user.\r\n\r\nThe solution to this is to use the in-development multi-node [dask-cudf](https://github.com/rapidsai/dask-cudf), but we haven't committed to building that yet. Once that is developed, finding methods for advanced user session or resource management would make a lot of sense, as it is pretty basic currently. \r\n\r\n1. There is an ability so use sessions or not, [docs here](https://github.com/rapidsai/cuxfilter/tree/master/client_side#1-load-data), so the effect is similar to sharing a cuDF. Anyone accessing the cuDF would be able to see and alter its state. This means you can do some interesting cross-browser or remote interactions, but its a bit flaky.\r\n\r\n2. Something we are looking into is using pointers to GPU memory so dataframes wouldn't have to be duplicated as often - this is assuming you've set the same data dimension for those different operations. \r\n\r\n3 / 4. This would probably be mostly simply done by initializing different cuDFs for each and relying on some sort of resource manager. \r\n\r\nTo answer your last question - the aggregations are not stored on GPU memory since their values are so small - but they are stored as part of a cuXfilter object server side.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "exactlyallan",
"comment_id": null,
"datetime": 1550519168000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 2,429 | false | false | 2,429 | true |
alefragnani/vscode-bookmarks | null | 594,738,603 | 280 | null | [
{
"action": "opened",
"author": "aybiss",
"comment_id": null,
"datetime": 1586134617000,
"masked_author": "username_0",
"text": "Until a recent update of VSCode, bookmarks were visible in the left margin next to the code. Now they are not showing. The bookmarks can be created just fine and I can navigate to them, I just can't see them.\r\n\r\nIs this a known problem or is it something I have done to my editor settings or something else?\r\n\r\nThanks in advance, your extension is invaluable.",
"title": "Bookmarks not visible any more",
"type": "issue"
},
{
"action": "created",
"author": "alefragnani",
"comment_id": 612215991,
"datetime": 1586552481000,
"masked_author": "username_1",
"text": "Hi @username_0 ,\r\n\r\nFirst of all, thank you for your kind words. I'm glad to know the extension is being useful.\r\n\r\nI have received a few reports (#34, #43, #160, #170, #272) about missing Icon (Side Bar) and it was always related to some error while installing/upgrading VS Code or the extension.The bookmark icon, on the other hand, I just remember on issue, caused by the fact of using a Retina display (Mac) when the extension was still using PNG images. When I upgraded to SVG the problem disappeared.\r\n\r\nYou said a recent VS Code update has happened, so I guess it _could be_ the reason. Try to reinstalling the extension, so see if it works. It must be a full reinstall, which means:\r\n\r\n1. Uninstall the extension \r\n2. Close all VS Code instances (reload window is not an option)\r\n3. Open VS Code\r\n4. Install the extension again\r\n\r\nIt's very important to _close all VS Code instances_, because VS Code removes the extension (old/uninstalled) when it starts from zero.\r\n\r\nHope this helps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aybiss",
"comment_id": 612268986,
"datetime": 1586562444000,
"masked_author": "username_0",
"text": "Thanks very much for the comprehensive reply. When loading up vscode this\nmorning fresh it was working fine. If they disappear again I will try your\nsuggestions. Have a great weekend!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alefragnani",
"comment_id": 612279481,
"datetime": 1586565006000,
"masked_author": "username_1",
"text": "Thank you! That's great to hear 🎉 \r\n\r\nEnjoy...",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "alefragnani",
"comment_id": null,
"datetime": 1586565007000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jvzr",
"comment_id": 662406813,
"datetime": 1595418309000,
"masked_author": "username_2",
"text": "If somebody is in the same situation, and a VSCode restart didn't fix it, just make sure the 'glyph margin' is enabled: `\"editor.glyphMargin\": true`\r\n\r\nIt's not on by default, somehow, and I've spent more time \"debugging\" the icon missing than I'd like to admit...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alefragnani",
"comment_id": 662409714,
"datetime": 1595418770000,
"masked_author": "username_1",
"text": "Hi @username_2 ,\r\n\r\nThank you for the tip!\r\n\r\nMaybe something has changed in newer VS Code releases, because for me, the `editor.glyphMargin` default value is `true`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jvzr",
"comment_id": 662425048,
"datetime": 1595420999000,
"masked_author": "username_2",
"text": "Must have been an issue on my end, because as you made me double-check it reverted to on by default.\n\nLonger story: your reply made me double-check, so I opened Settings. Next to the glyph margin setting, which was enabled, it displayed the blue indicator meaning this is not the default. I clicked once, the value set to disabled but the indicator remained. I clicked again, the value set to enabled and the indicator disappeared. I must be crazy.\n\nIn any case, it might be useful to let users know that this setting must be enabled for the gutter icon to show. People like me who had it disabled before because they had no use for it until now might appreciate the info 😄 I blame the name of the setting, as I was looking for something something \"gutter\" and only by trial and error found the misnomer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alefragnani",
"comment_id": 662435126,
"datetime": 1595422381000,
"masked_author": "username_1",
"text": "That's a good idea, thanks!\n\nIn fact, I didn't know about that VS Code setting, until now 😁",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "farukonfly",
"comment_id": 1042698335,
"datetime": 1645087068000,
"masked_author": "username_3",
"text": "I did that, but it still doesn't work",
"title": null,
"type": "comment"
}
] | 4 | 10 | 2,934 | false | false | 2,934 | true |
SkillsFundingAgency/das-platform-automation | SkillsFundingAgency | 498,215,864 | 36 | {
"number": 36,
"repo": "das-platform-automation",
"user_login": "SkillsFundingAgency"
} | [
{
"action": "opened",
"author": "mwevill",
"comment_id": null,
"datetime": 1569409915000,
"masked_author": "username_0",
"text": "Adding new script Infrastructure-Scripts/New-StorageAccountQueue.ps1. This will allow the Automation of creating storage account queues as part of deployment\r\n\r\nAdding an associated Pester unit test Tests/UT.New-StorageAccountQueue.Tests.ps1\r\n\r\nUpdated Tests/Unit.Tests.Config.ps1 with config variables required by Tests/UT.New-StorageAccountQueue.Tests.ps1",
"title": "Adding new script New-StorageAccountQueue.ps1 +semver: minor",
"type": "issue"
},
{
"action": "created",
"author": "dalemorson",
"comment_id": 539524268,
"datetime": 1570542772000,
"masked_author": "username_1",
"text": "Closing PR as it was completed as part of another PR https://github.com/SkillsFundingAgency/das-platform-automation/pull/37",
"title": null,
"type": "comment"
}
] | 2 | 2 | 480 | false | false | 480 | false |
Intel-Media-SDK/MediaSDK | Intel-Media-SDK | 515,576,343 | 1,750 | null | [
{
"action": "opened",
"author": "dvrogozh",
"comment_id": null,
"datetime": 1572539630000,
"masked_author": "username_0",
"text": "https://github.com/Intel-Media-SDK/MediaSDK/blob/fcca4c526374e410a7fae33e97edad08632e815c/samples/sample_common/src/sample_utils.cpp#L981",
"title": "What is this hardcoded color format (commented as DXGI_FORMAT_AYUV) value about?",
"type": "issue"
},
{
"action": "closed",
"author": "dmitryermilov",
"comment_id": null,
"datetime": 1583360075000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 137 | false | false | 137 | false |
ithaka/aiw-ui | ithaka | 475,098,556 | 1,112 | {
"number": 1112,
"repo": "aiw-ui",
"user_login": "ithaka"
} | [
{
"action": "opened",
"author": "rehanabbasi",
"comment_id": null,
"datetime": 1564573966000,
"masked_author": "username_0",
"text": "Add to an existing group: Make sure to query for editable groups for the logged-in user using `&level=created`, while fetching groups list.",
"title": "AIR-2481",
"type": "issue"
},
{
"action": "created",
"author": "codiak",
"comment_id": 517731401,
"datetime": 1564757682000,
"masked_author": "username_1",
"text": "@username_0, If we should be swapping to using \"created\" for private groups, we should probably change this logic in multiple places?\r\n\r\nBut additionally, I know this is the solution that was suggested, but I don't understand how it would impact whether or not the option is enabled in the dropdown? Wouldn't this technically be more exclusive/specific?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 493 | false | false | 493 | true |
forpdi/forpdi | forpdi | 423,747,981 | 199 | null | [
{
"action": "opened",
"author": "almeidaevt",
"comment_id": null,
"datetime": 1553177325000,
"masked_author": "username_0",
"text": "Não estou conseguindo cadastrar um risco.\r\n\r\n",
"title": "Não é possível cadastrar um risco",
"type": "issue"
},
{
"action": "closed",
"author": "matheus0392",
"comment_id": null,
"datetime": 1553180797000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 154 | false | false | 154 | false |
kiegroup/kie-docs | kiegroup | 579,388,839 | 2,270 | {
"number": 2270,
"repo": "kie-docs",
"user_login": "kiegroup"
} | [
{
"action": "opened",
"author": "kaldesai",
"comment_id": null,
"datetime": 1583943799000,
"masked_author": "username_0",
"text": "**JIRAs:**\r\n- [Epic](https://issues.redhat.com/browse/BXMSDOC-5201)\r\n- [Dedicated JIRA](https://issues.redhat.com/browse/BXMSDOC-5240)\r\n\r\n**Doc previews:**\r\n- [7.7 RHPAM Managing and Monitoring KIE Server](http://file.pnq.redhat.com/~username_0/BXMSDOC-5240-RHPAM-MMES/#migration-configure-kie-server-proc)\r\n- [7.7 RHDM Managing and Monitoring KIE Server](http://file.pnq.redhat.com/~username_0/BXMSDOC-5240-RHDM-MMES/#migration-configure-kie-server-proc)\r\n\r\n**Following changes are incorporated in the doc:**\r\n\r\n- Properties *org.kie.server.persistence.dialect* and *org.kie.server.persistence.ds* they are only present in RHPAM and removed from RHDM.\r\n- This chapter *Configuring Smart Router for TLS support* is only present in RHPAM doc as Smart Router is applicable to RHPAM only.\r\n- Business central doesn't process KJARs any more so I have replaced Business central by KIE server.\r\n- Chapter 9. Configuring KIE Server Managed by Business Central and 9.1. Configuring Smart Router for TLS support are now separated.\r\n- references from version 7.5.x to 7.6 are now updated to *7.6.x to 7.7*.",
"title": "Upstream 7.33.x PR for BXMSDOC-5240: Updated the Managing & monitoring KIE Server doc as per RHPAM/RHDM 7.7",
"type": "issue"
},
{
"action": "created",
"author": "heathjoy",
"comment_id": 597750507,
"datetime": 1583946010000,
"masked_author": "username_1",
"text": "ok to test",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,102 | false | false | 1,102 | true |
calpa/gatsby-starter-calpa-blog | null | 376,736,912 | 98 | null | [
{
"action": "opened",
"author": "calpa",
"comment_id": null,
"datetime": 1541151734000,
"masked_author": "username_0",
"text": "For now, the stats config is coded inside [/src/pages/stats.js](https://github.com/username_0/gatsby-starter-username_0-blog/blob/master/src/pages/stats.js).\r\n\r\nTo improve, please \r\n1. Extract the configuration to [/src/data/config.js](https://github.com/username_0/gatsby-starter-username_0-blog/blob/master/data/config.js).\r\n2. get the config from config.js\r\n\r\nFor example:\r\n```js\r\n{\r\n stats: {\r\n title: '過去三十日數據',\r\n description: '過去三十日數據',\r\n image: 'https://i.imgur.com/pimaXpl.png',\r\n }\r\n}\r\n```",
"title": "Extract stats page params to config.js",
"type": "issue"
},
{
"action": "created",
"author": "calpa",
"comment_id": 437790855,
"datetime": 1542010081000,
"masked_author": "username_0",
"text": "I will do this.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "calpa",
"comment_id": null,
"datetime": 1542027369000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 504 | false | false | 504 | true |
rusqlite/rusqlite | rusqlite | 619,519,755 | 738 | null | [
{
"action": "opened",
"author": "Voodlaz",
"comment_id": null,
"datetime": 1589649901000,
"masked_author": "username_0",
"text": "Rusqlite need an Riot(IRC)/Discord/gitter/etc. community where people can ask questions and discuss rusqlite.",
"title": "Rusqlite need a community.",
"type": "issue"
},
{
"action": "created",
"author": "thomcc",
"comment_id": 629680491,
"datetime": 1589650240000,
"masked_author": "username_1",
"text": "I'm not opposed to it. I'm active on some of the rust discord channels, and mozilla riot (altho the latter mostly for work, and on the weekends I generally don't sign in there).\r\n\r\nGitter is probably the easiest for others though.\r\n\r\n@username_2 do you have any thoughts here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gwenn",
"comment_id": 629757532,
"datetime": 1589701516000,
"masked_author": "username_2",
"text": "Sorry, I have only restricted access to internet where I work.\r\nAnd I am not active on any of them at home.\r\nSo I don't have any opinion.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thomcc",
"comment_id": 629881215,
"datetime": 1589759600000,
"masked_author": "username_1",
"text": "I've made https://gitter.im/rusqlite/community. I chose gitter just because it doesn't require anybody create another account for a thing, e.g. it uses github oauth.\r\n\r\nMaybe it can help coordinate things, or something. Or at least reduce the number of issues we get that are actually about how to use rust or sqlite.\r\n\r\nI'll add it to the readme later tonight.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Voodlaz",
"comment_id": 632268787,
"datetime": 1590085685000,
"masked_author": "username_0",
"text": "I made a pull request adding gitter chat badge to readme.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Voodlaz",
"comment_id": null,
"datetime": 1590085686000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 935 | false | false | 935 | true |
MISP/PyMISP | MISP | 390,662,529 | 314 | null | [
{
"action": "opened",
"author": "marcnil815",
"comment_id": null,
"datetime": 1544705061000,
"masked_author": "username_0",
"text": "The pymisp.get_csv function uses the deprecated api. The api is broken at the moment (filters do not work).",
"title": "pymisp.get_csv uses deprecated api",
"type": "issue"
},
{
"action": "created",
"author": "marcnil815",
"comment_id": 447680416,
"datetime": 1544998011000,
"masked_author": "username_0",
"text": "New API works fine. Should have been clearer. The function called here: https://github.com/MISP/PyMISP/blob/master/examples/get_csv.py\r\nUses the old API. That's all :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Rafiot",
"comment_id": 447754514,
"datetime": 1545033664000,
"masked_author": "username_1",
"text": "Oh, right, thank you, I'll fix it :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Rafiot",
"comment_id": null,
"datetime": 1546512566000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 310 | false | false | 310 | false |
NetApp/ez-rancher | NetApp | 645,883,551 | 25 | null | [
{
"action": "opened",
"author": "jacobweinstock",
"comment_id": null,
"datetime": 1593123395000,
"masked_author": "username_0",
"text": "Rancher has the ability to take a user generated certificate and use it for its UI/api/etc. we need to provide the user of terraform-rancher the ability to supply the certificate so that rancher can use it for the UI/api/etc",
"title": "support for user provided TLS certificate",
"type": "issue"
},
{
"action": "created",
"author": "scaleoutsean",
"comment_id": 746290029,
"datetime": 1608125541000,
"masked_author": "username_1",
"text": "Would this work?\r\n\r\nhttps://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/certificate_signing_request#generate_name\r\n\r\nIt uses existing snake-oil CA so while it is user-generated, the CA is self-signed.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 455 | false | false | 455 | false |
angular/angular | angular | 557,206,975 | 35,049 | {
"number": 35049,
"repo": "angular",
"user_login": "angular"
} | [
{
"action": "opened",
"author": "gregmagolan",
"comment_id": null,
"datetime": 1580346014000,
"masked_author": "username_0",
"text": "This means integration tests no longer need to depend on a $CI_CHROMEDRIVER_VERSION_ARG environment variable to specify which chromedriver version to download to match the locally installed chrome. This was bad DX and not having it specified was not reliable as webdriver-manager would not always download the chromedriver version to work with the locally installed chrome.\r\n\r\n`webdriver-manager update --gecko=false --standalone=false $CI_CHROMEDRIVER_VERSION_ARG` is now replaced with `node webdriver-manager-update.js` in the root package.json, which checks which version of chrome puppeteer has come bundled with & downloads informs webdriver-manager to download the corresponding chrome driver version.\r\n\r\nIntegration tests now use `\"webdriver-manager\": \"file:../../node_modules/webdriver-manager\"` and set resolution for it as well so they don't have to waste type calling webdriver-manager update in postinstall\r\n```\r\n\"// resolutions\": \"Ensure a single version of webdriver-manager which comes from root node_modules that has already run webdriver-manager update\",\r\n\"resolutions\": {\r\n\"webdriver-manager\": \"file:../../node_modules/webdriver-manager\"\r\n}\r\n```\r\nThis should speed up each integration postinstall by a few seconds.\r\n\r\nFurther, integration test package.json files link puppeteer via `file:../../node_modules/puppeteer` which is the ideal situation as the puppeteer post-install won't download chrome if it is already downloaded. In CI, since node_modules is cached it should not need to download Chrome either unless the node_modules cache is busted.\r\n\r\nNB: each version of puppeteer comes bundles with a specific version of chrome. Root package.json & yarn.lock currently pull down puppeteer 2.1.0 which comes with chrome 80. See https://github.com/puppeteer/puppeteer#q-which-chromium-version-does-puppeteer-use for more info.\r\n\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Documentation content changes\r\n- [ ] angular.io application / infrastructure changes\r\n- [x] Other... Please describe: integration test changes \r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information",
"title": "test: use puppeteer in integration tests and to download correct chromedriver",
"type": "issue"
},
{
"action": "created",
"author": "gregmagolan",
"comment_id": 580073780,
"datetime": 1580357161000,
"masked_author": "username_0",
"text": "BONUS: updated the aio build to use puppeteer as well so it no longer depends on `CI_CHROMEDRIVER_VERSION_ARG`.\r\n\r\nOnly two references to `CI_CHROMEDRIVER_VERSION_ARG` left:\r\n1) integration/bazel-schematics/test.sh which I'm not entirely sure how to get rid of it <== @kyliau \r\n2) aio/tools/examples/shared/package.json which I'm not hesitant to touch as its used for examples",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregmagolan",
"comment_id": 583355609,
"datetime": 1581075731000,
"masked_author": "username_0",
"text": "aio changes included back into this PR at Igor's request after all the review comments & Igor reviewed both.\r\n\r\nhttps://github.com/angular/angular/pull/35102 now just testing CI job for this PR that only run on master",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregmagolan",
"comment_id": 583356598,
"datetime": 1581075924000,
"masked_author": "username_0",
"text": "@gkalpak I switch the PWA score test to use protractor. Couldn't figure out the doc examples so will leave that to you :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "IgorMinar",
"comment_id": 583705679,
"datetime": 1581140638000,
"masked_author": "username_1",
"text": "let's see if @filipesilva or @gkalpak have anything else to add. I believe that all their feedback has been addressed.",
"title": null,
"type": "comment"
}
] | 4 | 7 | 5,002 | false | true | 3,923 | false |
elmejdki/Enumerable | null | 579,317,358 | 2 | null | [
{
"action": "opened",
"author": "voscarmv",
"comment_id": null,
"datetime": 1583937871000,
"masked_author": "username_0",
"text": "- Good use of `===` for class comparison \r\n- Check `#my_select` and `#my_map` \r\n- Check range input for methods\r\n- Use `#make_array` on `#my_each` so it applies to all the methods that use it\r\n- Really good project, mostly the implementation of `case` where no block/no parameter given\r\n- Good project, neat and clean code. Really easy to understand.\r\n- Good job. Nice way to put the conditions at different steps. A bit more comments would help maybe.",
"title": "Peer-to-Peer code reviewby Team 78 - The Hummingbirds 🐦",
"type": "issue"
},
{
"action": "created",
"author": "elmejdki",
"comment_id": 606704846,
"datetime": 1585669133000,
"masked_author": "username_1",
"text": "thank you guys for your review",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "elmejdki",
"comment_id": null,
"datetime": 1585669134000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 482 | false | false | 482 | false |
EHDEN/NetworkDashboards | EHDEN | 652,347,356 | 68 | null | [
{
"action": "opened",
"author": "aspedrosa",
"comment_id": null,
"datetime": 1594130314000,
"masked_author": "username_0",
"text": "## Charts in use\r\n- Types (Visit)\r\n\r\n## Materialized view name\r\n\r\n## Original Query\r\n```sql\r\nSELECT source.name, \r\n concept_name AS \"Observation\", \r\n count_value AS \"Nr_Observations\",\r\n source.slug\r\nFROM public.achilles_results AS achilles\r\n INNER JOIN public.data_source AS source\r\n ON achilles.data_source_id=source.id\r\n INNER JOIN public.concept\r\n ON stratum_1 = CAST(concept_id AS text)\r\nWHERE analysis_id = 201\r\n```\r\n\r\n## Optimized Query (If applicable)\r\nMaterialize the join between public.achilles_results, public.data_source and public.concept\r\n```sql\r\nSELECT name, \r\n concept_name, -- AS \"Observation\", -- do this transformation on superset\r\n count_value -- AS \"Nr_Observations\" -- do this transformation on superset\r\nFROM already_joined_view\r\nWHERE analysis_id = 201\r\n```\r\n\r\n## Remarks (If applicable)",
"title": "Visit Types Query",
"type": "issue"
},
{
"action": "closed",
"author": "aspedrosa",
"comment_id": null,
"datetime": 1610718010000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "aspedrosa",
"comment_id": 760947701,
"datetime": 1610718010000,
"masked_author": "username_0",
"text": "Solution took: materialize the entire query",
"title": null,
"type": "comment"
}
] | 1 | 3 | 905 | false | false | 905 | false |
acceptbitcoincash/acceptbitcoincash | acceptbitcoincash | 683,974,770 | 1,874 | null | [
{
"action": "opened",
"author": "accept-bitcoin-cash",
"comment_id": null,
"datetime": 1598093053000,
"masked_author": "username_0",
"text": "Requesting to add 'SonicFast' to the 'Web Hosting provider' category. \n\nDetails follow: \n```yml \n- name: SonicFast\n url: https://sonicfast.io/\n img: SonicFast.png\n bch: true\n btc: true\n othercrypto: true\n twitter: sonicfast9\n facebook: sonicfastio\n email_address: hello@sonicfast.io\n exceptions:\n text: \"Just go to checkout and choose Bitcoin Cash\"\n```\n\n\nResources for adding this merchant:\nLogo Provided:\n\nTwitter Profile Image (48x48):\n\nFacebook Profile Image:\n\n[Link to SonicFast](https://sonicfast.io/)\nCheck their Twitter Page: [twitter.com/sonicfast9](https://twitter.com/sonicfast9)\nCheck their Facebook Page: [fb.com/sonicfastio](https://fb.com/sonicfastio)\nMaybe you might want to check their [Alexa Rank](https://www.alexa.com/siteinfo/sonicfast.io/)\nMaybe you might want to check [Scam Adviser](https://www.scamadviser.com/check-website/sonicfast.io/)\nMaybe you might want to check [Trust Pilot](https://www.trustpilot.com/review/sonicfast.io/)\n\n\n- Verify site is legitimate and safe to list.\n- Correct data in form if any is inaccurate.\n\nIf everything looks okay, Add it to the site:\n- Assign to yourself when you begin work.\n- Download and resize the image and put it into the proper img folder.\n- Add listing alphabetically to proper .yml file.\n- Commit changes mentioning this issue number with `closes #[ISSUE NUMBER HERE]`.",
"title": "Add 'SonicFast' to the 'Web Hosting provider' category",
"type": "issue"
},
{
"action": "created",
"author": "EchterAgo",
"comment_id": 684914666,
"datetime": 1598972086000,
"masked_author": "username_1",
"text": "/ABCbot process",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "accept-bitcoin-cash",
"comment_id": 684914713,
"datetime": 1598972089000,
"masked_author": "username_0",
"text": "Unable to Process. Please set a category section label before retrying.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EchterAgo",
"comment_id": 684916539,
"datetime": 1598972238000,
"masked_author": "username_1",
"text": "/ABCbot process",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "accept-bitcoin-cash",
"comment_id": 684916736,
"datetime": 1598972254000,
"masked_author": "username_0",
"text": "Processed and ready to be evaluated.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,728 | false | false | 1,728 | false |
gravitational/gravity | gravitational | 675,359,745 | 1,984 | null | [
{
"action": "opened",
"author": "aelkugia",
"comment_id": null,
"datetime": 1596844762000,
"masked_author": "username_0",
"text": "### Feature Request\r\nCustomer request where they have a lot of replicas for the same pods and would be best if the logs could be filtered by labels. For example the labels they use are:\r\n\r\n```\r\nselector:\r\napp: cs\r\nmicroservice: cs-auth\r\ncomponent: cs-auth\r\n```\r\n\r\nIn this case they would like to be able to filter logs for `app:cs`, or for `microservice:cs-auth` or by `component: cs-auth`.\r\n\r\nThis would simplify their troubleshooting of their platform.\r\n\r\nMore info in internal zendesk ticket: [#105](https://gravitational.zendesk.com/agent/tickets/105)",
"title": "Enable logs filtering by labels of pods",
"type": "issue"
}
] | 1 | 1 | 555 | false | false | 555 | false |
nim-lang/Nim | nim-lang | 487,468,257 | 12,095 | {
"number": 12095,
"repo": "Nim",
"user_login": "nim-lang"
} | [
{
"action": "opened",
"author": "Clyybber",
"comment_id": null,
"datetime": 1567169620000,
"masked_author": "username_0",
"text": "",
"title": "Remove ENDB",
"type": "issue"
},
{
"action": "created",
"author": "krux02",
"comment_id": 526637811,
"datetime": 1567177712000,
"masked_author": "username_1",
"text": "From me this get's green light. But Araq has to approve it, ENDB is his baby.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mratsim",
"comment_id": 526725031,
"datetime": 1567194247000,
"masked_author": "username_2",
"text": "He thought he already removed it https://irclogs.nim-lang.org/30-08-2019.html#07:32:28\r\nbut it was just the docs in-between 0.18 and 0.19 (https://nim-lang.org/0.18.0/endb.html, https://nim-lang.org/0.19.0/endb.html)",
"title": null,
"type": "comment"
}
] | 3 | 3 | 293 | false | false | 293 | false |
MicrosoftDocs/visualstudio-docs | MicrosoftDocs | 318,110,303 | 862 | {
"number": 862,
"repo": "visualstudio-docs",
"user_login": "MicrosoftDocs"
} | [
{
"action": "opened",
"author": "BioChristou",
"comment_id": null,
"datetime": 1524760754000,
"masked_author": "username_0",
"text": "",
"title": "Fixed a reference and some typos in \"Creating an Extension with an Editor Item Template\"",
"type": "issue"
},
{
"action": "created",
"author": "opbld22",
"comment_id": 384708914,
"datetime": 1524760821000,
"masked_author": "username_1",
"text": "### :white_check_mark: Validation status: passed\r\n\r\n\r\nFile | Status | Preview URL | Details\r\n---- | ------ | ----------- | -------\r\n[docs/extensibility/creating-an-extension-with-an-editor-item-template.md](https://github.com/username_0/visualstudio-docs/blob/feature/editor-item-template-fixes/docs/extensibility/creating-an-extension-with-an-editor-item-template.md) | :white_check_mark:Succeeded | |\r\n\r\nFor more details, please refer to the [build report](https://opbuildstorageprod.blob.core.windows.net/report/2018%5C4%5C26%5C692e8138-f1b0-9929-d89e-225d116f9c25%5CPullRequest%5C201804261639167274-862%5Cworkflow_report.html?sv=2015-02-21&sr=b&sig=WN3ja4Xy0g8EAD%2FhlnOg1%2BfbFJJUJADocMU6C0ghumw%3D&st=2018-04-26T16%3A35%3A20Z&se=2018-05-27T16%3A40%3A20Z&sp=r).\r\n\r\n**Note:** If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregvanl",
"comment_id": 384709518,
"datetime": 1524760950000,
"masked_author": "username_2",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 3 | 3 | 944 | false | false | 944 | true |
miguelgfierro/pybase | null | 529,539,905 | 18 | null | [
{
"action": "opened",
"author": "miguelgfierro",
"comment_id": null,
"datetime": 1574883585000,
"masked_author": "username_0",
"text": "```\r\ndef _save_image(raw_image, image_type, save_directory):\r\n os.makedirs(save_directory, exist_ok=True)\r\n extension = image_type if image_type else \"jpg\"\r\n file_name = str(uuid.uuid4().hex) + \".\" + extension\r\n save_path = os.path.join(save_directory, file_name)\r\n with open(save_path, \"wb+\") as image_file:\r\n image_file.write(raw_image)\r\n```\r\nthe file name is a random name instead of a name related to the file",
"title": "BUG not possible to get the filename where the data is downloaded",
"type": "issue"
},
{
"action": "closed",
"author": "miguelgfierro",
"comment_id": null,
"datetime": 1574984083000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 435 | false | false | 435 | false |
pawamoy/mkdocstrings | null | 556,092,814 | 40 | null | [
{
"action": "opened",
"author": "duichwer",
"comment_id": null,
"datetime": 1580204868000,
"masked_author": "username_0",
"text": "Hi,\r\nI am unable to build docs for one file.\r\nIf I understand those errors correct than they might be caused by the following class definition:\r\n```python\r\nclass GSS(NamedTuple):\r\n \"\"\"\r\n Helper Class to specify the return type of gss\r\n \"\"\"\r\n\r\n gss: float\r\n nA: float\r\n nB: float\r\n nAB: float\r\n```\r\nIs there any way to solve this?\r\n\r\n```bash\r\npoetry run mkdocs build\r\nINFO - Cleaning site directory \r\nINFO - Building documentation to directory: /mnt/c/Users/demo/Documents/repos/myownpackage/site \r\nTraceback (most recent call last):\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/bin/mkdocs\", line 8, in <module>\r\n sys.exit(cli())\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/click/core.py\", line 764, in __call__\r\n return self.main(*args, **kwargs)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/click/core.py\", line 717, in main\r\n rv = self.invoke(ctx)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/click/core.py\", line 1137, in invoke\r\n return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/click/core.py\", line 956, in invoke\r\n return ctx.invoke(self.callback, **ctx.params)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/click/core.py\", line 555, in invoke\r\n return callback(*args, **kwargs)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocs/__main__.py\", line 163, in build_command\r\n ), dirty=not clean)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocs/commands/build.py\", line 270, in build\r\n nav = config['plugins'].run_event('nav', nav, config=config, files=files)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocs/plugins.py\", line 94, in run_event\r\n result = method(item, **kwargs)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocstrings/plugin.py\", line 110, in on_nav\r\n root_object = self.documenter.get_object_documentation(import_string)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 305, in get_object_documentation\r\n root_object = self.get_module_documentation(obj)\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 323, in get_module_documentation\r\n root_object.add_child(self.get_class_documentation(member, module))\r\n File \"/mnt/c/Users/demo/Documents/repos/myownpackage/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 362, in get_class_documentation\r\n source = inspect.getsourcelines(actual_member)\r\n File \"/usr/lib/python3.6/inspect.py\", line 955, in getsourcelines\r\n lines, lnum = findsource(object)\r\n File \"/usr/lib/python3.6/inspect.py\", line 786, in findsource\r\n raise OSError('could not get source code')\r\nOSError: could not get source code\r\nMakefile:64: recipe for target 'docs' failed\r\nmake: *** [docs] Error 1\r\n```",
"title": "\"OSError: could not get source code\" - caused by class?",
"type": "issue"
},
{
"action": "created",
"author": "pawamoy",
"comment_id": 581345663,
"datetime": 1580726013000,
"masked_author": "username_1",
"text": "Hello! Thank you for the report.\r\n\r\nIt seems `inspect` cannot access the file in which the code is written. I'll try to see if this can be fixed on `mkdocstrings` side or if we should just catch and log the error.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "duichwer",
"comment_id": 581625306,
"datetime": 1580765080000,
"masked_author": "username_0",
"text": "Okay. \r\nI do not tottaly understand what is going wrong, but maybe the issue from pytorch with `NamedTuple` is similiar? \r\nhttps://github.com/pytorch/pytorch/issues/29035",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pawamoy",
"comment_id": 591631084,
"datetime": 1582749454000,
"masked_author": "username_1",
"text": "Could you share a link to a repo with a procedure allowing to reproduce? What system are you using? Linux, Windows, WSL, Docker?\r\n\r\nIn the meanwhile I pushed 8e8d604 to catch the OSError and log a warning instead of failing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "duichwer",
"comment_id": 592150023,
"datetime": 1582833623000,
"masked_author": "username_0",
"text": "I'm using Windows 10 with WSL (Ubuntu).\r\nI cannot directly share this project, but I will try to create a dummy project to reproduce this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pawamoy",
"comment_id": 600886655,
"datetime": 1584569854000,
"masked_author": "username_1",
"text": "Hello, were you by chance able to create a dummy project to reproduce it? :slightly_smiling_face:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "duichwer",
"comment_id": 601599397,
"datetime": 1584695498000,
"masked_author": "username_0",
"text": "Thanks for the reminder. The last weeks have been a little tough, but now here is the demo project to reproduce the error.\r\nhttps://github.com/username_0/mkdocstringsdummy\r\nOnly the error message has changed somehow.\r\n```shell\r\npoetry run mkdocs build\r\nINFO - Cleaning site directory \r\nINFO - Building documentation to directory: /mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/site \r\nWARNING - Could not read source for object mkdocstringsdummy.gss.GSS.__getnewargs__: could not get source code\r\nWARNING - Could not read source for object mkdocstringsdummy.gss.GSS.__new__: could not get source code\r\nWARNING - Could not read source for object mkdocstringsdummy.gss.GSS.__repr__: could not get source code\r\nTraceback (most recent call last):\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/bin/mkdocs\", line 11, in <module>\r\n sys.exit(cli())\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/click/core.py\", line 829, in __call__\r\n return self.main(*args, **kwargs)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/click/core.py\", line 782, in main\r\n rv = self.invoke(ctx)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/click/core.py\", line 1259, in invoke\r\n return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/click/core.py\", line 1066, in invoke\r\n return ctx.invoke(self.callback, **ctx.params)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/click/core.py\", line 610, in invoke\r\n return callback(*args, **kwargs)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocs/__main__.py\", line 159, in build_command\r\n build.build(config.load_config(**kwargs), dirty=not clean)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocs/commands/build.py\", line 269, in build\r\n nav = config['plugins'].run_event('nav', nav, config=config, files=files)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocs/plugins.py\", line 94, in run_event\r\n result = method(item, **kwargs)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocstrings/plugin.py\", line 110, in on_nav\r\n root_object = self.documenter.get_object_documentation(import_string)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 313, in get_object_documentation\r\n root_object = self.get_module_documentation(obj)\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 331, in get_module_documentation\r\n root_object.add_child(self.get_class_documentation(member, module))\r\n File \"/mnt/d/User/testuser/Projekte/2020/mkdocstringsdummy/.venv/lib/python3.6/site-packages/mkdocstrings/documenter.py\", line 408, in get_class_documentation\r\n signature = inspect.signature(actual_member.fget)\r\n File \"/usr/lib/python3.6/inspect.py\", line 3065, in signature\r\n return Signature.from_callable(obj, follow_wrapped=follow_wrapped)\r\n File \"/usr/lib/python3.6/inspect.py\", line 2815, in from_callable\r\n follow_wrapper_chains=follow_wrapped)\r\n File \"/usr/lib/python3.6/inspect.py\", line 2381, in _signature_from_callable\r\n raise ValueError('callable {!r} is not supported by signature'.format(obj))\r\nValueError: callable operator.itemgetter(0) is not supported by signature\r\nMakefile:64: recipe for target 'docs' failed\r\nmake: *** [docs] Error 1\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pawamoy",
"comment_id": 601702621,
"datetime": 1584711143000,
"masked_author": "username_1",
"text": "Thanks for the repo! Yes I'll transfer the issue over to pytkdocs.",
"title": null,
"type": "comment"
}
] | 2 | 8 | 7,992 | false | false | 7,992 | true |
uuuuuuuuy/github-slideshow | null | 687,131,328 | 1 | null | [
{
"action": "created",
"author": "uuuuuuuuy",
"comment_id": 681883383,
"datetime": 1598526768000,
"masked_author": "username_0",
"text": "attac",
"title": null,
"type": "comment"
}
] | 2 | 3 | 6,144 | false | true | 5 | false |
overload-development-community/olmod | overload-development-community | 670,416,895 | 26 | null | [
{
"action": "opened",
"author": "roncli",
"comment_id": null,
"datetime": 1596246218000,
"masked_author": "username_0",
"text": "When a match starts, check CRC with overloadmaps.com. If CRC doesn't match, olmod needs to download a new version of the map.",
"title": "Automatic Map Download - Better handling of new maps",
"type": "issue"
},
{
"action": "created",
"author": "roncli",
"comment_id": 673168389,
"datetime": 1597277050000,
"masked_author": "username_0",
"text": "@username_1 This appears to be an issue with overloadmaps.com.\r\n\r\nExample: Kegparty has 2 versions: Kegparty.zip which is broken, and KegpartyU.zip which is fixed. They both have the same Kegparty.mp with the same CRC. However, overloadmaps.com picks the *oldest* file, not the newest, and therefore downloads the broken file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roncli",
"comment_id": 674350677,
"datetime": 1597468294000,
"masked_author": "username_0",
"text": "While the issue in the comment has been resovled, what I'd like is for an API from overloadmaps.com that, when providing the .mp file name it gives a JSON like this:\r\n\r\nGET: https://overloadmaps.com/api/latest-map?level=kegparty.mp\r\n```\r\n{url: \"https://overloadmaps.com/path/to/download/link.zip\" CRC: \"1234ABCD\"}\r\n```\r\n\r\nWhat I can do with this is then prompt the client to download the latest version, and then if the server doesn't have a copy of the level with that CRC it can download it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roncli",
"comment_id": 676830948,
"datetime": 1597884017000,
"masked_author": "username_0",
"text": "@username_1 Any chance we could get an API like this? An empty JSON object would be fine for no results. This API would be hit whenever a player creates a multiplayer game.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arbruijn",
"comment_id": 677533900,
"datetime": 1597921770000,
"masked_author": "username_1",
"text": "This is to automatically change the map version used by the match creator to the version on overloadmaps? Wouldn't that be confusing when trying to test a newer version of a map?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roncli",
"comment_id": 677854623,
"datetime": 1597951485000,
"masked_author": "username_0",
"text": "Not automatically, but rather for a prompt in game. If you're testing a newer version of the map, the creator of the game would just opt to not download the overloadmaps.com version.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,478 | false | false | 1,478 | true |
wirecard/paymentSDK-php | wirecard | 640,494,132 | 679 | null | [
{
"action": "opened",
"author": "grandpalacko",
"comment_id": null,
"datetime": 1592404502000,
"masked_author": "username_0",
"text": "I have been working on the implementation of Wirecard payment in a custom webshop and run into a weird error. When I'm trying to reserve the payment by using the `$transactionService->processJsResponse()` method, I receive multiple warnings and a `String could not be parsed as XML` fatal error.\r\n\r\nI cloned the SDK and changed the city in the `createUiWppV2NonThreeD.php` to München, and after sending the credit card form I received the same fatal error.\r\n\r\nThe problem resides in the `XmlBuilder.php` file where you are using the `htmlentities()` function, which actually doesn't create XML safe strings:\r\n\r\nhttps://github.com/wirecard/paymentSDK-php/blob/77dd6713c633d96d6e0cba44d41e761b2a675030/src/Helper/XmlBuilder.php#L62-L64\r\n\r\nUsing `htmlspecialchars()` seems to be fixing the issue.\r\n\r\nSDK version: 4.0.3\r\nPHP version: 7.3.19",
"title": "XML encoding error",
"type": "issue"
}
] | 1 | 1 | 836 | false | false | 836 | false |
raiguard/Factorio-LtnManager | null | 651,168,143 | 94 | null | [
{
"action": "opened",
"author": "PiggyWhiskey",
"comment_id": null,
"datetime": 1593992249000,
"masked_author": "username_0",
"text": "#### Describe the Bug\r\n\r\nI use Rich Text tags exclusively for Train Station names, and attempted to search for the text.\r\n\r\n\r\n\r\n\r\n#### To Reproduce\r\n\r\nSteps to reproduce the behavior:\r\n\r\n1. Go to GUI\r\n2. Click on Search\r\n3. Type [\r\n4. See error\r\n\r\nThis occurs on a fresh save as well as existing saves.",
"title": "Crash when searching with left Square Bracket",
"type": "issue"
},
{
"action": "closed",
"author": "raiguard",
"comment_id": null,
"datetime": 1595645889000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 411 | false | false | 411 | false |
mitanshu001/blockchain-electronic-voting | null | 519,190,259 | 1 | {
"number": 1,
"repo": "blockchain-electronic-voting",
"user_login": "mitanshu001"
} | [
{
"action": "created",
"author": "hasnat23",
"comment_id": 551403503,
"datetime": 1573194658000,
"masked_author": "username_0",
"text": "Hey bro, I wanna reuse your project. Can you Please guide me on how to run this project? How to connect with azure blockchain service with this project? I shall be thankful to you.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 5,168 | false | true | 180 | false |
pannal/Sub-Zero.bundle | null | 626,335,960 | 733 | null | [
{
"action": "opened",
"author": "bekich21",
"comment_id": null,
"datetime": 1590655893000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nIs it possible to add more subtitle providers to sub zero plugin as: http://utf.subsunacs.net/ and http://subs.sab.bz/",
"title": "Adding more subtitle providers",
"type": "issue"
},
{
"action": "created",
"author": "anexcho",
"comment_id": 1000851949,
"datetime": 1640354906000,
"masked_author": "username_1",
"text": "I would be more than glad to support some beers if you add these providers.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 203 | false | false | 203 | false |
gesagtgetan/GesagtGetan.KrakenOptimizer | gesagtgetan | 539,593,585 | 5 | null | [
{
"action": "opened",
"author": "eckeSolutions",
"comment_id": null,
"datetime": 1576665103000,
"masked_author": "username_0",
"text": "Please update package to support Neos 5.*",
"title": "Neos 5.* support",
"type": "issue"
},
{
"action": "created",
"author": "eckeSolutions",
"comment_id": 580218592,
"datetime": 1580385305000,
"masked_author": "username_0",
"text": "Any news?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerhard-boden",
"comment_id": 580662924,
"datetime": 1580464085000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nsorry for the lack of communication. We talked about this topic internally yesterday and we prioritized, so this will be our first plugin to receive 5.1. support. \r\n\r\nThere is also a new implementation on the way (https://github.com/gesagtgetan/GesagtGetan.KrakenOptimizer/pull/3) but we'll update the active one first ofc.\r\n\r\nJust out of curiosity: What happens if you you manually install this package in your 5.x dev environment? I figured it could just work, but haven't found the time yet to test it out.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eckeSolutions",
"comment_id": 580691018,
"datetime": 1580468884000,
"masked_author": "username_0",
"text": "Well I really don’t know how to do that, with registering the classes and all that. I am happy to try if you tell me how to do it though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerhard-boden",
"comment_id": 580882408,
"datetime": 1580499914000,
"masked_author": "username_1",
"text": "You could clone the package and run `./flow package:rescan` and it might just work, but to make things easier I created a branch with the correct constraint. Just require this in your root `composer.json`:\r\n`\"gesagtgetan/krakenoptimizer\": \"dev-neos-5-test\"`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eckeSolutions",
"comment_id": 581021713,
"datetime": 1580557144000,
"masked_author": "username_0",
"text": "Krakenoptimizer does show up on the package list as “gesagtgetan/krakenoptimizer”",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerhard-boden",
"comment_id": 581126955,
"datetime": 1580643573000,
"masked_author": "username_1",
"text": "Oh boy, worked for me on Friday because it was updated on our private composer repository, but not the public one (I just set up auto-updates for packagist.org).\r\n\r\nCould you please try again, I should at least install just fine now 😊",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eckeSolutions",
"comment_id": 581391828,
"datetime": 1580732981000,
"masked_author": "username_0",
"text": "sorry to bother you again, since requirement is \"neos/neos\": \"^3.0 || ^4.0 || ^5.9\"\r\n^5.9 and not 5.0 I still cant install this package. I think its just a typo...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerhard-boden",
"comment_id": 581396129,
"datetime": 1580733744000,
"masked_author": "username_1",
"text": "Haha, you're right 🙈 \r\nYou don't have to wait until that minor version (which will most probably never come into existence).\r\nI fixed the version constraint\r\n\r\nIn other good news: @gradinarufelix made great progress on the feature branch with cloud asset support, so we might release that version with support for 5.1 very soon. \r\n\r\nBe aware that the provided test branch for master for 5.x has not been tested for 5.x yet, but should merely provide feedback if some parts work without adjustments.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerhard-boden",
"comment_id": 582383682,
"datetime": 1580905541000,
"masked_author": "username_1",
"text": "https://packagist.org/packages/gesagtgetan/krakenoptimizer\r\n\r\nVersion 3.0.0 is here, sorry for the long wait and special thanks to @gradinarufelix",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gerhard-boden",
"comment_id": null,
"datetime": 1580905557000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "eckeSolutions",
"comment_id": 582425696,
"datetime": 1580911897000,
"masked_author": "username_0",
"text": "Thank you verry mutch, this is great!",
"title": null,
"type": "comment"
}
] | 2 | 12 | 2,135 | false | false | 2,135 | true |
GoogleCloudPlatform/mllp | GoogleCloudPlatform | 675,241,116 | 18 | {
"number": 18,
"repo": "mllp",
"user_login": "GoogleCloudPlatform"
} | [
{
"action": "opened",
"author": "cloud-healthcare-github",
"comment_id": null,
"datetime": 1596829997000,
"masked_author": "username_0",
"text": "Prevent multiple MLLP adapter instances from submitting metrics with the same label\n\nWhen running multiple instances of MLLP adapter in the same VM instance, we could get the following error: \"CreateTimeSeries failed: rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Points must be written in order. One or more of the points specified had an older start time than the most recent point.: timeSeries[...]\". This is because multiple MLLP adapter instances tried to submit metrics with the same label. Adding UUID to the label to prevent the possible collision.",
"title": "Prevent multiple MLLP adapter instances from submitting metrics with the same label",
"type": "issue"
}
] | 2 | 5 | 3,960 | false | true | 596 | false |
squidfunk/mkdocs-material | null | 528,157,544 | 1,350 | null | [
{
"action": "opened",
"author": "timvink",
"comment_id": null,
"datetime": 1574695417000,
"masked_author": "username_0",
"text": "__I checked that...__\r\n\r\n- [x] ... the documentation does not mention anything about my idea\r\n- [x] ... to my best knowledge, my idea wouldn't break something for other users\r\n- [x] ... there are no open or closed issues that are related to my idea\r\n\r\n## Description\r\n\r\nAdd support for [mkdocs-git-committers-plugin](https://github.com/zhaoterryy/mkdocs-git-revision-date-plugin). In effect, when a user enables the plugin in `mkdocs.yml`, the latest revision date would automatically display under the page title.\r\n\r\n### Use Cases\r\n\r\nUsers can see clearly when pages where last updated -- without having to go to git.\r\n\r\n### Screenshots / Mockups\r\n\r\nIt would look something like this:\r\n\r\n\r\n\r\nIf this is something that is considered useful I would be happy to work on the PR. Work to be done:\r\n\r\n- Update `base.html` with conditional statements\r\n- Some CSS work\r\n- Update documentation page with supported extensions",
"title": "Add support for mkdocs-git-revision-date-plugin and mkdocs-git-committers-plugin",
"type": "issue"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 558206063,
"datetime": 1574695709000,
"masked_author": "username_1",
"text": "Looks useful to me, happy to collaborate on a PR.\r\n\r\nHow does the plugin handle L10N/I18N? Is the date string printed according to the environment locale? This also needs to be addressed in all other content that is automatically added to the template, i.e. `\"Last update:\"`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 558328970,
"datetime": 1574714151000,
"masked_author": "username_0",
"text": "Good points! \r\n\r\nThe plugin outputs dates in YYYY-MM-DD format. We could use [timeago](https://timeago.org/) which has localization, which we can map to mkdocs [list of supported languages](https://www.mkdocs.org/user-guide/configuration/#lang). Downside is this adds a 2kb dependency. That doesn't solve the `\"Last update:\"` part though. I realize now that this should be part of the `mkdocs-git-committers-plugin` plugin. \r\n\r\nIs I18N a hard requirement for you? If so, I'll need to go and contribute to that plugin first & then re-open this issue here. Otherwise, we can start already with adding an english version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 558351225,
"datetime": 1574717833000,
"masked_author": "username_1",
"text": "Kind of. Adding a hard-coded string to the template I would want to provide a way to translate it easily.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 558507910,
"datetime": 1574755113000,
"masked_author": "username_0",
"text": "I looked into it, and mkdocs offers no special `datetime` formatting, username_2 refers to standard `strftime` functionality (see [this issue](https://github.com/mkdocs/mkdocs/issues/1408)), but the `mkdocs-git-revision-date-plugin` plugin returns a `str` and `datetime` is not imported by `mkdocs`.\r\n\r\nIf we accept the date is always in ISO-8610 format (the [only right format](https://xkcd.com/1179/) anyway), we can move forward with an output like:\r\n\r\n```html\r\n{% if git_revision_date is defined %}\r\n # ... \r\n {{ lang.t('last.update') }}: {{ git_revision_date }}\r\n{% endif %}\r\n```\r\n\r\n```html\r\nLast updated: 2019-11-26\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 558513006,
"datetime": 1574756050000,
"masked_author": "username_1",
"text": "`strftime` would be perfect, or am I missing something? So if the date would be exposed as a date variable, we could use `strftime` in the template with a localized format string (with a reasonable default). MkDocs's [`build_date_utc`](https://www.mkdocs.org/user-guide/custom-themes/#build_date_utc) is also exposed as a `datetime` object. So for reasons of consistency alone I would favor `datetime` over a string.\r\n\r\nAs much as I love XKCD – ISO-8610 is a very technical format. For my own docs I would prefer something more readable like _November 26, 2019_. Could we update the mentioned plugin that it outputs `datetime` objects? It could be implemented as an option to support both formats, `string` and `datetime`. If a `datetime` is encountered, Material will render it using the given format, otherwise it will just display the string.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 558513718,
"datetime": 1574756179000,
"masked_author": "username_1",
"text": "Also see https://github.com/zhaoterryy/mkdocs-git-revision-date-plugin/issues/4, which is already a request for different date formats.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 558594147,
"datetime": 1574768978000,
"masked_author": "username_0",
"text": "Yes let's do it proper then, will contribute to `mkdocs-git-revision-date-plugin` first so we get a `datetime` object, then get back here. Thanks so far!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 558643466,
"datetime": 1574777102000,
"masked_author": "username_0",
"text": "Figured I could already start on this PR while I wait for the other one, so I started here: https://github.com/username_0/mkdocs-material/tree/1350-support-git-revision-date \r\n\r\nI need some help with the `scss`, basically with a conditional margin on `<h1>`, if revision date is available no `margin-bottom: -2em` on h1:\r\n\r\n\r\n\r\nAnd another more challenging issue: When you use a heading 1 (`#`) in a page it takes precedence over the navigation tree title (in `mkdocs.yml`), which means either the revision date is not shown (if within the title if block in `base.html`) or the ordering is wrong (when using separate if block below the title, see picture):\r\n\r\n```html\r\n{% if not \"\\x3ch1\" in page.content %}\r\n <h1>{{ page.title | default(config.site_name, true)}}</h1>\r\n{% endif %}\r\n{% if page.meta.revision_date %}\r\n <small>\r\n {{ lang.t('last.update') }}: {{ page.meta.revision_date.strftime('%d %B %Y') }}\r\n </small>\r\n{% endif %} \r\n```\r\n\r\n\r\nMaybe you have some ideas or pointers in the right direction?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 558678045,
"datetime": 1574781575000,
"masked_author": "username_1",
"text": "Placing it under the `h1` will not work consistently, as the theme sets the page title as `h1` if there's no `h1` in the content as you already noticed. This behavior is not configurable. I think I would recommend to place it [at the bottom after the content and footnotes and before the footer](https://github.com/username_1/mkdocs-material/blob/c706667fb0db97fc8d7b0ae9b88f13e96e7e3436/src/base.html#L331). This should also solve the spacing problems, which are tricky to get right in all possible combinations, as there are quite some rules for subsequent headlines, e.g. `h1 + h2` etc.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 558985015,
"datetime": 1574843640000,
"masked_author": "username_0",
"text": "That's not as nice but a lot more practical.\r\n\r\nI also only now realize `{{ page.meta.revision_date.strftime('%d %B %Y') }}` does not respect the language option from `mkdocs-material`. It will default to the user's python locale.\r\n\r\nChanging that is possible in python:\r\n\r\n```python\r\nimport locale\r\nimport datetime\r\ndate = datetime.datetime.now().date()\r\nlocale.setlocale(locale.LC_ALL, 'en_US.UTF-8')\r\nprint(date.strftime('%A'))\r\n#> Wednesday\r\nlocale.setlocale(locale.LC_ALL, 'nl_NL.UTF-8')\r\nprint(date.strftime('%A'))\r\n#> woensdag\r\n```\r\n\r\nBut not every user has every locale installed on his system. And it would also require a contribution to `mkdocs`. The alternative of exporting `LC_ALL` as an environment variable before building is not a failsafe method, and perhaps not user-friendly either.\r\n\r\nAnother way to do this is to use the python [timeago](https://github.com/hustcc/timeago) package that has localization files:\r\n\r\n```python\r\nimport timeago\r\ndate = datetime.datetime.now().date()\r\nprint(timeago.format(date))\r\n#> 9 hours ago\r\nprint(timeago.format(date, locale = \"nl\"))\r\n#> 9 uren geleden\r\n```\r\n\r\nI could contribute to `mkdocs` a new custom jinja2 [mkdocs template filter](https://www.mkdocs.org/user-guide/custom-themes/#template-filters) that uses timeago and takes locale as an argument, something like:\r\n\r\n```html\r\n`{{ lang.t('last.update') }}: {{ totimeago( page.meta.revision_date, config.theme.language) }}`\r\n```\r\n\r\nSo finally output would be something like:\r\n\r\n```html\r\nLast update: 9 hours ago\r\n```\r\n\r\nAlternatively, the easiest route would be using YYYY-MM-DD format, e.g.:\r\n\r\n```html\r\nLast update: 2019-11-27\r\n```\r\n\r\nLet me know what you prefer, or if you have any other good ideas ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559019826,
"datetime": 1574849227000,
"masked_author": "username_1",
"text": "@username_0 thanks for the thorough research and experimentation! If opening the possibility to set locales opens yet another can of worms, I would also be fine with an English-only formatted date string which is adjustable through `strftime`. I guess it's possible to adjust the locale via `LC_ALL` as an environment variable in front of the `mkdocs` command, isn't it? We could add a hint in the documentation how to achieve this, e.g:\r\n\r\n```\r\nLC_ALL=nl_NL mkdocs build\r\n```\r\n\r\n@username_2 could you maybe comment on this topic? Before we go down a specific path I would like to hear your opinion. I feel that localization is kind of an open and unresolved issue of MkDocs, which is also why Material went its own way with L10N based on template files / macros. Are there any plans for improving localization, maybe with a language parameter set in `mkdocs.yml` or via environment variables?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waylan",
"comment_id": 559095892,
"datetime": 1574862721000,
"masked_author": "username_2",
"text": "The current state of L10N is summarized in mkdocs/mkdocs#211 and the beginning of an implementation exists in mkdocs/mkdocs#1778. That PR adds a `local` setting to the `theme`. In other words, the default language would be defined in [mkdocs_theme.yml][1] and could be overridden in `mkdocs.yml`:\r\n\r\n```yml\r\ntheme:\r\n local: fr\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 559105695,
"datetime": 1574864247000,
"masked_author": "username_0",
"text": "@username_1 Localization seems like the way to go then. I suggest I first propose & make a PR to `mkdocs` that implements the `totimeago` jinja2 filter. Then back here in addition to changes discussed we should also rename the `language` parameter to `locale` to be consistent with future versions of `mkdocs`. We can do this in a backwards compatible way with some jinja2 logic.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559108200,
"datetime": 1574864639000,
"masked_author": "username_1",
"text": "We definitely need to provide backward-compatibility. Furthermore, we'll wait for a new MkDocs version to configure the locale for `strftime`, so there should be no necessity for `timeago` I guess.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waylan",
"comment_id": 559113275,
"datetime": 1574865407000,
"masked_author": "username_2",
"text": "As this is all about supporting a third party plugin, I would suggest changes like this should be made to the plugin. As a reminder, plugins can alter the Jinja environment with the [on_env][1] event (to add filters, for example). I would expect a plugin which provides dates to a template to provide that date as a `datetime` object and also provide any date based filters needed to work with the `datetime` object. There is no need for MkDocs to change anything in that respect.\r\n\r\n[1]: https://www.mkdocs.org/user-guide/plugins/#on_env",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waylan",
"comment_id": 559127101,
"datetime": 1574867431000,
"masked_author": "username_2",
"text": "I'm not sure what you mean here. Plugins have access to the config, including `config['theme']['locale']` so a plugin can, if it chooses, act on the `locale`. However, as it is currently implemented, the translation files are provided by the theme, so any translation should be done within the theme templates, not a plugin. \r\n\r\nAs an example, the only change to the `search` plugin in the PR is [to the JS][1] and all that does is obtain the \"no results found\" string from the HTML rather than hardcoding it in the JS. The string is now defined and translated [in the template][2].\r\n\r\n[1]: https://github.com/mkdocs/mkdocs/pull/1778/files#diff-a7101432976e7e08eca206a334bc12ed\r\n[2]: https://github.com/mkdocs/mkdocs/pull/1778/files#diff-343ab2b4999ffe54a053bf9108362d29R15",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559135244,
"datetime": 1574868572000,
"masked_author": "username_1",
"text": "@username_2 thanks! Do you have a rough estimate on when this will be released? Are we talking weeks or months? I'm asking because I have Material v5 in the making which will have some breaking changes and it would be great to push them out at once and not with a v6 some weeks after that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waylan",
"comment_id": 559230050,
"datetime": 1574884369000,
"masked_author": "username_2",
"text": "I have no concrete timetable for this and can't commit to including it in a specific release. As it stands, the PR needs some more work: the `readthedocs` theme needs updated and the whole thing needs documented. I'm not sure when I'll have the time to get to it. In fact I haven't worked on MkDocs in months (aside from reviewing PRs by others). So if someone else completed the PR, it could get merged sooner, but the next release still has some other blockers so it will likely be a while. In other words, I wouldn't wait on it if I were you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559240607,
"datetime": 1574886506000,
"masked_author": "username_1",
"text": "@username_2 answers my question, thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 559591144,
"datetime": 1574970019000,
"masked_author": "username_0",
"text": "Update: made a [PR for adding totimeago](https://github.com/zhaoterryy/mkdocs-git-revision-date-plugin/pull/8) jinja2 filter to `mkdocs-git-revision-date-plugin`, pending review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559591537,
"datetime": 1574970196000,
"masked_author": "username_1",
"text": "@username_0 pretty cool. Is it possible to format a date with a locale similar to `strftime`, like for example `November 28, 2019`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 559601623,
"datetime": 1574974557000,
"masked_author": "username_0",
"text": "`timeago` only has basic localization (see example for [en](https://github.com/hustcc/timeago/blob/master/src/timeago/locales/en.py)). \r\n\r\nYour remark made me think: dates don't require much translation. Then I found [babel](https://github.com/python-babel/babel):\r\n\r\n```python\r\nfrom datetime import date\r\nfrom babel.dates import format_date\r\nd = date(2007, 4, 1)\r\nformat_date(d, format='long', locale='en')\r\n#> 'April 1, 2007'\r\n```\r\n\r\nI'll contribute a PR with a `formatdate` jinja2 filter to `mkdocs-git-revision-date-plugin` as well. Once it's merged I can come back here. We'll get there eventually!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 559928833,
"datetime": 1575103705000,
"masked_author": "username_0",
"text": "Update: `mkdocs-git-revision-date-plugin` v.02 is now published on PyPi which enables the option of having the date as a `datetime` instead of `str`.\r\n\r\nI currently writing my own mkdocs plugin or order to provide some jinja2 date filters ([mkdocs-date-filters-plugin](https://github.com/username_0/mkdocs-date-filters-plugin)), because [babel](https://github.com/python-babel/babel) and [timeago](https://github.com/hustcc/timeago) are dependencies that shouldn't be in `mkdocs-git-revision-date-plugin`. That way I can also make sure that the plugin uses `theme.language` as the default locale, and mkdoc's future `locale` setting as well.\r\n\r\nThen using all that in `mkdocs-material` should be relatively easy:\r\n\r\n```yml\r\n# mkdocs.yml\r\nplugins:\r\n - git-revision-date:\r\n as_datetime: True\r\n - date-filters\r\n```\r\n\r\nAnd in `base.html`, including a nice fall back to `YYYY-MM-DD` if you don't want to use `date-filters`: \r\n\r\n```html\r\n{% if todateformat is defined %}\r\n {{ page.meta.revision_date | todateformat }}\r\n{% else %}\r\n {{ page.meta.revision_date }}\r\n{% endif %}\r\n```\r\n\r\nI tested this, but jinja throws an error if you don't have the new `mkdocs-date-filters-plugin` installed:\r\n\r\n```bash\r\njinja2.exceptions.TemplateAssertionError: no filter named 'todateformat'\r\n```\r\n\r\nThere's an open issue for this behaviour in jinja: (https://github.com/pallets/jinja/issues/842).\r\nI'll need to think about a workaround, or take up the challenge of providing a PR to jinja first.\r\n\r\nTo be continued :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559933459,
"datetime": 1575105596000,
"masked_author": "username_1",
"text": "Thanks for sharing your progress. I hope that in the end the configuration for this will not be too complicated with multiple possible scenarios that all need to be handled. There’s a reasonable amount of non tech-savvy people using this project.\r\n\r\nAs I understand there would be four cases that need to be addressed:\r\n\r\n- both plugins set + `as_datetime: true`\r\n- both plugins set + `as_datetime: false`\r\n- no date filters plugin\r\n- no revision date plugin (default, same as now)\r\n\r\nThat’s a lot of potential for breakage. Could we improve on the DX here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 559942717,
"datetime": 1575109412000,
"masked_author": "username_0",
"text": "Yes you're right. I didn't even think of the \"both plugins set + `as_datetime: false`\" case. Setup is too involved, implementation in `mkdocs-material` is not clean, and indeed too much potential for breakage.\r\n\r\nThought about it some more and I have a new idea: Fork and create a new plugin `mkdocs-git-revision-date-localized-plugin` that just makes the localized git revision dates available as normal jinja variables. \r\n\r\nUsage:\r\n\r\n```\r\n# mkdocs.yml\r\nplugins:\r\n - git-revision-date-localized:\r\n```\r\n\r\nImplementation:\r\n\r\n```html\r\n{% if git_revision_date_localized is defined %}\r\n # ... \r\n {{ lang.t('last.update') }}: {{ git_revision_date_localized }}\r\n{% endif %}\r\n```\r\n\r\n(and we could also support the `YYYY-MM-DD` version of `git_revision_date`, prioritizing the localizated version over the normal one). \r\n\r\nShould solve all the problems :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 559950896,
"datetime": 1575112934000,
"masked_author": "username_1",
"text": "Yes, that sounds like a reasonable plan! So the format is automatically handled by the plugin according to the selected locale. How is the locale determined? `theme.lang`? Later it's possible to use `mkdocs.locale`, but not for now I guess.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 563217764,
"datetime": 1575894819000,
"masked_author": "username_0",
"text": "I published [username_0/mkdocs-git-revision-date-localized-plugin ](https://github.com/username_0/mkdocs-git-revision-date-localized-plugin) this morning. It supports `theme.language` as well as the future `mkdocs.locale`. \r\n\r\nI just opened a PR to add support for it. I included documentation & the translations I could find on google translate. Would appreciate a review!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "squidfunk",
"comment_id": null,
"datetime": 1576057565000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "timvink",
"comment_id": 564643815,
"datetime": 1576084478000,
"masked_author": "username_0",
"text": "Thanks for all the support on this issue @username_1. I realize now even more how much effort has gone into `mkdocs-material`. Thanks for all your work and the awesome theme! Glad I could contribute back a little bit.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "squidfunk",
"comment_id": 564650071,
"datetime": 1576085393000,
"masked_author": "username_1",
"text": "Thanks for your contributions! Pleasure to work with you. The changes were just released with 4.6.0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RDIL",
"comment_id": 565874960,
"datetime": 1576461403000,
"masked_author": "username_3",
"text": "Hey @username_0, I tried it out but got:\r\n```python\r\nException in callback <bound method LiveReloadHandler.poll_tasks of <class 'livereload.handlers.LiveReloadHandler'>>\r\n Traceback (most recent call last):\r\n File \"/home/gitpod/.pyenv/versions/3.7.4/lib/python3.7/site-packages/tornado/ioloop.py\", line 907, in _run\r\n return self.callback()\r\n File \"/workspace/.pip-modules/lib/python3.7/site-packages/livereload/handlers.py\", line 69, in poll_tasks\r\n filepath, delay = cls.watcher.examine()\r\n File \"/workspace/.pip-modules/lib/python3.7/site-packages/livereload/watcher.py\", line 105, in examine\r\n func()\r\n File \"/workspace/.pip-modules/lib/python3.7/site-packages/mkdocs/commands/serve.py\", line 107, in builder\r\n site_dir=site_dir\r\n File \"/workspace/.pip-modules/lib/python3.7/site-packages/mkdocs/config/base.py\", line 210, in load_config\r\n \"Aborted with {0} Configuration Errors!\".format(len(errors))\r\n mkdocs.exceptions.ConfigurationError: Aborted with 1 Configuration Errors!\r\n```\r\nAny idea why? I really want to use it.\r\n\r\n`mkdocs.yml`:\r\n\r\n```yaml\r\nsite_name: username_3 Web Docs\r\n\r\ntheme:\r\n name: 'material'\r\n palette:\r\n primary: 'cyan'\r\n accent: 'cyan'\r\n feature:\r\n tabs: false\r\n favicon: /favicon.ico\r\n logo: assets/34555510.png\r\n\r\nrepo_name: 'rdilweb/docs'\r\nrepo_url: 'https://github.com/rdilweb/docs'\r\n\r\nmarkdown_extensions:\r\n - markdown.extensions.admonition\r\n - markdown.extensions.codehilite:\r\n guess_lang: false\r\n - markdown.extensions.def_list\r\n - markdown.extensions.footnotes\r\n - markdown.extensions.meta\r\n - markdown.extensions.toc:\r\n permalink: true\r\n - pymdownx.arithmatex\r\n - pymdownx.betterem:\r\n smart_enable: all\r\n - pymdownx.caret\r\n - pymdownx.critic\r\n - pymdownx.details\r\n - pymdownx.emoji:\r\n emoji_generator: !!python/name:pymdownx.emoji.to_svg\r\n - pymdownx.inlinehilite\r\n - pymdownx.keys\r\n - pymdownx.magiclink\r\n - pymdownx.mark\r\n - pymdownx.smartsymbols\r\n - pymdownx.superfences\r\n - pymdownx.tasklist:\r\n custom_checkbox: true\r\n - pymdownx.tilde\r\n - git-revision-date-localized:\r\n type: timeago\r\n\r\nsite_description: Documentation for username_3's services and libraries.\r\nsite_url: https://docs.rdil.rocks\r\nsite_author: Reece Dunham\r\ncopyright: Copyright (©) Reece Dunham 2019-present\r\nremote_branch: master\r\n\r\nextra:\r\n social:\r\n - type: 'github'\r\n link: 'https://github.com/rdilweb'\r\n - type: 'twitter'\r\n link: 'https://twitter.com/rdil_pickle'\r\n\r\nnav:\r\n - Home: index.md\r\n - API: api.md\r\n - Libraries:\r\n - area4: libraries/area4.md\r\n - filehandlers: libraries/filehandlers.md\r\n - intutils: libraries/intutils.md\r\n - lcpy: libraries/lcpy.md\r\n - LiquidBT:\r\n - Introduction: libraries/liquidbt/intro.md\r\n - \"Getting Started\": libraries/liquidbt/getting-started.md\r\n - Plugins: libraries/liquidbt/plugins.md\r\n - \"Code of Conduct\": CODE_OF_CONDUCT.md\r\n - \"Docs License\": LICENSE.md\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timvink",
"comment_id": 565964355,
"datetime": 1576486295000,
"masked_author": "username_0",
"text": "Hi @username_3 \r\n\r\nHappy to hear you'd like to use it! \r\n\r\nYou have an error in your config, as you added a plugin under `markdown-extensions`. Instead, add a new section with:\r\n\r\n```\r\nplugins:\r\n - git-revision-date-localized\r\n type: timeago\r\n```\r\n\r\nand if you use search, you need to explictly enable it under plugins as well, i.e.:\r\n\r\n```\r\nplugins:\r\n - search\r\n - git-revision-date-localized\r\n type: timeago\r\n```\r\n\r\nIf you have any issues with the plugin you can open an issue at [mkdocs-git-revision-date-localized-plugin](https://github.com/username_0/mkdocs-git-revision-date-localized-plugin)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RDIL",
"comment_id": 566035361,
"datetime": 1576498327000,
"masked_author": "username_3",
"text": "Ohhh thanks @username_0, didn't notice that. 😄",
"title": null,
"type": "comment"
}
] | 4 | 34 | 19,654 | false | false | 19,654 | true |
emberjs/guides | emberjs | 231,797,653 | 1,955 | {
"number": 1955,
"repo": "guides",
"user_login": "emberjs"
} | [
{
"action": "opened",
"author": "tchan",
"comment_id": null,
"datetime": 1495887289000,
"masked_author": "username_0",
"text": "Added UI definition.\r\nReferencing https://github.com/emberjs/guides/issues/1877",
"title": "Update web-development.md",
"type": "issue"
},
{
"action": "created",
"author": "locks",
"comment_id": 304460090,
"datetime": 1495900211000,
"masked_author": "username_1",
"text": "👌 Thank you!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 91 | false | false | 91 | false |
nim-lang/Nim | nim-lang | 601,114,138 | 13,995 | {
"number": 13995,
"repo": "Nim",
"user_login": "nim-lang"
} | [
{
"action": "opened",
"author": "cooldome",
"comment_id": null,
"datetime": 1587047867000,
"masked_author": "username_0",
"text": "Case object assign restrictions are lifted. In new runtime it is now allowed to assign discriminator field.",
"title": "Implements RFCs #209",
"type": "issue"
},
{
"action": "created",
"author": "Araq",
"comment_id": 614818582,
"datetime": 1587061329000,
"masked_author": "username_1",
"text": "The patch looks really clean and all tests pass. Do you want me to review it carefully anyway?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timotheecour",
"comment_id": 615199978,
"datetime": 1587123865000,
"masked_author": "username_2",
"text": "for reference: clickable link to RFC: https://github.com/nim-lang/RFCs/issues/209",
"title": null,
"type": "comment"
}
] | 3 | 3 | 282 | false | false | 282 | false |
material-components/material-components-ios | material-components | 391,770,777 | 6,030 | null | [
{
"action": "opened",
"author": "material-mirror",
"comment_id": null,
"datetime": 1545061509000,
"masked_author": "username_0",
"text": "This was filed as an internal issue. If you are a Googler, please visit [b/121127197](http://b/121127197) for more details.\n\n<!-- Auto-generated content below, do not modify -->\n\n---\n#### Internal data\n- Associated internal bug: [b/121127197](http://b/121127197)",
"title": "[Cards] Internal issue: b/121127197",
"type": "issue"
},
{
"action": "closed",
"author": "rami-a",
"comment_id": null,
"datetime": 1545143919000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 262 | false | false | 262 | false |
robvanderleek/create-issue-branch | null | 647,416,288 | 176 | null | [
{
"action": "opened",
"author": "Jamesking56",
"comment_id": null,
"datetime": 1593440289000,
"masked_author": "username_0",
"text": "It would be nice if we could force the branch name to always be lowercase",
"title": "Feature Request: Force lowercase",
"type": "issue"
},
{
"action": "created",
"author": "robvanderleek",
"comment_id": 655508303,
"datetime": 1594213723000,
"masked_author": "username_1",
"text": "Hi @username_0 \r\n\r\nThanks for the feedback 😄 \r\n\r\nIt should be possible to extend the `${...}` placeholder substitution functionality in the [custom branch name](https://github.com/username_1/create-issue-branch#branch-names) configuration option a bit to support this.\r\n\r\nFor example, I can adopt the [bash-style](https://www.gnu.org/software/bash/manual/bash.html#Shell-Parameter-Expansion) parameter expansion flags `^`, and `,` to uppercase and lowercase strings (I don't think the options to uppercase or lowercase the first character are necessary).\r\nIf you want the issue title part of the branch to always be lowercase you would then configure it like this:\r\n\r\n```yaml\r\nbranchName: '${issue.number}-${issue.title,}'\r\n```\r\n\r\nWould this work for your use-case?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "robvanderleek",
"comment_id": 663884608,
"datetime": 1595700675000,
"masked_author": "username_1",
"text": "Hi @username_0 \r\n\r\nI've implemented the lowercase and uppercase operators for branch name placeholder substitutions. Hope this works for your use-case.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 1,154 | false | true | 994 | true |
cloud-hypervisor/cloud-hypervisor | cloud-hypervisor | 615,669,433 | 1,153 | null | [
{
"action": "opened",
"author": "sboeuf",
"comment_id": null,
"datetime": 1589183524000,
"masked_author": "username_0",
"text": "Base on https://github.com/cloud-hypervisor/cloud-hypervisor/pull/1121#discussion_r422071103, we should introduce a `PciBar` structure containing all information related to a BAR, instead of having separate arrays for each info.",
"title": "pci: Introduce PciBar structure to simplify the code",
"type": "issue"
},
{
"action": "closed",
"author": "sboeuf",
"comment_id": null,
"datetime": 1594792775000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 228 | false | false | 228 | false |
iconfont-cli/mini-program-iconfont-cli | iconfont-cli | 526,952,217 | 5 | null | [
{
"action": "opened",
"author": "xxasd",
"comment_id": null,
"datetime": 1574390243000,
"masked_author": "username_0",
"text": "",
"title": "能支持uniapp吗",
"type": "issue"
},
{
"action": "closed",
"author": "xxasd",
"comment_id": null,
"datetime": 1574391094000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "xxasd",
"comment_id": null,
"datetime": 1574391102000,
"masked_author": "username_0",
"text": "",
"title": "能支持uniapp吗",
"type": "issue"
},
{
"action": "created",
"author": "fwh1990",
"comment_id": 557428722,
"datetime": 1574408993000,
"masked_author": "username_1",
"text": "uniapp还没用过。能说明一下使用场景吗？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xxasd",
"comment_id": 557461465,
"datetime": 1574415323000,
"masked_author": "username_0",
"text": "就是uniapp编译到微信小程序的时候没法用多色的svg，我现在用的也是svg改base64格式方法，但是多色设置这一块我没有好的解决办法，uniapp用的是vue，行内样式如果放base64格式的话它不起效，很头疼",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fwh1990",
"comment_id": 557475469,
"datetime": 1574417857000,
"masked_author": "username_1",
"text": "Ok，我先评估一下。如果有兼容uniapp，应该是会再开一个库。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xxasd",
"comment_id": 557746127,
"datetime": 1574470080000,
"masked_author": "username_0",
"text": "好的谢谢",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nxboo",
"comment_id": 571245744,
"datetime": 1578334118000,
"masked_author": "username_2",
"text": "uni 可以理解为mpvue",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fwh1990",
"comment_id": 571419721,
"datetime": 1578368436000,
"masked_author": "username_1",
"text": "目前uni-app的市场占有和taro比如何",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jsLyLeeHi",
"comment_id": 998562314,
"datetime": 1640074445000,
"masked_author": "username_3",
"text": "我在用taro",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "xxasd",
"comment_id": null,
"datetime": 1640248009000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "SCC0821",
"comment_id": 1020055832,
"datetime": 1643027833000,
"masked_author": "username_4",
"text": "https://juejin.cn/post/7056749403104608287/这篇文章告诉了如何在uni-app中使用，完美解决",
"title": null,
"type": "comment"
}
] | 5 | 12 | 277 | false | false | 277 | false |
Hammerspoon/hammerspoon | Hammerspoon | 706,745,080 | 2,501 | {
"number": 2501,
"repo": "hammerspoon",
"user_login": "Hammerspoon"
} | [
{
"action": "opened",
"author": "latenitefilms",
"comment_id": null,
"datetime": 1600815791000,
"masked_author": "username_0",
"text": "- `hs.accessibilityStateCallback`, `hs.textDroppedToDockIconCallback` and `hs.fileDroppedToDockIconCallback` no longer generate an error if there’s no callback defined.\r\n- Closes #2500",
"title": "[READY] Removed unnecessary error messages when callback functions not defined
",
"type": "issue"
},
{
"action": "created",
"author": "asmagill",
"comment_id": 697132054,
"datetime": 1600836561000,
"masked_author": "username_1",
"text": "lgtm",
"title": null,
"type": "comment"
}
] | 2 | 2 | 188 | false | false | 188 | false |
DrewScoggins/performance-2 | null | 627,605,977 | 37 | null | [
{
"action": "closed",
"author": "DrewScoggins",
"comment_id": null,
"datetime": 1590800628000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 1,413 | false | true | 0 | false |
dianping/cat | dianping | 499,848,407 | 1,827 | null | [
{
"action": "opened",
"author": "Lovnx",
"comment_id": null,
"datetime": 1569725783000,
"masked_author": "username_0",
"text": "现象：服务端更改应用采样率后，客户端并未按照更新的采样率上报数据\r\n\r\n源码阅读：\r\n客户端每3分钟去拉一下服务端配置，但是如果获取的最新router与客户端初始化的router相等的话，则不会去更新采样率等信息，也就是说，只有在服务端修改了routers信息之后，才会更新\r\n\r\n\r\n",
"title": "java客户端采样率更新无效",
"type": "issue"
},
{
"action": "closed",
"author": "Lovnx",
"comment_id": null,
"datetime": 1569977558000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 363 | false | false | 363 | false |
input-output-hk/jormungandr | input-output-hk | 595,858,185 | 2,033 | null | [
{
"action": "opened",
"author": "NicolasDP",
"comment_id": null,
"datetime": 1586265215000,
"masked_author": "username_0",
"text": "https://github.com/input-output-hk/jormungandr/blob/3ed43d274cfd680e7cb8eb05a11afdb282900c2a/jormungandr-watchdog/src/service/intercom.rs#L35",
"title": "remove the use of the mutex",
"type": "issue"
},
{
"action": "closed",
"author": "danielSanchezQ",
"comment_id": null,
"datetime": 1587637660000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 141 | false | false | 141 | false |
pmd/pmd | pmd | 598,319,385 | 2,413 | {
"number": 2413,
"repo": "pmd",
"user_login": "pmd"
} | [
{
"action": "opened",
"author": "adangel",
"comment_id": null,
"datetime": 1586628041000,
"masked_author": "username_0",
"text": "**PR Description:**\r\n\r\n* CPD has an own subsection now\r\n* Extra page for CPD's renderers\r\n* Extra page for PMD's renderers including examples\r\n\r\nNote: while the CPD page is moved in the sidebar, the permalink stays the same.",
"title": "[doc] Improve documentation about the available renderer (PMD/CPD)",
"type": "issue"
},
{
"action": "created",
"author": "adangel",
"comment_id": 618261910,
"datetime": 1587630808000,
"masked_author": "username_0",
"text": "Sounds good. I sometimes did this before as well. The only thing I'm unsure about is: when to add an entry to the release notes? If it's an issue, that is fixed - always - that's easy to decide. Simple rule. But for pull requests, there is no such simple rule... but we can try to do this in the future. For external PRs we might to mention it then twice in the release notes (under fixed issues and under external contributions).",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,417 | false | true | 654 | false |
philanderson888/c-sharp | null | 551,736,197 | 23 | null | [
{
"action": "opened",
"author": "philanderson888",
"comment_id": null,
"datetime": 1579333867000,
"masked_author": "username_0",
"text": "At the moment the date is blank in edit mode even though there is a valid date in the database.\r\n\r\nChange the view logic to show the date\r\n\r\nShould be trivial.",
"title": "Show the date when editing an item in the FamilyDatabase application",
"type": "issue"
},
{
"action": "created",
"author": "philanderson888",
"comment_id": 575876243,
"datetime": 1579333914000,
"masked_author": "username_0",
"text": "At the moment here is the code in the model\r\n\r\n```\r\n [Display(Name = \"Date\")]\r\n [DataType(DataType.Date)]\r\n [DisplayFormat(ApplyFormatInEditMode = true, DataFormatString = \"{0:dd/MM/yyyy}\")]\r\n public DateTime LogDate { get; set; }\r\n```\r\n\r\nI'm not sure if I have to update the model code or the view code.\r\n\r\nLet's try updating the model code first",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philanderson888",
"comment_id": 575876274,
"datetime": 1579333942000,
"masked_author": "username_0",
"text": "Let's try this fix\r\n\r\n```\r\nDataFormatString = \"{0:yyyy-MM-dd}\"\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philanderson888",
"comment_id": 575876364,
"datetime": 1579334023000,
"masked_author": "username_0",
"text": "### This was a solution given - does it work?\r\n\r\n```\r\npublic class ObScore\r\n{\r\n [DataType(DataType.Date)]\r\n [DisplayFormat(DataFormatString = \"{0:yyyy-MM-dd}\", ApplyFormatInEditMode = true)]\r\n public DateTime Date { get; set; }\r\n}\r\n```\r\n\r\nand \r\n\r\n```\r\n<div class=\"form-group\">\r\n @Html.LabelFor(model => model.Date, htmlAttributes: new { @class = \"control-label col-md-2\" })\r\n <div class=\"col-md-10\">\r\n\r\n @* Control with date picker *@\r\n @Html.EditorFor(model => model.Date, new { htmlAttributes = new { @class = \"form-control\" } })\r\n @Html.ValidationMessageFor(model => model.Date, \"\", new { @class = \"text-danger\" })\r\n </div>\r\n</div>\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philanderson888",
"comment_id": 575876415,
"datetime": 1579334071000,
"masked_author": "username_0",
"text": "And - yes - wow - just making that very small change has worked!\r\n\r\nProblem is now fixed!!!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philanderson888",
"comment_id": 575876429,
"datetime": 1579334082000,
"masked_author": "username_0",
"text": "Should update Notion now also!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "philanderson888",
"comment_id": null,
"datetime": 1579339490000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 7 | 1,400 | false | false | 1,400 | false |
stakater/Forecastle | stakater | 572,701,353 | 99 | {
"number": 99,
"repo": "Forecastle",
"user_login": "stakater"
} | [
{
"action": "opened",
"author": "usamaahmadkhan",
"comment_id": null,
"datetime": 1582889751000,
"masked_author": "username_0",
"text": "",
"title": "Update pipeline version",
"type": "issue"
},
{
"action": "created",
"author": "stakater-user",
"comment_id": 592477219,
"datetime": 1582890070000,
"masked_author": "username_1",
"text": "@username_0 Image is available for testing. ``docker pull stakater/forecastle:SNAPSHOT-PR-99-1``",
"title": null,
"type": "comment"
}
] | 2 | 2 | 100 | false | false | 100 | true |
ev3dev/ev3dev-lang-python | ev3dev | 617,517,124 | 742 | null | [
{
"action": "opened",
"author": "monsfortis1940",
"comment_id": null,
"datetime": 1589381583000,
"masked_author": "username_0",
"text": "**Question**\r\n\r\nHow do you ...?\r\n\r\nI have a question about tacho counts.\r\n\r\nIs it possible to run the tacho motors based upon the tacho counts.\r\nfor instance:\r\n\r\ncount_left = tacho_count_left\r\ncount_right = tacho_count_right\r\nerror = count_left - count_right\r\ntank_pair.on (left_speed = speed + error, right_speed = speed - error) \r\n\r\nthank you in advance\r\nmario\r\n\r\n\r\n\r\n**Screenshots**\r\nIf applicable, add screenshots to help explain your question.\r\n\r\n**Desktop (please complete the following information):**\r\n - OS and version: [e.g. Window 10 1809, macOS 10.14]\r\n - Connection Type: [e.g. USB, Bluetooth, Wi-Fi]\r\n - Software: [e.g. Visual Studio Code, PuTTY]\r\n\r\n**Robot (please complete the following information):**\r\n - Device: [e.g. EV3, BrickPi3]\r\n - Versions: [see below - SD card image version, Linux kernel version, etc.]\r\n\r\n```\r\nPlease paste the system info from the ev3dev VS Code extension or the output of `ev3dev-sysinfo -m` here!\r\n```",
"title": "EV3dev Python3: tacho_counts",
"type": "issue"
},
{
"action": "created",
"author": "WasabiFan",
"comment_id": 628384317,
"datetime": 1589431707000,
"masked_author": "username_1",
"text": "If you're asking whether you can provide speed in tacho counts per second, yes you can; you should use `SpeedNativeUnits`. So something like:\r\n\r\n```\r\ntank_pair.on (left_speed = SpeedNativeUnits(speed + error), right_speed = SpeedNativeUnits(speed - error))\r\n```\r\n\r\nThe units are documented here for more info: https://python-ev3dev.readthedocs.io/en/ev3dev-stretch/motors.html#units",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "monsfortis1940",
"comment_id": 628472914,
"datetime": 1589444189000,
"masked_author": "username_0",
"text": "Hello username_1,\r\n\r\nThank you for your prompt answer. but it is not exactly what I mean.\r\nWhat I like to know for both motors ( f.i large_motor_B and large_motor_C) is\r\nthe tacho_counts/ time_unit.\r\n\r\nWith f.i. the following routine I will control the both motors\r\nlarge _motor_B.on(SpeedRPM(30))\r\nlarge_motor_C.on(SpeedRPM(30))\r\n\r\nHow can I be informed about the tacho_counts/time_unit ?\r\n\r\nI hope You can help me\r\n\r\nThank you in advance\r\nmario",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WasabiFan",
"comment_id": 628876227,
"datetime": 1589488952000,
"masked_author": "username_1",
"text": "Ah, sorry, I misunderstood. To read the current motor speed you can use the `.speed` attribute of a Motor: https://ev3dev-lang.readthedocs.io/projects/python-ev3dev/en/ev3dev-stretch/motors.html#ev3dev2.motor.Motor.speed\r\n\r\nIf you are using a pair of motors (e.g. `MoveTank`), you can use `tank_pair.right_motor.speed` (or equivalently for `left_motor`).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "monsfortis1940",
"comment_id": 629127697,
"datetime": 1589534151000,
"masked_author": "username_0",
"text": "hallo Wasabifan\r\n\r\nProblem solved. Thank you very much\r\n\r\nkind regards \r\nMario",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WasabiFan",
"comment_id": 629413409,
"datetime": 1589567512000,
"masked_author": "username_1",
"text": "Glad to hear it!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "WasabiFan",
"comment_id": null,
"datetime": 1589567513000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 2,224 | false | false | 2,224 | true |
JasperFx/lamar | JasperFx | 585,795,714 | 243 | null | [
{
"action": "opened",
"author": "kieronlanning",
"comment_id": null,
"datetime": 1584905994000,
"masked_author": "username_0",
"text": "Add support for `IAsyncDisposable` to enable disposable operations that require asynchronous execution, in the same way that `IDisposable` is currently supported.\r\n\r\nInitially, this could be an ASP.NET Core integration only due to the generic nature of the request pipeline.",
"title": "Support for `IAsyncDisposable`",
"type": "issue"
},
{
"action": "created",
"author": "jeremydmiller",
"comment_id": 730413164,
"datetime": 1605796283000,
"masked_author": "username_1",
"text": "I might try to get into this over the holidays",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kieronlanning",
"comment_id": 731055118,
"datetime": 1605864672000,
"masked_author": "username_0",
"text": "Thanks @username_1!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jeremydmiller",
"comment_id": null,
"datetime": 1637274953000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 342 | false | false | 342 | true |
tullamods/Dominos | tullamods | 254,688,607 | 284 | null | [
{
"action": "opened",
"author": "Korvus-III",
"comment_id": null,
"datetime": 1504282665000,
"masked_author": "username_0",
"text": "I an unable to change the show state of the pet bar. When i cIick away from the advanced window, and open it back up, the show state defaults back to [@pet,exists,nopossessbar]show;hide. I don't get an error message when i attempt to do so, is this by design?",
"title": "Pet Bar Show State",
"type": "issue"
},
{
"action": "created",
"author": "Tuller",
"comment_id": 326708212,
"datetime": 1504311157000,
"masked_author": "username_1",
"text": "Yes, for the most part.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Tuller",
"comment_id": null,
"datetime": 1530662746000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "TheAthenA714",
"comment_id": 414652264,
"datetime": 1534853472000,
"masked_author": "username_2",
"text": "Any chance this could change in the future? I have all my bars set up with the same show/hide conditions, it kinda sucks to have a lonely pet bar staying behind all alone.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Tuller",
"comment_id": 414769922,
"datetime": 1534875077000,
"masked_author": "username_1",
"text": "Yes, eventually",
"title": null,
"type": "comment"
}
] | 3 | 5 | 470 | false | false | 470 | false |
wangshub/hammerspoon-config | null | 432,711,089 | 7 | {
"number": 7,
"repo": "hammerspoon-config",
"user_login": "wangshub"
} | [
{
"action": "opened",
"author": "zgqq",
"comment_id": null,
"datetime": 1555097113000,
"masked_author": "username_0",
"text": "网络不好的时候，获取天气会卡死",
"title": "perf(weather): use async http to prevent blocking main thread",
"type": "issue"
},
{
"action": "created",
"author": "wangshub",
"comment_id": 482766562,
"datetime": 1555120360000,
"masked_author": "username_1",
"text": "@username_0 Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 28 | false | false | 28 | true |
pranjal0791/mslearn-tailspin-spacegame-web | null | 610,812,095 | 1 | {
"number": 1,
"repo": "mslearn-tailspin-spacegame-web",
"user_login": "pranjal0791"
} | [
{
"action": "opened",
"author": "pranjal0791",
"comment_id": null,
"datetime": 1588347221000,
"masked_author": "username_0",
"text": "Run SonarCloud less often to reduce build times for normal CI builds.",
"title": "Run SonarCloud only on pull requests to master",
"type": "issue"
}
] | 2 | 2 | 3,526 | false | true | 69 | false |
NixOS/nixpkgs | NixOS | 611,815,160 | 86,764 | null | [
{
"action": "opened",
"author": "datafoo",
"comment_id": null,
"datetime": 1588593084000,
"masked_author": "username_0",
"text": "**Describe the bug**\r\n\r\nThe following warning logs are produced in my server.\r\n\r\n```\r\n# journalctl SYSLOG_IDENTIFIER=systemd-udevd -S \"11:17:35\" -p4\r\n-- Logs begin at Fri 2020-01-31 09:26:25 UTC, end at Mon 2020-05-04 11:41:06 UTC. --\r\nMay 04 11:17:35 myhostname systemd-udevd[1025]: eth0: Process '/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth0/use_tempaddr'' failed with exit code 1.\r\nMay 04 11:17:35 myhostname systemd-udevd[1021]: eth1: Process '/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth1/use_tempaddr'' failed with exit code 1.\r\n```\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Boot a NixOS server\r\n\r\n**Expected behavior**\r\nNo warning should be logged.\r\n\r\n**Additional context**\r\nIt should be noted the interfaces of my server are named `eno1` and `eno2` and not `eth0` and `eth1` as referred to in the warning logs.\r\n\r\n**Notify maintainers**\r\n@username_1 \r\n\r\n**Metadata**\r\nPlease run `nix-shell -p nix-info --run \"nix-info -m\"` and paste the result.\r\n```\r\n - system: `\"x86_64-linux\"`\r\n - host os: `Linux 5.4.35, NixOS, 20.09pre-git (Nightingale)`\r\n - multi-user?: `yes`\r\n - sandbox: `yes`\r\n - version: `nix-env (Nix) 2.3.4`\r\n - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`\r\n```\r\n\r\nMaintainer information:\r\n```yaml\r\n# a list of nixpkgs attributes affected by the problem\r\nattribute:\r\n# a list of nixos modules affected by the problem\r\nmodule:\r\n - networking.interfaces\r\n```",
"title": "Concerning warning log related to networking.interfaces.<name?>.tempAddress",
"type": "issue"
},
{
"action": "created",
"author": "rnhmjoj",
"comment_id": 625062007,
"datetime": 1588833714000,
"masked_author": "username_1",
"text": "(exact) duplicate of #86761.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rnhmjoj",
"comment_id": null,
"datetime": 1588833717000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "datafoo",
"comment_id": 627751217,
"datetime": 1589346986000,
"masked_author": "username_0",
"text": "It may seem related but it is not a duplicate.\r\n\r\nFirst the concerning logs are warning (PRIORITY=4) which makes me less inclined to whitelist it in journalwatch.\r\n\r\nAlso, there are no interfaces named `eth0` and `eth1`. It seems [Predictable Network Interface Names](https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/) is not respected.",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "rnhmjoj",
"comment_id": null,
"datetime": 1589354306000,
"masked_author": "username_1",
"text": "**Describe the bug**\r\n\r\nThe following warning logs are produced in my server.\r\n\r\n```\r\n# journalctl SYSLOG_IDENTIFIER=systemd-udevd -S \"11:17:35\" -p4\r\n-- Logs begin at Fri 2020-01-31 09:26:25 UTC, end at Mon 2020-05-04 11:41:06 UTC. --\r\nMay 04 11:17:35 myhostname systemd-udevd[1025]: eth0: Process '/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth0/use_tempaddr'' failed with exit code 1.\r\nMay 04 11:17:35 myhostname systemd-udevd[1021]: eth1: Process '/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth1/use_tempaddr'' failed with exit code 1.\r\n```\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Boot a NixOS server\r\n\r\n**Expected behavior**\r\nNo warning should be logged.\r\n\r\n**Additional context**\r\nIt should be noted the interfaces of my server are named `eno1` and `eno2` and not `eth0` and `eth1` as referred to in the warning logs.\r\n\r\n**Notify maintainers**\r\n@username_1 \r\n\r\n**Metadata**\r\nPlease run `nix-shell -p nix-info --run \"nix-info -m\"` and paste the result.\r\n```\r\n - system: `\"x86_64-linux\"`\r\n - host os: `Linux 5.4.35, NixOS, 20.09pre-git (Nightingale)`\r\n - multi-user?: `yes`\r\n - sandbox: `yes`\r\n - version: `nix-env (Nix) 2.3.4`\r\n - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`\r\n```\r\n\r\nMaintainer information:\r\n```yaml\r\n# a list of nixpkgs attributes affected by the problem\r\nattribute:\r\n# a list of nixos modules affected by the problem\r\nmodule:\r\n - networking.interfaces\r\n```",
"title": "Concerning warning log related to networking.interfaces.<name?>.tempAddress",
"type": "issue"
},
{
"action": "created",
"author": "rnhmjoj",
"comment_id": 627806466,
"datetime": 1589355415000,
"masked_author": "username_1",
"text": "Sorry, I didn't notice the interface names.\r\nThat message is surely coming from the IPv6 privacy udev rules. To see their content:\r\n```\r\ncat /etc/udev/rules.d/*-ipv6-privacy-extensions.rules\r\n```\r\nThe interfaces are set from NixOS but are coming from the kernel. I'm not sure why you're seeing `eth0` and `eth1`. Maybe the traditional scheme is used first and later the interfaces are converted to the new scheme so the udev rules are fired twice.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "datafoo",
"comment_id": 627811900,
"datetime": 1589356027000,
"masked_author": "username_0",
"text": "The message seems indeed to come from the udev rules:\r\n```\r\n[root@myhostname:~]# journalctl --grep \"/proc/sys/net/ipv6/conf/\" -b\r\n-- Logs begin at Fri 2020-01-31 09:26:25 UTC, end at Wed 2020-05-13 07:39:28 UTC. --\r\nMay 13 06:56:49 myhostname systemd-udevd[1007]: eth1: Process '/nix/store/x7fr0bvnwvqvr3zg60di9jxvfwimcw7m-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth1/use_tempaddr'' failed with exit code 1.\r\nMay 13 06:56:49 myhostname systemd-udevd[1011]: eth0: Process '/nix/store/x7fr0bvnwvqvr3zg60di9jxvfwimcw7m-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth0/use_tempaddr'' failed with exit code 1.\r\n\r\n[root@myhostname:~]# cat /etc/udev/rules.d/98-ipv6-privacy-extensions.rules\r\n# enable and prefer IPv6 privacy addresses by default\r\nACTION==\"add\", SUBSYSTEM==\"net\", RUN+=\"/nix/store/x7fr0bvnwvqvr3zg60di9jxvfwimcw7m-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/%k/use_tempaddr'\"\r\n\r\n\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "datafoo",
"comment_id": 644060104,
"datetime": 1592218957000,
"masked_author": "username_0",
"text": "So it seems the kernel does not respect [Predictable Network Interface Names](https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/) .\r\n\r\n@username_3 @volth: you worked on the following code, do you know what is happening?\r\nhttps://github.com/NixOS/nixpkgs/blob/a448d9156b54cb5970725c5b9bc17f93667b4cac/nixos/modules/tasks/network-interfaces.nix#L1169",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "datafoo",
"comment_id": 690141857,
"datetime": 1599733867000,
"masked_author": "username_0",
"text": "The interfaces are renamed according to the logs:\r\n- `igb 0000:01:00.0 eno1: renamed from eth0`\r\n- `igb 0000:02:00.0 eno2: renamed from eth1`\r\n\r\n```log\r\n[root@myhostname:~]# journalctl SYSLOG_IDENTIFIER=kernel SYSLOG_IDENTIFIER=systemd-udevd -o short-precise -S 07:50:58.322667\r\n-- Logs begin at Tue 2020-08-25 09:27:43 UTC, end at Thu 2020-09-10 10:16:18 UTC. --\r\nSep 10 07:50:58.322667 myhostname systemd-udevd[994]: ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.\r\nSep 10 07:50:58.338094 myhostname kernel: pps pps0: new PPS source ptp0\r\nSep 10 07:50:58.338416 myhostname kernel: igb 0000:01:00.0: added PHC on eth0\r\nSep 10 07:50:58.338729 myhostname kernel: igb 0000:01:00.0: Intel(R) Gigabit Ethernet Network Connection\r\nSep 10 07:50:58.339025 myhostname kernel: igb 0000:01:00.0: eth0: (PCIe:2.5Gb/s:Width x1) ac:1f:6b:**:**:*2\r\nSep 10 07:50:58.339320 myhostname kernel: igb 0000:01:00.0: eth0: PBA No: 012700-000\r\nSep 10 07:50:58.339613 myhostname kernel: igb 0000:01:00.0: Using MSI-X interrupts. 4 rx queue(s), 4 tx queue(s)\r\nSep 10 07:50:58.385474 myhostname kernel: Adding 16777212k swap on /dev/zd0. Priority:-2 extents:1 across:16777212k SSFS\r\nSep 10 07:50:58.387057 myhostname kernel: pps pps1: new PPS source ptp1\r\nSep 10 07:50:58.387332 myhostname kernel: igb 0000:02:00.0: added PHC on eth1\r\nSep 10 07:50:58.387643 myhostname kernel: igb 0000:02:00.0: Intel(R) Gigabit Ethernet Network Connection\r\nSep 10 07:50:58.387934 myhostname kernel: igb 0000:02:00.0: eth1: (PCIe:2.5Gb/s:Width x1) ac:1f:6b:**:**:*3\r\nSep 10 07:50:58.388234 myhostname kernel: igb 0000:02:00.0: eth1: PBA No: 012700-000\r\nSep 10 07:50:58.388534 myhostname kernel: igb 0000:02:00.0: Using MSI-X interrupts. 4 rx queue(s), 4 tx queue(s)\r\nSep 10 07:50:58.431596 myhostname kernel: dw-apb-uart.2: ttyS2 at MMIO 0x9141b000 (irq = 20, base_baud = 7500000) is a 16550A\r\nSep 10 07:50:58.483008 myhostname kernel: urandom_read: 3 callbacks suppressed\r\nSep 10 07:50:58.483060 myhostname kernel: random: rngd: uninitialized urandom read (16 bytes read)\r\nSep 10 07:50:58.489276 myhostname systemd-udevd[994]: Using default interface naming scheme 'v243'.\r\nSep 10 07:50:58.491201 myhostname kernel: igb 0000:01:00.0 eno1: renamed from eth0\r\nSep 10 07:50:58.490472 myhostname systemd-udevd[994]: ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.\r\nSep 10 07:50:58.493022 myhostname kernel: iTCO_wdt: Intel TCO WatchDog Timer Driver v1.11\r\nSep 10 07:50:58.493073 myhostname kernel: iTCO_wdt: Found a Intel PCH TCO device (Version=6, TCOBASE=0x0400)\r\nSep 10 07:50:58.493107 myhostname kernel: iTCO_wdt: initialized. heartbeat=30 sec (nowayout=0)\r\nSep 10 07:50:58.498628 myhostname systemd-udevd[993]: Using default interface naming scheme 'v243'.\r\nSep 10 07:50:58.504470 myhostname kernel: input: HID 0557:2419 as /devices/pci0000:00/0000:00:14.0/usb1/1-14/1-14.1/1-14.1:1.0/0003:0557:2419.0001/input/input2\r\nSep 10 07:50:58.506662 myhostname systemd-udevd[993]: ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.\r\nSep 10 07:50:58.510008 myhostname kernel: igb 0000:02:00.0 eno2: renamed from eth1\r\nSep 10 07:50:58.518009 myhostname kernel: checking generic (90000000 300000) vs hw (90000000 1000000)\r\nSep 10 07:50:58.518098 myhostname kernel: fb0: switching to astdrmfb from EFI VGA\r\nSep 10 07:50:58.520009 myhostname kernel: Console: switching to colour dummy device 80x25\r\nSep 10 07:50:58.520056 myhostname kernel: [drm] P2A bridge disabled, using default configuration\r\nSep 10 07:50:58.520084 myhostname kernel: [drm] AST 2500 detected\r\nSep 10 07:50:58.520109 myhostname kernel: [drm] Analog VGA only\r\nSep 10 07:50:58.520310 myhostname kernel: [drm] dram MCLK=800 Mhz type=1 bus_width=16 size=01000000\r\nSep 10 07:50:58.520061 myhostname systemd-udevd[994]: eth0: Process '/nix/store/hrpvwkjz04s9i4nmli843hyw9z4pwhww-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth0/use_tempaddr'' failed with exit code 1.\r\nSep 10 07:50:58.523512 myhostname kernel: [TTM] Zone kernel: Available graphics memory: 8150938 KiB\r\nSep 10 07:50:58.523642 myhostname kernel: [TTM] Zone dma32: Available graphics memory: 2097152 KiB\r\nSep 10 07:50:58.523668 myhostname kernel: [TTM] Initializing pool allocator\r\nSep 10 07:50:58.523700 myhostname kernel: [TTM] Initializing DMA pool allocator\r\nSep 10 07:50:58.525008 myhostname kernel: random: crng init done\r\nSep 10 07:50:58.543011 myhostname kernel: intel_rapl_common: Found RAPL domain package\r\nSep 10 07:50:58.543076 myhostname kernel: intel_rapl_common: Found RAPL domain core\r\nSep 10 07:50:58.543367 myhostname kernel: intel_rapl_common: Found RAPL domain dram\r\nSep 10 07:50:58.552832 myhostname systemd-udevd[978]: Using default interface naming scheme 'v243'.\r\nSep 10 07:50:58.554517 myhostname kernel: fbcon: astdrmfb (fb0) is primary device\r\nSep 10 07:50:58.557364 myhostname kernel: hid-generic 0003:0557:2419.0001: input,hidraw0: USB HID v1.00 Keyboard [HID 0557:2419] on usb-0000:00:14.0-14.1/input0\r\nSep 10 07:50:58.563007 myhostname kernel: input: HID 0557:2419 as /devices/pci0000:00/0000:00:14.0/usb1/1-14/1-14.1/1-14.1:1.1/0003:0557:2419.0002/input/input3\r\nSep 10 07:50:58.563061 myhostname kernel: hid-generic 0003:0557:2419.0002: input,hidraw1: USB HID v1.00 Mouse [HID 0557:2419] on usb-0000:00:14.0-14.1/input1\r\nSep 10 07:50:58.572008 myhostname kernel: Console: switching to colour frame buffer device 128x48\r\nSep 10 07:50:58.581011 myhostname kernel: ast 0000:05:00.0: fb0: astdrmfb frame buffer device\r\nSep 10 07:50:58.583068 myhostname systemd-udevd[993]: eth1: Process '/nix/store/hrpvwkjz04s9i4nmli843hyw9z4pwhww-bash-4.4-p23/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth1/use_tempaddr'' failed with exit code 1.\r\nSep 10 07:50:58.596009 myhostname kernel: [drm] Initialized ast 0.1.0 20120228 for 0000:05:00.0 on minor 0\r\nSep 10 07:50:58.612009 myhostname kernel: mousedev: PS/2 mouse device common for all mice\r\nSep 10 07:50:58.977012 myhostname kernel: Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011)\r\nSep 10 07:50:58.979607 myhostname systemd-udevd[978]: ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.\r\nSep 10 07:50:59.042025 myhostname kernel: bond0: (slave eno2): Enslaving as a backup interface with a down link\r\nSep 10 07:50:59.042087 myhostname kernel: kauditd_printk_skb: 18 callbacks suppressed\r\nSep 10 07:50:59.042127 myhostname kernel: audit: type=1305 audit(1599724259.039:29): op=set audit_enabled=0 old=1 auid=4294967295 ses=4294967295 subj=kernel res=1\r\nSep 10 07:50:59.068514 myhostname kernel: bond0: (slave eno1): Enslaving as a backup interface with a down link\r\nSep 10 07:50:59.081006 myhostname kernel: NET: Registered protocol family 17\r\nSep 10 07:51:01.898011 myhostname kernel: igb 0000:02:00.0 eno2: igb: eno2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX\r\nSep 10 07:51:01.932009 myhostname kernel: igb 0000:01:00.0 eno1: igb: eno1 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX\r\nSep 10 07:51:02.016800 myhostname kernel: bond0: (slave eno2): link status definitely up, 1000 Mbps full duplex\r\nSep 10 07:51:02.016871 myhostname kernel: bond0: (slave eno2): making interface the new active one\r\nSep 10 07:51:02.016903 myhostname kernel: bond0: active interface up!\r\nSep 10 07:51:02.016940 myhostname kernel: IPv6: ADDRCONF(NETDEV_CHANGE): bond0: link becomes ready\r\nSep 10 07:51:02.121011 myhostname kernel: bond0: (slave eno1): link status definitely up, 1000 Mbps full duplex\r\n```\r\n\r\nI do not know much about udev, maybe the udev [rule](https://github.com/NixOS/nixpkgs/blob/a448d9156b54cb5970725c5b9bc17f93667b4cac/nixos/modules/tasks/network-interfaces.nix#L1169) is triggered as soon as the network interface is detected and by the time the `RUN` command is executed, the kernel has already renamed the interface.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "QuantMint",
"comment_id": 1029742254,
"datetime": 1643961954000,
"masked_author": "username_2",
"text": "The same thing is happening here on NixOS unstable: `systemd-udevd[526]: eth0: Process '/nix/store/07j81a5xy8j1srvf57dl7lxsaihnmfac-bash-5.1-p12/bin/sh -c 'echo 2 > /proc/sys/net/ipv6/conf/eth0/use_tempaddr'' failed with exit code 1.`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lheckemann",
"comment_id": null,
"datetime": 1648543187000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 12 | 13,434 | false | true | 13,307 | true |
AceCentre/morAce | AceCentre | 695,226,031 | 13 | null | [
{
"action": "opened",
"author": "willwade",
"comment_id": null,
"datetime": 1599493508000,
"masked_author": "username_0",
"text": "1. Different sounds for dot/dash\r\n\r\n- When a dot pressed: signal a noise at DOT_LENGTH e.g. 1000Khz signal at 200ms\r\n- When a dash pressed: signal a noise at DOT_LENGTH*3 e.g. 1000Khz signal 600ms\r\n\r\nI'm not sure that if in fast typing mode this will make the sound last too long. If it does we might be wise halving this sound length. \r\n\r\n2. Sounds for moving between mouse and keyboard mode\r\n\r\nBecause we removed the Neopixel colour changing to show between mouse and keyboard mode - would be useful to have some way of showing when we move from one to another. Maybe a rising tone when changing to Mouse mode - and decreasing tone to Keyboard mode.\r\n\r\n3. User config to turn off sounds \r\n\r\nI realise we could simply disconnect the pin - but we might have a pre-soldered board! A user config option to turn this on or off would be useful\r\n\r\n4. Sound for switching connection\r\n\r\nSome users wont be able to see the Neopixel. So as well as the light a simple sound (maybe a altering tone of khz 1000khz, 3000khz, 1000khz for 200ms each may just do) - to say whether connecting to another device would be really handy",
"title": "Changes to sound",
"type": "issue"
},
{
"action": "created",
"author": "willwade",
"comment_id": 759353646,
"datetime": 1610533372000,
"masked_author": "username_0",
"text": "This is difficult to solve on this project. The timing of things isn't easy...",
"title": null,
"type": "comment"
}
] | 1 | 2 | 1,193 | false | false | 1,193 | false |
actions/virtual-environments | actions | 595,283,757 | 680 | {
"number": 680,
"repo": "virtual-environments",
"user_login": "actions"
} | [
{
"action": "opened",
"author": "dsame",
"comment_id": null,
"datetime": 1586193242000,
"masked_author": "username_0",
"text": "# Description\r\nNew tool\r\nInstall MongoDB\r\n\r\n**total size:** 930MB\r\n**installation time:** less than a minute\r\n\r\n#### Related issue:\r\nhttps://github.com/actions/virtual-environments/issues/94\r\n\r\n## Check list\r\n- [x] Related issue / work item is attached\r\n- [x] Tests are written (if applicable)\r\n- [x] Documentation is updated (if applicable)\r\n- [x] Changes are tested and related VM images are successfully generated",
"title": "Install MongoDB on Windows images",
"type": "issue"
},
{
"action": "created",
"author": "maxim-lobanov",
"comment_id": 614509487,
"datetime": 1587027068000,
"masked_author": "username_1",
"text": "/azp run windows2016, windows2019",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlenaSviridenko",
"comment_id": 614634860,
"datetime": 1587041728000,
"masked_author": "username_2",
"text": "/azp run windows2016, windows2019",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlenaSviridenko",
"comment_id": 637318551,
"datetime": 1591080478000,
"masked_author": "username_2",
"text": "/azp run windows2016, windows2019",
"title": null,
"type": "comment"
}
] | 4 | 7 | 755 | false | true | 515 | false |
JetBrains/kotlin | JetBrains | 510,694,935 | 2,717 | {
"number": 2717,
"repo": "kotlin",
"user_login": "JetBrains"
} | [
{
"action": "opened",
"author": "p7nov",
"comment_id": null,
"datetime": 1571754449000,
"masked_author": "username_0",
"text": "",
"title": "docs: improved descriptions of compiler options",
"type": "issue"
},
{
"action": "created",
"author": "bashor",
"comment_id": 545496349,
"datetime": 1571844049000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bashor",
"comment_id": 545496569,
"datetime": 1571844076000,
"masked_author": "username_1",
"text": "@username_2 as far as I understand you are going to merge it manualy",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "udalov",
"comment_id": 546442873,
"datetime": 1572024741000,
"masked_author": "username_2",
"text": "Merged manually in https://github.com/JetBrains/kotlin/commit/c6f54b6412e385ab3b96c7f69d06aa5e346ad43a with subsequent fixes https://github.com/JetBrains/kotlin/commit/f248e4a2eee2585e555259a5adeafd3b6409b491, https://github.com/JetBrains/kotlin/commit/e7fe144f5cacacc0f2077af190ee35ad71410c6a",
"title": null,
"type": "comment"
}
] | 3 | 4 | 361 | false | false | 361 | true |
platformio/platformio-vscode-ide | platformio | 530,536,051 | 1,408 | null | [
{
"action": "opened",
"author": "Motorbreath69",
"comment_id": null,
"datetime": 1575092353000,
"masked_author": "username_0",
"text": "%23 Description of problem\r\n Leave a comment...\r\n\r\n BEFORE SUBMITTING, PLEASE SEARCH FOR DUPLICATES IN\r\n - https://github.com/platformio/platformio-vscode-ide/issues\r\n\r\n %23 Configuration\r\n\r\n VSCode: 1.40.2\r\n PIO IDE: v1.10.0\r\n System: Darwin, 17.7.0, x64\r\n\r\n %23 Exception\r\n ```\r\n Error: PIP Core: /usr/bin/python: No module named pip\r\n\r\n\tat /Users/steve/.vscode/extensions/platformio.platformio-ide-1.10.0/node_modules/platformio-node-helpers/dist/index.js:1:35084\r\n\tat ChildProcess.d (/Users/steve/.vscode/extensions/platformio.platformio-ide-1.10.0/node_modules/platformio-node-helpers/dist/index.js:1:8215)\r\n\tat ChildProcess.emit (events.js:200:13)\r\n\tat maybeClose (internal/child_process.js:1021:16)\r\n\tat Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)\r\n ```",
"title": "Installation Manager",
"type": "issue"
},
{
"action": "created",
"author": "ivankravets",
"comment_id": 585825929,
"datetime": 1581608920000,
"masked_author": "username_1",
"text": "Please provide an output from system Terminal `cmd`\r\n```\r\necho %PATH%\r\npython --version\r\npip --version\r\npip list\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivankravets",
"comment_id": 593130965,
"datetime": 1583088660000,
"masked_author": "username_1",
"text": "Could you try this solution https://github.com/platformio/platformio-vscode-ide/issues/1570#issuecomment-593128668? Does it work for you?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivankravets",
"comment_id": 638124131,
"datetime": 1591182326000,
"masked_author": "username_1",
"text": "Hi,\r\n\r\nThanks for the report! We rewrote PlatformIO Core installer from the scratch. Please **download and install** the latest [PlatformIO IDE for VSCode 2.0 Beta](https://community.platformio.org/t/platformio-ide-for-vscode-2-0-beta/14097) as described in **Try Beta** section on that page. \r\n\r\nPlease respond to this thread if it helped you or you still have an issue. We will reopen this issue again. \r\n\r\nRegards,\r\nYour friends at PlatformIO",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ivankravets",
"comment_id": null,
"datetime": 1591182326000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 1,496 | false | false | 1,496 | false |
ManixVasan/github-slideshow | null | 409,599,277 | 3 | null | [
{
"action": "opened",
"author": "ManixVasan",
"comment_id": null,
"datetime": 1550026079000,
"masked_author": "username_0",
"text": "Column1| Column2\r\n--------|----------\r\nContent1|Content2\r\nContent3|Content4\r\nContent5|Content6",
"title": "Manix Test 2",
"type": "issue"
},
{
"action": "closed",
"author": "ManixVasan",
"comment_id": null,
"datetime": 1550115705000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 94 | false | true | 94 | false |
cloudfoundry-community/splunk-firehose-nozzle | cloudfoundry-community | 657,055,160 | 255 | {
"number": 255,
"repo": "splunk-firehose-nozzle",
"user_login": "cloudfoundry-community"
} | [
{
"action": "opened",
"author": "luckyj5",
"comment_id": null,
"datetime": 1594788110000,
"masked_author": "username_0",
"text": "upate app-info config param in the tile",
"title": "upate app-info config param in the tile",
"type": "issue"
},
{
"action": "created",
"author": "rockb1017",
"comment_id": 658542225,
"datetime": 1594788220000,
"masked_author": "username_1",
"text": "LGTM!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 44 | false | false | 44 | false |
jamesagnew/hapi-fhir | null | 562,992,211 | 1,708 | {
"number": 1708,
"repo": "hapi-fhir",
"user_login": "jamesagnew"
} | [
{
"action": "opened",
"author": "JLLeitschuh",
"comment_id": null,
"datetime": 1581400304000,
"masked_author": "username_0",
"text": "If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.\n\n## Tracking\n\nAll PR's generated as part of this fix are tracked here: \nhttps://github.com/username_0/bulk-security-pr-generator/issues/2",
"title": "[SECURITY] Use HTTPS to resolve dependencies in Maven Build",
"type": "issue"
},
{
"action": "created",
"author": "jamesagnew",
"comment_id": 671076855,
"datetime": 1596992833000,
"masked_author": "username_1",
"text": "Thanks @username_0 - This has been merged!",
"title": null,
"type": "comment"
}
] | 3 | 3 | 655 | false | true | 306 | true |
xcatliu/jekyllcn | null | 679,509,722 | 164 | null | [
{
"action": "opened",
"author": "zrzjohn",
"comment_id": null,
"datetime": 1597471971000,
"masked_author": "username_0",
"text": "为什么我访问网站的时候，显示的是这个样子？网站关闭了？\r\n",
"title": "网站关闭了？",
"type": "issue"
},
{
"action": "created",
"author": "xcatliu",
"comment_id": 674619939,
"datetime": 1597630303000,
"masked_author": "username_1",
"text": "没有关闭，由于部署在 github pages 上，有可能需要翻墙",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "xcatliu",
"comment_id": null,
"datetime": 1597630303000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zrzjohn",
"comment_id": 674620106,
"datetime": 1597630353000,
"masked_author": "username_0",
"text": "为什么我显示的是 AppServ 的自述页面？",
"title": null,
"type": "comment"
}
] | 2 | 4 | 564 | false | false | 564 | false |
rlworkgroup/garage | rlworkgroup | 523,961,973 | 1,030 | {
"number": 1030,
"repo": "garage",
"user_login": "rlworkgroup"
} | [
{
"action": "opened",
"author": "utkarshjp7",
"comment_id": null,
"datetime": 1573984327000,
"masked_author": "username_0",
"text": "This PR removes `optimizer_args` pattern from torch algorithm constructors. All torch algorithms now accept a constructed optimizer instead of an optimizer class.",
"title": "Remove optimizer_args from torch algos",
"type": "issue"
},
{
"action": "created",
"author": "krzentner",
"comment_id": 555287763,
"datetime": 1574126576000,
"masked_author": "username_1",
"text": "Ryan and I discussed this for some time. We eventually came to the following argument:\r\n - In most of garage, we expose the important arguments in easy-to-reach places (e.g. `hidden_layers` arguments to policies).\r\n - We should also do that in algorithms for consistency, and because we feel this way of providing ease-of-use is best for garage's users.\r\n - For most users, the most important parameter is the learning rate. In particular, the learning rate is a more important parameter than the algorithm itself.\r\n - Therefore the learning rate parameters (e.g. `lr`, `max_kl`, `policy_lr`, etc.) should be exposed to the users as arguments to the algorithm, so that it can be specified without specifying the optimizer itself.\r\n - There should still be a way of passing a custom optimizer for algorithms where doing so makes sense (i.e. gradient methods that aren't TRPO).\r\n\r\nAfter thinking about what that specifically looks like, we think that the following design would be best:\r\n - For algorithms where the optimizer cannot reasonably be changed from the default (TRPO), all hyper-parameters of the optimizer should be exposed as arguments on the algorithm. It should not be possible to specify the optimizer as an argument. In other words, we should remove the `optimizer` argument from TRPO, and keep / add the `max_kl` argument.\r\n - For algorithms where it is reasonable to set the optimizer to most torch optimizers, there should be an `optimizer` argument which specifies the type of the optimizer. There should also be a parameter to set that optimizer's important hyperparameters (e.g. `lr`, `policy_lr`, `q_lr`, etc.).\r\n - For algorithms where the optimizer can be specified, it should also be possible to pass a tuple of (optimizer type, optimizer hyper parameters) as the `optimizer`. If a tuple is passed, the second parameter must be a dictionary, and the other arguments specifying hyper-parameters for that algorithm (e.g. `policy_lr`) should not be passed. If any of them are passed, the algorithm should raise `ValueError`.\r\n\r\nBy the way, this probably also involves writing a utility function, which we think should probably be in something like this:\r\n```python\r\n# In src/garage/torch/algos/trpo.py:\r\n\r\nclass TRPO:\r\n def __init__(self, ..., max_kl=0.2):\r\n ...\r\n ...\r\n\r\n# In src/garage/torch/algos/_utils.py\r\n\r\nclass _Default:\r\n pass\r\n\r\ndef _make_optimizer(optimizer_type, module, **kwargs):\r\n if isinstance(optimizer_type, tuple):\r\n opt_type, opt_args = optimizer_type\r\n for name, arg in kwargs.items():\r\n if not isinstance(arg, Default):\r\n raise ValueError('Should not specify {} and explicit optimizer args'.format(name))\r\n return opt_type(module.parameters(), **opt_args)\r\n else:\r\n return policy_optimizer(module.parameters(), **kwargs)\r\n\r\n# In src/garage/torch/algos/__init__.py\r\nfrom garage.torch.algos._utils import _Default, _make_optimizer\r\nfrom garage.torch.algos.ddpg import DDPG\r\n...\r\n__all__ = ... # Should not include _Default, etc.\r\n\r\n# In src/garage/torch/algos/ddpg.py\r\nfrom garage.torch.algos import _Default, _make_optimizer\r\n\r\nclass DDPG:\r\n def __init__(self, policy_optimizer=torch.optim.Adam, policy_lr=_Default(1e-3), ...):\r\n ...\r\n self.policy_opt = _make_optimizer(policy_optimizer, self.policy, lr=policy_lr)\r\n ...\r\n ...\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ryanjulian",
"comment_id": 555674442,
"datetime": 1574192216000,
"masked_author": "username_2",
"text": "@username_0 when you do this, can you also file an issue to make this consistent in the TF and NP trees?",
"title": null,
"type": "comment"
}
] | 4 | 4 | 3,649 | false | true | 3,649 | true |
fastai/fastpages | fastai | 572,790,885 | 141 | null | [
{
"action": "created",
"author": "nikhilrayaprolu",
"comment_id": 592537447,
"datetime": 1582900178000,
"masked_author": "username_0",
"text": "It's a good feature, I have seen in terms of blogging.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hamelsmu",
"comment_id": null,
"datetime": 1582907112000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "KwangYeol",
"comment_id": 594274064,
"datetime": 1583286518000,
"masked_author": "username_2",
"text": "I got an error like below. \n\n```\nThe tag twitter on line 86 in _posts/2020-01-14-test-markdown-post.md is not a recognized Liquid tag.\n```\n\n`jekyll-twitter-plugin` works fine with \n\n```\nbundle exec jekyll serve --trace\n```\nor \n```\nmake server\n```\n\nI didn't edit the `md` file. How can I fix this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hamelsmu",
"comment_id": 594305551,
"datetime": 1583292308000,
"masked_author": "username_1",
"text": "@username_2 Please open an issue on GitHub and ensure you are using the latest version of fastpages. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rednafi",
"comment_id": 598104253,
"datetime": 1584007488000,
"masked_author": "username_3",
"text": "The comment section works flawlessly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lyldev",
"comment_id": 613895406,
"datetime": 1586939140000,
"masked_author": "username_4",
"text": "Nice!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abdulwahidgul24085",
"comment_id": 631483481,
"datetime": 1589982353000,
"masked_author": "username_5",
"text": "Can't get the blog section to work for me. Rest of the application is awesome.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rednafi",
"comment_id": 631571683,
"datetime": 1589990799000,
"masked_author": "username_3",
"text": "You've to add utterances manually to your repo. Install it from here https://utteranc.es/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abdulwahidgul24085",
"comment_id": 631573324,
"datetime": 1589990970000,
"masked_author": "username_5",
"text": "My problem was repo-name was commented out in config file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DebalB",
"comment_id": 632646233,
"datetime": 1590147258000,
"masked_author": "username_6",
"text": "Link for tutorial mentioned above seems to be broken:\n\"This tutorial contains more examples of what you can do with notebooks.\"\nhttps://fastpages.fast.ai/fastpages/jupyter/2020/02/20/test.html",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "micimize",
"comment_id": 686867751,
"datetime": 1599187562000,
"masked_author": "username_7",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hamelsmu",
"comment_id": 686896329,
"datetime": 1599193471000,
"masked_author": "username_1",
"text": "Thanks, @username_7 ! I fixed those typos. Appreciate it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gardnmi",
"comment_id": 712444363,
"datetime": 1603141851000,
"masked_author": "username_8",
"text": "Just wanted to show some appreciation. Amazing work! This would have saved me a lot of work a couple years back when I attempted a to merge Flask and Jupyter together for my blog. \n\nhttps://username_8.github.io/blog/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CongLiu-CN",
"comment_id": 748577050,
"datetime": 1608451969000,
"masked_author": "username_9",
"text": "My Machine Learning blog built using Fastpages:\n\nhttps://www.ai4love.xyz/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MrSteve2",
"comment_id": 770401061,
"datetime": 1612107458000,
"masked_author": "username_10",
"text": "Thank you, this is very useful.\nIs this available for GitLab?\nIf not is it simply a matter of converting the GitHub Actions to GitLab CI?\nWould like to use this to document models for in a ModelCards or Factsheets format.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MrSteve2",
"comment_id": 770401604,
"datetime": 1612107683000,
"masked_author": "username_10",
"text": "Okay quick check shoes you’re using [utterances](https://utteranc.es/) which is GitHub specific. Any other GitHub dependencies?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Munikumarnm",
"comment_id": 786818859,
"datetime": 1614364204000,
"masked_author": "username_11",
"text": "Hi,\nThanks for creating fastpages, it seems very helpful.\nHave created the blog. But couldn't able to upload the Jupyter notebooks. Need videos shows on how to upload the Jupyter notebook & converting them as blog post. I'm stuck here.\n\nThanks\nMunikumar",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yangruflo",
"comment_id": 822483004,
"datetime": 1618840281000,
"masked_author": "username_12",
"text": "One of the critical factors in turning visitors into customers is the speed of your website. Pages that are super slow to load will prompt the web page reader to move on to another site. Thus, conversion rates may drop by an estimated 25 percent when this happens. On that point, you can rely on fastpages. - stuartkerrs ( [federal way fence](https://www.federalwayfence.com/) )",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mdl-ai",
"comment_id": 855189394,
"datetime": 1622872530000,
"masked_author": "username_13",
"text": "Wow very cool",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Kimeiga",
"comment_id": 862124398,
"datetime": 1623828664000,
"masked_author": "username_14",
"text": "Is there a way to remove the \"jupyter/\" part from the URL if we wanted jupyter to be the default way to make pages?\nreference this URL: https://fastpages.fast.ai/fastpages/jupyter/2020/02/21/introducing-fastpages.html",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "butterswords",
"comment_id": 1013973095,
"datetime": 1642374818000,
"masked_author": "username_15",
"text": "Is there a way to merge this with the [FastTemplate](https://github.com/fastai/fast_template/generate) repository? I used the directions in the book and then saw this had come out and am not seeing an easy way to incorporate it.",
"title": null,
"type": "comment"
}
] | 17 | 22 | 2,982 | false | true | 2,702 | true |
bors-ng/bors-ng | bors-ng | 670,364,451 | 994 | null | [
{
"action": "opened",
"author": "matklad",
"comment_id": null,
"datetime": 1596240775000,
"masked_author": "username_0",
"text": "I've moved username_0/ungrammar over to rust-analyzer ungrammar, and that seems to confuse bors:\r\n\r\n* it doesn't see comments on the new repo:\r\n\r\n\r\n\r\n* but it sees PR on the old repo (PR was created after move):\r\n\r\n\r\n\r\nPR in question: https://github.com/rust-analyzer/ungrammar/pull/1",
"title": "Bors misses commands if repository is moved",
"type": "issue"
},
{
"action": "created",
"author": "itchymax",
"comment_id": 963934934,
"datetime": 1636447708000,
"masked_author": "username_1",
"text": "We have the same issue. Any solution to this?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 545 | false | false | 545 | true |
jhipster/generator-jhipster | jhipster | 499,742,439 | 10,509 | {
"number": 10509,
"repo": "generator-jhipster",
"user_login": "jhipster"
} | [
{
"action": "opened",
"author": "antonioortizpola",
"comment_id": null,
"datetime": 1569658616000,
"masked_author": "username_0",
"text": "No issue created for the simplicity of the commit.\r\n\r\nWorking with the JHipster blueprint I found some missing translations and some typos for the Spanish language.\r\n\r\n- Please make sure the below checklist is followed for Pull Requests.\r\n\r\n- [ X ] [Travis tests](https://travis-ci.org/jhipster/generator-jhipster/pull_requests) are green\r\n- [ X ] Tests are added where necessary\r\n- [ X ] Documentation is added/updated where necessary\r\n- [ X ] Coding Rules & Commit Guidelines as per our [CONTRIBUTING.md document](https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md) are followed\r\n\r\n<!--\r\nPlease also reference the issue number in a commit message to [automatically close the related Github issue](https://help.github.com/articles/closing-issues-via-commit-messages/)\r\n\r\nNote: It is also possible to add `[skip ci]` to your commit message to skip Travis tests\r\n-->",
"title": "corrections for spanish translation",
"type": "issue"
},
{
"action": "created",
"author": "MathieuAA",
"comment_id": 536166634,
"datetime": 1569659949000,
"masked_author": "username_1",
"text": "Congrats for your first contribution! And thanks for improving the generator :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antonioortizpola",
"comment_id": 536212294,
"datetime": 1569694199000,
"masked_author": "username_0",
"text": "Thanks a lot, it is actually the [second one](https://github.com/jhipster/generator-jhipster/pull/8389), but very simple issues, I hope I can contribute more in the future!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MathieuAA",
"comment_id": 536213281,
"datetime": 1569694995000,
"masked_author": "username_1",
"text": "Ah ah! Glad I'm wrong! Thanks again :)",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,188 | false | false | 1,188 | false |
newtonproject/NEPs | newtonproject | 635,262,440 | 20 | {
"number": 20,
"repo": "NEPs",
"user_login": "newtonproject"
} | [
{
"action": "opened",
"author": "benkoo",
"comment_id": null,
"datetime": 1591694380000,
"masked_author": "username_0",
"text": "<!---\r\n Change the title: 'Submit new NEP / Update a NEP-<replace number>'\r\n *Only make a request when a NEP is ready.\r\n *You should check `Allow edits from maintainers` option.\r\n To finalize a NEP, open an issue instead.\r\n-->\r\n\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n\r\n- [x] I have read the **NEP Guideline** document.\r\n- [x] I have checked my NEP Draft is ready.\r\n\r\n## Changes <!--- Required when updating an existing NEP Draft -->\r\n\r\n<!--- Describe your changes in detail -->\r\nAdded a number of Newton Encoded Asset Transaction definitions.",
"title": "Submit NEAT series NEPs",
"type": "issue"
},
{
"action": "created",
"author": "arisac",
"comment_id": 641767673,
"datetime": 1591771837000,
"masked_author": "username_1",
"text": "@username_0 following changes are required before we can move your NEPs to the Board Review stage:\r\n\r\n### NEP numbers\r\n- NEAT - #20\r\n- NPA - #21\r\n- NCA - #22\r\n- NBC - #23\r\n- NPC - #24\r\n\r\n### NEP File Naming\r\n\r\n**`N` is to be replaced by the NEP Number**\r\n\r\nNEP file name: /NEPS/nep-`N`.md\r\n\r\nAssets directory: /assets/nep-`N`/asset-name.extension\r\n\r\n### NEP Repo Contents\r\n\r\n- Please `remove any file not used in NEP doc file` from the repo.\r\n- For PDF files for reference purpose, `it is recommended to use URL to link that file` from it's origin since we don't actually own those files.\r\n- Please use #20 #21 #22 #23 #24 for individual NEP `Discussion Link`.\r\n\r\n### For Assitance\r\n\r\nIf you need NEP Editors to assist on the formatting works above, please add the NEP Editors as collaborators to your repo\r\n\r\n- Link to your repo access settings - https://github.com/toyhouse/NEPs/settings/access\r\n- NEP Editors Usernames - @username_1 @liuyong5653 @weixuefeng @zhouxiqiao [ref](https://github.com/newtonproject/NEPs/wiki/NEP-Review-Process#nep-editors)",
"title": null,
"type": "comment"
}
] | 3 | 9 | 3,291 | false | true | 1,660 | true |
python/typeshed | python | 625,627,284 | 4,105 | {
"number": 4105,
"repo": "typeshed",
"user_login": "python"
} | [
{
"action": "opened",
"author": "ilevkivskyi",
"comment_id": null,
"datetime": 1590580216000,
"masked_author": "username_0",
"text": "",
"title": "Fix concurrent.futures import for re-export",
"type": "issue"
},
{
"action": "created",
"author": "srittau",
"comment_id": 634621931,
"datetime": 1590581964000,
"masked_author": "username_1",
"text": "Stubtest fails because of `stdlib/3/concurrent/futures/_base.pyi:Executor.map`. First argument is called 'fn', not 'func'. It's whitelisted in `tests/stubtest_whitelists/py3_common.txt`, but I guess due to the re-export, it's now flagged. Cc @hauntsaninja",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ilevkivskyi",
"comment_id": 634627512,
"datetime": 1590582613000,
"masked_author": "username_0",
"text": "I updated the whitelist (just to unblock mypy release).",
"title": null,
"type": "comment"
}
] | 2 | 3 | 310 | false | false | 310 | false |
seatgeek/aws-dynamic-consul-catalog | seatgeek | 388,596,092 | 4 | {
"number": 4,
"repo": "aws-dynamic-consul-catalog",
"user_login": "seatgeek"
} | [
{
"action": "opened",
"author": "lorenzo",
"comment_id": null,
"datetime": 1544178841000,
"masked_author": "username_0",
"text": "under the same consul service name",
"title": "Allow multiple replicas and multiple masters to be registered",
"type": "issue"
},
{
"action": "created",
"author": "jippi",
"comment_id": 445244024,
"datetime": 1544191904000,
"masked_author": "username_1",
"text": "lgtm",
"title": null,
"type": "comment"
}
] | 2 | 2 | 38 | false | false | 38 | false |
input-output-hk/cardano-ledger | input-output-hk | 447,700,565 | 518 | {
"number": 518,
"repo": "cardano-ledger",
"user_login": "input-output-hk"
} | [
{
"action": "opened",
"author": "ruhatch",
"comment_id": null,
"datetime": 1558622143000,
"masked_author": "username_0",
"text": "Closes #336",
"title": "[#336] Select which tests to run via command line arguments",
"type": "issue"
},
{
"action": "created",
"author": "dnadales",
"comment_id": 495248627,
"datetime": 1558622530000,
"masked_author": "username_1",
"text": "NIce :tada: \r\n\r\nShould we add instructions in the README showing how to select the tests to run?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ruhatch",
"comment_id": 495533533,
"datetime": 1558688795000,
"masked_author": "username_0",
"text": "bors r+",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mhuesch",
"comment_id": 496562736,
"datetime": 1559056753000,
"masked_author": "username_2",
"text": "Looks like I didn't finish my review before the weekend...\r\n\r\n@username_0 Thanks for doing this, it'll make my test workflow much smoother. Also, I like what you did with `TSGroup` and `concatTSGroups`.",
"title": null,
"type": "comment"
}
] | 4 | 5 | 510 | false | true | 313 | true |
openshift/origin | openshift | 368,837,988 | 21,212 | {
"number": 21212,
"repo": "origin",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "wongma7",
"comment_id": null,
"datetime": 1539203132000,
"masked_author": "username_0",
"text": "… to false\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1634158",
"title": "3.10: UPSTREAM: 58646: Change the portworx volume attribute SupportsSELinux…",
"type": "issue"
},
{
"action": "created",
"author": "jsafrane",
"comment_id": 428845212,
"datetime": 1539241698000,
"masked_author": "username_1",
"text": "/lgtm\r\n/retes",
"title": null,
"type": "comment"
}
] | 4 | 15 | 9,802 | false | true | 78 | false |
open-mmlab/mmdetection | open-mmlab | 473,913,410 | 1,076 | null | [
{
"action": "opened",
"author": "qq237942920",
"comment_id": null,
"datetime": 1564388220000,
"masked_author": "username_0",
"text": "Why use caffe's models sometimes(especially in Anchor Free model) or pytorch's models sometimes? How should we select them correctly to get better result?",
"title": "Why use caffe's models sometimes or pytorch's models sometimes?",
"type": "issue"
},
{
"action": "created",
"author": "hellock",
"comment_id": 515894623,
"datetime": 1564388479000,
"masked_author": "username_1",
"text": "We adopt pytorch-style models by default and provide config files and checkpoints for popular methods. Meanwhile, there are some methods that use caffe-style methods in the original implementation, thus we provide caffe-style models for reference.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "qq237942920",
"comment_id": 515910426,
"datetime": 1564391216000,
"masked_author": "username_0",
"text": "Thanks for your reply! Did you compare their performance? Because I've heard some arguments about caffe-style method which can get better result in some specific task.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hellock",
"comment_id": 515964470,
"datetime": 1564402089000,
"masked_author": "username_1",
"text": "You can refer to the model zoo.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "qq237942920",
"comment_id": 516225390,
"datetime": 1564450979000,
"masked_author": "username_0",
"text": "Thx bro!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "qq237942920",
"comment_id": null,
"datetime": 1564450979000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 607 | false | false | 607 | false |
mirage/ocaml-base64 | mirage | 410,824,595 | 27 | null | [
{
"action": "opened",
"author": "adrien-n",
"comment_id": null,
"datetime": 1550245191000,
"masked_author": "username_0",
"text": "From README.md:\r\n\r\n utop # let plain = B64.decode_exn enc;;",
"title": "README.md still refers to the \"B64\" module",
"type": "issue"
},
{
"action": "closed",
"author": "dinosaure",
"comment_id": null,
"datetime": 1550407254000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 62 | false | false | 62 | false |
microsoft/vscode | microsoft | 539,084,478 | 87,178 | {
"number": 87178,
"repo": "vscode",
"user_login": "microsoft"
} | [
{
"action": "opened",
"author": "sandy081",
"comment_id": null,
"datetime": 1576591287000,
"masked_author": "username_0",
"text": "This PR fixes #87074",
"title": "Fix problems panel layout",
"type": "issue"
},
{
"action": "created",
"author": "isidorn",
"comment_id": 566566776,
"datetime": 1576593239000,
"masked_author": "username_1",
"text": "As commented in the issue I have verified this fixes the issue and the code changes make sense.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 115 | false | false | 115 | false |
qaprosoft/stf | qaprosoft | 511,340,181 | 85 | null | [
{
"action": "opened",
"author": "Alexandr611",
"comment_id": null,
"datetime": 1571838851000,
"masked_author": "username_0",
"text": "**Investigate the possibility of enhancement of the swap action in ios-device.**\r\n\r\n1. Try to implement the save swap as it has been implemented for the android device (During the move action change window location but not at the end of move action after mouseDown event).",
"title": "Investigate the possibility of enhancement of the swap action in ios-device.",
"type": "issue"
},
{
"action": "closed",
"author": "Alexandr611",
"comment_id": null,
"datetime": 1574686138000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Alexandr611",
"comment_id": 558140714,
"datetime": 1574686138000,
"masked_author": "username_0",
"text": "The enhancement of the swap action for ios-device isn't possible without updating WDA API.",
"title": null,
"type": "comment"
}
] | 1 | 3 | 362 | false | false | 362 | false |
OpenSourceEconomics/grmpy | OpenSourceEconomics | 606,291,650 | 177 | null | [
{
"action": "opened",
"author": "SeBecker",
"comment_id": null,
"datetime": 1587732836000,
"masked_author": "username_0",
"text": "It would make sense to compare our results for the semiparametric estimation approach (particularly the mte results) with the ones obtained from competing R packages. For this purpose I would suggest the following procedure:\r\n\r\n1. Simulate (lets say 100) data sets with our simulation routine (and save the associated init files in a json file)\r\n\r\n2. Write an R script that computes the MTE for each of this simulated samples and save the results in a json file\r\n\r\n3. Include a regression test in our current test frame work in which we estimate the mte with grmpy and compare the resulting mte with the one obtained from our R script",
"title": "Regression vault using the competing packages in R",
"type": "issue"
},
{
"action": "created",
"author": "SeBecker",
"comment_id": 618991290,
"datetime": 1587732902000,
"masked_author": "username_0",
"text": "@segsell : Do you know of any appropriate R packages for estimating the semiparametric MTE?",
"title": null,
"type": "comment"
}
] | 1 | 2 | 725 | false | false | 725 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.