repo
stringlengths
7
67
org
stringlengths
2
32
โŒ€
issue_id
int64
780k
941M
issue_number
int64
1
134k
pull_request
dict
events
list
user_count
int64
1
77
event_count
int64
1
192
text_size
int64
0
329k
bot_issue
bool
1 class
modified_by_bot
bool
2 classes
text_size_no_bots
int64
0
279k
modified_usernames
bool
2 classes
cypress-io/cypress
cypress-io
787,711,938
14,605
null
[ { "action": "opened", "author": "nehalbadelhafez", "comment_id": null, "datetime": 1610891990000, "masked_author": "username_0", "text": "Current behavior\r\nAfter increasing timeout of fixture to upload large video, suddenly the page turn white with this message. Also, this happens a lot not only with fixture.\r\nversion\r\n6.2.1\r\n\r\n![Screenshot from 2021-01-14 16-08-45](https://user-images.githubusercontent.com/65114493/104845252-03d15800-58dd-11eb-8d91-023b38f80a75.png)", "title": "Something went wrong while displaying the webpage", "type": "issue" }, { "action": "created", "author": "nehalbadelhafez", "comment_id": 762877283, "datetime": 1611066677000, "masked_author": "username_0", "text": "any help?", "title": null, "type": "comment" }, { "action": "created", "author": "jennifer-shehane", "comment_id": 763397876, "datetime": 1611127701000, "masked_author": "username_1", "text": "Can you provide a reproducible example? Here are some tips for providing a [Short, Self Contained, Correct, Example](http://sscce.org/) and our own [Troubleshooting Cypress](https://on.cypress.io/troubleshooting) guide.", "title": null, "type": "comment" }, { "action": "created", "author": "nehalbadelhafez", "comment_id": 763487632, "datetime": 1611136884000, "masked_author": "username_0", "text": "here is a reproducible example. Also, i change default command timeout to 600000 which is equivalent to 10 minutes\r\nit(\"Add three plugins within one job\", function () {\r\n // login \r\n cy.login(url, email, password);\r\n \r\n // create 3 media\r\n for (var iterator= 0; iterator < pluginNames.length; iterator++) {\r\n var mediaName1 = \"media \" + iterator;\r\n cy.createMedia(mediaName1, inputMediaNames[iterator]);\r\n cy.reload();\r\n }\r\n //create job\r\n cy.createJob(jobName);\r\n //add plugins and media within the job\r\n for (var iterator= 0; iterator < pluginNames.length; iterator++) {\r\n cy.addPlugin(pluginNames[iterator]);\r\n cy.reload();\r\n cy.addMedia(mediaName + iterator, pluginNames[iterator]);\r\n \r\n }\r\n cy.startJob(jobName);\r\n cy.connectWithWebSocket(jobName, status);\r\n cy.log(\"Run three plugins within one job finishes successfully\");\r\n});\r\nthe function declaration is at the commands js file this example is for the websocket connection \r\nCypress.Commands.add(\"connectWithWebSocket\", function (jobName, status) {\r\n var options = {\r\n takeWhileFn: (payload) => {\r\n if (payload) {\r\n if (payload.type) return true;\r\n if (payload.message) {\r\n if (payload.message.data) {\r\n let data = JSON.parse(payload.message.data);\r\n if (data && data.name === jobName) {\r\n if (data.status) {\r\n if (data.status.type === status) {\r\n return false;\r\n } else if (data.status.type == \"stopped\") {\r\n return false;\r\n }\r\n }\r\n return true;\r\n }\r\n }\r\n }\r\n }\r\n return false;\r\n },\r\n startUpMessage: {\r\n command: \"subscribe\",\r\n identifier: '{\"channel\":\"JobsChannel\"}',\r\n },\r\n };\r\n cy.streamRequest(config, options).then((results) => {\r\n const result = results && results[results.length - 1];\r\n console.log(result);\r\n var data = JSON.parse(result.message.data);\r\n if (data.status.type == status) {\r\n cy.log(expect(data.status).to.have.property(\"type\", status));\r\n } else if (data.status.type == \"stopped\") {\r\n cy.log(\" job has stopped !\");\r\n } else {\r\n cy.log(\"something went wrong\");\r\n }\r\n });\r\n});", "title": null, "type": "comment" }, { "action": "closed", "author": "jennifer-shehane", "comment_id": null, "datetime": 1614435480000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "jennifer-shehane", "comment_id": 787079678, "datetime": 1614435480000, "masked_author": "username_1", "text": "Right now there doesn't seem to be enough information to reproduce the problem on our end - we cannot run the first step, which is the login. We'll have to close this issue until we can reproduce it. This does not mean that your issue is not happening - it just means that we do not have a path to move forward. \r\n\r\nPlease comment in this issue with a reproducible example and we will consider reopening the issue. Here are some tips for providing a [Short, Self Contained, Correct, Example](http://sscce.org/) and our own [Troubleshooting Cypress](https://on.cypress.io/troubleshooting) guide.", "title": null, "type": "comment" } ]
2
6
3,416
false
false
3,416
false
matthewbdaly/laravel-azure-storage
null
747,570,516
30
null
[ { "action": "opened", "author": "kanidjar", "comment_id": null, "datetime": 1605885422000, "masked_author": "username_0", "text": "Hi,\r\n\r\nWe are using Lumen with your library and your commit [628fe40b2154ea0b5545590d3fd92b88e5e830c9](https://github.com/username_1/laravel-azure-storage/commit/628fe40b2154ea0b5545590d3fd92b88e5e830c9) broke our application.\r\n\r\nCould you please use Illuminate\\Contracts\\Container instead of Illuminate\\Contracts\\Foundation\\Application which is not available in Lumen.", "title": "Use Illuminate\\Contracts\\Container instead of Illuminate\\Contracts\\Foundation\\Application", "type": "issue" }, { "action": "created", "author": "matthewbdaly", "comment_id": 731272615, "datetime": 1605890089000, "masked_author": "username_1", "text": "I've pushed a commit that *should* fix this, but Travis CI is being a bit rubbish right now and not running the test suite.\r\n\r\nCan you confirm this fixes the issue for you?", "title": null, "type": "comment" }, { "action": "created", "author": "kanidjar", "comment_id": 731304609, "datetime": 1605893741000, "masked_author": "username_0", "text": "Confirmed, issue fixed.\r\n\r\nThank you ๐Ÿ‘", "title": null, "type": "comment" }, { "action": "closed", "author": "matthewbdaly", "comment_id": null, "datetime": 1605894351000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "matthewbdaly", "comment_id": 731309356, "datetime": 1605894351000, "masked_author": "username_1", "text": "Excellent. Will therefore close this off.", "title": null, "type": "comment" } ]
2
5
622
false
false
622
true
nicolasgomollon/AppSales-Mobile
null
608,350,218
53
null
[ { "action": "opened", "author": "tntechnology", "comment_id": null, "datetime": 1588083047000, "masked_author": "username_0", "text": "The program crashes when I exporting the reports. All reports are visible in the document folder, but \"open in\" does not appear. Is there a problem with the compression as ZIP?\r\nI use Xcode 11.4.1 with iPhone 11 and the current version of AppSales 2.4.5 (711).\r\n\r\nThe following error message appears in the console after the crash:\r\nTerminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread.'\r\n\r\nWhat could be the reason?\r\nThanks for your help!", "title": "app crash by \"export reports\"", "type": "issue" }, { "action": "created", "author": "nicolasgomollon", "comment_id": 623206787, "datetime": 1588550883000, "masked_author": "username_1", "text": "I just merged in #48, so this should now be fixed. Please let me know if this is fixed in the latest commit.", "title": null, "type": "comment" }, { "action": "closed", "author": "nicolasgomollon", "comment_id": null, "datetime": 1588550888000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
711
false
false
711
false
AY2021S1-CS2103T-T11-4/tp
AY2021S1-CS2103T-T11-4
738,491,973
337
{ "number": 337, "repo": "tp", "user_login": "AY2021S1-CS2103T-T11-4" }
[ { "action": "opened", "author": "wenhaogoh", "comment_id": null, "datetime": 1604849876000, "masked_author": "username_0", "text": "", "title": "Add history package tests", "type": "issue" } ]
2
2
0
false
true
0
false
beretta627/my-site-build-tools-3
null
700,675,745
53
{ "number": 53, "repo": "my-site-build-tools-3", "user_login": "beretta627" }
[ { "action": "opened", "author": "beretta627", "comment_id": null, "datetime": 1600041952000, "masked_author": "username_0", "text": "", "title": "Update Composer dependencies (2020-09-14-00-05)", "type": "issue" }, { "action": "created", "author": "beretta627", "comment_id": 691747245, "datetime": 1600042490000, "masked_author": "username_0", "text": "Visual regression test failed! [![Visual report](https://circleci.com/gh/username_0/my-site-build-tools-3/533/artifacts/0/artifacts/./backstop_data/bitmaps_test/20200913-161443/failed_diff_test_Homepage_0_document_2_desktop.png)](https://circleci.com/gh/username_0/my-site-build-tools-3/533/artifacts/0/artifacts/backstop_data/html_report/index.html)", "title": null, "type": "comment" } ]
1
2
350
false
false
350
true
constellation-app/constellation
constellation-app
563,649,928
245
null
[ { "action": "opened", "author": "aldebaran30701", "comment_id": null, "datetime": 1581468109000, "masked_author": "username_0", "text": "The postToNifi method I think we can change it to support SHA256 based on https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.11.1/org.apache.nifi.processors.standard.HashContent/.\r\n\r\nA global project search may need to be done to ensure other usages of HashContent.md5() are not hiding somewhere. \r\n\r\nTesting to ensure no behavioural changes are made and any subsequent methods which read from the hashed values still function as intended.\r\n\r\n### Steps to Reproduce\r\n\r\nN/A\r\n\r\n**Expected behaviour:** \r\n\r\n**Actual behaviour:** \r\n\r\n**Reproduces how often:** \r\n\r\n### Additional Information\r\n\r\nAlthough this change is a deprecation, it is useful to implement since the md5 is not cryptographically secure.", "title": "Update MD5 usages with Cryptographically secure SHA256", "type": "issue" }, { "action": "created", "author": "cygnus-x-1", "comment_id": 600057493, "datetime": 1584450052000, "masked_author": "username_1", "text": "Do we care about the use of MD5 hashes for file comparisons in ```ConstellationLoggerHelper.createMD5Hash``` and ```WebServer.getDigest```?", "title": null, "type": "comment" }, { "action": "created", "author": "arcturus2", "comment_id": 600062009, "datetime": 1584450610000, "masked_author": "username_2", "text": "In the `ConstellationLoggerHelper` I need some sort of hashing algorithm, doesn't have to be MD5 if that's what the issue is. I don't have an opinion on the `WebServer.getDigest`.", "title": null, "type": "comment" }, { "action": "created", "author": "cygnus-x-1", "comment_id": 600076537, "datetime": 1584452339000, "masked_author": "username_1", "text": "```WebServer.getDigest``` seems to be doing essentially the same thing as ```ConstellationLoggerHelper.createMD5Hash``` - I want to know if we're happy with continuing to use MD5 hashes for file comparisons as it is _probably_ fine in terms of collisions and almost certainly faster.", "title": null, "type": "comment" }, { "action": "created", "author": "arcturus2", "comment_id": 600082356, "datetime": 1584453021000, "masked_author": "username_2", "text": "Thinking about it further, I'd vote to replace it with SHA256 so that we are more future proof and don't have to worry about when it is removed from the JDK.\r\n\r\nAgreed in terms of speed it will be better to stay with MD5. For my use case I don't call `createMD5Hash` often so I can take the performance hit.", "title": null, "type": "comment" }, { "action": "created", "author": "cygnus-x-1", "comment_id": 600091416, "datetime": 1584454088000, "masked_author": "username_1", "text": "Okay, will do.", "title": null, "type": "comment" }, { "action": "closed", "author": "arcturus2", "comment_id": null, "datetime": 1585041618000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
7
1,658
false
false
1,658
false
dazuma/toys-test
null
694,102,503
19
null
[ { "action": "closed", "author": "dazuma", "comment_id": null, "datetime": 1599318363000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
2
252
false
true
0
false
project-chip/connectedhomeip
project-chip
679,470,020
2,187
null
[ { "action": "opened", "author": "mspang", "comment_id": null, "datetime": 1597453328000, "masked_author": "username_0", "text": "As of https://github.com/openthread/openthread/pull/5299 thread joiner initiated at boot results in unresponsive device. It takes several join attempts for this to occur.\r\n\r\nRepro (fails):\r\n```\r\n git checkout b15c292ee56a0505d3a3904eb295b38bac71cfc9\r\n git submodule update --init\r\n\r\n cd third_party/openthread/repo\r\n git checkout addb1936c3e7e14e59f617751e595596980e3ec8 # fails\r\n cd examples/lock-app/nrf5\r\n make flash\r\n \r\n # thread CLI\r\n factoryreset\r\n```\r\n\r\n Boot and just wait. Device hangs after a few join attempts.\r\n\r\nRepro: (stable)\r\n```\r\n cd third_party/openthread/repo\r\n git revert HEAD\r\n\r\n cd examples/lock-app/nrf5\r\n make flash\r\n```\r\n Boot and just wait. Device stable.\r\n\r\nLog:\r\n```\r\n[00000000] <info> chip: [DL] Setup PIN discriminator not found; using default: f00\r\n[00000000] <info> chip: [DL] Joiner Discerner: 3840\r\n[00000000] <info> chip: [DL] Setup PIN code not found; using default: 12345678\r\n[00000000] <info> chip: [DL] Joiner PSKd: 12345678\r\n[00000000] <info> chip: [DL] Joiner start: No Error\r\n[00000000] <debug> chip: [DL] Thread joiner timer triggered: No Error\r\n<hung>\r\n```\r\n\r\n@lanyuwen @bukepo", "title": "nrf5 examples stop responding while attempting thread join", "type": "issue" }, { "action": "created", "author": "mspang", "comment_id": 674326956, "datetime": 1597453872000, "masked_author": "username_0", "text": "Fault stack:\r\n\r\nLevel,Function,Stack Frame,Source,PC,Return Address,Stack Used\r\n0,<HardFault Exception>,32 @ 0x2001FAE8,,0x00000A60,[0x2001FB00]: 0x0008FFC2,160\r\n0,memcpy, 8 @ 0x2001FB08,,0x0008FFBE,[0x2001FB0C]: 0x0002CC32,128\r\n0,xQueueReceive,48 @ 0x2001FB10,queue.c:1288:5,0x0002CC2E,[0x2001FB3C]: 0x0002DE38,120\r\n0,prvProcessReceivedCommands, 0 @ 0x2001FB40,timers.c:696:7,0x0002DE34,<inline>: 0x0002DE98, 72\r\n0,prvTimerTask,72 @ 0x2001FB40,timers.c:644:2,0x0002DE24,[0x2001FB84]: 0x03000000, 72\r\n0,Top of stack - return address out of range: 0x3000000,,,,,", "title": null, "type": "comment" }, { "action": "created", "author": "mspang", "comment_id": 674454774, "datetime": 1597531735000, "masked_author": "username_0", "text": "This is a timer task stack overflow. The timer task uses 1k stack by default. Enabling configCHECK_FOR_STACK_OVERFLOW diagnoses this issue.", "title": null, "type": "comment" }, { "action": "created", "author": "mspang", "comment_id": 674459683, "datetime": 1597536142000, "masked_author": "username_0", "text": "@bukepo I believe we should move all of the code from `GenericThreadStackManagerImpl_FreeRTOS<ImplClass>::OnJoinerTimer` off the timer task. Logging uses a 256 byte stack buffer.\r\n\r\nIn the meantime I will post a patch to increase the stack size.", "title": null, "type": "comment" }, { "action": "closed", "author": "BroderickCarlin", "comment_id": null, "datetime": 1597886676000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
6
2,462
false
true
2,081
false
funkydan2/hugo-kiera
null
774,470,960
60
null
[ { "action": "opened", "author": "TeldridgeLDN", "comment_id": null, "datetime": 1608820470000, "masked_author": "username_0", "text": "Hi there\r\n\r\nI'm would like the links on my site to be clearly identified as hyperlinks.\r\n\r\nWhat would help massively is to have styling to highlight hyperlinks as being underlined.\r\n\r\nI've tried to get around this by using the following: \r\n\r\nHere's a summary of the [**services I offer.**](/about/what-i-do/)\r\n\r\nIt bolds the text, but not sufficiently enough to distinguish it", "title": "Can't identify Hyperlinks - not underlined", "type": "issue" }, { "action": "closed", "author": "funkydan2", "comment_id": null, "datetime": 1608858260000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
376
false
false
376
false
ppy/osu
ppy
681,134,378
9,906
{ "number": 9906, "repo": "osu", "user_login": "ppy" }
[ { "action": "opened", "author": "lanpai", "comment_id": null, "datetime": 1597764577000, "masked_author": "username_0", "text": "Resolves https://github.com/ppy/osu/issues/9888", "title": "Disable LegacyHitExplosion for hold notes", "type": "issue" }, { "action": "created", "author": "bdach", "comment_id": 676292175, "datetime": 1597841052000, "masked_author": "username_1", "text": "@username_0 Please pay attention to CI status going forward; your changes had a code style issue with spacing. We've fixed that for you in f6ca316, but it's easier for everyone involved if you keep track.", "title": null, "type": "comment" }, { "action": "created", "author": "peppy", "comment_id": 676294971, "datetime": 1597841171000, "masked_author": "username_2", "text": "@username_3 can you double-check this is correct? not 100% sure on it.", "title": null, "type": "comment" }, { "action": "created", "author": "smoogipoo", "comment_id": 676295659, "datetime": 1597841199000, "masked_author": "username_3", "text": "It seems fine. Stable doesn't have ticks.", "title": null, "type": "comment" } ]
4
4
357
false
false
357
true
MapperTV/roadstuff
null
766,821,774
24
null
[ { "action": "opened", "author": "Terpo", "comment_id": null, "datetime": 1607972086000, "masked_author": "username_0", "text": "I've got a small suggestion for the latest build of Road Stuff and Mapper Base: 1.16.4-4.2.0\r\n\r\nThe bitumen of Mapper Base and Immersive Petroleum are both tagged with forge:bitumen.\r\nThe recipes for Road Stuff and Mapper Base are using mapperbase:raw_bitumen instead of the forge tag. Could you change the recipes from using the item to the forge:bitumen tag?\r\n\r\nWith this the integration to other mods would be much easier.", "title": "[1.16.4] Bitumen tag in recipes", "type": "issue" }, { "action": "created", "author": "MapperTV", "comment_id": 745487076, "datetime": 1608057798000, "masked_author": "username_1", "text": "That's something I forgot to do when i added the tag. Will add it later in the meanwhile it is possible to add the tag through a datapack.", "title": null, "type": "comment" }, { "action": "closed", "author": "MapperTV", "comment_id": null, "datetime": 1623368265000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
563
false
false
563
false
austinpray/kaori
null
646,725,627
130
null
[ { "action": "opened", "author": "austinpray", "comment_id": null, "datetime": 1593280654000, "masked_author": "username_0", "text": "**Is your feature request related to a problem? Please describe.** \r\n\r\nRight now Kaori treats her home channel (direct message) as a regular channel\r\n\r\n![image](https://user-images.githubusercontent.com/2192970/85928684-8082e300-b874-11ea-8556-724997e21db9.png)\r\n\r\n![image](https://user-images.githubusercontent.com/2192970/85928790-53830000-b875-11ea-8fc5-4977f09fed2e.png)\r\n\r\nYou have to mention her like in a regular channel to get her to respond\r\n\r\n![image](https://user-images.githubusercontent.com/2192970/85928811-7f9e8100-b875-11ea-8c50-e66e31726f9f.png)\r\n\r\n**Describe the solution you'd like** \r\n\r\nKaori should consider direct message as a direct mention\r\n\r\n![image](https://user-images.githubusercontent.com/2192970/85928819-9349e780-b875-11ea-95a6-edade7b9349e.png)\r\n\r\nThis is how hubot and some other bot frameworks work by default. This is what I expect as a user as well.\r\n\r\n**Describe alternatives you've considered** \r\nA clear and concise description of any alternative solutions or features you've considered.\r\n\r\n**Additional context** \r\nAdd any other context or screenshots about the feature request here.\r\n\r\nCould sorta address #121. People who are annoyed by this could just create their card in a DM", "title": "Kaori should treat direct messages in her home channel like an @ message in a regular channel", "type": "issue" } ]
2
2
1,601
false
true
1,224
false
lokesh-coder/pretty-checkbox
null
582,905,617
81
null
[ { "action": "opened", "author": "mikeldn", "comment_id": null, "datetime": 1584440506000, "masked_author": "username_0", "text": "Hi, \r\n\r\nWould it be possible/make sense to allow the binding of labels to inputs for accessibility ... I'm not sure, given the fact that the input is actually hidden if that would be the wrong approach or not?\r\n\r\nAnyway, if it's possible, then something like:\r\n<label for=\"cheese\">Do you like cheese?</label>\r\n<input type=\"checkbox\" name=\"cheese\" id=\"cheese\">\r\n\r\nas per: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label\r\n\r\nMy suggestion is, that if you add an id tag your markup, it should get carried through into the <label for=\"\"> attribute?\r\n\r\nOn that page, they also talk about implicit association between label & input, like this: \r\n<label>Do you like peas?\r\n <input type=\"checkbox\" name=\"peas\">\r\n</label>\r\n\r\nAny thoughts, suggestions or upgrades would be appreciated! \r\n\r\nThanks!", "title": "Accessibility and Labeling", "type": "issue" } ]
1
1
803
false
false
803
false
input-output-hk/cardano-wallet
input-output-hk
509,019,484
868
{ "number": 868, "repo": "cardano-wallet", "user_login": "input-output-hk" }
[ { "action": "opened", "author": "KtorZ", "comment_id": null, "datetime": 1571397802000, "masked_author": "username_0", "text": "# Issue Number\r\n\r\n<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->\r\n\r\n#713 \r\n\r\n# Overview\r\n\r\n<!-- Detail in a few bullet points the work accomplished in this PR -->\r\n\r\n- [x] I have added a StakeDistribution table\r\n- [x] I have added two operations for reading and putting stake distributions to DB\r\n- [x] I have added two basic properties for the operations above.\r\n\r\n# Comments\r\n\r\n<!-- Additional comments or screenshots to attach if any -->\r\n\r\n```\r\n Sqlite\r\n Stake Pool properties\r\n readStakeDistribution . putStakeDistribution == pure\r\n +++ OK, passed 100 tests (4% Empty distributions).\r\n readStake . putStake a1 . putStake s0 == pure a1\r\n +++ OK, passed 100 tests:\r\n 6% b is empty\r\n 4% a is empty\r\n 3% a & b are empty\r\n```\r\n\r\n<!-- \r\nDon't forget to:\r\n\r\n โœ“ Self-review your changes to make sure nothing unexpected slipped through\r\n โœ“ Assign yourself to the PR\r\n โœ“ Assign one or several reviewer(s)\r\n โœ“ Once created, link this PR to its corresponding ticket\r\n โœ“ Acknowledge any changes required to the Wiki\r\n-->", "title": "store 'StakeDistribution' in the database, implement put & read ops ", "type": "issue" }, { "action": "created", "author": "KtorZ", "comment_id": 543736326, "datetime": 1571404206000, "masked_author": "username_0", "text": "bors r+", "title": null, "type": "comment" }, { "action": "created", "author": "KtorZ", "comment_id": 543765254, "datetime": 1571407855000, "masked_author": "username_0", "text": "bors r+", "title": null, "type": "comment" }, { "action": "created", "author": "KtorZ", "comment_id": 543777451, "datetime": 1571409566000, "masked_author": "username_0", "text": "bors r+", "title": null, "type": "comment" } ]
2
8
1,581
false
true
1,134
false
YevhenKap/couchdb_dart
null
780,560,680
18
null
[ { "action": "opened", "author": "pxlphoto", "comment_id": null, "datetime": 1609940504000, "masked_author": "username_0", "text": "I tried in several ways but no https support seems to be available.\r\nI could allow it in the AndroidManifest but this is unsafe (as password would travel clearly).\r\nPlease, think about adding https support.\r\nThanks in advance", "title": "No HTTPS support", "type": "issue" }, { "action": "closed", "author": "pxlphoto", "comment_id": null, "datetime": 1609942148000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "pxlphoto", "comment_id": 755319893, "datetime": 1609942219000, "masked_author": "username_0", "text": "My fault, I've found the \"Scheme\" parameter in CouchDBClient addresses this non-problem.\r\nSorry", "title": null, "type": "comment" } ]
1
3
320
false
false
320
false
AY2021S1-CS2103T-T17-3/tp
AY2021S1-CS2103T-T17-3
733,313,117
177
null
[ { "action": "closed", "author": "vanGoghhh", "comment_id": null, "datetime": 1604295318000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "vanGoghhh", "comment_id": 720246776, "datetime": 1604295318000, "masked_author": "username_0", "text": "Fixed by #223", "title": null, "type": "comment" } ]
2
3
442
false
true
13
false
PowerShell/PowerShell
PowerShell
549,126,619
11,571
null
[ { "action": "opened", "author": "ritchxu", "comment_id": null, "datetime": 1578942804000, "masked_author": "username_0", "text": "In our particular case, we have a custom shell around `ConsoleShell` that upon start up loads `Microsoft.WindowsAzure.Storage.dll` into the current app domain. Once the shell is up, we couldn't import for example `Az.Accounts` module because it depends on a different version of `Microsoft.WindowsAzure.Storage.dll`. Since this is a more general problem with PowerShell Core, I posted the issue here instead of over at Azure PowerShell. Effectively, I'm looking for a workaround for issue https://github.com/PowerShell/PowerShell/issues/2083.\r\n\r\n## Attempt 1: custom assembly resolve\r\n```\r\nusing Microsoft.PowerShell;\r\nusing System;\r\nusing System.Diagnostics;\r\nusing System.Reflection;\r\n\r\nnamespace Test\r\n{\r\n class Program\r\n {\r\n static void Main(string[] args)\r\n {\r\n AppDomain.CurrentDomain.AssemblyResolve += OnAssemblyResolve;\r\n\r\n ConsoleShell.Start(\"Hello\", \"\", new string[0] { });\r\n }\r\n\r\n private static Assembly OnAssemblyResolve(object sender, ResolveEventArgs args)\r\n {\r\n Debugger.Launch();\r\n return null;\r\n }\r\n }\r\n}\r\n```\r\n```\r\n<Project Sdk=\"Microsoft.NET.Sdk\">\r\n\r\n <PropertyGroup>\r\n <OutputType>Exe</OutputType>\r\n <TargetFramework>netcoreapp3.1</TargetFramework>\r\n </PropertyGroup>\r\n\r\n <ItemGroup>\r\n <PackageReference Include=\"Microsoft.PowerShell.SDK\" Version=\"7.0.0-rc.1\" />\r\n </ItemGroup>\r\n\r\n <ItemGroup>\r\n <Reference Include=\"Microsoft.PowerShell.ConsoleHost\">\r\n <HintPath>$(NuGetPackageRoot)\\microsoft.powershell.consolehost\\7.0.0-rc.1\\runtimes\\win\\lib\\netcoreapp3.1\\Microsoft.PowerShell.ConsoleHost.dll</HintPath>\r\n </Reference>\r\n </ItemGroup>\r\n\r\n</Project>\r\n```\r\n## Problem:\r\nWhen run two import (`Import-Module C:\\version1\\assembly.dll; Import-Module C:\\version2\\assembly.dll`) with different versions of the assembly, I hit error of `Import-Module: Assembly with same name is already loaded` but the `AssemblyResolve` event was not raised. \r\n\r\n## Attempt 2: binding redirect through config file\r\n```\r\n<assemblyBinding xmlns=\"urn:schemas-microsoft-com:asm.v1\">\r\n <dependentAssembly>\r\n <assemblyIdentity name=\"Microsoft.WindowsAzure.Storage\" publicKeyToken=\"31bf3856ad364e35\" culture=\"neutral\" />\r\n <bindingRedirect oldVersion=\"0.0.0.0-9.3.3.0\" newVersion=\"9.3.3.0\" />\r\n </dependentAssembly>\r\n</assemblyBinding>\r\n```\r\n## Problem:\r\nRun into the same error above\r\n\r\n## Attempt 3: run any external commands with `Invoke-Command -Session`, this basically out-sourced the command on a different domain.\r\n## Problem:\r\nThis seems to be the only workaround I can come up with, but it's really inconvenient to jump back and forth PS sessions.\r\n\r\n## Question:\r\nAny better workaround?", "title": "Workarounds in loading assembly with different versions", "type": "issue" }, { "action": "created", "author": "iSazonov", "comment_id": 574139617, "datetime": 1579002903000, "masked_author": "username_1", "text": "/cc @username_4 for information.", "title": null, "type": "comment" }, { "action": "created", "author": "SeeminglyScience", "comment_id": 574173439, "datetime": 1579008503000, "masked_author": "username_2", "text": "PowerShellEditorServices had some similar issues, @username_3 recently worked around that with `AssemblyLoadContext`'s.\r\n\r\n[Here's the load context class](https://github.com/PowerShell/PowerShellEditorServices/blob/81ba0c0b8efb7ee879f2ede511390ba73b0bc86e/src/PowerShellEditorServices.Hosting/Internal/PsesLoadContext.cs).\r\n\r\nAnd [here's where he sets it up for use](https://github.com/PowerShell/PowerShellEditorServices/blob/81ba0c0b8efb7ee879f2ede511390ba73b0bc86e/src/PowerShellEditorServices.Hosting/EditorServicesLoader.cs#L79-L109).", "title": null, "type": "comment" }, { "action": "created", "author": "rjmholt", "comment_id": 574384979, "datetime": 1579037735000, "masked_author": "username_3", "text": "Yeah, if you control the assembly load of your dependency, you can load it into a new assembly load context. In PSES we accomplish this as follows:\r\n\r\n- Compile the top level module against only the APIs we want to share with the default ALC (this means the dependencies won't be exposed to PowerShell, only the API of your own module)\r\n- Deploy the module with the dependency DLLs in a separate directory so that PowerShell won't find and load them itself\r\n- Define a new custom ALC in a new class with logic to look for requested assemblies in this isolated dependency directory\r\n- Add to the default ALC a new assembly resolve event handler for the top level DLL that we want to load into the default ALC (but with its dependencies in the custom ALC). This will load the top level assembly through the custom ALC into the default ALC (so it's loaded in both), but in such a way that its dependencies are only loaded into the custom ALC.\r\n\r\nThis assembly resolve setup means you don't need to use reflection anywhere, you just redirect loading through a new ALC at runtime. But it requires some layers:\r\n\r\n- PowerShell (owns the default ALC)\r\n- Assembly loaded immediately as part of module into the default ALC, where you set up custom ALC and resolve events. This is effectively a facade that does just enough to set up the ALCs and load your real API\r\n- The top level API DLL to be loaded through the custom ALC into the default ALC\r\n- Your dependencies, to be loaded into the custom ALC only\r\n\r\nWe've discussed getting this into PowerShell itself for modules, but it's quite complex and not planned currently, so unlikely to happen within the next 12 months at least.", "title": null, "type": "comment" }, { "action": "created", "author": "rjmholt", "comment_id": 574388170, "datetime": 1579038223000, "masked_author": "username_3", "text": "I should say that if you're rehosting PowerShell, you can condense the layers I describe above; you'll just have:\r\n\r\n- Hosted PowerShell with the custom ALC\r\n- The wrapping API to load into the default ALC (it can't clash with the Az modules' API)\r\n- The clashing dependency to load into the custom ALC", "title": null, "type": "comment" }, { "action": "created", "author": "ritchxu", "comment_id": 574407697, "datetime": 1579041568000, "masked_author": "username_0", "text": "1. Why do we need the top level assembly **loaded in both default ALC and the custom ALC**?\r\n2. Once our own module is loaded, if we intend to import Az modules and use it, it's going to be loaded to the default ALC. If so, how to avoid the assembly resolve event handler from kicking in? Do we simply `return null` to let the default ALC to resolve?\r\n3. Dummy question: the following doesn't seem to work for dynamically-loaded dependencies, why would I need a subclass of `AssemblyLoadContext`?\r\n```\r\n$customContext = [System.Runtime.Loader.AssemblyLoadContext]::new(\"Test\")\r\n$onAssemblyResolve = {\r\n param($sender, $asmName)\r\n Write-Host \"Resolving '$($asmName.Name)'\"\r\n return $customContext.LoadFromAssemblyPath(\"$PSScriptRoot\\bin\\$($asmName.Name).dll\")\r\n}\r\n[System.Runtime.Loader.AssemblyLoadContext]::Default.add_Resolving($onAssemblyResolve)\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "daxian-dbw", "comment_id": 574408088, "datetime": 1579041649000, "masked_author": "username_4", "text": "I want to point out that it won't work well to load PowerShell into a custom ALC. PowerShell depends on `Assembly.LoadFrom` heavily especially in module loading, but `Assembly.LoadFrom` will load an assembly to the default ALC, so it will result in conflicts.", "title": null, "type": "comment" }, { "action": "created", "author": "SeeminglyScience", "comment_id": 574410150, "datetime": 1579042042000, "masked_author": "username_2", "text": "That's a scoping issue. By the time your resolving handler is invoked, `$customContext` is no longer a variable. You'd have to do something like `[System.Runtime.Loader.AssemblyLoadContext]::Default.add_Resolving($onAssemblyResolve.GetNewClosure())` but really you're better off doing it from C#.", "title": null, "type": "comment" }, { "action": "created", "author": "rjmholt", "comment_id": 574413202, "datetime": 1579042642000, "masked_author": "username_3", "text": "PowerShell has its own assembly resolve event that fires before yours. When you load the Az module, that loads its immediate assembly. That assembly then needs its dependencies, which aren't found in $PSHOME (.NET's app root here), so PowerShell's resolve event handler gets called, which looks in the directory where that first assembly is loaded.\r\n\r\nSo for example:\r\n\r\n- `OurModule\\`\r\n - `OurModule.psd1`\r\n - `OurModule.dll`\r\n - `isolatedDeps\\`\r\n - `FacadeApi.dll`\r\n - `SharedDep.dll`\r\n- `AzModule\\`\r\n - `AzModule.psd1`\r\n - `AzModule.dll`\r\n - `SharedDep.dll`\r\n\r\nWhen you load `OurModule`, you load `OurModule.dll` which creates the custom ALC and adds a resolve event that checks if `FacadeApi` is the requested assembly and if so looks in `isolatedDeps` to load `FacadeApi.dll` in the custom ALC and take the result of that and return it in the resolve event handler for the default ALC. The custom ALC just looks for anything its asked for in `isolatedDeps` and that's how it finds the `SharedDep.dll` in the `isolatedDeps` directory. The `OurModule` is loaded, PowerShell fires its resolve handler, looks in `OurModule\\` and finds nothing, so we go to your resolve event, which only looks for the `FacadeApi.dll`.\r\n\r\nWhen you load `AzModule`, whether before or after, PowerShell loads the module which directly loads `AzModule.dll`. That assembly depends on another particular version of `SharedDep.dll` (or could be the same one, doesn't matter). That's not loaded into the default ALC at any time, so always fires the resolve event, which PowerShell handles, looks for `SharedDep.dll` in `AzModule\\`, finds it, and successfully loads.\r\n\r\nSo the two never clash. But it depends on the `FacadeApi.dll` existing and being unique to your module.\r\n\r\nThe other way to do it is to load your `SharedDep.dll` ahead of time in the custom ALC, but then you're forced to use reflection to call into its APIs.", "title": null, "type": "comment" }, { "action": "created", "author": "ritchxu", "comment_id": 575348909, "datetime": 1579209137000, "masked_author": "username_0", "text": "@username_3 I think I'm getting closer with your extremely useful explanation above.\r\n\r\nUsing the PSES as an example, if I understood correctly from the code, here is what happens:\r\n1. We create the custom ALC\r\n2. We load top-level module `Microsoft.PowerShell.EditorServices` using the custom ALC\r\n3. We rely on the custom ALC to load dependencies (by the logic in custom ALC's overwritten `Load` method).\r\n\r\nIf I understood correctly, when I applies the same logic in my code, the overwritten `Load` was not invoked, **any clue how that could happen?**\r\n\r\nAlternatively, I played with following approach instead:\r\n```\r\ntestContext = new AssemblyLoadContext(\"Test\");\r\nbinDirectory = @\"C:\\Test\\bin\";\r\nAssemblyLoadContext.Default.Resolving += (AssemblyLoadContext defaultLoadContext, AssemblyName asmName) =>\r\n{\r\n Console.WriteLine($\"Resolving {asmName.Name}.dll\");\r\n return testContext.LoadFromAssemblyPath(Path.Combine(binDirectory, $\"{asmName.Name}.dll\"));\r\n};\r\n```\r\n\r\nThis seems to be working, and here is what I assumed happening:\r\n1. My own top-level module and its dependencies are loaded in `testContext`\r\n2. When later importing `Az` module, PS will resolve all its dependencies to default ALC and no conflict occurred", "title": null, "type": "comment" }, { "action": "created", "author": "ritchxu", "comment_id": 575795048, "datetime": 1579295175000, "masked_author": "username_0", "text": "The problem with the approach above is, (at least what seems to be), if I import `Az` module first and say it loads a dependency `dep.1.dll` which my module has a different version of, say `dep.2.dll`. When `dep.2.dll` was later loaded, it seems it's loading `dep.1.dll` instead of going through my custom ALC's `Load` method, hence jeopardize the separation. Why wouldn't the custom ALC's `Load` method not invoked in this case?", "title": null, "type": "comment" }, { "action": "created", "author": "rjmholt", "comment_id": 575816344, "datetime": 1579299321000, "masked_author": "username_3", "text": "So the important details are:\r\n\r\n- If you load an assembly into the default context (even if you loaded it via a custom ALC), it will now be the result of trying to load assemblies of the same name into the default ALC\r\n- The key to our custom ALC logic is that we hook a resolve event to only respond to a specific name and version of an assembly, fire up a custom ALC around it and then load it into the default context. So that assembly we check for in the resolve event is the bridge between the two ALCs. What I've been calling the facade assembly/API. In your snippet, you're trying to load **all** assemblies firing a resolve event through the custom ALC into the default ALC, which defeats the purpose of the custom ALC. You need two layers; one to resolve the bridging assembly and one to load the conflicting dependencies in isolation, so they never get pulled into the default ALC.\r\n\r\nFor example:\r\n\r\n```csharp\r\ns_customLoadContext = new MyLoadContext(s_isolatedBinDir)\r\nAssemblyLoadContext.Default.Resolving += (AssemblyLoadContext defaultLoadContext, AssemblyName asmName) =>\r\n{\r\n Console.WriteLine($\"Resolving {asmName.Name}.dll\");\r\n if (asmName.Name != s_facadeAsmName\r\n || asmName.Version != s_facadeAsmVersion)\r\n {\r\n return null;\r\n }\r\n\r\n // Possibly s_customLoadContext.LoadFromAssemblyName(asmName) would work here too\r\n // and deduplicate knowledge of the bin dir path\r\n return s_customLoadContext.LoadFromAssemblyPath(Path.Combine(s_isolatedBinDir, $\"{s_facadeAsmName}.dll\"));\r\n};\r\n\r\ninternal class MyLoadContext : AssemblyLoadContext\r\n{\r\n private readonly string _dependencyDirPath;\r\n\r\n public MyLoadContext(string binDirPath)\r\n {\r\n _dependencyDirPath = binDirPath;\r\n } \r\n\r\n string asmPath = Path.Join(_dependencyDirPath, $\"{assemblyName.Name}.dll\");\r\n\r\n if (File.Exists(asmPath))\r\n {\r\n return LoadFromAssemblyPath(asmPath);\r\n }\r\n\r\n return null;\r\n}\r\n```\r\n\r\nAlso, I'm not entirely sure why your custom ALC's load isn't being called, but the way I approached it was to log things everywhere to trace the logic", "title": null, "type": "comment" }, { "action": "created", "author": "rjmholt", "comment_id": 575816989, "datetime": 1579299455000, "masked_author": "username_3", "text": "One thought here: if an assembly is loaded into a context and you try to load another assembly of the same name into that context, it won't try to load the new one and there won't be any resolve event either. So it may be that you've already loaded the assembly you want into the default ALC, meaning no resolve event, meaning no load call on the custom ALC.", "title": null, "type": "comment" } ]
6
15
12,859
false
true
12,731
true
FZJ-INM1-BDA/siibra-explorer
FZJ-INM1-BDA
731,269,918
698
null
[ { "action": "opened", "author": "xgui3783", "comment_id": null, "datetime": 1603877532000, "masked_author": "username_0", "text": "as of 213cd1a7da58af6d6e8aae5d484d58dfb88b4c46\r\n\r\n1/ cannot be lazy loaded\r\n\r\nto reproduce:\r\n\r\n- go to /, select human multi level atlas, load mni152\r\n- select hoc1\r\n- click `connectivity` expansion panel **once**\r\n\r\nexpected beahviour: opens panel\r\n\r\nactual behaviour: panel opens, but connectivity component has no content\r\n\r\n2/ when input changes, does not update color map\r\n\r\nto reproduce:\r\n\r\n- go to /, select human multilevel, load mni152\r\n- select hoc1\r\n- click `connectivity` until the panel is expanded (twice)\r\n- go to region finder field, clear text and search and select hoc3\r\n\r\nexpected behaviour: color map applied\r\nactual behaviour: color map not applied", "title": "[bug] connectivity browser cannot be lazy loaded / does not update on input changes", "type": "issue" }, { "action": "closed", "author": "fsdavid", "comment_id": null, "datetime": 1629654025000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "fsdavid", "comment_id": 903304349, "datetime": 1629654025000, "masked_author": "username_1", "text": "Not relevant", "title": null, "type": "comment" } ]
2
3
681
false
false
681
false
atlassian/yarn-deduplicate
atlassian
636,875,799
69
{ "number": 69, "repo": "yarn-deduplicate", "user_login": "atlassian" }
[ { "action": "opened", "author": "bluelovers", "comment_id": null, "datetime": 1591868674000, "masked_author": "username_0", "text": "", "title": "Update .npmignore", "type": "issue" }, { "action": "created", "author": "scinos", "comment_id": 655633391, "datetime": 1594226811000, "masked_author": "username_1", "text": "Thanks for the fix!", "title": null, "type": "comment" } ]
3
3
539
false
true
19
false
agence-webup/laravel-sendinblue
agence-webup
492,169,288
17
{ "number": 17, "repo": "laravel-sendinblue", "user_login": "agence-webup" }
[ { "action": "opened", "author": "marcbelletre", "comment_id": null, "datetime": 1568200068000, "masked_author": "username_0", "text": "", "title": "Add support for Laravel 6.0", "type": "issue" }, { "action": "created", "author": "Biptaste", "comment_id": 530365927, "datetime": 1568206318000, "masked_author": "username_1", "text": "Nice, thank you", "title": null, "type": "comment" } ]
2
2
15
false
false
15
false
commaai/openpilot
commaai
714,189,087
2,262
null
[ { "action": "opened", "author": "adeebshihadeh", "comment_id": null, "datetime": 1601764621000, "masked_author": "username_0", "text": "Controls should wait for a message from each process and all the carState signals to be updated before starting up. If this also delayed setting the safety mode, it would fix #1623.", "title": "Delay controls start until system is ready", "type": "issue" }, { "action": "created", "author": "LoganxDev", "comment_id": 718338194, "datetime": 1603942503000, "masked_author": "username_1", "text": "Tried to delay based on SubMaster all_valid and CarState canValid, but the camera can doesn't come up as valid. Is that a bad route to take?", "title": null, "type": "comment" }, { "action": "closed", "author": "adeebshihadeh", "comment_id": null, "datetime": 1619816118000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
3
321
false
false
321
false
OneSignal/OneSignal-iOS-SDK
OneSignal
708,889,101
757
null
[ { "action": "opened", "author": "RustyRyan98", "comment_id": null, "datetime": 1601036083000, "masked_author": "username_0", "text": "Description:\r\n\r\nOne Signal User ID is returning NSCFString object instead of the value\r\n\r\nEnvironment:\r\n\r\n1. im using pod 'OneSignal', '>= 2.11.2', '< 3.0' \r\n2. I used CocoaPods but im writing the code in python using Kivy's pyobjus framework (There is no SDK for kivy)\r\n\r\n\r\nSteps to Reproduce Issue:\r\n\r\n Example:\r\n\r\n1. Im successfully initialised OneSignal and the Player ID is showing on the OneSignal Dashboard\r\n2. When I type ```onesignal_object.getPermissionSubscriptionState().subscriptionStatus.userId```\r\n3. it returns ```<importlib._bootstrap.__NSCFString object at 0x1293ced10>```\r\n4. Although subscription status is True\r\n\r\nI would appreciate any assistance, when I first initialised it returns the result of the OSRegisterUser and it shows success and returns 1 and I can see the userID there as the key \"id\" but when I try to print the userId it returns ```<importlib._bootstrap.__NSCFString object at 0x1293ced10>``` and the same for pushToken.", "title": "OneSignal User ID is returning <importlib._bootstrap.__NSCFString object at 0x1293ced10> even when the subscribed status is returning True", "type": "issue" }, { "action": "created", "author": "emawby", "comment_id": 710464401, "datetime": 1602876004000, "masked_author": "username_1", "text": "", "title": null, "type": "comment" }, { "action": "closed", "author": "emawby", "comment_id": null, "datetime": 1642699864000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "emawby", "comment_id": 1017748374, "datetime": 1642699864000, "masked_author": "username_1", "text": "Closing for now please let us know if this is still an issue", "title": null, "type": "comment" } ]
2
4
1,020
false
false
1,020
false
cures-hub/cures-condec-jira
cures-hub
694,308,991
323
{ "number": 323, "repo": "cures-condec-jira", "user_login": "cures-hub" }
[ { "action": "opened", "author": "kleebaum", "comment_id": null, "datetime": 1599384336000, "masked_author": "username_0", "text": "", "title": "CONDEC-747: Simplify velocity templates and Javascript closure objects", "type": "issue" } ]
2
2
0
false
true
0
false
adobe/helix-service
adobe
575,195,329
121
{ "number": 121, "repo": "helix-service", "user_login": "adobe" }
[ { "action": "created", "author": "trieloff", "comment_id": 594375479, "datetime": 1583308329000, "masked_author": "username_0", "text": ":tada: This PR is included in version 1.6.12 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/@adobe/create-helix-service/v/1.6.12)\n- [GitHub release](https://github.com/adobe/helix-service/releases/tag/v1.6.12)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "title": null, "type": "comment" } ]
3
3
2,161
false
true
369
false
vaadin/vaadin-form-layout
vaadin
715,640,365
135
null
[ { "action": "opened", "author": "netbeansuser2019", "comment_id": null, "datetime": 1600082945000, "masked_author": "username_0", "text": "Is it really correct to not read that back from Json to instance in https://github.com/vaadin/vaadin-form-layout-flow/blob/d3223e80538f0da71bd78045b50fe135077f9dc3/vaadin-form-layout-flow/src/main/java/com/vaadin/flow/component/formlayout/FormLayout.java#L293 ?", "title": "Getting ResponsiveSteps - class cast exception", "type": "issue" }, { "action": "created", "author": "netbeansuser2019", "comment_id": 720278728, "datetime": 1604300391000, "masked_author": "username_0", "text": "It is long time ago I do not remember a steps, but I guess that there are probably no special steps or even uncommon against any of your examples. \r\nSo I can only suggest to revise if you do properly conversion to and from JSON.\r\n\r\nE.g. I do not see any usage of readJson() (of ResponsiveStep) in getResponsiveSteps(), but it seems it has been done toJson() in setResponsiveSteps().", "title": null, "type": "comment" }, { "action": "created", "author": "appreciated", "comment_id": 732937168, "datetime": 1606220106000, "masked_author": "username_1", "text": "@alvarezguille It is possible to identify the underlying issue just by looking at the code of the `getResponsiveSteps` method. \r\n\r\n```\r\npublic List<ResponsiveStep> getResponsiveSteps() {\r\n JsonArray stepsJsonArray = (JsonArray) getElement()\r\n .getPropertyRaw(\"responsiveSteps\");\r\n if (stepsJsonArray == null) {\r\n return Collections.emptyList();\r\n }\r\n List<ResponsiveStep> steps = new ArrayList<>();\r\n for (int i = 0; i < stepsJsonArray.length(); i++) {\r\n steps.add(stepsJsonArray.get(i)); // <-- stepsJsonArray.get(...) does not return a `ResponsiveStep` but instead a JSON Object. The transformation is missing\r\n }\r\n return steps;\r\n}\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "netbeansuser2019", "comment_id": 737776862, "datetime": 1606987475000, "masked_author": "username_0", "text": "@username_1 \r\nI guess that such line was already type have look on link that open up this bug.", "title": null, "type": "comment" }, { "action": "created", "author": "TatuLund", "comment_id": 802885824, "datetime": 1616165129000, "masked_author": "username_2", "text": "I added the fix to version 1.0.1 of the EnahncedFormLayout \r\n\r\nhttps://vaadin.com/directory/component/enhancedformlayout", "title": null, "type": "comment" } ]
3
5
1,544
false
false
1,544
true
ubuntu/microk8s
ubuntu
742,282,450
1,732
{ "number": 1732, "repo": "microk8s", "user_login": "ubuntu" }
[ { "action": "opened", "author": "didier-durand", "comment_id": null, "datetime": 1605258071000, "masked_author": "username_0", "text": "Hi there,\r\n\r\nI propose to add this repo that shows how to implement Kata Containers with MicroK8s. It's v1 but subsequent improvements to come: see head of README.md\r\n\r\nThanks \r\n\r\nDidier", "title": "Community.md : adding KataContainer on MicroK8s", "type": "issue" }, { "action": "created", "author": "didier-durand", "comment_id": 727803487, "datetime": 1605513200000, "masked_author": "username_0", "text": "@ktsakalozos : Thanks for the positive feedback. My next step will be to inplement K8s RuntimeClass on this repo to allow parallel use of runc and kata-runtime with MicroK8s.", "title": null, "type": "comment" } ]
1
2
360
false
false
360
false
boto/boto3
boto
693,452,786
2,577
null
[ { "action": "opened", "author": "WolVecz", "comment_id": null, "datetime": 1599242796000, "masked_author": "username_0", "text": "I am attempting to make a simple call via boto3 to get parameters from the SSM store. However, when I make a basic call, I am consistently running into an internal boto3 error. Not sure if boto3 is broken or if I am just doing something wrong.. \r\n\r\n```\r\nimport boto3\r\n\r\nregion = 'us-east-1'\r\nsession = boto3.Session(region_name = region, profile_name = 'custom')\r\nssm = session.client('ssm')\r\n\r\ntest = ssm.get_parameters(Name = '/location/to/desired/params', WithDecryption=True)\r\n```\r\n\r\nThis is consistently providing the following error after the last line:\r\n\r\n```\r\nTraceback (most recent call last):\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\httpsession.py\", line 263, in send\r\n chunked=self._chunked(request.headers),\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\urllib3\\connectionpool.py\", line 677, in urlopen\r\n chunked=chunked,\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\urllib3\\connectionpool.py\", line 381, in _make_request\r\n self._validate_conn(conn)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\urllib3\\connectionpool.py\", line 978, in _validate_conn\r\n conn.connect()\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\urllib3\\connection.py\", line 371, in connect\r\n ssl_context=context,\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\snowflake\\connector\\ssl_wrap_socket.py\", line 404, in ssl_wrap_socket_with_ocsp\r\n ).validate(server_hostname, ret.connection)\r\n\r\nAttributeError: 'SSLSocket' object has no attribute 'connection'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n\r\n File \"<ipython-input-11-e49109764d13>\", line 7, in <module>\r\n test = ssm.get_parameter(Name='/datalake/dev/snowflake/parameters/data-science-mktg', WithDecryption=True)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\client.py\", line 337, in _api_call\r\n return self._make_api_call(operation_name, kwargs)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\client.py\", line 643, in _make_api_call\r\n operation_model, request_dict, request_context)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\client.py\", line 662, in _make_request\r\n return self._endpoint.make_request(operation_model, request_dict)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\endpoint.py\", line 102, in make_request\r\n return self._send_request(request_dict, operation_model)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\endpoint.py\", line 137, in _send_request\r\n success_response, exception):\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\endpoint.py\", line 256, in _needs_retry\r\n caught_exception=caught_exception, request_dict=request_dict)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\hooks.py\", line 356, in emit\r\n return self._emitter.emit(aliased_event_name, **kwargs)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\hooks.py\", line 228, in emit\r\n return self._emit(event_name, kwargs)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\hooks.py\", line 211, in _emit\r\n response = handler(**kwargs)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 183, in __call__\r\n if self._checker(attempts, response, caught_exception):\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 251, in __call__\r\n caught_exception)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 269, in _should_retry\r\n return self._checker(attempt_number, response, caught_exception)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 317, in __call__\r\n caught_exception)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 223, in __call__\r\n attempt_number, caught_exception)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\retryhandler.py\", line 359, in _check_caught_exception\r\n raise caught_exception\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\endpoint.py\", line 200, in _do_get_response\r\n http_response = self._send(request)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\endpoint.py\", line 269, in _send\r\n return self.http_session.send(request)\r\n\r\n File \"C:\\Users\\me\\Anaconda3\\lib\\site-packages\\botocore\\httpsession.py\", line 299, in send\r\n raise HTTPClientError(error=e)\r\n\r\nHTTPClientError: An HTTP Client raised an unhandled exception: 'SSLSocket' object has no attribute 'connection'\r\n```\r\nI did try upgrading boto3 and I am still having the error. Note I am running this in Spyder.", "title": "AttributeError 'SSLSocket' object has not attribute 'connection'", "type": "issue" }, { "action": "created", "author": "swetashre", "comment_id": 687349474, "datetime": 1599249123000, "masked_author": "username_1", "text": "@username_0 - Thank you for your post. It looks like the error is coming from snowflake connector. Are you suing snowflake connector in your code ? \r\nI found some issue in snowflake github repo which might help:\r\nhttps://github.com/snowflakedb/snowflake-connector-python/issues/324\r\n\r\nIt looks like an issue with snowflake connector rather than boto3. I would recommend checking their [github repo](https://github.com/snowflakedb/snowflake-connector-python/issues).", "title": null, "type": "comment" }, { "action": "created", "author": "WolVecz", "comment_id": 687379948, "datetime": 1599253035000, "masked_author": "username_0", "text": "Oh wow. your right.... Just having \"import snowflake.connector\" added file seems to be the actual break. Sorry for the inconvenience. Thanks for your help!", "title": null, "type": "comment" }, { "action": "closed", "author": "swetashre", "comment_id": null, "datetime": 1599259372000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "manugarri", "comment_id": 728845574, "datetime": 1605609885000, "masked_author": "username_2", "text": "yeah snowflake connector is an embarrasment... still seing this issue every week :D", "title": null, "type": "comment" }, { "action": "created", "author": "WolVecz", "comment_id": 730802040, "datetime": 1605838668000, "masked_author": "username_0", "text": "It is truly one of the worst packages I have used to-date. Lets hope they rebuild their package with all that fresh IPO money they just got.", "title": null, "type": "comment" } ]
3
6
5,461
false
false
5,461
true
grpc/grpc-java
grpc
589,667,637
6,873
{ "number": 6873, "repo": "grpc-java", "user_login": "grpc" }
[ { "action": "opened", "author": "antonbashir", "comment_id": null, "datetime": 1585432707000, "masked_author": "username_0", "text": "โ€ฆ (for changing backoff values or algorithm)", "title": "Added setBackOffPolicyProvider for setting provider of backoff policyโ€ฆ", "type": "issue" }, { "action": "created", "author": "antonbashir", "comment_id": 606628002, "datetime": 1585661381000, "masked_author": "username_0", "text": "Of course!\r\n\r\nImagine that you stop your GRPC Server but do not stop GRPC client.\r\nThen GRPC client starts backoff process and exponentially increments interval.\r\nAfter start of GRPC server next request from client will be waiting for successful reconnect after backoff interval. \r\nBecause of it in our project we have situation when first request processing during (5-10 seconds).\r\nSo, i want to set some minimal value (one second or less) to max backoff interval parameter.\r\nMay be i mistake in this reason of long first request processing, but anyway i think that so parameters like backoff policy must be configurable through builder.", "title": null, "type": "comment" }, { "action": "created", "author": "ejona86", "comment_id": 606890966, "datetime": 1585690721000, "masked_author": "username_1", "text": "Then GRPC client starts backoff process and exponentially increments interval.\r\nAfter start of GRPC server next request from client will be waiting for successful reconnect after backoff interval.\r\n\r\nThis is essential behavior. Without the backoff, clients will reconnect rapidly to the server and overload it. The backoff _protects_ the server.\r\n\r\nSo I don't think reducing the backoff time is a good approach. Why does the server restart? And what type of server is it such that there is only one instance?", "title": null, "type": "comment" }, { "action": "created", "author": "mizantrop2397", "comment_id": 607243626, "datetime": 1585747073000, "masked_author": "username_2", "text": "I saw this comment and thought that not only me want to make this parameter configurable. \r\nAlso, i want to try some other policy, for example, periodic backoff policy with constant interval.\r\n\r\nAs you offer in other issue, solution for my case could be \"connection attempt exponential timeout\", but i think that this solution costs more developing time than configuring of backoff policy.\r\nhttps://github.com/grpc/grpc-java/issues/1943\r\n\r\nAs you could be seen this is my first PR in this project, so if you see some reasons to refuse this feature, please tell me. I want to understand, what negative aspects of configuring backoff policy.", "title": null, "type": "comment" }, { "action": "created", "author": "antonbashir", "comment_id": 607336295, "datetime": 1585756722000, "masked_author": "username_0", "text": "I saw this comment and thought that not only me want to make this parameter configurable. \r\nAlso, i want to try some other policy, for example, periodic backoff policy with constant interval.\r\n\r\nAs you offer in other issue, solution for my case could be \"connection attempt exponential timeout\", but i think that this solution costs more developing time than configuring of backoff policy.\r\nhttps://github.com/grpc/grpc-java/issues/1943\r\n\r\nAs you could be seen this is my first PR in this project, so if you see some reasons to refuse this feature, please tell me. I want to understand, what negative aspects of configuring backoff policy.", "title": null, "type": "comment" }, { "action": "created", "author": "ejona86", "comment_id": 607387480, "datetime": 1585762279000, "masked_author": "username_1", "text": "That's actually something different. The important part of that is the _timeout_. It causes _errors_ to occur sooner. If that would fix your issue, then this PR would _not_; they fix separate issues.", "title": null, "type": "comment" }, { "action": "created", "author": "ejona86", "comment_id": 609889779, "datetime": 1586189495000, "masked_author": "username_1", "text": "@username_0, closing the PR is fine, but did you want to open an issue so that we could discuss ways to resolve your use-case?", "title": null, "type": "comment" } ]
4
8
3,463
false
true
2,794
true
kubeform/kfc
kubeform
720,655,519
45
{ "number": 45, "repo": "kfc", "user_login": "kubeform" }
[ { "action": "opened", "author": "faem", "comment_id": null, "datetime": 1602613917000, "masked_author": "username_0", "text": "", "title": "Add Remote Backend", "type": "issue" }, { "action": "created", "author": "shabe", "comment_id": 782052596, "datetime": 1613738719000, "masked_author": "username_1", "text": "Hi @username_0 - super keen to see this functionality. Is this PR going to be merged and into a build anytime soon? Thanks!", "title": null, "type": "comment" } ]
3
3
648
false
true
117
true
elastic/apm-pipeline-library
elastic
727,716,475
789
null
[ { "action": "opened", "author": "v1v", "comment_id": null, "datetime": 1603400301000, "masked_author": "username_0", "text": "```\r\n\r\n{\r\nage: 1,\r\nduration: 0,\r\nerrorDetails: \"Failed\",\r\nerrorStackTrace: \" client_integration_test.go:58: for testing the flaky test reporting for an existing flaky test\",\r\nid: \"io.jenkins.blueocean.service.embedded.rest.junit.BlueJUnitTestResult:elasticsearch%3Ajunit%2F(root)%2Felasticsearch%2FBuild_Test___libbeat_build___TestClientPublishEventKerberosAware\",\r\nname: \"Build&Test / libbeat-build / TestClientPublishEventKerberosAware รขโ‚ฌโ€œ elasticsearch\",\r\nstatus: \"FAILED\"\r\n}\r\n\r\n```\r\n\r\n![image](https://user-images.githubusercontent.com/2871786/96929154-a0888300-14b1-11eb-9a2d-de1edd26994c.png)\r\n\r\n![image](https://user-images.githubusercontent.com/2871786/96929196-aed69f00-14b1-11eb-9ef6-e1de219199da.png)", "title": "[flaky] normalisation in the flaky does not happen with the tests-errors.json", "type": "issue" }, { "action": "created", "author": "v1v", "comment_id": 715439477, "datetime": 1603469834000, "masked_author": "username_0", "text": "It seems the issue is not related to the encoding since it was something in my browser, but worked like a charm in the CLI:\r\n\r\n![image](https://user-images.githubusercontent.com/2871786/97028119-95862f00-1553-11eb-85d0-db7253aaaa7d.png)\r\n\r\n\r\n\r\nIt seems the issue is related with the number of reported flaky tests, since it reports only the ones from August 2020 while there already some others\r\n\r\n![image](https://user-images.githubusercontent.com/2871786/97028025-75567000-1553-11eb-933d-357ce9dd856e.png)", "title": null, "type": "comment" }, { "action": "created", "author": "v1v", "comment_id": 716426040, "datetime": 1603704655000, "masked_author": "username_0", "text": "![image](https://user-images.githubusercontent.com/2871786/97155920-ea04f680-176d-11eb-8d3b-c13bd28a827d.png)\r\n\r\n```\r\nGET /reporter-beats-beats-master/_search?size=1000\r\n{\r\n \"timeout\": \"2s\",\r\n \"sort\" : [\r\n { \"timestamp\" : \"desc\" },\r\n { \"test_score\" : \"desc\" }\r\n ],\r\n \"query\" : {\r\n \"range\" : {\r\n \"test_score\" : {\r\n \"gt\" : 0.0\r\n }\r\n }\r\n }\r\n}\r\n```", "title": null, "type": "comment" }, { "action": "closed", "author": "v1v", "comment_id": null, "datetime": 1603804307000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
4
1,596
false
false
1,596
false
rvm/rvm
rvm
790,632,315
5,040
{ "number": 5040, "repo": "rvm", "user_login": "rvm" }
[ { "action": "opened", "author": "pedrofurtado", "comment_id": null, "datetime": 1611196811000, "masked_author": "username_0", "text": "Closes #5038.", "title": "GitHub Actions", "type": "issue" }, { "action": "created", "author": "pedrofurtado", "comment_id": 764194556, "datetime": 1611196952000, "masked_author": "username_0", "text": "@username_1 @mpapis When you have time, can you help me writing this file? I started some draft, migrating parts of the `.travis.yml` to `.github/workflows/all.yml`.\r\n\r\nLater, we can define a pattern for names, build steps and so on ๐Ÿค", "title": null, "type": "comment" }, { "action": "created", "author": "pedrofurtado", "comment_id": 883592626, "datetime": 1626804578000, "masked_author": "username_0", "text": "Github actions running on Ubuntu and MacOS ๐ŸŽ‰ \r\n\r\nThe commits can be squashed by administrators, when merging the PR (we just need to select the option \"squash and merge\")", "title": null, "type": "comment" }, { "action": "created", "author": "pkuczynski", "comment_id": 883624493, "datetime": 1626807803000, "masked_author": "username_1", "text": "Looks good to me too! And its much faster. I will give it a go...", "title": null, "type": "comment" }, { "action": "created", "author": "pkuczynski", "comment_id": 883630195, "datetime": 1626808350000, "masked_author": "username_1", "text": "Thank you @username_0 for putting your time into this!", "title": null, "type": "comment" } ]
2
5
539
false
false
539
true
micropython/micropython
micropython
517,572,401
5,294
{ "number": 5294, "repo": "micropython", "user_login": "micropython" }
[ { "action": "opened", "author": "dpgeorge", "comment_id": null, "datetime": 1572935360000, "masked_author": "username_0", "text": "This PR adds a \"general\" `machine.pixelbitstream(pin, timing, buf)` function which can be used to drive neopixels/ws2812/etc LEDs, using a software bit-banging approach. Arguments are:\r\n- pin -- the pin to output on (can be any pin)\r\n- timing -- tuple of 4 values for T0H, T0L, T1H, T1L in nanoseconds\r\n- buf -- buffer of bytes to output on the pin\r\n\r\nThe bytes are output according to the \"ws2812 scheme\", where each bit is encoded by a high pulse then a low pulse of a certain duration, specified by the timing tuple.\r\n\r\nThis should be general enough to support all variants of these kinds of LEDs, and tune the timing values in Python for any particular application.\r\n\r\nNote that this uses a software implementation and IRQs are disabled during the output of the bits. So long streams of bits will pause IRQs for a long time. But it's still useful for the cases where hardware (eg SPI) can't be used.\r\n\r\nThis function should be able to be used without much effort on all ports, but it's only tested and tuned so far on stm32 (PYBv1.0, also tested on an F0 to show that it can work at low CPU freq).\r\n\r\nSee also #5117", "title": "stm32/machine_pixelbitstream: Add machine.pixelbitstream function.", "type": "issue" }, { "action": "created", "author": "maludwig", "comment_id": 550571870, "datetime": 1573088567000, "masked_author": "username_1", "text": "There's a few things I would personally change here. You should include docs for how to use it. The \"Example usage:\" section in python should just be the NeoPixel class itself, as in the ESP8266/32 implementation. Make life easy for people. Have things be more similar across ports. I also feel like pixelbitstream should be exposed under the NeoPixel class, since it seems more related to neopixels as a concept, rather than to the machine. I'll make other, more minor suggestions with comments directly on the code.", "title": null, "type": "comment" }, { "action": "created", "author": "maludwig", "comment_id": 552275688, "datetime": 1573441789000, "masked_author": "username_1", "text": "After a conversation with @jimmo on IRC, I think it would be better to move this from the STM32 implementation, into a more generic place for all ports. I'm happy to test it on ESP8266/ESP32 and make the code work there, if you're happy to test the stm32 implementation. Let me know if I can help.", "title": null, "type": "comment" }, { "action": "created", "author": "dpgeorge", "comment_id": 552285282, "datetime": 1573445213000, "masked_author": "username_0", "text": "Ok, I'll move it so it can be reused by all ports. Then we can try to make it work well on stm32/esp8266/esp32.", "title": null, "type": "comment" }, { "action": "created", "author": "dpgeorge", "comment_id": 552296027, "datetime": 1573449197000, "masked_author": "username_0", "text": "See #5318 for a version of this which is usable by all ports. That PR would supersede this one.", "title": null, "type": "comment" }, { "action": "created", "author": "mcauser", "comment_id": 552299048, "datetime": 1573450228000, "masked_author": "username_2", "text": "This is mostly about driving NeoPixels, but it would be cool to use something like this to drive simple ASK/OOK 433MHz transmitters too. I was experimenting with the [ESP32 RTM implementation #5184](https://github.com/micropython/micropython/pull/5184) and the signals are pretty consistent and easy to generate.", "title": null, "type": "comment" }, { "action": "created", "author": "dpgeorge", "comment_id": 552299925, "datetime": 1573450515000, "masked_author": "username_0", "text": "The RMT is a much more general purpose bit stream generator. It's very esp32 specific but we could in principle implement a software version of it (bit banging) for other ports...", "title": null, "type": "comment" }, { "action": "created", "author": "dpgeorge", "comment_id": 897279287, "datetime": 1628732289000, "masked_author": "username_0", "text": "Closed in favour of #7637.", "title": null, "type": "comment" } ]
3
8
2,662
false
false
2,662
false
venikman/security-strategy-essentials
null
521,872,950
2
null
[ { "action": "closed", "author": "venikman", "comment_id": null, "datetime": 1573604067000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
2
0
false
true
0
false
firebase/firebase-admin-node
firebase
795,589,851
1,144
{ "number": 1144, "repo": "firebase-admin-node", "user_login": "firebase" }
[ { "action": "opened", "author": "hiranya911", "comment_id": null, "datetime": 1611797620000, "masked_author": "username_0", "text": "So far we have been exporting all API declarations through `default-namespace.d.ts` in order to generate a single API report that includes all of our APIs. However, we do not want to export everything from the above file. Since it is the declaration of the top-level `admin` namespace, it should only export the direct members of `admin` such as `admin.initializeApp()` and `admin.auth`. There are also other technical reasons why we cannot export everything from this file. For example, both RTDB and Firestore modules export a member named `Query`. Trying to export both these types from the same file results in an error.\r\n\r\nFixing this means we have to change how we generate API reports, and adopt a one report per module entry point scheme. API Extractor [doesn't support](https://github.com/microsoft/rushstack/issues/1596) this natively yet, and therefore I'm implementing a simple script that generates separate API reports for each entry point. I declare the following map of entry points:\r\n\r\n```js\r\nconst entryPoints = {\r\n 'firebase-admin': './lib/default-namespace.d.ts',\r\n 'firebase-admin/app': './lib/app/index.d.ts',\r\n 'firebase-admin/auth': './lib/auth/index.d.ts',\r\n 'firebase-admin/database': './lib/database/index.d.ts',\r\n 'firebase-admin/instance-id': './lib/instance-id/index.d.ts',\r\n};\r\n```\r\n\r\nThen I iterate over the map, invoking API Extractor on each entry point. Generated reports are added under the `etc/` directory.\r\n\r\nWhile this results in a set of comprehensive API reports (while enabling us to only export the necessary elements from `default-namespace.d.ts`), there are also a few caveats:\r\n\r\n1. The API report of the top-level `firebase-admin` module which contains all the namespaces like `admin.auth` and `admin.database`, ends up with a lot of `ae-forgotten-export` warnings. This is because we export type aliases from each of the namespaces, without directly exporting the alias target. For example `firebase-admin` exports the `admin.auth.UserRecord` type alias, but not what it points to. This gets reported as a warning in the generated report:\r\n\r\n```\r\n// Warning: (ae-forgotten-export) The symbol \"UserRecord\" needs to be exported by the entry point default-namespace.d.ts\r\n```\r\n\r\n2. Other service-level API reports emit an `ae-forgotten-export` warnings for the `App` type which comes from a separate module outside the immediate entry point.\r\n\r\n```\r\n// Warning: (ae-forgotten-export) The symbol \"App\" needs to be exported by the entry point index.d.ts\r\n```\r\n\r\nHopefully, we shall decommission the top-level `admin` namespace some day making the 1st issue irrelevant. 2nd issue is more of an annoyance at this point, and might get fixed if API Extractor starts supporting multiple entry points in the future.", "title": "chore: Generating separate API reports for module entry points", "type": "issue" }, { "action": "created", "author": "hiranya911", "comment_id": 768713902, "datetime": 1611797903000, "masked_author": "username_0", "text": "Check the end of CI build logs to see the new script in action.", "title": null, "type": "comment" }, { "action": "created", "author": "hiranya911", "comment_id": 769395486, "datetime": 1611868096000, "masked_author": "username_0", "text": "@Feiyang1 adding you for a quick look as well. This is my current solution to the multiple entry points problem with API Extractor. I'm ignoring the whole documentation issue for now (I'm hoping we can continue to use Typedoc or use a custom API Documenter plugin for that). But this gets us to a point where we can generate API reports for each entry point.", "title": null, "type": "comment" } ]
1
3
3,180
false
false
3,180
false
MicrosoftDocs/ATADocs
MicrosoftDocs
644,518,073
351
{ "number": 351, "repo": "ATADocs", "user_login": "MicrosoftDocs" }
[ { "action": "opened", "author": "PeterSelchDahl", "comment_id": null, "datetime": 1592995917000, "masked_author": "username_0", "text": "To/From direction change for Azure ATP Sensor", "title": "To/From direction change for Azure ATP Sensor", "type": "issue" }, { "action": "created", "author": "PeterSelchDahl", "comment_id": 648748221, "datetime": 1592995944000, "masked_author": "username_0", "text": "To/From direction change for Azure ATP Sensor", "title": null, "type": "comment" }, { "action": "created", "author": "PRMerger19", "comment_id": 648748683, "datetime": 1592996006000, "masked_author": "username_1", "text": "@username_0 : Thanks for your contribution! The author(s) have been notified to review your proposed change.", "title": null, "type": "comment" }, { "action": "created", "author": "shsagir", "comment_id": 653874053, "datetime": 1593946948000, "masked_author": "username_2", "text": "@username_0 Thanks for your feedback. We will be submitting a documentation change based on your suggestion in a separate PR, and the updated article should be live this week. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.", "title": null, "type": "comment" } ]
4
5
1,234
false
true
510
true
trailofbits/monitoring_linux_events
trailofbits
765,728,848
4,386
null
[ { "action": "opened", "author": "13042503719", "comment_id": null, "datetime": 1607906223000, "masked_author": "username_0", "text": "้˜ฒๅŸŽๆธฏๆฑฝ่ฝฆ็ซ™ๅ“ชๆœ‰็‰นๆฎŠๆœๅŠก็š„ๆด—ๆตดโ–‹โ•‹่–‡/่Šฏ:10771909โ–‹็พŽๅฅณ้˜ฒๅŸŽๆธฏๆฑฝ่ฝฆ็ซ™ๅ“ชๆœ‰็‰นๆฎŠๆœๅŠก็š„ๆด—ๆตดใ€๏ผ‹V:๏ผ‘๏ผ๏ผ—๏ผ—๏ผ‘๏ผ™๏ผ๏ผ™ใ€‘ๆœˆๆ—ฅ๏ผŒๆ–ฐๆˆฟ็”ตๅ•†้ข†่ท‘่€…ๅฑ…็†ๆ–ฐๆˆฟๆญฃๅผๅฎฃๅธƒ็ญพ็บฆ้’ๅนดๅฝฑ่ง†ๆผ”ๅ‘˜่ฟชไธฝ็ƒญๅทดไธบๅ…จๆ–ฐๅ“็‰Œไปฃ่จ€ไบบ๏ผŒๅŒๆ—ถๅ‘ๅธƒโ€œ้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅธฎไฝ ไนฐๅฅฝๆˆฟโ€ๅ“็‰Œๆ–ฐๆˆ˜็•ฅใ€‚ๅฑ…็†ๆ–ฐๆˆฟๆˆ็ซ‹ไบŽๅนด๏ผŒ่‡ดๅŠ›ไบŽๆ‰“้€ ไธ€็ซ™ๅผ่ดญๆˆฟๅนณๅฐ๏ผŒๅฏไปฅไธบ็”จๆˆทๆไพ›ไปŽๅคงๆ•ฐๆฎๆ‰พๆˆฟใ€ๅ…จๅŸŽ็œ‹ๆˆฟๅˆฐไนฐๆˆฟไปฅๅŠๅ”ฎๅŽๆœๅŠกไฟ้šœ็ญ‰ๅ…จๆต็จ‹ๅฎšๅˆถๅŒ–ๆœๅŠกใ€‚็ป่ฟ‡็Ÿญ็Ÿญๅ‡ ๅนด็š„ๅ‘ๅฑ•๏ผŒๅฑ…็†ๆ–ฐๆˆฟๅทฒ่ทƒ่บซๆˆไธบๅ›ฝๅ†…ๆ–ฐๆˆฟ็”ตๅ•†้ข†่ท‘่€…ใ€‚ๆž่‡ดๅฅณ็ฅžๆบๆ‰‹ๅฑ…็†ๆ–ฐๆˆฟๅ…ฑๅˆ›ไบบ็ฑป็†ๆƒณๅฑ…ไฝๆ—ถไปฃไฝœไธบๆ–ฐ็”Ÿไปฃ้’ๅนดๆผ”ๅ‘˜๏ผŒ่ฟชไธฝ็ƒญๅทด่‡ชๅ‡บ้“ไปฅๆฅๅฐฑๅฏนๆผ”่‰บ่กŒไธšๆŠฑๆœ‰ๆ•ฌ็•ไน‹ๅฟƒไธŽไธๅ‡ก็†ๆƒณใ€‚ไปŽๅˆšๆŸ”ๅนถๆตŽ็š„้˜ฟๅจœๅฐ”็ฝ•ๅˆฐๅค็ต็ฒพๆ€ช็š„้ซ˜้›ฏ๏ผŒๅ†ๅˆฐๆทณ็พŽ็ตๅŠจ็š„ๅ‡คไน๏ผŒๅฅนๅ‡ญๅ€Ÿๅฏนๆผ”่‰บ้“่ทฏไธŠ็š„ๆž่‡ด่ฟฝๆฑ‚ไธŽไธไฟ—็š„่กจ็ŽฐๅŠ›ๆˆๅŠŸๅก‘้€ ไบ†ๆ— ๆ•ฐไธชๆทฑๅ…ฅไบบๅฟƒ็š„่ง’่‰ฒ๏ผŒๆ”ถๅ‰ฒไบ†ๅคงๆ‰นๅนด่ฝป็ฒ‰ไธ็š„็ฐ‡ๆ‹ฅใ€‚่ฟชไธฝ็ƒญๅทดๅœจ่ฟฝๆฑ‚ๆž่‡ด็š„้“่ทฏไธŠไปŽๆœชๅœๆญ‡๏ผŒ่ฟ™ไนŸไธŽๅฑ…็†ๆ–ฐๆˆฟ็š„ไผไธšๅ†…ๆ ธ๏ผš้€š่ฟ‡ๆž่‡ด็š„่ฟฝๆฑ‚ๆปก่ถณไบบ็ฑปๅฏนๅฑ…ไฝ็š„็†ๆƒณ๏ผŒไธ่ฐ‹่€Œๅˆใ€‚ๅฑ…็†ๆ–ฐๆˆฟ่‡ดๅŠ›ไบŽไธ“ไธš่ƒฝๅŠ›ๆ‰“้€ ๆž่‡ด็š„้ซ˜ๅ“่ดจๆœๅŠก้ฉๆ–ฐๅนฟๅคง็”จๆˆท็š„่ดญๆˆฟไฝ“้ชŒใ€‚้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅธฎไฝ ไนฐๅฅฝๆˆฟๆˆ˜็•ฅๅ‘ๅธƒๆ‰“้€ ่กŒไธšๅ“่ดจๆœๅŠกๆ–ฐๆ ‡ๆ†่ฟ‡ๅŽปๅๅ‡ ๅนด๏ผŒๆˆ‘ๅ›ฝๆˆฟๅœฐไบง่กŒไธšๅค„ไบŽ้ป„้‡‘ๅ‘ๅฑ•ๆ—ถๆœŸ๏ผŒไฝ†็”ฑไบŽๅธ‚ๅœบไพ›ไธๅบ”ๆฑ‚ไปฅๅŠ่กŒไธšไปŽไธšไบบๅ‘˜็ด ่ดจๅ‚ๅทฎไธ้ฝ็ญ‰ๅ› ็ด ๏ผŒๆถˆ่ดน่€…็š„่ดญๆˆฟไฝ“้ชŒๆ™ฎ้่พƒๅทฎใ€‚ๅฆ‚ไปŠ๏ผŒๆˆฟๅœฐไบง่กŒไธš่ฟ›ๅ…ฅไบ†ๅนณ็จณๅ‘ๅฑ•ๆœŸ๏ผŒ้š็€ๆˆฟๅœฐไบง่กŒไธš่ง„ๆจกๅขž้€Ÿ็š„ๆ”พ็ผ“๏ผŒไธญๅ›ฝๆฅผๅธ‚ไนŸๆญฃ้€ๆธไปŽๅผ€ๅ‘ไธบๅ…ˆ่ฝฌๅ‘ไปฅๆœๅŠกไธบไธปๅฏผ็š„ๆˆฟไบงๆ–ฐ็ปๆตŽๆ—ถไปฃ๏ผŒๆถˆ่ดน่€…ๅฏน่ดญๆˆฟๆœๅŠกไฝ“้ชŒๆๅ‡บไบ†ๆ›ด้ซ˜็š„่ฆๆฑ‚ใ€‚ๅฑ…็†ๆ–ฐๆˆฟ็Ž‹้นๆ›พๅœจๆŽฅๅ—ๅช’ไฝ“้‡‡่ฎฟๆ—ถ่กจ็คบ๏ผšโ€œไธ‹ๅŠๅœบ็š„ๅ…ณ้”ฎ่ฏๆ˜ฏโ€œๆธ ้“ไธบ็Ž‹โ€ใ€โ€œไฝ“้ชŒ่‡ณไธŠโ€ไธŽโ€œๆ•ฐๆฎ้ฉฑๅŠจโ€ใ€‚่ฟ™ๅœบๆˆ˜ๅฝน็š„ๅ…ณ้”ฎไน‹ๅค„ๆ‹ผ็š„ๆ˜ฏไบบๆ‰่€Œ้žไบบๆตทใ€‚โ€œ่€Œๆญคๆฌกๅฑ…็†ๆ–ฐๆˆฟๅ‘ๅธƒ็š„ๅ…จๆ–ฐๅ“็‰Œๆˆ˜็•ฅโ€œ้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅธฎไฝ ไนฐๅฅฝๆˆฟโ€๏ผŒๆญฃๆ˜ฏไธบไบ†ๅบ”ๅฏนๆˆฟๅœฐไบง่กŒไธšไบŸ้œ€ๆๅ‡ๆœๅŠกๆฐดๅนณ็š„ๅคง่ƒŒๆ™ฏ๏ผŒๅ…ถๅฎžๅฑ…็†ๆ–ฐๆˆฟๅœจๅˆ›ไธšไน‹ๅˆๅฐฑๆžๅ…ถ้‡่ง†ไผ˜็ง€ไบบๆ‰ๅ›ข้˜Ÿ็š„ๅปบ่ฎพ๏ผŒๅ…ถๆ‹ฅๆœ‰็š„้ซ˜ๅญฆๅކๆˆฟไบงๅ’จ่ฏขๅธˆๅ›ข้˜Ÿๅ‡ญๅ€Ÿโ€œ้ซ˜็ด ่ดจโ€ใ€โ€œไธฅ่ฆๆฑ‚โ€ไธŽโ€œๆ›ดไธ“ไธšโ€็š„ไธ‰ๅคงๅ…ณ้”ฎ่ฏ๏ผŒๅŠฉๆŽจๅฑ…็†ๆ–ฐๆˆฟ้•ฟๆœŸ้ข†่ท‘ๆ–ฐๆˆฟ็”ตๅ•†้ข†ๅŸŸใ€‚ๆฎไบ†่งฃ๏ผŒๅฑ…็†ๆ–ฐๆˆฟ็š„้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅ›ข้˜Ÿไธญ๏ผŒๆœฌ็ง‘ๆฏ•ไธš็އ้ซ˜่พพ๏ผŒๅ…ถไธญๆ›ดๆœ‰็š„ๅ’จ่ฏขๅธˆๆฏ•ไธšไบŽใ€้ซ˜ๆ ก๏ผŒ้ฆ–ๅ…ˆๅœจไบบๆ‰็ด ่ดจไธŠไฟ่ฏไบ†ๅฏนๆถˆ่ดน่€…็š„ๆœๅŠกๅ“่ดจ๏ผ›ๅŒๆ—ถ๏ผŒไธฅไบŽๅพ‹ๅทฑไนŸๆ˜ฏๅฑ…็†ๆ–ฐๆˆฟๅฏนๅ…ถๅ’จ่ฏขๅธˆๅ›ข้˜Ÿ็š„้‡่ฆ็ฎก็†็ญ–็•ฅ๏ผŒๅคฉๅฒ—ๅ‰ๅŸน่ฎญไธŽไธฅๆ ผๆœๅŠก่€ƒๆ ธ๏ผŒๅฐ†ไธฅ่ฐจ็š„้€ป่พ‘ๆ€งไธŽๆ•ฐๆฎๆ€็ปดๆทฑๆคไบŽๆฏไฝๅ’จ่ฏขๅธˆ้ขๅ‘ๆถˆ่ดน่€…็š„ๆœๅŠกไน‹ไธญ๏ผ›ๆญคๅค–๏ผŒๆ›ดไธ“ไธšไนŸๆ˜ฏๅ…ถๅ“่ดจๆœๅŠก็š„้‡่ฆไธ€็Žฏใ€‚ๅœจๆœๅŠกๆœŸ้—ด๏ผŒๅ’จ่ฏขๅธˆ้€š่ฟ‡ๅฎžๅœฐๅ‹˜ๆŸฅ็™พไธชๆฅผ็›˜๏ผŒๆไพ›ๅ…จๅŸŽๆฅผ็›˜ๅ’จ่ฏข๏ผŒ็”จไธ“ไธš็š„ไธšๅŠก่ƒฝๅŠ›ๆทฑๆทฑๆธ—้€็ป™ๆœ‰่ดญๆˆฟ้œ€ๆฑ‚็š„็”จๆˆท๏ผŒๅธฎไป–ไปฌไนฐๅˆฐ็†ๆƒณๅฅฝๆˆฟใ€‚้™คไบ†้‡่ง†ๅฏน้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆ็š„ๅ›ข้˜Ÿๅปบ่ฎพ๏ผŒไธๆ–ญๅ‡็บงๅ“่ดจๆœๅŠก๏ผŒๅฑ…็†ๆ–ฐๆˆฟไนŸ่‡ดๅŠ›ไบŽๆ‰“้€ ไธ€็ซ™ๅผ่ดญๆˆฟๅนณๅฐใ€‚้€š่ฟ‡ๅคงๆ•ฐๆฎ็ณป็ปŸๅŒน้…ๆˆฟๅฎขๆ‰พๆˆฟ๏ผŒๅˆฐๅ…จ็จ‹ๅ…่ดนไธ“่ฝฆๆŽฅ้€ใ€้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅ…จ็จ‹้™ชๅŒ่ดดๅฟƒ็œ‹ๅฅฝๆˆฟ๏ผŒๅ†ๅˆฐไฝŽไปทไนฐๆˆฟใ€ไนฐ่ดต่ต”ๅทฎไปท็ญ‰่ดญๆˆฟไฟ้šœ็ญ‰ๆ”ฟ็ญ–้ฉฑๅŠจไธ‹๏ผŒๅฑ…็†ๆ–ฐๆˆฟ็š„ๅนณๅ‡็”จๆˆทๅ†ณ็ญ–ๅ‘จๆœŸไป…ไธบๅคฉ๏ผŒ่ฟœ้ซ˜ไบŽ่กŒไธšๅนณๅ‡ๆ•ˆ็އใ€‚็›ฎๅ‰๏ผŒๅฑ…็†ๆ–ฐๆˆฟๅทฒๆˆไธบไบฟ็”จๆˆท็š„้€‰ๆ‹ฉ๏ผŒๅนถ่Žทๅพ—่ถ…่ฟ‡ๅฎถๅ“็‰Œๅผ€ๅ‘ๅ•†็š„ๆ”ฏๆŒไธŽไฟก่ต–๏ผŒๅŒๆ—ถๅœจ็”จๆˆท็พคไฝ“ไธญไนŸๅฝขๆˆไบ†ๆžๅฅฝ็š„ๅฃ็ข‘๏ผŒๆฎไบ†่งฃๅฑ…็†ๆ–ฐๆˆฟ็ดฏ่ฎก่Žทๅพ—่ถ…่ฟ‡ไธ‡ๅญ—็œŸๅฎž็”จๆˆทๅฅฝ่ฏ„๏ผŒ็”จๆˆทๆปกๆ„ๅบฆ้ซ˜่พพ๏ผŒ่ถณ่งๅ“่ดจๆœๅŠกๅœจไบ’่”็ฝ‘ๆˆฟไบง้ข†ๅŸŸ็š„็ˆ†ๅ‘ๅŠ›ใ€‚ไฝœไธบๆ–ฐๆˆฟ็”ตๅ•†้ข†่ท‘่€…๏ผŒๅฑ…็†ๆ–ฐๆˆฟ่‡ดๅŠ›ไบŽๆ‰“้€ ้ซ˜ๅญฆๅކๅ’จ่ฏขๅธˆๅ›ข้˜Ÿไปฅๆไพ›็ป™็”จๆˆทๆ›ด้ซ˜ๅ“่ดจ็š„ๆœๅŠก๏ผŒๅœจ็”จๆˆทไฝ“้ชŒใ€ๆœๅŠกๆ•ˆ็އไธŠไธๆ–ญ่ฟฝๆฑ‚ๆž่‡ด๏ผŒไปฅๅฎž็Žฐๆปก่ถณไบบ็ฑปๅฑ…ไฝ็†ๆƒณ็š„ไผไธšๆ„ฟๆ™ฏใ€‚็›ธไฟก๏ผŒๆญคๆฌกๅฑ…็†ๆ–ฐๆˆฟไธŽ่ฟชไธฝ็ƒญๅทด็š„ๅˆไฝœๅฐ†ไผš่ฎฉๅฑ…็†ๆ–ฐๆˆฟ่ตฐ่ฟ‘ๆ›ดๅคšๆถˆ่ดน่€…๏ผŒๅฎž็Žฐไป–ไปฌๅฏน็†ๆƒณๅฑ…ไฝ็š„่ฟฝๆฑ‚๏ผŒๅผ€ๅฏ็†ๆƒณๅฑ…ไฝๆ–ฐๆ—ถไปฃใ€‚ๅฃฐๆ˜Ž๏ผšไธญๅŽๅจฑไน็ฝ‘ๅˆŠ่ฝฝๆญคๆ–‡ๅ‡บไบŽไผ ้€’ๆ›ดๅคšไฟกๆฏไน‹็›ฎ็š„๏ผŒๅนถ้žๆ„ๅ‘ณ็€่ตžๅŒๅ…ถ่ง‚็‚นๆˆ–่ฏๅฎžๅ…ถๆ่ฟฐใ€‚็‰ˆๆƒๅฝ’ไฝœ่€…ๆ‰€ๆœ‰๏ผŒๆ›ดๅคšๅŒ็ฑปๆ–‡็ซ ๆ•ฌ่ฏทๆต่งˆ๏ผš็ปผๅˆ่ต„่ฎฏ้€žๆ ธๆ…ๅŒฎ่ขซไธญๅญ”็ปž่—ค่‡ณๆ–—็”จๅฏผ้‡‰ๆ–—https://github.com/trailofbits/monitoring_linux_events/issues/4125?cxpqk <br />https://github.com/trailofbits/monitoring_linux_events/issues/1515?59169 <br />https://github.com/trailofbits/monitoring_linux_events/issues/817?xvmrf <br />https://github.com/trailofbits/monitoring_linux_events/issues/91?nbnta <br />https://github.com/trailofbits/monitoring_linux_events/issues/2284?w1iME <br />", "title": "้˜ฒๅŸŽๆธฏๆฑฝ่ฝฆ็ซ™ๅ“ชๆœ‰็‰นๆฎŠๆœๅŠก็š„ๆด—ๆตดq", "type": "issue" } ]
1
1
1,863
false
false
1,863
false
jerairrest/react-chartjs-2
null
645,107,872
534
null
[ { "action": "opened", "author": "ottworks", "comment_id": null, "datetime": 1593053859000, "masked_author": "username_0", "text": "Reproduction: https://codesandbox.io/s/react-chartjs-2-example-9zp80?file=/src/index.js\r\n\r\nExpected behavior: Clicking the button twice returns the chart to how it was initially.\r\n\r\nObserved behavior: Clicking the button twice puts the chart into a mixed state between before and after.\r\n\r\nIt looks like memoizeDataProps isn't doing a thorough enough clone of the data prop. Replacing the function body with `return JSON.parse(JSON.stringify(this.props.data))` seems to fix the issue somewhat.", "title": "Data props getting mutated between prop changes", "type": "issue" }, { "action": "created", "author": "typpo", "comment_id": 649932456, "datetime": 1593141296000, "masked_author": "username_1", "text": "Each dataset needs a unique key. By default, the `label` property on each dataset is used. Alternatively, you may provide a `datasetKeyProvider` as a prop that returns a unique key.\r\n\r\nIn this case, you could add something like this to your `Line` chart because each dataset has a unique label/borderColor combination):\r\n```\r\ndatasetKeyProvider={dataset => `${dataset.label}__${dataset.borderColor}`}\r\n```\r\n\r\nhttps://codesandbox.io/s/react-chartjs-2-example-j8il1\r\n\r\nMore generally, you could also serialize the data, combine other keys, etc - whatever suits your case.\r\n\r\nHope this helps.", "title": null, "type": "comment" }, { "action": "created", "author": "ottworks", "comment_id": 650349082, "datetime": 1593198598000, "masked_author": "username_0", "text": "They are the same datasets, so they have the same labels. The differences in properties are to be animated between when pressing the button, which does not work correctly.", "title": null, "type": "comment" }, { "action": "created", "author": "owen-duncan-snobel", "comment_id": 657188760, "datetime": 1594540889000, "masked_author": "username_2", "text": "I have a fix for you. All you need to add to the line component is 'redraw' it forces a reset of the canvas and will fix the behaviour check out the code pen.\r\n\r\nhttps://codesandbox.io/s/react-chartjs-2-example-cn8dl?file=/src/index.js\r\n<Line redraw/>", "title": null, "type": "comment" }, { "action": "created", "author": "ottworks", "comment_id": 657258805, "datetime": 1594578723000, "masked_author": "username_0", "text": "That will break animated transitions between graphs.", "title": null, "type": "comment" }, { "action": "created", "author": "owen-duncan-snobel", "comment_id": 657261538, "datetime": 1594580320000, "masked_author": "username_2", "text": "Okay, I understand. Well when you are swapping between the two you set background colour for one and border colour for the other so I added a blank border colour attribute to the first dataset and it will reset it to null on each switch.\r\n\r\nhttps://codesandbox.io/s/react-chartjs-2-example-cn8dl?file=/src/index.js\r\n\r\nLet me know if this is the intended behaviour.", "title": null, "type": "comment" }, { "action": "created", "author": "maxwell-oroark", "comment_id": 798717328, "datetime": 1615658775000, "masked_author": "username_3", "text": "Perhaps even more alarmingly, pollution of props also occurs when the length of the data array being passed changes. I have two time series datasets that render conditionally based on a prop, when I initially load dataset A the chart has the correct amount of data points being rendered on the map. props update to render dataset B and the chart updates to the correct new amount of data points, go back to dataset A and the chart tries to fit the data into the length of dataset B. I'll try and create a sandbox to illustrate.\r\n\r\nWill also try this datasetKeyProvider thing and see if that rectifies.", "title": null, "type": "comment" }, { "action": "created", "author": "maxwell-oroark", "comment_id": 798789987, "datetime": 1615671631000, "masked_author": "username_3", "text": "Does anyone know why this code sandbox doesn't update the Line chart at all?\r\nhttps://codesandbox.io/s/react-chartjs-2-example-forked-pb84t?fontsize=14&hidenavigation=1&theme=dark", "title": null, "type": "comment" }, { "action": "created", "author": "owen-duncan-snobel", "comment_id": 798805485, "datetime": 1615680528000, "masked_author": "username_2", "text": "You have to add the prop \"redraw\" to the component ex. <Line redraw options={...} /> It is just the behaviour of how the canvas works at the time of the component mounting in react.", "title": null, "type": "comment" } ]
4
9
2,883
false
false
2,883
false
microsoft/vscode-python
microsoft
567,037,597
10,173
null
[ { "action": "opened", "author": "IanMatthewHuff", "comment_id": null, "datetime": 1582045912000, "masked_author": "username_0", "text": "I have not root caused this yet, but here is what I'm seeing. On my development machine I'm seeing lots of repeat entries for my most commonly used kernels. I've never explicitly created a kernel on this machine just using our normal interpreter -> kernel creation process. As of right now here is what part of my kernel selection list looks like:\r\n![image](https://user-images.githubusercontent.com/812783/74759986-8ca7c580-522e-11ea-95cd-1085937f1c75.png)\r\n\r\nHere is my jupyter kernelspec list:\r\n```\r\nAvailable kernels:\r\n 8cc2130c-3b07-4e16-b6bf-5b1720182200 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\8cc2130c-3b07-4e16-b6bf-5b1720182200\r\n c0d0482c-0054-45d8-a16a-58e5411c533b C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\c0d0482c-0054-45d8-a16a-58e5411c533b\r\n python271664bite918c0506ca94f42a192013c578bb239 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python271664bite918c0506ca94f42a192013c578bb239\r\n python271664bitianhu27conda718271b3694a4b9e934d79334b884b3b C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python271664bitianhu27conda718271b3694a4b9e934d79334b884b3b\r\n python36664bit22e24328980b4b079af05aadf45daa3c C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python36664bit22e24328980b4b079af05aadf45daa3c\r\n python36864bitianhu36conda90b1c433727b40db816a7cbb833bbfa2 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python36864bitianhu36conda90b1c433727b40db816a7cbb833bbfa2\r\n python37264bit078c59b98ae040019a415d732bdf82df C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit078c59b98ae040019a415d732bdf82df\r\n python37264bit090b0b09d8844c789860451f8ade94ab C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit090b0b09d8844c789860451f8ade94ab\r\n python37264bit350e7cd1000f4c668a8d28abe86e0d58 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit350e7cd1000f4c668a8d28abe86e0d58\r\n python37264bit426656d91a9b442ea154d2957dfdc51f C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit426656d91a9b442ea154d2957dfdc51f\r\n python37264bit4ad5611cad964b85ac2dbd34aeaeec5c C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit4ad5611cad964b85ac2dbd34aeaeec5c\r\n python37264bit664d92e05e5f421d974734f8c3219d65 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit664d92e05e5f421d974734f8c3219d65\r\n python37264bit66a3422d540b4d4391cd8be561a41c12 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit66a3422d540b4d4391cd8be561a41c12\r\n python37264bit70dbdd712310438196ebde96aae150e4 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit70dbdd712310438196ebde96aae150e4\r\n python37264bit82cef949d57f412f9f47812a49ec6736 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bit82cef949d57f412f9f47812a49ec6736\r\n python37264bitde08df994ba84ca094ceaa7d74c34704 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bitde08df994ba84ca094ceaa7d74c34704\r\n python37264bite84de39e8fbb42de98967d25a8b0ad9a C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37264bite84de39e8fbb42de98967d25a8b0ad9a\r\n python37364bitab002188b8f9437588d72802d8927ca6 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitab002188b8f9437588d72802d8927ca6\r\n python37364bitbaseconda46106d1f28ea41d7a685fea4e1c0eb24 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbaseconda46106d1f28ea41d7a685fea4e1c0eb24\r\n python37364bitbaseconda82bdf59dbd9e40ab95e940888577e275 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbaseconda82bdf59dbd9e40ab95e940888577e275\r\n python37364bitbasecondadc3c706875e147cdac8252b9213d844c C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbasecondadc3c706875e147cdac8252b9213d844c\r\n python37364bitbasecondae6af1a663d454a468ccc14a2aa8eeb0b C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbasecondae6af1a663d454a468ccc14a2aa8eeb0b\r\n python37364bitbasecondaf6e81c11dda649728b025bf6c7a41828 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbasecondaf6e81c11dda649728b025bf6c7a41828\r\n python37364bitbasecondafece0224d1cb416f9e88e44510c74524 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitbasecondafece0224d1cb416f9e88e44510c74524\r\n python37364bitianhu37condab6e11791083146b7bec6d6d2d4db2d36 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitianhu37condab6e11791083146b7bec6d6d2d4db2d36\r\n python37364bitianhu37condacbe3ef6a741f43c683631b4fa81cfc4f C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitianhu37condacbe3ef6a741f43c683631b4fa81cfc4f\r\n python37364bitvirtualenv398731b4291f407f89336ded48b0232f C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37364bitvirtualenv398731b4291f407f89336ded48b0232f\r\n python37664bitbadservervenv692004fb3a0f47ae98ae85fbe9592954 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37664bitbadservervenv692004fb3a0f47ae98ae85fbe9592954\r\n python37664bitcleancondaca80d6af82ee4be9991f47a8b28777b7 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37664bitcleancondaca80d6af82ee4be9991f47a8b28777b7\r\n python37664bitenvvenv72d95196005c408e81f9a61ae98d927d C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37664bitenvvenv72d95196005c408e81f9a61ae98d927d\r\n python37664bittensorflowconda0cacd79e053f4ab1bbfc4bb6059e4f73 C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37664bittensorflowconda0cacd79e053f4ab1bbfc4bb6059e4f73\r\n python37664bittfenvvenv42c6257f362f4c56889cf2ae42e89ada C:\\Users\\ianhu\\AppData\\Roaming\\jupyter\\kernels\\python37664bittfenvvenv42c6257f362f4c56889cf2ae42e89ada\r\n python3 C:\\AnacondaNew\\share\\jupyter\\kernels\\python3\r\n```", "title": "Multiple entries in kernel selection list", "type": "issue" }, { "action": "closed", "author": "greazer", "comment_id": null, "datetime": 1582586419000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
5,971
false
false
5,971
false
SpoonLabs/gumtree-spoon-ast-diff
SpoonLabs
624,067,713
125
null
[ { "action": "opened", "author": "martinezmatias", "comment_id": null, "datetime": 1590386587000, "masked_author": "username_0", "text": "# Summary of the problem\r\n\r\nThe ActionClassifier (probably, IMO) produces an incorrect outputs when **Updates** operations are the **root** operations. \r\n\r\n# Description of the problem:\r\n\r\nThere are two mains problems.\r\n\r\nFirst, when we have two operations: 1) update on node X and 2) an Insert of Y on X (i.e., Y is a new child of X), the roots operation only shows 1 action: the update. \r\nIMO, That is incorrect: as we discussed in a[ previous issue ](https://github.com/SpoonLabs/gumtree-spoon-ast-diff/issues/114) (roots of multiple updates), updates should not be grouped (in this case with Insert)\r\n\r\nOne example is:\r\n```\r\n- int xxxxxx1 = foo001(0) ;\r\n+ int xxxxxx1 = foo002(0,1)\r\n```\r\nRoots is only one: [Update Invocation at X:1 foo001(0) to foo002(0, 1)]\r\nAll actions are 2: [Update Invocation at X:1 foo001(0) to foo002(0, 1), Insert Literal at X:1 1]\r\n\r\n\r\nSecond related problem.\r\nIn the previous case, the inserted node (literal 1) is a child of the updated node (foo001).\r\nHowever, if we consider a slightly different example, the ActionClassifier's behaviour is different.\r\n\r\n```\r\n- int xxxxxx1 = foo001(0) ;\r\n+ int xxxxxx2 = foo001(0,1);\r\n\r\n```\r\nHere, we update the var name instead of the invoked method name (and we always insert a new parameter).\r\n\r\nThe root operation there are 2: \r\nUpdate LocalVariable at X:1 int xxxxxx1 = foo001(0) to int xxxxxx2 = foo001(0, 1) , Insert Literal at X:1 1 ] \r\n\r\n(in the previous example the roots is only 1).\r\n\r\nThe difference of behaviour is caused by in [this line ](https://github.com/SpoonLabs/gumtree-spoon-ast-diff/blob/master/src/main/java/gumtree/spoon/diff/ActionClassifier.java#L77): the classifier checks if the parent of an action was updated. In this case, the parent of the Insert was not updated (but the grandparent (xxxxxx1) was).\r\n\r\n\r\n# Solution proposed\r\n\r\nIgnore Updates in Root classification. IMH, Updates are atomic ops that only affect one single node.\r\nThat would solve the two previous issues.", "title": "[bug] Potential Incorrect behaviour of ActionClassifier when computing roots actions", "type": "issue" }, { "action": "created", "author": "martinezmatias", "comment_id": 638023121, "datetime": 1591170360000, "masked_author": "username_0", "text": "Actually, one of the problem is when a change (e.g., Insert) also produces that a label of a parent node is updated.\r\nFor example: `test_t_223454'\r\n + ( new File(filePath, fileName), \"UTF-8\" );\r\n - ( new File(filePath, fileName) );\r\n\r\nThere, the remove of the Literal produces an update of the ConstructorCall (which label is the signature of the executable). \r\nIn this case, It could make sense to \"hide\" the Delete i.e., the Delete is not considered as Root. But I am not sure if in all cases.", "title": null, "type": "comment" }, { "action": "created", "author": "martinezmatias", "comment_id": 638027078, "datetime": 1591170797000, "masked_author": "username_0", "text": "A different case would be if you have an update of Method's name and an insert on its body: \r\nThere, it will show only one root: the update.", "title": null, "type": "comment" }, { "action": "created", "author": "slarse", "comment_id": 852982001, "datetime": 1622636627000, "masked_author": "username_1", "text": "Just for context, I'm approaching this from the perspective of applying operations from gumtree-spoon to an AST model (i.e. applying an edit script).\r\n\r\nI agree with the idea that updates are atomic operations on labels in GumTree. But when this is translated to Spoon, it's not that simple. If I get an update operation from gumtree-spoon, the only information I get is the source node and destination node, but there's no indication of exactly what was updated as the concept of labels doesn't carry over to Spoon. Given only that information, I think it's confusing to not include update operations in root operations, because from an API perspective an update kind of looks like a root operation, if that makes sense.\r\n\r\nA potential solution there would be to also include the role of the item that was updated. That would give sufficient information to allow for finding the updated \"thing\". For example, given that we update the name of a method, the update operation contains the source and destination nodes, as well as `CtRole.NAME`. To me, with that information it would make sense to treat update operations as orthogonal to root operations. Any idea if that would be feasible to implement?", "title": null, "type": "comment" }, { "action": "created", "author": "martinezmatias", "comment_id": 853020261, "datetime": 1622639905000, "masked_author": "username_0", "text": "Just an idea: What about to only consider the update of CtNamedElement? This would simplify the application of partial diffs into the source tree.\r\n(However, I dont have any idea about that to do with updates of VirtualElements i.e., update of modifiers).", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 853036416, "datetime": 1622641135000, "masked_author": "username_2", "text": "I think I have a case which will be an exemption to this. Consider an update from `int x = a + b` to `int x = a - b`. That should qualify as an update but it won't come under `CtNamedElement`. So I agree with @username_1 that `CtRole` should also be passed along with `src` and `dst` nodes. `CtRole.OPERATOR_KIND` can used to identify the operator and update it to `-`.", "title": null, "type": "comment" }, { "action": "created", "author": "slarse", "comment_id": 853039698, "datetime": 1622641405000, "masked_author": "username_1", "text": "That simplicity would be very neat from the use case of applying edit scripts, as @username_2 suggest I think we lose some amount of precision there.\r\n\r\nAs for virtual elements, I'm not sure. The fact that modifiers aren't proper nodes is just an eternal bother :(\r\n\r\nI'll consider this. I think the only way for all of this to make sense is to, as you suggest, dislodge the concept of update operations from root operations. Perhaps the best way to move forward here is that @username_2 and I just try to work out a solution that works for applying edit scripts, and then we'll get back to you with some new thoughts.", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 864620236, "datetime": 1624228250000, "masked_author": "username_2", "text": "I had a go at this problem with what both of you suggested. Might be a good thing to go ahead with if we don't have a lot of roles to care about. Let me elaborate in the steps below.\r\n\r\n1. Removed the check in `del` and `add` trees [(`getRootActions`)](https://github.com/SpoonLabs/gumtree-spoon-ast-diff/blob/master/src/main/java/gumtree/spoon/diff/ActionClassifier.java#L76) for parent node in update trees.\r\n ```diff\r\n - .filter(t -> !srcDelTrees.contains(t.getParent()) && !srcUpdTrees.contains(t.getParent()))\r\n + .filter(t -> !srcDelTrees.contains(t.getParent()))\r\n ```\r\n ```diff\r\n - .filter(t -> !dstAddTrees.contains(t.getParent()) && !dstUpdTrees.contains(t.getParent()))\r\n + .filter(t -> !dstAddTrees.contains(t.getParent()))\r\n ```\r\n This will ensure that insert/delete operation does not get ignored just because they are applied to a node which is a child of an `update`d node.\r\n\r\n2. Add API for returning `CtRole` in [`UpdateOperation`](https://github.com/SpoonLabs/gumtree-spoon-ast-diff/blob/master/src/main/java/gumtree/spoon/diff/operations/UpdateOperation.java#L8)\r\n ```diff\r\n public UpdateOperation(Update action) {\r\n super(action);\r\n \t destElement = (CtElement) action.getNode().getMetadata(SpoonGumTreeBuilder.SPOON_OBJECT_DEST);\r\n +\t if (destElement instanceof CtBinaryOperator<?>) {\r\n +\t \trole = CtRole.OPERATOR_KIND;\r\n +\t } else {\r\n +\t\trole = CtRole.NAME;\r\n +\t }\r\n }\r\n ```\r\n `role` is a `private` field in the `UpdateOperation` class.\r\n\r\nThe problem with this approach is that we will have to analyse many spoon elements for assigning the correct role. On the upside, there may not be a large number of elements that can be updated. Following this approach, we can use the `CtRole` to get the value from `dstNode` and set it on the `srcNode` using `getValueByRole` and `setValueByRole` respectively in `diffmin`. Following is a list of elements I have come across till now.\r\n- `CtLiteral`\r\n ```diff\r\n - System.out.println(4+8);\r\n + System.out.println(10000+8);\r\n ```\r\n `setValueByRole(CtRole.VALUE, dstNode.getValueByRole(CtRole.VALUE))`\r\n- `CtBinaryOperator`\r\n ```diff\r\n - System.out.println(4-4);\r\n + System.out.println(4+4); \r\n ```\r\n `setValueByRole(CtRole.OPERATOR_KIND, dstNode.getValueByRole(CtRole.OPERATOR_KIND))`\r\n- `CtInvocation`\r\n ```diff\r\n - System.out.println(1);\r\n + System.exit(1);\r\n ```\r\n This yields three operations.\r\n 1. Update Invocation\r\n 2. Delete FieldRead\r\n 3. Insert TypeAccess\r\n So I am not sure how to go about this because `UpdateOperation` does not make sense here. But if we really want to use it (for diffs like `System.out.println()` -> `System.out.print()`), we could probably update values of `CtRole.TARGET` and `CtRole.EXECUTABLE_REF`.\r\n- `CtMethod`\r\n ```diff\r\n - public void add() { }\r\n + public void multiply() { }\r\n ```\r\n `setValueByRole(CtRole.NAME, dstNode.getValueByRole(CtRole.NAME))` (valid for return types too)\r\n I have a feeling that many entities will fall under `CtRole.NAME`.", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 874016976, "datetime": 1625482494000, "masked_author": "username_2", "text": "@username_1 Did you get time to go through the above comment?", "title": null, "type": "comment" }, { "action": "created", "author": "slarse", "comment_id": 874029882, "datetime": 1625483667000, "masked_author": "username_1", "text": "It seems largely reasonable. What I can add is:\r\n\r\n* With this model, `UpdateOperation` should not at all be a root operation, so `getRootOperations()` should not return any update operations\r\n* Therefore, it would probably be most convenient to add a `getUpdateOperations()` method\r\n\r\n\r\nAs for the update from `System.out.println()` to `System.exit()`, isn't that just the name of the called method that is updated? I.e. `println() -> exit()`? The deleted field read is probably a deletion of reading `System.out`, replaced with a type access to `System`. If those are the operations, it does make sense.\r\n\r\n```\r\nSystem.out.println(1);\r\nSystem.out.exit(1); // update println -> exit\r\nexit(1); // delete field read\r\nSystem.exit(1); // insert type access\r\n```\r\n?", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 874144159, "datetime": 1625494259000, "masked_author": "username_2", "text": "It makes sense to me now too. Instead of it making sense, I think I meant it was unnecessary because `Delete FieldRead` and `Insert TypeAccess` could have combined into one update operation and we could handle it using `CtRole.TARGET`.", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 1008754325, "datetime": 1641812148000, "masked_author": "username_2", "text": "If we follow this approach to update spoon nodes, we shall only be updating the value corresponding to a specific role. We would be skipping the update of the source position of the element since we no longer \"replace\" elements instead we just updated their so-called labels. I am not sure if that would affect `diffmin`. It would definitely fail `ElementOriginTest`, but we just need to modify it for update operations. Other than that, I don't think so it would affect the functionality as of now.", "title": null, "type": "comment" }, { "action": "created", "author": "algomaster99", "comment_id": 1015663414, "datetime": 1642528177000, "masked_author": "username_2", "text": "@username_0 I needed to confirm what is the expected behavior of the classifier in the examples you have proposed above.\r\n```diff\r\n- int xxxxxx1 = foo001(0) ;\r\n+ int xxxxxx1 = foo002(0,1)\r\n```\r\nShould this have an update operation (`foo1` -> `foo2`) and insertion of literal `1` as root operations?\r\n\r\nIn more general terms, **any operation on any children node of an updated node should not be ignored.**", "title": null, "type": "comment" } ]
3
13
10,088
false
false
10,088
true
Lambda-School-Labs/Labs25-SaverLife-TeamC-ds
Lambda-School-Labs
691,270,236
3
{ "number": 3, "repo": "Labs25-SaverLife-TeamC-ds", "user_login": "Lambda-School-Labs" }
[ { "action": "opened", "author": "Vanagand", "comment_id": null, "datetime": 1599068981000, "masked_author": "username_0", "text": "## Description\r\n\r\n- [chore] Added a front administrator dashboard template for API navigation.\r\n\r\n- [chore] Refactor documentation endpoints in both Swagger UI, and Redoc templates.\r\n - Removed sample endpoints from project scaffolding\r\n - Added endpoint to query database\r\n - Added miscellaneous endpoints to navigate through dashboard\r\n\r\n- [feature] Added a python script to generate user sample data.\r\n - User ID tables\r\n - User TXN tables\r\n\r\n\r\n## Deployment\r\n- [x] Local\r\n- [x] Docker\r\n- [ ] AWS", "title": "Dashboard, documentation-endpoints, and sample_generator 0.1", "type": "issue" }, { "action": "created", "author": "Vanagand", "comment_id": 685897539, "datetime": 1599069042000, "masked_author": "username_0", "text": "![](https://github.trello.services/images/mini-trello-icon.png) [Create sample generator function](https://trello.com/c/n8q7b465/65-create-sample-generator-function)", "title": null, "type": "comment" } ]
1
2
679
false
false
679
false
kubernetes/test-infra
kubernetes
678,421,434
18,820
{ "number": 18820, "repo": "test-infra", "user_login": "kubernetes" }
[ { "action": "opened", "author": "jayunit100", "comment_id": null, "datetime": 1597323893000, "masked_author": "username_0", "text": "Velodrom no longer exists :)", "title": "Remove velodrome links", "type": "issue" }, { "action": "created", "author": "jayunit100", "comment_id": 674599537, "datetime": 1597623912000, "masked_author": "username_0", "text": "sure, done", "title": null, "type": "comment" }, { "action": "created", "author": "chases2", "comment_id": 675034878, "datetime": 1597688207000, "masked_author": "username_1", "text": "/retest", "title": null, "type": "comment" }, { "action": "created", "author": "MushuEE", "comment_id": 676530052, "datetime": 1597854596000, "masked_author": "username_2", "text": "/lgtm", "title": null, "type": "comment" }, { "action": "created", "author": "BenTheElder", "comment_id": 676601030, "datetime": 1597863286000, "masked_author": "username_3", "text": "/approve", "title": null, "type": "comment" } ]
5
9
4,510
false
true
58
false
ClickHouse/ClickHouse
ClickHouse
654,476,268
12,376
{ "number": 12376, "repo": "ClickHouse", "user_login": "ClickHouse" }
[ { "action": "opened", "author": "alexey-milovidov", "comment_id": null, "datetime": 1594350558000, "masked_author": "username_0", "text": "Changelog category (leave one):\r\n- Bug Fix\r\n\r\n\r\nChangelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):\r\nFix TOTALS/ROLLUP/CUBE for aggregate functions with `-State` and `Nullable` arguments. This fixes #12163.", "title": "Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments", "type": "issue" }, { "action": "created", "author": "alexey-milovidov", "comment_id": 656456582, "datetime": 1594350823000, "masked_author": "username_0", "text": "This also wrong:\r\n```\r\nSELECT uniqStateForEach([1, NULL]) WITH TOTALS\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "alexey-milovidov", "comment_id": 656789922, "datetime": 1594401602000, "masked_author": "username_0", "text": "I recommend @akuzm @KochetovNicolai @CurtizJ just to take a look - this is really weird issue in managing of aggregation states.", "title": null, "type": "comment" } ]
1
3
450
false
false
450
false
bilelmoussaoui/flatpak-github-actions
null
584,843,594
4
{ "number": 4, "repo": "flatpak-github-actions", "user_login": "bilelmoussaoui" }
[ { "action": "opened", "author": "nahuelwexd", "comment_id": null, "datetime": 1584680000000, "masked_author": "username_0", "text": "I had no idea what to title, so I put that on.\r\n\r\nThis PR corrects some errors that caused the action not to work correctly. Also, it converts the action from being a Docker Action to being a Javascript Action, that way it is able to start a Docker container with the necessary permissions so that Flatpak can compile at full speed with fuse activated.\r\n\r\nI took the liberty of making some modifications to the entrypoint.sh as well, to add the new proposals from the DevOps with Flatpak Initiative that is currently used in the GNOME apps on GitLab. As a side effect of this, this action will no longer clone the repository from the URL provided in the manifest, but will instead use the repo from which it is invoked. The idea is that this is also combined with a caching of the `.flatpak-builder/{git,downloads}` folders to prevent the CI from slowing down with unnecessary download tasks.\r\n\r\nI am currently using a small copy that I made for my own project, and it works perfectly. This copy is distributed in:\r\n- Docker image: https://github.com/username_0/flatpak-docker\r\n- GitHub Action: https://github.com/username_0/flatpak-builder-action\r\n- Project it is working on: https://github.com/username_0/unitube-gtk\r\n\r\nNote: Another side effect of this change is that now you will be required to create specific Docker image tags for each of the platforms: FreeDesktop, GNOME, KDE, etc. since this will no longer download the runtimes from Flathub", "title": "DevOps Flatpak revolution", "type": "issue" }, { "action": "created", "author": "bilelmoussaoui", "comment_id": 601656323, "datetime": 1584704260000, "masked_author": "username_1", "text": "Wow great job =) I will look into the rest of the code as soon as I can.", "title": null, "type": "comment" }, { "action": "created", "author": "bilelmoussaoui", "comment_id": 601842504, "datetime": 1584727931000, "masked_author": "username_1", "text": "Do you have any idea why the test build fails?", "title": null, "type": "comment" }, { "action": "created", "author": "nahuelwexd", "comment_id": 601886369, "datetime": 1584734421000, "masked_author": "username_0", "text": "The test build should now be in a full repository of an app, not here", "title": null, "type": "comment" }, { "action": "created", "author": "nahuelwexd", "comment_id": 601947273, "datetime": 1584745626000, "masked_author": "username_0", "text": "Well, I added a little project that should make the tests pass, but you need to update the Docker image or they will still failing", "title": null, "type": "comment" }, { "action": "created", "author": "bilelmoussaoui", "comment_id": 602485063, "datetime": 1584956358000, "masked_author": "username_1", "text": "Right, make sense. Thanks a lot! so we need to provide docker images for each runtime? :) that's a lot of images to maintain, I'm wondering if we should automate that using a github action too", "title": null, "type": "comment" }, { "action": "created", "author": "nahuelwexd", "comment_id": 602830232, "datetime": 1584994344000, "masked_author": "username_0", "text": "Yes, it also will avoid the need to download the runtimes every single time", "title": null, "type": "comment" }, { "action": "created", "author": "bilelmoussaoui", "comment_id": 609070296, "datetime": 1586024943000, "masked_author": "username_1", "text": "Makes sense, what I thought of is keeping the dockerfile's here and just use a github action to build and publish them. To make it easier to contribute to the action/images :)", "title": null, "type": "comment" } ]
2
8
2,209
false
false
2,209
true
AY2021S1-CS2103T-T17-4/tp
AY2021S1-CS2103T-T17-4
733,315,612
173
null
[ { "action": "closed", "author": "JoeyToh", "comment_id": null, "datetime": 1604681499000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
2
374
false
true
0
false
tidyverse/readr
tidyverse
628,610,820
1,102
null
[ { "action": "opened", "author": "jmcloughlin", "comment_id": null, "datetime": 1591033059000, "masked_author": "username_0", "text": "I've tried several variations of installing RCpp and readr separately, explicitly (or not) specifying they be from source, on latest openbsd snapshot after a clean installation of R, but readr always fails. Any suggestion on how to resolve this? It seems closely related to #1008.\r\n\r\nAfter successfully installing RCpp from source as well as the other tidyverse dependcies pull in by readr, \r\n\r\n```r\r\nsessionInfo()\r\nR version 4.0.0 (2020-04-24)\r\nPlatform: x86_64-unknown-openbsd6.7 (64-bit)\r\nRunning under: OpenBSD puffyx1.my.domain 6.7 GENERIC.MP#234 amd64\r\n\r\nMatrix products: default\r\nBLAS: /usr/local/lib/R/lib/libRblas.so.37.0\r\nLAPACK: /usr/local/lib/R/lib/libRlapack.so.37.0\r\n\r\nlocale:\r\n[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8\r\n\r\nattached base packages:\r\n[1] stats graphics grDevices utils datasets methods base \r\n\r\nloaded via a namespace (and not attached):\r\n[1] compiler_4.0.0\r\n```\r\nAnd the error message (excerpting most of the compiling) is:\r\n\r\n```r\r\ninstall.packages(c(\"readr\"), repos = \"http://lib.stat.cmu.edu/R/CRAN/\")\r\nInstalling package into โ€˜/home/me/R/x86_64-unknown-openbsd6.7-library/4.0โ€™\r\n(as โ€˜libโ€™ is unspecified)\r\ntrying URL 'http://lib.stat.cmu.edu/R/CRAN/src/contrib/readr_1.3.1.tar.gz'\r\nContent type 'application/x-gzip' length 268853 bytes (262 KB)\r\n==================================================\r\ndownloaded 262 KB\r\n\r\n* installing *source* package โ€˜readrโ€™ ...\r\n** package โ€˜readrโ€™ successfully unpacked and MD5 sums checked\r\n** using staged installation\r\n** libs\r\nc++ -std=gnu++11 -I\"/usr/local/lib/R/include\" -DNDEBUG -I'/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/Rcpp/include' -I'/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/BH/include' -I/usr/local/include -I. -Ircon -fpic -O2 -pipe -c Collector.cpp -o Collector.o\r\n...\r\n...\r\n...\r\ncc -I\"/usr/local/lib/R/include\" -DNDEBUG -I'/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/Rcpp/include' -I'/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/BH/include' -I/usr/local/include -fpic -O2 -pipe -c rcon/connection.c -o rcon/connection.o\r\nmkdir -p ../inst/rcon\r\nc++ -std=gnu++11 -shared -L\"/usr/local/lib/R/lib\" -L/usr/local/lib -Wl,-R/usr/local/lib/R/lib -o ../inst/rcon/librcon.so rcon/connection.o\r\nc++ -std=gnu++11 -shared -L/usr/local/lib/R/lib -L/usr/local/lib -Wl,-R/usr/local/lib/R/lib -o readr.so Collector.o CollectorGuess.o Iconv.o LocaleInfo.o RcppExports.o Reader.o Source.o Tokenizer.o TokenizerDelim.o TokenizerFwf.o TokenizerWs.o connection.o datetime.o grisu3.o init.o localtime.o parse.o read.o type_convert.o write.o write_connection.o write_delim.o -L. -lrcon -L../inst/rcon -Wl,-rpath,$ORIGIN/../rcon -L/usr/local/lib/R/lib -lR\r\ninstalling via 'install.libs.R' to /home/me/R/x86_64-unknown-openbsd6.7-library/4.0/00LOCK-readr/00new/readr\r\n** R\r\n** inst\r\n** byte-compile and prepare package for lazy loading\r\n** help\r\n*** installing help indices\r\n*** copying figures\r\n** building package indices\r\n** installing vignettes\r\n** testing if installed package can be loaded from temporary location\r\nError: package or namespace load failed for โ€˜readrโ€™ in dyn.load(file, DLLpath = DLLpath, ...):\r\n unable to load shared object '/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/00LOCK-readr/00new/readr/libs/readr.so':\r\n Cannot load specified object\r\nError: loading failed\r\nExecution halted\r\nERROR: loading failed\r\n* removing โ€˜/home/me/R/x86_64-unknown-openbsd6.7-library/4.0/readrโ€™\r\n\r\nThe downloaded source packages are in\r\n โ€˜/tmp/Rtmpqvf15G/downloaded_packagesโ€™\r\nWarning message:\r\nIn install.packages(c(\"readr\"), repos = \"http://lib.stat.cmu.edu/R/CRAN/\") :\r\n installation of package โ€˜readrโ€™ had non-zero exit status\r\n```\r\n\r\nApologies for the lack of proper reprex formatting: pandoc is not available on OpenBSD (yes I want to use OpenBSD!), and thanks for any help.", "title": "recurrence of readr install failure on OpenBSD", "type": "issue" }, { "action": "created", "author": "jimhester", "comment_id": 637027660, "datetime": 1591035799000, "masked_author": "username_1", "text": "try installing the development version of readr, I think it is likely to work.\r\n\r\n```r\r\nremotes::install_github(\"tidyverse/readr\")\r\n```", "title": null, "type": "comment" }, { "action": "closed", "author": "jmcloughlin", "comment_id": null, "datetime": 1591036353000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "jmcloughlin", "comment_id": 637032123, "datetime": 1591036360000, "masked_author": "username_0", "text": "Indeed that did the trick! Many thanks!", "title": null, "type": "comment" } ]
2
4
4,005
false
false
4,005
false
hapipal/hecks
hapipal
713,510,918
11
{ "number": 11, "repo": "hecks", "user_login": "hapipal" }
[ { "action": "opened", "author": "Nargonath", "comment_id": null, "datetime": 1601633797000, "masked_author": "username_0", "text": "", "title": "Use travis shareable config (#9)", "type": "issue" }, { "action": "created", "author": "Nargonath", "comment_id": 702648365, "datetime": 1601633832000, "masked_author": "username_0", "text": "Linked to issue #9", "title": null, "type": "comment" }, { "action": "created", "author": "Nargonath", "comment_id": 702715574, "datetime": 1601643003000, "masked_author": "username_0", "text": "I closed this PR because I figured I might just tackle everything needed to publish the new version rather than just updating the travis config. I'll make another PR when ready.", "title": null, "type": "comment" } ]
2
4
496
false
true
195
false
stepmania/stepmania
stepmania
646,495,845
2,030
{ "number": 2030, "repo": "stepmania", "user_login": "stepmania" }
[ { "action": "opened", "author": "sillybear", "comment_id": null, "datetime": 1593203436000, "masked_author": "username_0", "text": "Renamed GetTapNoteScores and GetHoldNoteScores to match with HighScore, Player and NoteTypes methods.", "title": "Rename 2 PlayerStageStats methods", "type": "issue" }, { "action": "created", "author": "quietly-turning", "comment_id": 650436388, "datetime": 1593211565000, "masked_author": "username_1", "text": "Thanks for this pull request, @username_0. I appreciate your efforts to make SM's code more consistent.\r\n\r\nI checked themes I have installed on my local dev machine. The changes proposed in this pull request would break compatibility with many current themes, including but not limited to:\r\n\r\n* SM5.1 default\r\n* SM5.1 legacy\r\n* CyberiaStyle LAST APPROACH\r\n* CyberiaStyle 8\r\n* DDR 2013 (G2008&strider)\r\n* DDRA (KENP_Mod)\r\n* DDR 2014 (Risk&pkwp)\r\n* DDRNG (Risk)\r\n* ITG3 (freem's port)\r\n* MetroQuadX (Ov3rHell3XoduZ)\r\n* MGD3 (MadkaT's port)\r\n* moonlight (freem)\r\n* optical (username_2)\r\n* Simply Love (username_1)\r\n* STARLiGHT (SilverDragon754, Inorizushi, Midflight Digital)\r\n* TIMERiFT (Lirodon)\r\n* Touhou Hisoutensoku (Jousway)\r\n* Ultimate (Luizsan)\r\n* waiei\r\n* waiei2\r\n\r\n(Some of these themes are no longer publicly available. And, as always, it's possible more current versions of these themes exist, where your proposed changes would not break compatibility.)\r\n\r\nI am *strongly* in favor of maintaining backwards compatibility for the sake making things easier on the player community. The changes here, as is, would break compatibility with current themes (and possibly scripted simfiles).\r\n\r\nWhat are your thoughts on this?", "title": null, "type": "comment" }, { "action": "created", "author": "sillybear", "comment_id": 650538730, "datetime": 1593253677000, "masked_author": "username_0", "text": "They should provide patches for these. The screens affected are mostly ScreenSelectMusic, ScreenStageInformations, and any ScreenEvaluation-based screens. They should be easy to update by just find and replace the text. Maybe someone should make a ziv thread fir providing third party theme patches if ever the source thene threads are inactive.\r\n\r\nThe reason why i proposed this is because it's awkward to make a duplicate global function that uses pss and the only difference is that NoteScore methods are in plural form. We used *Scores when in fact we are asking for just one score for each TNS/HNS.\r\n\r\nIn my experience, the original methods also brought confusion as to why some aren't working and it took me time to realize that they should be in plural form even if I asked only the individual score.", "title": null, "type": "comment" }, { "action": "created", "author": "shakesoda", "comment_id": 650589821, "datetime": 1593279294000, "masked_author": "username_2", "text": "i'd be okay with this if it still exposed the old names, but as it stands, i'm not going to break every theme on 5.1 in the name of consistent plural/singular naming.", "title": null, "type": "comment" } ]
3
4
2,309
false
false
2,309
true
IBM/carbon-components-angular
IBM
588,144,731
1,151
null
[ { "action": "opened", "author": "abhisheksinghrana", "comment_id": null, "datetime": 1585196607000, "masked_author": "username_0", "text": "There are lot of setTimeout and message handler issues are coming while scrolling table component because of that page gets hanged or sometime start responding slowly.\r\n\r\n<img width=\"880\" alt=\"violation issue\" src=\"https://user-images.githubusercontent.com/29912424/77610024-90261f00-6f47-11ea-99e8-d8ef75b800c7.png\">", "title": "Table component - setTimeout and message handler violation issues", "type": "issue" }, { "action": "created", "author": "cal-smith", "comment_id": 629379180, "datetime": 1589563024000, "masked_author": "username_1", "text": "Hey @username_0 sorry this has taken so long, we've been pretty swamped with some of the v4/v11 work ... I did some preliminary testing, and it does seem like as the rows increase some of the interactions do slow down quite significantly. That being said, in order for it to slow down to a noticeable degree I had to add quite a few rows - have you explored using pagination as a way to reduce the number of rows visible on screen?", "title": null, "type": "comment" }, { "action": "created", "author": "asudoh", "comment_id": 629532798, "datetime": 1589581774000, "masked_author": "username_2", "text": "Weighing in and @username_1 has a good point. Another suggestion I have for the issue author is following below steps:\r\n\r\n1. Go to Performance tab\r\n2. Hit the Record (icon) button\r\n3. Run the use case that shows the console log in question\r\n4. Click on the Stop button\r\n5. Hit the Save profile (icon) button and select the download location\r\n6. Post the downloaded file here\r\n\r\n![performance-tab-1](https://user-images.githubusercontent.com/1259051/82101142-a29e2700-9746-11ea-813b-d18c23cb87a9.gif)\r\n\r\nIn this way, the team can have much clearer insight of what the offending code is, without having to spending time to guess how to re-create the performance problem. Hope this helps!\r\n\r\nBTW agreed with @username_1 that pagination is a \"must\" for ensuring performance. Without it, the page can have excessive amount of DOM nodes that Carbon Angular library would have no control over for the performance.", "title": null, "type": "comment" }, { "action": "created", "author": "ninja511", "comment_id": 656187066, "datetime": 1594307583000, "masked_author": "username_3", "text": "Any updates on this?", "title": null, "type": "comment" }, { "action": "closed", "author": "ninja511", "comment_id": null, "datetime": 1598279959000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ninja511", "comment_id": 679167043, "datetime": 1598279959000, "masked_author": "username_3", "text": "closing for now - reopen if needed", "title": null, "type": "comment" } ]
4
6
1,713
false
false
1,713
true
smallrye/smallrye-jwt
smallrye
762,326,488
347
null
[ { "action": "opened", "author": "emecas", "comment_id": null, "datetime": 1607691978000, "masked_author": "username_0", "text": "I am getting the following error when building using an old version of Java8 (JDK 1.8.0_112)\r\n\r\n@username_2 has indicated [here](https://github.com/eclipse/microprofile-jwt-auth/issues/227#issuecomment-742862081) that PS256 is not a required algorithm to support for MP-JWT 1.2 and only RS256, ES256 are required signature algorithms.\r\n\r\n```\r\n[ERROR] Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.274 s <<< FAILURE! - in io.smallrye.jwt.build.JwtSignTest\r\n[ERROR] testSignClaimsPS256(io.smallrye.jwt.build.JwtSignTest) Time elapsed: 0.008 s <<< ERROR!\r\nio.smallrye.jwt.build.JwtSignatureException: SRJWT05012: Failure to create a signed JWT token: PS256 is an unknown, unsupported or unavailable alg algorithm (not one of [none, HS256, HS384, HS512, ES256, ES384, ES512, RS256, RS384, RS512]).\r\n at io.smallrye.jwt.build.JwtSignTest.testSignClaimsPS256(JwtSignTest.java:431)\r\nCaused by: org.jose4j.lang.InvalidAlgorithmException: PS256 is an unknown, unsupported or unavailable alg algorithm (not one of [none, HS256, HS384, HS512, ES256, ES384, ES512, RS256, RS384, RS512]).\r\n at io.smallrye.jwt.build.JwtSignTest.testSignClaimsPS256(JwtSignTest.java:431)\r\n\r\n[INFO]\r\n[INFO] Results:\r\n[INFO]\r\n[ERROR] Errors:\r\n[ERROR] JwtSignTest.testSignClaimsPS256:431 ยป JwtSignature SRJWT05012: Failure to crea...\r\n[INFO]\r\n[ERROR] Tests run: 58, Failures: 0, Errors: 1, Skipped: 0\r\n[INFO]\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] Reactor Summary for SmallRye: MicroProfile JWT Parent 3.0.0-RC1:\r\n[INFO]\r\n[INFO] SmallRye: MicroProfile JWT Parent .................. SUCCESS [ 8.091 s]\r\n[INFO] SmallRye: MicroProfile JWT - Implementation Parent . SUCCESS [ 1.384 s]\r\n[INFO] SmallRye: MicroProfile JWT Implementation Common ... SUCCESS [ 8.242 s]\r\n[INFO] SmallRye: MicroProfile JWT Build Implementation .... FAILURE [ 10.138 s]\r\n[INFO] SmallRye: MicroProfile JWT Implementation .......... SKIPPED\r\n[INFO] SmallRye: MicroProfile JWT - Testsuite Parent ...... SKIPPED\r\n[INFO] SmallRye: MicroProfile JWT Basic Testsuite ......... SKIPPED\r\n[INFO] SmallRye: MicroProfile JWT TCK ..................... SKIPPED\r\n[INFO] Empty Release Project to Avoid Maven Bug ........... SKIPPED\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] BUILD FAILURE\r\n[INFO] ------------------------------------------------------------------------\r\n```", "title": "[3.0.0-RC1] PS256 is not a required algorithm to support for MP-JWT 1.2 while building with old JDK8", "type": "issue" }, { "action": "created", "author": "radcortez", "comment_id": 743188951, "datetime": 1607692854000, "masked_author": "username_1", "text": "Can you try with a more recent JDK 8 update?", "title": null, "type": "comment" }, { "action": "created", "author": "sberyozkin", "comment_id": 743209360, "datetime": 1607695390000, "masked_author": "username_2", "text": "@username_0 this particular test is not related to MP JWT 1.2 for all Java versions and we do not set the expectations that it will work for all the Java 8 versions around :-). What is your expectation around this test ?", "title": null, "type": "comment" }, { "action": "created", "author": "sberyozkin", "comment_id": 743211065, "datetime": 1607695571000, "masked_author": "username_2", "text": "I'd like to avoid starting checking Java 8 update versions but also see why this failing test, due to the fact TCK tests are skipped, may cause some confusions. I think I'll just make it optional going forward - check if the related signature algorithm can be loaded and only then run the test", "title": null, "type": "comment" }, { "action": "created", "author": "sberyozkin", "comment_id": 743214897, "datetime": 1607695980000, "masked_author": "username_2", "text": "Hi @username_0 I've removed `for MP-JWT 1.2 ` part from the subject, otheriwise it can read as if the requirement varies depending on the Java 8 version", "title": null, "type": "comment" }, { "action": "created", "author": "sberyozkin", "comment_id": 743245445, "datetime": 1607699152000, "masked_author": "username_2", "text": "@username_0 I should further clarify, this test is only related to a JWT builder API which is currently not part of MP JWT, but as I said I'll make this test optional anyway...", "title": null, "type": "comment" }, { "action": "created", "author": "emecas", "comment_id": 743270235, "datetime": 1607701576000, "masked_author": "username_0", "text": "My original expectation was just testing and passing the build locally with my existent configuration. \r\n\r\nThen once noticed the particular issue, my expectation moved to figuring out the why and fixing it in a dependencies level or prerequisites.\r\n\r\nOnce validated that the only difference respect to the GitHub checks was the minor version of the `JDK8` and after your clarification related to `PS256` as not a required algorithm, as well as the build passed with newer `JDK8` version and apparently with any `JDK11`\r\n\r\nFinally, my expectation evolved towards providing (or at least helping on providing) a fix by updating the test from being required to behave as an optional check (un-related to MP-JWT 1.2) depending of the build's context (when using an old JDK8) and algorithm availability.\r\n\r\nIn conclusion, thank you @username_2 for following up this subject and all provided clarifications, as it seems you are already working on it, please let me know if I can help", "title": null, "type": "comment" }, { "action": "created", "author": "sberyozkin", "comment_id": 743277328, "datetime": 1607702380000, "masked_author": "username_2", "text": "@username_0 OK, I see, thanks, see #348 - that will make things clearer, so as you can see there, if we can determine that Java supports the `PS256` natively (with the name recognized by Java) then we run the test as is else we install BC.\r\nSo even with the older Java8 it should work.\r\nIt is unrelated to MP JWT but the test itself will become more robust :-)", "title": null, "type": "comment" }, { "action": "closed", "author": "sberyozkin", "comment_id": null, "datetime": 1607896158000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
9
4,639
false
false
4,639
true
microsoft/fluent-ui-react
microsoft
565,272,093
2,356
{ "number": 2356, "repo": "fluent-ui-react", "user_login": "microsoft" }
[ { "action": "opened", "author": "mnajdova", "comment_id": null, "datetime": 1581679946000, "masked_author": "username_0", "text": "Fixes https://github.com/microsoft/fluent-ui-react/issues/2272", "title": "fix(Carousel): do not render hidden carousel items", "type": "issue" } ]
2
2
17,238
false
true
62
false
curl/curl
curl
620,325,930
5,413
null
[ { "action": "opened", "author": "monocle-ai", "comment_id": null, "datetime": 1589817564000, "masked_author": "username_0", "text": "<span> What is a&nbsp;</span><span><b>Conditionally Uninitialized Variable? </b></span><span> The return value of a function that is potentially used to initialize a local variable is not checked. Therefore, reading the local variable may result in undefined behavior.</span>\n---\n\n1 instance of this defect were found in the following locations:\n---\n**Instance 1**\nFile : `lib/sendf.c` \nFunction: `curl_mvsnprintf` \nhttps://github.com/curl/curl/blob/17b1405b20f7ea916995c224992b0ec592f73039/lib/sendf.c#L270\nCode extract:\n\n```cpp\n size_t len;\n char error[CURL_ERROR_SIZE + 2];\n va_start(ap, fmt);\n mvsnprintf(error, CURL_ERROR_SIZE, fmt, ap); <------ HERE\n len = strlen(error);\n\n```\n\n**How can I fix it?** \nCorrect reference usage found in `lib/sendf.c` at line `241`.\nhttps://github.com/curl/curl/blob/17b1405b20f7ea916995c224992b0ec592f73039/lib/sendf.c#L241\nCode extract:\n\n```cpp\n size_t len;\n char print_buffer[2048 + 1];\n va_start(ap, fmt);\n len = mvsnprintf(print_buffer, sizeof(print_buffer), fmt, ap); <------ HERE\n /*\n * Indicate truncation of the input by replacing the last 3 characters\n```", "title": "Potential security issue in lib/sendf.c: Unchecked return from initialization function", "type": "issue" }, { "action": "closed", "author": "bagder", "comment_id": null, "datetime": 1589869110000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
2
1,135
false
false
1,135
false
loot/skyrimse
loot
542,965,456
954
null
[ { "action": "opened", "author": "CptMcSplody", "comment_id": null, "datetime": 1577474228000, "masked_author": "username_0", "text": "[Choose Your Own Arch Mage](https://www.nexusmods.com/skyrimspecialedition/mods/30887) Rules outlined on the main page.\r\n\r\n_Originally posted by @SomethingObscure in https://github.com/loot/skyrimse/issues/517#issuecomment-569316617_", "title": "Choose Your Own Arch-Mage", "type": "issue" }, { "action": "closed", "author": "CptMcSplody", "comment_id": null, "datetime": 1577693053000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "CptMcSplody", "comment_id": 569609979, "datetime": 1577693053000, "masked_author": "username_0", "text": "Done in https://github.com/loot/skyrimse/commit/39a4439fddc22825df64da8583311f72a596a4e7.", "title": null, "type": "comment" } ]
1
3
322
false
false
322
false
intellij-rust/intellij-rust
intellij-rust
638,581,156
5,571
{ "number": 5571, "repo": "intellij-rust", "user_login": "intellij-rust" }
[ { "action": "opened", "author": "Stzx", "comment_id": null, "datetime": 1592202355000, "masked_author": "username_0", "text": "#### Improve\r\n* Associate annotation level with lint level\r\n* Support for `forbid` attribute\r\n\r\nClosed #5567", "title": "INSP: Improve lint check", "type": "issue" } ]
2
2
414
false
true
108
false
facebookresearch/detectron2
facebookresearch
562,413,899
833
null
[ { "action": "opened", "author": "morestart", "comment_id": null, "datetime": 1581325011000, "masked_author": "username_0", "text": "can you tell me the annotation tools in the clolab custome datasets tutorials๏ผŸAnd the tools version,thanks.", "title": "Annotation tools for balloon datasets", "type": "issue" }, { "action": "closed", "author": "ppwwyyxx", "comment_id": null, "datetime": 1581327169000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ppwwyyxx", "comment_id": 584032899, "datetime": 1581327169000, "masked_author": "username_1", "text": "https://engineering.matterport.com/splash-of-color-instance-segmentation-with-mask-r-cnn-and-tensorflow-7c761e238b46", "title": null, "type": "comment" } ]
2
3
223
false
false
223
false
clamsproject/mmif
clamsproject
626,172,167
6
null
[ { "action": "opened", "author": "keighrim", "comment_id": null, "datetime": 1590634228000, "masked_author": "username_0", "text": "In lapps, tools can handle different type of data formats (LIF, gate, UIMA, ...), so we needed to have a `discriminator` at the very beginning of the I/O to indicate in which format is current input. \r\nI wonder if that's still the case for the MMIF and CLAMS. \r\nIf the CLAMS needs to be 100% compatible with all the lapps tools (including those handle non-LIF inputs, for instance UIMA-XML), we can still encode a LIF (with XML encoded) as a whole inside the MMIF - of course it would be ugly though.\r\nAny idea is welcome.", "title": "`discriminator` in MMIF", "type": "issue" }, { "action": "created", "author": "keighrim", "comment_id": 635556235, "datetime": 1590694934000, "masked_author": "username_0", "text": "I think at the moment, we decided not to use `discriminator` in MMIF and therefore wrapping native LIF json string inside MMIF as a whole is not an option any more. So next questions will be the way LIF string/objects are wrapped and represented in MMIF. Are we all agree on this?", "title": null, "type": "comment" }, { "action": "created", "author": "marcverhagen", "comment_id": 635564531, "datetime": 1590695983000, "masked_author": "username_1", "text": "That would be ugly indeed but why would we want to do that? Isn't MMIF already set up to deal with LIF? Sure, there are some differences in that there is no `text` property but instead text as one or more of the media, and views are as usual except that they refer to a media element.\r\n\r\nThe bigger question is how we incorporate LAPPS tools. There is some prose on this [here](https://github.com/clamsproject/mmif/tree/specification/specifications/draft#compatibility-with-lapps-tools), but that indeed needs more thought.", "title": null, "type": "comment" }, { "action": "created", "author": "keighrim", "comment_id": 636529588, "datetime": 1590958999000, "masked_author": "username_0", "text": "Yes, I agree that we decided to handle only LIF json strings - maybe after I left the first comment. So ignore that outdated part you quoted. \r\n\r\n---\r\nLAPPS services that produce LIF as output should indicate that in their metadata, so we can rely on that for integration (although the metadata might not be very reliable - that's a different story). Actual integration needs a lot more thoughts and careful design, as well as consideration of other new approaches we take in designing MMIF, such as #8.", "title": null, "type": "comment" }, { "action": "created", "author": "keighrim", "comment_id": 655258191, "datetime": 1594178396000, "masked_author": "username_0", "text": "So we don't have `discriminator` field at the top; that will limit our lapps integration in that only tools that output `LIF`-formatted json can be considered for integration. I'll leave this open for future reference, until we actually start lapps integration.", "title": null, "type": "comment" }, { "action": "created", "author": "marcverhagen", "comment_id": 655548769, "datetime": 1594217831000, "masked_author": "username_1", "text": "Yeah, that is a worry. But we will indeed be better able to figure this out once the first LAPPS tools is being integrated.", "title": null, "type": "comment" } ]
2
6
2,213
false
false
2,213
false
radixdlt/radixdlt-core
radixdlt
645,170,101
119
{ "number": 119, "repo": "radixdlt-core", "user_login": "radixdlt" }
[ { "action": "opened", "author": "talekhinezh", "comment_id": null, "datetime": 1593063822000, "masked_author": "username_0", "text": "* Refactor EpochManager to create new actors on epoch changes\r\n* Refactor genesis creation\r\n* Add epoch parameter to Vertex", "title": "Epochs", "type": "issue" } ]
2
7
23,082
false
true
123
false
beetbox/beets
beetbox
651,064,695
3,657
null
[ { "action": "opened", "author": "s1shed", "comment_id": null, "datetime": 1593953584000, "masked_author": "username_0", "text": "<!--\r\nDescribe your problem, feature request, or discussion topic here.\r\n\r\nPlease fill out this and the \"Setup\" section below and remember to include\r\nenough detail so that other people can reproduce the problem.\r\n-->\r\nBeets now crashes when trying to do anything. It was probably caused by an update to some system packages. Another user filed a [bug with Debian](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964245). The user says he was able to resolve it by downgrading the python package but I note my python version is not the (allegedly) buggy one.\r\n\r\nI've tried renaming the config directory to rule out problems with my configuration/plugins but this did not help.\r\n\r\nI'm filing this bug not yet knowing where the problem lies.\r\n\r\n### Problem\r\n\r\nRunning this command in verbose (`-vv`) mode:\r\n```sh\r\nbeet -vv ls anything \r\nbeet config\r\n```\r\n\r\nLed to this problem:\r\n\r\n```\r\nno user configuration found at /home/user/.config/beets/config.yaml\r\ndata directory: /home/user/.config/beets\r\nplugin paths: \r\nSending event: pluginload\r\ninline: adding item field multidisc\r\nTraceback (most recent call last):\r\n File \"/usr/bin/beet\", line 11, in <module>\r\n load_entry_point('beets==1.4.9', 'console_scripts', 'beet')()\r\n File \"/usr/share/beets/beets/ui/__init__.py\", line 1266, in main\r\n _raw_main(args)\r\n File \"/usr/share/beets/beets/ui/__init__.py\", line 1249, in _raw_main\r\n subcommands, plugins, lib = _setup(options, lib)\r\n File \"/usr/share/beets/beets/ui/__init__.py\", line 1144, in _setup\r\n lib = _open_library(config)\r\n File \"/usr/share/beets/beets/ui/__init__.py\", line 1201, in _open_library\r\n get_path_formats(),\r\n File \"/usr/share/beets/beets/ui/__init__.py\", line 619, in get_path_formats\r\n path_formats.append((query, template(view.as_str())))\r\n File \"/usr/share/beets/beets/util/functemplate.py\", line 571, in template\r\n return Template(fmt)\r\n File \"/usr/share/beets/beets/util/functemplate.py\", line 581, in __init__\r\n self.compiled = self.translate()\r\n File \"/usr/share/beets/beets/util/functemplate.py\", line 614, in translate\r\n func = compile_func(\r\n File \"/usr/share/beets/beets/util/functemplate.py\", line 155, in compile_func\r\n prog = compile(mod, '<generated>', 'exec')\r\nValueError: Name node can't be used with 'None' constant\r\n```\r\n\r\n### Setup\r\n\r\n* OS: Debian unstable\r\n* Python version: 3.8.3 (Debian package: python3, version 3.8.2-3)\r\n* beets version: 1.4.9 (both the debian package and one from a venv)\r\n* Turning off plugins made problem go away (yes/no): no.", "title": "Crash at start in Debian unstable", "type": "issue" }, { "action": "created", "author": "s1shed", "comment_id": 653892375, "datetime": 1593957588000, "masked_author": "username_0", "text": "I cannot reproduce the problem with the current master branch (cb668ccdab86855986dcff6b8da7b011d0d5b74c) but I can with v1.4.9.", "title": null, "type": "comment" }, { "action": "created", "author": "sampsyo", "comment_id": 654215180, "datetime": 1594039889000, "masked_author": "username_1", "text": "Please see #3621.", "title": null, "type": "comment" }, { "action": "closed", "author": "sampsyo", "comment_id": null, "datetime": 1594039889000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
4
2,677
false
false
2,677
false
geerlingguy/raspberry-pi-dramble
null
556,473,261
170
null
[ { "action": "opened", "author": "CodeDestroyer", "comment_id": null, "datetime": 1580246164000, "masked_author": "username_0", "text": "I am running on raspbian 2019-09-26 with aarch64 enabled.\r\n\r\nI have run through everything, and it all seems to standup. \r\nThe only change was the private network range\r\n\r\nwhen i try to hit the master 192.168.2.2 with host cluster.pidramble.test it cannot connect.\r\nif i try any of the other pods i get a 404.\r\n\r\nlooking into the kubernetes logs i am seeing `describe pod/traefik-ingress-controller-4ndhw -n kube-system`\r\n```\r\nlevel=info msg=\"Server configuration reloaded on :443\"\r\ntime=\"2020-01-28T20:17:15Z\" level=info msg=\"Server configuration reloaded on :80\"\r\ntime=\"2020-01-28T20:17:15Z\" level=info msg=\"Server configuration reloaded on :8080\"\r\ntime=\"2020-01-28T20:17:15Z\" level=warning msg=\"Endpoints not available for drupal/drupal\"\r\ntime=\"2020-01-28T19:54:48Z\" level=warning msg=\"Endpoints not available for registry/docker-registry\"```", "title": "Endpoints not available for drupal/drupal", "type": "issue" }, { "action": "created", "author": "mikev1963", "comment_id": 606085703, "datetime": 1585583756000, "masked_author": "username_1", "text": "I have the same issue. Why is NodePort not using port 80? Here is my issues below:\r\n```\r\n$ kubectl get svc -n nginx\r\nNAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE\r\nnginx NodePort 10.111.23.204 <none> 80:32357/TCP 4m31s\r\npi@master:/mnt/yaml $ \r\npi@master:/mnt/yaml $ curl --head http://master.mikevware.net\r\ncurl: (7) Failed to connect to master.mikevware.net port 80: Connection refused\r\n$ \r\n$ curl --head http://master.mikevware.net:32357\r\nHTTP/1.1 200 OK\r\nServer: nginx/1.17.9\r\nDate: Mon, 30 Mar 2020 15:54:43 GMT\r\nContent-Type: text/html\r\nContent-Length: 612\r\nLast-Modified: Tue, 03 Mar 2020 14:32:47 GMT\r\nConnection: keep-alive\r\nETag: \"5e5e6a8f-264\"\r\nAccept-Ranges: bytes\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "mikev1963", "comment_id": 606784842, "datetime": 1585677853000, "masked_author": "username_1", "text": "Jeff. Are you forwarding your website to the ingress port ? Since port 80 is not available to my domain. Should I forward my website to port 32357 as shown in the above post?", "title": null, "type": "comment" }, { "action": "created", "author": "geerlingguy", "comment_id": 640144615, "datetime": 1591495319000, "masked_author": "username_2", "text": "Could there be some other service running on port 80 on your Pis? If so, Traefik would not be able to bind to the port and serve traffic for Drupal there.", "title": null, "type": "comment" } ]
4
7
2,386
false
true
1,895
false
filecoin-project/go-bitfield
filecoin-project
648,474,326
20
null
[ { "action": "opened", "author": "Stebalien", "comment_id": null, "datetime": 1593549283000, "masked_author": "username_0", "text": "Currently, they need to scan the entire set. We can make this more efficient by keeping an array of run indexes. To lookup a bit, we can binary search the array indexes to find the appropriate run in `O(log runs)` steps.", "title": "IsSet/IsUnset are inefficient.", "type": "issue" } ]
1
1
220
false
false
220
false
yasserqureshi1/Sneaker-Monitors
null
737,194,127
8
null
[ { "action": "opened", "author": "TRiG222", "comment_id": null, "datetime": 1604603388000, "masked_author": "username_0", "text": "1. The webhook does not have the size of any product, even though it is\r\n2. The monitor loops and displays goods in a circle\r\n\r\nIn the first case, I solved the problem by changing the code, the second case is more difficult", "title": "Supreme Monitor ", "type": "issue" }, { "action": "created", "author": "yasserqureshi1", "comment_id": 727106845, "datetime": 1605316257000, "masked_author": "username_1", "text": "Code has been updated. It should work now.", "title": null, "type": "comment" }, { "action": "closed", "author": "yasserqureshi1", "comment_id": null, "datetime": 1605316257000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
265
false
false
265
false
sigp/lighthouse
sigp
614,807,312
1,124
{ "number": 1124, "repo": "lighthouse", "user_login": "sigp" }
[ { "action": "opened", "author": "pawanjay176", "comment_id": null, "datetime": 1588951028000, "masked_author": "username_0", "text": "## Proposed Changes\r\n\r\n- Fixes eth1 `update_deposit_cache` and `update_block_cache` and eth1 tests\r\n- Fixes `environment` to build proper tokio runtimes\r\n- Port `node_test_rig` to stable futures\r\n- Fix compile errors in beacon chain\r\n- Refactor eth1 service update to mirror task spawning in validator_client\r\n\r\n@username_1 I have kept each fix as a separate commit so you can cherry-pick individual fixes. Most of them are just straightforward fixes except the eth1 service spawning refactor which I am not sure works the way we would expect it to.", "title": "stable futures fixes", "type": "issue" }, { "action": "created", "author": "AgeManning", "comment_id": 626302068, "datetime": 1589104493000, "masked_author": "username_1", "text": "This looks sane to me on a quick review. I'll add it in and review in the stable-futures branch", "title": null, "type": "comment" } ]
2
2
644
false
false
644
true
imaNNeoFighT/fl_chart
null
804,402,444
567
null
[ { "action": "opened", "author": "newbieflutter", "comment_id": null, "datetime": 1612865393000, "masked_author": "username_0", "text": "Hi,\r\n I would like to know can I replace getTitle function rather than text with icon or images?", "title": "getTitles to be replace text with image or icon?", "type": "issue" }, { "action": "created", "author": "smwash", "comment_id": 779762169, "datetime": 1613473328000, "masked_author": "username_1", "text": "Hello, did you get a solution on this?", "title": null, "type": "comment" } ]
2
2
137
false
false
137
false
webpack/webpack-dev-server
webpack
646,666,533
2,663
null
[ { "action": "opened", "author": "hmnd", "comment_id": null, "datetime": 1593258515000, "masked_author": "username_0", "text": "<!--\r\n Please note that this template is not optional.\r\n Please fill out _ALL_ fields, or your issue may be closed as \"invalid.\"\r\n Please do not delete this template.\r\n Please ask questions on StackOverflow or Gitter (https://gitter.im/webpack/webpack).\r\n General questions, how-to questions, and support requests will be closed.\r\n-->\r\n\r\n- Operating System: Solus\r\n- Node Version: 12.18.0\r\n- NPM Version: 6.14.5\r\n- webpack Version: 5.0.0-beta.18\r\n- webpack-dev-server Version: 3.11.0\r\n- Browser: Firefox Developer Edition 78.0b9\r\n\r\n<!--\r\n Please place an x, no spaces, in all [ ] that apply\r\n Please note that we are NOT accepting FEATURE requests at this time.\r\n-->\r\n\r\n- [x] This is a **bug**\r\n- [ ] This is a **modification** request\r\n\r\n### Code\r\n\r\n<!--\r\n If you have a large amount of code to share which demonstrates the problem\r\n you're experiencing, or your webpack config is very large, please provide a link\r\n to your repository rather than pasting code. We'd also encourage you to use a\r\n Github Gist link instead of pasting code. Otherwise, please paste relevant\r\n short snippets below.\r\n\r\n For bugs, please do consider providing a link to a stripped-down, bare-bones\r\n repo that can reproduce the problem you're experiencing. Many times, bugs\r\n aren't actual bugs, but rather specific issues with loaders, plugins, or\r\n an environment/OS. Problems with complicated or large applications will almost\r\n always require this to be triaged.\r\n-->\r\n\r\n```js\r\n// webpack.config.js\r\nfunction genConfig(target, name) {\r\n const config = {\r\n mode: 'production',\r\n entry: combinedPaths,\r\n output: {\r\n path: buildPath,\r\n filename: `[name]${\r\n !target || target === 'window' ? '' : `.${target}`\r\n }.min.js`,\r\n libraryTarget: target,\r\n },\r\n externals: {\r\n _: '_',\r\n },\r\n module: {\r\n rules: [\r\n ...\r\n ],\r\n },\r\n plugins: [\r\n ...\r\n ],\r\n resolve: {\r\n alias: {\r\n vue$: 'vue/dist/vue.esm.js',\r\n '@': path.resolve(__dirname, 'src'),\r\n path: 'path-browserify',\r\n stream: 'stream-browserify',\r\n },\r\n extensions: ['.ts', '.js', '.vue'],\r\n },\r\n optimization: {\r\n ...\r\n },\r\n devServer: {\r\n host: 'localhost',\r\n port: 8080,\r\n https: true,\r\n headers: {\r\n 'Access-Control-Allow-Origin': '*',\r\n 'Access-Control-Allow-Methods':\r\n 'GET, POST, PUT, DELETE, PATCH, OPTIONS',\r\n 'Access-Control-Allow-Headers':\r\n 'X-Requested-With, content-type, Authorization',\r\n },\r\n disableHostCheck: true,\r\n compress: true,\r\n },\r\n };\r\n if (name) {\r\n config.output.library = name;\r\n }\r\n return config;\r\n}\r\n\r\nmodule.exports = [genConfig('window'), genConfig('umd', 'MyLibrary')];\r\n```\r\n\r\n### Expected Behavior\r\nFunctions are assigned to the `window` object when using dev-server.\r\n\r\n### Actual Behavior\r\nFunctions are not assigned to the `window` object.\r\n\r\n### For Bugs; How can we reproduce the behavior?\r\nSet `libraryTarget` to `window` with no `library` name specified.", "title": "Global window libraryTarget does not work with webpack 5", "type": "issue" }, { "action": "created", "author": "evilebottnawi", "comment_id": 651060858, "datetime": 1593430961000, "masked_author": "username_1", "text": "What is the problem? We bundle the client before include it. Yes, it is not respect `libraryTarget` and should not", "title": null, "type": "comment" }, { "action": "created", "author": "hmnd", "comment_id": 651327808, "datetime": 1593460741000, "masked_author": "username_0", "text": "@username_1 maybe I'm misunderstanding something, but as far as I can tell, it did work with webpack 4. I develop a library that is embedded in a third-party platform using a script tag. I provide a version of this library exported as a global to `window` to retain backwards compatibility for some of my clients, and I would like those functions to continue to work while I develop them.", "title": null, "type": "comment" }, { "action": "created", "author": "evilebottnawi", "comment_id": 651732182, "datetime": 1593516248000, "masked_author": "username_1", "text": "@username_0 how it is related to webpack-dev-server? We don't modify `libraryTarget`, without webpack-dev-server all works fine?", "title": null, "type": "comment" }, { "action": "created", "author": "zhangwilling", "comment_id": 652600168, "datetime": 1593631052000, "masked_author": "username_2", "text": "But actually it happened . it is very stranrgely, i found when `hot` is enabled, outout.libraryTarget would not works๏ผŒan empty object will be exported no matter which libraryTarget is setted.\r\n\r\nit may caused by webpack5 see [here ](https://github.com/webpack/changelog-v5#hot-module-replacement)\r\n\r\ni would do some research to find the answer.", "title": null, "type": "comment" }, { "action": "created", "author": "zhangwilling", "comment_id": 652737799, "datetime": 1593655858000, "masked_author": "username_2", "text": "aha, look this [issue](https://github.com/webpack/webpack-dev-server/issues/2484)", "title": null, "type": "comment" }, { "action": "created", "author": "evilebottnawi", "comment_id": 652952830, "datetime": 1593689558000, "masked_author": "username_1", "text": "Yep, duplicate, let's close in favor https://github.com/webpack/webpack-dev-server/issues/2484", "title": null, "type": "comment" }, { "action": "closed", "author": "evilebottnawi", "comment_id": null, "datetime": 1593689558000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
8
4,225
false
false
4,225
true
octokit/webhooks
octokit
800,691,586
356
{ "number": 356, "repo": "webhooks", "user_login": "octokit" }
[ { "action": "opened", "author": "G-Rath", "comment_id": null, "datetime": 1612385688000, "masked_author": "username_0", "text": "", "title": "fix: mark `author` and `committer` as nullable in `status` schema", "type": "issue" } ]
2
2
368
false
true
0
false
juhongseo/github-slideshow
null
688,814,858
1
null
[ { "action": "closed", "author": "juhongseo", "comment_id": null, "datetime": 1598833306000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
6
6,801
false
true
0
false
FergM/fattails
null
772,492,598
4
null
[ { "action": "opened", "author": "FergM", "comment_id": null, "datetime": 1608588289000, "masked_author": "username_0", "text": "# What\r\n* I guess MIT or BSD license\r\n* Django has a brief comments on the matter [here](https://docs.djangoproject.com/en/3.1/intro/reusable-apps/)\r\n\r\n# Why\r\n* So others can use the code\r\n* and know what the expectations are", "title": "Add License", "type": "issue" }, { "action": "closed", "author": "FergM", "comment_id": null, "datetime": 1608672568000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "FergM", "comment_id": 749784572, "datetime": 1608672568000, "masked_author": "username_0", "text": "Fixed.", "title": null, "type": "comment" } ]
1
3
231
false
false
231
false
kubevirt/project-infra
kubevirt
650,429,021
539
null
[ { "action": "opened", "author": "dhiller", "comment_id": null, "datetime": 1593764311000, "masked_author": "username_0", "text": "Jobs for flakefinder report generation are missing [configuration for `org` and `repo`](https://github.com/kubevirt/project-infra/blob/master/robots/flakefinder/main.go#L52).\r\n\r\nExample for missing configuration:\r\nhttps://github.com/kubevirt/project-infra/blob/412094f96c3c034dd86e810fda1aa5942a0ec558/github/ci/prow/files/jobs/kubevirt/cluster-network-addons-operator/cluster-network-addons-operator-periodics.yaml#L49\r\n\r\nExample for correct configuration: https://github.com/kubevirt/project-infra/blob/bef173d869b8e54c5ca3d76b49d94e2c3605da81/github/ci/prow/files/jobs/nmstate/kubernetes-nmstate/kubernetes-nmstate-periodics.yaml#L55\r\n\r\nRelates to: cluster-network-addons-operator#447\r\n\r\n/triage build-officer", "title": "cnao flakefinder jobvs are missing org and repo configs", "type": "issue" }, { "action": "created", "author": "dhiller", "comment_id": 653418975, "datetime": 1593764354000, "masked_author": "username_0", "text": "/kind bug", "title": null, "type": "comment" }, { "action": "created", "author": "dhiller", "comment_id": 653419088, "datetime": 1593764372000, "masked_author": "username_0", "text": "/cc @qinqon @RamLavi @phoracek", "title": null, "type": "comment" } ]
2
8
1,745
false
true
751
false
domtronn/all-the-icons.el
null
630,771,661
215
null
[ { "action": "opened", "author": "atanasj", "comment_id": null, "datetime": 1591272998000, "masked_author": "username_0", "text": "It would be great if there was an icon for files associated with the `R` language. The first example is what sublime text has. The second is what VSCode has. And the final is Emacs using `all-the-icons` for `treemacs`.\r\n\r\n<img width=\"140\" alt=\"image\" src=\"https://user-images.githubusercontent.com/27214625/83755283-ac191000-a6b0-11ea-8443-325dc0cbcb5a.png\">\r\n\r\n<img width=\"217\" alt=\"image\" src=\"https://user-images.githubusercontent.com/27214625/83755424-e8e50700-a6b0-11ea-839b-6c27e4df0d3e.png\">\r\n\r\n<img width=\"238\" alt=\"image\" src=\"https://user-images.githubusercontent.com/27214625/83755474-fb5f4080-a6b0-11ea-816e-df345281337e.png\">", "title": "Provide an R language icon", "type": "issue" }, { "action": "created", "author": "wyuenho", "comment_id": 640120216, "datetime": 1591478780000, "masked_author": "username_1", "text": "PR welcome", "title": null, "type": "comment" }, { "action": "created", "author": "wyuenho", "comment_id": 755199258, "datetime": 1609926682000, "masked_author": "username_1", "text": "all-the-icons already has a mapping [defined for R](https://github.com/domtronn/all-the-icons.el/blob/master/all-the-icons.el#L255)\r\n\r\nIf treemacs isn't using the correct icon, it could be a bug in `treemacs-all-the-icons`. Please file a bug there.", "title": null, "type": "comment" }, { "action": "closed", "author": "wyuenho", "comment_id": null, "datetime": 1609926683000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "atanasj", "comment_id": 761936605, "datetime": 1610936387000, "masked_author": "username_0", "text": "Okay, will do. Thanks @username_1.", "title": null, "type": "comment" } ]
2
5
927
false
false
927
true
puppetlabs/puppetlabs-postgresql
puppetlabs
666,368,385
1,181
{ "number": 1181, "repo": "puppetlabs-postgresql", "user_login": "puppetlabs" }
[ { "action": "opened", "author": "npwalker", "comment_id": null, "datetime": 1595862441000, "masked_author": "username_0", "text": "Prior to this commit, there was an old limitation noted that we only support up to PostgreSQL 9.5. \r\n\r\nAfter this commit, we remove that limitation because we support whatever the default for each OS is.", "title": "(MAINT) Indicate supported PostgreSQL versions", "type": "issue" }, { "action": "created", "author": "david22swan", "comment_id": 672089418, "datetime": 1597164906000, "masked_author": "username_1", "text": "@username_0 \r\nMaking a quick change to point your PR at the newly default `main` branch. \r\nApologies if this is inconvenient in any way.", "title": null, "type": "comment" } ]
2
2
338
false
false
338
true
kubernetes/kube-state-metrics
kubernetes
609,010,897
1,130
{ "number": 1130, "repo": "kube-state-metrics", "user_login": "kubernetes" }
[ { "action": "opened", "author": "paulfantom", "comment_id": null, "datetime": 1588162644000, "masked_author": "username_0", "text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n- finalizing support for creating multi-arch images (Makefile already had some targets to build images for multiple architectures)\r\n- adding support for creating a container manifest joining images into one\r\n- fixing propagation of ARCH variable in `kube-state-metrics` target\r\n- removed the containerized build process as there is no benefit of it when using go modules.\r\n\r\nTested by running:\r\n```\r\nmake release-images REGISTRY=quay.io/username_0 TAG=$(git rev-parse --short HEAD)\r\n```\r\nOutput can be seen in https://quay.io/repository/username_0/kube-state-metrics?tab=tags\r\n\r\nImages validated on ARMv7 and AMD64 systems.\r\n\r\n**NOTE**: This changes how images are published to quay.io. After merging, publishing images is done with `make release-images`. Added info about it in RELEASE.md\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #1037", "title": "add support for building multi-CPU architecture images", "type": "issue" }, { "action": "created", "author": "brancz", "comment_id": 621177974, "datetime": 1588164083000, "masked_author": "username_1", "text": "There is some work on publishing the images to k8s.gcr.io automatically, at that point we will probably no longer support the quay repo. I'm not sure how much work we should put into it. I'm fine with this, but be aware that it might disappear soon, and I don't know if the auto publishing workflow will support multi-arch.", "title": null, "type": "comment" }, { "action": "created", "author": "lilic", "comment_id": 621219289, "datetime": 1588168020000, "masked_author": "username_2", "text": "Not true, we will still publish the coreos images, no?", "title": null, "type": "comment" }, { "action": "created", "author": "paulfantom", "comment_id": 621227697, "datetime": 1588168739000, "masked_author": "username_0", "text": "/hold\r\n\r\nApparently docker on [travis has permissions problems](https://travis-ci.org/github/coreos/prometheus-operator/jobs/680948725#L547) when trying to create manifests.", "title": null, "type": "comment" }, { "action": "created", "author": "paulfantom", "comment_id": 621321753, "datetime": 1588177718000, "masked_author": "username_0", "text": "/unhold\r\n\r\nmoved to use `manifest-tool` tool instead of experimental docker feature to solve travis issue with docker permissions. Also simplifies Makefile a bit.", "title": null, "type": "comment" }, { "action": "created", "author": "tariq1890", "comment_id": 624772279, "datetime": 1588784754000, "masked_author": "username_3", "text": "Thanks for the PR @username_0 :). Provided some review comments", "title": null, "type": "comment" }, { "action": "created", "author": "mrueg", "comment_id": 651009300, "datetime": 1593418870000, "masked_author": "username_4", "text": "@username_3 @username_0 since I'm using kube-state-metrics on arm64, I would love to see this change in as it will simplifying deployment a lot. Anything I can help out with here to move it forward?", "title": null, "type": "comment" }, { "action": "created", "author": "paulfantom", "comment_id": 651033447, "datetime": 1593421555000, "masked_author": "username_0", "text": "@username_4 AFAIK right now kube-state-metrics is moving container builds to gcr (https://github.com/kubernetes/kube-state-metrics/pull/1155). After that move is done I don't this PR is necessary anymore (definitely not in this form).\r\n\r\nSince right now I don't have time or desire to investigate this issue again, I am closing it.", "title": null, "type": "comment" } ]
6
9
4,020
false
true
3,085
true
OPS-E2E-PPE/E2E_DocFxV3
OPS-E2E-PPE
774,723,231
12,645
{ "number": 12645, "repo": "E2E_DocFxV3", "user_login": "OPS-E2E-PPE" }
[ { "action": "opened", "author": "OPSTestPPE", "comment_id": null, "datetime": 1608899119000, "masked_author": "username_0", "text": "", "title": "PR Comment: Remove bookmark", "type": "issue" }, { "action": "created", "author": "e2ebd2", "comment_id": 751242536, "datetime": 1608899154000, "masked_author": "username_1", "text": "Docs Build status updates of commit _[325dfc0](https://github.com/OPS-E2E-PPE/E2E_DocFxV3/commits/325dfc00de0b6659569aadd9e5f7512b31c0bea2)_: \n\n### :warning: Validation status: warnings\r\n\r\n\r\nFile | Status | Preview URL | Details\r\n---- | ------ | ----------- | -------\r\n[E2E_DocsBranch_Dynamic/TOC.md](https://github.com/OPS-E2E-PPE/E2E_DocFxV3/blob/pr-comment-removeBookmark/E2E_DocsBranch_Dynamic/TOC.md) | :warning:Warning | [View](https://ppe.docs.microsoft.com/en-us/E2E_DocFxV3/index?branch=pr-en-us-12645) | [Details](#user-content-98760f43-9131f144)\r\n[E2E_DocsBranch_Dynamic/index.md](https://github.com/OPS-E2E-PPE/E2E_DocFxV3/blob/pr-comment-removeBookmark/E2E_DocsBranch_Dynamic/index.md) | :white_check_mark:Succeeded | [View](https://ppe.docs.microsoft.com/en-us/E2E_DocFxV3/index?branch=pr-en-us-12645) |\r\n\r\n<a id=\"98760f43-9131f144\"></a>\r\n### [E2E_DocsBranch_Dynamic/TOC.md](https://github.com/OPS-E2E-PPE/E2E_DocFxV3/blob/pr-comment-removeBookmark/E2E_DocsBranch_Dynamic/TOC.md)\r\n - **Line 2, Column 4**: **[Warning-bookmark-not-found]** `````Cannot find bookmark '#bookmark1' in 'index.md', did you mean '#bookmark2'?`````\r\n\r\nFor more details, please refer to the [build report](https://opbuildstoragesandbox2.blob.core.windows.net/report/2020%5C12%5C25%5C8b165afe-a866-8c48-e5c3-ead94440f27e%5CPullRequest%5C202012251225225893-12645%5Cworkflow_report.html?sv=2016-05-31&sr=b&sig=3z5GhSMqDM3079qgrZ1QD5RX9cJj7q9Q7%2Bq1zm6aT%2BQ%3D&st=2020-12-25T12%3A20%3A53Z&se=2021-01-25T12%3A25%3A53Z&sp=r).\r\n\r\nIf you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions [here](https://teams.microsoft.com/l/message/19:7ecffca1166a4a3986fed528cf0870ee@thread.skype/1590030602688?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=de9ddba4-2574-4830-87ed-41668c07a1ca&parentMessageId=1590030602688&teamName=Docs%20Support&channelName=General&createdTime=1590030602688) to re-authorize your GitHub account to Docs Build.\r\n\r\n**Note:** Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the [broken link report](https://opportal-sandbox.azurewebsites.net/#/repos/8b165afe-a866-8c48-e5c3-ead94440f27e?tabName=brokenlinks).\r\n\r\n**Note:** Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these [instructions](https://review.docs.microsoft.com/en-us/help/onboard/faq?branch=master&tabs=pr-validation-error-solution#q-why-do-i-get-pr-validation-result-with-cryptic-error-or-warning-messages-not-related-to-the-changes-i-make-in-my-working-branch) to resolve them.\r\n\r\nFor any questions, please:<ul><li>Try searching in the <a href=\"https://review.docs.microsoft.com/en-us/search/?search=&amp;category=All&amp;scope=help-docs&amp;category=All&amp;branch=master\">Docs contributor and Admin Guide</a></li><li>See the <a href=\"https://review.docs.microsoft.com/en-us/help/onboard/faq?branch=master\">frequently asked questions</a></li><li>Post your question in the <a href=\"https://teams.microsoft.com/l/channel/19%3a7ecffca1166a4a3986fed528cf0870ee%40thread.skype/General?groupId=de9ddba4-2574-4830-87ed-41668c07a1ca&amp;tenantId=72f98bf-86f1-41af-91ab-2d7cd011db47\">Docs support channel</a></li></ul>", "title": null, "type": "comment" } ]
2
2
3,436
false
false
3,436
false
ckeditor/ckeditor5
ckeditor
755,986,379
8,572
null
[ { "action": "opened", "author": "Mgsy", "comment_id": null, "datetime": 1606984680000, "masked_author": "username_0", "text": "## ๐Ÿ“ Provide detailed reproduction steps (if any)\r\n\r\n1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/markdown.html.\r\n2. Call\r\n\r\n```html\r\neditor.setData(`\r\n\t<p>test</p>\r\n <table>\r\n <tbody>\r\n <tr>\r\n <td>test</td>\r\n <td>test;</td>\r\n <td>nbsp;</td>\r\n </tr>\r\n <tr>\r\n <td>nbsp;</td>\r\n <td>nbsp;</td>\r\n <td>nbsp;</td>\r\n </tr>\r\n <tr>\r\n <td>nbsp;</td>\r\n <td>nbsp;</td>\r\n <td>nbsp;</td>\r\n </tr>\r\n </tbody>\r\n </table>\r\n`)\r\n```\r\n\r\n### โœ”๏ธ Expected result\r\n\r\nThe table outputs as markdown.\r\n\r\n### โŒ Actual result\r\n\r\nThe table outputs as HTML.\r\n\r\n## ๐Ÿ“ƒ Other details\r\n\r\nThis is interesting, as adding `<thead>` to the markup results in proper markdown output.ย \r\n\r\n---\r\n\r\nIf you'd like to see this fixed sooner, add a ๐Ÿ‘ reaction to this post.", "title": "Markdown plugin doesn't recognize a basic table", "type": "issue" }, { "action": "created", "author": "Reinmar", "comment_id": 739767903, "datetime": 1607330551000, "masked_author": "username_1", "text": "It works fine. But you must not have indentation at the beginning of that HTML because it makes the MD parser to recognize this a as code snippet.\r\n\r\nThis worked:\r\n\r\n![](https://user-images.githubusercontent.com/156149/101328512-63fdc480-3870-11eb-9945-9243c6fc508c.png)\r\n\r\nThis indeed didn't:\r\n\r\n![](https://user-images.githubusercontent.com/156149/101328610-8263c000-3870-11eb-8ae4-a3157a35186b.png)", "title": null, "type": "comment" }, { "action": "closed", "author": "Reinmar", "comment_id": null, "datetime": 1607330553000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
2
3
1,362
false
false
1,362
false
celo-org/celo-proposals
celo-org
747,775,071
92
null
[ { "action": "opened", "author": "YazzyYaz", "comment_id": null, "datetime": 1605904234000, "masked_author": "username_0", "text": "Celo Governance Call 1\r\nWhen: , 60 minutes max\r\nWhere: Celo Zoom Event (Instructions on joining found in the calendar event below)\r\nCalendar Event: Add to your calendar here\r\nFocus: Discussing Governance Proposals and understanding the motivation behind them with the community\r\n\r\nAgenda\r\n\r\n\r\n_Please post all relevant proposals below that should be discussed and evaluated_", "title": "Celo Governance Call #2", "type": "issue" }, { "action": "created", "author": "devme25", "comment_id": 736855366, "datetime": 1606861033000, "masked_author": "username_1", "text": "Hi we (Deepak, MultiSig; Patrick, Validator Capital/Moola; Dee, Usopp.Club) would like to propose CGP 0017 (PR made, yet to be committed) to active the Celo Community Fund.\r\nRequesting: 30min\r\n10-15 min - Proposal Presentation\r\n15-20min - Feedback and Q&A", "title": null, "type": "comment" }, { "action": "created", "author": "cla-bel", "comment_id": 737668817, "datetime": 1606972077000, "masked_author": "username_2", "text": "If there's time at the end would it be possible to have 5 min to share a quick update/heads up that cLabs is kicking off work on additional stable assets and expect to share more info for discussion shortly.", "title": null, "type": "comment" }, { "action": "created", "author": "YazzyYaz", "comment_id": 739017039, "datetime": 1607115547000, "masked_author": "username_0", "text": "Video for the call: https://youtu.be/BUXFL86P63U", "title": null, "type": "comment" }, { "action": "closed", "author": "YazzyYaz", "comment_id": null, "datetime": 1607351164000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
3
5
884
false
false
884
false
golang/go
golang
723,337,002
42,018
null
[ { "action": "opened", "author": "eliasnaur", "comment_id": null, "datetime": 1602863383000, "masked_author": "username_0", "text": "The Windows HANDLE type is translated to an unsafe.Pointer in by cgo, but can contain non-pointer values; it should be treated accordingly. Incomplete pointer types such as the [JNI types](https://github.com/golang/go/issues/40954#issuecomment-678391202) are covered by a rule so that they're not treated as pointers. However, that rule does not match HANDLE, which is a `void *`.\r\n\r\nFrom [golang-dev](https://groups.google.com/g/golang-dev/c/-sAWsdTv9JU/m/ENQucQr5CwA):\r\n```\r\npackage main\r\n\r\nimport (\r\n \"fmt\"\r\n \"os\"\r\n \"path/filepath\"\r\n \"runtime\"\r\n\r\n \"golang.org/x/sys/windows\"\r\n)\r\n\r\n/*\r\n#include <windows.h>\r\n*/\r\nimport \"C\"\r\n\r\nfunc main() {\r\n name := filepath.Join(os.TempDir(), \"handletest.tmp\")\r\n name16, err := windows.UTF16PtrFromString(name)\r\n if err != nil {\r\n panic(err)\r\n }\r\n fmt.Println(\"Using filepath\", name)\r\n\r\n handle := C.CreateFileW((*C.wchar_t)(name16), C.GENERIC_READ, C.FILE_SHARE_READ|C.FILE_SHARE_WRITE, nil, C.CREATE_ALWAYS, 0, nil)\r\n if handle == C.HANDLE(C.INVALID_HANDLE_VALUE) {\r\n panic(\"failed to open\")\r\n }\r\n\r\n fmt.Println(\"handle addr\", handle)\r\n\r\n runtime.GC()\r\n\r\n rtn := C.CloseHandle(handle)\r\n if rtn == C.FALSE {\r\n panic(\"failed to close handle\")\r\n }\r\n}\r\n```\r\n\r\n```\r\ngo build && handletest.exe\r\nUsing filepath C:\\Users\\Alex\\AppData\\Local\\Temp\\handletest.tmp\r\nhandle addr 0x154\r\nruntime: bad pointer in frame main.main at 0xc000075f10: 0x154\r\nfatal error: invalid pointer found on stack\r\n```\r\n\r\nDuplicate of https://github.com/golang/go/issues/8921.\r\n\r\nCC @randall77", "title": "runtime/cgo: treat Windows HANDLE as non-pointer type", "type": "issue" }, { "action": "created", "author": "zx2c4", "comment_id": 735215061, "datetime": 1606559902000, "masked_author": "username_1", "text": "Cc @username_2", "title": null, "type": "comment" }, { "action": "created", "author": "eliasnaur", "comment_id": 907588606, "datetime": 1630136670000, "masked_author": "username_0", "text": "Gentle ping. Expanding use of Cgo in Gio on Windows is blocked by this issue that is subtle and has no workaround.", "title": null, "type": "comment" }, { "action": "created", "author": "zx2c4", "comment_id": 907588938, "datetime": 1630136822000, "masked_author": "username_1", "text": "Im curious: why not use the faster x/sys/windows syscall trampolines instead of cgo?", "title": null, "type": "comment" }, { "action": "created", "author": "alexbrainman", "comment_id": 907591986, "datetime": 1630138394000, "masked_author": "username_2", "text": "I agree this is a duplicate of #8921. So you have to take it up with @rsc, because he made `working as intended` decision in #8921.\r\n\r\nI also agree with @username_1 that you don't need to use Cgo to call Windows APIs.\r\n\r\nAlex", "title": null, "type": "comment" }, { "action": "created", "author": "zx2c4", "comment_id": 907592201, "datetime": 1630138513000, "masked_author": "username_1", "text": "We could treat HANDLE as uintptr as a special case, though, I guess?", "title": null, "type": "comment" }, { "action": "created", "author": "alexbrainman", "comment_id": 907592779, "datetime": 1630138867000, "masked_author": "username_2", "text": "I read this as he does not want any exceptions in Cgo.\r\n\r\nAlex", "title": null, "type": "comment" }, { "action": "created", "author": "eliasnaur", "comment_id": 907609878, "datetime": 1630148353000, "masked_author": "username_0", "text": "His comment is from 2014, 3 years before adding special cases for [CoreFoundation](https://go-review.googlesource.com/c/go/+/66332/) and [Android JNI types](https://go-review.googlesource.com/c/go/+/81876/). We don't even have to change the mapped type from unsafe.Pointer to uintptr [anymore](https://go-review.googlesource.com/c/go/+/250940).", "title": null, "type": "comment" }, { "action": "created", "author": "alexbrainman", "comment_id": 907715702, "datetime": 1630202172000, "masked_author": "username_2", "text": "I am not familiar with compiler code. If you know what to change, just send CL to Russ or Keith or any compiler developer.\r\n\r\nAlex", "title": null, "type": "comment" }, { "action": "created", "author": "eliasnaur", "comment_id": 907741760, "datetime": 1630221048000, "masked_author": "username_0", "text": "I don't know what to change. My comment was to point out that while the older special cases (CoreFoundation, JNI) were breaking changing (Cgo generated type changed from unsafe.Pointer to uintptr), new special cases preserve the type but treat their values as non-pointers.", "title": null, "type": "comment" }, { "action": "created", "author": "alexbrainman", "comment_id": 907748805, "datetime": 1630224331000, "masked_author": "username_2", "text": "I definitely cannot help you with that.\r\n\r\nAlex", "title": null, "type": "comment" }, { "action": "created", "author": "ianlancetaylor", "comment_id": 919613120, "datetime": 1631667133000, "masked_author": "username_3", "text": "As far as I know the approach here would be to change cmd/cgo/gcc.go so that when it sees the type `HANDLE` with `GOOS == \"windows\"` it treats it as a pointer to an empty struct type for which `NotInHeap` is `true`.", "title": null, "type": "comment" } ]
5
14
3,265
false
true
3,146
true
tibbe/unordered-containers
null
588,044,254
248
{ "number": 248, "repo": "unordered-containers", "user_login": "tibbe" }
[ { "action": "opened", "author": "m-renaud", "comment_id": null, "datetime": 1585177556000, "masked_author": "username_0", "text": "This was causing CI failures, see:\r\n\r\nhttps://travis-ci.org/github/tibbe/unordered-containers/jobs/666393736?utm_medium=notification&utm_source=github_status\r\n\r\nThere must have been an incorrect merge somewhere along the line in #176 \r\n\r\n@username_1 FYI for CI breakage at HEAD.", "title": "Fix export list in Hash.HashMap.Strict.Base.hs.", "type": "issue" }, { "action": "created", "author": "treeowl", "comment_id": 604145724, "datetime": 1585179559000, "masked_author": "username_1", "text": "Thanks", "title": null, "type": "comment" } ]
2
2
281
false
false
281
true
abseil/abseil-cpp
abseil
612,525,126
679
null
[ { "action": "opened", "author": "0x8000-0000", "comment_id": null, "datetime": 1588677502000, "masked_author": "username_0", "text": "First of all thank you for the nice library. I have watched with great interest Titus' \"Live at Head\" talk a few years ago - it makes sense to keep pushing forward to make progress. So we'll keep updating HEAD as fast as we can.\r\n\r\nHowever, there is the question of the past. And sometimes we need to be able to recreate a build from some time ago for bugfix, regression, or any other business reason. We need to be able to rely on the state of the world as it was Tuesday afternoon, three and a half years ago. Also, other open source projects are starting to depend on Abseil, and they still make releases - with submodules pointing at a commit or other in master or 'LTS' branches..\r\n\r\nIt would be very useful to have a stated policy (subject to change, naturally) that describes the intent of the \"LTS\" branches, and the policy of stability of the commits and tags (on the \"LTS\" branches or anywhere else).\r\n\r\nOver at https://github.com/conan-io/conan-center-index/pull/1523#pullrequestreview-405626667 we're updating the Abseil package to support creating the 'gRPC' package and questions arose about the master branch being force-pushed into, or about past tags being removed.\r\n\r\nIn a world where reproducibility of builds is important, what do we need to do to be able to rely on the past being frozen?\r\n\r\nThank you!", "title": "Document the intent and policy around \"LTS\" branches", "type": "issue" }, { "action": "created", "author": "derekmauro", "comment_id": 624066029, "datetime": 1588686467000, "masked_author": "username_1", "text": "The concept of live-at-head has been so widely misinterpreted that I wrote an FAQ about it: https://github.com/abseil/abseil-cpp/blob/master/FAQ.md#what-is-live-at-head-and-how-do-i-do-it\r\n\r\nThere is no reason live-at-head is incompatible with build reproducibility.\r\n\r\nYour other questions are probably answered by\r\nhttps://abseil.io/about/compatibility\r\nhttps://abseil.io/about/releases", "title": null, "type": "comment" }, { "action": "created", "author": "derekmauro", "comment_id": 624072002, "datetime": 1588687092000, "masked_author": "username_1", "text": "I also read a bit of the Conan issue you linked to. I'm not sure where some of the ideas in that thread are coming from. We will not be force-pushing anything to GitHub, we will not be deleting any old LTS branches, and we will not be removing old tags. I'm not even sure where the idea that we will do these things comes from.", "title": null, "type": "comment" }, { "action": "created", "author": "Minimonium", "comment_id": 624167065, "datetime": 1588697035000, "masked_author": "username_2", "text": "@username_1 Hi, Derek! Thank you for looking into it. That's good to hear.", "title": null, "type": "comment" }, { "action": "created", "author": "0x8000-0000", "comment_id": 624274119, "datetime": 1588708680000, "masked_author": "username_0", "text": "@username_1 Thank you for clarifying this policy specifically. I see that @username_2 carried your message over to the other review so I'll close this ticket. We will keep packaging new LTS snapshots using the proper Git tags, and strive to use them before the \"best by\" date lapses :)", "title": null, "type": "comment" }, { "action": "closed", "author": "0x8000-0000", "comment_id": null, "datetime": 1588708680000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
3
6
2,397
false
false
2,397
true
bertoost/Craft-3-Mailjet
null
625,431,556
4
null
[ { "action": "opened", "author": "menberg", "comment_id": null, "datetime": 1590562575000, "masked_author": "username_0", "text": "The declaration of public function init() lacks a \": void\" which leads to a PHP Compile Error with error message \"Declaration of username_1\\\\mailjet\\\\services\\\\SmsService::init() must be compatible with username_1\\\\mailjet\\\\services\\\\AbstractService::init(): void\"\r\n\r\nA possible fix would be to add \": void\" to the following line:\r\nhttps://github.com/username_1/Craft-3-Mailjet/blob/711061078561f3cc8ed2656fa4aa1aeea93b938e/src/services/SmsService.php#L28\r\n\r\nThanks for your wonderful work on this plugin.", "title": "Missing void in SmsService leads to PHP Compile Error", "type": "issue" }, { "action": "created", "author": "bertoost", "comment_id": 634500441, "datetime": 1590566862000, "masked_author": "username_1", "text": "Good catch! It was added in the last update, without checking sub classes.\r\nWill fix is later today. Thanks! ๐Ÿ‘", "title": null, "type": "comment" }, { "action": "created", "author": "menberg", "comment_id": 634569128, "datetime": 1590574893000, "masked_author": "username_0", "text": "Thank you. Wonderful. Might there be also a chance to review https://github.com/username_1/Craft-3-Mailjet/pull/2 by the way? Thanks and have a nice day!", "title": null, "type": "comment" }, { "action": "created", "author": "bertoost", "comment_id": 634573475, "datetime": 1590575492000, "masked_author": "username_1", "text": "Yes. Thanks.", "title": null, "type": "comment" }, { "action": "closed", "author": "bertoost", "comment_id": null, "datetime": 1590612140000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "bertoost", "comment_id": 634928241, "datetime": 1590612148000, "masked_author": "username_1", "text": "Released soon!", "title": null, "type": "comment" } ]
2
6
787
false
false
787
true
weaveworks/flux
weaveworks
260,590,363
753
{ "number": 753, "repo": "flux", "user_login": "weaveworks" }
[ { "action": "opened", "author": "sambooo", "comment_id": null, "datetime": 1506425517000, "masked_author": "username_0", "text": "This change adds a new subject to the message bus which is generated by hashing the (giturl, branch) pair for each connecting fluxd, and adds methods to notify those fluxds to sync when notified by Github.", "title": "Add methods to receive Github push notifications", "type": "issue" }, { "action": "created", "author": "squaremo", "comment_id": 342864820, "datetime": 1510157146000, "masked_author": "username_1", "text": "Can this be transplanted to service/ ?", "title": null, "type": "comment" }, { "action": "created", "author": "sambooo", "comment_id": 342866517, "datetime": 1510157446000, "masked_author": "username_0", "text": "Yes indeed. I'll add it to my list.", "title": null, "type": "comment" }, { "action": "created", "author": "squaremo", "comment_id": 342868283, "datetime": 1510157758000, "masked_author": "username_1", "text": "Closing in the meantime ..", "title": null, "type": "comment" } ]
2
4
304
false
false
304
false
QuantConnect/Lean
QuantConnect
750,725,342
4,963
{ "number": 4963, "repo": "Lean", "user_login": "QuantConnect" }
[ { "action": "opened", "author": "cnaccio", "comment_id": null, "datetime": 1606302666000, "masked_author": "username_0", "text": "#### Description\r\nFixed Python runtime issue that was occurring when trying to generate reports locally on OSX/mono, but assume the issue impacts all configurations.\r\n\r\n#### Related Issue\r\nCloses #4962\r\n\r\n#### Motivation and Context\r\nSolves tie bug report above\r\n\r\n#### Requires Documentation Change\r\nI updated the readme as part of this PR, but other documentation may need to be updated as well?\r\n\r\n#### How Has This Been Tested?\r\nRan tests locally after applying fix. Mac/OSX, Visual Studio for Mac, Mono\r\n\r\n#### Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Refactor (non-breaking change which improves implementation)\r\n- [ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Non-functional change (xml comments/documentation/etc)", "title": "Fixed Python runtime issue with local report generation", "type": "issue" }, { "action": "created", "author": "Martin-Molinero", "comment_id": 743482104, "datetime": 1607729783000, "masked_author": "username_1", "text": "Thanks @username_0, we cherry picked the commit into PR https://github.com/QuantConnect/Lean/pull/5014, closing this one", "title": null, "type": "comment" } ]
2
2
1,113
false
false
1,113
true
trailofbits/blight
trailofbits
765,830,289
15,959
null
[ { "action": "opened", "author": "13140772047", "comment_id": null, "datetime": 1607916336000, "masked_author": "username_0", "text": "ๅคง่ฟžๅธ‚ไธญๅฑฑๅŒบๅ“ช้‡Œๆœ‰็œŸๅฎžๅคงไฟๅฅ(ๆ‰พ็‰น่‰ฒๆœๅŠกๅฆนๅญ(ๅๅพฎIO77I9O9)ๆ—ฉๅ‰๏ผŒ็ฝ‘ๅ‹ๅœจไผ—ๆธ…็ฉฟๅฐ่ฏดไน‹ไธญ๏ผŒ่ฏ„้€‰ๅ‡บๆธ…็ฉฟไธ‰ๅบงๅคงๅฑฑ๏ผŒๅนถๅ…ˆๅŽ่ขซๆ‹ๆˆ็”ต่ง†ๅ‰ง๏ผŒ่ฟ™ไธ‰้ƒจไฝœๅ“ๅฐฑๆ˜ฏใ€ŠๆญฅๆญฅๆƒŠๅฟƒใ€‹ใ€ใ€Š็‹ฌๆญฅๅคฉไธ‹ใ€‹ๅ’Œๆœ€่ฟ‘ๆญฃๅœจ็ƒญๆ’ญ็š„ใ€Šๆขฆๅ›žใ€‹ใ€‚ใ€Šๆขฆๅ›žใ€‹็š„ไธปๆผ”้˜ตๅฎน๏ผŒๅŒ…ๆ‹ฌๅฅณไธ€ๅทๆŽๅ…ฐ่ฟชๅœจๅ†…้ƒฝๆ˜ฏๆธ…ไธ€่‰ฒ็š„ๅนด่ฝปๆ–ฐไบบๆผ”ๅ‘˜๏ผŒ้ข‡ๅ…ทๆ–ฐ้ฒœๆ„Ÿใ€‚ๅพˆๅคšไบบ่กจ็คบ๏ผŒ่ฟ™้ƒจๅ‰งไนŸ่ฎธไผšๆˆไธบ้’ๆ˜ฅ็‰ˆ็š„ใ€ŠๆญฅๆญฅๆƒŠๅฟƒใ€‹๏ผŒ่€ŒๆŽๅ…ฐ่ฟชๅœจๅ‰งไธญ็š„่กจ็ŽฐไนŸไปค็ฒ‰ไธๅคงๅ‘ผ็›ด็ˆฝใ€ๅฏ็ˆฑใ€‚่ตฐๅ‡บ็”ต่ง†ๅ‰ง็š„ๆ‹ๆ‘„๏ผŒๆŽๅ…ฐ่ฟชๆˆๅŠŸ็˜ฆ่บซๅนถ็€ไธ€่ขญ็บข่ฃ™ไธŽ้ซ˜่ทŸ้ž‹๏ผŒๅ‡บๅธญๆตทๅ—ๅฒ›ๅ›ฝ้™…็”ตๅฝฑ่Š‚ใ€‚้ป‘่‰ฒ็š„้•ฟ็›ดๅ‘ๆŠซ่‚ฉ๏ผŒไธ€ๅผ ็™ฝ็š™้€š้€็š„่„ธ๏ผŒ็ฌ‘่ตทๆฅ็š„ๆ—ถๅ€™้žๅธธๆ˜Žๅชš๏ผŒๅ……ๆปกไบ†ๅŠจไบบ็š„ๅฐ‘ๅฅณๆฐ”ๆฏใ€‚ไธ€่ขญไผ˜้›…ๆ˜Ž่‰ณ็š„็บข่‰ฒๆŠน่ƒธ่ฃ™๏ผŒ่กฌๅพ—่‚คๅฆ‚็™ฝ้›ชใ€ๆ˜Ž่‰ณๅŠจไบบ๏ผŒๆญ้…ไธŠ๏ผŒๆ›ดๆ˜พ็พŽ่…ฟ็บค้•ฟ๏ผŒๆฐ”ๅœบๆปกๅˆ†ใ€‚่ฟ™ๅŒไธบ้€ ๅž‹ๅขž่‰ฒ็š„้ซ˜่ทŸ้ž‹๏ผŒๆ‹ฅๆœ‰ๅผ ๆ‰ฌ็š„้ขœ่‰ฒไธŽ็บค็ป†ๅฆฉๅชš็š„็บฟๆก๏ผŒๆ›ดๆœ‰้—ช่€€็‚น็ผ€็š„ๆฐดๆ™ถ่ฎฉๆญฅไผ็† ็† ็”Ÿ่พ‰ใ€‚ๅŽปๅนด้ฆ–ๅบฆๆŽจๅ‡บ็š„ๆฐดๆ™ถ้”้“พๆทฑๅ—็Ÿฅๅ่‰บไบบไธŽๆ—ถๅฐš่พพไบบ็š„ๅ–œ็ˆฑ๏ผŒ็ปๅ…ธๆฐดๆ™ถ่ฃน่ฆ†็€้”้“พ่ฎพ่ฎกไธๆ–ญ็š„ๆˆไธบ็บขๆฏฏไธŽ้•ๅ…‰็ฏไธ‹็š„้—ชไบฎ็„ฆ็‚นใ€‚ๅ…จๆ–ฐ้ซ˜่ทŸ้ž‹็ผฉๅฐไบ†้“พๆกๅฐบๅฏธ๏ผŒ็”จ็ป†่‡ด็š„ๅฐ้”้“พ็ปฝๆ”พ่€€็›ฎ็’€็’จ๏ผŒๅนถไปฅ่‚†ๆ„ๅผ ๆ‰ฌ็š„็บข่‰ฒ้‡‘ๅฑžๅ…‰ไบฎ้ข็šฎ้ฉๅˆถไฝœ้ž‹ไฝ“๏ผŒ่ฎฉๆฏๆฌกๅ‡บๅœบ้ƒฝๆˆไธบๅผ•ไบบ็žฉ็›ฎ็š„ๆ—ถ้ซฆ็„ฆ็‚นใ€‚ๅ•ไบคๅญ”ๆฆ”ๅฃฎๅ’ŒๆตŽๅญ•ๆพˆ็ญ‰ๆชฌๅƒฌ็™ป็ง‘็ง‘https://github.com/trailofbits/blight/issues/10265?iqotf <br />https://github.com/trailofbits/blight/issues/7355?qiuju <br />https://github.com/trailofbits/blight/issues/4481?pqmpi <br />https://github.com/trailofbits/blight/issues/1737?15314 <br />https://github.com/trailofbits/blight/issues/7324?zioxs <br />mkkvtvikxnkqkyxkaxuhlwoqg", "title": "ๅคง่ฟžๅธ‚ไธญๅฑฑๅŒบๅ“ชๆœ‰็‰นๆฎŠๆœๅŠก็š„ๆด—ๆตดb", "type": "issue" } ]
1
1
823
false
false
823
false
haskell/stm
haskell
275,533,747
2
{ "number": 2, "repo": "stm", "user_login": "haskell" }
[ { "action": "opened", "author": "arybczak", "comment_id": null, "datetime": 1511220312000, "masked_author": "username_0", "text": "Details: https://ghc.haskell.org/trac/ghc/ticket/14494", "title": "Fix space leak in TBQueue (#14494)", "type": "issue" }, { "action": "created", "author": "bgamari", "comment_id": 346228138, "datetime": 1511319243000, "masked_author": "username_1", "text": "Yes, this looks reasonable to me.", "title": null, "type": "comment" }, { "action": "created", "author": "qrilka", "comment_id": 353870630, "datetime": 1514209642000, "masked_author": "username_2", "text": "@username_1 when could we see a Hackage release with this fix?", "title": null, "type": "comment" }, { "action": "created", "author": "bgamari", "comment_id": 354170588, "datetime": 1514405234000, "masked_author": "username_1", "text": "I don't currently have the ability to upload `stm` releases. I believe @username_3 does, however. Herbert, could you upload a new release or add me as a maintainer?", "title": null, "type": "comment" }, { "action": "created", "author": "hvr", "comment_id": 354171349, "datetime": 1514405583000, "masked_author": "username_3", "text": "@username_1 I can happily take care; I see that #1 needs merging; is there anything else you can think of that we may want to add/change in `stm` in the next 2-3 months?", "title": null, "type": "comment" }, { "action": "created", "author": "bgamari", "comment_id": 357339378, "datetime": 1515787210000, "masked_author": "username_1", "text": "Nope, not that I can think of off-hand.", "title": null, "type": "comment" } ]
4
6
508
false
false
508
true
maxcountryman/flask-login
null
642,138,181
513
null
[ { "action": "opened", "author": "brassy-endomorph", "comment_id": null, "datetime": 1592589367000, "masked_author": "username_0", "text": "I would like to use `Flask-Login` for an application that allows a user to have multiple distinct sessions, and I want to be able to expose this in a view by storing session metadata in the table. My models and user loader would look like this.\r\n\r\n```python\r\n# db.py\r\nclass User(UserMixin, db.Model):\r\n id = db.Column(db.Integer, ...)\r\n \r\nclass SessionToken(db.Model):\r\n token_id = db.Column(db.String, ...)\r\n user_id = db.Column(db.Integer, ForeignKey('User.id'), ...)\r\n created_at = db.Column(db.DateTime, ...)\r\n user_agent = db.Column(db.String, ...)\r\n user = relationship('User', backref='session_tokens')\r\n\r\n# app.py\r\n@flask_login.user_loader\r\ndef load_user(session_id):\r\n t = SesstionToken.query.get(session_id)\r\n if t:\r\n return t.user\r\n```\r\n\r\nHowever, there is no way to use the `User` object plus `get_id` to be able to reliably get back to the current token. Is this pattern supported, and if not, is it possible to support that?", "title": "Pattern for many sessions to one user", "type": "issue" }, { "action": "created", "author": "lzjun567", "comment_id": 825694222, "datetime": 1619187775000, "masked_author": "username_1", "text": "+1", "title": null, "type": "comment" }, { "action": "created", "author": "davidism", "comment_id": 825715943, "datetime": 1619189797000, "masked_author": "username_2", "text": "Override `User.get_id` to return the appropriate session token. It should return whatever id is needed to load the session again. Not knowing more about how exactly you want things to work, there's not more we can say here, but nothing in Flask-Login should be preventing this.", "title": null, "type": "comment" }, { "action": "closed", "author": "davidism", "comment_id": null, "datetime": 1619189798000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "lzjun567", "comment_id": 826088834, "datetime": 1619268898000, "masked_author": "username_1", "text": "```python\r\nclass User(UserMixin, db.Model):\r\n id = db.Column(db.Integer, ...)\r\n\r\nclass SessionToken(BaseModel, UserMixin):\r\n __tablename__ = 'news_logintoken'\r\n token = db.Column(db.String(32), index=True)\r\n ip = db.Column(db.String(32))\r\n ua = db.Column(db.String(500))\r\n user_id = db.Column(db.Integer,\r\n db.ForeignKey('news_registeruser.id'),\r\n nullable=False)\r\n user = db.relationship('User',\r\n backref=db.backref('tokens', lazy=True, uselist=False))\r\n\r\n def get_id(self):\r\n return self.token\r\n\r\n\r\n@login_manager.user_loader\r\ndef load_user(token):\r\n \r\n login_token = SessionToken.query.filter(SessionToken.token == token).first()\r\n return login_token\r\n\r\n\r\n# real user for User model\r\nuser = current_user.user\r\n```", "title": null, "type": "comment" } ]
3
5
2,086
false
false
2,086
false
Estia-advanced-programming/issue-updater
Estia-advanced-programming
577,530,671
71
null
[ { "action": "closed", "author": "dhmmasson", "comment_id": null, "datetime": 1583687941000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
2
2
161
false
true
0
false
amplication/amplication
amplication
736,223,150
757
{ "number": 757, "repo": "amplication", "user_login": "amplication" }
[ { "action": "opened", "author": "meeroslava", "comment_id": null, "datetime": 1604505037000, "masked_author": "username_0", "text": "", "title": "Design System: Added Button stories, deleted eventData from the Button component", "type": "issue" }, { "action": "created", "author": "iddan", "comment_id": 722352600, "datetime": 1604579972000, "masked_author": "username_1", "text": "Awesome! Please resolve conflicts", "title": null, "type": "comment" } ]
2
2
33
false
false
33
false
AprilRobotics/apriltag_ros
AprilRobotics
791,564,935
89
null
[ { "action": "opened", "author": "canberkgurel", "comment_id": null, "datetime": 1611271446000, "masked_author": "username_0", "text": "The transformation from tag0 to map was defined, it gets preempted when `continuous_detection.launch` starts running. Why do I need to define the transformation from `/map` to `/camera`? That's the unknown in my equation, it needs to be estimated fusing `/map` >> `/tag0` >> `/camera` transformations.", "title": "No transformation from <..> to <..> error when continuous_detection.launch is executed.", "type": "issue" }, { "action": "created", "author": "Nosille", "comment_id": 772737153, "datetime": 1612378255000, "masked_author": "username_1", "text": "Hope I can explain this well. \r\n\r\nwhen using tf2, transforms have a defined direction from parent->child, and each child can only have one parent. You have defined map->tag0 and are expecting AprilTags to define the transform from tag0->camera, but AprilTags is actually defining a transform from camera->tag0 which conflicts your definition of tag0's parent. It would be necessary to go into the Apriltag code and reverse the direction of the transform to achieve what you are attempting.", "title": null, "type": "comment" }, { "action": "created", "author": "canberkgurel", "comment_id": 774540030, "datetime": 1612643846000, "masked_author": "username_0", "text": "this doesn't make sense to me, if a map-to-tag transformation is defined then the tag-to-map is also defined -- which happens to be the inverse of the original transformation. So are you telling me that I need to define two separate static_transform_publishers one from map-to-tag and another from tag-to-map ?", "title": null, "type": "comment" }, { "action": "created", "author": "Nosille", "comment_id": 774559275, "datetime": 1612654009000, "masked_author": "username_1", "text": "Just like the publisher that you setup, Apriltags_ros relies on the tf2_ros package (http://wiki.ros.org/tf2) for transforms. This directionality in the parent->child definition comes from that package. I suggest reading its documentation for the how and why. I think it mostly comes down to making it impossible to create loops in the tf tree. If there are multiple paths between frames in the tf tree, which one is right? This one parent, multiple children rule prevents that problem.\r\n\r\nApriltags_ros's authors simply assumed that the camera was already in the tf tree and the tag was not. Therefore, it is coded to generate the camera->tag transform. If you want it the other way, I suggest finding the line of code that calls the tf_publisher and reversing the transform. It is located in the block of code starting at line 390 in common_functions.cpp. You will need to both invert the transform, and swap camera_tf_frame_ and detection_names[i] in the call to send_transform.", "title": null, "type": "comment" }, { "action": "closed", "author": "rgreid", "comment_id": null, "datetime": 1612681870000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "rgreid", "comment_id": 774618921, "datetime": 1612681870000, "masked_author": "username_2", "text": "Would you like to update the documentation here http://wiki.ros.org/apriltag_ros to clarify?\r\n\r\nFeel free to reopen if you have other questions! Cheers.", "title": null, "type": "comment" }, { "action": "created", "author": "shawkontzu", "comment_id": 936934738, "datetime": 1633547435000, "masked_author": "username_3", "text": "I agree that the transformation /camera -> /apriltags can be a little confusing when we want to fuse the apriltag pose to robot_localization. Since tf only allows each frame to have a single parent frame, and a common tf tree is something similar to this\r\n\r\n`/world -> /map -> /odom -> /base_link -> /camera_link -> /apriltags`\r\n\r\nWe have the ground truth /map -> /apriltags and we have the predicted transformation /camera_link -> /apriltags, but what we want is /map -> /base_link and fuse this pose information to robot_localization. One approach I could think of is since\r\n\r\n`Tmap->apriltags = Tmap->base_link * Tbase_link->camera_link * Tcamera_link->apriltags`\r\n\r\nso \r\n\r\n`Tmap->base_link = Tmap->apriltags * (Tcamera_link->apriltag)^-1 * (Tbase_link->camera_link)^-1`\r\n\r\nWe can name this calculated pose data to something like /landmark, and set a 0 transformation from /base_link -> /landmark, now tf tree knows that the new pose information /landmark has 0 transformation from /base_link, we just need to publish the calculated /landmark for fusing the apriltag data. This seems to be a workaround if we want to use apriltags for robot localization.", "title": null, "type": "comment" } ]
4
7
3,403
false
false
3,403
false
ArctosDB/arctos
ArctosDB
735,773,811
3,189
null
[ { "action": "opened", "author": "ewommack", "comment_id": null, "datetime": 1604458822000, "masked_author": "username_0", "text": "Issue Documentation is http://handbook.arctosdb.org/how_to/How-to-Use-Issues-in-Arctos.html\r\n\r\n**Goal**\r\nI'm not actually sure if this should be a part, but I have a Porcupine quill removed from the knee joint of a Mountain Lion during prep. The quill was saved, and I would like to include it some how with the specimen record. \r\n\r\nWould this be more discoverable as its own part, or maybe it is such an odd occurrence it should just be listed as an unknown part or hair?\r\n\r\n\r\n**Table**\r\n[Mammal parts](https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name&coln=Mamm)\r\n\r\n**Value**\r\nQuill\r\n\r\n**Definition**\r\nhttps://www.sciencemag.org/news/2012/12/porcupine-quills-reveal-their-prickly-secrets#:~:text=Porcupines%20are%20famed%20for%20their,the%20animals%20against%20natural%20predators.&text=The%20North%20American%20porcupine%20has,or%20so%20nearest%20its%20tip.\r\n\r\n**Collection type**\r\nMamm", "title": "Code Table Request - Mammal Part - Quill", "type": "issue" }, { "action": "created", "author": "campmlc", "comment_id": 721826513, "datetime": 1604506459000, "masked_author": "username_1", "text": "This seems reasonable.", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 721829098, "datetime": 1604506720000, "masked_author": "username_2", "text": "https://github.com/ArctosDB/arctos/issues/2423 is relevant", "title": null, "type": "comment" }, { "action": "created", "author": "campmlc", "comment_id": 721832010, "datetime": 1604507010000, "masked_author": "username_1", "text": "So that would be part = \"hair\", part attribute = \"quill\"?\nUnder that data structure, if someone searches for \"quill\" via the part\nname, will they be able to find it, even though the data is in part\nattribute? If not, how will people know to search under attributes vs part\nname?", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 721853205, "datetime": 1604509207000, "masked_author": "username_2", "text": "That's just a UI problem - somewhat similar to what we do for taxonomy, might have a similar solution.", "title": null, "type": "comment" }, { "action": "created", "author": "campmlc", "comment_id": 721857541, "datetime": 1604509639000, "masked_author": "username_1", "text": "It would be good if \" just a UI problem\" could be followed by an acceptable\nUI solution.", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 722449221, "datetime": 1604590066000, "masked_author": "username_3", "text": "@AJLinn I would catalog the quill as a separate item and relate it to the mountain lion. As for the part name quill - I think we should add it until we have a real method for simplifying part names.", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 722463841, "datetime": 1604591491000, "masked_author": "username_2", "text": "No objections.", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 722493586, "datetime": 1604594349000, "masked_author": "username_3", "text": "So - changing my stance and suggesting that @username_0 use \"spine\" as the part name.", "title": null, "type": "comment" }, { "action": "created", "author": "campmlc", "comment_id": 722515750, "datetime": 1604596530000, "masked_author": "username_1", "text": "My issue with that is searchability. Will anyone know to search on \"spine\"\nwhen looking for quill? How do we allow searches on taxon specific terms if\nthey are lumped under terms that are not typically used?", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 722548351, "datetime": 1604599858000, "masked_author": "username_3", "text": "quill isn't in the code table - so you cannot search it. How many people will be looking for just \"quill\"?", "title": null, "type": "comment" }, { "action": "created", "author": "campmlc", "comment_id": 722572574, "datetime": 1604602425000, "masked_author": "username_1", "text": "Well, if I wanted to find a quill, I would type quill in part name. I would\nnot know to type spine or hair. This is where perhaps a part ontology with\nsynonyms would be useful. In the meantime, I would suggest we add quill as\na part name or attribute, but if we do it as an attribute, make a general\nsearch in the UI which would search for both. But we know that solution\ncreates timeout issues.", "title": null, "type": "comment" }, { "action": "created", "author": "ewommack", "comment_id": 724139979, "datetime": 1604940949000, "masked_author": "username_0", "text": "Ok, I'll find the quill and get it as its own catalog item...Is that the idea.\r\nI always thought this was going to be a one off thing, but I think we pulled another possible one out of a Black Bear this year. The more whole carnivore preps we do, we may find more...", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 724150998, "datetime": 1604942087000, "masked_author": "username_3", "text": "@username_0 are you OK with spine or do you still want quill?", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 724157733, "datetime": 1604942778000, "masked_author": "username_2", "text": "We probably need a new value for https://arctos.database.museum/info/ctDocumentation.cfm?table=ctid_references as well.", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 730685234, "datetime": 1605826140000, "masked_author": "username_3", "text": "code table committee says add quill", "title": null, "type": "comment" }, { "action": "created", "author": "Jegelewicz", "comment_id": 730686375, "datetime": 1605826324000, "masked_author": "username_3", "text": "done", "title": null, "type": "comment" }, { "action": "closed", "author": "Jegelewicz", "comment_id": null, "datetime": 1605826325000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ewommack", "comment_id": 730703131, "datetime": 1605828752000, "masked_author": "username_0", "text": "Thanks @username_3. I pivoted away when another collection needed work, and haven't managed enough time to get back to this now. Thanks for working on it for me!", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 962259725, "datetime": 1636151621000, "masked_author": "username_2", "text": "I'm putting this on the AWG agenda (or I'm trying to - @username_3 does the project still do that?). I don't have a solution for this particular situation, but I don't think a single hidden part should have this level of impact; this affects 1 of 727 authority values but only applies to 1 of 5,819,594 parts", "title": null, "type": "comment" }, { "action": "created", "author": "ewommack", "comment_id": 962282638, "datetime": 1636156120000, "masked_author": "username_0", "text": "Add it to the google doc. The Agenda is already made up for the next meeting :).\r\n\r\nI just did a search of quill from parts on the search page and only found 20 things...all either of porcupines or made from porcupine quills: https://arctos.database.museum/saved/1636156071952_quill%20part", "title": null, "type": "comment" }, { "action": "created", "author": "dustymc", "comment_id": 963640057, "datetime": 1636411222000, "masked_author": "username_2", "text": "Only one of them involves part_name=quill.", "title": null, "type": "comment" }, { "action": "created", "author": "ewommack", "comment_id": 963695436, "datetime": 1636417312000, "masked_author": "username_0", "text": "https://docs.google.com/document/d/1rGOyFMxQGiLA5xr0pBoVjO3of9LSzEjU_wheLvPqWhI/edit?usp=sharing", "title": null, "type": "comment" } ]
4
23
3,852
false
false
3,852
true
MicrosoftDocs/office-docs-powershell
MicrosoftDocs
792,354,779
7,152
null
[ { "action": "opened", "author": "soysoliscarlos", "comment_id": null, "datetime": 1611355753000, "masked_author": "username_0", "text": "New-ComplianceSearchAction -SearchNames $EmailToExport -Format Fxstream -NotifyEmail $NotifyEmail -Export\r\nA parameter cannot be found that matches parameter name 'Format'.\r\n + CategoryInfo : InvalidArgument: (:) [New-ComplianceSearchActi\r\n on], ParameterBindingException\r\n + FullyQualifiedErrorId : NamedParameterNotFound,New-ComplianceSearchAct\r\n ion\r\n + PSComputerName : nam11b.ps.compliance.protection.outlook.com\r\n\r\n\r\n$PSVersionTable\r\n\r\nName Value\r\n---- -----\r\nPSVersion 5.1.19041.610\r\nPSEdition Desktop\r\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}\r\nBuildVersion 10.0.19041.610\r\nCLRVersion 4.0.30319.42000\r\nWSManStackVersion 3.0\r\nPSRemotingProtocolVersion 2.3\r\nSerializationVersion 1.1.0.1\r\n\r\n\r\nGet-Command New-ComplianceSearchAction\r\n\r\nCommandType Name Version Source\r\n----------- ---- ------- ------\r\nFunction New-ComplianceSearchAction 1.0 tmp_gteabhwb.a2d", "title": "New-ComplianceSearchAction Not found parameters \"Format\" or \"Export\"", "type": "issue" }, { "action": "closed", "author": "soysoliscarlos", "comment_id": null, "datetime": 1611505499000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
1,209
false
false
1,209
false
ponyorm/pony
ponyorm
655,978,487
529
null
[ { "action": "opened", "author": "kostyachum", "comment_id": null, "datetime": 1594657307000, "masked_author": "username_0", "text": "The setup is very simple\r\n\r\nmodel\r\n```python\r\nclass Post(db.Entity):\r\n id = PrimaryKey(UUID, auto=True)\r\n title = Optional(str)\r\n```\r\n\r\n\r\ncode:\r\n```python\r\n@db_session\r\ndef test(text: str, limit: int = 20):\r\n set_sql_debug(True)\r\n return Post.select(lambda p: raw_sql(f\"'{by_post.title}' <% (title || ' ' || description)\"))\r\n```\r\n\r\nthe SQL produces is completely fine and runs as expected, by evaluating the lazy queryset crashes with the next error:\r\n```\r\nINFO:pony.orm:GET CONNECTION FROM THE LOCAL POOL\r\nINFO:pony.orm:SWITCH TO AUTOCOMMIT MODE\r\nINFO:pony.orm.sql:SELECT \"p\".\"id\", \"p\".\"user_id\", \"p\".\"created_at\", \"p\".\"title\", \"p\".\"type\", \"p\".\"location\", \"p\".\"description\"\r\nFROM \"post\" \"p\"\r\nWHERE 'sale' % (title || ' ' || description)\r\n---------------------------------------------------------------------------\r\nTypeError Traceback (most recent call last)\r\n<ipython-input-3-dcf7bea12933> in <module>\r\n----> 1 test('sale')[:]\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in __getitem__(query, key)\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/utils/utils.py in cut_traceback(func, *args, **kwargs)\r\n 76 if module_name.startswith('pony.utils') and tb.tb_frame.f_code.co_name == 'throw':\r\n 77 reraise(exc_type, exc, last_pony_tb)\r\n---> 78 reraise(exc_type, exc, full_tb)\r\n 79 finally:\r\n 80 del exc, full_tb, tb, last_pony_tb\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/utils/utils.py in reraise(***failed resolving arguments***)\r\n 93 else:\r\n 94 def reraise(exc_type, exc, tb):\r\n---> 95 try: raise exc.with_traceback(tb)\r\n 96 finally: del exc, tb\r\n 97 \r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/utils/utils.py in cut_traceback(func, *args, **kwargs)\r\n 59 return func(*args, **kwargs)\r\n 60 \r\n---> 61 try: return func(*args, **kwargs)\r\n 62 except AssertionError: raise\r\n 63 except Exception:\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in __getitem__(query, key)\r\n 6182 if stop is None:\r\n 6183 if not start:\r\n-> 6184 return query._fetch()\r\n 6185 else:\r\n 6186 return query._fetch(limit=None, offset=start)\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in _fetch(query, limit, offset, lazy)\r\n 6189 return query._fetch(limit=stop-start, offset=start)\r\n 6190 def _fetch(query, limit=None, offset=None, lazy=False):\r\n-> 6191 return QueryResult(query, limit, offset, lazy=lazy)\r\n 6192 @cut_traceback\r\n 6193 def fetch(query, limit=None, offset=None):\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in __init__(self, query, limit, offset, lazy)\r\n 6296 self._limit = limit\r\n 6297 self._offset = offset\r\n-> 6298 self._items = None if lazy else self._query._actual_fetch(limit, offset)\r\n 6299 self._expr_type = translator.expr_type\r\n 6300 self._col_names = translator.col_names\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in _actual_fetch(query, limit, offset)\r\n 5829 items = cache.query_results.get(query_key)\r\n 5830 if items is None:\r\n-> 5831 cursor = database._exec_sql(sql, arguments)\r\n 5832 if isinstance(translator.expr_type, EntityMeta):\r\n 5833 entity = translator.expr_type\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in _exec_sql(database, sql, arguments, returning_id, start_transaction)\r\n 947 try: new_id = provider.execute(cursor, sql, arguments, returning_id)\r\n 948 except Exception as e:\r\n--> 949 connection = cache.reconnect(e)\r\n 950 cursor = connection.cursor()\r\n 951 if local.debug: log_sql(sql, arguments)\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in reconnect(cache, exc)\r\n 1782 if exc is not None:\r\n 1783 exc = getattr(exc, 'original_exc', exc)\r\n-> 1784 if not provider.should_reconnect(exc): reraise(*sys.exc_info())\r\n 1785 if local.debug: log_orm('CONNECTION FAILED: %s' % exc)\r\n 1786 connection = cache.connection\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/utils/utils.py in reraise(***failed resolving arguments***)\r\n 93 else:\r\n 94 def reraise(exc_type, exc, tb):\r\n---> 95 try: raise exc.with_traceback(tb)\r\n 96 finally: del exc, tb\r\n 97 \r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/core.py in _exec_sql(database, sql, arguments, returning_id, start_transaction)\r\n 945 provider = database.provider\r\n 946 t = time()\r\n--> 947 try: new_id = provider.execute(cursor, sql, arguments, returning_id)\r\n 948 except Exception as e:\r\n 949 connection = cache.reconnect(e)\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/dbproviders/postgres.py in execute(provider, cursor, sql, arguments, returning_id)\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/dbapiprovider.py in wrap_dbapi_exceptions(func, provider, *args, **kwargs)\r\n 50 try:\r\n 51 if provider.dialect != 'SQLite':\r\n---> 52 return func(provider, *args, **kwargs)\r\n 53 else:\r\n 54 provider.local_exceptions.keep_traceback = True\r\n\r\n~/.virtualenvs/cri/lib/python3.8/site-packages/pony/orm/dbproviders/postgres.py in execute(provider, cursor, sql, arguments, returning_id)\r\n 254 else:\r\n 255 if arguments is None: cursor.execute(sql)\r\n--> 256 else: cursor.execute(sql, arguments)\r\n 257 if returning_id: return cursor.fetchone()[0]\r\n 258 \r\n\r\nTypeError: dict is not a sequence\r\n```\r\n\r\n\r\npg_trgm docs for reference: https://www.postgresql.org/docs/12/pgtrgm.html", "title": "Crash when using \"text % text\" filtering of pg_trgm", "type": "issue" } ]
1
1
6,040
false
false
6,040
false
microsoft/TypeScript
microsoft
479,894,608
32,833
null
[ { "action": "opened", "author": "mjbvz", "comment_id": null, "datetime": 1565652822000, "masked_author": "username_0", "text": "<!-- ๐Ÿšจ STOP ๐Ÿšจ ๐—ฆ๐—ง๐—ข๐—ฃ ๐Ÿšจ ๐‘บ๐‘ป๐‘ถ๐‘ท ๐Ÿšจ\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.6.0-dev.20190810Debug Failure. False expression: Token end is child end\r\n\r\n<!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n\r\n**Code**\r\n\r\nFor the code:\r\n\r\n```ts\r\nconsole.log(1)\r\nconsole.log(2)\r\nconsole.log(3)\r\nconsole.log(4)\r\nconsole.log(5)\r\nconsole.log(6)\r\n\r\nclass A {}\r\n\r\nclass B extends A {\r\n constructor() {1;}\r\n}\r\n```\r\n\r\n1. Trigger the `add missing super call` in the constructor of `B`\r\n\r\n**Expected behavior:**\r\nA quick fix is returned that changes the code to:\r\n\r\n```ts\r\nconsole.log(1)\r\nconsole.log(2)\r\nconsole.log(3)\r\nconsole.log(4)\r\nconsole.log(5)\r\nconsole.log(6)\r\n\r\nclass A {}\r\n\r\nclass B extends A {\r\n constructor() {\r\n super();\r\n 1;\r\n }\r\n}\r\n```\r\n\r\n**Actual behavior:**\r\nNo quick fixes returned. See this TS server error in the console:\r\n\r\n```\r\nTypeScript Server Error (3.6.0-dev.20190810)\r\nDebug Failure. False expression: Token end is child end\r\nError: Debug Failure. False expression: Token end is child end\r\n at processChildNode (tsserver.js:113342:34)\r\n at tsserver.js:113289:21\r\n at visitNode (tsserver.js:16956:24)\r\n at Object.forEachChild (tsserver.js:17202:24)\r\n at processNode (tsserver.js:113288:20)\r\n at processChildNode (tsserver.js:113348:21)\r\n at processChildNodes (tsserver.js:113399:48)\r\n at tsserver.js:113291:21\r\n at visitNodes (tsserver.js:16961:24)\r\n at Object.forEachChild (tsserver.js:17191:24)\r\n at processNode (tsserver.js:113288:20)\r\n at formatSpanWorker (tsserver.js:113103:17)\r\n at tsserver.js:113067:140\r\n at Object.getFormattingScanner (tsserver.js:111860:23)\r\n at Object.formatNodeGivenIndentation (tsserver.js:113067:31)\r\n at getFormattedTextOfNode (tsserver.js:115103:45)\r\n at format (tsserver.js:115081:52)\r\n at computeNewText (tsserver.js:115084:23)\r\n at tsserver.js:115054:89\r\n at Array.map (<anonymous>)\r\n at tsserver.js:115053:50\r\n at Array.map (<anonymous>)\r\n at Object.getTextChangesFromChanges (tsserver.js:115039:86)\r\n at ChangeTracker.getChanges (tsserver.js:115009:45)\r\n at Function.ChangeTracker.with (tsserver.js:114544:32)\r\n at Object.getCodeActions (tsserver.js:119357:64)\r\n at tsserver.js:115564:121\r\n at Object.flatMap (tsserver.js:583:25)\r\n at Object.getFixes (tsserver.js:115564:23)\r\n at tsserver.js:125578:35\r\n```", "title": "Debug Failure. False expression: Token end is child end โ€”ย For add missing super call quick fix", "type": "issue" }, { "action": "created", "author": "andrewbranch", "comment_id": 531946283, "datetime": 1568665943000, "masked_author": "username_1", "text": "Related: #32862", "title": null, "type": "comment" }, { "action": "created", "author": "orta", "comment_id": 555569581, "datetime": 1574178618000, "masked_author": "username_2", "text": "Looks like this has been fixed at some point in 3.7\r\n\r\n![924F2704-FA1D-4731-A067-8F7EE1145078-42466-0003D0E4AB40B52F](https://user-images.githubusercontent.com/49038/69162189-4077a880-0aba-11ea-927f-b7a159cb756f.gif)", "title": null, "type": "comment" }, { "action": "closed", "author": "orta", "comment_id": null, "datetime": 1574178618000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]
3
4
3,242
false
false
3,242
false
byuoitav/ui
byuoitav
590,448,228
116
null
[ { "action": "opened", "author": "dannyrandall", "comment_id": null, "datetime": 1585587809000, "masked_author": "username_0", "text": "It may be the same for the microphones, but I can't see them on firefox :/\r\n\r\nSteps to recreate:\r\n1. Log into a room with dragonfruit, open the same control group on a Pi that has blueberry\r\n2. Mute one of them, see that it doesn't sync to the other display", "title": "Blueberry/Dragonfruit media audio mute doesn't sync", "type": "issue" }, { "action": "created", "author": "dannyrandall", "comment_id": 606763666, "datetime": 1585675369000, "masked_author": "username_0", "text": "It seems like the issue here is that the AV-API doesn't generate events setting mute to true correctly - they are missing the `affected-room` block, and therefore the events are never routed to BFF's subscribed to that room. I'll transfer this issue to [av-control-api](https://github.com/byuoitav/av-control-api).", "title": null, "type": "comment" } ]
1
2
571
false
false
571
false
jhk0530/aladin
null
771,343,219
259
null
[ { "action": "opened", "author": "jhk0530", "comment_id": null, "datetime": 1608369129000, "masked_author": "username_0", "text": "- 2020 ์‹œ๋‚˜๊ณต ๊ธฐ์ถœ๋ฌธ์ œ์ง‘ ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 1๊ธ‰ ์‹ค๊ธฐ\n- 2020 ์‹œ๋‚˜๊ณต ์ •๋ณด์ฒ˜๋ฆฌ๊ธฐ์‚ฌ ์‹ค๊ธฐ\n- 2020 ์‹œ๋‚˜๊ณต ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 2๊ธ‰ ์‹ค๊ธฐ\n- ์˜ค๋ Œ์ง€๋…ธ์˜ ์˜์ƒ ํŽธ์ง‘์„ ์œ„ํ•œ ์œ ํŠœ๋ธŒ ๋ฐฐ๊ฒฝ์Œ์•…\n- AI ๋งˆ์ธ๋“œ\n- Do it! ํด๋ก  ์ฝ”๋”ฉ ์˜ํ™” ํ‰์  ์›น์„œ๋น„์Šค\n- ํŽญ๊ท„๋ธŒ๋กœ์˜ 3๋ถ„ ๋”ฅ๋Ÿฌ๋‹, ํŒŒ์ดํ† ์น˜๋ง›\n- ํ•œ ๊ถŒ์œผ๋กœ ๋๋‚ด๋Š” ํŒŒ์ด์ฌ\n- 15์ดˆ๋ฉด ์ถฉ๋ถ„ํ•ด, ํ‹ฑํ†ก!\n- 2020 ์ด๊ธฐ์  ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 1๊ธ‰ ์‹ค๊ธฐ ๊ธฐ๋ณธ์„œ : ๋ฌด๋ฃŒ ๋™์˜์ƒ ์ „๊ฐ• & ์ฑ„์  ํ”„๋กœ๊ทธ๋žจ ์ œ๊ณต\n- 2020 ์ด๊ธฐ์  ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 2๊ธ‰ ์‹ค๊ธฐ ๊ธฐ๋ณธ์„œ\n- ์ง„์งœ ํ•˜๋ฃจ๋งŒ์— ๋๋‚ด๋Š” ํฌํ† ์ƒต\n- 2020 ์ด๊ธฐ์  ITQ ์•ก์„ธ์Šค ver.2010\n- 2020 ์ด๊ธฐ์  ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 1๊ธ‰ ์‹ค๊ธฐ ๊ธฐ์ถœ๋ฌธ์ œ์ง‘\n- ํ•œ ๊ถŒ์œผ๋กœ ๋๋‚ด๋Š” ๋…ธ์…˜ NOTION\n- ๋ฌธ๊ณผ์ƒ, ๋ฐ์ดํ„ฐ ์‚ฌ์ด์–ธํ‹ฐ์ŠคํŠธ ๋˜๋‹ค\n- ์ƒˆ๋กœ์šด ์งˆ์„œ\n- 2019 ๋ฆฌ๋ˆ…์Šค๋งˆ์Šคํ„ฐ 2๊ธ‰ ํ•ต์‹ฌ ๋งˆ์Šคํ„ฐ\n- ๋‚ด ์ธ๋ฒคํ† ๋ฆฌ์— ๊ตฌ๊ธ€์„ ๋‹ด๋‹ค\n- ์•Œ์ญ๋‹ฌ์ญ C ์–ธ์–ด 180์ œ\n- ํŒœ 1 : ์ง€ํ•˜ ๋†์žฅ\n- 2018 ์ปดํ“จํ„ฐ๊ทธ๋ž˜ํ”ฝ์Šค์šด์šฉ๊ธฐ๋Šฅ์‚ฌ ํ•„๊ธฐ ์ตœ๊ทผ 7๋…„๊ฐ„ ๊ธฐ์ถœ๋ฌธ์ œ\n- ํ•œ ๊ถŒ์œผ๋กœ ์‹œ์ž‘ํ•˜๋Š” ์†Œํ”„ํŠธ์›จ์–ด\n- 2020 ์‹œ๋‚˜๊ณต ์ด์ •๋ฆฌ ์ปดํ“จํ„ฐํ™œ์šฉ๋Šฅ๋ ฅ 2๊ธ‰ ํ•„๊ธฐ (8์ ˆ)\n- 2019 ์ด๊ธฐ์  ์ปดํ“จํ„ฐ๊ทธ๋ž˜ํ”ฝ์Šค์šด์šฉ๊ธฐ๋Šฅ์‚ฌ ์‹ค๊ธฐ ๊ธฐ๋ณธ์„œ - ์ „2๊ถŒ\n- ์ฝ”๋”ฉ๋งจ ์—”ํŠธ๋ฆฌ 1 : ๋ฒ„๊ทธํ‚น๋ค์˜ ์ฐจ์› ์นจ๋žต\n- ์ฝ”๋”ฉ๋งจ 7 : ๋””๋ฒ„๊น… VS ๋ฒ„๊ทธํ‚น๋ค\n- ํ† ํฐ ์ด์ฝ”๋…ธ๋ฏธ\n- ์‚๋”ฑํ•˜๊ฒŒ ๋ฐ”๋ผ๋ณธ 4์ฐจ ์‚ฐ์—…ํ˜๋ช…\n- ์ผ๋ ‰ํŠธ๋ก  ์˜์›…์ „ 2 (์‹คํ—˜ํ‚คํŠธ ๋ณ„๋งค)\n- ํ•˜์ดํผ๋ ˆ์ € ๋ธ”๋ก์ฒด์ธ ๊ฐœ๋ฐœ\n- ์ปดํ“จํŒ… ์‚ฌ๊ณ ๋ ฅ์œผ๋กœ ๊ต๊ณผ์„œ๋ฅผ ์ฝ”๋”ฉํ•˜๋Š” ์ฝ”๋”ฉ์„ ์ซŒ ํ•˜๋Š” ์•„์ด๋“ค\n- 2020 ์ด๊ธฐ์  ITQ ํŒŒ์›Œํฌ์ธํŠธ ver.2010 (๋ฌด์„ )\n- ๋กœ๋ธ”๋ก์Šค ๊ณต์‹ ๊ฐ€์ด๋“œ๋ถ ๋ฐฐํ‹€ ๊ฒŒ์ž„ ํŽธ\n- ๋กœ๋ธ”๋ก์Šค ๊ณต์‹ ๊ฐ€์ด๋“œ๋ถ ๋กคํ”Œ๋ ˆ์ž‰ ๊ฒŒ์ž„ ํŽธ\n- ๊ต์‹ค์˜ ๋ฏธ๋ž˜ ๊ตฌ๊ธ€ ํด๋ž˜์Šค๋ฃธ\n- 2019 NEW ์ถœ์ œ๊ฒฝํ–ฅ๋Œ€๋น„ ์ปฌ๋Ÿฌ๋ฆฌ์ŠคํŠธ ํ•„๊ธฐ์‹œํ—˜ ์‚ฐ์—…๊ธฐ์‚ฌ.๊ธฐ์‚ฌ ์„ธํŠธ - ์ „3๊ถŒ\n- ํ”„๋กœ ์ผ์ž˜๋Ÿฌ๋ฅผ ์œ„ํ•œ ์Šฌ๊ธฐ๋กœ์šด ์•„์ดํŒจ๋“œ ์ƒํ™œ\n- 2019 ์‹œ๋‚˜๊ณต ์ •๋ณด์ฒ˜๋ฆฌ๊ธฐ๋Šฅ์‚ฌ ์‹ค๊ธฐ\n- ์ˆ˜์ œ๋น„ ์ •๋ณด์ฒ˜๋ฆฌ๊ธฐ์‚ฌ ์‹ค๊ธฐ (1๊ถŒ+2๊ถŒ ํ•ฉ๋ณธ์„ธํŠธ) 2020๋…„ ๊ธฐ์ถœ ๋ฌธ์ œ ์ˆ˜๋ก\n- 2019 ์‹œ๋‚˜๊ณต ์ •๋ณด์ฒ˜๋ฆฌ๊ธฐ์‚ฌ ์‹ค๊ธฐ (์‚ฐ์—…๊ธฐ์‚ฌ ํฌํ•จ) - ์ „2๊ถŒ\n- ์‹ค์ „! ํ•˜์ดํผ๋ ˆ์ € ํŒจ๋ธŒ๋ฆญ\n- ์šฐ๋ฆฌ๋“ค์˜ ๋ณ„๋ณ„ ์บ๋ฆญํ„ฐ ๋ณด๋ฌผ์„ฌ\n- ์†Œ์…œ์ž„ํŒฉํŠธ ์ฐฝ์ถœ์„ ํ†ตํ•œ ๋” ๋‚˜์€ ์„ธ์ƒ ๋งŒ๋“ค๊ธฐ 3\n- Splunk 7 ์—์„ผ์…œ 3/e", "title": "์•Œ๋ผ๋”˜ ์ž ์‹ค๋กฏ๋ฐ์›”๋“œํƒ€์›Œ์  ์ƒˆ๋กœ ๋“ฑ๋ก๋œ IT ๋„์„œ ์•Œ๋ฆผ(2020๋…„ 12์›” 19์ผ)", "type": "issue" }, { "action": "closed", "author": "jhk0530", "comment_id": null, "datetime": 1608698304000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]
1
2
1,109
false
false
1,109
false
jolibrain/deepdetect
jolibrain
750,666,124
1,013
{ "number": 1013, "repo": "deepdetect", "user_login": "jolibrain" }
[ { "action": "opened", "author": "sileht", "comment_id": null, "datetime": 1606297917000, "masked_author": "username_0", "text": "## fix: raise error is jsonapi is invalid\n\n\n## feat: use oatpp by default\n\n\n## feat: enable backtrace on segfault for oatpp\n\n\n## fix(oatpp): use parent _logger object", "title": "Pull request for oat-default", "type": "issue" }, { "action": "created", "author": "beniz", "comment_id": 735635789, "datetime": 1606724898000, "masked_author": "username_1", "text": "That was quick! \"Bon vent\" cppnetib!", "title": null, "type": "comment" } ]
2
2
202
false
false
202
false
torchbox/wagtail-markdown
torchbox
785,456,558
76
{ "number": 76, "repo": "wagtail-markdown", "user_login": "torchbox" }
[ { "action": "opened", "author": "StefanUlbrich", "comment_id": null, "datetime": 1610571942000, "masked_author": "username_0", "text": "SimpleMDE is no longer supported and as an open security issue.\r\nEasyMDE is a maintianed fork.\r\n\r\nThis PR directly addresses #72\r\n\r\nAdditions: \r\n* Readme updated to reflect required font-awesome 5 and clearer instructions on how to get it. \r\n* isort failure removed\r\n* isort deprecated parameter removed (now standard behavior)", "title": "Swtich to EasyMDE", "type": "issue" }, { "action": "created", "author": "jeriox", "comment_id": 817138425, "datetime": 1618061993000, "masked_author": "username_1", "text": "@thijstriemstra will this be merged and is this project still maintained?", "title": null, "type": "comment" }, { "action": "created", "author": "StefanUlbrich", "comment_id": 817142026, "datetime": 1618063553000, "masked_author": "username_0", "text": "@username_1 , @thijstriemstra , I cannot merge without write access", "title": null, "type": "comment" }, { "action": "created", "author": "zerolab", "comment_id": 817616749, "datetime": 1618217180000, "masked_author": "username_2", "text": "Hey all,\r\n\r\nSorry for the delay and radio silence. \r\nI will try to progress this in the coming day or two.", "title": null, "type": "comment" }, { "action": "created", "author": "zerolab", "comment_id": 822019503, "datetime": 1618763432000, "masked_author": "username_2", "text": "Thank you for this @username_0.\r\n\r\nMade a few tweaks around FontAwesome autodownload and merged it. Turns out SimpleMDE was doing the same autodownload thing - https://github.com/sparksuite/simplemde-markdown-editor/blob/master/src/js/simplemde.js#L1274-L1297 so the wagtailfontawesome dependency was erroneous", "title": null, "type": "comment" } ]
3
5
882
false
false
882
true
midudev/covid-vacuna
null
792,223,248
26
null
[ { "action": "opened", "author": "pangeasi", "comment_id": null, "datetime": 1611340732000, "masked_author": "username_0", "text": "![Captura de pantalla de 2021-01-22 19-32-41](https://user-images.githubusercontent.com/28918459/105530931-daec0100-5ce8-11eb-9f82-ba0e79d32f75.png)\r\n\r\nparece que hay alguna propiedad filter.", "title": "No se ve algunos textos", "type": "issue" }, { "action": "created", "author": "midudev", "comment_id": 765776153, "datetime": 1611359727000, "masked_author": "username_1", "text": "ยฟQuรฉ navegador y sistema operativo usas?", "title": null, "type": "comment" }, { "action": "created", "author": "pangeasi", "comment_id": 765886145, "datetime": 1611389015000, "masked_author": "username_0", "text": "firefox y ubuntu, este es mi user-agent\r\nMozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0", "title": null, "type": "comment" }, { "action": "created", "author": "midudev", "comment_id": 766093517, "datetime": 1611414533000, "masked_author": "username_1", "text": "Creo que quitando la animaciรณn esto deberรญa estar arreglado. ยฟLe puedes echar un vistazo? :)", "title": null, "type": "comment" }, { "action": "created", "author": "soker90", "comment_id": 766111557, "datetime": 1611418377000, "masked_author": "username_2", "text": "@username_1 parece que sigue sin verse bien en Firefox :'(", "title": null, "type": "comment" }, { "action": "created", "author": "midudev", "comment_id": 766132057, "datetime": 1611419540000, "masked_author": "username_1", "text": "@username_2 prueba otra vez ahora... ๐Ÿ˜†", "title": null, "type": "comment" }, { "action": "created", "author": "soker90", "comment_id": 766134829, "datetime": 1611419656000, "masked_author": "username_2", "text": "@username_1 ahora si!! que gustazo xD", "title": null, "type": "comment" }, { "action": "closed", "author": "midudev", "comment_id": null, "datetime": 1611419886000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]
3
8
564
false
false
564
true
ROCmSoftwarePlatform/MIOpen
ROCmSoftwarePlatform
733,331,571
558
{ "number": 558, "repo": "MIOpen", "user_login": "ROCmSoftwarePlatform" }
[ { "action": "opened", "author": "cderb", "comment_id": null, "datetime": 1604075770000, "masked_author": "username_0", "text": "", "title": "find db generation, reverting gemm time calculation to miopen default", "type": "issue" }, { "action": "created", "author": "daniellowell", "comment_id": 720142776, "datetime": 1604260768000, "masked_author": "username_1", "text": "This should go into rocm-3.10.x-staging instead of develop.", "title": null, "type": "comment" } ]
3
3
59
false
true
59
false
MoOx/pjax
null
572,746,941
221
null
[ { "action": "opened", "author": "gggg990", "comment_id": null, "datetime": 1582895537000, "masked_author": "username_0", "text": "I am trying to implement a white loading bar to the pjax code... I am also testing with logging the event to the console log but it only get's fired when there's a fresh restart of the whole page not just one section. Ideally I want to see it working also when changing page sections without a full reload.\r\n\r\nThis is my code:\r\n`var pjax;\r\nvar whiteloading; \r\n\r\ndocument.addEventListener(\"DOMContentLoaded\", function() {\r\n // Init Pjax instance\r\n pjax = new Pjax({\r\n elements: \"a\", // default is \"a[href], form[action]\"\r\n selectors: [\"title\", \".js-Pjax\"],\r\n cacheBust: false\r\n });\r\n});\r\nwhiteloading = $(\".whiteloading\");\r\nwhiteloading.show();\r\n\r\ndocument.addEventListener(\"pjax:send\", console.log(\"start\"));\r\ndocument.addEventListener(\"pjax:success\", console.log(\"done\"));`", "title": "pjax:send eventListener doesn't work", "type": "issue" } ]
1
1
780
false
false
780
false
tellor-io/telliot
tellor-io
777,244,403
345
{ "number": 345, "repo": "telliot", "user_login": "tellor-io" }
[ { "action": "opened", "author": "krasi-georgiev", "comment_id": null, "datetime": 1609490751000, "masked_author": "username_0", "text": "", "title": "Updated the grafana url", "type": "issue" }, { "action": "created", "author": "themandalore", "comment_id": 753308519, "datetime": 1609502795000, "masked_author": "username_1", "text": "this one good to go?", "title": null, "type": "comment" } ]
3
3
893
false
true
20
false
BuckleScript/syntax
BuckleScript
655,374,628
41
null
[ { "action": "opened", "author": "chenglou", "comment_id": null, "datetime": 1594550356000, "masked_author": "username_0", "text": "Multi_printer says 100. Other places have hardcoded 80 (including outcome printer)", "title": "Inconsistent default width", "type": "issue" }, { "action": "created", "author": "IwanKaramazow", "comment_id": 657969540, "datetime": 1594703326000, "masked_author": "username_1", "text": "Default to 100 everywhere? 80 will still be used in the printer tests to test wrapping.", "title": null, "type": "comment" } ]
2
2
169
false
false
169
false
openshift/openshift-docs
openshift
704,002,232
25,578
{ "number": 25578, "repo": "openshift-docs", "user_login": "openshift" }
[ { "action": "opened", "author": "mburke5678", "comment_id": null, "datetime": 1600390609000, "masked_author": "username_0", "text": "When researching https://github.com/openshift/openshift-docs/issues/25539 I saw that there were multiple instances where we still reference the *Subscribe* button in the Operators Web UI. In 4.5, this button was changed to *Install*.\r\nAlso, the *Create Operator Subscription* page was changed to *Install Operator* in 4.5.", "title": "Changed Subscribe to Install and Create Operator Subscription to Install Options", "type": "issue" }, { "action": "created", "author": "mburke5678", "comment_id": 694601194, "datetime": 1600393905000, "masked_author": "username_0", "text": "4.4\r\n![Install4 4](https://user-images.githubusercontent.com/25209155/93546049-f5276400-f92f-11ea-9c10-e7734c43d925.png)", "title": null, "type": "comment" }, { "action": "created", "author": "mburke5678", "comment_id": 694601315, "datetime": 1600393930000, "masked_author": "username_0", "text": "4.5\r\n![InstallOperator4 5](https://user-images.githubusercontent.com/25209155/93546072-04a6ad00-f930-11ea-8f01-20b58ac67ce8.png)", "title": null, "type": "comment" }, { "action": "created", "author": "ahardin-rh", "comment_id": 694879138, "datetime": 1600436935000, "masked_author": "username_1", "text": "@spadgett PTAL. Thank you!", "title": null, "type": "comment" }, { "action": "created", "author": "bobfuru", "comment_id": 694882982, "datetime": 1600437347000, "masked_author": "username_2", "text": "Thank you for correcting this! LGTM", "title": null, "type": "comment" }, { "action": "created", "author": "jboxman", "comment_id": 694943547, "datetime": 1600443950000, "masked_author": "username_3", "text": "@username_0 thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "mburke5678", "comment_id": 698644861, "datetime": 1600991549000, "masked_author": "username_0", "text": "/cherrypick enterprise-4.5", "title": null, "type": "comment" }, { "action": "created", "author": "mburke5678", "comment_id": 717381877, "datetime": 1603817698000, "masked_author": "username_0", "text": "/cherrypick enterprise-4.7", "title": null, "type": "comment" }, { "action": "created", "author": "mburke5678", "comment_id": 717423951, "datetime": 1603821828000, "masked_author": "username_0", "text": "/cherrypick enterprise-4.6", "title": null, "type": "comment" } ]
6
17
3,329
false
true
728
true
google/osv
google
802,646,996
56
null
[ { "action": "opened", "author": "KOLANICH", "comment_id": null, "datetime": 1612601086000, "masked_author": "username_0", "text": "You are not soory, if you were sorry, this website wouldn't have tried to coerce me into enabling JS.", "title": "Make it work without client-side JavaScript", "type": "issue" }, { "action": "created", "author": "oliverchang", "comment_id": 775484374, "datetime": 1612820744000, "masked_author": "username_1", "text": "Hi,\r\n\r\nUnfortunately we don't have the resources to devote to maintaining a JS-free frontend. \r\n\r\nWe will have an option for you to consume the data without having JS enabled, as our data will be exported to a repository as plain YAML files (see https://github.com/google/osv/issues/44).", "title": null, "type": "comment" }, { "action": "closed", "author": "oliverchang", "comment_id": null, "datetime": 1612820745000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "KOLANICH", "comment_id": 775494877, "datetime": 1612821989000, "masked_author": "username_0", "text": "Thanks, how about also making the site with docs no-JS?", "title": null, "type": "comment" } ]
2
4
443
false
false
443
false