repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
sensu/sensu-docs | sensu | 710,296,647 | 2,755 | null | [
{
"action": "opened",
"author": "palourde",
"comment_id": null,
"datetime": 1601302007000,
"masked_author": "username_0",
"text": "### Description\r\nWe will introduce support for a new HTTP verb, `PATCH`, in 6.1. For now, it will be available exclusively via the REST API (sensuctl won't be able to use that yet). It's also available to \"configuration\" resources:\r\n\r\n- apikeys\r\n- checks\r\n- clusterrolebindings\r\n- clusterroles\r\n- filters\r\n- hooks\r\n- mutators\r\n- namespaces\r\n- rolebindings\r\n- roles\r\n\r\nIt's also available to entities, but only to the **configuration** attributes; behind the scenes, entities are now stored into two distinct resources, an [`EntityConfig`](https://github.com/sensu/sensu-go/blob/fe06dac0a08176a87f65bb1934613879d928b7ac/api/core/v3/entity_config.pb.go#L29) and an [`EntityState`](https://github.com/sensu/sensu-go/blob/fe06dac0a08176a87f65bb1934613879d928b7ac/api/core/v3/entity_state.pb.go#L31). Therefore, users will be able to PATCH entities attributes that belong to the `EntityConfig`.\r\n\r\nThe two notable exceptions in terms of resources are `silenced` entries and `users`. We might tackle those in a subsequent release.\r\n\r\nFor the moment, we only support `JSON Merge Patches`, as defined by the [RFC7396](https://tools.ietf.org/html/rfc7396), therefore users will have to explicitly set the `Content-Type` header to `application/merge-patch+json`.\r\n\r\nAlso, users won't be able to alter the `name` or the `namespace` of a resource via a PATCH request.\r\n\r\nOne important thing to note is that all GET and PATCH requests will now return an [`Etag`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag) response header, which identifies a specific version of a resource.\r\n\r\nUsing that `Etag` value, users will be able to conditionally execute a PATCH request using the [`If-Match`]() and [`If-None-Match`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match) headers. When a PATCH request cannot be executed because one of the condition failed, we will return the response status code `412 Precondition Failed`.\r\n\r\nHere are some useful examples:\r\n\r\n### A user can add a label\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-d '{\r\n \"metadata\": {\r\n \"labels\": {\r\n \"what_magic\": \"is this\"\r\n }\r\n }\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/assets/sensu-go-hello-world\r\n\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nEtag: \"deeb157828631797\"\r\nDate: Mon, 28 Sep 2020 13:56:43 GMT\r\nContent-Length: 465\r\n\r\n{\"filters\":[\"entity.system.os == linux\"],\"builds\":[{\"url\":\"https://self-signed.badssl.com/sensu-go-hello-world-0.0.1.tar.gz\",\"sha512\":\"06665fea5b7c7ee15e7822820aa7ddb791cc6338e38444e976e601bc7d7970592e806a7b88733690a238b7325437d31f85e98ae2fe47b008ca09c86530da9600\",\"filters\":null,\"headers\":null}],\"metadata\":{\"name\":\"sensu-go-hello-world\",\"namespace\":\"default\",\"labels\":{\"sensu.io/managed_by\":\"sensuctl\",\"what_magic\":\"is this\"},\"created_by\":\"admin\"},\"headers\":null}\r\n```\r\n\r\n### A user can replace an array\r\nOne of the caveat of JSON merge patches is that it's not possible to add elements to an array, you can only replace it.\r\n\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-d '{\r\n \"subscriptions\": [\"tootsie_roll\"]\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/entities/gin\r\n\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nEtag: \"655cde6ef9f86805\"\r\nDate: Mon, 28 Sep 2020 13:58:48 GMT\r\nContent-Length: 302\r\n\r\n{\"metadata\":{\"name\":\"gin\",\"namespace\":\"default\",\"labels\":{\"what_magic\":\"is this\"}},\"entity_class\":\"agent\",\"user\":\"agent\",\"subscriptions\":[\"tootsie_roll\"],\"deregister\":false,\"deregistration\":{},\"redact\":[\"password\",\"passwd\",\"pass\",\"api_key\",\"api_token\",\"access_key\",\"secret_key\",\"private_key\",\"secret\"]}\r\n```\r\n\r\n### A user cannot alter the namespace or the name of a resource\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-H 'Content-Type:' \\\r\n-d '{\r\n \"metadata\": {\r\n \"namespace\": \"dev\"\r\n }\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/checks/check-asset\r\n\r\nHTTP/1.1 400 Bad Request\r\nX-Content-Type-Options: nosniff\r\nDate: Mon, 28 Sep 2020 13:52:31 GMT\r\nContent-Length: 108\r\nContent-Type: text/plain; charset=utf-8\r\n\r\n{\"message\":\"the namespace of the resource (dev) does not match the namespace in the URI (default)\",\"code\":1}\r\n```\r\n\r\n\r\n### A PATCH request can only be issued if the stored resource matches the provided Etag in `If-Match`\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-H 'If-Match: \"deeb157828631797\"' \\\r\n-d '{\r\n \"metadata\": {\r\n \"labels\": {\r\n \"what_magic\": \"is this\"\r\n }\r\n }\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/assets/sensu-go-hello-world\r\n\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nEtag: \"deeb157828631797\"\r\nDate: Mon, 28 Sep 2020 14:01:18 GMT\r\nContent-Length: 465\r\n\r\n{\"filters\":[\"entity.system.os == linux\"],\"builds\":[{\"url\":\"https://self-signed.badssl.com/sensu-go-hello-world-0.0.1.tar.gz\",\"sha512\":\"06665fea5b7c7ee15e7822820aa7ddb791cc6338e38444e976e601bc7d7970592e806a7b88733690a238b7325437d31f85e98ae2fe47b008ca09c86530da9600\",\"filters\":null,\"headers\":null}],\"metadata\":{\"name\":\"sensu-go-hello-world\",\"namespace\":\"default\",\"labels\":{\"sensu.io/managed_by\":\"sensuctl\",\"what_magic\":\"is this\"},\"created_by\":\"admin\"},\"headers\":null}\r\n```\r\n\r\n### A PATCH request can only be issued if the stored resource does not match any of the provided Etag in `If-Match`\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-H 'If-None-Match: \"2459df058c399716\", \"67ab43\"' \\\r\n-d '{\r\n \"metadata\": {\r\n \"labels\": {\r\n \"what_magic\": \"is this\"\r\n }\r\n }\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/entities/gin\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nEtag: \"655cde6ef9f86805\"\r\nDate: Mon, 28 Sep 2020 14:02:05 GMT\r\nContent-Length: 302\r\n\r\n{\"metadata\":{\"name\":\"gin\",\"namespace\":\"default\",\"labels\":{\"what_magic\":\"is this\"}},\"entity_class\":\"agent\",\"user\":\"agent\",\"subscriptions\":[\"tootsie_roll\"],\"deregister\":false,\"deregistration\":{},\"redact\":[\"password\",\"passwd\",\"pass\",\"api_key\",\"api_token\",\"access_key\",\"secret_key\",\"private_key\",\"secret\"]}\r\n```\r\n\r\n### A 412 Precondition Failed error is returned if the request cannot be fulfilled because of the condition\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-H 'If-Match: \"54ed21\"' \\\r\n-d '{\r\n \"metadata\": {\r\n \"labels\": {\r\n \"what_magic\": \"is this\"\r\n }\r\n }\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/assets/sensu-go-hello-world\r\n\r\nHTTP/1.1 412 Precondition Failed\r\nX-Content-Type-Options: nosniff\r\nDate: Mon, 28 Sep 2020 14:04:21 GMT\r\nContent-Length: 110\r\nContent-Type: text/plain; charset=utf-8\r\n\r\n{\"message\":\"at least one condition failed for the key /sensu.io/assets/default/sensu-go-hello-world\",\"code\":7}\r\n```\r\n\r\n### Only the entity configuration attributes can be PATCHED\r\nSee the returned response body, which only returns configuration attributes.\r\n```\r\n$ curl -i -X PATCH \\\r\n-H \"Authorization: Key $SENSU_API_KEY\" \\\r\n-H 'Content-Type: application/merge-patch+json' \\\r\n-d '{\r\n \"deregister\": true\r\n}' \\\r\nhttp://127.0.0.1:8080/api/core/v2/namespaces/default/entities/gin\r\n\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nEtag: \"655cde6ef9f86805\"\r\nDate: Mon, 28 Sep 2020 14:05:25 GMT\r\nContent-Length: 302\r\n\r\n{\"metadata\":{\"name\":\"gin\",\"namespace\":\"default\",\"labels\":{\"what_magic\":\"is this\"}},\"entity_class\":\"agent\",\"user\":\"agent\",\"subscriptions\":[\"tootsie_roll\"],\"deregister\":false,\"deregistration\":{},\"redact\":[\"password\",\"passwd\",\"pass\",\"api_key\",\"api_token\",\"access_key\",\"secret_key\",\"private_key\",\"secret\"]}\r\n```\r\n\r\n### Category\r\n\r\nThis is an issue with:\r\n\r\n- [ ] errata (error in doc content)\r\n- [x] new doc (requires a completely new doc)\r\n- [ ] update (add missing or refresh existing content)\r\n- [ ] improvement (improve docs content or format)\r\n\r\n\r\nPlease let me know if you have any question or you would like some specific examples.\r\n\r\nThanks!",
"title": "Document PATCH method for the REST API",
"type": "issue"
},
{
"action": "closed",
"author": "hillaryfraley",
"comment_id": null,
"datetime": 1601650432000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 8,167 | false | false | 8,167 | false |
pemkotbekasi/website-status | pemkotbekasi | 815,559,149 | 18 | null | [
{
"action": "opened",
"author": "rahadiana",
"comment_id": null,
"datetime": 1614178813000,
"masked_author": "username_0",
"text": "In [`a08e944`](https://github.com/pemkotbekasi/website-status/commit/a08e944a01bd8f9778d4214ef3538fac1f8a4c72\n), Dinas Perpustakaan Daerah (http://disperpus.bekasikota.go.id) was **down**:\n- HTTP code: 0\n- Response time: 0 ms",
"title": "🛑 Dinas Perpustakaan Daerah is down",
"type": "issue"
}
] | 1 | 1 | 225 | false | false | 225 | false |
microsoft/azure-tools-for-java | microsoft | 775,169,210 | 4,854 | {
"number": 4854,
"repo": "azure-tools-for-java",
"user_login": "microsoft"
} | [
{
"action": "opened",
"author": "shenqianjin",
"comment_id": null,
"datetime": 1609126059000,
"masked_author": "username_0",
"text": "",
"title": "[Icon Improvement] (No.3) Replace icons on actions - phrase II",
"type": "issue"
},
{
"action": "created",
"author": "andxu",
"comment_id": 752342903,
"datetime": 1609309250000,
"masked_author": "username_1",
"text": "Too many changes, reject to review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shenqianjin",
"comment_id": 752367431,
"datetime": 1609315532000,
"masked_author": "username_0",
"text": "already split and updated.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 60 | false | false | 60 | false |
trevtrich/cli | null | 709,816,282 | 278 | {
"number": 278,
"repo": "cli",
"user_login": "trevtrich"
} | [
{
"action": "created",
"author": "trevtrich",
"comment_id": 699719236,
"datetime": 1601255656000,
"masked_author": "username_0",
"text": ":tada: This PR is included in version 1.11.27 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/@username_0/cli/v/1.11.27)\n- [GitHub release](https://github.com/username_0/cli/releases/tag/v1.11.27)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 4,645 | false | true | 353 | true |
chakra-ui/chakra-ui | chakra-ui | 616,428,961 | 702 | {
"number": 702,
"repo": "chakra-ui",
"user_login": "chakra-ui"
} | [
{
"action": "opened",
"author": "christiannwamba",
"comment_id": null,
"datetime": 1589268699000,
"masked_author": "username_0",
"text": "This is the first time the `CSSReset` component was mentioned in the docs. It is not always intuitive to beginners that they should import it.\r\n\r\nI also removed the comment from `customTheme` import since it's actually being used in the code snippet",
"title": "Import CSSReset to match reference on GS page",
"type": "issue"
}
] | 2 | 2 | 728 | false | true | 249 | false |
microsoft/playwright | microsoft | 785,586,716 | 5,009 | {
"number": 5009,
"repo": "playwright",
"user_login": "microsoft"
} | [
{
"action": "opened",
"author": "domderen",
"comment_id": null,
"datetime": 1610589306000,
"masked_author": "username_0",
"text": "Currently the network tab contains a limited amount of information on the resources that were loaded in the browser. This change proposes extending the details displayed for each resource, to include:\r\n\r\n- HTTP method,\r\n- Status\r\n- Full url,\r\n- Easily visible response content type,\r\n- Request headers,\r\n- Request & response bodies.\r\n\r\nSuch level of information could help quickly understand what happened in the application, when it was communicating with backend services. This can help debug tests quicker to figure out why they are failing.\r\n\r\nWhat do you think about such extension?\r\n\r\n<img width=\"1680\" alt=\"Zrzut ekranu 2021-01-14 o 15 31 33\" src=\"https://user-images.githubusercontent.com/2360738/104636315-77882080-56a3-11eb-946f-d7fc096ec7fc.png\">\r\n<img width=\"1680\" alt=\"Zrzut ekranu 2021-01-14 o 19 58 58\" src=\"https://user-images.githubusercontent.com/2360738/104636306-735c0300-56a3-11eb-93d3-36fe3b1ad832.png\">\r\n<img width=\"1680\" alt=\"Zrzut ekranu 2021-01-14 o 02 53 39\" src=\"https://user-images.githubusercontent.com/2360738/104534016-c5edde80-5613-11eb-8386-05ce124e065b.png\">\r\n<img width=\"1680\" alt=\"Zrzut ekranu 2021-01-14 o 15 31 59\" src=\"https://user-images.githubusercontent.com/2360738/104636311-77882080-56a3-11eb-9e5c-b24f8717233d.png\">",
"title": "feat(trace viewer): Extending existing NetworkTab view.",
"type": "issue"
},
{
"action": "created",
"author": "domderen",
"comment_id": 766342130,
"datetime": 1611492261000,
"masked_author": "username_0",
"text": "Hey @dgozman thanks for taking a look at this PR, I think all the changes you pointed out should be fixed now :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "domderen",
"comment_id": 766350899,
"datetime": 1611496018000,
"masked_author": "username_0",
"text": "One more thing, I was looking at the failing checks, and most of them seems unrelated, but one of them peeked my interest, as it is related to the test I added here: https://github.com/microsoft/playwright/pull/5009/checks?check_run_id=1757111083\r\n\r\nIt looks like in this particular case, the trace file does not contain the `NetworkResourceTraceEvent` for `/file.json` request. I saw that issue before when I was adding those changes, but they went away. I thought it was related to the way the test was set up, but now I'm starting to wonder if there is potentially a race condition somewhere, that doesn't always wait for network events to resolve, before finishing an action like \"click\". Do you think this makes sense? Should I create a bug for it, and try to look for it?",
"title": null,
"type": "comment"
}
] | 1 | 3 | 2,150 | false | false | 2,150 | false |
detekt/detekt | detekt | 748,971,871 | 3,245 | null | [
{
"action": "opened",
"author": "adamkobor",
"comment_id": null,
"datetime": 1606150858000,
"masked_author": "username_0",
"text": "Hey there, I'm experiencing a weird bug with the `ExplicitItLambdaParameter` rule. I've enabled it in my config.yml, but it definitely doesn't trigger any rule violation.\r\n \r\n## Expected Behavior\r\nIt should trigger a rule violation for multi-line lambdas with implicit `it` parameters.\r\n\r\n## Observed Behavior\r\nIt doesn't trigger a rule violation in the cases described above.\r\n\r\n## Steps to Reproduce\r\nWrite a multi-line lambda with an implicit `it` parameter, and run detekt:\r\n\r\n```kotlin\r\nlistOf(\"a\",\"b\").forEach {\r\n doSomething()\r\n println(it)\r\n}\r\n```\r\n\r\n## Your Environment\r\n<!-- Include as many relevant details about the environment you experienced the bug in -->\r\n* Version of detekt used: 1.14.2\r\n* Version of Gradle used (if applicable): 6.7.1\r\n* Operating System and version: MacOS Big Sur",
"title": "ExplicitItLambdaParameter rule is not working",
"type": "issue"
},
{
"action": "created",
"author": "cortinico",
"comment_id": 735287173,
"datetime": 1606595580000,
"masked_author": "username_1",
"text": "As described in the rule documentation: https://detekt.github.io/detekt/style.html#explicititlambdaparameter\r\nyour code is actually valid, as you're using an **implicit** `it` parameter. The rule flags **explicit** usages of the `it` parameter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adamkobor",
"comment_id": 735291249,
"datetime": 1606598035000,
"masked_author": "username_0",
"text": "OMG, what a rookie mistake (and also a misread) 😄 Thanks, I was concentrating only to the word \"lambda\" in the rule's name",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "adamkobor",
"comment_id": null,
"datetime": 1606598036000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "QuinnBast",
"comment_id": 926899323,
"datetime": 1632515103000,
"masked_author": "username_2",
"text": "Hello. Just stumbled across this. Is there a rule that forces lambda parameters to be defined?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "BraisGabin",
"comment_id": 927110765,
"datetime": 1632571081000,
"masked_author": "username_3",
"text": "Your request is interesting but it's not related with this issue. Could you open a new issue so we can talk about it?\n\n(Github should allow to move one comment directly to a new issue)",
"title": null,
"type": "comment"
}
] | 4 | 6 | 1,450 | false | false | 1,450 | false |
nuita/nuita | nuita | 709,749,885 | 261 | {
"number": 261,
"repo": "nuita",
"user_login": "nuita"
} | [
{
"action": "opened",
"author": "utgwkk",
"comment_id": null,
"datetime": 1601216771000,
"masked_author": "username_0",
"text": "# やったこと\r\n\r\n- 開発環境 (Docker) やテスト (GitHub Actions) で使うMySQLのバージョンを、READMEにあるバージョンに合わせました\r\n - `image` にtagを指定しないと `mysql:latest` が使われて、開発環境のDBだけどんどんバージョンアップしてしまう気がする\r\n - [MySQL 8.0はメンテナンスバージョンアップにがんがん機能追加・削除を入れてくる](https://speakerdeck.com/yoku0825/mysql-8-dot-0nifu-kenaitesutofalsezuo-rifang-jia?slide=15)という話もある\r\n - 本番と開発環境で挙動が違うと難しいのでできるだけ環境を揃えたい\r\n - テストだけMySQL 5.7を使ってた\r\n\r\n# 動作確認方法\r\n\r\n- docker-compose.yml\r\n - Dockernizeされた開発環境を初期化して `docker-compose run --rm app rails test` が通る\r\n- GitHub Actions\r\n - CIのテストが通る\r\n\r\n# ご相談\r\n\r\n- READMEに書いてある各種アプリケーションのバージョンが本番環境のものなのか、推奨環境がこうなっているのか分かりませんでした。ひとまず本番環境のバージョンだと思ってcommit messageを書きましたが、もし違っていたらご指摘いただきたいです\r\n - そのようにcommit messageを修正します",
"title": "開発環境のMySQLのバージョンを本番環境に合わせる",
"type": "issue"
},
{
"action": "created",
"author": "kypkyp",
"comment_id": 699986288,
"datetime": 1601297482000,
"masked_author": "username_1",
"text": "確認したところ、本番環境のMySQLはv5.7.30でした。グワーーーーーッ\r\n\r\nできたらDockerイメージのほうもv5.7にしておいていただけると助かります……。\r\nあとREADMEちゃんと書きます。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "utgwkk",
"comment_id": 700350933,
"datetime": 1601338877000,
"masked_author": "username_0",
"text": "なるほど了解です、docker-compose.ymlとCIのバージョンは5.7.30に合わせておきます。READMEはひとまず置いておきます",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "utgwkk",
"comment_id": 700358060,
"datetime": 1601340308000,
"masked_author": "username_0",
"text": "@username_1 rebaseしてバージョンを5.7.30に合わせました",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kypkyp",
"comment_id": 702251772,
"datetime": 1601569693000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 2 | 5 | 904 | false | false | 904 | true |
neovim/neovim | neovim | 314,439,249 | 8,283 | {
"number": 8283,
"repo": "neovim",
"user_login": "neovim"
} | [
{
"action": "opened",
"author": "nimitbhardwaj",
"comment_id": null,
"datetime": 1523816789000,
"masked_author": "username_0",
"text": "When entering a large string in substitute command when `set inccommand=nosplit` is enabled, the string wraps around the single line. This was due to the condition that in Preview mode, we need a kind of behaviour where the DOCMD_NOWAIT is not completely necessary because there is change in the size of the cmdlilne, but we don't need to wait for the return, so ++no_wait_return was not necessary.",
"title": "[RFC] Fix for wrapping of large string in preview mode",
"type": "issue"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 381943760,
"datetime": 1523961802000,
"masked_author": "username_0",
"text": "What about the tests of this PR",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bfredl",
"comment_id": 381946395,
"datetime": 1523962330000,
"masked_author": "username_1",
"text": "As this is a visual glitch it should use a screen test. Follow the pattern of the exiting screen tests in `ui/inccommand_spec.lua`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 381953409,
"datetime": 1523963803000,
"masked_author": "username_0",
"text": "Ok",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "justinmk",
"comment_id": 383283711,
"datetime": 1524306342000,
"masked_author": "username_2",
"text": "The AppVeyor failure looks related to this change.\r\n\r\n```\r\n[ ERROR ] C:/projects/neovim/test/functional\\ui\\inccommand_spec.lua @ 135: :substitute, 'inccommand' preserves listed buffers (:ls)\r\ntest\\functional\\ui\\screen.lua:307: Row 1 did not match.\r\nExpected:\r\n |*{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |:ls |\r\n | 1 %a + \"[No Name]\" |\r\n | line 1 |\r\n |{13:Press ENTER or type command to}|\r\n |{13: continue}^ |\r\nActual:\r\n |*^BAC |\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n |{15:~ }|\r\n | |\r\nTo print the expect() call that would assert the current screen state, use\r\n```\r\n\r\nMaybe the test just needs to be adjusted. Need to look at the test, understand what it's doing, and decide if the change from this PR caused a bug, or if the test just needs to be a adjusted.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "justinmk",
"comment_id": 383283966,
"datetime": 1524306706000,
"masked_author": "username_2",
"text": "The quickbuild BSD failure looks related:\r\n\r\n```\r\n05:06:52,403 INFO - not ok 2743 - :substitute, inccommand=split shows correct line numbers with many lines\r\n05:06:52,403 INFO - # test/functional/ui/inccommand_spec.lua @ 1023\r\n05:06:52,403 INFO - # Failure message: ./test/functional/ui/screen.lua:307: Row 1 did not match.\r\n05:06:52,403 INFO - # Expected:\r\n05:06:52,403 INFO - # |*BBo lines |\r\n05:06:52,403 INFO - # |Inc substitution on |\r\n05:06:52,403 INFO - # |{12:X}o lines |\r\n05:06:52,403 INFO - # |Inc substitution on |\r\n05:06:52,403 INFO - # |{12:X}o lines |\r\n05:06:52,403 INFO - # |{11:[No Name] [+] }|\r\n05:06:52,403 INFO - # ||1001| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1003| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1005| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1007| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1009| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1011| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1013| {12:X}o lines |\r\n05:06:52,403 INFO - # |{10:[Preview] }|\r\n05:06:52,403 INFO - # |:%s/tw/X^ |\r\n05:06:52,403 INFO - # Actual:\r\n05:06:52,403 INFO - # |*Inc substitution on |\r\n05:06:52,403 INFO - # |BBo lines |\r\n05:06:52,403 INFO - # |Inc substitution on |\r\n05:06:52,403 INFO - # |{12:X}o lines |\r\n05:06:52,403 INFO - # |Inc substitution on |\r\n05:06:52,403 INFO - # |{11:[No Name] [+] }|\r\n05:06:52,403 INFO - # ||1001| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1003| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1005| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1007| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1009| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1011| {12:X}o lines |\r\n05:06:52,403 INFO - # ||1013| {12:X}o lines |\r\n05:06:52,403 INFO - # |{10:[Preview] }|\r\n05:06:52,403 INFO - # |:%s/tw/X^ |\r\n05:06:52,403 INFO - #-\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 383289429,
"datetime": 1524311735000,
"masked_author": "username_0",
"text": "I correct em",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 383290232,
"datetime": 1524312611000,
"masked_author": "username_0",
"text": "By the way why this error occurs, I didn't changed the code of that part, I even didn't touch the code for that `describe` i.e. of `substitute, inccommand=split` I put my test in describe of `inccommand=nosplit`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 383290277,
"datetime": 1524312671000,
"masked_author": "username_0",
"text": "Perhaps I should make the commit again and test if that error persists, and if persists, I will try by removing the test.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 383291888,
"datetime": 1524314286000,
"masked_author": "username_0",
"text": "Lets have a try on this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nimitbhardwaj",
"comment_id": 383292695,
"datetime": 1524315040000,
"masked_author": "username_0",
"text": "Yes error occurs, this may be due to my change in src, I try what can I do, I am sure, that error didn't occur previously, some changes occur after my work",
"title": null,
"type": "comment"
}
] | 3 | 11 | 4,731 | false | false | 4,731 | false |
microsoft/vscode-remote-release | microsoft | 690,714,643 | 3,617 | null | [
{
"action": "opened",
"author": "RMBeristain",
"comment_id": null,
"datetime": 1599022514000,
"masked_author": "username_0",
"text": "<!-- Please search existing issues to avoid creating duplicates. -->\r\nPlease add the option to group remotes in folders in Remote Explorer.\r\n<!-- Describe the feature you'd like. -->",
"title": "Group remotes by folder",
"type": "issue"
},
{
"action": "created",
"author": "chrmarti",
"comment_id": 686945094,
"datetime": 1599201368000,
"masked_author": "username_1",
"text": "Is this for SSH remotes?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RMBeristain",
"comment_id": 687548164,
"datetime": 1599280875000,
"masked_author": "username_0",
"text": "Specifically for WSL Remotes, but I guess organising all remotes is a good\nthing.",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,338 | false | true | 287 | false |
CodingZeal/redux-persist-sensitive-storage | CodingZeal | 658,028,719 | 28 | null | [
{
"action": "opened",
"author": "JeremyBradshaw7",
"comment_id": null,
"datetime": 1594892159000,
"masked_author": "username_0",
"text": "The docs for `react-native-sensitive-info`, on which this package relies, suggests that the user has to provide authentication info before it allows access to the keychain or shared preferences (eg. fingerprint, touch ID, face recognition). I've deployed this to various devices through testfairy and never get prompted to further authenticate, so am puzzled as to when and why this extra layer of security would kick in. Some clarification would be useful, we'd have to advise our users what to expect if we rolled this out to the stores.",
"title": "Clarification on authentication",
"type": "issue"
},
{
"action": "created",
"author": "erksch",
"comment_id": 660647409,
"datetime": 1595167089000,
"masked_author": "username_1",
"text": "I think you can just look into the [docs of `react-native-sensitive-info`](https://mcodex.dev/react-native-sensitive-info/docs/ios_options). You can use properties to control whether modals for touch id or should be displayed. I guess the default is false. But I have not tried any of that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JeremyBradshaw7",
"comment_id": 668037320,
"datetime": 1596463005000,
"masked_author": "username_0",
"text": "As far as I can gather the extra layer of security in react-native-sensitive-info is optional, defaulting to off, but I can't see in the docs for this package where you set it on or leave it off.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,024 | false | false | 1,024 | false |
bwya77/PSHTML-AD-Report | null | 448,266,849 | 46 | null | [
{
"action": "opened",
"author": "kasper334-ghost",
"comment_id": null,
"datetime": 1558717214000,
"masked_author": "username_0",
"text": "The Script is awesome, hoever i noticed that Last Log on Date not populating in the users Tab.",
"title": "Last Log on Date not populating",
"type": "issue"
},
{
"action": "created",
"author": "openmoto",
"comment_id": 554131207,
"datetime": 1573773746000,
"masked_author": "username_1",
"text": "Same here.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bramyuh",
"comment_id": 566059989,
"datetime": 1576502796000,
"masked_author": "username_2",
"text": "add \"$LastLogon = $AttVar.lastlogon\" to:\r\n\r\n\t$Name = $User.Name\r\n\t$UPN = $User.UserPrincipalName\r\n\t$Enabled = $AttVar.Enabled\r\n\t$EmailAddress = $AttVar.EmailAddress\r\n\t$AccountExpiration = $AttVar.AccountExpirationDate\r\n **$LastLogon = $AttVar.lastlogon**\r\n\t$PasswordExpired = $AttVar.PasswordExpired\r\n\t$PasswordLastSet = $AttVar.PasswordLastSet\r\n\t$PasswordNeverExpires = $AttVar.PasswordNeverExpires\r\n\t$daysUntilPWExpire = $daystoexpire",
"title": null,
"type": "comment"
}
] | 3 | 3 | 543 | false | false | 543 | false |
kujunda-seda/Worthy-v2 | kujunda-seda | 479,306,767 | 24 | null | [
{
"action": "opened",
"author": "kalbaxa",
"comment_id": null,
"datetime": 1565471522000,
"masked_author": "username_0",
"text": "# Goal: Create high-level I/O diagram with modules and chosen technologies\r\nArchitecture is based on product MVP feature set and is not dependent on frontend visualization and design.\r\n\r\n## Acceptance checklist:\r\n- [ ] choose technology to parse API requests and provide responses (e.g. API Gateway)\r\n- [ ] choose database processor (e.g. lambda function)\r\n- [ ] choose database\r\n- [ ] decide on dependencies from 3rd-party services (e.g. OAuth)\r\n- [ ] create one-page diagram in draw.io",
"title": "Project architecture",
"type": "issue"
},
{
"action": "created",
"author": "kalbaxa",
"comment_id": 533883440,
"datetime": 1569160054000,
"masked_author": "username_0",
"text": "will be merged with [database structure](https://github.com/kujunda-seda/worthy-v2/issues/26) and choice of account types",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kalbaxa",
"comment_id": null,
"datetime": 1570915729000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 608 | false | false | 608 | false |
vesoft-inc/nebula-docs | vesoft-inc | 719,218,573 | 161 | {
"number": 161,
"repo": "nebula-docs",
"user_login": "vesoft-inc"
} | [
{
"action": "opened",
"author": "hy9125",
"comment_id": null,
"datetime": 1602494481000,
"masked_author": "username_0",
"text": "Update 1.install-with-rpm-deb.md",
"title": "Update 1.install-with-rpm-deb.md",
"type": "issue"
}
] | 2 | 2 | 596 | false | true | 32 | false |
home-assistant/core | home-assistant | 699,811,486 | 39,954 | null | [
{
"action": "opened",
"author": "offbyone",
"comment_id": null,
"datetime": 1599863121000,
"masked_author": "username_0",
"text": "<!-- READ THIS FIRST:\r\n - If you need additional help with this template, please refer to https://www.home-assistant.io/help/reporting_issues/\r\n - Make sure you are running the latest version of Home Assistant before reporting an issue: https://github.com/home-assistant/core/releases\r\n - Do not report issues for integrations if you are using custom components or integrations.\r\n - Provide as many details as possible. Paste logs, configuration samples and code into the backticks.\r\n DO NOT DELETE ANY TEXT from this template! Otherwise, your issue may be closed without comment.\r\n-->\r\n## The problem\r\nIf the `waqi` search API is not available when HA starts up, it leaves the sensor in a state where it can't ever find the stations.\r\n\r\n## Environment\r\n<!--\r\n Provide details about the versions you are using, which helps us to reproduce\r\n and find the issue quicker. Version information is found in the\r\n Home Assistant frontend: Configuration -> Info.\r\n-->\r\n\r\n- Home Assistant Core release with the issue: Home Assistant 0.114.4\r\n- Last working Home Assistant Core release (if known): None\r\n- Operating environment (OS/Container/Supervised/Core): raspbian\r\n- Integration causing this issue: waqi\r\n- Link to integration documentation on our website: https://www.home-assistant.io/integrations/waqi/\r\n\r\n## Problem-relevant `configuration.yaml`\r\n```yaml\r\nsensor:\r\n - platform: waqi\r\n token: \"{{ waqi_api_token }}\"\r\n locations:\r\n - seattle\r\n - corvallis\r\n```\r\n\r\n## Traceback/Error logs\r\n<!--\r\n If you come across any trace or error logs, please provide them.\r\n-->\r\n\r\n```txt\r\n2020-09-11 15:11:31 ERROR (MainThread) [homeassistant.components.waqi.sensor] Failed to connect to WAQI servers\r\nTraceback (most recent call last):\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 936, in _wrap_create_connection\r\n return await self._loop.create_connection(*args, **kwargs) # type: ignore # noqa\r\n File \"/usr/lib/python3.7/asyncio/base_events.py\", line 986, in create_connection\r\n ssl_handshake_timeout=ssl_handshake_timeout)\r\n File \"/usr/lib/python3.7/asyncio/base_events.py\", line 1014, in _create_connection_transport\r\n await waiter\r\n File \"/usr/lib/python3.7/asyncio/selector_events.py\", line 801, in _read_ready__data_received\r\n data = self._sock.recv(self.max_size)\r\nConnectionResetError: [Errno 104] Connection reset by peer\r\n\r\nThe above exception was the direct cause of the following exception:\r\n\r\nTraceback (most recent call last):\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/homeassistant/components/waqi/sensor.py\", line 73, in async_setup_platform\r\n stations = await client.search(location_name)\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/waqiasync/__init__.py\", line 32, in search\r\n return (yield from self._get(SEARCH_URL, keyword=keyword))\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/waqiasync/__init__.py\", line 48, in _get\r\n path, params=dict(self._params, **kwargs))\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/client.py\", line 483, in _request\r\n timeout=real_timeout\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 523, in connect\r\n proto = await self._create_connection(req, traces, timeout)\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 859, in _create_connection\r\n req, traces, timeout)\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 1004, in _create_direct_connection\r\n raise last_exc\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 986, in _create_direct_connection\r\n req=req, client_error=client_error)\r\n File \"/srv/homeassistant/lib/python3.7/site-packages/aiohttp/connector.py\", line 943, in _wrap_create_connection\r\n raise client_error(req.connection_key, exc) from exc\r\naiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.waqi.info:443 ssl:default [Connection reset by peer]\r\n```\r\n\r\n## Additional information\r\n\r\nFrom looking at the code in `waqi/sensor.py` it looks a lot like the mapping of location to station is done early in the process of HA start, and not again. That means that uses of this sensor fail pretty clunkily, with errors like \"Entity is non-numeric: sensor.waqi_queen_anne_hill_seattle_washington_usa\" and do not appear to recover.",
"title": "WAQI integration is unrecoverably disabled if the search API is not available during HA startup.",
"type": "issue"
}
] | 3 | 4 | 5,169 | false | true | 4,402 | false |
x48-crypto/yearn-party | null | 707,640,955 | 3 | null | [
{
"action": "opened",
"author": "DarkGhost7",
"comment_id": null,
"datetime": 1600891122000,
"masked_author": "username_0",
"text": "Let people manually put in an address as an option so they can check their yield even when they don't have their web3 wallet on them. Or like yieldfarming does let them add ?addr= in the url",
"title": "Let people use none-web 3 ",
"type": "issue"
},
{
"action": "created",
"author": "Deepcryptodive",
"comment_id": 700233692,
"datetime": 1601321121000,
"masked_author": "username_1",
"text": "This would actually be really nice, yes! :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "x48-crypto",
"comment_id": 700236701,
"datetime": 1601321496000,
"masked_author": "username_2",
"text": "@username_1, it's certainly possible to do this without too much work :) \r\nFocused on another project at the moment (will release soon!) but will keep this in mind!",
"title": null,
"type": "comment"
}
] | 3 | 3 | 401 | false | false | 401 | true |
pbrakel/anica | null | 671,932,866 | 2 | null | [
{
"action": "opened",
"author": "yerzhanimanmalik",
"comment_id": null,
"datetime": 1596446567000,
"masked_author": "username_0",
"text": "Great work! \r\nIt seems to be applicable to the research that I am currently doing.\r\n\r\nHowever, I am struggling to run this code on Tensorflow2 and Python3.\r\nDo you aware of the ways I can do it? Or do you have any other suggestions?\r\nPerhaps some other pytorch implementations of adversarial nonlinear ica are existent\r\n\r\nThanks in advance",
"title": "Run on newer tensorfolow",
"type": "issue"
},
{
"action": "created",
"author": "pbrakel",
"comment_id": 668413299,
"datetime": 1596523687000,
"masked_author": "username_1",
"text": "Hi,\r\n\r\nThanks for your interest and reaching out.\r\n\r\nI haven't maintained this code in a while but if you have Tensorflow2 installed, replacing occurrences of `import tensorflow as tf` with `import tensorflow.compat.v1 as tf` would be the first thing to do and it might be sufficient but see https://www.tensorflow.org/guide/upgrade for more info. Python3 compatibility is a bit harder to predict. I might add this in the future but if you get it to work yourself, a pull request would be very welcome :)\r\n\r\nI don't know of any other implementations of exactly this algorithm (it's research code) but the factorized VAE is almost the same idea (although not used for ICA) and can be found here: https://github.com/YannDubs/disentangling-vae. You might also want to check out Devon Hjelm's work on Deep Infomax: https://github.com/rdevon/DIM\r\n\r\nBest,\r\n\r\nPhilemon",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yerzhanimanmalik",
"comment_id": 668462043,
"datetime": 1596530001000,
"masked_author": "username_0",
"text": "Thank you for your answer!\r\n\r\nYeah sure, if I'll manage to run it or going to implement it on pytorch, I'll let you know :)\r\n\r\nThanks for pointing out the works on factorized VAE and Deep Infomax. I am looking for the ways to do fMRI component analysis using neural nets instead of ICA. If by any chance you have encountered any other use of deep learning for ICA, I'd be very grateful if you share the links.\r\n\r\nSincerely, Yerzhan",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "yerzhanimanmalik",
"comment_id": null,
"datetime": 1596771468000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "yerzhanimanmalik",
"comment_id": 670303606,
"datetime": 1596771468000,
"masked_author": "username_0",
"text": "Philemon, thanks again for your previous answer!\r\n\r\nI found this recent work on non-linear ICA, just wanted to share with you [(https://github.com/ilkhem/icebeem)]",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pbrakel",
"comment_id": 670329177,
"datetime": 1596777934000,
"masked_author": "username_1",
"text": "Hi Yerzhan,\r\n\r\nThanks for sharing that paper! It looks interesting.\r\n\r\nBest,\r\n\r\nPhilemon",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,882 | false | false | 1,882 | false |
redbluegames/unity-mulligan-renamer | redbluegames | 688,842,702 | 262 | null | [
{
"action": "opened",
"author": "edwardrowe",
"comment_id": null,
"datetime": 1598838652000,
"masked_author": "username_0",
"text": "Duplicate and translate the english.json file into spanish.json. I think that's all that we need to do to get this to work.",
"title": "Add Spanish translations",
"type": "issue"
},
{
"action": "created",
"author": "Arcnor",
"comment_id": 694100232,
"datetime": 1600333403000,
"masked_author": "username_1",
"text": "Hey, not sure why you target Spanish specifically, but I can help if you want? I didn't find any `english.json` file but a `en.json` instead, which I guess is the right one. Let me know if you want me to translate this one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edwardrowe",
"comment_id": 694627305,
"datetime": 1600399772000,
"masked_author": "username_0",
"text": "Spanish translation help would be great!\r\n\r\nI actually have a friend who may have nearly finished a Spanish translation, but I have to get it from him. I'll update this once I get the translation, and you could double check it in the app (he just did it by reading the json).\r\n\r\nThe file would be named es.json. These match the google language codes. I don't love it, but we should keep that convention for now.\r\n\r\nAlso, you should look at https://hacktoberfest.digitalocean.com/ if you haven't. October would be a great time to contribute this translation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edwardrowe",
"comment_id": 695220605,
"datetime": 1600526008000,
"masked_author": "username_0",
"text": "Es.json added by @jesus-devalos. Note it's only working in the *staging* branch right now, and you could make pull requests directly in there.\r\n\r\nThere are a few keys at the bottom that were added since he made that translation. Those could be translated, and a general QA pass would be helpful. @username_1. No pressure, though. You've already helped just by contributing to these issues!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Arcnor",
"comment_id": 695290375,
"datetime": 1600530563000,
"masked_author": "username_1",
"text": "Awesome, I'll take a look at it soon!\r\n\r\nAlso, as a general comment, may I suggest (for next time, probably) that you change your I18N format a bit? I've seen that you have some sentences split that I guess you later concatenate in the plugin (like the \"This is an example with added words\" or something similar). That's a bit too English centric, and some languages won't work splitting them like that :).\r\n\r\nAlso, some languages have different words depending on the numeral appended to them, so if you have any sentences that contain a number, some languages will need the number itself to be able to translate it properly.\r\n\r\nThere are a few things like that, but I won't bore you with the details, as you might even know them already.\r\n\r\nAnyway, I hope this helps, and if you haven't worked with I18N before this, let me know if you want any help, I love this kind of thing :).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edwardrowe",
"comment_id": 695345939,
"datetime": 1600542685000,
"masked_author": "username_0",
"text": "The advice is appreciated, for sure. I do actually know a decent amount about it through my work in games, but there is still plenty I don't know. I've never included a language that reads right to left for example. And I don't know the best way to do singular and plural stuff like \"You have renamed {0} {1}\" : \"You have renamed 24 objects\", where you might need to change the object of the sentence (1) based on the plurality of (0).\r\n\r\nSooo any tips on best practices or frameworks would be helpful. \r\n\r\nI will say most of the errors I knew about and just figured YAGNI - I'll fix it when I need it, but I should have fixed it before doing any translation.\r\n\r\nIf fixing it is feasible, we could open an issue. But I'm curious, does it actually impact Spanish or Portuguese?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "edwardrowe",
"comment_id": null,
"datetime": 1600607764000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "edwardrowe",
"comment_id": 695786127,
"datetime": 1600607764000,
"masked_author": "username_0",
"text": "Ok this is done - feel free to review the translation @username_1, or let me know if the format is causing problems with any of the languages. I'm gonna close this out but feel free to comment here or we can open another issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Arcnor",
"comment_id": 696030495,
"datetime": 1600684154000,
"masked_author": "username_1",
"text": "Hi there, sorry for the delay, I've been busy (like everybody else :D). I've done a quick check of the translations, and unfortunately there are various issues I've found (inconsistencies, mistakes as well as things that don't make much sense). I'll try to get a corrected one this week if possible, as well as try to get some friends to do a second proofread pass on it after I'm done.\r\n\r\nAs for the format causing problems, I don't think so (at least for Spanish) but I haven't checked all sentences. Also, if you already have experience I'm sure whatever I mention will sound patronizing, so I don't want to get there :).\r\n\r\nThanks for this wonderful asset though, I forgot to mention it as my very first message (as well as the Null Checker, which is the one I use the most)!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edwardrowe",
"comment_id": 696506217,
"datetime": 1600750058000,
"masked_author": "username_0",
"text": "Thanks! I'm happy to contribute to open source with this Asset. If you do\nhave some best practices on translation formatting they'd be welcome -\nespecially if you have experience with it outside games. No need to worry\nabout sounding patronizing :)\n\nIf you want to verify the translation, I've created an issue to track the\nwork against:\nhttps://github.com/redbluegames/unity-mulligan-renamer/issues/268\n\nAnd if you like NotNull, I'd highly recommend checking out OdinInspector\nfor commercial products. It's got great (better than NotNull) validation\nattributes.",
"title": null,
"type": "comment"
}
] | 2 | 10 | 4,510 | false | false | 4,510 | true |
emartinm/lsql | null | 757,357,221 | 18 | {
"number": 18,
"repo": "lsql",
"user_login": "emartinm"
} | [
{
"action": "opened",
"author": "Tamiflu9",
"comment_id": null,
"datetime": 1607111048000,
"masked_author": "username_0",
"text": "No se si los test estarán bien, pero no me saltan errores..\r\n\r\nAl comprobar el pylint me daba un 9.99/10 y he añadido dos cosas para que no me salieran los mensajes de error y conseguir el 10/10. No se si he hecho bien.",
"title": "Botón para descargar el código de un envío y sus tests",
"type": "issue"
},
{
"action": "created",
"author": "emartinm",
"comment_id": 739083551,
"datetime": 1607126491000,
"masked_author": "username_1",
"text": "Me resulta imposible revisar un PR que dice haber modificado 37 ficheros :-( Sobre todo porque el 95% de los cambios que dice tener no son tuyos, y es una auténtica locura. Otra cosa que tendrías que corregir son los conflictos en lsql/judge/tests/test_views.py.\r\n\r\nCreo que algo mal estamos haciendo en la manera en la que actualizáis vuestro fork con los cambios del upstream. Porque antes de hacer el PR actualizas los ficheros de tu repositorio a partir del principal y fusionas los cambios, ¿verdad? ¿Podrías decirme qué comandos ejecutas para actualizar tu repositorio fork con los cambios del repositorio principal?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Tamiflu9",
"comment_id": 739239055,
"datetime": 1607167993000,
"masked_author": "username_0",
"text": "No uso comandos, me descargue una aplicación: Github-Desktop, que parecía más fácil de usar pero igual no lo estoy haciendo bien. He probado ahora a hacerlo con comandos clonando el repositorio otra vez y todo y no me deja actualizar mi repositorio. \r\nHe usado estos comandos:\r\n\r\n$ git clone https://github.com/username_0/lsql.git\r\n$ cd lsql\r\n$ git remote add upstream https://github.com/username_1/lsql.git\r\n$ git fetch upstream\r\n$ git rebase upstream/master\r\n\r\n-- aqui me da un error el TODO.md\r\n\r\nerror: could not apply 4e10dcf... Update TODO.md\r\nCONFLICT (content): Merge conflict in TODO.md\r\n\r\ny luego a la hora de actualizar no hace nada.\r\n$ git push -f origin master",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "emartinm",
"comment_id": 739424728,
"datetime": 1607207277000,
"masked_author": "username_1",
"text": "Resolviste al final el conflicto con TODO.md, @username_0 ? Es que ahora me aparece un nuevo commit mucho más manejable, que podría revisar. ¿Hiciste algo concreto?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Tamiflu9",
"comment_id": 739433715,
"datetime": 1607213205000,
"masked_author": "username_0",
"text": "al cambiar el test_view.py y resolver los conflictos me pedía hacer un commit y después de hacerlo ahi si que me parecían solo mis cambios (y no como antes que salían todos los que se habían hecho hasta el momento) y no se si ha sido eso lo que ha cambiado, porque no he hecho nada mas creo...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "emartinm",
"comment_id": 782933671,
"datetime": 1613944368000,
"masked_author": "username_1",
"text": "Cerrado porque es muy antiguo y se hará uno nuevo desde cero.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 2,026 | false | false | 2,026 | true |
zrpm/github-slideshow | null | 806,729,934 | 1 | null | [
{
"action": "closed",
"author": "zrpm",
"comment_id": null,
"datetime": 1613077440000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "zrpm",
"comment_id": null,
"datetime": 1613077445000,
"masked_author": "username_0",
"text": "# :wave: Bienvenido a \"Introducción a GitHub\" de GitHub Learning Lab\n\nPara empezar, te guiaré a través de unos primeros pasos que son importantes para programar y colaborar en GitHub. \n\n:point_down: _Esta flecha indica que puedes expandir la ventana! Haz clic en ellas durante el curso para más información._\n<details><summary>¿Qué es GitHub?</summary>\n<hr>\n \n## ¿Qué es GitHub?\n\n¡Me alegra que lo hayas preguntado! Muchas personas usan GitHub porque quieren contribuir a proyectos de código abierto <sup>[:book:](https://help.github.com/articles/github-glossary/#open-source)</sup>, o porque son invitados por compañeros de trabajo o de clase que usan GitHub en sus proyectos. ¿Por qué la gente usa GitHub en sus proyectos?\n\n**En esencia, GitHub es una plataforma de colaboración.**\n\nDesde software hasta documentos legales, puedes contar con GitHub para ayudarte a hacer tu mejor trabajo con las herramientas de colaboración y seguridad que tu equipo necesita. Con GitHub, puedes mantener proyectos completamente privados, invitar al mundo a colaborar y optimizar cada paso de tu proyecto. \n\n**GitHub también es una poderosa herramienta de versión de control.**\n\nGitHub usa Git <sup>[:book:](https://help.github.com/articles/github-glossary/#git)</sup>, el software de control de versión más popular para rastrear cada contribución y colaborador <sup>[:book:](https://help.github.com/articles/github-glossary/#contributor)</sup> de tu proyecto--de esta manera sabrás exactamente de dónde vino cada línea de código de tu proyecto.\n\n**GitHub ayuda a las personas a hacer mucho más.**\n\nLa gente usa GitHub para construir varias de las tecnologías más avanzadas del mundo. Ya sea que estes visualizando datos o construyendo un nuevo juego, hay una comunidad entera y un set de herramientas en GitHub que te puedan llevar al siguiente nivel. Este curso empieza con lo básico pero ¡profundizaremos el resto después!\n\n:tv: [Video: ¿Qué es GitHub?](https://www.youtube.com/watch?v=w3jLJU7DT5E)\n<hr>\n</details><br>\n\n<details><summary>Explorando un repositorio de GitHub</summary>\n<hr>\n\n## Explorando un repositorio de GitHub\n\n:tv: [Video: Explorando un repositorio](https://www.youtube.com/watch?v=R8OAwrcMlRw)\n\n### Más características\n\nEl video cubre algunas de las características usadas con mayor frecuencia. Aquí hay otras cosas que puedes encontrar en los repositorios de GitHub:\n\n- Tableros para el proyecto: Crear un tablero estilo Kanban para seguir tus tareas dentro de GitHub \n- Wiki: Crea y guarda documentación relevante acerca de tu proyecto. \n- Estadísticas: Ve un menú desplegable que contiene enlaces a herramientas de análisis para tu repositorio, que incluyen:\n - Pulso: Encuentra información sobre el trabajo que ha sido completado y el trabajo que está en progreso en este panel del proyecto.\n - Gráficas: Las gráficas proporcionan una vista más granular de la actividad del repositorio, incluyendo quién contribuyó al repositorio, quién lo bifurcó y cuándo completaron el trabajo.\n\n### Archivos especiales\n\nEn el video aprendiste sobre un archivo especial llamado README.md. Aquí hay una lista de algunos otros archivos especiales que puedes añadir a tus repositorios:\n\n- CONTRIBUTING.md: El archivo `CONTRIBUTING.md` es usado para describir el proceso para contribuir al repositorio. Un link al archivo `CONTRIBUTING.md` es mostrado cada vez que alguien crea una nueva propuesta o una solicitud de extracción. \n- ISSUE_TEMPLATE.md: El archivo `ISSUE_TEMPLATE.md` lo puedes usar para rellenar el cuerpo de una propuesta. Por ejemplo, si siempre necesitas el mismo tipo de información para reportar errores puedes incluirlo en la plantilla de tu propuesta y cada nueva propuesta será abierta con el texto que has recomendado para empezar. \n\n<hr>\n</details>\n\n### Usando las propuestas (o _issues_)\nEsto es una propuesta (o _issue_) <sup>[:book:](https://help.github.com/articles/github-glossary/#issue)</sup>: un lugar en el que puedes tener conversaciones sobre los errores en tu código, revisiones de código y casi cualquier otra cosas que te puedas imaginar. \n\nLos títulos de tus propuestas son como la línea de asunto de un email. Avisan de un vistazo a tus colaboradores de qué trata tu propuesta. Por ejemplo, el título de esta propuesta es Getting Started with GitHub.\n\n<details><summary>Usando GitHub Issues (propuestas)</summary>\n\n## Usando propuestas de GitHub\n\nLas propuestas se usan para discutir ideas, mejoras, tareas y errores. Facilitan la colaboración al:\n\n- Proveer a todos (incluso miembros futuros) la historia completa en un solo lugar\n- Permitirte entrelazar tu propuesta con otras propuestas o una solicitud de extracción (o _pull request_) <sup>[:book:](https://help.github.com/articles/github-glossary/#pull-request)</sup>\n- Crear un registro único y completo de cómo y por qué tomaste ciertas decisiones\n- Permitirte atraer fácilmente a las personas y los equipos adecuados a una conversación con @mencion\n:tv: [Video: Usando propuestas](https://www.youtube.com/watch?v=Zhj46r5D0nQ)\n\n<hr>\n</details>\n\n<details><summary>Administrando notificaciones</summary>\n<hr>\n\n## Administrando notificaciones\n\n:tv: [Video: Observando, notificaciones, estrellas y explorar](https://www.youtube.com/watch?v=ocQldxF7fMY)\n\nUna vez que hayas comentado en una propuesta o solicitud de extracción, empezarás a recibir notificaciones por email cada vez que haya actividad en tu hilo. \n\n## Cómo silenciar o dejar de silenciar conversaciones en específico. \n\n1. Ve a la propuesta o solicitud de extracción\n2. Bajo _\"Notifications\"_, haz clic en el botón de **Unsubscribe** a la derecha para silenciar notificaciones o **Subscribe** para dejar de silenciarlas. \n\nVerás una descripción corta que explica tu estado actual de notificaciones.\n\n### Cómo personalizar notificaciones en Settings\n\n1. Haz clic en el icono de tu perfil\n2. Haz clic en **Settings**\n3. Haz clic en **Notifications** desde el menú a tu izquierda y [ajusta tus preferencias de notificaciones](https://help.github.com/articles/managing-notification-delivery-methods/)\n\n### Opciones de notificación de un repositorio\n\n* **Watch**: Recibirás una notificación cuando una nueva propuesta, solicitud de extracción o comentario ha sido publicado y también cuando una propuesta ha sido cerrado o una solicitud de extracción ha sido fusionada.\n* **Not watching**: No vas a recibir notificaciones al menos que te hayan mencionado usando @\n* **Ignore**: No vas a recibir ningún tipo de notificación sobre este respoitorio\n\n## Cómo revisar las notificaciones de los repositorios que estás observando\n\n1. Haz clic en tu icono de perfil\n2. Haz clic en **Settings**\n3. Haz clic en **Notification** desde el menú a tu izquierda\n4. Haz clic en el link de [repositorios que estás observando](https://github.com/watching)\n5. Selecciona la pestaña **Watching**\n6. Haz clic en el botón de **Unwatch** para inhabilitar las notificaciones o en **Watch** para habilitarlas. \n\n<hr>\n</details>\n\n<hr>\n<h3 align=\"center\">Sigue leyendo a continuación para encontrar tu primera tarea</h3>",
"title": "Getting Started with GitHub",
"type": "issue"
},
{
"action": "closed",
"author": "zrpm",
"comment_id": null,
"datetime": 1613077670000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 8 | 14,808 | false | true | 7,049 | false |
eamodio/vscode-gitlens | null | 801,075,549 | 1,363 | null | [
{
"action": "opened",
"author": "mtelgkamp",
"comment_id": null,
"datetime": 1612429279000,
"masked_author": "username_0",
"text": "<!--\r\nFor any Git related or intermittent issues, please enable output channel logging by setting `\"gitlens.outputLevel\": \"debug\"` in your settings.json.\r\nThis will enable logging to the `GitLens` and `GitLens (Git)` channels in the Output pane.\r\nOnce enabled, please attempt to reproduce the issue (if possible) and attach the log lines from both channels.\r\n-->\r\n\r\n- GitLens Version: 11.1.3\r\n- Git Version: 2.30.0\r\n- VSCode Version: 1.52.1\r\n- OS Version: Ubuntu 20.10\r\n\r\n## Steps to Reproduce\r\n\r\n1. add git config setting `log.showsignature=true`\r\n2. try to display a diff of a file by selecting it in the COMMITS section\r\n3. Error: Unable to open compare. See output channel for more details\r\n\r\n## The reason\r\nFrom the logs I figured out that the following git command is called\r\n```\r\ngit log -n1 --no-renames --format=%H --find-object=HASH ANOTHER_HASH -- FILENAME\r\n```\r\nWhen I execute it manually the output looks like this:\r\n```\r\ngpg: some text\r\ngpg: some text\r\ngpg: some text\r\nHASH VALUE\r\n```\r\nAfterwards the following command is in the `GitLens (Git)` log:\r\n```\r\ngit show --name-status --format= gpg: Signature...\r\n```\r\n\r\n## Idea\r\nIt might be useful to add the parameter `-c log.showSignature=false` to all git comands relying on the git output. In this case the command would look like this:\r\n```\r\ngit -c log.showSignature=false log -n1 --no-renames --format=%H --find-object=HASH ANOTHER_HASH -- FILENAME\r\n```\r\nAnother option would be to ignore all output starting with `gpg: `.",
"title": "Error 'Unable to open compare', when git setting log.showsignature is active",
"type": "issue"
},
{
"action": "closed",
"author": "eamodio",
"comment_id": null,
"datetime": 1612911485000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "eamodio",
"comment_id": 776300670,
"datetime": 1612911538000,
"masked_author": "username_1",
"text": "Great catch -- it looks like I had a bunch of newer log calls that were failing to include the `-c log.showSignature=false` parameter.\r\n\r\nCan you please verify this fix in tomorrow's insiders edition?\r\n\r\nYou can install the insiders edition from [here](https://marketplace.visualstudio.com/items?itemName=username_1.gitlens-insiders). Be sure to disable/uninstall the stable version of GitLens first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mtelgkamp",
"comment_id": 776864608,
"datetime": 1612976668000,
"masked_author": "username_0",
"text": "Thank you very much for the quick fix. It works for me, in the insider edition.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 2,112 | false | true | 1,964 | true |
vincentlaucsb/csv-parser | null | 537,289,348 | 66 | null | [
{
"action": "opened",
"author": "vincentlaucsb",
"comment_id": null,
"datetime": 1576197930000,
"masked_author": "username_0",
"text": "## Background\r\nCurrently, `CSVReader` rejects all rows not the same size as the predetermined header row. This causes issues when parsing CSV files which are not quite up to spec.\r\n\r\nAlthough it is possible to handle weird rows by creating a subclass of `CSVReader` and overriding `CSVReader::bad_row_handler`, that's kind of annoying.\r\n\r\n## Solution\r\n`CSVFormat` will get a new method called `allow_variable_lengths(false)`. `CSVReader` will then simply not perform row length checking until `read_row()` is called. This may even lead to performance improvements as the nested if/else branches in `CSVReader::write_record` will no longer be necessary.\r\n\r\nFor the default case (reject different length rows), `CSVReader` will behave as it has before, i.e. bad rows are tossed out and ignored with no user intervention.\r\n\r\n### Behavior for Variable Length Rows\r\nIf a user wants to keep rows of different length but still use `CSVReader`'s format guessing ability, then when iterating over the read rows, then the library will provide a `size()` method (and potentially others such as `is_weird_length()`, `is_shorter()`, etc. so that the user can tell which rows are malformed.\r\n\r\n#### Indexing Operator\r\nIf \"foobar\" is the name of the 16th column, and some malformed row has <16 columns, then `row[\"foobar\"]` shall result in an error being thrown.\r\n\r\nIf a CSV mostly has 16 columns but some row has >16 columns, then the extra columns should only be retrieved using `operator[](size_t)` and not `operator[](string)`. The `CSVRow` iterator should iterate through all entries of shorter and longer rows without crashing.",
"title": "Implement new API for handling malformed rows",
"type": "issue"
},
{
"action": "closed",
"author": "vincentlaucsb",
"comment_id": null,
"datetime": 1583995039000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "vincentlaucsb",
"comment_id": 598030243,
"datetime": 1583995039000,
"masked_author": "username_0",
"text": "Implemented by #80",
"title": null,
"type": "comment"
}
] | 1 | 3 | 1,636 | false | false | 1,636 | false |
RussKie/WindowsFormsAnalyzers | null | 809,261,853 | 1 | null | [
{
"action": "opened",
"author": "RussKie",
"comment_id": null,
"datetime": 1613477788000,
"masked_author": "username_0",
"text": "### Actual:\r\n\r\n```\r\n Non_numeric_TabIndex_should_produce_diagnostics\r\n Source: WinFormsAccessibilityTests.NonNumericTabIndexValueRule.cs line 18\r\n Duration: 4.5 sec\r\n\r\n Message: \r\n Assert.AreEqual failed. Expected:<0>. Actual:<14>. Context: Diagnostics of test state\r\n Mismatch between number of diagnostics returned, expected \"0\" actual \"14\"\r\n \r\n Diagnostics:\r\n // /0/Test0.cs(8,28): error CS0234: The type or namespace name 'Forms' does not exist in the namespace 'System.Windows' (are you missing an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS0234\").WithSpan(8, 28, 8, 33).WithArguments(\"Forms\", \"System.Windows\"),\r\n // /0/Test0.cs(8,70): error CS0234: The type or namespace name 'Forms' does not exist in the namespace 'System.Windows' (are you missing an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS0234\").WithSpan(8, 70, 8, 75).WithArguments(\"Forms\", \"System.Windows\"),\r\n // /0/Test0.cs(10,28): error CS0234: The type or namespace name 'Forms' does not exist in the namespace 'System.Windows' (are you missing an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS0234\").WithSpan(10, 28, 10, 33).WithArguments(\"Forms\", \"System.Windows\"),\r\n // /0/Test0.cs(10,70): error CS0234: The type or namespace name 'Forms' does not exist in the namespace 'System.Windows' (are you missing an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS0234\").WithSpan(10, 70, 10, 75).WithArguments(\"Forms\", \"System.Windows\"),\r\n // /0/Test0.cs(11,32): warning WF0001: Control 'button2' has unexpected TabIndex value: 'INDEX'.\r\n VerifyCS.Diagnostic(ControlTabOrderAnalyzer.WF0001).WithSpan(11, 32, 11, 37).WithArguments(\"button2\", \"INDEX\"),\r\n // /0/Test0.cs(15,18): error CS1061: 'Form1' does not contain a definition for 'AutoScaleDimensions' and no accessible extension method 'AutoScaleDimensions' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(15, 18, 15, 37).WithArguments(\"WinFormsApp1.Form1\", \"AutoScaleDimensions\"),\r\n // /0/Test0.cs(16,18): error CS1061: 'Form1' does not contain a definition for 'AutoScaleMode' and no accessible extension method 'AutoScaleMode' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(16, 18, 16, 31).WithArguments(\"WinFormsApp1.Form1\", \"AutoScaleMode\"),\r\n // /0/Test0.cs(16,34): error CS0234: The type or namespace name 'Forms' does not exist in the namespace 'System.Windows' (are you missing an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS0234\").WithSpan(16, 34, 16, 54).WithArguments(\"Forms\", \"System.Windows\"),\r\n // /0/Test0.cs(17,18): error CS1061: 'Form1' does not contain a definition for 'ClientSize' and no accessible extension method 'ClientSize' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(17, 18, 17, 28).WithArguments(\"WinFormsApp1.Form1\", \"ClientSize\"),\r\n // /0/Test0.cs(18,18): error CS1061: 'Form1' does not contain a definition for 'Controls' and no accessible extension method 'Controls' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(18, 18, 18, 26).WithArguments(\"WinFormsApp1.Form1\", \"Controls\"),\r\n // /0/Test0.cs(19,18): error CS1061: 'Form1' does not contain a definition for 'Controls' and no accessible extension method 'Controls' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(19, 18, 19, 26).WithArguments(\"WinFormsApp1.Form1\", \"Controls\"),\r\n // /0/Test0.cs(20,18): error CS1061: 'Form1' does not contain a definition for 'Name' and no accessible extension method 'Name' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(20, 18, 20, 22).WithArguments(\"WinFormsApp1.Form1\", \"Name\"),\r\n // /0/Test0.cs(21,18): error CS1061: 'Form1' does not contain a definition for 'Text' and no accessible extension method 'Text' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(21, 18, 21, 22).WithArguments(\"WinFormsApp1.Form1\", \"Text\"),\r\n // /0/Test0.cs(22,18): error CS1061: 'Form1' does not contain a definition for 'ResumeLayout' and no accessible extension method 'ResumeLayout' accepting a first argument of type 'Form1' could be found (are you missing a using directive or an assembly reference?)\r\n DiagnosticResult.CompilerError(\"CS1061\").WithSpan(22, 18, 22, 30).WithArguments(\"WinFormsApp1.Form1\", \"ResumeLayout\"),\r\n \r\n \r\n Stack Trace: \r\n MSTestVerifier.Equal[T](T expected, T actual, String message) line 41\r\n AnalyzerTest`1.VerifyDiagnosticResults(IEnumerable`1 actualResults, ImmutableArray`1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) line 336\r\n AnalyzerTest`1.VerifyDiagnosticsAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken) line 249\r\n CodeFixTest`1.RunAsync(CancellationToken cancellationToken) line 238\r\n CSharpCodeFixVerifier`2.VerifyAnalyzerAsync(String source, DiagnosticResult[] expected) line 37\r\n NonNumericTabIndexValueRule.Non_numeric_TabIndex_should_produce_diagnostics() line 47\r\n```\r\n\r\n### Expected:\r\n\r\n```\r\n Non_numeric_TabIndex_should_produce_diagnostics\r\n Source: WinFormsAccessibilityTests.NonNumericTabIndexValueRule.cs line 18\r\n Duration: 4.5 sec\r\n\r\n Message: \r\n Assert.AreEqual failed. Expected:<0>. Actual:<1>. Context: Diagnostics of test state\r\n Mismatch between number of diagnostics returned, expected \"0\" actual \"1\"\r\n \r\n Diagnostics:\r\n // /0/Test0.cs(11,32): warning WF0001: Control 'button2' has unexpected TabIndex value: 'INDEX'.\r\n VerifyCS.Diagnostic(ControlTabOrderAnalyzer.WF0001).WithSpan(11, 32, 11, 37).WithArguments(\"button2\", \"INDEX\"),\r\n\r\n```",
"title": "Failing tests",
"type": "issue"
},
{
"action": "created",
"author": "sharwell",
"comment_id": 779914909,
"datetime": 1613489595000,
"masked_author": "username_1",
"text": "```\r\nawait new VerifyCS.Test\r\n{\r\n ReferenceAssemblies = ReferenceAssemblies.NetFramework.Net472.DefaultWithWinForms,\r\n TestState =\r\n {\r\n Sources = { ... },\r\n },\r\n FixedState =\r\n {\r\n Sources = { ... },\r\n },\r\n}.RunAsync();\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "RussKie",
"comment_id": null,
"datetime": 1613525872000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "RussKie",
"comment_id": 780234790,
"datetime": 1613525882000,
"masked_author": "username_0",
"text": "Thank you!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 6,689 | false | false | 6,689 | false |
adobe/S3Mock | adobe | 343,392,543 | 88 | {
"number": 88,
"repo": "S3Mock",
"user_login": "adobe"
} | [
{
"action": "opened",
"author": "timoe",
"comment_id": null,
"datetime": 1532252752000,
"masked_author": "username_0",
"text": "## Description\r\nI'd like to have ListObjectsV2 as one separat commit so I squashed these 6 commits. I also went through the code and removed some of IDEAs Inspections warning and added @sveryovka to the list of authors.\r\n\r\n## Related Issue\r\n<!--- if applicable -->\r\n\r\n## Tasks\r\n<!--- These tasks need to be done in order to get the PR merged, please mark with `x` if done or if they are not applicable to you or the change -->\r\n\r\n- [x] I have signed the [CLA](http://adobe.github.io/cla.html).\r\n- [ ] I have written tests and verified that they fail without my change.",
"title": "adds sveryovka as an author, squashed last 6 commits and polished code a bit",
"type": "issue"
},
{
"action": "created",
"author": "agudian",
"comment_id": 406860425,
"datetime": 1532260714000,
"masked_author": "username_1",
"text": "The squashing part is already pushed to master, right?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 622 | false | false | 622 | false |
penske-media-corp/pmc-larva | penske-media-corp | 733,227,942 | 276 | {
"number": 276,
"repo": "pmc-larva",
"user_login": "penske-media-corp"
} | [
{
"action": "opened",
"author": "m-muhsin",
"comment_id": null,
"datetime": 1604067930000,
"masked_author": "username_0",
"text": "Hi @laras126 \r\n\r\nI was not able to do a `npm run build` from `packages/larva-css`. So, I have added the source code for the new algorithm. We need to build it.\r\n\r\nThanks,\r\nMuhammad",
"title": "Add line clamp algorithm",
"type": "issue"
}
] | 2 | 2 | 655 | false | true | 180 | false |
ChildMindInstitute/mindlogger-app-backend | ChildMindInstitute | 544,260,437 | 385 | null | [
{
"action": "opened",
"author": "binarybottle",
"comment_id": null,
"datetime": 1577822359000,
"masked_author": "username_0",
"text": "Display fields in more appropriate order\n\nFIRST NAME\nLAST NAME\nEMAIL\nUSERNAME\nPASSWORD\n",
"title": "New user panel",
"type": "issue"
},
{
"action": "closed",
"author": "binarybottle",
"comment_id": null,
"datetime": 1577822360000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "binarybottle",
"comment_id": 569982574,
"datetime": 1577822362000,
"masked_author": "username_0",
"text": "Consolidating design-related issues into a single document...",
"title": null,
"type": "comment"
}
] | 1 | 3 | 272 | false | false | 272 | false |
aminnairi/collatz | null | 624,794,042 | 17 | null | [
{
"action": "opened",
"author": "aminnairi",
"comment_id": null,
"datetime": 1590490642000,
"masked_author": "username_0",
"text": "**Is your feature request related to a problem? Please describe.**\r\nThe description should not include that this is a command-line interface. It is pretty much self-explanatory at the way it is used in the documentation.\r\n\r\n**Describe the solution you'd like**\r\nUpdate the `README.md` & man page by removing the part talking about the command-line interface.\r\n\r\n**Describe alternatives you've considered**\r\nN/A.\r\n\r\n**Additional context**\r\nN/A.",
"title": "Shorten the description",
"type": "issue"
}
] | 1 | 1 | 443 | false | false | 443 | false |
manniwatch/manniwatch | manniwatch | 685,187,856 | 890 | {
"number": 890,
"repo": "manniwatch",
"user_login": "manniwatch"
} | [
{
"action": "created",
"author": "donmahallem",
"comment_id": 679815574,
"datetime": 1598336094000,
"masked_author": "username_0",
"text": "@dependabot squash and merge",
"title": null,
"type": "comment"
}
] | 3 | 3 | 11,656 | false | true | 28 | false |
kubeflow/manifests | kubeflow | 561,292,529 | 879 | {
"number": 879,
"repo": "manifests",
"user_login": "kubeflow"
} | [
{
"action": "created",
"author": "zhenghuiwang",
"comment_id": 583168153,
"datetime": 1581033119000,
"masked_author": "username_0",
"text": "/lgtm\r\n/approve",
"title": null,
"type": "comment"
}
] | 3 | 4 | 1,730 | false | true | 15 | false |
facebookresearch/pytext | facebookresearch | 643,266,254 | 1,386 | {
"number": 1386,
"repo": "pytext",
"user_login": "facebookresearch"
} | [
{
"action": "opened",
"author": "kartikayk",
"comment_id": null,
"datetime": 1592849257000,
"masked_author": "username_0",
"text": "Summary: For classification problems with a large label space, its not possible to explictly specify the label vocab as a list in the config (eg: megataxon where there are ~10K labels). Its also not possible to extract these from the data because there might be some labels which are missing from the training data. While this is not ideal, its not right to enforce that every label in the dataset should be present in the training data especially if the instances with these labels in the test set is quite small. These failures can be annoying and the pre-processing involved is quite cumbersome. So here I add the ability to just specify the labels as a file.\n\nReviewed By: snisarg\n\nDifferential Revision: D21575711",
"title": "Make it easy to specify a large number of labels",
"type": "issue"
}
] | 2 | 4 | 1,096 | false | true | 718 | false |
openshift/ocs-operator | openshift | 774,614,032 | 973 | {
"number": 973,
"repo": "ocs-operator",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "umangachapagain",
"comment_id": null,
"datetime": 1608866909000,
"masked_author": "username_0",
"text": "Before migrating to new project structure and tools, CSV Merger was using templates added by source-manifests to inject OCS_IMAGE value. When we moved to using Kustomize, we set the images directly instead of first templating and replacing.\r\nThis broke the build pipeline as it didn't safeguard itself against uninitialized OCS_IMAGE var.\r\n\r\nThis PR reverts back to using templates instead of Kustomize to unblock the build pipeline.\r\nAlternatively, build pipeline can set OCS_IMAGE env var a little early and all will be well (without this PR)",
"title": "Source Manifest uses template instead of OCS_IMAGE for backward compatibility",
"type": "issue"
},
{
"action": "created",
"author": "umangachapagain",
"comment_id": 754032589,
"datetime": 1609773171000,
"masked_author": "username_0",
"text": "Build pipeline is fixed. Closing this PR as we decided to use Kustomize instead of Go Templates for simplicity.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 3,814 | false | true | 655 | false |
sophiakaterina5/write-docker-actions | null | 671,690,052 | 4 | {
"number": 4,
"repo": "write-docker-actions",
"user_login": "sophiakaterina5"
} | [
{
"action": "opened",
"author": "sophiakaterina5",
"comment_id": null,
"datetime": 1596402479000,
"masked_author": "username_0",
"text": "",
"title": "Create action.yml",
"type": "issue"
}
] | 2 | 12 | 14,325 | false | true | 0 | false |
CamileHTLTT/github-slideshow | null | 624,514,776 | 3 | {
"number": 3,
"repo": "github-slideshow",
"user_login": "CamileHTLTT"
} | [
{
"action": "opened",
"author": "CamileHTLTT",
"comment_id": null,
"datetime": 1590447963000,
"masked_author": "username_0",
"text": "hmm",
"title": "Create 0000-01-02-CamileHTLTT.md",
"type": "issue"
}
] | 2 | 2 | 1,772 | false | true | 3 | false |
filecoin-project/community | filecoin-project | 648,647,762 | 40 | null | [
{
"action": "opened",
"author": "JacobDenver007",
"comment_id": null,
"datetime": 1593574959000,
"masked_author": "username_0",
"text": "我现在想基于filecoin 当前的测试网开发钱包，但是没有找到以上的资料",
"title": "请问有开发者电报群或者有测试网的公共节点么",
"type": "issue"
},
{
"action": "created",
"author": "sypro2020",
"comment_id": 672370896,
"datetime": 1597189858000,
"masked_author": "username_1",
"text": "没有，你可以建立一个",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jennijuju",
"comment_id": 778572494,
"datetime": 1613198418000,
"masked_author": "username_2",
"text": "https://network.filecoin.io",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jennijuju",
"comment_id": null,
"datetime": 1613198418000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 74 | false | false | 74 | false |
JelteF/derive_more | null | 740,079,857 | 146 | null | [
{
"action": "opened",
"author": "abonander",
"comment_id": null,
"datetime": 1605027404000,
"masked_author": "username_0",
"text": "C-like enums with an explicit `#[repr(<int type>)]` attribute can be cast to that integer type, but there's no easy way to convert back:\r\n\r\n```rust\r\n#[repr(i16)]\r\nenum MyEnum {\r\n Foo = 1,\r\n Bar = 2,\r\n}\r\n\r\nlet val = MyEnum::Bar as i16;\r\nlet my_enum: MyEnum = // convert `val` back to `MyEnum`\r\n```\r\n\r\nThis derive exists in [`enum-utils`](https://docs.rs/enum-utils/0.1.2/enum_utils/derive.TryFromRepr.html) but it would be nice not to have to reach for multiple crates.",
"title": "Derive `TryFrom<T>` for enums marked `#[repr(T)]`",
"type": "issue"
}
] | 1 | 1 | 474 | false | false | 474 | false |
ctu-mrs/mrs_uav_system | ctu-mrs | 761,071,946 | 28 | null | [
{
"action": "opened",
"author": "PhilPhal",
"comment_id": null,
"datetime": 1607592995000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nDuring the simulations I noticed the position of the drone always has a certain offset from the demanded position. In my situation, I make the drone go to the origin. But it never reaches it and stays at an offset of approximately 20cm (from the center of mass of the drone). Do you have an idea how to get rid of this offset?\r\n\r\nThank you in advance.\r\n\r\nBest,\r\nPhilippe",
"title": "Offset in position of drone",
"type": "issue"
},
{
"action": "created",
"author": "PhilPhal",
"comment_id": 743277467,
"datetime": 1607702395000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nThank you for the explanation and tips. Everything works fine now.\r\n\r\nBest regards,\r\nPhilippe",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "PhilPhal",
"comment_id": null,
"datetime": 1607702395000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 483 | false | false | 483 | false |
daos-stack/daos | daos-stack | 604,333,541 | 2,499 | {
"number": 2499,
"repo": "daos",
"user_login": "daos-stack"
} | [
{
"action": "opened",
"author": "dpquigl",
"comment_id": null,
"datetime": 1587509446000,
"masked_author": "username_0",
"text": "The default values for certificates expected by each component do not line up\r\nwith the names that are generated by the certificate generation script.\r\nAdditionally dmg and daos_agent shared a single default configuration. This\r\nsplits those configurations to have component specific configuration defaults\r\nin addition to unifying the default values of the certificate names.",
"title": "DAOS-4336 Security: Unify certificate naming",
"type": "issue"
},
{
"action": "created",
"author": "daosbuild1",
"comment_id": 617468883,
"datetime": 1587512940000,
"masked_author": "username_1",
"text": "Test stage Test CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2499/1/execution/node/569/log",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "daosbuild1",
"comment_id": 617564513,
"datetime": 1587534433000,
"masked_author": "username_1",
"text": "Test stage Functional_Hardware_Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-2499/1/testReport/(root)/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dpquigl",
"comment_id": 617830433,
"datetime": 1587567377000,
"masked_author": "username_0",
"text": "I still need to fix the rpm test failure since its using the wrong config and trying to use certificates but the failure in Functional Hardware Large is a known failure (https://jira.hpdd.intel.com/browse/DAOS-4285)",
"title": null,
"type": "comment"
}
] | 2 | 4 | 941 | false | false | 941 | false |
hassio-addons/addon-node-red | hassio-addons | 403,586,774 | 121 | null | [
{
"action": "opened",
"author": "gibman",
"comment_id": null,
"datetime": 1548617813000,
"masked_author": "username_0",
"text": "Trying to install node red on hass.io 0.86.1 (raspberry pi) but Im stuck with this log:\r\n\r\n19-01-27 18:45:01 INFO (SyncWorker_0) [hassio.docker.interface] Pull image hassioaddons/node-red-armhf tag 1.2.5.\r\n19-01-27 18:45:16 ERROR (SyncWorker_0) [hassio.docker.interface] Can't install hassioaddons/node-red-armhf:1.2.5 -> 404 Client Error: Not Found (\"no such image: hassioaddons/node-red-armhf:1.2.5: No such image: hassioaddons/node-red-armhf:1.2.5\").\r\n\r\nany idea whats going on ?",
"title": "cant install node red on hass.io",
"type": "issue"
},
{
"action": "created",
"author": "frenck",
"comment_id": 457947245,
"datetime": 1548617859000,
"masked_author": "username_1",
"text": "404 can be 2 things:\r\n- The image does not exist\r\n- You do not have enough disk space available to complete the action.\r\n\r\nLittle hint, it is not the first one ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cnc79",
"comment_id": 464353885,
"datetime": 1550329437000,
"masked_author": "username_2",
"text": "@username_1 sorry i am a little bit of a noob :( I am getting the following error.\r\n\r\n9-02-16 14:36:25 INFO (MainThread) [hassio.homeassistant] Updated Home Assistant API token\r\n19-02-16 14:46:18 INFO (SyncWorker_17) [hassio.docker.interface] Pull image hassioaddons/node-red-armhf tag 1.3.2.\r\n19-02-16 14:46:22 ERROR (SyncWorker_17) [hassio.docker.interface] Can't install hassioaddons/node-red-armhf:1.3.2 -> 500 Server Error: Internal Server Error (\"readlink /mnt/data/docker/overlay2/l: invalid argument\"\r\n\r\nCurrently running hassio version 87.1 and HASSos 2.8\r\n\r\ndisk space command shows the following.\r\n\r\ncore-ssh:~# df -h\r\nFilesystem Size Used Available Use% Mounted on\r\noverlay 13.6G 2.3G 10.6G 18% /\r\ntmpfs 64.0M 0 64.0M 0% /dev\r\ntmpfs 463.1M 0 463.1M 0% /sys/fs/cgroup\r\n/dev/root 89.9M 89.9M 0 100% /dev/init\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /config\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /ssl\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /addons\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /backup\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /share\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /data\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /etc/resolv.conf\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /etc/hostname\r\n/dev/mmcblk0p8 13.6G 2.3G 10.6G 18% /etc/hosts\r\nshm 64.0M 0 64.0M 0% /dev/shm\r\ntmpfs 64.0M 0 64.0M 0% /proc/keys\r\ntmpfs 64.0M 0 64.0M 0% /proc/latency_stats\r\ntmpfs 64.0M 0 64.0M 0% /proc/timer_list\r\ntmpfs 64.0M 0 64.0M 0% /proc/sched_debug\r\ntmpfs 463.1M 0 463.1M 0% /sys/firmware\r\n\r\nnote that the first attempt to install nodered froze the system.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cnc79",
"comment_id": 464963935,
"datetime": 1550546139000,
"masked_author": "username_2",
"text": "Backed up, reflashed sdcard, all working again 😁",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "frenck",
"comment_id": 465620250,
"datetime": 1550675777000,
"masked_author": "username_1",
"text": "👍",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "frenck",
"comment_id": null,
"datetime": 1550675778000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 8 | 3,123 | false | true | 2,741 | true |
artsy/eigen | artsy | 596,378,607 | 3,157 | {
"number": 3157,
"repo": "eigen",
"user_login": "artsy"
} | [
{
"action": "opened",
"author": "damassi",
"comment_id": null,
"datetime": 1586332099000,
"masked_author": "username_0",
"text": "Addresses https://artsyproduct.atlassian.net/browse/CSGN-98\r\nDepends on https://github.com/artsy/metaphysics/pull/2284 \r\nRelated https://github.com/artsy/reaction/pull/3364\r\n\r\nUpdates the Consign button with new `isTargetSupply` check.",
"title": "[Consignments] Update ArtistConsignButton with targetSupply check",
"type": "issue"
}
] | 2 | 3 | 1,836 | false | true | 235 | false |
dbeaver/dbeaver | dbeaver | 686,238,326 | 9,633 | null | [
{
"action": "opened",
"author": "wiwwo",
"comment_id": null,
"datetime": 1598440887000,
"masked_author": "username_0",
"text": "Ordering rows in Datagrid (Eg. by \"ID desc\"), selecting the first rows in datagrid (meaning i select the latest/biggest N IDs Eg), and selecting \"Export data\"-> \"Export SQL Insert statement\" with following options\r\n\r\nDoes not export selected rows, but the first X rows *ordered by ID*, not in a desc way.",
"title": "Export data exports wrong rows",
"type": "issue"
},
{
"action": "created",
"author": "uslss",
"comment_id": 681012409,
"datetime": 1598462127000,
"masked_author": "username_1",
"text": "seems to be duplicate of #9252 (issue with rows is mentioned in comments)\r\nanyway, thanks for the bug report",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "uslss",
"comment_id": null,
"datetime": 1598462127000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 550 | false | false | 550 | false |
romanz/electrs | null | 678,560,080 | 293 | null | [
{
"action": "opened",
"author": "iangregsondev",
"comment_id": null,
"datetime": 1597335283000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nThis is a bit of a newbie question, I do apologise.\r\n\r\nI want to hook a wallet I am developing in dart to an electrum server and was hoping to use this implementation as its written in RUST.\r\n\r\nIt currently doesn't support websockets so how does the client (dart) receive updates to the wallet, new transactions etc.\r\n\r\nMaybe I am overlooking something, I was hoping to use something like websockets.\r\n\r\nIf anybody has some info or help - it would be gratefully appreciated\r\n\r\nThanks.",
"title": "Receiving wallet updates ?",
"type": "issue"
},
{
"action": "created",
"author": "Kixunil",
"comment_id": 673575084,
"datetime": 1597335804000,
"masked_author": "username_1",
"text": "Websocket is not implemented in `electrs` yet. See #257 \r\n\r\nIf you have experience in Rust, I think it shouldn't take you too long to add. If not, I might look at it later, but I'm not promising anything. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iangregsondev",
"comment_id": 673575754,
"datetime": 1597335877000,
"masked_author": "username_0",
"text": "Thanks @username_1 , so if there is no websocket or does a client keep up to date ? Does he poll the electrumx server every xxx minutes ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Kixunil",
"comment_id": 673578436,
"datetime": 1597336192000,
"masked_author": "username_1",
"text": "The original Electrum API allows [subscriptions](https://electrum.readthedocs.io/en/latest/protocol.html#blockchain-address-subscribe) over raw TCP socket and this is implemented in `electrs` too. If you can use raw TCP socket, you should be able to use it too. (Pretty much if it's not web browser app.)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "iangregsondev",
"comment_id": null,
"datetime": 1597336928000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "iangregsondev",
"comment_id": 673584440,
"datetime": 1597336928000,
"masked_author": "username_0",
"text": "Ah, that's great then! I can put my own websockets in front - no probs!\r\n\r\nThanks for confirming, I need to a have a bit of a read with electrum :-)",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,284 | false | false | 1,284 | true |
CodeDrMeow/github-slideshow | null | 788,042,308 | 1 | null | [
{
"action": "closed",
"author": "CodeDrMeow",
"comment_id": null,
"datetime": 1610958650000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "CodeDrMeow",
"comment_id": 762078604,
"datetime": 1610958657000,
"masked_author": "username_0",
"text": "asda",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "CodeDrMeow",
"comment_id": null,
"datetime": 1610958658000,
"masked_author": "username_0",
"text": "# :wave: Welcome to GitHub Learning Lab's \"Introduction to GitHub\"\n\nTo get started, I’ll guide you through some important first steps in coding and collaborating on GitHub.\n\n:point_down: _This arrow means you can expand the window! Click on them throughout the course to find more information._\n<details><summary>What is GitHub?</summary>\n<hr>\n\n## What is GitHub?\n\nI'm glad you asked! Many people come to GitHub because they want to contribute to open source <sup>[:book:](https://help.github.com/articles/github-glossary/#open-source)</sup> projects, or they're invited by teammates or classmates who use it for their projects. Why do people use GitHub for these projects?\n\n**At its heart, GitHub is a collaboration platform.**\n\nFrom software to legal documents, you can count on GitHub to help you do your best work with the collaboration and security tools your team needs. With GitHub, you can keep projects completely private, invite the world to collaborate, and streamline every step of your project.\n\n**GitHub is also a powerful version control tool.**\n\nGitHub uses Git <sup>[:book:](https://help.github.com/articles/github-glossary/#git)</sup>, the most popular open source version control software, to track every contribution and contributor <sup>[:book:](https://help.github.com/articles/github-glossary/#contributor)</sup> to your project--so you know exactly where every line of code came from.\n\n**GitHub helps people do much more.**\n\nGitHub is used to build some of the most advanced technologies in the world. Whether you're visualizing data or building a new game, there's a whole community and set of tools on GitHub that can get you to the next step. This course starts with the basics, but we'll dig into the rest later!\n\n:tv: [Video: What is GitHub?](https://www.youtube.com/watch?v=w3jLJU7DT5E)\n<hr>\n</details><br>\n\n<details><summary>Exploring a GitHub repository</summary>\n<hr>\n\n## Exploring a GitHub repository\n\n:tv: [Video: Exploring a repository](https://www.youtube.com/watch?v=R8OAwrcMlRw)\n\n### More features\n\nThe video covered some of the most commonly-used features. Here are a few other items you can find in GitHub repositories:\n\n- Project boards: Create Kanban-style task tracking board within GitHub\n- Wiki: Create and store relevant project documentation\n- Insights: View a drop-down menu that contains links to analytics tools for your repository including:\n - Pulse: Find information about the work that has been completed and the work that’s in-progress in this project dashboard\n - Graphs: Graphs provide a more granular view of the repository activity including who contributed to the repository, who forked it, and when they completed the work\n\n### Special Files\n\nIn the video you learned about a special file called the README.md. Here are a few other special files you can add to your repositories:\n\n- CONTRIBUTING.md: The `CONTRIBUTING.md` is used to describe the process for contributing to the repository. A link to the `CONTRIBUTING.md` file is shown anytime someone creates a new issue or pull request.\n- ISSUE_TEMPLATE.md: The `ISSUE_TEMPLATE.md` is another file you can use to pre-populate the body of an issue. For example, if you always need the same types of information for bug reports, include it in the issue template, and every new issue will be opened with your recommended starter text.\n\n<hr>\n</details>\n\n### Using issues\n\nThis is an issue <sup>[:book:](https://help.github.com/articles/github-glossary/#issue)</sup>: a place where you can have conversations about bugs in your code, code review, and just about anything else.\n\nIssue titles are like email subject lines. They tell your collaborators what the issue is about at a glance. For example, the title of this issue is Getting Started with GitHub.\n\n\n<details><summary>Using GitHub Issues</summary>\n\n## Using GitHub issues\n\nIssues are used to discuss ideas, enhancements, tasks, and bugs. They make collaboration easier by:\n\n- Providing everyone (even future team members) with the complete story in one place\n- Allowing you to cross-link to other issues and pull requests <sup>[:book:](https://help.github.com/articles/github-glossary/#pull-request)</sup>\n- Creating a single, comprehensive record of how and why you made certain decisions\n- Allowing you to easily pull the right people and teams into a conversation with @-mentions\n\n:tv: [Video: Using issues](https://www.youtube.com/watch?v=Zhj46r5D0nQ)\n\n<hr>\n</details>\n\n<details><summary>Managing notifications</summary>\n<hr>\n\n## Managing notifications\n\n:tv: [Video: Watching, notifications, stars, and explore](https://www.youtube.com/watch?v=ocQldxF7fMY)\n\nOnce you've commented on an issue or pull request, you'll start receiving email notifications when there's activity in the thread. \n\n### How to silence or unmute specific conversations\n\n1. Go to the issue or pull request\n2. Under _\"Notifications\"_, click the **Unsubscribe** button on the right to silence notifications or **Subscribe** to unmute them\n\nYou'll see a short description that explains your current notification status.\n\n### How to customize notifications in Settings\n\n1. Click your profile icon\n2. Click **Settings**\n3. Click **Notifications** from the menu on the left and [adjust your notification preferences](https://help.github.com/articles/managing-notification-delivery-methods/)\n\n### Repository notification options\n\n* **Watch**: You'll receive a notification when a new issue, pull request or comment is posted, and when an issue is closed or a pull request is merged \n* **Not watching**: You'll no longer receive notifications unless you're @-mentioned\n* **Ignore**: You'll no longer receive any notifications from the repository\n\n### How to review notifications for the repositories you're watching\n\n1. Click your profile icon\n2. Click **Settings**\n3. Click **Notification** from the menu on the left\n4. Click on the [things you’re watching](https://github.com/watching) link\n5. Select the **Watching** tab\n6. Click the **Unwatch** button to disable notifications, or **Watch** to enable them\n\n<hr>\n</details>\n\n<hr>\n<h3 align=\"center\">Keep reading below to find your first task</h3>",
"title": "Getting Started with GitHub",
"type": "issue"
},
{
"action": "closed",
"author": "CodeDrMeow",
"comment_id": null,
"datetime": 1610958661000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "CodeDrMeow",
"comment_id": 762078645,
"datetime": 1610958661000,
"masked_author": "username_0",
"text": "asdasd",
"title": null,
"type": "comment"
}
] | 2 | 10 | 18,907 | false | true | 6,149 | false |
euske/pdfminer | null | 756,270,859 | 300 | null | [
{
"action": "opened",
"author": "mal-mel",
"comment_id": null,
"datetime": 1607007536000,
"masked_author": "username_0",
"text": "In my logs, I often see messages that some of the characters are not recognized. I would like to disable these messages.\r\nI tried to do it through:\r\n`logging.getLogger(pdfminer.__name__).setLevel(logging.WARNING)`\r\nBut this does not help :(",
"title": "It is possible to off logging from pdfminer?",
"type": "issue"
}
] | 1 | 1 | 240 | false | false | 240 | false |
YummyLau/Anchors | null | 613,778,904 | 16 | null | [
{
"action": "opened",
"author": "Dwan-xie",
"comment_id": null,
"datetime": 1588828655000,
"masked_author": "username_0",
"text": "Task启动时是否可以不依赖project或者不依赖TaskFactory",
"title": "Task启动时是否可以不依赖project或者不依赖TaskFactory",
"type": "issue"
},
{
"action": "created",
"author": "YummyLau",
"comment_id": 625041293,
"datetime": 1588830249000,
"masked_author": "username_1",
"text": "@username_0 Task可以独立。依赖TaskFactory只是构建project方便而已，project也是一个task",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Dwan-xie",
"comment_id": null,
"datetime": 1588837927000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Dwan-xie",
"comment_id": 625092276,
"datetime": 1588837927000,
"masked_author": "username_0",
"text": "我试了task直接dependOn，可以正常执行后学task。",
"title": null,
"type": "comment"
}
] | 2 | 4 | 132 | false | false | 132 | true |
bytesparadise/libasciidoc | bytesparadise | 641,789,229 | 624 | {
"number": 624,
"repo": "libasciidoc",
"user_login": "bytesparadise"
} | [
{
"action": "opened",
"author": "gdamore",
"comment_id": null,
"datetime": 1592553988000,
"masked_author": "username_0",
"text": "Quoted texts (such as bold) should span newlines, but should\r\nnot be permitted to span paragraphs or blocks. This fixes\r\nall of them, and includes parser and renderer validation.\r\n\r\nFixes #623",
"title": "fix(parser): quoted text newline handling",
"type": "issue"
},
{
"action": "created",
"author": "gdamore",
"comment_id": 646505116,
"datetime": 1592554448000,
"masked_author": "username_0",
"text": "I did not copy and modify the rendering tests for HTML to XHTML in this case. I don't think they add any useful extra value in the XHTML tree, since the parse tree is already validated, and these formats are not different between HTML and XHTML.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 890 | false | true | 439 | false |
trailofbits/ebpfpub | trailofbits | 765,914,985 | 389 | null | [
{
"action": "opened",
"author": "17071040292",
"comment_id": null,
"datetime": 1607923314000,
"masked_author": "username_0",
"text": "马鞍山雨山区哪有特殊服务的洗浴【＋V:７８１３７２５２４】 在今天，有越来越多的人通过镜头记录着自己的日常生活。抖音为网友们提供了这样一个平台，让更多朋友在记录与分享的同时收获多一份欢乐，多一份温暖。最近，名为“麻辣锅包肉”的网友就在抖音上红了，获赞近九百万的他用充满温暖的视频感染着许许多多的网友。 一个重庆妹和一个东北哥组成了一个有爱的家庭，由此就诞生了“麻辣锅包肉”这个“组合”。热爱生活、“浑身是戏”的夫妻俩希望用镜头记录下他们充满乐趣的生活，于是就通过抖音和大家分享一些日常发生的趣事和温暖瞬间。 比如，短视频记录了他们东北话和重庆话之间碰撞出的奇妙火花，身为东北人的“锅包肉”每次纠正妻子的东北方言，总会被重庆话的口音带偏。还有许多婚姻生活中的细小片段，无论琐碎或温馨，都真实地反映着许多人生活中的每一幕相似场景。在柴米油盐的气息中，他们之间的美好感情也令网友们十分羡慕。 而这个有爱的小家庭，在加入一位新的成员后变得更加完整。夫妻二人的生活中多了一个需要照顾的小家伙，这也让他们的日子充满了快乐。他们的视频记录了和孩子一同成长过程中的点点滴滴，虽然刚刚成为新手爸妈，还对很多事情都不熟悉，但摸索的阶段也让他们乐在其中。 在一个视频中，“锅包肉”拍摄了爸爸带孩子的日常，父子二人之间滑稽的相处模式让网友们捧腹大笑。而照顾孩子也无疑是辛苦的，熬夜更是家常便饭。于是，把孩子哄睡之后的深夜变成了他的自由时刻，无论白天多么辛苦，夜晚用美食犒劳自己一顿就能够心满意足。这是发生在无数个新手父母身上的故事，被他们用幽默的形式表达出来后，网友们纷纷对这样的“遭遇”表示既同情又好笑。 家庭永远是我们每个人最温暖的港湾，其中有欢笑、愤怒、悲伤的故事在上演。而这有爱的一家人将他们的生活小片段与大家分享，在记录的同时也感动了很多人，让每个人都有机会看到家庭生活的美好与幸福。 对于“麻辣锅包肉“夫妻二人来说，生活虽然是柴米油盐的主旋律，但平凡之中处处充满着惊喜与乐趣，他们也珍惜每一个无论欢乐或是悲伤的瞬间，更想继续用镜头记录一家人的故事。他们身上传递出的正能量和积极乐观的生活态度，也在感染着更多人，助力他们发现美好、创造属于自己的幸福生活。 声明：中华娱乐网刊载此文出于传递更多信息之目的，并非意味着赞同其观点或证实其描述。版权归作者所有，更多同类文章敬请浏览：综合资讯堑糯中孤掷https://github.com/trailofbits/ebpfpub/issues/210?6ywyA <br />https://github.com/trailofbits/ebpfpub/issues/371 <br />https://github.com/trailofbits/ebpfpub/issues/58?mK48d <br />https://github.com/trailofbits/ebpfpub/issues/293?6qYMa <br />https://github.com/trailofbits/ebpfpub/issues/205?kicyg <br />https://github.com/trailofbits/ebpfpub/issues/117?fhldl <br />https://github.com/trailofbits/ebpfpub/issues/352?yyvbc <br />mredgqcflngihlashwquclseesoexwicchn",
"title": "马鞍山雨山区妹子真实找上门服务y",
"type": "issue"
}
] | 1 | 1 | 1,466 | false | false | 1,466 | false |
mafintosh/hyperbee | null | 692,144,410 | 6 | null | [
{
"action": "opened",
"author": "martinheidegger",
"comment_id": null,
"datetime": 1599153590000,
"masked_author": "username_0",
"text": "Is there a way for hyperbee to be closed?",
"title": "Closing a hyperbee?",
"type": "issue"
},
{
"action": "created",
"author": "mafintosh",
"comment_id": 686757528,
"datetime": 1599166163000,
"masked_author": "username_1",
"text": "Just close the feed you pass in",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RangerMauve",
"comment_id": 686812811,
"datetime": 1599175338000,
"masked_author": "username_2",
"text": "Would a PR adding `.close` be welcome?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "martinheidegger",
"comment_id": 686814642,
"datetime": 1599175696000,
"masked_author": "username_0",
"text": "Let me ask differently: is there a chance I break existing things if I close the hypercore at an inconvenient time?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mafintosh",
"comment_id": 687070024,
"datetime": 1599216241000,
"masked_author": "username_1",
"text": "No should be safe.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "martinheidegger",
"comment_id": null,
"datetime": 1608122917000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 243 | false | false | 243 | false |
kokkonisd/baiopsy | null | 615,777,276 | 1 | null | [
{
"action": "opened",
"author": "kokkonisd",
"comment_id": null,
"datetime": 1589193150000,
"masked_author": "username_0",
"text": "Currently the depth is not calculated via trigonometric functions and we are instead producing orthographic views. Draw depth such as the length of its sides are exactly equal to the depth passed in as an argument, to save a bit of vertical space.",
"title": "Draw depth non-orthographically",
"type": "issue"
},
{
"action": "created",
"author": "kokkonisd",
"comment_id": 626855212,
"datetime": 1589219466000,
"masked_author": "username_0",
"text": "Commit 84d7329 implements this.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kokkonisd",
"comment_id": null,
"datetime": 1589219467000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 278 | false | false | 278 | false |
m-lab/k8s-support | m-lab | 784,567,407 | 535 | null | [
{
"action": "opened",
"author": "nkinkade",
"comment_id": null,
"datetime": 1610483106000,
"masked_author": "username_0",
"text": "Just recently I have noticed in sandbox and staging that the first API server in each cluster, after being rebooted, fails to rejoin the API cluster. The error from the kubelet is that it is getting a connection refused from the API load-balancer URL. Wondering if this could be some sort of a hairpin issue in the loadbalancer, I removed the `us-central1-a` (the one failing to rejoin) from the load balancer, and almost immediately it rejoined.\r\n\r\nWhat we have is a situation where backends of the load-balancer are attempting to communicate with the load-balancer itself, a sort of self-referential problem. It would that the when a backend attempts to communicate with the load-balancer of which it is a part, that the traffic is sent back to that same backend/node. This doesn't work because the kubelet needs to communicate with the API cluster _and_ is also responsible for starting up the api-server pod.\r\n\r\nWe are currently using a \"legacy\" TCP/UDP target-pool-based external load balancer. Among other things, this type of backend only supports HTTP health checks, which necessitates the use of the `gcp-loadbalancer-proxy`. Perhaps these issues might go away if we move to the more modern \"backend service\" type of external load-balancer? It seems worth the trouble, if for nothing else than to get rid of the `gcp-loadbalancer-proxy` and let GCP health checks talk directly to the nodes in the backend instance group using HTTPS.",
"title": "API nodes sometimes fail to rejoin the API cluster",
"type": "issue"
},
{
"action": "closed",
"author": "nkinkade",
"comment_id": null,
"datetime": 1610731535000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 1,441 | false | false | 1,441 | false |
Pradeep-CV/github-slideshow | null | 669,631,610 | 3 | {
"number": 3,
"repo": "github-slideshow",
"user_login": "Pradeep-CV"
} | [
{
"action": "opened",
"author": "Pradeep-CV",
"comment_id": null,
"datetime": 1596188882000,
"masked_author": "username_0",
"text": "**Added some contents\r\nLearned lots of things**",
"title": "Add Pradeep-CV's file",
"type": "issue"
}
] | 2 | 2 | 1,815 | false | true | 47 | false |
strongloop/loopback-next | strongloop | 697,155,084 | 6,314 | {
"number": 6314,
"repo": "loopback-next",
"user_login": "strongloop"
} | [
{
"action": "opened",
"author": "raymondfeng",
"comment_id": null,
"datetime": 1599685255000,
"masked_author": "username_0",
"text": "This PR renames the following packages to be consistent with other extension modules.\r\n\r\n- @loopback/extension-health => @loopback/health\r\n- @loopback/extension-logging => @loopback/logging\r\n- @loopback/extension-metrics => @loopback/metrics\r\n\r\n## Checklist\r\n\r\n- [x] DCO (Developer Certificate of Origin) [signed in all commits](https://loopback.io/doc/en/contrib/code-contrib.html)\r\n- [x] `npm test` passes on your machine\r\n- [ ] New tests added or existing tests modified to cover all changes\r\n- [x] Code conforms with the [style guide](http://loopback.io/doc/en/contrib/style-guide.html)\r\n- [ ] API Documentation in code was updated\r\n- [x] Documentation in [/docs/site](../tree/master/docs/site) was updated\r\n- [x] Affected artifact templates in `packages/cli` were updated\r\n- [x] Affected example projects in `examples/*` were updated\r\n\r\n👉 [Check out how to submit a PR](https://loopback.io/doc/en/lb4/submitting_a_pr.html) 👈",
"title": "refactor: rename `@loopback/extension-*` packages",
"type": "issue"
},
{
"action": "created",
"author": "bajtos",
"comment_id": 690313447,
"datetime": 1599746838000,
"masked_author": "username_1",
"text": "+1 to rename extensions for consistency.\r\n\r\nHow are users of the existing packages going to learn about the new name? Have you considered deprecating the old packages with a message pointing users to the new name? Example:\r\n\r\nhttps://www.npmjs.com/package/shot\r\n\r\nIn the past, we published a new version of the old package with a short readme pointing users to the new one, see https://www.npmjs.com/package/loopback-explorer",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raymondfeng",
"comment_id": 690357301,
"datetime": 1599750813000,
"masked_author": "username_0",
"text": "@username_1 Here is my plan.\r\n\r\n1. We'll publish a new release to include the renamed packages \r\n2. We'll add `deprecation` messages to existing `@loopback/extension-*` npm packages using `npm deprecate` to remind our users to upgrade.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,585 | false | false | 1,585 | true |
mashabow/slack-rota | null | 673,716,186 | 3 | null | [
{
"action": "opened",
"author": "mashabow",
"comment_id": null,
"datetime": 1596648044000,
"masked_author": "username_0",
"text": "いまは全員にメンションが飛ぶようになっている。",
"title": "担当者以外にはメンションを飛ばさないオプション",
"type": "issue"
},
{
"action": "created",
"author": "mashabow",
"comment_id": 669914555,
"datetime": 1596719153000,
"masked_author": "username_0",
"text": "Slack API を叩いて `user_id` からユーザー名を取得する必要がありそう",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mashabow",
"comment_id": 674138513,
"datetime": 1597420093000,
"masked_author": "username_0",
"text": "- [メンション飛ばさずに @username をメッセージに含めたい](https://qiita.com/munky69rock/items/3342c7b7c642fd2c68f3#%E3%83%A1%E3%83%B3%E3%82%B7%E3%83%A7%E3%83%B3%E9%A3%9B%E3%81%B0%E3%81%95%E3%81%9A%E3%81%AB-username-%E3%82%92%E3%83%A1%E3%83%83%E3%82%BB%E3%83%BC%E3%82%B8%E3%81%AB%E5%90%AB%E3%82%81%E3%81%9F%E3%81%84)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mashabow",
"comment_id": 677678616,
"datetime": 1597931672000,
"masked_author": "username_0",
"text": "`users.list` を使えば、1回のリクエストで全ユーザーのデータが一気に取得できる。\r\n\r\n- [users.list method | Slack](https://api.slack.com/methods/users.list)\r\n\r\n権限としては `users:read` が必要。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mashabow",
"comment_id": null,
"datetime": 1597939112000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 5 | 510 | false | false | 510 | false |
tobymao/18xx | null | 670,194,555 | 1,291 | null | [
{
"action": "opened",
"author": "perwestling",
"comment_id": null,
"datetime": 1596227263000,
"masked_author": "username_0",
"text": "18AL has 5 swamp hexes which currently is rendered as water hexes. \r\n\r\nI have tried to just do upgrade=cost and not specify any terrain, and then add a swamp icon (from 18xx-makers) but it does not look very good.\r\n\r\nWould it be possible to render a swamp hex by specifying terrain=swamp?\r\n\r\nLooking ahead to 18MEX I can also see a couple of more terrain types:\r\n- Double mountain (cost 120, instead of 60 for the single ones)\r\n- Cactus (cost 20)\r\n- And also Swamp",
"title": "18AL Swamp terrain",
"type": "issue"
},
{
"action": "created",
"author": "perwestling",
"comment_id": 667342956,
"datetime": 1596227322000,
"masked_author": "username_0",
"text": "Here is how the swamp icon looks like on the 18AL map:\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "perwestling",
"comment_id": 667343818,
"datetime": 1596227452000,
"masked_author": "username_0",
"text": "The tree on the N2 tile is just to separate it more from the standard gentle town hex. It is the special Lumber Terminal tile that is placed via the BLC company ability. \r\n\r\nThe two 18MEX is not urgent, and there are more issues with 18MEX tiles.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "perwestling",
"comment_id": 673407995,
"datetime": 1597316026000,
"masked_author": "username_0",
"text": "For 18AL the work around was to add a swamp icon and use water terrain. \r\n\r\nThis issue is now a request to add more terrain types to 18xx.games.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tobymao",
"comment_id": null,
"datetime": 1598373516000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 1,050 | false | false | 1,050 | false |
spring-cloud/spring-cloud-stream-binder-kafka | spring-cloud | 647,256,017 | 925 | null | [
{
"action": "opened",
"author": "tkaszuba",
"comment_id": null,
"datetime": 1593425471000,
"masked_author": "username_0",
"text": "In the `KeyValueSerdeResolver` class the following code exists:\r\n\r\n`if (serdeGenericRawClazz.isAssignableFrom(genericRawClazz)) {\r\n serdeBeans[0] = v;\r\n}`\r\n\r\nwhich means that if a bean is defined in a configuration class that is assignable to the Specific Avro Key class it will override the default Serdes class defined in the app.properties: \r\n\r\n`spring.cloud.stream.kafka.streams.binder.configuration.default.key.serde=io.confluent.kafka.streams.serdes.avro.SpecificAvroSerde`\r\n\r\nRecently we had the following defined value Serde in a config class. Instead of taking the default key serde this bean was taken, which resulted in many hours of debugging to find out why.\r\n\r\n`@Bean\r\npublic Serde<SpecificRecordBase> serde() {\r\n return Serdes.avroValueSerde(url);\r\n}`\r\n\r\nIn the document section: https://cloud.spring.io/spring-cloud-stream-binder-kafka/spring-cloud-stream-binder-kafka.html#_outbound_serialization\r\n\r\nI would add a warning about defining assignable beans in the configuration and how those will be taken instead of the default ones defined in the config file.",
"title": "Missing documentation on KeyValueSerdeResolver functionality",
"type": "issue"
},
{
"action": "created",
"author": "sobychacko",
"comment_id": 651267944,
"datetime": 1593452948000,
"masked_author": "username_1",
"text": "@username_0 That link you provided above is from an older release. Did you get there through some bookmarks?\r\n\r\nHere are the latest [docs](https://cloud.spring.io/spring-cloud-static/spring-cloud-stream-binder-kafka/3.0.6.RELEASE/reference/html/spring-cloud-stream-binder-kafka.html#_record_serialization_and_deserialization) on serialization.\r\n\r\nYou can navigate to it through the main project page: https://spring.io/projects/spring-cloud-stream#learn\r\n\r\nThe updates about the `Serde` beans are detailed there. Can you see if that is sufficient for your needs?\r\nIf so, let us know and we can polish it further (or you can send a PR). \r\n\r\nThanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tkaszuba",
"comment_id": null,
"datetime": 1593454459000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tkaszuba",
"comment_id": 651279697,
"datetime": 1593454459000,
"masked_author": "username_0",
"text": "Yes, you are right. The documentation in this version seems much better and explains this overloading concept better. The previous doc I got from google. I didn't notice that it was for the previous version. I will close this issue.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,956 | false | false | 1,956 | true |
wso2/product-ei | wso2 | 714,779,315 | 5,279 | null | [
{
"action": "opened",
"author": "arunans23",
"comment_id": null,
"datetime": 1601899429000,
"masked_author": "username_0",
"text": "**Description:**\r\n<!-- Give a brief description of the issue -->\r\n\r\nPayloadFactory mediator performance has significantly reduced in EI 6.6.0. You can try out by calling the following sequence.\r\n\r\n```\r\n<sequence name=\"payload-factory-seq\" trace=\"disable\" xmlns=\"http://ws.apache.org/ns/synapse\">\r\n <property description=\"Set PAYLOAD_FACTORY_TEST_PARAMETER1\" expression=\"json-eval($.PARAMETER1)\" name=\"PAYLOAD_FACTORY_TEST_PARAMETER1\" scope=\"default\" type=\"STRING\"/>\r\n <property description=\"Set PAYLOAD_FACTORY_TEST_PARAMETER2\" expression=\"json-eval($.PARAMETER2)\" name=\"PAYLOAD_FACTORY_TEST_PARAMETER2\" scope=\"default\" type=\"STRING\"/>\r\n <property description=\"Set PAYLOAD_FACTORY_TEST_PARAMETER3\" expression=\"json-eval($.PARAMETER3)\" name=\"PAYLOAD_FACTORY_TEST_PARAMETER3\" scope=\"default\" type=\"STRING\"/>\r\n <payloadFactory media-type=\"xml\">\r\n <format>\r\n <TECHNICAL_PARAMETERS xmlns=\"\">\r\n <PARAMETER1>$1</PARAMETER1>\r\n <PARAMETER2>$2</PARAMETER2>\r\n <PARAMETER3>$3</PARAMETER3>\r\n </TECHNICAL_PARAMETERS>\r\n </format>\r\n <args>\r\n <arg evaluator=\"xml\" expression=\"$ctx:PAYLOAD_FACTORY_TEST_PARAMETER1\" xmlns:ns=\"http://org.apache.synapse/xsd\"/>\r\n <arg evaluator=\"xml\" expression=\"$ctx:PAYLOAD_FACTORY_TEST_PARAMETER2\" xmlns:ns=\"http://org.apache.synapse/xsd\"/>\r\n <arg evaluator=\"xml\" expression=\"$ctx:PAYLOAD_FACTORY_TEST_PARAMETER3\" xmlns:ns=\"http://org.apache.synapse/xsd\"/>\r\n </args>\r\n </payloadFactory>\r\n</sequence>\r\n\r\n```\r\n\r\nThis is due to the increase in time when initiating a [DocumentBuilder](https://github.com/wso2/wso2-synapse/blob/v2.1.7-wso2v143/modules/core/src/main/java/org/apache/synapse/mediators/transform/PayloadFactoryMediator.java#L683).\r\n\r\n**Suggested Labels:**\r\n<!-- Optional comma separated list of suggested labels. Non committers can’t assign labels to issues, so this will help issue creators who are not a committer to suggest possible labels-->\r\n\r\n**Suggested Assignees:**\r\n<!--Optional comma separated list of suggested team members who should attend the issue. Non committers can’t assign issues to assignees, so this will help issue creators who are not a committer to suggest possible assignees-->\r\n\r\n**Affected Product Version:**\r\n\r\n**OS, DB, other environment details and versions:** \r\n\r\n**Steps to reproduce:**\r\n\r\n\r\n**Related Issues:**\r\n<!-- Any related issues such as sub tasks, issues reported in other repositories (e.g component repositories), similar problems, etc. -->",
"title": "PayloadFactory mediator performance degraded",
"type": "issue"
}
] | 1 | 1 | 2,553 | false | false | 2,553 | false |
mdn/browser-compat-data | mdn | 679,296,656 | 6,518 | null | [
{
"action": "opened",
"author": "Roger-Melo",
"comment_id": null,
"datetime": 1597425880000,
"masked_author": "username_0",
"text": "Hi!\r\n\r\n.scrollTo() isn't supported in Google Chrome. Maybe the compatibility should be changed?",
"title": ".scrollTo() isn't supported on Chrome",
"type": "issue"
},
{
"action": "created",
"author": "ddbeck",
"comment_id": 676561155,
"datetime": 1597858232000,
"masked_author": "username_1",
"text": "Thanks for opening this issue. I'd welcome a PR fixing this!\r\n\r\nThe data in question would be need to be updated in [`/api/ScrollToOptions.json`](https://github.com/mdn/browser-compat-data/blob/52fb1728cbda3a152420839c3a2173c073355767/api/ScrollToOptions.json#L50). It would probably need a note, like Safari. To actually merge such a change, we'd also need some sort of test or reference showing that the feature is unsupported.\r\n\r\nThank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpmedley",
"comment_id": 683933276,
"datetime": 1598896475000,
"masked_author": "username_2",
"text": "Chromium forks should inherit `smooth` from [ScrollOptions](https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/frame/scroll_options.idl). What version of Chrome are you using? Can we see your code?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "queengooborg",
"comment_id": 1000515160,
"datetime": 1640292065000,
"masked_author": "username_3",
"text": "I'm closing this because there has been no response for over a year and the `smooth` behavior appears to function as expected.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "queengooborg",
"comment_id": null,
"datetime": 1640292065000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 901 | false | false | 901 | false |
ssproessig/ipc-adapter | null | 502,950,026 | 42 | null | [
{
"action": "opened",
"author": "ssproessig",
"comment_id": null,
"datetime": 1570273783000,
"masked_author": "username_0",
"text": "## Current Situation\r\n- currently components are structured by their component-type (Converters, Sinks, Sources)\r\n- this may lead to duplicate code, if Sinks/Sources share code (shared configuration parsers)\r\n\r\n## Expected Situation\r\n- group components in logical packages\r\n-- `UdpSink` and `UdpSource` go to `NetworkComponents`\r\n-- `AmqpExchangeSink` goes to `AmqpComponents`\r\n\r\n## Dependencies\r\nThis is a prerequisite to add further AMQP components.",
"title": "Components: restructure components by usage, not component type",
"type": "issue"
},
{
"action": "closed",
"author": "ssproessig",
"comment_id": null,
"datetime": 1570277572000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 451 | false | false | 451 | false |
MontFerret/ferret | MontFerret | 624,887,383 | 519 | null | [
{
"action": "opened",
"author": "Hedgehogues",
"comment_id": null,
"datetime": 1590499998000,
"masked_author": "username_0",
"text": "Is there python dsl language like ferret?",
"title": "DSL for different languages",
"type": "issue"
},
{
"action": "created",
"author": "ziflex",
"comment_id": 634035893,
"datetime": 1590500859000,
"masked_author": "username_1",
"text": "Maybe? I do not know. \r\nSyntax and grammar definitions are out there for parser generation, so if anyone want to implement the runtime, they are very welcome :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Hedgehogues",
"comment_id": 634064455,
"datetime": 1590503676000,
"masked_author": "username_0",
"text": "This is a very long way. I want to do it by one-two-three week.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ziflex",
"comment_id": 634085752,
"datetime": 1590505741000,
"masked_author": "username_1",
"text": "It really depends on your use case.\r\nYou can try to use [this tool](https://github.com/go-python/gopy) to generate CPython extension off the Ferret runtime. But it's a hardcore way.\r\nMaybe a simple dedicated HTTP service would be enough? If so, you can use [this project](https://github.com/MontFerret/worker) for that.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Hedgehogues",
"comment_id": null,
"datetime": 1590514450000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "Hedgehogues",
"comment_id": null,
"datetime": 1590514537000,
"masked_author": "username_0",
"text": "Is there python dsl language like ferret?",
"title": "DSL for different languages",
"type": "issue"
},
{
"action": "created",
"author": "Hedgehogues",
"comment_id": 634169840,
"datetime": 1590514537000,
"masked_author": "username_0",
"text": "What about swagger for thi",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Hedgehogues",
"comment_id": 634177269,
"datetime": 1590515400000,
"masked_author": "username_0",
"text": "- What about swagger into service?\r\n- Transform from golang to python is a problem. I will have a trouble with `struct`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ziflex",
"comment_id": 634183140,
"datetime": 1590516066000,
"masked_author": "username_1",
"text": "The service has just 3 simple endpoints (2 of them are mostly informative).\r\nIndex route (``/``) expects a POST request with the following shape a of a payload:\r\n```\r\n{\r\n text: string\r\n params?: map<string, any>\r\n}\r\n```\r\n\r\nBut you are right, I need to document that service better :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Hedgehogues",
"comment_id": null,
"datetime": 1590529361000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 10 | 1,067 | false | false | 1,067 | false |
giraffe-fsharp/Giraffe.ViewEngine | giraffe-fsharp | 812,140,573 | 13 | null | [
{
"action": "opened",
"author": "devcrafting",
"comment_id": null,
"datetime": 1613750459000,
"masked_author": "username_0",
"text": "I am converting a HTML hard coded website to Giraffe (for layout, data templating...). It is quite boring to transform HTML to function-style view. I thought a tool could help, an XSLT stylesheet would do the job, any ideas about that ? existing tool in other equiv framework ?",
"title": "Is there a HTML to function-style view tool ?",
"type": "issue"
},
{
"action": "created",
"author": "devcrafting",
"comment_id": 782173090,
"datetime": 1613750951000,
"masked_author": "username_0",
"text": "In fact event better, something like https://mbylstra.github.io/html-to-elm/ ;) (or https://marketplace.visualstudio.com/items?itemName=Rubymaniac.vscode-html-to-elm)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dustinmoris",
"comment_id": 787468730,
"datetime": 1614525570000,
"masked_author": "username_1",
"text": "I don't know of such a tool but if you do find something please let me know as it would be nice to link it in the repo!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "devcrafting",
"comment_id": 787507318,
"datetime": 1614540202000,
"masked_author": "username_0",
"text": "I started a fork of html-to-elm https://github.com/username_0/html-to-giraffeview\r\nA bit of effort to upgrade to last ELM, and very few modifications to adapt to GiraffeView (very close to ELM view). Far from perfect but working. For example I had to disable all tests, still work to be done to propose a merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dustinmoris",
"comment_id": 787521707,
"datetime": 1614545835000,
"masked_author": "username_1",
"text": "Nice!",
"title": null,
"type": "comment"
}
] | 2 | 5 | 878 | false | false | 878 | true |
moejoe/hilfswerk | null | 595,914,130 | 70 | null | [
{
"action": "opened",
"author": "heckmueller",
"comment_id": null,
"datetime": 1586269929000,
"masked_author": "username_0",
"text": "Ich vermute das das Feld ein Integer ist, und wir das Problem ev. lösen können indem wir einfach Kommazahlen zulassen.",
"title": "Zentrums-Mitarbeiter:innen wollen Einsätze protokollieren deren Länge 1,5h ist",
"type": "issue"
},
{
"action": "created",
"author": "heckmueller",
"comment_id": 611108404,
"datetime": 1586369242000,
"masked_author": "username_0",
"text": "Zeit als Minuten eintragen",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "moejoe",
"comment_id": 612885457,
"datetime": 1586782323000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "moejoe",
"comment_id": null,
"datetime": 1586799893000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 253 | false | false | 253 | false |
conan-io/docs | conan-io | 756,673,611 | 1,952 | {
"number": 1952,
"repo": "docs",
"user_login": "conan-io"
} | [
{
"action": "opened",
"author": "memsharded",
"comment_id": null,
"datetime": 1607038363000,
"masked_author": "username_0",
"text": "Docs for: https://github.com/conan-io/conan/pull/8014",
"title": "conan.tools.microsoft docs",
"type": "issue"
},
{
"action": "created",
"author": "czoido",
"comment_id": 738736027,
"datetime": 1607081751000,
"masked_author": "username_1",
"text": "I think we should point this one to the release/1.32.0 branch so that after the 1.33 is launched we don't lose this in the docs generated for 1.32",
"title": null,
"type": "comment"
}
] | 2 | 2 | 199 | false | false | 199 | false |
CSS-Tricks/conferences | CSS-Tricks | 413,858,603 | 74 | {
"number": 74,
"repo": "conferences",
"user_login": "CSS-Tricks"
} | [
{
"action": "opened",
"author": "joemaddalone",
"comment_id": null,
"datetime": 1551036817000,
"masked_author": "username_0",
"text": "This PR adds React Loop 2019. While we have adopted the conference code of conduct we have added language on our site that clearly establishes how to contact us with concerns or questions. We've also included actionable steps for conference participants to take if they identify a situation where the CoC is not being followed. https://reactloop.com/conduct",
"title": "add React Loop 2019",
"type": "issue"
},
{
"action": "created",
"author": "chriscoyier",
"comment_id": 468311000,
"datetime": 1551367017000,
"masked_author": "username_1",
"text": "🎉",
"title": null,
"type": "comment"
}
] | 2 | 2 | 361 | false | false | 361 | false |
PDXFinder/pdxfinder | PDXFinder | 667,838,014 | 232 | null | [
{
"action": "opened",
"author": "zperova",
"comment_id": null,
"datetime": 1596028663000,
"masked_author": "username_0",
"text": "### Description:\r\n\r\nAs a user, I want to filter models by the strain.\r\n\r\nJira ticket [PDXI-251](https://www.ebi.ac.uk/panda/jira/browse/PDXI-251)\r\n\r\n### Acceptance criteria:\r\n\r\n- [ ] harmonize strain values (this is what Steve is working on atm) [affect the loaders, after it is done, a database reload is required]\r\n- [ ] add strain to the searchService [backend] \r\n- [ ] add strain to the filters on search page [frontend]",
"title": "Add strain facet",
"type": "issue"
}
] | 1 | 1 | 424 | false | false | 424 | false |
facebook/docusaurus | facebook | 807,573,670 | 4,221 | null | [
{
"action": "opened",
"author": "csestito",
"comment_id": null,
"datetime": 1613167164000,
"masked_author": "username_0",
"text": "<!--\r\n\r\n ! PLEASE HELP US HELP YOU !\r\n\r\n Bugs are fixed faster if you include:\r\n - a repro repository to inspect the code\r\n - an url to see the problem live (if possible)\r\n\r\n Pro tip: create a reproducible demo of the bug with https://new.docusaurus.io\r\n\r\n-->\r\n\r\n## 🐛 Bug Report\r\n\r\nThe search parameters e.g. facets passed into searchParameters are used for the SearchBar, but don't carry over to the DocSearchPage. \r\n\r\n### Have you read the [Contributing Guidelines on issues](https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md#reporting-new-issues)?\r\n\r\nYes \r\n\r\n## To Reproduce\r\n\r\nIf possible, use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.\r\n\r\n1. Add a facet to searchParameters to algolia in docusaurus config'\r\n2. Search in Search Bar\r\n3. Click view all\r\n4. See filter is not run on the search page\r\n5. \r\n## Expected behavior\r\n\r\n<!--\r\n How did you expect your project to behave?\r\n It’s fine if you’re not sure your understanding is correct.\r\n Write down what you thought would happen.\r\n-->\r\n\r\nany searchParameters specified in the config would carry over to the DocSearchPage \r\n\r\n## Actual Behavior\r\n\r\n<!--\r\n Did something go wrong?\r\n Is something broken, or not behaving as you expected?\r\n Describe this section in detail, and attach screenshots if possible.\r\n Don't only say \"it doesn't work\"!\r\n-->\r\n\r\nNo searchParameters were used on the DocSearchPage\r\n\r\n## Your Environment\r\n\r\n<!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Public source code/URL https://codesandbox.io/s/magical-mclaren-byg9e?file=/docusaurus.config.js\r\n- Docusaurus version used: 70\r\n\r\n## Reproducible Demo\r\n\r\nIf possible, use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.\r\n\r\nhttps://codesandbox.io/s/magical-mclaren-byg9e?file=/docusaurus.config.js\r\n\r\n<!--\r\n What happens if you skip this step?\r\n\r\n Someone will read your bug report, and maybe will be able to help you,\r\n but it’s unlikely that it will get much attention from the team. Eventually,\r\n the issue will likely get closed in favor of issues that have reproducible demos.\r\n\r\n Please remember that:\r\n\r\n * Issues without reproducible demos have a very low priority.\r\n * The person fixing the bug would have to do that anyway. Please be respectful of their time.\r\n * You might figure out the issues yourself as you work on extracting it.\r\n\r\n Thanks for helping us help you!\r\n-->",
"title": "Algolia DocSearchPage doesn't inherit searchParameters ",
"type": "issue"
},
{
"action": "closed",
"author": "slorber",
"comment_id": null,
"datetime": 1613409234000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "slorber",
"comment_id": 779355662,
"datetime": 1613409234000,
"masked_author": "username_1",
"text": "Yes you are right\r\n\r\nDuplicate of https://github.com/facebook/docusaurus/issues/3805",
"title": null,
"type": "comment"
}
] | 2 | 3 | 2,560 | false | false | 2,560 | false |
mellard-org/terraform-azurerm-jx | mellard-org | 694,059,527 | 7 | {
"number": 7,
"repo": "terraform-azurerm-jx",
"user_login": "mellard-org"
} | [
{
"action": "opened",
"author": "chrismellard",
"comment_id": null,
"datetime": 1599303231000,
"masked_author": "username_0",
"text": "…ources",
"title": "feat: enable specification of node_resource_group for AKS cluster res…",
"type": "issue"
},
{
"action": "created",
"author": "chris-mellard",
"comment_id": 687589948,
"datetime": 1599303237000,
"masked_author": "username_1",
"text": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by:\nTo complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **username_0**\nYou can assign the PR to them by writing `/assign @username_0` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=mellard-org%2Fterraform-azurerm-jx).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/mellard-org/terraform-azurerm-jx/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"username_0\"]} -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chris-mellard",
"comment_id": 687591355,
"datetime": 1599303759000,
"masked_author": "username_1",
"text": "@username_0: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npr-build | 58978103d1b641705d42e4557ac14c7b9b3b8d34 | [link]() | `/test this`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chris-mellard",
"comment_id": 687737353,
"datetime": 1599384373000,
"masked_author": "username_1",
"text": "@username_0: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npr-build | 4484170528db9085de6a473e84e0268ac00d86f9 | [link]() | `/test this`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"title": null,
"type": "comment"
}
] | 2 | 4 | 2,241 | false | false | 2,241 | true |
gajus/eslint-plugin-jsdoc | null | 434,838,190 | 207 | {
"number": 207,
"repo": "eslint-plugin-jsdoc",
"user_login": "gajus"
} | [
{
"action": "opened",
"author": "TuckerWhitehouse",
"comment_id": null,
"datetime": 1555602432000,
"masked_author": "username_0",
"text": "#184 added support for auto-fixing the `check-tag-names`, but it looks like the replacement is on the entire string, and not tag names specifically. This PR is to prefix the replacement with an `@` symbol to try and target tag names.\r\n\r\nI'm not sure if it would be better to do a global find and replace so all tag names are updated, not just the first match? e.g. `new RegExp('@' + jsdocTag.tag, 'g')`\r\n\r\nI was also looking to add tests, but I didn't see anything for the autofixes - if you have some guidance on how I might go about adding them, I'd be more than happy to.",
"title": "Prefix the tag name with an @ sign to avoid replacements in non-tag-names",
"type": "issue"
},
{
"action": "created",
"author": "TuckerWhitehouse",
"comment_id": 484874466,
"datetime": 1555675746000,
"masked_author": "username_0",
"text": "Sorry, I think this is actually a bug. Give a comment like this:\r\n```js\r\n/**\r\n * Some description that talks about the return value...\r\n\r\n * @return {Object}\r\n */\r\n```\r\nThe current behaviour replaces `return` with `returns` in the description and leaves the tag name unmodified. Because the tag name is unchanged, the fix will run on every execution and continue to replace `return` with `returns` which ends up with something like this:\r\n```js\r\n/**\r\n * Some description that talks about the returnssssssssssssssss value...\r\n\r\n * @return {Object}\r\n */\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gajus",
"comment_id": 484911292,
"datetime": 1555683866000,
"masked_author": "username_1",
"text": "Thank you for the explanation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gajus",
"comment_id": 491491614,
"datetime": 1557563473000,
"masked_author": "username_1",
"text": ":tada: This PR is included in version 4.8.4 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/eslint-plugin-jsdoc)\n- [GitHub release](https://github.com/username_1/eslint-plugin-jsdoc/releases/tag/v4.8.4)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,516 | false | false | 1,516 | true |
HarshCasper/WebEdge | null | 748,178,753 | 16 | null | [
{
"action": "opened",
"author": "HarshCasper",
"comment_id": null,
"datetime": 1606025318000,
"masked_author": "username_0",
"text": "## Descrption \r\n\r\nRefactor the Directory Structure. \r\n\r\n- Add all the Scripts in `webedge` directory\r\n- Add a Test directory to keep all the Tests \r\n- Update the Travis YML file",
"title": "Refactor the Directory Structure",
"type": "issue"
},
{
"action": "closed",
"author": "ridhambhat",
"comment_id": null,
"datetime": 1606028532000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 177 | false | false | 177 | false |
unicsmcr/unics_social_api | unicsmcr | 720,520,795 | 125 | null | [
{
"action": "opened",
"author": "Bottersnike",
"comment_id": null,
"datetime": 1602607181000,
"masked_author": "username_0",
"text": "When an API request is made without a token, a 401 response is generated as expected, however when a correctly authenticated request is made but the user lacks permissions, a 401 response is still generated, rather than the semantically correct 403.",
"title": "Semantically correct HTTP codes",
"type": "issue"
}
] | 1 | 1 | 249 | false | false | 249 | false |
cwida/duckdb | cwida | 766,560,059 | 1,229 | {
"number": 1229,
"repo": "duckdb",
"user_login": "cwida"
} | [
{
"action": "opened",
"author": "tiagokepe",
"comment_id": null,
"datetime": 1607958053000,
"masked_author": "username_0",
"text": "Hey all,\r\n\r\nThis is an initial implementation of Filters Pull UP as a separate optimizer.",
"title": "Filter Pull Up",
"type": "issue"
},
{
"action": "created",
"author": "tiagokepe",
"comment_id": 750417789,
"datetime": 1608747555000,
"masked_author": "username_0",
"text": "Hey Mark,\r\n\r\nI think I implemented everything that was suggested / commented.\r\nLet me know if I forgot something.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Mytherin",
"comment_id": 754523003,
"datetime": 1609839469000,
"masked_author": "username_1",
"text": "Thanks for the PR, apologies for the delayed merge. Looks great now!",
"title": null,
"type": "comment"
}
] | 2 | 3 | 270 | false | false | 270 | false |
DivanteLtd/shopware-pwa | DivanteLtd | 641,039,718 | 873 | {
"number": 873,
"repo": "shopware-pwa",
"user_login": "DivanteLtd"
} | [
{
"action": "opened",
"author": "mmeester",
"comment_id": null,
"datetime": 1592471153000,
"masked_author": "username_0",
"text": "## Changes\r\n<!-- Describe the changes which you did and which issue you're closing\r\n example: closes #230\r\n-->\r\n\r\n\r\n\r\n\r\n<!-- Paste here screenshot if there are visual changes -->\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] I followed [contributing](https://github.com/DivanteLtd/shopware-pwa/blob/master/CONTRIBUTING.md) guidelines",
"title": "fix(api-client): create context token on init if needed (#872)",
"type": "issue"
},
{
"action": "created",
"author": "patzick",
"comment_id": 661872219,
"datetime": 1595339275000,
"masked_author": "username_1",
"text": "closing for now as fixed with 0.2.0",
"title": null,
"type": "comment"
}
] | 4 | 4 | 1,116 | false | true | 356 | false |
russelltg/srt-rs | null | 611,866,618 | 34 | null | [
{
"action": "opened",
"author": "MarcAntoine-Arnaud",
"comment_id": null,
"datetime": 1588598120000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI'm starting using the library, what do you mean by `The reference implementation of SRT requires 3 threads per sender and 5 threads per receiver` ?\r\n\r\nCan you provide simple examples in a folder `examples` ? it can be run using `cargo run --example sender` for a filename `sender.rs`\r\nIt can send fake data and implement also a demo example.",
"title": "Threading",
"type": "issue"
},
{
"action": "created",
"author": "MarcAntoine-Arnaud",
"comment_id": 623486185,
"datetime": 1588601301000,
"masked_author": "username_0",
"text": "If I change the data size to >8000 bytes the sender stop avec 113 packets.\r\nIs it linked to the threading part ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "russelltg",
"comment_id": 623521730,
"datetime": 1588605001000,
"masked_author": "username_1",
"text": "What do you mean? Could you give a code example?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MarcAntoine-Arnaud",
"comment_id": 623555136,
"datetime": 1588608391000,
"masked_author": "username_0",
"text": "Yes `async` is just awesome !\r\n\r\nIn the example, [here](https://github.com/media-io/srt-rs/blob/add_examples/examples/sender.rs#L18) I have changed to 8000 and it not works as mentionned.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "russelltg",
"comment_id": 623576171,
"datetime": 1588610698000,
"masked_author": "username_1",
"text": "Oh wow that's surprising, considering I have a test that's pretty much exactly that (message_splitting) except it's 500k and not 8k. \r\n\r\nI'll debug it tonight, thanks a ton for the report.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "russelltg",
"comment_id": 626354206,
"datetime": 1589128419000,
"masked_author": "username_1",
"text": "I'm going to close this, I've commented on your PR. Feel free to repoen if you have more questions, or open a new issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "russelltg",
"comment_id": null,
"datetime": 1589128419000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 1,007 | false | false | 1,007 | false |
valdisiljuconoks/EPiBootstrapArea | null | 688,933,139 | 63 | null | [
{
"action": "closed",
"author": "valdisiljuconoks",
"comment_id": null,
"datetime": 1613459886000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 2,536 | false | true | 0 | false |
absoIute/Speedhack | null | 560,616,011 | 2 | null | [
{
"action": "opened",
"author": "HileYapak",
"comment_id": null,
"datetime": 1580935164000,
"masked_author": "username_0",
"text": "Hello, I used the code you gave\r\nBut I encountered a problem. I speed up the game. No problem. But the game freezes when it slows down again.\r\n`if (GetKeyState(VK_SHIFT) & 0x8000)\r\n\t\t{\r\n\t\t\tif (speedcontrol == true)\r\n\t\t\t{\r\n\t\t\t\tspeedcontrol = false;\r\n\t\t\t\tmultiplier =5.0f;\r\n\t\t\t}\r\n\t\t}else{\r\n\t\t\tif (speedcontrol==false)\r\n\t\t\t{\r\n\t\t\t\tspeedcontrol = true;\r\n\t\t\t\tmultiplier = 1.0f;\r\n\t\t\t}\r\n\t\t\t\r\n\t\t}`\r\n\r\nCodes may seem inexperienced sorry :) \r\nCan you tell me how to solve it?",
"title": "Hi man Speed Slow problem",
"type": "issue"
},
{
"action": "created",
"author": "HileYapak",
"comment_id": 590119404,
"datetime": 1582493999000,
"masked_author": "username_0",
"text": "Thanks I solved it myself",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "HileYapak",
"comment_id": null,
"datetime": 1582493999000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "decoder0007",
"comment_id": 926833534,
"datetime": 1632507648000,
"masked_author": "username_1",
"text": "How did you solve this",
"title": null,
"type": "comment"
}
] | 2 | 4 | 511 | false | false | 511 | false |
CMPUT301F20T32/BookIt | CMPUT301F20T32 | 722,782,766 | 15 | null | [
{
"action": "opened",
"author": "vyomea",
"comment_id": null,
"datetime": 1602809930000,
"masked_author": "username_0",
"text": "As an owner or borrower, I want a profile with a unique username and my contact information,\r\nso that I can be easily found and contacted about a book on the app.\r\n\r\nStory points: 3\r\nRisk level: medium",
"title": "US 02.01.01",
"type": "issue"
},
{
"action": "closed",
"author": "Sutanshu",
"comment_id": null,
"datetime": 1603836979000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 201 | false | false | 201 | false |
gdh1995/vimium-c-helpers | null | 684,094,637 | 4 | null | [
{
"action": "opened",
"author": "Zeioth",
"comment_id": null,
"datetime": 1598145047000,
"masked_author": "username_0",
"text": "Is it possible to edit NewTab.html, or include a local html file, so I can create my own starting page? I cannot locate NewTab.html in my firefox profile.",
"title": "Question about NewTab Adapter",
"type": "issue"
},
{
"action": "created",
"author": "Zeioth",
"comment_id": 678799530,
"datetime": 1598202637000,
"masked_author": "username_0",
"text": "I can confirm, serving the .html file with nginx worked! In case someone else need help in the future I did it like this, since I find docker is the most portable way to run a local server:\r\n\r\n # You basically copy local directories to docker with -v\r\n docker run --name nginx-devserver -d -v ~/workspaces/docker/nginx-devserver/nginx.conf:/etc/nginx/nginx.conf -v ~/.mozilla/startpage:/var/projects/startpage -p 8080:80 nginx\r\n\r\nAnd the content of nginx.conf is\r\n\r\n```\r\n# Configured to run as a non root user as described in:\r\n# https://hub.docker.com/_/nginx \r\n\r\npid /tmp/nginx.pid;\r\n\r\nevents {\r\n worker_connections 4096; ## Default: 1024\r\n}\r\n\r\nhttp {\r\n include /etc/nginx/mime.types;\r\n client_body_temp_path /tmp/client_temp;\r\n proxy_temp_path /tmp/proxy_temp_path;\r\n fastcgi_temp_path /tmp/fastcgi_temp;\r\n uwsgi_temp_path /tmp/uwsgi_temp;\r\n scgi_temp_path /tmp/scgi_temp;\r\n\r\n\r\n # Everything you store in a directory under /var/projects will be served\r\n # Example: localhost:8080/mypage\r\n server {\r\n listen 80;\r\n listen [::]:80;\r\n server_name localhost;\r\n root /var/projects;\r\n\r\n # serve static files\r\n location ~* \\.(css|js|gif|jpe?g|png)$ {\r\n # expires 168h;\r\n }\r\n }\r\n}\r\n```\r\n\r\nThat's all!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Zeioth",
"comment_id": null,
"datetime": 1598202637000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 1,422 | false | false | 1,422 | false |
castwide/vscode-solargraph | null | 704,873,562 | 194 | null | [
{
"action": "opened",
"author": "NuriYuri",
"comment_id": null,
"datetime": 1600518452000,
"masked_author": "username_0",
"text": "- Issue Type: Visual or Lint\r\n- Extension Name: solargraph \r\n- Extension Version: 0.21.1\r\n- OS Version: Windows 10 Pro, 18362.1082 (1903)\r\n- VSCode version: 1.49.0\r\n- Gem Version: 39.15\r\n\r\nHi, I have a little lint error when I'm using the operator `/` for division, it thinks its a regular expression. It's really weird, I don't know if that comes from Visual Studio Code or Solar Graph itself but here's what I see when I'm using this operator:\r\n\r\n",
"title": "Lint error with / operator",
"type": "issue"
},
{
"action": "created",
"author": "castwide",
"comment_id": 701171594,
"datetime": 1601445111000,
"masked_author": "username_1",
"text": "This appears to be an issue with VS Code's built-in syntax highlighting. Solargraph doesn't perform any syntax highlighting at all.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "NuriYuri",
"comment_id": null,
"datetime": 1601643963000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 689 | false | false | 689 | false |
strongloop/loopback | strongloop | 760,214,624 | 4,341 | null | [
{
"action": "opened",
"author": "giovanni-bertoncelli",
"comment_id": null,
"datetime": 1607510554000,
"masked_author": "username_0",
"text": "<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨\r\n\r\nAre you using LoopBack version 4? Please report the bug here:\r\nhttps://github.com/strongloop/loopback-next/issues/new\r\n\r\nHELP US HELP YOU, PLEASE\r\n- Do a quick search to avoid duplicate issues\r\n- Provide as much information as possible (reproduction sandbox, use case for features, etc.)\r\n- Consider using a more suitable venue for questions such as Stack Overflow, Gitter, etc.\r\n\r\nPlease fill in the *entire* template below.\r\n\r\n-->\r\n\r\n## Steps to reproduce\r\n- Configure the project with the flag `replaceOnPUT: true`\r\n- Create a model and declare an hook on `prototype.updateAttributes`, like this:\r\n```javascript\r\nTask.beforeRemote('prototype.updateAttributes', function(context, opt, next) {\r\n console.log('here');\r\n})\r\n```\r\n- Calling the PUT on that model does not pass through that beforeRemote.\r\n\r\n<!-- Describe how to reproduce the issue -->\r\n\r\n## Current Behavior\r\nCalling the PUT on that model does not pass through that beforeRemote.\r\nOnly declaring the hook on the `prototype.patchAttributes` will resolve to the expected behaviour.\r\n\r\n<!-- Describe the observed result -->\r\n\r\n## Expected Behavior\r\nCalling the PUT on that model should pass through the `prototype.updateAttributes` beforeRemote.\r\n\r\n<!-- Describe what did you expect instead, what is the desired outcome? -->",
"title": "prototype.updateAttributes hooks not triggered with replaceOnPUT configuration",
"type": "issue"
},
{
"action": "created",
"author": "bajtos",
"comment_id": 743103420,
"datetime": 1607681393000,
"masked_author": "username_1",
"text": "Thank you @username_0 for reporting the bug. Please note that LoopBack 3 is in maintenance mode, we are fixing only critical bugs and security vulnerabilities. \r\n\r\nBased on your report, there is a reasonable workaround for your issue, thus I don't consider it as critical and closing this issue as \"won't fix\".",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bajtos",
"comment_id": null,
"datetime": 1607681393000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,637 | false | false | 1,637 | true |
linz/linz-bde-schema | linz | 503,246,567 | 153 | null | [
{
"action": "opened",
"author": "imincik",
"comment_id": null,
"datetime": 1570427596000,
"masked_author": "username_0",
"text": "Develop tests for linz-bde-schema-publish script",
"title": "Develop tests for linz-bde-schema-publish script",
"type": "issue"
},
{
"action": "closed",
"author": "strk",
"comment_id": null,
"datetime": 1570530691000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 48 | false | false | 48 | false |
microsoftgraph/MSGraph-SDK-Code-Generator | microsoftgraph | 830,626,101 | 479 | {
"number": 479,
"repo": "MSGraph-SDK-Code-Generator",
"user_login": "microsoftgraph"
} | [
{
"action": "opened",
"author": "zengin",
"comment_id": null,
"datetime": 1615590160000,
"masked_author": "username_0",
"text": "Fixes #478\r\n\r\nSteps followed:\r\n1. Removed all references to Templates project\r\n2. Removed Templates project from the solution.\r\n3. Added back Templates project to the solution.\r\n4. Added back project references.",
"title": "Re-add Templates project to the Typewriter solution",
"type": "issue"
},
{
"action": "created",
"author": "MIchaelMainer",
"comment_id": 797806729,
"datetime": 1615590651000,
"masked_author": "username_1",
"text": "verified locally",
"title": null,
"type": "comment"
}
] | 2 | 2 | 227 | false | false | 227 | false |
bitfocus/companion-module-extron-in1604 | bitfocus | 493,025,561 | 1 | null | [
{
"action": "opened",
"author": "EventReplay",
"comment_id": null,
"datetime": 1568321777000,
"masked_author": "username_0",
"text": "@username_1 I've had a nose @ code and the manual, I have a couple of observations.\r\n\r\nI think Login is being set to true early by matching IN16 from copyright message, therfore password warning will not be triggered.\r\nYou are sending the command \"I\" and I don't think the response returns \"IN16\" for your data-match, could be \"Vid\" based on manual.\r\n\r\nHeartbeat: By using \"!\" your creating a variable data-match (for gui status interaction, debug) makes no sense, Just change to \"I\" if you changed to \"Vid\" as advised above.\r\n\r\nThese changes should then give a true status indication in the gui.\r\n\r\nHope that makes sense.",
"title": "I think Login & Heartbeat need a tweak!",
"type": "issue"
},
{
"action": "created",
"author": "JeffreyDavidsz",
"comment_id": 531146924,
"datetime": 1568362906000,
"masked_author": "username_1",
"text": "Yes this module was made quickly based on an other Extron module, I've changed some stuff (like remove a function within a function) and let it test it. Those extron modules need some extra attention.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EventReplay",
"comment_id": 531254976,
"datetime": 1568384295000,
"masked_author": "username_0",
"text": "@username_1 \"Those extron modules need some extra attention.\" What can I do to be of some help? I'm sure you'd rather be dealing with more important modules!\r\nShould the heartbeat function be expressed as you've done for IN1604 to be correct coding? It does seem to be working fine for SMX & DXP.\r\nI'll run my eyes over all Extron Modules.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JeffreyDavidsz",
"comment_id": 531325833,
"datetime": 1568396057000,
"masked_author": "username_1",
"text": "Well the function in a function could be placed separate. But to be honest I don't remember, I'll need to see the code again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EventReplay",
"comment_id": 531571548,
"datetime": 1568558768000,
"masked_author": "username_0",
"text": "@username_1 I've tested heartbeat with SMX, function placed seperate, don't see any difference in functionality but I guess does make sense for function to be before setinterval!\r\nI am however now a little confused as the IN1604 dosen't appear to have a LAN port! The IN1606 & IN1608 do. Given what the manual is saying for 06/08 here is what I think the instance.prototype.incomingData should be.\r\n`instance.prototype.incomingData = function(data) {\r\n\tvar self = this;\r\n\tdebug(data);\r\n\r\n\t// Match part of the copyright response from unit when a connection is made.\r\n\tif (self.login === false && data.match(\"Extron Electronics\")) {\r\n\t\tself.status(self.STATUS_WARNING,'Logging in');\r\n\t// Send Info request which should reply with Scaler setup, eg: \"Vid3 Aud3 Typ6 Std0 Blk0 Hrtxxx.x Vrtxxx.x\"\r\n\t\tself.socket.write(\"I\"+ \"\\n\");\r\n\t}\r\n\r\n\tif (self.login === false && data.match(\"Password:\")) {\r\n\t\tself.log('error', \"expected no password\");\r\n\t\tself.status(self.STATUS_ERROR, 'expected no password');\r\n\t}\r\n\r\n\t// Match part of expected Info request response from unit.\r\n\telse if (self.login === false && data.match(/Vid/)) {\r\n\t\tself.login = true;\r\n\t\tself.status(self.STATUS_OK);\r\n\t\tdebug(\"logged in\");\r\n\t}\r\n\t// Heatbeat to keep connection alive\r\n\tfunction heartbeat() {\r\n\t\tself.login = false;\r\n\t\tself.status(self.STATUS_WARNING,'Checking Connection');\r\n\t\tself.socket.write(\"I\"+ \"\\n\"); // should reply with Scaler setup, eg: \"Vid3 Aud3 Typ6 Std0 Blk0 Hrtxxx.x Vrtxxx.x\"\r\n\t\tdebug(\"Checking Connection\");\r\n\t}\r\n\r\n\tif (self.login === true) {\r\n\t\tclearInterval(self.heartbeat_interval);\r\n\t\tvar beat_period = 180; // Seconds\r\n\t\tself.heartbeat_interval = setInterval(heartbeat, beat_period * 1000);\r\n\t}\r\n\telse {\r\n\t\tdebug(\"data nologin\", data);\r\n\t}\r\n};\r\n`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JeffreyDavidsz",
"comment_id": 531685696,
"datetime": 1568622633000,
"masked_author": "username_1",
"text": "Regarding to password, that indeed was skipped on purpose. Sending `!` was just a polling request. I've changed the stuff, will send a email to the original requester",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JeffreyDavidsz",
"comment_id": null,
"datetime": 1568622635000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 3,201 | false | false | 3,201 | true |
ant-design/pro-table | ant-design | 588,445,096 | 256 | null | [
{
"action": "opened",
"author": "jamalabo1",
"comment_id": null,
"datetime": 1585231364000,
"masked_author": "username_0",
"text": "- Ant Design Pro 4\r\n- Umi 2.13.4\r\n- Google chrome\r\n- Windows 10 \r\n\r\nwhen the direction is set to RTL the components still adapt to LTR style, from pagination to header and search even toolbar, \r\n```\r\n <ConfigProvider direction={PageDirection}>\r\n <PageHeaderWrapper>\r\n <IntlProvider value={{locale: getLocale(), getMessage: TableGetMessage}}>\r\n <ProTable<App>\r\n search={false}\r\n headerTitle={null}\r\n actionRef={actionRef}\r\n rowKey={x => x.id}\r\n tableAlertRender={false}\r\n request={params => queryApps({\r\n ...params,\r\n })}\r\n columns={columns}\r\n rowSelection={{}}\r\n />\r\n </IntlProvider>\r\n </PageHeaderWrapper>\r\n </ConfigProvider>\r\n```",
"title": "🐛[BUG] ProTable does not respond to ConfigProvider from antd",
"type": "issue"
},
{
"action": "created",
"author": "chenshuai2144",
"comment_id": 605623012,
"datetime": 1585482033000,
"masked_author": "username_1",
"text": "Our support for RTL is really bad, are you interested in giving a pr？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jamalabo1",
"comment_id": 605713020,
"datetime": 1585521519000,
"masked_author": "username_0",
"text": "@username_1 no problem, I'll do my best.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ssteiger",
"comment_id": 621131469,
"datetime": 1588158348000,
"masked_author": "username_2",
"text": "How I fixed this in my project (hacky):\r\n- import `an-design/pro-table` package by hand\r\n- in `/es/component/intlContext/index.js` line 71\r\n\r\n```javascript\r\nvar IntlContext = React.createContext(zhCNIntl);\r\n# to\r\nvar IntlContext = React.createContext(enUSIntl);\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavidNorena",
"comment_id": 708682372,
"datetime": 1602712664000,
"masked_author": "username_3",
"text": "any workaround ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavidNorena",
"comment_id": 709516678,
"datetime": 1602787064000,
"masked_author": "username_3",
"text": "I found a possible issue, and its related to craco-antd package ...\r\n\r\nI had to modify this piece of code manually inside the node_modules:\r\n\r\nhttps://github.com/DocSpring/craco-antd/blob/master/lib/craco-antd.js#L91\r\n\r\nand change the library directory from \"lib\" to \"es\" compile and its working again ...\r\n\r\n@username_1 why did it work ?\r\n\r\ndoes that change (the one manually made by me) break anything else ?...\r\n\r\nim using\r\nantd: 4.7.0\r\n@ant-design/pro-table: 2.9.5",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ItamarSoffer",
"comment_id": 967703599,
"datetime": 1636756344000,
"masked_author": "username_4",
"text": "Hi, I noticed two things:\r\n1. If I change the toolbar (with the `options` prop) it cancels the `RTL` from the ContextProvider\r\n2. RTL and `sticky` prop not working together: cant scroll from right to left \r\n\r\nAny ideas why?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sansavision",
"comment_id": 970056572,
"datetime": 1637052968000,
"masked_author": "username_5",
"text": "A simple way for the ConfigProvider to work (as far as tested on the ProSelect component) is to use the babel-plugin-import. Either directly or if you are using it through craco - antd; set the option in the craco config js. babelPluginImportOptions: {\r\n libraryDirectory: \"es\",\r\n },",
"title": null,
"type": "comment"
}
] | 6 | 8 | 2,358 | false | false | 2,358 | true |
X-Profiler/xprofiler | X-Profiler | 666,808,981 | 84 | {
"number": 84,
"repo": "xprofiler",
"user_login": "X-Profiler"
} | [
{
"action": "opened",
"author": "hyj1991",
"comment_id": null,
"datetime": 1595918249000,
"masked_author": "username_0",
"text": "Commits:\r\n* [f07563f] test: update the regexp for location field (diag)\r\n* [8b6eabc] fix: formating error message before using\r\n* [df3987d] fix: compile warning in vs2019 at windows\r\n* [3610483] fix: duplicate process info\r\n\r\nPR-URL: https://github.com/X-Profiler/xprofiler/pull/84\r\nCommitted-BY: [username_0](https://github.com/username_0)",
"title": "release v1.2.4",
"type": "issue"
}
] | 2 | 2 | 334 | false | true | 334 | true |
ueokande/vim-vixen | null | 506,500,564 | 659 | null | [
{
"action": "opened",
"author": "Spacewalker2",
"comment_id": null,
"datetime": 1571040131000,
"masked_author": "username_0",
"text": "### I'm opening this issue because:\r\n\r\n- [x] I'll propose a new feature\r\n\r\n### Description\r\n\r\nIt would be nice to have the ability to copy a link on the current page to clipboard or save the content behind a link like the keybindings f or F. Thanks.",
"title": "[Feature Request] Copy link to clipboard or save as a link keybindings like f or F.",
"type": "issue"
},
{
"action": "created",
"author": "ueokande",
"comment_id": 545227276,
"datetime": 1571795354000,
"masked_author": "username_1",
"text": "Thank you for your proposal. That is \"extended hint mode\" in Vimperator.\r\nhttps://github.com/vimperator/vimperator-labs/blob/master/common/locale/en-US/hints.xml#L59",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Spacewalker2",
"comment_id": 545801416,
"datetime": 1571904812000,
"masked_author": "username_0",
"text": "This sound even better.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 438 | false | false | 438 | false |
lyft/cartography | lyft | 749,963,837 | 479 | null | [
{
"action": "opened",
"author": "achantavy",
"comment_id": null,
"datetime": 1606244669000,
"masked_author": "username_0",
"text": "56d3a384d664fec80fe2fc0591673d5b4e83e85f",
"title": "AWS ECR ClientError - InternalFailure",
"type": "issue"
}
] | 2 | 4 | 320 | false | true | 40 | false |
Integreat/cms-django | Integreat | 619,059,940 | 390 | null | [
{
"action": "opened",
"author": "thimmy687",
"comment_id": null,
"datetime": 1589556518000,
"masked_author": "username_0",
"text": "We should consider to implement some rate limiting mechanism to avoid kind of DoS attacks or just an unwanted overload off our API from single sources.\r\n\r\nFor this may we can have a look on the following source:\r\n\r\nhttps://django-ratelimit.readthedocs.io/en/stable/",
"title": "Rate limiting",
"type": "issue"
}
] | 1 | 1 | 265 | false | false | 265 | false |
mousebird/WhirlyGlobe | null | 745,525,999 | 1,266 | null | [
{
"action": "opened",
"author": "onepointsixtwo",
"comment_id": null,
"datetime": 1605694716000,
"masked_author": "username_0",
"text": "The documentation states that the MaplyVectorObject should have a userObject property to help identify it on selection etc., but it doesn't appear to actually exist in the latest version. Has this changed name, or is there another method of identifying your Vector objects on selection now?",
"title": "iOS: MaplyVectorObject.userObject is documented but doesn't exist",
"type": "issue"
},
{
"action": "created",
"author": "mousebird",
"comment_id": 729784180,
"datetime": 1605715910000,
"masked_author": "username_1",
"text": "Thanks for the note about the documentation.\r\n\r\nThe preferred way to identify a VectorObject is to put an attribute in the attribute dictionary.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "onepointsixtwo",
"comment_id": 729791731,
"datetime": 1605716639000,
"masked_author": "username_0",
"text": "Ah ha, yes, that worked. Can I just ask, are the objects in the dictionary stored in memory as-is or are they copied when returned via the delegate allSelect method? I ask because if they're not copied I can directly use a model object there with a callback, but if not then I guess I'll just use an identifier and a mapping back to the model.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "onepointsixtwo",
"comment_id": 729800395,
"datetime": 1605717457000,
"masked_author": "username_0",
"text": "Actually tried it out with a simple closure in the attributes and it worked fine. Awesome!\r\n\r\nThanks very much for your help. This is a really great project.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "onepointsixtwo",
"comment_id": null,
"datetime": 1605717458000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mousebird",
"comment_id": 729803068,
"datetime": 1605717729000,
"masked_author": "username_1",
"text": "They shouldn't be copied at that point. There's some funkyness with Vector Tiles, but it happens before this point, so it should affect your usage.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "onepointsixtwo",
"comment_id": 729810222,
"datetime": 1605718427000,
"masked_author": "username_0",
"text": "OK, that's great. That makes it a lot easier for me and the way I like to write ViewModels. Thanks again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kalpeshTOPS",
"comment_id": 844816686,
"datetime": 1621496512000,
"masked_author": "username_2",
"text": "if let jsonData = NSData(contentsOfFile: outline),\r\n let wgVecObj = MaplyVectorObject(fromGeoJSON: jsonData as Data) {\r\n // the admin tag from the country outline geojson has the country name save\r\n if let attrs = wgVecObj.attributes,\r\n let vecName = attrs.object(forKey: \"ADMIN\") as? NSObject {\r\n wgVecObj. = vecName}",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mousebird",
"comment_id": 845189342,
"datetime": 1621522178000,
"masked_author": "username_1",
"text": "How is this related to the userObject question?\r\nIf it is not, then please open your own issue.",
"title": null,
"type": "comment"
}
] | 3 | 9 | 1,708 | false | false | 1,708 | false |
DigitecGalaxus/Galaxus.Functional | DigitecGalaxus | 707,914,568 | 12 | null | [
{
"action": "opened",
"author": "FreeApophis",
"comment_id": null,
"datetime": 1600930994000,
"masked_author": "username_0",
"text": "The type constructor of None currently is very verbose. You always have to give the type information of the inner type. This is not necessary in the some case, the type can be inferred from the value.\r\n\r\nInstead of\r\n\r\n```cs\r\nvar option = Option<TSource>.Some(value);\r\n```\r\n\r\nIt should look like this:\r\n\r\n```cs\r\nvar option = Option.Some(value);\r\n```",
"title": "Consider an Option.Some constructor relying on type inference.",
"type": "issue"
},
{
"action": "created",
"author": "MindSwipe",
"comment_id": 703468686,
"datetime": 1601884714000,
"masked_author": "username_1",
"text": "I thought the same when I first used this library, and actually got around to thinking of an implementation. The only part I don't like about it is that the class `Option` has no relation to `Option<T>`, but that may just be my object oriented brain making me think it's bad.\r\n\r\n```csharp\r\npublic class Option\r\n{\r\n public static Option<T> Some<T>(T value) => Option<T>.Some(value);\r\n}\r\n```\r\n\r\nThis is an incredibly simple and possibly naïve implementation, but it at least allows me write `var option = Option.Some(value);`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FreeApophis",
"comment_id": 706609370,
"datetime": 1602362823000,
"masked_author": "username_0",
"text": "The class can be static too, this might help your OO mind ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NoelWidmer",
"comment_id": 707331569,
"datetime": 1602534729000,
"masked_author": "username_2",
"text": "_Why is this not useful?_\r\nWe can only call the `Option.Some(value)` constructor if we already have a value. At that point we might as well do `value.ToOption()` or `value.ToOption<T>()`.\r\n\r\n_Why this is still a good idea:_\r\n`Option<T>.Some(value)` is basically the counterpart to `value.ToOption<T>()`. But there is currently no counterpart for `value.ToOption()`.\r\n\r\n_My opinion_\r\nWe should add `Option.Some(value)` to act as a counterpart to `value.ToOption()` even if there latter is already is a very short way of doing it.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 1,463 | false | false | 1,463 | false |
DFE-Digital/teacher-vacancy-service | DFE-Digital | 723,118,474 | 2,150 | {
"number": 2150,
"repo": "teacher-vacancy-service",
"user_login": "DFE-Digital"
} | [
{
"action": "opened",
"author": "cpjmcquillan",
"comment_id": null,
"datetime": 1602845859000,
"masked_author": "username_0",
"text": "## Jira ticket URL\r\nhttps://dfedigital.atlassian.net/browse/TEVA-1374\r\n\r\n## Changes in this PR\r\n- Add publisher organisation to vacancy",
"title": "Add publisher organisation to vacancy",
"type": "issue"
}
] | 3 | 5 | 7,107 | false | true | 135 | false |
wowchemy/wowchemy-hugo-modules | wowchemy | 807,722,738 | 2,158 | null | [
{
"action": "opened",
"author": "DominiqueMakowski",
"comment_id": null,
"datetime": 1613212183000,
"masked_author": "username_0",
"text": "Thanks for the great work! I am currently updating my website from academic 4.0 to wowchemy 5.0, and I've encountered an issue with the slider widget.\r\n\r\nPreviously (see https://dominiquemakowski.github.io/#slider), the overlay image was rescaled by the width, whereas with the new version, the same image is not rescaled: it starts from its corner and the image extends far beyond the widget.\r\n\r\nIs there any option to tweak the scaling / size of images? Thanks",
"title": "Autoscale images (img_overlay) in slider widget",
"type": "issue"
},
{
"action": "created",
"author": "seichter",
"comment_id": 803285224,
"datetime": 1616235381000,
"masked_author": "username_1",
"text": "The name of this issue is wrong the item parameter is overlay_img. Unfortunately the history of https://github.com/wowchemy/wowchemy-hugo-modules/commits/main/wowchemy/layouts/partials/widgets/slider.html has been deleted. So tracing back what has changed is not possible.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seichter",
"comment_id": 803296060,
"datetime": 1616240616000,
"masked_author": "username_1",
"text": "So, because it bothered me a lot I hacked just some CSS in there, this should be better served with proper resizing in hugo but for now it works. \r\n\r\nI added in line 25 in slides.html this:\r\n\r\n```css\r\nbackground-position:center; background-repeat: no-repeat; background-size: contain; \r\n```\r\nto get some sort of resizing. Not really a good solution but until the actual problem is fixed it suffices.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fliptanedo",
"comment_id": 856292370,
"datetime": 1623103218000,
"masked_author": "username_2",
"text": "I agree with @username_1 that this is a bug. The hack @username_1 presents [https://github.com/wowchemy/wowchemy-hugo-modules/issues/2158#issuecomment-803296060](url) is really helpful and clever, thanks. \r\n\r\nI offer that it can be implemented in a simple way in the markdown file for the homepage widget (e.g. ./content/home/slider.md):\r\n\r\n```\r\nheight: '300px; background-position:center; background-repeat: no-repeat; background-size: cover'\r\n```\r\n\r\n\r\n\r\nThis is because the [current slider template](https://github.com/wowchemy/wowchemy-hugo-modules/blob/main/wowchemy/layouts/partials/widgets/slider.html) (as of this writing) inserts the height in the style attribute of the carousel item:\r\n\r\n```\r\n<div class=\"wg-hero dark carousel-item active\" style=\" height: 300px; \r\n```\r\n\r\nSo by replacing \r\n\r\n```\r\nheight: 300px\r\n``` \r\n\r\nwith \r\n\r\n```\r\nheight: '300px; background-position:center;'\r\n```\r\n you can insert additional CSS into the div tag.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jingtaisong",
"comment_id": 857391057,
"datetime": 1623216984000,
"masked_author": "username_3",
"text": "Hi @username_2 , thanks for looking into this issue. It has bothered me for a long time! I tried replacing the\r\n```\r\nheight: 300px\r\n```\r\nin ./content/home/slider.md with\r\n```\r\nheight: '300px; background-position:center; background-repeat: no-repeat; background-size: cover'\r\n```\r\nbut it seems the slider picture is still not auto-scaled. Is there another change that I should have made somewhere else?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seichter",
"comment_id": 857411658,
"datetime": 1623219258000,
"masked_author": "username_1",
"text": "@username_3 ... you need to copy the `slider.html` template to the new folder as I mentioned [here](https://github.com/wowchemy/wowchemy-hugo-modules/issues/2158#issuecomment-803296060). There you can add your CSS changes. This will overlay the existing template. The actual `slider.md` can stay unchanged or can be used as usual.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seichter",
"comment_id": 876510986,
"datetime": 1625756303000,
"masked_author": "username_1",
"text": "With version 5.3.0 `slider.html` needs to be fixed like this:\r\n\r\n```\r\n\r\n {{ $style_bg := \"\" }}\r\n {{with $page.Params.height}}\r\n {{ $style_bg = printf \"%s height: %s;\" $style_bg . }}\r\n {{end}}\r\n {{ if $item.overlay_color }}\r\n {{ $style_bg = printf \"%s background-color: %s;\" $style_bg ($item.overlay_color | default \"transparent\") }}\r\n {{ end }}\r\n {{ if $item.overlay_img }}\r\n {{ $bg_img := resources.Get (printf \"media/%s\" $item.overlay_img) }}\r\n {{ if $bg_img }}\r\n {{ $style_bg = printf \"%sbackground-image: url('%s'); background-position: center; background-repeat: no-repeat; background-size: cover;\" $style_bg $bg_img.Permalink }}\r\n {{ else }}\r\n {{ errorf \"Couldn't find `%s` in the `assets/media/` folder - please add it.\" $item.overlay_img }}\r\n {{ end }}\r\n {{ if $item.overlay_filter }}\r\n {{ $style_bg = printf \"%sfilter: brightness(%s);\" $style_bg (string $item.overlay_filter) }}\r\n {{ end }}\r\n {{ end }}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DominiqueMakowski",
"comment_id": 883033740,
"datetime": 1626753804000,
"masked_author": "username_0",
"text": "@username_1 thanks ofr the workaround! Is there an easy PR that could be made to directly fix this bug? I cannot find any `slider.html` in this repo. Tagging also @gcushen since the issue has been closed but the bug is unresolved and a fix seems to be possible.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joe4dev",
"comment_id": 933017990,
"datetime": 1633291963000,
"masked_author": "username_4",
"text": "This issue together with the [overlay filter being applied to text and buttons](https://github.com/wowchemy/wowchemy-hugo-themes/issues/2357) breaks two essential features of the slider widget.\r\n\r\nThe snippet by @username_1 fixes the autoscaling issue and I posted an adapted version that fixes both issues here: https://github.com/wowchemy/wowchemy-hugo-themes/issues/2357#issuecomment-933017687",
"title": null,
"type": "comment"
}
] | 7 | 12 | 5,575 | false | true | 4,454 | true |
appsody/stacks | appsody | 568,985,796 | 691 | {
"number": 691,
"repo": "stacks",
"user_login": "appsody"
} | [
{
"action": "opened",
"author": "Kamran64",
"comment_id": null,
"datetime": 1582295028000,
"masked_author": "username_0",
"text": "### Checklist:\r\n\r\n- [x] Read the [Code of Conduct](https://github.com/appsody/website/blob/master/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/appsody/website/blob/master/CONTRIBUTING.md).\r\n\r\n- [x] Followed the [commit message guidelines](https://github.com/appsody/website/blob/master/CONTRIBUTING.md#commit-message-guidelines).\r\n\r\n- [x] Stack adheres to [Appsody stack structure](https://github.com/appsody/website/blob/master/content/docs/stacks/stacks-overview.md#stack-structure).\r\n\r\n### Modifying an existing stack:\r\n\r\n- [x] Updated the stack version in `stack.yaml`\r\n\r\nThere was a bug causing a few stacks released in the past couple of days to not be pushed to Docker hub. This PR bumps the version so that we can release the stacks properly.",
"title": "open liberty: Update version to rerelease stack",
"type": "issue"
},
{
"action": "created",
"author": "scottkurz",
"comment_id": 589689610,
"datetime": 1582297201000,
"masked_author": "username_1",
"text": "Closing since with #686 we're ready to release a \"real\" 0.2.2",
"title": null,
"type": "comment"
}
] | 2 | 2 | 835 | false | false | 835 | false |
knaxus/problem-solving-javascript | knaxus | 509,531,989 | 115 | {
"number": 115,
"repo": "problem-solving-javascript",
"user_login": "knaxus"
} | [
{
"action": "opened",
"author": "ashu8912",
"comment_id": null,
"datetime": 1571535730000,
"masked_author": "username_0",
"text": "#112",
"title": "ZigZag BTree Traversal added",
"type": "issue"
},
{
"action": "created",
"author": "TheSTL",
"comment_id": 544246995,
"datetime": 1571573848000,
"masked_author": "username_1",
"text": "Hii @username_0 this is problem on binary tree. Therefore it should be in separated folder. You can check Stack Datastructure as an example [Stack](https://github.com/knaxus/problem-solving-javascript/tree/master/src/_DataStructures_/Stack)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ashu8912",
"comment_id": 544266362,
"datetime": 1571587740000,
"masked_author": "username_0",
"text": "Ok sending in a pr soon",
"title": null,
"type": "comment"
}
] | 2 | 3 | 269 | false | false | 269 | true |
tensorflow/tensorflow | tensorflow | 734,666,704 | 44,524 | {
"number": 44524,
"repo": "tensorflow",
"user_login": "tensorflow"
} | [
{
"action": "opened",
"author": "Flamefire",
"comment_id": null,
"datetime": 1604336141000,
"masked_author": "username_0",
"text": "I noticed that in addition to com_github_googleapis_googleapis being missing as a system lib (see #42361) the new typing_extensions_archive wasn't added to the list of valid options.\r\n\r\nThis simply removes the com_github_googleapis_googleapis, the alternative is to readd it as the new name com_google_googleapis and readd (and potentially update) the system build file but I can't verify this. Maybe @username_2 may?\r\n\r\nIt also adds typing_extensions_archive as a valid option.\r\n\r\nI also made a script which points out those issues. I'd like to have that added to CI as this acts like a basic sanity check. Could anyone from the TF team guide me on how to do that?",
"title": "Update list of systemlibs and add script to verify",
"type": "issue"
},
{
"action": "created",
"author": "mihaimaruseac",
"comment_id": 721348437,
"datetime": 1604433978000,
"masked_author": "username_1",
"text": "I like this, thank you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flamefire",
"comment_id": 721620603,
"datetime": 1604482409000,
"masked_author": "username_0",
"text": "@username_1 Could you tell me where I could add this so it is run by the CI scripts for PRs?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "perfinion",
"comment_id": 721947188,
"datetime": 1604520353000,
"masked_author": "username_2",
"text": "I talked with mihai at yesterday's SIG-Build meeting, we're not really sure about where yet. Lets get this merged first then maybe we can do a github action, the complicated part is most of their kokoro alerting is internal to google so there isnt a way to notify you and I. initially i'll try running a cronjob on my build machine until we figure out alerting",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mihaimaruseac",
"comment_id": 722037159,
"datetime": 1604533975000,
"masked_author": "username_1",
"text": "Sorry, came to review GitHub stuff only now. We could try Github Actions at one point in the future, besides what username_2@ said.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flamefire",
"comment_id": 722274004,
"datetime": 1604570501000,
"masked_author": "username_0",
"text": "I used GHA in the past and it is generally very easy to use. I could add one to run this to this PR or a follow up. It should be pretty trivial (checkout, setup python, run script) but needs maybe some bikeshedding about names and probably someone need to enable GHA for this repo. Also it will only run AFTER it is merged, so testing is a bit nasty. I could test it in my fork and link that in the PR though\r\nIMO running linters and such things like this are perfect for GHA as they are fast and easy to set up. Also that takes off pressure from the other tests",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mihaimaruseac",
"comment_id": 722574182,
"datetime": 1604602601000,
"masked_author": "username_1",
"text": "Let's rebase this on master again, that should fix sanity build",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flamefire",
"comment_id": 722934511,
"datetime": 1604649275000,
"masked_author": "username_0",
"text": "Rebased",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "perfinion",
"comment_id": 724209374,
"datetime": 1604948182000,
"masked_author": "username_2",
"text": "I'm not sure if im mis-reading the patches after the rebase or not?\r\nit looks like \"typing_extensions_archive\" is removed from syslibs_configure.bzl?\r\nThat got added in commit b7871f8a232536fcb6e388bb05a9fd7171ff3a96 so should stay in the valid list",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flamefire",
"comment_id": 724517496,
"datetime": 1604993238000,
"masked_author": "username_0",
"text": "Good catch, thanks! Corrected and rebased to current master",
"title": null,
"type": "comment"
}
] | 3 | 10 | 2,213 | false | false | 2,213 | true |
vultr/vultr-cli | vultr | 642,390,890 | 100 | null | [
{
"action": "opened",
"author": "egee-irl",
"comment_id": null,
"datetime": 1592664866000,
"masked_author": "username_0",
"text": "I noticed on the readme, it says: `Snap (Coming soon)`.\r\n\r\nI didn't see a `snapcraft.yml` or a branch for it in the repo.. Is there a fork or someplace else where progress has been made on this?\r\n\r\nI'd love to help get the vultr-cli built into a Snap as I have some experience snapping apps!",
"title": "Linux Snap support",
"type": "issue"
},
{
"action": "created",
"author": "ddymko",
"comment_id": 656699371,
"datetime": 1594390555000,
"masked_author": "username_1",
"text": "Hey @username_0 \r\n\r\nWe started to implement a snapcraft.yml but then we switched over to goreleaser to handle our releases and we never got around to implementing the snapcraft portion.\r\n\r\nWhat we would need ot do is to upgrade the gorealeaser.yml to support building snaps and deploying them along side our homebrew and github builds.\r\nhttps://goreleaser.com/customization/snapcraft/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "egee-irl",
"comment_id": 657139570,
"datetime": 1594506391000,
"masked_author": "username_0",
"text": "Very cool, I can take a look at the Snapcraft portion and see if I can make some magic happen.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 767 | false | false | 767 | true |
openshift/enhancements | openshift | 672,869,645 | 418 | {
"number": 418,
"repo": "enhancements",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "derekwaynecarr",
"comment_id": null,
"datetime": 1596553943000,
"masked_author": "username_0",
"text": "All usages of cluster profiles in OpenShift MUST have an associated enhancement describing their requirement and the alternative manifests needed in support of that requirement.\r\n\r\ncc @username_1 @csrwng",
"title": "Clarify cluster profile usage requirements",
"type": "issue"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 668656721,
"datetime": 1596554068000,
"masked_author": "username_1",
"text": "/approve\r\n/lgtm\r\n\r\nThere was no intent to allow profiles unrestricted for other use cases without discussion (in fact, we explicitly scoped profiles to ibm cloud because we don't intend to allow profiles for wide use without more concrete discussion)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 668657554,
"datetime": 1596554152000,
"masked_author": "username_1",
"text": "/lgtm",
"title": null,
"type": "comment"
}
] | 3 | 7 | 3,202 | false | true | 462 | true |
rossbar/networkx | null | 722,858,647 | 1 | {
"number": 1,
"repo": "networkx",
"user_login": "rossbar"
} | [
{
"action": "opened",
"author": "jarrodmillman",
"comment_id": null,
"datetime": 1602820738000,
"masked_author": "username_0",
"text": "",
"title": "Make nodes more visible and refactor code",
"type": "issue"
},
{
"action": "created",
"author": "jarrodmillman",
"comment_id": 709734645,
"datetime": 1602821896000,
"masked_author": "username_0",
"text": "If this looks good to you, I think we are done. I don't think trying to get the nodes in the same position is a good idea now. I tried a few things and they looked much worse. i am pretty happy with the result above.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 330 | false | false | 330 | false |
anchore/anchore-charts | anchore | 547,155,145 | 16 | null | [
{
"action": "opened",
"author": "Btodhunter",
"comment_id": null,
"datetime": 1578524929000,
"masked_author": "username_0",
"text": "The postgresql dependent chart should be updated from v1.0.0 to the latest available postgresql chart. This upgrade has been avoided due to backwards compatibility issues with deployments using the v1.0.0 due to the required upgrade path for the postgresql chart.\r\n\r\nThe migration to a new chart repository will be a good time to update the dependencies of stable/anchore-engine in conjunction with the upgrade to using the Chart `apiVersion: v2` for Helm3 support.",
"title": "Update stable/anchore-engine postgresql dependency",
"type": "issue"
},
{
"action": "created",
"author": "Btodhunter",
"comment_id": 606276562,
"datetime": 1585606021000,
"masked_author": "username_0",
"text": "To make the switch to a new chart repository easy & to allow users on older version of k8s to utilize the chart, we will directly migrate the stable chart to `anchore-charts/legacy/anchore-engine`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Btodhunter",
"comment_id": 668298897,
"datetime": 1596499472000,
"masked_author": "username_0",
"text": "Fixed with #49",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Btodhunter",
"comment_id": null,
"datetime": 1596499473000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 4 | 675 | false | false | 675 | false |
aquaULB/solving_pde_mooc | aquaULB | 711,413,516 | 9 | {
"number": 9,
"repo": "solving_pde_mooc",
"user_login": "aquaULB"
} | [
{
"action": "opened",
"author": "Oedipsos",
"comment_id": null,
"datetime": 1601410143000,
"masked_author": "username_0",
"text": "- Fixed wrong index value in the comparison between forward and backward Euler schemes\r\n- Fixed typos and spelling\r\n- Minor visual changes for consistency (newlines, aligning, ...)",
"title": "Euler: Fix typos & writing",
"type": "issue"
},
{
"action": "created",
"author": "bknaepen",
"comment_id": 702053678,
"datetime": 1601549531000,
"masked_author": "username_1",
"text": "Thanks for a lot the typos corrected, a very good bug catch !\r\n@YelyzavetaV Could you merge if you also agree?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 290 | false | false | 290 | false |
getsentry/symbolic | getsentry | 795,042,112 | 315 | null | [
{
"action": "opened",
"author": "t-veor",
"comment_id": null,
"datetime": 1611749012000,
"masked_author": "username_0",
"text": "Sometimes rustc can produce a zero-length WASM function. When compiling something like this:\r\n```rust\r\n//! ```cargo\r\n//! [package]\r\n//! name = \"zero-size-test\"\r\n//! version = \"0.1.0\"\r\n//! edition = \"2018\"\r\n//!\r\n//! [lib]\r\n//! crate-type = [\"cdylib\"]\r\n//!\r\n//! [profile.release]\r\n//! debug = 2\r\n//! opt-level = \"s\"\r\n//! ```\r\n\r\n#![no_std]\r\n\r\nuse core::panic::PanicInfo;\r\n\r\n#[panic_handler]\r\nfn panic(_info: &PanicInfo) -> ! {\r\n loop {}\r\n}\r\n\r\n#[no_mangle]\r\npub extern \"C\" fn main() {\r\n panic!();\r\n}\r\n```\r\nwith `cargo build --target=wasm32-wasi --release`, one of the functions it generates is this (output from wasm-objdump):\r\n```\r\n...\r\n0000af func[2] <_ZN4core3ptr13drop_in_place17h0004e302d1c67d0eE>:\r\n 0000b0: 0b | end\r\n...\r\n```\r\n(I've no idea why this function doesn't get pruned by dead code elimination.)\r\n\r\nThis function seems to break `WasmObject::symbol_map`, which returns this output for this binary:\r\n```\r\nSymbolMap {\r\n symbols: [\r\n Symbol {\r\n name: \"_ZN4core3ptr13drop_in_place17h0004e302d1c67d0eE\",\r\n address: 0x0,\r\n size: 0xb5,\r\n },\r\n Symbol {\r\n name: \"rust_begin_unwind\",\r\n address: 0x90,\r\n size: 0x8,\r\n },\r\n Symbol {\r\n name: \"main\",\r\n address: 0x98,\r\n size: 0x1d,\r\n },\r\n Symbol {\r\n name: \"_ZN4core9panicking5panic17h97b5c3a1a3625519E\",\r\n address: 0xb5,\r\n size: 0x55,\r\n },\r\n Symbol {\r\n name: \"_ZN4core9panicking9panic_fmt17hcdbc22275273f460E\",\r\n address: 0x10a,\r\n size: 0x41,\r\n },\r\n Symbol {\r\n name: \"_ZN36_$LT$T$u20$as$u20$core..any..Any$GT$7type_id17hf7e256a7acecf50fE\",\r\n address: 0x14b,\r\n size: 0x0,\r\n },\r\n ],\r\n}\r\n```\r\n\r\nAs you can see, the symbol map thinks that `_ZN4core3ptr13drop_in_place17h0004e302d1c67d0eE` ranges from 0x0 to 0xb5, which completely covers the range of `rust_begin_unwind` and overlaps with the range of `main`. This actually messes up name lookups later as `DebugSession::functions` will report that that `rust_begin_unwind` is called `_ZN4core3ptr13drop_in_place17h0004e302d1c67d0eE` and that `_ZN4core3ptr13drop_in_place17h0004e302d1c67d0eE` is called `main`, because they're both fully included in the wonky ranges that `symbol_map` reports.\r\n\r\nThe culprit appears to be this function that `WasmSymbolIterator` uses (here https://github.com/getsentry/symbolic/blob/master/symbolic-debuginfo/src/wasm.rs#L315):\r\n```rust\r\nfn get_addr_of_function(func: &walrus::Function) -> u64 {\r\n if let walrus::FunctionKind::Local(ref loc) = func.kind {\r\n let entry_block = loc.entry_block();\r\n let seq = loc.block(entry_block);\r\n seq.instrs.get(0).map_or(0, |x| x.1.data() as u64)\r\n } else {\r\n 0\r\n }\r\n}\r\n```\r\nNote that this function returns 0 if there are no instructions in the function's entry block. Walrus appears to not include the `end` pseudo-instruction that is at the end of every function, and so as a result we get a weird range for the zero-size function which fully includes every other function up to where it appears in the code section.\r\n\r\nAs an aside, this function seems a little wonky to me anyway for getting the address of a function - it gets the address of the first instruction in the function, but this skips over the function declaration and local declarations. For example, compare the ranges of `_ZN4core9panicking5panic17h97b5c3a1a3625519E` and `_ZN4core9panicking9panic_fmt17hcdbc22275273f460E` with the output from wasm-objdump here:\r\n\r\n```\r\n...\r\n0000b2 func[3] <_ZN4core9panicking5panic17h97b5c3a1a3625519E>:\r\n 0000b3: 01 7f | local[0] type=i32\r\n 0000b5: 23 80 80 80 80 00 | global.get 0\r\n ...\r\n 000105: 0b | end\r\n000107 func[4] <_ZN4core9panicking9panic_fmt17hcdbc22275273f460E>:\r\n 000108: 01 7f | local[0] type=i32\r\n 00010a: 23 80 80 80 80 00 | global.get 0\r\n ...\r\n 000148: 0b | end\r\n00014a func[5] <_ZN36_$LT$T$u20$as$u20$core..any..Any$GT$7type_id17hf7e256a7acecf50fE>:\r\n 00014b: 42 d4 c9 d5 d6 d6 b3 d4 be | i64.const 5511651255515440340\r\n ...\r\n```\r\n\r\n`_ZN4core9panicking5panic17h97b5c3a1a3625519E` is actually 0xb2..0x107 but the symbol map reports it as 0xb5..0x10a, which overlaps a little with the next function `_ZN4core9panicking9panic_fmt17hcdbc22275273f460E`, because 0x10a is where this function thinks `_ZN4core9panicking9panic_fmt17hcdbc22275273f460E` begins.",
"title": "Zero-length WASM functions cause strange behaviour in SymbolMap",
"type": "issue"
},
{
"action": "created",
"author": "mitsuhiko",
"comment_id": 768280775,
"datetime": 1611753654000,
"masked_author": "username_1",
"text": "Two things. I think part of this might explain what I filed her: https://github.com/rust-lang/rust/issues/79410\r\n\r\nSecond: using walrus here to get the addr is indeed questionable. I wanted to change it to wasmparser already but didn't finish it yet. Walrus is kinda the wrong tool for this job.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 4,894 | false | false | 4,894 | false |
projectceladon/device-intel-civ-battery | projectceladon | 626,408,620 | 2 | {
"number": 2,
"repo": "device-intel-civ-battery",
"user_login": "projectceladon"
} | [
{
"action": "opened",
"author": "tanujtekriwal",
"comment_id": null,
"datetime": 1590662683000,
"masked_author": "username_0",
"text": "This utility will be used in VMs to fetch the battery related sysfs entry\r\ndata from the Host OS to the Guest OS (Android). The Health HAL on the\r\nandroid will receive the data and take actions accordingly. This will also\r\nhelp update the battery percentage icon on Android UI.\r\n\r\nThis version supports the following:\r\n1. Update battery related sysfs entry data to the guest OS.\r\n2. Send battery related data at every 1 second interval.\r\n3. When android is rebooted or connection is lost, then the utility will\r\nagain start listening on the port specified for connection.",
"title": "Battery Utility: This patch adds the battery utility code to github.",
"type": "issue"
},
{
"action": "created",
"author": "tanujtekriwal",
"comment_id": 635277729,
"datetime": 1590664626000,
"masked_author": "username_0",
"text": "Wrong branch.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 584 | false | false | 584 | false |
interfax/interfax-nodejs | interfax | 650,638,318 | 14 | null | [
{
"action": "opened",
"author": "djorg83",
"comment_id": null,
"datetime": 1593787303000,
"masked_author": "username_0",
"text": "There are a lot of files published to npm with this package that are not needed to be downloaded and included in downstream applications.\r\n\r\nThe `\"files\"` attribute should be added to the `package.json`, or `.npmignore` should be updated.\r\n\r\n### package.json\r\n```\r\n{\r\n \"files\": [\r\n \"lib\"\r\n ],\r\n}\r\n```\r\n\r\n### .npmignore\r\n```\r\nsrc/\r\ntests/\r\n.babelrc\r\n.eslintrc.js\r\n.travis.yml\r\nCHANGELOG.md\r\nCONTRIBUTING.md\r\n```\r\n\r\n<img width=\"274\" alt=\"Screen Shot 2020-07-03 at 10 32 39 AM\" src=\"https://user-images.githubusercontent.com/3258109/86478688-a39c0f80-bd18-11ea-8714-015f2b5d2391.png\">",
"title": "Useless files published to npm",
"type": "issue"
}
] | 1 | 1 | 586 | false | false | 586 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.