repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
prometheus/prometheus | prometheus | 152,044,928 | 1,607 | null | [
{
"action": "opened",
"author": "harneksidhu",
"comment_id": null,
"datetime": 1462040703000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI am trying to find some documentation on how to setup basic authentication for the Prometheus database. I was not able to find anything on Prometheus' documentation. However, I notice Grafana mentions that basic auth is possible for Prometheus http://docs.grafana.org/datasources/prometheus/.\r\n\r\nIs basic authentication possible and if so, where can I find the appropriate instructions in the documentation?\r\n\r\nThanks!",
"title": "Prometheus Basic Authentication",
"type": "issue"
},
{
"action": "created",
"author": "barkerd427",
"comment_id": 215985660,
"datetime": 1462041123000,
"masked_author": "username_1",
"text": "I believe this is done by putting something line nginx in front of it. I\nknow of no authentication within Prometheus.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beorn7",
"comment_id": 215986953,
"datetime": 1462042302000,
"masked_author": "username_2",
"text": "Answer is here: http://www.robustperception.io/adding-basic-auth-to-prometheus-with-nginx/",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "beorn7",
"comment_id": null,
"datetime": 1462042302000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 786 | false | true | 637 | false |
scikit-learn/scikit-learn | scikit-learn | 251,648,120 | 9,593 | {
"number": 9593,
"repo": "scikit-learn",
"user_login": "scikit-learn"
} | [
{
"action": "opened",
"author": "reiinakano",
"comment_id": null,
"datetime": 1503319417000,
"masked_author": "username_0",
"text": "<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\nFixes #9589 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nI figured that the purpose of this code (original)\r\n\r\n```python\r\nif method in ['decision_function', 'predict_proba', 'predict_log_proba']:\r\n n_classes = len(set(y))\r\n predictions_ = np.zeros((X_test.shape[0], n_classes))\r\n if method == 'decision_function' and len(estimator.classes_) == 2:\r\n predictions_[:, estimator.classes_[-1]] = predictions\r\n else:\r\n predictions_[:, estimator.classes_] = predictions\r\n predictions = predictions_\r\n```\r\n\r\nis to handle cases where the cross-validation done in `cross_val_predict` doesn't properly stratify the classes i.e. one fold in the CV may not have all classes present.\r\n\r\nHowever, it misses an edge case for `decision_function` when `len(estimator.classes_) == 2` (train split has only 2 classes) and `n_classes == 2` (total data has only 2 classes). It wrongly assumes that the output will be of shape `(n_samples, n_classes)`, when in fact, this is only true for `decision_function` if `n_classes > 2`. For the correct behavior, we must first check if the total number of classes is greater than 2, and if it is not, we must stick to an output shape of `(n_samples,)`.\r\n\r\n#### Any other comments?\r\n\r\nWhile this PR fixes the case raised in #9589, it still doesn't take into account the fact that for `sklearn.svm.SVC`, `decision_function` does not always follow the shape `(n_samples, n_classes)` or `(n_samples,)`. If `decision_function_shape` is not set to `ovr`, the shape is `(n_samples, n_classes * (n_classes-1) / 2)`, and if different train splits have different numbers of classes (not stratified), this inconsistency can't be fixed by the approach currently taken by `cross_val_predict`.\r\n\r\nI would also like to point out my personal opinion that `cross_val_predict` should probably just throw an error if the classes are not stratified properly (by this I mean some classes are entirely absent in some splits) instead of handling it automatically as it tries to do now. Metrics like log loss and ROC might be affected if for some splits, entire columns are zeroed out. Idk, it just feels inconsistent. Of course, you guys have the final say on this.\r\n\r\nWhat I mean by inconsistent:\r\n\r\n```python\r\nfrom sklearn.model_selection import cross_val_predict, KFold\r\nfrom sklearn.datasets import load_iris\r\nfrom sklearn.linear_model import LogisticRegression\r\n\r\nX, y = load_iris(True)\r\ncross_val_predict(LogisticRegression(), X, y, cv=KFold().split(X), method='predict_proba')\r\n```\r\n\r\nreturns (array cut down in size)\r\n\r\n```\r\narray([[ 0.00000000e+00, 9.99987841e-01, 1.21585683e-05],\r\n [ 0.00000000e+00, 9.99963190e-01, 3.68104260e-05],\r\n [ 0.00000000e+00, 9.99970224e-01, 2.97757119e-05],\r\n [ 0.00000000e+00, 9.99978481e-01, 2.15185386e-05],\r\n [ 0.00000000e+00, 9.99993136e-01, 6.86428459e-06],\r\n [ 1.20030529e-01, 0.00000000e+00, 8.79969471e-01],\r\n [ 1.13183668e-01, 0.00000000e+00, 8.86816332e-01],\r\n [ 6.75506225e-02, 0.00000000e+00, 9.32449377e-01],\r\n [ 1.07273496e-01, 0.00000000e+00, 8.92726504e-01],\r\n [ 1.26854747e-01, 0.00000000e+00, 8.73145253e-01],\r\n [ 1.16881976e-01, 0.00000000e+00, 8.83118024e-01],\r\n [ 2.45077442e-04, 9.99754923e-01, 0.00000000e+00],\r\n [ 2.70475201e-04, 9.99729525e-01, 0.00000000e+00],\r\n [ 6.59523734e-04, 9.99340476e-01, 0.00000000e+00],\r\n [ 4.07574999e-04, 9.99592425e-01, 0.00000000e+00],\r\n [ 2.42451670e-03, 9.97575483e-01, 0.00000000e+00],\r\n [ 2.03959503e-03, 9.97960405e-01, 0.00000000e+00]])\r\n```\r\nNotice how there are \"zeroed out\" columns.\r\n\r\nAnd even worse:\r\n\r\n```python\r\nfrom sklearn.model_selection import cross_val_predict, KFold\r\nfrom sklearn.datasets import load_iris\r\nfrom sklearn.linear_model import LogisticRegression\r\n\r\nX, y = load_iris(True)\r\ncross_val_predict(LogisticRegression(), X, y, cv=KFold().split(X), method='decision_function')\r\n```\r\nreturns (array cut down in size)\r\n```\r\narray([[ 0. , 0. , -11.31746426],\r\n [ 0. , 0. , -10.20969263],\r\n [ 0. , 0. , -10.42178776],\r\n [ 0. , 0. , -9.60397656],\r\n [ 0. , 0. , -11.30005126],\r\n [ 0. , 0. , -11.1906238 ],\r\n [ 0. , 0. , -10.05510072],\r\n [ 0. , 0. , -10.74657422],\r\n [ 0. , 0. , -9.20295991],\r\n [ 0. , 8.3136912 , 0. ],\r\n [ 0. , 6.77281268, 0. ],\r\n [ 0. , 7.79874366, 0. ],\r\n [ 0. , 7.29615134, 0. ],\r\n [ 0. , 7.9199709 , 0. ],\r\n [ 0. , 9.163118 , 0. ],\r\n [ 0. , 5.8858718 , 0. ],\r\n [ 0. , 6.37425957, 0. ],\r\n [ 0. , 6.66261924, 0. ],\r\n [ 0. , 6.19296233, 0. ]])\r\n```\r\nwhich is hardly of use to anyone.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->",
"title": "[WIP] Fix cross_val_predict behavior for binary classification in decision_function (Fixes #9589)",
"type": "issue"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323743822,
"datetime": 1503322023000,
"masked_author": "username_1",
"text": "I think better not to error in the context of using this in ClassifierChain or a stacking meta-estimator.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323749514,
"datetime": 1503323712000,
"masked_author": "username_0",
"text": "NaN makes it clearer that these columns weren't considered at all for this particular split, but wouldn't that break things? For instance, I frequently use `np.argmax(cross_val_predict(..., method='predict_proba))` to recover the true labels for calculating accuracy, etc. Of course, I always make sure my folds are stratified so I'm probably not going to face it, but still.. Also, wouldn't that break ClassifierChains and stacking meta-estimators?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323870974,
"datetime": 1503355162000,
"masked_author": "username_1",
"text": "yes, nan would probably break it all. a warning is probably a good idea.\nBut first we need to fix the regression.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323921155,
"datetime": 1503378845000,
"masked_author": "username_0",
"text": "I've added the necessary unit tests.\r\n\r\nAlthough at this point, I'd like to point out there's another regression for the case of SVC with `decision_function_shape=ovo`\r\n\r\nCode to test:\r\n```python\r\nfrom sklearn.datasets import load_digits\r\nfrom sklearn.svm import SVC\r\nfrom sklearn.model_selection import cross_val_predict\r\n\r\nX, y = load_digits(return_X_y=True)\r\ncross_val_predict(SVC(kernel='linear', decision_function_shape='ovo'), X, y, method='decision_function').shape\r\n```\r\n\r\n**Expected Results**\r\nIn previous versions, this is `(1797, 45)`\r\n\r\n**Actual Results**\r\n```\r\nValueError: shape mismatch: value array of shape (602,45) could not be broadcast to indexing result of shape (10,602)\r\n```\r\n\r\nThis error is due to the shape of an SVC decision function with `decision_function_shape` set to `'ovr'` which is `(n_samples, n_classes * (n_classes-1) / 2)`\r\n\r\nShould I include the fix in this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323945416,
"datetime": 1503387659000,
"masked_author": "username_1",
"text": "Thanks. Maybe fix that in a separate PR unless they're going to step on\neach others' toes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323989642,
"datetime": 1503398748000,
"masked_author": "username_0",
"text": "Hi @username_1, I changed this back to WIP since there was a conflict with a recent merge. I also figured out a better fix that also fixes the SVC \"ovo\" regression.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323989752,
"datetime": 1503398776000,
"masked_author": "username_1",
"text": "Okay. Let me know when it's MRG, i.e. ready for review.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 324014866,
"datetime": 1503405930000,
"masked_author": "username_0",
"text": "@username_1 Ready for review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 324057852,
"datetime": 1503414774000,
"masked_author": "username_0",
"text": "Yup, sorry. Added unit test and addressed comments.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 325999056,
"datetime": 1504101555000,
"masked_author": "username_2",
"text": "A solution to some more of this will be in #9532 but that will probably still take a while.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326031443,
"datetime": 1504107640000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326031684,
"datetime": 1504107683000,
"masked_author": "username_2",
"text": "This is the case when some classifiers have 1 class and some have 2 classes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326042552,
"datetime": 1504109866000,
"masked_author": "username_0",
"text": "Got it. Didn't know some classifiers could be fit on a single class. So that's *another* regression. How do you want to handle this case? It sounds similar to the case `if method == 'decision_function' and len(estimator.classes_) == 2`, which is currently handled by doing `predictions_[:, estimator.classes_[-1]] = predictions`.\r\n\r\nIf that's fine, I think the fix is to simply change the former line to `if method == 'decision_function' and len(estimator.classes_) <= 2`.\r\n\r\nThis would fix the errors, but frankly, I'd still prefer a stern warning that something went wrong during cross-validation using `cross_val_predict`.\r\n\r\nFor the ovo case, should I include that in this PR as well? I didn't include it previously since this PR primarily fixes regressions and I didn't want to include a new \"feature\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326045716,
"datetime": 1504110575000,
"masked_author": "username_2",
"text": "Not sure if the 1 class thing is a regression or was always broken ;)\r\nAnd I think I'd like the error / test for OVO in this PR.\r\n\r\nSorry, I don't understand your proposal for the 1class / 2class case. The result in the 2 class case should be 1d, not 2d. That's the original bug this is trying to solve, right?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326048935,
"datetime": 1504111277000,
"masked_author": "username_0",
"text": "The case I'm talking about is when the original dataset has >2 classes, and a particular fold is <=2 *and* the method is `decision_function`. The original bug is still fixed by the `if n_classes != len(estimator.classes_):` check.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326050223,
"datetime": 1504111545000,
"masked_author": "username_2",
"text": "Ah. My breaking example is with the dataset having two classes, and some folds have one class.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326054741,
"datetime": 1504112458000,
"masked_author": "username_0",
"text": "You're right. It's not a regression, but another edge case that needs to be fixed. Yes, we should add an explicit check that `n_classes > 2` but only if the method used is `decision_function`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326349959,
"datetime": 1504196799000,
"masked_author": "username_0",
"text": "@username_2 I've added both the error for OvO and the fix for a dataset having two classes, and some folds having one class. Added unit tests for both.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327260698,
"datetime": 1504635709000,
"masked_author": "username_0",
"text": "@username_1 Addressed comments. Failure in Appveyor appears from an unrelated test.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327699214,
"datetime": 1504765388000,
"masked_author": "username_0",
"text": "I'm not sure why an unrelated test in `sklearn.neighbors` is failing in Appveyor when the only difference in the commit that caused the failure is a few comments and additional unit tests.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 327705902,
"datetime": 1504767536000,
"masked_author": "username_1",
"text": "That appears to be a very rare failure at random. I'll fix that test and restart appveyor.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327755133,
"datetime": 1504778720000,
"masked_author": "username_0",
"text": "Finally green. Thanks! Ready for review.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 332542212,
"datetime": 1506522978000,
"masked_author": "username_2",
"text": "Ok, I think if one fold only contains one class, we should probably just error becaus it's a bit unclear to me what is supposed to happen. And this is such a weird edge-case that I don't think we should hold 0.19.1 for that.\r\n\r\nFor the if-else thing in the decision function case: maybe just add some comments? right now I find the code hard to read. But seems ok to me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332619872,
"datetime": 1506538219000,
"masked_author": "username_0",
"text": "@username_2 I've addressed your comments. So, ready for review again.\r\n\r\nThe test failures are due to something unrelated again..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332705569,
"datetime": 1506564094000,
"masked_author": "username_0",
"text": "@username_2 addressed your comments. Ready for review again.\r\n\r\nThe test failures seem to be due to something unrelated again...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 332710191,
"datetime": 1506566012000,
"masked_author": "username_1",
"text": "Add a blank commit and the failures should go away due to a patch in master",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332788289,
"datetime": 1506592589000,
"masked_author": "username_0",
"text": "So.. something failed. But again, I have no idea what...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 332841282,
"datetime": 1506606399000,
"masked_author": "username_3",
"text": "You can see that this is lgtm failing (google it if you want to know more what lgtm does). For some reason it has done that recently, not sure why but you don't need to worry about this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 333735039,
"datetime": 1507004590000,
"masked_author": "username_1",
"text": "I'll add a what's new entry when throwing it into 0.19.1, to avoid having it incorrectly in 0.20",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335178848,
"datetime": 1507560062000,
"masked_author": "username_3",
"text": "I looked at this for a bit, my main comment: with your change it seems like we are not very consistent when we ave a training fold which does not have all the training labels present in the complete dataset:\r\n* if prediction.ndim == 2, which I think for method='decision_function' means `len(est.classes_) >= 3`, we raise an error saying use a proper stratification technique\r\n* if prediction.ndim < 2, which I think for method='decision_function' means `len(est.classes_) <= 2`, we do not raise an error.\r\n\r\nAlso it seems like the fix for cross_val_predict in binary classification as reported in #9589 is actually moving the from the logic from https://github.com/scikit-learn/scikit-learn/pull/7889 in a `if n_classes != len(estimator.classes_)`. I would like to take a closer look at this to understand better whether this is the right thing to do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335187932,
"datetime": 1507561928000,
"masked_author": "username_0",
"text": "I don't think there is ever a case when `decision_function` returns `predictions.ndim == 2`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335418355,
"datetime": 1507628373000,
"masked_author": "username_3",
"text": "You are right, I read the code too quickly, which to my defence is a bit tricky to follow.\r\n\r\nI am not convinced we are doing the right thing when we don't have all the classes in the training fold (for example setting decision function to 0 in the missing classes does not seem right).\r\nOne way to avoid the problem would be to raise an error when we don't have all the classes in the training fold? Is there a reason why we don't do this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335421814,
"datetime": 1507629188000,
"masked_author": "username_0",
"text": "Yup, I agree this does not make sense.\r\n\r\nPerhaps what we could do is keep the special imbalanced handling code only for `predict_proba` and error out when it is imbalanced for `decision_function`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335425268,
"datetime": 1507629983000,
"masked_author": "username_1",
"text": "The problem is that it does just happen in practice, when some classes are\ninfrequent. It might not make sense for decision_function to assume some\narbitrary value but it does make sense to zero out a column in\npredict_proba.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335426165,
"datetime": 1507630215000,
"masked_author": "username_0",
"text": "How about erroring out imbalanced classes in `decision_function` but zeroing out columns in `predict_proba` and `log_predict_proba`? Literally all the complication in this PR is because of the different weird ways `decision_function` behaves.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335426250,
"datetime": 1507630240000,
"masked_author": "username_1",
"text": "Essentially all we do in that case is make it harder for people to do the\nsame analysis on a highly imbalanced classification problem that they do\nwith a balanced one, which in turn makes it harder for people to provide\ngeneric ML tools built on top of our library.\n\nOne example, again, is stacking.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335427204,
"datetime": 1507630483000,
"masked_author": "username_1",
"text": "I suppose that is, at least, more principled, and I can accept that. (And\nby that I mean erroring for decision_function but not for\npredict_{log_}proba).\n\nYes, these quirks and edge cases are annoying to deal with. But I feel like\nsometimes it's our role as a library provider to handle them as best we\ncan, and raise an error only when the user has done something wrong or at\nleast very rare. I don't think this falls under very rare.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335473669,
"datetime": 1507642411000,
"masked_author": "username_3",
"text": "I read a bit the discussion in the related PRs, sorry it's taking me some time to catch up. Basically here is my summary:\r\n\r\n* I would be a favour of a warning when the training fold does not contain all the classes. https://github.com/scikit-learn/scikit-learn/pull/8773#issuecomment-330362879 agrees with that as well.\r\n* the fix for the wrong shape in cross_validation_predict with method=decision_function (which consists in only applying the logic from #7889 when `n_classes != n_classes_train`) is fine\r\n* `method='decision_function'` has a number of edge cases. Raising an exception for `method='decision_function'` if `n_classes_train != n_classes` may be an easy way to avoid tackling all these special cases.\r\n 1. SVC with ovo with uncommon number of columns for decision function `n_classes_train * (n_classes_train - 1) / 2` rather than `n_classes`. Tackled in this PR already.\r\n 2. `n_classes_train <= 2` and `n_classes >= 3`, you get a 1d array as the output of decision_function and then it is not clear what to do with it. I would be in favour of raising an exception in this case.\r\n 3. `n_classes_train == 1` and `n_classes == 2`. No idea what to do in this case. I don't know how common this is for classifier to be able to be fittable with a single class and have decision_function. I quickly looked using all_estimators and I found `['AdaBoostClassifier', 'LinearDiscriminantAnalysis', 'RidgeClassifier', 'RidgeClassifierCV']`.\r\n* predictions should be initialized to 0 if `method='predict_proba'` but `-inf` (or maybe `np.finfo(X.dtype).min`) if `method='predict_log_proba'`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335477729,
"datetime": 1507643230000,
"masked_author": "username_0",
"text": "There is another case for `decision_function`\r\n\r\niv. `n_classes_train > 2` and `n_classes > 2` but `n_classes_train < n_classes`. Currently we set missing classes to 0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335698632,
"datetime": 1507704113000,
"masked_author": "username_3",
"text": "For decision_function either we do the same as predict_log_proba or we decide that we always raise an exception, given that there are many edge cases for decision_function ...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335800354,
"datetime": 1507726575000,
"masked_author": "username_0",
"text": "I think I've mostly sorted this out. For a non-special case of `decision_function` (`iv. n_classes_train > 2 and n_classes > 2 but n_classes_train != n_classes.`), I do the same as `predict_log_proba`. For the other special cases, there is an error message. \r\n\r\nApologies for the confusing code previously, I should've done it this way in the first place, but I didn't expect `decision_function` to have so many edge cases.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 337407829,
"datetime": 1508282875000,
"masked_author": "username_1",
"text": "I would like to see this merged and 0.19.1 released by the end of the week. Is that reasonable, @username_2?",
"title": null,
"type": "comment"
}
] | 5 | 44 | 16,588 | false | true | 16,588 | true |
JohnSundell/Marathon | null | 232,606,889 | 81 | null | [
{
"action": "opened",
"author": "johndpope",
"comment_id": null,
"datetime": 1496244937000,
"masked_author": "username_0",
"text": "➜ Desktop marathon help add\r\n📦 add\r\n------\r\nAdd a package from a given URL to be able to use it from your scripts\r\n\r\n👉 Usage: 'marathon add <url-or-path-to-package>'\r\n\r\nℹ️ You can also use a 'Marathonfile' to automatically add packages. See https://github.com/johnsundell/marathon for more information",
"title": "clarification on adding / (if it not possible - letting user know) specific tags of repos in marathon add",
"type": "issue"
},
{
"action": "created",
"author": "johndpope",
"comment_id": 305226494,
"datetime": 1496244995000,
"masked_author": "username_0",
"text": "eg. want to add tag 0.0.1\r\n marathon add https://github.com/username_0/swift-grpc-tensorflow.git \r\n\r\nhttps://github.com/username_0/swift-grpc-tensorflow/tree/0.0.1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JohnSundell",
"comment_id": 305245497,
"datetime": 1496248838000,
"masked_author": "username_1",
"text": "Version pinning is not yet supported, but it's something that we do want to add support for. I added this issue: https://github.com/username_1/Marathon/issues/82 to keep track of this new feature, so feel free to put any comments/suggestions you might have in there 🙂 Closing this in favor of the linked issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JohnSundell",
"comment_id": null,
"datetime": 1496248838000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 777 | false | false | 777 | true |
jonathantribouharet/JTCalendar | null | 172,977,491 | 292 | null | [
{
"action": "opened",
"author": "roadst3r",
"comment_id": null,
"datetime": 1472051176000,
"masked_author": "username_0",
"text": "I've been trying to get the current month from JTCalendar manager without any success.\r\nIts easy when the user touches a day, but I want to update my own label, when user swipes the month.\r\nThere are 2 methods: calendarDidLoadNextPage & calendarDidLoadPreviousPage, that are triggered when user swipe the month or week, but after that, I cant get the month date from anywhere, visible month date, not selected one.\r\n\r\nAny ideas?",
"title": "Struggling with a way to get current month/week on screen.",
"type": "issue"
},
{
"action": "created",
"author": "jneiluj",
"comment_id": 253986709,
"datetime": 1476540785000,
"masked_author": "username_1",
"text": "Use date from calendar.date in the 2 delegates (or calendarManager.date) and not dateSelected saved in - (void)calendar:(JTCalendarManager *)calendar didTouchDayView:(JTCalendarDayView *)dayView;",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jonathantribouharet",
"comment_id": null,
"datetime": 1483494786000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jonathantribouharet",
"comment_id": 270276485,
"datetime": 1483494786000,
"masked_author": "username_2",
"text": "Just like that `[_calendarManager date];`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brunotereso-acceptto",
"comment_id": 270276804,
"datetime": 1483494946000,
"masked_author": "username_3",
"text": "I don't have the code with me right now, but from what I remember [_calendarManager date] was updated after choosing a day.\r\nMy problem was getting the month while swiping the calendar without choosing any day.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roadst3r",
"comment_id": 270276991,
"datetime": 1483495035000,
"masked_author": "username_0",
"text": "I don't have the code with me right now, but from what I remember [_calendarManager date] was updated after choosing a day.\r\nMy problem was getting the month while swiping the calendar without choosing any day.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantribouharet",
"comment_id": 270278130,
"datetime": 1483495565000,
"masked_author": "username_2",
"text": "The manager is just a proxy for the date in `JTHorizontalCalendarView` which is updated in continuous during the scroll. Check again and come back if you still have the problem.",
"title": null,
"type": "comment"
}
] | 4 | 7 | 1,261 | false | false | 1,261 | false |
tensorics/tensorics-core | tensorics | 118,232,658 | 3 | null | [
{
"action": "opened",
"author": "kaifox",
"comment_id": null,
"datetime": 1448156262000,
"masked_author": "username_0",
"text": "Instead, it should be possible to e.g. use an interface as a dimension.",
"title": "Dimension should not be limited to lowermost classes",
"type": "issue"
},
{
"action": "created",
"author": "agorzawski",
"comment_id": 248386820,
"datetime": 1474395516000,
"masked_author": "username_1",
"text": "Please check the test defined in the **CoordinatesOnInterfacesTest.class.** It is Simplified (only Double Tensor one) but covering the main issues we have. I will start investigating/coding slowly, fell free to change the test on **interface-in-dimension branch**.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michi42",
"comment_id": 254839273,
"datetime": 1476889155000,
"masked_author": "username_2",
"text": "fixed by #8",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "michi42",
"comment_id": null,
"datetime": 1476889159000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 347 | false | false | 347 | false |
slamdata/purescript-halogen | slamdata | 71,598,613 | 98 | null | [
{
"action": "opened",
"author": "cryogenian",
"comment_id": null,
"datetime": 1430229856000,
"masked_author": "username_0",
"text": "How do you think is it possible to add pseudoattributes for `HTML` like `clicked`, `focused` etc? And if it setted to `true` generate an event. Can be helpful to change focus or select texts.",
"title": "Generate events",
"type": "issue"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97210197,
"datetime": 1430255957000,
"masked_author": "username_1",
"text": "It should be fairly simple to implement these in terms of `init`, no?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97213108,
"datetime": 1430256433000,
"masked_author": "username_0",
"text": "Erm... Could you give a clue how to do it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97244323,
"datetime": 1430259836000,
"masked_author": "username_1",
"text": "Something like\r\n\r\n```purescript\r\nH.div [ A.init if shouldClick then yield ThingToDoOnClick else empty ] []\r\n```\r\n\r\n?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97245161,
"datetime": 1430260165000,
"masked_author": "username_0",
"text": "Do you mean `initializer`? I can't find `A.init`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97245321,
"datetime": 1430260229000,
"masked_author": "username_1",
"text": "Yes, sorry.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97246814,
"datetime": 1430260831000,
"masked_author": "username_0",
"text": "I mean not to do something that we do when events are fired, but to fire those events. In example `e.focus()` or `e.select()`. I'm afraid it can be done only by `Widget`'s `init` not `A.initializer`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97247179,
"datetime": 1430260974000,
"masked_author": "username_1",
"text": "Sorry, I was thinking of the jQuery-style, where `el.click()` means \"generate a click event\", and assumed you just wanted to generate the input to the state machine without a click from the user. Maybe we do need #89 after all...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97295904,
"datetime": 1430278847000,
"masked_author": "username_1",
"text": "Can we do this with hooks?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97308260,
"datetime": 1430284517000,
"masked_author": "username_1",
"text": "@username_3 @username_0 I've put an (untested) sketch of a possible solution on the `hooks` branch. I think we can use this to define custom attributes like `focus`. I don't have time to work on this any more tonight, but I can take a look tomorrow if this approach looks ok.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97868023,
"datetime": 1430411148000,
"masked_author": "username_1",
"text": "Here's a thought. What if you used a data attribute, and we did an effectful pass over the DOM after each render, to apply any custom attributes, using jQuery or `simple-dom`? I could add a hook to `runUI`, and it would probably be cleaner than hook attributes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97870133,
"datetime": 1430411474000,
"masked_author": "username_2",
"text": "That might be an option, but manipulating the DOM outside of virtual dom can really be asking for trouble when you're not doing it with hooks, widgets, etc. Or is that what you meant by using the data attribute? Use that as a marker for \"make change here\"?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97872723,
"datetime": 1430411930000,
"masked_author": "username_1",
"text": "Pretty much. The case I was thinking of was focussing a text box. We could set a `data-should-focus` attribute, and then use jQuery to focus or blur that element if necessary after rendering.\r\n\r\nWe could do the same thing with a hook in an attribute, defining\r\n\r\n```purescript\r\nfocussed :: Boolean -> Attr\r\nfocussed = attr \"halogen-hook-focussed\" <<< makeFocusHook\r\n\r\nmakeFocusHook :: Boolean -> Hook\r\nmakeFocusHook = hook ...\r\n```\r\n\r\nI have a sketch of the second approach in the `hooks2` branch.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97874326,
"datetime": 1430412230000,
"masked_author": "username_2",
"text": "Sounds reasonable to me.\r\n\r\nThat general method is pretty much how I proposed widget initialisation should work in one of the many other discussions - although with the machinery hidden somehow. The idea being then we can delay init until the node exists, has size, etc.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97875658,
"datetime": 1430412483000,
"masked_author": "username_1",
"text": "Sorry, which one?\r\n\r\nImplementing widgets with the data-attribute approach seems possible, and even preferable, if we can cram arbitrary data into a data-attribute using `virtual-dom`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97882011,
"datetime": 1430413299000,
"masked_author": "username_2",
"text": "Well it's something I did in a JS project, so it might not translate directly, but the idea was using a hook that registered a \"update me\" request on `hook`, and then after render those requests were all processed. The registration part in that case was done with a global array, so that wouldn't quite be the way to handle it, but perhaps a data-attribute could be used to similar effect.\r\n\r\nIn my case it was for triggering animations on elements rather than doing anything widgety, but it seemed potentially workable?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jdegoes",
"comment_id": 97942132,
"datetime": 1430422914000,
"masked_author": "username_3",
"text": "Note that this is really a symptom of the more general information flow problem I've been ranting about: which is that it's not possible to emit messages from an SF; rather, the SF can only emit stateless, declarative HTML, which is leading to questionable hacks like this (not that I have a good way of solving it, just remarking on why this issue is arising and why information is being forced through pseudo-attributes -- because that's the only way to get event-oriented information out).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 98011853,
"datetime": 1430442000000,
"masked_author": "username_1",
"text": "It seems what you're referring to is really a limitation of `virtual-dom`, or even React, or just the general \"generate a pure virtual DOM element and patch\" approach, unless I'm missing something.\r\n\r\nAnyway, I want to nail this down so that I can implement something this weekend. Given everyone's current experience, which do we prefer?\r\n\r\n- Support for hook-valued attributes\r\n- Data attributes and support for custom post-render hooks\r\n\r\nThere's no reason we can't support both of course, but I think it would be good to pick one and stick with it. I prefer the second, since I think it actually subsumes the current widget implementation, and it is closer in spirit to the \"push effects to the boundary\" approach.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jdegoes",
"comment_id": 98168574,
"datetime": 1430496934000,
"masked_author": "username_3",
"text": "I defer to @username_2, @username_0, and @puffnfresh, as they're the ones who have to use this. :smile:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 98349759,
"datetime": 1430566542000,
"masked_author": "username_2",
"text": "Custom post-render hooks seem like they'll be more useful given the requirements of widgets and Bootstrap-style functionality decorators, so my vote goes to the data attribute approach too.\r\n\r\nSomething to keep in mind is we need to preserve those when manually setting values via `dataSet`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 98522600,
"datetime": 1430679143000,
"masked_author": "username_1",
"text": "I think this is handled by #106, shall I close?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cryogenian",
"comment_id": null,
"datetime": 1430717705000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 22 | 4,837 | false | false | 4,837 | true |
aspnet/Hosting | aspnet | 126,418,773 | 567 | null | [
{
"action": "opened",
"author": "davidfowl",
"comment_id": null,
"datetime": 1452692058000,
"masked_author": "username_0",
"text": "We have `IWebApplicationBuilder`, `WebApplicationBuilder`, `IWebApplication`, and `IApplicationBuilder`.\r\n\r\n`IApplicationBuilder` looks related to `IWebApplicationBuilder` but they are not. \r\n\r\nToday:\r\n\r\n\r\n```C#\r\nvar host = new WebHostBuilder()\r\n .UseServer(\"Microsoft.AspNet.Server.Kestrel\")\r\n .UseUrls(\"http://localhost:5001\")\r\n .UseStartup<Startup>()\r\n .Build();\r\n\r\nhost.Run();\r\n```\r\n\r\nPotential:\r\n\r\n```C#\r\nvar app = new WebApplicationBuilder()\r\n .UseServer(\"Microsoft.AspNet.Server.Kestrel\")\r\n .UseUrls(\"http://localhost:5001\")\r\n .UseStartup<Startup>()\r\n .Build();\r\n\r\napp.Run();\r\n```",
"title": "Consider changing WebApplication* to WebHost*",
"type": "issue"
},
{
"action": "created",
"author": "Tratcher",
"comment_id": 171301621,
"datetime": 1452694305000,
"masked_author": "username_1",
"text": "I do agree there's ambiguity between IWebApplicationBuilder and IApplicationBuilder.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171502219,
"datetime": 1452737378000,
"masked_author": "username_0",
"text": "Shall we go with host instead of application then?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Tratcher",
"comment_id": 171516529,
"datetime": 1452740699000,
"masked_author": "username_1",
"text": "You're with @DamianEdwards right? Did he have anything to say on the subject?\r\n\r\nI think it's fine, but I don't envy @username_5 having to touch all the repos again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171518301,
"datetime": 1452741722000,
"masked_author": "username_0",
"text": "Yes, we spoke about this today and concluded that it looks like WebApplication was wrong.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171584312,
"datetime": 1452763665000,
"masked_author": "username_2",
"text": "Would that mean also changing WebApplicationConfiguration to WebHostConfiguration?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171584767,
"datetime": 1452763802000,
"masked_author": "username_0",
"text": "@username_2 yes re: `WebHostConfiguration`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171585401,
"datetime": 1452763997000,
"masked_author": "username_2",
"text": "@username_0 \r\n```\r\nWebHostBuilder\r\nWebHostConfiguration\r\n```\r\nvs\r\n```\r\nWebHostingBuilder\r\nWebHostingConfiguration\r\n```\r\nThe later seems slightly more abstracted to me",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171585729,
"datetime": 1452764094000,
"masked_author": "username_0",
"text": "I dunno what you mean by more abstracted. I prefer:\r\n\r\nI prefer a `WebHostBuilder` that builds a `WebHost` using `WebHostConfiguration`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171586586,
"datetime": 1452764351000,
"masked_author": "username_2",
"text": "WebHost is fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171586737,
"datetime": 1452764409000,
"masked_author": "username_0",
"text": "PS: @username_5 I'm sorry dude, that's alot of repos to update :disappointed:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171593695,
"datetime": 1452765989000,
"masked_author": "username_2",
"text": "WebHostConfiguration would read hosting.json seems a mismatch\r\nWebHostingConfiguration would seem a more logically. match..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171594575,
"datetime": 1452766259000,
"masked_author": "username_0",
"text": "But we're going to call it `WebHostConfiguration` so it matches the other names. We're splitting hairs and naming is hard but that's what we're calling it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aL3891",
"comment_id": 172204116,
"datetime": 1452949529000,
"masked_author": "username_3",
"text": "Maybe hosting.json could be host.json? (or webhost.json)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "henkmollema",
"comment_id": 172260852,
"datetime": 1452981415000,
"masked_author": "username_4",
"text": "`hosting.json` configures the hosting API. Webhost is just a part of that. It's not like we're renaming the repo to Webhost.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172418370,
"datetime": 1453089119000,
"masked_author": "username_5",
"text": "Marking as done since rename has been merged to dev and all repos have been updated. Will post announcement after monitoring test pass and close issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GuardRex",
"comment_id": 172424019,
"datetime": 1453091941000,
"masked_author": "username_6",
"text": "... according to @username_1 https://github.com/aspnet/IISIntegration/issues/52#issuecomment-171444840",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 172620732,
"datetime": 1453142834000,
"masked_author": "username_2",
"text": "@username_5 \r\nLooks like aspnet/Security is failing after this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 172624161,
"datetime": 1453143852000,
"masked_author": "username_0",
"text": "What is failing?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 172626295,
"datetime": 1453144463000,
"masked_author": "username_2",
"text": "Microsoft.AspNet.Authentication.Test \r\n\r\nI noticed because I have a pull request for FacebookMiddleware\r\n\r\n```\r\n[00:05:14] Compiling \r\n[00:05:14] Microsoft.AspNet.Authentication.Test\r\n[00:05:14] for \r\n[00:05:14] DNX,Version=v4.5.1\r\n[00:05:14] \r\n[00:05:17] \u001b[1m\u001b[31mC:\\projects\\security\\test\\Microsoft.AspNet.Authentication.Test\\test\\Microsoft.AspNet.Authentication.Test\\Twitter\\TwitterMiddlewareTests.cs(155,31): error CS0246: The type or namespace name 'WebHostBuilder' could not be found (are you missing a usi\r\n[00:05:17] ng directive or an assembly reference?)\r\n[00:05:17] \r\n[00:05:17] \r\n[00:05:17] Compilation failed.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172683272,
"datetime": 1453160533000,
"masked_author": "username_5",
"text": "@username_2 I think your packages may be out of date and updating to the newest packages should fix the problem. @username_6 I don't know how feasible listing all the versions is since many packages were affected. I will look into it but at least the renames will impact Microsoft.AspNet.Hosting rc2-16237 or later for sure.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JunTaoLuo",
"comment_id": null,
"datetime": 1453168089000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172703513,
"datetime": 1453168089000,
"masked_author": "username_5",
"text": "Seems like test pass will be broken for other reasons. Since I did not see any test failures relating to this change, I'm closing the issue for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 172743492,
"datetime": 1453181554000,
"masked_author": "username_0",
"text": ":clap:",
"title": null,
"type": "comment"
}
] | 7 | 24 | 3,561 | false | false | 3,561 | true |
sckott/usdaplantsapi | null | 259,891,798 | 11 | null | [
{
"action": "opened",
"author": "sckott",
"comment_id": null,
"datetime": 1506103178000,
"masked_author": "username_0",
"text": "@username_1 curious if you've seen a newer dump of the database?",
"title": "new dump perhaps",
"type": "issue"
},
{
"action": "created",
"author": "dlebauer",
"comment_id": 331580132,
"datetime": 1506121632000,
"masked_author": "username_1",
"text": "Nope. It seems pretty stable. Not sure how frequently it is updated. You can get updated dumps in the advanced search page. I quickly tried it just now and wasn't getting any results.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sckott",
"comment_id": 331583913,
"datetime": 1506123717000,
"masked_author": "username_0",
"text": "okay, thx",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sckott",
"comment_id": null,
"datetime": 1597419438000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 254 | false | false | 254 | true |
asascience-open/ooi-ui | asascience-open | 169,127,466 | 780 | {
"number": 780,
"repo": "ooi-ui",
"user_login": "asascience-open"
} | [
{
"action": "opened",
"author": "Bobfrat",
"comment_id": null,
"datetime": 1470229796000,
"masked_author": "username_0",
"text": "@DanielJMaher goes along with https://github.com/asascience-open/ooi-ui-services/pull/519",
"title": "Keep color checked on and disabled always",
"type": "issue"
},
{
"action": "created",
"author": "oceanzus",
"comment_id": 237253448,
"datetime": 1470234648000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 93 | false | false | 93 | false |
phpstan/phpstan | phpstan | 201,990,838 | 94 | null | [
{
"action": "opened",
"author": "hkdobrev",
"comment_id": null,
"datetime": 1484863966000,
"masked_author": "username_0",
"text": "When a class has a `__toString()` method, an instance of it should be able to be passed to a method expecting a string.\r\n\r\nPlease let me know if this sounds right.\r\n\r\nI currently get an error like that with level 5:\r\n\r\n```\r\nParameter #1 $expression of method Foo::parse() expects string, Expression given.\r\n```\r\nWhere\r\n```php\r\nclass Expression\r\n{\r\n public function __toString()\r\n {\r\n // ...\r\n }\r\n}\r\n```",
"title": "Accept classes with __toString() method as valid string arguments",
"type": "issue"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 273933227,
"datetime": 1484869021000,
"masked_author": "username_1",
"text": "You're right, this can be correctly handled how you suggested. It hasn't been until now because I consider using `__toString` to be a not very good programming practice. It's very limiting - what if an object has two or more possible string representations? Like \"First name Last name\" or \"Last Name, First name\"? Also, `__toString` cannot throw exception. The only acceptable `__toString` usage is for debugging purposes. So your entities could probably implement something like this:\r\n\r\n```\r\npublic function __toString()\r\n{\r\n return get_class($this) . '#' . $this->getId();\r\n}\r\n```\r\n\r\nPassing an object where only string is accepted is often a mistake rather than an intent. But I agree that this should be allowed by default with a possible stricter setting to reject it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hkdobrev",
"comment_id": 273939215,
"datetime": 1484871068000,
"masked_author": "username_0",
"text": "@username_1 I agree with all of your remarks, but when you are trying to use PHPStan to detect problems in a legacy system which has a ton of classes already using `__toString()`, this should be covered. Also when you are dealing with 3rd party libraries which use such patterns, it's only sensible to detect this by default.\r\n\r\nAlso some people coming from different languages may say this is their preferred practice of writing classes. Even if it's not OOP. The same logic applies in part for `Countable`, `ArrayAccess`, `Iterable` and `Traversable` but with them we at least have interfaces and a more documented and a sensible way of doing things.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 273994105,
"datetime": 1484896543000,
"masked_author": "username_1",
"text": "I agree. PHPStan cannot be opinionated since it's for finding bugs, so it\nwill accept objects with __toString in places where string belongs by\ndefault :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 274287352,
"datetime": 1485031743000,
"masked_author": "username_1",
"text": "Fixed with https://github.com/phpstan/phpstan/commit/254def88b153eb9dfa8ceab4a92eed92ccab8ca2.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ondrejmirtes",
"comment_id": null,
"datetime": 1485031744000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 2,097 | false | false | 2,097 | true |
rubygems/rubygems | rubygems | 51,710,797 | 1,098 | null | [
{
"action": "opened",
"author": "zeljkofilipin",
"comment_id": null,
"datetime": 1418317012000,
"masked_author": "username_0",
"text": "For example, mediawiki_selenium gem reports warnings when building the gem. Code example from commit [172518](https://gerrit.wikimedia.org/r/#/c/172518/):\r\n\r\n```\r\n$ gem build mediawiki_selenium.gemspec\r\nWARNING: open-ended dependency on redcarpet (>= 0, development) is not\r\nrecommended\r\n if redcarpet is semantically versioned, use:\r\n add_development_dependency 'redcarpet', '~> 0'\r\nWARNING: open-ended dependency on yard (>= 0, development) is not\r\nrecommended\r\n if yard is semantically versioned, use:\r\n add_development_dependency 'yard', '~> 0'\r\nWARNING: See http://guides.rubygems.org/specification-reference/ for\r\nhelp\r\n Successfully built RubyGem\r\n Name: mediawiki_selenium\r\n Version: 0.4.1\r\n File: mediawiki_selenium-0.4.1.gem\r\n```\r\n\r\nI would like for the jenkins job that builds the gem to fail if there are any warnings. Looking at [gem build](http://guides.rubygems.org/command-reference/#gem-build) documentation, I do not see a way for the build to fail if there are any warnings.\r\n\r\nWhat I am looking for is something like this:\r\n\r\n```\r\n$ gem build mediawiki_selenium.gemspec --strict\r\nWARNING: open-ended dependency on redcarpet (>= 0, development) is not\r\nrecommended\r\n if redcarpet is semantically versioned, use:\r\n add_development_dependency 'redcarpet', '~> 0'\r\n...\r\nGem build failed because of warnings.\r\n```\r\n\r\nI have [asked](http://help.rubygems.org/discussions/questions/8986-can-gem-build-fail-if-there-are-_any_-warnings) at help.rubygems.org and got the answer to file a bug here.",
"title": "Can \"gem build\" fail if there are _any_ warnings?",
"type": "issue"
},
{
"action": "created",
"author": "djberg96",
"comment_id": 145888848,
"datetime": 1444144181000,
"masked_author": "username_1",
"text": "I like the idea, but wonder if this would be better suited as a plugin.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "segiddins",
"comment_id": 145901171,
"datetime": 1444145320000,
"masked_author": "username_2",
"text": "You can manually load up the gem spec and validate it for packaging in the interim, and I have an open PR to disallow warnings that I need to finish up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drbrain",
"comment_id": 145950803,
"datetime": 1444155146000,
"masked_author": "username_3",
"text": "It needs to be built-in, otherwise projects that build gems through API (not `gem build`) can't take advantage of it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "djberg96",
"comment_id": 145953966,
"datetime": 1444155795000,
"masked_author": "username_1",
"text": "@username_3 Ok, sounds alright to me, then.\r\n\r\n@username_0 we just need a PR now. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drbrain",
"comment_id": 145954633,
"datetime": 1444155877000,
"masked_author": "username_3",
"text": "There's #1335 by @username_2 that is in-progress",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "copiousfreetime",
"comment_id": 180596027,
"datetime": 1454710849000,
"masked_author": "username_4",
"text": "Calling this as a duplicate of #1334",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "copiousfreetime",
"comment_id": null,
"datetime": 1454710849000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 8 | 2,033 | false | false | 2,033 | true |
SpoonX/aurelia-orm | SpoonX | 143,861,804 | 62 | {
"number": 62,
"repo": "aurelia-orm",
"user_login": "SpoonX"
} | [
{
"action": "opened",
"author": "kellyethridge",
"comment_id": null,
"datetime": 1459122937000,
"masked_author": "username_0",
"text": "This update has a hard-coded set for exactly one import. This may become fragile depending on how often you change the API.",
"title": "Excluded imports except ValidationRule in generating d.ts files.",
"type": "issue"
},
{
"action": "created",
"author": "kellyethridge",
"comment_id": 202170521,
"datetime": 1459123165000,
"masked_author": "username_0",
"text": "This pull-request probably shouldn't be accepted until after the removal of the spoonx prefix is applied.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 202318969,
"datetime": 1459157078000,
"masked_author": "username_1",
"text": "why is the validation import needed while the other external imports are not?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 202347525,
"datetime": 1459164757000,
"masked_author": "username_2",
"text": "@username_1 Because we provide a custom validator. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 202953050,
"datetime": 1459265235000,
"masked_author": "username_1",
"text": "@username_0 right. that place is giving me pain. i suggest to add a like 'dts-builder-options.js' file (where and like paths.js) and get an array of additional importsToAdd from there. (you might need to rebase first)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 204269982,
"datetime": 1459492480000,
"masked_author": "username_1",
"text": "yes. :+1: that's good. lets merge those commits to make it look nicer in the commit log. (reset to branching point (--mixed which is default to keep changes). add what should be in new version, commit and force push)\r\n\r\nfor command line that'll be :\r\n```sh\r\ngit reset 9e84f30\r\ngit add build/*\r\ngit commit -m \"fix(d.ts): include only necessary imports\"\r\ngit push -f origin HEAD\r\n```\r\ngulp util and a new build isn't needed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 204306618,
"datetime": 1459499263000,
"masked_author": "username_2",
"text": "@username_0 That's one beautiful commit you have there :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 204306780,
"datetime": 1459499313000,
"masked_author": "username_2",
"text": "Two tiny comments in the same file. After that, you have my :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 204650124,
"datetime": 1459575176000,
"masked_author": "username_1",
"text": "nice work !!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kellyethridge",
"comment_id": 204667913,
"datetime": 1459582892000,
"masked_author": "username_0",
"text": ":+1: thanks guys. It's been a fun learning experience.",
"title": null,
"type": "comment"
}
] | 3 | 10 | 1,191 | false | false | 1,191 | true |
boonproject/boon | boonproject | 56,049,415 | 294 | null | [
{
"action": "opened",
"author": "patient-zero",
"comment_id": null,
"datetime": 1422633077000,
"masked_author": "username_0",
"text": "I struggled trying to figure out why I could not override encoding of a java.net.InetAddress, and finally realized that TypeType was recognizing it as SYSTEM, which always uses the unknown serializer, i.e. the toString() method. It would be better to lift this limitation, otherwise types like Java 8 Time representations, InetAddress and lots of other reasonable things to override will need to be wrapped.",
"title": "system types cannot be overridden with custom serializers",
"type": "issue"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 73315254,
"datetime": 1423257926000,
"masked_author": "username_1",
"text": "Ok.. I will consider that. I think I want to handle InetAddress the right way.. not sure what that is yet.\r\n\r\nBoon is still in Java 7 land, but I will try to figure out how to support Java 8 Time in Java 7 in a way so you can use Boon with Java 8 even though it is still in Java 7. \r\n\r\nI have been working on QBit a lot lately. I need to come back to Boon and fix some of these things.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 85250883,
"datetime": 1427154829000,
"masked_author": "username_1",
"text": "Do you have the code where you attempted to install a custom serializer that failed?\r\nI will use that as the test case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kyle-downey",
"comment_id": 85256776,
"datetime": 1427156361000,
"masked_author": "username_2",
"text": "If you remove setUseAnnotations(true) it will not work.\r\n\r\n JsonSerializerFactory jsonSerializerFactory = new JsonSerializerFactory()\r\n .setAsciiOnly(true)\r\n .setUseAnnotations(true)\r\n .addTypeSerializer(PasswordHolder.class, new AbstractCustomObjectSerializer<PasswordHolder>(PasswordHolder.class) {\r\n @Override\r\n public void serializeObject(JsonSerializerInternal serializer, PasswordHolder instance, CharBuf builder) {\r\n builder.addQuoted(instance.getPassword());\r\n }\r\n })\r\n .usePropertyOnly();",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 85257062,
"datetime": 1427156522000,
"masked_author": "username_1",
"text": "I think you meant that comment for the other issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kyle-downey",
"comment_id": 85452353,
"datetime": 1427195244000,
"masked_author": "username_2",
"text": "Migrated comment to #292",
"title": null,
"type": "comment"
}
] | 3 | 6 | 1,645 | false | false | 1,645 | false |
mapbox/carto | mapbox | 161,277,524 | 449 | null | [
{
"action": "opened",
"author": "springmeyer",
"comment_id": null,
"datetime": 1466451857000,
"masked_author": "username_0",
"text": "```\r\n1) JS linting eslint should have no errors in lib:\r\n Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.\r\n ```\r\n\r\n@username_1 looks like you added this test: https://github.com/mapbox/carto/commit/1421611d619e093af463bdc09a88683aa5249ca9. Can you think through a solution such that travis runs stay green? I presume the problem is that linking takes too long on the slow travis machines.\r\n\r\nPossible solutions I see:\r\n\r\n - 1) Flip to `sudo:false` at https://github.com/mapbox/carto/blob/master/.travis.yml#L3 to access more powerful travis machines. Using `sudo:false` broke things mysteriously before, but it likely doable with a little effort to figure out what broke\r\n - 2) Increase the timeout length\r\n - 3) Move linting out of the tape tests and move to a `pretest` target.\r\n\r\n#3 would be my preference, but no strong opinion.",
"title": "Travis failures",
"type": "issue"
},
{
"action": "created",
"author": "nebulon42",
"comment_id": 227564774,
"datetime": 1466541613000,
"masked_author": "username_1",
"text": "Right, I'll have a look.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nebulon42",
"comment_id": null,
"datetime": 1481464908000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 906 | false | false | 906 | true |
nfl/glitr | nfl | 195,044,816 | 6 | null | [
{
"action": "opened",
"author": "tinnou",
"comment_id": null,
"datetime": 1481566106000,
"masked_author": "username_0",
"text": "Glitr scans domains however some domains might exist outside of the graph but we could still need them in the GraphQL schema.\r\n\r\nAdd GLiTR configuration time, offer the ability to add additional Java types for inspection.\r\n\r\nExample:\r\nFor instance types A and B could implement an interface C that is discovered by GLiTR. Types A and B being never referenced elsewhere will not be inspected by GLiTR.",
"title": "Have a way to add additional types that are outside of the visited domain graph",
"type": "issue"
},
{
"action": "created",
"author": "tinnou",
"comment_id": 269697645,
"datetime": 1483047571000,
"masked_author": "username_0",
"text": "Here is an example on how to add types after initiation of the `Glitr` instance.\r\n\r\n```\r\n Glitr glitr = GlitrBuilder.newGlitr()\r\n .withRelay()\r\n .withQueryRoot(new Viewer())\r\n .withMutationRoot(mutation)\r\n .withObjectMapper(configureGlitrObjectMapper())\r\n .build();\r\n // Man and Cyborg implement the Person interface but they haven't been discovered by GLiTR\r\n // we can ask for additional lookup\r\n glitr.getTypeRegistry().lookup(Man.class);\r\n glitr.getTypeRegistry().lookup(Cyborg.class);\r\n // make sure to reload the GraphQL Schema for the changes to take effect\r\n glitr.reloadSchema(Viewer.class, mutation.getClass());\r\n```\r\n\r\nSee this [test](https://github.com/nfl/glitr/commit/851eda6a31e7b68a81afbf3db4b342371555dc18#diff-72b0c7662755b3a4b8379243cc511df4R13) for a full example.\r\n\r\nAs a side note, we could add the option to register additional types in the builder. We will come back to it in the future when needed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tinnou",
"comment_id": null,
"datetime": 1483047571000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 1,447 | false | false | 1,447 | false |
fugacious/fugacious | fugacious | 172,547,676 | 63 | {
"number": 63,
"repo": "fugacious",
"user_login": "fugacious"
} | [
{
"action": "opened",
"author": "adelevie",
"comment_id": null,
"datetime": 1471897942000,
"masked_author": "username_0",
"text": "",
"title": "fix spacing in message.rb",
"type": "issue"
},
{
"action": "created",
"author": "jgrevich",
"comment_id": 246256748,
"datetime": 1473660129000,
"masked_author": "username_1",
"text": "Thanks. Alan!",
"title": null,
"type": "comment"
}
] | 3 | 3 | 298 | false | true | 13 | false |
akofman/cordova-plugin-add-swift-support | null | 219,748,589 | 27 | null | [
{
"action": "opened",
"author": "chrisdurfee",
"comment_id": null,
"datetime": 1491436443000,
"masked_author": "username_0",
"text": "iTunes connect is refusing to allow builds to be uploaded in the application loader due to a missing \"SwiftSupport\" folder. I have included the plugin in my project but it still doesn't add the necessary swift files to allow it to be added to itunes. \r\n\r\niTunes error: \r\n\r\n'We have discovered one or more issues with your recent delivery for \"app name\". To process your delivery, the following issues must be corrected: \r\nInvalid Swift Support - The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it. \r\nOnce these issues have been corrected, you can then redeliver the corrected binary. \r\nRegards,'",
"title": "Invalid Swift Support iTunes Error",
"type": "issue"
},
{
"action": "created",
"author": "jelkevdh",
"comment_id": 305025628,
"datetime": 1496182887000,
"masked_author": "username_1",
"text": "Have the same issue :(",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akofman",
"comment_id": 313742015,
"datetime": 1499447941000,
"masked_author": "username_2",
"text": "Hello guys, what version of `XCode` are you using ? Are you uploading your app from `XCode` or `Application Loader` ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdurfee",
"comment_id": 318917825,
"datetime": 1501437101000,
"masked_author": "username_0",
"text": "I'm using cocoon.io to cloud compile. They won't specify what version of xcode they use but I assume it recent. After i upload the iPad to the iTunes connect through application loader using xcode.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akofman",
"comment_id": 318939970,
"datetime": 1501459801000,
"masked_author": "username_2",
"text": "hmmm maybe you don't use the last version of this plugin (1.7.0) ?\r\nThe previous versions were not compatible with the most recent xcode.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yogeshwar238",
"comment_id": 344247039,
"datetime": 1510663223000,
"masked_author": "username_3",
"text": "I am also facing the same issue. \r\nAny help is much appreciated.",
"title": null,
"type": "comment"
}
] | 4 | 6 | 1,197 | false | false | 1,197 | false |
nolimits4web/Swiper | null | 56,712,996 | 1,084 | null | [
{
"action": "opened",
"author": "soupking",
"comment_id": null,
"datetime": 1423162705000,
"masked_author": "username_0",
"text": "Hi username_1,\r\n\r\nI'm trying to build a page where the first slide slides halfway upon swipe and subsequent slides swipe underneath the first slide all sliding left horizontally. I see you have a vertical slider inside your horizontal nested slider demo but when the mode is altered it doesn't recognize it separately from the main one. Is there another attribute I need to turn off/on for this to happen?\r\n\r\nAlso is it possible to have slide images stop fixed at a certain value? Those are the two things I need to sort out to build this thing.\r\n\r\nThanks for any suggestions.",
"title": "Is it possible to build a horizontal nested Swiper inside another?",
"type": "issue"
},
{
"action": "created",
"author": "nolimits4web",
"comment_id": 73362588,
"datetime": 1423312543000,
"masked_author": "username_1",
"text": "No, it is impossible to have nested horizontal in horizontal",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nolimits4web",
"comment_id": null,
"datetime": 1423686484000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "IllyaMoskvin",
"comment_id": 196377524,
"datetime": 1457970538000,
"masked_author": "username_2",
"text": "Apparently, it is possible now? You have to set `nested: true` for the configuration of the inner slider. Here, I modified the [nested swiper demo](http://idangero.us/swiper/demos/11-nested.html) from the main site so that the inner slider is horizontal, not vertical. Check out this fiddle: https://jsfiddle.net/imoskvin/s0fm20m6/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pkuczynski",
"comment_id": 250601752,
"datetime": 1475185906000,
"masked_author": "username_3",
"text": "Another example of an alternative nested swiper: https://jsfiddle.net/imoskvin/s0fm20m6/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "but1head",
"comment_id": 294359928,
"datetime": 1492359225000,
"masked_author": "username_4",
"text": "it is impossible for horizontal parent and freeMode nested?",
"title": null,
"type": "comment"
}
] | 6 | 7 | 1,265 | false | true | 1,116 | true |
nokiatech/heif | null | 266,424,403 | 25 | null | [
{
"action": "opened",
"author": "anbysure",
"comment_id": null,
"datetime": 1508319228000,
"masked_author": "username_0",
"text": "This is error log. please help me,thank you.\r\n\r\n[root@baseline build]# cmake ..\r\n-- The C compiler identification is GNU 4.4.7\r\n-- The CXX compiler identification is GNU 4.4.7\r\n-- Check for working C compiler: /usr/bin/cc\r\n-- Check for working C compiler: /usr/bin/cc -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Check for working CXX compiler: /usr/bin/c++\r\n-- Check for working CXX compiler: /usr/bin/c++ -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- System name : Linux\r\n-- Project Name : HEIF\r\n-- Project directory : /home/heif\r\n-- Executables in : /home/heif/Bins\r\n-- File-list : \r\n-- Performing Test COMPILER_SUPPORTS_CXX11\r\n-- Performing Test COMPILER_SUPPORTS_CXX11 - Failed\r\n-- Performing Test COMPILER_SUPPORTS_CXX0X\r\n-- Performing Test COMPILER_SUPPORTS_CXX0X - Success\r\n-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) \r\n-- Configuring done\r\n-- Generating done\r\n-- Build files have been written to: /home/heif/build\r\n[root@baseline build]# make\r\n/usr/bin/cmake -H/home/heif -B/home/heif/build --check-build-system CMakeFiles/Makefile.cmake 0\r\n/usr/bin/cmake -E cmake_progress_start /home/heif/build/CMakeFiles /home/heif/build/CMakeFiles/progress.marks\r\nmake -f CMakeFiles/Makefile2 all\r\nmake[1]: Entering directory `/home/heif/build'\r\nmake -f Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build.make Srcs/parser/h265parser/CMakeFiles/h265parser.dir/depend\r\nmake[2]: Entering directory `/home/heif/build'\r\ncd /home/heif/build && /usr/bin/cmake -E cmake_depends \"Unix Makefiles\" /home/heif /home/heif/Srcs/parser/h265parser /home/heif/build /home/heif/build/Srcs/parser/h265parser /home/heif/build/Srcs/parser/h265parser/CMakeFiles/h265parser.dir/DependInfo.cmake --color=\r\nScanning dependencies of target h265parser\r\nmake[2]: Leaving directory `/home/heif/build'\r\nmake -f Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build.make Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build\r\nmake[2]: Entering directory `/home/heif/build'\r\n/usr/bin/cmake -E cmake_progress_report /home/heif/build/CMakeFiles 65\r\n[ 1%] Building CXX object Srcs/parser/h265parser/CMakeFiles/h265parser.dir/h265parser.cpp.o\r\ncd /home/heif/build/Srcs/parser/h265parser && /usr/bin/c++ -std=c++0x -Wall -Wextra -Werror -Wno-missing-field-initializers -I/home/heif/Srcs/common -I/home/heif/Srcs/parser -o CMakeFiles/h265parser.dir/h265parser.cpp.o -c /home/heif/Srcs/parser/h265parser/h265parser.cpp\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In destructor ‘virtual H265Parser::~H265Parser()’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:38: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected ‘;’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected ‘;’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘;’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘)’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘;’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In member function ‘bool H265Parser::initDisplayOrderArray(const char*)’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:109: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:116: error: could not convert ‘std::sort [with _RAIter = __gnu_cxx::__normal_iterator<ParserInterface::PicOrder*, std::vector<ParserInterface::PicOrder, std::allocator<ParserInterface::PicOrder> > >, _Compare = bool (*)(const ParserInterface::PicOrder&, const ParserInterface::PicOrder&)](picOrder.std::vector<_Tp, _Alloc>::begin [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>](), picOrder.std::vector<_Tp, _Alloc>::end [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>](), ParserInterface::compareDecodeOrder)’ to ‘bool’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:122: error: could not convert ‘picOrder.std::vector<_Tp, _Alloc>::clear [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>]()’ to ‘bool’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected ‘)’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected ‘;’ before ‘}’ token\r\ncc1plus: warnings being treated as errors\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:86: error: unused variable ‘displayNum’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In member function ‘bool H265Parser::hasVpsExtension()’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:147: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected primary-expression at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘;’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected primary-expression at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘)’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected statement at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:146: error: unused variable ‘hasExtension’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘}’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: no return statement in function returning non-void\r\nmake[2]: *** [Srcs/parser/h265parser/CMakeFiles/h265parser.dir/h265parser.cpp.o] Error 1\r\nmake[2]: Leaving directory `/home/heif/build'\r\nmake[1]: *** [Srcs/parser/h265parser/CMakeFiles/h265parser.dir/all] Error 2\r\nmake[1]: Leaving directory `/home/heif/build'\r\nmake: *** [all] Error 2",
"title": "build fail in Centos 6.5",
"type": "issue"
},
{
"action": "created",
"author": "guoying1030",
"comment_id": 346562238,
"datetime": 1511427911000,
"masked_author": "username_1",
"text": "you must upgrad gcc and g++ to 4.8",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jieweijasson",
"comment_id": 363365680,
"datetime": 1517909976000,
"masked_author": "username_2",
"text": "请问我在centos7上编译通过了，生成了可执行文件，下一步怎么让.heic格式的图片转为jpeg格式？谢谢",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nokiatech",
"comment_id": 371476688,
"datetime": 1520513095000,
"masked_author": "username_3",
"text": "Code requires C++11 support from compiler.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nokiatech",
"comment_id": null,
"datetime": 1520513095000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 7,606 | false | false | 7,606 | false |
appcelerator/amp | appcelerator | 172,890,111 | 59 | null | [
{
"action": "opened",
"author": "ndegory",
"comment_id": null,
"datetime": 1472026109000,
"masked_author": "username_0",
"text": "Main issue is that when the Kafka input fails, the telemetry worker doesn't exit, because there's at least one input that is working correctly. the netstat plugin (enabled by default in the image) should be explicitely removed from the telemetry worker.",
"title": "netstat metrics from telemetry workers appeared in influxdb",
"type": "issue"
},
{
"action": "closed",
"author": "freignat91",
"comment_id": null,
"datetime": 1472026423000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 253 | false | false | 253 | false |
clawpack/clawpack | clawpack | 191,415,364 | 94 | {
"number": 94,
"repo": "clawpack",
"user_login": "clawpack"
} | [
{
"action": "opened",
"author": "mandli",
"comment_id": null,
"datetime": 1479951456000,
"masked_author": "username_0",
"text": "See PRs in the sub-repositories for details:\r\n - clawpack/amrclaw#178\r\n - clawpack/geoclaw#232\r\n - clawpack/clawutil#106\r\n - clawpack/classic#75",
"title": "Adds gauge output options",
"type": "issue"
},
{
"action": "created",
"author": "rjleveque",
"comment_id": 263167812,
"datetime": 1480298996000,
"masked_author": "username_1",
"text": "Will be replaced by a new PR.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 173 | false | false | 173 | false |
auth0/repo-supervisor | auth0 | 240,170,774 | 7 | null | [
{
"action": "opened",
"author": "glenjamin",
"comment_id": null,
"datetime": 1499088023000,
"masked_author": "username_0",
"text": "/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:13199\r\n result[value] = key;\r\n ^\r\n\r\nTypeError: Cannot convert object to primitive value\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:13199:21\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3209:9\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:4944:15\r\n at baseForOwn (/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3001:24)\r\n at baseInverter (/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3208:7)\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:5247:16\r\n at e.exports (/Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:3646)\r\n at /Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:2281\r\n at Array.forEach (native)\r\n at Object.processFile (/Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:2148)\r\n```",
"title": "Crashes with \"Cannot convert object to primitive value\"",
"type": "issue"
},
{
"action": "created",
"author": "radekk",
"comment_id": 314787693,
"datetime": 1499869894000,
"masked_author": "username_1",
"text": "I tried to reproduce this issue successfully. It does trigger an error when you scan the current directory of repo-supervisor project.\r\n\r\nIt's caused by `node_modules/globals/globals.json` file which is a standard JSON file but it breaks `invert()` function from `lodash` module. I already filled an issue for mentioned library, depending on that I will decide what to do further.\r\n\r\nReported issue: https://github.com/lodash/lodash/issues/3260",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "radekk",
"comment_id": null,
"datetime": 1499983541000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,508 | false | false | 1,508 | false |
KnpLabs/FriendlyContexts | KnpLabs | 217,327,387 | 227 | null | [
{
"action": "opened",
"author": "Nek-",
"comment_id": null,
"datetime": 1490637821000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI think we should consider to add a configuration \"by feature\" and enable (or not) features with this configuration. (just like it's done in the FrameworkBundle of Symfony !)\r\n\r\nThis would fix #225.\r\n\r\nI already start to work on the topic. Stop me if you think it's a wrong idea :) .",
"title": "[RFC] Disable features by default",
"type": "issue"
},
{
"action": "created",
"author": "Einenlum",
"comment_id": 289695678,
"datetime": 1490688628000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 297 | false | false | 297 | false |
YoKeyword/Fragmentation | null | 269,873,030 | 619 | null | [
{
"action": "opened",
"author": "andy91310",
"comment_id": null,
"datetime": 1509438340000,
"masked_author": "username_0",
"text": "`Caused by: android.content.res.Resources$NotFoundException: File res/anim/h_fragment_exit.xml from xml type anim resource ID #0x7f050012\r\n\tat android.content.res.Resources.loadXmlResourceParser(Resources.java:3743)\r\n\tat android.content.res.Resources.loadXmlResourceParser(Resources.java:3690)\r\n\tat android.content.res.Resources.getAnimation(Resources.java:2165)\r\n\tat android.view.animation.AnimationUtils.loadAnimation(AnimationUtils.java:71)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.initExitAnim(AnimatorHelper.java:75)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.notifyChanged(AnimatorHelper.java:30)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.<init>(AnimatorHelper.java:24)\r\n\tat me.yokeyword.fragmentation.SupportFragmentDelegate.onCreate(SupportFragmentDelegate.java:108)\r\n\tat me.yokeyword.fragmentation.SupportFragment.onCreate(SupportFragment.java:48)\r\n\tat com.ftt.app.ui.fragment.BaseMvpFragment.onCreate(BaseMvpFragment.java:18)\r\n\tat android.support.v4.app.Fragment.performCreate(Fragment.java:2339)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1377)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)\r\n\tat android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:794)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)\r\n\tat android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)\r\n\tat android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3221)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3171)\r\n\tat android.support.v4.app.Fragment.performActivityCreated(Fragment.java:2369)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1442)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1809)\r\n\tat android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:799)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)\r\n\tat android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)\r\n\tat android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3221)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3171)\r\n\tat android.support.v4.app.FragmentController.dispatchActivityCreated(FragmentController.java:192)\r\n\tat android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:560)\r\n\tat android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:177)\r\n\tat android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1178)\r\n\tat android.app.Activity.performStart(Activity.java:5321)\r\n\tat android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2292)\r\n\t... 11 more`",
"title": "这个错误是因为什么呢？",
"type": "issue"
},
{
"action": "created",
"author": "YoKeyword",
"comment_id": 340729095,
"datetime": 1509447706000,
"masked_author": "username_1",
"text": "描述下发生异常的环境\r\n\r\n偶现还是必现？ 线上环境还是开发环境？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andy91310",
"comment_id": 340962600,
"datetime": 1509504235000,
"masked_author": "username_0",
"text": "线上环境呢，目前只发现一个在三星4.4.4的手机上。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "YoKeyword",
"comment_id": null,
"datetime": 1509523956000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "YoKeyword",
"comment_id": 341029740,
"datetime": 1509523956000,
"masked_author": "username_1",
"text": "如果发生在开发环境，一般clean下即可；\r\n\r\n你的情况是只发生在线上该机型，并只有一次的话，可以忽略， 毕竟Android系统也会抽风 ＝，＝",
"title": null,
"type": "comment"
}
] | 2 | 5 | 3,564 | false | false | 3,564 | false |
PurpleI2P/i2pd | PurpleI2P | 157,320,747 | 504 | null | [
{
"action": "opened",
"author": "radfish",
"comment_id": null,
"datetime": 1464411534000,
"masked_author": "username_0",
"text": "i2pd is probably using the bind address in the URL. This works if the bind address is 127.0.0.1 and browser is on same host, or if bind is the local LAN address and browser is on LAN, but is not correct if bind address is 0.0.0.0.\r\n\r\nInstead, i2pd should get the hostname from headers sent by the browser in its requests. Then, use this hostname whenever it has to construct a URL.",
"title": "HTTP proxy redirects to 0.0.0.0:7070/?page=jumpservices",
"type": "issue"
},
{
"action": "created",
"author": "orignal",
"comment_id": 222302544,
"datetime": 1464432814000,
"masked_author": "username_1",
"text": "It's not in a header, it should take it from local endpoint",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hagen-i2p",
"comment_id": 222572142,
"datetime": 1464656926000,
"masked_author": "username_2",
"text": "It's temporary solution, proxy refactoring still in process.\r\n\r\nJumservices should be moved directly to proxy error page. Instead \"addressbook\" page should be added to webconsole.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xcps",
"comment_id": 228488058,
"datetime": 1466810871000,
"masked_author": "username_3",
"text": "I made a temporary solution.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "xcps",
"comment_id": null,
"datetime": 1466812093000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 647 | false | false | 647 | false |
civisanalytics/go-makefile | civisanalytics | 131,730,957 | 1 | {
"number": 1,
"repo": "go-makefile",
"user_login": "civisanalytics"
} | [
{
"action": "opened",
"author": "christophermanning",
"comment_id": null,
"datetime": 1454700051000,
"masked_author": "username_0",
"text": "",
"title": "Add Code of Conduct",
"type": "issue"
},
{
"action": "created",
"author": "jeffreyc",
"comment_id": 180517647,
"datetime": 1454701144000,
"masked_author": "username_1",
"text": "LGTM.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 5 | false | false | 5 | false |
keras-team/keras | keras-team | 271,189,411 | 8,385 | null | [
{
"action": "opened",
"author": "danhper",
"comment_id": null,
"datetime": 1509799418000,
"masked_author": "username_0",
"text": "I have a model with two inputs, each encoded using different embeddings.\r\nWhen I do not used pretrained weights, I get the expected graph:\r\n\r\n\r\n\r\n\r\nWhen I use pretrained weights, the graph has an unexpected edge between the LSTM of the first input and the embedding of the second one:\r\n\r\n\r\nI think `lstm_1` and `embedding_2` should not be connected here.\r\n\r\n`model.summary` does not give any information about this connection either:\r\n\r\n```\r\n\r\nLayer (type) Output Shape Param # Connected to\r\n==================================================================================================\r\ninput_1 (InputLayer) (None, 50) 0\r\n\r\ninput_2 (InputLayer) (None, 50) 0\r\n\r\nembedding_1 (Embedding) (None, 50, 10) 1000 input_1[0][0]\r\n\r\nembedding_2 (Embedding) (None, 50, 10) 1000 input_2[0][0]\r\n\r\nlstm_1 (LSTM) (None, 100) 44400 embedding_1[0][0]\r\n\r\nlstm_2 (LSTM) (None, 100) 44400 embedding_2[0][0]\r\n\r\nconcatenate_1 (Concatenate) (None, 200) 0 lstm_1[0][0]\r\n lstm_2[0][0]\r\n\r\ndense_1 (Dense) (None, 64) 12864 concatenate_1[0][0]\r\n\r\ndense_2 (Dense) (None, 1) 65 dense_1[0][0]\r\n==================================================================================================\r\nTotal params: 103,729\r\nTrainable params: 103,729\r\nNon-trainable params: 0\r\n\r\n```\r\n\r\nHere is a small example reproducing the issue:\r\n\r\n```python\r\nimport numpy as np\r\n\r\nfrom keras.models import Input, Model\r\nfrom keras.layers import Embedding, LSTM, Dense, concatenate\r\nfrom keras.callbacks import TensorBoard\r\n\r\nPRETRAINED = True\r\n\r\ndef make_encoder():\r\n model_input = Input(shape=(50,), dtype=\"int32\")\r\n weights = [np.random.uniform(size=(100, 10))] if PRETRAINED else None\r\n x = Embedding(100, 10, weights=weights)(model_input)\r\n x = LSTM(100)(x)\r\n return model_input, x\r\n\r\ninput1, output1 = make_encoder()\r\ninput2, output2 = make_encoder()\r\n\r\nx = concatenate([output1, output2])\r\nx = Dense(64)(x)\r\nmain_output = Dense(1, activation=\"sigmoid\")(x)\r\n\r\nmodel = Model(inputs=[input1, input2], outputs=main_output)\r\nmodel.compile(optimizer=\"rmsprop\",\r\n loss=\"binary_crossentropy\",\r\n metrics=[\"accuracy\"])\r\n\r\ndata1 = np.random.randint(0, 100, size=(100, 50))\r\ndata2 = np.random.randint(0, 100, size=(100, 50))\r\ntargets = np.random.randint(0, 2, size=(100,))\r\n\r\nmodel.summary()\r\nmodel.fit([data1, data2], targets, callbacks=[TensorBoard()])\r\n```\r\n\r\nchanging `PRETRAINED` to `False` gives the correct graph.\r\n\r\nThe issue occurs with the latest version of Keras and both Tensorflow 1.3 and 1.4.\r\nAfter trying older versions of Keras, the issue seems to be present from 2.0.4.\r\nKeras 2.0.3 gives the expected graph. \r\n\r\nPlease let me know if I am missing something.\r\n\r\nThank you.",
"title": "Wrong graph with pretrained embeddings",
"type": "issue"
},
{
"action": "closed",
"author": "fchollet",
"comment_id": null,
"datetime": 1624573319000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 3,242 | false | false | 3,242 | false |
soffes/RateLimit | null | 109,363,250 | 15 | {
"number": 15,
"repo": "RateLimit",
"user_login": "soffes"
} | [
{
"action": "opened",
"author": "AnthonyMDev",
"comment_id": null,
"datetime": 1443726471000,
"masked_author": "username_0",
"text": "When the `execute` method is called, but the block was not called, because the rate limit had not been reached, the execution time was still being recorded. This would cause the block to never be called if the `execute` method was continually called too quickly. The execution time should only be recorded on a successful execution.",
"title": "Fixed bug where limit was being reset when the block was not executed",
"type": "issue"
},
{
"action": "created",
"author": "AnthonyMDev",
"comment_id": 144823060,
"datetime": 1443727566000,
"masked_author": "username_0",
"text": "I just realized that this is also fixed by #13, I think the syntax for fixing this bug is slightly cleaner in this PR. Also, #16 depends on this PR, so if you plan on pulling #16, you can actually just close this and #13.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "soffes",
"comment_id": 255173853,
"datetime": 1476984777000,
"masked_author": "username_1",
"text": "Thanks so much! Reworked a bit to make sure accessing the dictionary happens in the queue to avoid threading race conditions.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 678 | false | false | 678 | false |
cloudfoundry/bosh-utils | cloudfoundry | 209,084,190 | 13 | {
"number": 13,
"repo": "bosh-utils",
"user_login": "cloudfoundry"
} | [
{
"action": "opened",
"author": "Fydon",
"comment_id": null,
"datetime": 1487668767000,
"masked_author": "username_0",
"text": "As mentioned in #10 there is still a problem when using rename across drives in Windows. This error occurs when using `bosh-cli add-blobs`.",
"title": "Move across drives in Windows",
"type": "issue"
},
{
"action": "created",
"author": "cppforlife",
"comment_id": 300630679,
"datetime": 1494455207000,
"masked_author": "username_1",
"text": "@fydon can you please add a windows specific mover_test.go",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Fydon",
"comment_id": 300703518,
"datetime": 1494486893000,
"masked_author": "username_0",
"text": "@username_1 Sure I can try. How would I go about doing this across two drives? I assume that these would need to be real, rather than fake_file_system?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cppforlife",
"comment_id": 301640758,
"datetime": 1494894297000,
"masked_author": "username_1",
"text": "@username_0 i think it will be fine to use fake file sys just like we do for other branches in this class: https://github.com/cloudfoundry/bosh-utils/blob/master/fileutil/mover_test.go#L48",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Fydon",
"comment_id": 301725721,
"datetime": 1494926630000,
"masked_author": "username_0",
"text": "@username_1 Sure. I copied that context and its tests and used the Windows specific error. Are those tests correct?",
"title": null,
"type": "comment"
}
] | 3 | 6 | 814 | false | true | 647 | true |
aspnet/Home | aspnet | 107,359,660 | 936 | null | [
{
"action": "opened",
"author": "ahmetalpbalkan",
"comment_id": null,
"datetime": 1442702808000,
"masked_author": "username_0",
"text": "https://github.com/aspnet/Home/tree/dev/samples/latest\r\n\r\nthis is not the latest one... the ENTRYPOINT in the dockerfile is simply wrong (pre-beta7).\r\n\r\nPlease use symlinks to point to the latest... someone already got confused by this at https://github.com/aspnet/aspnet-docker/issues/92\r\n\r\nI would like to also remind you that you should have a release document with well defined steps. The human errors around the `samples/` directory is just very frequent. @username_1 @danroth27 @Eilon",
"title": "samples/latest is not really the latest",
"type": "issue"
},
{
"action": "created",
"author": "glennc",
"comment_id": 142692851,
"datetime": 1443033718000,
"masked_author": "username_1",
"text": "Latest isn't a copy of one of the existing Betas, it is supposed to update as we make breaking changes and then be effectively snapshotted as we do a release, so I'm not sure I understand where symlinks come in. Am I missing something?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetalpbalkan",
"comment_id": 142698572,
"datetime": 1443034920000,
"masked_author": "username_0",
"text": "@username_1 so instead of copying all the contents of `samples/1.0.0-betaN` into `samples/latest` in each release, you can make a symlink and at each release change the symlink to the latest version's directory.\r\n\r\nSo the current snapshot of `samples/latest` is this: https://github.com/aspnet/Home/tree/615efcc78e813d52b513adb412d8757e9bf011a4/samples/latest It is older than beta7 (hence does not work in beta7 due to breaking changes) and the user at #92 practically got confused by the instructions in the documentation saying \"use samples/latest\"... If the `samples/latest` directory was indeed \"latest\" this wouldn't be happening.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tlk",
"comment_id": 142733822,
"datetime": 1443043488000,
"masked_author": "username_2",
"text": "Have you considered using git branches?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetalpbalkan",
"comment_id": 142735591,
"datetime": 1443043826000,
"masked_author": "username_0",
"text": "I think folders are easier to navigate and we already have tags for snapshotting purposes. I feel -1 for multile branches as discovering them and navigation is pretty difficult.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glennc",
"comment_id": 142739417,
"datetime": 1443044697000,
"masked_author": "username_1",
"text": "The copy is supposed to be the other way around. Latest is copied to beta8 when beta8 is released.\r\n\r\nLatest is supposed to be maintained as we make breaking changes. So it always works with * dependencies. It doesn't appear that it has been in this release which is really the problem here.\r\n\r\nWe had branches in the past and it was too confusing for people to navigate. They didn't know what to do. However, latest might be a bad name as well. dev or nightly or something might give more of an idea of its intent.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetalpbalkan",
"comment_id": 142740800,
"datetime": 1443045100000,
"masked_author": "username_0",
"text": ":+1: also the instructions are saying users should use latest folder to build the docker image, but the base image Dockerfile uses is a stable image (ie previous version) so if there's a breaking change it is very likely users will hit problems if they use \"latest\" samples. Calling them \"nightly\" and not sending users there from the documentation is a good idea.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glennc",
"comment_id": 143070185,
"datetime": 1443135117000,
"masked_author": "username_1",
"text": "I looked at what is required of the Dockerfile for latest and sent a PR with changes I think will work. Can you guys have a look and tell me if I'm crazy?\r\n\r\nI can't see how the old Dockerfile would've ever been ok for what latest is.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetalpbalkan",
"comment_id": 143070413,
"datetime": 1443135212000,
"masked_author": "username_0",
"text": "@username_1 looks neat, if you have verified it works, then it should be fine :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glennc",
"comment_id": 143070763,
"datetime": 1443135292000,
"masked_author": "username_1",
"text": "I run it on my machine. Not sure why we ever did the copy of the project.json then copy the rest and run. That seems less than optimal. I will update the other sample and it should be good.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glennc",
"comment_id": 143278439,
"datetime": 1443199921000,
"masked_author": "username_1",
"text": "Merged. Closing. Thanks for reporting and talking about this one all :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "glennc",
"comment_id": null,
"datetime": 1443199921000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 12 | 3,020 | false | false | 3,020 | true |
galetahub/ckeditor | null | 95,105,348 | 591 | null | [
{
"action": "opened",
"author": "ccfiel",
"comment_id": null,
"datetime": 1436935620000,
"masked_author": "username_0",
"text": "I have tried to used s3 in uploading files. The file was successfully uploaded in the s3 bucket but the link that the ckeditor is not correct. \r\nckeditor url is this\r\nhttps://s3.amazonaws.com/tinda/var/app/current/public/ckeditor_assets/pictures/6/content_untitled.png\r\nbut it should be \r\nhttps://tinda.s3.amazonaws.com/var/app/current/public/ckeditor_assets/pictures/6/content_untitled.png\r\n\r\n\r\nany ideas?",
"title": "using AWS s3 for upload files",
"type": "issue"
},
{
"action": "created",
"author": "cytomich",
"comment_id": 121517682,
"datetime": 1436945896000,
"masked_author": "username_1",
"text": "@username_0 which gem you use for store files? paperclip, carrierwave or dragonfly?\r\nMaybe problem in asset model options?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ccfiel",
"comment_id": 121518633,
"datetime": 1436946069000,
"masked_author": "username_0",
"text": "@username_1 Solve the problem. You are right. I just change the attachment_file and picture model options.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ccfiel",
"comment_id": null,
"datetime": 1436946070000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "bo-oz",
"comment_id": 234524547,
"datetime": 1469188363000,
"masked_author": "username_2",
"text": "Could you share how you fixed this? I have the same issue with CKEditor & Paperclip.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Duleja",
"comment_id": 327775180,
"datetime": 1504784590000,
"masked_author": "username_3",
"text": "Try this for Picture model:\r\n\r\nhas_attached_file :data,\r\n :url => \":s3_alias_url\",\r\n :path => 'ckeditor/pictures/:id/:style_:basename.:extension',\r\n :styles => { content: '800>', thumb: '118x100#' },\r\n :s3_host_alias => \"your CloudFront domain\"\r\n\r\nFor AttachmentFile.rb do the same just change your path and remove styles options...",
"title": null,
"type": "comment"
}
] | 4 | 6 | 1,056 | false | false | 1,056 | true |
Parallels/vagrant-parallels | Parallels | 105,013,575 | 212 | null | [
{
"action": "opened",
"author": "dogweather",
"comment_id": null,
"datetime": 1441441793000,
"masked_author": "username_0",
"text": "Can anyone offer anecdotes or benchmarks for Linux as the guest OS on Parallels? It's easy to find Windows benchmarks comparing the Parallels versions, but not with Linux. I'm considering whether to upgrade from 10 to 11.",
"title": "Just wondering: performance of Parallels 11 vs. 10?",
"type": "issue"
},
{
"action": "created",
"author": "legal90",
"comment_id": 143234775,
"datetime": 1443190371000,
"masked_author": "username_1",
"text": "There is some kind of benchmark for Parallels Desktop + Vagrant, but there is no data about version 11 yet: https://github.com/username_2/vagrant-virtualbox-vs-parallels\r\n\r\n@username_2, could you please run your tests with new Parallels Desktop 11?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adri",
"comment_id": 143418736,
"datetime": 1443264411000,
"masked_author": "username_2",
"text": "There you go https://github.com/username_2/vagrant-virtualbox-vs-parallels",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "legal90",
"comment_id": null,
"datetime": 1443301728000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "legal90",
"comment_id": 143495813,
"datetime": 1443301728000,
"masked_author": "username_1",
"text": "@username_2 Thank you very much!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dogweather",
"comment_id": 143506619,
"datetime": 1443313020000,
"masked_author": "username_0",
"text": "Excellent @username_2 ! Thank you",
"title": null,
"type": "comment"
}
] | 3 | 6 | 578 | false | false | 578 | true |
este/este | este | 107,904,946 | 481 | null | [
{
"action": "opened",
"author": "ronag",
"comment_id": null,
"datetime": 1443009716000,
"masked_author": "username_0",
"text": "Sorry, I'm a little lost I can't find where the react component hot reload is injected. Can't find `react-hot-loader` in webpack config nor a `react-transform-hmr` in babel config.",
"title": "How is hot reload added?",
"type": "issue"
},
{
"action": "closed",
"author": "ronag",
"comment_id": null,
"datetime": 1443009753000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "grabbou",
"comment_id": 142582717,
"datetime": 1443010818000,
"masked_author": "username_1",
"text": "babel config :D",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ronag",
"comment_id": 142586197,
"datetime": 1443012054000,
"masked_author": "username_0",
"text": "Yes, I just missed that there is 2 babel configs.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 244 | false | false | 244 | false |
cms-sw/cmssw | cms-sw | 161,699,061 | 14,951 | {
"number": 14951,
"repo": "cmssw",
"user_login": "cms-sw"
} | [
{
"action": "opened",
"author": "makortel",
"comment_id": null,
"datetime": 1466605894000,
"masked_author": "username_0",
"text": "The check for `Track::seedRef()` availability in MultiTrackValidator, added in #14248, was not sufficient. This omission leads to an exception from missing product in the MTV standalone mode ([SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo](https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo)). Requiring explicitly the availability of the seed product fixes the exception. Thanks to @username_2 for reporting the bug.\r\n\r\nTested in CMSSW_8_1_0_pre6, no changes expected in standard workflows.\r\n\r\n@rovere @username_1",
"title": "Fix to MultiTrackValidator standalone mode",
"type": "issue"
},
{
"action": "created",
"author": "VinInn",
"comment_id": 228316456,
"datetime": 1466765727000,
"masked_author": "username_1",
"text": "@cmsbuild , please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ebrondol",
"comment_id": 228479847,
"datetime": 1466807875000,
"masked_author": "username_2",
"text": "@username_3 is it possible to fit also this in pre8? It would be useful (with another PR that I am testing now) to fix the validation for the phase2 tracking.. We just discover the issue today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kpedro88",
"comment_id": 228480219,
"datetime": 1466807998000,
"masked_author": "username_3",
"text": "@davidlange6 this seems to be a one-line bug fix, would be nice to put in pre8.\r\n\r\n@dmitrijus, @vanbesien please review and sign if possible (I realize it's short notice, but it seems to be a straightforward change).",
"title": null,
"type": "comment"
}
] | 5 | 8 | 1,787 | false | true | 1,008 | true |
dmvaldman/samsara | null | 163,534,428 | 55 | {
"number": 55,
"repo": "samsara",
"user_login": "dmvaldman"
} | [
{
"action": "opened",
"author": "jd-carroll",
"comment_id": null,
"datetime": 1467491298000,
"masked_author": "username_0",
"text": "",
"title": "Create `off` method to de-register from upstream events",
"type": "issue"
},
{
"action": "created",
"author": "jd-carroll",
"comment_id": 230123137,
"datetime": 1467495339000,
"masked_author": "username_0",
"text": "I don't see why this is failing..\r\n```\r\n...\r\nonScriptLoad@file:///home/travis/build/username_1/samsara/test/vendor/require.js:30:186: undefined is not an object (evaluating 'this.upstream[i].off')\r\n```\r\n\r\nShouldn't all upstream objects have an `off`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmvaldman",
"comment_id": 230205651,
"datetime": 1467608694000,
"masked_author": "username_1",
"text": "Found the problem. Thought I was the only one who messed up for loop expressions, but now there's two of us ;-)\r\n\r\nPut up some more tests, and this PR (with the fixes) passes them. So looking forward to merging in the fixed version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jd-carroll",
"comment_id": 230319981,
"datetime": 1467648236000,
"masked_author": "username_0",
"text": "Should be all set.\r\n\r\nThe best is when I write syntactically correct loops from Java / .Net / JS in the wrong language...",
"title": null,
"type": "comment"
}
] | 2 | 4 | 602 | false | false | 602 | true |
FasterXML/jackson-core | FasterXML | 139,671,234 | 256 | null | [
{
"action": "opened",
"author": "Veske",
"comment_id": null,
"datetime": 1457550503000,
"masked_author": "username_0",
"text": "I upgraded a project from jackson 2.4.4 to 2.7.1. The older version had a class BytesToNameCanonicalizer that was used. The version 2.7.1 does not have it anymore. \r\n\r\nWas the class removed at some point of development and if so then are there any alternatives?",
"title": "BytesToNameCanonicalizer does not exist",
"type": "issue"
},
{
"action": "created",
"author": "cowtowncoder",
"comment_id": 194468669,
"datetime": 1457551910000,
"masked_author": "username_1",
"text": "@username_0 yes, it was replaced by `ByteQuadsCanonicalizer`, added in 2.6 (and `CharsToNameCanonicalizer`).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Veske",
"comment_id": null,
"datetime": 1457559467000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 365 | false | false | 365 | true |
gmr/consulate | null | 75,361,903 | 34 | null | [
{
"action": "opened",
"author": "inhumantsar",
"comment_id": null,
"datetime": 1431379287000,
"masked_author": "username_0",
"text": "foobar\r\n \r\n $ pip show consulate\r\n ---\r\n Metadata-Version: 2.0\r\n Name: consulate\r\n Version: 0.4.0\r\n Summary: A Client library for the Consul\r\n Home-page: https://consulate.readthedocs.org\r\n Author: Gavin M. Roy\r\n Author-email: gavinr@aweber.com\r\n License: BSD\r\n Location: /Library/Python/2.7/site-packages\r\n Requires: requests\r\n \r\n $ python --version\r\n Python 2.7.6\r\n \r\n $ uname -a\r\n Darwin martins.local 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64\r\n \r\n $ sw_vers -productVersion\r\n 10.10.3",
"title": "Python claims that session.kv.set_record() has no 'replace' keyword argument.",
"type": "issue"
},
{
"action": "created",
"author": "inhumantsar",
"comment_id": 101070136,
"datetime": 1431385063000,
"masked_author": "username_0",
"text": "So it appears that readthedoc's \"latest\" != \"latest stable\" (ie 0.4.0) but rather, the master branch where development is happening. This runs counter to expected behaviour. Take the *boto* project for example. They use \"latest\" on RTD to display documentation for the version that is \"latest\" in the pip repos, which is what the vast majority of people will be looking for. \r\n\r\nThis isn't a bug in the library itself so I'm going to change the title to match. \r\n\r\nNew request: It would be helpful to have the docs display the version they're referencing, though defaulting to \"latest stable\" rather than the development branch would make the most sense.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmr",
"comment_id": 101475133,
"datetime": 1431479898000,
"masked_author": "username_1",
"text": "Bummer, that's annoying. I'll update RTD.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gmr",
"comment_id": null,
"datetime": 1431479983000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "gmr",
"comment_id": 101475266,
"datetime": 1431479983000,
"masked_author": "username_1",
"text": "Updated to use \"stable\" in RTD which is pointing to 0.4.0 at the time of this comment. Sorry for the trouble.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,426 | false | false | 1,426 | false |
webdriverio/webdriverio | webdriverio | 183,988,428 | 1,655 | {
"number": 1655,
"repo": "webdriverio",
"user_login": "webdriverio"
} | [
{
"action": "opened",
"author": "fustic",
"comment_id": null,
"datetime": 1476889468000,
"masked_author": "username_0",
"text": "## Proposed changes\r\n\r\nI cloned the repo and run ```npm install```. It appeared that eslint:target failed on 2 lines.\r\nI fixed them according to eslint rules.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce to WebdriverIO?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [x] I have read the [CONTRIBUTING](/CONTRIBUTING.md) doc\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\n### Reviewers: @username_1",
"title": "fix 2 errors reported by eslint:target",
"type": "issue"
},
{
"action": "created",
"author": "christian-bromann",
"comment_id": 254852995,
"datetime": 1476891790000,
"masked_author": "username_1",
"text": "thanks 👍",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,059 | false | false | 1,059 | true |
phonegap/phonegap-plugin-contentsync | phonegap | 116,762,780 | 90 | null | [
{
"action": "opened",
"author": "abonec",
"comment_id": null,
"datetime": 1447418813000,
"masked_author": "username_0",
"text": "Is there feature to delete installed update?",
"title": "Need feature to delete installed update",
"type": "issue"
},
{
"action": "created",
"author": "macdonst",
"comment_id": 156424436,
"datetime": 1447419090000,
"masked_author": "username_1",
"text": "@username_0 do you mean remove all the content at a sync location or roll back the latest merge?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abonec",
"comment_id": 156424814,
"datetime": 1447419209000,
"masked_author": "username_0",
"text": "I mean delete whole directory with downloaded and extracted update by ID or by full path.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "macdonst",
"comment_id": 156608173,
"datetime": 1447466595000,
"masked_author": "username_1",
"text": "As of 1.2.0 of the plugin both Android & iOS store their data in the path represented by `cordova.file.dataDirectory` so you can use the File plugin to remove your cached data.\r\n\r\n```\r\nwindow.resolveLocalFileSystemURL(cordova.file.dataDirectory + id, function (dirEntry) {\r\n dirEntry. removeRecursively(function() {\r\n // success\r\n }, function(error) {\r\n // error\r\n });\r\n} function(e) {\r\n // handle error\r\n});\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CookieCookson",
"comment_id": 156987902,
"datetime": 1447670924000,
"masked_author": "username_2",
"text": "Would there be a way in the future to have this functionality included without requiring the file plugin? I'm using the id as a way of keeping track what update version is running, so would be awesome if there was a function which 'cleans up' old IDs.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "burin",
"comment_id": 158101062,
"datetime": 1447948973000,
"masked_author": "username_3",
"text": "I think being able to clear cached data would be nice too (although using the File plugin works too). I need to do the same thing as @username_2 (clear \"old\" ids)\r\n\r\nI imagined the API would be similar to the `ionic-plugin-deploy` methods `getVersions` and `deleteVersion`:\r\n\r\nhttps://github.com/driftyco/ionic-plugin-deploy/blob/master/www/ionicdeploy.js#L65",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tripodsan",
"comment_id": 158145354,
"datetime": 1447957203000,
"masked_author": "username_4",
"text": "maybe the contentsync plugin should keep a history/manifest of synced updates. eg:\r\n\r\ncontentsync.json\r\n```\r\n{\r\n\t\"appid-1\": {\r\n\t\t\"src\": \"http://some.server.com/update-package.zip\",\r\n\t\t\"localPath\": \"..../files/appid-1\",\r\n\t\t\"lastUpdate\": 12341234123,\r\n\t\t\"lastSyncType\": \"merge\"\r\n\t},\r\n\t\"appid-2\": {\r\n\t\t\"src\": \"http://some.server.com/update-package.zip?v=2\",\r\n\t\t\"localPath\": \"..../files/appid-2\",\r\n\t\t\"lastUpdate\": 12341234126,\r\n\t\t\"lastSyncType\": \"replace\"\r\n\t},\r\n\t\"deep/appid/1.0\": {\r\n\t\t\"localPath\": \"..../files/deep/appid/1.0\",\r\n\t\t\"lastUpdate\": 12341234126,\r\n\t\t\"lastSyncType\": \"local\",\r\n\t\t\"copyRootApp\": true\r\n\t}\r\n}\r\n```\r\n\r\nand then offer a method to retrieve this list. delete could be done with a new sync type `delete` which wouldn't require a `src`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "imhotep",
"comment_id": 162095266,
"datetime": 1449266910000,
"masked_author": "username_5",
"text": "I have a feeling that the plugin already does too much. We could offer the functionality to delete old synced folders but we might end up with a full replacement of the File plugin and I am not sure we want that.",
"title": null,
"type": "comment"
}
] | 6 | 8 | 2,222 | false | false | 2,222 | true |
ekalinin/nodeenv | null | 76,663,182 | 123 | null | [
{
"action": "opened",
"author": "sirmar",
"comment_id": null,
"datetime": 1431681628000,
"masked_author": "username_0",
"text": "When installing nodeenv through bamboo it get this:\r\n\r\n15-May-2015 11:14:52\t Traceback (most recent call last):\r\n15-May-2015 11:14:52\t File \"<string>\", line 20, in <module>\r\n15-May-2015 11:14:52\t File \"/tmp/pip-build-_gpsu3pm/nodeenv/setup.py\", line 20, in <module>\r\n15-May-2015 11:14:52\t ldesc = read_file('README.rst')\r\n15-May-2015 11:14:52\t File \"/tmp/pip-build-_gpsu3pm/nodeenv/setup.py\", line 18, in read_file\r\n15-May-2015 11:14:52\t ).read()\r\n15-May-2015 11:14:52\t File \"/bamboo/xml-data/build-dir/PIT-DE-TEST/.tox/ci/lib/python3.4/encodings/ascii.py\", line 26, in decode\r\n15-May-2015 11:14:52\t return codecs.ascii_decode(input, self.errors)[0]\r\n15-May-2015 11:14:52\t UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 7085: ordinal not in range(128)",
"title": "Encoding not specified in setup.py",
"type": "issue"
},
{
"action": "closed",
"author": "ekalinin",
"comment_id": null,
"datetime": 1431698203000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "asottile",
"comment_id": 102535250,
"datetime": 1431727479000,
"masked_author": "username_2",
"text": "Would love a release with this, it's breaking my travis builds: https://travis-ci.org/username_2/css-explore/jobs/62762793",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sirmar",
"comment_id": 102617642,
"datetime": 1431777244000,
"masked_author": "username_0",
"text": "We found a workaround to be to set LANG environment variable to something utf-8-ish inside tox.\n\nSo in tox.ini:\n\n[testenv]\nsetenv =\n LANG=en_US.UTF-8\n\nGive it a try.\n\n/Marcus",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ekalinin",
"comment_id": 102624319,
"datetime": 1431781091000,
"masked_author": "username_1",
"text": "Thanks! Done.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "asottile",
"comment_id": 102717435,
"datetime": 1431824289000,
"masked_author": "username_2",
"text": "So the root cause is tox no longer passes through environment variables by default. I've created https://bitbucket.org/hpk42/tox/issue/247/pass-through-lang-environment-variable-by\r\n\r\nI think the more-correct patch is to passenv LANG instead of explicitly setting it in tox",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "homeworkprod",
"comment_id": 102823319,
"datetime": 1431882231000,
"masked_author": "username_3",
"text": "@username_2, thanks for creating the ticket.\r\n\r\nFTR, I came across this as the installation of the Arrow package (v0.5.4) fails on my CI like this (because of some Korean symbols in the README):\r\n```\r\nCollecting Arrow>=0.4.4 (from -r requirements.txt (line 13))\r\n Downloading arrow-0.5.4.tar.gz (81kB)\r\n Complete output from command python setup.py egg_info:\r\n Traceback (most recent call last):\r\n File \"<string>\", line 20, in <module>\r\n File \"/tmp/pip-build-41rzo0k_/Arrow/setup.py\", line 31, in <module>\r\n long_description=open('README.rst').read(),\r\n File \"/fooooo/.tox/py34/lib/python3.4/encodings/ascii.py\", line 26, in decode\r\n return codecs.ascii_decode(input, self.errors)[0]\r\n UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in position 2974: ordinal not in range(128)\r\n \r\n ----------------------------------------\r\n Command \"python setup.py egg_info\" failed with error code 1 in /tmp/pip-build-41rzo0k_/Arrow\r\n```\r\n\r\nTox itself is invoked with `LANG=C.UTF-8 tox` (and the locale `C-UTF-8` is present).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ekalinin",
"comment_id": 102855999,
"datetime": 1431895900000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 4 | 8 | 2,477 | false | false | 2,477 | true |
18F/dashboard | 18F | 112,862,301 | 273 | null | [
{
"action": "opened",
"author": "noahmanger",
"comment_id": null,
"datetime": 1445538423000,
"masked_author": "username_0",
"text": "",
"title": "C2 Related link text is broken",
"type": "issue"
},
{
"action": "created",
"author": "pkarman",
"comment_id": 150314921,
"datetime": 1445538623000,
"masked_author": "username_1",
"text": "thanks, I think this is already fixed in master but we just haven't deployed it yet. See https://github.com/18F/C2/pull/727 -- is that the same issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "noahmanger",
"comment_id": 150317943,
"datetime": 1445539243000,
"masked_author": "username_0",
"text": "Oh probably.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbland",
"comment_id": 150347418,
"datetime": 1445545728000,
"masked_author": "username_2",
"text": "Nope, that file is fixed. There were other errors preventing the Team API from rebuilding, addressed by 18F/18f.gsa.gov#1268 and 18F/openFEC#1291.\r\n\r\nWe'll get this brittleness fixed soon.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mbland",
"comment_id": null,
"datetime": 1445547165000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mbland",
"comment_id": 150352986,
"datetime": 1445547165000,
"masked_author": "username_2",
"text": "OK, this is all good now:\r\n\r\n",
"title": null,
"type": "comment"
}
] | 3 | 6 | 611 | false | false | 611 | false |
icsharpcode/SharpZipLib | icsharpcode | 126,398,646 | 99 | null | [
{
"action": "opened",
"author": "goldenbull",
"comment_id": null,
"datetime": 1452684729000,
"masked_author": "username_0",
"text": "lzma is suitable for some special scenarios which need higher compression ratio and faster decompression speed, and do not care about compression speed.",
"title": "Any plan for lzma/xz format?",
"type": "issue"
},
{
"action": "created",
"author": "McNeight",
"comment_id": 210383110,
"datetime": 1460712740000,
"masked_author": "username_1",
"text": "Chen,\r\n\r\nAt the moment I am focused more on cleaning up the existing code and bug fixing, rather than adding new features. Hopefully soon, we can take a look at incorporating lzma/xz into our project.\r\n\r\n-Neil",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "goldenbull",
"comment_id": 210409602,
"datetime": 1460716544000,
"masked_author": "username_0",
"text": "Thanks for your reply. I have created a ManagedXZ project to interop with the native liblzma.dll. Maybe it's possible to re-compile the lzma source code in C++/cli, but I didn't try.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "McNeight",
"comment_id": 215990666,
"datetime": 1462045953000,
"masked_author": "username_1",
"text": "I discovered that Igor Pavlov has a written a [public domain LZMA SDK](http://www.7-zip.org/sdk.html) with an implementation in C#. I'll take a look at what it will take to integrate his code into the library, but no guarantees on a timeline.\r\n\r\n-Neil",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "goldenbull",
"comment_id": 216097337,
"datetime": 1462158600000,
"masked_author": "username_0",
"text": "A simple comparison of LZMA C# SDK and liblzma.dll from http://tukaani.org/xz/\r\n\r\nLZMA C# SDK\r\n- supports only LZMA, not LZMA2, so doesn't support parallel compression\r\n- pure C# implementation, platform independent but bad performance compared to native C/C++ implementation\r\n\r\nliblzma.dll from http://tukaani.org/xz/\r\n- supports both LZMA and LZMA2, so can compress in parallel (this is important to me when I have a powerful server with 40 CPU cores)\r\n- native C implementation results in high performance but platform dependent",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "goldenbull",
"comment_id": 216097642,
"datetime": 1462158880000,
"masked_author": "username_0",
"text": "I found the Java implementation of XZ Utils here: http://tukaani.org/xz/java.html\r\nMaybe we can try translate the Java source code into C# :smile:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "goldenbull",
"comment_id": 216100482,
"datetime": 1462160699000,
"masked_author": "username_0",
"text": "Well, further investigation shows that Java implementation supports only single thread yet, and the LZMA C# SDK from 7-zip is the translation as I meant :disappointed:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gigi81",
"comment_id": 220730901,
"datetime": 1463782389000,
"masked_author": "username_2",
"text": "There is also another C# porting of the LZMA library here:\r\nhttps://github.com/weltkante/managed-lzma\r\nNot sure what is the status of the project and how it compares in terms of performance.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "goldenbull",
"comment_id": 221172021,
"datetime": 1464068642000,
"masked_author": "username_0",
"text": "@username_2 I haven't dived into the C# code yet, but to my knowledge, compression algorithm needs to access memory heavily, which is much slower in C# even with unsafe pointer.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "goldenbull",
"comment_id": null,
"datetime": 1580651465000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 10 | 2,001 | false | false | 2,001 | true |
sequelize/sequelize | sequelize | 30,602,460 | 1,577 | null | [
{
"action": "opened",
"author": "alekbarszczewski",
"comment_id": null,
"datetime": 1396361841000,
"masked_author": "username_0",
"text": "I know that sequelize does not support geo data type like postgis, but I would like to hack it to be able to insert geo data (lon and lat) and query by them to find nearest points.\n\nIs it possible to somehow modify postgres query on the fly or maybe there is better method to do this? Could you give me some beta?\n\nAre you planning to add support for PostGis in the future?",
"title": "How to use postgis with sequelize",
"type": "issue"
},
{
"action": "created",
"author": "yalva",
"comment_id": 612860250,
"datetime": 1586776921000,
"masked_author": "username_1",
"text": "How to retrieve lat, long with find?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 409 | false | false | 409 | false |
jcelliott/turnpike | null | 182,499,393 | 130 | null | [
{
"action": "opened",
"author": "dcelasun",
"comment_id": null,
"datetime": 1476270980000,
"masked_author": "username_0",
"text": "It seems like turnpike is semi-maintained by a few different people, but there are multiple open PRs and issues and it doesn't seem like there is any progress. Some of them look quite serious like [#94](https://github.com/username_2/turnpike/issues/94), [#85](https://github.com/username_2/turnpike/issues/85), [#50](https://github.com/username_2/turnpike/issues/50) and a few more.\r\n\r\nDoes any of the current maintainers plan to work on these?",
"title": "Status of turnpike?",
"type": "issue"
},
{
"action": "created",
"author": "willeponken",
"comment_id": 253193755,
"datetime": 1476273425000,
"masked_author": "username_1",
"text": "I know nothing about the current maintainers in this repo, but there has been active development in these:\n\nhttps://github.com/awakenetworks/turnpike\nhttps://github.com/username_6/turnpike\n\nWould be really great if these two could go together and collaborate in a shared repository.\n\nMaybe the current owner of this repo could arrange something?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jcelliott",
"comment_id": 253224931,
"datetime": 1476281593000,
"masked_author": "username_2",
"text": "I don't really have time to work on this right now. There are a few people besides me who have commit access, and they have been making some progress. @username_6 and I were the original authors of the first implementation and the v2 rewrite, so if he plans on maintaining his fork I will link to that one as the \"official\" fork. I would like to hear his opinion as well as @username_4, @username_3 and any others who have been working on turnpike.\r\n\r\nA shared repo would be another great option. I created a `go-turnpike` organization a long time ago (to resolve `gopkg.in/turnpike.v2` to turnpike v2) that I could turn over to current maintainers if anyone is interested.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanfali",
"comment_id": 253356091,
"datetime": 1476310649000,
"masked_author": "username_3",
"text": "I'd love to see an org, and would be willing to participate. I am using turnpike at work daily and I really appreciate the solid work that has gone in to it.\r\n\r\nOne feature I would contribute, is an alternate backend implementation for Dealer. I'd also contribute some example code/documentation for simple authentication of wamp connections using ticket. I really like how flexible/pluggable the code base is.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mourad",
"comment_id": 253382656,
"datetime": 1476320787000,
"masked_author": "username_4",
"text": "I've contributed to the project a few times and continue to use turnpike daily as well, but have been more careful at making changes lately as I currently have 2 open PRs that I was hopeful that either @username_2 or @username_6 or others that know more about the direction that they would like to take turnpike could've provided feedback.\r\n\r\nI am ok with whichever direction you decide to take, and am also willing to spend time should you decide to continue moving this repo forward. I just did not want to introduce changes that negatively affected others simply because no one was available to review them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mourad",
"comment_id": 256943623,
"datetime": 1477666696000,
"masked_author": "username_4",
"text": "I've gone ahead and added my changes to the v2 branch, as I've been working with them for quite a while and haven't seen any significant issues.\r\n\r\nI plan on continuing to work on turnpike as time permits, and fix issues as I find them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "migueleliasweb",
"comment_id": 301319331,
"datetime": 1494774739000,
"masked_author": "username_5",
"text": "+1 as a wish for this repo come back to life !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beatgammit",
"comment_id": 301640483,
"datetime": 1494894166000,
"masked_author": "username_6",
"text": "Me too :(\r\n\r\nI use it in production, and it's reasonably stable, but there are still occasional crashes from runtime panics. I have a branch that fixes a few of them, so I just need to sit down and rethink the concurrency model to make sure I'm happy before merging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "richardartoul",
"comment_id": 312467424,
"datetime": 1498963667000,
"masked_author": "username_7",
"text": "About to start using this in production and wondering if there is any status update? @username_6 What kind of load are you handling in production?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beatgammit",
"comment_id": 359265389,
"datetime": 1516555986000,
"masked_author": "username_6",
"text": "@username_7 Not too much, something like 5 clients and tens of messages per second. My fork has some concurrency fixes (to fix panics, though they probably don't scale well), so feel free to take a look at that if you like.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dcelasun",
"comment_id": null,
"datetime": 1520002163000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 8 | 11 | 3,392 | false | false | 3,392 | true |
Esri/resource-proxy | Esri | 158,448,708 | 367 | null | [
{
"action": "opened",
"author": "dasa",
"comment_id": null,
"datetime": 1464985848000,
"masked_author": "username_0",
"text": "`esri/request` won't return xml when \"handleAs\" is \"xml\" unless the response Content-Type header is either \"text/xml\" or \"application/xml\".\r\n\r\nReference: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseXML\r\n\r\nExample code:\r\n\r\n```java\r\n// Most of the new ms documents have content type as application/vnd.openxmlformats-*, we need to set these correctly\r\n// For rest of the xml formats, convert them to text/xml, need to be very careful on this\r\nString contentType = con.getContentType();\r\nif (contentType != null && contentType.contains(\"xml\") && !contentType.contains(\"vnd.openxmlformats\")) {\r\n\tresponse.setContentType(\"text/xml\");\r\n}\r\nelse {\r\n\tresponse.setContentType(contentType);\r\n}\r\n```",
"title": "Normalize xml response content type",
"type": "issue"
},
{
"action": "created",
"author": "bsvensson",
"comment_id": 223726628,
"datetime": 1465002032000,
"masked_author": "username_1",
"text": "Is this a problem with the proxy or esri/request? \r\n\r\nLooking at the [HTTP spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.17) it doesn't seem that sending two Content-Type headers are legal. So, as far as I understand, this means that in this case we would have to overwrite the Content-Type.\r\n\r\nWould changing the Content-Type from a vendor-specific one `vnd.openxmlformats*` to a generic `application\\xml` always be a good thing? Or should it be something configurable in the proxy?\r\n\r\nVendor specific content types are registered with [IANA](https://www.iana.org/assignments/media-types/media-types.xhtml).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dasa",
"comment_id": 223976608,
"datetime": 1465223527000,
"masked_author": "username_0",
"text": "👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dasa",
"comment_id": 223977337,
"datetime": 1465223661000,
"masked_author": "username_0",
"text": "`esri/request` is relying on dojo which is relying on the behavior of `XMLHttpRequest`. This could be changed and this could be made a configurable option in the proxy.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bsvensson",
"comment_id": 225280334,
"datetime": 1465588630000,
"masked_author": "username_1",
"text": "Fixed in all three proxies. @username_0 - can you test?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bsvensson",
"comment_id": 225327316,
"datetime": 1465606710000,
"masked_author": "username_1",
"text": "@username_0 - I installed a better fix now that I understand the problem better.\r\n\r\nAny WMG OGC servers that use `application/vnd.ogc.wms_xml` will now have their content-type changed to `text/xml`. \r\n\r\nTest case:\r\n`curl --verbose \"http://localhost/resource-proxy/DotNet/proxy.ashx?http://data.wien.gv.at/daten/wms?SERVICE=WMS&REQUEST=GetCapabilities\"`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dasa",
"comment_id": 225477613,
"datetime": 1465784898000,
"masked_author": "username_0",
"text": "👍 for PHP",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bsvensson",
"comment_id": null,
"datetime": 1465787210000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 8 | 1,922 | false | false | 1,922 | true |
aheyne/geomesa | null | 217,448,419 | 1 | {
"number": 1,
"repo": "geomesa",
"user_login": "aheyne"
} | [
{
"action": "opened",
"author": "tkunicki",
"comment_id": null,
"datetime": 1490677224000,
"masked_author": "username_0",
"text": "I went through the denorm method and fully mapped to norm to make sure every thing was understood and characterized in unit tests. The denorm method will now return a value from the middle of the range of all possible inputs that that might results in the given index (x). This should be numerically stable given increased precision.",
"title": "GEOMESA-1740 modify denormalize with fully characterized impl.",
"type": "issue"
},
{
"action": "created",
"author": "aheyne",
"comment_id": 289780714,
"datetime": 1490709951000,
"masked_author": "username_1",
"text": "Nice, thanks for doing this!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 363 | false | false | 363 | false |
assisrafael/angular-input-masks | null | 193,111,823 | 240 | null | [
{
"action": "opened",
"author": "laurindo",
"comment_id": null,
"datetime": 1480683938000,
"masked_author": "username_0",
"text": "Ao recuperar o valor salvo, está sendo adicionado o valor +55 dentro do DDD (85) por exemplo.\r\nEssa é a forma como estou pegando o valor.\r\n<input type=\"text\"\r\n name=\"telefone\"\r\n ui-br-phone-number\r\n placeholder=\"Digite aqui\"\r\n ng-model=\"vm.contato.telefone\" />\r\n\r\nDepois que salvo no banco o valor fica:\r\n85991568956\r\n\r\nQuando tento recuperar do banco e imprimir com a mascara, está ficando assim:\r\n(55)85991-5689\r\n\r\nAlguém com esse problema?",
"title": "Problemas na máscara de ui-br-phone-number",
"type": "issue"
},
{
"action": "closed",
"author": "assisrafael",
"comment_id": null,
"datetime": 1506179991000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "assisrafael",
"comment_id": 331642246,
"datetime": 1506179991000,
"masked_author": "username_1",
"text": "The mask uiBrPhoneNumber now supports the country prefix. Check the latest version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "matheusnicolas",
"comment_id": 401439624,
"datetime": 1530297572000,
"masked_author": "username_2",
"text": "Tem como utilizar sem o country code?",
"title": null,
"type": "comment"
}
] | 3 | 4 | 570 | false | false | 570 | false |
simbody/simbody | simbody | 104,973,721 | 433 | {
"number": 433,
"repo": "simbody",
"user_login": "simbody"
} | [
{
"action": "opened",
"author": "chrisdembia",
"comment_id": null,
"datetime": 1441402405000,
"masked_author": "username_0",
"text": "The changes I made here are based on discussions in https://github.com/opensim-org/opensim-core/issues/592.\r\n\r\nI chose to remove the template class typedefs necessary, but I left the ones that I didn't need to change (with perhaps 1 or 2 exceptions). Also, I chose *not* to remove any typedefs for Mat.h; instead I put the typedefs in the public section. I justify this because Vec.h has similar typedefs that are public. By making only the necessary changes, I hope to have minimized the chance of introducing a bug.\r\n\r\nAlso, for computation within enums, I chose to use `#ifndef SWIG` rather than resorting to a `constexpr` function in order to make sure the C++ code remains clear and that I don't introduce a bug.\r\n\r\nI've tested OpenSim wrapping against these changes, and both the python and java wrapping compile (and the python tests and testContext both pass). You can see my changes to OpenSim here: https://github.com/opensim-org/opensim-core/tree/swig-simtk",
"title": "Changes to allow swig 3.0.5 to process certain Simbody headers.",
"type": "issue"
},
{
"action": "created",
"author": "chrisdembia",
"comment_id": 137858592,
"datetime": 1441402586000,
"masked_author": "username_0",
"text": "@aymanhab",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sherm1",
"comment_id": 138355821,
"datetime": 1441651750000,
"masked_author": "username_1",
"text": "This all looks good, Chris -- thanks! Merging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdembia",
"comment_id": 138359422,
"datetime": 1441652535000,
"masked_author": "username_0",
"text": "Thank you Sherm.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,039 | false | false | 1,039 | false |
Discordius/Lesswrong2 | null | 270,889,422 | 262 | null | [
{
"action": "opened",
"author": "Discordius",
"comment_id": null,
"datetime": 1509691072000,
"masked_author": "username_0",
"text": "It seems reasonable to deactivate downvoting a user's content from their profile page.",
"title": "It's right now too easy to downvote all of one user's content from their profile page",
"type": "issue"
},
{
"action": "created",
"author": "gwillen",
"comment_id": 349729859,
"datetime": 1512584596000,
"masked_author": "username_1",
"text": "I believe Reddit uses the following simple trick to discourage mass downvoting: The user page has up/down arrows on each comment, but they don't do anything. They remember state (so refreshing preserves the illusion of voting), but they have no effect on karma or post ranking.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Raemon",
"comment_id": 388197800,
"datetime": 1525989235000,
"masked_author": "username_2",
"text": "Since this issue was created, we ended up deactivating the ability to dowvote _posts_ but not comments. Could use someone doing that.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 496 | false | false | 496 | false |
tieniber/ConfirmButton | null | 219,568,333 | 1 | null | [
{
"action": "opened",
"author": "Mcpoowl",
"comment_id": null,
"datetime": 1491395887000,
"masked_author": "username_0",
"text": "Hi Eric,\r\n\r\nI've run in to a little snag and I was wondering if this was by design. Example case is that I check if a purchase is above $1k. So my primary microflow is:\r\n\r\n`if $Expense/total > 1000 then true else false`\r\n\r\nIf I create an expense with a total of 1100, the confirmation shows and everything works as expected. However I'd expect that, if I create an expense with a total of 900, no confirmation is shown, but the microflow is executed anyway, this last bit does not work:\r\n\r\nNo confirmation is shown, but my microflow isn't executing either.\r\n\r\nI'd like to use this widget as a extra check to notify the user, however when the user doesn't receive a confirmation (primary = false, I'd still like to execute the follow-up microflow)",
"title": "confirmation microflow not called if primary returns false",
"type": "issue"
},
{
"action": "created",
"author": "tieniber",
"comment_id": 291877509,
"datetime": 1491402242000,
"masked_author": "username_1",
"text": "Hi Paul,\r\n\r\nYou can simply put your follow-up logic on the false branch of the first microflow.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Mcpoowl",
"comment_id": null,
"datetime": 1491402317000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Mcpoowl",
"comment_id": 291877923,
"datetime": 1491402317000,
"masked_author": "username_0",
"text": "Wow, of course. I was thinking way to difficult. Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 897 | false | false | 897 | false |
openshift/openshift-docs | openshift | 145,679,129 | 1,852 | {
"number": 1852,
"repo": "openshift-docs",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "pweil-",
"comment_id": null,
"datetime": 1459775233000,
"masked_author": "username_0",
"text": "@username_2 @username_1 ptal and let me know if you think this should be more specific.\r\n\r\n@username_3 - this should go in a 3.2 build.\r\n\r\nref: https://github.com/openshift/origin/issues/8329#issuecomment-204417847",
"title": "specify compute resources for the registry",
"type": "issue"
},
{
"action": "created",
"author": "kargakis",
"comment_id": 205293586,
"datetime": 1459776014000,
"masked_author": "username_1",
"text": "LGTM\r\n\r\n@username_2 should we recommend a specific request/limit for average clusters?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derekwaynecarr",
"comment_id": 205341653,
"datetime": 1459782594000,
"masked_author": "username_2",
"text": "I do not have any data that can make a specific recommendation at this time.\r\n\r\nThe text is LGTM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pweil-",
"comment_id": 217508455,
"datetime": 1462556015000,
"masked_author": "username_0",
"text": "@username_3 can this get merged?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adellape",
"comment_id": 217514626,
"datetime": 1462557473000,
"masked_author": "username_3",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 4 | 5 | 435 | false | false | 435 | true |
lesaux/puppet-kibana4 | null | 116,756,644 | 26 | null | [
{
"action": "opened",
"author": "eperdeme",
"comment_id": null,
"datetime": 1447416469000,
"masked_author": "username_0",
"text": "Howdy,\r\n\r\nI notice when you extract the ZIP you force the permissions to root:root.\r\n\r\nShould the permissions not be kibanaUSER/kibanagroup ? I can send a pull request in, but wondering if I was missing a reason why the directory and files should not be owned by the kibana user ?",
"title": "Permissions - extraction",
"type": "issue"
},
{
"action": "created",
"author": "lesaux",
"comment_id": 156449767,
"datetime": 1447425517000,
"masked_author": "username_1",
"text": "Hi username_0, thanks for the comment. I put this because some people don't manage their kibana user and group in this module (another users manifest, ldap or whatever). But, we could definitely do something when manage_user=>true. A PR is welcome!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "landerson61",
"comment_id": 157990999,
"datetime": 1447922732000,
"masked_author": "username_2",
"text": "Hi username_1,\r\n\r\nShouldn't the owner on the extracted directory be set to kibana_user & kibana_group anyway regardless of whether this module manages the user/group?\r\n\r\nEven if the user/group is managed by another module/ldap etc, having ownership set to root on the kibana directory prevents the kibana_user from executing the kibana binary (the extracted bin/ folder has 700 permisisons)?\r\n\r\nThoughts?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesaux",
"comment_id": 158092007,
"datetime": 1447947378000,
"masked_author": "username_1",
"text": "Hi username_2,\r\nthis doesn't seem to be the case.\r\n```\r\nls -l /opt/\r\ntotal 4\r\ndrwxr-xr-x 7 root root 4096 Jun 29 18:07 kibana-4.1.1-linux-x64\r\n```\r\n\r\n```\r\nps aux|grep kibana\r\nkibana4 6357 0.4 1.6 976276 64968 ? Sl 15:31 0:00 /opt/kibana-4.1.1-linux-x64/bin/../node/bin/node /opt/kibana-4.1.1-linux-x64/bin/../src/bin/kibana.js\r\nroot 6399 0.0 0.0 11740 932 pts/0 R+ 15:33 0:00 grep --color=auto kibana\r\n```\r\n\r\nI still agree with you that this is an issue and we should chown the extracted directories to the kibana4_user.\r\nI will look into the archive modules to see if ownership of the extracted dir is supported.\r\nThanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "landerson61",
"comment_id": 158634817,
"datetime": 1448108540000,
"masked_author": "username_2",
"text": "Hi username_1,\r\n\r\nAs far as I can see, there doesn't seem to be support for changing ownership of extracted directories in the archive moduels. However I have submitted a PR to fix this issue. Hope it is ok!\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lesaux",
"comment_id": null,
"datetime": 1448382513000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "lesaux",
"comment_id": 159323584,
"datetime": 1448382513000,
"masked_author": "username_1",
"text": "Thanks for the PR - merging now.",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,826 | false | false | 1,826 | true |
lminhtm/LMGeocoder | null | 54,292,127 | 4 | {
"number": 4,
"repo": "LMGeocoder",
"user_login": "lminhtm"
} | [
{
"action": "opened",
"author": "iosengineer",
"comment_id": null,
"datetime": 1421220474000,
"masked_author": "username_0",
"text": "- Added ISOcountryCode to LMAddress from both Apple and Google sources\r\n\r\n- Fixed issue with incorrect license reference in podspec\r\n\r\n- Bumped podspec to 1.0.1 for convenience",
"title": "Add ISOcountryCode",
"type": "issue"
},
{
"action": "created",
"author": "iosengineer",
"comment_id": 69879097,
"datetime": 1421220889000,
"masked_author": "username_0",
"text": "Having moved on with what I needed this for, I'd recommend renaming the new property to countryCode, to more easily allow 1:1 import into Core Data (for example), that cannot have property names beginning with an uppercase character (which I did not know until just now - hmph).",
"title": null,
"type": "comment"
}
] | 1 | 2 | 454 | false | false | 454 | false |
arjunkomath/Feline-for-Product-Hunt | null | 245,566,425 | 7 | null | [
{
"action": "opened",
"author": "ztalk112",
"comment_id": null,
"datetime": 1501026332000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nLove the fresh new look after your recent update, however I have an issue when sharing PH posts on Android 6.0.1 (Nexus 5).\r\n\r\nRegardless of the vehicle used (tested with Gmail, Messenger and Pushbullet), no link is passed in the share . . . only the short post description.\r\n\r\n(Note, my strong preference is that the PH post itself should be shared, not the Get It website link).\r\n\r\nCheers.\r\n\r\n",
"title": "No link passed when shared",
"type": "issue"
},
{
"action": "closed",
"author": "arjunkomath",
"comment_id": null,
"datetime": 1510855767000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "arjunkomath",
"comment_id": 345452588,
"datetime": 1511021856000,
"masked_author": "username_1",
"text": "Fixed in Production Release 2.2.1",
"title": null,
"type": "comment"
}
] | 2 | 3 | 552 | false | false | 552 | false |
apache/incubator-openwhisk | apache | 237,909,694 | 2,413 | {
"number": 2413,
"repo": "incubator-openwhisk",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "Jiri-Kremser",
"comment_id": null,
"datetime": 1498150515000,
"masked_author": "username_0",
"text": "this is based on https://github.com/apache/incubator-openwhisk/pull/2403\r\n.. except the code is little bit more Scala idiomatic (using options instead of null checks, etc.), but the functionality is still the same, pls see the original PR for the details.",
"title": "[wip] Draft 2 - Wrap runs within OpenTracing spans",
"type": "issue"
},
{
"action": "created",
"author": "rabbah",
"comment_id": 310441868,
"datetime": 1498151047000,
"masked_author": "username_1",
"text": "no null! 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rabbah",
"comment_id": 310695149,
"datetime": 1498231405000,
"masked_author": "username_1",
"text": "Option(null) == None.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rabbah",
"comment_id": 310695375,
"datetime": 1498231450000,
"masked_author": "username_1",
"text": "oops, use filter instead of exists.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpkrohling",
"comment_id": 311062699,
"datetime": 1498484543000,
"masked_author": "username_2",
"text": "@username_0 , may I close #2403 in favor of this one?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Jiri-Kremser",
"comment_id": 311066513,
"datetime": 1498485365000,
"masked_author": "username_0",
"text": "yes",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Jiri-Kremser",
"comment_id": 314476276,
"datetime": 1499785916000,
"masked_author": "username_0",
"text": "@username_1 is there anything else you want me to improve on this PR? Is it ok to have the open tracing code next to the markers in the logs as the first step? The tracing can be turned off or set to 10% using the env properties, so that only the fraction of the calls will be traced.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rabbah",
"comment_id": 314477110,
"datetime": 1499786083000,
"masked_author": "username_1",
"text": "There is a second tracing pr #2282 - does it make sense to consider consolidating efforts?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpkrohling",
"comment_id": 314483193,
"datetime": 1499787258000,
"masked_author": "username_2",
"text": "I don't think so: there has been a thread on the mailing list, and it looks like that one has a different goal.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rabbah",
"comment_id": 343180104,
"datetime": 1510239543000,
"masked_author": "username_1",
"text": "Closing per discussion on the dev list https://mail-archives.apache.org/mod_mbox/incubator-openwhisk-dev/201707.mbox/browser.",
"title": null,
"type": "comment"
}
] | 3 | 10 | 985 | false | false | 985 | true |
urbit/docs | urbit | 148,722,416 | 5 | null | [
{
"action": "opened",
"author": "ohAitch",
"comment_id": null,
"datetime": 1460742032000,
"masked_author": "username_0",
"text": "Blocked on urbit/tree#9, which implements such.",
"title": "<list> should use [src] instead of [dataPath]",
"type": "issue"
},
{
"action": "created",
"author": "ohAitch",
"comment_id": 210603873,
"datetime": 1460747759000,
"masked_author": "username_0",
"text": "Most of these shouldn't even _have_ a `dataPath`, because they just use the current one. Though a `src=\".\"` might be fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "galenwp",
"comment_id": 210605612,
"datetime": 1460748143000,
"masked_author": "username_1",
"text": "i think src=“.” should be implicit. No?\n\n\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ohAitch",
"comment_id": 210605916,
"datetime": 1460748185000,
"masked_author": "username_0",
"text": "It already is for dataPath! Yet docs/*.md is putting it in anyway :/\n\nOn Friday, 15 April 2016, Galen Wolfe-Pauly <notifications@github.com>\nwrote:\n\n> i think src=“.” should be implicit. No?\n>\n>\n> >",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Fang-",
"comment_id": 242972107,
"datetime": 1472387266000,
"masked_author": "username_2",
"text": "Fixed in #6, this issue can be closed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "juped",
"comment_id": null,
"datetime": 1472391409000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 6 | 449 | false | false | 449 | false |
timdp/es6-promise-pool | null | 252,723,087 | 40 | {
"number": 40,
"repo": "es6-promise-pool",
"user_login": "timdp"
} | [
{
"action": "opened",
"author": "urish",
"comment_id": null,
"datetime": 1503606841000,
"masked_author": "username_0",
"text": "With the current typings, you must write your import as \r\n\r\n import PromisePool from 'es6-promise-pool';\r\n\r\nhowever, this causes a runtime error in Node.js: \r\n\r\n TypeError: es6_promise_pool_1.default is not a constructor\r\n\r\nThis commit changes the supported TypeScript import syntax to \r\n\r\n import * as PromisePool from 'es6-promise-pool';\r\n\r\nwhich works correctly in Node.js",
"title": "Fix typings for use inside node.js",
"type": "issue"
},
{
"action": "created",
"author": "timdp",
"comment_id": 324837861,
"datetime": 1503643745000,
"masked_author": "username_1",
"text": "Thanks for contributing!\r\n\r\nIs this ultimately caused by [this TypeScript issue](https://github.com/Microsoft/TypeScript/issues/5565)?\r\n\r\nIn that case, maybe it's also worth mentioning that there's a legacy API with a named export rather than the default one that TypeScript is struggling with. I'm not sure if the compiler will understand it (and you'd need to add typings) but in ES6, this is also possible:\r\n\r\n```js\r\nimport { PromisePool } from 'es6-promise-pool'\r\n```\r\n\r\nI don't want to keep that API around per se because as I said, it's a legacy thing, but it does seem cleaner than `import *`, right? What would be the expected behavior here?\r\n\r\nI'm no TypeScript expert though. The typings were contributed by @bcherny. Maybe he wants to weigh in as well?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urish",
"comment_id": 324880938,
"datetime": 1503656804000,
"masked_author": "username_0",
"text": "Hi Tim, thanks for the super quick and thoughtful response. Yes, it seems to be related.\r\n\r\nFrom [examples in the typescript documentation](https://basarat.gitbooks.io/typescript/docs/quick/nodejs.html) (and also [here](https://www.typescriptlang.org/docs/handbook/declaration-files/library-structures.html)), seems like they use the following syntax:\r\n\r\n import PromisePool = require('es6-promise-pool');\r\n\r\nHowever, it seems like the current typings don't play well with this syntax (typescript complains about `Cannot use 'new' with an expression whose type lacks a call or construct signature`), whereas the typings from the PR also makes it happy in this case.\r\n\r\n\r\n\r\nI created a super-small demo repo for this, just git clone, npm install, npm start to watch it in in action:\r\n\r\nhttps://github.com/username_0/es6-promise-pool-typescript",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "timdp",
"comment_id": 324960765,
"datetime": 1503676276000,
"masked_author": "username_1",
"text": "Hmm, I'm curious why it worked for @bcherny then.\r\n\r\nWe use TypeScript at work though. I'll ask someone on my team next week just to make sure we don't break anything. :slightly_smiling_face:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urish",
"comment_id": 324962223,
"datetime": 1503676577000,
"masked_author": "username_0",
"text": "Awesome, thanks!\r\n\r\nFeel free to ping me if anything. And thanks for this awesome library, I recently used it in a project and it was a perfect fit",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jimthedev",
"comment_id": 350478647,
"datetime": 1512833612000,
"masked_author": "username_2",
"text": "Hi there, any update to this? Currently seems like for ts/es6/cjs purposes many are switching away from default exports since it just makes things easier.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Aankhen",
"comment_id": 390425992,
"datetime": 1526756839000,
"masked_author": "username_3",
"text": "FWIW, I have the same problem trying to use it with TypeScript and the PR fixed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "urish",
"comment_id": 665456619,
"datetime": 1596003522000,
"masked_author": "username_0",
"text": "Closing due to inactivity.",
"title": null,
"type": "comment"
}
] | 5 | 9 | 2,880 | false | true | 2,696 | true |
Animatron/player | Animatron | 84,106,467 | 312 | {
"number": 312,
"repo": "player",
"user_login": "Animatron"
} | [
{
"action": "opened",
"author": "shamansir",
"comment_id": null,
"datetime": 1433264327000,
"masked_author": "username_0",
"text": "Now masks take the element's band into consideration + their rendering time now corresponds with their own jumps and repeat-modes.",
"title": "Masks fixes",
"type": "issue"
},
{
"action": "created",
"author": "shamansir",
"comment_id": 108014953,
"datetime": 1433264399000,
"masked_author": "username_0",
"text": "I merge this one too, to test it in a live `test` environment, but it's still a subject to review.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 228 | false | false | 228 | false |
pybuilder/pybuilder | pybuilder | 190,082,650 | 421 | null | [
{
"action": "opened",
"author": "AlexeySanko",
"comment_id": null,
"datetime": 1479397451000,
"masked_author": "username_0",
"text": "Into distutils_plugin.py hardcoded [\"clean\", \"--all\"] for each distutils_commands. And we cannot use results one step into next steps.\r\nMy particular case: I need specific shebang into script into wheel. But setuptools replace shebang for all scripts by default from build machine. I can avoid it though sequence call:\r\n```\r\npython setup.py build -e '/opt/python2.7/bin/python'\r\npython setup.py bdist_wheel\r\n```\r\nI expected it with next params:\r\n```\r\nproject.set_property('distutils_commands', ['build', 'bdist_wheel'])\r\nproject.set_property('distutils_command_options', {'build': ('--executable', '/opt/python2.7/bin/python')})\r\n```\r\n\r\nBy by fact I got next commands\r\n```\r\npython setup.py clean --all build -e '/opt/python2.7/bin/python'\r\npython setup.py clean --all bdist_wheel\r\n```\r\nAnd bdist_wheel re-build package with incorrect shebang.\r\nI have possibility to call \"clean --all\" through 'distutils_command_options' property and do not see reasons for hardcode it. Also we have task clean which remove /target directory\r\n\r\ndistutils_plugin.py\r\n```\r\n...\r\nexecute_distutils(project, logger, commands, True)\r\n...\r\nexecute_distutils(project, logger, upload_cmd_line, True)\r\n...\r\ndef execute_distutils(project, logger, distutils_commands, clean=False):\r\n...\r\n for command in distutils_commands:\r\n....\r\n with open(output_file_path, \"w\") as output_file:\r\n...\r\n if clean:\r\n commands.extend([\"clean\", \"--all\"])\r\n...\r\n```",
"title": "Pybuilder clean build derictory after each distutils command",
"type": "issue"
},
{
"action": "created",
"author": "AlexeySanko",
"comment_id": 261287295,
"datetime": 1479398521000,
"masked_author": "username_0",
"text": "Expected result produce next properties:\r\n```\r\nproject.set_property('distutils_commands', 'build')\r\nproject.set_property('distutils_command_options',\r\n {'build': ('-e', '/opt/python2.7/bin/python', 'bdist_wheel')})\r\n```\r\nIn this case which advantages of usage different distutils_commands isolated?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arcivanov",
"comment_id": 261533584,
"datetime": 1479476352000,
"masked_author": "username_1",
"text": "Aren't shebangs supposed to be resolved by the installer at the installation time, especially for a wheel (PEP-0427, PEP-0491)?\r\n\r\nThe reason that `clean --all` is used is to ensure that if you're generating multiple packages (bdist_wheel vs dumb vs bdist) that the \"build/\" directory doesn't cross-contaminate the builds. Some use absolute paths, some use relative.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlexeySanko",
"comment_id": 261570047,
"datetime": 1479485368000,
"masked_author": "username_0",
"text": "I expected the same result, but on develop and target machine I had python by /opt/python2.7/bin/python. On build machine (with Jenkins) - basic Python. And on target host I got incorrect interpreter error (shebung was #!python).\r\nSo in this case it's expected behavior and we just should add it to documentation [distutils_commands property](http://pybuilder.github.io/documentation/plugins.html#BuildingaPythonpackage). We can add project property which can regular it (like \"distutils_clean_between_commands with default True), but it could be overloading of properties.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arcivanov",
"comment_id": 261570824,
"datetime": 1479485563000,
"masked_author": "username_1",
"text": "@username_0 irrespective of this bug, what you probably are experiencing are old versions of setuptools, pip or both.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlexeySanko",
"comment_id": 261579099,
"datetime": 1479487382000,
"masked_author": "username_0",
"text": "On target host:\r\npip (8.1.2)\r\nsetuptools (22.0.5)\r\nOn build:\r\npip (9.0.1)\r\nsetuptools (28.8.0)\r\n\r\nIn this case target host looks like not a very fresh, :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arcivanov",
"comment_id": 261579773,
"datetime": 1479487544000,
"masked_author": "username_1",
"text": "To say the least ;) I suspect that's why your shebang doesn't get properly massaged.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlexeySanko",
"comment_id": 261580619,
"datetime": 1479487731000,
"masked_author": "username_0",
"text": "Anyway hardcoded [clean -all] is unexpected and cannot be managed. How we can at least add it to documentation?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arcivanov",
"comment_id": 261583766,
"datetime": 1479488443000,
"masked_author": "username_1",
"text": "The documentation is very outdated. I'll add this to the queue. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlexeySanko",
"comment_id": 338587384,
"datetime": 1508747859000,
"masked_author": "username_0",
"text": "Created into doc repo: https://github.com/pybuilder/pybuilder.github.io/issues/37",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "AlexeySanko",
"comment_id": null,
"datetime": 1508747859000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 11 | 3,333 | false | false | 3,333 | true |
shader-slang/slang | shader-slang | 243,709,188 | 115 | null | [
{
"action": "opened",
"author": "nbenty",
"comment_id": null,
"datetime": 1500383217000,
"masked_author": "username_0",
"text": "[Blit.ps.glsl.txt](https://github.com/shader-slang/slang/files/1155911/Blit.ps.glsl.txt)\r\n[MySlang.slang.txt](https://github.com/shader-slang/slang/files/1155910/MySlang.slang.txt)\r\n\r\n(remove the `.txt`. GitHub wouldn't let me upload the slang/glsl files)\r\n\r\nSlang declares the textures in struct like so:\r\n```C++\r\nlayout(binding = 1)\r\nuniform texture2DArray SLANG_parameterBlock_PerFrameCB_gCsmData_shadowMap[4];\r\nlayout(binding = 2)\r\nuniform sampler SLANG_parameterBlock_PerFrameCB_gCsmData_csmSampler[4];\r\n```\r\n\r\nBut binding (1) is already used by `gSampler`. The issue is that the location is computed relative to the constant-buffer binding (I confirmed that it can be fixed by changing the CB binding).\r\n\r\nThis is another thing we need to solve before the release, as CSM uses texture-in-array-of-struct. Slang/glslang gives no indication that something went wrong and the user will have a hard time debugging it.",
"title": "Incorrect binding calculation for textures in array-of-structs",
"type": "issue"
},
{
"action": "created",
"author": "tangent-vector",
"comment_id": 316073626,
"datetime": 1500386610000,
"masked_author": "username_1",
"text": "What is the behavior you'd expect? It looks to me like the Slang compiler is doing exactly what you told if to, and the problem is that the original problem has overlapping bindings.\r\n\r\nTo put it in terms of a simpler example, suppose I had:\r\n\r\n```\r\nstruct S { Texture2D a; Texture2D b; };\r\n\r\nlayout(binding = 0) S foo;\r\nlayout(binding = 1) S bar;\r\n```\r\n\r\nIn this case `foo.b` and `bar.a` will both have the same binding, but that is just because Slang did what the user said. I can try to issue an error on this (and I really will try to do that once I have time to work on it), but I can't go and move bindings around - the user told me what they expected.\r\n\r\nIn Slang's view of the world, a `cbuffer` is really no different from a `struct` variable at global scope. This means that whatever bindings it uses will always be sequential, and if the user gave us an explicit starting binding, we'll respect it.\r\n\r\nIf there is something else you think Slang should do, let me know. Unfortunately, having Slang allocate bindings for stuff inside a CB independent of the CB itself is pretty much not possible.\r\n\r\nI can see a few workarounds:\r\n- Don't use explicit bindings on a CB that contains a `Material` or similar\r\n- Use an explicit binding, but put the CB in its own set, or *after* anything else explicit in the same set\r\n- I expect the implementation in Slang won't handle it, but it would be nice if you could just specify a `set` (no `binding`) and have Slang put the CB off by itself.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nbenty",
"comment_id": 316115362,
"datetime": 1500394400000,
"masked_author": "username_0",
"text": "Duplicate of #96",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nbenty",
"comment_id": null,
"datetime": 1500394400000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 2,428 | false | false | 2,428 | false |
Adobe-Marketing-Cloud/aem-sites-example-custom-template-type | Adobe-Marketing-Cloud | 179,302,719 | 1 | {
"number": 1,
"repo": "aem-sites-example-custom-template-type",
"user_login": "Adobe-Marketing-Cloud"
} | [
{
"action": "opened",
"author": "gdoublev",
"comment_id": null,
"datetime": 1474914465000,
"masked_author": "username_0",
"text": "Added \"cq:template\" property so that _Initial Content_ and _Layouting_ views also work while editing the \"my-template\" template. Presently, after a clean install, you can only edit the _Structure_ of the \"my-template\" template.",
"title": "Updated my-template's .content.xml",
"type": "issue"
},
{
"action": "created",
"author": "bpauli",
"comment_id": 396938274,
"datetime": 1528896736000,
"masked_author": "username_1",
"text": "@username_0 Thank you for your contribution!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 269 | false | false | 269 | true |
caskroom/homebrew-versions | caskroom | 240,324,528 | 4,100 | {
"number": 4100,
"repo": "homebrew-versions",
"user_login": "caskroom"
} | [
{
"action": "opened",
"author": "commitay",
"comment_id": null,
"datetime": 1499150139000,
"masked_author": "username_0",
"text": "After making all changes to the cask:\n\n- [x] `brew cask audit --download {{cask_file}}` is error-free.\n- [x] `brew cask style --fix {{cask_file}}` left no offenses.\n- [x] The commit message includes the cask’s name and version.\n\nAdditionally, if **updating a cask**:\n\n- [ ] [If the `sha256` changed but the `version` didn’t](https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md#updating-the-sha256),\n provide public confirmation by the developer: {{link}}",
"title": "Update sourcetree-beta to 2.6b1",
"type": "issue"
},
{
"action": "created",
"author": "commitay",
"comment_id": 312794861,
"datetime": 1499150951000,
"masked_author": "username_0",
"text": "Strange, `appcast` is working now but I'm getting different `sha256` locally compared to travis.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 603 | false | false | 603 | false |
ohyou/twitch-viewer | null | 224,016,105 | 27 | null | [
{
"action": "opened",
"author": "Helpmenowpleaseandthanks",
"comment_id": null,
"datetime": 1493093584000,
"masked_author": "username_0",
"text": "I have Generated my own API\r\nUsed 2 Accounts to Generate Different API linked to different Twitch Accounts\r\nUsed 2 Commands with differnet API using 10 Different Verified Proxies in each script\r\nUsed 1 Command on Second PC and VPN and Used other command on First PC on normal IP address\r\n\r\nWont go Past 10 Viewers? Any fix for this?",
"title": "Wont go past 10 Viewers?",
"type": "issue"
},
{
"action": "created",
"author": "dforcen",
"comment_id": 298235921,
"datetime": 1493563100000,
"masked_author": "username_1",
"text": "Same problem, maybe it's because of twitch or the channel",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Nikay19",
"comment_id": 299317241,
"datetime": 1493934073000,
"masked_author": "username_2",
"text": "Yeah same for me, anyone found a solution for that?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ohyou",
"comment_id": null,
"datetime": 1506184474000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ohyou",
"comment_id": 331648454,
"datetime": 1506184474000,
"masked_author": "username_3",
"text": "I'm closing this issue because the project is currently not maintained and it will unlikely to be resolved. \r\nFor more, please read this: https://github.com/username_3/twitch-viewer/blob/master/README.md#project-state",
"title": null,
"type": "comment"
}
] | 4 | 5 | 654 | false | false | 654 | true |
dlang/phobos | dlang | 129,722,763 | 3,960 | {
"number": 3960,
"repo": "phobos",
"user_login": "dlang"
} | [
{
"action": "opened",
"author": "yebblies",
"comment_id": null,
"datetime": 1454062147000,
"masked_author": "username_0",
"text": "I don't think it's possible to unittest this without making excessive assumptions.\r\n\r\nhttps://issues.dlang.org/show_bug.cgi?id=15621",
"title": "Issue 15621 - std.file.rename does not allow moving files to a different drive",
"type": "issue"
},
{
"action": "created",
"author": "wilzbach",
"comment_id": 239719548,
"datetime": 1471229615000,
"masked_author": "username_1",
"text": "Can someone assign the decision to Andrei? Seems like we need a judge & final decision :/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andralex",
"comment_id": 284265325,
"datetime": 1488750197000,
"masked_author": "username_2",
"text": "Cool, I assume the Posix version already has the capability.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "braddr",
"comment_id": 284969577,
"datetime": 1488958824000,
"masked_author": "username_3",
"text": "Removed the auto-merge tag since the presumption is false.\r\n@username_2 posix does not rename across disks, see the feb 2 comment from @schuetzm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andralex",
"comment_id": 285777449,
"datetime": 1489178080000,
"masked_author": "username_2",
"text": "Eh, in that case we need to get the Posix version done. An implementation with diverging capabilities on different OSs does more harm than good. @username_0 please reopen when up for it, thx!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yebblies",
"comment_id": 285930819,
"datetime": 1489308367000,
"masked_author": "username_0",
"text": "Ok, implementing the posix fallback should be easy since copy and delete are already part of this module.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "marler8997",
"comment_id": 378416016,
"datetime": 1522793521000,
"masked_author": "username_4",
"text": "@username_0 \r\n\r\nI ran into this problem with http://github.com/username_4/rund It looks like you were going to modify this PR to also work on POSIX...are you able to do that and finish this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jmdavis",
"comment_id": 378448756,
"datetime": 1522804669000,
"masked_author": "username_5",
"text": "I don't have a Linux system to test this behavior at the moment, but I can guarantee that FreeBSD won't rename across filesystems, and I run into this problem fairly often. AFAIK, the only way to make this work in general is to try `rename`, and then if it fails, try to copy the file and then delete the original. But at this point, if we do something like that, I think that it should probably be a new function which is explicit about this behavior - particularly since the name `rename` carries with it certain expectations (particularly for those familiar with POSIX), and changing the current behavior could have unexpected consequences in existing code.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jmdavis",
"comment_id": 378450165,
"datetime": 1522805204000,
"masked_author": "username_5",
"text": "Honestly, I'd rather have a new function, particularly since the behavior of `rename` carries with it the implication of `CanCopy.no`, and it's way more verbose to have to pass a flag for what is arguably the default behavior that many folks will want. The other nasty question here is what to do about directories. With `rename`, you can move a directory, and it's not a problem, but with a function designed to actually move a file and not just rename it, moving a directory could entail recursively copying the directory and the deleting the original. I'd be tempted to argue that we should punt on that and just add `moveFile` which only works on files and not directories.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "marler8997",
"comment_id": 378451462,
"datetime": 1522805672000,
"masked_author": "username_4",
"text": "https://github.com/dlang/phobos/pull/6417",
"title": null,
"type": "comment"
}
] | 6 | 10 | 2,287 | false | false | 2,287 | true |
devfd/react-native-google-signin | null | 160,403,948 | 88 | null | [
{
"action": "opened",
"author": "karolsojko",
"comment_id": null,
"datetime": 1465991708000,
"masked_author": "username_0",
"text": "I think I did everything according to the Readme - the app runs and works, but when I click the Google Sign In button it crashes - what I can see in the logs is:\r\n\r\n```\r\nHelloWorldApp[75023:1475420] *** Terminating app due to uncaught exception \r\n'NSInvalidArgumentException', reason: 'uiDelegate must either be a |UIViewController| \r\nor implement the |signIn:presentViewController:| and |signIn:dismissViewController:| methods from |GIDSignInUIDelegate|.'\r\n```\r\n\r\nDoes anyone have any idea how to fix this?",
"title": "[iOS] uiDelegate is not a UIViewController",
"type": "issue"
},
{
"action": "created",
"author": "karolsojko",
"comment_id": 226210108,
"datetime": 1466001978000,
"masked_author": "username_0",
"text": "I've been able to fix this with a custom `ViewController.h` and `ViewController.m` - so the part from Google Docs https://developers.google.com/identity/sign-in/ios/sign-in#add_the_sign-in_button - should be added as a reference to the docs",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "devfd",
"comment_id": 232860989,
"datetime": 1468559431000,
"masked_author": "username_1",
"text": "@username_0 thanks for reporting this. Any chance you can set up a public repo or best a PR so that I can look into it ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tomeng728",
"comment_id": 235294984,
"datetime": 1469545122000,
"masked_author": "username_2",
"text": "@username_0 Seeing the same error here! What do you mean by customer ViewController files?\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "karolsojko",
"comment_id": 236120520,
"datetime": 1469779774000,
"masked_author": "username_0",
"text": "@username_2 I used this repo as a refference and copied ViewControllers or most of their contents https://github.com/googlesamples/google-services/tree/master/ios/signin/SignInExample",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "khuong291",
"comment_id": 264054708,
"datetime": 1480556941000,
"masked_author": "username_3",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joaofranca",
"comment_id": 287386896,
"datetime": 1489764687000,
"masked_author": "username_4",
"text": "@username_0 can you be a little more specific? My problem is not copying/adapting the view controllers or the code, but in the context of react-native how does this all blend together?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jozan",
"comment_id": null,
"datetime": 1527365189000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jozan",
"comment_id": 392285121,
"datetime": 1527365189000,
"masked_author": "username_5",
"text": "This is quite old issue and we have not seen similar reports lately. If you experience this don't hesitate to create a new issue.",
"title": null,
"type": "comment"
}
] | 6 | 9 | 1,464 | false | false | 1,464 | true |
SumoLogic/sumologic-net-appenders | SumoLogic | 226,273,008 | 35 | {
"number": 35,
"repo": "sumologic-net-appenders",
"user_login": "SumoLogic"
} | [
{
"action": "opened",
"author": "TerribleDev",
"comment_id": null,
"datetime": 1493902832000,
"masked_author": "username_0",
"text": "* No more stylecop \r\n * We'll have to circle back and fix, but it keeps trying to load assemblies not found in the coreclr\r\n* Comment out xsltransform to convert nunit to junit \r\n * xsltransforms currently do not exist but will probably comeback when netstandard 2.0 comes back\r\n* Use the dotnet cli to compile and create packages\r\n* Move AssemblyInfo data to csproj files\r\n* Update log4net to target 2.0.8\r\n* Replace System.Timers.Timer with System.Threading.Timer as System.Timers.Timer is not in netstandard\r\n* Replace Thread.Sleep with Task.Delay as Thread.Sleep is not in netstandard 1.5\r\n* Move SumoLogic.Logging.Common to seperate package\r\n * The dotnet cli, and the msbuild based nuget pack tasks, do not allow you to easily package dependent project dlls. There are workarounds, but do not work with multiTarget builds, and honestly it feels like it should be a seperate package anyway.\r\n* Only console log on the Desktop CLR\r\n* Target NLog 5.0.0-beta7 only on the core clr\r\n * I kept the desktop on 4.x since NLog 5 is only in beta.\r\n* I did **not** port the tests projects. Mostly because they didn't need to be ported, and this was enough work as it is\r\n\r\n \r\nsee #19 and #22",
"title": "port2csproj + target core!",
"type": "issue"
},
{
"action": "created",
"author": "latkin",
"comment_id": 300014974,
"datetime": 1494284605000,
"masked_author": "username_1",
"text": "woot, this is on my list to review this week.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "latkin",
"comment_id": 300023989,
"datetime": 1494288166000,
"masked_author": "username_1",
"text": "Getting this when building with CI bat file first time:\r\n\r\n```\r\nDONE UPDATING NUGET PACKAGES\r\n\r\nBUILDING SOLUTION ...\r\n=====================\r\nMicrosoft (R) Build Engine version 15.1.548.43366\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\nC:\\src\\terribledev-sumologic-net-appenders\\SumoLogic.Logging.Log4Net.Tests\\SumoLogic.Logging.Log4Net.Tests.csproj(114,5): error : This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\\packages\\xunit.core.2.0.0\\build\\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\\xunit.core.props.\r\nC:\\src\\terribledev-sumologic-net-appenders\\SumoLogic.Logging.EnterpriseLibrary.Tests\\SumoLogic.Logging.EnterpriseLibrary.Tests.csproj(99,5): error : This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\\packages\\xunit.core.2.0.0\\build\\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\\xunit.core.props.\r\nC:\\src\\terribledev-sumologic-net-appenders\\SumoLogic.Logging.NLog.Tests\\SumoLogic.Logging.NLog.Tests.csproj(115,5): error : This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\\packages\\xunit.core.2.0.0\\build\\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\\xunit.core.props.\r\nC:\\src\\terribledev-sumologic-net-appenders\\SumoLogic.Logging.Common.Tests\\SumoLogic.Logging.Common.Tests.csproj(107,5): error : This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\\packages\\xunit.core.2.0.0\\build\\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\\xunit.core.props.\r\n```\r\n\r\nClears if I explicitly `./.nuget/nuget.exe restore` from repo root, but this should work out of the box.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300124907,
"datetime": 1494325825000,
"masked_author": "username_0",
"text": "its supposed to run dotnet restore before the build on this line here: https://github.com/SumoLogic/sumologic-net-appenders/pull/35/files#diff-6ee9f301d8821dfdceea09f2967f45a1R30",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300125232,
"datetime": 1494325922000,
"masked_author": "username_0",
"text": "@username_1 I can't repro the bad restore you previously mentioned. Do you have the newest version of the dotnet cli installed? In this file it should do a restore. Do you see that output when you run this? https://github.com/SumoLogic/sumologic-net-appenders/pull/35/files#diff-6ee9f301d8821dfdceea09f2967f45a1R30",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300126488,
"datetime": 1494326319000,
"masked_author": "username_0",
"text": "nvm I was able to repro it",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300127715,
"datetime": 1494326718000,
"masked_author": "username_0",
"text": "nvm I was able to repro it 568e54f",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300127825,
"datetime": 1494326761000,
"masked_author": "username_0",
"text": "Here is the issue related to stylecop https://github.com/StyleCop/StyleCop/issues/126",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300185503,
"datetime": 1494340674000,
"masked_author": "username_0",
"text": "@username_1 I pushed some updates\r\n\r\n* fix whitespace (I realized my text editor was set to tabs and not spaces) 17945c5 \r\n* fix restoring of both older style packages and newer ones\t568e54f",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "latkin",
"comment_id": 300913952,
"datetime": 1494536046000,
"masked_author": "username_1",
"text": "Awesome! Builds/tests clean, and sanity check on a desktop and .net core app both work great.\r\n\r\nThank you for the hard work to get this all together! I will get a new nuget package published soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300946116,
"datetime": 1494546383000,
"masked_author": "username_0",
"text": "@username_1 Holy CRAPPPPPPPPPPPPPPPPPPPPPP\r\n\r\nOk, so when can I expect my sumologic hoodie 😛",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 300946611,
"datetime": 1494546577000,
"masked_author": "username_0",
"text": "Just kidding, but thanks this is awesome.\r\n\r\ncc @username_2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "latkin",
"comment_id": 300973815,
"datetime": 1494559285000,
"masked_author": "username_1",
"text": "@username_0 let me see what we can do... 😉 \r\n\r\nQQ -- nuget yells at me b/c NLog package for .NET Core is still pre-release, but our package is (as it stands) marked stable.\r\n\r\nI am thinking I'll push 1.0.0.3 for Common + Log4Net, but push 1.0.0.3-beta1 for NLog so that one is marked pre-release. Is that the right way to do this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 301053906,
"datetime": 1494588931000,
"masked_author": "username_0",
"text": "@username_1 You can just set the version in the csproj to have that suffix. So just make the version say 1.0.0.3-beta1\r\n\r\nYou can also pass in versions on the command D line\r\n\r\ndotnet pack awesome.csproj /p:Version=1.0.0.3-beta1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TerribleDev",
"comment_id": 301054026,
"datetime": 1494588966000,
"masked_author": "username_0",
"text": "@username_1 that sounds like a solid plan btw",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "billpratt",
"comment_id": 301170802,
"datetime": 1494618854000,
"masked_author": "username_2",
"text": "Nice work!",
"title": null,
"type": "comment"
}
] | 3 | 16 | 5,239 | false | false | 5,239 | true |
mldbai/mldb | mldbai | 213,123,767 | 862 | {
"number": 862,
"repo": "mldb",
"user_login": "mldbai"
} | [
{
"action": "opened",
"author": "guyd",
"comment_id": null,
"datetime": 1489083898000,
"masked_author": "username_0",
"text": "",
"title": "[MLDB-2163] add support to call functions and query with POST",
"type": "issue"
},
{
"action": "created",
"author": "guyd",
"comment_id": 285446616,
"datetime": 1489086022000,
"masked_author": "username_0",
"text": "@username_1 What is missing?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FinchPowers",
"comment_id": 285447864,
"datetime": 1489086299000,
"masked_author": "username_1",
"text": "* routes /v1/query and /v1/functions must not to be modified.\r\n* route /v1/get must be added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jeremybarnes",
"comment_id": 286214997,
"datetime": 1489432873000,
"masked_author": "username_2",
"text": "+1 from me",
"title": null,
"type": "comment"
}
] | 3 | 4 | 132 | false | false | 132 | true |
milligram/milligram | milligram | 128,594,937 | 61 | null | [
{
"action": "opened",
"author": "voodah",
"comment_id": null,
"datetime": 1453743258000,
"masked_author": "username_0",
"text": "Everything looks very similar to Skeleton (http://getskeleton.com/). \r\n\r\nDid you take some inspiration from them?",
"title": "Similarity to Skeleton",
"type": "issue"
},
{
"action": "closed",
"author": "cjpatoilo",
"comment_id": null,
"datetime": 1453745027000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "cjpatoilo",
"comment_id": 174604925,
"datetime": 1453745027000,
"masked_author": "username_1",
"text": "Hi @username_0 \r\n\r\nSkeleton is a awesome reference but if look at the code you will see that the resemblance is related apelas by simplicity of design. \r\n\r\nSee this article, I'll tell him more about how this project began.\r\nhttps://medium.com/@username_1/milligram-a-minimalist-css-framework-e0496aea8167#.qaab27kgz",
"title": null,
"type": "comment"
}
] | 2 | 3 | 423 | false | false | 423 | true |
kenwheeler/slick | null | 106,584,205 | 1,731 | null | [
{
"action": "opened",
"author": "CandiceYap",
"comment_id": null,
"datetime": 1442331637000,
"masked_author": "username_0",
"text": "Please help, can slick carousel change the dots with text? like numbering 1 2 3... sample like : http://www.css-jquery-design.com/wp-content/uploads/2012/05/dg_slider-ultimate-jquery-content-slider-with-multiple-options.jpg Thanks!",
"title": "How can i change the dots to text? like numbering",
"type": "issue"
},
{
"action": "created",
"author": "kenwheeler",
"comment_id": 140442462,
"datetime": 1442332830000,
"masked_author": "username_1",
"text": "Using the customPaging option",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kenwheeler",
"comment_id": null,
"datetime": 1442332833000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 260 | false | false | 260 | false |
twbs/bootstrap | twbs | 8,084,744 | 5,782 | null | [
{
"action": "opened",
"author": "Merg1255",
"comment_id": null,
"datetime": 1351992411000,
"masked_author": "username_0",
"text": "Tooltips should allow an option to set the background color (currently #000 with opacity). It will be useful in many applications.",
"title": "Tooltip: Add color option",
"type": "issue"
},
{
"action": "created",
"author": "leecollings",
"comment_id": 471536632,
"datetime": 1552310688000,
"masked_author": "username_1",
"text": "Why not?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 138 | false | false | 138 | false |
rails/sprockets-rails | rails | 69,008,218 | 235 | null | [
{
"action": "opened",
"author": "rickpr",
"comment_id": null,
"datetime": 1429217791000,
"masked_author": "username_0",
"text": "`uname -a`\r\n```\r\nLinux centaurus 3.10.0-123.20.1.el7.x86_64 #1 SMP Thu Jan 29 18:05:33 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux\r\n```\r\nOS: CentOS Linux release 7.0.1406 (Core)\r\n\r\nThis also is present on Fedora 21, and Ubuntu 14.04.\r\n\r\n# Steps to reproduce:\r\n\r\nMake a new Rails application:\r\n```\r\nrails new my_app\r\n```\r\n\r\nAdd Twitter Bootstrap and Less Rails to the application (also uncomment `therubyracer`):\r\n``` ruby\r\ngem 'therubyracer'\r\ngem 'twitter-bootstrap-rails'\r\ngem 'less-rails'\r\n```\r\n\r\nInstall Bootstrap Less using the preconfigured generators:\r\n```\r\nrails g bootstrap install:less\r\nrails g bootstrap layout\r\n```\r\n\r\nNow, try to compile assets\r\n```\r\nrake assets:precompile\r\n```\r\nErrors:\r\n```\r\nNoMethodError: undefined method `[]' for nil:NilClass\r\n/home/fdisk/.rvm/gems/ruby-2.2.1/gems/less-rails-2.6.0/lib/less/rails/template_handlers.rb:37:in `config_paths'\r\n```\r\n\r\n# Workaround\r\nThis is because the `env.context_class.less_config` is set to `nil` by Sprockets. The `less-rails` Railtie makes this config variable, and I also tried writing an initializer but this gets destroyed when put into `Sprockets::CachedEnvironment`. Edit `~/.rvm/gems/ruby-2.2.1/gems/sprockets-3.0.1/lib/rake/sprocketstask.rb` and on line 147, add the following:\r\n``` ruby\r\nenv.context_class.less_config = app.config.less\r\n```\r\n\r\nYou may now precompile assets.\r\n\r\nI will try to find out why this variable gets lost. Currently I can't figure out how this is called.",
"title": "Can't use with Twitter Bootstrap Rails or Less Rails (with hacky workaround)",
"type": "issue"
},
{
"action": "created",
"author": "josh",
"comment_id": 93845344,
"datetime": 1429220213000,
"masked_author": "username_1",
"text": "I think the less railtie should probably be wrapping its access in an `config.assets.configure` block rather than an initializer here https://github.com/metaskills/less-rails/blob/master/lib/less/rails/railtie.rb#L21-L27",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "josh",
"comment_id": null,
"datetime": 1430885568000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,669 | false | false | 1,669 | false |
FaridSafi/react-native-gifted-chat | null | 213,841,523 | 396 | null | [
{
"action": "opened",
"author": "gperdomor",
"comment_id": null,
"datetime": 1489426334000,
"masked_author": "username_0",
"text": "Hi...\r\n\r\nCan you release a 0.1.4 version to get `renderAvatarOnTop` using yarn or npm without using the repository url?",
"title": "[Proposal] Release 0.1.4",
"type": "issue"
},
{
"action": "created",
"author": "kfiroo",
"comment_id": 289282132,
"datetime": 1490533543000,
"masked_author": "username_1",
"text": "@username_0 Sorry for the delay, I was AFK for a month now.\r\nI'll do it later this week",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "xcarpentier",
"comment_id": null,
"datetime": 1549969199000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 205 | false | false | 205 | true |
DevExpress/AjaxControlToolkit | DevExpress | 186,508,447 | 252 | {
"number": 252,
"repo": "AjaxControlToolkit",
"user_login": "DevExpress"
} | [
{
"action": "opened",
"author": "MikhailTymchukDX",
"comment_id": null,
"datetime": 1477998230000,
"masked_author": "username_0",
"text": "The current ChromeDriver produces an error starting with Chrome v.54: http://stackoverflow.com/q/40240299/644496\r\n\r\nChromeDriver v2.25 supports it.",
"title": "Update chromedriver.exe",
"type": "issue"
},
{
"action": "created",
"author": "AlekseyMartynov",
"comment_id": 257541925,
"datetime": 1477998853000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 2 | 2 | 151 | false | false | 151 | false |
typicode/lowdb | null | 107,657,139 | 67 | null | [
{
"action": "opened",
"author": "tosone",
"comment_id": null,
"datetime": 1442905255000,
"masked_author": "username_0",
"text": "i find another application changed the db, but anything has changed in this application, because all data is in the memory. I think refresh API is nessary.",
"title": "A refresh API?",
"type": "issue"
},
{
"action": "created",
"author": "typicode",
"comment_id": 142835042,
"datetime": 1443078181000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nCan you provide some code example of what you need or the problem?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "typicode",
"comment_id": 169549661,
"datetime": 1452141999000,
"masked_author": "username_1",
"text": "There's now a `db.read()` method. Thank you for the suggestion :+1:",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "typicode",
"comment_id": null,
"datetime": 1452141999000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "anthlasserre",
"comment_id": 398736598,
"datetime": 1529498928000,
"masked_author": "username_2",
"text": "@username_1 Can you join an user example of db.read() ?\r\nI don't really understand how it works, I just want to refresh all my database state after a db.get('test').push(data).write()",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "HeCorr",
"comment_id": 804515535,
"datetime": 1616462936000,
"masked_author": "username_3",
"text": "well, I'm a few years late but this is how to use it, in case anyone finds this: `db.read().get('whatever').push(data).write()`",
"title": null,
"type": "comment"
}
] | 4 | 6 | 613 | false | false | 613 | true |
gabdube/native-windows-gui | null | 256,479,776 | 51 | {
"number": 51,
"repo": "native-windows-gui",
"user_login": "gabdube"
} | [
{
"action": "opened",
"author": "zoumi",
"comment_id": null,
"datetime": 1505010221000,
"masked_author": "username_0",
"text": "",
"title": "Hide console window for the example in readme.md",
"type": "issue"
},
{
"action": "created",
"author": "gabdube",
"comment_id": 328315280,
"datetime": 1505010342000,
"masked_author": "username_1",
"text": "Yup. That is a good idea.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 25 | false | false | 25 | false |
AnalyticalGraphicsInc/cesium-concierge | AnalyticalGraphicsInc | 268,461,288 | 90 | {
"number": 90,
"repo": "cesium-concierge",
"user_login": "AnalyticalGraphicsInc"
} | [
{
"action": "opened",
"author": "ggetz",
"comment_id": null,
"datetime": 1508948353000,
"masked_author": "username_0",
"text": "`Path.join` does not preserve the `//` in for urls.\r\n\r\n@username_1",
"title": "Resolve urls properly",
"type": "issue"
},
{
"action": "created",
"author": "mramato",
"comment_id": 339387907,
"datetime": 1508948690000,
"masked_author": "username_1",
"text": "In general, using `path.join` for urls is a really bad idea. I think `url.resolve` will do what you want. `url.resolve('http://example.com/', '/one') // 'http://example.com/one'`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ggetz",
"comment_id": 339388371,
"datetime": 1508948775000,
"masked_author": "username_0",
"text": "Yep, that's what I updated it to. 👍 Lesson learned.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mramato",
"comment_id": 339388534,
"datetime": 1508948806000,
"masked_author": "username_1",
"text": "Whoops, totally misread the diff 😄 sorry.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 337 | false | false | 337 | true |
rackerlabs/repose | rackerlabs | 140,255,106 | 1,495 | {
"number": 1495,
"repo": "repose",
"user_login": "rackerlabs"
} | [
{
"action": "opened",
"author": "Mario-Lopez",
"comment_id": null,
"datetime": 1457720342000,
"masked_author": "username_0",
"text": "Updated pom.xml to target Java 8.",
"title": "Java 8",
"type": "issue"
},
{
"action": "created",
"author": "wdschei",
"comment_id": 196344163,
"datetime": 1457966647000,
"masked_author": "username_1",
"text": "This is already part of [REP-3166](https://github.com/rackerlabs/repose/blob/REP-3166_UpgradeScala2-10to2-11/pom.xml#L82-L92).",
"title": null,
"type": "comment"
}
] | 2 | 2 | 159 | false | false | 159 | false |
formix/infernal-engine | null | 128,584,968 | 12 | null | [
{
"action": "opened",
"author": "formix",
"comment_id": null,
"datetime": 1453740777000,
"masked_author": "username_0",
"text": "The `load` method will take one object as a parameter.\r\n\r\nWithin that object:\r\n* values will be added as facts at their corresponding context and name.\r\n* functions will be added as rules at their corresponding context and name.",
"title": "Add the `load` method",
"type": "issue"
},
{
"action": "closed",
"author": "formix",
"comment_id": null,
"datetime": 1454177091000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 228 | false | false | 228 | false |
androidannotations/androidannotations | androidannotations | 245,171,163 | 2,028 | null | [
{
"action": "opened",
"author": "ahornerr",
"comment_id": null,
"datetime": 1500921495000,
"masked_author": "username_0",
"text": "* Try:\r\nRun with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.\r\n\r\nBUILD FAILED in 1s\r\n13 actionable tasks: 1 executed, 12 up-to-date\r\n```\r\n\r\n[Link to full modified build.gradle](https://gist.github.com/username_0/3a82d3958a79621d520c4284392a3f17)\r\n\r\nChecking the generated path that the error spits out, `androidannotations/examples/kotlin/build/generated/source/kapt/some_flavorDebug/` is empty. \r\n\r\nUp a level at `androidannotations/examples/kotlin/build/generated/source/kapt/` there is an `androidannotations.log` file with the following contents:\r\n\r\n```\r\n14:31:52.154 [RMI TCP Connection(51)-127.0.0.1] ERROR o.a.i.h.AndroidManifestFinder:147 - Could not find the AndroidManifest.xml file, using generation folder [androidannotations/examples/kotlin/build/generated/source/kapt/some_flavorDebug])\r\n```\r\n\r\n#### AndroidAnnotations version:\r\n4.4.0-SHAPSHOT\r\n\r\n#### Android compile SDK version:\r\n25",
"title": "'Could not find the AndroidManifest.xml file' error using AA 4.4.0-SNAPSHOT and Android Gradle plugin 3.0.0-alpha7 with productFlavors",
"type": "issue"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317537919,
"datetime": 1500926558000,
"masked_author": "username_1",
"text": "Thanks for the detailed bug report! Is this happening if you do not use\nkotlin? Where is the generated full manifest is at in your case?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahornerr",
"comment_id": 317538743,
"datetime": 1500926753000,
"masked_author": "username_0",
"text": "It looks like the generated manifest is at `androidannotations/examples/kotlin/build/intermediates/manifests/full/some_flavor/debug/AndroidManifest.xml` but not in the `generated`folder.\r\n\r\nI haven't tested without kotlin but I can tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahornerr",
"comment_id": 317816645,
"datetime": 1501005093000,
"masked_author": "username_0",
"text": "@username_1 Swapping out `kapt` for `annotationProcessor`, disabling the `kotlin-apt` Gradle plugin, it appears to work.\r\n\r\nIt seems like kapt may be the issue here. I'm also getting a warning for both `kapt` and `annotationProcessor`:\r\n\r\n```\r\nwarning: The following options were not recognized by any processor: '[resourcePackageName]'\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahornerr",
"comment_id": 317820762,
"datetime": 1501005947000,
"masked_author": "username_0",
"text": "It appears that the `resourcePackageName` annotation processor issue is related to the Android Gradle plugin, see: https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#variant_api\r\n\r\nThis breaks my current workflow because each of my application flavors have different application IDs.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317859962,
"datetime": 1501014001000,
"masked_author": "username_1",
"text": "The application ID may be different, but your resource package name should\nbe the same (this is the package where the R file is generated). In all my\nprojects I have the same Workflow as you. Moreover, I think the linked\nchange is not related to this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317860451,
"datetime": 1501014108000,
"masked_author": "username_1",
"text": "Thanks for the details. Please ignore that warning, it is a false positive,\nand was always displayed.\n\n@username_2 I thought we fixed this for kapt. WDYT?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dodgex",
"comment_id": 317956884,
"datetime": 1501049114000,
"masked_author": "username_2",
"text": "@username_1 yes, but @username_0 states that the manifests are now generated in `build/intermediates/manifests/full/some_flavor/debug/AndroidManifest.xml` instead of `build/generated/source/[k]apt`. Maybe google changed the ouput directories once again.\r\n\r\nWe should investigate this, maybe we need to enhance/update the `GradleAndroidManifestFinderStrategy`. :/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317974445,
"datetime": 1501054762000,
"masked_author": "username_1",
"text": "I found what is the problem. We still have the `kapt` block which tries to set the manifest according to the `variant`. @username_0 is right, this is not working anymore. However, we already find the manifest automatically, configuring the `androidManifestFile` in the `kapt` block is not necessary. I tried it, if you remove the `kapt` block, it will compile!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dodgex",
"comment_id": 317975183,
"datetime": 1501054968000,
"masked_author": "username_2",
"text": "Not sure what you mean with `kapt` block?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317976201,
"datetime": 1501055250000,
"masked_author": "username_1",
"text": "@username_2 eh, i missed the most important thing, the flavor. It is still not working.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317986133,
"datetime": 1501057827000,
"masked_author": "username_1",
"text": "Okay, i see what is the problem now... The Java annotation processor uses this generation folder in the end: `flavor/buildtype` . However `kapt` uses this generation folder : `flavorBuildtype`. This is pretty tricky, because we have to parse the variant name into the two parts in some way...\r\n\r\nI will report this to the Kotlin guys, maybe way agree to change this directory to be in par with the Java one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "WonderCsabo",
"comment_id": 317988296,
"datetime": 1501058366000,
"masked_author": "username_1",
"text": "I created [this](https://youtrack.jetbrains.com/issue/KT-19245) issue. Let's see if they are willing to change this. If not, we have to come up with a workaround.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dodgex",
"comment_id": 318023800,
"datetime": 1501067680000,
"masked_author": "username_2",
"text": "I voted for the issue. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahornerr",
"comment_id": 318043791,
"datetime": 1501073527000,
"masked_author": "username_0",
"text": "I was hoping it would be possible to hook into the Android Gradle variants API to fetch the generated manifest path but unfortunately it's the same broken API that is throwing the `resourcePackageName` error. We may need to wait for the Android build team to fix the variants API first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahornerr",
"comment_id": 318151146,
"datetime": 1501095779000,
"masked_author": "username_0",
"text": "I did a bit more testing, getting my project back to a stable state with an older version of the Android Gradle plugin. Using v2.3.1 and the following `kapt` configuration, I have AA v4.4.0-SNAPSHOT working.\r\n\r\n```groovy\r\nkapt {\r\n arguments {\r\n arg(\"androidManifestFile\", variant.outputs[0].processResourcesTask.manifestFile)\r\n arg(\"resourcePackageName\", android.defaultConfig.applicationId)\r\n }\r\n}\r\n```\r\n\r\nBoth of these arguments are necessary - without either of them the build will fail.\r\n\r\nKnowing that these two arguments are necessary, and that the Android Gradle plugin variants API is broken, it makes sense why AA isn't working for me with the 3.0.0-alpha plugin.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "WonderCsabo",
"comment_id": null,
"datetime": 1501405843000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 17 | 4,801 | false | false | 4,801 | true |
indexzero/nconf | null | 152,802,072 | 220 | null | [
{
"action": "opened",
"author": "deveras",
"comment_id": null,
"datetime": 1462289103000,
"masked_author": "username_0",
"text": "Hi guys, \r\n\r\nI've tried nconf and loved it!\r\nIt would be great to be able to use with \"child_process\" execFile() and phantomjs, I tried but it complains about a few things (like the absense of __dirname). If you guys get it working let me know how, I would love to use it again. Apologies for not coding it myself\r\n\r\nBest regards",
"title": "phantomjs",
"type": "issue"
}
] | 1 | 1 | 329 | false | false | 329 | false |
angular-actioncable/angular-actioncable | angular-actioncable | 151,789,352 | 21 | {
"number": 21,
"repo": "angular-actioncable",
"user_login": "angular-actioncable"
} | [
{
"action": "opened",
"author": "Neil-Ni",
"comment_id": null,
"datetime": 1461902722000,
"masked_author": "username_0",
"text": "https://github.com/angular-actioncable/angular-actioncable/issues/19\r\n- switched from\r\n```\r\nActionCableSocketWrangler.connected()\r\nActionCableSocketWrangler.connecting()\r\nActionCableSocketWrangler.disconnected()\r\n```\r\nto\r\n```\r\nActionCableSocketWrangler.connected\r\nActionCableSocketWrangler.connecting\r\nActionCableSocketWrangler.disconnected\r\n```",
"title": "chore: switch wrangler connection status to properties",
"type": "issue"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 215775804,
"datetime": 1461945429000,
"masked_author": "username_1",
"text": "This is great!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "b264",
"comment_id": 215809531,
"datetime": 1461949120000,
"masked_author": "username_2",
"text": "Thank you",
"title": null,
"type": "comment"
}
] | 3 | 3 | 368 | false | false | 368 | false |
dinukadesilva/music-ctrls | null | 166,633,910 | 53 | null | [
{
"action": "opened",
"author": "simonbates",
"comment_id": null,
"datetime": 1469034740000,
"masked_author": "username_0",
"text": "On Firefox, it is only possible to initiate change with the mouse if the mouse cursor is positioned in the range of approximately 45% to 55%. Outside that range, it is not possible to initiate change of the value with the mouse.\r\n\r\nThis issue does not appear on Chrome.",
"title": "[Knob] Mouse control on Firefox only works when value approximately 45% - 55%",
"type": "issue"
},
{
"action": "created",
"author": "dinukadesilva",
"comment_id": 234467319,
"datetime": 1469169990000,
"masked_author": "username_1",
"text": "@username_0 Can you provide more details about this...... because it seems the knob is working very well in firefox for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "simonbates",
"comment_id": 234572942,
"datetime": 1469200795000,
"masked_author": "username_0",
"text": "This appears to be working for me now -- maybe another change has fixed?\r\n\r\nI'll close this issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "simonbates",
"comment_id": null,
"datetime": 1469200795000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "simonbates",
"comment_id": 235654713,
"datetime": 1469639687000,
"masked_author": "username_0",
"text": "I'm still seeing this on my home computer (but not my work computer, which is weird).\r\n\r\nComputer that I'm seeing the issue on:\r\n\r\n- Firefox 47.0\r\n - No extensions\r\n - Plugins: OpenH264 Video Codec\r\n- Ubuntu 16.04.1 LTS",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "simonbates",
"comment_id": null,
"datetime": 1469639689000,
"masked_author": "username_0",
"text": "On Firefox, it is only possible to initiate change with the mouse if the mouse cursor is positioned in the range of approximately 45% to 55%. Outside that range, it is not possible to initiate change of the value with the mouse.\r\n\r\nThis issue does not appear on Chrome.",
"title": "[Knob] Mouse control on Firefox only works when value approximately 45% - 55%",
"type": "issue"
},
{
"action": "created",
"author": "simonbates",
"comment_id": 237575770,
"datetime": 1470322001000,
"masked_author": "username_0",
"text": "Okay, we were able to figure this out. This issue is seen when the page zoom is increased in Firefox. At 100% page zoom, the controls act as desired. When the page zoom is increased, say to 200%, the controls have problems.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dinukadesilva",
"comment_id": 238774891,
"datetime": 1470809590000,
"masked_author": "username_1",
"text": "@username_0 @sepidehshahi\r\n\r\nThis issue has been fixed now, Could you please verify this again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "simonbates",
"comment_id": 239274658,
"datetime": 1470945741000,
"masked_author": "username_0",
"text": "Yes, I confirm that I am no longer seeing this issue. I verified at 200% zoom on Firefox.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dinukadesilva",
"comment_id": null,
"datetime": 1470972846000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 10 | 1,387 | false | false | 1,387 | true |
markmarkoh/datamaps | null | 221,225,000 | 390 | null | [
{
"action": "opened",
"author": "pierpaolocira",
"comment_id": null,
"datetime": 1491994523000,
"masked_author": "username_0",
"text": "Ok, I know there is the possibility to add custom topojson maps, but I think it would be great to directly provide users with more than two maps.\r\nOk for world and USA, but what about starting with Europe and eventually move forward?",
"title": "Add other scopes",
"type": "issue"
},
{
"action": "created",
"author": "Chalkin",
"comment_id": 401383493,
"datetime": 1530284894000,
"masked_author": "username_1",
"text": "Plus 1 for this. Would love to see scopes for South America, Asia, Africa, Europe and Australie/Indonesia.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "HanandaIZ",
"comment_id": 466782332,
"datetime": 1551018781000,
"masked_author": "username_2",
"text": "can someone please answer this, i need this too",
"title": null,
"type": "comment"
}
] | 3 | 3 | 386 | false | false | 386 | false |
dresende/node-orm2 | null | 119,712,195 | 679 | {
"number": 679,
"repo": "node-orm2",
"user_login": "dresende"
} | [
{
"action": "opened",
"author": "stueynz",
"comment_id": null,
"datetime": 1448974685000,
"masked_author": "username_0",
"text": "Another bug fix when using mapsTo on PK properties. We have to adjust PK property names to matching database name (using mapsTo field in property definition) when setting up JOIN for Many association.\r\n\r\nOtherwise the ON part of the JOIN clause will have the property name instead of the database field name when doing the select.",
"title": "Ensure hasMany() associations work when properties have mapsTo",
"type": "issue"
},
{
"action": "created",
"author": "dxg",
"comment_id": 161102624,
"datetime": 1449005670000,
"masked_author": "username_1",
"text": "Awesome, thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dxg",
"comment_id": 161107193,
"datetime": 1449006749000,
"masked_author": "username_1",
"text": "Released 2.1.28 with this changed.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 382 | false | false | 382 | false |
stefankroes/ancestry | null | 225,302,525 | 331 | null | [
{
"action": "opened",
"author": "vovimayhem",
"comment_id": null,
"datetime": 1493524937000,
"masked_author": "username_0",
"text": "I'm working on a legacy-code project running on Rails 3.2.21, and I'm currently isolating problems with rspec, spring & postgres.\r\n\r\nSeveral gems in the project are adding modules to `ActiveRecord::Base` on load phase, and somehow this is attempting a connection before spring's forking of processes.... which in turn it causes the app to raise the following error whenever I run rspec with the app already preloaded on spring:\r\n\r\n```\r\nActiveRecord::StatementInvalid:\r\n PG::ConnectionBad: PQsocket() can't get socket descriptor: SELECT tablename\r\n FROM pg_tables\r\n WHERE schemaname = ANY (current_schemas(false))\r\n```\r\n\r\nI suspect this is no longer the case on Rails >= 4.x.\r\n\r\nIs there a particular reason why [`lib/ancestry/has_ancestry.rb`] is using `class << ActiveRecord::Base` to add the `has_ancestry` method instead of using a module & adding it to `ActiveRecord::Base` inside an `ActiveSupport.on_load` hook? I think this is in fact what's causing all the trouble (for me, at least)",
"title": "Problem with rails 3.2.x, postgres & spring: PG::ConnectionBad: PQsocket() can't get socket descriptor",
"type": "issue"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 298359454,
"datetime": 1493653851000,
"masked_author": "username_1",
"text": "think this is fixed by 332.\r\n\r\nLet me know if this is still a problem",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kbrock",
"comment_id": null,
"datetime": 1493653852000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,093 | false | false | 1,093 | false |
mikepenz/FastAdapter | null | 211,993,169 | 358 | null | [
{
"action": "opened",
"author": "eygraber",
"comment_id": null,
"datetime": 1488755409000,
"masked_author": "username_0",
"text": "Realm recently added support for fine grained notifications, and updated their adapter library to make use of them - https://github.com/realm/realm-android-adapters/pull/83",
"title": "Support fine grained notifications in realm",
"type": "issue"
},
{
"action": "created",
"author": "FabianTerhorst",
"comment_id": 284271693,
"datetime": 1488755690000,
"masked_author": "username_1",
"text": "this is part of https://github.com/username_3/FastAdapter/pull/294",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RJFares",
"comment_id": 285059852,
"datetime": 1488984391000,
"masked_author": "username_2",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mikepenz",
"comment_id": null,
"datetime": 1489407785000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mikepenz",
"comment_id": 286092335,
"datetime": 1489407785000,
"masked_author": "username_3",
"text": "Close as it will be solved in v3",
"title": null,
"type": "comment"
}
] | 4 | 5 | 270 | false | false | 270 | true |
baldurk/renderdoc | null | 180,858,736 | 384 | {
"number": 384,
"repo": "renderdoc",
"user_login": "baldurk"
} | [
{
"action": "opened",
"author": "michaelrgb",
"comment_id": null,
"datetime": 1475577439000,
"masked_author": "username_0",
"text": "",
"title": "Tool menu option to start the Android remote server.",
"type": "issue"
},
{
"action": "created",
"author": "michaelrgb",
"comment_id": 251354679,
"datetime": 1475577727000,
"masked_author": "username_0",
"text": "Maybe we could move this button into a device-specific menu somewhere?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michaelrgb",
"comment_id": 251637526,
"datetime": 1475662971000,
"masked_author": "username_0",
"text": "I took out the Process.WaitForExit() so the user can still interact with the main GUI without closing the cmd window. \r\n\r\nI was intending for the user to close the cmd window first, but its opened in the correct directory, so its very useful for then typing subsequent android_capture commands.",
"title": null,
"type": "comment"
}
] | 1 | 3 | 364 | false | false | 364 | false |
jupyter/nbgrader | jupyter | 47,991,891 | 35 | null | [
{
"action": "opened",
"author": "jhamrick",
"comment_id": null,
"datetime": 1415295860000,
"masked_author": "username_0",
"text": "This is very much a wishlist item, but it would be awesome to somehow be able to autograde markdown cells that have simple and clear solutions.",
"title": "Autograding markdown cells",
"type": "issue"
},
{
"action": "created",
"author": "oarriaga",
"comment_id": 302038323,
"datetime": 1495013680000,
"masked_author": "username_1",
"text": "Hello @username_0 is there any updates on this issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jhamrick",
"comment_id": 305012972,
"datetime": 1496179508000,
"masked_author": "username_0",
"text": "@username_1 No, unfortunately -- as mentioned this is a wishlist item, which effectively means it's something we're not planning to address anytime in the near future (but if someone else wanted to implement it, it's a feature we'd be happy to have in nbgrader).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "psychemedia",
"comment_id": 576206905,
"datetime": 1579515778000,
"masked_author": "username_2",
"text": "Picking up on this issue, we're exploring the possibility of autograding free text answers, provided via markdown cells.\r\n\r\nOne possible architecture would be to support grading of free text markdown cells, if we could find a way to introspect on a notebook's markdown cells.\r\n\r\nThe text could either be handled by loading in a package and using it to autograde the free text, or by passing the text to a third party service API and getting a grade back: `response = markFreeText(ANSWER)`. \r\n\r\nMarkdown answer cells could be tagged as `studentTextAnswer` cells to simplify discovery and retrieval.\r\n\r\nBut I'm not sure a code in a notebook can easily introspect the content of markdown cells in the same notebook (at least, not directly).\r\n\r\nA second approach might be to parse the notebook JSON, run tests on particular (markdown) cells and inject the marks back in to the notebook.\r\n\r\nThis also suggests a third, more general approach, of a marking service. My understanding is that `nbgrader` uses `nbconvert` to run the notebooks, but what if a grading service instead loaded the JSON and then processed either all on only gradeable cells according to some sort of policy.\r\n\r\nThis requires stepping back from thinking about the notebook as a linear notebook, and instead thinking about it as a container for assessment answers.\r\n\r\nFor example, you might want to execute some cells in their own shell so there is no confusion about state. On the other hand, you might want some cells to run in the same context (perhaps identifying those cells using cell tags). Or you might want to run all the cells in the notebook in the same context (i.e. run the notebook *as a notebook*. (We could achieve this manually, for example by adding a `%%python` shell magic at the top of a cell in the first case, or using something like the [`execution_dependencies`](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/tree/master/src/jupyter_contrib_nbextensions/nbextensions/execution_dependencies) extension in the second case.\r\n\r\nSo rather than preprocess a notebook and then execute it using `nbconvert` tools, the idea would be to load in the notebook as a JSON files then work through it, deciding in turn for each cell what to do with it.\r\n\r\nThis approach perhaps also suggests a new way of looking at the `nbgrader` marking process, perhaps in terms of a process that:\r\n\r\n1. accepts one or more notebooks for one or more students.\r\n2. passes them to a marking service.\r\n\r\nThe marking service then marks the notebooks and returns them as marked notebooks.\r\n\r\nWith suitable protocols defined, the marking service could be a local marking service or it could be a remote, batch execution service. So for example, I might run a central grading service, and separate `nbgrader` \"clients\" could then submit notebooks to that service for grading, and retrieve marked scripts from the grading service.\r\n\r\nThis would separate concerns, seeing `nbgrader` more as a co-ordinator running in a JupyterHub instance, managing release and collection of scripts, *then passing them to a separate, external service for grading*, retrieving the graded scripts and managing them locally again.\r\n\r\nI'm not sure if the way `nbgrader` is architected already supports this sort of operation? But what it would do would open the ability to separate student notebook management from the actual assessment / grading service.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 3,861 | false | false | 3,861 | true |
pybel/pybel-tools | pybel | 249,646,706 | 110 | null | [
{
"action": "opened",
"author": "cthoyt",
"comment_id": null,
"datetime": 1502460468000,
"masked_author": "username_0",
"text": "1. Overlay differential gene expression. Apply cutoff for significantly up-regulated, down-regulated, and un-regulated genes\r\n2. Look for statements that match (up-regulated increases up-regulated, up-regulated decreases down-regulated, etc.)\r\n3. Calculate summary statistics over network\r\n\r\nCouple to a pipeline for stratifying a graph by an annotation (neurommsig subgraph usually) then provide total summary.\r\n\r\nWhat's the distribution of correct/(correct + incorrect + ambiguous) over all subgraphs?",
"title": "Network concordance algorithm",
"type": "issue"
},
{
"action": "closed",
"author": "cthoyt",
"comment_id": null,
"datetime": 1502473077000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 503 | false | false | 503 | false |
Bookworm-project/BookwormDB | Bookworm-project | 134,411,910 | 94 | null | [
{
"action": "opened",
"author": "organisciak",
"comment_id": null,
"datetime": 1455746105000,
"masked_author": "username_0",
"text": "Unless I'm mistaken, the API won't be accessible across domains in Javascript. It would be really nice to support JSONP, then clients (the GUI foremost) don't have to be on the same system as the API.\r\n\r\nA search for \"python jsonp\" returned a JSONP extension for Flask. So, for the path of least resistance, I'll extend the Flask-based minimal server that I wrote a few weeks ago with that library. However, since we seemed in agreement that my Flask implementation overlaps with `bookworm server` and will eventually be pulled out, we should discuss how to implement it into the regular `dbbindings.py`.\r\n\r\nThat is, unless I'm mistaken about there not being support currently.",
"title": "JSONP support",
"type": "issue"
},
{
"action": "created",
"author": "organisciak",
"comment_id": 185427771,
"datetime": 1455746576000,
"masked_author": "username_0",
"text": "Assigning to myself, at least for the band-aid approach of extending the Flask implementation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "borice",
"comment_id": 185427928,
"datetime": 1455746607000,
"masked_author": "username_1",
"text": "You should consider using CORS.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bmschmidt",
"comment_id": 185751881,
"datetime": 1455806846000,
"masked_author": "username_2",
"text": "So CORS would be a solution lying entirely in the webserver configuration?\r\n\r\nOne note: A full implementation of JSONP will require fulfilling the split in [this issue](https://github.com/Bookworm-project/BookwormAPI/issues/15), since you would also want a JSONP version of the book arrays.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bmschmidt",
"comment_id": 185754607,
"datetime": 1455807222000,
"masked_author": "username_2",
"text": "A third option would be to extend the `general_API` class to make a call over the web to a different host. The client wouldn't even know.\r\n\r\n1. Allow a 'host' field in the API.\r\n2. If 'host' is specified and not `localhost` or a synonym, then instead of running the query locally just build the url for where the query is going (without `host` as a term this time). Then just pass through the results to the client.\r\n\r\nThis is probably slower than the other two results unless there's some nice way to just route the results through an internet connection rather than processing them on python on the intermediate server, but might be the easiest to implement.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "borice",
"comment_id": 185783644,
"datetime": 1455810274000,
"masked_author": "username_1",
"text": "@username_2 To use CORS all you have to do is set appropriate headers in your API response. The rest is up to the web browser. All modern browsers I came across support it...\r\n\r\nHere's a Python example of how to set those to allow requests from everywhere:\r\n` # set CORS headers\r\n response.headers['Access-Control-Allow-Origin'] = '*'\r\n response.headers['Access-Control-Allow-Methods'] = 'GET, POST, PUT, OPTIONS'\r\n response.headers['Access-Control-Allow-Headers'] = 'Origin, Accept, Content-Type, ' \\\r\n 'X-Requested-With, X-CSRF-Token'`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "organisciak",
"comment_id": 185846012,
"datetime": 1455819752000,
"masked_author": "username_0",
"text": "Boris, thanks, CORS is a more elegant solution than JSONP.\n\nI tested it with a local GUI on my PC accessing a server-based API and it\nworks great. Ben, unless you have objections, I'll commit the update to\ndbbindings.py.\n\nRegarding Ben's earlier message, changing the host is useful for two real\nbut different issues. The first is changing the host in the client, which\nwe're working on at the moment for the BookwormGUI. This is necessary even\nfor the same server because sometimes you may want the API to be in a\ndifferent location than `cgi-bin/dbbindings.py`. The second is changing the\nmysql host for the API, which we have a ticket on already. This one I'm\ndriving on because in the Docker implementation, the DB is never on\nlocalhost, regardless of whether it's on the same machine or not.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bmschmidt",
"comment_id": 185849179,
"datetime": 1455820144000,
"masked_author": "username_2",
"text": "Thanks Boris and Peter.\r\n\r\nCORS sounds like the best solution to me. Patch welcomed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "organisciak",
"comment_id": 185974073,
"datetime": 1455836873000,
"masked_author": "username_0",
"text": "Added in 35cf1ef.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "organisciak",
"comment_id": null,
"datetime": 1455836873000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 10 | 3,291 | false | false | 3,291 | true |
scisoft/autocmake | scisoft | 93,911,442 | 26 | {
"number": 26,
"repo": "autocmake",
"user_login": "scisoft"
} | [
{
"action": "opened",
"author": "ihrasko",
"comment_id": null,
"datetime": 1436397458000,
"masked_author": "username_0",
"text": "Added test in lib/config.py to testing at AppVeyor.\r\nAdapted build info for Windows and MinGW compilers - use mingw32-make.\r\nAdded example to docs how to download update.py file on Windows with Git tools.",
"title": "add test to appveyor, adapt build info, docs update",
"type": "issue"
},
{
"action": "created",
"author": "bast",
"comment_id": 121163260,
"datetime": 1436861815000,
"masked_author": "username_1",
"text": "Ivan, I really appreciate your contributions but I need to ask you to submit unrelated changes\r\nas separate pull requests (in this case I agree with the first two changes but not fully with third change and this makes it impossible for me to integrate your change). Also please do not use your username in the commit message. This is not needed since every commit carries meta info and it is also non-standard. Thank you for your understanding.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bast",
"comment_id": 121164885,
"datetime": 1436862211000,
"masked_author": "username_1",
"text": "In expectation of separate PRs, I am closing this one.\r\nAgain, thank you for your work and understanding but it is IMO\r\nbetter if we do things properly right from the start.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bast",
"comment_id": 121168104,
"datetime": 1436863289000,
"masked_author": "username_1",
"text": "http://www.contribution-guide.org/#version-control-branching",
"title": null,
"type": "comment"
}
] | 2 | 4 | 881 | false | false | 881 | false |
1000ch/whale | null | 224,256,629 | 12 | null | [
{
"action": "opened",
"author": "vitorgalvao",
"comment_id": null,
"datetime": 1493150794000,
"masked_author": "username_0",
"text": "I’ve tested this on the last two versions of Whale. Auto-updating does not seem to work. Are you sure it’s set up correctly?\r\n\r\nSpecifically, is the app signed? Because [Whale needs to be signed for auto-updating to work](https://github.com/electron/electron/blob/master/docs/api/auto-updater.md#macos).",
"title": "Are you sure auto-updating is correctly set up?",
"type": "issue"
},
{
"action": "created",
"author": "1000ch",
"comment_id": 297214534,
"datetime": 1493171451000,
"masked_author": "username_1",
"text": "Whale.app seems to be signed correctly, but [update feed does not work well](https://github.com/username_1/whale/blob/master/update.js#L47). It's a problem of json server, not of this app 😢",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vitorgalvao",
"comment_id": 297851906,
"datetime": 1493330637000,
"masked_author": "username_0",
"text": "What about hosting the JSON in this repo? Would that not work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "1000ch",
"comment_id": 297882663,
"datetime": 1493342751000,
"masked_author": "username_1",
"text": "@username_0 Nice idea, I'll try.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "1000ch",
"comment_id": 320442057,
"datetime": 1501937539000,
"masked_author": "username_1",
"text": "Finally fixed from `v0.10.3`.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "1000ch",
"comment_id": null,
"datetime": 1501937541000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 612 | false | false | 612 | true |
gpoore/minted | null | 123,319,943 | 99 | null | [
{
"action": "opened",
"author": "gpoore",
"comment_id": null,
"datetime": 1450718141000,
"masked_author": "username_0",
"text": "`obeytabs` is incompatible with `breaklines`. The fundamental problem is that `fancyvrb`'s implementation of `obeytabs` uses `\\FV@TrueTab`, which uses `\\hbox` and conflicts with the line breaking code.\r\n\r\nThe discovery of the issue was prompted by [this TeX.SE question](http://tex.stackexchange.com/questions/283996/minted-fails-with-breaklines-and-obeytabs). **The next version of `minted` will give an error if `obeytabs` and `breaklines` are used together.**\r\n\r\nThe proper solution is to have code that scans the beginning of a line token by token, collecting `\\FV@Space` and `\\FV@Tab`, and replacing them with appropriate characters using appropriate tab stops. This is doable and shouldn't be terribly complex. However, it is different from the current approach used in `fancyvrb`, so it would require either a new verbatim package, or a significant patch of `fancyvrb`. Getting this to work with line breaking, particularly `breakanywhere`, could also be a little tricky in terms of making sure the order of operations is correct.\r\n\r\nIf there is an attempt to patch `fancyvrb`, it should be noted that the current use of tabs is also problematic in other ways. In particular, on line 605,\r\n```latex\r\n\\def\\FancyVerbFormatLine#1{\\FV@ObeyTabs{#1}}\r\n```\r\nThis means that redefining `\\FancyVerbFormatLine`, which should be a user command, will break tabbing. The proper way to do this is probably to have `\\FancyVerbFormatLine`, which applies to the entire line, and `\\FancyVerbFormatText`, which applies only to the text, and to use these two in such a way that their implementation doesn't interfere with the internals. Again, that could involve significant patching.\r\n\r\nA diff of changes made while trying to work around this is given below (this is off of 2eef990). Some of this may be useful in the future, but a completely different approach will probably be better.\r\n\r\n```diff\r\ndiff --git a/source/minted.sty b/source/minted.sty\r\nindex 56e8c2c..b788c23 100644\r\n--- a/source/minted.sty\r\n+++ b/source/minted.sty\r\n@@ -816,6 +816,7 @@\r\n \\let\\FV@Next=\\FV@GetLineIndent\r\n \\else\r\n \\let\\FV@Next=\\FV@CleanRemainingChars\r\n+ \\g@addto@macro{\\FV@LineIndentChars}{\\relax}%\r\n \\fi\r\n \\fi\r\n \\fi\r\n@@ -831,18 +832,29 @@\r\n \\gdef\\FV@Break@Scan{%\r\n \\@ifnextchar\\FV@EndBreak%\r\n {}%\r\n- {\\ifx\\@let@token$\\relax\r\n- \\let\\FV@Break@Next\\FV@Break@Math\r\n+ {\\ifx\\@let@token\\FV@Space\\relax\r\n+ \\let\\FV@Break@Next\\FV@Break@Whitespace\r\n \\else\r\n- \\ifx\\@let@token\\bgroup\\relax\r\n- \\let\\FV@Break@Next\\FV@Break@Group\r\n+ \\ifx\\@let@token\\FV@Tab\\relax\r\n+ \\let\\FV@Break@Next\\FV@Break@Whitespace\r\n \\else\r\n- \\let\\FV@Break@Next\\FV@Break@Token\r\n+ \\ifx\\@let@token$\\relax\r\n+ \\let\\FV@Break@Next\\FV@Break@Math\r\n+ \\else\r\n+ \\ifx\\@let@token\\bgroup\\relax\r\n+ \\let\\FV@Break@Next\\FV@Break@Group\r\n+ \\else\r\n+ \\let\\FV@Break@Next\\FV@Break@Token\r\n+ \\fi\r\n+ \\fi\r\n \\fi\r\n \\fi\r\n \\FV@Break@Next}%\r\n }\r\n \\endgroup\r\n+\\gdef\\FV@Break@Whitespace#1{%\r\n+ \\g@addto@macro{\\FV@Tmp}{#1}%\r\n+ \\FV@Break@Scan}\r\n \\begingroup\r\n \\catcode`\\$=3%\r\n \\gdef\\FV@Break@Math$#1${%\r\n@@ -935,8 +947,8 @@\r\n \\ifthenelse{\\boolean{FV@BreakAutoIndent}}%\r\n {\\hspace*{-\\wd\\FV@LineIndentBox}}%\r\n {}%\r\n- \\strut\\FancyVerbFormatText{%\r\n- \\FancyVerbBreakStart#1\\FancyVerbBreakStop}\\nobreak\\strut\r\n+ \\strut\\FancyVerbFormatText{\\expandafter\\FV@Break@ObeyTabs\\expandafter{%\r\n+ \\FancyVerbBreakStart#1\\FancyVerbBreakStop}}\\nobreak\\strut\r\n \\end{internallinenumbers*}\r\n }%\r\n \\ifdefempty{\\FancyVerbBreakSymbolRight}{}%\r\n@@ -957,6 +969,8 @@\r\n \\advance\\linewidth by -\\FV@FrameRule\r\n \\fi\r\n \\sbox{\\FV@LineBox}{\\FancyVerbFormatLine{\\FancyVerbFormatText{#1}}}%\r\n+ \\let\\FV@Break@ObeyTabs\\FV@ObeyTabs\r\n+ \\let\\FV@ObeyTabs\\relax\r\n \\ifdim\\wd\\FV@LineBox>\\linewidth\r\n \\setcounter{FancyVerbLineBreakLast}{0}%\r\n \\FV@SaveLineBox{#1}%\r\n@@ -972,10 +986,12 @@\r\n \\FV@LeftListNumber\r\n \\FV@LeftListFrame\r\n \\FancyVerbFormatLine{%\r\n- \\parbox[t]{\\linewidth}{\\noindent\\strut\\FancyVerbFormatText{#1}\\strut}}%\r\n+ \\parbox[t]{\\linewidth}{\\noindent\\strut%\r\n+ \\FancyVerbFormatText{\\FV@Break@ObeyTabs{#1}}\\strut}}%\r\n \\FV@RightListFrame\r\n \\FV@RightListNumber\r\n- \\fi}%\r\n+ \\fi\r\n+ \\let\\FV@ObeyTabs\\FV@Break@ObeyTabs}%\r\n \\hss}\\baselineskip\\z@\\lineskip\\z@}\r\n \\ifcsname KV@FV@linenos\\endcsname\\else\r\n \\define@booleankey{FV}{linenos}%\r\n```",
"title": "obeytabs and breaklines",
"type": "issue"
},
{
"action": "created",
"author": "gpoore",
"comment_id": 166390617,
"datetime": 1450724503000,
"masked_author": "username_0",
"text": "`obeytabs` also doesn't work with multiline comments (#88), so I'm renaming the issue to be broader.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gpoore",
"comment_id": 166404214,
"datetime": 1450728119000,
"masked_author": "username_0",
"text": "If this is resolved, then an option for customizing the tab character should be added. For example, see #98.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gpoore",
"comment_id": 229135147,
"datetime": 1467137678000,
"masked_author": "username_0",
"text": "The new [`fvextra` package](https://github.com/username_0/fvextra) fixes the incompatibility between `breaklines` and `obeytabs`. It also adds a `tab` option for redefining the tab character.\r\n\r\nThe incompatibility with tabs inside multiline comments remains. This might be resolved by having the `\\PYG` comment macros look ahead and relocate any leading whitespace. Another option would be to attempt a special version of `\\FV@TrueTab` that can handle this scenario correctly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gpoore",
"comment_id": 232691870,
"datetime": 1468508547000,
"masked_author": "username_0",
"text": "All of these tab issues are resolved in [v2.3](https://github.com/username_0/minted/releases/tag/v2.3). Essentially everything is fixed by [`fvextra`](https://github.com/username_0/fvextra), except that `obeytabs` doesn't use correct tab stops for tabs preceded by anything other than spaces or tabs. Fixing that is beyond what the current tab expansion algorithms can handle. There are notes about what would be required for a better algorithm in the `fvextra` implementation.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gpoore",
"comment_id": null,
"datetime": 1468508548000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 6 | 5,653 | false | false | 5,653 | true |
spinnaker/spinnaker | spinnaker | 262,423,820 | 2,007 | null | [
{
"action": "opened",
"author": "kiril-dayradzhiev",
"comment_id": null,
"datetime": 1507036697000,
"masked_author": "username_0",
"text": "*Cannot install spinnaker using halyard following you documentation -> https://www.spinnaker.io/setup/*\r\n\r\n\r\nCloud provider: *Openstack*\r\n\r\nEnvironment: *debianlocal*\r\n\r\nStorage: *Redis*\r\n\r\nDescription:\r\nI cannot install Spinnaker using halyard on Ubuntu 17.4, Ubuntu 16.4 and on Mac OS.\r\nUbuntu 17.4 issue: E: Unable to locate package spinnaker-igor\r\nroot cause: Failed to fetch https://dl.bintray.com/spinnaker-releases/debians/dists/zesty/spinnaker/binary-amd64/Packages\r\n\r\nUbuntu 16.4 issue: E: Unable to locate package spinnaker-igor\r\nroot cause: Failed to fetch https://dl.bintray.com/spinnaker-releases/debians/dists/xenial/spinnaker/binary-amd64/Packages\r\n\r\nMac OS - you are claiming that halyard and spinnaker supports it, but during the installation of spinnaker using halyard this is what I got:\r\nsudo hal deploy apply\r\nPassword:\r\n\r\nGet current deployment\r\nSuccess\r\n^ Apply deployment\r\n. Apply deployment\r\nApply deployment\r\nApply deployment\r\nSuccess\r\nRun hal deploy connect to connect to Spinnaker.\r\nNot a supported operating system: Darwin\r\nIt's recommended you use Ubuntu 14.04 or higher\r\n\r\n\r\n\r\nAlso your troubleshooting link is broken -> http://www.spinnaker.io/docs/troubleshooting-guide",
"title": "Cannot install spinnaker using halyard",
"type": "issue"
},
{
"action": "created",
"author": "kiril-dayradzhiev",
"comment_id": 334447537,
"datetime": 1507205936000,
"masked_author": "username_0",
"text": "It was also tested with Ubuntu 15.04(vivid), still not working. \r\nIt works only with Ubuntu 14.04(trusty). Requirements message could be changed from \"It's recommended you use Ubuntu 14.04 or higher\" to \"It's recommended you use only Ubuntu 14.04\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhilninawe",
"comment_id": 398698993,
"datetime": 1529489699000,
"masked_author": "username_1",
"text": "@username_0 : Are you able to solve this issue on mac?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kiril-dayradzhiev",
"comment_id": 398702415,
"datetime": 1529490526000,
"masked_author": "username_0",
"text": "Nope, and I didn’t try since the comment was posted.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fr34k8",
"comment_id": 401117747,
"datetime": 1530207980000,
"masked_author": "username_2",
"text": "dudes.. problem resides in /etc/apt/sources.list.d/halyard.list there is no release candidate for 17.xx or 15.xx ..\r\n\r\nbelow could work or the installer needs to be changed.. https://raw.githubusercontent.com/spinnaker/halyard/master/install/debian/InstallHalyard.sh\r\n\r\n`\r\n/etc/apt/sources.list.d/halyard.list\r\n\r\ndeb https://dl.bintray.com/spinnaker-releases/debians xenial spinnaker\r\n`\r\n\r\n`\r\nsudo dpkg -i spinnaker_0.82.0_all.deb\r\n`\r\n\r\n`\r\nsudo apt --fix-broken install\r\n`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fr34k8",
"comment_id": 407444029,
"datetime": 1532445367000,
"masked_author": "username_2",
"text": "@username_3 is there a chance to get a working `InstallSpinnaker.sh` script to 16.04 ? \r\n\r\n`sudo /opt/spinnaker_upstream/InstallSpinnaker.sh\r\nNot a supported version of Ubuntu\r\nVersion is 16.04 we require 14.04.x LT`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lwander",
"comment_id": 407449224,
"datetime": 1532446234000,
"masked_author": "username_3",
"text": "Unfortunately we stopped supporting that script a while ago (a little over a year). Where did you find a copy?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fr34k8",
"comment_id": 407672470,
"datetime": 1532506485000,
"masked_author": "username_2",
"text": "@username_3 it's in the upstream repo root, as you can see in my tree.. please remove that if not supported! \r\n\r\nbtw, as discussed here:\r\nhttps://github.com/spinnaker/spinnaker/issues/1544\r\n\r\nthere are few install scripts for halyard!\r\nthis one: `https://raw.githubusercontent.com/spinnaker/halyard/master/install/stable/InstallHalyard.sh`\r\n\r\nwhich does not work afterwards because of the incomplete `/lib/systemd/system/halyard.service`\r\n\r\n`halyard.service: Service lacks both ExecStart= and ExecStop= setting. Refusing.`\r\ninside the Debian package \r\n\r\nand this one:\r\n`https://raw.githubusercontent.com/spinnaker/halyard/master/install/debian/InstallHalyard.sh`\r\n\r\nwhich does not get `spinnaker` deb package and `spinnaker-halyard` package.. \r\n\r\nis there any consistent and reproducible way to get halyard to work ? \r\nmy favorite would be to use the Debian packages from \r\n`https://dl.bintray.com/spinnaker-releases/debians/dists/`\r\n\r\noh and btw why is the following mirror still existent ? \r\n`https://dl.bintray.com/spinnaker/debians/dists/` \r\n\r\nI thought, last mirror would be the mirror of choice, but my team mate told me about the first mirror .. its confusing..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lwander",
"comment_id": 407735619,
"datetime": 1532521268000,
"masked_author": "username_3",
"text": "It only fetches a JAR, puts in in your /opt directory, and writes a wrapper script when to start the daemon if it's not already running with calling `hal`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fr34k8",
"comment_id": 407748193,
"datetime": 1532524127000,
"masked_author": "username_2",
"text": "@username_3 that's cool 4 now! 😎 \r\n\r\ncould you tell us which wrapper it writes and where ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lwander",
"comment_id": 407750732,
"datetime": 1532524628000,
"masked_author": "username_3",
"text": "It writes to /usr/local/bin/hal the contents of https://github.com/spinnaker/halyard/blob/master/startup/debian/hal",
"title": null,
"type": "comment"
}
] | 4 | 11 | 3,881 | false | false | 3,881 | true |
TwilioDevEd/account-verification-csharp | TwilioDevEd | 155,312,519 | 4 | {
"number": 4,
"repo": "account-verification-csharp",
"user_login": "TwilioDevEd"
} | [
{
"action": "opened",
"author": "mosampaio",
"comment_id": null,
"datetime": 1463504962000,
"masked_author": "username_0",
"text": "",
"title": "Use period at the end of the sentence",
"type": "issue"
},
{
"action": "created",
"author": "acamino",
"comment_id": 219868164,
"datetime": 1463522629000,
"masked_author": "username_1",
"text": "@username_0 please update the step 3 (_ngrok_) to use bash. The result will look like:\r\n\r\n```bash\r\n ngrok http 25451 -host-header=\"localhost:25451\"\r\n```",
"title": null,
"type": "comment"
}
] | 2 | 2 | 152 | false | false | 152 | true |
travis-ci/travis-api | travis-ci | 161,155,919 | 277 | {
"number": 277,
"repo": "travis-api",
"user_login": "travis-ci"
} | [
{
"action": "opened",
"author": "svenfuchs",
"comment_id": null,
"datetime": 1466415808000,
"masked_author": "username_0",
"text": "This cleans out several parts of (vendored) travis-core, and moves some parts of it to `lib`.",
"title": "cleanup core",
"type": "issue"
},
{
"action": "created",
"author": "svenfuchs",
"comment_id": 227220870,
"datetime": 1466445823000,
"masked_author": "username_0",
"text": "tested on staging. looks alright!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "svenfuchs",
"comment_id": 227415354,
"datetime": 1466509333000,
"masked_author": "username_0",
"text": "Rolled production back. It doesn't seem to properly update the oauth scopes from GitHub when set to an empty Array on the console.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joecorcoran",
"comment_id": 227425966,
"datetime": 1466512511000,
"masked_author": "username_1",
"text": "PR looks sensible, as much as it possibly can with such a big diff. Is there any part of it you'd like to draw my attention to?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "svenfuchs",
"comment_id": 227427906,
"datetime": 1466513020000,
"masked_author": "username_0",
"text": "@username_1 the only commits that sort of change logic are these. they pull things out of the `User` activerecord callbacks, and move these calls to the endpoint instead:\r\n\r\n* https://github.com/travis-ci/travis-api/pull/277/commits/84ebb6b24ed5dcec499356c8be7aaaac226bcd58\r\n* https://github.com/travis-ci/travis-api/pull/277/commits/6603990fe4aa43beb932e90d7071b3e2894f4646\r\n\r\nthis is the only commit that changes actual behaviour (as seen from the outside) ... which i briefly discussed in slack https://travisci.slack.com/archives/teal/p1466509669000832\r\n\r\n* https://github.com/travis-ci/travis-api/pull/277/commits/25f74defe5e0d96371842bbe78561bde2cf37a2d\r\n\r\nall the rest is basically just:\r\n\r\n* moving around files\r\n* changing the namespace `Travis::Api` to `Travis::Api::Serialize` for the serializers that have been in core (we've kinda messed with that namespace by using the same one in travis-api and travis-core for different purposes, so i fixed that now)\r\n* changing test setups so that both suites can run in the same process",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "svenfuchs",
"comment_id": 227439226,
"datetime": 1466515713000,
"masked_author": "username_0",
"text": "For the sake of documenting this ... my motivation for moving the user sync and oauth scope tracking stuff out of the model was that:\r\n\r\nDuring merging the test suites for some reason that I haven't been able to understand the test suite suddenly started calling the GitHub API several times per test setup/teardown ... which I only noticed because the test runtimes suddenly quadrupled. I tracked this down to `track_github_oauth_scopes` being triggered all the time (per user created as part of the test setup) ... which then called the GitHub API to ask for the scopes.\r\n\r\nI figured it was both easier and cleaner to move this stuff out of the `User` model callbacks, and into the respective API endpoint.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 2,131 | false | false | 2,131 | true |
owen2345/camaleon-cms | null | 126,332,033 | 290 | null | [
{
"action": "opened",
"author": "Uysim",
"comment_id": null,
"datetime": 1452655211000,
"masked_author": "username_0",
"text": "I need multiple domain per site. Can you implement that ?\r\n\r\nThank before hand",
"title": "Multiple Domain Needed",
"type": "issue"
},
{
"action": "created",
"author": "owen2345",
"comment_id": 171251109,
"datetime": 1452681754000,
"masked_author": "username_1",
"text": "@username_0 \r\nPlease try this:\r\n- create an initializer in your project and add a method: cama_current_site_helper(args)\r\n- args is a Hash{site, request}\r\n- samples:\r\ndef cama_current_site_helper(args)\r\n args[:site] = Cama::Site.order(id: :asc).last.decorate\r\n # args[:site] = Cama::Site.find(10).last.decorate if args[:request].original_url.to_s.parse_domain == \"my_domain.com\"\r\n # args[:site] = Cama::Site.find_by_slug('my_domain_x').decorate if args[:request].original_url.to_s.parse_domain == \"my_domain_xx\"\r\nend",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "owen2345",
"comment_id": 171251190,
"datetime": 1452681779000,
"masked_author": "username_1",
"text": "Note: use master branch please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyjedi",
"comment_id": 172085865,
"datetime": 1452890077000,
"masked_author": "username_2",
"text": "This is a great tip, thanks! Definitely belongs in the Wiki. :-)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "owen2345",
"comment_id": null,
"datetime": 1461812060000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 687 | false | false | 687 | true |
Jasonette/JASONETTE-iOS | Jasonette | 265,678,590 | 279 | null | [
{
"action": "opened",
"author": "gliechtenstein",
"comment_id": null,
"datetime": 1508140935000,
"masked_author": "username_0",
"text": "There's a little bug with $lambda. \r\n\r\nIt happens only in a complicated situation so most people probably haven't experienced this yet, but it's important regardless.\r\n\r\nBasically happens when a function C triggers function B, which triggers function A. The return value of function A needs to propagate all the way back to function C when using `$return.success`, but that's not how it's working right now.\r\n\r\n```\r\n{\r\n \"C\": {\r\n \"trigger\": \"B\",\r\n \"success\": {\r\n \"type\": \"$render\"\r\n }\r\n },\r\n \"B\": {\r\n \"trigger\": \"A\",\r\n \"success\": {\r\n \"type\": \"$return.success\",\r\n \"options\": \"{{$jason}}\"\r\n }\r\n },\r\n \"A\": {\r\n \"type\": \"$network.request\",\r\n \"options\": {\r\n ...\r\n },\r\n \"success\": {\r\n \"type\": \"$return.success\",\r\n \"options\": \"{{$jason}}\"\r\n }\r\n }\r\n}\r\n```",
"title": "$lambda function call stack bug",
"type": "issue"
}
] | 1 | 1 | 814 | false | false | 814 | false |
agra-uni-bremen/metaSMT | agra-uni-bremen | 70,392,826 | 27 | null | [
{
"action": "opened",
"author": "hriener",
"comment_id": null,
"datetime": 1429790008000,
"masked_author": "username_0",
"text": "BOOST_AUTO_TEST_CASE( bvshl_long_sizet )\r\n{\r\n const unsigned w = 1407u;\r\n bitvector x = new_bitvector(w);\r\n bitvector y = new_bitvector(w);\r\n bitvector z = new_bitvector(w);\r\n assertion( ctx, equal( z, bvshl( x, y ) ) );\r\n BOOST_REQUIRE( solve(ctx) );\r\n}\r\n\r\n$ ./tests/direct_STP -t QF_BV/bvshl_long_sizet\r\nRunning 1 test case...\r\nFatal Error: CreateBVConst: trying to create bvconst using unsigned long long of width: \r\n1407\r\ndirect_STP: /home/development-vm/development/metaSMT/build/build/stp-git/lib/AST/ASTmisc.cpp:258: void stp::FatalError(const char*, const stp::ASTNode&, int): Assertion `false' failed.\r\nunknown location(0): fatal error in \"bvshl_long_sizet\": signal: SIGABRT (application abort requested)",
"title": "bvshl with long bitwidth fails in STP",
"type": "issue"
},
{
"action": "created",
"author": "hriener",
"comment_id": 95586804,
"datetime": 1429796149000,
"masked_author": "username_0",
"text": "Fixed in 15703f274ce8b40b6cc04e5cbd408515a8ee5b2a",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hriener",
"comment_id": 95615128,
"datetime": 1429801176000,
"masked_author": "username_0",
"text": "Fixed in 13310570e18cc8e35efe3e3a8590dceaef4ece1e",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hriener",
"comment_id": null,
"datetime": 1429801180000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 4 | 817 | false | false | 817 | false |
citelao/Spotify-for-Alfred | null | 196,256,535 | 82 | null | [
{
"action": "opened",
"author": "dillonplunkett",
"comment_id": null,
"datetime": 1482033024000,
"masked_author": "username_0",
"text": "I'm unable to set a country during initial setup, and seeing the following error in the debugger: \r\n\r\n`[2016-12-17 22:40:13][ERROR: action.script] 40:41: syntax error: Expected end of line but found “\"”. (-2741)` \r\n\r\nThe rest of the installation process works fine.",
"title": "Error when setting country during installation",
"type": "issue"
},
{
"action": "created",
"author": "eduwass",
"comment_id": 285540246,
"datetime": 1489107642000,
"masked_author": "username_1",
"text": "This is also happening to me:\r\n\r\n```\r\nStarting debug for 'Spotifious'\r\n\r\n[2017-03-10 01:58:48][ERROR: action.script] 40:41: syntax error: Expected end of line but found “\"”. (-2741)\r\n[2017-03-10 01:58:56][input.scriptfilter] <?xml version='1.0'?>\r\n<items>\r\n\r\n\t<item uid='1489107536-Welcome to Spotifious!' valid='no' autocomplete=''>\r\n\t\t<arg>null</arg>\r\n\t\t<title>Welcome to Spotifious!</title>\r\n\t\t<subtitle>You need to configure a few more things before you can use Spotifious.</subtitle>\r\n\t\t<icon>include/images/configuration.png</icon>\r\n\t</item>\r\n\r\n\r\n\t<item uid='1489107536-1. Set your country code' valid='no' autocomplete='Country Code ⟩'>\r\n\t\t<arg>null</arg>\r\n\t\t<title>1. Set your country code</title>\r\n\t\t<subtitle>Choosing the correct country code makes sure you can play songs you select.</subtitle>\r\n\t\t<icon>include/images/checked.png</icon>\r\n\t</item>\r\n\r\n\r\n\t<item uid='1489107536-2. Create a Spotify application' valid='yes' autocomplete=''>\r\n\t\t<arg>appsetup⟩</arg>\r\n\t\t<title>2. Create a Spotify application</title>\r\n\t\t<subtitle>Set up a Spotify application so you can search playlists!</subtitle>\r\n\t\t<icon>include/images/unchecked.png</icon>\r\n\t</item>\r\n\r\n\r\n\t<item uid='1489107536-3. Link your Spotify application' valid='no' autocomplete=''>\r\n\t\t<arg>applink⟩</arg>\r\n\t\t<title>3. Link your Spotify application</title>\r\n\t\t<subtitle>Connect your Spotify application to Spotifious to search your playlists.</subtitle>\r\n\t\t<icon>include/images/disabled.png</icon>\r\n\t</item>\r\n\r\n\r\n\t<item uid='1489107536-You can access settings easily.' valid='no' autocomplete=''>\r\n\t\t<arg>null</arg>\r\n\t\t<title>You can access settings easily.</title>\r\n\t\t<subtitle>Type `s` from the main menu.</subtitle>\r\n\t\t<icon>include/images/info.png</icon>\r\n\t</item>\r\n</items>\r\n[2017-03-10 01:59:05][input.scriptfilter] <?xml version='1.0'?>\r\n<items>\r\n\r\n\t<item uid='1489107545-Spain' valid='yes' autocomplete='Country Code ⟩Spain'>\r\n\t\t<arg>country⟩ES</arg>\r\n\t\t<title>Spain</title>\r\n\t\t<subtitle>Set your country to “ES.”</subtitle>\r\n\t\t<icon>include/images/dash.png</icon>\r\n\t</item>\r\n</items>\r\n[2017-03-10 01:59:06][input.scriptfilter] Processing output of 'action.revealfile' with arg 'country⟩ES'\r\n[2017-03-10 01:59:06][input.scriptfilter] Processing output of 'action.script' with arg 'country⟩ES'\r\n[2017-03-10 01:59:06][ERROR: action.script] 40:41: syntax error: Expected end of line but found “\"”. (-2741)\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "citelao",
"comment_id": 285922588,
"datetime": 1489294783000,
"masked_author": "username_2",
"text": "Hey! I made some changes that should fix the problem.\r\n\r\nYou can test them with the dev release, available here:\r\n\r\nhttps://github.com/username_2/Spotify-for-Alfred/tree/dev/dist\r\n\r\nCan you give it a shot for me?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dillonplunkett",
"comment_id": null,
"datetime": 1489324414000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dillonplunkett",
"comment_id": 285943793,
"datetime": 1489324414000,
"masked_author": "username_0",
"text": "Syntax Error and the Alfred 2/3 both gone!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "citelao",
"comment_id": 286208415,
"datetime": 1489431425000,
"masked_author": "username_2",
"text": "@username_0 @username_1 You may want to update to the latest master build! https://github.com/username_2/Spotify-for-Alfred/releases/tag/v0.13.2",
"title": null,
"type": "comment"
}
] | 3 | 6 | 3,040 | false | false | 3,040 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.