sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
7a435127f2841a052095c1d42a7b629900ea0120 | Tobias Bieniek | Tobias Bieniek | Add blueprint dependencies | add blueprint dependencies | 26 | false | false | 3 | true | true | true | emberjs | ember.js | 10,200 |
a96ccb87d4a67319f3cb1b912633713167e8f00f | Godfrey Chan | Godfrey Chan | Merge pull request #13057 from emberjs/component-helper
Glimmer dynamic components (component helpers) | merge pull request from emberjs/component-helper | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,201 |
bcd59877706b2091e1d5f0b73dbc1fd250c5253f | Godhuda | Godhuda | Glimmer dynamic components (component helpers)
The tests are copied from the (new) curly component tests. The first
test case has been split to test the dynamic component switching, but
this is otherwise just a straight port of the existing tests (which is
itself not the complete set of components tests we have).
As usual, we need to come back and port the rest of the tests.
The foundation for this feature is exhaustively matrix-tested in
Glimmer, including the component switch scenario. | glimmer dynamic components (component helpers) | 46 | false | false | 5 | false | false | false | emberjs | ember.js | 10,202 |
fce275bfc1055dd84640a2d4f876ab45b324b7b1 | Robert Jackson | Robert Jackson | Merge pull request #13049 from emberjs/fix-13045
[BUGFIX release] Fixes `{{#with proxy as |foo|}}` | merge pull request from emberjs/fix-13045 | 42 | true | false | 5 | true | true | false | emberjs | ember.js | 10,203 |
29943af019a2c96b657cb4d84c64f0c415695958 | Godfrey Chan | Godfrey Chan | Coercer array values too for correctness
As far as I can tell, this doesn’t have any meaningful effect in
practice. | coercer array values too for correctness | 40 | false | false | 6 | false | false | false | emberjs | ember.js | 10,204 |
1c8831e94b61821acac264d09b65d5ae9d18a833 | Godfrey Chan | Godfrey Chan | [BUGFIX release] Fixes `{{#with proxy as |foo|}}`
This fixes an issue in HTMLBars where passing a truthy proxy (i.e.
`{ isTruthy: true, ... }`) to `{{#with}}` would end up yielding
the literal `true` rather than the proxy itself.
The Glimmer implementation is unaffected by this bug.
Fixes #13045 | [bugfix release] fixes `{{#with proxy as |foo|}}` | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 10,205 |
7e807172f5f5cf6509af06634f91cc29d855ea4c | Godfrey Chan | Godfrey Chan | Merge pull request #13048 from emberjs/glimmer-each
Implement Ember semantics for Glimmer {{#each}} | merge pull request from emberjs/glimmer-each | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,206 |
e54a431dff8f917d2116dfd6b6ed87228949b216 | Godfrey Chan | Godfrey Chan | Finish porting {{#with}} tests to {{#each}}
Also cleaned up the {{#with}} tests a bit, e.g. remove duplicated tests,
following the mutation -> replacement cycle, etc | finish porting {{#with}} tests to {{#each}} | 43 | false | false | 6 | false | true | false | emberjs | ember.js | 10,207 |
f9588683fc8417cb544e3d3583efdc1ebb0fef63 | Godhuda | Godhuda | Re-enable failing conditional tests
These are fixed in tildeio/glimmer@2910a5b | re-enable failing conditional tests | 35 | false | false | 4 | false | true | false | emberjs | ember.js | 10,208 |
2733a56fb8d3bb71624c944cd03052b2974fbcec | Godhuda | Godhuda | Implement Ember semantics for Glimmer {{#each}}
As usual, we only ported enough tests to test the system is working, and
we need to finish porting the rest of the tests (we actually haven’t
looked into the existing each tests yet – we just borrowed the {{#with}}
tests as a starting point). However, since we are now sharing the same
basic test cases from the conditionals test, we already covered a lot of
ground from-the-get-go. | implement ember semantics for glimmer {{#each}} | 47 | false | false | 6 | false | true | false | emberjs | ember.js | 10,209 |
8b643c6eed9f6d0b1dd6091d9302244cae7bcd2d | Godfrey Chan | Godfrey Chan | Merge pull request #13047 from emberjs/refactor-conditionals-tests
Refactor the shared conditionals test cases | merge pull request from emberjs/refactor-conditionals-tests | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 10,210 |
84ac9b3ca53ee6369f4810fdd14d539bfeefa14b | Godhuda | Godhuda | Refactor the shared view test cases
* Extract the apply “generators” logic into a more generic function
which allows us to pre-mix the BASIC_*_TESTS into a super class,
instead of having to repeat that every time you call `moduleFor`.
* Extend the “generators” concept to a more generic (very basic) mixin
system, which allows us to separate the test cases into groups.
* Instead of hard coding `true` and `false` inside the test cases, go
through a getter that can be overridden by the subclasses.
* Restructure the conditionals test classes to achieve better layering.
* Test `{{#if}}/{{#unless}}` without inverse as a “matrix item” instead
of a single test case which should give us better coverage. (The trick
is to generate them as a pair in `templateFor`.)
Most of these work is to make it possible to reuse the basic test cases
for `{{#each}}` tests, which will come in a different PR. This is needed
because `{{#each}}` has different rules about truthiness than the
“toggling” conditional constructs. | refactor the shared view test cases | 35 | false | false | 6 | false | true | false | emberjs | ember.js | 10,211 |
58c9ff81dcd46b9809c513d954d056a4fdc5e589 | Robert Jackson | Robert Jackson | [FEATURE ember-htmlbars-local-lookup] Enable by default.
This was already enabled in 2.5.0-beta.1, but I forgot to pull that
commit into master also. | [feature ember-htmlbars-local-lookup] enable by default | 55 | false | false | 5 | false | false | false | emberjs | ember.js | 10,212 |
0f0482f2cdd6d824b9440b65c1a9389aeb574314 | Robert Jackson | Robert Jackson | [FEATURE ember-metal-ember-assign] Enable by default.
This was already enabled in 2.5.0-beta.1 branch, but I forgot to update
master also. | [feature ember-metal-ember-assign] enable by default | 52 | false | false | 5 | false | false | false | emberjs | ember.js | 10,213 |
386c65efa1ff8e2a8325081b9771f2daa2949c58 | Godfrey Chan | Godfrey Chan | Merge pull request #13043 from tildeio/failing-if-tests
Add some failing test cases for glimmer 2 conditionals | merge pull request from tildeio/failing-if-tests | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,214 |
913913ac922d36be0ccf67803ca32765b328a6ef | Godhuda | Godhuda | Add failing test cases for glimmer 2 conditionals | add failing test cases for glimmer 2 conditionals | 49 | false | false | 8 | true | true | true | emberjs | ember.js | 10,215 |
9dee81eb3845b73ec96ab102799fff425252f00c | Stefan Penner | Stefan Penner | Merge pull request #13041 from jbrown/patch-6
[DOC] Fix indent | merge pull request from jbrown/patch-6 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 10,216 |
86599ab7a9261925ba008b67e469adaf55767fcf | Justin Brown | Justin Brown | [DOC] Fix indent
Removed extra indent in the `didTransition` docs. | [doc] fix indent | 16 | false | false | 3 | false | false | false | emberjs | ember.js | 10,217 |
c7ddfb44c4978d5b983ff9f9bd68e449fc2295cf | Robert Jackson | Robert Jackson | Merge pull request #13031 from Panman8201/fix-create-mergedProperties-proto
[BUGFIX release] Fix mergedProperties at create time modifying proto | merge pull request from panman8201/fix-create-mergedproperties-proto | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 10,218 |
fa8751770ff707f38770a36193c761f5226b41d2 | Ryan Panning | Ryan Panning | [BUGFIX release] Fix mergedProperties at create time modifying proto
When `mergedProperties` are passed into an object at `.create()` time,
the objects prototype is inadvertently modified, which is then
reflected on all instances of the object. Simply passing in a new
object during `assign()` resolves this problem (per krisselden). Also
added a test for this use case, where `objA` results in 3 when the
proto is modified. Fixes #11714 | [bugfix release] fix mergedproperties at create time modifying proto | 68 | false | false | 9 | false | false | false | emberjs | ember.js | 10,219 |
9578667426e7f4a84792c9c11030aa27d6a4c516 | Robert Jackson | Robert Jackson | Merge pull request #13036 from emberjs/revert-13007-11252-update-ember-compare
Revert "[BUGFIX canary] Update Ember.compare to use operators" | merge pull request from emberjs/revert-13007-11252-update-ember-compare | 72 | true | false | 5 | true | true | false | emberjs | ember.js | 10,220 |
ef8622c7e7f89b398ae6a090af873550270f886b | Kris Selden | Kris Selden | Revert "[BUGFIX canary] Update Ember.compare to use operators" | revert "[bugfix canary] update ember.compare to use operators" | 62 | false | false | 8 | false | false | false | emberjs | ember.js | 10,221 |
036ff2fba75e7311aed1fd59e84ed943e733e552 | Robert Jackson | Robert Jackson | Merge pull request #13030 from emberjs/fix-legacy-addon-deprecations
[BUGFIX release] Fix legacy addon deprecations | merge pull request from emberjs/fix-legacy-addon-deprecations | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,222 |
59e9045d9784dcdafe1cbd164f042528848626dd | Godhuda | Godhuda | [BUGFIX release] Fix legacy addon deprecations
The signature of `Ember.deprecate` is `message`, `test`, `options`,
where `test` is `If falsy, the deprecation will be displayed.` Here,
we did the opposite, causing the deprecation message to be shown only
when the addons are NOT installed.
This commit fixes the issue, and also moved the deprecation to first-
boot. This gives users (and our test harness) a chance to register
custom handlers before we issue the warning.
Also added tests. | [bugfix release] fix legacy addon deprecations | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 10,223 |
57d8c36a12730a8926851a9d4168b869ffd059ef | Robert Jackson | Robert Jackson | Post release version bump. | post release version bump | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 10,224 |
dd6a1bdbd0a05a06d7e388052c5760c6336b1012 | Robert Jackson | Robert Jackson | Update CHANGELOG for 2.4/2.5 releases. | update changelog for 2.4/2.5 releases | 37 | false | false | 5 | true | true | true | emberjs | ember.js | 10,225 |
8364cde050c44b47e24d3ebae23a51f6696f656c | Robert Jackson | Robert Jackson | Fix stupid rule errors.
GGRRRRRR!!!!!! | fix stupid rule errors | 22 | false | false | 4 | true | true | true | emberjs | ember.js | 10,226 |
2bf4f1df3e11d50d0529ae88f8291d5c82b30904 | Robert Jackson | Robert Jackson | Merge pull request #13018 from chancancode/copy-glimmer-test-helpers
Don't depend on glimmer-test-helpers | merge pull request from chancancode/copy-glimmer-test-helpers | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,227 |
3fe509e71f7f99387e16d7769c57cdd254aab8d1 | Robert Jackson | Robert Jackson | Merge pull request #13015 from chancancode/deprecate-legacy-addons
Add deprecation for legacy addons | merge pull request from chancancode/deprecate-legacy-addons | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 10,228 |
346bdc34136cd3746995b4f80b5526c6117fbc41 | Robert Jackson | Robert Jackson | Merge pull request #13007 from duggiefresh/11252-update-ember-compare
[BUGFIX canary] Update Ember.compare to use operators | merge pull request from duggiefresh/11252-update-ember-compare | 63 | true | false | 5 | true | true | false | emberjs | ember.js | 10,229 |
e134483eccbb6de0bb283f0807d694ad64f26f45 | Matthew Beale | Matthew Beale | Merge pull request #13024 from kellyselden/patch-1
lookup router outside of setInterval | merge pull request from kellyselden/patch-1 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,230 |
c21321a2c6dde2688bb8f2cb3e0331d1d7b6ecef | Kelly Selden | Kelly Selden | lookup router outside of setInterval
minor optimization. | lookup router outside of setinterval | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 10,231 |
6b3411a19d91e87e43dc7335c0c7009ebca11174 | Godfrey Chan | Godfrey Chan | Don't depend on glimmer-test-helpers | don't depend on glimmer-test-helpers | 36 | false | false | 4 | false | false | false | emberjs | ember.js | 10,232 |
5c8018004a3a756f4a0f69a5347747c0a61f5759 | Godfrey Chan | Godfrey Chan | Add deprecation for legacy addons | add deprecation for legacy addons | 33 | false | false | 5 | true | true | true | emberjs | ember.js | 10,233 |
552e2840a1c48a09e528cfcfdbbb55ebe3f237cd | Godfrey Chan | Godfrey Chan | Merge pull request #13014 from chancancode/fix-jscs
Fix a few JSCS errors | merge pull request from chancancode/fix-jscs | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,234 |
185f2095412b7352558cfb21a0753daa82f07e65 | Godfrey Chan | Godfrey Chan | Fix a few JSCS errors | fix a few jscs errors | 21 | false | false | 5 | false | true | false | emberjs | ember.js | 10,235 |
e067234f1571b8a4fe8440cd3cfd36ed2652bb77 | Robert Jackson | Robert Jackson | Merge pull request #13013 from mixonic/bugfix-render-rerender
[BUGFIX release] Do not set model on {{render}} rerender | merge pull request from mixonic/bugfix-render-rerender | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,236 |
6083b25d05841d2c72e5e984fa62821f9e842e39 | Matthew Beale | Matthew Beale | [BUGFIX release] Do not set model on {{render rerender
Upon rerender of the {{render}} helper, the model was set to the value
of the second argument regardless of if there was a second argument.
This means upon rerender a singleton controller would lose its model.
Should be backported to 1.13 | [bugfix release] do not set model on {{render rerender | 54 | false | false | 9 | false | false | false | emberjs | ember.js | 10,237 |
c152e3f85dbfecec0efa732c1b194e1837ef6ea3 | Stefan Penner | Stefan Penner | Merge pull request #13000 from Turbo87/addon
Add basic ember-cli addon structure | merge pull request from turbo87/addon | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 10,238 |
81c75336c86876ee60dc26e75086b98d022b5b02 | Godfrey Chan | Godfrey Chan | Merge pull request #13008 from chancancode/glimmer-teardown
Implement Glimmer teardown | merge pull request from chancancode/glimmer-teardown | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,239 |
825b955778cb0ce7c56bc77807c8d1bfae20c785 | Godfrey Chan | Godfrey Chan | Re-enable this.$() tests in glimmer | re-enable this.$() tests in glimmer | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 10,240 |
a3e0d93b867c2b733c83f98b92be9daa8a511ec1 | Godfrey Chan | Godfrey Chan | Implement Glimmer Teardown | implement glimmer teardown | 26 | false | false | 3 | true | true | true | emberjs | ember.js | 10,241 |
13f0d2b4b06c8e620d4865578c9cd4cef55fa41a | Robert Jackson | Robert Jackson | Merge pull request #13010 from Serabe/patch-1
[BUGFIX beta] Fix documentation | merge pull request from serabe/patch-1 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 10,242 |
a5e845b1e2207a29f4a37441ecaea84d5ad0fb1a | Sergio Arbeo | Sergio Arbeo | Fix documentation
Currently, the `input` keyword cannot be used as a contextual component. This fixes the misleading documentation. | fix documentation | 17 | false | false | 2 | true | true | false | emberjs | ember.js | 10,243 |
1659f53c54cd34f5c39993b7b2aaa0da2e88e01b | Godfrey Chan | Godfrey Chan | Merge pull request #13009 from emberjs/merge-12920
Merge + minor cleanup for #12920 | merge pull request from emberjs/merge-12920 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,244 |
952c4b8e3eb17432d6a2da1a067aea3ad9456937 | Godfrey Chan | Godfrey Chan | Rename inline-if-test -> if-unless-test | rename inline-if-test -> if-unless-test | 39 | false | false | 4 | false | true | false | emberjs | ember.js | 10,245 |
1512d3fcb7969d5566870369c462b60e33bcb824 | Godfrey Chan | Godfrey Chan | Test nested if helpers | test nested if helpers | 22 | false | false | 4 | false | false | false | emberjs | ember.js | 10,246 |
5fa2a238b69e6067d3a43ca576ea268be22be4fd | Godfrey Chan | Godfrey Chan | Run the basic tests for each helper configuration | run the basic tests for each helper configuration | 49 | false | false | 8 | true | true | true | emberjs | ember.js | 10,247 |
c0a26082e6e5017502b754316325595b73aa83cb | Godfrey Chan | Godfrey Chan | Also test this in helper positions | also test this in helper positions | 34 | false | false | 6 | false | false | false | emberjs | ember.js | 10,248 |
1300b1e8e7f2de43012394d23b92db3d63a0e660 | Godfrey Chan | Godfrey Chan | this.$() should work like Ember components | this.$() should work like ember components | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 10,249 |
527ba41a55a151e5792217a66292c86217d1d3fe | Godfrey Chan | Godfrey Chan | Merge pull request #12920 from GavinJoyce/gj/glimmer-inline-if
[Glimmer2] inline if | merge pull request from gavinjoyce/gj/glimmer-inline-if | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,250 |
f9289cd7ac17b35f28184f25fdc9204189fd480a | Doug Yun | Doug Yun | [BUGFIX canary] Update Ember.compare to use operators
instead of String#localeCompare
There are edge cases where String#localeCompare behaves unexpectedly,
so, we'll use relational operators instead to compare Strings.
Closes #11252 | [bugfix canary] update ember.compare to use operators | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 10,251 |
67c6db05ed52ca804a148f3c2f7dad25da8a72ac | Zack Hall | Zack Hall | Update README.md with symlink instructions. | update readme.md with symlink instructions | 42 | false | false | 5 | false | true | false | emberjs | ember.js | 10,252 |
4acbd7f7744f24fa3bd74987aab9536a00967661 | Robert Jackson | Robert Jackson | Merge pull request #13003 from mmun/fix-crashing-assertion
Fix a broken assertion that relies on values being coercible to strings | merge pull request from mmun/fix-crashing-assertion | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 10,253 |
b71e8bb77cea809ce943afaf3a4cda6ec2605a9c | Martin Muñoz | Martin Muñoz | [BUGFIX] Fix a broken assertion that relies on values being coercible to strings | [bugfix] fix a broken assertion that relies on values being coercible to strings | 80 | false | false | 13 | false | false | false | emberjs | ember.js | 10,254 |
f9b99cdc0cacbeb6d6105cdc9ff0af9395bcf873 | Martin Muñoz | Martin Muñoz | Add a util function for toString'ing objects | add a util function for tostring'ing objects | 44 | false | false | 7 | true | true | true | emberjs | ember.js | 10,255 |
eac772a92a70dd2b92be5e0f178ae2911b43f2e0 | Robert Jackson | Robert Jackson | Merge pull request #12998 from duggiefresh/10865-calling-set-on-destroyed-object
Make "calling set on destroyed object" error more descriptive | merge pull request from duggiefresh/10865-calling-set-on-destroyed-object | 74 | true | false | 5 | true | false | false | emberjs | ember.js | 10,256 |
3a2486eb911ad77d2ab1a4324c1aacef08c156da | Doug Yun | Doug Yun | Make "calling set on destroyed object" error more descriptive
Actual code is from PR #12264, I just added a test :)
Closes #10865 | make "calling set on destroyed object" error more descriptive | 61 | false | false | 9 | false | true | false | emberjs | ember.js | 10,257 |
b3603d67662efd0da8898bc1935cb088d62be0ea | Tobias Bieniek | Tobias Bieniek | package.json: Add "ember-addon" keyword
... and add a very basic index.js file | add "ember-addon" keyword | 25 | false | false | 3 | false | false | false | emberjs | ember.js | 10,258 |
89e85a3197b514b7a3c4c32afdf4a008afbff468 | Tobias Bieniek | Tobias Bieniek | package.json: Do not "bower install" automatically
This will cause the dev dependencies to be installed even though they are not necessarily needed | do not "bower install" automatically | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 10,259 |
c32897573fa0e8ffa96bec089fa3113fb822b2d8 | Robert Jackson | Robert Jackson | Merge pull request #12999 from fivetanley/visit-doc
[DOC beta] mark Application.visit as Public API | merge pull request from fivetanley/visit-doc | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,260 |
d1d50d1d8a9690fcb90f130e9a3853dd1f39b003 | Robert Jackson | Robert Jackson | Merge pull request #12996 from spencer516/with-array
[bugfix BETA] Fixes 12995 #with array yields true | merge pull request from spencer516/with-array | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 10,261 |
a90158684d25812c58d3d7dcc106bdc69fc50b87 | Stanley Stuart | Stanley Stuart | [DOC beta] mark Application.visit as Public API
As it is mentioned in the 2.3 blog post here:
http://emberjs.com/blog/2016/01/15/ember-2-3-released.html
It's used in Ember CLI Fastboot, Ember Fastboot Server, and its
usage examples seem to indicate its usage to be a public API. | [doc beta] mark application.visit as public api | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 10,262 |
7c0befbc7f84749c35b12cbd7da9543175ac27de | Gavin Joyce | Gavin Joyce | Glimmer2 inline if | glimmer2 inline if | 18 | false | false | 3 | false | false | false | emberjs | ember.js | 10,263 |
626339c61c1d3a4a4cc89e5cddd6b99c969f8969 | Spencer P | Spencer P | [bugfix BETA] #with array support | [bugfix beta] #with array support | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 10,264 |
b8eda40c980c65e2e52bd88e4d1d1fca622f2243 | Stanley Stuart | Stanley Stuart | Merge pull request #12994 from stefanpenner/fix-12993
[FIXES #12993] add missing devDependency | merge pull request from stefanpenner/fix-12993 | 47 | true | false | 5 | true | true | false | emberjs | ember.js | 10,265 |
287e9defd7b168cfaaa5579e0d8d7e52208d5941 | Stefan Penner | Stefan Penner | [FIXES #12993] add missing devDependency | [fixes ] add missing devdependency | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 10,266 |
4a404de21d70b780f2ac85b6fb265e037998d2d1 | Kris Selden | Kris Selden | Merge pull request #12991 from mmun/fix-computed-sort
[BUGFIX beta] Fix a regression in Ember.computed.sort | merge pull request from mmun/fix-computed-sort | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 10,267 |
f05bd2d6d311b10c956a9d1541e68673f3deca4f | Martin Muñoz | Martin Muñoz | [BUGFIX beta] Fix a regression in Ember.computed.sort
Resolves a regression in `Ember.computed.sort` that has existed since
2.0.0. The regression occurred when there were multiple instances of a
class using `Ember.computed.sort` and caused the sorted value to stop
updating.
Closes #12212.
Closes #12215.
Closes #12221.
Closes #12516. | [bugfix beta] fix a regression in ember.computed.sort | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 10,268 |
6f2cdba68de25622e239b3955cabefb65faa4814 | Stefan Penner | Martin Muñoz | [BUGFIX beta] Add another failing test for #12212 | [bugfix beta] add another failing test for | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 10,269 |
8adb04cb668742b45b3b02a9eac96ebd9cc4a8d8 | Wesley Workman | Martin Muñoz | [BUGFIX beta] Add a failing test for #12212
Demonstrates issues with Ember.computed.sort used on class with multiple instances. | [bugfix beta] add a failing test for | 36 | false | false | 7 | false | false | false | emberjs | ember.js | 10,270 |
b00c0762089ff4bacc778de1a12b4c1e809daf08 | Kris Selden | Kris Selden | Merge pull request #12990 from mmun/weak-map
[BUGFIX beta] Add private WeakMap | merge pull request from mmun/weak-map | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 10,271 |
bce8ed35161f8d830375a8ccd4cd3dd8c0e1d4bf | Martin Muñoz | Martin Muñoz | [BUGFIX beta] Add private WeakMap (3/3) | [bugfix beta] add private weakmap (3/3) | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 10,272 |
52792ff38c14d1a7677e61f2bd45f2607b77e1d2 | Travis Hoover | Martin Muñoz | [BUGFIX beta] Add private WeakMap (2/3) | [bugfix beta] add private weakmap (2/3) | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 10,273 |
580162618fd7bb5684eaaa1fdd8e78654afbe8ce | Stefan Penner | Martin Muñoz | [BUGFIX beta] Add private WeakMap (1/3) | [bugfix beta] add private weakmap (1/3) | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 10,274 |
3b8e8751f408bb645c37281e8e43794c5f2ff409 | Robert Jackson | Robert Jackson | Merge pull request #12985 from Turbo87/patch-2
controller: Fix "queryParams" documentation formatting | merge pull request from turbo87/patch-2 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 10,275 |
752a7b9c49874b57669e2ee2dfd5b942387bb3e5 | Robert Jackson | Robert Jackson | Merge pull request #12984 from Turbo87/patch-1
mixins/observable: Update "Observing Property Changes" comment section | merge pull request from turbo87/patch-1 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 10,276 |
d1f0d2aa167365558baa31e3fa828935e52cda67 | Tobias Bieniek | Tobias Bieniek | [DOC release] controller: Fix "queryParams" documentation formatting | fix "queryparams" documentation formatting | 42 | false | false | 4 | false | false | false | emberjs | ember.js | 10,277 |
f8e81803b2cdd11834f129f9d85f2b3d539b7ad4 | Tobias Bieniek | Tobias Bieniek | [DOC release] mixins/observable: Update "Observing Property Changes" comment section | update "observing property changes" comment section | 51 | false | false | 6 | false | false | false | emberjs | ember.js | 10,278 |
0b80c18841cd8fd9b7bb272df337a1d72e5c19f1 | Stefan Penner | Stefan Penner | Merge pull request #12947 from btecu/insertAt
[BUGFIX beta] Don't use prototype extensions ({add,remove}ArrayObserver) | merge pull request from btecu/insertat | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 10,279 |
d60236d82038216c25a509f660f106b1d6c87cd9 | Stefan Penner | Stefan Penner | Merge pull request #12982 from HeroicEric/patch-1
[DOC] Update copyright year | merge pull request from heroiceric/patch-1 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 10,280 |
9cb258bcc09e19e11d61520fd093faed82c43e3d | Eric Kelly | Eric Kelly | [DOC] Update copyright year
Bumps the copyright year to 2016 | [doc] update copyright year | 27 | false | false | 4 | false | false | false | emberjs | ember.js | 10,281 |
d7fbc891a9b7c05adcb424ca588166398676848e | Stanley Stuart | Stanley Stuart | Merge pull request #12971 from thomascchen/sum-typo
[DOC release] Fix typo in computed.sum function description | merge pull request from thomascchen/sum-typo | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,282 |
cd45f5a32e91a144c8649da1c4ce0947245019c0 | Godfrey Chan | Godfrey Chan | Merge pull request #12978 from tildeio/view-tree
Track view-tree hierarchy in Glimmer | merge pull request from tildeio/view-tree | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 10,283 |
202a93048fafd075feae44337aef96e989312413 | Godhuda | Godhuda | Track view-tree hierarchy in Glimmer | track view-tree hierarchy in glimmer | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 10,284 |
033fe1b661ad794018eff99e99732426a8362cf4 | Godfrey Chan | Godfrey Chan | Merge pull request #12975 from tildeio/component-element
Implement `this.element` for components | merge pull request from tildeio/component-element | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 10,285 |
9422740ae4ec81945608613f2601483904fded99 | Godhuda | Godhuda | Implement `this.element` for components
The code that implements `this.$()` is currently commented out, because
it causes the teardown assertions to fail at the moment. We will re-
enable it once we have implemented the correct hooks on Glimmer side. | implement `this.element` for components | 39 | false | false | 4 | false | true | false | emberjs | ember.js | 10,286 |
c609f7de199e5dac116ae8a0b0af9fcf0cb49c86 | Godfrey Chan | Godfrey Chan | Merge pull request #12927 from chadhietala/moar-glim-glam-with
[Glimmer2] More with tests | merge pull request from chadhietala/moar-glim-glam-with | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,287 |
21ab6c006e1aa0f1e6304960b3a7b51f330ef72d | Chad Hietala | Chad Hietala | [Glimmer2] `with` tests | [glimmer2] `with` tests | 23 | false | false | 3 | false | false | false | emberjs | ember.js | 10,288 |
5d554b255f67aa4de170a0c75299c8d90436c669 | Thomas Chen | Thomas Chen | [DOC release] fix typo | [doc release] fix typo | 22 | false | false | 4 | false | false | false | emberjs | ember.js | 10,289 |
444de325633d1877e486fbccba315e2322d93531 | Robert Jackson | Robert Jackson | Merge pull request #12928 from rwjblue/remove-ember-htmlbars-component-generation
[FEATURE ember-htmlbars-component-generation] Remove feature. | merge pull request from rwjblue/remove-ember-htmlbars-component-generation | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 10,290 |
6f8f4dc79a91ccd08ffb256c0bd6590f1e942200 | Yehuda Katz | Yehuda Katz | Merge pull request #12962 from tildeio/fix-components
Use new glimmer engine APIs for building component layout | merge pull request from tildeio/fix-components | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 10,291 |
a8179e33413ab5d464bf8cab262dcddb94d8cc9d | Godhuda | Godhuda | Use new glimmer engine APIs for building component layout | use new glimmer engine apis for building component layout | 57 | false | false | 9 | false | true | false | emberjs | ember.js | 10,292 |
13c99713fd0df4621e2d57e660f14b1a61d3a108 | Robert Jackson | Robert Jackson | Merge pull request #12960 from tildeio/pin-glimmer
Pin glimmer-engine version | merge pull request from tildeio/pin-glimmer | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,293 |
1b1796e50986c1314beef86c30c0aa3a87a95ec6 | Godhuda | Godhuda | Pin glimmer-engine version | pin glimmer-engine version | 26 | false | false | 3 | false | false | false | emberjs | ember.js | 10,294 |
74c99ab19065f3daad0b2004b7281c2cbc26820b | Robert Jackson | Robert Jackson | Merge pull request #12959 from sly7-7/publish-jsons-to-s3
publish dist bower.json & co to s3 | merge pull request from sly7-7/publish-jsons-to-s3 | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,295 |
bfe959e72879f38adde992a3e46ea4cd6fabef3d | Sylvain MINA | Sylvain MINA | publish dist bower.json & co to s3 | publish dist bower.json & co to s3 | 34 | false | false | 7 | true | true | true | emberjs | ember.js | 10,296 |
5ccadc47eed886d2beac503ea8c6e3d5282f2666 | Robert Jackson | Robert Jackson | Merge pull request #12951 from vitch/patch-2
[typo] `componet` > `component` | merge pull request from vitch/patch-2 | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 10,297 |
c7d4cb63c6bf557a7a8fa03301c6dbfa1fcafcc7 | Robert Jackson | Robert Jackson | Merge pull request #12958 from sly7-7/update-jquery
update jquery dependency | merge pull request from sly7-7/update-jquery | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,298 |
edbf2dd34672be90b95087c0fac7871919001490 | Sylvain MINA | Sylvain MINA | update jquery dependency | update jquery dependency | 24 | false | false | 3 | true | true | true | emberjs | ember.js | 10,299 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.