sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
3d791dd0c9bb6b5190ae218cf2639e5e49bd4285 | Godfrey Chan | Godfrey Chan | Add a toggle for hidding skipped tests | add a toggle for hidding skipped tests | 38 | false | false | 7 | true | true | true | emberjs | ember.js | 10,400 |
b42590d94b812b3d0a39e2c3875c0fa482f86f47 | Godfrey Chan | Godfrey Chan | Add a dummy test to keep the test runner happy | add a dummy test to keep the test runner happy | 46 | false | false | 10 | true | true | true | emberjs | ember.js | 10,401 |
ef537a1ba72ff237bf19542e39fbcabfd95c6576 | Godfrey Chan | Godfrey Chan | Bump ember-cli-built to fix IE issues
This version adds the `proto-to-assign` transform which makes static
methods work on IE <= 10 | bump ember-cli-built to fix ie issues | 37 | true | false | 6 | false | false | false | emberjs | ember.js | 10,402 |
142b38859fc082a7034e8fdb466e58937c261503 | Godhuda | Godfrey Chan | Include a stub for the tests directory to keep the watcher happy | include a stub for the tests directory to keep the watcher happy | 64 | false | false | 12 | false | true | false | emberjs | ember.js | 10,403 |
f7c3e140e213aabb687fc9c3a1b6489e24828eef | Godhuda | Godfrey Chan | Pull in glimmer sourcemap files | pull in glimmer sourcemap files | 31 | false | false | 5 | false | false | false | emberjs | ember.js | 10,404 |
98735d5d2a208806af6f49bced52301e988411f7 | Godhuda | Godfrey Chan | Pull in all glimmer packages | pull in all glimmer packages | 28 | false | false | 5 | false | false | false | emberjs | ember.js | 10,405 |
56c3072168bffe88065940dfde425441855a1b11 | Robert Jackson | Godfrey Chan | Add ember-glimmer feature flag. | add ember-glimmer feature flag | 30 | false | false | 4 | false | false | false | emberjs | ember.js | 10,406 |
978b11dd3d1ed89700e82cfac94778fe187c5850 | Robert Jackson | Godfrey Chan | Use master of glimmer for integration efforts.
We will lock this down when we have made more progress. | use master of glimmer for integration efforts | 45 | false | false | 7 | true | true | true | emberjs | ember.js | 10,407 |
2f243cef1e1eabf4a612c19190f5b51a2147798d | Robert Jackson | Godfrey Chan | Only load glimmer-engine if feature is enableable. | only load glimmer-engine if feature is enableable | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 10,408 |
365743bfe8bd77ec48db4f3817d592e3bb9f89bc | Stefan Penner | Godfrey Chan | depend on relevant feature branch | depend on relevant feature branch | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 10,409 |
5402d306d32c2940fcc7c8296452201c7764f24c | Stefan Penner | Godfrey Chan | simpler glimmer-engine import | simpler glimmer-engine import | 29 | false | false | 3 | false | false | false | emberjs | ember.js | 10,410 |
78fd5adcdeec8222faefc24db65ec8e7d8b11bb4 | Stefan Penner | Godfrey Chan | We currently consume the ES6 output of glimmer build (post TS etc). So we must transpile it.
If we restructure the glimmer build slightly, we could just consume the separate AMD modules (likely as one would expect..) | we currently consume the es6 output of glimmer build (post ts etc). so we must transpile it | 91 | false | false | 17 | false | false | false | emberjs | ember.js | 10,411 |
8798c146c300d13eaa037d788c12d642f2cfb1fc | Stefan Penner | Godfrey Chan | power of broccoli
* import glimmers build… use it | power of broccoli | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 10,412 |
78763be44ce9e2a1b60777e50ad33a6a7794fb7d | Stefan Penner | Godfrey Chan | basic glimmer import (From output of build node_module)
I plan to still improve this, but this should help move stuff long. | basic glimmer import (from output of build node_module) | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 10,413 |
01a0c04a8939987cc04b7a7490529303b5a67d3f | Robert Jackson | Godfrey Chan | Begin fleshing out addition of Glimmer (2.0) package for integration. | begin fleshing out addition of glimmer (2.0) package for integration | 68 | false | false | 10 | false | false | false | emberjs | ember.js | 10,414 |
046e933f88a7b483b85253337bd8e8308bbb3dcd | Stefan Penner | Stefan Penner | Merge pull request #12872 from CarlMungazi/patch-1
Update CONTRIBUTING.md | merge pull request from carlmungazi/patch-1 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,415 |
585008bd21f10b8739fd006469420fb96b21eb1e | Carl Mungazi | Carl Mungazi | Update CONTRIBUTING.md
Fixed typos. | update contributing.md | 22 | false | false | 2 | false | false | false | emberjs | ember.js | 10,416 |
fe3ed83710d1c2640bb1e36c6bcf69ca4d80c0a3 | Robert Jackson | Robert Jackson | Merge pull request #12856 from pixelhandler/docs-remove-build-container-ref
[Documentation] Remove abstract detail in controller#target docs | merge pull request from pixelhandler/docs-remove-build-container-ref | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 10,417 |
866625822669078f9ae58cd3d635f8d7851049c8 | Bill Heaton | Bill Heaton | [Documentation] Remove abstract detail in controller#target docs
[Fixes #12844] | [documentation] remove abstract detail in controller#target docs | 64 | false | false | 7 | false | false | false | emberjs | ember.js | 10,418 |
76e9c595809957c14d6616d45be35ae2fe94fd3b | Robert Jackson | Robert Jackson | Merge pull request #12858 from pixelhandler/docs-route-action-bubbling
[Documentation] willTransiting event bubbling to parent route | merge pull request from pixelhandler/docs-route-action-bubbling | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 10,419 |
3f3313adbefb06956aafe9d90a892624b3d3ece5 | Bill Heaton | Bill Heaton | [Documentation] willTransiting event bubbling to parent route
[Fixes #12839] | [documentation] willtransiting event bubbling to parent route | 61 | false | false | 7 | false | false | false | emberjs | ember.js | 10,420 |
2e7991e07c6cd7803c3817baee433cea3343981f | Stefan Penner | Stefan Penner | Merge pull request #12491 from stefanpenner/fix-es5-watched-getter
[BUGFIX beta] allow watching of ES5+ Getter | merge pull request from stefanpenner/fix-es5-watched-getter | 60 | true | false | 5 | true | true | false | emberjs | ember.js | 10,421 |
4ea97e080a686a0d11ecf2b770a85ec20878160c | Matthew Beale | Matthew Beale | Merge pull request #12810 from jeradg/fix-typo-in-templates-helpers-docs
[DOC] Typo/readability fixes for Ember.Templates.helpers | merge pull request from jeradg/fix-typo-in-templates-helpers-docs | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 10,422 |
0a366915a252c68ff99df57047341bb28682e6b7 | Robert Jackson | Robert Jackson | Merge pull request #12847 from jgwhite/deep-each-warning
[BUGFIX beta] Add warning for “deep @each” usage in dependent keys | merge pull request from jgwhite/deep-each-warning | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 10,423 |
4cd46155f548517f255e3518d5ddb6055b931c5a | Jamie White | Jamie White | [BUGFIX beta] Add warning for “deep @each” usage in dependent keys | [bugfix beta] add warning for “deep @each” usage in dependent keys | 66 | false | false | 11 | false | false | false | emberjs | ember.js | 10,424 |
48562e67229cd88dc6217205914b667d58aad337 | Robert Jackson | Robert Jackson | Merge pull request #12848 from emberjs/fix-each-dep
Make dependencies that end in `@each` expand to `[]`. | merge pull request from emberjs/fix-each-dep | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,425 |
0567c11ccfffca44a4dca95dde1e4e4f9b6dfc6d | Kris Selden | Kris Selden | Make dependencies that end in `@each` expand to `[]`. | make dependencies that end in `@each` expand to `[]` | 52 | false | false | 9 | true | true | false | emberjs | ember.js | 10,426 |
bb163d0eb9a2ae35365a0e2379025aa54add3560 | Robert Jackson | Robert Jackson | Merge pull request #12766 from trentmwillis/test-router
Use routing service instead of application controller in test helpers | merge pull request from trentmwillis/test-router | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,427 |
65172aef8023d357773849387f16fba682184c90 | Trent Willis | Trent Willis | Use routing service instead of application controller in test helpers | use routing service instead of application controller in test helpers | 69 | false | false | 10 | true | true | false | emberjs | ember.js | 10,428 |
c54ecab568e6a904c8c3acca02972efb654637a2 | Stefan Penner | Stefan Penner | Merge pull request #12838 from thoov/use-default-param
Use default parameters | merge pull request from thoov/use-default-param | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,429 |
85eabaa5fa29278e8461d2d1393680c765e200e6 | Travis Hoover | Travis Hoover | making node happy | making node happy | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 10,430 |
586d4c6ab0a82abee0df1f331121e9c99433770e | Travis Hoover | Travis Hoover | Use default parameters
Move to default parameters where appropriate | use default parameters | 22 | false | false | 3 | true | true | true | emberjs | ember.js | 10,431 |
551a2312038dd815a2ff3e7843a8475da3d0fd11 | Robert Jackson | Robert Jackson | Merge pull request #12829 from emberjs/fastboot-tagless
[BUGFIX canary] Support tagless components in fastboot | merge pull request from emberjs/fastboot-tagless | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,432 |
2c0b326ea53acc0f41b0076c54fbbe7d144eee81 | Jerad Gallinger | Jerad Gallinger | Added closing '}}' to '{{action}}' in prose | added closing '}}' to '{{action}}' in prose | 43 | false | false | 7 | false | false | false | emberjs | ember.js | 10,433 |
f2adc4f3aadfd9fb01c5e4142b93eaa14e42eeb0 | Trek Glowacki | Trek Glowacki | Merge pull request #12831 from emberjs/fix-jshint
Fix jshint warnings | merge pull request from emberjs/fix-jshint | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 10,434 |
f8d551721102c6b430a884bc256cf77c9edcff36 | Edward Faulkner | Edward Faulkner | fix jshint warnings
A recent version of jshint has begun finding problems that were missed by earlier versions. This cleans them up. | fix jshint warnings | 19 | false | false | 3 | true | true | true | emberjs | ember.js | 10,435 |
7f5bcd51f30494ce1d26dbb1d64b0aca140fc2c3 | Robert Jackson | Robert Jackson | Post release version bump. | post release version bump | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 10,436 |
7b072fc4ddaab69d3ca116eddd587ffafc5916bc | Stefan Penner | Stefan Penner | Merge pull request #12826 from hibariya/improve-test
Improve tests for thrown errors | merge pull request from hibariya/improve-test | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 10,437 |
325e9e3c7a6253654a68a8ac9d85305465827907 | Robert Jackson | Robert Jackson | Update HTMLBars to 0.14.13. | update htmlbars to 0.14.13 | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 10,438 |
a84492187646717b1e73bd4ab9a2e045ba2f0161 | Edward Faulkner | Edward Faulkner | [BUGFIX canary] Support tagless components in fastboot
Attempting to render a component with `tagName: ''` in fastboot kills the fastboot server with a stack trace that looks like:
```
undefined:55214
_emberViewsSystemJquery.default(rootElement).off('.ember', '**').removeC
^
TypeError: undefined is not a function
at exports.default._emberRuntimeSystemObject.default.extend.destroy (<anonymous>:55214:38)
at superWrapper [as destroy] (<anonymous>:33934:22)
at <anonymous>:11887:16
at eachDestroyable (<anonymous>:12166:9)
at Object.Container.destroy (<anonymous>:11885:7)
at Object.Backburner.run (<anonymous>:11256:25)
at Object.run [as default] (<anonymous>:31959:27)
at exports.default._emberMetalMixin.Mixin.create.willDestroy (<anonymous>:44068:36)
at superWrapper (<anonymous>:33934:22)
at _emberRuntimeSystemObject.default.extend.willDestroy (<anonymous>:15925:19)
```
The root cause is that initializing a tagless component causes a lookup of `event_dispatcher:main`. This actually succeeds, and the `EventDispatcher` doesn't try to do anything, but then during container teardown the EventDispatcher's `destroy` method throws the above exception.
To make any future bugs in this class more obvious, I added an assertion in `EventDispatcher` so that it will fail faster if you try to instantiate it in fastboot mode. | [bugfix canary] support tagless components in fastboot | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 10,439 |
4ce4cb6a5aa23b81d6b1446bb70a763d2fba9047 | Stefan Penner | Stefan Penner | Merge pull request #12828 from trek/extend-docs-on-ember-copyable
Extend docs on ember copyable | merge pull request from trek/extend-docs-on-ember-copyable | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 10,440 |
3bf93e16bee0025e4698f35aa99fe39ee07777a6 | Trek Glowacki | Trek Glowacki | Merge pull request #12348 from alexspeller/fix-route-private
Route#disconnectOutlet should not be private | merge pull request from alexspeller/fix-route-private | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,441 |
f0be0d44be3fb287864a14d498e9fde728174505 | Trek Glowacki | Trek Glowacki | Merge pull request #12341 from kennethdavidbuck/master
[DOC release] Update ember-metal/is_present.js example return value to true for cases where input value is false. | merge pull request from kennethdavidbuck/master | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,442 |
d9a4391071eaed2257cdf157cc9b9181be1908ac | Trek Glowacki | Trek Glowacki | Merge pull request #12279 from fullsailor/patch-1
[DOC release] Fix `action` helper event type example | merge pull request from fullsailor/patch-1 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 10,443 |
b306714b6536791cef71a75bbb9adb7694da1a5e | Trek Glowacki | Trek Glowacki | [ci skip] Small fixup for Ember.copy API documentation | [ci skip] small fixup for ember.copy api documentation | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 10,444 |
d69b2f75b8bfa509a7146b2f1efe44ba5bb6c35f | Trek Glowacki | Trek Glowacki | Merge pull request #12692 from joeruello/master
[DOC release] Include NaN as a falsey value in {{if}} docs. | merge pull request from joeruello/master | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 10,445 |
3f9218bbb7a85bccb4a17dc6805b18a895df683b | Trek Glowacki | Trek Glowacki | Merge pull request #12735 from jwworth/pull-request-1450634635
[DOC release] Fix typo | merge pull request from jwworth/pull-request-1450634635 | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 10,446 |
c9ef70457e7ddee4c1d9eaa18d2c93d1e4da6e56 | Trek Glowacki | Trek Glowacki | Merge pull request #12736 from jwworth/pull-request-1450635015
[DOC release] Clean up documentation | merge pull request from jwworth/pull-request-1450635015 | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 10,447 |
068ffdab28aa77a14995750f15a7412308f16dcc | Trek Glowacki | Trek Glowacki | Merge pull request #12823 from pra85/2016
[DOC] Update copyright year | merge pull request from pra85/2016 | 35 | true | false | 5 | true | false | false | emberjs | ember.js | 10,448 |
7c5a5ce8ac34bd4bdecf2c33858b09e56ee61937 | Hika Hibariya | Hika Hibariya | Improve tests for thrown errors | improve tests for thrown errors | 31 | false | false | 5 | true | true | true | emberjs | ember.js | 10,449 |
8fd9af78faff1bbc798ad1f1cf7497fce250d675 | Prayag Verma | Prayag Verma | [DOC] Update copyright year | [doc] update copyright year | 27 | false | false | 4 | false | false | false | emberjs | ember.js | 10,450 |
ee426b093874d30b883d049bc3e876082c8aedcd | Robert Jackson | Robert Jackson | Merge pull request #12816 from Serabe/fix/12762
[BUGFIX beta] Avoid leaking variables between component instances | merge pull request from serabe/fix/12762 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 10,451 |
135b39334787d204c18ee76bfc9a8cf23d20c993 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Avoid leaking variables between component instances
Given that attributes are modified in place, the `{{component}}` helper needs
to duplicate the `hash`. Furthermore, rerendering a `@element_component` needs
to process positional parameters. | [bugfix beta] avoid leaking variables between component instances | 65 | false | false | 8 | false | false | false | emberjs | ember.js | 10,452 |
6de89a95c47b08ef9d5858b9554718cefee6a49d | Robert Jackson | Robert Jackson | Merge pull request #12812 from Serabe/fix/12804
[BUGFIX beta] Fix block behaviour for `Helper.extend` helpers | merge pull request from serabe/fix/12804 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 10,453 |
ce42e009a99cd96069ed6fcc4c5ddcfdc545e5b2 | Robert Jackson | Robert Jackson | Merge pull request #12797 from hibariya/inject-falsy-values
[BUGFIX beta] Make container always return the same value even if the registered value is falsy | merge pull request from hibariya/inject-falsy-values | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,454 |
c76b09221a320835ff45d462f1b38d29ea124b26 | Hika Hibariya | Hika Hibariya | Add a test for falsy value from resolvers | add a test for falsy value from resolvers | 41 | false | false | 8 | true | true | true | emberjs | ember.js | 10,455 |
94467933661eaacaa7adb0dd86974eca2834c60b | Hika Hibariya | Hika Hibariya | Use `let` instead of `var` | use `let` instead of `var` | 26 | false | false | 5 | false | true | false | emberjs | ember.js | 10,456 |
6d35451afc677d9452c7b50f798fbc6e73e351e6 | Hika Hibariya | Hika Hibariya | Use strictEqual for rigid comparison | use strictequal for rigid comparison | 36 | false | false | 5 | true | false | true | emberjs | ember.js | 10,457 |
d770aa8e8f1d29ac86761ab5f8831b4a04757ebf | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Fix block behaviour for `Helper.extend` helpers
Change the condition in invoke helper assertions to throw on helpers extending
`Ember.Helper`.
Fixes #12804 | [bugfix beta] fix block behaviour for `helper.extend` helpers | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 10,458 |
58623802516d249f24522a21469c6ab003c04738 | Jerad Gallinger | Jerad Gallinger | Typo/style fixes and changes for consistency | typo/style fixes and changes for consistency | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 10,459 |
7eace13135c08e9b38ae73f9980b2a395740d8e8 | Gaurav Munjal | Gaurav Munjal | Merge branch 'master' of https://github.com/emberjs/ember.js into include_transition_yuidoc | //github.com/emberjs/ember.js into include_transition_yuidoc | 60 | false | false | 3 | false | false | false | emberjs | ember.js | 10,460 |
c5492eab98599172af1529e2da29075f8632722c | Robert Jackson | Robert Jackson | Add 2.2.0-beta.3 to CHANGELOG.md. | add 2.2.0-beta.3 to changelog.md | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 10,461 |
4e052ff3816894f24bc8a53ade11784eb6e62558 | Stefan Penner | Stefan Penner | [BUGFIX beta] MandatorySetter should work with inheritance. | [bugfix beta] mandatorysetter should work with inheritance | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 10,462 |
46257f178c0cb13ed78b68a5c063c336bdb38c74 | Hika Hibariya | Hika Hibariya | [BUGFIX beta] Make container always return the same value even if the registered value is falsy | [bugfix beta] make container always return the same value even if the registered value is falsy | 95 | false | false | 16 | false | false | false | emberjs | ember.js | 10,463 |
f34af07657c62e5f13e9797444ce391300b614ac | Stefan Penner | Stefan Penner | Merge pull request #12793 from rwjblue/remove-jquery-assertion
[BUGFIX release-1-13] Remove jQuery version assertion. | merge pull request from rwjblue/remove-jquery-assertion | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,464 |
a9ac424d86ebd472f48abd736cb20dccff991d7b | Robert Jackson | Robert Jackson | [BUGFIX release-1-13] Remove jQuery version assertion. | [bugfix release-1-13] remove jquery version assertion | 53 | false | false | 6 | false | false | false | emberjs | ember.js | 10,465 |
10ab23d86a72a716bc7ad2631aaa1a76334a8363 | Robert Jackson | Robert Jackson | Merge pull request #12788 from chancancode/upgrade-htmlbars
Upgrade HTMLBars | merge pull request from chancancode/upgrade-htmlbars | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,466 |
fb2136c80a9548a266a260b9ba6e3f790fd1907d | Godfrey Chan | Godfrey Chan | Upgrade HTMLBars | upgrade htmlbars | 16 | false | false | 2 | true | true | false | emberjs | ember.js | 10,467 |
f621c2e7c1ef2612d37e75321b712ef9ba4ad447 | Gaurav Munjal | Gaurav Munjal | Update yuidoc.json to exclude all of router.js except transition.js | update yuidoc.json to exclude all of router.js except transition.js | 67 | false | false | 9 | true | true | false | emberjs | ember.js | 10,468 |
90c4d125879189941f86a184141f69b3fdba79dc | Gaurav Munjal | Gaurav Munjal | Merge branch 'master' of https://github.com/emberjs/ember.js into include_transition_yuidoc | //github.com/emberjs/ember.js into include_transition_yuidoc | 60 | false | false | 3 | false | false | false | emberjs | ember.js | 10,469 |
a364b39e2c531b72af4c8e56bd893a9403ed848d | Robert Jackson | Robert Jackson | Merge pull request #12781 from cibernox/fix_run_cancel_documentation
[DOC release] Amend `Ember.run.cancel` docs | merge pull request from cibernox/fix_run_cancel_documentation | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 10,470 |
f5e152837d2876d8cbb687cd3e00dd7de3682f1a | cibernox | cibernox | [DOC release] Amend `Ember.run.cancel` docs
The documentation listed the functions that return a cancellable timer, and Ember.run.scheduleOnce was not among them.
I tested and it returns a cancelable timer. | [doc release] amend `ember.run.cancel` docs | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 10,471 |
1f8c70bd0af18afbfb20517b76c8752625872e3f | Stefan Penner | Stefan Penner | [BUGFIX beta] MandatorySetter: Restore properties correctly
* no longer rely on meta to store the value until next set after uninstalling MandatorySetter
* no longer incorrectly re-set on set to enumerable (enumerability should remain constant)
* test both enumerable / non-enumerable variants | restore properties correctly | 28 | false | false | 3 | true | true | true | emberjs | ember.js | 10,472 |
68d262ac4e1b37cc1e2eff035dd70ae3759c77c4 | Stefan Penner | Stefan Penner | [BUGFIX beta] remove redundant code (already the default M getter) | [bugfix beta] remove redundant code (already the default m getter) | 66 | false | false | 10 | false | false | false | emberjs | ember.js | 10,473 |
aed80aaa7620c8f5b7090fdd5089bbc22c3637fa | Stefan Penner | Stefan Penner | [BUGFIX beta] Ember.set should not smash ES5 descriptor
[fixes 12480] | [bugfix beta] ember.set should not smash es5 descriptor | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 10,474 |
a0d7deca589b667197300edd9f534467ea3db54a | Stefan Penner | Stefan Penner | [BUGFIX beta] unwatch should not destroy foreign descriptor | [bugfix beta] unwatch should not destroy foreign descriptor | 59 | false | false | 8 | false | false | false | emberjs | ember.js | 10,475 |
076e05a67d1d0057fdb895e7a96039d59ce7dac9 | Stefan Penner | Stefan Penner | [BUGFIX Release] allow watching of ES5+ Getter
Before this commit MandatorySetter enabled + current property being watched
resulted in `get` always fetching via meta.values. Although this typically works,
the default getter for a MandatorySetter already does this, so it is actually redundant.
Going further, when a user defines their own getter this code-path is incorrectly taken,
instead the original value (which originated from the getter) should be the consulted value | [bugfix release] allow watching of es5+ getter | 46 | false | false | 7 | false | false | false | emberjs | ember.js | 10,476 |
9926caa129281271b02aa4432ef78dd5f3cc6acf | Stefan Penner | Stefan Penner | Merge pull request #12427 from emberjs/note-for-future-travelers
Update watch_key.js | merge pull request from emberjs/note-for-future-travelers | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 10,477 |
c2248aa8ab7911944e377b4c4b46a5ee0a9f24e8 | Stefan Penner | Stefan Penner | Merge pull request #12754 from rwjblue/use-empty-object-for-null
Use EmptyObject for `dictionary(null)`. | merge pull request from rwjblue/use-empty-object-for-null | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 10,478 |
3b2c08715f81215e07be2d42a69748414a431fbb | Robert Jackson | Robert Jackson | Merge pull request #12776 from rwjblue/prevent-overiding-owner-if-present
Do not override `OWNER` if already present on child view. | merge pull request from rwjblue/prevent-overiding-owner-if-present | 67 | true | false | 5 | true | false | false | emberjs | ember.js | 10,479 |
0f09498b56556be6c1f315f163cf29394ce2e273 | Robert Jackson | Robert Jackson | Do not override `OWNER` if already present on child view.
Previously, `linkChild` would always set the new child view's `OWNER` to
its own `OWNER`. Unfortunately, when dealing with Engines mounted at a
given outlet this means that any components and whatnot rendered in that
engines template have their `OWNER` changed after init (just before
render).
The intent of the original code was to ensure that all child views had
an `OWNER` (actually it was `.container` at the time). The
`ViewNodeManager` and `ComponentNodeManager`'s now handle properly
creating the views/components with the right `OWNER` so this code is
mostly no longer needed (except for edge case legacy support). The guard
added here ensures that we are only setting `OWNER` if it wasn't
previously set (which is that one legacy edge case). | do not override `owner` if already present on child view | 56 | false | false | 10 | false | false | false | emberjs | ember.js | 10,480 |
90d51dc9b07226264b4792e22d92aea48d0ead2c | Robert Jackson | Robert Jackson | Merge pull request #12764 from Serabe/fix/12740
[BUGFIX beta] Read values of `action` helper parameters | merge pull request from serabe/fix/12740 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 10,481 |
d967382559a328b9121f5b3b4d38303d665b02bc | Robert Jackson | Robert Jackson | Merge pull request #12771 from rwjblue/cleanup-extra-getowner-calls
Remove extra `getOwner` invocations and pass owner into render state. | merge pull request from rwjblue/cleanup-extra-getowner-calls | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 10,482 |
1ae881a977e6f2b370cdb79f60cb198c077ec61c | Robert Jackson | Robert Jackson | [FEATURE ember-application-engines] Pass routes owner into outlet state.
This allows the `{{outlet}}` keyword to be aware of the owner for a
given route (instead of always assuming there is only a single owner). | [feature ember-application-engines] pass routes owner into outlet state | 71 | false | false | 8 | false | false | false | emberjs | ember.js | 10,483 |
8eefbe471053d0ce76e7d65fda8fa4d7825a6bca | Robert Jackson | Robert Jackson | Remove extra `getOwner` invocations.
Calling `getOwner(route)` here is pretty fast, but it still seems silly
to do it so many times. | remove extra `getowner` invocations | 35 | false | false | 4 | true | true | true | emberjs | ember.js | 10,484 |
c213c2c8e3085f6831ca1fbaf387d7455806b19c | Trek Glowacki | Trek Glowacki | Merge pull request #12730 from trek/remove-referenece-to-removed-global
[DOC release] Removes reference to Ember.ORDER_DEFINITION | merge pull request from trek/remove-referenece-to-removed-global | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 10,485 |
56ac6a3e39762ca25145ffc877cdff680a7ca849 | Robert Jackson | Robert Jackson | Merge pull request #12765 from chancancode/patch-1
[DOC release] Remove extra "@" for `BootOptions` | merge pull request from chancancode/patch-1 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,486 |
fa585ecabf0f564c4251e0802c01cfa605ebe067 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Read values of `action` helper parameters
This change makes helper `action` `read` values when the action is executed
instead of just using the value. This worked as far as the value was not bound.
Fixes #12740 | [bugfix beta] read values of `action` helper parameters | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 10,487 |
9e8770ea8a4fee159a3cfeb049e1ef796a586de0 | Godfrey Chan | Godfrey Chan | [DOC release] Remove extra "@" for `BootOptions` | [doc release] remove extra "@" for `bootoptions` | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 10,488 |
23f15df02c21781c610df29d6d6f2bb137be09f8 | Robert Jackson | Robert Jackson | Merge pull request #12759 from johanneswuerbach/testem-v1
Use testem v1 | merge pull request from johanneswuerbach/testem-v1 | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,489 |
7ab171827d45d9d7679f7f2d2a2a31619c88421f | Johannes Würbach | Johannes Würbach | Testem 1.0.0-rc.3
ember-cli 2.2.0-beta.2 includes testem v1 already. | testem 1.0.0-rc.3 | 17 | false | false | 2 | false | false | false | emberjs | ember.js | 10,490 |
2fd5719082d128ff7e50de6c9768749f6dd3ef36 | Trek Glowacki | Trek Glowacki | Merge pull request #12722 from Charizard/document-index-block-param
[DOC release] Document on index block param for each helper | merge pull request from charizard/document-index-block-param | 61 | true | false | 5 | true | true | false | emberjs | ember.js | 10,491 |
7b51fbb553a95bbc215ec15fe2ffe190ed6864c5 | Robert Jackson | Robert Jackson | Merge pull request #12757 from rwjblue/update-emberjs-build
Update build related deps. | merge pull request from rwjblue/update-emberjs-build | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,492 |
9d0a98a3896bdc467171f58a1460b96695102e39 | Robert Jackson | Robert Jackson | Update ember-cli-dependency-checker to 1.2.0. | update ember-cli-dependency-checker to 1.2.0 | 44 | false | false | 4 | false | false | false | emberjs | ember.js | 10,493 |
1615777c8a5ef468038d71203e108d44eafd698e | Robert Jackson | Robert Jackson | Update ember-cli to 2.2.0-beta.2. | update ember-cli to 2.2.0-beta.2 | 32 | false | false | 4 | false | true | false | emberjs | ember.js | 10,494 |
3a9fef7984666f8d913a7e215099d816153cf946 | Robert Jackson | Robert Jackson | Update emberjs-build to v0.5.4.
Includes updated broccoli-merge-trees that drammatically reduces
rebuild time (from 2.5s to .5s for simple change operations). | update emberjs-build to v0.5.4 | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 10,495 |
850a1c84b1052ba352cd2158244b653ca61dac22 | Robert Jackson | Robert Jackson | Merge pull request #12755 from rwjblue/update-qunit
Update to QUnit 1.20. | merge pull request from rwjblue/update-qunit | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,496 |
5188cbbd5473387a4b4f992fac47126ca23f875f | Robert Jackson | Robert Jackson | Update to QUnit 1.20. | update to qunit 1.20 | 20 | false | false | 4 | false | false | false | emberjs | ember.js | 10,497 |
8c8fe83d45d08ae38ad0a73dc5576455abb31030 | Robert Jackson | Robert Jackson | Use EmptyObject for `dictionary(null)`.
A huge number of usages of `ember-metal/dictionary` are using `null` as
the parent. Creating a `new EmptyObject()` is quite a bit faster than
`Object.create(null)` (see comments in `ember-metal/empty_object` for
details).
Note: we are working around an issue with QUnit due to using constructor
value of `undefined` (they support `null` as of 1.20). Perhaps we should
tweak to use `null`, but that seems out of scope for this change. | use emptyobject for `dictionary(null)` | 38 | false | false | 4 | true | true | true | emberjs | ember.js | 10,498 |
cf3ce9bade526272d3ef64112971a90dca0dd8ab | Robert Jackson | Robert Jackson | Merge pull request #12753 from rwjblue/remove-shrinkwrap
Remove npm-shrinkwrap.json. | merge pull request from rwjblue/remove-shrinkwrap | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 10,499 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.