sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
d38ca83de7dc24f4d872bd54e5e9e5a86f2603bf | Robert Jackson | Robert Jackson | Merge pull request #11952 from rwjblue/extract-is-equal
Make `isEqual` its own module. | merge pull request from rwjblue/extract-is-equal | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,400 |
149c4f41ee5c0cfc9143b5bfcf966109ddab94f8 | Robert Jackson | Robert Jackson | Make `isEqual` its own module. | make `isequal` its own module | 29 | false | false | 5 | true | false | true | emberjs | ember.js | 11,401 |
eb2e127e352e830f78bef3cab07a08e69a603f2a | Edward Faulkner | Edward Faulkner | [BUGFIX release] Faster attrs-proxy
The attrs-proxy exists to make component attrs available directly on the
component instance, for compatibility with the pre-Glimmer world. This
change makes the attrs-proxy significantly faster by implementing the
proxy using Glimmer's lifecycle hooks instead of creating observers.
I also moved the didInitAttrs hook inside component `init`, so that
changes made there do not trigger observers.
I condensed two distinct tests into one, because the subtle difference
between the two scenarios has disappeared. The behavior change seems
acceptable because this case is already covered under the double-render
warning, so people will be told they're doing something with potentially
undefined behavior.
Using [complex list
benchmark](https://github.com/ef4/initial-render-perf) that has been
ported to idiomatic modern Ember, I'm measuring 56% faster rendering
when compared to master. This takes us from 270% slower than 1.12 to 21%
slower than 1.12. And much remains to still be optimized. | [bugfix release] faster attrs-proxy | 35 | false | false | 4 | false | false | false | emberjs | ember.js | 11,402 |
bc2a93fb73b8848a908f411d8145cb67e020f83a | Robert Jackson | Robert Jackson | Merge pull request #11945 from rwjblue/fix-optional-feature-tests
Fix bug with optional feature tests. | merge pull request from rwjblue/fix-optional-feature-tests | 59 | true | false | 5 | true | true | false | emberjs | ember.js | 11,403 |
ebef8697d56ab484372fcb4ccda5a46e1de4d24c | Robert Jackson | Robert Jackson | Skip failing angle bracket component tests. | skip failing angle bracket component tests | 42 | false | false | 6 | false | true | false | emberjs | ember.js | 11,404 |
6c7115500fb4bc97186fee8f3c3d6c47eede1885 | Robert Jackson | Robert Jackson | Fix `View.prototype.visit` tests for container-registry-reform. | fix `view.prototype.visit` tests for container-registry-reform | 62 | false | false | 5 | false | true | false | emberjs | ember.js | 11,405 |
91804148f5c2653fc75246d1d620993f170e73f4 | Robert Jackson | Robert Jackson | Fix optional feature tests. | fix optional feature tests | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 11,406 |
42586fa9c3733e5bdc736039ce4ac467cdc8e7e3 | Robert Jackson | Robert Jackson | Merge pull request #11944 from EricSchank/update_contributing
[DOC release] add Travis CI build info to docs | merge pull request from ericschank/update_contributing | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,407 |
07745b9f14e1a596a658c32777a22e3ba542f2e1 | Eric Schank | Eric Schank | [DOC release] add Travis CI build info to docs | [doc release] add travis ci build info to docs | 46 | false | false | 9 | false | false | false | emberjs | ember.js | 11,408 |
574df27b55da5a1d343c31626d0719692834aee7 | Robert Jackson | Robert Jackson | Merge pull request #11941 from rwjblue/split-assign-from-merge
Split assign helper function into its own module. | merge pull request from rwjblue/split-assign-from-merge | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,409 |
30add0336c4a24a22410b0a3de1c3292d5cdeddd | Robert Jackson | Robert Jackson | Merge pull request #11940 from rwjblue/remove-dead-code
[CLEANUP beta] Remove unsued View.prototype.appendAttr code. | merge pull request from rwjblue/remove-dead-code | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,410 |
a4cb03d1c951c0df593db1639cda8f8c84192764 | Robert Jackson | Robert Jackson | Split assign helper function into its own module. | split assign helper function into its own module | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 11,411 |
13d2099c224b48b0af3b1a4097dfff28bcbcdca1 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove unsued View.prototype.appendAttr code. | [cleanup beta] remove unsued view.prototype.appendattr code | 59 | false | false | 6 | false | false | false | emberjs | ember.js | 11,412 |
3ab78a8b9657aae9d517e74d267a1ac77d103eff | Robert Jackson | Robert Jackson | Merge pull request #11942 from rwjblue/lockdown-simple-dom
Lock down simple-dom version. | merge pull request from rwjblue/lockdown-simple-dom | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,413 |
4bd61691cb036baf2a4a5b5b10b580f4978f29e3 | Robert Jackson | Robert Jackson | Lock down simple-dom version.
There is an issue with
https://github.com/krisselden/simple-dom/compare/v0.2.4...v0.2.5 causing
the node tests to fail with simple-dom@0.2.5. Locking them down here so
we can fix that issue (either upstream or in our test suite) out of
band. | lock down simple-dom version | 28 | false | false | 4 | false | false | false | emberjs | ember.js | 11,414 |
e5ab0af4d8cf8775468af653f2cfe5ce3148752a | Robert Jackson | Robert Jackson | Merge pull request #11902 from EricSchank/dangerous-route-names
[DOC release] per #11893 warn when using a route named 'select' as may not work … | merge pull request from ericschank/dangerous-route-names | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 11,415 |
622e59752055dd96fde9098aa609947b0418a17c | Robert Jackson | Robert Jackson | Merge pull request #11937 from duggiefresh/contributing-remove-jsfiddle
[DOC] CONTRIBUTING.md - Remove JSFiddle link | merge pull request from duggiefresh/contributing-remove-jsfiddle | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 11,416 |
dbf234fdcdfdc5fc36b14d718620a7f298e8f65e | Doug Yun | Doug Yun | [DOC] CONTRIBUTING.md - Remove JSFiddle link, add Ember Twiddle
Seems that JSBin is the preferred method of reporting bugs, and
JSFiddle was not preconfigured with the latest version of Ember.
Closes #11198
[ci skip] | [doc] contributing.md - remove jsfiddle link, add ember twiddle | 63 | false | false | 9 | false | false | false | emberjs | ember.js | 11,417 |
72282a3a040e58895d6e6a294cbc681c6fc395a8 | Bill Heaton | Bill Heaton | [Documentation] Contributing: use RFC process for new features | use rfc process for new features | 32 | false | false | 6 | true | true | true | emberjs | ember.js | 11,418 |
facb04b98ef8d9d11690d749240ea422485c85f9 | Stefan Penner | Stefan Penner | Merge pull request #11935 from ef4/attrs-perf
[BUGFIX release] Avoid unnecessary change events during initial render | merge pull request from ef4/attrs-perf | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 11,419 |
b0f6540e8f4ffbe7b11e1a8f246f7e15a65b8270 | Edward Faulkner | Edward Faulkner | [BUGFIX release] Avoid double-setting attrs during initial renders
This significantly reduces unnecessary event firing during the initial
render of each component. In my sample scenario, it cut average events
per component from 14.9 to 7.07.
This does not have a major performance impact by itself, but
applications that are observing any of these events may experience
improvement. | [bugfix release] avoid double-setting attrs during initial renders | 66 | false | false | 8 | false | false | false | emberjs | ember.js | 11,420 |
4373ac654c4713c2969caabdc0559578a448ca05 | Robert Jackson | Robert Jackson | [BUGFIX release] Setup named positionalParam array.
Previously, when `positionalParams` was a string value (which means to
set all params as an array at that particular prop in `attrs`) we were
iterating over the length of the destination property name instead of
the available `params`. | [bugfix release] setup named positionalparam array | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 11,421 |
fbe3f03ce3a692b6c42068f475055aa3d32e3475 | Robert Jackson | Robert Jackson | [BUGFIX release] Avoid positionalParams changing attrs after create. | [bugfix release] avoid positionalparams changing attrs after create | 67 | false | false | 8 | false | false | false | emberjs | ember.js | 11,422 |
02284d19cf7ddac0454137acb284391de6f5f5d0 | Robert Jackson | Robert Jackson | Merge pull request #11929 from HeroicEric/mark-render-template-public
[DOC release] Mark Route.renderTemplate() as public | merge pull request from heroiceric/mark-render-template-public | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 11,423 |
91e4e7915014a00e6d0ee8de794504ea81ecb277 | Robert Jackson | Robert Jackson | Merge pull request #11919 from emberjs/rwjblue-patch-1-1
[DOC release] Make `notifyPropertyChange` public. | merge pull request from emberjs/rwjblue-patch-1-1 | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,424 |
93bc48a54ccd00a262dcb2eaffd81acaf4dcbc55 | Eric Kelly | Eric Kelly | [DOC release] Mark Route.renderTemplate() as public | [doc release] mark route.rendertemplate() as public | 51 | false | false | 6 | false | false | false | emberjs | ember.js | 11,425 |
3a450b567bd760a10a3157d7cec3b08d84f44e41 | Eric Schank | Eric Schank | [DOC release] warn when using a route named 'select' as may not work quite as expected | [doc release] warn when using a route named 'select' as may not work quite as expected | 86 | false | false | 16 | false | false | false | emberjs | ember.js | 11,426 |
3a4e1a572d14a18bca73927e3be4804a158abf54 | Robert Jackson | Robert Jackson | [DOC release] Make `Ember.Observable#notifyPropertyChange` public.
[ci skip] | [doc release] make `ember.observable#notifypropertychange` public | 65 | false | false | 5 | false | false | false | emberjs | ember.js | 11,427 |
5fba8196336e1b8c04c73e021432d1611a3f2471 | Ray Tiley | Robert Jackson | [DOC release] Mark Ember.Logger methods as public
Pretty sure these are supposed to be public. [ci skip]
Make Ember.Logger Public
(cherry picked from commit 15f2831d742452bac5c683b2d46cf14cd23e5c32) | [doc release] mark ember.logger methods as public | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 11,428 |
eb8049d6199ed1fec49b649c159fd375f441cc66 | Robert Jackson | Robert Jackson | Merge pull request #11917 from rwjblue/update-emberjs-build
[BUGFIX release] Ensure `"use strict";` is properly added for modules. | merge pull request from rwjblue/update-emberjs-build | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,429 |
e5c64900400dd2d8160313e403d93ef45c8e086f | Robert Jackson | Robert Jackson | Merge pull request #11914 from rwjblue/remove-ember-oneway
[CLEANUP beta] Remove `Ember.oneWay`. | merge pull request from rwjblue/remove-ember-oneway | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,430 |
f6bf5335b58a94b48bbd387ecd1a2cad566f3a6e | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure `"use strict";` is properly added for modules.
Esperanto would automatically add `"use strict";` to the beginning of
every file. When we swapped to using Babel for module transpilation, we
forgot to update the Babel whitelist to add `"use strict";` back.
This has been an issue since v1.13.0. | [bugfix release] ensure `"use strict";` is properly added for modules | 69 | false | false | 10 | false | false | false | emberjs | ember.js | 11,431 |
c650f1d3da090ddc23fab5a81d97204c75241ac5 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `Ember.oneWay`.
This was still be exported on the global. | [cleanup beta] remove `ember.oneway` | 36 | false | false | 4 | false | false | false | emberjs | ember.js | 11,432 |
df9fba3f19874d9f64d7d176be4803bbf8223278 | Robert Jackson | Robert Jackson | Merge pull request #11910 from emberjs/rwjblue-patch-1
[BUGFIX release] Ensure `Ember.CollectionView.CONTAINER_MAP` is present. | merge pull request from emberjs/rwjblue-patch-1 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 11,433 |
ed5a3c4913b133dc8e0878ed68ddf5852bd3a3e7 | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure `Ember.CollectionView.CONTAINER_MAP` is present. | [bugfix release] ensure `ember.collectionview.container_map` is present | 71 | false | false | 6 | false | false | false | emberjs | ember.js | 11,434 |
bc63d3582de248937658d8f1bad201dce4a17b78 | bmac | bmac | Update the changelog script to make it more robust about finding the cherry-picked commit. | update the changelog script to make it more robust about finding the cherry-picked commit | 89 | false | false | 14 | true | true | false | emberjs | ember.js | 11,435 |
02a8f86e911b5cdc99c397109d7008ec05864a89 | Robert Jackson | Robert Jackson | Merge pull request #11903 from stefanpenner/upgrade-rsvp-and-backburner
[BUGFIX release] upgrade rsvp + backburner | merge pull request from stefanpenner/upgrade-rsvp-and-backburner | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 11,436 |
260a81f978b2e36c020e1bfe6990c23e4bcb6adb | Stefan Penner | Stefan Penner | [BUGFIX release] upgrade rsvp + backburner + add more tests | [bugfix release] upgrade rsvp + backburner + add more tests | 59 | false | false | 10 | false | false | false | emberjs | ember.js | 11,437 |
6e00835bc6128b92157d97cc59a1bc8a61b5afd4 | Stefan Penner | Stefan Penner | Merge pull request #11895 from brzpegasus/node-detection
[BUGFIX beta] Properly detect if the environment is Node. | merge pull request from brzpegasus/node-detection | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,438 |
68719dd852c5d8e5b6f1d1c7049e33724af6ae4c | Robert Jackson | Robert Jackson | Merge pull request #11900 from rwjblue/deprecate-various-helpery-things
Deprecate legacy helper versions. | merge pull request from rwjblue/deprecate-various-helpery-things | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 11,439 |
a3d268d6e290911b9f88581e016e91188310f426 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate `Ember.Handlebars.registerHelper`. | [bugfix release] deprecate `ember.handlebars.registerhelper` | 60 | false | false | 4 | false | false | false | emberjs | ember.js | 11,440 |
63da31f6d83be56cbfe0f71136b8c6872024948f | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate `Ember.Handlebars.helper`. | [bugfix release] deprecate `ember.handlebars.helper` | 52 | false | false | 4 | false | false | false | emberjs | ember.js | 11,441 |
03de0677bfebb7516f889f1dbfbf9b622be22e32 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate `Ember.Handlebars.registerBoundHelper`. | [bugfix release] deprecate `ember.handlebars.registerboundhelper` | 65 | false | false | 4 | false | false | false | emberjs | ember.js | 11,442 |
45e96d16b15ae023af5d3cf90c867ca3788bee2a | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate `Ember.Handlebars.makeBoundHelper`. | [bugfix release] deprecate `ember.handlebars.makeboundhelper` | 61 | false | false | 4 | false | false | false | emberjs | ember.js | 11,443 |
7e3b4109ee1c228daeed9b3c4b31da1bea2b5de9 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate `Ember.HTMLBars.makeBoundHelper`. | [bugfix release] deprecate `ember.htmlbars.makeboundhelper` | 59 | false | false | 4 | false | false | false | emberjs | ember.js | 11,444 |
3b880ea37c42356ab9c7e9cc9b973bffb743a2b8 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate Ember.HTMLBars._registerHelper. | [bugfix release] deprecate ember.htmlbars._registerhelper | 57 | false | false | 4 | false | false | false | emberjs | ember.js | 11,445 |
f81bf1eb49563ebf901ef1ffac9c9a096b01da7d | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate Ember.Handlebars.makeViewHelper. | [bugfix release] deprecate ember.handlebars.makeviewhelper | 58 | false | false | 4 | false | false | false | emberjs | ember.js | 11,446 |
2c137a19971d814c94c10e5bca9520168c528254 | Robert Jackson | Robert Jackson | Merge pull request #11897 from rwjblue/remove-global-lookup-from-templates
[CLEANUP beta] Remove globals lookup from templates. | merge pull request from rwjblue/remove-global-lookup-from-templates | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 11,447 |
caa99153e6abb26b186f3c2beb19b20694e6858c | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove globals lookup from templates. | [cleanup beta] remove globals lookup from templates | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 11,448 |
97b1a3d7c0fd6d6d7fbf8489fd3e9d67fbd45b12 | Estelle DeBlois | Estelle DeBlois | [BUGFIX beta] Properly detect if the environment is Node.
* Check for both `process` and `window` when determining if the environment is Node.
* Closes #11679. | [bugfix beta] properly detect if the environment is node | 56 | false | false | 9 | false | false | false | emberjs | ember.js | 11,449 |
e4f80326e789538e3c02dab92ac7dd8f6ad2998b | Robert Jackson | Robert Jackson | Merge pull request #11891 from martndemus/deprecate-collection-view
[BUGFIX release] Deprecate Ember.CollectionView | merge pull request from martndemus/deprecate-collection-view | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 11,450 |
79d53af761d443e39945f1feb0641236cb7a3926 | Marten Schilstra | Marten Schilstra | [BUGFIX release] Deprecate Ember.CollectionView | [bugfix release] deprecate ember.collectionview | 47 | false | false | 4 | false | false | false | emberjs | ember.js | 11,451 |
7348ea18bd38b26d83d743a203de19a0c0e89174 | Robert Jackson | Robert Jackson | Merge pull request #11889 from rwjblue/attributeBindings-for-id
[BUGFIX release] Fix `attributeBindings` for `id` attribute. | merge pull request from rwjblue/attributebindings-for-id | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 11,452 |
712227c2df63299667e5c80c4d2b1d4091509bf2 | Robert Jackson | Robert Jackson | [BUGFIX release] Fix `attributeBindings` for `id` attribute.
In prior versions of Ember you could customize `id` via
`attributeBindings` like so:
```javascript
export default Ember.Component.extend({
attributeBindings: [ 'someThing:id' ]
someThing: 'asdfasdfasdf'
});
```
However, that was broken during the glimmer refactorings because we
process `attributeBindings` *before* the defaults (meaning the default
`elementId` is used whenever `id` isn't passed in the template).
This fix is to process the default first, then process `attributeBindings`. | [bugfix release] fix `attributebindings` for `id` attribute | 59 | false | false | 7 | false | false | false | emberjs | ember.js | 11,453 |
86d63d43f3e32d89c026693ab687b5de23ac81ba | Stefan Penner | Stefan Penner | Merge pull request #11675 from duggiefresh/public-isany
[DOC release] - Mark Enumerable.isAny as `public` | merge pull request from duggiefresh/public-isany | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,454 |
360d41da7877cd7b00943f0b8d7e7025bc53dbf2 | Robert Jackson | Robert Jackson | Merge pull request #11885 from duggiefresh/doc-public-layout-layoutName
[DOC release] - Mark Component#layout and #layoutName as public | merge pull request from duggiefresh/doc-public-layout-layoutname | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 11,455 |
e96c93450c6dbcaa4ec01c96e292e72b88735f0a | Doug Yun | Doug Yun | [DOC release] - Mark Component#layout and #layoutName as public
[ci skip] | [doc release] - mark component#layout and #layoutname as public | 63 | false | false | 9 | false | false | false | emberjs | ember.js | 11,456 |
e927f3b7787b5339f330d6fd2324a56c1f2a3578 | Matthew Beale | Matthew Beale | Merge pull request #11866 from martndemus/fix-deprecated-view-reopen
[BUGFIX release] Fix DeprecatedView (and friends) reopen function to delegate to original | merge pull request from martndemus/fix-deprecated-view-reopen | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 11,457 |
eeae38e9370589da5d5b4045e1e968b022d7f0b3 | Robert Jackson | Robert Jackson | Merge pull request #11884 from balinterdi/fix-typo-in-query-param-test-description
Fix typo in query param test description | merge pull request from balinterdi/fix-typo-in-query-param-test-description | 76 | true | false | 5 | true | false | false | emberjs | ember.js | 11,458 |
e09c61a717c1c34b03d4cbe30fe87ba4dae9499c | Robert Jackson | Robert Jackson | Merge pull request #11882 from dgeb/fix-11879
[BUGFIX] Correctly alias properties on Container and ApplicationInstance | merge pull request from dgeb/fix-11879 | 39 | true | false | 5 | true | true | false | emberjs | ember.js | 11,459 |
2a32a95b939ecf6ff664f74bcfc2914e11e71a88 | Robert Jackson | Robert Jackson | Merge pull request #11883 from Patsy-issa/ember-inject-controller-public
[DOC Release] Made Ember.inject.controller() public | merge pull request from patsy-issa/ember-inject-controller-public | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 11,460 |
0be28eb608971605ae2f041940ffc2d98a8ffe27 | Balint Erdi | Balint Erdi | Fix typo in query param test description | fix typo in query param test description | 40 | false | false | 7 | true | true | true | emberjs | ember.js | 11,461 |
3cb02b6495b9e44052e2fba75d171fe3d2577be6 | patsy-issa | patsy-issa | Made Ember.inject.controller() public | made ember.inject.controller() public | 37 | false | false | 3 | false | false | false | emberjs | ember.js | 11,462 |
f9f083b7041d1694cf4cc49ebd50ece0acc27afa | Dan Gebhardt | Dan Gebhardt | Fix aliased properties assigned to ApplicationInstance.
Also introduce some basic tests for ApplicationInstance to prevent
regressions.
[Fixes #11879] | fix aliased properties assigned to applicationinstance | 54 | false | false | 6 | true | true | false | emberjs | ember.js | 11,463 |
7f33b312fb308dbbefc197d97b36f1288b454a41 | Dan Gebhardt | Dan Gebhardt | Fix Container#_registry -> Container#registry alias. | fix container#_registry -> container#registry alias | 51 | false | false | 5 | true | true | false | emberjs | ember.js | 11,464 |
82b123c6bea62a0ecafe2b2ae4f3e17d0fd46616 | Robert Jackson | Robert Jackson | Merge pull request #11878 from machty/qp-object-prototype-clash-fix
[BUGFIX beta] QP routes named after Obj.prototype props should work | merge pull request from machty/qp-object-prototype-clash-fix | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 11,465 |
27931735592328ace3fe7cdca08a9643f9a52217 | machty | machty | [BUGFIX beta] QP routes named after Obj.prototype props should work
Fixes #11877 | [bugfix beta] qp routes named after obj.prototype props should work | 67 | false | false | 10 | false | false | false | emberjs | ember.js | 11,466 |
708d3356f40a0e58852e190e2292175815caa9ae | Robert Jackson | Robert Jackson | Merge pull request #11875 from dgeb/remove-unneeded-gets
Remove unnecessary property access with `get`. | merge pull request from dgeb/remove-unneeded-gets | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,467 |
be1d622e3bed92d9073faec23b915b44db48c81c | Robert Jackson | Robert Jackson | Merge pull request #11819 from emberjs/abstract-chainwatchers
[CLEANUP beta] Abstract chainWatchers into an object. | merge pull request from emberjs/abstract-chainwatchers | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,468 |
2f63cab2640d3f138ae41a902968cbcb42b089d8 | Kris Selden | Kris Selden | [CLEANUP beta] Abstract chainWatchers into an object. | [cleanup beta] abstract chainwatchers into an object | 52 | false | false | 7 | false | false | false | emberjs | ember.js | 11,469 |
0d7b8f6989a9208c2151edfa8f7352453fd8f90a | Dan Gebhardt | Dan Gebhardt | Remove unnecessary property access with `get`.
Cleans up proxy methods in ContainerProxy and RegistryProxy. | remove unnecessary property access with `get` | 45 | false | false | 6 | true | true | true | emberjs | ember.js | 11,470 |
aa5cfa963cfb16d437d2d7dcae3c5bdfbd35c02c | Marten Schilstra | Marten Schilstra | [BUGFIX release] Fix DeprecatedView (and friends) reopen function to delegate to original | [bugfix release] fix deprecatedview (and friends) reopen function to delegate to original | 89 | false | false | 12 | false | false | false | emberjs | ember.js | 11,471 |
665c7335d262ccedae8482df9fc5a61da7a9371e | Matthew Beale | Matthew Beale | Merge pull request #11864 from stefanpenner/ensure-test-helpers-are-auto-cleanedup
[BUGFIX release] ensure testHelpers are removed when the app is destr… | merge pull request from stefanpenner/ensure-test-helpers-are-auto-cleanedup | 76 | true | false | 5 | true | false | false | emberjs | ember.js | 11,472 |
9549f063659248350ebf840ff6f407ad2b6797f9 | Robert Jackson | Robert Jackson | Merge pull request #11868 from fpauser/property-set-typo-fix
Fixed typo | merge pull request from fpauser/property-set-typo-fix | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 11,473 |
86459ec25a8dd52d5511d96b61596f98469da38c | Falk Pauser | Falk Pauser | Fixed typo | fixed typo | 10 | false | false | 2 | false | false | false | emberjs | ember.js | 11,474 |
1d7b833664292bc6644adc41a7dd9a842ea078c5 | Robert Jackson | Robert Jackson | Merge pull request #11440 from dgeb/registry-reform
Container / Registry Reform | merge pull request from dgeb/registry-reform | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 11,475 |
c353c383b666474e5fb2c2d6fa17934946dcc9ca | Dan Gebhardt | Dan Gebhardt | Introduce `ember-registry-container-reform` feature flag.
* Ensure that `Container#_registry` remains supported for now.
Can be deleted once cont/reg reform is enabled by default.
* Continue to expose `registry` and `container` on `ApplicationInstance`.
These can be removed once cont/reg reform is enabled, but we’ll still
need to expose `ApplicationInstance.container.lookup` until 3.0.
* Flag deprecation of Application initializer `initialize` arguments. | introduce `ember-registry-container-reform` feature flag | 56 | false | false | 4 | false | false | false | emberjs | ember.js | 11,476 |
253edc47fbfd5960e9438fd6b0cc582a0593d6b5 | Dan Gebhardt | Dan Gebhardt | Mark `ContainerProxy#lookupFactory` private. | mark `containerproxy#lookupfactory` private | 43 | false | false | 3 | false | true | false | emberjs | ember.js | 11,477 |
f982e894fa381d5b5733a065c75576016529a821 | Dan Gebhardt | Dan Gebhardt | Fix app-boot-test to call `app.register`. | fix app-boot-test to call `app.register` | 40 | false | false | 5 | false | false | false | emberjs | ember.js | 11,478 |
e64c9ba077a13a5e493543a7041a090960528595 | Dan Gebhardt | Dan Gebhardt | Replace double quotes with single quotes. | replace double quotes with single quotes | 40 | false | false | 6 | true | true | true | emberjs | ember.js | 11,479 |
e3ad9e2772e066459ddb3af78be45d9a6003f5ce | Dan Gebhardt | Dan Gebhardt | Do not set the resolver on the application instance's registry.
Instead, allow the application's resolver to be invoked only as part of
the fallback strategy for the application instance's registry.
This has a couple benefits:
* It allows registrations made in the app instance's registry to be
resolved before falling back to the app's registry, rather than
hitting the resolver beforehand. This is important for scenarios such
as testing in which custom registrations need to take precedence
over the resolver.
* It is also more efficient in the case when the app's registry's
registrations are used to resolve, because it avoids calling the same
resolver twice before finally getting the registration.
[Closes #11174] | do not set the resolver on the application instance's registry | 62 | false | false | 10 | false | false | false | emberjs | ember.js | 11,480 |
93a95c6bd7533664116e17cc922fda3c2aecd20e | Dan Gebhardt | Dan Gebhardt | Introduce ContainerProxy mixin.
Mix in to `ApplicationInstance` class to provide public access to
a few select methods on the encapsulated container. | introduce containerproxy mixin | 30 | false | false | 3 | true | true | true | emberjs | ember.js | 11,481 |
c1256491085eaa23f9005830074e05f66fe794c2 | Dan Gebhardt | Dan Gebhardt | Rename Container#_registry to Container#registry.
Now that container will be fully privatized, we can relax naming of
members like `registry` that won't be accessed outside of the
framework. | rename container#_registry to container#registry | 48 | false | false | 4 | false | true | false | emberjs | ember.js | 11,482 |
a27dc7af0ca9d6b5766b1ae41f0b7e19c5254071 | Dan Gebhardt | Dan Gebhardt | Initializers now just take a single argument: App.
Registry access must go through the Application now. | app | 3 | false | false | 1 | false | false | false | emberjs | ember.js | 11,483 |
b1cec5585cdcae560b5ca6bded6c467c7cda71c9 | Dan Gebhardt | Dan Gebhardt | Privatize `registry` access with dunderscores.
The `RegistryProxy` mixin now maintains the registry instance as
`__registry__`.
As appropriate, the equivalent `RegistryProxy` methods are called
instead of directly accessing the `registry`. | privatize `registry` access with dunderscores | 45 | false | false | 5 | false | true | false | emberjs | ember.js | 11,484 |
b06bd88352228cbc826b3a0e033936b50506260e | Dan Gebhardt | Dan Gebhardt | Simplify ApplicationInstance creation.
Pass the related Application, which the instance can inspect to obtain
the initialization data that it needs.
This eliminates the need to set `applicationRegistry` on the instance,
which was always an anti-pattern. | simplify applicationinstance creation | 37 | false | false | 3 | true | true | true | emberjs | ember.js | 11,485 |
be5b06723ce293454c1687b406bbe6751bafc954 | Dan Gebhardt | Dan Gebhardt | Comment cleanup / corrections in registry.js. | comment cleanup / corrections in registry.js | 44 | false | false | 6 | false | true | false | emberjs | ember.js | 11,486 |
ca6179249a62943fa84b26e39f1b848e1690dcb8 | Dan Gebhardt | Dan Gebhardt | Introduce RegistryProxy mixin.
Mix in to both `Application` and `ApplicationInstance` classes to
provide consistent public access to their internally maintained
registries. | introduce registryproxy mixin | 29 | false | false | 3 | true | true | true | emberjs | ember.js | 11,487 |
876aeea09c24aa81592a05f33624d1584a8c2310 | Stefan Penner | Stefan Penner | [BUGFIX release] ensure testHelpers are removed when the app is destroyed | [bugfix release] ensure testhelpers are removed when the app is destroyed | 73 | false | false | 11 | false | false | false | emberjs | ember.js | 11,488 |
4ff7ba7fdc73caea97d14c7b30af2916a9d8ba3c | Robert Jackson | Robert Jackson | Merge pull request #11861 from rwjblue/duplicate-keys
[BUGFIX release] Update HTMLBars to allow duplicate {{each}} keys. | merge pull request from rwjblue/duplicate-keys | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,489 |
3204d4eea4494b448bb3780073c191197c92f9c9 | Robert Jackson | Robert Jackson | [BUGFIX release] Test {{each}} with duplicate items. | [bugfix release] test {{each}} with duplicate items | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 11,490 |
6e3085ab0c4db92014c2d5089c1db205b8e051a9 | Robert Jackson | Robert Jackson | [BUGFIX release] Update HTMLBars to allow duplicate {{each}} keys. | [bugfix release] update htmlbars to allow duplicate {{each}} keys | 65 | false | false | 9 | false | false | false | emberjs | ember.js | 11,491 |
aa97f840db966515253489a358195001d1af4ba5 | Stefan Penner | Stefan Penner | Merge pull request #11855 from rwjblue/fix-jshint-error
Fix JSHint error in ember-debug/main. | merge pull request from rwjblue/fix-jshint-error | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,492 |
76f3238605b9317cad3bee31b52219ebf28b5399 | Stefan Penner | Stefan Penner | Merge pull request #11854 from rwjblue/deprecation-cleanup
[CLEANUP beta] Lots of deprecation removals. | merge pull request from rwjblue/deprecation-cleanup | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,493 |
12bca9f7fcdc7701e61f1f84af50919c0065e7af | Robert Jackson | Robert Jackson | Fix JSHint error in ember-debug/main. | fix jshint error in ember-debug/main | 36 | false | false | 5 | true | true | true | emberjs | ember.js | 11,494 |
836e706b68670837a60b8dfb29d4e666383349f7 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `length` from `OrderedSet` and `Map`. | [cleanup beta] remove `length` from `orderedset` and `map` | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 11,495 |
b4d02fd3c91fa9867901dad92acebaea36472e41 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `OrderedSet.prototype.length`. | [cleanup beta] remove `orderedset.prototype.length` | 51 | false | false | 4 | false | false | false | emberjs | ember.js | 11,496 |
546118dcb67e8c8b334725fd0344763b2b221d90 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `Ember.libraries.each`. | [cleanup beta] remove `ember.libraries.each` | 44 | false | false | 4 | false | false | false | emberjs | ember.js | 11,497 |
9787c73c63545883de866cc5afa5c81e208e6946 | Robert Jackson | Robert Jackson | Merge pull request #11852 from rwjblue/remove-render-buffer
[CLEANUP beta] Remove Ember.RenderBuffer. | merge pull request from rwjblue/remove-render-buffer | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,498 |
0955c5e6af914f59b9156b78ed7c8daadd9f5909 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove deprecated special `{{each}}` keys. | [cleanup beta] remove deprecated special `{{each}}` keys | 56 | false | false | 7 | false | false | false | emberjs | ember.js | 11,499 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.