sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
0c95d4904506927d2ee8d0a03692c1910b3ed56c | Robert Jackson | Robert Jackson | Merge pull request #12056 from rwjblue/event-dispatcher-stuffs
[BUGFIX release] Ensure initializers can augment customEvents. | merge pull request from rwjblue/event-dispatcher-stuffs | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,200 |
1f4b499db0570796c9cd8a6ec2864905d3ed93d0 | Godhuda | Godhuda | Merge remote-tracking branch 'origin/master' into glimmer-component | merge remote-tracking branch 'origin/master' into glimmer-component | 67 | true | false | 6 | false | false | false | emberjs | ember.js | 11,201 |
addbd22b9b14e7ecfc83e68a1b6212052077fe07 | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure initializers can augment customEvents.
The initial refactor for Ember 1.11 to use `ApplicationInstance` broke
the ability for an initializer to specify `customEvents`. This meant
for example that addons could not add their own events to the listing
before the `EventDispatcher` was setup.
The reason for the failure, was that we were copying `customEvents` from
the application upon `init` of the `ApplicationInstance` (which is done
before initializers are called), and never looking at
`application.customEvents` again.
The fix is to avoid eagerly copying from `application.customEvents` when
the application instance is created, and to do it just before setting up
the event dispatcher.
Also, apparently `packages/tests/application_lifecycle.js` test file was
never running because it didn't have the proper test file suffix. | [bugfix release] ensure initializers can augment customevents | 61 | false | false | 7 | false | false | false | emberjs | ember.js | 11,202 |
d488f3123793f82d42f3642a086b00658cf2577f | Adam Luikart | Adam Luikart | [DOC release] Make controller property on Route public | [doc release] make controller property on route public | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 11,203 |
5a947038fb8b5713049d65bfe4811cf96031998c | Robert Jackson | Robert Jackson | Merge pull request #12032 from EricSchank/update-docs
[DOC release] document {{input}} helper | merge pull request from ericschank/update-docs | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,204 |
1bd0e85217af038b39a21ea1f650804246e0dac7 | Robert Jackson | Robert Jackson | Merge pull request #12034 from rwjblue/expose-current-path-on-routing-service
Ensure currentRouteName and currentPath are always set. | merge pull request from rwjblue/expose-current-path-on-routing-service | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 11,205 |
8459b2a2e18201404af806d64f7e5c9f9ee437a3 | Stefan Penner | Stefan Penner | Merge pull request #12048 from rwjblue/update-htmlbars
Update HTMLBars to 0.14.3. | merge pull request from rwjblue/update-htmlbars | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 11,206 |
29af9007c04887e0931e96926340a67dd86d1c69 | Robert Jackson | Robert Jackson | Update HTMLBars to 0.14.3. | update htmlbars to 0.14.3 | 25 | false | false | 4 | true | true | true | emberjs | ember.js | 11,207 |
38713a522d0d68c29eceb7c08bbd374b2008df4c | Eric Schank | Eric Schank | [DOC release] document {{input}} helper | [doc release] document {{input}} helper | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 11,208 |
9b6d5ae4104d58b481ec49b1f93e69251c6e0f4e | Godhuda | Godhuda | Implement nextElementSibling in JS
This feature works in all browsers in our support matrix except for
PhantomJS, so the Travis tests are failing. | implement nextelementsibling in js | 34 | false | false | 4 | false | true | false | emberjs | ember.js | 11,209 |
bf5d155faf97cd5a9ac3abb4622f767ff3d3b8ef | Robert Jackson | Robert Jackson | Merge pull request #12046 from mixonic/doc-each-in
[DOC beta] each-in docs | merge pull request from mixonic/doc-each-in | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 11,210 |
5b686d44e3cadb174ed30a2f00e605eca1ebf37f | Godhuda | Godhuda | Disallow fragments in GlimmerComponent for now
There are multiple competing proposals for how to represent fragments in
GlimmerComponents, and we have not yet settled on the exact solution.
In the interim, GlimmerComponents require a top-level wrapper element.
This commit also provides a good error message describing exactly what
the user did wrong. In the future, when fragments are allowed, we can
update the error message to suggest opting into a fragment. | disallow fragments in glimmercomponent for now | 46 | false | false | 6 | false | true | false | emberjs | ember.js | 11,211 |
64247979b8d112de7a89c259ca3e6edc9061abca | Godhuda | Godhuda | Optimize the AST transform for top-level elements
Don’t bother to convert top-level elements into dynamic calls if they
aren’t the top-level element *of a template*.
Consider a template like this:
```
{{#each posts as |post|}}
<div>hello</div>
{{/each}}
```
The previous version of the transform would convert the nested template
(the <div>) into a dynamic call, because the AST transformation didn’t
differentiate between top-level templates and nested templates. It
didn’t have any other effects (the dynamic call is required to restore
the semantics of the original static form) but it unnecessarily bloats
templates and makes execution slower. | optimize the ast transform for top-level elements | 49 | false | false | 7 | true | true | true | emberjs | ember.js | 11,212 |
b5734429665f895583c3b553655544e415f9338a | Matthew Beale | Matthew Beale | [DOC beta] each-in docs | [doc beta] each-in docs | 23 | false | false | 4 | false | false | false | emberjs | ember.js | 11,213 |
b2b6861081b810b3ca45751468868041403408dd | Matthew Beale | Matthew Beale | Merge pull request #12043 from mixonic/docs
[DOC release] Bring back docs for several helpers | merge pull request from mixonic/docs | 37 | true | false | 5 | true | false | false | emberjs | ember.js | 11,214 |
99aaa34224e96df97b95a2ceeba9755af356fc0a | Matthew Beale | Matthew Beale | [DOC release] Bring back docs for several helpers | [doc release] bring back docs for several helpers | 49 | false | false | 8 | false | false | false | emberjs | ember.js | 11,215 |
6f359d2a9c97724cf885d80f2fcfced0ca1570a1 | Godhuda | Godhuda | Merge pull request #11991 from funtusov/failing_angle_bracket_component_computed_function
Failing test for computed property alias in angle-bracket component | merge pull request from funtusov/failing_angle_bracket_component_computed_function | 83 | true | false | 5 | true | false | false | emberjs | ember.js | 11,216 |
a55c38def25a3d50286f8f5eec78f372df5abff3 | Godhuda | Godhuda | Merge remote-tracking branch 'origin/master' into glimmer-component | merge remote-tracking branch 'origin/master' into glimmer-component | 67 | true | false | 6 | false | false | false | emberjs | ember.js | 11,217 |
92b8d933bc4052b23626a983b1622512e6b19baf | Robert Jackson | Robert Jackson | Merge pull request #12037 from jmurphyau/issue-11857
[BUGFIX release] Fix cacheValuePrefix Error | merge pull request from jmurphyau/issue-11857 | 46 | true | false | 5 | true | true | false | emberjs | ember.js | 11,218 |
bfd52f006d9c287d2d1c107afbda79c8ef049440 | James Murphy | James Murphy | [BUGFIX release] Fix cacheValuePrefix Error
Fixed an issue where cacheValuePrefix would incorrectly check "valA in valB" where valB would be null
Resolves Issue #11857 | [bugfix release] fix cachevalueprefix error | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 11,219 |
87e021a83559001dec692e6872a69ce2752f8f59 | Godhuda | Godhuda | Make regular elements like identity elements
In Ember 1.x components, the top-level element was configured in
JavaScript using APIs like `classNames`, `attributeBindings`, `tagName`
etc.
Glimmer components move that configuration into a top-level element in
the template. However, the template compiler does not know how the
template will actually be used, so it makes all top-level elements
dynamic, and leaves it up to the runtime to figure out what to do.
If the template is being invoked for a curly component, the runtime
restores the original semantics, treating it just like a regular
element.
If the template is being invoked for an angle-bracket component, the
top-level element is treated as the component’s element.
This commit makes top-level `<div>`s work correctly in Glimmer
components (they become the component’s element), and work correctly
in curly components (they behave as before).
Both modifiers (`<div {{action “foo”}}>`) and triple-curly attributes
are not supported in top-level elements of Glimmer components. As a
result, if the AST transformation sees either of those two features,
it assumes the template is for a curly component, and does not make the
root element dynamic.
At the moment, it would be impossible to support either of those two
features, since the component AST node in HTMLBars do not support them.
Ultimately, we may want to support triple-curly attributes, but probably
not modifiers.
Note that this commit requires an update to HTMLBars master. | make regular elements like identity elements | 44 | false | false | 6 | true | true | true | emberjs | ember.js | 11,220 |
0a66e7f0cad634876297c2814190c52db83a73ec | Godhuda | Godhuda | Skip AST transform without Glimmer Components
To reduce the possibility of regressions when the
`ember-htmlbars-component-generation` flag is off, this commit moves an
important AST transformation behind the flag.
This AST transformation makes top-level elements in *all* templates
dynamic, and requires runtime work to restore the original semantics.
Moving the AST transformation behind the flag limits the impact of any
bugs in the runtime work. | skip ast transform without glimmer components | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 11,221 |
f3ab6c283e462f401f0a083beb677c434a5cde31 | Robert Jackson | Robert Jackson | Ensure currentRouteName and currentPath are always set.
Previously, the `currentRouteName` and `currentPath` were only set if
`controller:application` existed. This ensures that the props on the
router itself are set (just not the ones on `controller:application`
when it isn't setup yet).
Also, add `currentPath` to `service:-routing`. | ensure currentroutename and currentpath are always set | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 11,222 |
afb1f3dd977c7317981cbe2db148671d690745bf | Godhuda | Godhuda | Merge remote-tracking branch 'origin/master' into glimmer-component | merge remote-tracking branch 'origin/master' into glimmer-component | 67 | true | false | 6 | false | false | false | emberjs | ember.js | 11,223 |
52b55acfbb40d92cfdced7573bd302c2f9562bfa | Robert Jackson | Robert Jackson | Merge pull request #12031 from steffenbrem/fix-docs-typo
Fix typo in docs for `mut` helper | merge pull request from steffenbrem/fix-docs-typo | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,224 |
fc20f0a5205359ca1b01a8403002724dc79af046 | Steffen Brem | Steffen Brem | FIx typo in docs for `mut` helper | fix typo in docs for `mut` helper | 33 | false | false | 7 | true | true | true | emberjs | ember.js | 11,225 |
590c1a492806c5e435da54f1d7d311baf2423f6b | Robert Jackson | Robert Jackson | Merge pull request #11908 from bmac/update-changelog-script
Update the changelog script to make it more robust about finding the … | merge pull request from bmac/update-changelog-script | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,226 |
06b1bb62edd67c2fa3e5723b795c2b72d9cf4e1d | Robert Jackson | Robert Jackson | Merge pull request #12005 from ef4/before-observers-are-evil
Remove internal uses of beforeObservers | merge pull request from ef4/before-observers-are-evil | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 11,227 |
1b45842c29987705d4482e71afd292b6a96a1c70 | Robert Jackson | Robert Jackson | Merge pull request #12030 from EricSchank/update-docs
[DOC release] document {{mut}} helper | merge pull request from ericschank/update-docs | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,228 |
24f6a96939a275b0a0d6a26a189df5fdcd1f682a | Eric Schank | Eric Schank | [DOC release] document {{mut}} helper | [doc release] document {{mut}} helper | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 11,229 |
17297c94522d7d9ccf356b3f3b40c5e1003d8a37 | Robert Jackson | Robert Jackson | Merge pull request #12029 from EricSchank/update-docs
[DOC release] document {{outlet}} helper | merge pull request from ericschank/update-docs | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,230 |
c0ce9f7f7f05d0ced104d9b39723924ea66a700b | Robert Jackson | Robert Jackson | Merge pull request #11550 from swarmbox/v2.0.0-beta.1+canary+redefine-property-observer-fix
[BUGFIX beta] Observers after Dependent Key Change | merge pull request from swarmbox/v2.0.0-beta.1+canary+redefine-property-observer-fix | 85 | true | false | 5 | true | false | false | emberjs | ember.js | 11,231 |
c9577a9ad7dfcd165423f5f3ca1488cdd866a572 | Robert Jackson | Robert Jackson | Merge pull request #11705 from Kerrick/patch-1
Mark Enumerable#sortBy as public | merge pull request from kerrick/patch-1 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 11,232 |
4630cfac6bd65f2e455b45778a7049ed2b8b7e5f | Robert Jackson | Robert Jackson | Merge pull request #11983 from emberjs/fix-volatile-setter
[BUGFIX beta] Cleanup CP set, volatile and various related things. | merge pull request from emberjs/fix-volatile-setter | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,233 |
02ed7516c7f9612ae8cb5d7d2aa3080f38396666 | Eric Schank | Eric Schank | [DOC release] document {{outlet}} helper | [doc release] document {{outlet}} helper | 40 | false | false | 5 | false | false | false | emberjs | ember.js | 11,234 |
66e71ff7957eaf61d05a98d2a721b220aab8e168 | Robert Jackson | Robert Jackson | Merge pull request #12028 from rwjblue/remove-underscore-actions
[CLEANUP beta] Store actions in `actions` not `_actions`. | merge pull request from rwjblue/remove-underscore-actions | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,235 |
76b3f7a005eabc6758702e999ce53aef65481438 | Robert Jackson | Robert Jackson | [BUGFIX beta] Guard `meta` and move readonly error to prototype. | [bugfix beta] guard `meta` and move readonly error to prototype | 63 | false | false | 10 | false | false | false | emberjs | ember.js | 11,236 |
5214c634421081d30cb474a55d3d461afec153ea | Robert Jackson | Robert Jackson | [CLEANUP beta] Store actions in `actions` not `_actions`.
Provide a deprecated property accessor at `._actions` for backwards
compatibility. | [cleanup beta] store actions in `actions` not `_actions` | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 11,237 |
d2c181edf15e66ff7ae1f55083288f60352ca3e7 | Robert Jackson | Robert Jackson | Merge pull request #12027 from rwjblue/remove-deprecated-template-access-from-component
[CLEANUP beta] Remove deprecated `template` access in Ember.Component. | merge pull request from rwjblue/remove-deprecated-template-access-from-component | 81 | true | false | 5 | true | false | false | emberjs | ember.js | 11,238 |
bccb1e046c7519392e5925c58e688a30245214e3 | Robert Jackson | Robert Jackson | Merge pull request #12024 from rwjblue/remove-component-template-deprecation
[CLEANUP beta] Remove `ComponentTemplateDeprecation` mixin. | merge pull request from rwjblue/remove-component-template-deprecation | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 11,239 |
16e064a65855db074d6aa38caf6580ba84e31f75 | Matthew Beale | Matthew Beale | Merge pull request #12014 from btecu/master
[DOC release] Mark didTransition and willTransition as public | merge pull request from btecu/master | 37 | true | false | 5 | true | false | false | emberjs | ember.js | 11,240 |
9a0b064e9c2050a8efaad2efe190788fd8113ced | Bujorel Tecu | Bujorel Tecu | [DOC release] Mark didTransition and willTransition as public | [doc release] mark didtransition and willtransition as public | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 11,241 |
e71d6a8847f3634483afecf52adbfeae91e28425 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove template CP on `Ember.Component`. | [cleanup beta] remove template cp on `ember.component` | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 11,242 |
a5b5213e1ee4ffd63179a8a1d8c140bd7acf417d | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove support for specifying `template` in a component. | [cleanup beta] remove support for specifying `template` in a component | 70 | false | false | 10 | false | false | false | emberjs | ember.js | 11,243 |
1d1301522db83ee2ceb592eed43b1aff962b505a | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `positionalParams` specified to `.extend`. | [cleanup beta] remove `positionalparams` specified to `.extend` | 63 | false | false | 7 | false | false | false | emberjs | ember.js | 11,244 |
5030271be8d99bb023f5d045dc94cf39d0c6e6b7 | Robert Jackson | Robert Jackson | [CLEANUP beta] Ensure `{{foo-bar controller=blah}}` triggers an assertion. | [cleanup beta] ensure `{{foo-bar controller=blah}}` triggers an assertion | 73 | false | false | 8 | false | false | false | emberjs | ember.js | 11,245 |
3f1614cb966efeb9a84b203095f51feeb974eb63 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove deprecated `template` access in Ember.Component. | [cleanup beta] remove deprecated `template` access in ember.component | 69 | false | false | 8 | false | false | false | emberjs | ember.js | 11,246 |
7c008239182cce203f024768d3df999c2850f66f | Robert Jackson | Robert Jackson | Merge pull request #12026 from rwjblue/remove-dep-keys
[BUGFIX release] Remove wasted DK's for `template` and `layout`. | merge pull request from rwjblue/remove-dep-keys | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 11,247 |
306778b55cb7cc03b2489c9c0c0f9d9e5d74ab99 | Robert Jackson | Robert Jackson | [BUGFIX release] Remove wasted DK's for `template` and `layout`.
We used to observe and rerender properly when `template` or `layout`
changed. As of 1.13 we do not rerender any longer, and the additional
dependent keys cause extra unusable observers (which add up perf wise).
It is unclear if the change to make `layout` not rerender is a
regression, but we certainly shouldn't be paying for observation when we
can't take advantage of it. | [bugfix release] remove wasted dk's for `template` and `layout` | 63 | false | false | 9 | false | false | false | emberjs | ember.js | 11,248 |
e75a442a7712fe58c5de999373937feaef025272 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `ComponentTemplateDeprecation` mixin.
Specifying `template` or `templateName` to a Component has been
deprecated (and moved to `layout` or `layoutName`) for a very long time
(1.3.x).
This removes that long deprecated behavior. | [cleanup beta] remove `componenttemplatedeprecation` mixin | 58 | false | false | 5 | false | false | false | emberjs | ember.js | 11,249 |
f1a3fe65a748de56c7642a1ee1e9a49c5b1b18ed | Robert Jackson | Robert Jackson | Merge pull request #12020 from rwjblue/cleanup-render
[CLEANUP beta] Remove `View.prototype.render`. | merge pull request from rwjblue/cleanup-render | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,250 |
65bdee00782c6d0a7930fc4c3eb8f2639555a286 | Robert Jackson | Robert Jackson | Merge pull request #12023 from mixonic/get-docs
[DOC beta] Add docs for get helper | merge pull request from mixonic/get-docs | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 11,251 |
ba6935ee0f1cab1a1f893c1502c77ca18ba5b81b | Robert Jackson | Robert Jackson | Merge pull request #12022 from mixonic/update-templates
[DOC release] Fix up ember-templates namespace docs | merge pull request from mixonic/update-templates | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,252 |
c10d14715c7f2da98c0ff9d28d46cbfbf0d95461 | Matthew Beale | Matthew Beale | [DOC beta] Add docs for get helper | [doc beta] add docs for get helper | 34 | false | false | 7 | false | false | false | emberjs | ember.js | 11,253 |
7eaead1cfa0ea570de83d2c45036f4564d88ac2f | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove `View.prototype.render`. | [cleanup beta] remove `view.prototype.render` | 45 | false | false | 4 | false | false | false | emberjs | ember.js | 11,254 |
e9751f500a3560531406b91efba02ce2a87d3ffd | Robert Jackson | Robert Jackson | Merge pull request #12021 from mixonic/unbound-doc
[DOC release] Improve unbound documentation | merge pull request from mixonic/unbound-doc | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 11,255 |
74ee133f46600affd7cf78ee99f0029cf378828f | Matthew Beale | Matthew Beale | [DOC release] move concat helper to the right spot | [doc release] move concat helper to the right spot | 50 | false | false | 9 | false | false | false | emberjs | ember.js | 11,256 |
f99140553f849944fe38223f9d29c6708a47fc40 | Robert Jackson | Robert Jackson | Merge pull request #12019 from rwjblue/add-assertion-for-at-each
[DOC beta] Add helpful assertion when using @each as a leaf in DK. | merge pull request from rwjblue/add-assertion-for-at-each | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,257 |
b9f80fcf8fd775e14bca5e51de18144ab70a1910 | Matthew Beale | Matthew Beale | [DOC release] Fix up ember-templates namespace docs | [doc release] fix up ember-templates namespace docs | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 11,258 |
341a876aed8db78dd76deb88f684b959ed68116f | Robert Jackson | Robert Jackson | [DOC beta] Add helpful assertion when using @each as a leaf in DK. | [doc beta] add helpful assertion when using @each as a leaf in dk | 65 | false | false | 13 | false | false | false | emberjs | ember.js | 11,259 |
4feb881d8de319683369fb1f6545cf8ac9c59e57 | Robert Jackson | Robert Jackson | Merge pull request #12017 from rwjblue/deprecate-render-function
[BUGFIX release] Deprecate specifying `.render` to views/components. | merge pull request from rwjblue/deprecate-render-function | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,260 |
32fb31a7fe1fd7e759c1e90677c389e0a1cc1665 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate specifying `.render` to views/components. | [bugfix release] deprecate specifying `.render` to views/components | 67 | false | false | 7 | false | false | false | emberjs | ember.js | 11,261 |
f7ac13b6a8dfeaf9241c5a7c956077cae9eaad09 | Matthew Beale | Matthew Beale | [DOC release] Improve unbound documentation | [doc release] improve unbound documentation | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 11,262 |
ca436a2b1d4d488a6aeadd9ba7e6ab170e3a5e49 | Godhuda | Godhuda | WIP: make regular elements like identity elements | make regular elements like identity elements | 44 | false | false | 6 | true | true | true | emberjs | ember.js | 11,263 |
c745c4766c371a3495049a9769876a6680ddbe85 | Godhuda | Godhuda | Fix GlimmerComponent scoping issue
See "non-block ... should have correct scope" test cases | fix glimmercomponent scoping issue | 34 | false | false | 4 | false | true | false | emberjs | ember.js | 11,264 |
f2f09e8d12cc2c8e440eca0582cefd507c5a05a9 | Godhuda | Godhuda | Skip failing tests for now
Also re-enabling a test that was actually fixed in the previous commit. | skip failing tests for now | 26 | false | false | 5 | true | true | true | emberjs | ember.js | 11,265 |
fe1dd754739b8f8b36b5e5c2be4b05d9cbf4c8f1 | Godhuda | Godhuda | Refactor test cases to not test exact output
This was annoying because the ordering of non-user attributes are
unimportant, but can change (and has changed) depending on the
implementation. | refactor test cases to not test exact output | 44 | false | false | 8 | false | false | false | emberjs | ember.js | 11,266 |
fa01e2424d1e699c43abfaed37266339936c3305 | Godhuda | Godhuda | Fix GlimmerComponent not having `this.element` set | fix glimmercomponent not having `this.element` set | 50 | false | false | 6 | false | true | false | emberjs | ember.js | 11,267 |
7f62867aca66db04f09481c2f10719b1ab762c47 | Robert Jackson | Robert Jackson | Merge pull request #12013 from rwjblue/update-qunit
Update QUnit to 1.18.0. | merge pull request from rwjblue/update-qunit | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 11,268 |
d280c5353c3031272a3fda59e619e1d8f6fc6e02 | Godhuda | Godhuda | Remove post-processing ("attributes") hook
This was previously used for attaching outer attributes as well as
system attributes (e.g. class="ember-view" id="ember123") onto regular
HTML elements at the root, once they have been rendered.
This results in multiple AttrNodes for a single attribute, which means
that there is no guarantee that any particular AttrNode will actually
"win". This incorrect strategy "works" a surprising amount of the time,
but the failure modes are unacceptable. (See new tests introduced in the
previous commit.)
This is in anticipation of making all top-level elements in a
component's layout dynamic, so that they can share attribute merging
logic with the "identity element" case (top-level `<my-component>` in
the layout for `my-component`). | remove post-processing ("attributes") hook | 42 | false | false | 4 | true | false | true | emberjs | ember.js | 11,269 |
205a393af9b669e78e3ca196515a453c3d0cdaf0 | Robert Jackson | Robert Jackson | Update QUnit to 1.18.0.
Also includes an update to emberjs-build to ensure the static test page
that is generated contains the correct QUnit version. | update qunit to 1.18.0 | 22 | false | false | 4 | true | true | true | emberjs | ember.js | 11,270 |
b0644b1cd9b5d76db10ee24d0ca644fd7bc7fb82 | Trek Glowacki | Trek Glowacki | Merge pull request #11890 from pixelhandler/contributing-feature-requests
[Documentation] Contributing: use RFC process for new features | merge pull request from pixelhandler/contributing-feature-requests | 67 | true | false | 5 | true | true | false | emberjs | ember.js | 11,271 |
a668299bc8dcc922617718d9dc4b63152413cef2 | Godhuda | Godhuda | Add some new (failing) tests for component bugs | add some new (failing) tests for component bugs | 47 | false | false | 8 | true | false | true | emberjs | ember.js | 11,272 |
a3b88ec526edf92992ed2fb17c13c046385b55ab | Godhuda | Godhuda | This commit fixes a top-level element bug
If the layout for `<my-component>` has `<my-component>` as its root
element, this is a special case. The semantics of this case are intended
to be the same as a top-level `<div>`.
However, in an attempt to share code, we inadvertantly introduced a bug
where we installed the dynamic attributes defined by JS APIs twice (via
`normalizeComponentAttributes` and post-processing of the parent
template).
The fix, therefore, is to not do anything special with dynamic
attributes and rely on the same post-processing step as the `<div>`
case. | this commit fixes a top-level element bug | 41 | false | false | 7 | false | false | false | emberjs | ember.js | 11,273 |
361990401342186150f43004eb35f2a83dfc3789 | Godhuda | Godhuda | Remove incorrect attributes
This code was previously telling HTMLBars to post-process content
templates to add top-level attributes. That is not correct (it only
makes sense to post-process layouts). | remove incorrect attributes | 27 | false | false | 3 | true | true | true | emberjs | ember.js | 11,274 |
6b002cafaaa6cae7d792814065eff7adb3fb6fc4 | Godhuda | Godhuda | Re-enable skipped tests for GlimmerComponents
They were disabled due to a bug in the feature flag infrastructure; but
it has since been fixed and everything appears to be working again here. | re-enable skipped tests for glimmercomponents | 45 | false | false | 5 | false | true | false | emberjs | ember.js | 11,275 |
912392ea5d7d5bb607c0914c40b5810dbef3d4bd | Godhuda | Godhuda | Show error for component class/invocation mismatch
1. {{my-component ...}} curly braces can only be used on legacy Component
2. <my-component ...> angle brackets can only be used on GlimmerComponent
TBD: rule number 2 might be loosened with an explicit opt-in later,
depending on how painful this transition turns out to be for large apps.
It might be better to provide automated rewriting through ember-watson,
which would do the job quickly, once and for all, rather than leaving
large apps in a semantic limbo with one foot in the old world and
another foot in the new world. | show error for component class/invocation mismatch | 50 | false | false | 6 | true | true | true | emberjs | ember.js | 11,276 |
8dc7d58cd4c0f45cc5aaf79c3ccf03d10dd7445f | Godhuda | Godhuda | Fix attr setting in Glimmer Components
Previously, Glimmer components got their attrs set after positional
attrs were applied. The `didInitAttrs` hook was used to indicate that
the full set of attributes were applied.
Recently, positional attrs were changed to ensure that the full set of
attrs are always applied before `init`, eliminating the need for
`didInitAttrs`.
However, the existing code that applied attrs on init only did so for
non-angle bracket components (to avoid double-setting on new-world
features). Consequently, angle bracket components *never* got their
attrs set.
This commit ensures that `attrs` are set on all components before init,
regardless of style. | fix attr setting in glimmer components | 38 | false | false | 6 | true | true | true | emberjs | ember.js | 11,277 |
fb9477dc7fab6d38553d4774eacb993e56545531 | Godhuda | Godhuda | Fix tests
1. Make sure tests that test Glimmer Components are feature flagged.
2. Update a test to use `init` instead of `didInitAttr` due to a change to
the lifecycle that landed on master. | fix tests | 9 | false | false | 2 | true | true | false | emberjs | ember.js | 11,278 |
a6856fdaf25afa4fbdf971a54084874eeece896b | Yehuda Katz | Godhuda | Create GlimmerComponent subclass | create glimmercomponent subclass | 32 | false | false | 3 | true | true | true | emberjs | ember.js | 11,279 |
9de956f44464af0ed9d89906ca3a2f3bf998fc02 | Tom Dale | Godhuda | wip | wip | 3 | false | false | 1 | false | false | false | emberjs | ember.js | 11,280 |
f36f569cbe15d90ea9cb12b8f24cf230eed3d417 | Tom Dale | Godhuda | Move Ember.Component to components/ directory | move ember.component to components/ directory | 45 | false | false | 5 | true | true | true | emberjs | ember.js | 11,281 |
d315900ea5d7fc976b4b1b9901c6c7ff9f0fc46e | Tom Dale | Godhuda | Remove unused view mixin | remove unused view mixin | 24 | false | false | 4 | false | true | false | emberjs | ember.js | 11,282 |
b3865f80a61fa1b24055000d918d53768e85fc01 | Matthew Beale | Matthew Beale | Merge pull request #12010 from duggiefresh/12004-doc-array-methods
[DOC release] Mark `Ember.Array` methods as public | merge pull request from duggiefresh/12004-doc-array-methods | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 11,283 |
d9c3027ef60b47d55ba62d0ccd07aea339171a33 | Doug Yun | Doug Yun | [DOC release] Mark `Ember.Array` methods as public
- compact
- every
- forEach
- without
- sortBy
Closes #12004
[ci skip] | [doc release] mark `ember.array` methods as public | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 11,284 |
3c4749a19826b5e0479679341d2a746a04424685 | Matthew Beale | Matthew Beale | Merge pull request #12009 from duggiefresh/11989-doc-unbound
[DOC release] Ember.HTMLBars.unbound | merge pull request from duggiefresh/11989-doc-unbound | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 11,285 |
c3b61b86e2268533f23f22b1304ca453769f3841 | Doug Yun | Doug Yun | [DOC release] Ember.HTMLBars.unbound
Closes #11989
[ci skip] | [doc release] ember.htmlbars.unbound | 36 | false | false | 3 | false | false | false | emberjs | ember.js | 11,286 |
d9c3a617f9369424e3d2c4b2ec00aa4fba389353 | Matthew Beale | Matthew Beale | Merge pull request #11970 from pixelhandler/ember-rfc-80
[DOC Release] Make ArrayProxy public | merge pull request from pixelhandler/ember-rfc-80 | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,287 |
c8f6ecd52885dd4865d9cc3c105da111bd88cd37 | Edward Faulkner | Edward Faulkner | Remove internal uses of beforeObservers
This refactors array_proxy, collection_view, and container_view to not
depend on beforeObservers. The motivation here is to get us closer to
the point where an app that doesn't use any beforeObservers doesn't need
to pay the performance cost of supporting them. | remove internal uses of beforeobservers | 39 | false | false | 5 | true | true | true | emberjs | ember.js | 11,288 |
62e32596c4a864a2f162a518df0e4d97cc721988 | Robert Jackson | Robert Jackson | Merge pull request #11984 from emberjs/fix-each
[PERF beta] `@each` should remain a stable node for chains. | merge pull request from emberjs/fix-each | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 11,289 |
490fba7e014a60bb73694ee8e213b84386bc548d | Robert Jackson | Robert Jackson | Merge pull request #12001 from rwjblue/remove-with-controller
[CLEANUP beta] Remove {{with}} keyword's controller option. | merge pull request from rwjblue/remove-with-controller | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,290 |
75a7ba3095728fd8ad0eff5a5f33d8298903a6c1 | Mike M Pestorich | Mike M Pestorich | [BUGFIX beta] Observers after Dependent Key Change
Currently when a property is overriden in an extended class and its
dependent keys change, observers watching that property will still fire
for changes made to the old set of dependent keys.
```js
var count = 0;
var MyClass = Ember.Object.extend({
prop1: 'foo',
content: Ember.computed.alias('prop1'),
incrementCount: Ember.observer('content', function () { count++; })
});
var obj = MyClass.extend({
prop2: Ember.computed.alias('prop1'),
content: Ember.computed.alias('prop2') // redefine content with diff depKey
}).create();
Ember.run(function() {
obj.set('prop1', 'bar');
});
// assert(count === 1); // Fails, should be 1 but in fact is 2
``` | [bugfix beta] observers after dependent key change | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 11,291 |
5868df395fdcd66f7f44f558b4a5aa619a20a8a3 | Kris Selden | Kris Selden | [PERF beta] `@each` should remain a stable node for chains.
`@each` was designed for chaining, the special cased eager behavior + it invalidating for array changes meant that the EachProxy and chains were rebuilt every array change, instead of the leaves just changing.
Conflicts:
packages/ember-runtime/lib/system/each_proxy.js
packages/ember-runtime/tests/mixins/array_test.js | [perf beta] `@each` should remain a stable node for chains | 58 | false | false | 10 | false | false | false | emberjs | ember.js | 11,292 |
95823bc9a348522731e4fe46f177b9b947fef733 | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove {{with}} keyword's controller option. | [cleanup beta] remove {{with}} keyword's controller option | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 11,293 |
af8ed0440b416ce59fc538d20d9f1e2f0e60ecfc | Robert Jackson | Robert Jackson | Merge pull request #12000 from rwjblue/deprecate-with-controller
[BUGFIX release] Deprecate using `controller` for {{with}} | merge pull request from rwjblue/deprecate-with-controller | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,294 |
4dee6c5c3c940c2052f4d8736692f106b153eb78 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate using `controller` for {{with}} | [bugfix release] deprecate using `controller` for {{with}} | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 11,295 |
691fc6045e24f2cfe73c7e011f9c8d9cbd5a7493 | Robert Jackson | Robert Jackson | Merge pull request #11993 from rwjblue/remove-cruft
Deprecate and remove TrackedArray and SubArray. | merge pull request from rwjblue/remove-cruft | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 11,296 |
883cd4b9d59d0db7da4a50994fb68cbcaab555eb | Robert Jackson | Robert Jackson | [CLEANUP beta] Remove Ember.TrackedArray and Ember.SubArray. | [cleanup beta] remove ember.trackedarray and ember.subarray | 59 | false | false | 6 | false | false | false | emberjs | ember.js | 11,297 |
1f50e49b277b27637f7525fa488ca9a34960e43b | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate Ember.SubArray | [bugfix release] deprecate ember.subarray | 41 | false | false | 4 | false | false | false | emberjs | ember.js | 11,298 |
281b8ca95329a23e06eea9e4dfb7460abb991dd7 | Robert Jackson | Robert Jackson | [BUGFIX release] Deprecate Ember.TrackedArray. | [bugfix release] deprecate ember.trackedarray | 45 | false | false | 4 | false | false | false | emberjs | ember.js | 11,299 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.