sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
95f8650654c12e458f5df20bd279c7734eadf326 | Alex Navasardyan | Alex Navasardyan | Disallows blocks from beginning and ending with 2 newlines. | disallows blocks from beginning and ending with 2 newlines | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 11,700 |
2b2ebc2df4e75ec1a587168f7ec49ad452773ea9 | Doug Yun | Doug Yun | [DOC release] - Mark Enumerable.isAny as `public`
[ci skip] | [doc release] - mark enumerable.isany as `public` | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 11,701 |
9ff18d05aa71f66666cb17bafe95dbea22b7d12d | Stefan Penner | Stefan Penner | Merge pull request #11690 from emberjs/fix-master
I must have broken stuff, anyways restoring... | merge pull request from emberjs/fix-master | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 11,702 |
5550de14dfbd158e576fec9401e34ffc529a21b0 | Stefan Penner | Stefan Penner | [BUGFIX release] Correct apply in deprecateFunc
Re: #11677 (comment)
restored by @stefanpenner | [bugfix release] correct apply in deprecatefunc | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 11,703 |
6b1068a23c3974150742f67a06dc0f507ddf86bb | Stefan Penner | Stefan Penner | Merge pull request #11587 from emberjs/remove-bind-attr
[CLEANUP beta] Remove bind-attr | merge pull request from emberjs/remove-bind-attr | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,704 |
3da09505bd8a0178102d497672cecbcdea341e8d | Stefan Penner | Stefan Penner | [BUGFIX release] Deprecate `immediateObserver`
* Ember.immediateObserver was already deprecated, but it's prototype
extension counterpart wasn't. It's not used internally at all.
* Improve beforeObserver deprecations.
* I had to improve `Ember.deprecateFunc` to accept an options object
(originally by @cibernox, but I screwed up master, so in-case i messed something up I’ll take the git-blame | [bugfix release] deprecate `immediateobserver` | 46 | false | false | 4 | false | false | false | emberjs | ember.js | 11,705 |
19499a3b3a06180a248b6bd591b296c861a17df7 | Miguel Camba | Stefan Penner | [BUGFIX release] Privatize all related with beforeObserver and deprecate public APIs | [bugfix release] privatize all related with beforeobserver and deprecate public apis | 84 | false | false | 11 | false | false | false | emberjs | ember.js | 11,706 |
67a941ae46a3c41892283cd47521e83bfd114210 | Doug Yun | Stefan Penner | [CLEANUP beta] Removes `someProperty` | [cleanup beta] removes `someproperty` | 37 | false | false | 4 | false | false | false | emberjs | ember.js | 11,707 |
642f5c385c1aad20215b756c2940df19bc07f5a1 | Martin Muñoz | Martin Muñoz | [CLEANUP beta] Remove bind-attr | [cleanup beta] remove bind-attr | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 11,708 |
c3f15cf4c226adf621e93b13e240f4117a7bbc6b | Stefan Penner | Stefan Penner | just some cleanup | just some cleanup | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 11,709 |
dba41cbad681a2da3002fe2bb08acd904b63805e | Stefan Penner | Stefan Penner | [BUGFIX beta] ensure fmt + loc use restArgs, which prevents `arguments` from leaking around. | [bugfix beta] ensure fmt + loc use restargs, which prevents `arguments` from leaking around | 91 | false | false | 14 | false | false | false | emberjs | ember.js | 11,710 |
a6e119ddaf4ed86134b17af053e92fdbaf7d283d | Stefan Penner | Stefan Penner | Merge pull request #10137 from vitch/patch-3
[DOC] Clear up description for isAny/isEvery | merge pull request from vitch/patch-3 | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 11,711 |
8767515d65def291dfbf42b9ad7f48816f425a32 | Stefan Penner | Stefan Penner | Merge pull request #11665 from stefanpenner/fixup-tests
Fixup tests | merge pull request from stefanpenner/fixup-tests | 49 | true | false | 5 | true | true | false | emberjs | ember.js | 11,712 |
9adc59d0b45d01c8eeb9b1d074c76a0bcbcd2ddb | Stefan Penner | Stefan Penner | Merge pull request #11632 from HeroicEric/mark-enum-everyby-public
[DOC Release] Mark Enumerable.everyBy() as public | merge pull request from heroiceric/mark-enum-everyby-public | 60 | true | false | 5 | true | true | false | emberjs | ember.js | 11,713 |
663aff3f77d3a03906f952958794c104b20407b6 | Stefan Penner | Stefan Penner | Merge pull request #11628 from HeroicEric/mark-filter-public
[DOC Release] Mark Enumerable.filter() as public | merge pull request from heroiceric/mark-filter-public | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 11,714 |
6276f931b2ada79a6c5ddc3ff3796c34c008608f | Stefan Penner | Stefan Penner | Merge pull request #11629 from HeroicEric/mark-enum-rejectby-public
[DOC Release] Mark Enumerable.rejectBy() as public | merge pull request from heroiceric/mark-enum-rejectby-public | 61 | true | false | 5 | true | true | false | emberjs | ember.js | 11,715 |
14536c1e91fa45ea94e6991a6b07fc3705ccaa95 | Stefan Penner | Stefan Penner | Merge pull request #11626 from HeroicEric/mark-enum-filter-by-public
[DOC Release] Mark Enumerable.filterBy() as public | merge pull request from heroiceric/mark-enum-filter-by-public | 62 | true | false | 5 | true | true | false | emberjs | ember.js | 11,716 |
5e86d5ca686e8ebecac5f904ad9d69c3e3a57f1b | Stefan Penner | Stefan Penner | Merge pull request #11625 from HeroicEric/mark-enum-reject-public
[DOC Release] Mark Enumerable.reject() as public | merge pull request from heroiceric/mark-enum-reject-public | 59 | true | false | 5 | true | true | false | emberjs | ember.js | 11,717 |
b1d83df686c68ea7f615a36afcd65e73901980c9 | Stefan Penner | Stefan Penner | Merge pull request #11623 from HeroicEric/mark-enum-mapby-public
[DOC Release] Mark Enumerable.mapBy() as public | merge pull request from heroiceric/mark-enum-mapby-public | 58 | true | false | 5 | true | true | false | emberjs | ember.js | 11,718 |
8c5fd2ff0dc051a8646db2fe67419270e07b81f8 | Stefan Penner | Stefan Penner | Merge pull request #11622 from HeroicEric/mark-enum-map-public
[DOC Release] Mark Enumerable.map() as public | merge pull request from heroiceric/mark-enum-map-public | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 11,719 |
e748d68cb6cdb5b56d3345303fcc73acdb00a17d | Stefan Penner | Stefan Penner | Merge pull request #11621 from HeroicEric/mark-seteach-public
[DOC Release] Mark Enumerable.setEach() as public | merge pull request from heroiceric/mark-seteach-public | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,720 |
4ff7ae35d93620274eea53ba2365f53a8ee2fad0 | Stefan Penner | Stefan Penner | Merge pull request #11618 from HeroicEric/mark-enum-last-object-public
[DOC Release] Mark Enumerable.lastObject() as public | merge pull request from heroiceric/mark-enum-last-object-public | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 11,721 |
283f5df0adde87e5f8e3404787eebe08aa697f0b | Stefan Penner | Stefan Penner | Merge pull request #11620 from HeroicEric/mark-geteach-public
[DOC Release] Mark Enumerable.getEach() as public | merge pull request from heroiceric/mark-geteach-public | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,722 |
de0dc73cbe00f739fa6ecd037ae7255f9fbc8da2 | Stefan Penner | Stefan Penner | Merge pull request #11617 from HeroicEric/ek-mark-contains-public
[DOC Release] Mark Enumerable.contains as public | merge pull request from heroiceric/ek-mark-contains-public | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 11,723 |
e86465fe769e3063a96bd12a1f18ed639bdfbe96 | Stefan Penner | Stefan Penner | Merge pull request #11614 from HeroicEric/mark-enum-first-object-public
[DOC Release] Mark Enumerable.firstObject() as public | merge pull request from heroiceric/mark-enum-first-object-public | 65 | true | false | 5 | true | true | false | emberjs | ember.js | 11,724 |
2d0d1cd167a3d770c00b455e00e44c5b173b0f1b | Stefan Penner | Stefan Penner | Merge pull request #11613 from HeroicEric/mark-find-as-public
[DOC Release] Mark Enumerable.find as public | merge pull request from heroiceric/mark-find-as-public | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,725 |
723a82e5fdb6e4a038e87f7fef63779d594ba616 | Stefan Penner | Stefan Penner | Merge pull request #11612 from HeroicEric/mark-find-by-public
[DOC Release] Mark Enumerable.findBy as public | merge pull request from heroiceric/mark-find-by-public | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,726 |
dc0938c84d4de3cd6a2af29e3e327a7b107f15ae | Stefan Penner | Stefan Penner | Merge pull request #11667 from emberjs/stefanpenner-memory-leak
[BUGFIX release] Fix Glimmer memory leak | merge pull request from emberjs/stefanpenner-memory-leak | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 11,727 |
6c82fff186aab7ae195c63961236f43dd503a491 | Stefan Penner | Stefan Penner | switch to common browser sniffing code | switch to common browser sniffing code | 38 | false | false | 6 | false | false | false | emberjs | ember.js | 11,728 |
b587c4809715cfab72c8af90df11777f608b1ec5 | Tom Dale | Tom Dale | Merge pull request #11359 from emberjs/in-template-config
Implements RFC #60 (Component Unification) | merge pull request from emberjs/in-template-config | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 11,729 |
e7866ca9f37d2ac417f4fdb98331a99a6199ba1c | Tom Dale | Tom Dale | Implements RFC #60 (Component Unification)
https://github.com/emberjs/rfcs/pull/60
This commit implements the proposed semantics for angle-bracket
components. The TLDR is that a component’s template represents its
“outerHTML” rather than its “innerHTML”, which makes it easier to
configure the element itself using templating constructs.
Some salient points:
1. If there is a single root element, the attributes from the invocation
are copied onto the root element.
2. The invocation’s attributes “win out” over the attributes from the
root element in the component’s layout.
3. Classes are merged. If the invocation says `class=“a”` and the root
element says `class=“b”`, the result is `class=“a b”`. The rationale
is that when you say `class=“a”`, you are really saying “add the `a`
class to this element”.
A few sticky issues:
1. If the root element for the `my-foo` component is `<my-foo>`, we
insert an element with tag name of `my-foo`. While this is intuitive,
note that in all other cases, `<my-foo>` represents an invocation of
the component. In the root position, that makes no sense, since it
would inevitably produce a stack overflow.
a. This “identity element” case makes it idiomatic to reflect the
name of the component onto the DOM.
b. Unfortunately, when we compile a template, we do not yet know
what component that template is used for, and, indeed, whether it
is even a template for a component at all.
c. To capture the semantic differences, we do a bit of analysis at
compile time (to determine *candidates* for top-level elements),
and use runtime information (component invocation style and
the name of the component looked up in the container) to
disambiguate between a component’s element and an invocation of
another component.
2. If the root element for the `my-foo` component is a regular HTML
element, we use the `attachAttributes` functionality of HTMLBars to
attach the attributes that the component was invoked with onto the
root element.
3. In general, it is important that changes to attributes do not result
in a change to the identity of the element that they are contained
in. To achieve this, we reused much of the infrastructure built in
`buildComponentTemplate`.
The consequence of (1) and (2) above is that the semantics are always
“a component’s layout represents its outerHTML”, even though the
implementation is quite different depending on whether the root element
is the same-named component or not. | implements rfc #60 (component unification) | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 11,730 |
106095e50e1067ce7ccd4e13b315d0a39d211925 | Tomhuda Katzdale | Tom Dale | Clarify scope.view / scope.locals.view / env.view
In general, if you want to get access to the “nearest view”, you should
always use `env.view`.
However, some legacy semantics around controllers were a bit quirky.
In some cases, the controller was looked up dynamically from the current
view, but in other cases, the controller was expected to be provided in
another way.
Coincidentally, `scope.view` was only set when the controller was
expected to be derived dynamically from the current view. As a result,
some code was written to check for `scope.view`, and only *then*, look
up its `context` to get the current controller.
Over time, more code came to use `scope.view` when that code actually
wanted to look up the “ambient view”, regardless of whether the ambient
view provided the current controller.
Using `scope.view` in this way had a bad side effect: because it was
sometimes not present (but still used to wire up the view hierarchy in
some cases), the view hierarchy could have “holes”. This manifested
itself as views deep in the hierarchy with `ownerView` set to themselves
and `parentView` set to null.
Not surprisingly, this produced a number of pernicious bugs. The reason
that it was difficult to track this down is that the primary source of
this bug was views at the top level of an outlet. Ember users are very
unlikely to ask for the `parentView` of these views, so they would not
notice the problem.
This would be likely to manifest itself as memory leaks and multiple
root “revalidations” per run loop, rather than a single top-level
revalidation. Both of those behaviors have been observed recently.
This commit removes `scope.view` entirely, and relies on
`scope.locals.view` in the two remaining cases that legitimately needed
this information. All other `scope.view`s were incorrect and have been
changed to `env.view`.
Note that there were some historic bugs in the propagation of `env.view`
that likely caused us (and others) to use `scope.view` in places where
`env.view` would have been more appropriate. | clarify scope.view / scope.locals.view / env.view | 49 | false | false | 6 | false | true | false | emberjs | ember.js | 11,731 |
efb82e67eb8efe47cb9de10a22b0ba4c770727c1 | Stefan Penner | Stefan Penner | ensure npm run is actually always used, and — is used to pass args through | ensure npm run is actually always used, and — is used to pass args through | 74 | false | false | 15 | false | false | false | emberjs | ember.js | 11,732 |
3c6508cb43edd8ec2ab8a92665150fddb6e5a795 | Stefan Penner | Stefan Penner | update to iojs | update to iojs | 14 | false | false | 3 | false | false | false | emberjs | ember.js | 11,733 |
5c6b6278b6807b55dc4d70823c9b04e182eb3609 | Tom Dale | Tom Dale | Track parent view of cleaned up render nodes
This commit fixes a bug where views created inside an `{{#each}}` were
not getting removed appropriately from their parent’s `childViews`
array when they were destroyed.
Previously, we used a boolean flag to track whether we had removed the
destroyed view from its parent. The first time we saw a view while
walking the tree of destroyed render nodes, we should remove it from
its parent view’s `childViews` and flip the flag to true.
As we walked the tree, we assumed that any subsequent views were
descendants of the root destroyed view, and therefore could be left in
place while we waited for the GC to do its magic.
However, the case we missed was when there were two sibling views being
destroyed as part of the same root render node being cleaned up.
For example, imagine this view graph:
A
/ \
B /\
C D <— both created via an {{#each}}
If the sibling views were inside a non-view-associated render node,
and that render node was cleaned up (e.g., an {{#if}} that became
falsy), the tree of nodes would be walked. Once it reached the render
node associated with the C view, it would remove C from A’s
`childViews` and toggle the flag to true, indicating that we had seen
the view and removed it.
However, the tree walker would then get to the render node
representing the D view. Because the flag was now set to true, it
would erroneously assume D was a child of C and leave it in A’s
`childViews`.
In this commit, we change the flag to a property that tracks the
nearest view to the render node being cleaned up. As we traverse the
render node tree, if we find a node with a view, we remove that view
from it’s parent view’s `childViews` array if and only if its parent
view is the same as the render node’s nearest view. This is a more
correct version of the heuristic for determining when to remove
destroyed views from their parents’ than our previous attempt. | track parent view of cleaned up render nodes | 44 | false | false | 8 | false | true | false | emberjs | ember.js | 11,734 |
d1e1da4e758adf4ee9d8dc445dfd6e85cc694e5b | Stefan Penner | Stefan Penner | add back firefox (skip the one dubious test) | add back firefox (skip the one dubious test) | 44 | false | false | 8 | false | true | false | emberjs | ember.js | 11,735 |
c910771107d082b4609ad9ff4abfbaa9aaddd001 | Stefan Penner | Stefan Penner | * combine testem.dist.json and testem.sauce.json
* ensure local ember-cli is used via npm run sauce:launch | * combine testem.dist.json and testem.sauce.json | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 11,736 |
1af874cdf9b71314917cf5fc0d66f4430a57a3d7 | Tom Dale | Tom Dale | Rename tests | rename tests | 12 | false | false | 2 | false | true | false | emberjs | ember.js | 11,737 |
e5d8ea4d004c4a830079f5410b8910e36cb76842 | Stefan Penner | Stefan Penner | another test for #115401 | another test for 1 | 18 | false | false | 4 | false | false | false | emberjs | ember.js | 11,738 |
8574876d9ffca952102e4e2a33f31f6aa57dbe1c | Tomhuda Katzdale | Stefan Penner | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not removed from its parent’s `childViews` array.
Specifically, three hooks are invoked when a render node is cleared:
1. `env.hooks.willCleanupNode`
2. `Morph#cleanup`
3. `env.hooks.didCleanupNode`
Prior to this commit, `willCleanupNode` would blindly set the owner
view’s `isDestroyingSubtree` flag if there was a view set in the `env`
(i.e., basically always).
Sidebar on the `isDestroyingSubtree` flag: this flag is used as a
performance optimization. If a view is destroyed, we want to remove that
view from its parent’s `childViews` array so that garbage collection can
happen. However, it is unnecessary to remove child views from the
destroyed view’s `childViews` array; the GC will take care of any clean
up when the link between the view hierarchy and the destroyed view is
severed.
For example, imagine this hypothetical view hierarchy:
A
/ \
B C
/ \
D E
If the render node for view C is destroyed, we need to remove C from
A’s array of child views. However, it is unnecessary to remove D or E
from C’s child views, because they will be imminently removed by the GC,
and temporarily lingering in the child views array does no harm.
We accomplish this by setting the `isDestroyingSubtree` flag on the
root-most view in a hierarchy (view A in the example above), which we
call the owner view. When the render node for C is destroyed, it removes
C from A’s child views array and sets the flag to true. When D and E’s
render nodes are destroyed, they see that the flag has already been
flipped and do not remove their associated views from C’s child views
array.
The memory leak manifested itself when the a render node that did not
have a view associated with it was destroyed, and contained a child
render node that _did_ have a view associated. For example:
```handlebars
{{#if foo}}
{{my-component}}
{{/if}}
```
In this case, the `willCleanupNode` hook would erroneously set the flag
without actually moving the `my-component` view, because the render node
for the `{{if}}` does not know about the component.
When the cleanup for `{{my-component}}` finally happens (in
Morph#cleanup), the flag has already been set, so the render node
incorrectly assumes that its view is part of a subgraph that has already
been severed.
As far as we can tell, the `willCleanupNode` hook is not doing any
cleanup that is not already done in `Morph#cleanup`. We still do need
`didCleanupNode` to clear the flag, but can leave individual render node
cleanup to the render node itself. | eliminate redundant willcleanupnode hook | 40 | false | false | 4 | true | true | true | emberjs | ember.js | 11,739 |
0d43d24bc27db5b6267753c93868e8565f61f670 | Tomhuda Katzdale | Tom Dale | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not removed from its parent’s `childViews` array.
Specifically, three hooks are invoked when a render node is cleared:
1. `env.hooks.willCleanupNode`
2. `Morph#cleanup`
3. `env.hooks.didCleanupNode`
Prior to this commit, `willCleanupNode` would blindly set the owner
view’s `isDestroyingSubtree` flag if there was a view set in the `env`
(i.e., basically always).
Sidebar on the `isDestroyingSubtree` flag: this flag is used as a
performance optimization. If a view is destroyed, we want to remove that
view from its parent’s `childViews` array so that garbage collection can
happen. However, it is unnecessary to remove child views from the
destroyed view’s `childViews` array; the GC will take care of any clean
up when the link between the view hierarchy and the destroyed view is
severed.
For example, imagine this hypothetical view hierarchy:
A
/ \
B C
/ \
D E
If the render node for view C is destroyed, we need to remove C from
A’s array of child views. However, it is unnecessary to remove D or E
from C’s child views, because they will be imminently removed by the GC,
and temporarily lingering in the child views array does no harm.
We accomplish this by setting the `isDestroyingSubtree` flag on the
root-most view in a hierarchy (view A in the example above), which we
call the owner view. When the render node for C is destroyed, it removes
C from A’s child views array and sets the flag to true. When D and E’s
render nodes are destroyed, they see that the flag has already been
flipped and do not remove their associated views from C’s child views
array.
The memory leak manifested itself when the a render node that did not
have a view associated with it was destroyed, and contained a child
render node that _did_ have a view associated. For example:
```handlebars
{{#if foo}}
{{my-component}}
{{/if}}
```
In this case, the `willCleanupNode` hook would erroneously set the flag
without actually moving the `my-component` view, because the render node
for the `{{if}}` does not know about the component.
When the cleanup for `{{my-component}}` finally happens (in
Morph#cleanup), the flag has already been set, so the render node
incorrectly assumes that its view is part of a subgraph that has already
been severed.
As far as we can tell, the `willCleanupNode` hook is not doing any
cleanup that is not already done in `Morph#cleanup`. We still do need
`didCleanupNode` to clear the flag, but can leave individual render node
cleanup to the render node itself. | eliminate redundant willcleanupnode hook | 40 | false | false | 4 | true | true | true | emberjs | ember.js | 11,740 |
abf09ab98fe69b63363a2be657a7e3c4b13b6e74 | Stefan Penner | Stefan Penner | downgrade to tester ^0.8.0-1 so everything works | downgrade to tester ^0.8.0-1 so everything works | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 11,741 |
7290cd090d68c5b09f66bb7920014d026b616103 | Stefan Penner | Stefan Penner | Merge pull request #11662 from rwjblue/prevent-array-controller-deprecation-on-generated-controllers
[BUGFIX release] Prevent ArrayController deprecation on generated controllers. | merge pull request from rwjblue/prevent-array-controller-deprecation-on-generated-controllers | 94 | true | false | 5 | true | false | false | emberjs | ember.js | 11,742 |
15aa7246ed4b9b7a5e216af859eb390de490bfcb | Stefan Penner | Stefan Penner | Merge pull request #11664 from rwjblue/ensure-route-unit-tests-work
[BUGFIX release] Ensure Route actions can be unit tested. | merge pull request from rwjblue/ensure-route-unit-tests-work | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 11,743 |
09d41a474b9e3a85976b5e00362f6072c0b24fd6 | Stefan Penner | Stefan Penner | add readme entry | add readme entry | 16 | false | false | 3 | true | true | true | emberjs | ember.js | 11,744 |
bb243948da0c088e8b1b8df8941ce030906d14ce | Stefan Penner | Stefan Penner | tell tested to run PhantomJS in dev | tell tested to run phantomjs in dev | 35 | false | false | 7 | false | false | false | emberjs | ember.js | 11,745 |
1dcd65220251ff524651a037aa0af4c6fd715275 | Stefan Penner | Stefan Penner | Merge pull request #11661 from stefanpenner/disable-testem-watching
prevent testem from watching (ember-cli already does this) | merge pull request from stefanpenner/disable-testem-watching | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 11,746 |
ef6569570dd657e4136e502002da0457b9d2f22d | Stefan Penner | Stefan Penner | extra feedback when running ./bin/run-tests | extra feedback when running ./bin/run-tests | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 11,747 |
092b1dc10cc092961e0142a683af257e3fa0e067 | Stefan Penner | Stefan Penner | serve tests over HTTP, to work with phantomjs being confused with query-params and file:// | // | 2 | false | false | 1 | false | false | false | emberjs | ember.js | 11,748 |
b74e26a0e8dbf81a55a3b0bac0c6a1fb9164c886 | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure Route actions can be unit tested.
With ember-qunit@0.3.x the normal `router` injection for all Routes
looked up from the container was not set, so the guarding `this.router`
was enough to force us down the `else` path in `Ember.Route#send`.
ember-qunit@0.4.x fixes many bugs with the previous manual container
setup, by doing exactly what a "normal" app would do and use its
registry/container pair. This is a **huge** improvement, but
unfortunately broke the guard that previously existed (since
`this.router` was now the `Ember.Router` instance due to the
aforementioned injection rule). | [bugfix release] ensure route actions can be unit tested | 56 | false | false | 9 | false | false | false | emberjs | ember.js | 11,749 |
8892d4dd5847615fa1837200d53b89b56db89854 | Stefan Penner | Stefan Penner | update testem | update testem | 13 | false | false | 2 | true | false | false | emberjs | ember.js | 11,750 |
561a030386e2a35db05c9701de6d5ffd1d175824 | Stefan Penner | Stefan Penner | * ensure ember test && ember test —-server work
* provide a utility for connecting a phantom runner to ember test —server | * ensure ember test && ember test —-server work | 47 | false | false | 9 | false | false | false | emberjs | ember.js | 11,751 |
59c5800099b0bdda44d9ad4d31d28ec96802f10a | Robert Jackson | Robert Jackson | [BUGFIX release] Prevent ArrayController deprecation on generated controllers. | [bugfix release] prevent arraycontroller deprecation on generated controllers | 77 | false | false | 8 | false | false | false | emberjs | ember.js | 11,752 |
17d8e156b5d40e48a8eaa322ac2866c7b9bbf979 | Stefan Penner | Stefan Penner | prevent testem from watching (ember-cli already does this) | prevent testem from watching (ember-cli already does this) | 58 | false | false | 8 | false | true | false | emberjs | ember.js | 11,753 |
1b91adcebc8b36493c1029e2e39eead27ae76e30 | Stefan Penner | Stefan Penner | failing test for #11501 | failing test for | 16 | false | false | 3 | false | false | false | emberjs | ember.js | 11,754 |
1361d8a67120328da4e583367a37b4eee8ed3042 | Robert Jackson | Robert Jackson | Merge pull request #11656 from rwjblue/fix-jscs-issue
Fix JSCS quoting issue with cherry-pick from stable branch. | merge pull request from rwjblue/fix-jscs-issue | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,755 |
7875af25e880cc50c0e04ec2e7dc4a665a61790d | Robert Jackson | Robert Jackson | Fix JSCS quoting issue with cherry-pick from stable branch. | fix jscs quoting issue with cherry-pick from stable branch | 58 | false | false | 9 | false | true | false | emberjs | ember.js | 11,756 |
09d8f93f53e5878e3347ed5ec90bcb87226dd255 | Robert Jackson | Robert Jackson | Merge pull request #11655 from cibernox/fix_blockless_qp_only_links
[BUGFIX release] Fix blockless link-to with only query params | merge pull request from cibernox/fix_blockless_qp_only_links | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 11,757 |
35f8a3515940cd7e4aaade8f20fa5fa9b334a1ac | Jesse Rusak | Robert Jackson | [BUGFIX release] On re-render, ensure child views of non-dirty components get the correct parentView
On re-render of a non-dirty component, the `env` was simply passed down when
rendering the component's template, which means its parentView was wrong; this
patch mimics what keywords already do to solve this for components.
Fixes emberjs/ember.js#11554
(cherry picked from commit bc9dbcdd03305ec44f0c3167eccbc0c5d9dd3139) | [bugfix release] on re-render, ensure child views of non-dirty components get the correct parentview | 100 | false | false | 14 | false | false | false | emberjs | ember.js | 11,758 |
96e2abda928874f72a9f84feeca15616fc47fd33 | Miguel Camba | Miguel Camba | [BUGFIX release] Fix blockless link-to with only query params | [bugfix release] fix blockless link-to with only query params | 61 | false | false | 9 | false | false | false | emberjs | ember.js | 11,759 |
a9e8379031e6b0205042a0f61016808977d25663 | Stefan Penner | Stefan Penner | Merge pull request #11599 from joeruello/object-proxy
[DOC Release] Mark ObjectProxy as public | merge pull request from joeruello/object-proxy | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,760 |
3c23610d12f300244c0ce3911a23b4fa78338345 | Robert Jackson | Robert Jackson | Merge pull request #11650 from emberjs/update-htmlbars
[BUGFIX release] Update HTMLBars to 0.13.32. | merge pull request from emberjs/update-htmlbars | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 11,761 |
95a8aa7d96da350050cb77ba7efa03dddc30069f | Stefan Penner | Stefan Penner | the signature for normalizeProperty has changed. The return value is now { normalized, type }, and internally both the lower and non lower prop forms are handled | the signature for normalizeproperty has changed. the return value is now { normalized, type }, and internally both the lower and non lower prop forms are handled | 161 | false | false | 27 | false | false | false | emberjs | ember.js | 11,762 |
04163354e29d59b00d86315fbedc5e0b9d75dae0 | Stefan Penner | Stefan Penner | prefer template string | prefer template string | 22 | false | false | 3 | true | true | true | emberjs | ember.js | 11,763 |
dc2e0861b4e16796694666acb72bfd5254b8b984 | Stefan Penner | Stefan Penner | ensure RenderBuffer is shaped correctly | ensure renderbuffer is shaped correctly | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 11,764 |
97439874844a73b77afd405c935d96dec83cdf9b | Stefan Penner | Stefan Penner | ES6 allows use to export default a function statement directly | es6 allows use to export default a function statement directly | 62 | false | false | 10 | false | false | false | emberjs | ember.js | 11,765 |
01831c4a1c2f728b904ef5661efe6111c42d5a01 | Stefan Penner | Stefan Penner | more fixed whitespace | more fixed whitespace | 21 | false | false | 3 | false | false | false | emberjs | ember.js | 11,766 |
a3ae83c07d8b60eb236889702470110b27efd31d | Stefan Penner | Stefan Penner | we actually expect this to be w/e the browsers default input.maxLength is. | we actually expect this to be w/e the browsers default input.maxlength is | 73 | false | false | 12 | false | false | false | emberjs | ember.js | 11,767 |
96e69138325840232b792a2d242abb0301a48993 | Stefan Penner | Stefan Penner | fix whitespace | fix whitespace | 14 | false | false | 2 | true | true | false | emberjs | ember.js | 11,768 |
225d73abc6963cbcf787a89ac2d873af40bb8dc8 | Robert Jackson | Robert Jackson | [BUGFIX release] Update HTMLBars to 0.13.32.
Fixes a number of edgecases with property vs attributes. | [bugfix release] update htmlbars to 0.13.32 | 43 | false | false | 6 | false | false | false | emberjs | ember.js | 11,769 |
0465f5b3eff21bae7d7dd54c3cf307f4491bb98a | Kris Selden | Kris Selden | Merge pull request #11268 from mitchlloyd/chains-remove-duplicate-method
Consolidate duplicated method | merge pull request from mitchlloyd/chains-remove-duplicate-method | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 11,770 |
f789afb89396b2e6282389bc88042b10b386d4e6 | Stefan Penner | Stefan Penner | Merge pull request #11648 from duggiefresh/cleanup-remove-mapproperty
[CLEANUP beta] - Remove `mapProperty` | merge pull request from duggiefresh/cleanup-remove-mapproperty | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 11,771 |
dc8e2b9972660bf0d6986dd299859caeb3aacd17 | Doug Yun | Doug Yun | [CLEANUP beta] - Remove `mapProperty` | [cleanup beta] - remove `mapproperty` | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 11,772 |
92502ba86d2553f7042d7fe225a39e2a2c923869 | Robert Jackson | Robert Jackson | Merge pull request #11591 from xtian/patch-1
Mark Route#refresh as public | merge pull request from xtian/patch-1 | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 11,773 |
a069c4d8b0e7dda16410ff075dbd50c5ef59e8bf | Matthew Beale | Matthew Beale | Merge pull request #11646 from rwjblue/fixup-some-labels
[BUGFIX beta] Fix subexpr stream labels. | merge pull request from rwjblue/fixup-some-labels | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,774 |
780b1dfe54589ddf07cea5178b318023dda6f552 | Robert Jackson | Robert Jackson | Merge pull request #11611 from duggiefresh/cleanup-remove-filterproperty
[CLEANUP beta] - Remove `filterProperty` | merge pull request from duggiefresh/cleanup-remove-filterproperty | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 11,775 |
81a44e964a165a427fb76c14ae59b244e9253869 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix subexpr stream labels.
* The `subexpr` hook was creating a label function for each
sub-expression, but nothing in the system was doing anything with a
function.
* The `element` and `subexpr` hooks were passing the generated `label`
in the `context` slot. | [bugfix beta] fix subexpr stream labels | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 11,776 |
065947c37c6fecfd6a413833d6c5259089b2e135 | Alex Matchneer | Alex Matchneer | Merge pull request #11641 from SaladFork/patch-1
[DOC Release] Mark Ember.Route#paramsFor as public | merge pull request from saladfork/patch-1 | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 11,777 |
7bdbf4fd2cb99ebc85e944391e036fe9f6a18d86 | Robert Jackson | Robert Jackson | Merge pull request #11644 from nathanhammond/new-link-to-test
[BUGFIX beta] Guard against trying to use a non-setup router.js instance. | merge pull request from nathanhammond/new-link-to-test | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,778 |
7bb3e2120e1cd2d308767a5bacb5eea6894a5a69 | Robert Jackson | Robert Jackson | Merge pull request #11643 from rwjblue/update-emberjs-build
[BUGFIX beta] Update emberjs-build to 0.2.1. | merge pull request from rwjblue/update-emberjs-build | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,779 |
e81403e3cbe6ca0b4a7cd1a029740268aa919d3b | Nathan Hammond | Nathan Hammond | Guard against trying to use a non-setup router.js instance.
Conflicts:
packages/ember/tests/helpers/link_to_test.js | guard against trying to use a non-setup router.js instance | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 11,780 |
7b8b23a495b468e8e6c4fcf1a232c40c004ad5c3 | Robert Jackson | Robert Jackson | [BUGFIX beta] Update emberjs-build to 0.2.1.
Fixes super annoying Babel deprecation:
The transformer es6.parameters.rest has been renamed | [bugfix beta] update emberjs-build to 0.2.1 | 43 | false | false | 6 | false | false | false | emberjs | ember.js | 11,781 |
235a91d96f3ed0fafaff3ab34875f39753fca1aa | Elad Shahar | Elad Shahar | [DOC Release] Mark Ember.Route#paramsFor as public
[ci skip]
In our application we use `paramsFor` in three ways:
* for child routes to be able to access parameters of a parent route. This is often required to get data for passing to the adapter to make the appropriate data request.
* for a route to get its own params to transition to itself in an action with slightly tweaked values. We do this via `this.paramsFor(this.routeName)`
* for a route to get a parent's params to transition to itself or another route with a parent's parameter changed
Some of these can probably be implemented through other mechanisms (or should be), but `paramsFor` provides a somewhat clean way of doing so today. | [doc release] mark ember.route#paramsfor as public | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 11,782 |
a49894f4229d5c4cb6515619d2cbbe2f99e873c9 | Robert Jackson | Robert Jackson | Merge pull request #11634 from HeroicEric/mark-enum-isEvery-public
[DOC Release] Mark Enumerable.isEvery() as public | merge pull request from heroiceric/mark-enum-isevery-public | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 11,783 |
571be56b492bcde0c75c241a977bd9f9e83c39ac | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.isEvery() as public
[ci skip] | [doc release] mark enumerable.isevery() as public | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 11,784 |
5cfae2ee23ad1d7e715ae0e9066ec6c04995d6bd | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.everyBy() as public
[ci skip] | [doc release] mark enumerable.everyby() as public | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 11,785 |
c54683261491d08ce399addd468cb3a96932fb83 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.rejectBy() as public
[ci skip] | [doc release] mark enumerable.rejectby() as public | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 11,786 |
f3010c132ba82515466d20552c512d4225ae3738 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.filterBy() as public
[ci skip] | [doc release] mark enumerable.filterby() as public | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 11,787 |
76f1fe39a480b14438706120c886392cd6d6d138 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.reject() as public
[ci skip] | [doc release] mark enumerable.reject() as public | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 11,788 |
bfe35f82a9045234853dfb34cfeae64313530515 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.filter() as public
[ci skip] | [doc release] mark enumerable.filter() as public | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 11,789 |
474f497b92af2581ea4bd6ec7c9ca59ebdbddb05 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.mapBy() as public
[ci skip] | [doc release] mark enumerable.mapby() as public | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 11,790 |
cf84683ba50660f3465ce93aad52b395cc779839 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.map() as public
[ci skip] | [doc release] mark enumerable.map() as public | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 11,791 |
a001688580f80dc1e2ad5988c69cd6b877e2a71b | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.setEach() as public
[ci skip] | [doc release] mark enumerable.seteach() as public | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 11,792 |
cea3ec9f34e7c827ace0f4f76dd52e7394c6433a | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.getEach() as public
[ci skip] | [doc release] mark enumerable.geteach() as public | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 11,793 |
3378bb89f4a295575a45309d815664f9786100b9 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.lastObject() as public
[ci skip] | [doc release] mark enumerable.lastobject() as public | 52 | false | false | 6 | false | false | false | emberjs | ember.js | 11,794 |
e97bd2b37fb79b23ea51995c2a2b7397dbdf0a14 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.contains as public
[ci skip] | [doc release] mark enumerable.contains as public | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 11,795 |
7387b7aae07f152ef68759f5a137a5305f8d2be2 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.firstObject() as public
[ci skip] | [doc release] mark enumerable.firstobject() as public | 53 | false | false | 6 | false | false | false | emberjs | ember.js | 11,796 |
0fe0e309abb0dda8711258cd08f422a39675c695 | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.find as public | [doc release] mark enumerable.find as public | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 11,797 |
0248148712601c2148c8054cefdf58c91f36d36b | Eric Kelly | Eric Kelly | [DOC Release] Mark Enumerable.findBy as public | [doc release] mark enumerable.findby as public | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 11,798 |
be966d454f1e46eb95d285aafa1a979f74412d0b | Doug Yun | Doug Yun | [CLEANUP beta] - Remove `filterProperty`
Deprecated since '13. See: #3227 | [cleanup beta] - remove `filterproperty` | 40 | false | false | 5 | false | false | false | emberjs | ember.js | 11,799 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.