sha
stringlengths
40
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85k
2e890543901bc2c92be234ab3b37a7cfa5ebe7e0
Robert Jackson
Robert Jackson
Merge pull request #11608 from rwjblue/remove-linkTo-support [CLEANUP beta] Remove long deprecated {{linkTo}} helper.
merge pull request from rwjblue/remove-linkto-support
54
true
false
5
true
false
false
emberjs
ember.js
11,800
d8a67e4ce12c1292e9bb67ee0ac306e20c17f633
Robert Jackson
Robert Jackson
Merge pull request #11605 from rwjblue/each-in-inverse Test that {{each-in}} traversing from truthy to falsey works.
merge pull request from rwjblue/each-in-inverse
48
true
false
5
true
false
false
emberjs
ember.js
11,801
f3da227643836f6861ab4758d974a7ea13e59f26
Robert Jackson
Robert Jackson
[CLEANUP beta] Remove long deprecated {{linkTo}} helper. This was deprecated prior to 1.0.0. This is **NOT** removing `{{link-to}}`.
[cleanup beta] remove long deprecated {{linkto}} helper
55
false
false
7
false
false
false
emberjs
ember.js
11,802
3073bc0bbf0654579dedc5fe5cdadf478fddafb7
Miguel Camba
Robert Jackson
Test that {{each-in}} traversing from truthy to falsey works. Once {{each-in}} got rendered, set the content to an empty object doesn't renders the alternate block (cherry picked from commit 6b4b2d7988f39337e43ff9beb8c9e3c1aae3daa1)
test that {{each-in}} traversing from truthy to falsey works
60
false
false
9
false
false
false
emberjs
ember.js
11,803
4cc13844d29872d92395255a03f014abe8623c52
Edward Faulkner
Edward Faulkner
Merge pull request #11606 from ef4/fix-deprecation-test Fix tests that got broken by a spelling change
merge pull request from ef4/fix-deprecation-test
49
true
false
5
true
false
false
emberjs
ember.js
11,804
377b36b263ed2e82b6ce4d8fa9bd0bafbbf7a71a
Edward Faulkner
Edward Faulkner
Fix tests that got broken by a spelling change
fix tests that got broken by a spelling change
46
false
false
9
true
true
true
emberjs
ember.js
11,805
84909b21960e8b19a5e3d2d7f74febe227bf83af
joe
joe
[DOC Release] Mark ObjectProxy as public [ci skip]
[doc release] mark objectproxy as public
40
false
false
6
false
false
false
emberjs
ember.js
11,806
0c8910d198dca50677263a8a3fc5697afaa22978
Stefan Penner
Stefan Penner
Merge pull request #11558 from stefanpenner/only-invoke-still-present-chain-entries only invoke didChange if a node is still present.
merge pull request from stefanpenner/only-invoke-still-present-chain-entries
77
true
false
5
true
false
false
emberjs
ember.js
11,807
5adf9662e5841895f5dd701eab82f15353604727
Stefan Penner
Stefan Penner
Merge pull request #11598 from raycohen/in-favor-no-hyphen ‘in-favour’ -> ‘in favor’
merge pull request from raycohen/in-favor-no-hyphen
52
true
false
5
true
false
false
emberjs
ember.js
11,808
96647927cd5bb2fb8f452c6add7054d4b5de0d89
Ray Cohen
Ray Cohen
‘in-favour’ -> ‘in favor’
‘in-favour’ -> ‘in favor’
25
false
false
4
false
false
false
emberjs
ember.js
11,809
20b16a5bf0f991aaa22db49a72de31fa63fc91d6
Stefan Penner
Stefan Penner
[BUGFix release][Fixes #11564] ensure didChange/willChange are only invoked if the node is present.
[bugfix release][fixes ] ensure didchange/willchange are only invoked if the node is present
92
false
false
13
false
false
false
emberjs
ember.js
11,810
2c3e78f74dfd81442cc750d6054b8c5de34fc1fb
Christian Wesselhoeft
Christian Wesselhoeft
[DOC release] Mark Route#refresh as public
[doc release] mark route#refresh as public
42
false
false
6
false
false
false
emberjs
ember.js
11,811
922e2dafdcce6e35e0f7d34b239cc43a0fd8e1cd
Robert Jackson
Robert Jackson
Merge pull request #11577 from ef4/fix-11539 Fix view destruction inside outlets
merge pull request from ef4/fix-11539
38
true
false
5
true
true
false
emberjs
ember.js
11,812
8102ab29ed35aebfc71931e0d8c2e5b734033ae9
Robert Jackson
Robert Jackson
Merge pull request #11589 from joeruello/classNameBindings [DOC Release] Mark classNameBindings as public
merge pull request from joeruello/classnamebindings
52
true
false
5
true
false
false
emberjs
ember.js
11,813
1a3950c5c6b3113c82e96d441a068f07fc309472
Robert Jackson
Robert Jackson
Merge pull request #11588 from joeruello/classNames [DOC Release] Mark classNames as public
merge pull request from joeruello/classnames
45
true
false
5
false
false
false
emberjs
ember.js
11,814
bf1f72a585155459c5b208c5f6fe4162158fc307
joe
joe
[DOC Release] Mark classNameBindings as public [ci skip]
[doc release] mark classnamebindings as public
46
false
false
6
false
false
false
emberjs
ember.js
11,815
f3fd3193c74624c38e7c39868d6ded483e1516f3
joe
joe
[DOC Release] Mark classNames as public [ci skip]
[doc release] mark classnames as public
39
false
false
6
false
false
false
emberjs
ember.js
11,816
8edb866eb9354b888acd95f9bbf269c13228534d
Robert Jackson
Robert Jackson
Merge pull request #11581 from joeruello/route-deactiveate [DOC Release] Mark Route.deactivate() as public
merge pull request from joeruello/route-deactiveate
52
true
false
5
true
false
false
emberjs
ember.js
11,817
f2e3b349b9c0bed92336b621f9397d4ba3dc4b2d
Robert Jackson
Robert Jackson
Merge pull request #11584 from joeruello/redirect [DOC Release] Mark Route.redirect() as public
merge pull request from joeruello/redirect
43
true
false
5
true
false
false
emberjs
ember.js
11,818
f6293824b3a94d11a18e80210f27ee4a89d99cfa
Robert Jackson
Robert Jackson
Merge pull request #11582 from joeruello/route-activate [DOC Release] Mark Route.activate() as public
merge pull request from joeruello/route-activate
49
true
false
5
true
false
false
emberjs
ember.js
11,819
3e5cfddeeac9d9605007a0f2d8e5e76db5e35caa
Robert Jackson
Robert Jackson
Merge pull request #11579 from joeruello/transition-to-route [DOC Release] Mark Controller.transitionToRoute() as public
merge pull request from joeruello/transition-to-route
54
true
false
5
true
false
false
emberjs
ember.js
11,820
d61363cbdbffc14152fa95705557e627680f57cc
joe
joe
[DOC Release] Mark Route.renderTemplate() as public
[doc release] mark route.rendertemplate() as public
51
false
false
6
false
false
false
emberjs
ember.js
11,821
4c79a0e4c2c999827cd4b4adbb22cb8177dfbbb1
joe
joe
[DOC Release] Mark Route.redirect() as public
[doc release] mark route.redirect() as public
45
false
false
6
false
false
false
emberjs
ember.js
11,822
43bceb11852075fb421373888177d3433ff8869f
joe
joe
[DOC Release] Mark Route.replaceWith() as public
[doc release] mark route.replacewith() as public
48
false
false
6
false
false
false
emberjs
ember.js
11,823
f623e5328b3a723d18c73922a3d0928900e03830
joe
joe
[DOC Release] Mark Route.activate() as public
[doc release] mark route.activate() as public
45
false
false
6
false
false
false
emberjs
ember.js
11,824
c26ee92b69ee1a6f42a651d7802bad746b55d23d
joe
joe
[DOC Release] Mark Route.deactivate() as public
[doc release] mark route.deactivate() as public
47
false
false
6
false
false
false
emberjs
ember.js
11,825
918030e3f26659011b006bb3a0b1326c13440d46
joe
joe
[DOC Release] Mark Controller.transitionToRoute() as public
[doc release] mark controller.transitiontoroute() as public
59
false
false
6
false
false
false
emberjs
ember.js
11,826
39d6ef7df7088919fb77d166b99c2860cb80fa28
Stefan Penner
Stefan Penner
Merge pull request #11578 from steffenbrem/fix-route-modelFor-visibility [DOCS] Changed docs Ember.Route#modelFor to public
merge pull request from steffenbrem/fix-route-modelfor-visibility
66
true
false
5
true
false
false
emberjs
ember.js
11,827
88a0e98898980dda509af3b8bf2506497f58220c
Steffen Brem
Steffen Brem
[DOCS] Changed docs Ember.Route#modelFor to public Shouldn’t the `modelFor` method of `Ember.Route` be public? Since the code example is also using it in a public way.
[docs] changed docs ember.route#modelfor to public
50
false
false
6
false
false
false
emberjs
ember.js
11,828
1fc7811a45dfb6184667364067203db4e2ff45dc
Edward Faulkner
Edward Faulkner
Fix view destruction inside outlets This solution feels hacky and we need to discuss what code is really responsible for view destruction. The htmlbars code that clears the DOM does not do view destruction, which leaves us in an awkward situation where the DOM is already removed but we need to destroy the view.
fix view destruction inside outlets
35
false
false
5
true
true
true
emberjs
ember.js
11,829
78d03067055b96128c3c25ece10ff358c4764557
Edward Faulkner
Edward Faulkner
Added failing test for #11539
added failing test for
22
false
false
4
false
false
false
emberjs
ember.js
11,830
76359b76581bac20375dcecac73f95817a99fbd0
Stefan Penner
Stefan Penner
Merge pull request #11575 from ef4/fix-unused Remove unused import to fix jshint
merge pull request from ef4/fix-unused
39
true
false
5
true
false
false
emberjs
ember.js
11,831
7ffe8f70ee2b8a5c46e61c8e257e4157d141cc09
Edward Faulkner
Edward Faulkner
Remove unused import to fix jshint This error sneaked into the repo due to #11574.
remove unused import to fix jshint
34
false
false
6
true
true
true
emberjs
ember.js
11,832
165cd58fab9c82b4b107e0f1e1906598c026d673
Robert Jackson
Robert Jackson
Merge pull request #11535 from jmurphyau/nested-sticky-qp [BUGFIX release] Sticky query params for nested and for dynamic routes
merge pull request from jmurphyau/nested-sticky-qp
51
true
false
5
true
false
false
emberjs
ember.js
11,833
8a762df9f4474ed9c0e19ca9a5c1478fc59448d3
Robert Jackson
Robert Jackson
Merge pull request #11560 from joeruello/master [DOC Release] Mark transitionTo as public
merge pull request from joeruello/master
41
true
false
5
true
false
false
emberjs
ember.js
11,834
2b6e4b688b6dc4f27b1be49285a1a821a28ab594
Robert Jackson
Robert Jackson
Merge pull request #11570 from emberjs/11519-block-param-infinite-loop [BUGFIX release] Don’t force invalidation of block param streams
merge pull request from emberjs/11519-block-param-infinite-loop
64
true
false
5
true
false
false
emberjs
ember.js
11,835
2e505cd6785c2b51d937e674f2e6dffde3da89eb
Robert Jackson
Robert Jackson
Merge pull request #11572 from rwjblue/ensure-local-state-can-shadow-attrs [BUGFIX release] Ensure local state can shadow attrs.
merge pull request from rwjblue/ensure-local-state-can-shadow-attrs
68
true
false
5
true
false
false
emberjs
ember.js
11,836
9e7cc9c17eb09b0f2b81993cbedb93e2bc79192f
Robert Jackson
Robert Jackson
[BUGFIX release] Ensure local state can shadow attrs. We initially intended to deprecate access to local state (ala proxying to attrs) at this location, but we have decided to hold off on that deprecation until angle bracked component invocation is available. Later in the integration efforts, we added an AttrsProxy to handle most of this functionality for us (when using a View inheritor). In the future, the deprecation will almost certainly be added in the `AttrsProxy` (not `getRoot` hook). --- Prior to this change local state could never use the same name as a value in `attrs` (because the `attrs` always "won"). The else case is still present, when a given template is not backed by a view/component instance.
[bugfix release] ensure local state can shadow attrs
52
false
false
8
false
false
false
emberjs
ember.js
11,837
2579522a9e137af2e9fceda4aee5855042e9328d
Tom Dale
Tom Dale
[BUGFIX release] Don’t force invalidation of block param streams This commit removes the forced invalidation of block param streams on re-renders. Previously, on re-renders, all block param streams were revalidated by calling `notify()` on them blindly. While this often works, it creates a vector for light scopes to inadvertently invalidate their associated shadow scopes. In some cases, this leads to an infinite loop. For example, imagine a component with the following template: ```handlebars {{! app/templates/components/block-with-yield.hbs }} {{yield danger}} ``` (Here `danger` is a property on the component.) Now we invoke it: ```handlebars {{#block-with-yield as |dangerBlockParam|}} {{dangerBlockParam}} {{/block-with-yield}} ``` This works. The yielded block (light scope) receives a stream for the `danger` value. On re-renders, the stream is invalidated, but all that happens is the `{{dangerBlockParam}}` render node is dirtied again (which doesn’t matter, because we haven’t rendered and cleaned it yet). However, imagine we change the component template to now display the same `{{danger}}` value: ```handlebars {{! app/templates/components/block-with-yield.hbs }} {{danger}} {{yield danger}} ``` Now, when the block param stream is invalidated, it goes back and dirties the render node _from the parent shadow scope_. Because the component is dirtied, its `{{yield}}` helper is dirtied, causing the block param streams to be dirtied, and so on in an infinite loop. This commit removes the forced invalidation, which I believe is unnecessary and probably left over from an earlier implementation. Specifically, if we are yielded a stream (`{{yield danger}}`), the stream should notify us of any changes to the value. Any downstream consumers of that stream will be notified correctly. In the case of `{{yield “hello”}}` or some other primitive, we already wrap those values in a `ProxyStream` and call `setSource` when it changes, which has the effect of invalidating the stream anyway. Closes #11519
[bugfix release] don’t force invalidation of block param streams
64
false
false
9
false
false
false
emberjs
ember.js
11,838
248335def4d8b9f2df062543a8234d92809f7699
Joe Ruello
Joe Ruello
[DOC release] Mark transitionTo as public
[doc release] mark transitionto as public
41
false
false
6
false
false
false
emberjs
ember.js
11,839
dc479cef91c1b9815157612c2a2f9483a2a04edc
Robert Jackson
Robert Jackson
Merge pull request #11561 from juggy/query-params-links [BUGFIX release] Rerender link on routing state change.
merge pull request from juggy/query-params-links
49
true
false
5
true
false
false
emberjs
ember.js
11,840
47ec66225a6c2a01aca8d38a2b4fa2a334da32b6
Robert Jackson
Robert Jackson
Merge pull request #11513 from stefanpenner/remove-rc-dc Move away from ArrayComputed/ReduceComputed
merge pull request from stefanpenner/remove-rc-dc
50
true
false
5
true
false
false
emberjs
ember.js
11,841
9c919caee8c63f37504bcf21f06ecb4ccba9e536
Robert Jackson
Robert Jackson
Merge pull request #11547 from stefanpenner/revert-ios-6.0.x-double-finally-on-error Revert "Fixes: Safari's 'double finally on error bug'"
merge pull request from stefanpenner/revert-ios-6.0.x-double-finally-on-error
78
true
false
5
true
true
false
emberjs
ember.js
11,842
e189688d40c738ce3ccbdde39f336d50e6909432
Julien Guimont
Julien Guimont
Rerender link on routing state change. Test link-to with only query params provided
rerender link on routing state change
37
false
false
6
true
true
true
emberjs
ember.js
11,843
9c52115bf3a2f20bf560dfe8b7b5d26aa1e8372c
Stefan Penner
Stefan Penner
only invoke didChange if a node is still present.
only invoke didchange if a node is still present
48
false
false
9
false
false
false
emberjs
ember.js
11,844
0dc1a6c73258d891fe54014754c33772310d7b48
Stefan Penner
Stefan Penner
[BUGFIX beta] [fixes #11181, #10343, #9739, #9462, #4919, #4231, #3706, #5596, #9485, #9492, #5319, #5268, #4831, #5558] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency. For more complex scenarios, custom solutions should be used. @wagenet & @stefanpenner
[bugfix beta] [fixes , , , , , , , , , , , , , ] move away from ac/rc instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency
172
false
false
36
false
false
false
emberjs
ember.js
11,845
ea004a5105a0864958d26308807021c94ae807a3
James Murphy
James Murphy
[BUGFIX release] Sticky query params for nested and for dynamic routes. Fixed query params not being sticky for nested routes Fixed query params not working for multiple routes that each have a dynamic segment Previous only 1 dynamic segment was working correctly
[bugfix release] sticky query params for nested and for dynamic routes
70
false
false
11
false
false
false
emberjs
ember.js
11,846
7847cc48290f00344c73dd87029613bbd6985b7e
Stefan Penner
Stefan Penner
Revert "Fixes: Safari's 'double finally on error bug'" This reverts commit 917da11e1814d88106b5c62022486c716a94afaf. iOS 6 makes up less the 4% of the iOS market, and this bug appears to be fixed in iOS 6.1. As such the potentially affected devices is quite small. Finally, the bug only comes into play in very specific failure scenarios which are nearly all already handled in backburner.
safari's 'double finally on error bug'"
39
false
false
6
false
false
false
emberjs
ember.js
11,847
6130fa62ba1c52788593367f3456a882025a673e
Robert Jackson
Robert Jackson
Merge pull request #11545 from jherdman/remove-bind-attr-in-component-docs [DOC release] Remove `{{bind-attr}}` in Component Docs
merge pull request from jherdman/remove-bind-attr-in-component-docs
68
true
false
5
true
false
false
emberjs
ember.js
11,848
dfd9d82c0e5acad090bf90f55e2238038a84f491
James Herdman
James Herdman
[DOC release] Remove `{{bind-attr}}` in Component Docs
[doc release] remove `{{bind-attr}}` in component docs
54
false
false
7
false
false
false
emberjs
ember.js
11,849
2a64be6d98d8ddf77a84570de55b6abeba7c7806
Stefan Penner
Stefan Penner
Merge pull request #11536 from stefanpenner/chains-cleanup [Bugfix beta] cleanup Chains
merge pull request from stefanpenner/chains-cleanup
52
true
false
5
true
false
false
emberjs
ember.js
11,850
7d9932e2d1425881d795f22160c77ba7f308e642
Stefan Penner
Stefan Penner
[Bugfix beta] cleanup Chains * ensure ChainNode stays shaped correctly (_chains, _object, count) * ensure _chains are descendants of Null Prototyped object * remove now needed hasOwnProperty * take advantage of existing branching to prevent unneeded work * release chain values, but don’t delete.
[bugfix beta] cleanup chains
28
false
false
4
false
false
false
emberjs
ember.js
11,851
49d58530527c9025b4bafe4f937b0c78cfe3818e
Robert Jackson
Robert Jackson
Merge pull request #11517 from jayphelps/deprecate-router-map-resource [BUGFIX beta] deprecate this.resource() in Router.map()
merge pull request from jayphelps/deprecate-router-map-resource
64
true
false
5
true
false
false
emberjs
ember.js
11,852
b6d70b08263c209fed857fec932d6875367c6cdd
Jay Phelps
Jay Phelps
[BUGFIX beta] Add additional documentation on resetNamespace and other options for this.route()
[bugfix beta] add additional documentation on resetnamespace and other options for this.route()
95
false
false
12
false
false
false
emberjs
ember.js
11,853
af98f598ee1d1ec063854f575c3fa58cce099c23
Robert Jackson
Robert Jackson
Merge pull request #11511 from stefanpenner/deprecate-ember-create-keys Deprecate ember create keys
merge pull request from stefanpenner/deprecate-ember-create-keys
65
true
false
5
true
false
false
emberjs
ember.js
11,854
1ed73ac3d1c218b9a3b56640543fd13d0913d27e
Stefan Penner
Robert Jackson
[BUGFIX release] Deprecate Ember.keys.
[bugfix release] deprecate ember.keys
37
false
false
4
false
false
false
emberjs
ember.js
11,855
501d4739f82845065a856bbd0d6b91ee8e3a67d6
Stefan Penner
Robert Jackson
[BUGFIX release] Deprecate Ember.create.
[bugfix release] deprecate ember.create
39
false
false
4
false
false
false
emberjs
ember.js
11,856
20fbf210fb3b8918a30b37828aec2bfdcd45bfa3
Robert Jackson
Robert Jackson
Merge pull request #11528 from stefanpenner/pr-11521 [BUGFIX beta] Complain if you use the wrong map macro
merge pull request from stefanpenner/pr-11521
46
true
false
5
true
true
false
emberjs
ember.js
11,857
ec9ba95dc244771ae54df01b275ef8cce1ef0a77
Ben Holmes
Stefan Penner
[BUGFIX beta] Complain if you use the wrong map macro
[bugfix beta] complain if you use the wrong map macro
53
false
false
10
false
false
false
emberjs
ember.js
11,858
8ee36cb2402ae3757caca84ad532a667af6e6b9d
Robert Jackson
Robert Jackson
Merge pull request #11525 from rwjblue/add-helpful-error-for-duplicate-keys [BUGFIX release] Add helpful error for {{each}} with duplicate keys.
merge pull request from rwjblue/add-helpful-error-for-duplicate-keys
69
true
false
5
true
false
false
emberjs
ember.js
11,859
f896a896832d43f0fc979fa481a0ce805b6cbfc7
Robert Jackson
Robert Jackson
Merge pull request #11522 from emberjs/fix-link-to-regression [BUGFIX beta] {{link-to}} before application boot
merge pull request from emberjs/fix-link-to-regression
55
true
false
5
true
false
false
emberjs
ember.js
11,860
c9dbecb70c828e3b65c60fcaadb449bc438b2c0f
Tom Dale
Tom Dale
[BUGFIX beta] {{link-to}} before application boot Previously, {{link-to}} would work even if the application had not been booted completely. This behavior is relied on by test harnesses like ember-qunit, since an “integration test” of a component may include a template that uses {{link-to}}. Many people have discovered that they would like to test a component that has a link without booting the entire app. > You wanted a banana but what you got was a gorilla holding the banana > and the entire jungle. –Joe Armstrong During the Glimmer work, we refactored the interface between the LinkComponent and the router into a service. Unfortunately, this caused a regression where rendering the link before the router was completely initialized would raise an exception. This commit adds a very stupid guard to ensure that we have enough router state to determine if a link is active or not. This whole path could be significantly cleaned up, and in particular, we should move towards using a stubbed routing service in tests that encapsulates all of these concerns.
[bugfix beta] {{link-to}} before application boot
49
false
false
6
false
false
false
emberjs
ember.js
11,861
319cbf599af1968299117d309f3464b3f093fbb3
Robert Jackson
Robert Jackson
Merge pull request #11526 from duggiefresh/11518-contributing-add-cleanup [DOC] - Adds `CLEANUP` tag to CONTRIBUTING.md
merge pull request from duggiefresh/11518-contributing-add-cleanup
67
true
false
5
true
false
false
emberjs
ember.js
11,862
c018c74d60f664e3290ea11b4e17f246609f4b5d
Doug Yun
Doug Yun
[DOC] - Adds `CLEANUP` tag to CONTRIBUTING.md * For more information, see: https://github.com/emberjs/ember.js/pull/11439 * Fixes #11518
[doc] - adds `cleanup` tag to contributing.md
45
false
false
7
false
false
false
emberjs
ember.js
11,863
150708b911760befb11d1d633d9078424b9359f8
Robert Jackson
Robert Jackson
Merge pull request #11523 from jmurphyau/route-qp-failing-test Query Params on Route Bug/Fix
merge pull request from jmurphyau/route-qp-failing-test
56
true
false
5
true
false
false
emberjs
ember.js
11,864
d5fd95a3a5440228601f367721f09a7695867d3e
James Murphy
James Murphy
[BUGFIX beta] Query Params on Route Bug/Fix
[bugfix beta] query params on route bug/fix
43
false
false
7
false
false
false
emberjs
ember.js
11,865
0401f9baf9c56e948d107dc21f36ddab927bd94d
Robert Jackson
Robert Jackson
Add link to community guidelines as CODE_OF_CONDUCT.md.
add link to community guidelines as code_of_conduct.md
54
false
false
7
true
true
false
emberjs
ember.js
11,866
baee94a5e02340f5a2d0b28ed839470109a29b33
Robert Jackson
Robert Jackson
[BUGFIX release] Add helpful error for {{each}} with duplicate keys.
[bugfix release] add helpful error for {{each}} with duplicate keys
67
false
false
10
false
false
false
emberjs
ember.js
11,867
78c22ee744e8cd082d5ba95ea491ee9824c5b1dd
Jay Phelps
Jay Phelps
[BUGFIX beta] deprecate this.resource() in Router.map(), use this.route('name', { resetNamespace: true }) instead
true }) instead
15
false
false
3
false
false
false
emberjs
ember.js
11,868
0df7bebb5615567c795703d91aaf7cbcafa79ec9
Stefan Penner
Stefan Penner
Merge pull request #11466 from stefanpenner/fix-should-display [Bugfix beta] ensure isTruthy is only attempted if the predicate is a…
merge pull request from stefanpenner/fix-should-display
56
true
false
5
true
false
false
emberjs
ember.js
11,869
d8b1bb1b300e5616bdf328244c806578e1110d85
Robert Jackson
Robert Jackson
Merge pull request #11512 from stefanpenner/pr-10669-rebase [Bugfix release] Deprecate Ember.oneWay
merge pull request from stefanpenner/pr-10669-rebase
53
true
false
5
true
false
false
emberjs
ember.js
11,870
bc7ec8d49961e961a076e63b3a97437b11ea84c4
Robert Jackson
Robert Jackson
Merge pull request #11510 from stefanpenner/deprecate-create-with-mixins [Bugfix Release] deprecate createWithMixins
merge pull request from stefanpenner/deprecate-create-with-mixins
66
true
false
5
true
false
false
emberjs
ember.js
11,871
e56650d7e2011d5b3f8c85336640e5aea1e22357
Peter Wagenet
Stefan Penner
[Bugfix release] Deprecate Ember.oneWay
[bugfix release] deprecate ember.oneway
39
false
false
4
false
false
false
emberjs
ember.js
11,872
c54d8870e76e265a0a3552fb0c264bc9a6f2400a
Stefan Penner
Stefan Penner
[Bugfix Release] deprecate createWithMixins * it’s private * easily replaced with extend(…).create(…) * embers own tests should likely not rely on these private APIs
[bugfix release] deprecate createwithmixins
43
false
false
4
false
false
false
emberjs
ember.js
11,873
4b74503eae1264e3bb22766bfa87c760f4c1399a
Robert Jackson
Robert Jackson
Merge pull request #11496 from emberjs/fast-boot-unescaped-mustaches Support {{{unescapedContent}}} in FastBoot
merge pull request from emberjs/fast-boot-unescaped-mustaches
62
true
false
5
true
false
false
emberjs
ember.js
11,874
116763689532ae3fb0e1a63b6d88f06f9907659b
Stefan Penner
Stefan Penner
[Bugfix beta] ensure istruthy is only consulted for objects * add tests
[bugfix beta] ensure istruthy is only consulted for objects
59
false
false
9
false
false
false
emberjs
ember.js
11,875
41be946f26b1c232c183a9e42de74d2142042e5a
Stefan Penner
Stefan Penner
Merge pull request #11463 from stefanpenner/is-array-cleanup [CLEANUP Beta] isArray Prefer Array.isArray for ember-metal variant, …
merge pull request from stefanpenner/is-array-cleanup
54
true
false
5
true
false
false
emberjs
ember.js
11,876
a90b7b3a525ac78998a94340651588e95705b059
Robert Jackson
Robert Jackson
Merge pull request #11507 from jayphelps/patch-9 Missing apostrophe `doesnt`
merge pull request from jayphelps/patch-9
42
true
false
5
true
false
false
emberjs
ember.js
11,877
dd9dd6114b2555b9b613c9310c0a751cced588b9
Stefan Penner
Stefan Penner
[CLEANUP Beta] isArray Prefer Array.isArray for ember-metal variant, but not runtime variant (╯°□°)╯︵ ʎɐɹɹɐsı¬
[cleanup beta] isarray prefer array.isarray for ember-metal variant, but not runtime variant
92
false
false
12
false
false
false
emberjs
ember.js
11,878
5bcfd7aa1e35264e955878a0f1ebe386b55648d0
Jay Phelps
Jay Phelps
Missing apostrophe `doesnt`
missing apostrophe `doesnt`
27
false
false
3
false
false
false
emberjs
ember.js
11,879
9bf5428ce242dfe869dbfd7d4d18244195a63744
Stefan Penner
Stefan Penner
Merge pull request #11459 from stefanpenner/remove-object-keys [CLEANUP Beta] Remove EmberKeys (internally) continue to expose Ember…
merge pull request from stefanpenner/remove-object-keys
56
true
false
5
true
false
false
emberjs
ember.js
11,880
3f8df7a49ad4cd0aa966248763d369bac242543e
Stefan Penner
Stefan Penner
[CLEANUP Beta] Drop Object.create playful – just use Object.create [ES5-only] (╯°□°)╯︵ ʃıɟʎʃod ǝʇɐǝɹɔ ʇɔǝɾqo
[cleanup beta] drop object.create playful – just use object.create [es5-only]
77
false
false
10
false
false
false
emberjs
ember.js
11,881
be3caa413b830baa01dd3e4cf4e481e1145d79e4
Stefan Penner
Stefan Penner
[CLEANUP Beta] Remove EmberKeys (internally) continue to expose Ember.keys but as 1:1 with Object.keys [ES5-only] (╯°□°)╯︵ sʎǝʞ¬
1 with object.keys [es5-only]
29
false
false
4
false
false
false
emberjs
ember.js
11,882
e2355a6c7a4a1f64f50b8e00d8df326f9660c605
Robert Jackson
Robert Jackson
Merge pull request #11498 from mmun/remove-ember-predef Ensure Ember is imported correctly everywhere
merge pull request from mmun/remove-ember-predef
49
true
false
5
true
false
false
emberjs
ember.js
11,883
09ddfa74c454d799c1a99543128bb7cedaf0f72b
Martin Muñoz
Martin Muñoz
Ensure Ember is imported correctly everywhere
ensure ember is imported correctly everywhere
45
false
false
6
false
false
false
emberjs
ember.js
11,884
dfbf122627fff16aa1d2932686f423b0f3b30597
Tom Dale
Tom Dale
Support {{{unescapedContent}}} in FastBoot The interesting work is all in SimpleDOM, but this commit bumps the HTMLBars and SimpleDOM dependencies and includes a test to verify that escaped content works when rendered in Node.
support {{{unescapedcontent}}} in fastboot
42
false
false
4
false
true
false
emberjs
ember.js
11,885
3254874cc6a05148969282f3c6ae9d5eaa0297f9
Robert Jackson
Robert Jackson
Merge pull request #11495 from rwjblue/strip-debug-statements [BUGFIX release] Properly strip debug statements in prod builds.
merge pull request from rwjblue/strip-debug-statements
55
true
false
5
true
false
false
emberjs
ember.js
11,886
ee406a039bbc1b36b4c0d0410589934b522bca50
Robert Jackson
Robert Jackson
[BUGFIX release] Properly strip debug statements in prod builds. In https://github.com/emberjs/ember.js/pull/11367 we swapped to using babel for module transpilation, which lead to the transpiled output being slightly different than previously with esperanto. The long term solution is to use a babel transform to strip, this will have the benefit of not having this particular issue any longer (this is actually the second time we have had this issue). https://github.com/ember-cli/babel-plugin-filter-imports has been created specifically for this purpose, and we have a roadmap to implementing soonish. --- This adds the new formats to the list of debug statements for defeatureify.
[bugfix release] properly strip debug statements in prod builds
63
false
false
9
false
false
false
emberjs
ember.js
11,887
680f997ed0958c420abdcd0b1673111aee26afe7
Robert Jackson
Robert Jackson
Merge pull request #11142 from jayphelps/single-quotes-plz-k-thnx Use single quotes in ember core and enforce it
merge pull request from jayphelps/single-quotes-plz-k-thnx
59
true
false
5
true
false
false
emberjs
ember.js
11,888
6e9c3f061dc6abf5c4e322d419e33e8b2dc88d66
Jay Phelps
Jay Phelps
Use single quotes in ember and enforce it
use single quotes in ember and enforce it
41
false
false
8
true
true
true
emberjs
ember.js
11,889
6d6d9a854fc107a29cf62898d5b52d0550663949
Robert Jackson
Robert Jackson
Merge pull request #11461 from rwjblue/use-default-key [BUGFIX release] Default {{each}} key to @guid or @item based on type.
merge pull request from rwjblue/use-default-key
48
true
false
5
true
false
false
emberjs
ember.js
11,890
01a710336085930a030cbddccf73a3c0918b2cb0
Robert Jackson
Robert Jackson
[BUGFIX release] Default {{each}} key to @guid or @item based on type.
[bugfix release] default {{each}} key to @guid or @item based on type
69
false
false
12
false
false
false
emberjs
ember.js
11,891
3278e0d7286dd17df324cd197c750ff478681ea6
Robert Jackson
Robert Jackson
Merge pull request #11478 from thejameskyle/tjk/deprecate-render-buffer Deprecate RenderBuffer
merge pull request from thejameskyle/tjk/deprecate-render-buffer
65
true
false
5
true
false
false
emberjs
ember.js
11,892
f3b2cf221b7b1108eb93aeafe205aa68a9c73ef4
Robert Jackson
Robert Jackson
Merge pull request #11476 from thejameskyle/tjk/deprecate-array-controller Deprecate ArrayController
merge pull request from thejameskyle/tjk/deprecate-array-controller
68
true
false
5
true
false
false
emberjs
ember.js
11,893
c858bc33316ff381117cb9277b4b26b3529f4daf
James Kyle
James Kyle
Deprecate RenderBuffer. Resolves #11431
deprecate renderbuffer. resolves
32
false
false
3
false
true
false
emberjs
ember.js
11,894
af7cd981d5de40956ff19f104bbbe14eff11adb2
James Kyle
James Kyle
Deprecate ArrayController. Resolves #11450
deprecate arraycontroller. resolves
35
false
false
3
false
true
false
emberjs
ember.js
11,895
1d170a2b64bf66e917ee7222760bc6f37cbd16cb
Robert Jackson
Robert Jackson
Merge pull request #11474 from satchmorun/docs-for-remove-set-chaining [DOC beta] Remove out-of-date docs
merge pull request from satchmorun/docs-for-remove-set-chaining
64
true
false
5
true
false
false
emberjs
ember.js
11,896
4f92d0fa048b2a6cfa4ebc68ad996f5feedccb72
Stefan Penner
Stefan Penner
Merge pull request #11460 from stefanpenner/remove-object-create-polyfil [CLEANUP Beta] Drop Object.create polyfill – just use Object.create [E…
merge pull request from stefanpenner/remove-object-create-polyfil
66
true
false
5
true
false
false
emberjs
ember.js
11,897
94f5c3c1d3953fa4d9c4364ea256d28a1ad3d534
Arun Srinivasan
Arun Srinivasan
Fixup the `setProperties` docs as well.
fixup the `setproperties` docs as well
38
false
false
6
false
true
false
emberjs
ember.js
11,898
43d13b5b8e4c66c2a4d747caaee0919fafd1a76c
Stefan Penner
Stefan Penner
Merge pull request #11470 from marcioj/define-property Fix Object.defineProperty
merge pull request from marcioj/define-property
48
true
false
5
true
false
false
emberjs
ember.js
11,899