mamiksik/analysed-diff-metadata · Datasets at Hugging Face

sha stringlengths 40 40	author stringlengths 1 63	committer stringlengths 1 41	message stringlengths 1 65.5k	subject stringlengths 1 5.64k	subject_length float64 1 5.64k	is_chore bool 2 classes	is_bot bool 2 classes	subject_word_count float64 1 806	verb_object_spacy bool 2 classes	verb_object_stanza bool 2 classes	fits_requirements bool 2 classes	owner stringlengths 2 15	repo stringlengths 2 21	__index_level_0__ int64 0 85k
32d625b9ca0860bb29bb0bf425e9549449f814ad	Mitch Lloyd	Mitch Lloyd	Destroy ember views in destroy-render-node hook The way `clearRender` works, it won’t call destroy on the top level view if given `destroySelf` flag set to false. By moving the `view.destroy` call into this hook, we can avoid destroying the top level view when it is being cleared by `clearRender`. The `view.lastResult` check seemed to just happen to work and needed to be changed to get more tests passing.	destroy ember views in destroy-render-node hook	47	false	false	6	true	true	true	emberjs	ember.js	12,500
1f24be60b34e508df81012275916bf9698faba72	Mitch Lloyd	Mitch Lloyd	Cancel scheduled view#append on view#remove If a view is in a ‘preRender’ state (or any state for that matter) attempting to destroy the element will effectively make any pending view#append operations a noop.	cancel scheduled view#append on view#remove	43	false	false	5	false	true	false	emberjs	ember.js	12,501
54ed612c6b214861e480308b4201c1deab04e09e	Mitch Lloyd	Mitch Lloyd	Get more tests with view#remove working	get more tests with view#remove working	39	false	false	6	true	true	true	emberjs	ember.js	12,502
8eea2e63091b6de57ec6bd461fe3db3cc74e360d	Robert Jackson	Robert Jackson	Merge pull request #10920 from stefanpenner/settable-layout-cp [Bugfix beta] Settable layout cp	merge pull request from stefanpenner/settable-layout-cp	56	true	false	5	true	false	false	emberjs	ember.js	12,503
a6ed5187c90a8b20be0a1f6918188146c296f76c	Robert Jackson	Robert Jackson	Merge pull request #10929 from stefanpenner/view-states-cleanup some cleanup as I read.	merge pull request from stefanpenner/view-states-cleanup	57	true	false	5	true	false	false	emberjs	ember.js	12,504
c6b9f7fa86e219d50053126a4724bff0d5d51659	Stefan Penner	Stefan Penner	some cleanup as I read.	some cleanup as i read	22	false	false	5	false	false	false	emberjs	ember.js	12,505
30989b85ec5dda5610701bfac77d8cd08d5a9546	Stefan Penner	Stefan Penner	[Bugfix beta] ensure scheduleOnce has a stable function + context The run-loop once methods, detect uniqueness based on function identity. If we pass an anonymous function each time its identity constantly changes. ```js Ember.run.scheduleOnce(queue, function() { }); // will invoke the callback once per schedule function stableCallback() { } Ember.run.scheduleOnce(queue, stableCallback); // will invoke the callback once per run-loop, regardless of schedules ``` Not only does this mean that the `once` requirement is not actually respected – in theory allowing repeated re-renders – but we incur the penalty of ensuring once-ness, which isn’t always costly but in this case can be. ```js // does a linear search across all queued functions to check uniqueness // this can be a large search space // implementation: https://github.com/ebryn/backburner.js/blob/7b14e2e3ea9b8e1b7329c0b61f652a888d6e49bd/lib/backburner/queue.js#L26-L41 Ember.run.scheduleOne(queueName, fn); // does a linear search across queued functions only for this emberObject to check uniqueness // this is typically a very small search space // implementation: https://github.com/ebryn/backburner.js/blob/7b14e2e3ea9b8e1b7329c0b61f652a888d6e49bd/lib/backburner/queue.js#L63-L80 Ember.run.scheduleOne(queueName, emberObject, fn); ``` Unfortunately, this won’t make a drastic improvement for all apps, but if an app did hit this scenario it will make a difference	[bugfix beta] ensure scheduleonce has a stable function + context	65	false	false	10	false	false	false	emberjs	ember.js	12,506
5f0d067ffd5b79de78a968a1a34e166b0b1838eb	Stefan Penner	Stefan Penner	[Bugfix beta] Component.prototype.layout is now settable. Previously setting `layout` would replace the underlying CP. This would prevent `layoutName` from working when a component had an existing template.	[bugfix beta] component.prototype.layout is now settable	56	false	false	6	false	false	false	emberjs	ember.js	12,507
a8400e6c018dca08d67a41add72d4798d13f475f	Stefan Penner	Stefan Penner	Merge pull request #10919 from stefanpenner/cleanup some cleanup	merge pull request from stefanpenner/cleanup	45	true	false	5	true	true	false	emberjs	ember.js	12,508
1404ce4fe9eabe1a21d0ed718e3c075bb14e2c93	Robert Jackson	Robert Jackson	Update assertions to show NullLiteral type works properly.	update assertions to show nullliteral type works properly	57	false	false	8	true	true	false	emberjs	ember.js	12,509
ad2933d8dd2f5bbdba31c6273c1ba85202e828f3	Robert Jackson	Robert Jackson	Merge pull request #10883 from mitchlloyd/replace-in Fix replace in	merge pull request from mitchlloyd/replace-in	46	true	false	5	true	false	false	emberjs	ember.js	12,510
37be98e22bcb968b8990c7cedaca4123fd505eb7	Robert Jackson	Robert Jackson	Update emberjs-build to use esperanto for HTMLBars packages.	update emberjs-build to use esperanto for htmlbars packages	59	false	false	8	true	true	false	emberjs	ember.js	12,511
9b1ac59a15f4e6664efb223737fe9ff418e26205	Robert Jackson	Robert Jackson	Update HTMLBars.	update htmlbars	15	false	false	2	false	false	false	emberjs	ember.js	12,512
aaa9377a9dc38a1d22fce6fe809a43c32b831fe0	Stefan Penner	Stefan Penner	Merge pull request #10891 from jbrown/patch-6 [DOC beta] Remove prototype extensions example.	merge pull request from jbrown/patch-6	39	true	false	5	true	false	false	emberjs	ember.js	12,513
60c93c4c874bfcc3e7729734ca49f21742c7fd4d	Stefan Penner	Stefan Penner	some cleanup * computed(dk, fn) over computed(fn).property * concise literals for those cp	some cleanup	12	false	false	2	false	false	false	emberjs	ember.js	12,514
371afb3e473f99653f06865e69f71c0ba05eea44	Martin Muñoz	Martin Muñoz	Split up render_test.js - Rename render_test.js to view_test.js. - Move conatiner view related tests to container_view_test.js. - Remove invalid tests that are overly specific about rerender behaviour. There are much more comprehensive tests in view_lifecycle_test.js.	split up render_test.js	23	false	false	3	false	false	false	emberjs	ember.js	12,515
05ee7112c5f68181e234c18bdd2c6105df996291	Martin Muñoz	Martin Muñoz	Remove MetamorphView, salvage useful metamorph view tests	remove metamorphview, salvage useful metamorph view tests	57	false	false	7	false	true	false	emberjs	ember.js	12,516
41648d7e5a0dae380147a574569d9579288008ea	Martin Muñoz	Martin Muñoz	Reimplement willInsertElement	reimplement willinsertelement	29	false	false	2	true	false	false	emberjs	ember.js	12,517
f11e02afce4056734ec7ebb994a8860200cb384c	Martin Muñoz	Martin Muñoz	Use template instead of render buffer	use template instead of render buffer	37	false	false	6	true	true	true	emberjs	ember.js	12,518
8230c84bd04828a8063f09ff8525765b5ad71930	Stefan Penner	Stefan Penner	Merge pull request #10915 from martypenner/promise-proxy-docs-fix [DOC release] Fix tiny grammar mistakes in Ember.PromiseProxy docs	merge pull request from martypenner/promise-proxy-docs-fix	59	true	false	5	true	false	false	emberjs	ember.js	12,519
6a14a9814e383b8a10d80ac1c8877b6c3048ed53	Marty Penner	Marty Penner	[DOC release] Fix tiny grammar mistakes in Ember.PromiseProxy docs	[doc release] fix tiny grammar mistakes in ember.promiseproxy docs	66	false	false	9	false	false	false	emberjs	ember.js	12,520
fe9f1fcb55fdea4295ab0447a3bf5d7ac714c6ce	Robert Jackson	Robert Jackson	Merge pull request #10912 from stefanpenner/node-fixes Node fixes (misc)	merge pull request from stefanpenner/node-fixes	48	true	false	5	true	false	false	emberjs	ember.js	12,521
463dd44eaf164dc72b830afdbac74b360fc3707f	Stefan Penner	Stefan Penner	__deprecatedInstance__ is not available when autoboot is disabled, during app.visit As it is deprecated, I do not feel the new API app.visit must support it.	__deprecatedinstance__ is not available when autoboot is disabled, during app.visit	83	false	false	10	false	false	false	emberjs	ember.js	12,522
ae8d81711eebd954bf0a5bf951c4b8042e18d6a9	Stefan Penner	Stefan Penner	call super in willDestroy (its a framework hook)	call super in willdestroy (its a framework hook)	48	false	false	8	false	false	false	emberjs	ember.js	12,523
2ebd3ccdcfa51040371a64510dd6903cb06a051a	Stefan Penner	Stefan Penner	don’t use global ok	don’t use global ok	19	false	false	4	false	false	false	emberjs	ember.js	12,524
baa6cf7ab408f259f7699bb23cb9956a009b2857	Stefan Penner	Stefan Penner	app is now shared stated (for future cleanup)	app is now shared stated (for future cleanup)	45	false	false	8	false	false	false	emberjs	ember.js	12,525
1d55056cd4a0966aa577d1fa355e11627a62f462	Stefan Penner	Stefan Penner	prefer promises to semaphores * test now correctly fail, not just hang	prefer promises to semaphores	29	false	false	4	true	true	true	emberjs	ember.js	12,526
447e8c6cbfe698d74fb221efc6520df2c0c649a8	Stefan Penner	Stefan Penner	consistently use `run`	consistently use `run`	22	false	false	3	false	false	false	emberjs	ember.js	12,527
b8cfe3026474ab03625e735c013485676108be83	Stefan Penner	Stefan Penner	make jshint happy	make jshint happy	17	false	false	3	false	true	false	emberjs	ember.js	12,528
e1d528a5b498c17e0f0bcef215d0cae06148a6f5	Robert Jackson	Robert Jackson	Merge pull request #10905 from rwjblue/merge-features [BUGFIX beta] Allow feature flags to be merged.	merge pull request from rwjblue/merge-features	47	true	false	5	true	false	false	emberjs	ember.js	12,529
9d7ec1a38e1b3999dae678a7897f4cb51dda5841	Martin Muñoz	Martin Muñoz	Modernize child_views_test Use templates instead of render method	modernize child_views_test	26	false	false	2	true	true	false	emberjs	ember.js	12,530
195a6d0de0e56cdc39da2bcc87e8b395302db786	Robert Jackson	Robert Jackson	Bump emberjs-build to ensure default features are available to runtime tree.	bump emberjs-build to ensure default features are available to runtime tree	75	true	false	11	true	false	false	emberjs	ember.js	12,531
23682a4b38fbc520a54145d7bc689f73203ac1e4	Stefan Penner	Stefan Penner	Update registry.js	update registry.js	18	false	false	2	false	false	false	emberjs	ember.js	12,532
d8138d344d9d0579c98272771a240c378a13705a	Stefan Penner	Stefan Penner	Update container.js	update container.js	19	false	false	2	true	false	false	emberjs	ember.js	12,533
c72b91e757fe576dea40d14e6fc0ccccca9022bf	Robert Jackson	Robert Jackson	[BUGFIX beta] Allow feature flags to be merged. Previously, having `EmberENV.FEATURES` specified as an empty object (the default for ember-cli), meant that development builds of Ember would not have ANY feature flags (even those that are supposed to be always enabled). This changes that, by starting with the default features listing and only changing those that are specified.	[bugfix beta] allow feature flags to be merged	46	false	false	8	false	false	false	emberjs	ember.js	12,534
7e489a6c756b0b312ac7dc8f3a5874381fb350d8	Edward Faulkner	Edward Faulkner	refactor test to avoid buffer.push & appendChild	refactor test to avoid buffer.push & appendchild	48	false	false	7	false	false	false	emberjs	ember.js	12,535
9ced6d9bbd5faf0c94140fb4afe5f0dc1ff1171f	Edward Faulkner	Edward Faulkner	this was already passing, not sure when forceskipped didn't find it sooner	this was already passing, not sure when forceskipped didn't find it sooner	74	false	false	12	false	false	false	emberjs	ember.js	12,536
b325125a1f54c2e4a6e034da5ebfb55b15c8db2f	Edward Faulkner	Edward Faulkner	fix action targeting when there is no view	fix action targeting when there is no view	42	false	false	8	true	true	true	emberjs	ember.js	12,537
5c5585dc7673adc8bab3181e5967c53b170c9c52	Edward Faulkner	Edward Faulkner	topmost outlet must ensure its child has a DOM element This keeps us consistent with the DOM structure we produced pre-glimmer. The topmost out ensures that it's child (not itself) always has a real View with an element.	topmost outlet must ensure its child has a dom element	54	false	false	10	false	false	false	emberjs	ember.js	12,538
fda788458e8d40454c343a3ccf34f05e7a98bf69	Edward Faulkner	Edward Faulkner	drop dead code this argument was used by the pre-glimmer OutletView only	drop dead code	14	false	false	3	true	true	true	emberjs	ember.js	12,539
bbc901d90dc1aca1f926579deecbcca05b930214	Edward Faulkner	Edward Faulkner	fix tests that don't cleanup Application instances	fix tests that don't cleanup application instances	50	false	false	7	true	true	true	emberjs	ember.js	12,540
03b420b1ea2d6e26dd6617c272e0ba1a08ea7e98	Matthew Beale	Matthew Beale	Can presume the view.parentView is not virtual	can presume the view.parentview is not virtual	46	false	false	7	false	false	false	emberjs	ember.js	12,541
09752c480ed1e1c87e37706462a6e6ced5d895aa	Matthew Beale	Matthew Beale	Throw when appending and already appended view	throw when appending and already appended view	46	false	false	7	false	false	false	emberjs	ember.js	12,542
2d3b012d5f0d4f63649a930facdaaf82876a337a	Matthew Beale	Matthew Beale	Clean up some lifecycle tests	clean up some lifecycle tests	29	false	false	5	false	false	false	emberjs	ember.js	12,543
011b876be624f6bebfebef92c026edca0045d6d2	Matthew Beale	Matthew Beale	Make createElement work without view entering inDOM state createElement requires that a view be rendered without the lifecycle hooks being rendered. This leaves it in the hasElement state instead of moving to inDOM as a normal render would.	make createelement work without view entering indom state	57	false	false	8	true	true	false	emberjs	ember.js	12,544
06aab7c7f986540a5446cc903d6303ade58d5129	Martin Muñoz	Martin Muñoz	Reimplement hasBlock and hasBlockParams	reimplement hasblock and hasblockparams	39	false	false	4	true	true	true	emberjs	ember.js	12,545
8a92672d2c1660a051a03a0645df483c6514e1c5	Martin Muñoz	Martin Muñoz	Rewrite some tests to use templates instead of a buffer	rewrite some tests to use templates instead of a buffer	55	false	false	10	true	true	false	emberjs	ember.js	12,546
9d923a687c77b06b7808203d6aea6afb20546676	Robert Jackson	Robert Jackson	Add missing -legacy-each registration for deprecated tests.	add missing -legacy-each registration for deprecated tests	58	false	false	7	true	true	false	emberjs	ember.js	12,547
f892dc8390f40ba84e825e946dea131afbaa01c1	Mitch Lloyd	Robert Jackson	Use templates to test View.nearestTypeOf.	use templates to test view.nearesttypeof	40	false	false	5	true	true	true	emberjs	ember.js	12,548
44b219c31bab9ec5b8559945f899c3132e7c0b71	Robert Jackson	Robert Jackson	Merge pull request #10903 from mixonic/idempotent-rerender-no-virtual Completely remove the concept of isVirtual	merge pull request from mixonic/idempotent-rerender-no-virtual	63	true	false	5	true	false	false	emberjs	ember.js	12,549
6368254d0dc4ee6c11a71f04f17086ae67b5e089	Matthew Beale	Robert Jackson	Completely remove the concept of isVirtual MetamorphView (and the Metamorph mixin) are the final bastion of virtual views. This commit removes much of their use. MetamorphView had two behaviors: First, it was tagless. Second, it was not included in the view hierarchy. The first concept (taglessness) is still valid in Ember post-Glimmer. For this, we use `tagName: ''`. The second concept (virtual views) is not longer present. So views which previously used MetamorphView will not longer be able to escape the view hierarchy. In most cases, the intent was likely to be tagless and being virtual was simply a side effect. OutletView and EachView will now be present in childViews and will be parentViews. `{{render` used to always create a view. Now, it will only create a view if one is set by the user. By default it is only a componentNode and has no view at all. The final spot MetamorphViews are used it for the default itemView and emptyView on EachView. This should be easy to address in a manner similar to {{render: If the user does not specify a view, none should be required. After this, MetamorphView will no longer be used by internals.	completely remove the concept of isvirtual	42	false	false	6	false	false	false	emberjs	ember.js	12,550
e60116d4da6ab380e8a65a63032b1ae0ace21f56	Robert Jackson	Robert Jackson	Merge pull request #10893 from sandstrom/patch-3 [DOC] Minor doc fix for expanded properties	merge pull request from sandstrom/patch-3	42	true	false	5	true	false	false	emberjs	ember.js	12,551
0985123f9390b16042cd73300d5b9fc94515a7a8	sandstrom	sandstrom	Minor documentation fix Fix minor typo in inline documentation.	minor documentation fix	23	false	false	3	false	false	false	emberjs	ember.js	12,552
f34d66901205b8088821c14e1c78a77a6edd0a82	Justin Brown	Justin Brown	Remove prototype extensions example.	remove prototype extensions example	35	false	false	4	true	false	true	emberjs	ember.js	12,553
d9965f6417032ed4645f2d01af487536739ed646	Mitch Lloyd	Mitch Lloyd	[BUGFIX beta] Fix replace in Resolves #10881	[bugfix beta] fix replace in	28	false	false	5	false	false	false	emberjs	ember.js	12,554
ffedc10ea3c11ff17040175b28d3bbe3bfda24a3	Robert Jackson	Robert Jackson	Fix invalid assertion.	fix invalid assertion	21	false	false	3	true	true	true	emberjs	ember.js	12,555
5a4667b4afc4bea61b617a839fec61ccf2071a40	Robert Jackson	Robert Jackson	[SECURITY CVE-2015-1866] Escape Ember.Select option label contents. (cherry picked from commit 29703251a3d36ff972753985aa23f4e6bf2cf24e) (cherry picked from commit 3368489926d95cc0c9960e31c7ca904b9b092300)	[security cve-2015-1866] escape ember.select option label contents	66	false	false	7	false	false	false	emberjs	ember.js	12,556
3707d7ac9d3727792bf3208317bcb6c882fa191c	Nathan Hammond	Nathan Hammond	Make the component helper able to deal with falsey values.	make the component helper able to deal with falsey values	57	false	false	10	false	true	false	emberjs	ember.js	12,557
41542c6f2aec89378f312009e0e7d642a3c848f1	Robert Jackson	Robert Jackson	Merge pull request #10874 from MajorBreakfast/patch-1 [BUGFIX beta] Include all files in jspm package	merge pull request from majorbreakfast/patch-1	47	true	false	5	true	false	false	emberjs	ember.js	12,558
dec934b4295a902237b9af6cffcf05535ff7432d	Josef Brandl	Josef Brandl	[BUGFIX beta] Include all files in jspm package	[bugfix beta] include all files in jspm package	47	false	false	8	false	false	false	emberjs	ember.js	12,559
a21045d7c8fda68f4c4ca669ef38401e95dfe803	Robert Jackson	Robert Jackson	Merge pull request #10873 from usmantahirr/master ember-template-engine added to main tag in Bower.json for wiredep errors.	merge pull request from usmantahirr/master	43	true	false	5	true	false	false	emberjs	ember.js	12,560
bed7dd38cbccc7274b56d4c460a726fe861d8332	Usman Tahir	Usman Tahir	Added Ember Template Engine to Bower, WireDep plugin don't include this component if its not in main hence templates won't compile. For templates compilation its required or it throws an error "Uncaught Error: Cannot call compile without the template compiler loaded. Please load ember-template-compiler.js prior to calling compile"	added ember template engine to bower, wiredep plugin don't include this component if its not in main hence templates won't compile	130	false	false	21	false	false	false	emberjs	ember.js	12,561
e697ef3f4308ee6b525e7b6f3eca4a14c6f23b34	Yehuda Katz	Yehuda Katz	Handle legacy View scope better	handle legacy view scope better	31	false	false	5	false	false	false	emberjs	ember.js	12,562
e2ea5f0ba59974a67c0fd32b7e9d444676e90db3	Tom Dale	Tom Dale	WIP on {{each itemController}}	wip on {{each itemcontroller}}	30	false	false	4	false	false	false	emberjs	ember.js	12,563
7ce75ed106001a7eb75b874ba0760f25becc72b5	Tom Dale	Tom Dale	Implement legacy {{each}} features	implement legacy {{each}} features	34	false	false	4	false	true	false	emberjs	ember.js	12,564
7d342b6682b95692d2d93e7a8a787dc3d6a1d655	Robert Jackson	Robert Jackson	Remove unused AttrNode.	remove unused attrnode	22	false	false	3	true	true	true	emberjs	ember.js	12,565
14d15f4b0f8f3f26411ac138b98dbbd0c595fc65	Martin Muñoz	Martin Muñoz	Remove ember-metal-views tests These tests were removed because they were only testing a stub renderer defined in the tests.	remove ember-metal-views tests	30	false	false	3	false	false	false	emberjs	ember.js	12,566
f73264d685fda7e9b9d9d17bc7d39f9477ed225c	Martin Muñoz	Martin Muñoz	Fix a test using an undefined context Context-changing helpers no longer allow an undefined context. Instead, null is substituted for the context.	fix a test using an undefined context	37	false	false	7	true	true	true	emberjs	ember.js	12,567
03c17104605c4c366091ac75b5199d2104b5a31d	Robert Jackson	Robert Jackson	Correct assertion messages in tests.	correct assertion messages in tests	35	false	false	5	false	false	false	emberjs	ember.js	12,568
701f11f25d429995a8ca92384795b6f89d9fd9de	Robert Jackson	Robert Jackson	Implement custom element hook to allow deprecating legacy unbound helpers.	implement custom element hook to allow deprecating legacy unbound helpers	73	false	false	10	false	true	false	emberjs	ember.js	12,569
d8a8679553dd310ce60155170128e9f843d0fd1c	Tom Dale	Tom Dale	For backwards-compat, make attrs available at init	for backwards-compat, make attrs available at init	50	false	false	7	false	false	false	emberjs	ember.js	12,570
62df0e5b98a7a14f3e38fe46208cbcb4c481afb2	Tom Dale	Tom Dale	Munge attrs before creating ComponentNode	munge attrs before creating componentnode	41	false	false	5	false	true	false	emberjs	ember.js	12,571
55dd117d60781468c5cade525406545f3300c9c8	Robert Jackson	Robert Jackson	Add Ember specific AttrMorphClass to provide style warning.	add ember specific attrmorphclass to provide style warning	58	false	false	8	false	true	false	emberjs	ember.js	12,572
7324b93d0a3a61d7295363ca6833edd1a137a871	Robert Jackson	Robert Jackson	Merge pull request #10888 from mitchlloyd/is-visible-fixes isVisible fixes	merge pull request from mitchlloyd/is-visible-fixes	52	true	false	5	true	false	false	emberjs	ember.js	12,573
c0561486baf574ffdcb07daa2159d88d5695abd2	Martin Muñoz	Martin Muñoz	Remove invalid test	remove invalid test	19	false	false	3	true	true	true	emberjs	ember.js	12,574
8cde4d388a5f2298ac5b130ee531ed46d6c19da6	Edward Faulkner	Edward Faulkner	provide deprecation warning if we fall back to template	provide deprecation warning if we fall back to template	55	false	false	9	true	true	false	emberjs	ember.js	12,575
85ff4278f0c8f252cd35a1a9ef967aadc01412fc	Edward Faulkner	Edward Faulkner	fix use of template & layout together	fix use of template & layout together	37	false	false	7	true	true	true	emberjs	ember.js	12,576
86bdbc6450403bee31f29a794b515cb3e7b0ea93	Edward Faulkner	Edward Faulkner	rely on stable childEnvs to for outletState	rely on stable childenvs to for outletstate	43	false	false	7	false	false	false	emberjs	ember.js	12,577
a180c80f9b444d58600ff09a24cb6b97e1355275	Edward Faulkner	Edward Faulkner	dropping dead code this is all old implementation of pre-glimmer outlet behavior	dropping dead code	18	false	false	3	false	false	false	emberjs	ember.js	12,578
c7f67e8806354e36497f68ec5644405c4d2b5e1f	Martin Muñoz	Martin Muñoz	Fix inverse block in compat helpers	fix inverse block in compat helpers	35	false	false	6	true	true	true	emberjs	ember.js	12,579
db465aefdbe4472dc90bfdd481b7cdedd1095bda	Mitch Lloyd	Mitch Lloyd	Add fix for overwriting style attribute bindings	add fix for overwriting style attribute bindings	48	false	false	7	true	true	true	emberjs	ember.js	12,580
6deadbe303feccc2ccf6ce7451fada49b18b60d5	Mitch Lloyd	Mitch Lloyd	Get isVisible with container tests passing	get isvisible with container tests passing	42	false	false	6	false	false	false	emberjs	ember.js	12,581
9ce28453fb77ecf092ff237e1490f37114d7e66a	Edward Faulkner	Edward Faulkner	dropping dead code: outlets don't use the rerender hook	outlets don't use the rerender hook	35	false	false	6	false	false	false	emberjs	ember.js	12,582
188d00cc3db6dc4c711d0d72833773462fd7528f	Mitch Lloyd	Mitch Lloyd	Fix isVisible on first render	fix isvisible on first render	29	false	false	5	false	false	false	emberjs	ember.js	12,583
d2a9f029d1f6d55fdd1268a90a1199c65f542a13	Robert Jackson	Robert Jackson	Fix a couple Ember.Select tests.	fix a couple ember.select tests	31	false	false	5	false	false	false	emberjs	ember.js	12,584
6ff39999d17ab457264b007765fbdb79dc1582e0	Robert Jackson	Robert Jackson	Update link-render-node to handle missing params. The `{{component}}` keyword specifies `null` as `params` (since a component cannot receive ordered arguments). This commit simply adds a guard to ensure we do not attempt to access `params.length` when `params` is `null`.	update link-render-node to handle missing params	48	false	false	6	false	false	false	emberjs	ember.js	12,585
c43cb492c073b079a6a69fc71a2c1e42ff837d83	Robert Jackson	Robert Jackson	Enable tests that are now passing.	enable tests that are now passing	33	false	false	6	true	true	true	emberjs	ember.js	12,586
55ece9fdc400c02ef4b001570ff29cbb9ac2a912	Robert Jackson	Robert Jackson	Merge pull request #10886 from mitchlloyd/html-class-spacing Fix class spacing for classNameBindings	merge pull request from mitchlloyd/html-class-spacing	54	true	false	5	true	false	false	emberjs	ember.js	12,587
9c334449e3b220f36f9e9d0b45ad89d86607ba99	Mitch Lloyd	Mitch Lloyd	Wrap `set` in run loop	wrap `set` in run loop	22	false	false	5	false	true	false	emberjs	ember.js	12,588
b07d55cf49a80b1edac5bc4b98a8dd42fc0b7970	Mitch Lloyd	Mitch Lloyd	Fix spacing between omitted class names	fix spacing between omitted class names	39	false	false	6	false	true	false	emberjs	ember.js	12,589
9efd004ca7e7bd76e4451ebffaa31093c5c78557	Robert Jackson	Robert Jackson	Update HTMLBars to 0.13.1. Updates HTMLBars to ensure that initially undefined/null `attributeBindings` are not set on the views element.	update htmlbars to 0.13.1	25	false	false	4	true	true	true	emberjs	ember.js	12,590
2823dd95c4847797a865fe04065604881e57b68b	Tom Dale	Tom Dale	Implement collection’s itemClass	implement collection’s itemclass	32	false	false	3	false	false	false	emberjs	ember.js	12,591
8e56b7fd6a30852b4b2b992ba2bfe6a1da2176a1	Tom Dale	Tom Dale	ContainerView should inherit from View While it was a noble effort, the attempt to have ContainerView subclass Component did not work because it broke propagation of the `controller` template keyword.	containerview should inherit from view	38	false	false	5	false	false	false	emberjs	ember.js	12,592
47ddf42b2c10324d9e8d35397db8195c9108a465	Tom Dale	Tom Dale	Unify legacy class binding into AST preprocessor There are several paths and microsyntaxes for creating class name bindings for a component’s element via Handlebars. For example: `{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}` With HTMLbars, these have been deprecated in favor of a single API: `{{view class=“hello foo (if isApp ‘is-an-app’)”}}` This commit rewrites the AST of templates that contain the old syntax into the new syntax at template compile time.	unify legacy class binding into ast preprocessor	48	false	false	7	true	true	true	emberjs	ember.js	12,593
6153cd8b2f93a90f2862de7ce7aabad978c146a7	Tom Dale	Tom Dale	Add note on Checkbox inheriting from Component	add note on checkbox inheriting from component	46	false	false	7	true	true	true	emberjs	ember.js	12,594
c692bd0464f393cb334fb8110e2c3c297df42931	Robert Jackson	Robert Jackson	Fix current node tests.	fix current node tests	22	false	false	4	true	true	true	emberjs	ember.js	12,595
8728fd15dd50678b219ad0f80f2f19c03a2b005b	Martin Muñoz	Edward Faulkner	Fix last textarea test	fix last textarea test	22	false	false	4	false	true	false	emberjs	ember.js	12,596
0c8c5737eeab40a2f6948de3880dbac39bd6e52e	Tom Dale	Edward Faulkner	Set component props to attrs if defined	set component props to attrs if defined	39	false	false	7	false	true	false	emberjs	ember.js	12,597
764a138247c72783738e2c5a11dbbbebf8d91387	Tom Dale	Edward Faulkner	Get Ember.Select tests passing	get ember.select tests passing	30	false	false	4	false	true	false	emberjs	ember.js	12,598
66acf7fcbcb721ffb332dd48d3cad2b305ab327b	Tom Dale	Edward Faulkner	Update Ember.Select to use HTMLbars templates	update ember.select to use htmlbars templates	45	false	false	6	true	true	true	emberjs	ember.js	12,599

32d625b9ca0860bb29bb0bf425e9549449f814ad

Mitch Lloyd

Destroy ember views in destroy-render-node hook The way `clearRender` works, it won’t call destroy on the top level view if given `destroySelf` flag set to false. By moving the `view.destroy` call into this hook, we can avoid destroying the top level view when it is being cleared by `clearRender`. The `view.lastResult` check seemed to just happen to work and needed to be changed to get more tests passing.

destroy ember views in destroy-render-node hook

47

false

6

true

emberjs

ember.js

12,500

1f24be60b34e508df81012275916bf9698faba72

Mitch Lloyd

Cancel scheduled view#append on view#remove If a view is in a ‘preRender’ state (or any state for that matter) attempting to destroy the element will effectively make any pending view#append operations a noop.

cancel scheduled view#append on view#remove

43

false

5

false

true

false

emberjs

ember.js

12,501

54ed612c6b214861e480308b4201c1deab04e09e

Mitch Lloyd

Get more tests with view#remove working

get more tests with view#remove working

39

false

6

true

emberjs

ember.js

12,502

8eea2e63091b6de57ec6bd461fe3db3cc74e360d

Robert Jackson

Merge pull request #10920 from stefanpenner/settable-layout-cp [Bugfix beta] Settable layout cp

merge pull request from stefanpenner/settable-layout-cp

56

true

false

5

true

false

emberjs

ember.js

12,503

a6ed5187c90a8b20be0a1f6918188146c296f76c

Robert Jackson

Merge pull request #10929 from stefanpenner/view-states-cleanup some cleanup as I read.

merge pull request from stefanpenner/view-states-cleanup

57

true

false

5

true

false

emberjs

ember.js

12,504

c6b9f7fa86e219d50053126a4724bff0d5d51659

Stefan Penner

some cleanup as I read.

some cleanup as i read

22

false

5

false

emberjs

ember.js

12,505

30989b85ec5dda5610701bfac77d8cd08d5a9546

Stefan Penner

[Bugfix beta] ensure scheduleOnce has a stable function + context The run-loop *once* methods, detect uniqueness based on function identity. If we pass an anonymous function each time its identity constantly changes. ```js Ember.run.scheduleOnce(queue, function() { }); // will invoke the callback once per schedule function stableCallback() { } Ember.run.scheduleOnce(queue, stableCallback); // will invoke the callback once per run-loop, regardless of schedules ``` Not only does this mean that the `once` requirement is not actually respected – in theory allowing repeated re-renders – but we incur the penalty of ensuring once-ness, which isn’t always costly but in this case can be. ```js // does a linear search across all queued functions to check uniqueness // this can be a large search space // implementation: https://github.com/ebryn/backburner.js/blob/7b14e2e3ea9b8e1b7329c0b61f652a888d6e49bd/lib/backburner/queue.js#L26-L41 Ember.run.scheduleOne(queueName, fn); // does a linear search across queued functions only for this emberObject to check uniqueness // this is typically a very small search space // implementation: https://github.com/ebryn/backburner.js/blob/7b14e2e3ea9b8e1b7329c0b61f652a888d6e49bd/lib/backburner/queue.js#L63-L80 Ember.run.scheduleOne(queueName, emberObject, fn); ``` Unfortunately, this won’t make a drastic improvement for all apps, but if an app did hit this scenario it will make a difference

[bugfix beta] ensure scheduleonce has a stable function + context

65

false

10

false

emberjs

ember.js

12,506

5f0d067ffd5b79de78a968a1a34e166b0b1838eb

Stefan Penner

[Bugfix beta] Component.prototype.layout is now settable. Previously setting `layout` would replace the underlying CP. This would prevent `layoutName` from working when a component had an existing template.

[bugfix beta] component.prototype.layout is now settable

56

false

6

false

emberjs

ember.js

12,507

a8400e6c018dca08d67a41add72d4798d13f475f

Stefan Penner

Merge pull request #10919 from stefanpenner/cleanup some cleanup

merge pull request from stefanpenner/cleanup

45

true

false

5

true

false

emberjs

ember.js

12,508

1404ce4fe9eabe1a21d0ed718e3c075bb14e2c93

Robert Jackson

Update assertions to show NullLiteral type works properly.

update assertions to show nullliteral type works properly

57

false

8

true

false

emberjs

ember.js

12,509

ad2933d8dd2f5bbdba31c6273c1ba85202e828f3

Robert Jackson

Merge pull request #10883 from mitchlloyd/replace-in Fix replace in

merge pull request from mitchlloyd/replace-in

46

true

false

5

true

false

emberjs

ember.js

12,510

37be98e22bcb968b8990c7cedaca4123fd505eb7

Robert Jackson

Update emberjs-build to use esperanto for HTMLBars packages.

update emberjs-build to use esperanto for htmlbars packages

59

false

8

true

false

emberjs

ember.js

12,511

9b1ac59a15f4e6664efb223737fe9ff418e26205

Robert Jackson

Update HTMLBars.

update htmlbars

15

false

2

false

emberjs

ember.js

12,512

aaa9377a9dc38a1d22fce6fe809a43c32b831fe0

Stefan Penner

Merge pull request #10891 from jbrown/patch-6 [DOC beta] Remove prototype extensions example.

merge pull request from jbrown/patch-6

39

true

false

5

true

false

emberjs

ember.js

12,513

60c93c4c874bfcc3e7729734ca49f21742c7fd4d

Stefan Penner

some cleanup * computed(dk, fn) over computed(fn).property * concise literals for those cp

some cleanup

12

false

2

false

emberjs

ember.js

12,514

371afb3e473f99653f06865e69f71c0ba05eea44

Martin Muñoz

Split up render_test.js - Rename render_test.js to view_test.js. - Move conatiner view related tests to container_view_test.js. - Remove invalid tests that are overly specific about rerender behaviour. There are much more comprehensive tests in view_lifecycle_test.js.

split up render_test.js

23

false

3

false

emberjs

ember.js

12,515

05ee7112c5f68181e234c18bdd2c6105df996291

Martin Muñoz

Remove MetamorphView, salvage useful metamorph view tests

remove metamorphview, salvage useful metamorph view tests

57

false

7

false

true

false

emberjs

ember.js

12,516

41648d7e5a0dae380147a574569d9579288008ea

Martin Muñoz

Reimplement willInsertElement

reimplement willinsertelement

29

false

2

true

false

emberjs

ember.js

12,517

f11e02afce4056734ec7ebb994a8860200cb384c

Martin Muñoz

Use template instead of render buffer

use template instead of render buffer

37

false

6

true

emberjs

ember.js

12,518

8230c84bd04828a8063f09ff8525765b5ad71930

Stefan Penner

Merge pull request #10915 from martypenner/promise-proxy-docs-fix [DOC release] Fix tiny grammar mistakes in Ember.PromiseProxy docs

merge pull request from martypenner/promise-proxy-docs-fix

59

true

false

5

true

false

emberjs

ember.js

12,519

6a14a9814e383b8a10d80ac1c8877b6c3048ed53

Marty Penner

[DOC release] Fix tiny grammar mistakes in Ember.PromiseProxy docs

[doc release] fix tiny grammar mistakes in ember.promiseproxy docs

66

false

9

false

emberjs

ember.js

12,520

fe9f1fcb55fdea4295ab0447a3bf5d7ac714c6ce

Robert Jackson

Merge pull request #10912 from stefanpenner/node-fixes Node fixes (misc)

merge pull request from stefanpenner/node-fixes

48

true

false

5

true

false

emberjs

ember.js

12,521

463dd44eaf164dc72b830afdbac74b360fc3707f

Stefan Penner

__deprecatedInstance__ is not available when autoboot is disabled, during app.visit As it is deprecated, I do not feel the new API app.visit must support it.

__deprecatedinstance__ is not available when autoboot is disabled, during app.visit

83

false

10

false

emberjs

ember.js

12,522

ae8d81711eebd954bf0a5bf951c4b8042e18d6a9

Stefan Penner

call super in willDestroy (its a framework hook)

call super in willdestroy (its a framework hook)

48

false

8

false

emberjs

ember.js

12,523

2ebd3ccdcfa51040371a64510dd6903cb06a051a

Stefan Penner

don’t use global ok

19

false

4

false

emberjs

ember.js

12,524

baa6cf7ab408f259f7699bb23cb9956a009b2857

Stefan Penner

app is now shared stated (for future cleanup)

45

false

8

false

emberjs

ember.js

12,525

1d55056cd4a0966aa577d1fa355e11627a62f462

Stefan Penner

prefer promises to semaphores * test now correctly fail, not just hang

prefer promises to semaphores

29

false

4

true

emberjs

ember.js

12,526

447e8c6cbfe698d74fb221efc6520df2c0c649a8

Stefan Penner

consistently use `run`

22

false

3

false

emberjs

ember.js

12,527

b8cfe3026474ab03625e735c013485676108be83

Stefan Penner

make jshint happy

17

false

3

false

true

false

emberjs

ember.js

12,528

e1d528a5b498c17e0f0bcef215d0cae06148a6f5

Robert Jackson

Merge pull request #10905 from rwjblue/merge-features [BUGFIX beta] Allow feature flags to be merged.

merge pull request from rwjblue/merge-features

47

true

false

5

true

false

emberjs

ember.js

12,529

9d7ec1a38e1b3999dae678a7897f4cb51dda5841

Martin Muñoz

Modernize child_views_test Use templates instead of render method

modernize child_views_test

26

false

2

true

false

emberjs

ember.js

12,530

195a6d0de0e56cdc39da2bcc87e8b395302db786

Robert Jackson

Bump emberjs-build to ensure default features are available to runtime tree.

bump emberjs-build to ensure default features are available to runtime tree

75

true

false

11

true

false

emberjs

ember.js

12,531

23682a4b38fbc520a54145d7bc689f73203ac1e4

Stefan Penner

Update registry.js

update registry.js

18

false

2

false

emberjs

ember.js

12,532

d8138d344d9d0579c98272771a240c378a13705a

Stefan Penner

Update container.js

update container.js

19

false

2

true

false

emberjs

ember.js

12,533

c72b91e757fe576dea40d14e6fc0ccccca9022bf

Robert Jackson

[BUGFIX beta] Allow feature flags to be merged. Previously, having `EmberENV.FEATURES` specified as an empty object (the default for ember-cli), meant that development builds of Ember would not have ANY feature flags (even those that are supposed to be always enabled). This changes that, by starting with the default features listing and only changing those that are specified.

[bugfix beta] allow feature flags to be merged

46

false

8

false

emberjs

ember.js

12,534

7e489a6c756b0b312ac7dc8f3a5874381fb350d8

Edward Faulkner

refactor test to avoid buffer.push & appendChild

refactor test to avoid buffer.push & appendchild

48

false

7

false

emberjs

ember.js

12,535

9ced6d9bbd5faf0c94140fb4afe5f0dc1ff1171f

Edward Faulkner

this was already passing, not sure when forceskipped didn't find it sooner

74

false

12

false

emberjs

ember.js

12,536

b325125a1f54c2e4a6e034da5ebfb55b15c8db2f

Edward Faulkner

fix action targeting when there is no view

42

false

8

true

emberjs

ember.js

12,537

5c5585dc7673adc8bab3181e5967c53b170c9c52

Edward Faulkner

topmost outlet must ensure its child has a DOM element This keeps us consistent with the DOM structure we produced pre-glimmer. The topmost out ensures that it's child (not itself) always has a real View with an element.

topmost outlet must ensure its child has a dom element

54

false

10

false

emberjs

ember.js

12,538

fda788458e8d40454c343a3ccf34f05e7a98bf69

Edward Faulkner

drop dead code this argument was used by the pre-glimmer OutletView only

drop dead code

14

false

3

true

emberjs

ember.js

12,539

bbc901d90dc1aca1f926579deecbcca05b930214

Edward Faulkner

fix tests that don't cleanup Application instances

fix tests that don't cleanup application instances

50

false

7

true

emberjs

ember.js

12,540

03b420b1ea2d6e26dd6617c272e0ba1a08ea7e98

Matthew Beale

Can presume the view.parentView is not virtual

can presume the view.parentview is not virtual

46

false

7

false

emberjs

ember.js

12,541

09752c480ed1e1c87e37706462a6e6ced5d895aa

Matthew Beale

Throw when appending and already appended view

throw when appending and already appended view

46

false

7

false

emberjs

ember.js

12,542

2d3b012d5f0d4f63649a930facdaaf82876a337a

Matthew Beale

Clean up some lifecycle tests

clean up some lifecycle tests

29

false

5

false

emberjs

ember.js

12,543

011b876be624f6bebfebef92c026edca0045d6d2

Matthew Beale

Make createElement work without view entering inDOM state createElement requires that a view be rendered without the lifecycle hooks being rendered. This leaves it in the hasElement state instead of moving to inDOM as a normal render would.

make createelement work without view entering indom state

57

false

8

true

false

emberjs

ember.js

12,544

06aab7c7f986540a5446cc903d6303ade58d5129

Martin Muñoz

Reimplement hasBlock and hasBlockParams

reimplement hasblock and hasblockparams

39

false

4

true

emberjs

ember.js

12,545

8a92672d2c1660a051a03a0645df483c6514e1c5

Martin Muñoz

Rewrite some tests to use templates instead of a buffer

rewrite some tests to use templates instead of a buffer

55

false

10

true

false

emberjs

ember.js

12,546

9d923a687c77b06b7808203d6aea6afb20546676

Robert Jackson

Add missing -legacy-each registration for deprecated tests.

add missing -legacy-each registration for deprecated tests

58

false

7

true

false

emberjs

ember.js

12,547

f892dc8390f40ba84e825e946dea131afbaa01c1

Mitch Lloyd

Robert Jackson

Use templates to test View.nearestTypeOf.

use templates to test view.nearesttypeof

40

false

5

true

emberjs

ember.js

12,548

44b219c31bab9ec5b8559945f899c3132e7c0b71

Robert Jackson

Merge pull request #10903 from mixonic/idempotent-rerender-no-virtual Completely remove the concept of isVirtual

merge pull request from mixonic/idempotent-rerender-no-virtual

63

true

false

5

true

false

emberjs

ember.js

12,549

6368254d0dc4ee6c11a71f04f17086ae67b5e089

Matthew Beale

Robert Jackson

Completely remove the concept of isVirtual MetamorphView (and the Metamorph mixin) are the final bastion of virtual views. This commit removes much of their use. MetamorphView had two behaviors: First, it was tagless. Second, it was not included in the view hierarchy. The first concept (taglessness) is still valid in Ember post-Glimmer. For this, we use `tagName: ''`. The second concept (virtual views) is not longer present. So views which previously used MetamorphView will not longer be able to escape the view hierarchy. In most cases, the intent was likely to be tagless and being virtual was simply a side effect. OutletView and EachView will now be present in childViews and will be parentViews. `{{render` used to always create a view. Now, it will only create a view if one is set by the user. By default it is only a componentNode and has no view at all. The final spot MetamorphViews are used it for the default itemView and emptyView on EachView. This should be easy to address in a manner similar to {{render: If the user does not specify a view, none should be required. After this, MetamorphView will no longer be used by internals.

completely remove the concept of isvirtual

42

false

6

false

emberjs

ember.js

12,550

e60116d4da6ab380e8a65a63032b1ae0ace21f56

Robert Jackson

Merge pull request #10893 from sandstrom/patch-3 [DOC] Minor doc fix for expanded properties

merge pull request from sandstrom/patch-3

42

true

false

5

true

false

emberjs

ember.js

12,551

0985123f9390b16042cd73300d5b9fc94515a7a8

sandstrom

Minor documentation fix Fix minor typo in inline documentation.

minor documentation fix

23

false

3

false

emberjs

ember.js

12,552

f34d66901205b8088821c14e1c78a77a6edd0a82

Justin Brown

Remove prototype extensions example.

remove prototype extensions example

35

false

4

true

false

true

emberjs

ember.js

12,553

d9965f6417032ed4645f2d01af487536739ed646

Mitch Lloyd

[BUGFIX beta] Fix replace in Resolves #10881

[bugfix beta] fix replace in

28

false

5

false

emberjs

ember.js

12,554

ffedc10ea3c11ff17040175b28d3bbe3bfda24a3

Robert Jackson

Fix invalid assertion.

fix invalid assertion

21

false

3

true

emberjs

ember.js

12,555

5a4667b4afc4bea61b617a839fec61ccf2071a40

Robert Jackson

[SECURITY CVE-2015-1866] Escape Ember.Select option label contents. (cherry picked from commit 29703251a3d36ff972753985aa23f4e6bf2cf24e) (cherry picked from commit 3368489926d95cc0c9960e31c7ca904b9b092300)

[security cve-2015-1866] escape ember.select option label contents

66

false

7

false

emberjs

ember.js

12,556

3707d7ac9d3727792bf3208317bcb6c882fa191c

Nathan Hammond

Make the component helper able to deal with falsey values.

make the component helper able to deal with falsey values

57

false

10

false

true

false

emberjs

ember.js

12,557

41542c6f2aec89378f312009e0e7d642a3c848f1

Robert Jackson

Merge pull request #10874 from MajorBreakfast/patch-1 [BUGFIX beta] Include all files in jspm package

merge pull request from majorbreakfast/patch-1

47

true

false

5

true

false

emberjs

ember.js

12,558

dec934b4295a902237b9af6cffcf05535ff7432d

Josef Brandl

[BUGFIX beta] Include all files in jspm package

[bugfix beta] include all files in jspm package

47

false

8

false

emberjs

ember.js

12,559

a21045d7c8fda68f4c4ca669ef38401e95dfe803

Robert Jackson

Merge pull request #10873 from usmantahirr/master ember-template-engine added to main tag in Bower.json for wiredep errors.

merge pull request from usmantahirr/master

43

true

false

5

true

false

emberjs

ember.js

12,560

bed7dd38cbccc7274b56d4c460a726fe861d8332

Usman Tahir

Added Ember Template Engine to Bower, WireDep plugin don't include this component if its not in main hence templates won't compile. For templates compilation its required or it throws an error "Uncaught Error: Cannot call compile without the template compiler loaded. Please load ember-template-compiler.js prior to calling compile"

added ember template engine to bower, wiredep plugin don't include this component if its not in main hence templates won't compile

130

false

21

false

emberjs

ember.js

12,561

e697ef3f4308ee6b525e7b6f3eca4a14c6f23b34

Yehuda Katz

Handle legacy View scope better

handle legacy view scope better

31

false

5

false

emberjs

ember.js

12,562

e2ea5f0ba59974a67c0fd32b7e9d444676e90db3

Tom Dale

WIP on {{each itemController}}

wip on {{each itemcontroller}}

30

false

4

false

emberjs

ember.js

12,563

7ce75ed106001a7eb75b874ba0760f25becc72b5

Tom Dale

Implement legacy {{each}} features

implement legacy {{each}} features

34

false

4

false

true

false

emberjs

ember.js

12,564

7d342b6682b95692d2d93e7a8a787dc3d6a1d655

Robert Jackson

Remove unused AttrNode.

remove unused attrnode

22

false

3

true

emberjs

ember.js

12,565

14d15f4b0f8f3f26411ac138b98dbbd0c595fc65

Martin Muñoz

Remove ember-metal-views tests These tests were removed because they were only testing a stub renderer defined in the tests.

remove ember-metal-views tests

30

false

3

false

emberjs

ember.js

12,566

f73264d685fda7e9b9d9d17bc7d39f9477ed225c

Martin Muñoz

Fix a test using an undefined context Context-changing helpers no longer allow an undefined context. Instead, null is substituted for the context.

fix a test using an undefined context

37

false

7

true

emberjs

ember.js

12,567

03c17104605c4c366091ac75b5199d2104b5a31d

Robert Jackson

Correct assertion messages in tests.

correct assertion messages in tests

35

false

5

false

emberjs

ember.js

12,568

701f11f25d429995a8ca92384795b6f89d9fd9de

Robert Jackson

Implement custom element hook to allow deprecating legacy unbound helpers.

implement custom element hook to allow deprecating legacy unbound helpers

73

false

10

false

true

false

emberjs

ember.js

12,569

d8a8679553dd310ce60155170128e9f843d0fd1c

Tom Dale

For backwards-compat, make attrs available at init

for backwards-compat, make attrs available at init

50

false

7

false

emberjs

ember.js

12,570

62df0e5b98a7a14f3e38fe46208cbcb4c481afb2

Tom Dale

Munge attrs before creating ComponentNode

munge attrs before creating componentnode

41

false

5

false

true

false

emberjs

ember.js

12,571

55dd117d60781468c5cade525406545f3300c9c8

Robert Jackson

Add Ember specific AttrMorphClass to provide style warning.

add ember specific attrmorphclass to provide style warning

58

false

8

false

true

false

emberjs

ember.js

12,572

7324b93d0a3a61d7295363ca6833edd1a137a871

Robert Jackson

Merge pull request #10888 from mitchlloyd/is-visible-fixes isVisible fixes

merge pull request from mitchlloyd/is-visible-fixes

52

true

false

5

true

false

emberjs

ember.js

12,573

c0561486baf574ffdcb07daa2159d88d5695abd2

Martin Muñoz

Remove invalid test

remove invalid test

19

false

3

true

emberjs

ember.js

12,574

8cde4d388a5f2298ac5b130ee531ed46d6c19da6

Edward Faulkner

provide deprecation warning if we fall back to template

55

false

9

true

false

emberjs

ember.js

12,575

85ff4278f0c8f252cd35a1a9ef967aadc01412fc

Edward Faulkner

fix use of template & layout together

37

false

7

true

emberjs

ember.js

12,576

86bdbc6450403bee31f29a794b515cb3e7b0ea93

Edward Faulkner

rely on stable childEnvs to for outletState

rely on stable childenvs to for outletstate

43

false

7

false

emberjs

ember.js

12,577

a180c80f9b444d58600ff09a24cb6b97e1355275

Edward Faulkner

dropping dead code this is all old implementation of pre-glimmer outlet behavior

dropping dead code

18

false

3

false

emberjs

ember.js

12,578

c7f67e8806354e36497f68ec5644405c4d2b5e1f

Martin Muñoz

Fix inverse block in compat helpers

fix inverse block in compat helpers

35

false

6

true

emberjs

ember.js

12,579

db465aefdbe4472dc90bfdd481b7cdedd1095bda

Mitch Lloyd

Add fix for overwriting style attribute bindings

add fix for overwriting style attribute bindings

48

false

7

true

emberjs

ember.js

12,580

6deadbe303feccc2ccf6ce7451fada49b18b60d5

Mitch Lloyd

Get isVisible with container tests passing

get isvisible with container tests passing

42

false

6

false

emberjs

ember.js

12,581

9ce28453fb77ecf092ff237e1490f37114d7e66a

Edward Faulkner

dropping dead code: outlets don't use the rerender hook

outlets don't use the rerender hook

35

false

6

false

emberjs

ember.js

12,582

188d00cc3db6dc4c711d0d72833773462fd7528f

Mitch Lloyd

Fix isVisible on first render

fix isvisible on first render

29

false

5

false

emberjs

ember.js

12,583

d2a9f029d1f6d55fdd1268a90a1199c65f542a13

Robert Jackson

Fix a couple Ember.Select tests.

fix a couple ember.select tests

31

false

5

false

emberjs

ember.js

12,584

6ff39999d17ab457264b007765fbdb79dc1582e0

Robert Jackson

Update link-render-node to handle missing params. The `{{component}}` keyword specifies `null` as `params` (since a component cannot receive ordered arguments). This commit simply adds a guard to ensure we do not attempt to access `params.length` when `params` is `null`.

update link-render-node to handle missing params

48

false

6

false

emberjs

ember.js

12,585

c43cb492c073b079a6a69fc71a2c1e42ff837d83

Robert Jackson

Enable tests that are now passing.

enable tests that are now passing

33

false

6

true

emberjs

ember.js

12,586

55ece9fdc400c02ef4b001570ff29cbb9ac2a912

Robert Jackson

Merge pull request #10886 from mitchlloyd/html-class-spacing Fix class spacing for classNameBindings

merge pull request from mitchlloyd/html-class-spacing

54

true

false

5

true

false

emberjs

ember.js

12,587

9c334449e3b220f36f9e9d0b45ad89d86607ba99

Mitch Lloyd

Wrap `set` in run loop

wrap `set` in run loop

22

false

5

false

true

false

emberjs

ember.js

12,588

b07d55cf49a80b1edac5bc4b98a8dd42fc0b7970

Mitch Lloyd

Fix spacing between omitted class names

fix spacing between omitted class names

39

false

6

false

true

false

emberjs

ember.js

12,589

9efd004ca7e7bd76e4451ebffaa31093c5c78557

Robert Jackson

Update HTMLBars to 0.13.1. Updates HTMLBars to ensure that initially undefined/null `attributeBindings` are not set on the views element.

update htmlbars to 0.13.1

25

false

4

true

emberjs

ember.js

12,590

2823dd95c4847797a865fe04065604881e57b68b

Tom Dale

Implement collection’s itemClass

implement collection’s itemclass

32

false

3

false

emberjs

ember.js

12,591

8e56b7fd6a30852b4b2b992ba2bfe6a1da2176a1

Tom Dale

ContainerView should inherit from View While it was a noble effort, the attempt to have ContainerView subclass Component did not work because it broke propagation of the `controller` template keyword.

containerview should inherit from view

38

false

5

false

emberjs

ember.js

12,592

47ddf42b2c10324d9e8d35397db8195c9108a465

Tom Dale

Unify legacy class binding into AST preprocessor There are several paths and microsyntaxes for creating class name bindings for a component’s element via Handlebars. For example: `{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}` With HTMLbars, these have been deprecated in favor of a single API: `{{view class=“hello foo (if isApp ‘is-an-app’)”}}` This commit rewrites the AST of templates that contain the old syntax into the new syntax at template compile time.

unify legacy class binding into ast preprocessor

48

false

7

true

emberjs

ember.js

12,593

6153cd8b2f93a90f2862de7ce7aabad978c146a7

Tom Dale

Add note on Checkbox inheriting from Component

add note on checkbox inheriting from component

46

false

7

true

emberjs

ember.js

12,594

c692bd0464f393cb334fb8110e2c3c297df42931

Robert Jackson

Fix current node tests.

fix current node tests

22

false

4

true

emberjs

ember.js

12,595

8728fd15dd50678b219ad0f80f2f19c03a2b005b

Martin Muñoz

Edward Faulkner

Fix last textarea test

fix last textarea test

22

false

4

false

true

false

emberjs

ember.js

12,596

0c8c5737eeab40a2f6948de3880dbac39bd6e52e

Tom Dale

Edward Faulkner

Set component props to attrs if defined

set component props to attrs if defined

39

false

7

false

true

false

emberjs

ember.js

12,597

764a138247c72783738e2c5a11dbbbebf8d91387

Tom Dale

Edward Faulkner

Get Ember.Select tests passing

get ember.select tests passing

30

false

4

false

true

false

emberjs

ember.js

12,598

66acf7fcbcb721ffb332dd48d3cad2b305ab327b

Tom Dale

Edward Faulkner

Update Ember.Select to use HTMLbars templates

update ember.select to use htmlbars templates

45

false

6

true

emberjs

ember.js

12,599