sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
b2c739e456af531db15e5612730a44bb3c0a1307 | Matthew Beale | Matthew Beale | Merge pull request #11093 from mixonic/improved-actions
Action subexpression simply reads off actions, no send | merge pull request from mixonic/improved-actions | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,300 |
9b529cf04d9359288fa737c5d65f28b623d5621b | Matthew Beale | Matthew Beale | Action subexpression simply reads off actions, no send | action subexpression simply reads off actions, no send | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 12,301 |
0b72242c95b4da2f0cb63e455f79fac2492efec2 | Robert Jackson | Robert Jackson | Merge pull request #11092 from mixonic/improved-actions
Fix edge case in improved actions. String action w/ value | merge pull request from mixonic/improved-actions | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,302 |
51f6221232a831a66d273e00293eff92a820010c | Matthew Beale | Matthew Beale | Fix edge case in improved actions. String action w/ value
String action arguments cause a new first argument to be pushed onto the
curried params list. Semantically value is supposed to reference the
first param, so this change in position of the first argument must be
tracked. | fix edge case in improved actions. string action w/ value | 57 | false | false | 10 | true | true | false | emberjs | ember.js | 12,303 |
24e42ced437e78009bb10a919d89080b36dc5aad | Robert Jackson | Robert Jackson | Merge pull request #11089 from mixonic/improved-actions
[FEATURE] Improved closure based actions per RFC #50 | merge pull request from mixonic/improved-actions | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,304 |
e19b9e2261b170ee82aff94457b0f4143cb70de1 | Matthew Beale | Matthew Beale | [FEATURE] Improved closure based actions per RFC #50 | [feature] improved closure based actions per rfc #50 | 52 | false | false | 8 | false | false | false | emberjs | ember.js | 12,305 |
8fe0caa26354d8b2198b00fb3a8101d5cd15cd4e | Robert Jackson | Robert Jackson | Merge pull request #11002 from trek/remove-qp-inactive-state
Clarifies intent of `states.inactive` | merge pull request from trek/remove-qp-inactive-state | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,306 |
9415efa1676aa9b390be8b21a88d823948d822c3 | Tony Pitale | Tony Pitale | make equality match the comment | make equality match the comment | 31 | false | false | 5 | false | true | false | emberjs | ember.js | 12,307 |
d333e01578e2a5d26ed2f872f466e6437521fe44 | Robert Jackson | Robert Jackson | Merge pull request #11075 from joeruello/with-docs
[DOC canary] Document {{#with foo as |bar|}} falsey behavior | merge pull request from joeruello/with-docs | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 12,308 |
52ef8290d358ab7e13885cbef1953ddfa90ed064 | joe | Joe | [DOC canary] Document {{#with foo as |bar|}} falsey behavior | [doc canary] document {{#with foo as |bar|}} falsey behavior | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 12,309 |
0c8ba4fb92df041cdf8e25ad113f3a7a57428429 | Robert Jackson | Robert Jackson | Merge pull request #11081 from emberjs/computed-attribute-updates
Fix a cycle in mutable bindings | merge pull request from emberjs/computed-attribute-updates | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,310 |
5107da66e567895edb821d1440ba4e4cc5e5d4bb | Yehuda Katz | Yehuda Katz | Fix a cycle caused by legacy semantics
Consider a component like this:
```js
// my-component.js
Component.extend({
thingy: null
});
```
And an invocation like this:
```hbs
{{my-component thingy=(mut someValue)}}
```
(note that `mut` is the default for old-style component invocations)
In this case, because `my-component` has an explicit `thingy` property,
we set the property on rendering and re-rerendering for backwards
compatibility reasons.
Because `attrs.thingy` is a mutable cell, when we try to set `thingy` on
`my-component` during re-render, its `update` method is invoked, which
clobbers the original `someValue` unexpectedly. When `someValue` is a
computed property, the results can be catastrophic.
This commit avoids invoking `update` on a mutable cell in this
situation, avoiding this unnecessary cycle. | fix a cycle caused by legacy semantics | 38 | false | false | 7 | true | true | true | emberjs | ember.js | 12,311 |
32a8fc07b4f005a860c0e3bcaa28f1301366b068 | Robert Jackson | Robert Jackson | Add test for invalidating mutable bindings with a CP source.
Test for https://github.com/emberjs/ember.js/issues/11023. | add test for invalidating mutable bindings with a cp source | 59 | false | false | 10 | true | true | false | emberjs | ember.js | 12,312 |
7c174d5dfb914d934dbdf5e762fc6a3808dade32 | Robert Jackson | Robert Jackson | Merge pull request #11074 from ef4/issue-11073
Don't ovewrite default elementId with undefined | merge pull request from ef4/issue-11073 | 40 | true | false | 5 | true | true | false | emberjs | ember.js | 12,313 |
a97eeb5626cf6a9d41ae1b65e884b43c88b611c6 | Edward Faulkner | Edward Faulkner | Don't ovewrite default elementId with undefined
Fixes #11073 | don't ovewrite default elementid with undefined | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 12,314 |
5f4cfbc706fc3a90b7dbbda80490e91ba7247311 | Robert Jackson | Robert Jackson | Merge pull request #11072 from ofbriggs/correct-spelling
[DOC] Corrected spelling in CONTRIBUTING.md | merge pull request from ofbriggs/correct-spelling | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 12,315 |
988f1c96dae3bef06fdc40cc649189dd0016e65b | Olivia Briggs | Olivia Briggs | [DOC] Corrected spelling in CONTRIBUTING.md | [doc] corrected spelling in contributing.md | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 12,316 |
42ae2aebc0784d4d5082e6b00171ca015e7dbef9 | Robert Jackson | Robert Jackson | Merge pull request #11069 from rwjblue/make-view-renderNode-private
Move `view.renderNode` to `view._renderNode`. | merge pull request from rwjblue/make-view-rendernode-private | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,317 |
636756513920799237bd9126b304697606144d24 | Robert Jackson | Robert Jackson | Merge pull request #11068 from emberjs/component-helper-invalidation-in-each
Fixes {{component}} never re-rendering | merge pull request from emberjs/component-helper-invalidation-in-each | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 12,318 |
3639e21a8f473da78e0e4a0a39ece1af980f3e9c | Robert Jackson | Robert Jackson | Move `view.renderNode` to `view._renderNode`.
This is definitely considered a private API. | move `view.rendernode` to `view._rendernode` | 44 | false | false | 4 | false | true | false | emberjs | ember.js | 12,319 |
9885e9ac48cc2c8b22f63d8e439add860cfe0e80 | Yehuda Katz | Yehuda Katz | Dynamic {{component}} re-renders when attrs change
For some reason, the `{{component}}` keyword did not implement any
re-rendering behavior, which means that it... didn't rerender. Go
figure.
Fixes #11044. | dynamic {{component}} re-renders when attrs change | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 12,320 |
be1652f41e0df82b2ff995d7d766145898d23db4 | Robert Jackson | Yehuda Katz | Add test to ensure that {{component}} helper properly sets attributes in each.
Tests for https://github.com/emberjs/ember.js/issues/11044. | add test to ensure that {{component}} helper properly sets attributes in each | 77 | false | false | 12 | true | true | false | emberjs | ember.js | 12,321 |
aace10519b50c4821bf27945335e878b942eb4ac | Robert Jackson | Robert Jackson | Merge pull request #11066 from rwjblue/disable-dynamic-view-keyword
Disable dynamically changing views with `{{view}}` keyword. | merge pull request from rwjblue/disable-dynamic-view-keyword | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,322 |
f5aaa8babed6660219a1d1923d978a975c9490de | Robert Jackson | Robert Jackson | Merge pull request #11055 from jayphelps/cleanup1
Clean up unused variable, assignment flow, etc in buildComponentTemplate | merge pull request from jayphelps/cleanup1 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 12,323 |
d4119c38ca82edf99ce875f5054c079ee22d11fc | Robert Jackson | Robert Jackson | Disable dynamically changing views with `{{view}}` keyword.
The recent Glimmer refactor made dynamic `{{view viewName}}` work when
the `viewName` property changed (it would teardown the previous view and
render a new one).
This is a nice feature (and we may want to bring it back), but it should
be feature flagged and communicated properly to users. | disable dynamically changing views with `{{view}}` keyword | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 12,324 |
60d942f0da90c1a17f6c1a937166f2a7000839f7 | Yehuda Katz | Yehuda Katz | yielded content fully inherits original scope
Previously, `createShadowScope` would unconditionally clobber
`scope.attrs`. This was under the mistaken assumption that shadow scopes
are always fresh scopes. However, this assumption is not true today, and
has almost never been true historically.
The reason this error was not caught earlier was this if `scope.attrs`
is not properly inherited, `attrs.foo` will usually fall back to the
`attrs` property on the surrounding view.
There are several differences between `scope.attrs` and `view.attrs`,
however, and the most crucial one is that `view.attrs` represents
mutable values as `{ value: val, update(v) { ... }`, while they are
passed along as streams internally. This difference is never exposed
under normal circumstances (via the `scope.attrs` mechanism), but since
`scope.attrs` was being clobbered, the difference was exposed.
This means that if you try to do `{{attrs.foo.bar}}` and `attrs.foo` is
a mutable binding, the bug fixed in this commit would look up the
"mutable cell" object and not find `bar` inside of it.
This commit only replaces `scope.attrs` in `createShadowScope` if the
caller actually provides a new `attrs`, not blindly. | yielded content fully inherits original scope | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 12,325 |
5e1fd0453fe25998e05f7403a71447a4e59e9cd3 | Jay Phelps | Jay Phelps | Clean up unused variable, assignment flow, etc in buildComponentTemplate | clean up unused variable, assignment flow, etc in buildcomponenttemplate | 72 | false | false | 9 | false | false | false | emberjs | ember.js | 12,326 |
5ff3d02e339e640d429445f20f6bb727ccd0d15a | Robert Jackson | Robert Jackson | Merge pull request #11061 from hibariya/fix-legacy-each-view-tagname
[Glimmer] Add empty tagName to avoid unnecessary div-tag | merge pull request from hibariya/fix-legacy-each-view-tagname | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 12,327 |
e2fba329ecc4380570c233aac9a8d83ed1905f15 | Robert Jackson | Robert Jackson | Merge pull request #11060 from eliotsykes/document-auto-option-for-location
Add 'auto' to list of available location types [ci skip] | merge pull request from eliotsykes/document-auto-option-for-location | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 12,328 |
56877d07c50de776a25ada5ddb60954d89eee8c7 | Eliot Sykes | Eliot Sykes | Add 'auto' to list of available location types | add 'auto' to list of available location types | 46 | false | false | 8 | false | true | false | emberjs | ember.js | 12,329 |
6069bb4e65e1272bb7d5d46307387c73ddb89775 | Hika Hibariya | Hika Hibariya | Add empty tagName to avoid unnecessary div-tag
Fixes #11056 | add empty tagname to avoid unnecessary div-tag | 46 | false | false | 7 | true | true | true | emberjs | ember.js | 12,330 |
982884b24640004ad3678148877f926cfcd3c3ff | Robert Jackson | Robert Jackson | Merge pull request #11059 from simi/remove-test-comment
Remove commented import in htmlbars component lookup test. | merge pull request from simi/remove-test-comment | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,331 |
dd2afa7a9c78989fe9f7d31592489fe307f9d96f | Josef Šimánek | Josef Šimánek | Remove commented import in htmlbars component lookup test. | remove commented import in htmlbars component lookup test | 57 | false | false | 8 | false | true | false | emberjs | ember.js | 12,332 |
a69f48bc50f9da8224da17b2162c9b72eb8745b5 | Robert Jackson | Robert Jackson | Merge pull request #11035 from joeruello/with-falsey
[Bugfix] {{#with}} helper should not render if passed variable is falsey | merge pull request from joeruello/with-falsey | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 12,333 |
deb960341a626e7443729742a23449a6d9fa8bc6 | Robert Jackson | Robert Jackson | Merge pull request #11042 from pangratz/add_assertion_for_dynamic_positional_params_test
Add missing assertion for testing dynamical positionalParams | merge pull request from pangratz/add_assertion_for_dynamic_positional_params_test | 82 | true | false | 5 | true | false | false | emberjs | ember.js | 12,334 |
ec89d239a1f564df640f0ed3235119eae6056e57 | Robert Jackson | Robert Jackson | Merge pull request #11058 from rwjblue/disable-non-attrs-deprecations
Disable deprecation instructing folks to use `attrs.*`. | merge pull request from rwjblue/disable-non-attrs-deprecations | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 12,335 |
72ce690460cb3b8a87e05ff38a5c87e1e327eb95 | Robert Jackson | Robert Jackson | Merge pull request #11057 from rwjblue/dashless-components
Restore hyphen requirement for component lookup. | merge pull request from rwjblue/dashless-components | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 12,336 |
59854bbd87a95aa5a0bb178ec2a7e3e982d399ef | Robert Jackson | Robert Jackson | Disable deprecation instructing folks to use `attrs.*`.
Using `attrs.*` is definitely a good thing, but the transition plan is
not fully fleshed out. Disable the deprecation until we have documented
the transition plan. | disable deprecation instructing folks to use `attrs.*` | 54 | false | false | 7 | false | true | false | emberjs | ember.js | 12,337 |
5014201d48e3777b7578b2d9e44619f92cad0eae | Robert Jackson | Robert Jackson | Restore hyphen requirement for component lookup. | restore hyphen requirement for component lookup | 47 | false | false | 6 | true | true | true | emberjs | ember.js | 12,338 |
6869d58e138ccaa9e5e738591a0bcad84d62f946 | Robert Jackson | Robert Jackson | Merge pull request #11045 from pangratz/positional_params_in_component_helper
Fix positionalParams when using {{component}} helper | merge pull request from pangratz/positional_params_in_component_helper | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 12,339 |
9b062f67b36e124ac06e097a67e6509fa615ecab | pangratz | pangratz | Add missing assertion for testing dynamical positionalParams | add missing assertion for testing dynamical positionalparams | 60 | false | false | 7 | true | true | false | emberjs | ember.js | 12,340 |
e02bb70920199196334db03500be2be38cbb0372 | pangratz | pangratz | Fix positionalParams when using {{component}} helper
Since the first parameter passed to the `{{component}}` helper is the
name of the component which shall be rendered, this needs to be
considered when the positionalParams are constructed for the specific
component. | fix positionalparams when using {{component}} helper | 52 | false | false | 6 | true | true | false | emberjs | ember.js | 12,341 |
e921b0dfea8e364a98b70c33528d1abac048ea9e | Martin Muñoz | Martin Muñoz | Merge pull request #11050 from vanthome/patch-1
Update run_loop.js | merge pull request from vanthome/patch-1 | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 12,342 |
7603ac6d6831ca7d933f58873679f9f3cf4a9093 | Robert Jackson | Robert Jackson | Merge pull request #11052 from mitchlloyd/fix-collection-item-class-names
[Glimmer] Correctly handle collection's itemClassNames | merge pull request from mitchlloyd/fix-collection-item-class-names | 67 | true | false | 5 | true | false | false | emberjs | ember.js | 12,343 |
4c6a0fa7256588ef0200c4ab30feb34e6f623044 | Mitch Lloyd | Mitch Lloyd | Correctly handle collection's itemClassNames
Fixes #11024 | correctly handle collection's itemclassnames | 44 | false | false | 4 | false | false | false | emberjs | ember.js | 12,344 |
d2d0fa81362126d3153bb8d45df6fce4788edf31 | Thomas Hoppe | Thomas Hoppe | Update run_loop.js
`setupEditor` is not a message, it's a method. | update run_loop.js | 18 | false | false | 2 | true | false | false | emberjs | ember.js | 12,345 |
d10d66e87437c6847102637361ca49a1aeb9520c | Robert Jackson | Robert Jackson | Merge pull request #11049 from emberjs/attr-proxy-observation
Fix attr proxy observation | merge pull request from emberjs/attr-proxy-observation | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 12,346 |
5adecd0027c6a80f3036c8fb63fe87d677df1b37 | Yehuda Katz | Yehuda Katz | Legacy observers on views should work | legacy observers on views should work | 37 | false | false | 6 | false | false | false | emberjs | ember.js | 12,347 |
9bdf771d5c25746288846175f3b85f859a89fa39 | Robert Jackson | Robert Jackson | Add test for observing an attribute set via the attr-proxy. | add test for observing an attribute set via the attr-proxy | 58 | false | false | 10 | true | true | false | emberjs | ember.js | 12,348 |
b2163fd241feaddec7a64844756acac7cb83d972 | Robert Jackson | Robert Jackson | Merge pull request #11041 from rwjblue/export-private-legacy-each-view
Export private LegacyEachView. | merge pull request from rwjblue/export-private-legacy-each-view | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 12,349 |
1ef99f6e9e74e0b0854584a31f966bb03b48bab9 | Robert Jackson | Robert Jackson | Export private LegacyEachView.
Since we are looking this up from the container, we need to export so
ember-test-helpers can register with the testing isolatedContainer.
Without this registration, it is not possible to unit test a view/component
with certain types of `{{each}}` in them. | export private legacyeachview | 29 | false | false | 3 | false | true | false | emberjs | ember.js | 12,350 |
589c11ab08a228a63cefe0395b7213ccf279dbf6 | joe | joe | [Bugfix] {{#with}} helper should not render if passed variable is falsey | [bugfix] {{#with}} helper should not render if passed variable is falsey | 72 | false | false | 11 | false | false | false | emberjs | ember.js | 12,351 |
f29a21bb8e6fb4f2ab22949b2b257c62fdf93af7 | Robert Jackson | Robert Jackson | Merge pull request #11033 from rwjblue/fix-element-morphs
Update HTMLBars to 0.13.15. | merge pull request from rwjblue/fix-element-morphs | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,352 |
b28c5ea99b5444f7f2ecfe7ab6ba7eae5ca4b26e | Robert Jackson | Robert Jackson | Add test to ensure that ElementMorph's can be cleaned up. | add test to ensure that elementmorph's can be cleaned up | 56 | false | false | 10 | true | true | false | emberjs | ember.js | 12,353 |
995e2d2e0d5e6ae54afb6f3095c3d1efb20cdcfc | Edward Faulkner | Robert Jackson | Adding positional parameter support to components
A longstanding pattern is to use helpers to simulate components with
positional parameters. But under Glimmer, helpers are pure functions, so
this doesn't work anymore.
Thankfully, we can do something even better, which is to stop wrapping
components in helpers just to get positional params, and instead make
components that can natively accept positional params. That's what this
PR does.
To use, you define your component like:
```js
Ember.Component.extend({
positionalParams: ['name', 'city']
});
```
Then you can invoke it like:
```handlebars
{{my-component "Ed" "Somerville"}}
```
Which is equivalent to:
```handlebars
{{my-component name="Ed" city="Somerville"}}
```
(cherry picked from commit f0d28c2b5518bfbfe45a357638ad1ad1a90277e1) | adding positional parameter support to components | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 12,354 |
1ca99f9825ad6671eb7107d6756bed3e24aa6f23 | Robert Jackson | Robert Jackson | Merge pull request #11031 from rwjblue/ensure-nested-attributes-do-not-blow-up
Fix issue with bound attributes inside block helpers. | merge pull request from rwjblue/ensure-nested-attributes-do-not-blow-up | 72 | true | false | 5 | true | false | false | emberjs | ember.js | 12,355 |
bcefabd35c6435c894466fe72b2b3736fc644b9c | Robert Jackson | Robert Jackson | Fix issue with bound attributes inside block helpers. | fix issue with bound attributes inside block helpers | 52 | false | false | 8 | true | true | false | emberjs | ember.js | 12,356 |
fd0cb35c24ffc70a4f8ffe7bc5a3bea5d29de923 | Robert Jackson | Robert Jackson | Merge pull request #11029 from ef4/bound-outlet-names
Allow bound outlet names | merge pull request from ef4/bound-outlet-names | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 12,357 |
984f9a29941de4087b9dee514819ca9c5c1f48fd | Yehuda Katz | Yehuda Katz | Support downcasting a mutable binding to readonly
If a mutable binding is passed into a child component without `{{mut}}`,
downcast it into an immutable binding.
The idea is that this preserves a local annotation at every point where
a component is invoked with a mutable binding, and makes it very easy to
drop the mutability when invoking a child component that doesn't need
it. | support downcasting a mutable binding to readonly | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 12,358 |
6e63de48f3a94aa4ef3e76b484074807faa8df77 | Edward Faulkner | Edward Faulkner | Allow bound outlet names
Bound outlet names actually work fine without any additional work. They
were just disallowed due to a very old assert that was introduced back
when we were first standardizing the use of quoted strings to represent
literals.
This drops the assertion and adds a test that shows bound outlet names
work. | allow bound outlet names | 24 | false | false | 4 | true | true | true | emberjs | ember.js | 12,359 |
c4dbc70b8f69d1b9fc5aad2d01537288e3efd3b6 | Artem Charykov | Artem Charykov | [BUGFIX beta] Fix wrong string conversions for namespaced model names
Now Camelize, capitalize, classify consider "/".
For example, 'private-docs/owner-invoice'.classify(); // 'PrivateDocs/OwnerInvoice' | [bugfix beta] fix wrong string conversions for namespaced model names | 69 | false | false | 10 | false | false | false | emberjs | ember.js | 12,360 |
6f20f6a5d178c69fc0079b3e5772693d10296f44 | Robert Jackson | Robert Jackson | Merge pull request #11026 from rwjblue/attr-proxy-blow-up
Prevent error when attributes are undefined/null. | merge pull request from rwjblue/attr-proxy-blow-up | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,361 |
ef926752426f99285e643d3286c034a2ccddcdb3 | Robert Jackson | Robert Jackson | Prevent error when attributes are undefined/null. | prevent error when attributes are undefined/null | 48 | false | false | 6 | true | true | true | emberjs | ember.js | 12,362 |
716404259158ed972c12e7643ec71831cf83b4b3 | bmac | bmac | [Bugfix release] Fix ember-routing-named-substates
Names substates routing only works with based and checks for the
`moduleBasedResolver` property to be set to true on the resolver.
Unfortunatly, it looks like some refactorings caused the resolver to
be hidden behind a function. This pr exposes the `moduleBasedResolver`
property on the resolver function that is exposed to routing
machinery.
Closes #10644
I believe this functionality was broken in this refactor:
https://github.com/emberjs/ember.js/commit/66ac1b3849f4bedf3c99fc3c07528b6bb0de5a41 | [bugfix release] fix ember-routing-named-substates | 50 | false | false | 4 | false | false | false | emberjs | ember.js | 12,363 |
8962e36f16a79e336371428fd265db3a2dbbdf8e | Robert Jackson | Robert Jackson | Merge pull request #10501 from emberjs/idempotent-rerender
Implement Glimmer Engine | merge pull request from emberjs/idempotent-rerender | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 12,364 |
691a5b0eb7f2682091b6fcc3eb2a06dd34e38334 | Robert Jackson | Robert Jackson | Ensure that `controller` is provided for route backed views.
Fixes #11013. | ensure that `controller` is provided for route backed views | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 12,365 |
38a9d867aca46af38d88083947681edacba26c36 | Robert Jackson | Robert Jackson | Add test controller propagation from route driven views.
(cherry picked from commit 035545ed2c47b84f1c104d3e22bded6f72db1a37) | add test controller propagation from route driven views | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 12,366 |
820d559175253e79c183942407ff4d7c3acec767 | Martin Muñoz | Martin Muñoz | Remove more dead code, relocate docs | remove more dead code, relocate docs | 36 | false | false | 6 | false | false | false | emberjs | ember.js | 12,367 |
12cd90756de806afe233d5b33af053587710e589 | Martin Muñoz | Martin Muñoz | Privatize bind-attr class compat helper | privatize bind-attr class compat helper | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 12,368 |
4d177cafd5943d3d7937945abfe392716f237d73 | Martin Muñoz | Martin Muñoz | Remove dead code | remove dead code | 16 | false | false | 3 | true | true | true | emberjs | ember.js | 12,369 |
535e44b09c2c5b905d9bdb8d39f7c554a21b23a1 | Martin Muñoz | Martin Muñoz | Fix a memory leak when KeyStream is observering a proxy | fix a memory leak when keystream is observering a proxy | 55 | false | false | 10 | true | true | false | emberjs | ember.js | 12,370 |
5bbfe689f7de2f497bdda8a7e5cc8d629bb0114c | Robert Jackson | Robert Jackson | Merge pull request #11022 from mixonic/idempotent-rerender-layout
outlet keywords must pass the template to render as template | merge pull request from mixonic/idempotent-rerender-layout | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,371 |
f81b17d1bf472dc3075eda83f3aa96c4049fb642 | Matthew Beale | Matthew Beale | outlet keywords must pass the template to render as template
Previously, they were passing it as layout which smashed a layout that
may have existed on the view being rendered. | outlet keywords must pass the template to render as template | 60 | false | false | 10 | false | false | false | emberjs | ember.js | 12,372 |
ff82f2e04ef3100c38d7f10e24133e7813eeb5a4 | Robert Jackson | Robert Jackson | Revert "Allow publishing of idempotent-rerender PR to S3."
This reverts commit 12b249632c4047c312441b69a7d51584595141dc.
This was accidentally pushing the glimmer builds to `canary` URL's.
Removed for now. Lets just merge this PR.... | revert "allow publishing of idempotent-rerender pr to s3." | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 12,373 |
dddca9a37bd2a6b823a0947c3ae4ad09f4219f5b | Robert Jackson | Robert Jackson | Bring Ember._Metamorph and Ember._MetamorphView back and deprecate.
ember-test-helpers still attempts to register `Ember._Metamorph` as
`view:default` which causes an error. We will need to update
ember-test-helpers to check for its existence first and remove the
globals at a later date. | bring ember._metamorph and ember._metamorphview back and deprecate | 66 | false | false | 7 | true | true | false | emberjs | ember.js | 12,374 |
12b249632c4047c312441b69a7d51584595141dc | Robert Jackson | Robert Jackson | Allow publishing of idempotent-rerender PR to S3. | allow publishing of idempotent-rerender pr to s3 | 48 | false | false | 7 | true | true | true | emberjs | ember.js | 12,375 |
a233059b52fa865eac093f6076bf8736d49afe18 | Robert Jackson | Robert Jackson | Publish Glimmer builds to S3.
Make testing apps easier... | publish glimmer builds to s3 | 28 | false | false | 5 | true | false | true | emberjs | ember.js | 12,376 |
d9e5c8018fad8a1ddab2e5f1f2ddd61975ef08c1 | Robert Jackson | Robert Jackson | Unskip mutable binding test. | unskip mutable binding test | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 12,377 |
27a6c57b0d15766b65a8ae1f74e1ab37e3493add | Martin Muñoz | Robert Jackson | Intercept property changes instead of sets
(cherry picked from commit b4d53bfd2d2769c4133f5f55e5551c6cc2dc87f8) | intercept property changes instead of sets | 42 | false | false | 6 | true | true | true | emberjs | ember.js | 12,378 |
807a0cd8fd48ea311395161d75a2b024a00d0ad0 | Yehuda Katz | Yehuda Katz | Don't warn when for-compat stream is not a path
The `(mut foo)` construction is designed to throw an error if you try to
do `(mut "foo")`, for obvious reasons.
When I wrote that error, I missed an alternative scenario:
```hbs
{{!-- component-one: --}}
{{!-- bar is not a path here --}}
<component-two foo="bat" />
{{!-- component-two: --}}
{{!-- attrs.foo is a path here --}}
<component-three baz={{mut attrs.foo}} />
```
In this case, `attrs.foo` is a path, but it directly refers to a string,
which is itself not mutable.
With angle-bracket components, when `{{mut}}` is explicit, the error
still makes sense: `<component-three>` should not try to mutate
`attrs.foo` and we should warn as soon as we can.
Unfortunately, that logic does not apply to the compatibility work we
are doing:
```hbs
{{!-- component-one: --}}
{{component-two foo="bat"}}
{{!-- component-two: --}}
{{component-three baz=attrs.foo}}
```
In this case, we can't know ahead of time that `attrs.foo` refers to a
non-mutator, so we have to allow for the possibility that this is a
two-way binding. For what it's worth, scenarios like this, which are
clearly bugs (`component-three` settting `baz`), help to explain the
motivation for the change in the first place.
This commit adds a private `@mut` that can support the looser semantics
of Ember 1.x curly components, while retaining the stricter errors for
explicit calls to `mut` used with angle bracket components. | don't warn when for-compat stream is not a path | 47 | false | false | 9 | false | false | false | emberjs | ember.js | 12,379 |
067286845e1ce09d61f6d6c62011b55d48d3d957 | Robert Jackson | Robert Jackson | Add skipped test showing issue with mutable binding system. | add skipped test showing issue with mutable binding system | 58 | false | false | 9 | true | false | false | emberjs | ember.js | 12,380 |
b01031305fc5f8c2cdb307bcda6d70465d1d8a5b | Robert Jackson | Robert Jackson | Remove deprecation on accessing `attrs` in component root.
We have not fully fleshed out the transition plan for this. Remove the
deprecation until we have... | remove deprecation on accessing `attrs` in component root | 57 | false | false | 8 | true | true | false | emberjs | ember.js | 12,381 |
a4f9da43dd978f2ea624fb95bac2b5cdc771fa87 | Robert Jackson | Robert Jackson | Fix propagation test. | fix propagation test | 20 | false | false | 3 | false | true | false | emberjs | ember.js | 12,382 |
5d38b798bd244a765f66a72404b9a557ad6d90e2 | Matthew Beale | Matthew Beale | Add a (passing?) test for settable upstreaming template bindings | add a (passing?) test for settable upstreaming template bindings | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 12,383 |
6795e0be87de82fb8b7c41e72fc62b976015000a | Robert Jackson | Robert Jackson | Make JSCS happy. | make jscs happy | 15 | false | false | 3 | false | true | false | emberjs | ember.js | 12,384 |
4cfb2bdb32b3df7df460ab1e20e9bb6592239298 | Tom Dale | Tom Dale | Fix controller local w/ `{{#each itemController}}` | fix controller local w/ `{{#each itemcontroller}}` | 50 | false | false | 6 | true | true | true | emberjs | ember.js | 12,385 |
4f46a23f91a2ebcf9c5d9d9726bebdadbe8ae4da | Tom Dale | Tom Dale | Fix {{#each}} with itemController in outlet | fix {{#each}} with itemcontroller in outlet | 43 | false | false | 6 | false | true | false | emberjs | ember.js | 12,386 |
42b5df02cabf553968bb499f7761f506aebb68a6 | Matthew Beale | Matthew Beale | Skipped test for values propagating upstream via templates | skipped test for values propagating upstream via templates | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 12,387 |
658f260e1caf9b0a20790c596dfa9c0ef1038aea | Matthew Beale | Matthew Beale | Drop old render_buffer file in favor of compat/ file | drop old render_buffer file in favor of compat/ file | 52 | false | false | 9 | true | true | false | emberjs | ember.js | 12,388 |
5a33e9c00b025152e3ed30981f245738c02fd52c | Tom Dale | Tom Dale | Propagate controller keyword for outlets | propagate controller keyword for outlets | 40 | false | false | 5 | true | true | true | emberjs | ember.js | 12,389 |
86ecba9dd4c3e90cacc9672b1c75b72df83297da | Matthew Beale | Matthew Beale | Merge pull request #11012 from mixonic/idempotent-rerender-buffer
Bring back the render hook with a pushable buffer | merge pull request from mixonic/idempotent-rerender-buffer | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,390 |
de821af2f92d763a12af31a49807ccfeeefc2540 | Matthew Beale | Matthew Beale | Bring back the render hook with a pushable buffer | bring back the render hook with a pushable buffer | 49 | false | false | 9 | false | false | false | emberjs | ember.js | 12,391 |
d1da84038a57961802be545cb0d7c713aa3739d9 | Martin Muñoz | Martin Muñoz | Fix stream teardown... I think | fix stream teardown... i think | 30 | false | false | 5 | false | true | false | emberjs | ember.js | 12,392 |
4189eb0f5ef9b8d468131adcae6d8f006abc1ada | Robert Jackson | Robert Jackson | Set outlet state prior to rendering {{outlet}} in tests. | set outlet state prior to rendering {{outlet}} in tests | 55 | false | false | 9 | false | false | false | emberjs | ember.js | 12,393 |
73881e41290eb86850193fb34e085d7e46c53641 | Robert Jackson | Robert Jackson | Fix dynamic `makeViewHelper`. | fix dynamic `makeviewhelper` | 28 | false | false | 3 | true | true | true | emberjs | ember.js | 12,394 |
57f05daa8fc4fd94e3507e4dab2bcbab3e32f699 | Robert Jackson | Robert Jackson | Fix dynamic `makeViewHelper`. | fix dynamic `makeviewhelper` | 28 | false | false | 3 | true | true | true | emberjs | ember.js | 12,395 |
c762400b954e044adbc568a0db9e312a6eb3ce9e | Robert Jackson | Robert Jackson | Merge pull request #10977 from fivetanley/bower-idemptotent-rerender
publish idemptotent rerender to bower | merge pull request from fivetanley/bower-idemptotent-rerender | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 12,396 |
2d501df08085018bcab80148ce941ce4410a6c03 | Robert Jackson | Robert Jackson | Remove unused imports in Ember.TextArea. | remove unused imports in ember.textarea | 39 | false | false | 5 | true | true | true | emberjs | ember.js | 12,397 |
0e674a4eb9e08ad98909db8de78b89e505114405 | Robert Jackson | Robert Jackson | Update HTMLBars to v0.13.11.
* Remove 'value' attribute hacks.
* Add `AttrMorph.prototype.getContent`. | update htmlbars to v0.13.11 | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 12,398 |
a80574534bf0ec76d34ac3cdbc956df03c2fe183 | Robert Jackson | Robert Jackson | Use readDOMAttr + attributeBinding for <textarea>.
The new `readDOMAttr` API allows us to remove this manual `value`
property binding in `Ember.TextArea`. | use readdomattr + attributebinding for <textarea> | 49 | false | false | 6 | true | true | true | emberjs | ember.js | 12,399 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.