sha
stringlengths
40
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85k
d4645deaf0f3c7d462895c63a08b0bd20338001d
Robert Jackson
Robert Jackson
Use native class for promise inheritance test. Prior to this change, when testing untranspiled ES an error is thrown (cannot call promise constructor without `new`).
use native class for promise inheritance test
45
false
false
7
true
true
true
emberjs
ember.js
5,600
00509569b30299f23df9aee3a5e2baa5e9e08022
Robert Jackson
Robert Jackson
Avoid using assert.throws with second arg as arrow func. Due to the various things QUnit allows for the second argument to `assert.throws` passing an untranspiled arrow function causes a `TypeError` to be thrown. This is ultimately due to QUnit using `instanceof` on the arrow function, which emits the following: ``` Uncaught TypeError: Function has non-object prototype 'undefined' in instanceof check ``` Demo (for the curious): ```js (function() { "use strict"; let f = () => {}; let error = new Error('some message'); let isInstance = error instanceof f; })() ```
avoid using assert.throws with second arg as arrow func
55
false
false
9
false
false
false
emberjs
ember.js
5,601
7ee78b34b104e5ea811287cf1fa15ffa61c39e32
Robert Jackson
Robert Jackson
Ensure @glimmer/compiler is available as "pure es". Unfortunatly, the `ember-template-compiler.js` asset that was being used in tests, was clobbering all of the "pure ES" modules that we were loading and replacing it with the transpiled versions :weary:. This updates to: 1) include `@glimmer/compiler` in the list of "raw" es packages 2) ensure that the global require that is done within `@glimmer/compiler` (for `crypto`) does not get rewritten to an `import` (due to babel6 doing ES -> CJS -> AMD).
ensure @glimmer/compiler is available as "pure es"
50
false
false
7
false
false
false
emberjs
ember.js
5,602
3b5727e7a1400bd43aa41332d5bae20770d27c51
Robert Jackson
Robert Jackson
Fix issue with custom test harness and native classes. When transpiled by babel the original code worked fine, however without transpilation tests are no longer generated. This is because class methods are non-enumerable, and therefore `Object.keys` does not iterate them any longer. The fix here is to explicitly use `Object.getOwnPropertyNames` to retrieve all property names (even the non-enumerable ones) instead of `Object.keys`.
fix issue with custom test harness and native classes
53
false
false
9
true
true
false
emberjs
ember.js
5,603
7d5a9c300b6275b58bb1c8c42af071cf145bcb94
Robert Jackson
Robert Jackson
Enable tests using ES<latest> AMD bundle...
enable tests using es<latest> amd bundle..
42
false
false
6
true
true
true
emberjs
ember.js
5,604
7087b9d702529f7500b9678dcb717c76923321b3
Robert Jackson
Robert Jackson
Emit an ES<latest> AMD bundle (for testing).
emit an es<latest> amd bundle (for testing)
43
false
false
7
false
true
false
emberjs
ember.js
5,605
5296270867c9b9d8128680c59cf49d30bf019051
Robert Jackson
Robert Jackson
Add simple to-named-amd utility.
add simple to-named-amd utility
31
false
false
4
false
false
false
emberjs
ember.js
5,606
30ffe1a92413e6d5e3660edd77a70530b3a5113f
Robert Jackson
Robert Jackson
Add utility function to allow generating `ember-env-flags` module. This is generally not a module that is expected to exist in an app, but while working on "non-transpiled ES<latest> in AMD modules" we need the imports to resolve to _something_...
add utility function to allow generating `ember-env-flags` module
65
false
false
8
true
true
false
emberjs
ember.js
5,607
9203fbb835b4d02236146dd1fbb003a94bd14ecb
Robert Jackson
Robert Jackson
Rename local variable to `concatBundle`. Does more than "just" concat, lets make it clearer...
rename local variable to `concatbundle`
39
false
false
5
false
true
false
emberjs
ember.js
5,608
82b74dd15d1292406bed82ede945079bc31af6f3
Robert Jackson
Robert Jackson
Emit loose modules into `dist/es` (leave other output alone).
emit loose modules into `dist/es` (leave other output alone)
60
false
false
9
true
true
false
emberjs
ember.js
5,609
3fdcb70d966b3b515a4fa63654a45805b3a68915
Kris Selden
Robert Jackson
es6
es6
3
false
false
1
false
false
false
emberjs
ember.js
5,610
8678d54722064c9d771062bca3826b5fbc613d25
benjaminJ
benjaminJ
[CLEANUP beta] Use HtmlSafe to fix the "Binding style attribute" warning
[cleanup beta] use htmlsafe to fix the "binding style attribute" warning
72
false
false
11
false
false
false
emberjs
ember.js
5,611
a4d34eff8587a03630097d48d1da9830f8592d73
Ricardo Mendes
GitHub
Merge pull request #16415 from bekzod/mandatory-setter-condition move `MANDATORY_SETTER` related things to its conditional in meta
merge pull request from bekzod/mandatory-setter-condition
58
true
false
5
true
false
false
emberjs
ember.js
5,612
5318a261473fca42441e9a5bbe357bb119327b0b
Robert Jackson
GitHub
Merge pull request #16418 from bekzod/remove-compare-check remove redundant existence checks
merge pull request from bekzod/remove-compare-check
52
true
false
5
true
false
false
emberjs
ember.js
5,613
7b9c1a19535eb334c9caf39bf6a946987c9582fe
bekzod
bekzod
remove redundant existence checks
remove redundant existence checks
33
false
false
4
true
true
true
emberjs
ember.js
5,614
df251349dbdf69184615e1a82fa59cf61c9b5f98
bekzod
bekzod
move `MANDATORY_SETTER` related things to conditional in meta
move `mandatory_setter` related things to conditional in meta
61
false
false
8
true
true
false
emberjs
ember.js
5,615
b021c157c4a92dcf6c00f7e3ff67ea1114a8f4af
Godfrey Chan
GitHub
Merge pull request #16409 from emberjs/refactor-each-tests Refactor each tests
merge pull request from emberjs/refactor-each-tests
52
true
false
5
true
false
false
emberjs
ember.js
5,616
6d64f3b48811efe4ed961c63e1afb673621edf22
Godfrey Chan
Godfrey Chan
Add tests for native Set
add tests for native set
24
false
false
5
true
true
true
emberjs
ember.js
5,617
5cc0de8202f358e69bc17c0b05886f0ec56d47a4
Martin Muñoz
GitHub
Merge pull request #16416 from bekzod/remove-listener-callback remove support for `didRemoveListener` and `didAddListener`
merge pull request from bekzod/remove-listener-callback
56
true
false
5
true
false
false
emberjs
ember.js
5,618
2df4eb7cca00078935e6ac291f9b87f44df499b0
bekzod
bekzod
remove support for `didRemoveListener` and `didAddListener`
remove support for `didremovelistener` and `didaddlistener`
59
false
false
6
true
true
false
emberjs
ember.js
5,619
93fdd6b00a049914aaba88a9dc570c5798d26e92
Robert Jackson
GitHub
Merge pull request #16414 from runspired/master [BUGFIX] downgrade broccoli-merge-trees to 2.x due to 3.x node-6 dependency
merge pull request from runspired/master
41
true
false
5
true
true
false
emberjs
ember.js
5,620
8c9760016dabdbdeb3e092e3a9a03a3ece583948
Chris Thoburn
Chris Thoburn
[BUGFIX] downgrade broccoli-merge-trees to 2.x due to fs-updater dependency on node 6
[bugfix] downgrade broccoli-merge-trees to 2.x due to fs-updater dependency on node 6
85
false
false
12
false
false
false
emberjs
ember.js
5,621
f45c1f2023a14dec44b6db680a49b7c82b94344b
Robert Jackson
GitHub
Merge pull request #16412 from rwjblue/remove-build-time-linting Remove build time linting.
merge pull request from rwjblue/remove-build-time-linting
58
true
false
5
true
false
false
emberjs
ember.js
5,622
ed27baafef1ce299e624b6c7acb36d1f9d476230
Robert Jackson
Robert Jackson
Remove build time linting. We have a specific CI build that runs eslint, tsc, and tslint. Doing this also in the build has turned out to be expensive and needlessly bloat the final browser builds (which has a direct impact on IE11 test run times)...
remove build time linting
25
false
false
4
true
false
true
emberjs
ember.js
5,623
59bdea74e8f782c25f156bd748ca88facb001cd4
Robert Jackson
GitHub
Merge pull request #16411 from chilicoder/fix-delete-vscode-settings deleted .vscode folder
merge pull request from chilicoder/fix-delete-vscode-settings
62
true
false
5
true
false
false
emberjs
ember.js
5,624
eeb9406213b71d187ecbc7e4ecd3a69976882b0b
Iaroslav Popov
Iaroslav Popov
deleted .vscode folder
deleted .vscode folder
22
false
false
3
false
false
false
emberjs
ember.js
5,625
04000b0d4862ebc3b78b4babb5b6a559dd0cb2b9
Godfrey Chan
Godfrey Chan
Refactor each tests, merging single and multi each tests Resolves a TODO, so that tests using multiple `{{#each}}` helpers are testing against all the different array-like objects.
refactor each tests, merging single and multi each tests
56
false
false
9
false
true
false
emberjs
ember.js
5,626
3ad9c4d6d8bde4b615591a8a8ae1d03a09a5674b
Kris Selden
GitHub
Merge pull request #16354 from bekzod/avoid-creating-seen-map avoid creating `Map` in `dependentKeysDidChange`
merge pull request from bekzod/avoid-creating-seen-map
55
true
false
5
true
false
false
emberjs
ember.js
5,627
a9ac71755b76e464ced3ec91eb88850e2f9d1c94
Kris Selden
GitHub
Merge pull request #16358 from bekzod/reuse-build-mixin reuse mixin array build logic
merge pull request from bekzod/reuse-build-mixin
49
true
false
5
true
false
false
emberjs
ember.js
5,628
d49f3edea0229d17c2ecd610d6d3b386a6a4310a
Kris Selden
GitHub
Merge pull request #16359 from bekzod/cleanup-unwatch-key cleanup `watch` methodes
merge pull request from bekzod/cleanup-unwatch-key
51
true
false
5
true
false
false
emberjs
ember.js
5,629
0bc178ba2e91603e03f12c17758c3f7d3c35cda6
Kris Selden
GitHub
Merge pull request #16407 from bekzod/cleanup-array avoid iteration when possible in `each_proxy`
merge pull request from bekzod/cleanup-array
45
true
false
5
true
false
false
emberjs
ember.js
5,630
87980e24a49c46cea29c08b76a90a3bc979f54e6
bekzod
bekzod
avoid iteration when possible in `each_proxy`
avoid iteration when possible in `each_proxy`
45
false
false
6
true
true
true
emberjs
ember.js
5,631
9da6134b21e4e1ae2160f3a4b013f1f652b3e280
Robert Jackson
GitHub
Merge pull request #16393 from Draggha/test-output-cleanup [CLEANUP beta] #16391 Cleaning up the test output
merge pull request from draggha/test-output-cleanup
52
true
false
5
true
true
false
emberjs
ember.js
5,632
ba72780ac91fc94e57942bdc0ee3187d198d9dae
Robert Jackson
GitHub
Merge pull request #16396 from KamiKillertO/cleanup-test-output [CLEANUP beta] #16391 Cleaning up the test output
merge pull request from kamikillerto/cleanup-test-output
57
true
false
5
true
false
false
emberjs
ember.js
5,633
57494d764c4944b1bfa083809db4447930991083
Robert Jackson
GitHub
Merge pull request #16401 from Draggha/test-output-cleanup-banner [CLEANUP beta] #16391 Cleaning up the test output
merge pull request from draggha/test-output-cleanup-banner
59
true
false
5
true
true
false
emberjs
ember.js
5,634
bb5ca5319a77d16577e62d41f1a9826e39f6d955
Robert Jackson
GitHub
Merge pull request #16402 from Draggha/test-output-cleanup-deprecation [CLEANUP beta] #16391 Cleaning up the test output
merge pull request from draggha/test-output-cleanup-deprecation
64
true
false
5
true
true
false
emberjs
ember.js
5,635
5d78a27ab2781103c6f1616775436af709620625
Kris Selden
GitHub
Merge pull request #16405 from emberjs/update-deps Update deps
merge pull request from emberjs/update-deps
44
true
false
5
true
false
false
emberjs
ember.js
5,636
123d60d697d35e05a03c27159c3b47ea4c521a78
Kris Selden
Kris Selden
up IE session timeout to 25 min
up ie session timeout to 25 min
31
false
false
7
false
false
false
emberjs
ember.js
5,637
9579cad57ad3c1dea32c8cfac84e968a7bd5f72a
Kris Selden
Kris Selden
fix broken imports
fix broken imports
18
false
false
3
true
true
true
emberjs
ember.js
5,638
d8e187a7fb1a14391184b1db3213f526670c7f2a
Kris Selden
Kris Selden
Fix types
fix types
9
false
false
2
true
true
false
emberjs
ember.js
5,639
c4e8f12c5a91136da43434761d2da5c8d3bf3220
Kris Selden
Kris Selden
update things add prettierrc
update things
13
false
false
2
true
true
false
emberjs
ember.js
5,640
c2e1f40ca962a04aaaef2078fe2ae2fe9f29191f
Kris Selden
GitHub
Merge pull request #16399 from emberjs/iterable-refactor Iterable refactor
merge pull request from emberjs/iterable-refactor
50
true
false
5
true
false
false
emberjs
ember.js
5,641
bec7eb6f5fd4609fa19b2962f2d8623083c5759d
Martin Muñoz
GitHub
Merge pull request #16406 from bekzod/watch-docs add small doc for `unwatch`
merge pull request from bekzod/watch-docs
42
true
false
5
true
false
false
emberjs
ember.js
5,642
97ed5c28a1d4fe4dbeee6cb2de3931f725dfbdd2
bekzod
bekzod
add small doc for `unwatch`
add small doc for `unwatch`
27
false
false
5
true
true
true
emberjs
ember.js
5,643
e9a88e9816c35ade7c6e88ac29ca8e699036edc0
Robert Jackson
GitHub
Merge pull request #16404 from rondale-sc/evented-on-proxyish-objects [BUGFIX beta] Add exception for `didRemoveListener` so evented proxy objects can
merge pull request from rondale-sc/evented-on-proxyish-objects
63
true
false
5
true
false
false
emberjs
ember.js
5,644
77d1fdc3000c3aa2a84ec8075407bae6b6b36ecb
Jonathan Jackson
Jonathan Jackson
Add exception for `didRemoveListener` so evented proxy objects can function When `off` is called on an Evented proxyish object it checks to see if didRemoveListener is a function (so that it can later call it). This check triggers the assertion for proxy-ish objects to use `get` rather than installed es5-getter so we add a special case to allow it. Prior to this change when you called `off` on the proxyish object it would trigger an assertion telling you to call `eventedProxyObj.get('didRemoveListener') rather than `eventedProxyObj.didRemoveListener`. A few notes about this test: - the unknownProperty is how we let ember know this is a proxy - the unknownProperty function must return a value other than undefined - Evented Mixin must be mixed in
add exception for `didremovelistener` so evented proxy objects can
66
false
false
9
true
true
false
emberjs
ember.js
5,645
f4c336287cd0707455364f9868d826eab86144a0
benjaminJ
benjaminJ
[CLEANUP beta] Fix tests by adding missing call to super.afterEach
[cleanup beta] fix tests by adding missing call to super.aftereach
66
false
false
10
false
false
false
emberjs
ember.js
5,646
6ee886ba609f3fb3bada12c2b09b2ff88d155db7
Robert Jackson
GitHub
Merge pull request #16398 from emberjs/acorncom-patch-1 [DOCS Beta] Tweaked the url for the Ember Inspector
merge pull request from emberjs/acorncom-patch-1
49
true
false
5
true
false
false
emberjs
ember.js
5,647
1d0ef5f60647b07d49509dea80b1d86a9416900c
Godfrey Chan
Godfrey Chan
Refactor ember-glimmer iterables - Merge native iterable tests to use shared test cases - Refactor iterable implementations, fix missing/wrong types and type errors - Introduce `key="@key"` for `{{#each-in}}` (the default) - Make `key="@index"` actually use the index in `{{#each-in}}` - Add support for native iterables and `forEach` in `{{#each-in}}`
refactor ember-glimmer iterables
32
false
false
3
false
false
false
emberjs
ember.js
5,648
e03af05b82ea2ed643a12468d85270856f20281f
Johann Haaf
Johann Haaf
[CLEANUP beta] #16391 Cleaning up the test output solves the task: `DEPRECATION: Should not throw [deprecation id: test]`
[cleanup beta] cleaning up the test output
43
false
false
7
false
false
false
emberjs
ember.js
5,649
3f5584ef45e4e3998ed4e2aa30fe40036471a0db
cibernox
Godfrey Chan
Allow {{each}} to handle iterables on browsers that support them The requirement is that they support `Symbol.iterator`. The browsers that don't support are Internet Explorer and phantomjs, every other browser does. One caveat of this feature is that iterables are not observables, so each cannot track updates to them, but the code is structured on a way that this branch is a fallback, so all special cases where KVO is possible are handled as they where before.
allow {{each}} to handle iterables on browsers that support them
64
false
false
10
false
true
false
emberjs
ember.js
5,650
398d334b0bad80b4f982ab1460cf8116c515460d
Johann Haaf
Johann Haaf
[CLEANUP beta] #16391 Cleaning up the test output solves the task: `the library version banner on app boot`
[cleanup beta] cleaning up the test output
43
false
false
7
false
false
false
emberjs
ember.js
5,651
95903bffe926644fefa7f348b1fd7080da5b9488
Robert Jackson
GitHub
Merge pull request #16384 from emberjs/locks-patch-1 Turn ember-template-block-let-helper feature flag on by default
merge pull request from emberjs/locks-patch-1
46
true
false
5
true
false
false
emberjs
ember.js
5,652
57999530943fe09a9dc16761e3dd4104f8aa856b
benjaminJ
benjaminJ
[CLEANUP beta] Override console.error in tests Bring back console.error in `ember-testing/lib/test/adapter`. Instead override `console.error` with a noop function in tests
[cleanup beta] override console.error in tests
46
false
false
6
false
false
false
emberjs
ember.js
5,653
b1e3cac12d23f931ce6831a400149505b5213f1a
Johann Haaf
Johann Haaf
[CLEANUP beta] #16391 Cleaning up the test output solves the task "Testing paused. Use resumeTest() to continue."
[cleanup beta] cleaning up the test output
43
false
false
7
false
false
false
emberjs
ember.js
5,654
664272fd422764ac9129263ea0793f845919a3dd
Johann Haaf
Johann Haaf
[CLEANUP beta] #16391 Cleaning up the test output solves the task "WARNING: Library "magic" is already registered with Ember."
[cleanup beta] cleaning up the test output
43
false
false
7
false
false
false
emberjs
ember.js
5,655
0b81f52f76e328a29ab9e2260374f4f55744a260
David Baker
GitHub
[DOCS Beta] Tweaked the url for the Ember Inspector
[docs beta] tweaked the url for the ember inspector
51
false
false
9
false
false
false
emberjs
ember.js
5,656
83230807e9fa17fcb3bde8b6cf2db2913bc5b767
benjaminJ
benjaminJ
[CLEANUP beta] #16391 Cleaning up the test output Remove console error `Error: Element .does-not-exist not found.`
[cleanup beta] cleaning up the test output
43
false
false
7
false
false
false
emberjs
ember.js
5,657
614c1db7a81d90c2db336717668f85a8ed1fced1
Robert Jackson
GitHub
Merge pull request #16392 from emberjs/array-cleanup [CLEANUP] Refactor some array stuff
merge pull request from emberjs/array-cleanup
46
true
false
5
true
false
false
emberjs
ember.js
5,658
d80943f8173f35b74f9483cb32e66341653109cd
Kris Selden
GitHub
Merge pull request #16388 from emberjs/glimmer-vm-bump Bump glimmer-vm
merge pull request from emberjs/glimmer-vm-bump
48
true
false
5
true
false
false
emberjs
ember.js
5,659
f6ec14aaa33a5c3aff1853b7c9b6ae0277db59e5
Martin Muñoz
Martin Muñoz
Refactor objectAt and replace implementations
refactor objectat and replace implementations
45
false
false
5
false
false
false
emberjs
ember.js
5,660
545a5c3d111e0023e83c976f54395724fef5eb0a
Kris Selden
Kris Selden
bump glimmer-vm
bump glimmer-vm
15
true
false
2
true
false
false
emberjs
ember.js
5,661
4eff18ae2cdc40e9b39e885261f0646744260166
Robert Jackson
GitHub
Merge pull request #16387 from runspired/assert-send-on-destroy [FEAT] assert that actions cannot be sent from a destroyed/destroying object
merge pull request from runspired/assert-send-on-destroy
57
true
false
5
true
false
false
emberjs
ember.js
5,662
6b2981569b3a015ac17ef764a424e3cdfd2f0d25
bekzod
bekzod
avoid creating `Map` in `dependentKeysDidChange`
avoid creating `map` in `dependentkeysdidchange`
48
false
false
5
false
false
false
emberjs
ember.js
5,663
27de208c87685aa3ea4e51ac967d23da15e0181c
Martin Muñoz
Martin Muñoz
Move array internals to ember-metal
move array internals to ember-metal
35
false
false
5
true
true
true
emberjs
ember.js
5,664
39bbf0bef63f4f6a106c6dcf0c23da231c8f3564
Stefan Penner
GitHub
Merge pull request #16386 from runspired/assert-transitions-on-destroy [FEAT] assert transitions on destroyed app instances
merge pull request from runspired/assert-transitions-on-destroy
64
true
false
5
true
false
false
emberjs
ember.js
5,665
283a339b36f22c39834ff13e0dd5b39e7f8d792c
Chris Thoburn
Chris Thoburn
Make tests follow a natural app flow
make tests follow a natural app flow
36
false
false
7
false
true
false
emberjs
ember.js
5,666
99b0c0a73141ea520369652f0e83be2a5df480fa
Chris Thoburn
Chris Thoburn
fix destroy in test
fix destroy in test
19
false
false
4
false
true
false
emberjs
ember.js
5,667
c9e5969a6688b7727cb76298386298d4d980c9b1
Kris Selden
Kris Selden
make simple-html-tokenizer resolve from @glimmer/syntax this makes yarn linking @glimmer/syntax easier
make simple-html-tokenizer resolve from @glimmer/syntax
55
false
false
5
false
false
false
emberjs
ember.js
5,668
246e16aa99673003a6010d3ab9d21d123c289436
Chris Thoburn
Chris Thoburn
[FEAT] assert transitions on destroyed app instances
[feat] assert transitions on destroyed app instances
52
false
false
7
false
false
false
emberjs
ember.js
5,669
e00f26a5cb34be0f47b95fef4de159c4df35f38a
Chris Thoburn
Chris Thoburn
[FEAT] assert-send-on-destroy
[feat] assert-send-on-destroy
29
false
false
2
false
false
false
emberjs
ember.js
5,670
87f43e40b2cdc5ce4f105aed259ad486b3ae0d13
Robert Jackson
GitHub
Merge pull request #16293 from jamescdavis/ignore-pod-for-addon-helper-initializer-instance-initializer [BUGFIX release] Ignore --pod for -addon blueprints: helper, initializer, and instance-initializer
merge pull request from jamescdavis/ignore-pod-for-addon-helper-initializer-instance-initializer
97
true
false
5
true
false
false
emberjs
ember.js
5,671
4fe25d0783fac06bc2f9957358b1ff31c9a4d3ba
Robert Jackson
GitHub
Merge pull request #16378 from thoov/update-ember-metal-tests [CLEANUP] Convert ember-metal tests over to new style
merge pull request from thoov/update-ember-metal-tests
55
true
false
5
true
false
false
emberjs
ember.js
5,672
6a990add2f26f7acc11fb44867c51180ac51f03e
Ricardo Mendes
GitHub
[FEATURE] Turn ember-template-block-let-helper feature flag on by default
[feature] turn ember-template-block-let-helper feature flag on by default
73
false
false
8
false
false
false
emberjs
ember.js
5,673
ba736db6872866c05cbe738f2ae5bc8c08bdfaeb
Martin Muñoz
GitHub
Merge pull request #16357 from bekzod/use-set-for-mixins store mixins in set
merge pull request from bekzod/use-set-for-mixins
50
true
false
5
true
false
false
emberjs
ember.js
5,674
94f2a46d64d3c12fdeb9425a6062f480da990a22
Robert Jackson
GitHub
Merge pull request #16383 from rwjblue/update-yarn-lock Update glimmer-vm packages in yarn.lock.
merge pull request from rwjblue/update-yarn-lock
49
true
false
5
true
false
false
emberjs
ember.js
5,675
3d20dac232b6ef066480e017aa6bcb9ecd5e84a1
Robert Jackson
GitHub
Merge pull request #16382 from rwjblue/bring-back-bb-update-again Upgrade backburner.js to 2.2.2.
merge pull request from rwjblue/bring-back-bb-update-again
59
true
false
5
true
false
false
emberjs
ember.js
5,676
aa9baa559f78fcbaa63cfdac92d804695855fdf5
Robert Jackson
GitHub
Merge pull request #16312 from cibernox/rename-private-property-route.router [BUGFIX beta] Rename private property Route#router to Router#_router
merge pull request from cibernox/rename-private-property-route.router
70
true
false
5
true
false
false
emberjs
ember.js
5,677
02d6d9d4a237e15bbd4d970e9594cca3fb783bb8
Robert Jackson
Robert Jackson
Update glimmer-vm packages in yarn.lock. The last glimmer-vm upgrade did not properly update the yarn.lock, this brings yarn.lock back in sync with package.json.
update glimmer-vm packages in yarn.lock
39
false
false
5
false
false
false
emberjs
ember.js
5,678
4feeed7daeb442b9575603d5f48a32c9f786cd8f
Robert Jackson
Robert Jackson
Upgrade backburner.js to 2.2.2. Upstream issue causing revert of 2.2.0 and 2.2.1 has been addressed, this updates to the fixed version 2.2.2. Once landed, further testing can be done..
upgrade backburner.js to 2.2.2
30
false
false
4
true
true
true
emberjs
ember.js
5,679
4690f6363cffbe4c2960300fbb224b457434bd56
cibernox
cibernox
Rename private property Route#router to Router#_router The fact that this private property was named router was preventing user from injecting the router service into routes like this: ```js export default Route.extend({ router: service() }); ``` I consider that the above code is pretty reasonable, and it should be the private property the one that should be renamed to a clearer `_router` name that is less likely to collide with user-defined properties or methods. If you deem this an _intimate_ API we could consider adding a deprecated alias, but I don't have evidence to consider it such, as `router` is too common of a term to search for in emberobserver.
rename private property route#router to router#_router
54
false
false
6
false
true
false
emberjs
ember.js
5,680
963277e6c8f8ebbf08ea415f5d7ab1da6e3541a5
Robert Jackson
GitHub
Merge pull request #16352 from rwjblue/cleanup [BUGFIX beta] Avoid allocating wastefully in lookup.
merge pull request from rwjblue/cleanup
40
true
false
5
true
false
false
emberjs
ember.js
5,681
10ea169c71958131fe23c297e20c186e9e4bd1a8
Robert Jackson
GitHub
Merge pull request #16362 from bekzod/fix-meta-usage correct usage of `meta` property in `tagForProperty`
merge pull request from bekzod/fix-meta-usage
46
true
false
5
true
false
false
emberjs
ember.js
5,682
7f77a6f0268bf716ad2154c8b8a67e19c11c2845
Robert Jackson
GitHub
Merge pull request #16375 from Turbo87/remove-test-helper Remove obsolete `test-helper` blueprint
merge pull request from turbo87/remove-test-helper
51
true
false
5
true
false
false
emberjs
ember.js
5,683
96b732d435ae6a4e12e75146e75eb4fd802fa271
Robert Jackson
GitHub
Merge pull request #16380 from emberjs/revert-16348-update-bb Revert "Update to backburner.js@2.2.1."
merge pull request from emberjs/revert-16348-update-bb
55
true
false
5
true
true
false
emberjs
ember.js
5,684
764f6242f8a9eb3e413271b3fd4cb8b6e3c4946c
Edward Faulkner
GitHub
Revert "Update to backburner.js@2.2.1."
revert "update to backburner.js@2.2.1."
39
false
false
4
false
true
false
emberjs
ember.js
5,685
ce4065d4e5f0473eac3b3fa99be663f880f053c4
Travis Hoover
Travis Hoover
[CLEANUP] Convert ember-metal tests over to new style Apart of #15988
[cleanup] convert ember-metal tests over to new style
53
false
false
8
false
false
false
emberjs
ember.js
5,686
dc478b3bd0b7ef5f36f3fccf94f1dc97174e5b8c
Tobias Bieniek
Tobias Bieniek
Remove obsolete `test-helper` blueprint registerAsyncHelper() is no longer a thing with the new APIs and having this blueprint generate something outdated seems bad :-/
remove obsolete `test-helper` blueprint
39
false
false
4
false
false
false
emberjs
ember.js
5,687
5a59eef5e6eb34001f8d002e1f8bc146d8d3f86f
Robert Jackson
GitHub
Merge pull request #16374 from scalvert/idiomatic-bitwise Changing bitwise evaluation to use more idiomatic pattern
merge pull request from scalvert/idiomatic-bitwise
51
true
false
5
true
false
false
emberjs
ember.js
5,688
b8b37dbb88ba355325f9b8f390870a2984a77444
scalvert
scalvert
Changing bitwise evaluation to use more idiomatic pattern
changing bitwise evaluation to use more idiomatic pattern
57
false
false
8
false
false
false
emberjs
ember.js
5,689
dd933614629d1ac5cf118181661392faabb53641
Robert Jackson
GitHub
Merge pull request #16366 from emberjs/tracked Add tracked properties behind a feature flag
merge pull request from emberjs/tracked
40
true
false
5
false
true
false
emberjs
ember.js
5,690
a45620062bc832082eedd4ea062452c630288d69
Chad Hietala
Chad Hietala
Skip test. The `todo` fails the build
skip test. the `todo` fails the build
37
false
false
7
false
true
false
emberjs
ember.js
5,691
66c39c2f1888c6533f0d807d7f4804ec2bfbcb65
Katie Gengler
Katie Gengler
Add v3.1.0-beta.5 to CHANGELOG [ci skip] (cherry picked from commit 8f395f06a2b6140ecfa326945bf657c040a1a6f9)
add v3.1.0-beta.5 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
5,692
5431f71df060e7b5c82c05c300f40e9151d135e8
Godfrey Chan
Katie Gengler
[DOCS beta] debug functions are removed from prod build in apps Also better document the intent and caveats of using assertions. (cherry picked from commit c96b801371b3e366cd770dc1d9ef15d8cad6bfa6)
[docs beta] debug functions are removed from prod build in apps
63
false
false
11
false
false
false
emberjs
ember.js
5,693
0931537834a63d5392a9115f77dd47e8e3320d88
Robert Jackson
GitHub
Merge pull request #16365 from mani-mishra/fix_trap_properties_together [BUGFIX release] Fold all trap methods together
merge pull request from mani-mishra/fix_trap_properties_together
65
true
false
5
true
false
false
emberjs
ember.js
5,694
b008da70c526b1c29d384b869aca47d27a9bccc5
Mani Mishra
Mani Mishra
[BUGFIX release] Fold all trap methods together
[bugfix release] fold all trap methods together
47
false
false
7
false
false
false
emberjs
ember.js
5,695
5be557aec3f11bb84f4bc5bb1bb1bdbbfeae7ab2
Martin Muñoz
GitHub
Merge pull request #16363 from bekzod/weakset add weakset polyfill
merge pull request from bekzod/weakset
39
true
false
5
true
false
false
emberjs
ember.js
5,696
06c40663a22e1a225d3308fd35487b27bdeef83d
bekzod
bekzod
add weakset polyfill
add weakset polyfill
20
false
false
3
true
true
true
emberjs
ember.js
5,697
ebd5b4b7aed820058539c7d314bcaa5c27da725f
bekzod
bekzod
correct usage of `meta` property in `tagForProperty`
correct usage of `meta` property in `tagforproperty`
52
false
false
7
false
false
false
emberjs
ember.js
5,698
b2fc87ee1184c9aa8a9960758ae6a023e65ae91d
Yehuda Katz
Godfrey Chan
Add tracked properties behind a feature flag
add tracked properties behind a feature flag
44
false
false
7
true
true
true
emberjs
ember.js
5,699