sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
f470727be3319f22ea2407117ad7e756d15460e7 | Robert Jackson | Robert Jackson | [BUGFIX release] Update to router_js@2.0.0-beta.2.
Main changes:
* ES6ify a few classes.
* Fix issue when calling `.replaceWith` when the current transition is also
a `.replaceWith` (previously this would surprisingly result in a
`.transitionTo` _not_ a replace).
[Full
changelog](https://github.com/tildeio/router.js/compare/v2.0.0-beta.1...v2.0.0-beta.2) | [bugfix release] update to router_js@2.0.0-beta.2 | 49 | false | false | 5 | false | false | false | emberjs | ember.js | 5,800 |
af48b4e02763ecf383be71266e3418a6ee0e1f52 | Robert Jackson | GitHub | Merge pull request #16285 from rwjblue/more-version-fixes
[BUGFIX beta] Fix version with many special chars. | merge pull request from rwjblue/more-version-fixes | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 5,801 |
f1176f6b32c0bf14e812ec540d52b7bf441b9dc9 | Robert Jackson | GitHub | Merge pull request #16286 from rwjblue/update-glimmer-vm
[BUGFIX beta] Update to glimmer-vm@0.32.1. | merge pull request from rwjblue/update-glimmer-vm | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 5,802 |
5bb4b664e07eceeb5afb8b0eed10b2247461a815 | Robert Jackson | Robert Jackson | [BUGFIX beta] Update to glimmer-vm@0.32.1.
Fixes an issue with static numbers > 4000 being used in a template. | [bugfix beta] update to glimmer-vm@0.32.1 | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 5,803 |
2e99d1ff3b8a28f966b52c12cb5109b377216c10 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix version with many special chars.
The current sanitizer regexp works well when there is a single invalid
character, but does not handle the case where multiple invalid chars are
present (e.g. with a branch name of
`__DESCRIPTOR__-something__something/special`). | [bugfix beta] fix version with many special chars | 49 | false | false | 8 | false | false | false | emberjs | ember.js | 5,804 |
623336b579825932ce1b4875733d182a21c4b45e | Robert Jackson | GitHub | Merge pull request #16281 from lennyburdette/patch-1
fix(link-to): add id to "inactive loading state" warning | merge pull request from lennyburdette/patch-1 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 5,805 |
3f033531dd7cd60aa7777e4645b016bb442ed481 | Robert Jackson | GitHub | Merge pull request #16282 from emberjs/fix-nested-observerset-flushes
[BUGFIX beta] Fix nested ObserverSet flushes | merge pull request from emberjs/fix-nested-observerset-flushes | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 5,806 |
b6592149c7ca026ca758d2915b738cb15c140d6f | Martin Muñoz | Martin Muñoz | [BUGFIX beta] Fix nested ObserverSet flushes | [bugfix beta] fix nested observerset flushes | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 5,807 |
3509c99d6de5201cdb29dc4c267c60ed13f9801c | Lenny Burdette | GitHub | fix(link-to): add id to "inactive loading state" warning
Without an ID, this triggers an assertion with the message "When calling warn you must provide an options hash as the third parameter. options should include an id property." | add id to "inactive loading state" warning | 42 | false | false | 7 | true | true | true | emberjs | ember.js | 5,808 |
0e80c4056c63447f921f34d23428eaf77af4a057 | Robert Jackson | GitHub | Merge pull request #16279 from emberjs/better-eachComputedProperty
Improve eachComputedProperty implementation | merge pull request from emberjs/better-eachcomputedproperty | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 5,809 |
810c2c6a82ce797a6a9f3e397f4796c890e28b6b | Martin Muñoz | Martin Muñoz | Improve eachComputedProperty implementation | improve eachcomputedproperty implementation | 43 | false | false | 3 | true | true | true | emberjs | ember.js | 5,810 |
29b0f89a4c834d1126098a0b359131cce7116227 | Robert Jackson | GitHub | Merge pull request #16278 from bekzod/avoid-meta-for
avoid calling `metaFor` wherever possible | merge pull request from bekzod/avoid-meta-for | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 5,811 |
0ecfeccc2cd46857cabba774cc781bd66db631d9 | bekzod | bekzod | avoid calling `metaFor` wherever possible | avoid calling `metafor` wherever possible | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 5,812 |
acd4d22ce6c381865b8421ec0c714497f277c954 | Martin Muñoz | GitHub | Merge pull request #16277 from bekzod/remove-is-descriptor
remove redundant `this.isDescriptor` | merge pull request from bekzod/remove-is-descriptor | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 5,813 |
1c1f0d2113573b5e2f52e2733c08fb32750c2292 | bekzod | bekzod | remove redundant `this.isDescriptor` | remove redundant `this.isdescriptor` | 36 | false | false | 3 | false | true | false | emberjs | ember.js | 5,814 |
c9b68d122a221f6beed217a6a609991dbf534d72 | Robert Jackson | GitHub | Merge pull request #16274 from rwjblue/__descriptor__-opt-out
[BUGFIX beta] Ensure accessing a "proxy" itself does not error. | merge pull request from rwjblue/__descriptor__-opt-out | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 5,815 |
4e950a903043afd7d0f532bc0f9cbb4b98e32e5f | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure accessing a "proxy" itself does not error.
Prior to this change, if `Ember.get` (or `this.get`) is used to access a
property that is an Ember.Object with an `unknownProperty` that always
returns a non-`undefined` value, the internals of `Ember.get` would
check if that property is a "descriptor" and (due to the
`unknownProperty` never returning `undefined`) the dev time assertion
for accessing a proxy's content without using `Ember.get` would be
triggered. | [bugfix beta] ensure accessing a "proxy" itself does not error | 62 | false | false | 10 | false | false | false | emberjs | ember.js | 5,816 |
dc5c9eb6840bda133d34ea5ad94437cedb1f7d74 | Martin Muñoz | GitHub | Merge pull request #15962 from Exelord/fix-computed-setter-only
Allow to define only setter in computed property | merge pull request from exelord/fix-computed-setter-only | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 5,817 |
3a537b52a4336bc95c96dcbd316787d6864d95f1 | Robert Jackson | GitHub | Merge pull request #16272 from bekzod/weak-proxy
use `WeakMap` for marking proxy | merge pull request from bekzod/weak-proxy | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 5,818 |
94be7266d4afad87394a4857af65a57c2d3d452d | Maciej Kwaśniak | Maciej Kwaśniak | Allow to define only setter in computed property | allow to define only setter in computed property | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 5,819 |
2a7eda06ca48a5ea982cff8d4d3373ba5f998c97 | bekzod | bekzod | use `WeakMap` for marking proxy | use `weakmap` for marking proxy | 31 | false | false | 5 | false | true | false | emberjs | ember.js | 5,820 |
2973d1d67e6afaea5f4c36e597d42ce4341f12e2 | Martin Muñoz | GitHub | Merge pull request #16244 from kturney/expand-properties-doc-fix
[DOC release] fix documented module for expandProperties | merge pull request from kturney/expand-properties-doc-fix | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 5,821 |
3634b21fe6ea7ac4f1f14e5c5087ebb7e5bce229 | Martin Muñoz | GitHub | Merge pull request #15704 from bekzod/remove-redundant-logic
simplify `applyConcatenatedProperties` | merge pull request from bekzod/remove-redundant-logic | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 5,822 |
f9e51c9d9545d771ecccece90f426020a3bd2ab0 | Kyle Turney | Martin Muñoz | [DOC release] Fix expandProperties documentation | [doc release] fix expandproperties documentation | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 5,823 |
48c556444e0ac0cbbf232f7ae810b9d7d15f25f6 | Robert Jackson | GitHub | Merge pull request #16271 from emberjs/fix-chainnode-unchaining
[BUGFIX beta] Fix ChainNode unchaining | merge pull request from emberjs/fix-chainnode-unchaining | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 5,824 |
94f2b2f035ae623d743020b58a78ab95707d56db | Martin Muñoz | Martin Muñoz | [BUGFIX beta] Fix ChainNode unchaining | [bugfix beta] fix chainnode unchaining | 38 | false | false | 5 | false | false | false | emberjs | ember.js | 5,825 |
04ad41daa87bd94cd201800148bd15d1eeca2fd5 | Jonathan Jackson | Jonathan Jackson | `this.visit` since a new instance will be allocated because we destroyed
the application | `this.visit` since a new instance will be allocated because we destroyed | 72 | false | false | 11 | false | false | false | emberjs | ember.js | 5,826 |
c6386c043f1c8aafc858f1990da51b1b041c1ff1 | Jonathan Jackson | Jonathan Jackson | Remove unnecessary runTask | remove unnecessary runtask | 26 | false | false | 3 | true | true | true | emberjs | ember.js | 5,827 |
56cbef5c0d2660b5befdd4a0a588bfab87def008 | Jonathan Jackson | Jonathan Jackson | Use visit api to better ecapsulate serialize/rehydrate test
Formerly we were asserting on a string we manually created with
knowledge of the glimmer-vm encoding for both serialization and
rehydration.
This test now generates an application instance with the serialize
method and asserts that the first node is a node we know is set by
glimmer-vm serializer
Then we destroy that instance and create a new instance with the
rehydrate _renderMode that uses it to rehydrate the dom.
Thus we go through a closer to real-world scenario of serialization in
an SSR visit with _renderMode set appropriately, through visit with
an instance set to rehydrate the SSR generated content. | use visit api to better ecapsulate serialize/rehydrate test | 59 | false | false | 8 | true | true | false | emberjs | ember.js | 5,828 |
0627ae68cbbfbc7179f39ad0ed7eee670d5f371a | Jonathan Jackson | Jonathan Jackson | update serialized format to new glimmer-vm output
This is meant to be a temporary test. Want a more robust test that
doesn't rely on the actual serialization format of glimmer's serializer
builder | update serialized format to new glimmer-vm output | 49 | false | false | 7 | true | true | true | emberjs | ember.js | 5,829 |
882bbdd5df177fa4c9690679d91774e80bfbc269 | Jonathan Jackson | Jonathan Jackson | Ensure correct signature for renderMain | ensure correct signature for rendermain | 39 | false | false | 5 | true | true | true | emberjs | ember.js | 5,830 |
27f4e2def3f83128c97cfd519bca472efdc22a38 | Jonathan Jackson | Jonathan Jackson | Make _renderMode private | make _rendermode private | 24 | false | false | 3 | false | true | false | emberjs | ember.js | 5,831 |
ba8f62ba049a38809ab63b83176b26a83df32285 | Jonathan Jackson | Jonathan Jackson | Allow visit to specify Rehydration/Serialization or default
ClientBuilder
Expose as a configurable option the `renderMode` option. This option
would be to specify the clientBuilder to be used when Glimmer does it's
append run.
The serialization mode, used by SSR applications, is used to specify
additional markings necessary to get enough fidelity to accurately
rehydrate the DOM. For example, it would provide additional comment
nodes with codes to ensure text nodes are separated when they are rather
than merged.
The rehydration mode is specifically designed to read DOM that is
produced by the serialization mode and accurately reproduce it.
A great description of how Rehydration works can be found in this
commit:
https://github.com/glimmerjs/glimmer-vm/commit/316805b9175e01698120b9566ec51c88d075026a
This PR allows the appropriate ElementBuilder interface to be used via
the `visit` API.
Additional Work:
- Update Fastboot to pass the appropriate `renderMode` flag such that it
generates the serialization format DOM
- Update ember-cli-fastboot instance-initializer to not do a double boot
and instead configure it to use the rehydration `renderMode`
- See more information here:
https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/addon/instance-initializers/clear-double-boot.js
Open Questions:
- Is the `renderMode` flag Public API
- Should this be put behind a feature flag
- @rwjblue noted that this technically would be a bug fix as it would
remove the double render problem with SSR ember apps | allow visit to specify rehydration/serialization or default | 59 | false | false | 7 | false | true | false | emberjs | ember.js | 5,832 |
67bf23f2b0a9ed42bd6ccfcdb82aa9e89798bb52 | Martin Muñoz | GitHub | Merge pull request #16264 from emberjs/more-classes
Convert Descriptor and Alias to native classes | merge pull request from emberjs/more-classes | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 5,833 |
7703d4fd0b135fd6308c853fcc57306e0bb83e88 | Martin Muñoz | GitHub | Merge pull request #16265 from bekzod/to-class
convert `BootOptions` to class | merge pull request from bekzod/to-class | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 5,834 |
45b9f15b874068f2e8d6c8789602e697942c0f40 | Martin Muñoz | Martin Muñoz | Convert Descriptor and Alias to native classes | convert descriptor and alias to native classes | 46 | false | false | 7 | true | true | true | emberjs | ember.js | 5,835 |
4a912cd9f663dcf04cf99b50a6b332a3ac61f448 | bekzod | bekzod | convert `BootOptions` to class | convert `bootoptions` to class | 30 | false | false | 4 | false | true | false | emberjs | ember.js | 5,836 |
37d6bea2d9e410ca56e26f569ba7104e015cac62 | Sergio Arbeo | Matthew Beale | [BUGFIX] Don't use destroyApp if new API is being used
Fixes #16180 | [bugfix] don't use destroyapp if new api is being used | 54 | false | false | 10 | false | false | false | emberjs | ember.js | 5,837 |
673f9550049c6a8a80e6dcd42eb1a12e45c315e4 | Ricardo Mendes | GitHub | Merge pull request #16261 from GavinJoyce/gj/mu-component-blueprint-node-4
remove destructuring in MU component blueprint | merge pull request from gavinjoyce/gj/mu-component-blueprint-node-4 | 68 | true | false | 5 | true | true | false | emberjs | ember.js | 5,838 |
e7e2f28b2c5ca62f8f478440e724ecf0dc411411 | Gavin Joyce | Gavin Joyce | remove destructuring in MU component blueprint | remove destructuring in mu component blueprint | 46 | false | false | 6 | false | true | false | emberjs | ember.js | 5,839 |
4965ac76a3b367652403dc3e7d6d2d5ec86cc48d | Martin Muñoz | GitHub | Merge pull request #16260 from emberjs/computed-property-class
Migrate ComputedProperty and InjectedProperty to native classes | merge pull request from emberjs/computed-property-class | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 5,840 |
455c4c44410f55c2d77258934d903dcd3328782e | Katie Gengler | Katie Gengler | Add v3.1.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 0f8e2f4d823c590a76e0158960a8b05aeb5f64e1) | add v3.1.0-beta.2 to changelog | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 5,841 |
b0424f8caa4ab895b023de7dcff66a531eec7727 | bekzod | Martin Muñoz | Migrate ComputedProperty and InjectedProperty to native classes | migrate computedproperty and injectedproperty to native classes | 63 | false | false | 7 | false | true | false | emberjs | ember.js | 5,842 |
b05e16dc7e9f8b16b89163df1c0d5d9be3574b03 | Gavin Joyce | Matthew Beale | [Feature] added module-unification component blueprint | [feature] added module-unification component blueprint | 54 | false | false | 5 | false | false | false | emberjs | ember.js | 5,843 |
1f825d69aa3445938c2f928b4c06b5b13aa905f0 | Martin Muñoz | GitHub | Merge pull request #15701 from bekzod/non-enum-remove
remove `__defineNonEnumerable` | merge pull request from bekzod/non-enum-remove | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 5,844 |
5c4df8c76fce261a3f1ab688395670f3b73801b6 | bekzod | Martin Muñoz | remove `__defineNonEnumerable` | remove `__definenonenumerable` | 30 | false | false | 2 | false | true | false | emberjs | ember.js | 5,845 |
9300d1b7d3aa70987986b1997ecf02a542ea49be | Martin Muñoz | GitHub | Merge pull request #16137 from bekzod/convert-class
use es6 classes for `QueryParams` and `RouterState` | merge pull request from bekzod/convert-class | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 5,846 |
4a4c9cd20d46cf5e796251fabd481313ff2b3ff7 | Martin Muñoz | GitHub | Merge pull request #16185 from emberjs/fix-did-receive-attrs-in-es-class
Fix didReceiveAttrs in ES Class | merge pull request from emberjs/fix-did-receive-attrs-in-es-class | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 5,847 |
2cd6e2f6d570d2489322e317adcb52a0756372d3 | Yehuda Katz | Martin Muñoz | Run dRA after the constructor in ES classes
Running didReceiveAttrs inside of the base constructor means that it
runs before subclass constructors (and ES fields in subclasses) are run.
This commit moves didReceiveAttrs to the component manager (after
creating the component), which changes the order it runs in, and causes
it not to run when simply creating the component. | run dra after the constructor in es classes | 43 | false | false | 8 | true | true | true | emberjs | ember.js | 5,848 |
b054552efa344fbccac5a88a3f9a9f268280e99e | Christopher Garrett | Martin Muñoz | [TESTS es-classes] Adds a failing test for didReceiveAttrs
Adds a failing test for didReceiveAttrs in native classes. Class fields
will likely be the prefered way to initialize default values on class instances,
but because didReceiveAttrs is called in the base class constructor it is
initially called before class fields have had an opportunity to be setup. | [tests es-classes] adds a failing test for didreceiveattrs | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 5,849 |
ccce19bd0f069972c9e4deb9acbfdc716d815176 | Chad Hietala | GitHub | Merge pull request #16251 from emberjs/remove-ember-global-loc
Remove Ember global from ember-glimmer loc tests | merge pull request from emberjs/remove-ember-global-loc | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 5,850 |
01514cfa6c9de3592a3f2f38a0da5b02b62c1fd3 | Robert Jackson | GitHub | Merge pull request #16252 from emberjs/move-template-compiler-initializer
Move Globals Mode template compiler initializer | merge pull request from emberjs/move-template-compiler-initializer | 67 | true | false | 5 | true | false | false | emberjs | ember.js | 5,851 |
c8ff883b5b9dce80f1b1bd26000608a522765fc2 | Chad Hietala | Chad Hietala | Move Globals Mode template compiler initializer into ember-template-compiler | move globals mode template compiler initializer into ember-template-compiler | 76 | false | false | 8 | false | false | false | emberjs | ember.js | 5,852 |
6e01000e4002910ddc966de07714323c101b95af | Chad Hietala | Chad Hietala | Remove Ember global from ember-glimmer loc tests | remove ember global from ember-glimmer loc tests | 48 | false | false | 7 | true | true | true | emberjs | ember.js | 5,853 |
f4709408d200474ba7c8dc7e78c4369618a01568 | Robert Jackson | GitHub | Merge pull request #16249 from emberjs/remove-pragma
Remove glimmer pragma transform | merge pull request from emberjs/remove-pragma | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 5,854 |
52c48d08158857329e8bdd52873fefca32780057 | Chad Hietala | Chad Hietala | Remove custom manager test | remove custom manager test | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 5,855 |
908ca3231423cf298a12f2251bcd0808cd52630d | Chad Hietala | Chad Hietala | Remove glimmer pragma transform | remove glimmer pragma transform | 31 | false | false | 4 | false | true | false | emberjs | ember.js | 5,856 |
a7d5ed567e661a95c7ad40ccaf1c43644bd63d95 | Stefan Penner | GitHub | Merge pull request #13355 from rwjblue/fix-trySet
[BUGFIX beta] Fix issue with `Ember.trySet` on destroyed objects. | merge pull request from rwjblue/fix-tryset | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 5,857 |
5d6c25277b9943e8b1d42180ead32fb295175e64 | Robert Jackson | GitHub | Merge pull request #16246 from emberjs/fix-empty-sort-properties
[BUGFIX beta] computed.sort should not sort if sortProperties is empty | merge pull request from emberjs/fix-empty-sort-properties | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 5,858 |
7d0cfa2ec1a6637c143184b258c798198dc2b8e0 | Martin Muñoz | GitHub | Merge pull request #15449 from bekzod/rename-prop
rename `_watching` => `_isWatching` in `ChainNode` | merge pull request from bekzod/rename-prop | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 5,859 |
d3969de72bf176c11bf641e45d4addf747c1383c | Martin Muñoz | GitHub | Merge pull request #15993 from bekzod/cleanup-observer
removed `return this` in `lib/observer` | merge pull request from bekzod/cleanup-observer | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 5,860 |
1f4a3bc432ecc888290667fb582b18592794aa69 | Robert Jackson | Martin Muñoz | [BUGFIX beta] Fix issue with `Ember.trySet` on destroyed objects.
`Ember.trySet` is designed to be an error-tolerant form of `Ember.set`
(per its public API documentation). However, in some circumstances an
error is still thrown when setting on a destroyed object.
Prior to this change, the following would properly prevent an error:
```js
let obj = { some: { deep : 'path', isDestroyed: true }};
Ember.trySet(obj, 'some.deep', 'stuff');
```
But the following would throw an error incorrectly:
```js
let obj = { some: 'path', isDestroyed: true };
Ember.trySet(obj, 'some', 'stuff');
```
This fixes the latter case... | [bugfix beta] fix issue with `ember.tryset` on destroyed objects | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 5,861 |
e99dd8947d715898b505d6a47e15d32251bb14ad | Martin Muñoz | Martin Muñoz | [BUGFIX beta] computed.sort should not sort if sortProperties is empty | [bugfix beta] computed.sort should not sort if sortproperties is empty | 70 | false | false | 10 | false | false | false | emberjs | ember.js | 5,862 |
0bd4d998d7375e62e32cacea5bb241db03955760 | Martin Muñoz | GitHub | Merge pull request #16189 from bekzod/use-es6-class-for-bucket-cache
convert `BucketCache` to es6 class | merge pull request from bekzod/use-es6-class-for-bucket-cache | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 5,863 |
a4229ad212a380e6c5ef3f229f35a4cf5a57453d | Robert Jackson | GitHub | Merge pull request #16245 from rwjblue/more-error-recovery
[BUGFIX lts] Ensure errors in deferred component hooks can be recovered. | merge pull request from rwjblue/more-error-recovery | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 5,864 |
ab4a2e367f042e7b82cb62d740e9bf03637a1d62 | Robert Jackson | Robert Jackson | [BUGFIX lts] Ensure errors in deferred component hooks can be recovered.
Previously, any errors thrown during `didInsertElement` would leave the
running environment in an invalid state (`env.inTransaction` would be
`true` but `this._transaction` would have been nullified).
This commit ensures that we _always_ reset `inTransaction` if
`Environment.prototype.commit` is called. Thus avoiding an error RE:
"calling commit on null"... | [bugfix lts] ensure errors in deferred component hooks can be recovered | 71 | false | false | 11 | false | false | false | emberjs | ember.js | 5,865 |
9da3a7e6c517961ad8a074bb8807a30e4554c413 | Robert Jackson | GitHub | Merge pull request #16243 from rwjblue/remove-yuidoc-confusion
[DOC release] Fix issue with invalid YUIDoc parsing. | merge pull request from rwjblue/remove-yuidoc-confusion | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 5,866 |
a3ba91fe9fb5da384e6677a280bb0943ac1de250 | Robert Jackson | Robert Jackson | [DOC release] Fix issue with invalid YUIDoc parsing. | [doc release] fix issue with invalid yuidoc parsing | 51 | false | false | 8 | false | false | false | emberjs | ember.js | 5,867 |
f21a6cf48a4f77025984906955dd9aeb81032c47 | Robert Jackson | Robert Jackson | Post release version bump... | post release version bump.. | 27 | false | false | 4 | false | false | false | emberjs | ember.js | 5,868 |
b3786610acdad73be20092876bf60f0b17af83c3 | Robert Jackson | Robert Jackson | Add v3.1.0-beta.1 to CHANGELOG.md. | add v3.1.0-beta.1 to changelog.md | 33 | false | false | 4 | true | true | true | emberjs | ember.js | 5,869 |
1cd2c2e0ec9acacd2745987e8a63297a743d3fc9 | Aurelien 'Sol' Pieropan | Aurelien 'Sol' Pieropan | removed duplicate line in the Changelog | removed duplicate line in the changelog | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 5,870 |
080ba6643251209dd7f88974955aae5848bdc8e2 | Robert Jackson | Robert Jackson | Add v3.0.0 to CHANGELOG.md. | add v3.0.0 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 5,871 |
8222f4eafd2a1ff305cb1e465b359badb77097fb | Robert Jackson | Robert Jackson | Add v2.18.1 to CHANGELOG.md. | add v2.18.1 to changelog.md | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 5,872 |
5112d7a4443670dbf965432540a468dc59b4e850 | Robert Jackson | Robert Jackson | Add v2.17.1 to CHANGELOG.md
(cherry picked from commit 6e0b9fdec1b500050e117744e3d7216d21833833) | add v2.17.1 to changelog.md | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 5,873 |
85c78893f5ae84a8587755faa9f8c2d9073298c9 | Robert Jackson | Robert Jackson | Add v2.16.2 to CHANGELOG.md. | add v2.16.2 to changelog.md | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 5,874 |
8bd2be07262ed6e8bcd7c691cce25b872c3ea20c | Robert Jackson | GitHub | Merge pull request #16241 from rwjblue/be-less-stupid
[BUGFIX lts] Avoid excessively calling Glimmer AST transforms. | merge pull request from rwjblue/be-less-stupid | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 5,875 |
a95e31470a95bb8e1c8e74fac076f4d6d8eeae99 | Robert Jackson | Robert Jackson | [BUGFIX lts] Avoid excessively calling Glimmer AST transforms.
During the Ember 2.15 cycle glimmer-vm was updated and contained a new
format for AST plugins. This required that all "legacy" plugins be
wrapped (to avoid breakage of this intimate API). When the wrapping code
was implemented two distinct bugs were introduced that would have caused
custom AST transforms to be called many more times than in Ember < 2.15.
Bug #1: Accruing AST Transforms via re-registration
---------------------------------------------------
ember-cli-htmlbars allows addons to register AST plugins via the normal
ember-cli preprocessor registry system. When this support was added it
was not possible to provide plugins during a specific compilation, and
therefore all plugins are registered globally (even by current
ember-cli-htmlbars versions).
Due to the mechanism that ember-cli uses to build up the list of addons
and dependencies for use at build time ember-cli-htmlbars ends up
requiring the template compiler many times and subsequently registering
any AST transform plugins that are present using the exported
`registerPlugin` API. Since this tracks plugins in module state it is
possible to have `registerPlugin` called many times with the same
plugin. ember-cli-htmlbars attempts to mitigate the polution of plugins
by forcing the require.cache of the template compiler module to be
flushed. Unfortuneately, there are circumstances where this cache
invalidation doesn't work and we therefore grow the number of registered
AST plugins _very_ quickly (once for each nested addon / engine / app
that is in the project).
During the 2.15 glimmer-vm upgrade the previous deduping logic was
removed (due to the fact that "legacy" AST transforms were always
generating unique plugin instances). When combined with situations where
ember-cli-htmlbars was not properly clearing the require cache the
resulting build times of complex applications using AST plugins grew >
double.
Bug #2: Legacy AST Transform Compat Bug
---------------------------------------------------
In order to avoid breakage in addons leveraging the intimate AST plugin
APIs a wrapper layer was added. Unfortunately, the wrapper layer
assumed that there would only be a single `Program` node. However, in
glimmers AST every `BlockStatement` has a `Program` node (and _may_
have an inverse with another `Program` node). This mistake meant that
the legacy "wrapped" AST transforms would be instantiated and ran _many_
times per-template which generates quite a bit of wasted work.
Fixes Included
--------------
* Bring back the deduplication code ensuring that a given AST plugin is
only registered once.
* Fix the legacy AST transform wrapper code to _only_ instantiate and
invoke the legacy AST transform once for the outermost `Program` node. | [bugfix lts] avoid excessively calling glimmer ast transforms | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 5,876 |
35889593cb05d8934413be96efa31a375fd0b4e3 | Matthew Beale | Matthew Beale | Add referrer capability to the test resolver | add referrer capability to the test resolver | 44 | false | false | 7 | true | true | true | emberjs | ember.js | 5,877 |
6bf01d0391dfffb18e186bdc083c57cc819ce50f | Kris Selden | GitHub | Merge pull request #16225 from emberjs/glimmer-vm-bump
Update for glimmer-vm v0.32.0 | merge pull request from emberjs/glimmer-vm-bump | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 5,878 |
d51c363d93c6afab06842f64d0ff8c0f3a2081b9 | Kris Selden | Kris Selden | Update to latest glimmer-vm v0.32.0 | update to latest glimmer-vm v0.32.0 | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 5,879 |
8a002357625bbff85d6a83a45a705bd7a4b81ab5 | Robert Jackson | GitHub | Merge pull request #16237 from artemgurzhii/no-jquery
Drop jQuery usage from the packages/ember/tests | merge pull request from artemgurzhii/no-jquery | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 5,880 |
1364855dca0aa58025e3df3a1d70e6955cb0b4e3 | Kris Selden | GitHub | Merge pull request #16238 from emberjs/remove-old-school-suites
Remove Array Suites | merge pull request from emberjs/remove-old-school-suites | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 5,881 |
6fa227795a58822694f8bfbb14396a244b3d7d80 | Todd Jordan | GitHub | Merge pull request #16234 from toddjordan/remove-native-array-from-array-module
[doc beta] Reorder array code so native array is in ember module | merge pull request from toddjordan/remove-native-array-from-array-module | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 5,882 |
7c4e925553ac3a0bdfcc14ba44d19c5719ab6c95 | Chad Hietala | Chad Hietala | Fix failing tests | fix failing tests | 17 | false | false | 3 | true | true | true | emberjs | ember.js | 5,883 |
30702be41b358b5cb8e65f3c66bb484342003d56 | Chad Hietala | Chad Hietala | Kill Array Suites | kill array suites | 17 | false | false | 3 | true | true | true | emberjs | ember.js | 5,884 |
d962e6e9e941ca8c0abfdcec8341b749b34d1710 | Chad Hietala | Chad Hietala | Migrate shiftObject, unshiftObject, unshiftObjects | migrate shiftobject, unshiftobject, unshiftobjects | 50 | false | false | 4 | false | true | false | emberjs | ember.js | 5,885 |
0dd3ed07cd676b504316a59e7a4f1724984d721f | Chad Hietala | Chad Hietala | Migrate replace, reverseObject, setObjects | migrate replace, reverseobject, setobjects | 42 | false | false | 4 | false | true | false | emberjs | ember.js | 5,886 |
151616c94643701776358a79221c7d11096978c9 | Chad Hietala | Chad Hietala | Migrate removeAt, removeObject, removeObjects | migrate removeat, removeobject, removeobjects | 45 | false | false | 4 | false | true | false | emberjs | ember.js | 5,887 |
1cddb07f0ab9e0b2c9159da9164647ee2ad1009e | Chad Hietala | Chad Hietala | Migrate popObject, pushObject, pushObjects | migrate popobject, pushobject, pushobjects | 42 | false | false | 4 | false | true | false | emberjs | ember.js | 5,888 |
82573633a795ead5a175bf000678e72366cebdc9 | Chad Hietala | Chad Hietala | Migrate addObject, clear, insertAt | migrate addobject, clear, insertat | 34 | false | false | 4 | false | true | false | emberjs | ember.js | 5,889 |
1efdd9041fe6845ce380adc6c74341d6d40e20e9 | Chad Hietala | Chad Hietala | Migrate Copayable | migrate copayable | 17 | false | false | 2 | false | true | false | emberjs | ember.js | 5,890 |
e6b99f6f5fca3a53f77df6a2efdd35d24dbb4136 | Chad Hietala | Chad Hietala | Migrate toArray, uniq, uniqBy, without | migrate toarray, uniq, uniqby, without | 38 | false | false | 5 | false | true | false | emberjs | ember.js | 5,891 |
153774ae8fafb9b0156013e5c47a565caf449ce0 | Chad Hietala | Chad Hietala | Migrate reduce, reject, sortBy | migrate reduce, reject, sortby | 30 | false | false | 4 | false | false | false | emberjs | ember.js | 5,892 |
632d7b2b58b1ce1be8d9b899c690cc1aa6d9e319 | Chad Hietala | Chad Hietala | Migrate objectAt, map, mapBy | migrate objectat, map, mapby | 28 | false | false | 4 | false | true | false | emberjs | ember.js | 5,893 |
9b499e004eaee223c0bef96f339e0b081c311bed | Chad Hietala | Chad Hietala | Migrate isAny, lastIndex, lastObject | migrate isany, lastindex, lastobject | 36 | false | false | 4 | false | true | false | emberjs | ember.js | 5,894 |
e8715121faf109ec07409427ae54b1560f1dbd97 | Chad Hietala | Chad Hietala | Migrate includes, indexOf, invoke | migrate includes, indexof, invoke | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 5,895 |
fefa706fc6da2d5c3a6cbc36599610183ce9c6c2 | Chad Hietala | Chad Hietala | Migrate find, firstObject, forEach | migrate find, firstobject, foreach | 34 | false | false | 4 | false | true | false | emberjs | ember.js | 5,896 |
0e4d47a4fc2445964e43cb124250f2e2f691028d | Chad Hietala | Chad Hietala | Migrate filter and every | migrate filter and every | 24 | false | false | 4 | false | true | false | emberjs | ember.js | 5,897 |
ed8313fd2861e863a33e9886d8c92ecb9185f2c4 | Chad Hietala | Chad Hietala | Migrate any and compact | migrate any and compact | 23 | false | false | 4 | false | true | false | emberjs | ember.js | 5,898 |
e70650a2d8646dd0e06ad8304849eec090c1cc60 | Robert Jackson | GitHub | Merge pull request #16233 from toddjordan/remove-rogue-ember-refs-from-object-and-test
[doc beta] add ember module to namespaced classes so "Ember" doesn't show | merge pull request from toddjordan/remove-rogue-ember-refs-from-object-and-test | 80 | true | false | 5 | true | false | false | emberjs | ember.js | 5,899 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.