sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
a4d9579bc5a21e936a5262e3e3eb3339fe585bcb | Kris Selden | Kris Selden | compile-options should be a singleton across app and engines | compile-options should be a singleton across app and engines | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 6,700 |
29880cff9e475d475339d30142dbc2e6740b1723 | Kris Selden | Kris Selden | Workaround for qunit-fixture not having class=ember-application removed | workaround for qunit-fixture not having class=ember-application removed | 71 | false | false | 7 | false | false | false | emberjs | ember.js | 6,701 |
fadb79af811ec454ca7f5200cd8141ddb1b3c857 | Steven Footea | Steven Footea | WIP: Get curly components to render with class and id
The contents are not rendering at all, and a lot of the code is not
handling error cases. This is just to get the component to render at
all. | get curly components to render with class and id | 48 | false | false | 9 | false | true | false | emberjs | ember.js | 6,702 |
ede4b9065d9745ee5b0a256673713539e9214b11 | Robert Jackson | GitHub | Merge pull request #15875 from rwjblue/upgrade-backburner
Upgrade to backburner@1.3.1. | merge pull request from rwjblue/upgrade-backburner | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 6,703 |
c099fb0f9c58aa021c405f3b7cb9a7ca3a004985 | Robert Jackson | GitHub | Merge pull request #15871 from rwjblue/revert-14898
[BUGFIX lts] Refactor / fix error handling scenarios. | merge pull request from rwjblue/revert-14898 | 45 | true | false | 5 | true | true | false | emberjs | ember.js | 6,704 |
87efb0a1dd95d9fbfbc3d1b682b90bbaa4170d5c | Robert Jackson | GitHub | Merge pull request #15855 from bekzod/filter-computed-expand
[BUGFIX release] fix regression with computed `filter/map/sort` | merge pull request from bekzod/filter-computed-expand | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 6,705 |
601d03be0483f46508c9c0eeb3efa54fa2698c50 | Robert Jackson | Robert Jackson | Upgrade to backburner@1.3.1.
Includes a nice refactor to use a shared method for parsing the
arguments of `run`, `run.join`, `run.schedule`, etc.
Should make stepping through Backburner code a bit easier... | upgrade to backburner@1.3.1 | 27 | false | false | 3 | false | false | false | emberjs | ember.js | 6,706 |
b3ae3b2fbcc2a52509520dcb1369a1f00a155e0c | Robert Jackson | GitHub | Merge pull request #15858 from emberjs/regular-loc-helper
Turn `loc` from a built-in helper into a regular helper | merge pull request from emberjs/regular-loc-helper | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 6,707 |
0f3f49cd6c27ee4d4d41033f16a438c2b69d9220 | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid double throwing unhandled promise rejections.
When used in Ember, `RSVP` is configured to settle within
Backburner's configured `actions` queue.
Prior to this change, any unhandled promise rejections would:
* `Ember.testing === true`
* When `Ember.Test.adapter` was registered the `Test.adapter`'s
`exception` method would be called, and the rejection would be logged
to the console.
* When `Ember.Test.adapter` was not registered, the `defaultDispatch`
implementation would re-throw the error, and since RSVP settles in the
run loop this means that the re-thrown error would be caught by the
currently flushing Backburner queue's `invokeWithOnError` which sends
any errors to `Ember.onerror` (if present). If `Ember.onerror` was not
present, the exception would bubble up the "normal" unhandled
exception system (and ultimately to `window.onerror`).
* `Ember.testing === false`
* When `Ember.onerror` is present, it would be invoked with the
rejection reason.
* When `Ember.onerror` is not present, the rejection reason would be
logged to the console.
After this change:
* When `Ember.Test.adapter` is present, its `exception` method is
invoked with the rejection.
* Otherwise the rejection reason is rethrown.
The benefits of this are:
* It is now possible to debug rejected promises via "normal" JS
exception debugging (e.g. break on uncaught exception).
* There are many fewer decision points, making it much easier to grok
what is going on. | [bugfix beta] avoid double throwing unhandled promise rejections | 64 | false | false | 8 | false | false | false | emberjs | ember.js | 6,708 |
80f7d6b46b434777216f247967596548cd06abae | Robert Jackson | Robert Jackson | [BUGFIX lts] Allow Ember.Test.adapter to opt out of `exception` handling.
In the majority of testing frameworks (e.g. Mocha, QUnit, Jasmine) a
global error handler is attached to `window.onerror`. When an uncaught
exception is thrown, this global handler is invoked and the test suite
will properly fail.
Requiring that the provided test adapter provide an exception method
is strictly worse in nearly all cases than allowing the error to be
bubbled upwards and caught/handled by either `Ember.onerror` (if
present) or `window.onerror` (generally from the test framework).
This commit makes `Ember.Test.adapter.exception` optional. When not
present, errors during testing will be handled by existing "normal"
means. | [bugfix lts] allow ember.test.adapter to opt out of `exception` handling | 72 | false | false | 10 | false | false | false | emberjs | ember.js | 6,709 |
1d37ba6b761de84c7765f3fc213225ae1de44cb7 | Robert Jackson | Robert Jackson | [BUGFIX lts] Add tests for various permutations of error handler setup.
Known permutations:
* Testing
* With `Ember.onerror`
* Sync Backburner (`run` and `run.join`)
* Async Backburner (`run.later`, `run.next`)
* RSVP
* Without `Ember.onerror`
* Sync Backburner (`run` and `run.join`)
* Async Backburner (`run.later`, `run.next`)
* RSVP
* Development / Production
* With `Ember.onerror`
* Sync Backburner (`run` and `run.join`)
* Async Backburner (`run.later`, `run.next`)
* RSVP
* Without `Ember.onerror`
* Sync Backburner (`run` and `run.join`)
* Async Backburner (`run.later`, `run.next`)
* RSVP
This commit adds tests for all scenarios. | [bugfix lts] add tests for various permutations of error handler setup | 70 | false | false | 11 | false | false | false | emberjs | ember.js | 6,710 |
8360825e8415e03836ba0c0f907a533ed5f8a666 | Robert Jackson | Robert Jackson | [BUGFIX lts] Revert "[BUGFIX] Changed backburner's error handler to use `dispatchError` instead of `onError`. This is so that backburner errors can be caught by the `Test.adapter`. Fixes #14864."
This reverts commit 196442dc17b2511495b68087b1c5e817c70d62da which
essentially made all error handling for things that are run-wrapped
async, dramatically impacting development ergonomics.
The originally reported issue is a _very real_ problem that we need to
guard against. To reproduce that issue, the following conditions must
exist:
* The application must implement `Ember.onerror` in a way that does not
rethrow errors.
* Throw an error during anything that uses `run.join`. The example
scenario had a template like this:
```hbs
<button {{action 'throwsAnError'}}>Click me!</button>
```
To fix this error swallowing behavior, the commit being reverted made
all errors hit within the run loop use `dispatchError`, which (during
tests) has the default implementation of invoking `QUnit`'s
`assert.ok(false)`. Unfortunately, this meant that it is now impossible
to use a standard `try` / `catch` to catch errors thrown within anything
"run-wrapped".
For example, these patterns were no longer possible after the commit in
question:
```js
try {
Ember.run(() => {
throw new Error('This error should be catchable');
});
} catch(e) {
// this will never be hit during tests...
}
```
This ultimately breaks a large number of test suites that rely
(rightfully so!) on being able to do things like:
```js
module('service:foo-bar', function(hooks) {
setupTest(hooks);
hooks.beforeEach(() => {
this.owner.register('service:whatever', Ember.Service.extend({
someMethod(argumentHere) {
Ember.assert('Some random argument validation here', !argumentHere);
}
});
});
test('throws when argumentHere is missing', function(assert) {
let subject = this.owner.lookup('service:foo-bar');
assert.throws(() => {
run(() =>
subject.someMethod());
}, /random argument validation/);
});
});
```
The ergonomics of breaking standard JS `try` / `catch` is too much, and
therefore the original commit is being reverted. | [bugfix lts] revert "[bugfix] changed backburner's error handler to use `dispatcherror` instead of `onerror`. this is so that backburner errors can be caught by the `test.adapter`. fixes ." | 189 | false | false | 28 | false | false | false | emberjs | ember.js | 6,711 |
2272e0e0d904674a3e46d363e2b323e2a7d8cdeb | Robert Jackson | GitHub | Merge pull request #15874 from rwjblue/upgrade-backburner
[BUGFIX canary] Update Backburner.js to v1.3.0. | merge pull request from rwjblue/upgrade-backburner | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 6,712 |
1898ad40f3cfa7bdcacc0afbd6e08575d3ce3cc0 | Robert Jackson | Robert Jackson | [BUGFIX canary] Update Backburner.js to v1.3.0.
For a full list of changes see:
https://github.com/BackburnerJS/backburner.js/compare/v1.2.2...v1.3.0
High level changes:
* Includes fixes for Ember.run.join swallowing errors when an
`Ember.onerror` exists.
* Fix `run.throttle` argument usage to now invoke the throttled function
with the _last_ arguments (previously was the first set of arguments).
* Various cleanup / refactors of the codebase. | [bugfix canary] update backburner.js to v1.3.0 | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 6,713 |
4c2a910eefe765a0349e850fcbf86c698825a4cd | Kris Selden | Kris Selden | Hello World outlet test passes. | hello world outlet test passes | 30 | false | false | 5 | false | false | false | emberjs | ember.js | 6,714 |
9226d7225542f602e7619233c4b88e2a5ccd2099 | Kris Selden | Kris Selden | update get more typing | update get more typing | 22 | false | false | 4 | false | false | false | emberjs | ember.js | 6,715 |
56cafa32ca073fbc5dc2646d070b5bd60e986063 | Kris Selden | Kris Selden | make compileOptions injected and populate macros | make compileoptions injected and populate macros | 48 | false | false | 6 | false | true | false | emberjs | ember.js | 6,716 |
5d1c1ab58058952d77812167575c05361d8da6ba | Kris Selden | Kris Selden | more cleanup of Outlet manager | more cleanup of outlet manager | 30 | false | false | 5 | false | false | false | emberjs | ember.js | 6,717 |
6498f4c2fa0a47a7f6ac77a5950553c7d7c6c74c | Kris Selden | Kris Selden | Merge remote-tracking branch 'origin/master' into upgrade-glimmer | merge remote-tracking branch 'origin/master' into upgrade-glimmer | 65 | true | false | 6 | false | false | false | emberjs | ember.js | 6,718 |
8911d3bd27102583a756602f897bc3d154e46716 | Kris Selden | Kris Selden | Cleanup curried stuff. | cleanup curried stuff | 21 | false | false | 3 | false | false | false | emberjs | ember.js | 6,719 |
cbc39f58c3f7176d45997182019262df8ce8d2d8 | Ricardo Mendes | GitHub | Merge pull request #15869 from toddjordan/bring-logger-back
[DOC release]Make it so Logger comes back to YUIDoc builds | merge pull request from toddjordan/bring-logger-back | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 6,720 |
c30901afceb4144eb29a63e288c973cd3c8173ab | Todd Jordan | Todd Jordan | [DOC release]Make it so Logger comes back to YUIDoc builds | [doc release]make it so logger comes back to yuidoc builds | 58 | false | false | 10 | false | false | false | emberjs | ember.js | 6,721 |
cd0a5e7da05de375ac0337bce0bddc7912325fad | Steven Footea | Steven Footea | WIP Add getLayout to outlet manager | wip add getlayout to outlet manager | 35 | false | false | 6 | false | false | false | emberjs | ember.js | 6,722 |
c85c9822660807124599766f6889484a7d53e454 | Kris Selden | Kris Selden | hacks to get a little further | hacks to get a little further | 29 | false | false | 6 | false | false | false | emberjs | ember.js | 6,723 |
aaada07db8c4f2d6242c4954c732da59ceadf80e | Steven Footea | Steven Footea | WIP: Start getDynamicLayout and compileTemplate | start getdynamiclayout and compiletemplate | 42 | false | false | 4 | true | true | true | emberjs | ember.js | 6,724 |
2765f31d0573c53b150867b75f13fa24a5ca47b2 | Kris Selden | Kris Selden | now to compiling root layout | now to compiling root layout | 28 | false | false | 5 | false | false | false | emberjs | ember.js | 6,725 |
c825a4c8324f4e2609db565ef083f85cc0ad8d80 | Kris Selden | Kris Selden | more WIP | more wip | 8 | false | false | 2 | false | false | false | emberjs | ember.js | 6,726 |
32116addd881bab595d467233675717f55bec81e | Kris Selden | Kris Selden | more fixes and todos | more fixes and todos | 20 | false | false | 4 | false | false | false | emberjs | ember.js | 6,727 |
636f95bfe835c12d20df2de7f7484665c4dd627d | Kris Selden | Kris Selden | more resolver stuff | more resolver stuff | 19 | false | false | 3 | false | false | false | emberjs | ember.js | 6,728 |
c3a8ba3a209b25f6a64dfba1aeec82ae0fbc3d3f | Kris Selden | Kris Selden | improve types | improve types | 13 | false | false | 2 | true | true | false | emberjs | ember.js | 6,729 |
9f61acdde04719b84b9bbe654fc43418055ee3ad | Kris Selden | Kris Selden | bump glimmer-vm because Tom's done cleanup in the resolver area. | bump glimmer-vm because tom's done cleanup in the resolver area | 63 | true | false | 10 | true | true | false | emberjs | ember.js | 6,730 |
a09f6bb781ef415de58b529affcf1205e71fb369 | Kris Selden | Kris Selden | simple type fixes | simple type fixes | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 6,731 |
9155a4ea35e2186f8cdeb8e7af89ea3875303b14 | Steven Footea | Steven Footea | WIP Add skeleton resolvers, more upgrade work | wip add skeleton resolvers, more upgrade work | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 6,732 |
64673692ddfbc1c6cfc8b087238bd9cb9f4213b4 | Ricardo Mendes | Ricardo Mendes | Turn `loc` from a built-in helper into a regular helper
This is necessary for the RFC 236 `loc` deprecation, so the `@ember/string` package can override it once it is deprecated. | turn `loc` from a built-in helper into a regular helper | 55 | false | false | 10 | false | true | false | emberjs | ember.js | 6,733 |
aabc86b5e7506cf53d4df728051c3719b652b5ed | bekzod | bekzod | [BUGFIX beta] assert for passing brace expanding deps to `sum/max..` | [bugfix beta] assert for passing brace expanding deps to `sum/max..` | 68 | false | false | 10 | false | false | false | emberjs | ember.js | 6,734 |
c02250953a21f2ce85f4f8c02a2dc4d9bafd0fe7 | bekzod | bekzod | [BUGFIX release] fix regression with computed `filter/map/sort` | [bugfix release] fix regression with computed `filter/map/sort` | 63 | false | false | 7 | false | false | false | emberjs | ember.js | 6,735 |
2f32bf3fd7981d05dda4bac5c2a7c680c676d265 | Robert Jackson | GitHub | [BUGFIX beta] Merge pull request #15854 from ef4/version-checker
updating ember-cli-version-checker | [bugfix beta] merge pull request from ef4/version-checker | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 6,736 |
1a439ecc721817a6f6b0521fb4d2ff05c777a817 | Ivan Lučin | bekzod | Add failing test for computed.filter @each with {} regression | add failing test for computed.filter @each with {} regression | 61 | false | false | 9 | true | true | false | emberjs | ember.js | 6,737 |
5c091344a40c1ecc5ebdf7451e7d917af480971b | Edward Faulkner | Edward Faulkner | updating ember-cli-version-checker
Updating this everywhere is a prerequisite for getting ember-cli to work with yarn workspaces. | updating ember-cli-version-checker | 34 | false | false | 2 | false | false | false | emberjs | ember.js | 6,738 |
b7271b65e2fc0ca628ac90f5fa63a5ba5d2586ad | Katie Gengler | Katie Gengler | Add 2.17.0-beta.6 to CHANGELOG
[ci skip]
(cherry picked from commit d6dea181a9b3c5ce2f2f5f19dbb316a02dc19e44) | add 2.17.0-beta.6 to changelog | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 6,739 |
81c9489e493f12d02f1ed2bf08e4b0087770b062 | Robert Jackson | GitHub | Merge pull request #15853 from rwjblue/cleanup-helper-factory-instance-bean
[BUGFIX beta] Simplify non-class based helper system. | merge pull request from rwjblue/cleanup-helper-factory-instance-bean | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 6,740 |
c00c85b0068c010768bfec3e991e009bbfaf72f2 | Robert Jackson | Robert Jackson | [BUGFIX beta] Simplify non-class based helper system. | [bugfix beta] simplify non-class based helper system | 52 | false | false | 7 | false | false | false | emberjs | ember.js | 6,741 |
05a89f0591251afb9c1e4dd462964a6cfc54abdc | Robert Jackson | GitHub | Merge pull request #15848 from rwjblue/ensure-helpers-are-consistent
[BUGFIX beta] Ensure helpers have a consistent API. | merge pull request from rwjblue/ensure-helpers-are-consistent | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 6,742 |
5b3a22c073b176c049de9daa72851a4035b9a9cc | Robert Jackson | GitHub | Merge pull request #15849 from bekzod/chain-fix
[BUGFIX release] fix issue with unchaining ChainNodes | merge pull request from bekzod/chain-fix | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 6,743 |
250e10a85916c10d185a1533631afca593a4ffe2 | Ivan Lučin | bekzod | Add failing test for observer computed reads 2.16 regression | add failing test for observer computed reads 2.16 regression | 60 | false | false | 9 | true | true | false | emberjs | ember.js | 6,744 |
1396becfc2f19045ae88b33888f46b102b3faf2f | bekzod | bekzod | [BUGFIX release] fix issue with unchaining ChainNodes | [bugfix release] fix issue with unchaining chainnodes | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 6,745 |
f98688e6872c3ffd41edd9b8a532da838d270cd7 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure helpers have a consistent API.
Having class based helpers return a different API from "simple" helpers
is quite confusing. It makes testing a helper significantly different
based on the type of helper, and also makes refactoring from simple to
class-based a hazzard.
This change ensures that both types of helper return the same basic
interface, and enables us to use output similar to the following
regardless of the specific type of helper that was exported:
```js
module('foo | Helper', function(hooks) {
module('unit tests', function(hooks) {
setupRenderingTest(hooks);
test('returns some-value', async function(assert) {
await render(hbs`{{foo 'input' 'values'}}`);
assert.equal(this.element.textContent, 'some-value', 'helper works!');
});
});
module('unit tests', function(hooks) {
setupTest(hooks);
test('returns some-value', function(assert) {
let helper = this.owner.factoryFor('helper:foo').create();
assert.equal(helper.compute(['input', 'values']), 'some-value', 'helper works!');
});
});
});
``` | [bugfix beta] ensure helpers have a consistent api | 50 | false | false | 8 | false | false | false | emberjs | ember.js | 6,746 |
1fe22743e553dbdf9104988b392d0f3a7003caea | Robert Jackson | GitHub | Merge pull request #15838 from kellyselden/eslint
promote eslint rule "semi" to entire project | merge pull request from kellyselden/eslint | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,747 |
cd364f5c15081c9e20ccb475f9216cf8be779c9f | Kelly Selden | Kelly Selden | promote eslint rule "semi" to entire project | promote eslint rule "semi" to entire project | 44 | false | false | 7 | true | true | true | emberjs | ember.js | 6,748 |
c1a892dd08099ff757d7f95e96f74c2775a467ad | Robert Jackson | GitHub | Merge pull request #15825 from kellyselden/eslint-node-tests
run node-tests through eslint | merge pull request from kellyselden/eslint-node-tests | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 6,749 |
112922b59b08280f7e55164182d2f96431da1176 | Ricardo Mendes | GitHub | Merge pull request #15824 from kellyselden/eslint_remove_require
remove unused requires in eslint config | merge pull request from kellyselden/eslint_remove_require | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 6,750 |
e59bc82a418b139ac03cb59fd2a39287b2214eae | Ricardo Mendes | GitHub | Merge pull request #15833 from Turbo87/💣-jscs
Remove obsolete JSCS code | merge pull request from turbo87/💣-jscs | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 6,751 |
4e965f3cd21bc6fdd6a05a79515d1fdd3adda31a | Robert Jackson | GitHub | Merge pull request #15834 from Turbo87/ts-fix
ember-glimmer/string: Fix `escapeExpression()` types | merge pull request from turbo87/ts-fix | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 6,752 |
4caeb8c84dc317af1346337536909c2164e7e3fe | Tobias Bieniek | Tobias Bieniek | ember-glimmer/string: Fix escapeExpression() types
escapeExpression() accepts anything and always returns a string | fix escapeexpression() types | 28 | false | false | 3 | true | true | true | emberjs | ember.js | 6,753 |
f366bc672291c6d3e70c6ac5dcefcecfcd82ad41 | Tobias Bieniek | Tobias Bieniek | Remove obsolete JSCS code
We're using ESLint now... | remove obsolete jscs code | 25 | false | false | 4 | true | true | true | emberjs | ember.js | 6,754 |
f5d0dedb95f0af04fd80f4e008ffc16479b43f04 | Robert Jackson | GitHub | Merge pull request #15829 from toddjordan/make-ember-a-visible
[DOC beta]Ensure A function shows in apidocs | merge pull request from toddjordan/make-ember-a-visible | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,755 |
afbd490813f3ff202a809a0f7167bb476c9a4f0b | Todd Jordan | Todd Jordan | [DOC beta]Ensure A function shows in apidocs | [doc beta]ensure a function shows in apidocs | 44 | false | false | 7 | false | false | false | emberjs | ember.js | 6,756 |
131bf7ba6c18d4ea711297e58764a7b05f7ba51a | Katie Gengler | Katie Gengler | Add 2.17.0-beta.5 to CHANGELOG
[ci skip] | add 2.17.0-beta.5 to changelog | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 6,757 |
8b912e6c643868499f44effc7cf74ae4add2d777 | Robert Jackson | GitHub | Merge pull request #15788 from bekzod/remove-routeArgs
remove `routeArgs` | merge pull request from bekzod/remove-routeargs | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 6,758 |
98bb2bced61ff19b14d4f86e53da47f22c2ac894 | bekzod | bekzod | remove `routeArgs` | remove `routeargs` | 18 | false | false | 2 | false | true | false | emberjs | ember.js | 6,759 |
32b79662675b2a1ba0db836f72fd8fb5f433be85 | Steven Footea | Steven Footea | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (help
wanted). Below is a list of the needed changes and problems I have
encountered in the upgrade process.
UPGRADE NOTES (starting at glimmer-vm 0.25.6)
* Simple is now in @glimmer/interfaces
* ComponentManager.getSelf cannot return null (returns RootReference?)
* ComponentManager.getTag returns ComponentStateBucket.tag (: Tag)
* Some code moved from ComponentManager.update to
* ComponentManager.didUpdate
* ComponentManager<ComponentStateBucket> -->
* ComponentManager<ComponentStateBucket, ComponentDefinition>
* ComponentManager.create signature changed
* ComponentStateBucket's defintion is now DefinitionState instead of
* ComponentDefinition
* ComponentManager.prepareArgs signature changed
* ComponentManager.getCapabilities is new
* CompiledDynamicTemplate is gone (no longer in runtime, anyway) see
* https://github.com/glimmerjs/glimmer-vm/commit/79f2b4521f5a7d48d04e3fd34e224ddf5bc4c241#diff-d561208b0ad153d9273c2188e16c7442
* Must implicitly include @glimmer/vm and @glimmer/opcode-compiler and
* @glimmer/encoder in ember-cli-build.js
* compileLayout -> scanLayout -> prepareLayout -> new WrappedBuilder
* isSafeString is no longer exported publicly. Is that intentional?
* normalizeTextValue is no longer exported publicly. Is that
* intentional?
* isComponentDefinition is gone, kind of replaced by
* `isCurriedComponentDefinition`. Neither is exported.
* getComponentDefintion is no longer part of Environment.
* referenceFromParts has been removed.
* f3444e9ae0c7751047bdcd856e61344bfb548e12
* readDOMAttr has been removed. 316805b9175e01698120b9566ec51c88d075026a | upgrade glimmer-vm to 0.29.10 | 29 | false | false | 4 | true | true | true | emberjs | ember.js | 6,760 |
c432844ce4666d9a0813e026d22a85ccc0541d37 | Katie Gengler | Katie Gengler | Add 2.17.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 96671cbe447b091968120780a29425d5acd055fb) | add 2.17.0-beta.4 to changelog | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 6,761 |
53bfb16e72f0493f4ab6d4c73f6296b271527209 | Kelly Selden | Kelly Selden | run node-tests through eslint | run node-tests through eslint | 29 | false | false | 4 | true | false | true | emberjs | ember.js | 6,762 |
5b30f6ebfc2392603cdf0b225d112b2f4f26cc98 | Kelly Selden | Kelly Selden | remove unused requires in eslint config | remove unused requires in eslint config | 39 | false | false | 6 | true | false | true | emberjs | ember.js | 6,763 |
bae456bc71e305e86c61323152b8d24efa8bec6e | Robert Jackson | GitHub | Merge pull request #15823 from kellyselden/helper-unit-test
convert new helper unit test to fixture | merge pull request from kellyselden/helper-unit-test | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 6,764 |
36b22430d14319833eed90af0f0450f15029daea | Robert Jackson | GitHub | Merge pull request #15822 from kellyselden/helper-addon-test
missed a helper-addon fixture | merge pull request from kellyselden/helper-addon-test | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 6,765 |
f4e055e3269b793245ea35faa7cd7c7e28d3acb4 | Kelly Selden | Kelly Selden | convert new helper unit test to fixture | convert new helper unit test to fixture | 39 | false | false | 7 | false | false | false | emberjs | ember.js | 6,766 |
e6730806ee0078ba437680bd69cb41ee21ff8126 | Kelly Selden | Kelly Selden | missed a helper-addon fixture | missed a helper-addon fixture | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 6,767 |
f203d7992aaac70883b8638d6dc55fa49f086f64 | Robert Jackson | GitHub | Merge pull request #15821 from kellyselden/helper-addon-test
use fixture for helper-addon blueprint test | merge pull request from kellyselden/helper-addon-test | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 6,768 |
78bb86dd98601bfe74afd9a184e6849090ea4ec1 | Robert Jackson | GitHub | Merge pull request #15779 from bekzod/link-to-comptued
cleanup `active` computed property | merge pull request from bekzod/link-to-comptued | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 6,769 |
896ce04ed0797a503672db0a5c56d28e7b4074ad | Kelly Selden | Kelly Selden | use fixture for helper-addon blueprint test | use fixture for helper-addon blueprint test | 43 | false | false | 6 | true | true | true | emberjs | ember.js | 6,770 |
909723c08b467f9f266a3ddf36d6ad689270a213 | Robert Jackson | GitHub | Merge pull request #15820 from kellyselden/helper-test-fixture
clean up helper text assertion by using fixture file | merge pull request from kellyselden/helper-test-fixture | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,771 |
0b8c1b734d54c33c9d840be45e05edd4743cec75 | Ricardo Mendes | GitHub | Merge pull request #15819 from kellyselden/helper-int-test-fix
fix newlines in integration helper test blueprint | merge pull request from kellyselden/helper-int-test-fix | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,772 |
e0227c729a60dc9913a8344f7a93d0d6a7d0b1d1 | Robert Jackson | GitHub | Merge pull request #15818 from kellyselden/helper-test-unit
add test coverage of helper unit test | merge pull request from kellyselden/helper-test-unit | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 6,773 |
1a93ae0bdc1d0916b075fddf301c5f8a7258fc6c | Kelly Selden | Kelly Selden | clean up helper text assertion by using fixture file | clean up helper text assertion by using fixture file | 52 | false | false | 9 | false | false | false | emberjs | ember.js | 6,774 |
b8914d1217ae89df13402e6973395a0c8479048b | Kelly Selden | Kelly Selden | fix newlines in integration helper test blueprint | fix newlines in integration helper test blueprint | 49 | false | false | 7 | true | true | true | emberjs | ember.js | 6,775 |
cb8dc6c82bde289f4339d65c0c0a53ddf1a233ca | Kelly Selden | Kelly Selden | add test coverage of helper unit test
will fix new line issues in followup | add test coverage of helper unit test | 37 | false | false | 7 | true | true | true | emberjs | ember.js | 6,776 |
e4af430c09f9d8041d79fdddb1573325f48cb3c7 | Robert Jackson | GitHub | Merge pull request #15762 from bekzod/cleanup-linkto
make sure `_isActive` returns boolean in `link-to` | merge pull request from bekzod/cleanup-linkto | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 6,777 |
3831a4e74104f65cd74a174d6292ad2c9e9eb58e | Robert Jackson | GitHub | Merge pull request #15705 from bekzod/set-cleanup
cleanup `computed._set` | merge pull request from bekzod/set-cleanup | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,778 |
254d6f02fc6af2ad71fc93e54b0dabb84c6a28a6 | Robert Jackson | GitHub | Merge pull request #15608 from kellyselden/helper-test
use a fixture to test `helper-test` blueprint | merge pull request from kellyselden/helper-test | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 6,779 |
33402e27a35131446e3bb9f0eaf1262fa252a868 | Robert Jackson | GitHub | Merge pull request #15394 from bekzod/return-this
return `this` for `addObserver` and `removeObserver` | merge pull request from bekzod/return-this | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,780 |
8109f90bde34dfcd1763aca0be090a7ea3c9f26a | Robert Jackson | GitHub | Merge pull request #14590 from sduquej/sd/deprecate-usage-of-targetObject
[BUGFIX beta] Adds a deprecation message when using targetObject | merge pull request from sduquej/sd/deprecate-usage-of-targetobject | 67 | true | false | 5 | true | true | false | emberjs | ember.js | 6,781 |
24a32b14d25c2d2b6dcf845fc22bc450f4e14ae1 | Sebastian Duque | Sebastian Duque | [BUGFIX beta] Adds deprecation for targetObject | [bugfix beta] adds deprecation for targetobject | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 6,782 |
16e2aabc5927c32bd5e0a8ae2172b07694abe094 | Robert Jackson | GitHub | Merge pull request #15656 from bekzod/build-injection
cleanup `buildInjections` | merge pull request from bekzod/build-injection | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 6,783 |
0780f0e92537fb9a9665f9871f7e17cd96378548 | Robert Jackson | GitHub | Merge pull request #15811 from bekzod/reuse-extract-query-args
reuse `extractQueryParamsArgument` | merge pull request from bekzod/reuse-extract-query-args | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,784 |
c69cdbfaedb94dd827b81418079e1a65ae4d9b4b | Robert Jackson | GitHub | Merge pull request #15793 from bekzod/lint
added ts linting rules | merge pull request from bekzod/lint | 36 | true | false | 5 | true | false | false | emberjs | ember.js | 6,785 |
fd983637343d16695c0277002533f32efb1dd3d8 | Robert Jackson | GitHub | Merge pull request #15814 from Serabe/fix/15812
[BUGFIX beta] Add assertion in NativeArray.replace | merge pull request from serabe/fix/15812 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 6,786 |
1067c297bc568c569a3bdcc40768509ec10cf3ac | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Add assertion in NativeArray.replace
NativeArray.replace requires an array of items as third argument.
Before, it only check for the length property. The way it was
implemented made that the following two calls behave differently:
```js
arr.replace(0, 1, 'hola');
arr.replace(0, 1, '');
```
The first one would replace the first item with `'hola'`, but the second
would act as an splice and just remove the first element.
This PR adds an assertion and fixes some calls in tests.
Fixes #15812 | [bugfix beta] add assertion in nativearray.replace | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 6,787 |
cb3234dc22e6797c28ee335c66d168999f7d7338 | Robert Jackson | GitHub | Merge pull request #15307 from bekzod/assert-render
bailout for empty string too in `render` | merge pull request from bekzod/assert-render | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,788 |
1e6dcffba568a3f108b2b4b37fd2b211943c668c | bekzod | bekzod | use `peekMeta` where appropriate | use `peekmeta` where appropriate | 32 | false | false | 4 | false | true | false | emberjs | ember.js | 6,789 |
191553ece962e1af438463757d41e8b3ea41191a | bekzod | bekzod | added linting rules | added linting rules | 19 | false | false | 3 | false | false | false | emberjs | ember.js | 6,790 |
2e1b34563f10f5524df1a61d492636234d408bef | bekzod | bekzod | reuse `extractQueryParamsArgument` | reuse `extractqueryparamsargument` | 34 | false | false | 2 | false | true | false | emberjs | ember.js | 6,791 |
880d5ddbc39f6c52cfe79866599b9479dc16e369 | Robert Jackson | GitHub | Merge pull request #15706 from bekzod/fullname-valid
use `isValidFullName` for `assert` | merge pull request from bekzod/fullname-valid | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 6,792 |
276fa1e3d281c9e021900eddec029b23d867ee96 | Robert Jackson | GitHub | Merge pull request #15810 from bekzod/resuse-resemble-url
reuse `resemblesURL` | merge pull request from bekzod/resuse-resemble-url | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 6,793 |
e519985dc70410f0bf95f4f31625473f16447266 | Robert Jackson | GitHub | Merge pull request #15808 from emberjs/fix-double-assert-render-leak
Cleanup at end of transaction to prevent memory leaks | merge pull request from emberjs/fix-double-assert-render-leak | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 6,794 |
a1b98a054e5e79ac642ab90de52121c006d2217b | bekzod | bekzod | return `this` for `addObserver` and `removeObserver`
to be consistent with other method, `addObserver` and `removeObserver`
return `this` now | return `this` for `addobserver` and `removeobserver` | 52 | false | false | 6 | false | true | false | emberjs | ember.js | 6,795 |
8be996db419fcfe29ad46c66d410d803bd483bbb | bekzod | bekzod | rename `_watching` => `_isWatching` | rename `_watching` => `_iswatching` | 35 | false | false | 4 | false | true | false | emberjs | ember.js | 6,796 |
cd4873d92ec6a7ca3e587d87e2e6ea74cb6d30fa | bekzod | bekzod | reuse `resemblesURL` | reuse `resemblesurl` | 20 | false | false | 2 | false | true | false | emberjs | ember.js | 6,797 |
00c4c82a3f6fd03fe692601ad8e052f7bb5e2914 | Kris Selden | GitHub | Merge pull request #15806 from emberjs/more-type-fixes
more type stuff | merge pull request from emberjs/more-type-fixes | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 6,798 |
316c7c6d47299820b9401cd87683c860afd8a117 | Kris Selden | Kris Selden | Cleanup at end of transaction to prevent memory
leaks when objects that are rendered are retained.
Fix #15803 | cleanup at end of transaction to prevent memory | 47 | false | false | 8 | false | false | false | emberjs | ember.js | 6,799 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.