sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
896abc4be7c79bbb8e6d32cba1f52b30bfa376eb | Ricardo Mendes | Todd Jordan | Update component.js | update component.js | 19 | false | false | 2 | true | false | false | emberjs | ember.js | 6,900 |
9f07191716816273b2445e2d618753c8a72c9826 | Ricardo Mendes | Todd Jordan | Update component.js | update component.js | 19 | false | false | 2 | true | false | false | emberjs | ember.js | 6,901 |
448c29120b2e0a11e8b8d26a2645cf55bb8a83c7 | Todd Jordan | Todd Jordan | Make observer static | make observer static | 20 | false | false | 3 | true | true | true | emberjs | ember.js | 6,902 |
56cf38400e7478a8dea68e9eef07a30be45ac004 | Todd Jordan | Todd Jordan | Fix Computed return references, array references | fix computed return references, array references | 48 | false | false | 6 | false | true | false | emberjs | ember.js | 6,903 |
32b09dcb339861b9a6a9208ec2aa292682366670 | Todd Jordan | Todd Jordan | Fix various oversights with initial 176 deploy | fix various oversights with initial 176 deploy | 46 | false | false | 7 | true | true | true | emberjs | ember.js | 6,904 |
468475f9786b8528c342f4eebda14b32af1d52a3 | Todd Jordan | Todd Jordan | [DOC Canary] Yuidoc annotation changes for rfc 176
label appropiate modules private
Get Ember.Templates.helpers to show up in classes list
migrate more api code block documentation
Get jquery $ showing up in API Docs
Add access visibility to pass linting | [doc canary] yuidoc annotation changes for rfc 176 | 50 | false | false | 8 | false | false | false | emberjs | ember.js | 6,905 |
fb7cf48705109d2fea100bb16eb9d2411088fc11 | Robert Jackson | GitHub | Merge pull request #15769 from alexmiddeleer/fix-native-array-docs
[DOC canary] Update Ember.A() docs to include optional param | merge pull request from alexmiddeleer/fix-native-array-docs | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 6,906 |
0b190028c0fa0840175a1cd3dc2d2d9e4cadc275 | Robert Jackson | GitHub | Merge pull request #15765 from bekzod/move-to-debug
move `_logLookup` definition to `DEBUG` mode | merge pull request from bekzod/move-to-debug | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,907 |
190400fec003ffbd4bd53f538e9235127e761c7c | Alex | Alex | [DOC canary] Update Ember.A() docs to include optional param | [doc canary] update ember.a() docs to include optional param | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 6,908 |
56651588853c6717238fe9006a71aa950c14cf2f | Matt Wagner | Matt Wagner | [DOC release] Remove Extra Space in Computed Macros
Removes an extra space in computed macros documentation to fix misalignment. | [doc release] remove extra space in computed macros | 51 | false | false | 8 | false | false | false | emberjs | ember.js | 6,909 |
e011e68c992f9503716fbab00e36f4dc2d9d66db | bekzod | bekzod | move `_logLookup` definition to `DEBUG` mode | move `_loglookup` definition to `debug` mode | 44 | false | false | 6 | false | true | false | emberjs | ember.js | 6,910 |
d7d40fcc3a8fa4be3310bcff0c6d14eac084a422 | bekzod | bekzod | convert `Registry` to es6 class | convert `registry` to es6 class | 31 | false | false | 5 | true | true | true | emberjs | ember.js | 6,911 |
14a9a2383027f7f539a8df9faf4fab05f0baebbb | Robert Jackson | GitHub | Merge pull request #15763 from bekzod/use-bind
remove `bind` fallback | merge pull request from bekzod/use-bind | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 6,912 |
0c62821a2f773457b57f1218ffede3f19e9b426d | bekzod | bekzod | convert `Container` to es6 class | convert `container` to es6 class | 32 | false | false | 5 | true | true | true | emberjs | ember.js | 6,913 |
edc65aad1499bce088a701798482970b4302a1c5 | bekzod | bekzod | remove `bind` fallback | remove `bind` fallback | 22 | false | false | 3 | false | true | false | emberjs | ember.js | 6,914 |
99b43dc699bede8be3c371b41ca4f1074196ffde | Katie Gengler | Katie Gengler | Update Changelog for 2.17.0-beta.3
[ci skip]
(cherry picked from commit 2131f66c85888d8a74eb555334886e45d856787b) | update changelog for 2.17.0-beta.3 | 34 | false | false | 4 | true | true | true | emberjs | ember.js | 6,915 |
1ee77481bbb6edfcc0d32806c2913447e7815708 | Kelly Selden | Kelly Selden | remove fs-extra dependency | remove fs-extra dependency | 26 | false | false | 3 | true | false | true | emberjs | ember.js | 6,916 |
b52da3c1538dbfad21c88b2f9cd6f7dd1b7db578 | Robert Jackson | GitHub | Merge pull request #15754 from bekzod/remove-deprication
remove `router.router` deprecation | merge pull request from bekzod/remove-deprication | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 6,917 |
e3627124940d8063845dde9f58995a3abc66a122 | Robert Jackson | GitHub | Merge pull request #15606 from kellyselden/fs-extra
[BUGFIX LTS] add fs-extra to deps | merge pull request from kellyselden/fs-extra | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,918 |
4842f036a330a39c57147898ca074c8a66946783 | bekzod | bekzod | remove `router.router` deprecation | remove `router.router` deprecation | 34 | false | false | 3 | true | true | true | emberjs | ember.js | 6,919 |
acdd288d1ea52cee19587eb3be30857069233fb8 | Kelly Selden | Kelly Selden | add fs-extra to deps | add fs-extra to deps | 20 | false | false | 4 | true | true | true | emberjs | ember.js | 6,920 |
15e1d153b8198776df51915459cd12b1e8d67f1d | Ricardo Mendes | GitHub | Fix script that publishes to Rubygems
Apparently a brilliant young man tacked a `.strip` to the end of a bash command in hopes that it would strip whitespace.
Of course, what ended up happening was that a gem with `.strip` tacked on to the end of the name would not be found in the filesystem by the publish command. | fix script that publishes to rubygems | 37 | false | false | 6 | true | true | true | emberjs | ember.js | 6,921 |
1213b4a06205fadf4d7e70653886b1a9510bf793 | Robert Jackson | GitHub | Merge pull request #15697 from bekzod/meta-meta
move accessing meta out of the loop | merge pull request from bekzod/meta-meta | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 6,922 |
9bacd6885417024bf71654766bc91c8f5085e324 | Robert Jackson | GitHub | Merge pull request #15710 from bekzod/reset-cache
correctly reset container cache | merge pull request from bekzod/reset-cache | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,923 |
922aed6f70b6daae16a0c0c5a351d9e243916c77 | Robert Jackson | Katie Gengler | Add 2.15.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 53cfa5995c79fcf5892fd4910b43882a50240b46) | add 2.15.3 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 6,924 |
8bfa2013de2c15108b123f41b6a407a56f64108e | Katie Gengler | Katie Gengler | Add 2.17.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 99d993cf529ee19e0ce29779eaf5524255d8f999) | add 2.17.0-beta.2 to changelog | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 6,925 |
70a3d879b8b7a64b7bf11da5479fd3dfc6191241 | Robert Jackson | Katie Gengler | Add v2.17.0-beta.1 to CHANGELOG.
[ci skip]
(cherry picked from commit 07d4236bd94604d9392f50dbf0941f168e2ee9de) | add v2.17.0-beta.1 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 6,926 |
64dfd70b4e875c8b5b0fe0def3da5b358fdea904 | Robert Jackson | Katie Gengler | Add 2.16.0 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 3576aee3e04970d25a1470ad784c14d504516c1d) | add 2.16.0 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 6,927 |
78d1aa69fa10b7375a82e8bfeeb7638fb3f19744 | bekzod | bekzod | correctly reset container cache | correctly reset container cache | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 6,928 |
df87455285173fc90a344a3c71f8bf32e606f6e1 | Ricardo Mendes | GitHub | Merge pull request #15741 from Panman8201/remove-needs-example-from-controller-docs
[DOC release] Remove controller needs from docs | merge pull request from panman8201/remove-needs-example-from-controller-docs | 77 | true | false | 5 | true | false | false | emberjs | ember.js | 6,929 |
831afffc120cf68a30951b51466962534283c2f4 | Ryan Panning | Ryan Panning | [DOC release] Remove controller needs from docs | [doc release] remove controller needs from docs | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 6,930 |
241adea495be3363dfc4c09a749e73230fa80998 | Kris Selden | GitHub | Merge pull request #15707 from bekzod/can-invoke
fix `canInvoke` for edge cases | merge pull request from bekzod/can-invoke | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 6,931 |
c482f7bb4d7a90abf0f80cf7c983380272402eb7 | Ricardo Mendes | GitHub | Merge pull request #15730 from fullsailor/patch-2
[DOC release] Update Evented example code for RFC 176 | merge pull request from fullsailor/patch-2 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,932 |
f94a4b6aef5b41b96ef2e481f35e07608df01440 | Robert Jackson | GitHub | Merge pull request #15738 from Serabe/test/reset-namespace
[CLEANUP] Fix test for resetNamespace | merge pull request from serabe/test/reset-namespace | 52 | true | false | 5 | true | true | false | emberjs | ember.js | 6,933 |
577300e5f6ae5f1d29098d1cec16620c966f60df | Sergio Arbeo | Sergio Arbeo | [CLEANUP] Fix test for resetNamespace
While triaging #15728, locks and I saw that the `resetNamespace` part of
the helpers test was flawed, given that it is set in a top level route.
This commit adds a test for a resetNamespace in a nested route. | [cleanup] fix test for resetnamespace | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 6,934 |
032a271110d61af60eeff916aadac7ae3506c320 | Robert Jackson | GitHub | Merge pull request #15733 from ilucin/fix-computed-sort-regression
[BUGFIX] Fix computed sort regression when array prop initially null | merge pull request from ilucin/fix-computed-sort-regression | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 6,935 |
2cf4219212e5f47850473eb137f1dfca0efb9513 | Ivan Lučin | Ivan Lučin | [BUGFIX] Fix computed sort regression when array prop initally null | [bugfix] fix computed sort regression when array prop initally null | 67 | false | false | 10 | false | false | false | emberjs | ember.js | 6,936 |
46a9b61c672d67907e05e5ab228496c70142c8c9 | Andrew Smith | GitHub | [DOC release] Update Evented example code for RFC 176
The Ember namespace is no longer used. | [doc release] update evented example code for rfc 176 | 53 | false | false | 9 | false | false | false | emberjs | ember.js | 6,937 |
f4bbfe27d55caa5182fcd229f09a690fe11a9ca6 | Robert Jackson | GitHub | Merge pull request #15613 from CvX/query-params-from-service-fix
[BUGFIX beta] Don't throw an error, when not all query params are passed to routerService.transitionTo | merge pull request from cvx/query-params-from-service-fix | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 6,938 |
f7fa758b275bf69e30761651562e3acf268a7b1f | Robert Jackson | GitHub | Merge pull request #15722 from bekzod/get-empty-string
[BUGFIX release] empty path in `get` helper should not throw assertion | merge pull request from bekzod/get-empty-string | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 6,939 |
ee0aba25c4307e66f66422bec1dd32e8029211df | bekzod | bekzod | [BUGFIX release] empty path for get helper should not throw assertion | [bugfix release] empty path for get helper should not throw assertion | 69 | false | false | 11 | false | false | false | emberjs | ember.js | 6,940 |
de55b12a89ae497086b6a7aa02716ef2bc2faea1 | Robert Jackson | GitHub | Merge pull request #15720 from rwjblue/remove-inline-sourcemaps
[BUGFIX release] Remove sourceMappingURL for dag-map. | merge pull request from rwjblue/remove-inline-sourcemaps | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 6,941 |
93aaf2cffd02d503d4857c1ea11b27b25720d0d5 | Robert Jackson | Robert Jackson | Remove old / outdated comments in ember-cli-build.js. | remove old / outdated comments in ember-cli-build.js | 52 | false | false | 7 | true | false | false | emberjs | ember.js | 6,942 |
90da1083dc12b517f473b8c1c4949fe2326bbd2c | Robert Jackson | Robert Jackson | [BUGFIX release] Remove sourceMappingURL for dag-map.
Babel is not properly ingesting the sourcemaps (even when the upstream
funnel brings the mapping file in with it), this commit strips it out to
avoid errors during uglification (reported in
ember-cli/ember-cli-uglify#29). | [bugfix release] remove sourcemappingurl for dag-map | 52 | false | false | 6 | false | false | false | emberjs | ember.js | 6,943 |
8d5ee89c301e86ba47a5d2ef9262dbefbbdcf063 | Robert Jackson | GitHub | Merge pull request #15715 from bekzod/move-to-debug
move `normalizeInjectionsHash` definition to debug | merge pull request from bekzod/move-to-debug | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,944 |
ad255fa20707b3a132e7a3c396fc62b454c5bf15 | Robert Jackson | GitHub | Merge pull request #15719 from bekzod/avoid-creating-cache-key
avoid creating cachekey for non-singleton objects | merge pull request from bekzod/avoid-creating-cache-key | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,945 |
c46c19dbc6cc2c6bf9bb033400a818fcbfcebe99 | Robert Jackson | Robert Jackson | Add 2.15.2 to CHANGELOG.
[ci skip] | add 2.15.2 to changelog | 23 | false | false | 4 | true | true | true | emberjs | ember.js | 6,946 |
9a6b038d303ade2f643ad0499054457403f86294 | Robert Jackson | Robert Jackson | Add 2.15.1 to CHANGELOG.md.
[ci skip] | add 2.15.1 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 6,947 |
a9a36f4f8931488de40c64f4f190c0c3ce5be035 | Robert Jackson | Robert Jackson | Update CHANGELOG for 2.16.0-beta.2.
[ci skip] | update changelog for 2.16.0-beta.2 | 34 | false | false | 4 | true | true | true | emberjs | ember.js | 6,948 |
9cc4465e1a3eb5e77efb55a91f724322ea19caa4 | bekzod | bekzod | avoid creating cachekey for non-singleton objects | avoid creating cachekey for non-singleton objects | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 6,949 |
c63ca1397bb11b007cc95d5ae1f3da03945398ee | Robert Jackson | GitHub | Merge pull request #15717 from emberjs/fix-bb-stuff
[BUGFIX] bump backburner (fixes clock + autorun interop) | merge pull request from emberjs/fix-bb-stuff | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,950 |
783fcd0821bded248215b1274b88410da978c070 | Stefan Penner | Stefan Penner | [BUGFIX] bump backburner (fixes clock + autorun interop) | [bugfix] bump backburner (fixes clock + autorun interop) | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 6,951 |
1cbc8db47de6a29c8eadf9a357f052a4bd6db1a8 | Robert Jackson | GitHub | Merge pull request #15713 from emberjs/ember.js/dynamic-injections
mark dynamic injections without polluting instance properties | merge pull request from emberjs/ember.js/dynamic-injections | 60 | true | false | 5 | true | true | false | emberjs | ember.js | 6,952 |
98c93e62ff302f196af433341f00a5c82f84e966 | bekzod | bekzod | mark dynamic injections without polluting instance property | mark dynamic injections without polluting instance property | 59 | false | false | 7 | false | true | false | emberjs | ember.js | 6,953 |
47026fc3aedee2b1a10fded8ae41765a0a4c21b6 | Robert Jackson | GitHub | Merge pull request #15711 from bekzod/consistent-destroy
make consistent `destroyDestroyables` with `resetMember` | merge pull request from bekzod/consistent-destroy | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 6,954 |
774a192ece628d08a3fcd877f8395f858aa33972 | bekzod | bekzod | move `normalizeInjectionsHash` definition to debug | move `normalizeinjectionshash` definition to debug | 50 | false | false | 5 | true | true | true | emberjs | ember.js | 6,955 |
d66485fbc07d0db3a1ae7aa40a9a8485cdd2a8c0 | bekzod | bekzod | make consistent `destroyDestroyables` with `resetMember` | make consistent `destroydestroyables` with `resetmember` | 56 | false | false | 5 | true | true | false | emberjs | ember.js | 6,956 |
b6e016eb09b7de037013547dd851ddb3f98943a3 | bekzod | bekzod | fix `canInvoke` for edge cases | fix `caninvoke` for edge cases | 30 | false | false | 5 | false | true | false | emberjs | ember.js | 6,957 |
5cbe3fffd222380d6eadbdc99a2d2ad81ce00716 | Robert Jackson | GitHub | Merge pull request #15703 from bekzod/move-export
rename `destroy` to `deleteMeta` | merge pull request from bekzod/move-export | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,958 |
a20a784836a28de7a6eab0a8ad1e7add2093f292 | Robert Jackson | GitHub | Merge pull request #15691 from bekzod/alias-meta
reuse meta for `didUnwatch` and `willWatch` in `alias descriptor` | merge pull request from bekzod/alias-meta | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 6,959 |
24c67d27acc2df0aefdcf79a975dfef3fd78d3a7 | Robert Jackson | GitHub | Merge pull request #15544 from bekzod/remove-frozen
remove `isFrozen` check in `native_array` | merge pull request from bekzod/remove-frozen | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,960 |
dd09c4db533457b7dea8a4bba0655333bd15388d | bekzod | bekzod | replace `throw` with assertion | replace `throw` with assertion | 30 | false | false | 4 | false | true | false | emberjs | ember.js | 6,961 |
934f2f754c614dd4d4b3aa92931989bb75662285 | bekzod | bekzod | rename `destroy` to `deleteMeta` | rename `destroy` to `deletemeta` | 32 | false | false | 4 | false | true | false | emberjs | ember.js | 6,962 |
6aab203232c633486ef42189eaf66261550c9168 | bekzod | Ricardo Mendes | reuse meta for `didUnwatch` and `willWatch` | reuse meta for `didunwatch` and `willwatch` | 43 | false | false | 6 | true | true | true | emberjs | ember.js | 6,963 |
92a6aece5809cd4a53e4b6bd434b842b7c4aa0ff | Robert Jackson | GitHub | Merge pull request #15610 from kellyselden/inflection
[BUGFIX LTS] add inflection to dependencies | merge pull request from kellyselden/inflection | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 6,964 |
7a4effea7265af68092e3a66afe825f03744a40c | Robert Jackson | GitHub | Merge pull request #15593 from caseywatts/pauseTest
[DOC release] document how to use pauseTest() with ember-mocha | merge pull request from caseywatts/pausetest | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 6,965 |
f518397371360dddd04b61363b9c4940540b5a5a | Robert Jackson | GitHub | Merge pull request #15696 from bekzod/remove-if-check
remove redundant existence check | merge pull request from bekzod/remove-if-check | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 6,966 |
87291c1ae30212d21e7536e9635f486ed39b4de2 | Robert Jackson | GitHub | Merge pull request #15702 from bekzod/fix-assert
correctly escape values in `core_object` assertions | merge pull request from bekzod/fix-assert | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 6,967 |
5c6333c22315dbf3a4652601b22f3708edc24fcb | Robert Jackson | GitHub | Merge pull request #15604 from emberjs/data-adapter-observer
Data Adapter: Only trigger model type update if the record live array count actually changed | merge pull request from emberjs/data-adapter-observer | 54 | true | false | 5 | true | true | false | emberjs | ember.js | 6,968 |
f7015c62fe24ab448bb14ce9e2df92a16da9b056 | bekzod | bekzod | correctly escape values in assertion | correctly escape values in assertion | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 6,969 |
20f0dddf935ca7ad367f3fe11932c98a24adaf75 | Robert Jackson | GitHub | Merge pull request #15695 from rwjblue/avoid-event-manager-in-non-interactive
[BUGFIX release] Avoid creating event dispatcher in FastBoot with Engines | merge pull request from rwjblue/avoid-event-manager-in-non-interactive | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 6,970 |
decbb29493f99627c3cdff8ebcaafb97c6b9dd42 | Robert Jackson | GitHub | Merge pull request #15699 from bekzod/lazy-assertion
cleanup assertion | merge pull request from bekzod/lazy-assertion | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 6,971 |
25229042494dc9374ff0cda5fe7d960bea61114a | bekzod | bekzod | cleanup assertion | cleanup assertion | 17 | false | false | 2 | false | false | false | emberjs | ember.js | 6,972 |
ea84510d7905ceec6cda89b187f083c296cc956a | Robert Jackson | GitHub | Merge pull request #15685 from bekzod/update-rsvp
bump `rsvp` | merge pull request from bekzod/update-rsvp | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 6,973 |
28c2e552a432bb974640957ff2d2a1f503ad04e7 | bekzod | bekzod | [BUGFIX release] bump `rsvp` | [bugfix release] bump `rsvp` | 28 | false | false | 4 | false | false | false | emberjs | ember.js | 6,974 |
df5d28d0fa66dc91feae4b16da0ef36f7f6797b5 | bekzod | bekzod | move accessing meta out of the loop | move accessing meta out of the loop | 35 | false | false | 7 | false | false | false | emberjs | ember.js | 6,975 |
d540769d02a485a13be1db074183bf53aec0fd1d | bekzod | bekzod | remove redundant `if` check | remove redundant `if` check | 27 | false | false | 4 | false | true | false | emberjs | ember.js | 6,976 |
6e9a9c134a9f65a02f29621461b8972ee017af8f | Robert Jackson | Robert Jackson | [BUGFIX release] Avoid creating event dispatcher in FastBoot with Engines
Prior to this commit, the `event_dispatcher:main` was always being
instantiated so that it can be injected eagerly into child engines. In
general, this is good (we should only ever have a single event
dispatcher going) but in the FastBoot case the event dispatcher should
not have been created at all (since there is no DOM or interactivity
booting the event dispatcher to listen to DOM events is wasteful and
error prone).
This commit updates the EventDispatcher base class to properly look for
the `isInteractive` flag (which is what it should have been doing all
along) on the `-environment:main` that is injected from the
`Application.visit` API. When `isInteractive` is falsey and the event
dispatcher is instantiated we will issue an assertion.
We also avoid eagerly looking up (and therefore forcing to initialize)
the EventDispatcher if `.visit` API is passed `isInteractive: false`.
This avoids the specifically reported issue of triggering an assertion
in FastBoot mode. | [bugfix release] avoid creating event dispatcher in fastboot with engines | 73 | false | false | 10 | false | false | false | emberjs | ember.js | 6,977 |
ed381d7003ce87dde032d6edae6c19bcf4d37c79 | Robert Jackson | GitHub | Merge pull request #15689 from kratiahuja/fastboot-error-template
[BUGFIX lts] Mark error as handled before transition for error routes and substates | merge pull request from kratiahuja/fastboot-error-template | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 6,978 |
6e32f4e0116645204288f0aa937141d197aa2822 | Krati Ahuja | Krati Ahuja | [BUGFIX lts] Add failing test for error template | [bugfix lts] add failing test for error template | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 6,979 |
9e24c7c87b820539aa54235d6ff463ab4166da65 | Robert Jackson | GitHub | Merge pull request #15687 from sduquej/sd/empty
[DOC release] Update description of value returned by Ember.computed.empty | merge pull request from sduquej/sd/empty | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 6,980 |
b3088d4d1b582b70a586497b6e737d5435cb7085 | Sebastián Duque | Sebastián Duque | Update description of value returned by Ember.computed.empty | update description of value returned by ember.computed.empty | 60 | false | false | 7 | true | false | false | emberjs | ember.js | 6,981 |
862321f9bb0bb842c25358f12262f8271c10c3da | Robert Jackson | GitHub | Merge pull request #15616 from emberjs/document-router-service
[DOC release] Improve documentation for RouterService and mount helper | merge pull request from emberjs/document-router-service | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 6,982 |
b8e786c5fd1025532468fb68420d095d412139d2 | Ricardo Mendes | Ricardo Mendes | [DOC release] Improve documentation for RouterService and mount helper
Fixes #15622 | [doc release] improve documentation for routerservice and mount helper | 70 | false | false | 9 | false | false | false | emberjs | ember.js | 6,983 |
04b6f42ca7f5ae90be91b9759ba2a3c6b3322d82 | Robert Jackson | GitHub | Merge pull request #15600 from emberjs/improve-test-debugging
[BUGFIX LTS] ensure “pause on exception” pauses in the right place | merge pull request from emberjs/improve-test-debugging | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 6,984 |
db55502dee8d6eb31f31d88bf407ccc17b7d1e9c | Robert Jackson | Robert Jackson | [BUGFIX lts] Fix test issues exposed by not swallowing errors.
Previously, due to always running within a try/catch these errors were
swallowed in production build test runs. | [bugfix lts] fix test issues exposed by not swallowing errors | 61 | false | false | 10 | false | false | false | emberjs | ember.js | 6,985 |
6e245236e2c7afab725ed83f4d06a5d0378aca32 | Robert Jackson | Robert Jackson | [BUGFIX beta] Cleanup test to ensure `backburner._platform` is present.
Previously, this test assumed that the only value on
`backburner._platform` that was required was `setTimeout`. As of
Backburner 1.2.1 this is no longer true (it also requires `.now()`), and
really should not have been assumed to begin with.
This change simply ensures that `backburner._platform` continues to have
all the same methods on it, but uses the test override of `setTimeout`
to run its assertions. | [bugfix beta] cleanup test to ensure `backburner._platform` is present | 70 | false | false | 9 | false | false | false | emberjs | ember.js | 6,986 |
8ad2db4cb6fc35ccbe40cf726a47573e0a8712a9 | Robert Jackson | Robert Jackson | [BUGFIX release] Update backburner.js to 1.2.1.
The diff between [v1.1.0 and
v1.2.0](https://github.com/BackburnerJS/backburner.js/compare/v1.1.0...v1.2.1)
includes the following changes:
* Allow `onError` to be late bound (and recalculated for each flush).
* Make `now()` late bound (allowing for things like
`sinon.useFakeTimers()`). | [bugfix release] update backburner.js to 1.2.1 | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 6,987 |
54040ec8825f3251fc2e5c6169eeb92c0a787704 | Stefan Penner | Robert Jackson | [BUGFIX LTS] ensure “pause on exception” pauses in the right place
It is quite common (like in ember-data’s tests) to not have a global onError handler in tests.
But because of the previous state of code, we would still end up paused in the default dispatchError rather then where the actual error was thrown.
This addresses the issue, but ensuring onErrorTarget.onerror returns undefined if no onError has been set | [bugfix lts] ensure “pause on exception” pauses in the right place | 66 | false | false | 11 | false | false | false | emberjs | ember.js | 6,988 |
c3777881575c37f06ec7f2b9f6081a473f1e098d | Robert Jackson | GitHub | Merge pull request #15672 from rwjblue/update-router-js
Update router_js to 2.0.0. | merge pull request from rwjblue/update-router-js | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 6,989 |
d31f0d1a6ead3a80f4aac67a0fff4ac4ce744547 | Robert Jackson | GitHub | Merge pull request #15676 from Serabe/fix/15675
[BUGFIX beta] Fix range input values | merge pull request from serabe/fix/15675 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 6,990 |
e9399bfdcea7c0580ae6e24ec5cef372af4d6086 | Robert Jackson | Robert Jackson | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update to use classes throughout the repo.
* Ensure `Route.prototype.serialize` is called bound to the route
instance. | update router_js to 2.0.0 | 25 | false | false | 4 | true | true | true | emberjs | ember.js | 6,991 |
dc7bf1a2fbb9b585ab541b95d88b33a6b1658261 | Dan Gebhardt | GitHub | Merge pull request #15636 from Serabe/fix/15630-private
[DOC beta] Mark getEngineParent as private | merge pull request from serabe/fix/15630-private | 49 | true | false | 5 | true | true | false | emberjs | ember.js | 6,992 |
9656b431c363d460e44064587c3a9b76b03b6e02 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Fix range input values
If an input a type range is set after value but before min and max, it
produces different results than done in markup.
Given IE9 does not support range inputs, tests first make sure that the
type of the input is range.
Closes #15675 | [bugfix beta] fix range input values | 36 | false | false | 6 | false | false | false | emberjs | ember.js | 6,993 |
6c5db5a4ae3a4fd47a1dc8c0a9d359ff7b1bd377 | Robert Jackson | GitHub | Merge pull request #15644 from kellyselden/patch-2
run Travis on tagged builds | merge pull request from kellyselden/patch-2 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 6,994 |
61b0605e42cf441b53752cbdec8fdb5eee71c8a0 | Robert Jackson | GitHub | Merge pull request #15665 from rwjblue/prevent-errors-finding-router
Fix error & loading (sub-)states with async handlers. | merge pull request from rwjblue/prevent-errors-finding-router | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 6,995 |
70dbb0ace0e9f2e341f70b1ca7c7286dd4e5e53b | Ricardo Mendes | GitHub | Merge pull request #15623 from emberjs/tweak-rubygem-version
[INTERNAL] Use JSON.parse to fetch version number | merge pull request from emberjs/tweak-rubygem-version | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 6,996 |
e2885604a90bc4313f7a8494ea1e23e535055489 | Ricardo Mendes | Ricardo Mendes | [INTERNAL] Fetch version number from package.json
The json gem has been part of the Ruby stdlib for a while now.
With this change, we mirror what is done in the Ember Data codebase. | [internal] fetch version number from package.json | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 6,997 |
0e590f5a81e6db0cbdc36573146f462945c979f1 | Robert Jackson | GitHub | Merge pull request #15654 from bekzod/clean-map
convert to es6 `OrderedSet` `Map` `MapWithDefault` | merge pull request from bekzod/clean-map | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 6,998 |
b03b716110b8e661223d574b1cdc9ef53dfe95d7 | Ricardo Mendes | GitHub | Merge pull request #15667 from bekzod/zero-key
[BUGFIX beta] allow numeric `0` key to work with `get` helper | merge pull request from bekzod/zero-key | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 6,999 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.