sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
e4f4b8f532b208144f6400a7df2d8c113058645b | Robert Jackson | GitHub | Merge pull request #15312 from rwjblue/avoid-refreezing
[BUGFIX release] Avoid re-freezing already frozen objects. | merge pull request from rwjblue/avoid-refreezing | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 7,400 |
2e01276c2a4c0eee51669f3e12092dcf720fb46a | Robert Jackson | Robert Jackson | Add 2.14.0-beta.3 to CHANGELOG.md.
[ci skip] | add 2.14.0-beta.3 to changelog.md | 33 | false | false | 4 | true | true | true | emberjs | ember.js | 7,401 |
567b1d75f7da75d86af20f3cfcda4ec20cc7aafe | Robert Jackson | Robert Jackson | [BUGFIX release] Avoid re-freezing already frozen objects.
When a helper is invoked we pass in the arguments, those arguments
are frozen (via Object.freeze) so that helpers can't mutate them
(and cause issues in the rendering engine itself). When a helper
doesn't have hash arguments, we use a shared `EMPTY_HASH` empty
object to avoid allocating a bunch of empty objects for no reason
(we do roughly the same thing when no positional params are
passed). Since these objects are shared they are being frozen
over and over again (throughout the lifetime of the running
application). Turns out that there is what we think is almost
certainly a bug in Chrome, where re-freezing the same object many
times starts taking significantly more time upon each freeze
attempt.
This change introduces a guard to ensure we do not re-freeze repeatedly.
Thanks to @krisselden for identifying the root cause and reporting
the upstream Chrome bug: https://bugs.chromium.org/p/v8/issues/detail?id=6450 | [bugfix release] avoid re-freezing already frozen objects | 57 | false | false | 7 | false | false | false | emberjs | ember.js | 7,402 |
eff9312c7db81bbdfa3e738ad9fb3d0285855f34 | Robert Jackson | GitHub | Merge pull request #15310 from rwjblue/avoid-message-generation
[BUGFIX beta] Update babel-plugin-debug-macros to 0.1.10. | merge pull request from rwjblue/avoid-message-generation | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 7,403 |
5291c74d5ec0125161e8b7c72d7c6b0688efb4b2 | Robert Jackson | Robert Jackson | Add 2.13.3 to CHANGELOG.md
[ci skip] | add 2.13.3 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 7,404 |
787e0894144fb498f5350d25a72559217b227403 | Robert Jackson | Robert Jackson | Add 2.13.2 to CHANGELOG.md
[ci skip] | add 2.13.2 to changelog.md | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 7,405 |
f7615bd2817563226d699824e5487b21c84abb97 | Robert Jackson | Robert Jackson | Add 2.13.1 to CHANGELOG.
[ci skip] | add 2.13.1 to changelog | 23 | false | false | 4 | true | true | true | emberjs | ember.js | 7,406 |
5971b940172542566443e3fb57788eb60d4b18a9 | Robert Jackson | Robert Jackson | [BUGFIX beta] Update babel-plugin-debug-macros to 0.1.10.
The primary changes in this version allow us to avoid costly assertion
message generation when the assert predicate would not trigger an
assertion. | [bugfix beta] update babel-plugin-debug-macros to 0.1.10 | 56 | false | false | 6 | false | false | false | emberjs | ember.js | 7,407 |
91dd6bbfe6e7e9dc0a0ec8b2b2759743d3d1e927 | Robert Jackson | GitHub | Merge pull request #15308 from simonihmig/test-event-bubbling
Add EventDispatcher tests for event bubbling | merge pull request from simonihmig/test-event-bubbling | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 7,408 |
c2f40bf6e1cc898a4fa2b7c5e76d7127acbb7bcc | simonihmig | simonihmig | Add EventDispatcher tests for event bubbling | add eventdispatcher tests for event bubbling | 44 | false | false | 6 | true | true | true | emberjs | ember.js | 7,409 |
99004b91c42fa7134f769ed98c890ea434beb43d | bekzod | bekzod | bailout for empty string too in `render` | bailout for empty string too in `render` | 40 | false | false | 7 | false | false | false | emberjs | ember.js | 7,410 |
f183e43ab64fb085ca94b950db052da9cdcd4a6b | Stefan Penner | GitHub | Merge pull request #15263 from bekzod/undef-check
cleanup transitioningIn/transitioningOut | merge pull request from bekzod/undef-check | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 7,411 |
0c26fccadbe45451ebc5f5e991e63f275795da40 | Stefan Penner | GitHub | Merge pull request #15264 from bekzod/cleaner-options
cleaner options passing to registry and container | merge pull request from bekzod/cleaner-options | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,412 |
92d57c5c07935d5424bec6acb29ba374280333f8 | Stefan Penner | GitHub | Merge pull request #15285 from emberjs/privatized-fix
[BUGFIX beta] private registry entries should have names that don’t n… | merge pull request from emberjs/privatized-fix | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,413 |
f4b151f3d6c64c5b1c0835e72b52df1c0b4ecda1 | Stefan Penner | GitHub | Merge pull request #15293 from bekzod/cleanup-disconnect-outlet
small cleanup `disconnectOutlet` | merge pull request from bekzod/cleanup-disconnect-outlet | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 7,414 |
26d238eaf7194b14ba9b630ba884822b4fe8ef4a | Stefan Penner | GitHub | Merge pull request #15302 from bekzod/send-cleanup
cleanup `route/send` | merge pull request from bekzod/send-cleanup | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 7,415 |
3bbdb0fcfc96236ac368d635d5708a25b6947201 | Stefan Penner | GitHub | Merge pull request #15303 from bekzod/small-cleanup-route
route cleanup | merge pull request from bekzod/small-cleanup-route | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 7,416 |
311ce4ad34957c67b6cea841e2a7aa5cb82b413d | Stefan Penner | GitHub | Merge pull request #15301 from bekzod/cleanup-build-options
cleanup `buildRenderOptions` | merge pull request from bekzod/cleanup-build-options | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 7,417 |
580379085265bdda39f4872e39fcc2555b12a055 | bekzod | bekzod | route cleanup | route cleanup | 13 | false | false | 2 | false | false | false | emberjs | ember.js | 7,418 |
ab8769af56b9db4ed2dc893fbad51b27a46b1da4 | bekzod | bekzod | use `slice` directly | use `slice` directly | 20 | false | false | 3 | false | true | false | emberjs | ember.js | 7,419 |
cc6c42e5c293cf4974cb11cced1cdc1c92714f1e | bekzod | bekzod | turned throw error to assertion | turned throw error to assertion | 31 | false | false | 5 | false | false | false | emberjs | ember.js | 7,420 |
91860f6b87bdbf54e3bc771bc0ed1e1c1a46dfc5 | bekzod | bekzod | buildRenderOptions cleanup | buildrenderoptions cleanup | 26 | false | false | 2 | false | false | false | emberjs | ember.js | 7,421 |
40d1953d23799bc12f19b99e1e1ca05792061a9a | Robert Jackson | GitHub | Merge pull request #15300 from rwjblue/beef-up-unregister-tests
Beef up tests around `owner.unregister`. | merge pull request from rwjblue/beef-up-unregister-tests | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 7,422 |
92904171a53819e10bbdc761bb102d0643a50b49 | Robert Jackson | Robert Jackson | Fix runnable tests configuration. | fix runnable tests configuration | 32 | false | false | 4 | false | true | false | emberjs | ember.js | 7,423 |
9fcf1a72cf6a8a1613f006842a5a868a241b146b | Robert Jackson | Robert Jackson | Beef up tests around `owner.unregister`.
While attempting to run down a reported issue around `owner.unregister`
I updated this test to have more assertions/scenarios just to confirm
all was working properly.
Seems fine to keep around... | beef up tests around `owner.unregister` | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 7,424 |
91d8f08ddc030dd02bca4a331860fc2805f0bb21 | Robert Jackson | GitHub | Merge pull request #15245 from emberjs/bump-glimmer
Bump glimmer-vm packages to 0.24. | merge pull request from emberjs/bump-glimmer | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 7,425 |
d42a2a6c3a9db4af37e3174b8e5c5d6916578b9d | Robert Jackson | GitHub | Merge pull request #15295 from bekzod/throw-to-assert
converted throw error to assertion | merge pull request from bekzod/throw-to-assert | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,426 |
d5f21b526c926768a50e126706baf4340673bc4f | Robert Jackson | GitHub | Merge pull request #15294 from bekzod/cleanup-core-object
micro optimizations in core-object | merge pull request from bekzod/cleanup-core-object | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 7,427 |
b39b4ffec3bdc676d1e2685f5b85d01f4101a464 | Robert Jackson | GitHub | Merge pull request #15292 from bekzod/remove-redundant-prop
removed `namePassed` flag | merge pull request from bekzod/remove-redundant-prop | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 7,428 |
28cda590edc771b8979113c1d0dae8fa714e7c18 | Robert Jackson | GitHub | Merge pull request #15297 from bekzod/combine-assign
combine assign | merge pull request from bekzod/combine-assign | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 7,429 |
603796b5d0d05bf5fd3e56f83789138d30a4f5ba | Robert Jackson | GitHub | Merge pull request #15298 from bekzod/reuse-owner
reuse owner | merge pull request from bekzod/reuse-owner | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 7,430 |
0d1a1b84ec4600d45e702a70bc0c91ade1332895 | bekzod | bekzod | reuse owner | reuse owner | 11 | false | false | 2 | true | true | false | emberjs | ember.js | 7,431 |
2d4d2f41ce9af311c0095749e6fdd84b6a01ad57 | bekzod | bekzod | combine assign | combine assign | 14 | false | false | 2 | true | true | false | emberjs | ember.js | 7,432 |
e90763da2df0014cdb7ef725e2f650df2dd4203d | Ricardo Mendes | GitHub | Merge pull request #15296 from bekzod/remove-redundant-import
removed unused import | merge pull request from bekzod/remove-redundant-import | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 7,433 |
baade2069d1e34a0f15f767616403401e908fd66 | bekzod | bekzod | removed unused import | removed unused import | 21 | false | false | 3 | false | false | false | emberjs | ember.js | 7,434 |
33391a82bb6193c677c4b04df9e8597bf7dcc713 | Robert Jackson | Robert Jackson | Migrate default component manager hooks to abstract base class. | migrate default component manager hooks to abstract base class | 62 | false | false | 9 | false | false | false | emberjs | ember.js | 7,435 |
1a616bedd6b73da3416b044ee3f470073fb57823 | bekzod | bekzod | small cleanup `disconnectOutlet` | small cleanup `disconnectoutlet` | 32 | false | false | 3 | false | false | false | emberjs | ember.js | 7,436 |
94107135ed1876d7cc63f092de75d4dd3f97c106 | bekzod | bekzod | converted throw error to assertion | converted throw error to assertion | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 7,437 |
9231d6695a2abe63e95b437d6702ef37d69477c9 | bekzod | bekzod | micro optimizations | micro optimizations | 19 | false | false | 2 | false | false | false | emberjs | ember.js | 7,438 |
1884d9f1a44c85871e4e4c8235a6b54d13ff9415 | bekzod | bekzod | removed `namePassed` flag | removed `namepassed` flag | 25 | false | false | 3 | false | false | false | emberjs | ember.js | 7,439 |
9b66427f5c6b1937823f2f12be30c7f146ea0ee5 | Stefan Penner | GitHub | Merge pull request #15289 from rwjblue/update-yarn-lock
Update yarn.lock to use `backburner.js@1.0.0`. | merge pull request from rwjblue/update-yarn-lock | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 7,440 |
53df92d1da07f2691b3c9731590d146e5f5837b9 | Stefan Penner | GitHub | Merge pull request #15272 from bekzod/cleanup-buildoptions
cleanup `route/render` | merge pull request from bekzod/cleanup-buildoptions | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 7,441 |
d703655a3384d5b985bb4a72adfb9d031103ff3a | bekzod | bekzod | turned error throws to assertion | turned error throws to assertion | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 7,442 |
570b96791ba6e16447b304ad3f02064c4d438e0b | bekzod | bekzod | correct property name | correct property name | 21 | false | false | 3 | false | false | false | emberjs | ember.js | 7,443 |
b58496330b4ddc2ef4b6462a24cb4e8220ecfc42 | Robert Jackson | Robert Jackson | Bump glimmer-vm packages to 0.24.0-beta.4 | bump glimmer-vm packages to 0.24.0-beta.4 | 41 | true | false | 5 | false | false | false | emberjs | ember.js | 7,444 |
8ad80ceb250d0360e84717619b1a0fd32fbfec25 | Robert Jackson | Robert Jackson | Merge remote-tracking branch 'origin/master' into bump-glimmer | merge remote-tracking branch 'origin/master' into bump-glimmer | 62 | true | false | 6 | false | false | false | emberjs | ember.js | 7,445 |
44f8068ade5b917f0a9dae6d80b9d95bcfc9e9f0 | Robert Jackson | Robert Jackson | Update yarn.lock to use `backburner.js@1.0.0`.
Looks like this was not done when the `package.json` was updated. | update yarn.lock to use `backburner.js@1.0.0` | 45 | false | false | 5 | true | true | true | emberjs | ember.js | 7,446 |
1e1d3d5644ece0ba0fffdc82717ec7a3c40d82b8 | Stefan Penner | Stefan Penner | [BUGFIX beta] private registry entries should have names that don’t need to be normalized
Previously they contained a `.` | [bugfix beta] private registry entries should have names that don’t need to be normalized | 89 | false | false | 14 | false | false | false | emberjs | ember.js | 7,447 |
03b64ddfc2225c072410362c88e379f16e55b8bf | Stefan Penner | GitHub | Merge pull request #15282 from emberjs/bump-bb
bump backburner | merge pull request from emberjs/bump-bb | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 7,448 |
f9c102f00f4fe7285e8cbeead9d43d80d1085ee4 | Stefan Penner | Stefan Penner | bump backburner | bump backburner | 15 | true | false | 2 | true | false | false | emberjs | ember.js | 7,449 |
151e702024cd0ab4d16f93b056cd1036ac110485 | Stefan Penner | GitHub | Merge pull request #15271 from bekzod/render-cleanup
`render` method cleanup | merge pull request from bekzod/render-cleanup | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 7,450 |
c41af6104a2dffaa070598810dceb7b2c16b985e | Stefan Penner | GitHub | Merge pull request #15277 from rwjblue/update-router-js
[BUGFIX beta] Update to router_js@1.2.8. | merge pull request from rwjblue/update-router-js | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 7,451 |
35da6c403e683d732c525595863d7a2b8aab827e | Stefan Penner | GitHub | Merge pull request #15278 from rwjblue/remove-lookup-factory-remnants
Remove remaining `_lookupFactory` reference in container proxy. | merge pull request from rwjblue/remove-lookup-factory-remnants | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 7,452 |
de9d7a7355f9e5f1eab9650989d903adb2022988 | Stefan Penner | GitHub | Merge pull request #15280 from bekzod/undefined-check
clean undefined check | merge pull request from bekzod/undefined-check | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,453 |
a2bb741ed83f71d4293e3577d216121332a400a5 | Stefan Penner | GitHub | Merge pull request #15279 from bekzod/cleanup-route
small cleanup `route` | merge pull request from bekzod/cleanup-route | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 7,454 |
1ec2e33c65403abbe258c51db13475ab1c3a1277 | bekzod | bekzod | clean undefined check | clean undefined check | 21 | false | false | 3 | true | false | true | emberjs | ember.js | 7,455 |
c0da1008a324c972a800e6fb3cb840d9f4abd063 | bekzod | bekzod | cleanup `route` | cleanup `route` | 15 | false | false | 2 | false | false | false | emberjs | ember.js | 7,456 |
abe944d2997881ed4502071337cbec79116b1b62 | Robert Jackson | Robert Jackson | Remove remaining `_lookupFactory` reference in container proxy.
This was missed when the rest of `lookupFactory` was landed. | remove remaining `_lookupfactory` reference in container proxy | 62 | false | false | 7 | true | true | false | emberjs | ember.js | 7,457 |
7ba68eae146f975796283013ee9fc9402c86b422 | Robert Jackson | Robert Jackson | [BUGFIX beta] Update to router_js@1.2.8.
Fixes issues with retrying initial transition. | [bugfix beta] update to router_js@1.2.8 | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 7,458 |
fab7a33a36966a840501430d90611f6f0b372a65 | Robert Jackson | Robert Jackson | Bump glimmer-vm packages to 0.24.0-beta.3.
Fixes a few node tests. | bump glimmer-vm packages to 0.24.0-beta.3 | 41 | true | false | 5 | false | false | false | emberjs | ember.js | 7,459 |
3abb295b87caa2bffbcc1f0eea78fa1423ca1038 | Robert Jackson | Robert Jackson | Fix `glimmer-custom-component-manager` feature for glimmer-vm 0.24.x. | fix `glimmer-custom-component-manager` feature for glimmer-vm 0.24.x | 68 | false | false | 6 | false | false | false | emberjs | ember.js | 7,460 |
4461804ac3f4443a8e31421bc3e697463281ce7e | Robert Jackson | Robert Jackson | Update to glimmer-vm 0.24.0-beta.2. | update to glimmer-vm 0.24.0-beta.2 | 34 | false | false | 4 | false | false | false | emberjs | ember.js | 7,461 |
b519467ea93b53df38685e3c2418b5b65e571dad | Robert Jackson | Robert Jackson | Fix `ember-engines-mount-params` feature with glimmer-vm@0.24. | fix `ember-engines-mount-params` feature with glimmer-vm@0.24 | 61 | false | false | 5 | false | false | false | emberjs | ember.js | 7,462 |
a76889e80f3d08897156ea93111816f71a13f2f3 | Robert Jackson | Robert Jackson | Ensure that newly created `PositionalArgumentsReference` implements `PathReference` API. | ensure that newly created `positionalargumentsreference` implements `pathreference` api | 87 | false | false | 8 | false | false | false | emberjs | ember.js | 7,463 |
2c89920db27898fc1691e39134799ea76d83f0cc | Robert Jackson | Robert Jackson | Bump glimmer-vm packages to 0.24.0-beta.1. | bump glimmer-vm packages to 0.24.0-beta.1 | 41 | true | false | 5 | false | false | false | emberjs | ember.js | 7,464 |
3747924382c5526d4bf921a1d6dc5325bf42e38f | Robert Jackson | Robert Jackson | Fix issues with AST transform for `{{this.attrs.foo}}` -> `{{@foo}}`. | fix issues with ast transform for `{{this.attrs.foo}}` -> `{{@foo}}` | 68 | false | false | 9 | true | true | false | emberjs | ember.js | 7,465 |
86fcd7c50cdb42c7d782d7f80190b8e06df965fb | Robert Jackson | Robert Jackson | Fixup layout caching tests. | fixup layout caching tests | 26 | false | false | 4 | false | false | false | emberjs | ember.js | 7,466 |
877dfa93890f06ff16b0c747241c01aa4882c513 | Robert Jackson | Robert Jackson | Fix closure component currying and positional param munging. | fix closure component currying and positional param munging | 59 | false | false | 8 | true | false | false | emberjs | ember.js | 7,467 |
479941a8ac255911253050deb9dfcdba520f234e | Robert Jackson | Robert Jackson | Split component managers out from syntax definition. | split component managers out from syntax definition | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 7,468 |
23b0d101e8fc47b690eefd7cd9e6c08cbc554fc7 | Robert Jackson | Robert Jackson | Merge remote-tracking branch 'origin/master' into bump-glimmer | merge remote-tracking branch 'origin/master' into bump-glimmer | 62 | true | false | 6 | false | false | false | emberjs | ember.js | 7,469 |
2f5f544b2901589f02d953a11e2617fa1e4ae61b | Robert Jackson | Robert Jackson | Update glimmer versions to 0.24.0-alpha.2. | update glimmer versions to 0.24.0-alpha.2 | 41 | false | false | 5 | true | true | true | emberjs | ember.js | 7,470 |
17db59927e40c5556cc45c3ecb30f0a0d02686c1 | bekzod | bekzod | `render` method cleanup | `render` method cleanup | 23 | false | false | 3 | false | false | false | emberjs | ember.js | 7,471 |
e9e2f2b69f625716539b854f4a8934fa945faec8 | Ricardo Mendes | GitHub | Merge pull request #15270 from bekzod/model-for-cleanup
cleanup `modelFor` | merge pull request from bekzod/model-for-cleanup | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 7,472 |
3da5219649a7e2cd2a929468e97b7a11f7641590 | Robert Jackson | Robert Jackson | Remove iterableForObject tests.
These are largely duplication functionality in `{{each-in}}`'s own
tests. They were added as a way to flesh out the iterable implementation. | remove iterableforobject tests | 30 | false | false | 3 | true | true | true | emberjs | ember.js | 7,473 |
8f8559f8275571db5bbb0f7168212e03a031d013 | Robert Jackson | Robert Jackson | Initial pass at supporting "rest arg" style positionals. | initial pass at supporting "rest arg" style positionals | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 7,474 |
7a20aa2fca2f668baae6e8a134f9b8b1097f7fce | Robert Jackson | Robert Jackson | fixup! Fix non-singleton `{{render` tests. | fixup! fix non-singleton `{{render` tests | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 7,475 |
887cd9e12acb7acf8fb35f9e626ee6d4fb7762f9 | Robert Jackson | Robert Jackson | Make test helpers clear up renderers upon teardown.
This is only needed when a catastrophic failure happens that
prevents the normal removal from working. Doing this in the
teardown greatly reduces the number of invalid faulures when
errors occur during rendering. | make test helpers clear up renderers upon teardown | 50 | false | false | 8 | false | true | false | emberjs | ember.js | 7,476 |
56da2139de0f467d394a8f35a696dfe8ef1654cb | Robert Jackson | Robert Jackson | Ensure managers return `null` from `prepareArgs` to "pass through". | ensure managers return `null` from `prepareargs` to "pass through" | 66 | false | false | 9 | false | false | false | emberjs | ember.js | 7,477 |
d8e5b24290e39d296cf664a151aa6b00e0b26263 | Robert Jackson | GitHub | Merge pull request #15254 from twokul/custom-component-manager
[FEATURE glimmer-custom-component-manager] Custom Component Manager | merge pull request from twokul/custom-component-manager | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 7,478 |
931df59aab7a7835e26191285218faca2e81ee84 | Alex Navasardyan | Alex Navasardyan | [FEATURE glimmer-custom-component-manager] Custom Component Manager
This is the first step towards opening up new APIs for Ember.js community as per
[Custom Components RFC](https://github.com/emberjs/rfcs/blob/custom-components/text/0000-custom-components.md).
This will allow the following:
+ add-on authors can now start experimenting with Glimmer API while continue to support existing Ember.js components
+ developers will be able to _opt into_ using custom component managers
This change should be considered cutting-edge and introduced behind a feature flag `GLIMMER_CUSTOM_COMPONENT_MANAGER`.
To enable this feature flag in `config/environment.js` of your Ember application:
```js
module.exports = function(environment) {
let ENV = {
...
EmberENV: {
FEATURES: {
'glimmer-custom-component-manager': true
}
}
};
...
return ENV;
};
```
Or in Glimmer application, `config/environment.js`:
```js
module.exports = function(environment) {
let ENV = {
...
GlimmerENV: {
FEATURES: {
'glimmer-custom-component-manager': true
}
}
};
return ENV;
};
```
After that, you should be able to opt into registering your own component managers:
+ for applications
App with classic structure:
```
my-app/
component-managers/
nyan.js
components/
templates/
components/
nyan-cat.hbs
```
```hbs
{{!- tempates/components/nyan-cat.hbs -}}
{{use-component-manager "nyan"}}
<h1>🐱</h1>
```
App with Module Unification:
```
my-app/
src/
ui/
component-managers/
nyan.js
components/
nyan-cat/
template.hbs
```
```hbs
{{!- src/ui/components/nyan-cat.hbs -}}
{{use-component-manager "nyan"}}
<h1>🐱</h1>
```
+ for add-ons
```
nyan-cat-addon/
addon/
component-managers/
glimmer.js
app/
templates/
components/
nyan-cat.hbs
``` | [feature glimmer-custom-component-manager] custom component manager | 67 | false | false | 5 | false | false | false | emberjs | ember.js | 7,479 |
dc4fc0d6a213362ddd5c90edc6d6db90ec0341bb | Stefan Penner | GitHub | Merge pull request #15267 from bekzod/remove-wrap-func
remove extra wrapping function in `onUpdateURL` | merge pull request from bekzod/remove-wrap-func | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 7,480 |
68e73c3a88bc653650a4d7c8f90aed029fbdca0e | Stefan Penner | GitHub | Merge pull request #14338 from eventualbuddha/no-initializer-name
blueprints: remove explicit names from initializers. | merge pull request from eventualbuddha/no-initializer-name | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 7,481 |
c191d168494a41b4983e96ec9a47867374849f0d | bekzod | bekzod | cleanup `modelFor` | cleanup `modelfor` | 18 | false | false | 2 | false | false | false | emberjs | ember.js | 7,482 |
21696d7f4a4fe7e4d38523c809d594ef16bac9cf | bekzod | bekzod | remove extra wrapping function | remove extra wrapping function | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 7,483 |
15c10d5692f7eb3b354334d03a54c4c6a20a388c | Brian Donovan | Brian Donovan | blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54. | remove explicit names from initializers | 39 | false | false | 5 | true | true | true | emberjs | ember.js | 7,484 |
0aa38187c30e5ade9c07a83ce283c4479e6ac705 | bekzod | bekzod | cleaner options | cleaner options | 15 | false | false | 2 | false | false | false | emberjs | ember.js | 7,485 |
59728929493303cc001b562d814a758ae7c59fc7 | bekzod | bekzod | cleanup transitioningIn/transitioningOut | cleanup transitioningin/transitioningout | 40 | false | false | 2 | false | false | false | emberjs | ember.js | 7,486 |
908af2965c310a4523342d396132121b2f26ec8b | bekzod | bekzod | check for boolean instead of undefined | check for boolean instead of undefined | 38 | false | false | 6 | false | false | false | emberjs | ember.js | 7,487 |
0a0959bea9a239aa2ef47834b840f07fd1b83513 | Ricardo Mendes | GitHub | Merge pull request #15262 from ahmadsoe/emberjs-https
Use https in references to emberjs website | merge pull request from ahmadsoe/emberjs-https | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,488 |
93dd4709a17f1654853575e5d4e1da40df347095 | Stefan Penner | GitHub | Merge pull request #15259 from bekzod/match-test
use `.test` instead of `.match` in `isBlank` | merge pull request from bekzod/match-test | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 7,489 |
2db2c79e647d48dd86b52654d6992977f8d1b4e7 | Ahmad Suhendri | Ahmad Suhendri | Use https in references to emberjs website | use https in references to emberjs website | 42 | false | false | 7 | true | true | true | emberjs | ember.js | 7,490 |
07b28cf21afc7b7219d7c3b51c78c7552c29453b | bekzod | bekzod | avoid creating array in qualifiedRouteName | avoid creating array in qualifiedroutename | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 7,491 |
5c3393920dad5145bae7c76b14f23a109341eb5f | bekzod | bekzod | use test instead of match in `isBlank` | use test instead of match in `isblank` | 38 | false | false | 7 | true | true | true | emberjs | ember.js | 7,492 |
62aaae02656ed14859588dc7edfe34118337e161 | Andreas Solleder | Andreas Solleder | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | fix typos with misspell | 23 | false | false | 4 | true | true | true | emberjs | ember.js | 7,493 |
d3f6ffa976a0f8b9b12baf6347b60508b0278266 | Robert Jackson | Robert Jackson | Fix non-singleton `{{render` tests. | fix non-singleton `{{render` tests | 34 | false | false | 4 | true | true | true | emberjs | ember.js | 7,494 |
aeed4af35fa426135fce5b079a4fd890a765c333 | Robert Jackson | Robert Jackson | Fix `{{action`. | fix `{{action` | 14 | false | false | 2 | false | true | false | emberjs | ember.js | 7,495 |
d44b7d17fe01f4cf48fda41805872ed23ed94fc3 | Robert Jackson | Robert Jackson | Fix `(action`. | fix `(action` | 13 | false | false | 2 | false | true | false | emberjs | ember.js | 7,496 |
15376a8815a21b2800de0b5f49022edcbeb48239 | Robert Jackson | GitHub | Merge pull request #15253 from alexdiliberto/alex-patch-1
[CLEANUP] Output correct `console.log` for `bin/run-tests` | merge pull request from alexdiliberto/alex-patch-1 | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 7,497 |
28f2f50ae870e394c07af6e54bbd75144024c4f9 | Alex DiLiberto | Alex DiLiberto | Output correct `console.log` for `bin/run-tests`
This applies for the 'travis-browsers' case. | output correct `console.log` for `bin/run-tests` | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 7,498 |
68bbd91e93fb8d1307e81238fc2fd0879a842986 | Robert Jackson | Robert Jackson | Fix `{{mut}}`. | fix `{{mut}}` | 13 | false | false | 2 | false | true | false | emberjs | ember.js | 7,499 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.