sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ada50e931a015632bde5c6e56fa2b0286ab2c709 | Robert Jackson | Robert Jackson | [FEATURE ember-unique-location-history-state] Remove feature flagging. | [feature ember-unique-location-history-state] remove feature flagging | 69 | false | false | 5 | false | false | false | emberjs | ember.js | 7,600 |
ece5069e7e6a863be8efaca4681af94e2fe36dcb | Robert Jackson | GitHub | Merge pull request #15181 from rwjblue/cleanup-no-double-extend
[FEATURE ember-no-double-extend] Remove feature flagging and cleanup. | merge pull request from rwjblue/cleanup-no-double-extend | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 7,601 |
cc2450cfec79f85b3162f1c7d6fca3962e33e6db | Robert Jackson | GitHub | Merge pull request #15180 from rwjblue/update-until-for-container
[BUGFIX release] Correct `until` values for `this.container` deprecations. | merge pull request from rwjblue/update-until-for-container | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 7,602 |
c32446792cee3f1006c00b2aa546438693a6cae5 | Robert Jackson | Robert Jackson | Remove usage of `LOOKUP_FACTORY`.
This was added as a "backdoor" to use `container.lookupFactory`
(and its double extend semantics) without triggering a deprecation. | remove usage of `lookup_factory` | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 7,603 |
6fd34603286f76693a70cee4b16259c988d35154 | Robert Jackson | Robert Jackson | Remove `FACTORY_FOR` symbol.
`FACTORY_FOR` was created as a way to internally use the new `.factoryFor`
system, and not worry if `no-double-extend` feature was enabled or disabled.
Now that `ember-no-double-extend` is removed, this can also be removed and
all codepaths that were calling it should now just use `.factoryFor` instead. | remove `factory_for` symbol | 27 | false | false | 3 | false | true | false | emberjs | ember.js | 7,604 |
cd925dd13b706264042b11ec6e7e83ca8f269cd1 | Robert Jackson | Robert Jackson | [FEATURE ember-no-double-extend] Remove feature flagging. | [feature ember-no-double-extend] remove feature flagging | 56 | false | false | 5 | false | false | false | emberjs | ember.js | 7,605 |
d2220816b2451e52c35a78b13c5aa5ca2c094ba8 | Robert Jackson | GitHub | Merge pull request #15177 from rwjblue/take-two-dont-mutate-own-properties
[BUGFIX beta] Avoid creating enumerable properties on all objects created by DI. | merge pull request from rwjblue/take-two-dont-mutate-own-properties | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 7,606 |
93c5cc2df19e1b4bab3e85e8eae2dd3a058feff0 | Robert Jackson | Robert Jackson | [BUGFIX release] Correct `until` values for `this.container` deprecations.
These deprecations were added in the Ember 2.3 cycle, before we had established
the LTS system and how private API deprecations are handled. Per the rules
we created around private API deprecations, the `until` value is supposed to be
the version just after the next LTS. In theory, that means this could have been
2.5.0 originally, but I'm updating to 2.13.0 because 2.12 was also an LTS.
An emberobserver.com search shows little usage (other than fallbacks when owner
is not found), and very few issues are still open around this sort of `.container`
deprecation. | [bugfix release] correct `until` values for `this.container` deprecations | 73 | false | false | 8 | false | false | false | emberjs | ember.js | 7,607 |
652adeee2d34c0ae1855612b1d26916eb7c3e40a | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid creating enumerable properties on all objects created by DI.
Prior to these changes, every object created via `owner.factoryFor(...).create()`
was populated with `NAME_KEY`, `_debugContainerKey`, and `OWNER`.
After these changes:
* For `Ember.Object`'s, only actual injections are included in the create arguments.
* For non-`Ember.Object`'s, only `OWNER` is included in the create arguments.
`OWNER` is still provided for non-`Ember.Object`'s in order to support various
classes that are used in the rendering layer that expect to be passed `options[OWNER]`
so they can function properly. Examples are `ember-glimmer/environment` and
`ember-glimmer/template`. These should be refactored away from `OWNER` being passed
in, and this fallback should be removed.
A handful of tests were added / updated. In some cases `_debugContainerKey` assertions
were removed, since this is no longer supported configuration (e.g. there is no way to
inject `_debugContainerKey` onto the class itself without double extend). | [bugfix beta] avoid creating enumerable properties on all objects created by di | 79 | false | false | 12 | false | false | false | emberjs | ember.js | 7,608 |
c016eca38cccabdfaafa59cf2744c72c038d5ecc | Robert Jackson | GitHub | Merge pull request #15178 from rwjblue/lookup-controllers-for-_qp
Refactor route to lookup controller for QPs. | merge pull request from rwjblue/lookup-controllers-for-_qp | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 7,609 |
0e941742ecec0682b471c52949eb955b9c8a3dde | Robert Jackson | Robert Jackson | Refactor route to lookup controller for QPs.
Previously, the `_qp` computed property attempted to access properties
off of the `definedControllerClass.proto()`. We even specifically intended
to support accessing other computed properties or injected services to
share query param values on. Unfortunately, this entire system relied on
the old (and deprecated) double extend that was done by `lookupFactory`
(because CPs and service injections all may need access to injections like
`owner`). When `ember-no-double-extend` was introduced a "backdoor" was
added to allow `Route#_qp` to use a non-deprecated version of
`.lookupFactory`.
The original version of `_qp` used `ResolvedController.proto()` as a
performance optimization (to prevent extra instantiation and whatnot),
but at this point using the legacy double extend mechanism and relying
on `.proto()` is causing more trouble than its worth.
This change, makes accessing `_qp` instantiate the controller instances
(without the costly double extend), and simply accesses values on them.
Ultimately, this will force controllers to be instantiated earlier than
previously (though there were no guarantees on _when_ they would be
instantiated). This instantiation _should_ be cheaper than forcing the
double extend for these controllers, and it makes `_qp` much less brittle
since it is now using a standard public API. | refactor route to lookup controller for qps | 43 | false | false | 7 | false | false | false | emberjs | ember.js | 7,610 |
fad719a6a4a40f3fb72d46e9d880fbfba79f462a | Ryan Mark | Ryan Mark | third attempt, with more spaces! | third attempt, with more spaces! | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 7,611 |
d588d9871c9a3649084955bd6dc3d26f9fed4fed | Ryan Mark | Ryan Mark | second attempt at fixing indent. | second attempt at fixing indent | 31 | false | false | 5 | false | false | false | emberjs | ember.js | 7,612 |
0a5a17b10d2abd023bb4d215d2cf1d76cbfa34da | Ryan Mark | GitHub | Fix indentation | fix indentation | 15 | false | false | 2 | true | true | false | emberjs | ember.js | 7,613 |
5710d86690789c8dd2db458edcc3055137494f9d | Ryan Mark | Ryan Mark | inlines _initializeListeners in meta, fixes #15171 | inlines _initializelisteners in meta, fixes | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 7,614 |
ebdc828ddc454a1b71ee1a7cc250573b86fb49c4 | Stefan Penner | GitHub | Merge pull request #15169 from emberjs/avoid-extra-meta-lookup
[BUGFIX Beta] [PERF] avoid extra `meta` lookup in constructor | merge pull request from emberjs/avoid-extra-meta-lookup | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 7,615 |
7932a8d5ff99fcea469bd8c84b26347f041c08b9 | Robert Jackson | GitHub | Merge pull request #15148 from alexspeller/query-params-refreshModel-replace-failing-test
Add failing test for query params replace and refreshModel not working together | merge pull request from alexspeller/query-params-refreshmodel-replace-failing-test | 83 | true | false | 5 | true | false | false | emberjs | ember.js | 7,616 |
67d3f4fbfb69ff3153e63e193ddcd8f3bc41ae54 | Alex Speller | Alex Speller | Add failing test for query params replace and refreshModel not working together | add failing test for query params replace and refreshmodel not working together | 79 | false | false | 12 | true | true | false | emberjs | ember.js | 7,617 |
aa1d66e03c4025e7095c4639b4c896ccfc2a5654 | Robert Jackson | GitHub | Merge pull request #15168 from cibernox/bum-router-js
[BUGFIX] Retry transition created with `replaceWith` causes a history replacement | merge pull request from cibernox/bum-router-js | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,618 |
34705d1d70f08e7038686d5abf139b7a4c72548c | Stefan Penner | Stefan Penner | [BUGFIX Beta] [PERF] avoid extra `meta` lookup in constructor | [bugfix beta] [perf] avoid extra `meta` lookup in constructor | 61 | false | false | 9 | false | false | false | emberjs | ember.js | 7,619 |
651c7d3c065970834c1cab5090d78c90fbea56a5 | cibernox | cibernox | [BUGFIX] Retry transition created with `replaceWith` causes a state replacement
This issue was fixed upstream in router.js, I'm just repeating the information here
for context.
Before this change the next code:
```js
let transition = this.replaceWith('new.route')
transition.abort()
transition.retry();
```
caused the app to transition to `'new.route'` without replacing the previous history entry.
After this change, `Transition#retry` respects the intention of the original transition. In
the snippet above `'new.route'` will now replace the previous route in the history. | [bugfix] retry transition created with `replacewith` causes a state replacement | 79 | false | false | 10 | false | false | false | emberjs | ember.js | 7,620 |
0f1d5f5dbdf46feeb4e6776095a889352d3e04ae | Ricardo Mendes | GitHub | Merge pull request #15161 from mk-conn/ie-issue-15154
resolves #15154 | merge pull request from mk-conn/ie-issue-15154 | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 7,621 |
6d3b250dca285082c16a3683144217c9ad570189 | Krueger, Marko | Ricardo Mendes | [BUGFIX release] Fixes #15154
Usage of `Array#includes` is not supported by IE11. | [bugfix release] fixes | 22 | false | false | 3 | false | false | false | emberjs | ember.js | 7,622 |
adcc0e0394dba9ac167019dcbc3f53809d898b41 | Stefan Penner | GitHub | Merge pull request #15162 from emberjs/cp-14947
CherryPick tests from 14947 | merge pull request from emberjs/cp-14947 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 7,623 |
e36d849d0cd9c210b936fe5642b2aaf469bd1a89 | Stefan Penner | GitHub | Merge pull request #15150 from emberjs/cleanup-proxy
[BUGFIX beta] [PERF] Cleanup Proxy | merge pull request from emberjs/cleanup-proxy | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 7,624 |
b80407b53f882e3932ef739d2200676d8435e340 | Robert Jackson | GitHub | Merge pull request #15163 from rwjblue/avoid-leaking-container
[BUGFIX beta] Avoid storing container on the prototype. | merge pull request from rwjblue/avoid-leaking-container | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 7,625 |
b45ee9d207d8ecca87649de48e427e66044cced8 | Stefan Penner | Stefan Penner | [BUGFIX beta] [PERF] Cleanup Proxy
* remove `on(‘init`, just use the existing `init`
* remove redundant meta lookups
* remove observer (notify proxy change from a unified place, within markObjectAsDirty)
* remove double `tag` lookups
* remove redundant meta guards
* misc cleanup | [bugfix beta] [perf] cleanup proxy | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 7,626 |
4cd5b808a2e62b324a2ca7f25c360ed351e60f83 | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid storing container on the prototype.
In order to support `this.container` (deprecated since 2.3) being available
to objects for backwards compatibility, we define the `container` property
on all classes that we instantiate via normal DI APIs.
The bulk of the work to support this was done in prior refactorings. This
change is targetted at ensuring that we do not leak the container instance
onto the object's prototype in the `CONTAINER_OVERRIDE` slot.
After these changes, we still support all of the APIs that we supported
previously, but will fallback to the current objects owner `__container__`
property (instead of storing it on the prototype directly).
Also, the test being updated here was not providing the `owner` to the
container in the unit test. This test being changed was previously only
doing part of the required setup for creating a `registry` / `container` /
`owner` group. | [bugfix beta] avoid storing container on the prototype | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 7,627 |
a97f8c5c5181c776896591db34216697f199d7a1 | Tomasz Napieralski | Stefan Penner | add test for binding in input type=checkbox | add test for binding in input type=checkbox | 43 | false | false | 7 | true | true | true | emberjs | ember.js | 7,628 |
f44f1d54ce3ffedc1c41309a9746dbfdad570591 | Robert Jackson | GitHub | Merge pull request #15157 from locks/restore-test-scope
Ensure QUnit.test callbacks have proper scope | merge pull request from locks/restore-test-scope | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 7,629 |
73d03e2f5380150b0a2351cd31b905ace6146602 | Ricardo Mendes | Ricardo Mendes | Ensure QUnit.test callbacks have proper scope
Turn arrow functions back into regular function syntax so that the test
has the expected scoping.
Spurred by seeing comments by rwjblue after having merged a PR. | ensure qunit.test callbacks have proper scope | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 7,630 |
21c22ef423da983eb333505a56d1c175beceab2f | Ricardo Mendes | GitHub | Merge pull request #14990 from artemgurzhii/internal-test-helpers
Internal test helpers code refactoring | merge pull request from artemgurzhii/internal-test-helpers | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 7,631 |
98e01ceb9308433023d4e0bc371422526082b2f7 | Robert Jackson | GitHub | Merge pull request #15086 from thorsteinsson/route-blueprint-reset-namespace
[Bugfix beta] Fix route blueprint for --reset-namespace | merge pull request from thorsteinsson/route-blueprint-reset-namespace | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 7,632 |
13a77442a15f2f167a915b82bdcce999fd09c65d | Stefan Penner | GitHub | Merge pull request #15146 from Serabe/fix/supersede-12202
[BUGFIX beta] Improve isArray detection | merge pull request from serabe/fix/supersede-12202 | 51 | true | false | 5 | true | true | false | emberjs | ember.js | 7,633 |
48e1529229c9041d7044c54268151c342598c3d4 | Andrew Schreiber | Sergio Arbeo | [BUGFIX beta] Improve utils.isArray
Now identifies an object with a non-numeric value for `length` as not
an array. | [bugfix beta] improve utils.isarray | 35 | false | false | 4 | false | false | false | emberjs | ember.js | 7,634 |
32da9605754f69bd74cce9db925e82df55eb3d36 | Stefan Penner | GitHub | Merge pull request #15142 from emberjs/dont-leak-container
[BUGFIX release] Don’t leak container while injection deprecated cont… | merge pull request from emberjs/dont-leak-container | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 7,635 |
cb2e27856d08bcb15a9ddebdec578cacf2eb2dcf | Stefan Penner | GitHub | Merge pull request #15141 from emberjs/remove-cp-cache-busting-mixin
[PERF/Correctness] Remove global didDefineProperty | merge pull request from emberjs/remove-cp-cache-busting-mixin | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 7,636 |
b3c03773335b74232b03ecdc0fcf4c9967a0f18e | Robert Jackson | GitHub | Merge pull request #15147 from emberjs/finalize-chains-operates-on-meta
[BUGFIX beta] finishChains should operate on metas | merge pull request from emberjs/finalize-chains-operates-on-meta | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 7,637 |
651d57028da916ffc9c89e05681e20aede9c063c | Stefan Penner | Stefan Penner | [BUGFIX beta] finishChains should operate on metas
Previously, finishChains (run in every EmberObject creation) would have to lookup its own meta, even though the caller already has access to this meta.
* also fix an invalid test (I introduced the test bug here: https://github.com/emberjs/ember.js/commit/e46e056f1d5ed3136efbdf2136febebacd0461c6#commitcomment-21779571) | [bugfix beta] finishchains should operate on metas | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 7,638 |
e95112888464823ebbd91f368a667e24fff19ce2 | Stefan Penner | Stefan Penner | cleanup docs | cleanup docs | 12 | false | false | 2 | false | false | false | emberjs | ember.js | 7,639 |
c68ea416607fa33732ac94f93fc2edb43055d675 | Stefan Penner | Stefan Penner | [BUGFIX release] Don’t leak container while injection deprecated container | [bugfix release] don’t leak container while injection deprecated container | 74 | false | false | 9 | false | false | false | emberjs | ember.js | 7,640 |
ecff7b8bc7803fcf0ee33b9ef95e6cef6f30a15f | Stefan Penner | Stefan Penner | [BUGFIX beta] Remove global didDefineProperty
* removes an extra mixin from all Object Hierarchies
* only runs when actually defining a CP if actually defining a new computed property.
* misc cleanup | [bugfix beta] remove global diddefineproperty | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 7,641 |
c1d8f4e7b5d3e49e3b701a2c7f3b7945a09f4b10 | Stefan Penner | GitHub | Merge pull request #15134 from emberjs/cleanup-flag
remove old deprecation flag in Map/OrderedSet | merge pull request from emberjs/cleanup-flag | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 7,642 |
f4bb5e83916bf0e514b7f97b362a9e4f7b350c8c | Ricardo Mendes | GitHub | Merge pull request #15136 from marpo60/patch-1
Fix documentation | merge pull request from marpo60/patch-1 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 7,643 |
e33522449192c1f7285dbc856d9be1f684018982 | Marcelo Dominguez | GitHub | Fix documentation | fix documentation | 17 | false | false | 2 | true | true | false | emberjs | ember.js | 7,644 |
a1e3a9fbf2560ca77a4956780971d83b71eacb14 | Stefan Penner | Stefan Penner | remove old deprecation flag in Map/OrderedSet | remove old deprecation flag in map/orderedset | 45 | false | false | 6 | true | true | true | emberjs | ember.js | 7,645 |
58a2f5549437d4c5187cdb07d749ffcce02691c7 | Stefan Penner | GitHub | Merge pull request #15117 from Serabe/fix/14738
[BUGFIX beta] Make toString safe for arrays too. | merge pull request from serabe/fix/14738 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 7,646 |
2acf4186fad0285894fd0e5dfb8b68945ea32403 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Make toString safe for arrays too.
`ember-utils/to-string` is documented as a `toString` function that supports
objects without a `toString` method.
Arrays do have a string method that is based on their `join` method. This
method spec ([Array.prototype.join in exma262 2017
draft](https://tc39.github.io/ecma262/#sec-array.prototype.join)) is based on
calling `toString` on the objects that form the collection. If an object were
not to have such method, `Array.prototype.toString` would throw and error.
This PR recreates `Array.prototype.join` as closer to the spec as I could,
changing the `ToString` part with the safe version of `toString`.
Fixes #14738 and #15113. | [bugfix beta] make tostring safe for arrays too | 47 | false | false | 8 | false | false | false | emberjs | ember.js | 7,647 |
64afb55df72ea8c924ba5d3808b6f5b65244e413 | Chad Hietala | GitHub | Merge pull request #15066 from chadhietala/we-shave-yaks
[Project Svelte] Add deprecation flags | merge pull request from chadhietala/we-shave-yaks | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 7,648 |
059aed600984d8798a68c09de1b8c33be0be8205 | Danail Nachev | Danail Nachev | Fix access to service:-document in engines | -document in engines | 20 | false | false | 3 | false | false | false | emberjs | ember.js | 7,649 |
8b3ec78620d8582803dc3b39f6c86c1a3e6a03a6 | Chad Hietala | GitHub | Merge pull request #15122 from chadhietala/fix-build-times
Fix the build times to appease Stef | merge pull request from chadhietala/fix-build-times | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 7,650 |
7eb68a399147216daeeeb76347a0db82b6753f02 | Chad Hietala | Chad Hietala | Fix the build times to appease Stef | fix the build times to appease stef | 35 | false | false | 7 | true | true | true | emberjs | ember.js | 7,651 |
8d4ec0019f0810e6c33016fa2cd393a83c6c2e30 | Ricardo Mendes | GitHub | Merge pull request #15127 from olleolleolle/fix/misspellings
Fix misspellings | merge pull request from olleolleolle/fix/misspellings | 54 | true | false | 5 | true | true | false | emberjs | ember.js | 7,652 |
e33cd1e8db58d0a9e016747324711f03f51929e4 | Olle Jonsson | Olle Jonsson | Reword a comment | reword a comment | 16 | false | false | 3 | false | true | false | emberjs | ember.js | 7,653 |
62f6104d5e4debde9bcac9eb93ddf184166f01be | Olle Jonsson | Olle Jonsson | Fix misspellings | fix misspellings | 16 | false | false | 2 | true | true | false | emberjs | ember.js | 7,654 |
57b9802ebe87645990e0e7cdf87ab1b8911c81aa | Ricardo Mendes | GitHub | Merge pull request #15124 from Serabe/fix/15123
[DOC] Update Logo in README | merge pull request from serabe/fix/15123 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 7,655 |
5b3d2197fc143390d8cf15839dea825c2789e438 | Sergio Arbeo | Sergio Arbeo | [DOC] Update Logo in README
Update logo in README. It was fingerprinted and broken. Taking it from
githubusercontent.
Fix #15123 | [doc] update logo in readme | 27 | false | false | 5 | false | false | false | emberjs | ember.js | 7,656 |
919b66547dafda8da2cd5788361cb276d17b5cd4 | Ricardo Mendes | GitHub | Merge pull request #15118 from efx/topic-fix-13686
[DOC beta] document unexpected default behavior | merge pull request from efx/topic-fix-13686 | 44 | true | false | 5 | true | true | false | emberjs | ember.js | 7,657 |
921f9f65334c17876ea83801cf24c22782946c49 | Robert Jackson | GitHub | Merge pull request #15121 from alexander-alvarez/patch-1
fixing bash variable in travis.yml | merge pull request from alexander-alvarez/patch-1 | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 7,658 |
9e184f75bd7f9bcd5688b912561137d344d593f7 | Alex Alvarez | GitHub | fixing bash variable in travis.yml | fixing bash variable in travis.yml | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 7,659 |
697613263c55f105e546e72708f643b64a559f32 | Eli Flanagan | Eli Flanagan | [DOC beta] document unexpected default behavior
documenting issue described in #13686 | [doc beta] document unexpected default behavior | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 7,660 |
d9d5c242df7f5ed85354d303fbba885d09466c3c | Robert Jackson | GitHub | Merge pull request #15112 from trentmwillis/ember-testing
[BUGFIX release] Ensure Ember.Test globals setup when including ember-testing.js | merge pull request from trentmwillis/ember-testing | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 7,661 |
b22a55743d4e235f70dad428cbde94ed37fa7320 | Matthew Beale | GitHub | Merge pull request #15075 from josemarluedke/test-for-router-map
Decouple router_map_test from globals resolver | merge pull request from josemarluedke/test-for-router-map | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 7,662 |
d9286827dca47732b63ba4b4c325d3ede80fedab | Josemar Luedke | Josemar Luedke | Decouple router_map_test from globals resolver | decouple router_map_test from globals resolver | 46 | false | false | 5 | false | true | false | emberjs | ember.js | 7,663 |
df839ae1aa5dd41e52c28084397972eeb409692b | Trent Willis | Trent Willis | [BUGFIX release] Expose path to ember-testing.js | [bugfix release] expose path to ember-testing.js | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 7,664 |
17daea82ea72c94d6f1ea8b5e2fcca3b855335a9 | Trent Willis | Trent Willis | [BUGFIX release] Ensure Ember.Test globals setup when including ember-testing.js | [bugfix release] ensure ember.test globals setup when including ember-testing.js | 80 | false | false | 9 | false | false | false | emberjs | ember.js | 7,665 |
08a6719e2a1fe8babf7c3fa98570425d71f7e7bf | Stefan Penner | GitHub | Merge pull request #14961 from emberjs/duplicate-slashes
[BUGIX release] [Fixes #14925] remove duplicate `/` in pathname | merge pull request from emberjs/duplicate-slashes | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 7,666 |
e255d7360293a8d3ed8441ed25a75096171e8486 | Stefan Penner | GitHub | Merge pull request #15085 from jpadilla/ember-instrument-compiliation
Add missing instrumentation for compilation/lookup phase | merge pull request from jpadilla/ember-instrument-compiliation | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 7,667 |
92ff9b4a806e14b54ec423e2f0aa9ecaa4d153db | Matthew Beale | GitHub | Merge pull request #15100 from stevenwu/controller-for-test
Decouple controller_for test from globals resolver | merge pull request from stevenwu/controller-for-test | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 7,668 |
5e9ce4ac1553a1e51a4f85fe8d96df5a84b50f83 | Matthew Beale | GitHub | Merge pull request #15091 from Gaurav0/decouple_data_adapter_test
Decouple test from the default resolver for data_adapter | merge pull request from gaurav0/decouple_data_adapter_test | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 7,669 |
fe88d54a6d0f2931963584b5ea94004f1793abfb | Stefan Penner | Stefan Penner | [BUGIX release] [Fixes #14925] remove duplicate `/` in pathname
This avoids a DOMException, which interprets duplicate `/` as a security violation and prevents the associated history state modifications. | [bugix release] [fixes ] remove duplicate `/` in pathname | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 7,670 |
2c45a3b28656beb46ec6db7b9561b7a85c9a9056 | Stefan Penner | GitHub | Merge pull request #15107 from emberjs/to-boolean-chains
[BUGFIX beta] avoid toBoolean conversion when possible (chains) | merge pull request from emberjs/to-boolean-chains | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 7,671 |
72cad69c60d717338f81b6bead3a0313eeb4c66d | Stefan Penner | Stefan Penner | [BUGFIX beta] avoid toBoolean conversion when possible (chains) | [bugfix beta] avoid toboolean conversion when possible (chains) | 63 | false | false | 8 | false | false | false | emberjs | ember.js | 7,672 |
6fe971981f983f327b501bf2d9a6956a3f97f2ff | Robert Jackson | GitHub | Merge pull request #15106 from trek/tell-you-what-you-passed
[Cleanup] Introduce a tiny bit more debugging data to warnings about CP dependencies | merge pull request from trek/tell-you-what-you-passed | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 7,673 |
d7c3beda9f296dc594825042ca7c8079be3f9b71 | Trek Glowacki | Trek Glowacki | Introduce a tiny bit more debugging data to warnings about CP dependencies | introduce a tiny bit more debugging data to warnings about cp dependencies | 74 | false | false | 12 | false | false | false | emberjs | ember.js | 7,674 |
4da3cd7eb2ddebfd344303e2d5600ff7ba68108e | Robert Jackson | GitHub | Merge pull request #15105 from sly7-7/patch-1
fix missing 'afterEach' import | merge pull request from sly7-7/patch-1 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 7,675 |
0ed14e78499f08f7744de993bee89903386f3ec1 | Sylvain MINA | GitHub | fix missing 'afterEach' import | fix missing 'aftereach' import | 30 | false | false | 4 | false | true | false | emberjs | ember.js | 7,676 |
385a826793ca5156df2766937b4149b5822c0a2d | Chad Hietala | GitHub | Merge pull request #15104 from chadhietala/bump-rollup
Bump broccoli-rollup@1.2.0 | merge pull request from chadhietala/bump-rollup | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 7,677 |
fe59f2cafbc53b737b5542edbe7549c1e0a4dab0 | Steven Wu | Steven Wu | Improve test names | improve test names | 18 | false | false | 3 | true | true | true | emberjs | ember.js | 7,678 |
1efc74662bb4c22d5c995d2be21f6bfe9a12069d | Chad Hietala | Chad Hietala | Bump broccoli-rollup@1.2.0 | bump broccoli-rollup@1.2.0 | 26 | true | false | 2 | false | false | false | emberjs | ember.js | 7,679 |
93078b3bf4a8eaa4caa93bc7405c7fea0d78b34d | Gaurav Munjal | Gaurav Munjal | Decouple test from the default resolver for data_adapter
Apply Matthew's comments | decouple test from the default resolver for data_adapter | 56 | false | false | 8 | false | true | false | emberjs | ember.js | 7,680 |
4c8efd15e5063fcf200abf13950151071369c827 | Chris Westra | GitHub | Better wording for setupController documentation
One good sentence is better than two. | better wording for setupcontroller documentation | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 7,681 |
c9c7dbcd6d8bb55ccd93bbc3c905fbd0e4eabfd3 | Matthew Beale | GitHub | Merge pull request #15084 from ballPointPenguin/bootstrap-test
Decouple test from the default resolver for system/bootstrap-test | merge pull request from ballpointpenguin/bootstrap-test | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 7,682 |
4496286e6292eb159917039c3ab83be6a3f87eb0 | Matthew Beale | GitHub | Merge pull request #15073 from defraz/master
Decouple controller_test from globals resolver | merge pull request from defraz/master | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 7,683 |
f55a91eb45cccc97a07dc8414bd1c8949e322384 | Robert Jackson | GitHub | Merge pull request #15089 from workmanw/action-double-fire-fix
[BUGFIX release] Fixing IE and Edge issue causing action handlers to be fired twice. | merge pull request from workmanw/action-double-fire-fix | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 7,684 |
77078afeda519391b7880a71c5cbf5edd51f35b6 | Robert Jackson | GitHub | Merge pull request #15078 from habdelra/14754-deprecate-canDispatchToEventManager
[DEPRECATION] #14754 deprecate `canDispatchToEventManager` | merge pull request from habdelra/14754-deprecate-candispatchtoeventmanager | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 7,685 |
999515219eff20f9412e58e10bc425f13b803996 | Robert Jackson | GitHub | Merge pull request #15103 from Serabe/fix/15096
[BUGFIX beta] Allow calling `Ember.warn` without test. | merge pull request from serabe/fix/15096 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 7,686 |
6204a98e892cd81e792964d81f6c786b42682bc1 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Allow calling `Ember.warn` without test.
If `Ember.warn` is called without the `test` parameter, a deprecation message
is triggered.
[RFC
65](https://github.com/emberjs/rfcs/blob/master/text/0065-deprecation-warning-handlers.md)
makes the `test` parameter required for `Ember.deprecate` but not so for
`Ember.warn`.
Fixes #15096 | [bugfix beta] allow calling `ember.warn` without test | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 7,687 |
7f4bc846cefca1eb01b9f381b02d7ed3f34a4a0c | Steven Wu | Steven Wu | Decouple controller_for test from globals resolver | decouple controller_for test from globals resolver | 50 | false | false | 6 | false | true | false | emberjs | ember.js | 7,688 |
49d8e74314a6ce8c80d7cb59882924a315bda44b | Robert Jackson | GitHub | Merge pull request #15099 from chadhietala/1.13-deprecations
Remove 1.13 deprecations | merge pull request from chadhietala/1.13-deprecations | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 7,689 |
f97fae97ef1ead675d26812a1ba610586d7dacc2 | Chad Hietala | Chad Hietala | Remove 1.13 deprecations | remove 1.13 deprecations | 24 | false | false | 3 | true | true | true | emberjs | ember.js | 7,690 |
f8b5a9c74ed789a6d039407962d404dc5fbe0802 | Ricardo Mendes | GitHub | Merge pull request #15083 from mattmarcum/14797-missing-yield-docs
[DOC] update missing yield docs in api #14797 | merge pull request from mattmarcum/14797-missing-yield-docs | 60 | true | false | 5 | true | true | false | emberjs | ember.js | 7,691 |
2430e0f98fbac98011ff73a530ab6c2d8a4f8c43 | Matt Marcum | Matt Marcum | fixup! [DOC] update missing yield docs in api #14797 | fixup! [doc] update missing yield docs in api | 45 | false | false | 8 | false | false | false | emberjs | ember.js | 7,692 |
68101230531f9c96db658178d90318f6a289a488 | Hassan Abdel-Rahman | Hassan Abdel-Rahman | Updating PR #15078 with rwjblue feedback | updating pr with rwjblue feedback | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 7,693 |
92d58783f514b9c62b7e117f7dc87046e71757f0 | Ricardo Mendes | GitHub | Merge pull request #15088 from jkusa/remove-make-array-example
Remove use of private method makeArray in examples | merge pull request from jkusa/remove-make-array-example | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 7,694 |
2d64a0eec73e9c43d276638e19c30923c8748ec1 | Matt Marcum | Matt Marcum | fixup! [DOC] update missing yield docs in api #14797 | fixup! [doc] update missing yield docs in api | 45 | false | false | 8 | false | false | false | emberjs | ember.js | 7,695 |
00e95be311b36426a2bb1ac485a72c96c100c029 | Wesley Workman | Wesley Workman | [BUGFIX release] Fixing IE and Edge issue (#15076) which caused action handlers to be fired twice. | [bugfix release] fixing ie and edge issue which caused action handlers to be fired twice | 89 | false | false | 15 | false | false | false | emberjs | ember.js | 7,696 |
eb3299a85329b559f85ddcc5ef9e845067cdad3b | Martin Muñoz | GitHub | Merge pull request #15080 from devdesai/dd_test_for_14888
add a test to prevent regression of #14888 | merge pull request from devdesai/dd_test_for_14888 | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 7,697 |
482fdf6f09a465c4624298181c7b855d1b7697f7 | Martin Muñoz | GitHub | Merge pull request #15079 from josemarluedke/test-fro-container-debug-adapter
Decouple container_debug_adapter_test from globals resolver | merge pull request from josemarluedke/test-fro-container-debug-adapter | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 7,698 |
7b7e20e2297f63b26dd1dbd3455b63e06b6c591e | José Padilla | José Padilla | Implement feedback from merge party | implement feedback from merge party | 35 | false | false | 5 | true | true | true | emberjs | ember.js | 7,699 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.