sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
dfbf256ac43280982cab5975cb7812c6094027e5 | Robert Jackson | Robert Jackson | Use yarn to ensure builds are consistently reproducible. | use yarn to ensure builds are consistently reproducible | 55 | false | false | 8 | false | true | false | emberjs | ember.js | 8,300 |
cb9959b207a115bbee1715755be1f7c81abdcf39 | Robert Jackson | GitHub | Merge pull request #14389 from rwjblue/avoid-slicing-classNames
Do not slice `classNames` and `classNameBindings` speculatively. | merge pull request from rwjblue/avoid-slicing-classnames | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,301 |
bf6c66e8eb7d1b7804f6b5907063b7a5711c5ed2 | Robert Jackson | GitHub | Merge pull request #14457 from locks/ember-source-cleanup
ember-source related cleanup | merge pull request from locks/ember-source-cleanup | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,302 |
bcb41830cdc586b4c4b783010e64dfa1caab66b1 | Robert Jackson | GitHub | Merge pull request #14462 from mitchlloyd/es-compatibility
Add ES class compatibility tests | merge pull request from mitchlloyd/es-compatibility | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 8,303 |
24fb4f2358c02d1592a1117a06a89d668f69246a | Robert Jackson | GitHub | Merge pull request #14477 from alexspeller/update-route-docs
CLI-ify and improve modelFor docs | merge pull request from alexspeller/update-route-docs | 54 | true | false | 5 | true | true | false | emberjs | ember.js | 8,304 |
04173020ca92ac9671c1802174d4ba01c7b656a4 | Robert Jackson | GitHub | Merge pull request #14501 from emberjs/locks-patch-2-1
[DOC release] Fix typo in `mut` documentation | merge pull request from emberjs/locks-patch-2-1 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,305 |
cf70395099dae1a8cb8ad4a466ce8b29f2f416f2 | Robert Jackson | GitHub | Merge pull request #14533 from Serabe/fix/add-tests-from-14508-fix
[BUGFIX master] Add test for positional params passed explicitly. | merge pull request from serabe/fix/add-tests-from-14508-fix | 60 | true | false | 5 | true | true | false | emberjs | ember.js | 8,306 |
2b29e1caaad7e8456a8c1a334c44d14f74f38288 | Sergio Arbeo | Sergio Arbeo | [BUGFIX master] Add test for positional params passed explicitly.
See #14508 and #14509 for more details on the bug. | [bugfix master] add test for positional params passed explicitly | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 8,307 |
9b803fecb5cacd94c9396511c98f72288804ac50 | Godfrey Chan | Godfrey Chan | CHANGELOGs for v2.10.0-beta.2 [ci-skip]
(cherry picked from commit 8119ce3be121dd699f7de097d79de38c66ebf045) | changelogs for v2.10.0-beta.2 [ci-skip] | 39 | false | false | 4 | false | false | false | emberjs | ember.js | 8,308 |
8f94545ec9629b8ca61c46f0053f2a68a420edc7 | Ricardo Mendes | Ricardo Mendes | Cleans up ember-source | cleans up ember-source | 22 | false | false | 3 | false | false | false | emberjs | ember.js | 8,309 |
267fb272ccb00facd202e590d7917a781220c12e | Godfrey Chan | GitHub | Merge pull request #14520 from tildeio/bump-glimmer
[BUGFIX beta] Bump Glimmer | merge pull request from tildeio/bump-glimmer | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,310 |
8c87e5074a12487a9a45b962c25da247a72fe971 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Bump Glimmer
This pulls in two glimmer-engine bugfixes:
- local variables (block params) should always win over helpers
- stateful/class-based helpers used in `{{#if (my-helper ...)}}` and
other block arguments position are destroyed when the block syntax
switches from default to inverse (and vice versa)
Fixes #14351, #14413 | [bugfix beta] bump glimmer | 26 | false | false | 4 | false | false | false | emberjs | ember.js | 8,311 |
8cc93b64564ea0e7184dbab8db11b7c577973ac8 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Don't rely on non-cached reference
This commit fixes a bug where `OutletComponentReference`
inadvertently relied on broken behavior: it returned `null`, assuming
that that would cause the reference to be rebuilt. But
tildeio/glimmer#337 fixed the underlying bug, causing the reference to
be properly cached. As a result, we need to remember that we rendered a
`null` component, so that swapping back to the original component
replaces the empty component with the rendered component. | [bugfix beta] don't rely on non-cached reference | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 8,312 |
9d35d9c6159bdb245921be0fd5932e5751b1c7b1 | Stefan Penner | GitHub | Merge pull request #14517 from emberjs/render-in-render-queue
[BUGFIX beta] render in the rendering queue | merge pull request from emberjs/render-in-render-queue | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,313 |
2e4d9817df034250904bb15f8e2a8f162f60898f | Stefan Penner | Stefan Penner | [BUGFIX beta] render in the rendering queue
* [FIXES #14516]
* ensure appendOutletView is scheduled
* remove unused functions (rerender, destroy) | [bugfix beta] render in the rendering queue | 43 | false | false | 7 | false | false | false | emberjs | ember.js | 8,314 |
51ec0b50fdc6cc264d2df5cb88af92b079868e49 | Ricardo Mendes | Ricardo Mendes | [DOC release] Fix typo in `mut` documentation | [doc release] fix typo in `mut` documentation | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 8,315 |
9420cdd525f850bcad8408008d9c3b09ee188f2e | Robert Jackson | GitHub | Merge pull request #14506 from pixelhandler/issue-14503
[Doc release] Fix nested contextual component example | merge pull request from pixelhandler/issue-14503 | 49 | true | false | 5 | true | true | false | emberjs | ember.js | 8,316 |
67d116ebf7f1501a87780a6e7aa397fadf98ee48 | Josemar Luedke | Josemar Luedke | Deprecate renderToElement | deprecate rendertoelement | 25 | false | false | 2 | false | true | false | emberjs | ember.js | 8,317 |
06d737424bf5d4a38e59ed15ed721608478b09c4 | Bill Heaton | Bill Heaton | [Doc release] Fix nested contextual component example
- Add both uses, with hash and without
Fixes #14503 | [doc release] fix nested contextual component example | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 8,318 |
30172c7bc91ae86cb61d79dbcd2328abca09570d | Bryan Hickerson | Bryan Hickerson | Remove space from generated unit-tests | remove space from generated unit-tests | 38 | false | false | 5 | true | true | true | emberjs | ember.js | 8,319 |
292bb92758080866f40d54131c1e55432e3eb69a | Kris Selden | GitHub | Merge pull request #14499 from chadhietala/meta-guardian
[Bugfix beta] Guard _object on meta from being set for primitives | merge pull request from chadhietala/meta-guardian | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,320 |
39973200bee19e5433bbb87a8f4fd9656e6ced8b | Chad Hietala | Chad Hietala | [Bugfix beta] Guard _object on meta from being set to primitives
This effects node 0.12.0, because the WeakMap implementation is not to
spec. Also we should never observe a primative type. | [bugfix beta] guard _object on meta from being set to primitives | 64 | false | false | 11 | false | false | false | emberjs | ember.js | 8,321 |
63c1ec3e79f6a105089db77578ea2fd5a19afc5e | Stefan Penner | GitHub | Merge pull request #14493 from emberjs/pr-5591-rebased
Get firstObject/lastObject notifications only when cached | merge pull request from emberjs/pr-5591-rebased | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,322 |
03b9dbc21e1eef88bc5a080dbb500547fe6d55f7 | Standa Opichal | Stefan Penner | [BUGFIX beta] mixin/arrays firstObject/lastObject notifications only when cached
Basically the contents of https://gist.github.com/mmun/877bad33158578a8609b | [bugfix beta] mixin/arrays firstobject/lastobject notifications only when cached | 80 | false | false | 8 | false | false | false | emberjs | ember.js | 8,323 |
e601285bed0e2e108d41a68a61dc2098aac26dd7 | Kris Selden | GitHub | Merge pull request #14485 from emberjs/name-key
remove _toString, always use NAME_KEY | merge pull request from emberjs/name-key | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 8,324 |
b0801b77dce8c546074322f3fed1c9f7ab4df2bb | Robert Jackson | GitHub | Merge pull request #14238 from chadhietala/action-tests
Add non-interactive {{action}} test | merge pull request from chadhietala/action-tests | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,325 |
e9782456b4e094af82cadcbf48e4449bd115da0b | Chad Hietala | GitHub | Merge pull request #14465 from chadhietala/fine-proxy-grains
Move IS_PROXY flag into meta | merge pull request from chadhietala/fine-proxy-grains | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 8,326 |
29dc3a2192d02aef26423f642a1637661ae70ff8 | Chad Hietala | Chad Hietala | Move IS_PROXY flag into meta | move is_proxy flag into meta | 28 | false | false | 5 | true | true | true | emberjs | ember.js | 8,327 |
f381a441f0a963ef4176c86492f41edc642b7a10 | Robert Jackson | Robert Jackson | Update CHANGELOG for 2.9.0
[ci skip] | update changelog for 2.9.0 | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 8,328 |
63c9478c1477ec57f1e51c552ef9c7f529b1d267 | Robert Jackson | Robert Jackson | Add 2.10.0-beta.1 to CHANGELOG.md.
[ci skip] | add 2.10.0-beta.1 to changelog.md | 33 | false | false | 4 | true | true | true | emberjs | ember.js | 8,329 |
f0e63cd0a67b82f39b00088caff007c41556a28b | Kris Selden | GitHub | Merge pull request #14488 from emberjs/fix-engine-layout-cache
[BUGFIX beta] Fix cache key for getCompiledBlock | merge pull request from emberjs/fix-engine-layout-cache | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,330 |
3d6ba02433e4989d288d491b0703d48b0a148bd2 | Kris Selden | Kris Selden | [BUGFIX beta] Fix cache key for getCompiledBlock
Just use the owner on the template since at this
point it already has to have one. | [bugfix beta] fix cache key for getcompiledblock | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 8,331 |
6642ed02badecf954c9467059470dd4be5cace6f | Robert Jackson | GitHub | Merge pull request #14487 from trentmwillis/qp-engines
[BUGFIX] Use routeName instead of fullRouteName in QP meta | merge pull request from trentmwillis/qp-engines | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,332 |
a63e5feef5253b8f70c6cb81738a3301bcb1f6b4 | Trent Willis | Trent Willis | [BUGFIX] Use routeName instead of fullRouteName in QP meta | [bugfix] use routename instead of fullroutename in qp meta | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 8,333 |
f8f259a2e3c1d1c67207acd4027669185287c1db | Stefan Penner | Stefan Penner | remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used) | remove _tostring, always use name_key | 37 | false | false | 5 | true | true | true | emberjs | ember.js | 8,334 |
9b608cd014e84f3525224ca34495245e4e7950a0 | Josemar Luedke | Josemar Luedke | Deprecate {{render}} helper and outlet orphaning | deprecate {{render}} helper and outlet orphaning | 48 | false | false | 6 | false | true | false | emberjs | ember.js | 8,335 |
5988c079bf0b8f9e8d260f81086be023e127a026 | Alex Speller | Alex Speller | CLI-ify and improve route docs
Various updates, mainly cli-ify the docs, also remove references to
`resetNamespace` and fix examples, and remove a section about dynamic code
loading which is pretty misleading for cli based apps | cli-ify and improve route docs | 30 | false | false | 5 | false | false | false | emberjs | ember.js | 8,336 |
77c51f6e80322c9f0bd189be6c3c7bb5054a1bd1 | Robert Jackson | GitHub | Merge pull request #14471 from trentmwillis/qp-async
Support query params in asynchronously loaded routes | merge pull request from trentmwillis/qp-async | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,337 |
78c3afe6f0bb2d8e3ed8bb412666b445d6375814 | Trent Willis | Trent Willis | Add tests for query params with asynchronously loaded routes | add tests for query params with asynchronously loaded routes | 60 | false | false | 9 | true | true | false | emberjs | ember.js | 8,338 |
ac957bcf9fc1eccc72a5af9bf81b519db379cda1 | Trent Willis | Trent Willis | Cache QP meta in BucketCache
This will allow lazily loaded routes/engines to use the BucketCache as its source of truth for QP meta information instead of having to go directly to the Route instance. | cache qp meta in bucketcache | 28 | false | false | 5 | false | false | false | emberjs | ember.js | 8,339 |
fff3400e0e49438dd26de35c6d3bf6189eb9dba8 | Trent Willis | Trent Willis | Move (de)serialization logic for QPs into Router | move (de)serialization logic for qps into router | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 8,340 |
100dc174af0931922379ec993a75a63b369e1f51 | Trent Willis | Trent Willis | Add Router support for QP meta not being present
`_fullyScopeQueryParams` and `_hydrateUnsuppliedQueryParams` now have logic to skip over handlers that haven't loaded and thus can't give `qpMeta` information. Due to this, `_queryParamsFor` will not cache the result of an invocation where some `qpMeta` is missing. This way, when the `qpMeta` is available, it can then be accessed and cached. This solves the issue where QPs were never serializing into the URL during `finalizeQueryParamChange`. | add router support for qp meta not being present | 48 | false | false | 9 | true | true | true | emberjs | ember.js | 8,341 |
29df0f1c1d80d35dfce84ae85a68b58e24f51934 | Trent Willis | Trent Willis | Don't call HandlerInfo#becomeResolved
When calculating post-transition state, we no longer call
becomeResolved because it will attempt to fetch the handler
for that route even though we don't need it to serialize
params information. | don't call handlerinfo#becomeresolved | 37 | false | false | 3 | false | false | false | emberjs | ember.js | 8,342 |
a14421bad1a623dfb27efaece35d14fb3f588efe | Trent Willis | Trent Willis | Don't call getHandler from _queryParamsFor
`Router#_queryParamsFor` now takes a `handlerInfos` array instead of a route name so that it doesn't need to call `getHandler` on the Router.js instance. This is important because an asynchronously loaded Route will return a `Promise` from `getHandler`.
To support the above, several functions now take either a `TransitionState` object or an array of `HandlerInfo` objects instead of a route name and contexts/models to calculate the state. | don't call gethandler from _queryparamsfor | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 8,343 |
04709ff31d9ec9d8254321bed92f494158de31b0 | Trent Willis | Trent Willis | Introduce _setRouteName to allow easy access to fullRouteName in Engines | introduce _setroutename to allow easy access to fullroutename in engines | 72 | false | false | 10 | true | true | false | emberjs | ember.js | 8,344 |
45f1416d8a4fdf66102c0fb959087d3c733d0f21 | Chad Hietala | GitHub | Merge pull request #14476 from chadhietala/fix-willDestroy-hook
Correct willDestroyElement hook timing | merge pull request from chadhietala/fix-willdestroy-hook | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,345 |
855363285dc66ece8eac9f417375bd4d69460e7e | Chad Hietala | Chad Hietala | Correct willDestroyElement hook timing | correct willdestroyelement hook timing | 38 | false | false | 4 | false | false | false | emberjs | ember.js | 8,346 |
900c6fbebb61d9e649cc1db57438f0c003300d00 | Robert Jackson | GitHub | Merge pull request #14475 from trentmwillis/qp-clean
[CLEANUP] Prep for supporting QPs with async getHandler | merge pull request from trentmwillis/qp-clean | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,347 |
8b9ca0cdf5af019f91a87cad4712e4093db1e319 | Robert Jackson | GitHub | Merge pull request #14474 from thoov/update-readme-alignment
Adding a logo + center aligning the README intro section | merge pull request from thoov/update-readme-alignment | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 8,348 |
46a844b1b8fe0e20e7d6836df19811c12b96b3ab | Trent Willis | Trent Willis | [CLEANUP] Document and add tests for BucketCache | [cleanup] document and add tests for bucketcache | 48 | false | false | 7 | false | false | false | emberjs | ember.js | 8,349 |
96a2c7daceae9d49e1ab645f0b4b4c1b3923b54d | Trent Willis | Trent Willis | [CLEANUP] Centralize QP test helper functions | [cleanup] centralize qp test helper functions | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 8,350 |
99fa647e7e53fa8922e0842076817d8662097041 | Travis Hoover | Travis Hoover | Center align readme intro section | center align readme intro section | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 8,351 |
b84dc446715ca4924da3f92dfb1eed33dc1167d9 | Robert Jackson | GitHub | Merge pull request #14467 from trentmwillis/qp-overlap
[CLEANUP] Simplify and add additional overlapping query params tests | merge pull request from trentmwillis/qp-overlap | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,352 |
9bdb604365a33a67e84364f72bf5c63e7f77a12f | Robert Jackson | GitHub | Merge pull request #14466 from trentmwillis/qp-prefix
[CLEANUP] Remove qp.prefix and use qp.controllerName | merge pull request from trentmwillis/qp-prefix | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 8,353 |
db205d5a54d9108c05ce6e980f7ba8d183b6dadd | Trent Willis | Trent Willis | [CLEANUP] Simplify and add additional overlapping query params tests | [cleanup] simplify and add additional overlapping query params tests | 68 | false | false | 9 | false | false | false | emberjs | ember.js | 8,354 |
dfad2c17c0bb5de1067809ed95751417318088a8 | Stefan Penner | GitHub | Update d8-runner.js | update d8-runner.js | 19 | false | false | 2 | true | false | false | emberjs | ember.js | 8,355 |
0de4a96698426e9ee586b6ce994479c1b8bdfb2a | Trent Willis | Trent Willis | [CLEANUP] Remove qp.prefix and use qp.controllerName
Prefix was only ever set to the ctrl property, so removing that helps
simplify the code. Renaming ctrl to controllerName for added clarity. | [cleanup] remove qp.prefix and use qp.controllername | 52 | false | false | 6 | false | false | false | emberjs | ember.js | 8,356 |
0004e08acf295a1748b68622c00e7dbbea93135d | Kris Selden | GitHub | Merge pull request #14464 from chadhietala/fine-grains
Per-Property tagging | merge pull request from chadhietala/fine-grains | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,357 |
7df07a58206252a88d3af4d7ac9edf48ffddc5ea | Chad Hietala | Chad Hietala | Update test sense properties, not objects, are tagged | update test sense properties, not objects, are tagged | 53 | false | false | 8 | false | false | false | emberjs | ember.js | 8,358 |
48b500e6e9fe20f0eaf4b27be33fe12d644e9877 | Chad Hietala | Chad Hietala | Delegate to tagFor if we encounter a property that resolves in a proxy | delegate to tagfor if we encounter a property that resolves in a proxy | 70 | false | false | 13 | false | false | false | emberjs | ember.js | 8,359 |
ad47b7d2723e83404608f0090b12bcb1011fb220 | Chad Hietala | Chad Hietala | Rename tagging functions | rename tagging functions | 24 | false | false | 3 | false | true | false | emberjs | ember.js | 8,360 |
bb46126d07f79edcde330be45bade5ad17fd400c | Godfrey Chan | Chad Hietala | Test out finer-grained observers | test out finer-grained observers | 32 | false | false | 4 | false | false | false | emberjs | ember.js | 8,361 |
83fc16b477bdfca9e784cc3a4a2cc57fa79a095d | Ricardo Mendes | GitHub | Merge pull request #14463 from aldhsu/patch-1
[DOC release] Fix markdown formatting | merge pull request from aldhsu/patch-1 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 8,362 |
6469e2858a788e9dccca9887d977aafbfbf07ac7 | Allen Hsu | GitHub | Update pause_test.js | update pause_test.js | 20 | false | false | 2 | false | false | false | emberjs | ember.js | 8,363 |
4cac4c78c0b53fb5b787894f7e5c1683334e11c4 | Allen Hsu | GitHub | Fix markdown formatting | fix markdown formatting | 23 | false | false | 3 | true | true | true | emberjs | ember.js | 8,364 |
4ccb3b4a6762b0b5afb41a53a92a6882982a8198 | Mitch Lloyd | Mitch Lloyd | Add ES class compatibility tests | add es class compatibility tests | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 8,365 |
ae0ca0f3986c14a53949ed31f5442882a9abfc48 | Robert Jackson | GitHub | Merge pull request #14433 from trentmwillis/qp-tests
[CLEANUP+BUGFIX] Refactor query params tests | merge pull request from trentmwillis/qp-tests | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,366 |
e907e1828849a4611d1c879e6596d74911c2a6f9 | Kris Selden | GitHub | Merge pull request #14450 from chadhietala/fix-willRender-setting
[BUGFIX beta] Fix willRender and willInsertElement ordering and element availability | merge pull request from chadhietala/fix-willrender-setting | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 8,367 |
05401923664590425a5137ea890c294799773cc6 | Stefan Penner | GitHub | Merge pull request #14449 from chadhietala/attrs-with-positional
Added test for attrs in positional params | merge pull request from chadhietala/attrs-with-positional | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 8,368 |
48f2e1d5728229c0f494e11218da2862c9ca47e6 | Stefan Penner | GitHub | Merge pull request #14453 from emberjs/fix-14447
[BUGFIX beta] [FIXES #14447] fix didDestroyElement | merge pull request from emberjs/fix-14447 | 42 | true | false | 5 | true | true | false | emberjs | ember.js | 8,369 |
57815968b6d077d3f52a8630616ec63a3475aa59 | Chad Hietala | Chad Hietala | [BUGFIX beta] Fix willRender and willInsertElement ordering and element availability | [bugfix beta] fix willrender and willinsertelement ordering and element availability | 84 | false | false | 10 | false | false | false | emberjs | ember.js | 8,370 |
e9b33b43056458b84f6dd127da1694ae09ef696e | Stefan Penner | GitHub | Merge pull request #14420 from ming-codes/patch-3
[BUGFIX] Set computed property constructor | merge pull request from ming-codes/patch-3 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,371 |
1ca3fd71c0e018d5669339ecf8bf828b80e2bf19 | Stefan Penner | GitHub | Merge pull request #14435 from emberjs/speculative-change
Ensure constness of this property does not change | merge pull request from emberjs/speculative-change | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,372 |
7925d8868a9fc84e47b165533d6e79596df9e4bc | Stefan Penner | Stefan Penner | initial d8-runner ready to go | initial d8-runner ready to go | 29 | false | false | 5 | false | false | false | emberjs | ember.js | 8,373 |
0909e330d6a108dcf317f2e878a8507c44d5e4d4 | Stefan Penner | Stefan Penner | [BUGFIX beta] [FIXES #14447] fix didDestroyElement
Components via appendTo, must behave the same when torn down via destroy, and the regular rendering system tearing them down. This code-path isn’t as first class as it likely should be, as it only exists for supporting the more legacy style of unit testing. Using the component integration tests, the typical code path is taken. | [bugfix beta] [fixes ] fix diddestroyelement | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 8,374 |
dea43610c557552337004fff2ca73e5fe2daf3d2 | Stefan Penner | GitHub | Merge pull request #14448 from emberjs/fix-14447
[BUGFIX beta] more lifecycle fixes | merge pull request from emberjs/fix-14447 | 42 | true | false | 5 | true | true | false | emberjs | ember.js | 8,375 |
83c25821e470451f2ada8e3df6c205246387fa55 | Stefan Penner | Stefan Penner | [BUGFIX beta] fix did{Init,Receive}Attrs during component append | [bugfix beta] fix did{init,receive}attrs during component append | 64 | false | false | 7 | false | false | false | emberjs | ember.js | 8,376 |
b9b0ba9f16899eada71969f05641d9d34c839489 | Chad Hietala | Chad Hietala | Added test for attrs in positional params | added test for attrs in positional params | 41 | false | false | 7 | false | false | false | emberjs | ember.js | 8,377 |
8cb34f3b65a5aa9848b327b649243aa8728459e5 | Godfrey Chan | GitHub | Merge pull request #14446 from emberjs/fix-attrs-test
Fix attrs test | merge pull request from emberjs/fix-attrs-test | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 8,378 |
b992f1ae3695d54e5837f5a9cef19176a0753651 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Test component unit test+attrs hook | [bugfix beta] test component unit test+attrs hook | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 8,379 |
267a411ca445ddab9896ef270d4426775053da67 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Fix attrs hook test
`willReceiveAttrs` -> `didReceiveAttrs`
It was previously working because of the attrs -> props copying, I
changed it to use a different property, setting it to a different value
and asserting the result to make sure it actually works. | [bugfix beta] fix attrs hook test | 33 | false | false | 6 | false | false | false | emberjs | ember.js | 8,380 |
ded03d033990a44b8a62b67ae87fba7d39433801 | Trent Willis | Trent Willis | [CLEANUP] Clarify refreshModel + loading action behavior | [cleanup] clarify refreshmodel + loading action behavior | 56 | false | false | 7 | false | false | false | emberjs | ember.js | 8,381 |
d1124fa8424ee71125f801bf93e361de29df8a86 | Trent Willis | Trent Willis | [BUGFIX] Check for QP urlKey collisions during lookup instead of serialization
Fixes a bug where QP values can collide on initial page visit | [bugfix] check for qp urlkey collisions during lookup instead of serialization | 78 | false | false | 11 | false | false | false | emberjs | ember.js | 8,382 |
bf619dcc5203b38f368b1681ff58f9253e218c27 | Trent Willis | Trent Willis | [BUGFIX] Throw if dynamic segment and query param collide | [bugfix] throw if dynamic segment and query param collide | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 8,383 |
553383c8f2672f4d3a540a45393442e4f82e753f | Trent Willis | Trent Willis | [CLEANUP] Refactor query params tests | [cleanup] refactor query params tests | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 8,384 |
1b75abfd821b3f3bdcfd8c447dadf71f24be103d | Stefan Penner | GitHub | Merge pull request #14442 from emberjs/revert-post-init-removal
[BUGFIX beta] restore didInitAttrs + didReceiveAttrs to POST_INIT | merge pull request from emberjs/revert-post-init-removal | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,385 |
1babb3bdc1ef494fdaa91ec033c7d565a53cd72e | Stefan Penner | Stefan Penner | [FIXES #14439] [BUGFIX beta] restore didInitAttrs + didReceiveAttrs to POST_INIT | [fixes ] [bugfix beta] restore didinitattrs + didreceiveattrs to post_init | 74 | false | false | 10 | false | false | false | emberjs | ember.js | 8,386 |
e5174c7d196a698cd18a5fb723f5cc6c11642983 | Robert Jackson | GitHub | Merge pull request #14443 from emberjs/read-only-each-cp
mark `@each` cp readOnly | merge pull request from emberjs/read-only-each-cp | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,387 |
6a3706a833b920e61d01e5251d9597caea6bae80 | Stefan Penner | GitHub | Merge pull request #14331 from ssured/patch-5
[DOC] objectAtContent should be public | merge pull request from ssured/patch-5 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 8,388 |
dacff2b11502f904a62c6d17c0cc202e763e0190 | Stefan Penner | GitHub | Merge pull request #14372 from sumn2u/master
added multiple launchers with examples | merge pull request from sumn2u/master | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 8,389 |
9696724527f90b9c8d28ccb980cf3fc693891cdb | Stefan Penner | Stefan Penner | [BUGIFX beta] Ensure constness of this property does not change
As it turns out, V8 stores the following information about properties:
* kind: (raw data, or accessor)
* constness: (const or mutable)
* value: Smi, Double, HeapObject, Tagged
"Currently, V8 tracks constant values only for properties containing JS functions."
source: https://docs.google.com/document/d/1VEeXn6BfKmVkYpfMuxNs3otLLNPIxIVA1cLoSwGMIxI/edit#
So rather then making our UNDEFINED sentinal a function, we make it a very
unique string (which we already do in other parts of the system). | [bugifx beta] ensure constness of this property does not change | 63 | false | false | 10 | false | false | false | emberjs | ember.js | 8,390 |
75a514ce896318cb168a39f757e36fd5c6278de0 | Stefan Penner | Stefan Penner | mark `@each` cp readOnly | mark `@each` cp readonly | 24 | false | false | 4 | false | true | false | emberjs | ember.js | 8,391 |
0533f77b4c87ee5b78b9a7ac3eb569391e0df7ca | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Do not call set on PromiseProxy if destroyed.
Given an object including `PromiseProxy`, if such object is destroyed
before de promise is fullfill, an error is raised. This error is not
obvious from a user point of view.
This PR avoids setting anything if the proxy has been destroyed while
keeping the promise chain intact.
Fixes #14250 | [bugfix beta] do not call set on promiseproxy if destroyed | 58 | false | false | 10 | false | false | false | emberjs | ember.js | 8,392 |
fd20634c74cefa94ae4d3483b1b11d4e7bbd660b | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Remove style warning when the binding is quoted
Given the following template:
```hbs
<div style="{{myStyle}}"></div>
```
It behaves exactly like:
```hbs
<div style={{myStyle}}></div>
```
Fix #11395 | [bugfix beta] remove style warning when the binding is quoted | 61 | false | false | 10 | false | false | false | emberjs | ember.js | 8,393 |
9e2b53a9583c03315468ffcc915731d628867968 | Ricardo Mendes | GitHub | Merge pull request #14432 from san650/remove-unused-arg
Remove unused argument in test | merge pull request from san650/remove-unused-arg | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,394 |
e340677ca739c09d78b9000a8cb6b72a4baee756 | Robert Jackson | GitHub | Merge pull request #13663 from trentmwillis/resume-test
[FEATURE ember-testing-resume-test] Introduce resumeTest helper to complement pauseTest | merge pull request from trentmwillis/resume-test | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,395 |
10a64693f9bed8a949e8dcc4c3e37881925dfe17 | Trent Willis | Trent Willis | [FEATURE ember-testing-resume-test] Introduce resumeTest helper to complement pauseTest | [feature ember-testing-resume-test] introduce resumetest helper to complement pausetest | 87 | false | false | 8 | false | false | false | emberjs | ember.js | 8,396 |
c3fcb378e397afe160a2989a028dd9aeb58e5d4a | Robert Jackson | Robert Jackson | 2.10.0-alpha.1 | 2.10.0-alpha.1 | 14 | false | false | 1 | false | false | false | emberjs | ember.js | 8,397 |
454442b2590e7842a9644eea6e343abd034aeb9b | Robert Jackson | GitHub | Merge pull request #13022 from emberjs/ember-source
provide ember-core from NPM | merge pull request from emberjs/ember-source | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,398 |
3afdbc9cbc07dd5e2fd47cc8d87f4b5827e427ef | Robert Jackson | GitHub | Merge pull request #14339 from Serabe/feature/update-contributing
[DOC] Make public two-week policy for closing issues | merge pull request from serabe/feature/update-contributing | 59 | true | false | 5 | true | true | false | emberjs | ember.js | 8,399 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.