sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1f40774763a83c1ab66d111a3b5a6b4870dd577d | Santiago Ferreira | Santiago Ferreira | Remove unused argument in test | remove unused argument in test | 30 | false | false | 5 | true | true | true | emberjs | ember.js | 8,400 |
eead311032de088f61c9afb95b2cb486e41f1c9b | Robert Jackson | GitHub | Merge pull request #14396 from emberjs/locks-patch-2
Update package.json | merge pull request from emberjs/locks-patch-2 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,401 |
4b1cbe94534b47a27777b4a596a0fe9774d0f4b1 | Ricardo Mendes | GitHub | Update index.js | update index.js | 15 | false | false | 2 | true | false | false | emberjs | ember.js | 8,402 |
aec0fec55e86b842c61df42d8e6050877428e7df | Ricardo Mendes | GitHub | Update package.json | update package.json | 19 | false | false | 2 | true | false | false | emberjs | ember.js | 8,403 |
c3b7c8200c2ba1366d54e8f2e5afab75a45ddea1 | Godfrey Chan | Godfrey Chan | Add CHANGELOG for 2.8.2 [ci skip]
(cherry picked from commit 669560d1e8a8eb4fb2437d32d447c5da78ab3cf0)
(cherry picked from commit 476fa2d4aeec35cd86cf71ee5ad2435b5c84533a) | add changelog for 2.8.2 [ci skip] | 33 | false | false | 6 | true | true | true | emberjs | ember.js | 8,404 |
41e75f0b9368fc0dc11b2a5d437ea7467ec8259b | Godfrey Chan | Godfrey Chan | Add 2.9.0-beta.5 CHANGELOG [ci skip]
(cherry picked from commit 20e567a997f88c136fa7d37d72514e5c272659a3) | add 2.9.0-beta.5 changelog [ci skip] | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 8,405 |
d3ceb22421ededae47f1420eb10b3440f87a6498 | Robert Jackson | GitHub | Merge pull request #14426 from emberjs/promise-resolve-cleanup
Promise.resolve/then works with inheritance already | merge pull request from emberjs/promise-resolve-cleanup | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,406 |
8cb2107d7fffcabdc5fa57fb4e3ba36b6c22c8dd | Robert Jackson | GitHub | Merge pull request #14429 from trentmwillis/test-case-helpers
[CLEANUP] Move TestCase helpers to internal-test-helpers | merge pull request from trentmwillis/test-case-helpers | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,407 |
b685acbbe314aaf0fce5c56afd3478798b2da777 | Godfrey Chan | GitHub | Merge pull request #14403 from emberjs/tagless-will-insert-element
[BUGFIX beta] Fix tagless `willInsertElement` | merge pull request from emberjs/tagless-will-insert-element | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 8,408 |
feed68f7b5733e44911862d64aaa71f2c13af596 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Fix `this.didInitAttrs` deprecation
We don't want to be needlessly reading `this.didInitAttrs` in production
mode. | [cleanup beta] fix `this.didinitattrs` deprecation | 50 | false | false | 5 | false | false | false | emberjs | ember.js | 8,409 |
3caf352959750affe969ed56cbdd090796c74da0 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove unused `ensureViewNotRendering`
This is already covered by the "backtracking re-render" protection. | [cleanup beta] remove unused `ensureviewnotrendering` | 53 | false | false | 5 | false | false | false | emberjs | ember.js | 8,410 |
e31de2c10106545bc7a570ea16e6dd3dc481d985 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove `CoreObject#POST_INIT`
* Just regular `init` for most things
* Use `on('init')` if we have to
* Introduce a private `FrameworkObject` class to assert that init is
called (debug mode only) | [cleanup beta] remove `coreobject#post_init` | 44 | false | false | 4 | false | false | false | emberjs | ember.js | 8,411 |
d6c1670b207fc540f5268c1609b1019f2194a50d | Robert Jackson | GitHub | Merge pull request #14427 from chadhietala/multiple-roots
[BUGFIX beta] Setting in update should render | merge pull request from chadhietala/multiple-roots | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,412 |
9e9731d4064fd156225297ae6ed367beaa066ce3 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove `hasGlimmer` checks | [cleanup beta] remove `hasglimmer` checks | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 8,413 |
02a6088ba3b5cd345da7265573eef1bf933758c1 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove unused `componentInitAttrs` | [cleanup beta] remove unused `componentinitattrs` | 49 | false | false | 5 | false | false | false | emberjs | ember.js | 8,414 |
acffdd92b3ccb3418e4894e78cd663bc33ad81f7 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Fix tagless `willInsertElement`
* Transition into `hasElement` state for tagless components
* Fire `willInsertElement` on tagless components
* Fire `willInsertElement` before firing `willRender` (thus ensuring
`willRender` gets the element as well)
* Add lifecycle tests for tagless components
* Refactor the lifecycle tests to remove some duplications
Fixes #14398 | [bugfix beta] fix tagless `willinsertelement` | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 8,415 |
da67a908791b16f057d82cde612320ae5e176aa6 | Chad Hietala | Chad Hietala | [BUGFIX beta] Setting in update should render | [bugfix beta] setting in update should render | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 8,416 |
b303567fbe1c14a6d7f511bf5539a95e78625654 | Trent Willis | Trent Willis | [CLEANUP] Move TestCase helpers to internal-test-helpers | [cleanup] move testcase helpers to internal-test-helpers | 56 | false | false | 6 | false | false | false | emberjs | ember.js | 8,417 |
5790671e393e95d050d4c26b2731cb2a2aa7c044 | Robert Jackson | GitHub | Merge pull request #14428 from trentmwillis/test-helpers
[CLEANUP] Restructure internal-test-helpers exports | merge pull request from trentmwillis/test-helpers | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,418 |
a74dd2cc8b4fc1807f8a1c3c9e6456858c5c28ce | Trent Willis | Trent Willis | [CLEANUP] Restructure internal-test-helpers exports | [cleanup] restructure internal-test-helpers exports | 51 | false | false | 4 | false | false | false | emberjs | ember.js | 8,419 |
7de4892c45a4d0e8a9cf6383ff3c839c996f210e | Stefan Penner | GitHub | Update promise.js | update promise.js | 17 | false | false | 2 | true | false | false | emberjs | ember.js | 8,420 |
0d445912d1ec83b0c0d178577b555d314b5099c9 | Robert Jackson | GitHub | Merge pull request #14422 from sglanzer/master
Porting additional local-lookup tests | merge pull request from sglanzer/master | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,421 |
70c30db0c1acc4d28f704573f82451aec87ef1da | Chad Hietala | GitHub | Merge pull request #14425 from chadhietala/fix-this-attrs
[BUGFIX beta] Transform `this.attrs` in templates | merge pull request from chadhietala/fix-this-attrs | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,422 |
8c48131571002b63ca38cd5644b0cc1ca0de2b84 | Steven Glanzer | Steven Glanzer | Porting additional local-lookup tests | porting additional local-lookup tests | 37 | false | false | 4 | false | false | false | emberjs | ember.js | 8,423 |
21c9507f74a1af9f8baa73d171fbd1aac29597fd | Stefan Penner | GitHub | tidy-up test-promise/resolve | tidy-up test-promise/resolve | 28 | false | false | 2 | false | false | false | emberjs | ember.js | 8,424 |
40425c1bef13290b258e5d71b49335debfb4dcb6 | Stefan Penner | GitHub | Promise.resolve works with inheritance already
https://github.com/tildeio/rsvp.js/blob/master/lib/rsvp/promise/resolve.js#L40 | promise.resolve works with inheritance already | 46 | false | false | 5 | false | false | false | emberjs | ember.js | 8,425 |
3da025848f61fdf2070580c60ff0f1cf27414e97 | Chad Hietala | Chad Hietala | [BUGFIX beta] Transform `this.attrs` in templates | [bugfix beta] transform `this.attrs` in templates | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 8,426 |
8aeb9dc29fb9be04f1891ff7c0d16a71ea24f109 | Martin Muñoz | GitHub | Merge pull request #14419 from chadhietala/fix-string-len
[BUGFIX beta] Fix string length in a template | merge pull request from chadhietala/fix-string-len | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,427 |
3f900e95f1d9e026ddd3a2765c4fe1cdfd66586e | Chad Hietala | Chad Hietala | [BUGFIX beta] Fix string length in a template | [bugfix beta] fix string length in a template | 45 | false | false | 8 | false | false | false | emberjs | ember.js | 8,428 |
c2030c6ac73b5c5e9653c83a743f741a7972d657 | Ming Liu | GitHub | [BUGFIX] Set computed property constructor | [bugfix] set computed property constructor | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 8,429 |
7d5c764c9d67ce017149ac04acf4a527bb3cc60d | Chad Hietala | GitHub | Merge pull request #14417 from chadhietala/fix-positional-params
[BUGFIX beta] Unimplemented positionalParams should not error | merge pull request from chadhietala/fix-positional-params | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 8,430 |
d3b7e422f0599e53848ae163d239de6471aa05a8 | Chad Hietala | Chad Hietala | [BUGFIX beta] Unimplemented positionalParams should not error | [bugfix beta] unimplemented positionalparams should not error | 61 | false | false | 7 | false | false | false | emberjs | ember.js | 8,431 |
d56b914426147a1a7a111627ff95c1726d327cb4 | Kris Selden | GitHub | Merge pull request #14414 from trentmwillis/cleanup-route-qp
[CLEANUP] Remove ember-routing-route-configured-query-params feature flag | merge pull request from trentmwillis/cleanup-route-qp | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 8,432 |
0f96d18ee895cfcfe880aaa91a2b170ff06a3891 | Kris Selden | GitHub | Merge pull request #14415 from trentmwillis/cleanup-controller-bucket
[CLEANUP] Remove BucketCache from Controllers | merge pull request from trentmwillis/cleanup-controller-bucket | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 8,433 |
0dcfc341d9bb48da2a927d5017a4aa231c5147a0 | Trent Willis | Trent Willis | [CLEANUP] Remove ember-routing-route-configured-query-params feature flag | [cleanup] remove ember-routing-route-configured-query-params feature flag | 73 | false | false | 5 | false | false | false | emberjs | ember.js | 8,434 |
14c953b8588969f86cc2b46ad8003ee2cfef377d | Trent Willis | Trent Willis | [CLEANUP] Remove BucketCache from Controllers | [cleanup] remove bucketcache from controllers | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 8,435 |
94048fd251361f8e1c8ac74331a8245fb89dfef3 | Ricardo Mendes | GitHub | Merge pull request #14411 from tricknotes/fix-features.md-markup
[DOC] Fix markup for FEATURES.md | merge pull request from tricknotes/fix-features.md-markup | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 8,436 |
7d032b0062305825fa268b485bd7b6ffa4f47bd2 | Robert Jackson | GitHub | Merge pull request #14385 from HeroicEric/add-test-for-avoiding-assertion-when-id-is-bound
Avoid assertion when bound `id` is provided to tagless component | merge pull request from heroiceric/add-test-for-avoiding-assertion-when-id-is-bound | 84 | true | false | 5 | true | false | false | emberjs | ember.js | 8,437 |
38fe03495fd7b90ebcfaf70f3b18360795b466b3 | Eric Kelly | Eric Kelly | Avoid assertion when bound `id` is provided to tagless component
See https://github.com/emberjs/ember.js/pull/14382 | avoid assertion when bound `id` is provided to tagless component | 64 | false | false | 10 | true | true | false | emberjs | ember.js | 8,438 |
834b4baa6cd0379570c2050f416816998324be29 | Ryunosuke Sato | Ryunosuke Sato | [DOC] Fix markup for FEATURES.md | [doc] fix markup for features.md | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 8,439 |
e5b7d7edc7b850d6b76869d0ea7e6cdd0f92143a | Robert Jackson | GitHub | Merge pull request #14407 from sglanzer/master
Local lookup component closure test | merge pull request from sglanzer/master | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,440 |
f9a99366cca02a58e61357bca5e936926af2e017 | Steven Glanzer | Steven Glanzer | Local lookup component closure test | local lookup component closure test | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 8,441 |
7d1a708501d8fd0b9a7efa1fa17acfa22be111a8 | Chad Hietala | GitHub | Merge pull request #14402 from chadhietala/better-modify-error
[BUGFIX beta] Better error message for doubly modified property | merge pull request from chadhietala/better-modify-error | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,442 |
9449635a147c4761276e63178a03eb62d5b8a4fe | Robert Jackson | Godfrey Chan | Add 2.9.0-beta.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 26c564f5d18c9097f62bd5f76ebc3261ac7f7f7d) | add 2.9.0-beta.4 to changelog.md | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 8,443 |
620092fb2a5ee86967f1516ca4c49c2ea0443860 | Robert Jackson | Godfrey Chan | Add 2.9.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 40eae514e3ec40e60b68ae2d12a711c4e8eb0d5d) | add 2.9.0-beta.3 to changelog.md | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 8,444 |
754aa793e0d6da40253d0ccdf8438814f7ba9e31 | Chad Hietala | Chad Hietala | [BUGFIX beta] Better error message for doubly modified property | [bugfix beta] better error message for doubly modified property | 63 | false | false | 9 | false | false | false | emberjs | ember.js | 8,445 |
12f4fc0e6142e740a8cc4d566d9f3fbbc0b5a604 | Robert Jackson | GitHub | Merge pull request #14393 from emberjs/locks-patch-4
[DOC release] Introduce code sample for `Ember.Object.set` | merge pull request from emberjs/locks-patch-4 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,446 |
2990c13d8da1226569d2ac81a4f55a427fdf85b9 | Robert Jackson | GitHub | Merge pull request #14399 from imagentleman/patch-1
Fix typo on FEATURES.md | merge pull request from imagentleman/patch-1 | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,447 |
d2836d09ceb36b8beaa8c6acbd226ea1dbab9cf9 | José Antonio Chio | GitHub | Fix typo on FEATURES.md | fix typo on features.md | 23 | false | false | 4 | true | true | true | emberjs | ember.js | 8,448 |
5857213b7d7c6dd6d4742b825d92d2a8bd395b7e | Robert Jackson | GitHub | Merge pull request #14392 from emberjs/locks-patch-3
[DOC release] Use `Ember.computed` | merge pull request from emberjs/locks-patch-3 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,449 |
0e7668d11ff8cf57f95921bf4cdd7cd9722e355d | Robert Jackson | GitHub | Merge pull request #14394 from emberjs/locks-patch-3-1
[DOC release] Add code sample to Ember.set | merge pull request from emberjs/locks-patch-3-1 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,450 |
f909d0be10a2e9e6c5d4a60693abfd222532af23 | Robert Jackson | GitHub | Merge pull request #14395 from emberjs/locks-patch-5
[DOC release] Add code sample to Ember.get | merge pull request from emberjs/locks-patch-5 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,451 |
0224f81e3a40098ccccc34760e302f4c2bd38f93 | Robert Jackson | Robert Jackson | Ensure concatenated properties are frozen.
Mutating objects on the prototype (which includes concatenated
properties) is not good. This changes the functionality of concatenated
properties to freeze the resulting array while in debug mode, to make it
clear that mutating them without slicing first is not good. | ensure concatenated properties are frozen | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 8,452 |
18debdf69ac6518c36a4206d0ddb486ca9a6a5fd | Godfrey Chan | GitHub | Merge pull request #14355 from ef4/refactor-curly-args
Refactoring curly component argument processing | merge pull request from ef4/refactor-curly-args | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,453 |
09140df52f60af66a18944da1dfaf28d8c3906a0 | Robert Jackson | Robert Jackson | Avoid mutating the shared `queryParams` array on the prototype. | avoid mutating the shared `queryparams` array on the prototype | 62 | false | false | 9 | false | false | false | emberjs | ember.js | 8,454 |
3854b35691af86f7394d77fa15ac156964477301 | Ricardo Mendes | GitHub | Update package.json | update package.json | 19 | false | false | 2 | true | false | false | emberjs | ember.js | 8,455 |
8b691eb9231e45a558e6b5b7bf11cc2100b45d1a | Edward Faulkner | Edward Faulkner | Refactoring curly component argument processing
This cleans up and unifies the handling of curly comopnent arguments. It splits the work into two distinct phases
- gatherArgs assembles an EvaluatedArgs that combines all variations of positional and named arguments into a single EvaluatedArgs object
- ComponentArgs.create takes the EvaluatedArgs and produces the curly-component specific attrs & props structures with mutable cells, etc. | refactoring curly component argument processing | 47 | false | false | 5 | false | false | false | emberjs | ember.js | 8,456 |
e1fa90d72acbbda24037232ef8dcb859850e1d60 | Ricardo Mendes | Ricardo Mendes | [DOC release] Use `Ember.computed`
Replace function prototype extension with `Ember.computed` | [doc release] use `ember.computed` | 34 | false | false | 4 | false | false | false | emberjs | ember.js | 8,457 |
5aeee3ffe4397e95340265fdc2de0d03698790db | Ricardo Mendes | Ricardo Mendes | [DOC release] Add code sample to Ember.set | [doc release] add code sample to ember.set | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 8,458 |
b059ca50597b160d90a34b796ac240319390dcc3 | Ricardo Mendes | Ricardo Mendes | [DOC release] Introduce code sample for `Ember.Object.set` | [doc release] introduce code sample for `ember.object.set` | 58 | false | false | 7 | false | false | false | emberjs | ember.js | 8,459 |
cd8b3f60effa776428818c0f5e462a3cfd2958ad | Ricardo Mendes | Ricardo Mendes | [DOC release] Add code sample to Ember.get | [doc release] add code sample to ember.get | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 8,460 |
8e1374c27a2ca521b461983432d17fc5a8cd44b4 | Robert Jackson | GitHub | Merge pull request #14391 from emberjs/locks-patch-2
[DOC release] Make inline code-samples equivalent | merge pull request from emberjs/locks-patch-2 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,461 |
12e3ec069b41c5151b16f60703b5fe0558a54fe3 | Robert Jackson | GitHub | Merge pull request #14390 from toranb/layoutCPFix
[BUGFIX beta] layout now supports computed property | merge pull request from toranb/layoutcpfix | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,462 |
5a8f3cb97ef3b881beb4f780ef93b869086a51d8 | Ricardo Mendes | GitHub | [DOC release] Merge pull request #14341 from ziggythehamster/doc-ember-route-since
Add @since doc tags to everything in Ember.Route that didn't already have it | [doc release] merge pull request from ziggythehamster/doc-ember-route-since | 76 | false | false | 7 | false | false | false | emberjs | ember.js | 8,463 |
1417618641531ca7d85e8617c978955c4ddb694b | Ricardo Mendes | GitHub | [DOC release] Make inline code-samples equivalent | [doc release] make inline code-samples equivalent | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 8,464 |
761b67f3b2bbfd78738b402740f566d28bd0f4bc | toran billups | toran billups | [BUGFIX beta] layout now supports computed property | [bugfix beta] layout now supports computed property | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 8,465 |
172d158998598e401437f1670d6ec9df4b65bae5 | Robert Jackson | Robert Jackson | Do not slice `classNames` and `classNameBindings` per instance.
The vast majority of the time these arrays are completely static on the
prototype, there are relatively few instances where we actually need to
slice them but we were speculatively doing this "just in case" you
wanted it.
This change does not remove the ability to have custom `classNames` /
`classNameBindings` per instance, but it does make it so that folks
wanting to do this would need to do `this.classNames.slice()` first.
This avoids many extraneous array allocations, and just one more layer
of wasted work during initial render. | do not slice `classnames` and `classnamebindings` per instance | 62 | false | false | 8 | false | false | false | emberjs | ember.js | 8,466 |
4a96d358ed084bc34ab058385db716e599f275b6 | Kris Selden | GitHub | Merge pull request #14384 from chadhietala/attrs-actions
[Bugfix Beta] Fix attrs in className and attribute bindings | merge pull request from chadhietala/attrs-actions | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,467 |
b1a1baf57cb1da177b7f5f68e69a5113d4120e59 | Kris Selden | GitHub | Merge pull request #13996 from emberjs/auto-mut-action
[Bugfix Beta] Fix for auto-mut wrapping of closure actions. | merge pull request from emberjs/auto-mut-action | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,468 |
05fd9165c53b7e9e1c77d5e1ee1d0955b3c0bc09 | Chad Hietala | Chad Hietala | Make attr.actionFn work | make attr.actionfn work | 23 | false | false | 3 | true | true | true | emberjs | ember.js | 8,469 |
cdd108787882db445c289d722ed1c6ae4730b1e8 | Robert Jackson | Chad Hietala | [GLIMMER] Failing test showing auto-mut wrapping of closure actions.
Given the following:
```hbs
{{x-foo derp=(action 'herk')}}
```
```hbs
{{! app/templates/components/x-foo.hbs }}
{{x-bar derp=derp}}
```
```js
export default Component.extend({
didInsertElement() {
this.get('derp')();
m }
});
```
An error is triggered with the following output:
```
TypeError: this.attrs.derp is not a function
at Class.fireAction (http://localhost:7200/ember-tests.js:21306:46)
at http://localhost:7200/ember-tests.js:21344:24
at Object.run (http://localhost:7200/ember.debug.js:294:25)
at Object.run [as default] (http://localhost:7200/ember.debug.js:19515:27)
at _class2.runTask (http://localhost:7200/ember-tests.js:32041:34)
at _class2.testActionClosureDoesNotGetAutoMutWrapped [as @test action closure does not get auto-mut wrapped] (http://localhost:7200/ember-tests.js:21343:12)
at Object.<anonymous> (http://localhost:7200/ember-tests.js:31691:31)
at runTest (http://localhost:7200/qunit/qunit.js:843:28)
at Object.run (http://localhost:7200/qunit/qunit.js:828:4)
at http://localhost:7200/qunit/qunit.js:970:11
``` | [glimmer] failing test showing auto-mut wrapping of closure actions | 67 | false | false | 9 | false | false | false | emberjs | ember.js | 8,470 |
8502f0861a07da3d9cb1db3426761d9504086e8a | Chad Hietala | Chad Hietala | [Bugfix Beta] Fix attrs in className and attribute bindings | [bugfix beta] fix attrs in classname and attribute bindings | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 8,471 |
774b303b81421101c4716829945880c1ee11a817 | Robert Jackson | GitHub | Merge pull request #14370 from emberjs/rwjblue-patch-1
Update babel-plugin-feature-flags to 0.2.3 | merge pull request from emberjs/rwjblue-patch-1 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,472 |
ae80f07b99835bfaeca89fc89a8af401cbd4ea0e | Robert Jackson | Robert Jackson | Update babel-plugin-feature-flags to 0.2.3
Support was added to support multiple modules (which we need due to using both `ember-metal` and `ember-metal/features`). | update babel-plugin-feature-flags to 0.2.3 | 42 | false | false | 4 | false | true | false | emberjs | ember.js | 8,473 |
4927a9412cc8992566be447a7a4786767b607f08 | Sergio Arbeo | Sergio Arbeo | [DOC] Make public two-week policy for closing issues
When triaging a team, we use the _Needs Submitter Response_ to mark
issues that cannot be solved without some extra information from the
original submitter. If the submitter does not provide any extra
information after seven days, the team gently reminds the original
submitter. If another week passes, the issue might be closed. | [doc] make public two-week policy for closing issues | 52 | false | false | 8 | false | false | false | emberjs | ember.js | 8,474 |
26cc7d230bc0faa925f2f1e418487822d9233244 | Robert Jackson | GitHub | Merge pull request #14374 from emberjs/cache-caches
Cache the caches to avoid some npm bizarreness when bumping packages. | merge pull request from emberjs/cache-caches | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,475 |
221bd5a00ce483126b600f5d6a4e72eab33d7977 | Robert Jackson | Robert Jackson | Cache the caches to avoid some npm bizarreness when bumping packages.
This changes the Travis caching setup to cache the `.npm` and `.cache`
directories, instead of caching the output of `node_modules` /
`bower_components`. It should still reduce the network time, but allow
the npm installs to work properly when there are package bumps.
Can't make it worse ¯\_(ツ)_/¯... | cache the caches to avoid some npm bizarreness when bumping packages | 68 | false | false | 11 | true | true | false | emberjs | ember.js | 8,476 |
27d67841783004538ce0096083b37c6d4e96e824 | Robert Jackson | GitHub | Merge pull request #14371 from emberjs/alias-watch-on-consumption
[BUGFIX beta] Lazily add alias dependent keys. | merge pull request from emberjs/alias-watch-on-consumption | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 8,477 |
bfefe37425f9a71367507914945cf31ab2d482b3 | Suman Kunwar | GitHub | added multiple launchers with examples
There might be a case where a person wants to test with different launchers so an example is added | added multiple launchers with examples | 38 | false | false | 5 | false | false | false | emberjs | ember.js | 8,478 |
0db018eb57d90b8a1583ed5d24636e19fed7fa1d | Robert Jackson | Godfrey Chan | [BUGFIX beta] Fix alias test for interior sets to consume.
This test was added to ensure that the dirtying / tagging system used by
Glimmer 2 is properly aware of an alias being dirtied. At the time it
was authored, the assumption was that we would automatically watch all
aliases but this has proven to be a performance issue when lots of
alias's are used but not consumed in the template layer.
This change updates the test to ensure that it consumes the alias before
verifying that it is dirtied. This much more properly emulates "reality". | [bugfix beta] fix alias test for interior sets to consume | 57 | false | false | 10 | false | false | false | emberjs | ember.js | 8,479 |
ea5d4ff8cb785dca302175dbc15c67a4c6aa76a6 | Robert Jackson | Godfrey Chan | [BUGFIX beta] Add dependent keys when an alias is consumed or watched.
In Ember 2.8, an `Ember.computed.alias` will only call
`addDependentKeys` / `removeDependentKeys` if it itself is being
watched. This proved problematic during the Glimmer 2 refactor (2.9+)
because in production builds an alias that is consumed in a template
is not being watched (it is only watched in debug builds so that
mandatory setter is setup).
In order to fix that bug (prod builds would never update a template for
changes made to an aliased property), we made `Ember.computed.alias`
eagerly setup dependent keys (even if never watched or consumed). After
some benchmarking in a few real world apps, it became obvious that this
eager setup negatively impacted performance for scenarios where an alias
is present but unused/unconsumed. One such example is the `data` read
only alias that Ember Data sets on on all model instances (mostly as a
backwards compat shim), 90+% of apps are not using this alias but its
mere presence in the object caused us to do more work per model instance
created. The overall cost of adding a single dependent key and watch it
is relatively low, but when you do that for each model and use thousands
of models it adds up...
This change essentially reverts the changes that made all dependent key
setup eager, and replaces it with logic to ensure that dependent keys
are added both when watching (the prior behavior) and when an alias is
consumed (this fixes the originally reported regression). | [bugfix beta] add dependent keys when an alias is consumed or watched | 69 | false | false | 12 | false | false | false | emberjs | ember.js | 8,480 |
a98b4f98a514a48921d45397823c4a25d10007a9 | Robert Jackson | Godfrey Chan | Remove "meta" `Meta` building for `deps`.
`inheritedMapOfMaps` was only used for `deps`, and the abstraction
actually makes finding/understanding how to work on `peekDeps` /
`writeDeps` / `hasDeps` / `forEachInDeps` much harder.
This is a purely cosmetic change, no functionality was modified. | remove "meta" `meta` building for `deps` | 40 | false | false | 6 | false | false | false | emberjs | ember.js | 8,481 |
778ee33b9d7287d7925387abb5eedcb42acb1758 | Robert Jackson | GitHub | Merge pull request #14365 from nathanhammond/patch-1
[BUGFIX release] Bump route-recognizer. | merge pull request from nathanhammond/patch-1 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,482 |
c50866162cdc25ffefc965d020df7942de2ba78d | Godfrey Chan | GitHub | Merge pull request #14367 from emberjs/fix-features
[BUGFIX beta] Ensure feature flags are stripped | merge pull request from emberjs/fix-features | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,483 |
e632ff47ff850a94edb717e8f38a5fd3b9e876c6 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Ensure feature flags are stripped
The renaming of the `isEnabled` import caused the feature flag transform
to stop working. This fixes the problem.
Before:
```
File sizes:
- ember.debug.js: 2.65 MB (610.65 KB gzipped)
- ember.js: 2.65 MB (610.65 KB gzipped)
- ember.min.js: 495.83 KB (123.13 KB gzipped)
- ember.prod.js: 2.54 MB (584.96 KB gzipped)
```
After:
```
File sizes:
- ember.debug.js: 2.65 MB (610.45 KB gzipped)
- ember.js: 2.65 MB (610.45 KB gzipped)
- ember.min.js: 493.53 KB (122.67 KB gzipped)
- ember.prod.js: 2.53 MB (584.74 KB gzipped)
```
Diff (ember.prod.js):
```
diff --git a/dist-before/ember.prod.js b/dist-after/ember.prod.js
index 6d8ecf5..5a682c4 100644
--- a/dist-before/ember.prod.js
+++ b/dist-after/ember.prod.js
@@ -10374,7 +10374,7 @@ enifed('ember-glimmer/renderer', ['exports', 'ember-glimmer/utils/references', '
var runInTransaction = undefined;
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
runInTransaction = _emberMetal.runInTransaction;
} else {
runInTransaction = function (context, methodName) {
@@ -13168,7 +13168,7 @@ enifed('ember-glimmer/utils/references', ['exports', 'ember-utils', 'ember-metal
var TwoWayFlushDetectionTag = undefined;
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
TwoWayFlushDetectionTag = (function () {
function _class(tag, key, ref) {
this.tag = tag;
@@ -13236,13 +13236,13 @@ enifed('ember-glimmer/utils/references', ['exports', 'ember-utils', 'ember-metal
this._parentValue = parentValue;
this._propertyKey = propertyKey;
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
this.tag = new TwoWayFlushDetectionTag(_emberMetal.tagFor(parentValue), propertyKey, this);
} else {
this.tag = _emberMetal.tagFor(parentValue);
}
- if (_emberMetal.isFeatureEnabled('mandatory-setter')) {
+ if (false) {
_emberMetal.watchKey(parentValue, propertyKey);
}
}
@@ -13251,7 +13251,7 @@ enifed('ember-glimmer/utils/references', ['exports', 'ember-utils', 'ember-metal
var _parentValue = this._parentValue;
var _propertyKey = this._propertyKey;
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
this.tag.didCompute(_parentValue);
}
@@ -13280,7 +13280,7 @@ enifed('ember-glimmer/utils/references', ['exports', 'ember-utils', 'ember-metal
this._parentObjectTag = parentObjectTag;
this._propertyKey = propertyKey;
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
var tag = _glimmerReference.combine([parentReferenceTag, parentObjectTag]);
this.tag = new TwoWayFlushDetectionTag(tag, propertyKey, this);
} else {
@@ -13298,11 +13298,11 @@ enifed('ember-glimmer/utils/references', ['exports', 'ember-utils', 'ember-metal
_parentObjectTag.update(_emberMetal.tagFor(parentValue));
if (typeof parentValue === 'object' && parentValue) {
- if (_emberMetal.isFeatureEnabled('mandatory-setter')) {
+ if (false) {
_emberMetal.watchKey(parentValue, _propertyKey);
}
- if (_emberMetal.isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') || _emberMetal.isFeatureEnabled('ember-glimmer-allow-backtracking-rerender')) {
+ if (false || false) {
this.tag.didCompute(parentValue);
}
@@ -23292,7 +23292,7 @@ enifed('ember-routing/system/route', ['exports', 'ember-utils', 'ember-metal', '
var normalizedControllerQueryParameterConfiguration = _emberRoutingUtils.normalizeControllerQueryParams(controllerDefinedQueryParameterConfiguration);
combinedQueryParameterConfiguration = mergeEachQueryParams(normalizedControllerQueryParameterConfiguration, queryParameterConfiguraton);
- if (_emberMetal.isFeatureEnabled('ember-routing-route-configured-query-params')) {
+ if (false) {
if (controllerDefinedQueryParameterConfiguration.length) {}
}
} else if (hasRouterDefinedQueryParams) {
@@ -23321,7 +23321,7 @@ enifed('ember-routing/system/route', ['exports', 'ember-utils', 'ember-metal', '
var desc = combinedQueryParameterConfiguration[propName];
- if (_emberMetal.isFeatureEnabled('ember-routing-route-configured-query-params')) {
+ if (false) {
// apply default values to controllers
// detect that default value defined on router config
if (desc.hasOwnProperty('defaultValue')) {
@@ -25200,7 +25200,7 @@ enifed('ember-routing/system/route', ['exports', 'ember-utils', 'ember-metal', '
var keysAlreadyMergedOrSkippable = undefined;
var qps = {};
- if (_emberMetal.isFeatureEnabled('ember-routing-route-configured-query-params')) {
+ if (false) {
keysAlreadyMergedOrSkippable = {};
} else {
keysAlreadyMergedOrSkippable = {
@@ -29733,7 +29733,7 @@ enifed('ember-runtime/mixins/array', ['exports', 'ember-utils', 'ember-metal', '
}).readOnly(), _Mixin$create.lastObject = _emberMetal.computed(function () {
return objectAt(this, _emberMetal.get(this, 'length') - 1);
}).readOnly(), _Mixin$create.contains = function (obj) {
- if (_emberMetal.isFeatureEnabled('ember-runtime-enumerable-includes')) {}
+ if (true) {}
return this.indexOf(obj) >= 0;
}, _Mixin$create.slice = function (beginIndex, endIndex) {
@@ -29816,7 +29816,7 @@ enifed('ember-runtime/mixins/array', ['exports', 'ember-utils', 'ember-metal', '
return this.__each;
}).volatile(), _Mixin$create));
- if (_emberMetal.isFeatureEnabled('ember-runtime-enumerable-includes')) {
+ if (true) {
ArrayMixin.reopen({
/**
Returns `true` if the passed object can be found in the array.
@@ -30573,7 +30573,7 @@ enifed('ember-runtime/mixins/enumerable', ['exports', 'ember-utils', 'ember-meta
@public
*/
contains: function (obj) {
- if (_emberMetal.isFeatureEnabled('ember-runtime-enumerable-includes')) {}
+ if (true) {}
var found = this.find(function (item) {
return item === obj;
@@ -31359,7 +31359,7 @@ enifed('ember-runtime/mixins/enumerable', ['exports', 'ember-utils', 'ember-meta
}
});
- if (_emberMetal.isFeatureEnabled('ember-runtime-computed-uniq-by')) {
+ if (true) {
Enumerable.reopen({
/**
Returns a new enumerable that contains only items containing a unique property value.
@@ -31390,7 +31390,7 @@ enifed('ember-runtime/mixins/enumerable', ['exports', 'ember-utils', 'ember-meta
});
}
- if (_emberMetal.isFeatureEnabled('ember-runtime-enumerable-includes')) {
+ if (true) {
Enumerable.reopen({
/**
Returns `true` if the passed object can be found in the enumerable.
@@ -32042,7 +32042,7 @@ enifed('ember-runtime/mixins/mutable_array', ['exports', 'ember-metal', 'ember-r
addObject: function (obj) {
var included = undefined;
- if (_emberMetal.isFeatureEnabled('ember-runtime-enumerable-includes')) {
+ if (true) {
included = this.includes(obj);
} else {
included = this.contains(obj);
@@ -33697,7 +33697,7 @@ enifed('ember-runtime/system/core_object', ['exports', 'ember-utils', 'ember-met
if (typeof this.setUnknownProperty === 'function' && !(keyName in this)) {
this.setUnknownProperty(keyName, value);
} else {
- if (_emberMetal.isFeatureEnabled('mandatory-setter')) {
+ if (false) {
_emberMetal.defineProperty(this, keyName, null, value); // setup mandatory setter
} else {
this[keyName] = value;
@@ -38940,7 +38940,7 @@ enifed('ember/index', ['exports', 'require', 'ember-environment', 'ember-utils',
_emberMetal.default.Binding = _emberMetal.Binding;
_emberMetal.default.isGlobalPath = _emberMetal.isGlobalPath;
- if (_emberMetal.isFeatureEnabled('ember-metal-weakmap')) {
+ if (false) {
_emberMetal.default.WeakMap = _emberMetal.WeakMap;
}
@@ -39150,7 +39150,7 @@ enifed('ember/index', ['exports', 'require', 'ember-environment', 'ember-utils',
computed.filterBy = _emberRuntime.filterBy;
computed.uniq = _emberRuntime.uniq;
- if (_emberMetal.isFeatureEnabled('ember-runtime-computed-uniq-by')) {
+ if (true) {
computed.uniqBy = _emberRuntime.uniqBy;
}
computed.union = _emberRuntime.union;
@@ -39220,7 +39220,7 @@ enifed('ember/index', ['exports', 'require', 'ember-environment', 'ember-utils',
EmberHandleBarsUtils.escapeExpression = _emberGlimmer.escapeExpression;
_emberRuntime.String.htmlSafe = _emberGlimmer.htmlSafe;
- if (_emberMetal.isFeatureEnabled('ember-string-ishtmlsafe')) {
+ if (true) {
_emberRuntime.String.isHTMLSafe = _emberGlimmer.isHTMLSafe;
}
EmberHTMLBars.makeBoundHelper = _emberGlimmer.makeBoundHelper;
``` | [bugfix beta] ensure feature flags are stripped | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 8,484 |
b60d73f368f1641a1bb0d7cd5b6b46f0235cc440 | Robert Jackson | GitHub | Merge pull request #14366 from emberjs/fix-assign
[BUGFIX beta] Fix Ember.assign export. | merge pull request from emberjs/fix-assign | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,485 |
cc396f6ca94da2cf45e560bb15796484a3d473e2 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix `Ember.assign` without `Object.assign`.
Previously, the wrong export was used (this was a mistake from the
`ember-utils` migration). | [bugfix beta] fix `ember.assign` without `object.assign` | 56 | false | false | 6 | false | false | false | emberjs | ember.js | 8,486 |
a2812c1b4172c1db5ae336deb033f9c7ca29af38 | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid usage of `...args` for `assign` utility. | [bugfix beta] avoid usage of `...args` for `assign` utility | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 8,487 |
52a47d94c0faed1efdd25f63a7d9b0c450138c51 | Robert Jackson | GitHub | Merge pull request #14364 from dgeb/remove-metafor-usage
Remove unnecessary import of `metaFor`. | merge pull request from dgeb/remove-metafor-usage | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,488 |
3141f835991dee848a4983eb064bfab54fd2e473 | Robert Jackson | GitHub | Merge pull request #14359 from emberjs/move-is-destroyed-flags
Refactor Meta and object destruction tracking. | merge pull request from emberjs/move-is-destroyed-flags | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,489 |
e34ed31a0ddf6dd43f375348a9f3f9ee11a0eb9c | Robert Jackson | GitHub | Merge pull request #14363 from HeroicEric/tagless-component-id
[BUGFIX beta] Always use `guidFor` for tagless component id | merge pull request from heroiceric/tagless-component-id | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,490 |
66cb3b0ae8818ee9bd0d436c838cd16e2e56a5f7 | Nathan Hammond | GitHub | [BUGFIX release] Bump route-recognizer.
Trailing slashes with encoded chars did not previously work.
See: https://github.com/tildeio/route-recognizer/pull/114 | [bugfix release] bump route-recognizer | 38 | false | false | 4 | false | false | false | emberjs | ember.js | 8,491 |
5c0e590a0bd9c630849a35809e0d00191988959a | Robert Jackson | Robert Jackson | Refactor Meta and object destruction tracking.
* Moves the `isDestroying` and `isDestroyed` flags into meta
* Prevents recreating meta _while_ destroying the object (was happening
during chain node removal)
* Allows reading values/caches after object destruction, but triggers an
assertion if non-readable meta methods are called after the object is
destroyed
* Avoids doing extra work when unwatching keys/paths for an object that
is also destroyed
* Use bitwise flagging instead of many boolean properties for meta, and
expose helpful methods to interact with them
* Move chains cleanup to `Meta#destroy`. | refactor meta and object destruction tracking | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 8,492 |
36371e07fa7bff743e9ed15b1ee420845ed6be90 | Dan Gebhardt | Dan Gebhardt | Remove unnecessary import of `metaFor`.
`watchKey` internally calls `metaFor` if no `meta` has been provided. | remove unnecessary import of `metafor` | 38 | false | false | 5 | true | true | true | emberjs | ember.js | 8,493 |
fa104683ea80d8f65a665d8aa0a5cdd3276dcd07 | Eric Kelly | Eric Kelly | [BUGFIX beta] Always use `guidFor` for tagless component id
Fixes https://github.com/emberjs/ember.js/issues/14358 | [bugfix beta] always use `guidfor` for tagless component id | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 8,494 |
ca66d1908295861aa7861fb64deee4dc7b3316df | Robert Jackson | GitHub | Merge pull request #14361 from emberjs/cleanup-fastboot-hooks
Cleanup fastboot hooks and misc view cleanup | merge pull request from emberjs/cleanup-fastboot-hooks | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,495 |
daab1863f5dcdb59aef12fdb0293819ee563d711 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove more unused view cruft | [cleanup beta] remove more unused view cruft | 44 | false | false | 7 | false | false | false | emberjs | ember.js | 8,496 |
a6f3de450175b48105a5b38297526dbd92d6a2d4 | Godfrey Chan | Godfrey Chan | [CLEANUP beta] Remove `Ember.View` deadcode
The deprecated `Ember.View` has been removed a while ago. The exports
in this file is not used anywhere inside the `ember-views` package and
also not re-exported from the package index. Contrary to the outdated
documentation, we don’t export the `Ember.View` global also, so this is
just dead code.
I kept the file around for now until we finish migrating the
documentation. | [cleanup beta] remove `ember.view` deadcode | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 8,497 |
b4d22a8c0a9b4281e96db6de16db08c6c18e7d54 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Only call attr hooks in FastBoot
This is a follow-up to #14233.
At the September 2016 core team face-to-face meeting, we discussed and
clarified the intended features for life-cycle hooks in non-iterative
environments (i.e. FastBoot).
We agreed that components on FastBoot should only react to data changes
via the `didReceiveAttrs` and `didUpdateAttrs` hooks. (There is also
deprecated `didInitAttrs` hook.)
The main change is that we have been incorrectly calling `willRender`
and `willUpdate` in non-interactive mode so far (at least since we last
checked and added the tests). The problem is that `{will,did}Render` and
`{will,did}Update` are intended to work as a pair so running one but not
the other could introduce unexpected bugs for applications. | [bugfix beta] only call attr hooks in fastboot | 46 | false | false | 8 | false | false | false | emberjs | ember.js | 8,498 |
516baf73b6a1f4a4c4f9a8b654a2983b35c4f819 | Godfrey Chan | Godfrey Chan | [BUGFIX beta] Disallow accessing components’ element in FastBoot
We do not allow apps to accessing `this.element` in non-interactive
environments, such as FastBoot. This was enforced by not calling hooks
that would expose the “element” (which is often not a real DOM element)
such as `didInsertElement`. However, since we sometimes run “update”
hooks (such as `didUpdateAttrs`) that happen after the element has been
set, there is a chance that we would leak the “element” inadvertently.
This fixes the issue by making `this.element` a getter that throws in
non-interactive mode. To address cases where apps are relying on the
current accidental behavior, we added `ViewUtils.getViewElement` as a
private (“intimate”) API to forcefully retrieve the “element”. This
should balance the need for warning against incidental usage and still
provide a workaround for cases where the fake element is needed, such as
custom serializations.
As always, using private (“intimate”) APIs are strongly discouraged, not
fully supported and might not be unreliable. However, we will try our
best to keep it around and deprecate between LTS releases before
removing it.
Note: the main issue here is that the “element” you get back is likely
not a real DOM element with an undocumented set of APIs. This core issue
is not really addressed here and the supported APIs and internals of the
returned object is subject to change. | [bugfix beta] disallow accessing components’ element in fastboot | 64 | false | false | 8 | false | false | false | emberjs | ember.js | 8,499 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.