sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1b4971f1715fccd194a8ee9b55411f5d3d752257 | Robert Jackson | GitHub | Merge pull request #13774 from chadhietala/fix-top-level-outlets
[Glimmer2] Fix top level templates with loading/error states | merge pull request from chadhietala/fix-top-level-outlets | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 9,300 |
6b40cd4fa4add44f214005044c034e584de7cb02 | Kris Selden | GitHub | Merge pull request #13778 from asakusuma/localz
[Glimmer2] Implement glimmer local lookup for components | merge pull request from asakusuma/localz | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 9,301 |
242d6db2d7f74c866a895ea30f3b346b69a7db17 | asakusuma | asakusuma | [Glimmer2] Implement glimmer local lookup for components | [glimmer2] implement glimmer local lookup for components | 56 | false | false | 7 | false | false | false | emberjs | ember.js | 9,302 |
e81233a6aa8cb29b72b92e799be510ad66046db7 | Kris Selden | GitHub | Merge pull request #13775 from emberjs/view-destroy-cleanup
[BUGFIX beta] Cleanup view teardown. | merge pull request from emberjs/view-destroy-cleanup | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,303 |
9228bb85f7c2237b4699f1c9e810426d29ea5188 | Robert Jackson | Robert Jackson | Add tests for view cleanup/destruction.
* [Glimmer] Ensure `.parentView` is present at creation.
* Add tests for `.parentView` and `.element` in each lifecycle hook.
* Remove duplicated `parentView` manipulation (this is now done as part of `renderer.remove`).
* Add test ensuring `willDestroyElement` is called for inverse.
* Ensure element in DOM during willDestroyElement. | add tests for view cleanup/destruction | 38 | false | false | 5 | true | true | true | emberjs | ember.js | 9,304 |
186be31d3ce565f6d4b1e374a70b78695d71866c | Kris Selden | Robert Jackson | [BUGFIX] Cleanup view teardown. | [bugfix] cleanup view teardown | 30 | false | false | 4 | false | false | false | emberjs | ember.js | 9,305 |
2c63b7533be7380d8ca23a3e2d05e5b4069ab8a8 | Robert Jackson | GitHub | Merge pull request #13777 from emberjs/locks-patch-2
[DOC] Fixes typo in computed_macros API documentation | merge pull request from emberjs/locks-patch-2 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,306 |
22892c685cbc4ab6b4578c7175e54d8cfe7e13fd | Kris Selden | GitHub | Merge pull request #13736 from chadhietala/glimmer-teardown
[Glimmer2] Cleanup teardown | merge pull request from chadhietala/glimmer-teardown | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,307 |
5faf133b1950009f75d8ef40f0aeb40f6d59e6ee | Chad Hietala | Chad Hietala | [Glimmer2] Fix top level templates with loading/error states | [glimmer2] fix top level templates with loading/error states | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 9,308 |
2509579f90a5304a75ed5ca4931b1dacd17fa613 | Ricardo Mendes | Ricardo Mendes | whitespace | whitespace | 10 | false | false | 1 | false | false | false | emberjs | ember.js | 9,309 |
9c79789e35b4072090320e046dde8eba7dfc6efc | Ricardo Mendes | Ricardo Mendes | [DOC release] Fixes `Ember.computed.uniqBy`'s code sample | [doc release] fixes `ember.computed.uniqby`'s code sample | 57 | false | false | 6 | false | false | false | emberjs | ember.js | 9,310 |
1ddbd70e72e87fc3af44a3bb6dc8810c9a240c91 | Ricardo Mendes | GitHub | [DOC] Fixes typo in computed_macros API documentation | [doc] fixes typo in computed_macros api documentation | 53 | false | false | 7 | false | false | false | emberjs | ember.js | 9,311 |
b83b16605c661c7dccc444b099134422193f5473 | Kris Selden | GitHub | Merge pull request #13773 from emberjs/view-cleanup
[CLEANUP] reducing private API surface of views. | merge pull request from emberjs/view-cleanup | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,312 |
ccd145210d007fc3a065ace5a12d0eb86f86ca0c | Kris Selden | Kris Selden | [CLEANUP] reducing private API surface of views.
* remove unused internal `_willDestroyElement` hook
* cleanup `childViews` documentation not to refer to legacy methods
* remove undocumented `forEachChildView` used only by visibility support
and refactor visibility support not to use it.
* remove `remove` and `removeFromParent` methods, refactor legacy style
tests to avoid these. Removing a view should be done via the template
layer. Still leaves destroyElement which is equivalent and used in more
legacy style tests. | [cleanup] reducing private api surface of views | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 9,313 |
183f64612029cb7b4c023f67638619124813f395 | Kris Selden | GitHub | Merge pull request #13763 from zackthehuman/glimmer-each-iterator
[GLIMMER2] Fix ember-glimmer iterators when handling dupes in ({{#each}}) | merge pull request from zackthehuman/glimmer-each-iterator | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 9,314 |
62730a8ca062231a028ebb01c2ce401a2273f574 | Kris Selden | GitHub | Merge pull request #13761 from chadhietala/get-attr
[Glimmer 2] Impliment getAttr | merge pull request from chadhietala/get-attr | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,315 |
8892fa2661069af9fb0b18505ec1e07e469d9728 | Robert Jackson | GitHub | Merge pull request #13768 from rwjblue/update-route-recognizer
[BUGFIX beta] Update route-recognizer to v0.2.0. | merge pull request from rwjblue/update-route-recognizer | 56 | true | false | 5 | true | true | false | emberjs | ember.js | 9,316 |
af0489e6359c74f6227a4f72a4172e401f226ce7 | Robert Jackson | Robert Jackson | Migrate a few `link-to` tests to newer testing infrastructure. | migrate a few `link-to` tests to newer testing infrastructure | 61 | false | false | 9 | false | false | false | emberjs | ember.js | 9,317 |
b49b934ebc80e7d6db9a65db321303a7c38a42c4 | Robert Jackson | Robert Jackson | [BUGFIX beta] Update route-recognizer to v0.2.0.
This update includes a number of fixes regarding encoding/decoding.
Snippet from the upstream fixing PR:
This addresses the following:
* Adds many tests for non-standard routes and paths (with percent-encodings and/or unicode characters)
* Adds normalization for added routes and recognized paths to improve the matching of non-standard routes and paths
* Fixes a bug where dynamic segments are not percent-encoded during generation
* Fixes a bug where dynamic segments are not percent-decoded during recognition
* Adds tests (and some code) to ensure that star segments in routes do *not* get decoded during recognition
* Adds a flag that can be turned off by consumers to opt-out of the changes introduced here
It may only affect users who have routes with:
* percent-encoded or unicode characters
* dynamic segments that may match paths with percent-encoded characters
* dynamic segments that are generated using values that have characters that should be encoded (e.g. forward slash: `/`)
It **may cause breaking changes** for users who have workarounds in place to encode/decode before generation/recognition. The breakage can be fixed by removing the workaround.
It will likely **not cause breaking changes** for users who have static routes with percent-encoded or unicode characters. All static route/path combinations that currently match will *also* match after this PR. Static routes that used to be considered distinct (e.g. `/f%20o` and `/f o`) are now normalized to the same thing. Users with affected static route/path combos likely need to do nothing; they may simply end up with superfluous routes that can be removed. | [bugfix beta] update route-recognizer to v0.2.0 | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 9,318 |
8bc48a7f345815e7a468e01b539ee25cfae631b8 | Zack Mulgrew | Zack Mulgrew | Fix ember-glimmer iterators when handling dupes | fix ember-glimmer iterators when handling dupes | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 9,319 |
d44c4f554ea61f7798c44446363ddbcd193ebf24 | Godfrey Chan | GitHub | Merge pull request #13766 from emberjs/implement-render-helper
[Glimmer] Basic `{{render}}` helper support | merge pull request from emberjs/implement-render-helper | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 9,320 |
6cecfaa2120114c3b677731c9b8c724c260bbec7 | Chad Hietala | Chad Hietala | [Glimmer 2] Impliment getAttr
@rwjblue can we deprecate this? It is un-documented but appears to be an
intimate API. | [glimmer 2] impliment getattr | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 9,321 |
3006e198f4de1e6994053625d8592e5090d42f63 | Godhuda | Godhuda | [Glimmer] Basic `{{render}}` helper support | [glimmer] basic `{{render}}` helper support | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 9,322 |
c960e049c9e53dd85204a8016f3275dd18052a02 | Godfrey Chan | GitHub | Merge pull request #13762 from emberjs/fix-outlets
Fix outlet states | merge pull request from emberjs/fix-outlets | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 9,323 |
471d28d52c68df4a5c11b9be57ac7fe5e5dc84c4 | Matthew Beale | GitHub | Merge pull request #13765 from emberjs/updates
bump ember-cli-yuidoc | merge pull request from emberjs/updates | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 9,324 |
a18185381b9b6cdc21c1999915a99643afd2dd3f | Godhuda | Godhuda | Fix outlet states
We forgot to cache the `lastState`, so everything was invalidating all
the time. However, we were supposed to look at `state.render.{controller,template}`,
but we did `state.{controller,template}` instead (which are, of course,
always `undefined`). This actually made it "stable" some of the time,
because the check was `oldStuff === newStuff`. So, as a whole, it more
or less behaves randomly 😗
Also, since Glimmer now accepts `null`s as "no component definition", we
can simplify the code a bit here. | fix outlet states | 17 | false | false | 3 | false | true | false | emberjs | ember.js | 9,325 |
a19d46a8b1c71bd5069331ba30c18c627253232f | Stefan Penner | Stefan Penner | bump ember-cli-yuidoc | bump ember-cli-yuidoc | 21 | true | false | 2 | true | true | false | emberjs | ember.js | 9,326 |
670a88ec92925c09e3c06f621e694aae73e4422c | Stefan Penner | GitHub | Merge pull request #13760 from cibernox/fix-helper-docs
[DOC] Fix docs on idiomatic helper export pattern | merge pull request from cibernox/fix-helper-docs | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 9,327 |
30e6e263b1b5a003530681d19977095c6d8aa2b7 | cibernox | cibernox | [DOC] Fix docs on idiomatic helper export pattern
Update docs to match the pattern that ember-cli uses when a helper is generated
via command line. In that pattern, the helper function is a pure function exported
as a named export, and the default export is `Ember.Helper.helper(fnName)` | [doc] fix docs on idiomatic helper export pattern | 49 | false | false | 8 | false | false | false | emberjs | ember.js | 9,328 |
9e807f3e119f16eece09de5600d02574a5e5886f | Robert Jackson | Robert Jackson | Add 2.7.0-beta.2 to CHANGELOG.
[ci skip] | add 2.7.0-beta.2 to changelog | 29 | false | false | 4 | true | true | true | emberjs | ember.js | 9,329 |
b03759847fe171528e83a8d5aaf89b79aeda65e4 | Robert Jackson | Robert Jackson | Add 2.6.1 changelog info.
[ci skip]
(cherry picked from commit 8b33eb2b827f64f2ce9cd04fd6fac25917aa8aa7) | add 2.6.1 changelog info | 24 | false | false | 4 | true | true | true | emberjs | ember.js | 9,330 |
8e9ec7dd382b0402417502ac4f612d5cbfeb93a0 | Robert Jackson | GitHub | Merge pull request #13759 from rwjblue/update-glimmer-to-use-npm-for-typescript
Update glimmer-engine to avoid pulling Typescript from github. | merge pull request from rwjblue/update-glimmer-to-use-npm-for-typescript | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 9,331 |
d8b811a1586ea9fcb04840c6bbc6de388bfbd8bf | Kris Selden | GitHub | Merge pull request #13754 from habdelra/helper-docs
Fixes #13291 Improved helper function documentation | merge pull request from habdelra/helper-docs | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,332 |
6b7355aa7d70aef19b59a2aa38c1cff54a0ebd30 | Robert Jackson | Robert Jackson | Update glimmer-engine to avoid pulling Typescript from github.
It now uses typescript from npm nightlies. | update glimmer-engine to avoid pulling typescript from github | 61 | false | false | 8 | true | true | false | emberjs | ember.js | 9,333 |
7e62fb0ea7ea43ff4e7886cad9dc3e09c72888b3 | Robert Jackson | GitHub | Merge pull request #13273 from raytiley/moar-qp-fixes
[BUGFIX] - Merge query params from previous transition into active transition | merge pull request from raytiley/moar-qp-fixes | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 9,334 |
3bfe8bb314b54fe6394aff8280a6134bbf2e0eb9 | Hassan Abdel-Rahman | Hassan Abdel-Rahman | Fixes #13291 Improved helper function documentation | fixes improved helper function documentation | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 9,335 |
f693865338abe24194f586a2bcb929821d172bd9 | Igor Terzic | raytiley | Add renetrant test for query params changes | add renetrant test for query params changes | 43 | false | false | 7 | true | true | true | emberjs | ember.js | 9,336 |
7802351d0528e246e22d1b0dd835441ab3513140 | raytiley | raytiley | Normalize query params when merging in from active transition
This merges in queryParams from an active transition in such a way that
`prepareQueryParams` won't duplicate them. It also won't merge in the
qp if it is already int he qp changed list, for example if it's already
been set during route setup by a call to `controller.set('qpProp',
'someValue')`. Fixing these things with my current test jsbin also
recreated another issue that has been biting people and that is that a
call to `transitionTo` creates an aborted transition that calls
`didTransition` with an empty set of handlerInfos. This would cause the
`updatePaths` method to fail since it couldn't calculate the paths
without the handler infos. We now bail early from `updatePaths` it is
called with an empty array of handlerInfos. I think this is fine
because the aborted transition is followed by a successful transition
that will update the paths appropriatly.
This gets the active queryParams and the provided using the same key
`controller:prop` so that the calls to `assign` override as expected.
This fixes issues where the QP doesn't update properly on refresh
because the merged value conflicts with the provided value. | normalize query params when merging in from active transition | 61 | false | false | 9 | true | true | false | emberjs | ember.js | 9,337 |
503834b44688fac806895dde0950c890b9bf7d47 | Kris Selden | GitHub | Merge pull request #13758 from rwjblue/remove-bad-initializer-test
Remove duplicated (and faulty) test. | merge pull request from rwjblue/remove-bad-initializer-test | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 9,338 |
62bd268529c7d023a96b64a35d3c0fd23c4e31bc | Robert Jackson | GitHub | Merge pull request #13752 from habdelra/promise-proxy-mixin-doc
Fixes #13750 update documentation to cast `getJSON` to compliant promise | merge pull request from habdelra/promise-proxy-mixin-doc | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 9,339 |
2c5214d8c39bd2447bf7e7f3ebf411a2fe1831df | Kris Selden | GitHub | Merge pull request #13757 from rwjblue/remove-more-view-cruft
View cruft removal. | merge pull request from rwjblue/remove-more-view-cruft | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 9,340 |
0d78739dbf3400340a881a857d0d1a9d1697c67f | Robert Jackson | Robert Jackson | Remove duplicated (and faulty) test.
This is duplicated by the tests in:
packages/ember-application/tests/system/application_test.js. | remove duplicated (and faulty) test | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 9,341 |
c9f42d7d43e6d63a522219199dbcc294416c6f1f | Robert Jackson | Robert Jackson | Fix JSHint issue. | fix jshint issue | 16 | false | false | 3 | true | true | true | emberjs | ember.js | 9,342 |
a85d6a19fc82ea86f137483a773aa0f1a0e15366 | Robert Jackson | Robert Jackson | Remove legacy addon `viewName` support. | remove legacy addon `viewname` support | 38 | false | false | 5 | true | false | true | emberjs | ember.js | 9,343 |
f69e66cf67e43a62b33e651edf4b39d70443c6e8 | Robert Jackson | Robert Jackson | Remove ported tests.
These tests were ported to the newer INUR style test setup, and can be
removed. | remove ported tests | 19 | false | false | 3 | true | true | true | emberjs | ember.js | 9,344 |
b4a9fd201364166e6552625b9a5b5dcb84c276d7 | Robert Jackson | Robert Jackson | Remove references to `controller` in component/views. | remove references to `controller` in component/views | 52 | false | false | 6 | true | true | false | emberjs | ember.js | 9,345 |
0f88f6927cfb8d5cfc1d6402ab92044e0e6c3336 | Robert Jackson | Robert Jackson | Simplify child views support.
* Remove `Ember.A` usage for `this.childViews` (this was left over from
container view support).
* Remove `this.childViews.slice` (also left over from container view).
* Re-unified glimmer fork of the mixin. | simplify child views support | 28 | false | false | 4 | false | true | false | emberjs | ember.js | 9,346 |
13f00d11e9e90b2a4c239af99743470e1c638349 | Robert Jackson | Robert Jackson | Remove `createChildView`. | remove `createchildview` | 24 | false | false | 2 | true | true | false | emberjs | ember.js | 9,347 |
980e492125b2f01b97c3cf5ec4ed48dce6f7462c | Robert Jackson | Robert Jackson | Remove unsupported and long deprecated legacy view support.
* The `.controller` and `.context` support was only present to support
the legacy view and controller addons. That support only lasted
through 2.6, and can be removed.
* The `nearestChildOf` and `nearestInstanceOf` deprecations were added
well before 2.0 (I have traced them back to at least 1.11), and they
were private methods (documented as private since at least 1.12). When
the `until` versions were added (to support the ember-debug-handlers
feature) these were accidentally defaulted to 3.0.0. | remove unsupported and long deprecated legacy view support | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 9,348 |
0e1fdbc17d20b5040e41d4f0f6156d87adec4394 | Kris Selden | GitHub | Merge pull request #13756 from rwjblue/more-targetobject-stuff
Remove reference to `.controller` on components. | merge pull request from rwjblue/more-targetobject-stuff | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 9,349 |
13afe72bd37cdf5db007bda269eca0d18e7f1ac7 | Robert Jackson | Robert Jackson | Remove reference to `.controller` on components. | remove reference to `.controller` on components | 47 | false | false | 6 | true | true | true | emberjs | ember.js | 9,350 |
41f378c48e3f79cd133f1759b6e66872a4dcecd3 | Tom Dale | GitHub | Merge pull request #13700 from rwjblue/use-static-length-statements
[BUGFIX beta] Ensure all template statements are constant length. | merge pull request from rwjblue/use-static-length-statements | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 9,351 |
c7991fccf3cd282746a9ef7af3792d66a3da6160 | Tom Dale | GitHub | Merge pull request #13755 from rwjblue/remove-targetobject-computed
Remove usage of `targetObject` computed property. | merge pull request from rwjblue/remove-targetobject-computed | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 9,352 |
7d1a8d5800db55664e16c5955ec14f9930181406 | Robert Jackson | Robert Jackson | Remove usage of `targetObject` computed property.
This PR removes the `targetObject` CP in favor of simply looking up the
correct `targetObject` when needed. This simplifies the code path for
`sendAction` and removes some overloading of the term "controller"
(before this change it could mean an actual outlet's controller or the
parentView.controller which may be a component and not a "real"
controller). | remove usage of `targetobject` computed property | 48 | false | false | 6 | true | true | true | emberjs | ember.js | 9,353 |
cd5717e46f111651c9c75ff1a541a53a92e97b48 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure all template statements are constant length. | [bugfix beta] ensure all template statements are constant length | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 9,354 |
26879fabb535fbf266cf16c29e3c4237d787fb8b | Hassan Abdel-Rahman | Hassan Abdel-Rahman | Fixes #13750 update documentation to cast `getJSON` to compliant promise | fixes update documentation to cast `getjson` to compliant promise | 66 | false | false | 9 | false | false | false | emberjs | ember.js | 9,355 |
b68dcc4d69d7b194628c416ca92d917de4b0f6dc | Robert Jackson | GitHub | Merge pull request #13688 from mmun/public-weakmap
[FEATURE ember-metal-weakmap] Add a WeakMap polyfill | merge pull request from mmun/public-weakmap | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 9,356 |
88a9ab1417fa6f772839a9a9c2cb9199a08648b9 | Martin Muñoz | Martin Muñoz | [FEATURE ember-metal-weakmap] Add a WeakMap polyfill
This patch exposes the Ember's private WeakMap polyfill under a feature
flag. This implementation has a small but important caveat. It assumes
that the weak map will live longer (in the sense of garbage collection)
than all of its keys, otherwise it is possible to leak the values stored
in the weak map.
This patch also includes a few improvements:
- implement WeakMap constructor
- implement WeakMap toString
- guard against non-Object keys | [feature ember-metal-weakmap] add a weakmap polyfill | 52 | false | false | 6 | false | false | false | emberjs | ember.js | 9,357 |
01e16a7aac9f01d20c25cac0e32fb46ae2763ff5 | Robert Jackson | GitHub | Merge pull request #13733 from dgeb/engine-outlets
[FEATURE ember-application-engines] Enable routable engines. | merge pull request from dgeb/engine-outlets | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 9,358 |
9cb7486e3d825c4a3a355e22a849cdfeda0b4f4f | Robert Jackson | GitHub | Merge pull request #13745 from chadhietala/pr/13532
[Glimmer2] sendAction | merge pull request from chadhietala/pr/13532 | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,359 |
86a1d49c8e1e9a52b60781059b91a7bec13554c1 | Joel Kang | Chad Hietala | [Glimmer2] Add support for target actions and migrate tests | [glimmer2] add support for target actions and migrate tests | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 9,360 |
af590e3bc15e3167eb0a3ba2b6eed784470e3af7 | Robert Jackson | GitHub | Merge pull request #13739 from chadhietala/move-render-node-things
[WIP][Glimmer2] Move renderNode refs in view_support | merge pull request from chadhietala/move-render-node-things | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 9,361 |
60a3ac79483ff72f760c1526541e2062150badf3 | Stefan Penner | GitHub | Merge pull request #13741 from Turbo87/broken-super
Fix "super() use outside of constructor" issues | merge pull request from turbo87/broken-super | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,362 |
81a375b24351dc90db40b55f4fee4ce1b75c0ec2 | Tobias Bieniek | Tobias Bieniek | Fix "super() use outside of constructor" issues | fix "super() use outside of constructor" issues | 47 | false | false | 7 | true | true | true | emberjs | ember.js | 9,363 |
d2c1f99e36c753fde4fe33b1396eb7e1dece6fce | Chad Hietala | Chad Hietala | [Glimmer2] Move renderNode refs in view_support | [glimmer2] move rendernode refs in view_support | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 9,364 |
1b2c171c39a0c22d8189212ae7a389e5a2c7ae32 | Robert Jackson | GitHub | Merge pull request #13738 from chadhietala/unskip-a-couple-input-tests
[Glimmer2] Unskip a couple tests related to {{input}} | merge pull request from chadhietala/unskip-a-couple-input-tests | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 9,365 |
de087ded60c6fb7e596b1cd94c27c37daaf64ff9 | Chad Hietala | Chad Hietala | [Glimmer2] Unskip a couple tests related to {{input}} | [glimmer2] unskip a couple tests related to {{input}} | 53 | false | false | 8 | false | false | false | emberjs | ember.js | 9,366 |
eccb363653c1fd8db51189b5b3e8884ae79fae19 | Robert Jackson | GitHub | Merge pull request #13615 from asakusuma/input-dynamic
[Glimmer2] Implement input | merge pull request from asakusuma/input-dynamic | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,367 |
22e1b1314457e1e06e5f94be0633c27801aa3fbe | asakusuma | asakusuma | [Glimmer2] Implement input | [glimmer2] implement input | 26 | false | false | 3 | false | false | false | emberjs | ember.js | 9,368 |
ffd3d203eb0543e0c2f0c1fd873b784e73d76fda | Chad Hietala | Chad Hietala | [Glimmer2] Implement teardown | [glimmer2] implement teardown | 29 | false | false | 3 | false | false | false | emberjs | ember.js | 9,369 |
39b606fd40b1ca1a5b8fb69d81d99c446f3a86e7 | Robert Jackson | GitHub | Merge pull request #12964 from Charizard/fix-stack-trace-in-firefox
[BUGFIX beta] Fix Error object's stacktrace inconsistency across browsers | merge pull request from charizard/fix-stack-trace-in-firefox | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 9,370 |
add23a347f82031b2fc3c1e1af43fab0a2b1f826 | Dan Gebhardt | Dan Gebhardt | [FEATURE ember-application-engines] Make router DSL engine-aware. | [feature ember-application-engines] make router dsl engine-aware | 64 | false | false | 6 | false | false | false | emberjs | ember.js | 9,371 |
ece9045da630cdbe532c4b2a33d1bf68e2961a9e | Robert Jackson | GitHub | Merge pull request #13729 from tricknotes/remove-ember-metal-replace
[BUGFIX beta] Remove unreferenced function from `ember-metal/replace` | merge pull request from tricknotes/remove-ember-metal-replace | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 9,372 |
c9b09a357d0328dc8e9ee8bb4a983b0088398308 | Robert Jackson | GitHub | Merge pull request #13730 from cafedomancer/fix-typo
[DOC release] Fix a typo | merge pull request from cafedomancer/fix-typo | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,373 |
8bc716b78805055a8dcaab599e5d1fab3d76ff54 | Robert Jackson | GitHub | Merge pull request #13731 from tricknotes/remove-unnecessary
[CLEANUP beta] Remove unreferenced module 'ember-runtime/core' | merge pull request from tricknotes/remove-unnecessary | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,374 |
6a97907ccc0ceeadcbbef6c66fda080e926c42b2 | Yuvaraja Balamurugan | Yuvaraja Balamurugan | Fix Error object's stacktrace inconsistency across browsers | fix error object's stacktrace inconsistency across browsers | 59 | false | false | 7 | false | false | false | emberjs | ember.js | 9,375 |
c148e90264337b7d98fb420cb67ab40b631ce51f | Dan Gebhardt | Dan Gebhardt | [FEATURE ember-application-engines] Make router engine-aware. | [feature ember-application-engines] make router engine-aware | 60 | false | false | 5 | false | false | false | emberjs | ember.js | 9,376 |
c1e71f9c32d9e8e79a1e34493e1ef860dde3ca91 | Dan Gebhardt | Dan Gebhardt | [FEATURE ember-application-engines] Make outlets engine-aware. | [feature ember-application-engines] make outlets engine-aware | 61 | false | false | 5 | false | false | false | emberjs | ember.js | 9,377 |
8bf216f59692136eded9ab9fd7b253696dbe096a | Dan Gebhardt | Dan Gebhardt | [FEATURE ember-application-engines] Make routes engine-aware. | [feature ember-application-engines] make routes engine-aware | 60 | false | false | 5 | false | false | false | emberjs | ember.js | 9,378 |
bf9cb8f8fbcae0d6328595c4a981e62636ec79f9 | cafedomancer | cafedomancer | [DOC release] Fix a typo | [doc release] fix a typo | 24 | false | false | 5 | false | false | false | emberjs | ember.js | 9,379 |
c36672ff1a22eba04d6ca616cd84b6f8ce6ba85b | Ryunosuke Sato | Ryunosuke Sato | [CLEANUP beta] Remove unreferenced module 'ember-runtime/core'
It is unnecessary since 149c4f41. | [cleanup beta] remove unreferenced module 'ember-runtime/core' | 62 | false | false | 6 | false | false | false | emberjs | ember.js | 9,380 |
879a17410b0c9e2e2204ad2bf949f286557bb0ab | Ryunosuke Sato | Ryunosuke Sato | [BUGFIX beta] Remove unreferenced function from `ember-metal/replace`
This old function `replace` became unnecessary with the followings:
* Ember.ArrayController: 9899dffe
* Ember.Select: 4b5b9729 | [bugfix beta] remove unreferenced function from `ember-metal/replace` | 69 | false | false | 7 | false | false | false | emberjs | ember.js | 9,381 |
2335a917d6944b832db17e482a42c0b381da4543 | Robert Jackson | GitHub | Merge pull request #13719 from chadhietala/cleanup-compile-helpers
[CLEANUP] Compile/precompile should use same code path | merge pull request from chadhietala/cleanup-compile-helpers | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 9,382 |
0d8a7e07191640d17dfc7d812df1b9adfe838210 | Robert Jackson | GitHub | Merge pull request #13724 from chadhietala/class-name-binding-setting
[Glimmer 2] Support classNameBindings from the call site | merge pull request from chadhietala/class-name-binding-setting | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 9,383 |
d5b0c5af8fcd17f3d34c604ea4f59ada39c2a34e | Robert Jackson | GitHub | Merge pull request #13725 from bmac/fix-data-adapter-test
Bind the watchModelTypes's release function to `this` so it correctly… | merge pull request from bmac/fix-data-adapter-test | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,384 |
61c6ab542bff78bc5935c69888549e587bccca07 | Robert Jackson | GitHub | Merge pull request #13716 from rwjblue/add-back-test-waiters
[BUGFIX beta] Bring back Ember.Test.waiters. | merge pull request from rwjblue/add-back-test-waiters | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,385 |
76b054ce19dcbde5fa7e7012683a09bd87d1237a | Robert Jackson | GitHub | Merge pull request #13726 from zackthehuman/action-issues
[GLIMMER2] Click action links instead of touching action manager internals | merge pull request from zackthehuman/action-issues | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,386 |
c8183b6631b5978a00584b2f2aa4b347a4825253 | Zack Mulgrew | Zack Mulgrew | Click action links instead of touching action manager internals | click action links instead of touching action manager internals | 63 | false | false | 9 | true | true | false | emberjs | ember.js | 9,387 |
f5926fe3579abf4fc5cb94ce0f90e185295fae26 | Chad Hietala | Chad Hietala | [Glimmer 2] Support classNameBindings from the call site | [glimmer 2] support classnamebindings from the call site | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 9,388 |
a6c775764300139a6899d06e926e1ac6a21e1a00 | bmac | bmac | Bind the watchModelTypes's release function to `this` so it correctly removes the array observers | bind the watchmodeltypes's release function to `this` so it correctly removes the array observers | 97 | false | false | 14 | false | false | false | emberjs | ember.js | 9,389 |
ad29f5b7a5ee31eedc36a18c88db7bf25e9d4f47 | Chad Hietala | Chad Hietala | [CLEANUP] Compile/precompile should use same code path | [cleanup] compile/precompile should use same code path | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 9,390 |
c381acb726166de5caa2520e09d67a7e2d1bcc45 | Robert Jackson | Robert Jackson | [BUGFIX beta] Bring back Ember.Test.waiters.
Brings back `Ember.Test.waiters` and adds a feature flag for exposing
`Ember.Test.checkWaiters`. | [bugfix beta] bring back ember.test.waiters | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 9,391 |
d2b56a290a45b23a792575dfa6e3af37cf58bc79 | Robert Jackson | GitHub | Merge pull request #13721 from fivetanley/fix-each-key-test
[glimmer2] fix #each with key option test | merge pull request from fivetanley/fix-each-key-test | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,392 |
53fa8febfd5d0bda95b1df0c8b27e56cf4ec1ec5 | Stanley Stuart | GitHub | Merge pull request #13722 from fivetanley/each-key-collission-tests
[glimmer2] add collission tests for #each key="key" | merge pull request from fivetanley/each-key-collission-tests | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 9,393 |
a75be5c1c5ef9a39e768acf1db75d513daea3d65 | Robert Jackson | GitHub | Merge pull request #13720 from emberjs/prevent-safestring-deprecation-without-feature
[FEATURE ember-string-ishtmlsafe] Prevent deprecation when not enabled. | merge pull request from emberjs/prevent-safestring-deprecation-without-feature | 79 | true | false | 5 | true | false | false | emberjs | ember.js | 9,394 |
dd940d1f5ed8ea0e7ea24bb965f561ec00c2197c | Stanley Stuart | Stanley Stuart | [glimmer2] add collission tests for #each key="key" | [glimmer2] add collission tests for #each key="key" | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 9,395 |
10cc6e83f287b658495c0885ec9cb1ad1022a07d | Robert Jackson | GitHub | Merge pull request #13718 from chadhietala/attrs-ordering
[Glimmer 2] Attrs merging should not clobber | merge pull request from chadhietala/attrs-ordering | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,396 |
581d898b0b1fb58d7aeda93310a746268aaefb02 | Stanley Stuart | Stanley Stuart | [glimmer2] fix #each with key option test
In Ember, you can remove duplicates in an array by providing the `key`
option to the `{{#each}}` helper.
For example, if given the following `model` property:
```javascript
[
{
"id": "1",
"name": "Robert Jackson"
},
{
"id": "1",
"name": "Robert Jackson with diff name but same ID"
},
{
"id": "2",
"name": "Katie Gengler"
}
]
```
And the following template:
```handlebars
{{#each model key="id" as |person|
{{person.name}}
{{/each}}
```
It would render the following:
```html
Robert Jackson
Katie Gengler
```
Even though we have two objects with "Robert Jackson" as the name, they
share the same "id", so Ember will only render the first object it
encounters with that "id" while iterating. That's why "Robert Jackson"
shows up but not "Robert Jackson with diff name but same ID".
This test was adding in a new object (in our case `{text: ' '}`), but an
object with `{text: ' '}` already existed in the setup line. Because it
was cached by the same `'text'` value, it did not show up in the
subsequent rerender.
We change it to a different text value so we can assert it was added
correctly in the list.
refs #13644 | [glimmer2] fix #each with key option test | 41 | false | false | 7 | false | false | false | emberjs | ember.js | 9,397 |
c802a8dec35bd434ae436936660f99f124ec2336 | Robert Jackson | Robert Jackson | [FEATURE ember-string-ishtmlsafe] Prevent deprecation when not enabled. | [feature ember-string-ishtmlsafe] prevent deprecation when not enabled | 70 | false | false | 7 | false | false | false | emberjs | ember.js | 9,398 |
04f1136214841c0b8dedbff245cebd9f9f2953ac | Chad Hietala | Chad Hietala | [Glimmer 2] Attrs merging should not clobber | [glimmer 2] attrs merging should not clobber | 44 | false | false | 7 | false | false | false | emberjs | ember.js | 9,399 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.