sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
a89dcfc0bc1d045de9fb5a8c47c4c0b498454df6 | Robert Jackson | GitHub | Merge pull request #13857 from rwjblue/fix-bootstrapping-initializer
Fix bootstrapping of script tag templates. | merge pull request from rwjblue/fix-bootstrapping-initializer | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 9,200 |
0a56e68653cd9751eb6437f9a7ee5d86a8df644d | Robert Jackson | Robert Jackson | Fix bootstrapping of script tag templates.
There were two main issues with this:
* When the `ember-template-compiler/system/bootstrap` module was
present, the initializers `initialize` function was being set to an
object (not a function). The fix is "simple", grab the `.default`
export from the module.
* Depending on timing, the
`ember-application/initializers/dom-templates` module is evaluated
before the second script tag including `ember-template-compiler.js`,
which means that the `bootstrap` function was never updated (since it
was only checking for the boostrap module at eval time). The fix for
this is to lazily check for the module during the initializer itself. | fix bootstrapping of script tag templates | 41 | false | false | 6 | false | true | false | emberjs | ember.js | 9,201 |
dc3cfac0234e4ef0ba23235b81c7d169ccee43d5 | Robert Jackson | GitHub | Merge pull request #13856 from rwjblue/fix-escapeExpression-export
Fix Ember.Handlebars.Utils.escapeExpression global export. | merge pull request from rwjblue/fix-escapeexpression-export | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 9,202 |
99096ec022923ae6b73a270417888010b2bce207 | Robert Jackson | GitHub | Merge pull request #13851 from rwjblue/style-tests
[GLIMMER] Migrate remaining `style` attribute tests from HTMLBars. | merge pull request from rwjblue/style-tests | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 9,203 |
245488d6159449bb466a5b1d39939db11745039a | Robert Jackson | GitHub | Merge pull request #13855 from rwjblue/enable-features
Enable features approved on 2016-07-15. | merge pull request from rwjblue/enable-features | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,204 |
696e6b2507ce95d0c76735b9300f028e8e774785 | Robert Jackson | Robert Jackson | Fix Ember.Handlebars.Utils.escapeExpression global export.
* Fix export of `Ember.Handlebars.Utils.escapeExpression`.
* Create `getSafeString` getter function in the engine specific package.
* Add tests for compat exports from ember-templates. | fix ember.handlebars.utils.escapeexpression global export | 57 | false | false | 4 | false | true | false | emberjs | ember.js | 9,205 |
428ad545166151a9d4c664278e46865a104db572 | Robert Jackson | Robert Jackson | [FEATURE ember-testing-check-waiters] Enable by default. | [feature ember-testing-check-waiters] enable by default | 55 | false | false | 5 | false | false | false | emberjs | ember.js | 9,206 |
1197729a9b5792123a9190eddafa40ac9a559112 | Robert Jackson | Robert Jackson | [FEATURE ember-string-ishtmlsafe] Enable by default. | [feature ember-string-ishtmlsafe] enable by default | 51 | false | false | 5 | false | false | false | emberjs | ember.js | 9,207 |
84b16eb36772b5292e392309d79ce66b0a70b1ab | Robert Jackson | Robert Jackson | [FEATURE ember-runtime-enumerable-includes] Enable by default. | [feature ember-runtime-enumerable-includes] enable by default | 61 | false | false | 5 | false | false | false | emberjs | ember.js | 9,208 |
1f3a1e35ce388aa2e21fcc1f6baa3cd8faefe15a | Robert Jackson | Robert Jackson | [FEATURE ember-application-engines] Enable by default. | [feature ember-application-engines] enable by default | 53 | false | false | 5 | false | false | false | emberjs | ember.js | 9,209 |
6c5d3c3ee8858495e93a3f355c8c86946414c5cc | Robert Jackson | Robert Jackson | Migrate remaining `style` attribute tests from HTMLBars. | migrate remaining `style` attribute tests from htmlbars | 55 | false | false | 7 | false | true | false | emberjs | ember.js | 9,210 |
6933403faf2f91b08a150902458114b5616dc29f | Kris Selden | GitHub | Merge pull request #13852 from rwjblue/pass-through-view-registry
[GLIMMER] Ensure the view registry is propagated. | merge pull request from rwjblue/pass-through-view-registry | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 9,211 |
2a233df8c6aa387898299d79dd4b2965b4266015 | Robert Jackson | Robert Jackson | Use the renderer to manage the view registry.
* Remove usage of `Ember.View.views`. This has not been exposed since 1.x.
* Use the renderer to update view registry. | use the renderer to manage the view registry | 44 | false | false | 8 | true | true | true | emberjs | ember.js | 9,212 |
7246a373d229a8c2b548d935fc0a9d6a72a2bc70 | Robert Jackson | GitHub | Merge pull request #13764 from Serabe/fix/13742
[BUGFIX beta] Keep rest positional parameters when nesting contextual components if needed. | merge pull request from serabe/fix/13742 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 9,213 |
7737eb4a86dccf5b1f228cbf761b48a0e9c8258b | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] Keep rest positional parameters when nesting contextual
components if needed.
Steps to reproduce the bug before this patch:
1. Create a component with rest positional param (like `link-to`).
2. Create contextual component (`(component "link-to" "index")`).
3. Render it (`{{component (component "link-to" "index")}}`).
4. Realize the component did not receive `"index"` at all.
What was causing it?
====================
Because of how positional parameters work (both in components and contextual
components), it is needed to treat them at each level and then merge them.
Sadly, this was causing to overwrite the rest positional parameters because
when no parameters are passed, the attribute get an empty array nonetheless.
In the example above, assuming `LinkToComponent.positionalParams === 'params'`:
1. Contextual component in `2` gets its positional parameters processed and
receives the following named parameters `{ params: ['index'] }`.
2. When rendering, the `{{component}}` processes its own parameters getting
`{ params: [] }`. Then it merges in a `new EmptyObject()` these attributes
on top of the ones in the contextual component. (See what I did there?
I used the JS keyword `new` as an adjective! He he. Don't judge me, it is
pretty late in here)
Solving the issue
=================
This PR changes the implementation of `mergeInNewHash` to keep the original
positional parameters if the new ones are empty and the positional parameter is
of type rest.
Fixes #13742 | [bugfix beta] keep rest positional parameters when nesting contextual | 69 | false | false | 9 | false | false | false | emberjs | ember.js | 9,214 |
52ba7d0325f034475e93887eee48110de514455d | Chad Hietala | GitHub | Merge pull request #13845 from chadhietala/rando-tests
[Glimmer2] tests for html-safe and render | merge pull request from chadhietala/rando-tests | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,215 |
cbe74dddf20eda2fdd64526b0723025cfe58ff4f | Robert Jackson | GitHub | Merge pull request #13850 from chadhietala/fix-action-scope
[Glimmer2] Fix action target in a block | merge pull request from chadhietala/fix-action-scope | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,216 |
a9fe3744481d1ec4b3f85bf768cf56797739189f | Chad Hietala | Chad Hietala | [Glimmer2] tests for html-safe and render
Maintain our own safestring and escapeexpression for now | [glimmer2] tests for html-safe and render | 41 | false | false | 6 | false | false | false | emberjs | ember.js | 9,217 |
f718cdb3793c1c31e73a4451a14e2bd34741446d | Chad Hietala | Chad Hietala | [Glimmer2] Fix action target in a block | [glimmer2] fix action target in a block | 39 | false | false | 7 | false | false | false | emberjs | ember.js | 9,218 |
5757ea5f8a7dd4e93113d1a195e18532656c07ea | Robert Jackson | GitHub | Merge pull request #13843 from rwjblue/move-bootstrapping
Make `ember-template-compiler` unneeded in ember.prod.js. | merge pull request from rwjblue/move-bootstrapping | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,219 |
68fbec3c94af5b811d8aa8e4d2ab4818ae7c4300 | Robert Jackson | Robert Jackson | Update node tests to properly simulate precompilation. | update node tests to properly simulate precompilation | 53 | false | false | 7 | true | true | false | emberjs | ember.js | 9,220 |
a642ec941ec323be72e0288e4a369850555d76df | Robert Jackson | Robert Jackson | Update emberjs-build to fix dist output.
* Ensures that `ember-templates` is available in
`ember-template-compiler`
* Removes `ember-template-compiler` (and related packages) from
`ember.debug.js` and `ember.prod.js`. | update emberjs-build to fix dist output | 39 | false | false | 6 | true | true | true | emberjs | ember.js | 9,221 |
eca90811385d694ad7f63fcd64196e151a3921b8 | Robert Jackson | Robert Jackson | Move `template` method to respective engine packages.
This is currently exposed as `Ember.HTMLBars.template` and
`Ember.Handlebars.template` (we should probably figure out a more
generic place for this in both globals and modules land), and is the
only piece of the `ember-template-compiler` that is actually needed at
runtime when the `dist/ember-template-compiler.js` file is not present.
This paves the way to removing `ember-template-compiler` packge from
`ember.debug.js` and `ember.prod.js` (without changing any public API's
or expectations). | move `template` method to respective engine packages | 52 | false | false | 7 | false | true | false | emberjs | ember.js | 9,222 |
0140ffef8bd782a2e15fd9007bcd196ac4f8709f | Robert Jackson | Robert Jackson | Move globals based template bootstrapping code.
* Avoid requiring `jQuery` from `ember-views` within the
ember-template-compiler (just use normal DOM API's).
* Add `domTemplates` initializer inside `ember-application` package | move globals based template bootstrapping code | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 9,223 |
2e18421c26de3d1a806a805c36c6e4e4ee866aa7 | Robert Jackson | GitHub | Merge pull request #13839 from asakusuma/action-instrument
[FEATURE ember-improved-instrumentation] Basic actions | merge pull request from asakusuma/action-instrument | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 9,224 |
62e8e297d750c2622e2da2b740a0ef8485c05c63 | asakusuma | asakusuma | [FEATURE ember-improved-instrumentation] Basic actions
Ensure basic actions, not just closure actions, are instrumented | [feature ember-improved-instrumentation] basic actions | 54 | false | false | 4 | false | false | false | emberjs | ember.js | 9,225 |
a20e1f186f71f44a2b173f90d10cf746c24b40b3 | Robert Jackson | GitHub | Merge pull request #13842 from dgeb/component-lookup
Register `component-lookup:main` for all engines. | merge pull request from dgeb/component-lookup | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,226 |
0fd0d57d65ab42c98161a100b8d6361cf5d01de3 | Dan Gebhardt | Dan Gebhardt | Register `component-lookup:main` for all engines.
This registration is required for applications _and_ engines. | main` for all engines | 21 | false | false | 4 | false | false | false | emberjs | ember.js | 9,227 |
477ebf13499421e903e805815ec109ea9c29c2c1 | Robert Jackson | GitHub | Merge pull request #13841 from rwjblue/move-component-lookup-main
Add component-lookup:main during normal registry setup. | merge pull request from rwjblue/move-component-lookup-main | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 9,228 |
0fb7e4ddd69b30009327f9df5f0ac89cdad65700 | Robert Jackson | Robert Jackson | Add component-lookup:main during normal registry setup.
There really is no reason to delay registering `component-lookup:main`
here, and we plan to move this whole bootstrapping process to be done
only when the template compiler is actually loaded/present. Moving
`component-lookup:main` here is a precursor for that. | main during normal registry setup | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 9,229 |
46a8721b13ae7119889c86abf3e1a8ce0bf3aa7f | Robert Jackson | GitHub | Merge pull request #13838 from chadhietala/cleanup-views
[Glimmer2/Cleanup] Remove tests related to private View APIs | merge pull request from chadhietala/cleanup-views | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 9,230 |
8cfd2571fff00b1a3a3a8d718b6bd7d39e64d0e2 | Stefan Penner | GitHub | Merge pull request #13837 from chadhietala/moar-test-helper-tests
[Glimmer2] Unskip test helper tests related to chaining | merge pull request from chadhietala/moar-test-helper-tests | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 9,231 |
aa537322d9c7980a85fac486b0b5e522e504c4bd | Chad Hietala | Chad Hietala | [GLimmer2/Cleanup] Remove tests related to private View APIs | [glimmer2/cleanup] remove tests related to private view apis | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 9,232 |
a06493ec8cca58e67641415675b0740c679a672c | Robert Jackson | GitHub | Merge pull request #13836 from chadhietala/cleanup-helpers
[CLEANUP] Cleanup test helpers | merge pull request from chadhietala/cleanup-helpers | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 9,233 |
65d7734b589fbd7e60edf1dbab50848e8680b540 | Robert Jackson | GitHub | Merge pull request #13772 from chadhietala/rerendering-attrs
[Glimmer2] Add test for glimmer re-renders | merge pull request from chadhietala/rerendering-attrs | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,234 |
244c2514217733301b0e398f0b6d09e2996f1c81 | Chad Hietala | Chad Hietala | [Glimmer2] Unskip test helper tests related to chaining | [glimmer2] unskip test helper tests related to chaining | 55 | false | false | 8 | false | false | false | emberjs | ember.js | 9,235 |
86d68628b82a6ea2d850cef09776410cde38c4a7 | Kris Selden | GitHub | Merge pull request #13835 from chadhietala/several-tests
[Glimmer2] Fix some tests related input | merge pull request from chadhietala/several-tests | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 9,236 |
05534f080695b567441f4a70b0123a0d472fe891 | Chad Hietala | Chad Hietala | [CLEANUP] Cleanup test helpers | [cleanup] cleanup test helpers | 30 | false | false | 4 | false | false | false | emberjs | ember.js | 9,237 |
e4cb9f48b8af0f60af20f78dbd268a6c980d79a4 | Chad Hietala | Chad Hietala | [Glimmer2] Fix some tests related input | [glimmer2] fix some tests related input | 39 | false | false | 6 | false | false | false | emberjs | ember.js | 9,238 |
64865a827d3b8b1364e01bb1ad5911a538c9bfb5 | Kris Selden | GitHub | Merge pull request #13829 from emberjs/new-component-layout-caching
[GLIMMER] Refactor of template compiling and caching. | merge pull request from emberjs/new-component-layout-caching | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 9,239 |
9ebda97047be7f8ce2c5b3f4e4568cdc25844dea | Robert Jackson | GitHub | Merge pull request #12974 from vikram7/vr-object-syntax-typo
[DOC release] Fix spacing typo in objects | merge pull request from vikram7/vr-object-syntax-typo | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,240 |
67081fae8121d48e2c42e8e47e2c3bb5cec3c6d3 | Vikram Ramakrishnan | Vikram Ramakrishnan | fix spacing typo in object | fix spacing typo in object | 26 | false | false | 5 | false | true | false | emberjs | ember.js | 9,241 |
da6ce36bd818199f6fe5ae325a2dbede64c8de51 | Kris Selden | Kris Selden | Share the OutletLayoutCompiler which is identical to the RenderLayoutCompiler | share the outletlayoutcompiler which is identical to the renderlayoutcompiler | 77 | false | false | 9 | true | true | false | emberjs | ember.js | 9,242 |
092fd990993b847ca26a5a814b2934c3752cac39 | Kris Selden | Kris Selden | Add more flexibility to Cache and use it for caching in the glimmer
Environment. | add more flexibility to cache and use it for caching in the glimmer | 67 | false | false | 13 | true | true | false | emberjs | ember.js | 9,243 |
7edd6ff77369f162eab86139d35377f91a39c1f2 | Godfrey Chan | Kris Selden | Migrate to use new layoutFor APIs | migrate to use new layoutfor apis | 33 | false | false | 6 | false | false | false | emberjs | ember.js | 9,244 |
64724530f7a3e1943091150b040b46cdeec59f93 | Homu | Homu | Auto merge of #13834 - emberjs:rwjblue-patch-2, r=stefanpenner
Remove broken `require('jquery')`.
Originally [this line](https://github.com/emberjs/ember.js/blob/3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4/packages/ember-views/lib/system/jquery.js#L8) was checking for a global `require`, but as of https://github.com/emberjs/ember.js/pull/13440 we changed to import or own internal `require`. At the moment, that `require('jquery')` (using our internal loader's version of `require`) will never find a module named `jquery` and will error.
I believe we should just remove this guard/check completely. We can always reevaluate if folks still need this for something...
/cc @krisselden | rwjblue-patch-2, r=stefanpenner | 31 | false | false | 2 | false | false | false | emberjs | ember.js | 9,245 |
73060aa0bcd1251198cbafdf6a4b256c17f1a41d | Robert Jackson | GitHub | Remove broken `require('jquery')`.
Originally [this line](https://github.com/emberjs/ember.js/blob/3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4/packages/ember-views/lib/system/jquery.js#L8) was checking for a global `require`, but as of https://github.com/emberjs/ember.js/pull/13440 we changed to import or own internal `require`. At the moment, that `require('jquery')` (using our internal loader's version of `require`) will never find a module named `jquery` and will error.
I believe we should just remove this guard/check completely. We can always reevaluate if folks still need this for something... | remove broken `require('jquery')` | 33 | false | false | 3 | true | true | true | emberjs | ember.js | 9,246 |
3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4 | Godfrey Chan | GitHub | Merge pull request #13833 from chadhietala/some-tests
[Glimmer2] Unskip some tests that pass | merge pull request from chadhietala/some-tests | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 9,247 |
a0b94b146e6bba802c4e780d0d0854e357750d5f | Godfrey Chan | GitHub | Merge pull request #13811 from chadhietala/much-secure
[Glimmer 2] Unskip tests related to inline styles and unsafe hrefs | merge pull request from chadhietala/much-secure | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,248 |
a13fbbe36cdd67a67c54a291d74cabff46f8be0f | Godfrey Chan | GitHub | Merge pull request #13825 from chadhietala/basic-routing-tests-2
[GLIMMER2] Fix spooky {{render}}/route functionality | merge pull request from chadhietala/basic-routing-tests-2 | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 9,249 |
0dd85569e1a0b8f7c336559935376bc34b44219c | Chad Hietala | Chad Hietala | [Glimmer2] Unskip some tests that pass | [glimmer2] unskip some tests that pass | 38 | false | false | 6 | false | false | false | emberjs | ember.js | 9,250 |
fd367c6d16c399994550896b5b5c5142dc220b39 | Chad Hietala | Chad Hietala | [Glimmer 2] Unskip tests related to inline styles and unsafe hrefs
Part of #13644 | [glimmer 2] unskip tests related to inline styles and unsafe hrefs | 66 | false | false | 11 | false | false | false | emberjs | ember.js | 9,251 |
f8ff02170e701b429fd6ec233a796d24af126f0a | Chad Hietala | Chad Hietala | [GLIMMER2] Fix spooky {{render}}/route functionality
This is carry over from things that were not removed in 2.0. We really
should make it a point to deprecate this spooky functionality
post-glimmer release. This will to make sure we do not carry this
functionality for another JavaScript half-life. | [glimmer2] fix spooky {{render}}/route functionality | 52 | false | false | 5 | false | false | false | emberjs | ember.js | 9,252 |
62d0a35b584e11dcc5b9f3ce758344964f5a3574 | Godfrey Chan | GitHub | Merge pull request #13832 from emberjs/glimmer-test-updates
#13807 rebased | merge pull request from emberjs/glimmer-test-updates | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,253 |
8263842502adb64571ea64d8e926ce7e5199878d | Stanley Stuart | Godfrey Chan | [glimmer2] enable tests fixed by #13615
refs #13644 | [glimmer2] enable tests fixed by | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 9,254 |
4d0cebf302901d2867098c177cf15e7a5ef3c7bc | Robert Jackson | GitHub | Merge pull request #13827 from workmanw/is-html-safe-update
[FEATURE ember-string-ishtmlsafe] Changed `isHtmlSafe` to `isHTMLSafe` for consistency. | merge pull request from workmanw/is-html-safe-update | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,255 |
f11782083c07d5158fdab12fd7a0cb5b3297ce35 | Wesley Workman | Wesley Workman | [FEATURE ember-string-ishtmlsafe] Changed `Ember.String.isHtmlSafe` to `Ember.String.isHTMLSafe` for consistency. | [feature ember-string-ishtmlsafe] changed `ember.string.ishtmlsafe` to `ember.string.ishtmlsafe` for consistency | 112 | false | false | 8 | false | false | false | emberjs | ember.js | 9,256 |
2b4a919be852020ab472c7aacc5a3ed1854c6bed | Robert Jackson | GitHub | Merge pull request #13818 from trentmwillis/engine-substates
[FEATURE ember-application-engines] Enable loading and error substates for mounts | merge pull request from trentmwillis/engine-substates | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,257 |
8e2129ecf73c0b9f9e67fa045d2c064247f75e0e | Trent Willis | Trent Willis | [FEATURE ember-application-engines] Enable loading and error substates for mounts | [feature ember-application-engines] enable loading and error substates for mounts | 81 | false | false | 9 | false | false | false | emberjs | ember.js | 9,258 |
b117af32d1b0242f403352a6a1a39257cdfd04e2 | Robert Jackson | GitHub | Merge pull request #13820 from dgeb/mount-keyword
[FEATURE ember-application-engines] Introduce mount keyword. | merge pull request from dgeb/mount-keyword | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 9,259 |
ca2ae2b0416c54fbe7ee03dcf7357db83de4cec0 | Dan Gebhardt | Dan Gebhardt | [FEATURE ember-application-engines] Introduce mount keyword.
The `{{mount}}` keyword lets you embed a routeless engine in a template.
Mounting an engine will cause an instance to be booted and its
`application` template to be rendered. | [feature ember-application-engines] introduce mount keyword | 59 | false | false | 5 | false | false | false | emberjs | ember.js | 9,260 |
422adfb6f1d2c8693839ff1a3438c32608aa7f23 | Robert Jackson | GitHub | Merge pull request #13817 from trentmwillis/engine-route-serializers
[FEATURE ember-application-engines] Merge route serializers into engines work | merge pull request from trentmwillis/engine-route-serializers | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 9,261 |
db80416e4aeca78d5dce26c56eb9e2b7d528738c | Trent Willis | Trent Willis | [FEATURE ember-application-engines] Fix GlimmerEnvironment injection in Engines | [feature ember-application-engines] fix glimmerenvironment injection in engines | 79 | false | false | 7 | false | false | false | emberjs | ember.js | 9,262 |
f17383c004b3bc30e55c425bcc6dbb3fe83a1089 | Trent Willis | Trent Willis | [FEATURE ember-application-engines] Scope route-serializer behavior to Engines | [feature ember-application-engines] scope route-serializer behavior to engines | 78 | false | false | 7 | false | false | false | emberjs | ember.js | 9,263 |
4da6ebfc8d1df6108ff9ea948138c639ec709ea5 | Trent Willis | Trent Willis | [FEATURE ember-application-engines] Merge ember-route-serializers and ember-application-engines flags | [feature ember-application-engines] merge ember-route-serializers and ember-application-engines flags | 101 | false | false | 7 | false | false | false | emberjs | ember.js | 9,264 |
b19353f6faac7dbb10987a929871c034e0ac228f | Robert Jackson | GitHub | Merge pull request #13824 from trentmwillis/router-bump
Bump router.js to support async getHandler method | merge pull request from trentmwillis/router-bump | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 9,265 |
93a70d01e77fcb719182b42eacf527f31c39f3c0 | Trent Willis | Trent Willis | Bump router.js to support async getHandler method | bump router.js to support async gethandler method | 49 | true | false | 7 | true | true | false | emberjs | ember.js | 9,266 |
c47b1768f030d8959e95874a7abb49e06a36760a | Devin Weaver | Devin Weaver | Add container to yuidoc.json
Fixes #13734 | add container to yuidoc.json | 28 | false | false | 4 | true | true | true | emberjs | ember.js | 9,267 |
fc162b9e3c125f1afc22b16a96491a85d93e8451 | Devin Weaver | Devin Weaver | Add since param to getOwner docs
Per the discussion on #13734 I added the since parameter and reordered
to match other files. I searched the history to find the version number
when this was introduced:
git log --stat -- packages/container/lib/owner.js
git tag --contains 7d7450c99bbcec8e51b4adb184a147633603683e
Fixes #13734 | add since param to getowner docs | 32 | false | false | 6 | false | false | false | emberjs | ember.js | 9,268 |
72193d3f8f4708664813390b30112ea151b50a54 | Stefan Penner | GitHub | Merge pull request #13814 from kamilogorek/event-dispatcher-assertion
[BUGFIX Beta] Event dispatcher assertion | merge pull request from kamilogorek/event-dispatcher-assertion | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 9,269 |
aef1dd6689fee8c57fdacd3e08c1f21ae5331248 | Kamil Ogórek | Kamil Ogórek | [BUGFIX Beta] Added tests to EventDispatcher attach assertion | [bugfix beta] added tests to eventdispatcher attach assertion | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 9,270 |
c46d88d422d559013bee844b11f787bb08c4e6c7 | James Martinez | Kamil Ogórek | [BUGFIX Beta] Improve EventDispatcher attach assertion | [bugfix beta] improve eventdispatcher attach assertion | 54 | false | false | 6 | false | false | false | emberjs | ember.js | 9,271 |
77e63305ea0c48a3d0f1e6349daac4aa07e9074e | Kris Selden | GitHub | Merge pull request #13812 from chadhietala/svg-tests
[Glimmer2] Unskip SVG tests | merge pull request from chadhietala/svg-tests | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,272 |
d6e48318e68330acfdce0df290c1a050805b50f8 | Chad Hietala | Chad Hietala | [Glimmer2] Unskip SVG tests | [glimmer2] unskip svg tests | 27 | false | false | 4 | false | false | false | emberjs | ember.js | 9,273 |
57bd9ba06b0e8b2935fc2cf9681243600d342605 | Kris Selden | GitHub | Merge pull request #13810 from chadhietala/props-attributes
[Glimmer2] Fix property setting | merge pull request from chadhietala/props-attributes | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,274 |
2981ecfd97835b72858d25eeeaab3dbc54743fea | Kris Selden | GitHub | Merge pull request #13808 from asakusuma/global-local-lookup
[Glimmer2] Complete local lookup | merge pull request from asakusuma/global-local-lookup | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,275 |
0438278bbce0fc04b74c6d3144083ec5ed4888d3 | Chad Hietala | Chad Hietala | [Glimmer2] Fix property setting | [glimmer2] fix property setting | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 9,276 |
cfb8ac8f9d9f807af61cf7e627ca28609129c3b0 | Godfrey Chan | Godfrey Chan | v2.6.1 CHANGELOG [ci skip]
(cherry picked from commit af7776547dc5dba57cd99c75a1b2aa9332d6ac7d) | v2.6.1 changelog [ci skip] | 26 | false | false | 4 | false | false | false | emberjs | ember.js | 9,277 |
ceb1ca25da57a9399feef291b14b7110d04bd8c5 | asakusuma | asakusuma | [Glimmer2] Complete local lookup
- Turn on global override tests
- Fix fallback lookup error message | [glimmer2] complete local lookup | 32 | false | false | 4 | false | false | false | emberjs | ember.js | 9,278 |
9b11002d15fdfc03ab979be0aa9bdb645e9e21a5 | Kris Selden | GitHub | Merge pull request #13789 from asakusuma/helper-locals
[Glimmer2] Implement local lookup for helpers | merge pull request from asakusuma/helper-locals | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,279 |
fcd04520ecb8c0bb6b8c2e10a6198436bd5ac36a | asakusuma | asakusuma | Implement local lookup for helpers | implement local lookup for helpers | 34 | false | false | 5 | true | true | true | emberjs | ember.js | 9,280 |
84dc75a85f884057a2b4911a48cac95707372c86 | Robert Jackson | GitHub | Merge pull request #13769 from rwjblue/migrate-some-query-params
Migrate a few `link-to` tests to newer testing infrastructure. | merge pull request from rwjblue/migrate-some-query-params | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 9,281 |
eeb236e7190b2d6365a59757b14eeb92cc8e8157 | Robert Jackson | GitHub | Merge pull request #13799 from Turbo87/no-object
Rename "Object" imports to "EmberObject" | merge pull request from turbo87/no-object | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 9,282 |
2fefde66fd7a06bf1f0121c1e1bcdbb6ddbe455e | Kris Selden | GitHub | Merge pull request #13797 from rwjblue/prevent-slowdown-inprod
[BUGFIX beta] Ensure didInitAttrs deprecation is stripped in prod. | merge pull request from rwjblue/prevent-slowdown-inprod | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 9,283 |
67a9111ff35488be1a55365995614449d4febb25 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure didInitAttrs deprecation is stripped in prod.
In production builds, the `didInitAttrs` deprecation was not being fully
stripped. This refactors to remove the guarding `if` (in favor
`Ember.deprecate` test parameter). | [bugfix beta] ensure didinitattrs deprecation is stripped in prod | 65 | false | false | 9 | false | false | false | emberjs | ember.js | 9,284 |
f8d7dbc5ac0e7945b0038f416be93e2a22fcc9af | Robert Jackson | GitHub | Merge pull request #13785 from rwjblue/remove-remains-of-glimmer-1-angle-bracket-support
[CLEANUP/BUGFIX lts] Remove remnants of angle bracket components. | merge pull request from rwjblue/remove-remains-of-glimmer-1-angle-bracket-support | 82 | true | false | 5 | true | false | false | emberjs | ember.js | 9,285 |
be8fae5845e6097650c2044eeee1ea4ebbafd2a5 | Tobias Bieniek | Tobias Bieniek | Rename "Object" imports to "EmberObject"
Importing this as "Object" hides the native "Object" API which can lead to unexpected results. | rename "object" imports to "emberobject" | 40 | false | false | 5 | false | true | false | emberjs | ember.js | 9,286 |
08dbada375a968f353a10a71aed95f87d372149f | Peter Wagenet | Robert Jackson | [BUGFIX release] Fix Location#getURL
Prior fixes to NoneLocation and HistoryLocation's getURL broke the
case where the rootURL or baseURL matched the start of the main URL.
Resolve that case by checking for a subsequent forward slash or end
of string.
(cherry picked from commit fe473a2936b0d4514d6bf504a6b98633a65818ba) | [bugfix release] fix location#geturl | 36 | false | false | 4 | false | false | false | emberjs | ember.js | 9,287 |
0ffcf8209be2e11b8f2fa5c4b5b7acc11a9fbc45 | Godhuda | Godhuda | Update CHANGELOG for 2.7 beta 3
(cherry picked from commit b27e3a1ef2ead96693097617bd9ce92aa125cf2f) | update changelog for 2.7 beta 3 | 31 | false | false | 6 | true | true | true | emberjs | ember.js | 9,288 |
e81b9951b6c3e90be016b6eb9b070612a9ef3222 | Robert Jackson | GitHub | Merge pull request #13792 from igor-drozdov/patch-1
[DOC] Fix typo | merge pull request from igor-drozdov/patch-1 | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,289 |
d28c1b19b4089abde8185af29ad3b17e01c9301a | Robert Jackson | GitHub | Merge pull request #13791 from bmeurant/jscs-fails-windows
Fix Windows builds | merge pull request from bmeurant/jscs-fails-windows | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 9,290 |
e92bae18b80038126fb4bbe62d17759ea6bc5792 | Igor Drozdov | GitHub | [DOC] Fix typo | [doc] fix typo | 14 | false | false | 3 | false | false | false | emberjs | ember.js | 9,291 |
0bd185a38b599a1c65f6922ae655c4a1ba5f6091 | Baptiste Meurant | Baptiste Meurant | Fixes errors when running `npm test` & `npm test:sauce` on Windows | sauce` on windows | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 9,292 |
2c73ee6cbc15143307a765994118ad163281ef3c | Baptiste Meurant | Baptiste Meurant | Fixes JSCS failures on Windows. related to #13227 | fixes jscs failures on windows. related to | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 9,293 |
202a0277af2d3ac341879e72bc7e56f1a06d3d71 | Baptiste Meurant | Baptiste Meurant | Update api doc for Enumerable#contains to flag it as deprecated | update api doc for enumerable#contains to flag it as deprecated | 63 | false | false | 10 | true | true | false | emberjs | ember.js | 9,294 |
e59f5af41f1896cb8d84010ea0897bd6c930dd33 | Chad Hietala | Chad Hietala | [Glimmer2] Add test for glimmer re-renders | [glimmer2] add test for glimmer re-renders | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 9,295 |
83824c117d9c5636bb6227ec8b23baead35b4b9e | Robert Jackson | Robert Jackson | [CLEANUP/BUGFIX lts] Remove angle bracket component remnants.
The original techniques/hooks were removed when the feature was removed,
but this code remained. Unfortunately, when tagName is '' we were still
attempting to `''.charCodeAt(0)` which deopts the native `charCodeAt`. | [cleanup/bugfix lts] remove angle bracket component remnants | 60 | false | false | 7 | false | false | false | emberjs | ember.js | 9,296 |
45c92fb2c8931b4ca41313b52c2ea5e4a4444a8e | Robert Jackson | Robert Jackson | [BUGFIX beta] Prevent indexing into primitive types.
Doing `obj[GUID_KEY]` on primitive objects (strings, booleans,
numbers, etc) will not work, and triggers a deopt.
 | [bugfix beta] prevent indexing into primitive types | 51 | false | false | 7 | false | false | false | emberjs | ember.js | 9,297 |
accb666283ec02d48436cebc36db885ade03dc9b | Robert Jackson | Robert Jackson | [BUGFIX beta] Prevent deopting `Mixin.detect` for each type found.
With the truthiness check that existed before, this method is deopted
everytime it sees a new type of value.
See screenshots from irhydra, where `Mixin.detect` is inlined into
`Stream.prototype.revalidate`:
First optimized after having seen `Bool,Smi,SpecObject,String` as types:
Then it sees a new type of value (`undefined`) and deoptimizes:
Changing the guard to use `typeof obj === 'object' && obj !== null`
prevents the deopt (and prevents us from checking if `Bool`, `Smi`,
`SpecObject`, `String`, etc objects are Mixins). | [bugfix beta] prevent deopting `mixin.detect` for each type found | 65 | false | false | 9 | false | false | false | emberjs | ember.js | 9,298 |
5b649f47ba98a153a4730407fe49cf4761a02708 | Robert Jackson | Robert Jackson | [BUGFIX beta] Check `typeof` before testing for truthiness.
Using the `typeof` check before the truthiness check, prevents deopts in
Chrome for each new object type that is seen (after it initially
optimizes). | [bugfix beta] check `typeof` before testing for truthiness | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 9,299 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.