language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
spring-webmvc/src/main/java/org/springframework/web/servlet/view/groovy/GroovyMarkupConfigurer.java
@@ -80,7 +80,7 @@ * @author Rossen Stoyanchev * @since 4.1 * @see GroovyMarkupView - * @see <a href="http://groovy-lang.org/templating.html#_the_markuptemplateengine"> + * @see <a href="https://groovy-lang.org/templating.html#_the_markuptemplateengine"> * Groovy Markup Template engine documentation</a> */...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
spring-webmvc/src/main/java/org/springframework/web/servlet/view/groovy/GroovyMarkupView.java
@@ -47,7 +47,7 @@ * @since 4.1 * @see GroovyMarkupViewResolver * @see GroovyMarkupConfigurer - * @see <a href="http://groovy-lang.org/templating.html#_the_markuptemplateengine"> + * @see <a href="https://groovy-lang.org/templating.html#_the_markuptemplateengine"> * Groovy Markup Template engine documentation</a...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
spring-webmvc/src/main/java/org/springframework/web/servlet/view/groovy/package-info.java
@@ -1,6 +1,6 @@ /** * Support classes for the integration of - * <a href="http://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html#_the_markuptemplateengine"> + * <a href="https://groovy-lang.org/templating.html#_the_markuptemplateengine"> * Groovy Templates</a> as Spring web view technology....
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/core/core-expressions.adoc
@@ -1677,7 +1677,7 @@ ternary operator. === The Elvis Operator The Elvis operator is a shortening of the ternary operator syntax and is used in the -http://www.groovy-lang.org/operators.html#_elvis_operator[Groovy] language. +https://www.groovy-lang.org/operators.html#_elvis_operator[Groovy] language. With the ter...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/data-access.adoc
@@ -131,7 +131,7 @@ Typically, you need an application server's JTA capability only if your applicat to handle transactions across multiple resources, which is not a requirement for many applications. Many high-end applications use a single, highly scalable database (such as Oracle RAC) instead. Stand-alone transact...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/rsocket.adoc
@@ -53,7 +53,7 @@ through RSocket across the network. === The Protocol One of the benefits of RSocket is that it has well defined behavior on the wire and an -easy to read https://rsocket.io/about/Protocol[specification] along with some protocol +easy to read https://rsocket.io/about/protocol[specification] along w...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/testing.adoc
@@ -92,7 +92,7 @@ parties such as https://github.com/h-thurow/Simple-JNDI[Simple-JNDI]. The `org.springframework.mock.web` package contains a comprehensive set of Servlet API mock objects that are useful for testing web contexts, controllers, and filters. These mock objects are targeted at usage with Spring's Web MV...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/web/webflux-view.adoc
@@ -26,7 +26,7 @@ configuration involves a few bean declarations, such as `SpringResourceTemplateResolver`, `SpringWebFluxTemplateEngine`, and `ThymeleafReactiveViewResolver`. For more details, see https://www.thymeleaf.org/documentation.html[Thymeleaf+Spring] and the WebFlux integration -http://forum.thymeleaf.org/...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/web/webflux.adoc
@@ -34,7 +34,7 @@ The other part of the answer is functional programming. Much as the addition of in Java 5 created opportunities (such as annotated REST controllers or unit tests), the addition of lambda expressions in Java 8 created opportunities for functional APIs in Java. This is a boon for non-blocking applica...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/web/webmvc-view.adoc
@@ -479,7 +479,7 @@ In similar fashion, you can specify HTML escaping per field, as the following ex [[mvc-view-groovymarkup]] == Groovy Markup -The http://groovy-lang.org/templating.html#_the_markuptemplateengine[Groovy Markup Template Engine] +The https://groovy-lang.org/templating.html#_the_markuptemplateengine[...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/docs/asciidoc/web/websocket.adoc
@@ -597,7 +597,7 @@ a key reason for having SockJS. This section covers important considerations about running in those browsers. The SockJS client supports Ajax/XHR streaming in IE 8 and 9 by using Microsoft's -https://blogs.msdn.com/b/ieinternals/archive/2010/05/13/xdomainrequest-restrictions-limitations-and-work...
true
Other
spring-projects
spring-framework
ce49068ff92bfdc2e856038b37f5b19adcafff59.json
Fix links in Javadoc and reference docs - Fix broken links (by using a new URL, an alternative URL, or a Wayback Machine link) - Use HTTPS where possible - Remove https://issuetracker.springsource.com/browse/EBR-349: this link is dead and is also mentioned in https://jira.spring.io/browse/SPR-8093 - Clean up ...
src/nohttp/allowlist.lines
@@ -1,26 +1,7 @@ ^http://aopalliance.sourceforge.net.* -^http://[^/]*caucho.com.* -^http://cglib.sourceforge.net.* -^http://classdoc.sourceforge.net.* -^http://easymock.org.* -^http://forum.thymeleaf.org.* -^http://[^/]*gebish.org.* -^http://[^/]*groovy-lang.org.* -^http://[^/]*hsqldb.org.* -^http://htmlunit.sourcefor...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-aop/src/main/java/org/springframework/aop/framework/autoproxy/AbstractAutoProxyCreator.java
@@ -147,7 +147,7 @@ public abstract class AbstractAutoProxyCreator extends ProxyProcessorSupport /** * Set whether the proxy should be frozen, preventing advice * from being added to it once it is created. - * <p>Overridden from the super class to prevent the proxy configuration + * <p>Overridden from the sup...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-aspects/src/main/java/org/springframework/beans/factory/aspectj/AbstractDependencyInjectionAspect.aj
@@ -35,7 +35,7 @@ public abstract aspect AbstractDependencyInjectionAspect { mostSpecificSubTypeConstruction() && !preConstructionConfiguration(); /** - * Select least specific super type that is marked for DI + * Select least specific supertype that is marked for DI * (so that injection occurs only once w...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-context-indexer/src/main/java/org/springframework/context/index/processor/TypeHelper.java
@@ -81,7 +81,7 @@ private String getQualifiedName(Element element) { } /** - * Return the super class of the specified {@link Element} or null if this + * Return the superclass of the specified {@link Element} or null if this * {@code element} represents {@link Object}. */ public Element getSuperClass(E...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-core/src/main/java/org/springframework/asm/Type.java
@@ -708,8 +708,8 @@ public int getSize() { * * @return the size of the arguments of the method (plus one for the implicit this argument), * argumentsSize, and the size of its return value, returnSize, packed into a single int i = - * {@code (argumentsSize &lt;&lt; 2) | returnSize} (argumentsSize i...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-core/src/main/java/org/springframework/core/type/filter/AbstractTypeHierarchyTraversingFilter.java
@@ -86,7 +86,7 @@ public boolean match(MetadataReader metadataReader, MetadataReaderFactory metada } catch (IOException ex) { if (logger.isDebugEnabled()) { - logger.debug("Could not read super class [" + metadata.getSuperClassName() + + logger.debug("Could not read superclass [" + metada...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-core/src/main/java/org/springframework/util/DigestUtils.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2020 the original author or authors. + * Copyright 2002-2022 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-expression/src/main/java/org/springframework/expression/ExpressionException.java
@@ -19,7 +19,7 @@ import org.springframework.lang.Nullable; /** - * Super class for exceptions that can occur whilst processing expressions. + * Superclass for exceptions that can occur whilst processing expressions. * * @author Andy Clement * @author Phillip Webb
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-jdbc/src/main/java/org/springframework/jdbc/core/support/JdbcDaoSupport.java
@@ -29,7 +29,7 @@ import org.springframework.util.Assert; /** - * Convenient super class for JDBC-based data access objects. + * Convenient superclass for JDBC-based data access objects. * * <p>Requires a {@link javax.sql.DataSource} to be set, providing a * {@link org.springframework.jdbc.core.JdbcTemplate} ...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-jms/src/main/java/org/springframework/jms/core/support/JmsGatewaySupport.java
@@ -27,7 +27,7 @@ import org.springframework.lang.Nullable; /** - * Convenient super class for application classes that need JMS access. + * Convenient superclass for application classes that need JMS access. * * <p>Requires a ConnectionFactory or a JmsTemplate instance to be set. * It will create its own Jms...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractBrokerMessageHandler.java
@@ -262,7 +262,7 @@ public final boolean isRunning() { * may still independently alternate between being on and off depending on the * concrete subclass implementation. * <p>Application components may implement - * {@code org.springframework.context.ApplicationListener&lt;BrokerAvailabilityEvent&gt;} + * {@c...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-orm/src/main/java/org/springframework/orm/hibernate5/support/HibernateDaoSupport.java
@@ -26,7 +26,7 @@ import org.springframework.util.Assert; /** - * Convenient super class for Hibernate-based data access objects. + * Convenient superclass for Hibernate-based data access objects. * * <p>Requires a {@link SessionFactory} to be set, providing a * {@link org.springframework.orm.hibernate5.Hiber...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAttributeSourceEditor.java
@@ -29,7 +29,7 @@ * {@link TransactionAttributeEditor} in this package. * * <p>Strings are in property syntax, with the form:<br> - * {@code FQCN.methodName=&lt;transaction attribute string&gt;} + * {@code FQCN.methodName=<transaction attribute string>} * * <p>For example:<br> * {@code com.mycompany.mycode....
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-web/src/main/java/org/springframework/web/client/support/RestGatewaySupport.java
@@ -24,7 +24,7 @@ import org.springframework.web.client.RestTemplate; /** - * Convenient super class for application classes that need REST access. + * Convenient superclass for application classes that need REST access. * * <p>Requires a {@link ClientHttpRequestFactory} or a {@link RestTemplate} instance to be...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-web/src/main/java/org/springframework/web/context/request/AbstractRequestAttributesScope.java
@@ -28,7 +28,7 @@ * this class which {@link RequestAttributes} scope to read attributes from. * * <p>Subclasses may wish to override the {@link #get} and {@link #remove} - * methods to add synchronization around the call back into this super class. + * methods to add synchronization around the call back into this...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-web/src/main/java/org/springframework/web/method/HandlerTypePredicate.java
@@ -128,7 +128,7 @@ public static HandlerTypePredicate forBasePackageClass(Class<?>... packageClasse /** * Match handlers that are assignable to a given type. - * @param types one or more handler super types + * @param types one or more handler supertypes */ public static HandlerTypePredicate forAssignabl...
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-web/src/test/java/org/springframework/web/server/handler/ResponseStatusExceptionHandlerTests.java
@@ -26,6 +26,6 @@ */ public class ResponseStatusExceptionHandlerTests extends AbstractResponseStatusExceptionHandlerTests { - // all tests in super class + // all tests in superclass }
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/AbstractHtmlElementBodyTag.java
@@ -27,7 +27,7 @@ import org.springframework.util.StringUtils; /** - * Convenient super class for many html tags that render content using the databinding + * Convenient superclass for many html tags that render content using the databinding * features of the {@link AbstractHtmlElementTag AbstractHtmlElementTag}....
true
Other
spring-projects
spring-framework
92a231cf916d307aa0ab166f892cdfbf9a0d089f.json
Fix typos in Javadoc, reference docs, and code Closes gh-28822
src/docs/asciidoc/testing.adoc
@@ -1871,7 +1871,7 @@ Spring test configuration annotations are processed within enclosing class hiera for inner test classes. If `@NestedTestConfiguration` is not present or meta-present on a test class, in its -super type hierarchy, or in its enclosing class hierarchy, the default _enclosing +supertype hierarchy,...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-context/src/main/java/org/springframework/cache/Cache.java
@@ -24,7 +24,7 @@ * Interface that defines common cache operations. * * <b>Note:</b> Due to the generic use of caching, it is recommended that - * implementations allow storage of <tt>null</tt> values (for example to + * implementations allow storage of {@code null} values (for example to * cache methods that r...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/core/annotation/AnnotationTypeMappings.java
@@ -160,7 +160,7 @@ int size() { * @param index the index to return * @return the {@link AnnotationTypeMapping} * @throws IndexOutOfBoundsException if the index is out of range - * (<tt>index &lt; 0 || index &gt;= size()</tt>) + * ({@code index < 0 || index >= size()}) */ AnnotationTypeMapping get(int i...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/core/annotation/AttributeMethods.java
@@ -168,7 +168,7 @@ Method get(String name) { * @param index the index of the attribute to return * @return the attribute method * @throws IndexOutOfBoundsException if the index is out of range - * (<tt>index &lt; 0 || index &gt;= size()</tt>) + * ({@code index < 0 || index >= size()}) */ Method get(int...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/core/convert/TypeDescriptor.java
@@ -238,7 +238,7 @@ public Annotation[] getAnnotations() { * <p>As of Spring Framework 4.2, this method supports arbitrary levels * of meta-annotations. * @param annotationType the annotation type - * @return <tt>true</tt> if the annotation is present + * @return {@code true} if the annotation is present ...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/core/convert/converter/ConvertingComparator.java
@@ -104,7 +104,7 @@ public static <K, V> ConvertingComparator<Map.Entry<K, V>, V> mapEntryValues(Com /** - * Adapts a {@link ConversionService} and <tt>targetType</tt> to a {@link Converter}. + * Adapts a {@link ConversionService} and {@code targetType} to a {@link Converter}. */ private static class Conve...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/core/io/buffer/DataBuffer.java
@@ -38,9 +38,9 @@ * the following invariant holds for the read and write positions, and the capacity: * * <blockquote> - * <tt>0</tt> <tt>&lt;=</tt> - * <i>readPosition</i> <tt>&lt;=</tt> - * <i>writePosition</i> <tt>&lt;=</tt> + * {@code 0} {@code <=} + * <i>readPosition</i> {@code <=} + * ...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/util/AntPathMatcher.java
@@ -638,7 +638,7 @@ public Comparator<String> getPatternComparator(String path) { /** * Tests whether a string matches against a pattern via a {@link Pattern}. * <p>The pattern may contain special characters: '*' means zero or more characters; '?' means one and - * only one character; '{' and '}' indicate a UR...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-core/src/main/java/org/springframework/util/FastByteArrayOutputStream.java
@@ -150,7 +150,7 @@ public void close() { /** * Convert the buffer's contents into a string decoding bytes using the - * platform's default character set. The length of the new <tt>String</tt> + * platform's default character set. The length of the new {@code String} * is a function of the character set, an...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-web/src/main/java/org/springframework/web/util/WebUtils.java
@@ -628,17 +628,17 @@ public static String findParameterValue(ServletRequest request, String name) { * following algorithm: * <ol> * <li>Try to get the parameter value using just the given <i>logical</i> name. - * This handles parameters of the form <tt>logicalName = value</tt>. For normal + * This handles p...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-web/src/main/java/org/springframework/web/util/pattern/InternalPathPatternParser.java
@@ -192,8 +192,8 @@ else if ((this.pos > (this.variableCaptureStart + 1 + (this.isCaptureTheRestVari * Just hit a ':' and want to jump over the regex specification for this * variable. pos will be pointing at the ':', we want to skip until the }. * <p> - * Nested {...} pairs don't have to be escaped: <tt>/abc...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-web/src/main/java/org/springframework/web/util/pattern/RegexPathElement.java
@@ -26,7 +26,7 @@ /** * A regex path element. Used to represent any complicated element of the path. - * For example in '<tt>/foo/&ast;_&ast;/&ast;_{foobar}</tt>' both <tt>*_*</tt> and <tt>*_{foobar}</tt> + * For example in '<code>/foo/&#42;_&#42;/&#42;_{foobar}</code>' both {@code *_*} and {@code *_{foobar}} * ...
true
Other
spring-projects
spring-framework
0f479293b17765f7077a61a6b7b130754b6176de.json
Replace use of the <tt> HTML tag in Javadoc The <tt> HTML tag was used in HTML 4 to define teletype text. It is not supported in HTML5, and its use is discouraged. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt Closes gh-28819
spring-webmvc/src/main/java/org/springframework/web/servlet/view/json/MappingJackson2JsonView.java
@@ -97,7 +97,7 @@ public void setJsonPrefix(String jsonPrefix) { } /** - * Indicates whether the JSON output by this view should be prefixed with <tt>")]}', "</tt>. + * Indicates whether the JSON output by this view should be prefixed with <code>")]}', "</code>. * Default is {@code false}. * <p>Prefixing ...
true
Other
spring-projects
spring-framework
110e0f7f2b0a07699a96bf6410299d95635b2f63.json
Add support for Instant in @DateTimeFormat Closes gh-19846
spring-context/src/main/java/org/springframework/format/datetime/standard/Jsr310DateTimeFormatAnnotationFormatterFactory.java
@@ -16,6 +16,7 @@ package org.springframework.format.datetime.standard; +import java.time.Instant; import java.time.LocalDate; import java.time.LocalDateTime; import java.time.LocalTime; @@ -57,6 +58,7 @@ public class Jsr310DateTimeFormatAnnotationFormatterFactory extends EmbeddedValu static { // Create th...
true
Other
spring-projects
spring-framework
110e0f7f2b0a07699a96bf6410299d95635b2f63.json
Add support for Instant in @DateTimeFormat Closes gh-19846
spring-context/src/main/java/org/springframework/format/datetime/standard/TemporalAccessorParser.java
@@ -17,6 +17,7 @@ package org.springframework.format.datetime.standard; import java.text.ParseException; +import java.time.Instant; import java.time.LocalDate; import java.time.LocalDateTime; import java.time.LocalTime; @@ -115,7 +116,10 @@ public TemporalAccessor parse(String text, Locale locale) throws ParseEx...
true
Other
spring-projects
spring-framework
110e0f7f2b0a07699a96bf6410299d95635b2f63.json
Add support for Instant in @DateTimeFormat Closes gh-19846
spring-context/src/test/java/org/springframework/format/datetime/standard/DateTimeFormattingTests.java
@@ -397,6 +397,15 @@ void testBindInstant() { assertThat(binder.getBindingResult().getFieldValue("instant").toString().startsWith("2009-10-31T12:00")).isTrue(); } + @Test + void testBindInstantAnnotated() { + MutablePropertyValues propertyValues = new MutablePropertyValues(); + propertyValues.add("styleInstant...
true
Other
spring-projects
spring-framework
5649a6f8ef335735480616cbeb4dd87efb371adf.json
Update exchangeToMono Javadoc This time showing a more representative example. See gh-27645
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -519,18 +519,15 @@ interface Builder { * scenarios, for example to decode the response differently depending * on the response status: * <p><pre> - * Mono&lt;Object&gt; entityMono = client.get() + * Mono&lt;Person&gt; entityMono = client.get() * .uri("/persons/1") * .accept(MediaType....
true
Other
spring-projects
spring-framework
5649a6f8ef335735480616cbeb4dd87efb371adf.json
Update exchangeToMono Javadoc This time showing a more representative example. See gh-27645
src/docs/asciidoc/web/webflux-webclient.adoc
@@ -546,20 +546,16 @@ depending on the response status: [source,java,indent=0,subs="verbatim,quotes",role="primary"] .Java ---- - Mono<Object> entityMono = client.get() + Mono<Person> entityMono = client.get() .uri("/persons/1") .accept(MediaType.APPLICATION_JSON) .exchangeToMono(response -> { if (r...
true
Other
spring-projects
spring-framework
b77b45434f5c8fd73be39ffe5b1e52ebc641411b.json
Change createException to createError See gh-27645
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -530,7 +530,7 @@ interface Builder { * return response.bodyToMono(ErrorContainer.class); * } * else { - * return response.createException(); + * return response.createError(); * } * }); * </pre>
true
Other
spring-projects
spring-framework
b77b45434f5c8fd73be39ffe5b1e52ebc641411b.json
Change createException to createError See gh-27645
src/docs/asciidoc/web/webflux-webclient.adoc
@@ -559,7 +559,7 @@ depending on the response status: } else { // Turn to error - return response.createException(); + return response.createError(); } }); ----
true
Other
spring-projects
spring-framework
5ec1e20242bd47e87f822375ba34c39ef423b6d1.json
Add Kotlin extensions for Cache and CacheManager See gh-23927
spring-context/src/main/kotlin/org/springframework/cache/CacheExtensions.kt
@@ -0,0 +1,44 @@ +/* + * Copyright 2002-2019 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
5ec1e20242bd47e87f822375ba34c39ef423b6d1.json
Add Kotlin extensions for Cache and CacheManager See gh-23927
spring-context/src/main/kotlin/org/springframework/cache/CacheManagerExtensions.kt
@@ -0,0 +1,9 @@ +package org.springframework.cache + +/** + * Extension for [CacheManager.getCache(name)] providing a `cm[name]` variant. + * + * @author Mikhael Sokolov + * @since 5.2 + */ +operator fun CacheManager.get(name: String): Cache? = getCache(name) \ No newline at end of file
true
Other
spring-projects
spring-framework
5ec1e20242bd47e87f822375ba34c39ef423b6d1.json
Add Kotlin extensions for Cache and CacheManager See gh-23927
spring-context/src/test/kotlin/org/springframework/cache/CacheExtensionsTest.kt
@@ -0,0 +1,31 @@ +package org.springframework.cache + +import org.junit.jupiter.api.Assertions.assertEquals +import org.junit.jupiter.api.Test +import org.springframework.cache.concurrent.ConcurrentMapCacheManager + +class CacheExtensionsTest { + + @Test + fun `Check inline get variant`() { + val cache = createCache()...
true
Other
spring-projects
spring-framework
5ec1e20242bd47e87f822375ba34c39ef423b6d1.json
Add Kotlin extensions for Cache and CacheManager See gh-23927
spring-context/src/test/kotlin/org/springframework/cache/CacheManagerExtensionsTest.kt
@@ -0,0 +1,16 @@ +package org.springframework.cache + +import org.junit.jupiter.api.Assertions.assertNotEquals +import org.junit.jupiter.api.Test +import org.springframework.cache.concurrent.ConcurrentMapCacheManager + +class CacheManagerExtensionsTest { + + @Test + fun `Check operator get variant`() { + val cm = crea...
true
Other
spring-projects
spring-framework
8b89128c7bec7c1e902ba74d2b6c268f3011194a.json
Update createException example for WebClient Closes gh-27645
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -530,7 +530,7 @@ interface Builder { * return response.bodyToMono(ErrorContainer.class); * } * else { - * return Mono.error(response.createException()); + * return response.createException(); * } * }); * </pre> @@ -562,7 +562...
true
Other
spring-projects
spring-framework
8b89128c7bec7c1e902ba74d2b6c268f3011194a.json
Update createException example for WebClient Closes gh-27645
src/docs/asciidoc/web/webflux-webclient.adoc
@@ -559,7 +559,7 @@ depending on the response status: } else { // Turn to error - return response.createException().flatMap(Mono::error); + return response.createException(); } }); ----
true
Other
spring-projects
spring-framework
a0ba8082179f7d80d9f284b4d69020358be9a6f3.json
Use HttpHeaders.ALLOW instead of String constant This commit changes "Allow" strings into HttpHeaders.ALLOW. See gh-27356
spring-web/src/main/java/org/springframework/web/context/support/HttpRequestHandlerServlet.java
@@ -24,6 +24,7 @@ import jakarta.servlet.http.HttpServletResponse; import org.springframework.context.i18n.LocaleContextHolder; +import org.springframework.http.HttpHeaders; import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.StringUtils; @@ -68,7 +69...
true
Other
spring-projects
spring-framework
a0ba8082179f7d80d9f284b4d69020358be9a6f3.json
Use HttpHeaders.ALLOW instead of String constant This commit changes "Allow" strings into HttpHeaders.ALLOW. See gh-27356
spring-webmvc/src/main/java/org/springframework/web/servlet/FrameworkServlet.java
@@ -46,6 +46,7 @@ import org.springframework.core.GenericTypeResolver; import org.springframework.core.annotation.AnnotationAwareOrderComparator; import org.springframework.core.env.ConfigurableEnvironment; +import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springf...
true
Other
spring-projects
spring-framework
a0ba8082179f7d80d9f284b4d69020358be9a6f3.json
Use HttpHeaders.ALLOW instead of String constant This commit changes "Allow" strings into HttpHeaders.ALLOW. See gh-27356
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/AbstractController.java
@@ -20,6 +20,7 @@ import jakarta.servlet.http.HttpServletResponse; import jakarta.servlet.http.HttpSession; +import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.lang.Nullable; import org.springframework.web.servlet.ModelAndView; @@ -155,7 +156,7 @@ ...
true
Other
spring-projects
spring-framework
a0ba8082179f7d80d9f284b4d69020358be9a6f3.json
Use HttpHeaders.ALLOW instead of String constant This commit changes "Allow" strings into HttpHeaders.ALLOW. See gh-27356
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java
@@ -560,7 +560,7 @@ public void handleRequest(HttpServletRequest request, HttpServletResponse respon } if (HttpMethod.OPTIONS.matches(request.getMethod())) { - response.setHeader("Allow", getAllowHeader()); + response.setHeader(HttpHeaders.ALLOW, getAllowHeader()); return; }
true
Other
spring-projects
spring-framework
e986ff8d078395a902a3d77dde96a4e57ea7600e.json
Update copyright year of changed files See gh-27239
spring-core/src/test/java/org/springframework/util/xml/AbstractStaxHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
e986ff8d078395a902a3d77dde96a4e57ea7600e.json
Update copyright year of changed files See gh-27239
spring-core/src/test/java/org/springframework/util/xml/DomContentHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
e986ff8d078395a902a3d77dde96a4e57ea7600e.json
Update copyright year of changed files See gh-27239
spring-oxm/src/test/java/org/springframework/oxm/AbstractUnmarshallerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2020 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-core/src/test/java/org/springframework/util/xml/AbstractStaxHandlerTests.java
@@ -21,6 +21,8 @@ import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLStreamException; import javax.xml.transform.Result; import javax.xml.transform.dom.DOMResult; @@...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-core/src/test/java/org/springframework/util/xml/AbstractStaxXMLReaderTests.java
@@ -19,6 +19,8 @@ import java.io.ByteArrayInputStream; import java.io.InputStream; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLInputFactory; import javax.xml.stream.XMLStreamException; import javax.xml.transform.Transformer; @@ -64,10 +66,12 @@ abst...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-core/src/test/java/org/springframework/util/xml/DomContentHandlerTests.java
@@ -20,6 +20,8 @@ import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -62,13 +64,15 @@ class DomContentHandlerTes...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-oxm/src/main/java/org/springframework/oxm/jaxb/Jaxb2Marshaller.java
@@ -42,6 +42,9 @@ import javax.xml.datatype.Duration; import javax.xml.datatype.XMLGregorianCalendar; import javax.xml.namespace.QName; +import javax.xml.parsers.ParserConfigurationException; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLEventReader; im...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-oxm/src/main/java/org/springframework/oxm/support/AbstractMarshaller.java
@@ -26,6 +26,8 @@ import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLEventReader; import javax.xml.stream.XMLEve...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-oxm/src/test/java/org/springframework/oxm/AbstractUnmarshallerTests.java
@@ -22,6 +22,8 @@ import javax.xml.namespace.QName; import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLEventReader; import javax.xml.stream.XMLInputFactory; import ja...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-web/src/main/java/org/springframework/http/converter/xml/Jaxb2RootElementHttpMessageConverter.java
@@ -18,6 +18,9 @@ import java.io.StringReader; +import javax.xml.parsers.ParserConfigurationException; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.transform.Result; import javax.xml.transform.Source; import javax.xml.transform.sax.SAXSource; @@ -149,21 +152,...
true
Other
spring-projects
spring-framework
baed0785fd02b2bf6b93c72b756c37b603359220.json
Replace XMLReaderFactory with SAXParserFactory XMLReaderFactory has been marked as deprecated and without additional configuration, and it's slower than SAXParserFactory. Previously `XMLReaderFactory.createXMLReader()` is called upon every request. This is an anti-pattern as mentioned in [1] and it can be very slow s...
spring-web/src/main/java/org/springframework/http/converter/xml/SourceHttpMessageConverter.java
@@ -27,6 +27,8 @@ import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; import javax.xml.stream.XMLInputFactory; import javax.xml.stream.XMLRe...
true
Other
spring-projects
spring-framework
32359c52b4b2dd76f37f5c489d39f1a52cfa7448.json
Remove transitive dependency on Java EE 8 JAX-B Closes gh-27754
spring-webmvc/spring-webmvc.gradle
@@ -45,7 +45,9 @@ dependencies { testImplementation("org.apache.httpcomponents:httpclient") testImplementation("commons-io:commons-io") testImplementation("org.mozilla:rhino") - testImplementation("org.dom4j:dom4j") + testImplementation("org.dom4j:dom4j") { + exclude group: 'javax.xml.bind', module: "jaxb-api" +...
false
Other
spring-projects
spring-framework
a0d54105e99111755489339e34b3cce3e525b8e9.json
Use new features in JUnit Jupiter 5.8.2 See gh-27744
spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/ScriptUtilsUnitTests.java
@@ -200,37 +200,43 @@ public void readAndSplitScriptContainingMultiLineNestedComments() throws Excepti } @ParameterizedTest - @CsvSource(delimiter = '#', value = { - // semicolon - "'select 1\n select '';''' # ; # false", - "'select 1\n select \";\"...
false
Other
spring-projects
spring-framework
445c0def0ce741e70d716da74862e03a4524ab3f.json
Update docs on heartbeats with simple broker Closes gh-27746
src/docs/asciidoc/web/websocket.adoc
@@ -1439,8 +1439,11 @@ See <<websocket-stomp-destination-separator>>. If configured with a task scheduler, the simple broker supports https://stomp.github.io/stomp-specification-1.2.html#Heart-beating[STOMP heartbeats]. -For that, you can declare your own scheduler or use the one that is automatically -declared and...
false
Other
spring-projects
spring-framework
e209a460ca35b90daba6a923f1bdabc4bfdbaaa8.json
Fix reference to CountingBeforeAdvice See gh-22246
spring-aop/src/test/resources/org/springframework/aop/config/AopNamespaceHandlerEventTests-context.xml
@@ -16,9 +16,9 @@ </aop:aspect> </aop:config> - <bean id="getNameCounter" class="org.springframework.aop.framework.CountingBeforeAdvice"/> + <bean id="getNameCounter" class="org.springframework.tests.aop.advice.CountingBeforeAdvice"/> - <bean id="getAgeCounter" class="org.springframework.aop.framework.Counting...
true
Other
spring-projects
spring-framework
e209a460ca35b90daba6a923f1bdabc4bfdbaaa8.json
Fix reference to CountingBeforeAdvice See gh-22246
spring-aop/src/test/resources/org/springframework/aop/config/AopNamespaceHandlerEventTests-directPointcutEvents.xml
@@ -9,6 +9,6 @@ <aop:advisor advice-ref="countingAdvice" pointcut="within(org.springframework..*)"/> </aop:config> - <bean id="countingAdvice" class="org.springframework.aop.framework.CountingBeforeAdvice"/> + <bean id="countingAdvice" class="org.springframework.tests.aop.advice.CountingBeforeAdvice"/> </bean...
true
Other
spring-projects
spring-framework
e209a460ca35b90daba6a923f1bdabc4bfdbaaa8.json
Fix reference to CountingBeforeAdvice See gh-22246
spring-aop/src/test/resources/org/springframework/aop/config/AopNamespaceHandlerEventTests-pointcutRefEvents.xml
@@ -10,6 +10,6 @@ <aop:advisor advice-ref="countingAdvice" pointcut-ref="pc"/> </aop:config> - <bean id="countingAdvice" class="org.springframework.aop.framework.CountingBeforeAdvice"/> + <bean id="countingAdvice" class="org.springframework.tests.aop.advice.CountingBeforeAdvice"/> </beans>
true
Other
spring-projects
spring-framework
e209a460ca35b90daba6a923f1bdabc4bfdbaaa8.json
Fix reference to CountingBeforeAdvice See gh-22246
spring-aop/src/test/resources/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests-pointcutDuplication.xml
@@ -12,7 +12,7 @@ </aop:aspect> </aop:config> - <bean id="getAgeCounter" class="org.springframework.aop.framework.CountingBeforeAdvice"/> + <bean id="getAgeCounter" class="org.springframework.tests.aop.advice.CountingBeforeAdvice"/> <bean id="testBean" class="org.springframework.beans.testfixture.beans.TestB...
true
Other
spring-projects
spring-framework
e209a460ca35b90daba6a923f1bdabc4bfdbaaa8.json
Fix reference to CountingBeforeAdvice See gh-22246
spring-aop/src/test/resources/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests-pointcutMissing.xml
@@ -12,7 +12,7 @@ </aop:aspect> </aop:config> - <bean id="getAgeCounter" class="org.springframework.aop.framework.CountingBeforeAdvice"/> + <bean id="getAgeCounter" class="org.springframework.tests.aop.advice.CountingBeforeAdvice"/> <bean id="testBean" class="org.springframework.beans.testfixture.beans.TestB...
true
Other
spring-projects
spring-framework
2f32806bcb6cefa6479074d5fb66cb68043cedc9.json
Update aspectj-plugin to 6.3.0 Version 6.3.0 aligns with the used Gradle 7.3 Closes gh-27678
build.gradle
@@ -1,7 +1,7 @@ plugins { id 'io.spring.dependency-management' version '1.0.11.RELEASE' apply false id 'io.spring.nohttp' version '0.0.10' - id "io.freefair.aspectj" version '6.2.0' apply false + id "io.freefair.aspectj" version '6.3.0' apply false id 'org.jetbrains.dokka' version '1.5.0' apply false id 'org.j...
true
Other
spring-projects
spring-framework
2f32806bcb6cefa6479074d5fb66cb68043cedc9.json
Update aspectj-plugin to 6.3.0 Version 6.3.0 aligns with the used Gradle 7.3 Closes gh-27678
spring-aspects/spring-aspects.gradle
@@ -8,8 +8,6 @@ sourceSets.main.java.srcDirs = files() sourceSets.test.aspectj.srcDir "src/test/java" sourceSets.test.java.srcDirs = files() -aspectj.version = dependencyManagement.managedVersions['org.aspectj:aspectjweaver'] - compileAspectj { sourceCompatibility "17" targetCompatibility "17"
true
Other
spring-projects
spring-framework
d178eafc11f6576188df8bbb569d82e9d5569bc2.json
Fix SpEL comparison operator for comparable types Prior to this commit, the SpEL relational operators for comparison would have the following problem: * their implementation would claim that incompatible types could be compared and later fail during comparison * not delegate the comparison to the actual `TypeCompar...
spring-expression/src/main/java/org/springframework/expression/spel/ast/Operator.java
@@ -309,11 +309,8 @@ else if (leftNumber instanceof Byte || rightNumber instanceof Byte) { return true; } - if (left instanceof Comparable && right instanceof Comparable) { - Class<?> ancestor = ClassUtils.determineCommonAncestor(left.getClass(), right.getClass()); - if (ancestor != null && Comparable.cla...
true
Other
spring-projects
spring-framework
d178eafc11f6576188df8bbb569d82e9d5569bc2.json
Fix SpEL comparison operator for comparable types Prior to this commit, the SpEL relational operators for comparison would have the following problem: * their implementation would claim that incompatible types could be compared and later fail during comparison * not delegate the comparison to the actual `TypeCompar...
spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java
@@ -23,6 +23,7 @@ import org.springframework.expression.spel.SpelEvaluationException; import org.springframework.expression.spel.SpelMessage; import org.springframework.lang.Nullable; +import org.springframework.util.ClassUtils; import org.springframework.util.NumberUtils; /** @@ -44,8 +45,9 @@ public boolean ca...
true
Other
spring-projects
spring-framework
d178eafc11f6576188df8bbb569d82e9d5569bc2.json
Fix SpEL comparison operator for comparable types Prior to this commit, the SpEL relational operators for comparison would have the following problem: * their implementation would claim that incompatible types could be compared and later fail during comparison * not delegate the comparison to the actual `TypeCompar...
spring-expression/src/test/java/org/springframework/expression/spel/AlternativeComparatorTests.java
@@ -0,0 +1,62 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d178eafc11f6576188df8bbb569d82e9d5569bc2.json
Fix SpEL comparison operator for comparable types Prior to this commit, the SpEL relational operators for comparison would have the following problem: * their implementation would claim that incompatible types could be compared and later fail during comparison * not delegate the comparison to the actual `TypeCompar...
spring-expression/src/test/java/org/springframework/expression/spel/DefaultComparatorUnitTests.java
@@ -116,7 +116,7 @@ void testCanCompare() throws EvaluationException { assertThat(comparator.canCompare(2,1)).isTrue(); assertThat(comparator.canCompare("abc","def")).isTrue(); - assertThat(comparator.canCompare("abc",3)).isTrue(); + assertThat(comparator.canCompare("abc",3)).isFalse(); assertThat(comparat...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-beans/src/main/java/org/springframework/beans/factory/support/PropertiesBeanDefinitionReader.java
@@ -457,11 +457,11 @@ else if (LAZY_INIT_KEY.equals(property)) { } else if (property.startsWith(CONSTRUCTOR_ARG_PREFIX)) { if (property.endsWith(REF_SUFFIX)) { - int index = Integer.parseInt(property.substring(1, property.length() - REF_SUFFIX.length())); + int index = Integer.parseInt(propert...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-context/src/main/java/org/springframework/scheduling/config/TaskExecutorFactoryBean.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2020 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -106,8 +106,8 @@ private void determinePoolS...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-context/src/main/java/org/springframework/scheduling/support/BitsCronField.java
@@ -161,8 +161,8 @@ private static ValueRange parseRange(String value, Type type) { return ValueRange.of(result, result); } else { - int min = Integer.parseInt(value.substring(0, hyphenPos)); - int max = Integer.parseInt(value.substring(hyphenPos + 1)); + int min = Integer.parseInt(value, 0, hyphe...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-context/src/main/java/org/springframework/scheduling/support/QuartzCronField.java
@@ -86,7 +86,7 @@ else if (value.length() == 2 && value.charAt(1) == 'W') { // "LW" adjuster = lastDayOfMonth(); } else { // "L-[0-9]+" - int offset = Integer.parseInt(value.substring(idx + 1)); + int offset = Integer.parseInt(value, idx + 1, value.length(), 10); if (offset >= 0) { ...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-context/src/test/java/org/springframework/format/support/FormattingConversionServiceFactoryBeanTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -204,7 +204,7 @@ public Parser<?> getParser(...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java
@@ -309,8 +309,8 @@ public void setConcurrency(String concurrency) { try { int separatorIndex = concurrency.indexOf('-'); if (separatorIndex != -1) { - setConcurrentConsumers(Integer.parseInt(concurrency.substring(0, separatorIndex))); - setMaxConcurrentConsumers(Integer.parseInt(concurrency.substring(...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-jms/src/main/java/org/springframework/jms/listener/SimpleMessageListenerContainer.java
@@ -126,7 +126,7 @@ public void setConcurrency(String concurrency) { try { int separatorIndex = concurrency.indexOf('-'); if (separatorIndex != -1) { - setConcurrentConsumers(Integer.parseInt(concurrency.substring(separatorIndex + 1))); + setConcurrentConsumers(Integer.parseInt(concurrency, separatorIn...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-jms/src/main/java/org/springframework/jms/listener/endpoint/JmsActivationSpecConfig.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2020 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -226,7 +226,7 @@ public void setConcurrency(...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-test/src/main/java/org/springframework/mock/web/MockHttpServletRequest.java
@@ -707,7 +707,7 @@ public int getServerPort() { idx = host.indexOf(':'); } if (idx != -1) { - return Integer.parseInt(host.substring(idx + 1)); + return Integer.parseInt(host, idx + 1, host.length(), 10); } }
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java
@@ -94,7 +94,7 @@ private static URI resolveBaseUrl(HttpServerRequest request) throws URISyntaxExc if (portIndex != -1) { try { return new URI(scheme, null, header.substring(0, portIndex), - Integer.parseInt(header.substring(portIndex + 1)), null, null, null); + Integer.parseInt(header, portI...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -364,7 +364,7 @@ public static InetSocketAddress parseForwardedFor( } host = value.substring(0, portSeparatorIdx); try { - port = Integer.parseInt(value.substring(portSeparatorIdx + 1)); + port = Integer.parseInt(value, portSeparatorIdx + 1, value.length(), 10); } catch (Numbe...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-web/src/test/java/org/springframework/web/util/HtmlCharacterEntityReferencesTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2020 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -174,7 +174,7 @@ private boolean navigateToN...
true
Other
spring-projects
spring-framework
804b343cabe8a16a02a714f2f51d4b3815f9f6ff.json
Use parseInt without substring method
spring-web/src/testFixtures/java/org/springframework/web/testfixture/servlet/MockHttpServletRequest.java
@@ -710,7 +710,7 @@ public int getServerPort() { idx = host.indexOf(':'); } if (idx != -1) { - return Integer.parseInt(host.substring(idx + 1)); + return Integer.parseInt(host, idx + 1, host.length(), 10); } }
true
Other
spring-projects
spring-framework
4368e2563f9f83ccb6952d4cdf8c1586231bbc60.json
Reinstate RuntimeHintsAgent tests Closes gh-29062
spring-beans/src/main/java/org/springframework/beans/factory/annotation/JakartaAnnotationsRuntimeHints.java
@@ -0,0 +1,41 @@ +/* + * Copyright 2002-2022 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4368e2563f9f83ccb6952d4cdf8c1586231bbc60.json
Reinstate RuntimeHintsAgent tests Closes gh-29062
spring-beans/src/main/resources/META-INF/spring/aot.factories
@@ -1,5 +1,6 @@ org.springframework.aot.hint.RuntimeHintsRegistrar=\ -org.springframework.beans.factory.annotation.BeanFactoryAnnotationsRuntimeHints +org.springframework.beans.factory.annotation.BeanFactoryAnnotationsRuntimeHints,\ +org.springframework.beans.factory.annotation.JakartaAnnotationsRuntimeHints org.sp...
true
Other
spring-projects
spring-framework
4368e2563f9f83ccb6952d4cdf8c1586231bbc60.json
Reinstate RuntimeHintsAgent tests Closes gh-29062
spring-beans/src/test/java/org/springframework/beans/factory/annotation/JakartaAnnotationsRuntimeHintsTests.java
@@ -0,0 +1,59 @@ +/* + * Copyright 2002-2022 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 +...
true