language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java | @@ -42,6 +42,7 @@
import org.springframework.http.codec.json.Jackson2CodecSupport;
import org.springframework.http.codec.multipart.Part;
import org.springframework.http.server.PathContainer;
+import org.springframework.http.server.RequestPath;
import org.springframework.http.server.reactive.ServerHttpRequest;
impo... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -38,6 +38,7 @@
import org.springframework.http.codec.HttpMessageReader;
import org.springframework.http.codec.multipart.Part;
import org.springframework.http.server.PathContainer;
+import org.springframework.http.server.RequestPath;
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.s... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/RequestPredicatesTests.java | @@ -29,7 +29,6 @@
import org.springframework.web.testfixture.server.MockServerWebExchange;
import org.springframework.web.util.pattern.PathPatternParser;
-import static java.util.Collections.emptyList;
import static org.assertj.core.api.Assertions.assertThat;
/**
@@ -141,7 +140,7 @@ public void path() {
URI ... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerRequest.java | @@ -51,7 +51,6 @@
import org.springframework.http.MediaType;
import org.springframework.http.converter.GenericHttpMessageConverter;
import org.springframework.http.converter.HttpMessageConverter;
-import org.springframework.http.server.PathContainer;
import org.springframework.http.server.RequestPath;
import org.s... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/PathResourceLookupFunction.java | @@ -55,7 +55,7 @@ public PathResourceLookupFunction(String pattern, Resource location) {
@Override
public Optional<Resource> apply(ServerRequest request) {
- PathContainer pathContainer = request.pathContainer();
+ PathContainer pathContainer = request.requestPath().pathWithinApplication();
if (!this.pattern... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/RequestPredicates.java | @@ -21,7 +21,6 @@
import java.net.URI;
import java.security.Principal;
import java.time.Instant;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.EnumSet;
@@ -51,6 +50,7 @@
import org.springframework.http.MediaType;
import org.springframework.http.converter.Ht... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/ServerRequest.java | @@ -43,10 +43,12 @@
import org.springframework.http.MediaType;
import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.http.server.PathContainer;
+import org.springframework.http.server.RequestPath;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;... | true |
Other | spring-projects | spring-framework | d550d344d55e0b410f517069bb7d6e4cd816617e.json | Respect context path in WebMvc.fn & WebFlux.fn
This commit makes several changes in both WebMvc.fn as well as
WebFlux.fn.
- ServerRequest now exposes a RequestPath through requestPath(), and
pathContainer() has been deprecated.
- The PathPredicate and PathResourceLookupFunction now respects this
RequestPath'... | spring-webmvc/src/test/java/org/springframework/web/servlet/function/RequestPredicatesTests.java | @@ -148,6 +148,13 @@ void pathPredicates() {
assertThat(predicate.test(initRequest("GET", "/path"))).isTrue();
}
+ @Test
+ public void pathWithContext() {
+ RequestPredicate predicate = RequestPredicates.path("/p*");
+ ServerRequest request = initRequest("GET", "/context/path",
+ servletRequest -> servletRe... | true |
Other | spring-projects | spring-framework | 3a73533b1cae29fdffe56bece1d8b11ff3ad409f.json | Upgrade Gradle plugins to latest patch releases | build.gradle | @@ -1,14 +1,14 @@
plugins {
- id 'io.spring.dependency-management' version '1.0.8.RELEASE' apply false
+ id 'io.spring.dependency-management' version '1.0.9.RELEASE' apply false
+ id 'io.spring.gradle-enterprise-conventions' version '0.0.2'
+ id 'io.spring.nohttp' version '0.0.5.RELEASE'
id 'org.jetbrains.kotlin.jvm... | false |
Other | spring-projects | spring-framework | 7bc803598967ab9d5bf1eb378bd7b7c4bf212f15.json | Replace http with https in docs sample | src/docs/asciidoc/web/webflux-webclient.adoc | @@ -326,7 +326,7 @@ To configure a response timeout for a specific request:
.Java
----
WebClient.create().get()
- .uri("http://example.org/path")
+ .uri("https://example.org/path")
.httpRequest(httpRequest -> {
HttpClientRequest reactorRequest = httpRequest.getNativeRequest();
reactorRequest.respo... | false |
Other | spring-projects | spring-framework | 42aeb6cd939759f9f188048dc21da9c5980ea063.json | Update docs on timeouts with WebClient
Closes gh-25115 | src/docs/asciidoc/web/webflux-webclient.adoc | @@ -251,19 +251,26 @@ To configure a connection timeout:
import io.netty.channel.ChannelOption;
HttpClient httpClient = HttpClient.create()
- .tcpConfiguration(client ->
- client.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 10000));
+ .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 10000);
+
+ WebClient web... | false |
Other | spring-projects | spring-framework | 4ac9b7bff2a0f89a0c0b575c31d6261b7526a399.json | Fix typo in BasicJsonWriter.java
See gh-28890 | spring-core/src/main/java/org/springframework/aot/nativex/BasicJsonWriter.java | @@ -245,7 +245,7 @@ public IndentingWriter println() {
/**
* Increase the indentation level and execute the {@link Runnable}. Decrease the
* indentation level on completion.
- * @param runnable the code to execute withing an extra indentation level
+ * @param runnable the code to execute within an extra ... | false |
Other | spring-projects | spring-framework | 3a61930bd08ff85175b356ebf6e7cbed53588a98.json | Improve documentation of Cacheable
See gh-28183 | spring-context/src/main/java/org/springframework/cache/annotation/Cacheable.java | @@ -123,7 +123,8 @@
/**
* Spring Expression Language (SpEL) expression used for making the method
- * caching conditional.
+ * caching conditional. If condition is evaluated to {@code true}, result
+ * is cached.
* <p>Default is {@code ""}, meaning the method result is always cached.
* <p>The SpEL expre... | false |
Other | spring-projects | spring-framework | 608be54a58d4f4b94a23d37033877dfd0ce7b295.json | Improve test coverage of RdbmsOperation
See gh-28472 | spring-jdbc/src/test/java/org/springframework/jdbc/object/RdbmsOperationTests.java | @@ -31,6 +31,7 @@
import org.springframework.jdbc.core.SqlParameter;
import org.springframework.jdbc.datasource.DriverManagerDataSource;
+import static java.util.Map.entry;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@@ -50,6... | false |
Other | spring-projects | spring-framework | b6144e5682c966759e7fd16dbac4d4948d332161.json | Improve setting of WebSocket error status
See gh-28836 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/AbstractListenerWebSocketSession.java | @@ -33,6 +33,7 @@
import org.springframework.http.server.reactive.AbstractListenerWriteProcessor;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
+import org.springframework.util.StringUtils;
import org.springframework.web.reactive.socket.CloseStatus;
import org.springframework.we... | false |
Other | spring-projects | spring-framework | 3d4a778b7321b7145e73a3ad9a513db4bad3944e.json | Fix KDoc API link | src/docs/asciidoc/languages/kotlin.adoc | @@ -44,7 +44,7 @@ Kotlin https://kotlinlang.org/docs/reference/extensions.html[extensions] provide
to extend existing classes with additional functionality. The Spring Framework Kotlin APIs
use these extensions to add new Kotlin-specific conveniences to existing Spring APIs.
-The {docs-spring-framework}/kdoc-api/sp... | false |
Other | spring-projects | spring-framework | aef4b0ec5a63874710b362c05e99d1c63b098e59.json | Upgrade copyright year of changed file
See gh-28885 | spring-core/src/main/java/org/springframework/core/codec/AbstractEncoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 675e0b94c13e4a188a8b8a793f98593c5c897765.json | Fix typo in Javadoc of AbstractEncoder
See gh-28885 | spring-core/src/main/java/org/springframework/core/codec/AbstractEncoder.java | @@ -27,7 +27,7 @@
import org.springframework.util.MimeType;
/**
- * Abstract base class for {@link Decoder} implementations.
+ * Abstract base class for {@link Encoder} implementations.
*
* @author Sebastien Deleuze
* @author Arjen Poutsma | false |
Other | spring-projects | spring-framework | a4f3d1d6e820d247a4781e83cd972f28363c980a.json | Track the sources used to load AOT services
Update `AotServices` so that it tracks which source was used to
provide a given instance.
See gh-28866 | spring-beans/src/main/java/org/springframework/beans/factory/aot/AotServices.java | @@ -17,19 +17,23 @@
package org.springframework.beans.factory.aot;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.Collections;
+import java.util.IdentityHashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.stream.Stream;
+import org.spr... | true |
Other | spring-projects | spring-framework | a4f3d1d6e820d247a4781e83cd972f28363c980a.json | Track the sources used to load AOT services
Update `AotServices` so that it tracks which source was used to
provide a given instance.
See gh-28866 | spring-beans/src/test/java/org/springframework/beans/factory/aot/AotServicesTests.java | @@ -22,6 +22,7 @@
import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.aot.AotServices.Source;
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.beans.factory.support.RootBeanDefinition;
import org.springframework.core.Ordered;
@@ -30... | true |
Other | spring-projects | spring-framework | 97ea8a67892a20b0deedd54e6489895c7f1fea24.json | Copy HttpHeaders to ensure serializability
Not all HttpHeaders implementations are serializable. This commit
ensures that WebClientRequestException and WebClientResponseException
are serializable, by copying any non-serializable HttpHeaders into a
new, serializable, instance.
Closes gh-28321 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClientRequestException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -47,9 +47,20 @@ public WebClientRequestExcep... | true |
Other | spring-projects | spring-framework | 97ea8a67892a20b0deedd54e6489895c7f1fea24.json | Copy HttpHeaders to ensure serializability
Not all HttpHeaders implementations are serializable. This commit
ensures that WebClientRequestException and WebClientResponseException
are serializable, by copying any non-serializable HttpHeaders into a
new, serializable, instance.
Closes gh-28321 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClientResponseException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -96,12 +96,27 @@ public WebClientResponseExc... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/main/java/org/springframework/beans/factory/annotation/InitDestroyAnnotationBeanPostProcessor.java | @@ -159,6 +159,7 @@ public void postProcessMergedBeanDefinition(RootBeanDefinition beanDefinition, C
@Override
public BeanRegistrationAotContribution processAheadOfTime(RegisteredBean registeredBean) {
RootBeanDefinition beanDefinition = registeredBean.getMergedBeanDefinition();
+ beanDefinition.resolveDestroyM... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/main/java/org/springframework/beans/factory/aot/BeanDefinitionPropertiesCodeGenerator.java | @@ -24,7 +24,6 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
-import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.function.BiFunction;
@@ -140,23 +139,16 @@ CodeBlock generateCode(BeanDefinition beanDefinition) {
private void addInitDes... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/main/java/org/springframework/beans/factory/support/DisposableBeanAdapter.java | @@ -105,7 +105,7 @@ public DisposableBeanAdapter(Object bean, String beanName, RootBeanDefinition be
this.invokeDisposableBean = (bean instanceof DisposableBean &&
!beanDefinition.hasAnyExternallyManagedDestroyMethod(DESTROY_METHOD_NAME));
- String[] destroyMethodNames = inferDestroyMethodsIfNecessary(bean, ... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/main/java/org/springframework/beans/factory/support/RootBeanDefinition.java | @@ -550,6 +550,15 @@ public Set<String> getExternallyManagedInitMethods() {
}
}
+ /**
+ * Resolve the inferred destroy method if necessary.
+ * @since 6.0
+ */
+ public void resolveDestroyMethodIfNecessary() {
+ setDestroyMethodNames(DisposableBeanAdapter
+ .inferDestroyMethodsIfNecessary(getResolvableTyp... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/test/java/org/springframework/beans/factory/annotation/InitDestroyAnnotationBeanPostProcessorTests.java | @@ -18,10 +18,12 @@
import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.support.AbstractBeanDefinition;
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.beans.factory.support.RegisteredBean;
import org.springframework.beans.factory.... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/test/java/org/springframework/beans/factory/aot/BeanDefinitionPropertiesCodeGeneratorTests.java | @@ -36,7 +36,6 @@
import org.springframework.beans.factory.config.ConstructorArgumentValues.ValueHolder;
import org.springframework.beans.factory.config.RuntimeBeanNameReference;
import org.springframework.beans.factory.config.RuntimeBeanReference;
-import org.springframework.beans.factory.support.AbstractBeanDefini... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/test/java/org/springframework/beans/factory/support/RootBeanDefinitionTests.java | @@ -57,4 +57,39 @@ void setInstanceDoesNotOverrideResolvedFactoryMethodWithNull() {
verify(instanceSupplier).getFactoryMethod();
}
+ @Test
+ void resolveDestroyMethodWithMatchingCandidateReplacedInferredVaue() {
+ RootBeanDefinition beanDefinition = new RootBeanDefinition(BeanWithCloseMethod.class);
+ beanDefi... | true |
Other | spring-projects | spring-framework | 735051bf7d28a802598ec592ebcecaea2aeaf3dd.json | Resolve infer destroy method at build-time
This commit allows a RootBeanDefinition to resolve its infer destroy
method if necessary. Contrary to BeanInstanceAdapter that uses the
actual bean instance, the new method works against the type exposed
in the bean definition.
The AOT contribution of InitDestroyAnnotationBe... | spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/beans/factory/generator/lifecycle/InferredDestroyBean.java | @@ -0,0 +1,26 @@
+/*
+ * Copyright 2002-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 1dcaa0422462aa07003419e26a500a23bb1b6da6.json | Fix typo in reference manual | src/docs/asciidoc/languages/dynamic-languages.adoc | @@ -480,9 +480,9 @@ Finally, the following small application exercises the preceding configuration:
public class Main {
- public static void Main(String[] args) {
+ public static void main(String[] args) {
ApplicationContext ctx = new ClassPathXmlApplicationContext("beans.xml");
- Calculator calc = (Calcu... | false |
Other | spring-projects | spring-framework | 6a7e58ac82e4e2c5e31031587da45428c1b46e89.json | Add @FunctionalInterface to MessagePostProcessor
Add the @FunctionalInterface annotation to the MessagePostProcessor
interfaces in the spring-jms and spring-messaging projects.
Closes gh-25571 | spring-jms/src/main/java/org/springframework/jms/core/MessagePostProcessor.java | @@ -32,6 +32,7 @@
* @see JmsTemplate#convertAndSend(javax.jms.Destination, Object, MessagePostProcessor)
* @see org.springframework.jms.support.converter.MessageConverter
*/
+@FunctionalInterface
public interface MessagePostProcessor {
/** | true |
Other | spring-projects | spring-framework | 6a7e58ac82e4e2c5e31031587da45428c1b46e89.json | Add @FunctionalInterface to MessagePostProcessor
Add the @FunctionalInterface annotation to the MessagePostProcessor
interfaces in the spring-jms and spring-messaging projects.
Closes gh-25571 | spring-messaging/src/main/java/org/springframework/messaging/core/MessagePostProcessor.java | @@ -28,6 +28,7 @@
* @see MessageSendingOperations
* @see MessageRequestReplyOperations
*/
+@FunctionalInterface
public interface MessagePostProcessor {
/** | true |
Other | spring-projects | spring-framework | 3c832f0ec89ec0fa38d51ac7fa41697357d1302c.json | Upgrade ActiveMQ and extend timeout in STOMP tests | build.gradle | @@ -95,7 +95,7 @@ configure(allprojects) { project ->
dependency "commons-io:commons-io:2.5"
dependency "io.vavr:vavr:0.10.3"
dependency "net.sf.jopt-simple:jopt-simple:5.0.4"
- dependencySet(group: 'org.apache.activemq', version: '5.8.0') {
+ dependencySet(group: 'org.apache.activemq', version: '5.16.0... | true |
Other | spring-projects | spring-framework | 3c832f0ec89ec0fa38d51ac7fa41697357d1302c.json | Upgrade ActiveMQ and extend timeout in STOMP tests | spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/ReactorNettyTcpStompClientTests.java | @@ -106,8 +106,8 @@ public void publishSubscribe() throws Exception {
ConsumingHandler consumingHandler2 = new ConsumingHandler(destination);
ListenableFuture<StompSession> consumerFuture2 = this.client.connect(consumingHandler2);
- assertThat(consumingHandler1.awaitForSubscriptions(5000)).isTrue();
- assertT... | true |
Other | spring-projects | spring-framework | 3c832f0ec89ec0fa38d51ac7fa41697357d1302c.json | Upgrade ActiveMQ and extend timeout in STOMP tests | spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandlerIntegrationTests.java | @@ -254,7 +254,7 @@ public void publishEvent(Object event) {
}
public void expectBrokerAvailabilityEvent(boolean isBrokerAvailable) throws InterruptedException {
- BrokerAvailabilityEvent event = this.eventQueue.poll(20000, TimeUnit.MILLISECONDS);
+ BrokerAvailabilityEvent event = this.eventQueue.poll(40000... | true |
Other | spring-projects | spring-framework | 96a4e1150e608a66998988f5d4903297ef11e977.json | Avoid unnecessary computation of cleaned URL
Closes gh-25531 | spring-core/src/main/java/org/springframework/core/io/UrlResource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -56,7 +56,8 @@ public class UrlResource exte... | false |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/ClientRSocketFactoryConfigurer.java | @@ -1,38 +0,0 @@
-/*
- * Copyright 2002-2020 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/DefaultRSocketRequesterBuilder.java | @@ -89,9 +89,6 @@ final class DefaultRSocketRequesterBuilder implements RSocketRequester.Builder {
private List<RSocketConnectorConfigurer> rsocketConnectorConfigurers = new ArrayList<>();
- @SuppressWarnings("deprecation")
- private List<ClientRSocketFactoryConfigurer> rsocketFactoryConfigurers = new ArrayList<>... | true |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/MetadataEncoder.java | @@ -184,12 +184,12 @@ private DataBuffer encodeEntries(List<MetadataEntry> entries) {
CompositeByteBuf composite = this.allocator.compositeBuffer();
try {
if (this.route != null) {
- io.rsocket.metadata.CompositeMetadataFlyweight.encodeAndAddMetadata(composite, this.allocator,
+ io.rsocket.metadata... | true |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/RSocketRequester.java | @@ -215,29 +215,6 @@ interface Builder {
*/
RSocketRequester.Builder rsocketConnector(RSocketConnectorConfigurer configurer);
- /**
- * Callback to configure the {@code ClientRSocketFactory} directly.
- * <ul>
- * <li>The data and metadata mime types cannot be set directly
- * on the {@code ClientRSoc... | true |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketMessageHandler.java | @@ -330,8 +330,8 @@ protected CompositeMessageCondition extendMapping(CompositeMessageCondition comp
List<MessageCondition<?>> conditions = composite.getMessageConditions();
Assert.isTrue(conditions.size() == 2 &&
- conditions.get(0) instanceof RSocketFrameTypeMessageCondition &&
- conditions.get(1) insta... | true |
Other | spring-projects | spring-framework | 5bdbbdfcfb1e0200664e8a2ddcec644928a6d26d.json | Require RSocket 1.0+
This commit removes the previously deprecated classes in Spring
Framework 5.2.x. By doing so, Spring Framework now requires RSocket
1.0+.
Closes gh-25548 | spring-messaging/src/test/java/org/springframework/messaging/rsocket/DefaultRSocketRequesterBuilderTests.java | @@ -79,20 +79,17 @@ public void setup() {
@Test
- @SuppressWarnings({"unchecked", "deprecation"})
+ @SuppressWarnings("unchecked")
public void rsocketConnectorConfigurer() {
- ClientRSocketFactoryConfigurer factoryConfigurer = mock(ClientRSocketFactoryConfigurer.class);
Consumer<RSocketStrategies.Builder> s... | true |
Other | spring-projects | spring-framework | 0501999e439c27cf148ce30b296d561f06c181ee.json | Fix comment syntax in xml examples
See gh-25537 | src/docs/asciidoc/core/core-appendix.adoc | @@ -242,7 +242,7 @@ The following example shows a path being used against another bean, by name:
[source,xml,indent=0,subs="verbatim,quotes"]
----
- // target bean to be referenced by name
+ <!-- target bean to be referenced by name -->
<bean id="person" class="org.springframework.beans.TestBean" scope="prototype... | true |
Other | spring-projects | spring-framework | 0501999e439c27cf148ce30b296d561f06c181ee.json | Fix comment syntax in xml examples
See gh-25537 | src/docs/asciidoc/languages/dynamic-languages.adoc | @@ -462,7 +462,7 @@ The following bean definition uses the calculator defined in Groovy:
[source,xml,indent=0]
[subs="verbatim,quotes"]
----
- <-- from the file 'beans.xml' -->
+ <!-- from the file 'beans.xml' -->
<beans>
<lang:groovy id="calculator" script-source="classpath:calculator.groovy"/>
</beans> | true |
Other | spring-projects | spring-framework | 38690bdc7cebbbca1563f536a46754a73532e493.json | Upgrade CI image to jdk8u265-b01 | ci/images/get-jdk-url.sh | @@ -3,7 +3,7 @@ set -e
case "$1" in
java8)
- echo "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u262-b10/OpenJDK8U-jdk_x64_linux_hotspot_8u262b10.tar.gz"
+ echo "https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01/OpenJDK8U-jdk_x64_linux_hotspot_8u265b01.... | false |
Other | spring-projects | spring-framework | 5cb2cc2466dac275207a81f4095cedaf36257422.json | Fix asciidoctor syntax for source
See gh-25539 | src/docs/asciidoc/integration.adoc | @@ -1217,7 +1217,7 @@ To send multipart data, you need to provide a `MultiValueMap<String, Object>` wh
may be an `Object` for part content, a `Resource` for a file part, or an `HttpEntity` for
part content with headers. For example:
-[source,java,intent=0]
+[source,java,indent=0]
[subs="verbatim,quotes"]
----
M... | false |
Other | spring-projects | spring-framework | e150a956850977c57133914577803b46a102b52c.json | Fix comment syntax in xml examples
See gh-25537 | src/docs/asciidoc/core/core-appendix.adoc | @@ -242,7 +242,7 @@ The following example shows a path being used against another bean, by name:
[source,xml,indent=0,subs="verbatim,quotes"]
----
- // target bean to be referenced by name
+ <!-- target bean to be referenced by name -->
<bean id="person" class="org.springframework.beans.TestBean" scope="prototype... | true |
Other | spring-projects | spring-framework | e150a956850977c57133914577803b46a102b52c.json | Fix comment syntax in xml examples
See gh-25537 | src/docs/asciidoc/languages/dynamic-languages.adoc | @@ -462,7 +462,7 @@ The following bean definition uses the calculator defined in Groovy:
[source,xml,indent=0]
[subs="verbatim,quotes"]
----
- <-- from the file 'beans.xml' -->
+ <!-- from the file 'beans.xml' -->
<beans>
<lang:groovy id="calculator" script-source="classpath:calculator.groovy"/>
</beans> | true |
Other | spring-projects | spring-framework | 4d670ee25d8a1e615883dfb4468919c2b43c33b0.json | Drop support for standalone "L" in CronExpression
This commit removes support for a standalone "L" in the
day-of-week of a cron expression, which used a locale-dependent
API to determine what the last day of the week is (Saturday or
Sunday ?).
Alternatively, we could have implement this in the exact way as Quartz
has ... | spring-context/src/main/java/org/springframework/scheduling/support/CronExpression.java | @@ -121,9 +121,7 @@ private CronExpression(
* </li>
* <li>
* In the "day of week" field, {@code L} stands for "the last day of the
- * week", and uses the
- * {@linkplain java.util.Locale#getDefault() system default locale}
- * to determine which day that is (i.e. Sunday or Saturday).
+ * week".
* If pr... | true |
Other | spring-projects | spring-framework | 4d670ee25d8a1e615883dfb4468919c2b43c33b0.json | Drop support for standalone "L" in CronExpression
This commit removes support for a standalone "L" in the
day-of-week of a cron expression, which used a locale-dependent
API to determine what the last day of the week is (Saturday or
Sunday ?).
Alternatively, we could have implement this in the exact way as Quartz
has ... | spring-context/src/main/java/org/springframework/scheduling/support/QuartzCronField.java | @@ -23,9 +23,6 @@
import java.time.temporal.Temporal;
import java.time.temporal.TemporalAdjuster;
import java.time.temporal.TemporalAdjusters;
-import java.time.temporal.TemporalField;
-import java.time.temporal.WeekFields;
-import java.util.Locale;
import org.springframework.lang.Nullable;
import org.springfram... | true |
Other | spring-projects | spring-framework | 4d670ee25d8a1e615883dfb4468919c2b43c33b0.json | Drop support for standalone "L" in CronExpression
This commit removes support for a standalone "L" in the
day-of-week of a cron expression, which used a locale-dependent
API to determine what the last day of the week is (Saturday or
Sunday ?).
Alternatively, we could have implement this in the exact way as Quartz
has ... | spring-context/src/test/java/org/springframework/scheduling/support/CronExpressionTests.java | @@ -24,14 +24,12 @@
import java.time.ZonedDateTime;
import java.time.temporal.ChronoField;
import java.time.temporal.Temporal;
-import java.util.Locale;
import org.assertj.core.api.Condition;
import org.junit.jupiter.api.Test;
import static java.time.DayOfWeek.FRIDAY;
import static java.time.DayOfWeek.MONDAY... | true |
Other | spring-projects | spring-framework | 4d670ee25d8a1e615883dfb4468919c2b43c33b0.json | Drop support for standalone "L" in CronExpression
This commit removes support for a standalone "L" in the
day-of-week of a cron expression, which used a locale-dependent
API to determine what the last day of the week is (Saturday or
Sunday ?).
Alternatively, we could have implement this in the exact way as Quartz
has ... | spring-context/src/test/java/org/springframework/scheduling/support/QuartzCronFieldTests.java | @@ -18,12 +18,9 @@
import java.time.DayOfWeek;
import java.time.LocalDate;
-import java.util.Locale;
import org.junit.jupiter.api.Test;
-import static java.time.DayOfWeek.SATURDAY;
-import static java.time.DayOfWeek.SUNDAY;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.c... | true |
Other | spring-projects | spring-framework | 7a31885ae50ec81fc97cf22da9ab51f34d7619a2.json | Fix bug in StaticListableBeanFactory.isSingleton()
Prior to this commit, StaticListableBeanFactory.isSingleton() returned
false for singleton beans unless they were created by a FactoryBean.
StaticListableBeanFactory.isSingleton() now properly returns true for
all beans not created by a FactoryBean.
Closes gh-25522 | spring-beans/src/main/java/org/springframework/beans/factory/support/StaticListableBeanFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -45,20 +45,22 @@
/**
* Static {@link or... | true |
Other | spring-projects | spring-framework | 7a31885ae50ec81fc97cf22da9ab51f34d7619a2.json | Fix bug in StaticListableBeanFactory.isSingleton()
Prior to this commit, StaticListableBeanFactory.isSingleton() returned
false for singleton beans unless they were created by a FactoryBean.
StaticListableBeanFactory.isSingleton() now properly returns true for
all beans not created by a FactoryBean.
Closes gh-25522 | spring-beans/src/test/java/org/springframework/beans/factory/BeanFactoryUtilsTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -43,6 +43,7 @@
* @author Rod Johnson
* @... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/main/java/org/springframework/scheduling/support/BitsCronField.java | @@ -0,0 +1,235 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/main/java/org/springframework/scheduling/support/CronExpression.java | @@ -67,7 +67,7 @@ private CronExpression(
String expression) {
// to make sure we end up at 0 nanos, we add an extra field
- this.fields = new CronField[]{daysOfWeek, months, daysOfMonth, hours, minutes, seconds, CronField.zeroNanos()};
+ this.fields = new CronField[]{CronField.zeroNanos(), seconds, minutes,... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/main/java/org/springframework/scheduling/support/CronField.java | @@ -20,165 +20,93 @@
import java.time.temporal.ChronoField;
import java.time.temporal.Temporal;
import java.time.temporal.ValueRange;
-import java.util.BitSet;
import org.springframework.lang.Nullable;
-import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
/**
- * A single field... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/main/java/org/springframework/scheduling/support/QuartzCronField.java | @@ -0,0 +1,309 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/test/java/org/springframework/scheduling/support/BitsCronFieldTests.java | @@ -0,0 +1,73 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/test/java/org/springframework/scheduling/support/CronExpressionTests.java | @@ -22,11 +22,16 @@
import java.time.Year;
import java.time.ZoneId;
import java.time.ZonedDateTime;
+import java.time.temporal.ChronoField;
+import java.time.temporal.Temporal;
+import java.util.Locale;
+import org.assertj.core.api.Condition;
import org.junit.jupiter.api.Test;
import static java.time.DayOfWeek... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/test/java/org/springframework/scheduling/support/CronFieldTests.java | @@ -1,73 +0,0 @@
-/*
- * Copyright 2002-2020 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | 93b53dae2966ee5ab8ca7c0a00f56673f939a18a.json | Add support for Quartz features in CronExpression
This commit introduces support for Quartz-specific features in
CronExpression. This includes support for "L", "W", and "#".
Closes gh-20106
Closes gh-22436 | spring-context/src/test/java/org/springframework/scheduling/support/QuartzCronFieldTests.java | @@ -0,0 +1,144 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 1a8906bdc3a9e78e5036ef4874345a742fb151f7.json | Support macros in CronExpression
This commit introduces supports for macros like "@yearly", "@monthly",
etc. in CronExpression.
Closes gh-25471 | spring-context/src/main/java/org/springframework/scheduling/support/CronExpression.java | @@ -41,6 +41,16 @@ public final class CronExpression {
static final int MAX_ATTEMPTS = 366;
+ private static final String[] MACROS = new String[] {
+ "@yearly", "0 0 0 1 1 *",
+ "@annually", "0 0 0 1 1 *",
+ "@monthly", "0 0 0 1 * *",
+ "@weekly", "0 0 0 * * 0",
+ "@daily", "0 0 0 * * *",
+ "@midnight... | true |
Other | spring-projects | spring-framework | 1a8906bdc3a9e78e5036ef4874345a742fb151f7.json | Support macros in CronExpression
This commit introduces supports for macros like "@yearly", "@monthly",
etc. in CronExpression.
Closes gh-25471 | spring-context/src/test/java/org/springframework/scheduling/support/CronExpressionTests.java | @@ -27,6 +27,7 @@
import static java.time.DayOfWeek.FRIDAY;
import static java.time.DayOfWeek.MONDAY;
+import static java.time.DayOfWeek.SUNDAY;
import static java.time.DayOfWeek.TUESDAY;
import static java.time.DayOfWeek.WEDNESDAY;
import static java.time.temporal.TemporalAdjusters.next;
@@ -462,4 +463,124 @@ v... | true |
Other | spring-projects | spring-framework | dbec16d566ed7ac8a946e0d832d2a52d2d559f91.json | Add test for Friday 13th crontab failure
Added test for Friday 13th trigger, i.e. an uncommon crontab expression.
With the new CronExpression in place, this failure does not occur
anymore.
Closes gh-21574 | spring-context/src/test/java/org/springframework/scheduling/support/CronExpressionTests.java | @@ -25,6 +25,7 @@
import org.junit.jupiter.api.Test;
+import static java.time.DayOfWeek.FRIDAY;
import static java.time.DayOfWeek.MONDAY;
import static java.time.DayOfWeek.TUESDAY;
import static java.time.DayOfWeek.WEDNESDAY;
@@ -444,4 +445,21 @@ public void fixedDays() {
assertThat(actual.getDayOfWeek()).is... | false |
Other | spring-projects | spring-framework | b451379c2f6da834a24d230bc9f1355660da3e7c.json | Update eviction queue before size
See gh-25298 | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java | @@ -263,8 +263,9 @@ public LinkedMultiValueMap<String, String> getSubscriptions(String destination)
if (sessionIdToSubscriptionIds == null) {
sessionIdToSubscriptionIds = this.destinationCache.computeIfAbsent(destination, _destination -> {
LinkedMultiValueMap<String, String> matches = computeMatchingSubs... | false |
Other | spring-projects | spring-framework | d2e1150c7999b347d159ffc8247b123a406bf382.json | Fix typo in javadoc for @RequestMapping
Closes gh-25396 | spring-web/src/main/java/org/springframework/web/bind/annotation/RequestMapping.java | @@ -202,7 +202,7 @@
* produces = "text/plain;charset=UTF-8"
* </pre>
* <p>If a declared media type contains a parameter (e.g. "charset=UTF-8",
- * "type=feed", type="entry") and if a compatible media type from the request
+ * "type=feed", "type=entry") and if a compatible media type from the request
* has... | false |
Other | spring-projects | spring-framework | 490bdd11a562b665f1b8695d4b8f61f6bb7949a1.json | Use Math.min() in ExponentialBackOff
Use Math.min() instead of doing it manually in ExponentialBackOff.
Closes gh-25381 | spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -200,8 +200,7 @@ private long computeNextInt... | false |
Other | spring-projects | spring-framework | 313a7836b091d20dbb9763b3677d559fea32d13d.json | Provide access to Netty's WebSocketFrame
Closes gh-25099 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketMessage.java | @@ -39,6 +39,9 @@ public class WebSocketMessage {
private final DataBuffer payload;
+ @Nullable
+ private final Object nativeMessage;
+
/**
* Constructor for a WebSocketMessage.
@@ -47,13 +50,25 @@ public class WebSocketMessage {
* then invoke this constructor.
*/
public WebSocketMessage(Type type,... | true |
Other | spring-projects | spring-framework | 313a7836b091d20dbb9763b3677d559fea32d13d.json | Provide access to Netty's WebSocketFrame
Closes gh-25099 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/NettyWebSocketSessionSupport.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -74,7 +74,7 @@ public NettyDataBufferFactory... | true |
Other | spring-projects | spring-framework | 90467ba5689dae73e92f6a616d362fc76c93fe72.json | Use correct link to MaxInMemorySize
Closes gh-25368 | src/docs/asciidoc/web/webflux.adoc | @@ -835,7 +835,7 @@ exposes a `maxInMemorySize` property and if so the Javadoc will have details abo
values. On the server side, `ServerCodecConfigurer` provides a single place from where to
set all codecs, see <<webflux-config-message-codecs>>. On the client side, the limit for
all codecs can be changed in
-<<web-r... | false |
Other | spring-projects | spring-framework | 8734c64b75ee05a392cb173b257321883cb9fee8.json | Remove invalid import from Kotlin example | src/docs/asciidoc/core/core-aop.adoc | @@ -599,8 +599,6 @@ for this purpose. Such an aspect typically resembles the following example:
import org.aspectj.lang.annotation.Aspect
import org.aspectj.lang.annotation.Pointcut
- import org.springframework.aop.Pointcut
-
@Aspect
class CommonPointcuts {
| false |
Other | spring-projects | spring-framework | 1960666765a6bf93500f3bf8f2eeb29e428b68e9.json | Set error status in Observation Servlet filter
Prior to this commit, the Observation Servlet filter would record
unhandled exceptions on the observation context but would leave the
default HTTP response status as is.
Servlet containers do set the response status in that case to 500 by
default. Not doing that at the Se... | spring-web/src/main/java/org/springframework/web/filter/ServerHttpObservationFilter.java | @@ -27,6 +27,7 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
+import org.springframework.http.HttpStatus;
import org.springframework.http.server.observation.DefaultServerRequestObservationConvention;
import org.springframework.http.server.observation.ServerHtt... | true |
Other | spring-projects | spring-framework | 1960666765a6bf93500f3bf8f2eeb29e428b68e9.json | Set error status in Observation Servlet filter
Prior to this commit, the Observation Servlet filter would record
unhandled exceptions on the observation context but would leave the
default HTTP response status as is.
Servlet containers do set the response status in that case to 500 by
default. Not doing that at the Se... | spring-web/src/test/java/org/springframework/web/filter/ServerHttpObservationFilterTests.java | @@ -97,7 +97,18 @@ void filterShouldUnwrapServletException() {
ServerRequestObservationContext context = (ServerRequestObservationContext) this.request
.getAttribute(ServerHttpObservationFilter.CURRENT_OBSERVATION_CONTEXT_ATTRIBUTE);
assertThat(context.getError()).isEqualTo(customError);
- assertThatHttpObs... | true |
Other | spring-projects | spring-framework | ef5796c3a9ed759db0d112742d4986689470c847.json | Update documentation to mention Java 17+ baseline
Closes gh-29514 | framework-docs/src/docs/asciidoc/overview.adoc | @@ -8,10 +8,8 @@ include::attributes.adoc[]
Spring makes it easy to create Java enterprise applications. It provides everything you
need to embrace the Java language in an enterprise environment, with support for Groovy
and Kotlin as alternative languages on the JVM, and with the flexibility to create many
-kinds of... | false |
Other | spring-projects | spring-framework | f6eaa8e63c4eeb1ac4211fe5b134bfbd10b09ef3.json | Add missing callouts | framework-docs/src/docs/asciidoc/web/webmvc.adoc | @@ -1938,6 +1938,7 @@ You can also use the same with request header conditions, as the following examp
// ...
}
----
+<1> Testing whether `myHeader` equals `myValue`.
TIP: You can match `Content-Type` and `Accept` with the headers condition, but it is better to use
<<mvc-ann-requestmapping-consumes, consumes>... | false |
Other | spring-projects | spring-framework | cd27fbe55062d8da8b7a4634af4a42a0c20bf881.json | Add callouts to Kotlin examples for parity | framework-docs/src/docs/asciidoc/web/webflux-functional.adoc | @@ -640,14 +640,15 @@ RouterFunction<ServerResponse> route = route()
[source,kotlin,indent=0,subs="verbatim,quotes",role="secondary"]
.Kotlin
----
- val route = coRouter {
+ val route = coRouter { // <1>
"/person".nest {
GET("/{id}", accept(APPLICATION_JSON), handler::getPerson)
GET(accept(APPLICATION_JSO... | true |
Other | spring-projects | spring-framework | cd27fbe55062d8da8b7a4634af4a42a0c20bf881.json | Add callouts to Kotlin examples for parity | framework-docs/src/docs/asciidoc/web/webmvc-functional.adoc | @@ -623,13 +623,14 @@ RouterFunction<ServerResponse> route = route()
import org.springframework.web.servlet.function.router
val route = router {
- "/person".nest {
+ "/person".nest { // <1>
GET("/{id}", accept(APPLICATION_JSON), handler::getPerson)
GET(accept(APPLICATION_JSON), handler::listPeople)
... | true |
Other | spring-projects | spring-framework | 508d2c7a77e004afc7eb2f028a2345244c62939b.json | Fix Javadoc formatting issues for headings
Headings in method-level Javadoc must be h4 or higher in recent versions
of Java. | spring-core/src/main/java/org/springframework/util/AntPathMatcher.java | @@ -529,7 +529,7 @@ public Map<String, String> extractUriTemplateVariables(String pattern, String pa
* the first pattern contains a file extension match (e.g., {@code *.html}).
* In that case, the second pattern will be merged into the first. Otherwise,
* an {@code IllegalArgumentException} will be thrown.
- ... | true |
Other | spring-projects | spring-framework | 508d2c7a77e004afc7eb2f028a2345244c62939b.json | Fix Javadoc formatting issues for headings
Headings in method-level Javadoc must be h4 or higher in recent versions
of Java. | spring-test/src/main/java/org/springframework/test/context/TestPropertySource.java | @@ -112,11 +112,11 @@
* {@code Environment}'s set of {@code PropertySources}. Each location
* will be added to the enclosing {@code Environment} as its own property
* source, in the order declared.
- * <h3>Supported File Formats</h3>
+ * <h4>Supported File Formats</h4>
* <p>Both traditional and XML-based ... | true |
Other | spring-projects | spring-framework | 508d2c7a77e004afc7eb2f028a2345244c62939b.json | Fix Javadoc formatting issues for headings
Headings in method-level Javadoc must be h4 or higher in recent versions
of Java. | spring-test/src/main/java/org/springframework/test/context/jdbc/Sql.java | @@ -91,7 +91,7 @@
* {@link #value}, but it may be used instead of {@link #value}. Similarly,
* this attribute may be used in conjunction with or instead of
* {@link #statements}.
- * <h3>Path Resource Semantics</h3>
+ * <h4>Path Resource Semantics</h4>
* <p>Each path will be interpreted as a Spring
* {... | true |
Other | spring-projects | spring-framework | 508d2c7a77e004afc7eb2f028a2345244c62939b.json | Fix Javadoc formatting issues for headings
Headings in method-level Javadoc must be h4 or higher in recent versions
of Java. | spring-tx/src/main/java/org/springframework/transaction/annotation/TransactionManagementConfigurer.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -51,7 +51,7 @@ public interface TransactionM... | true |
Other | spring-projects | spring-framework | 42856bab164dd0b9d92dbb1cd42acce66d491ffa.json | Add milestone repo for optional Netty 5 support
Closes gh-29498 | build.gradle | @@ -21,6 +21,13 @@ ext {
configure(allprojects) { project ->
repositories {
mavenCentral()
+ maven {
+ url "https://repo.spring.io/milestone"
+ content {
+ // Netty 5 optional support
+ includeGroup 'io.projectreactor.netty'
+ }
+ }
maven { url "https://repo.spring.io/libs-spring-framework-build"... | false |
Other | spring-projects | spring-framework | 8e64701cb74aaded6f647d3c9aa0d186b8654b0b.json | Fix Javadoc formatting issue in TestSocketUtils | spring-test/src/main/java/org/springframework/test/util/TestSocketUtils.java | @@ -73,7 +73,7 @@ public class TestSocketUtils {
/**
* Although {@code TestSocketUtils} consists solely of static utility methods,
* this constructor is intentionally {@code public}.
- * <h4>Rationale</h4>
+ * <h5>Rationale</h5>
* <p>Static methods from this class may be invoked from within XML
* config... | false |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-beans/src/main/java/org/springframework/beans/factory/serviceloader/AbstractServiceLoaderBasedFactoryBean.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -69,7 +69,7 @@ public void setBeanClassLoade... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-context-support/src/main/java/org/springframework/cache/jcache/interceptor/DefaultJCacheOperationSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -166,7 +166,7 @@ public void setBeanFactory(... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-context/src/main/java/org/springframework/scheduling/annotation/ProxyAsyncConfiguration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -44,7 +44,7 @@ public class ProxyAsyncConfig... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java | @@ -378,43 +378,43 @@ protected void postProcessConfiguration(Configuration<?> configuration) {
@Override
public Validator getValidator() {
- Assert.notNull(this.validatorFactory, "No target ValidatorFactory set");
+ Assert.state(this.validatorFactory != null, "No target ValidatorFactory set");
return this.v... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-core-test/src/main/java/org/springframework/aot/agent/RecordedInvocation.java | @@ -98,7 +98,7 @@ public Stream<StackWalker.StackFrame> getStackFrames() {
*/
@SuppressWarnings("unchecked")
public <T> T getInstance() {
- Assert.notNull(this.instance, "Cannot resolve 'this' for static invocations");
+ Assert.state(this.instance != null, "Cannot resolve 'this' for static invocations");
re... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-core-test/src/main/java/org/springframework/aot/test/agent/RuntimeHintsRecorder.java | @@ -49,7 +49,7 @@ private RuntimeHintsRecorder() {
*/
public synchronized static RuntimeHintsInvocations record(Runnable action) {
Assert.notNull(action, "Runnable action must not be null");
- Assert.isTrue(RuntimeHintsAgent.isLoaded(), "RuntimeHintsAgent should be loaded in the current JVM");
+ Assert.state(... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-core-test/src/test/java/org/springframework/aot/agent/RecordedInvocationTests.java | @@ -63,8 +63,8 @@ void buildValidStaticInvocation() {
@Test
void staticInvocationShouldThrowWhenGetInstance() {
- assertThatThrownBy(staticInvocation::getInstance).isInstanceOf(IllegalArgumentException.class);
- assertThatThrownBy(staticInvocation::getInstanceTypeReference).isInstanceOf(IllegalArgumentException... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-core/src/main/java/org/springframework/aot/generate/DefaultMethodReference.java | @@ -42,29 +42,32 @@ public class DefaultMethodReference implements MethodReference {
@Nullable
private final ClassName declaringClass;
+
public DefaultMethodReference(MethodSpec method, @Nullable ClassName declaringClass) {
this.method = method;
this.declaringClass = declaringClass;
}
+
@Override
... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-core/src/test/java/org/springframework/aot/generate/DefaultMethodReferenceTests.java | @@ -30,6 +30,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
/**
* Tests for {@link DefaultMethodReference}.
@@ -86,7 +87,7 @@ void to... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/ConnectionHolder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -157,7 +157,7 @@ protected void setConnectio... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/SimpleDriverDataSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -136,8 +136,8 @@ public Driver getDriver() {... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-messaging/src/main/java/org/springframework/messaging/converter/MarshallingMessageConverter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -144,7 +144,7 @@ protected boolean supports(... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-r2dbc/src/main/java/org/springframework/r2dbc/connection/ConnectionHolder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,7 +23,6 @@
import org.springframework.t... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-web/src/main/java/org/springframework/http/converter/xml/MarshallingHttpMessageConverter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -121,7 +121,7 @@ protected boolean supports(... | true |
Other | spring-projects | spring-framework | abf3400c07da1e7e98c44388a5fbbd1a89cea0d8.json | Use Assert.state() where appropriate | spring-web/src/main/java/org/springframework/http/server/reactive/JettyHttpHandlerAdapter.java | @@ -59,7 +59,7 @@ public JettyHttpHandlerAdapter(HttpHandler httpHandler) {
protected ServletServerHttpRequest createRequest(HttpServletRequest request, AsyncContext context)
throws IOException, URISyntaxException {
- Assert.notNull(getServletPath(), "Servlet path is not initialized");
+ Assert.state(getServl... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.