language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | fd7e6486de580404993c2a3b7af3a464e8795df8.json | Fix syntax in validation examples
Closes gh-25251 | src/docs/asciidoc/core/core-validation.adoc | @@ -1891,12 +1891,11 @@ bean, as the following example shows:
import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;
@Configuration
-
public class AppConfig {
@Bean
public LocalValidatorFactoryBean validator() {
- return new LocalValidatorFactoryBean;
+ return new LocalValid... | false |
Other | spring-projects | spring-framework | 30385dae8d76c17c458381c88e3add8e35037bb0.json | Upgrade JDK 15 CI image to JDK 15 build 26 | ci/images/get-jdk-url.sh | @@ -12,7 +12,7 @@ case "$1" in
echo "https://github.com/AdoptOpenJDK/openjdk14-binaries/releases/download/jdk-14.0.1%2B7/OpenJDK14U-jdk_x64_linux_hotspot_14.0.1_7.tar.gz"
;;
java15)
- echo "https://download.java.net/java/early_access/jdk15/24/GPL/openjdk-15-ea+24_linux-x64_bin.tar.gz"
+ echo "https://downl... | false |
Other | spring-projects | spring-framework | b0e07cc7e336062cb02673e5ab60b9b52d51b70e.json | Delete dead code in spring-webmvc | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java | @@ -252,11 +252,6 @@ public DefaultEntityResponse(int statusCode, HttpHeaders headers,
this.entityType = entityType;
}
- private static <T> boolean isResource(T entity) {
- return !(entity instanceof InputStreamResource) &&
- (entity instanceof Resource);
- }
-
@Override
public T entity() {
r... | true |
Other | spring-projects | spring-framework | b0e07cc7e336062cb02673e5ab60b9b52d51b70e.json | Delete dead code in spring-webmvc | spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java | @@ -35,9 +35,6 @@
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
-import kotlin.reflect.KFunction;
-import kotlin.reflect.jvm.ReflectJvmMapping;
-
import org.springframework.aop.support.AopUtils;
import org.springframework.beans.factory.BeanFactoryUtils;
import org.springfra... | true |
Other | spring-projects | spring-framework | b0e07cc7e336062cb02673e5ab60b9b52d51b70e.json | Delete dead code in spring-webmvc | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterReturnValueHandler.java | @@ -61,8 +61,6 @@
*/
public class ResponseBodyEmitterReturnValueHandler implements HandlerMethodReturnValueHandler {
- private final List<HttpMessageConverter<?>> messageConverters;
-
private final List<HttpMessageConverter<?>> sseMessageConverters;
private final ReactiveTypeHandler reactiveHandler;
@@ -76,7... | true |
Other | spring-projects | spring-framework | b9e52a808921b76846f4b3ba8505c6c6d41542d2.json | Delete dead code in MockServerHttpRequest | spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerHttpRequest.java | @@ -457,11 +457,6 @@ private static class DefaultBodyBuilder implements BodyBuilder {
this.url = url;
}
- DefaultBodyBuilder(HttpMethod httpMethod, URI url) {
- this.methodValue = httpMethod.name();
- this.url = url;
- }
-
@Override
public BodyBuilder contextPath(String contextPath) {
this.cont... | true |
Other | spring-projects | spring-framework | b9e52a808921b76846f4b3ba8505c6c6d41542d2.json | Delete dead code in MockServerHttpRequest | spring-web/src/testFixtures/java/org/springframework/web/testfixture/http/server/reactive/MockServerHttpRequest.java | @@ -457,11 +457,6 @@ private static class DefaultBodyBuilder implements BodyBuilder {
this.url = url;
}
- DefaultBodyBuilder(HttpMethod httpMethod, URI url) {
- this.methodValue = httpMethod.name();
- this.url = url;
- }
-
@Override
public BodyBuilder contextPath(String contextPath) {
this.cont... | true |
Other | spring-projects | spring-framework | 1d0fe1223d8bfa47cc5d5c9a88e9a963419e73fe.json | Fix checkstyle violation | spring-messaging/src/test/java/org/springframework/messaging/rsocket/DefaultRSocketRequesterBuilderTests.java | @@ -52,7 +52,6 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; | false |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | spring-core/src/main/java/org/springframework/core/ReactiveAdapterRegistry.java | @@ -361,7 +361,7 @@ void registerAdapters(ReactiveAdapterRegistry registry) {
/**
* {@code BlockHoundIntegration} for spring-core classes.
- * <p>Whitelists the following:
+ * <p>Explicitly allow the following:
* <ul>
* <li>Reading class info via {@link LocalVariableTableParameterNameDiscoverer}.
* <l... | true |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | spring-web/src/main/java/org/springframework/web/accept/ContentNegotiationManagerFactoryBean.java | @@ -178,7 +178,7 @@ public void setFavorPathExtension(boolean favorPathExtension) {
* {@code ResourceHttpRequestHandler}.
* <li>Determine the media type of views rendered with
* {@code ContentNegotiatingViewResolver}.
- * <li>Whitelist extensions for RFD attack detection (check the Spring
+ * <li>List safe e... | true |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/ContentNegotiationConfigurer.java | @@ -146,9 +146,9 @@ public ContentNegotiationConfigurer favorPathExtension(boolean favorPathExtensio
* Add a mapping from a key, extracted from a path extension or a query
* parameter, to a MediaType. This is required in order for the parameter
* strategy to work. Any extensions explicitly registered here are ... | true |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java | @@ -76,12 +76,12 @@ public abstract class AbstractMessageConverterMethodProcessor extends AbstractMe
implements HandlerMethodReturnValueHandler {
/* Extensions associated with the built-in message converters */
- private static final Set<String> WHITELISTED_EXTENSIONS = new HashSet<>(Arrays.asList(
+ private sta... | true |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestResponseBodyMethodProcessorTests.java | @@ -380,15 +380,15 @@ public void addContentDispositionHeader() throws Exception {
Collections.singletonList(new StringHttpMessageConverter()),
factory.getObject());
- assertContentDisposition(processor, false, "/hello.json", "whitelisted extension");
+ assertContentDisposition(processor, false, "/hello.j... | true |
Other | spring-projects | spring-framework | a2d516d526b482c5824429480963dc92eb2fcd2f.json | Replace "whitelist" with alternative words | src/docs/asciidoc/web/webmvc.adoc | @@ -1737,11 +1737,11 @@ lower the risk but are not sufficient to prevent RFD attacks.
To prevent RFD attacks, prior to rendering the response body, Spring MVC adds a
`Content-Disposition:inline;filename=f.txt` header to suggest a fixed and safe download
-file. This is done only if the URL path contains a file exten... | true |
Other | spring-projects | spring-framework | 7b6293fa052ed67fabc01e013145294c6b9822b0.json | Avoid outdated Jackson API in tests
See gh-25907 | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java | @@ -355,7 +355,7 @@ private static DeserializerFactoryConfig getDeserializerFactoryConfig(ObjectMapp
@Test
public void propertyNamingStrategy() {
- PropertyNamingStrategy strategy = new PropertyNamingStrategy.LowerCaseWithUnderscoresStrategy();
+ PropertyNamingStrategy strategy = new PropertyNamingStrategy.Snak... | true |
Other | spring-projects | spring-framework | 7b6293fa052ed67fabc01e013145294c6b9822b0.json | Avoid outdated Jackson API in tests
See gh-25907 | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java | @@ -212,8 +212,7 @@ public void defaultModules() throws JsonProcessingException, UnsupportedEncoding
assertThat(new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8")).isEqualTo(timestamp.toString());
}
- @Test // SPR-12634
- @SuppressWarnings("unchecked")
+ @Test // SPR-12634
public void customizeDefa... | true |
Other | spring-projects | spring-framework | 7b6293fa052ed67fabc01e013145294c6b9822b0.json | Avoid outdated Jackson API in tests
See gh-25907 | spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -46,7 +46,6 @@
import com.fasterxml.jackson... | true |
Other | spring-projects | spring-framework | 74c2df43cc4c56dca18cc0da6eb7c308122389ec.json | Improve Javadoc for @NestedTestConfiguration
See gh-19930 | spring-test/src/main/java/org/springframework/test/context/NestedTestConfiguration.java | @@ -39,14 +39,14 @@
* mode</em> will be used. See {@link #ENCLOSING_CONFIGURATION_PROPERTY_NAME} for
* details on how to change the default mode.
*
- * <p>By default, if {@code @NestedTestConfiguration} is not <em>present</em> or
- * <em>meta-present</em> on a test class, configuration from the test class will
- ... | false |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-core/src/main/java/org/springframework/core/codec/Decoder.java | @@ -18,12 +18,12 @@
import java.util.List;
import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProc... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java | @@ -27,8 +27,6 @@
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
import org.springframework.core.io.buffer.DataBuffer;
import org.springframework.core.io.buffer.DataB... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketPayloadReturnValueHandler.java | @@ -21,7 +21,6 @@
import io.rsocket.Payload;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import org.springframework.core.MethodParameter;
import org.springframework.core.ReactiveAdapterRegistry;
@@ -36,7 +35,7 @@
/**
* Extension of {@li... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpClient.java | @@ -19,8 +19,8 @@
import java.time.Duration;
import java.util.Collection;
import java.util.List;
+import java.util.concurrent.CompletableFuture;
import java.util.function.BiFunction;
-import java.util.function.Consumer;
import java.util.function.Function;
import io.netty.buffer.ByteBuf;
@@ -33,7 +33,6 @@
impor... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpConnection.java | @@ -18,7 +18,7 @@
import io.netty.buffer.ByteBuf;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
+import reactor.core.publisher.Sinks;
import reactor.netty.NettyInbound;
import reactor.netty.NettyOutbound;
@@ -42,16 +42,16 @@
private final ReactorNettyCodec<P> codec;
- p... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketServerToClientIntegrationTests.java | @@ -28,7 +28,6 @@
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import reactor.core.scheduler.Schedulers;
import reactor.test.StepVerifier;
@@ -126,15 +125,15 @@ private ... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SimpAnnotationMethodMessageHandlerTests.java | @@ -34,7 +34,6 @@
import org.mockito.junit.jupiter.MockitoExtension;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.context.support.StaticApplicationContext;
@@ -342,8 +341,8 @@ ... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerHttpResponse.java | @@ -25,7 +25,6 @@
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.core.io.buffer.DataBuffer;
@@ -64,11 +63,14 @@ public MockServerHttpRespons... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/main/java/org/springframework/test/web/reactive/server/HttpHandlerConnector.java | @@ -24,7 +24,6 @@
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import reactor.core.scheduler.Schedulers;
@@ -84,8 +83,8 @@ public Mono<ClientHttpResponse> connect(Ht... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/main/java/org/springframework/test/web/reactive/server/WiretapConnector.java | @@ -24,9 +24,9 @@
import java.util.function.Function;
import org.reactivestreams.Publisher;
+import reactor.core.Scannable;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.core... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/test/java/org/springframework/test/web/reactive/server/CookieAssertionTests.java | @@ -19,8 +19,7 @@
import java.time.Duration;
import org.junit.jupiter.api.Test;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
+import reactor.core.publisher.Mono;
import org.springframework.http.HttpMethod;
import org.springframework.http.HttpStatus;
@@ -128,10 +127,9 @@ pr... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/test/java/org/springframework/test/web/reactive/server/HeaderAssertionTests.java | @@ -23,8 +23,7 @@
import java.util.concurrent.TimeUnit;
import org.junit.jupiter.api.Test;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
+import reactor.core.publisher.Mono;
import org.springframework.http.CacheControl;
import org.springframework.http.HttpHeaders;
@@ -241,1... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-test/src/test/java/org/springframework/test/web/reactive/server/StatusAssertionTests.java | @@ -20,8 +20,7 @@
import java.time.Duration;
import org.junit.jupiter.api.Test;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
+import reactor.core.publisher.Mono;
import org.springframework.http.HttpMethod;
import org.springframework.http.HttpStatus;
@@ -157,10 +156,9 @@ pr... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-web/src/testFixtures/java/org/springframework/web/testfixture/http/server/reactive/MockServerHttpResponse.java | @@ -25,7 +25,6 @@
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.core.io.buffer.DataBuffer;
@@ -64,11 +63,14 @@ public MockServerHttpRespons... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/SyncInvocableHandlerMethod.java | @@ -18,11 +18,10 @@
import java.lang.reflect.Method;
import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
import java.util.stream.Collectors;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
-
import org.spring... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ErrorsMethodArgumentResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -56,6 +56,11 @@ public Mono<Object> resolveA... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ModelAttributeMethodArgumentResolver.java | @@ -23,7 +23,6 @@
import java.util.Optional;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.beans.BeanUtils;
@@ -111,20 +110,23 @@ public Mono<Object> resolveArgument(
String name = ModelInitializer.getNameForP... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/AbstractListenerWebSocketSession.java | @@ -25,7 +25,6 @@
import org.reactivestreams.Subscription;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import reactor.util.concurrent.Queues;
@@ -65,7 +64,11 @@
@Nullable
- private final MonoProce... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@
import org.eclipse.jetty.web... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/StandardWebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@
import javax.websocket.Sessi... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/TomcatWebSocketSession.java | @@ -21,7 +21,6 @@
import javax.websocket.Session;
import org.apache.tomcat.websocket.WsSession;
-import reactor.core.publisher.MonoProcessor;
import org.springframework.core.io.buffer.DataBufferFactory;
import org.springframework.web.reactive.socket.HandshakeInfo;
@@ -47,8 +46,9 @@ public TomcatWebSocketSession... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/UndertowWebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,7 +25,7 @@
import io.undertow.websocket... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/JettyWebSocketClient.java | @@ -26,7 +26,6 @@
import org.eclipse.jetty.websocket.client.ClientUpgradeRequest;
import org.eclipse.jetty.websocket.client.io.UpgradeListener;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.context.Lifecycle;
@@ -... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/StandardWebSocketClient.java | @@ -31,7 +31,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import reactor.core.scheduler.Schedulers;
@@ -96,24 +95,24 @@ public Mono<Void> execute(URI... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/TomcatWebSocketClient.java | @@ -20,7 +20,6 @@
import javax.websocket.WebSocketContainer;
import org.apache.tomcat.websocket.WsWebSocketContainer;
-import reactor.core.publisher.MonoProcessor;
import org.springframework.web.reactive.socket.HandshakeInfo;
import org.springframework.web.reactive.socket.adapter.StandardWebSocketSession;
@@ -4... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/UndertowWebSocketClient.java | @@ -33,7 +33,6 @@
import org.xnio.IoFuture;
import org.xnio.XnioWorker;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.core.io.buffer.DataBufferFactory;
@@ -155,7 +154,7 @@ public Mono<Void> execute(URI url, HttpHe... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ErrorsMethodArgumentResolverTests.java | @@ -20,8 +20,6 @@
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
import org.springframework.core.MethodParameter;
import org.springframework.core.ReactiveAdapterRegistry;
@@ -91,9 +89,7 @@ private Binding... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SseIntegrationTests.java | @@ -26,7 +26,7 @@
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import reactor.core.publisher.Flux;
-import reactor.core.publisher.MonoProcessor;
+import reactor.core.publisher.Mono;
import reactor.core.publisher.Sinks;
import reactor.test.StepVerifier;
... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java | @@ -27,8 +27,6 @@
import org.apache.commons.logging.LogFactory;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
-import reactor.core.publisher.Sinks;
import reactor.util.retry.Retry;
import org.springframework.context.annotation.Bean;
@@ -99,7... | true |
Other | spring-projects | spring-framework | e73e489fd8a0fd5cc398916b95e2b86c9c8f86be.json | Remove use of MonoProcessor.fromSinks
See gh-25884 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandlerTests.java | @@ -32,7 +32,6 @@
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.Sinks;
import org.springframework.core.MethodParameter;
@@ -109,12 +108,18 @@ public void doesNotSupportType() t... | true |
Other | spring-projects | spring-framework | cdd48ddd7f18f4cebd2586e34e10dea1629d1eed.json | Improve Coroutines support consistency | spring-messaging/spring-messaging.gradle | @@ -16,7 +16,6 @@ dependencies {
optional("javax.json.bind:javax.json.bind-api")
optional("javax.xml.bind:jaxb-api")
optional("com.google.protobuf:protobuf-java-util")
- optional("org.jetbrains.kotlinx:kotlinx-coroutines-core")
optional("org.jetbrains.kotlinx:kotlinx-coroutines-reactor")
testCompile(project("... | true |
Other | spring-projects | spring-framework | cdd48ddd7f18f4cebd2586e34e10dea1629d1eed.json | Improve Coroutines support consistency | spring-webflux/spring-webflux.gradle | @@ -26,7 +26,6 @@ dependencies {
optional("org.jetbrains.kotlin:kotlin-reflect")
optional("org.jetbrains.kotlin:kotlin-stdlib")
optional("com.google.protobuf:protobuf-java-util")
- optional("org.jetbrains.kotlinx:kotlinx-coroutines-core")
optional("org.jetbrains.kotlinx:kotlinx-coroutines-reactor")
testCompil... | true |
Other | spring-projects | spring-framework | cdd48ddd7f18f4cebd2586e34e10dea1629d1eed.json | Improve Coroutines support consistency | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ControllerMethodResolver.java | @@ -189,9 +189,6 @@ private static List<HandlerMethodArgumentResolver> initResolvers(ArgumentResolve
result.add(new RequestAttributeMethodArgumentResolver(beanFactory, adapterRegistry));
// Type-based...
- if (KotlinDetector.isKotlinPresent()) {
- result.add(new ContinuationHandlerMethodArgumentResolver());
... | true |
Other | spring-projects | spring-framework | cdd48ddd7f18f4cebd2586e34e10dea1629d1eed.json | Improve Coroutines support consistency | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ControllerMethodResolverTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -105,14 +105,14 @@ public void requestMappin... | true |
Other | spring-projects | spring-framework | d49a7a105d0b4a19abce778d128f35d3452e558d.json | Fix failing tests from Reactor snapshot changes
See gh-25884 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/SyncInvocableHandlerMethod.java | @@ -102,7 +102,7 @@ public ParameterNameDiscoverer getParameterNameDiscoverer() {
public HandlerResult invokeForHandlerResult(ServerWebExchange exchange,
BindingContext bindingContext, Object... providedArgs) {
- MonoProcessor<HandlerResult> processor = MonoProcessor.fromSink(Sinks.one());
+ MonoProcessor<Han... | true |
Other | spring-projects | spring-framework | d49a7a105d0b4a19abce778d128f35d3452e558d.json | Fix failing tests from Reactor snapshot changes
See gh-25884 | spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java | @@ -99,7 +99,7 @@ void subProtocol(WebSocketClient client, HttpServer server, Class<?> serverConfi
String protocol = "echo-v1";
AtomicReference<HandshakeInfo> infoRef = new AtomicReference<>();
- MonoProcessor<Object> output = MonoProcessor.fromSink(Sinks.one());
+ MonoProcessor<Object> output = MonoProcessor... | true |
Other | spring-projects | spring-framework | eb11c6fa233092506d360fb46d40d489107efd5f.json | Reinstate removal of jsessionid from lookup path
Closes gh-25864 | spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java | @@ -556,7 +556,8 @@ protected String determineEncoding(HttpServletRequest request) {
* @return the updated URI string
*/
public String removeSemicolonContent(String requestUri) {
- return (this.removeSemicolonContent ? removeSemicolonContentInternal(requestUri) : requestUri);
+ return (this.removeSemicolonCon... | true |
Other | spring-projects | spring-framework | eb11c6fa233092506d360fb46d40d489107efd5f.json | Reinstate removal of jsessionid from lookup path
Closes gh-25864 | spring-web/src/test/java/org/springframework/web/util/UrlPathHelperTests.java | @@ -133,7 +133,7 @@ public void getRequestKeepSemicolonContent() {
assertThat(helper.getRequestUri(request)).isEqualTo("/foo;a=b;c=d");
request.setRequestURI("/foo;jsessionid=c0o7fszeb1");
- assertThat(helper.getRequestUri(request)).isEqualTo("/foo;jsessionid=c0o7fszeb1");
+ assertThat(helper.getRequestUri(re... | true |
Other | spring-projects | spring-framework | eb11c6fa233092506d360fb46d40d489107efd5f.json | Reinstate removal of jsessionid from lookup path
Closes gh-25864 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestResponseBodyMethodProcessorTests.java | @@ -389,6 +389,7 @@ public void addContentDispositionHeader() throws Exception {
assertContentDisposition(processor, true, "/hello.json;a=b;setup.dataless", "unknown ext in path params");
assertContentDisposition(processor, true, "/hello.dataless;a=b;setup.json", "unknown ext in filename");
assertContentDispos... | true |
Other | spring-projects | spring-framework | eb11c6fa233092506d360fb46d40d489107efd5f.json | Reinstate removal of jsessionid from lookup path
Closes gh-25864 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/UriTemplateServletAnnotationControllerHandlerMethodTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -69,6 +69,28 @@ public void simple() throws ... | true |
Other | spring-projects | spring-framework | b2d8180f825e3193464c4bc7bdf67a0ba8bf7867.json | Add params and remoteAddress to request builder
This commit adds methods for adding/changing parameters and remote
address in the WebMvc.fn request builder.
Closes gh-25776 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerRequestBuilder.java | @@ -24,6 +24,7 @@
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.security.Principal;
+import java.util.ArrayList;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
@@ -47,6 +48,7 @@
import org.springframework.http.MediaType;
import org.springframewo... | true |
Other | spring-projects | spring-framework | b2d8180f825e3193464c4bc7bdf67a0ba8bf7867.json | Add params and remoteAddress to request builder
This commit adds methods for adding/changing parameters and remote
address in the WebMvc.fn request builder.
Closes gh-25776 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/ServerRequest.java | @@ -553,6 +553,32 @@ interface Builder {
*/
Builder attributes(Consumer<Map<String, Object>> attributesConsumer);
+ /**
+ * Add a parameter with the given name and value.
+ * @param name the parameter name
+ * @param values the parameter value(s)
+ * @return this builder
+ */
+ Builder param(String... | true |
Other | spring-projects | spring-framework | b2d8180f825e3193464c4bc7bdf67a0ba8bf7867.json | Add params and remoteAddress to request builder
This commit adds methods for adding/changing parameters and remote
address in the WebMvc.fn request builder.
Closes gh-25776 | spring-webmvc/src/test/java/org/springframework/web/servlet/function/DefaultServerRequestBuilderTests.java | @@ -17,6 +17,7 @@
package org.springframework.web.servlet.function;
import java.io.IOException;
+import java.net.InetSocketAddress;
import java.util.Collections;
import java.util.List;
@@ -29,6 +30,7 @@
import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.http.converter.S... | true |
Other | spring-projects | spring-framework | 9990bd2ea84560c64b44900754ddfd35d77de763.json | Fix checkstyle errors
See gh-25771 | spring-web/src/main/java/org/springframework/http/codec/json/KotlinSerializationJsonDecoder.java | @@ -79,7 +79,7 @@ public Flux<Object> decode(Publisher<DataBuffer> inputStream, ResolvableType ele
@Override
public Mono<Object> decodeToMono(Publisher<DataBuffer> inputStream, ResolvableType elementType, MimeType mimeType, Map<String, Object> hints) {
- return stringDecoder
+ return this.stringDecoder
.de... | true |
Other | spring-projects | spring-framework | 9990bd2ea84560c64b44900754ddfd35d77de763.json | Fix checkstyle errors
See gh-25771 | spring-web/src/main/java/org/springframework/http/codec/json/KotlinSerializationJsonEncoder.java | @@ -92,7 +92,7 @@ public Flux<DataBuffer> encode(Publisher<?> inputStream, DataBufferFactory buffe
@Override
public DataBuffer encodeValue(Object value, DataBufferFactory bufferFactory, ResolvableType valueType, MimeType mimeType, Map<String, Object> hints) {
String json = this.json.encodeToString(serializer(val... | true |
Other | spring-projects | spring-framework | 30c79404834ff7862c24c4a464c58f681f994f81.json | Fix recent regression in WebTestClient
Closes gh-25854 | spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java | @@ -213,7 +213,6 @@ public RequestBodySpec uri(Function<UriBuilder, URI> uriFunction) {
@Override
public RequestBodySpec uri(URI uri) {
- this.uriTemplate = null;
this.uri = uri;
return this;
} | true |
Other | spring-projects | spring-framework | 30c79404834ff7862c24c4a464c58f681f994f81.json | Fix recent regression in WebTestClient
Closes gh-25854 | spring-test/src/test/java/org/springframework/test/web/reactive/server/DefaultControllerSpecTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -99,7 +99,16 @@ public void configurerConsum... | true |
Other | spring-projects | spring-framework | 32ab596e94ef15b15174218229c8ba216aece138.json | Upgrade CI to JDK15ea30 | ci/images/get-jdk-url.sh | @@ -12,7 +12,7 @@ case "$1" in
echo "https://github.com/AdoptOpenJDK/openjdk14-binaries/releases/download/jdk-14.0.1%2B7/OpenJDK14U-jdk_x64_linux_hotspot_14.0.1_7.tar.gz"
;;
java15)
- echo "https://download.java.net/java/early_access/jdk15/28/GPL/openjdk-15-ea+28_linux-x64_bin.tar.gz"
+ echo "https://downl... | false |
Other | spring-projects | spring-framework | 3aaff40e2ea3719eaaa98689e058c3edcc0a6e8a.json | Replace explicit use of PooledDataBuffer.release() | spring-core/src/main/java/org/springframework/core/io/buffer/DataBufferUtils.java | @@ -504,7 +504,7 @@ public static boolean release(@Nullable DataBuffer dataBuffer) {
catch (IllegalStateException ex) {
// Avoid dependency on Netty: IllegalReferenceCountException
if (logger.isDebugEnabled()) {
- logger.debug("Failed to release PooledDataBuffer", ex);
+ logger.debug("Failed ... | true |
Other | spring-projects | spring-framework | 3aaff40e2ea3719eaaa98689e058c3edcc0a6e8a.json | Replace explicit use of PooledDataBuffer.release() | spring-web/src/main/java/org/springframework/http/codec/multipart/PartHttpMessageWriter.java | @@ -26,6 +26,7 @@
import org.springframework.core.codec.Hints;
import org.springframework.core.io.buffer.DataBuffer;
import org.springframework.core.io.buffer.DataBufferFactory;
+import org.springframework.core.io.buffer.DataBufferUtils;
import org.springframework.core.io.buffer.PooledDataBuffer;
import org.spring... | true |
Other | spring-projects | spring-framework | 671d4519b203d8ec2049333f63e789ff49598dc1.json | Fix checkstyle error | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java | @@ -85,7 +85,6 @@ class ConfigurationClassBeanDefinitionReader {
* <p>The default is "false".
*/
private static final boolean shouldIgnoreXml = SpringProperties.getFlag("spring.xml.ignore");
-
private final BeanDefinitionRegistry registry;
| false |
Other | spring-projects | spring-framework | a142d21700a51c95656115bb2cdbd242cff62cb7.json | Use @SafeVarargs in Jackson builder and factory
Using @SafeVarargs in Jackson mapper builder and factory bean classes
allows the varargs methods to be used without a compiler warning. The
implementations of these methods do not perform unsafe operations on
their varargs parameter. It is therefore safe to add this anno... | spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java | @@ -595,8 +595,8 @@ public Jackson2ObjectMapperBuilder modulesToInstall(Module... modules) {
* @see #modulesToInstall(Module...)
* @see com.fasterxml.jackson.databind.Module
*/
- @SuppressWarnings("unchecked")
- public Jackson2ObjectMapperBuilder modulesToInstall(Class<? extends Module>... modules) {
+ @SafeVa... | true |
Other | spring-projects | spring-framework | a142d21700a51c95656115bb2cdbd242cff62cb7.json | Use @SafeVarargs in Jackson builder and factory
Using @SafeVarargs in Jackson mapper builder and factory bean classes
allows the varargs methods to be used without a compiler warning. The
implementations of these methods do not perform unsafe operations on
their varargs parameter. It is therefore safe to add this anno... | spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBean.java | @@ -409,8 +409,8 @@ public void setModules(List<Module> modules) {
* @since 4.0.1
* @see com.fasterxml.jackson.databind.Module
*/
- @SuppressWarnings("unchecked")
- public void setModulesToInstall(Class<? extends Module>... modules) {
+ @SafeVarargs
+ public final void setModulesToInstall(Class<? extends Modul... | true |
Other | spring-projects | spring-framework | a142d21700a51c95656115bb2cdbd242cff62cb7.json | Use @SafeVarargs in Jackson builder and factory
Using @SafeVarargs in Jackson mapper builder and factory bean classes
allows the varargs methods to be used without a compiler warning. The
implementations of these methods do not perform unsafe operations on
their varargs parameter. It is therefore safe to add this anno... | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java | @@ -242,7 +242,6 @@ void modules() {
}
@Test
- @SuppressWarnings("unchecked")
void modulesToInstallByClass() {
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json()
.modulesToInstall(CustomIntegerModule.class)
@@ -292,7 +291,6 @@ void customizeWellKnownModulesWithModule()
}
@Test // SPR-... | true |
Other | spring-projects | spring-framework | a142d21700a51c95656115bb2cdbd242cff62cb7.json | Use @SafeVarargs in Jackson builder and factory
Using @SafeVarargs in Jackson mapper builder and factory bean classes
allows the varargs methods to be used without a compiler warning. The
implementations of these methods do not perform unsafe operations on
their varargs parameter. It is therefore safe to add this anno... | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java | @@ -213,7 +213,6 @@ public void defaultModules() throws JsonProcessingException, UnsupportedEncoding
}
@Test // SPR-12634
- @SuppressWarnings("unchecked")
public void customizeDefaultModulesWithModuleClass() throws JsonProcessingException, UnsupportedEncodingException {
this.factory.setModulesToInstall(Custo... | true |
Other | spring-projects | spring-framework | 21d069695f301851254ff2d03b44478303f24806.json | Refine solution for 21de09
The following was reported after the change and is related to it:
https://github.com/reactor/reactor-netty/issues/1170. An HTTP HEAD with the body
not consumed. Connection is disposed and closed leading to subsequent request to
fail. Adding toBodilessEntity() helps.
This change does not clo... | spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpConnector.java | @@ -115,8 +115,8 @@ public Mono<ClientHttpResponse> connect(HttpMethod method, URI uri,
.next()
.doOnCancel(() -> {
ReactorClientHttpResponse response = responseRef.get();
- if (response != null && response.bodyNotSubscribed()) {
- response.getConnection().dispose();
+ if (response != null)... | true |
Other | spring-projects | spring-framework | 21d069695f301851254ff2d03b44478303f24806.json | Refine solution for 21de09
The following was reported after the change and is related to it:
https://github.com/reactor/reactor-netty/issues/1170. An HTTP HEAD with the body
not consumed. Connection is disposed and closed leading to subsequent request to
fail. Adding toBodilessEntity() helps.
This change does not clo... | spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpResponse.java | @@ -21,6 +21,8 @@
import java.util.function.BiFunction;
import io.netty.buffer.ByteBufAllocator;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import reactor.core.publisher.Flux;
import reactor.netty.Connection;
import reactor.netty.NettyInbound;
@@ -29,10 +31,10 @@
impo... | true |
Other | spring-projects | spring-framework | 8eedd9d5cc6357a71663232b9601410e0c1a9793.json | Use JDBC 4 API for connection validation
With this commit use the JDBC 4.0 isValid method to
validate the connection. This is favorable over a
validation query. | spring-jdbc/src/main/java/org/springframework/jdbc/support/DatabaseStartupValidator.java | @@ -59,7 +59,12 @@ public class DatabaseStartupValidator implements InitializingBean {
@Nullable
private DataSource dataSource;
+ /**
+ * The query used to validate the connection
+ * @deprecated in favor of JDBC 4.0 connection validation
+ */
@Nullable
+ @Deprecated
private String validationQuery;
pri... | true |
Other | spring-projects | spring-framework | 8eedd9d5cc6357a71663232b9601410e0c1a9793.json | Use JDBC 4 API for connection validation
With this commit use the JDBC 4.0 isValid method to
validate the connection. This is favorable over a
validation query. | spring-jdbc/src/test/java/org/springframework/jdbc/support/DatabaseStartupValidatorTests.java | @@ -0,0 +1,131 @@
+/*
+ * Copyright 2003-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 6419b18beed313fcbee35abdeabaf62614767125.json | Fix typo in Java example for handler class
Closes gh-25302 | src/docs/asciidoc/web/webmvc-functional.adoc | @@ -254,7 +254,7 @@ public class PersonHandler {
int personId = Integer.parseInt(request.pathVariable("id"));
Person person = repository.getPerson(personId);
if (person != null) {
- return ok().contentType(APPLICATION_JSON).body(person))
+ return ok().contentType(APPLICATION_JSON).body(person);
}
els... | false |
Other | spring-projects | spring-framework | 837dfe285a1be47a16336a6fb5a6030070e637fb.json | Set PathPatternParser in RouterFunctionMapping
See gh-24945 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/support/RouterFunctionMapping.java | @@ -38,6 +38,7 @@
import org.springframework.web.servlet.function.RouterFunctions;
import org.springframework.web.servlet.function.ServerRequest;
import org.springframework.web.servlet.handler.AbstractHandlerMapping;
+import org.springframework.web.util.pattern.PathPatternParser;
/**
* {@code HandlerMapping} im... | true |
Other | spring-projects | spring-framework | 837dfe285a1be47a16336a6fb5a6030070e637fb.json | Set PathPatternParser in RouterFunctionMapping
See gh-24945 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java | @@ -52,6 +52,7 @@
import javax.servlet.ServletConfig;
import javax.servlet.ServletContext;
+import javax.servlet.ServletException;
import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
@@ -60,6 +61,8 @@
import javax.validation.constraints.... | true |
Other | spring-projects | spring-framework | 23aeba0e46ad03be261be3239cad27a0a4b60ec2.json | Fix typos in WebRequest.checkNotModified docs
Closes gh-1035 | spring-web/src/main/java/org/springframework/web/context/request/WebRequest.java | @@ -140,7 +140,7 @@ public interface WebRequest extends RequestAttributes {
* and HTTP status when applicable.
* <p>Typical usage:
* <pre class="code">
- * public String myHandleMethod(WebRequest webRequest, Model model) {
+ * public String myHandleMethod(WebRequest request, Model model) {
* long lastMo... | true |
Other | spring-projects | spring-framework | 23aeba0e46ad03be261be3239cad27a0a4b60ec2.json | Fix typos in WebRequest.checkNotModified docs
Closes gh-1035 | src/docs/asciidoc/web/webmvc.adoc | @@ -4813,7 +4813,7 @@ as the following example shows:
.Java
----
@RequestMapping
- public String myHandleMethod(WebRequest webRequest, Model model) {
+ public String myHandleMethod(WebRequest request, Model model) {
long eTag = ... // <1>
@@ -4833,7 +4833,7 @@ as the following example shows:
.Kotlin
----
... | true |
Other | spring-projects | spring-framework | 6316a353bb074b118ab71ad89fe60553c4d073c9.json | Reduce String creation in BeanPropertyRowMapper
Prior to this commit the BeanPropertyRowMapper used
String.substring and String.toLowerCase to parse the
field names. This would generate more String than needed.
Instead one could iterate over the internal char[] of the
String and use the Character methods instead. Thi... | spring-jdbc/src/main/java/org/springframework/jdbc/core/BeanPropertyRowMapper.java | @@ -247,16 +247,15 @@ protected String underscoreName(String name) {
if (!StringUtils.hasLength(name)) {
return "";
}
+
StringBuilder result = new StringBuilder();
- result.append(lowerCaseName(name.substring(0, 1)));
- for (int i = 1; i < name.length(); i++) {
- String s = name.substring(i, i + 1);
- ... | false |
Other | spring-projects | spring-framework | 0f36569d75b814a43b081d5a8036534fc1090d62.json | Remove dead fallback code | spring-webmvc/src/main/java/org/springframework/web/servlet/config/FreeMarkerConfigurerBeanDefinitionParser.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -61,9 +61,6 @@ protected void doParse(Elemen... | false |
Other | spring-projects | spring-framework | 83eac9af187c0151bf8039f1827649a8c3ca588f.json | Upgrade CI to github-release resource 1.5.5
Closes gh-27459 | ci/pipeline.yml | @@ -46,6 +46,11 @@ resource_types:
source:
repository: springio/artifactory-resource
tag: 0.0.17
+- name: github-release
+ type: registry-image
+ source:
+ repository: concourse/github-release-resource
+ tag: 1.5.5
- name: github-status-resource
type: registry-image
source: | false |
Other | spring-projects | spring-framework | e8f6cd10a543d4f03da8e8a9750091ec9291e703.json | Apply value formatting to resolved exceptions | spring-core/src/main/java/org/springframework/core/log/LogFormatUtils.java | @@ -43,7 +43,7 @@ public abstract class LogFormatUtils {
* @return the formatted value
*/
public static String formatValue(@Nullable Object value, boolean limitLength) {
- return formatValue(value, 100, limitLength);
+ return formatValue(value, (limitLength ? 100 : -1), limitLength);
}
/** | true |
Other | spring-projects | spring-framework | e8f6cd10a543d4f03da8e8a9750091ec9291e703.json | Apply value formatting to resolved exceptions | spring-web/src/main/java/org/springframework/web/server/handler/ResponseStatusExceptionHandler.java | @@ -20,6 +20,7 @@
import org.apache.commons.logging.LogFactory;
import reactor.core.publisher.Mono;
+import org.springframework.core.log.LogFormatUtils;
import org.springframework.http.HttpStatus;
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.springframework.http.server.reactive.S... | true |
Other | spring-projects | spring-framework | e8f6cd10a543d4f03da8e8a9750091ec9291e703.json | Apply value formatting to resolved exceptions | spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerExceptionResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
import org.apache.commons.lo... | true |
Other | spring-projects | spring-framework | bdfd983bb4d855218f2c07d40ddd33d754559fdb.json | Fix example code formatting in @EnableWebMvc | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/EnableWebMvc.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -33,7 +33,6 @@
* @EnableWebMvc
* &#... | false |
Other | spring-projects | spring-framework | 6e92c4d6749e4ee4b68f74157a1c4539f19deb2d.json | Improve Questions section in CONTRIBUTING doc
Closes gh-27509 | CONTRIBUTING.md | @@ -6,7 +6,7 @@ First off, thank you for taking the time to contribute! :+1: :tada:
* [Code of Conduct](#code-of-conduct)
* [How to Contribute](#how-to-contribute)
- * [Discuss](#discuss)
+ * [Ask questions](#ask-questions)
* [Create an Issue](#create-an-issue)
* [Issue Lifecycle](#issue-lifecycle)
* [Su... | false |
Other | spring-projects | spring-framework | e8fe4493b94d15cfc0b41a1a5079b2806c514cb2.json | Upgrade Mockito to 3.0.0 | build.gradle | @@ -158,7 +158,7 @@ configure(allprojects) { project ->
testCompile("junit:junit:4.13-beta-3") {
exclude group: "org.hamcrest", module: "hamcrest-core"
}
- testCompile("org.mockito:mockito-core:2.28.2") {
+ testCompile("org.mockito:mockito-core:3.0.0") {
exclude group: "org.hamcrest", module: "hamcrest-... | false |
Other | spring-projects | spring-framework | 47d60b34f817d7ab6c95ea0af5871b1fce3ffb92.json | Fix checkstyle violation | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/MessageMapping.java | @@ -58,7 +58,7 @@
* a specialization such as
* {@link org.springframework.messaging.simp.SimpMessageHeaderAccessor
* SimpMessageHeaderAccessor}.</li>
- * <li>{@link Message Message<T>} for access to body and headers with the body
+ * <li>{@link Message Message<T>} for access to body and headers with the bod... | false |
Other | spring-projects | spring-framework | 7b1a6eb50a3ed32dd7158a8553c60ebc115cc296.json | Add getters to RSocketMessageHandler | spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/RSocketMessageHandler.java | @@ -148,6 +148,15 @@ public void setMetadataExtractor(MetadataExtractor extractor) {
this.metadataExtractor = extractor;
}
+ /**
+ * Return the configured {@link #setMetadataExtractor MetadataExtractor}.
+ * This may be {@code null} before {@link #afterPropertiesSet()}.
+ */
+ @Nullable
+ public MetadataExtra... | false |
Other | spring-projects | spring-framework | 507d128e1dd821a38b45449b325e4457f2ff48b3.json | Fix RSocket API warning | spring-messaging/src/test/kotlin/org/springframework/messaging/rsocket/RSocketClientToServerCoroutinesIntegrationTests.kt | @@ -199,7 +199,7 @@ class RSocketClientToServerCoroutinesIntegrationTests {
context = AnnotationConfigApplicationContext(ServerConfig::class.java)
server = RSocketFactory.receive()
- .addServerPlugin(interceptor)
+ .addResponderPlugin(interceptor)
.frameDecoder(PayloadDecoder.ZERO_COPY)
.a... | false |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-messaging/src/main/java/org/springframework/messaging/rsocket/DefaultRSocketRequester.java | @@ -157,24 +157,24 @@ public ResponseSpec data(Object data) {
}
@Override
- public ResponseSpec data(Object producer, Class<?> elementType) {
+ public ResponseSpec data(Object producer, Class<?> elementClass) {
Assert.notNull(producer, "'producer' must not be null");
- Assert.notNull(elementType, "'data... | true |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-messaging/src/main/java/org/springframework/messaging/rsocket/RSocketRequester.java | @@ -243,10 +243,10 @@ interface RequestSpec {
* @param producer the source of payload data value(s). This must be a
* {@link Publisher} or another producer adaptable to a
* {@code Publisher} via {@link ReactiveAdapterRegistry}
- * @param elementType the type of values to be produced
+ * @param elementCl... | true |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java | @@ -273,8 +273,8 @@ public RequestHeadersSpec<?> body(Object producer, Class<?> elementClass) {
}
@Override
- public RequestHeadersSpec<?> body(Object producer, ParameterizedTypeReference<?> elementType) {
- this.bodySpec.body(producer, elementType);
+ public RequestHeadersSpec<?> body(Object producer, Para... | true |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java | @@ -660,11 +660,11 @@ interface RequestBodySpec extends RequestHeadersSpec<RequestBodySpec> {
* @param producer the producer to write to the request. This must be a
* {@link Publisher} or another producer adaptable to a
* {@code Publisher} via {@link ReactiveAdapterRegistry}
- * @param elementType the typ... | true |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyExtractors.java | @@ -72,12 +72,12 @@ public static <T> BodyExtractor<Mono<T>, ReactiveHttpInputMessage> toMono(Class<
/**
* Variant of {@link #toMono(Class)} for type information with generics.
- * @param typeRef the type reference for the type to decode to
+ * @param elementTypeRef the type reference for the type to decode to... | true |
Other | spring-projects | spring-framework | 08a5196c3ab34d8f8f7cc0f20383d6ba0a114832.json | Use elementClass and elementTypeRef consistently | spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyInserters.java | @@ -92,7 +92,7 @@ public static <T> BodyInserter<T, ReactiveHttpOutputMessage> empty() {
* @see #fromProducer(Object, Class)
*/
public static <T> BodyInserter<T, ReactiveHttpOutputMessage> fromObject(T body) {
- Assert.notNull(body, "Body must not be null");
+ Assert.notNull(body, "'body' must not be null");
... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.