language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 22fd521e0aa9b18938b3e8be6070e2adf464ed84.json | Remove MessageHandlerAcceptor sub-class
This commit removes the MessageHandlerAcceptor sub-class of
RSocketMessageHandler, and rather than implementing directly the
contracts for RSocket client and server acceptors, RSocketMessageHandler
now exposes clientAcceptor() and serverAcceptor() methods that return
the require... | spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketBufferLeakTests.java | @@ -87,7 +87,7 @@ public static void setupOnce() {
server = RSocketFactory.receive()
.frameDecoder(PayloadDecoder.ZERO_COPY)
.addServerPlugin(payloadInterceptor) // intercept responding
- .acceptor(context.getBean(MessageHandlerAcceptor.class))
+ .acceptor(context.getBean(RSocketMessageHandler.class)... | true |
Other | spring-projects | spring-framework | 22fd521e0aa9b18938b3e8be6070e2adf464ed84.json | Remove MessageHandlerAcceptor sub-class
This commit removes the MessageHandlerAcceptor sub-class of
RSocketMessageHandler, and rather than implementing directly the
contracts for RSocket client and server acceptors, RSocketMessageHandler
now exposes clientAcceptor() and serverAcceptor() methods that return
the require... | spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketClientToServerIntegrationTests.java | @@ -67,7 +67,7 @@ public static void setupOnce() {
server = RSocketFactory.receive()
.addServerPlugin(interceptor)
.frameDecoder(PayloadDecoder.ZERO_COPY)
- .acceptor(context.getBean(MessageHandlerAcceptor.class))
+ .acceptor(context.getBean(RSocketMessageHandler.class).serverAcceptor())
.transp... | true |
Other | spring-projects | spring-framework | 22fd521e0aa9b18938b3e8be6070e2adf464ed84.json | Remove MessageHandlerAcceptor sub-class
This commit removes the MessageHandlerAcceptor sub-class of
RSocketMessageHandler, and rather than implementing directly the
contracts for RSocket client and server acceptors, RSocketMessageHandler
now exposes clientAcceptor() and serverAcceptor() methods that return
the require... | spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketServerToClientIntegrationTests.java | @@ -65,7 +65,7 @@ public static void setupOnce() {
server = RSocketFactory.receive()
.frameDecoder(PayloadDecoder.ZERO_COPY)
- .acceptor(context.getBean("serverAcceptor", MessageHandlerAcceptor.class))
+ .acceptor(context.getBean("serverMessageHandler", RSocketMessageHandler.class).serverAcceptor())
... | true |
Other | spring-projects | spring-framework | 22fd521e0aa9b18938b3e8be6070e2adf464ed84.json | Remove MessageHandlerAcceptor sub-class
This commit removes the MessageHandlerAcceptor sub-class of
RSocketMessageHandler, and rather than implementing directly the
contracts for RSocket client and server acceptors, RSocketMessageHandler
now exposes clientAcceptor() and serverAcceptor() methods that return
the require... | spring-messaging/src/test/kotlin/org/springframework/messaging/rsocket/RSocketClientToServerCoroutinesIntegrationTests.kt | @@ -16,8 +16,6 @@
package org.springframework.messaging.rsocket
-import java.time.Duration
-
import io.netty.buffer.PooledByteBufAllocator
import io.rsocket.RSocketFactory
import io.rsocket.frame.decoder.PayloadDecoder
@@ -31,9 +29,6 @@ import kotlinx.coroutines.flow.map
import org.junit.AfterClass
import org... | true |
Other | spring-projects | spring-framework | 7f8966774e2096b9ddd55ee931643b48bfc30218.json | Upgrade Jetty to 9.4.21
Make use of the new getAvailableExtensionNames() method.
Closes gh-23799 | build.gradle | @@ -33,7 +33,7 @@ ext {
groovyVersion = "2.5.8"
hsqldbVersion = "2.4.1"
jackson2Version = "2.9.9"
- jettyVersion = "9.4.20.v20190813"
+ jettyVersion = "9.4.21.v20190926"
junit5Version = "5.3.2"
kotlinVersion = "1.2.71"
log4jVersion = "2.11.2" | true |
Other | spring-projects | spring-framework | 7f8966774e2096b9ddd55ee931643b48bfc30218.json | Upgrade Jetty to 9.4.21
Make use of the new getAvailableExtensionNames() method.
Closes gh-23799 | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/JettyRequestUpgradeStrategy.java | @@ -30,7 +30,6 @@
import org.eclipse.jetty.websocket.api.WebSocketPolicy;
import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig;
-import org.eclipse.jetty.websocket.api.extensions.ExtensionFactory;
import org.eclipse.jetty.websocket.server.HandshakeRFC6455;
import org.eclipse.jetty.websocket.server.We... | true |
Other | spring-projects | spring-framework | f8b875d2d8a6ad4462a8b28cbeae4e40e400c087.json | Introduce failing @Disabled test for gh-23856 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java | @@ -34,6 +34,7 @@
import javax.annotation.ParametersAreNonnullByDefault;
import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.springframework.core.Ordered;
@@ -964,6 +965,25 @@ void findAnnotationWithRepeatablesElements() {
TestRepeata... | false |
Other | spring-projects | spring-framework | b343e733df333d6ead6d83f31175e846fc9028ff.json | Upgrade Jetty to 9.4.21
Make use of the new getAvailableExtensionNames() method.
Closes gh-23565 | build.gradle | @@ -47,7 +47,7 @@ configure(allprojects) { project ->
mavenBom "io.netty:netty-bom:4.1.39.Final"
mavenBom "io.projectreactor:reactor-bom:Dysprosium-RELEASE"
mavenBom "io.rsocket:rsocket-bom:1.0.0-RC5"
- mavenBom "org.eclipse.jetty:jetty-bom:9.4.20.v20190813"
+ mavenBom "org.eclipse.jetty:jetty-bom:9.4.2... | true |
Other | spring-projects | spring-framework | b343e733df333d6ead6d83f31175e846fc9028ff.json | Upgrade Jetty to 9.4.21
Make use of the new getAvailableExtensionNames() method.
Closes gh-23565 | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/JettyRequestUpgradeStrategy.java | @@ -30,7 +30,6 @@
import org.eclipse.jetty.websocket.api.WebSocketPolicy;
import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig;
-import org.eclipse.jetty.websocket.api.extensions.ExtensionFactory;
import org.eclipse.jetty.websocket.server.HandshakeRFC6455;
import org.eclipse.jetty.websocket.server.We... | true |
Other | spring-projects | spring-framework | 2146bc816a93caa0b12c2ec5d8896fe166253490.json | Fix Checkstyle violations
See gh-23767 | spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java | @@ -441,8 +441,8 @@ private Object getValueFromMetaAnnotation(int attributeIndex,
value = this.mapping.getMappedAnnotationValue(attributeIndex, forMirrorResolution);
}
if (value == null) {
- Method attribute = mapping.getAttributes().get(attributeIndex);
- value = ReflectionUtils.invokeMethod(attribute, m... | false |
Other | spring-projects | spring-framework | d1aee0e8691c41753621332ff69b17be3f7c8ba2.json | Fix typo in RSocket reference documentation
This commit fixes a typo in a Java code snippet of
the RSocket reference documentation.
Closes gh-23762 | src/docs/asciidoc/rsocket.adoc | @@ -689,7 +689,7 @@ you need to share configuration between a client and a server in the same proces
@Bean
public RSocketStrategies rsocketStrategies() {
- retrun RSocketStrategies.builder()
+ return RSocketStrategies.builder()
.encoders(encoders -> encoders.add(new Jackson2CborEncoder))
.decoders... | false |
Other | spring-projects | spring-framework | 972337e8f9424051d90a20e4680eb61037fe5f36.json | Introduce common .gitattributes file
Closes gh-23376 | .gitattributes | @@ -0,0 +1,5 @@
+# Normalize line endings to LF.
+* text eol=lf
+
+# Ensure that line endings for multipart files in spring-web are not modified.
+*.multipart -text | true |
Other | spring-projects | spring-framework | 972337e8f9424051d90a20e4680eb61037fe5f36.json | Introduce common .gitattributes file
Closes gh-23376 | spring-web/src/test/resources/org/springframework/http/codec/multipart/.gitattributes | @@ -1 +0,0 @@
-*.multipart -text | true |
Other | spring-projects | spring-framework | a4257f84e765389700d466d274e1e7cacabcb7a0.json | Fix base directory in distribution zip
Fixes gh-23745 | gradle/docs.gradle | @@ -203,7 +203,7 @@ task distZip(type: Zip, dependsOn: [docsZip, schemaZip]) {
description = "Builds -${archiveClassifier} archive, containing all jars and docs, " +
"suitable for community download page."
- ext.baseDir = "${archiveBaseName}-${project.version}";
+ ext.baseDir = "spring-framework-${project.versi... | false |
Other | spring-projects | spring-framework | b7f819c9e10fe0c30d599e6cb0f396c65bb3272a.json | Fix URI typo in Java code snippet of web-uris.adoc
Closes gh-23739 | src/docs/asciidoc/web/web-uris.adoc | @@ -265,7 +265,7 @@ You can shorten it further still with a full URI template, as the following exam
[source,java,indent=0,subs="verbatim,quotes",role="primary"]
.Java
----
- RI uri = UriComponentsBuilder.fromPath("/hotel list/{city}?q={q}")
+ URI uri = UriComponentsBuilder.fromPath("/hotel list/{city}?q={q}")
.... | false |
Other | spring-projects | spring-framework | d9bb9b55eecc87e18ae07a3b7d6d0897addf5741.json | Fix Checkstyle violation
See gh-23706 | import-into-eclipse.md | @@ -18,7 +18,7 @@ _When instructed to execute `./gradlew` from the command line, be sure to execut
1. Ensure that Eclipse launches with JDK 8.
- For example, on Mac OS this can be configured in the `Info.plist` file located in the `Contents` folder of the installed Eclipse or STS application (e.g., the `Eclipse.... | false |
Other | spring-projects | spring-framework | a446f572a67074c50477a6a17c55aa6d8e2f3808.json | Fix missing project information in generated POMS
This commit ensures that the project name and description are published
with the generated POMs. | gradle/publications.gradle | @@ -5,8 +5,10 @@ publishing {
publications {
mavenJava(MavenPublication) {
pom {
- name = project.description
- description = project.description
+ afterEvaluate {
+ name = project.description
+ description = project.description
+ }
url = "https://github.com/spring-projects/spring-fram... | false |
Other | spring-projects | spring-framework | 77bc1b05a6e4cba52352edc02262a37d75c67c09.json | Use RSocket BOM
See gh-23698 | build.gradle | @@ -46,6 +46,7 @@ configure(allprojects) { project ->
mavenBom "com.fasterxml.jackson:jackson-bom:2.10.0"
mavenBom "io.netty:netty-bom:4.1.39.Final"
mavenBom "io.projectreactor:reactor-bom:Dysprosium-RELEASE"
+ mavenBom "io.rsocket:rsocket-bom:1.0.0-RC5"
mavenBom "org.eclipse.jetty:jetty-bom:9.4.20.v2... | false |
Other | spring-projects | spring-framework | 29f0d1b25e73b1046a78c244cd05859e64e295a6.json | Remove TODO in AnnotationUtils
Closes gh-23727 | spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java | @@ -170,7 +170,6 @@ public static boolean isCandidateClass(Class<?> clazz, String annotationName) {
if (AnnotationsScanner.hasPlainJavaAnnotationsOnly(clazz)) {
return false;
}
- // TODO: annotation presence registry to be integrated here
return true;
}
| false |
Other | spring-projects | spring-framework | 1e0bdc0337843203f0971b2de7b9c5e2f221fbc5.json | Fix typo in DispatcherServlet Javadoc
Closes gh-23726 | spring-webmvc/src/main/java/org/springframework/web/servlet/DispatcherServlet.java | @@ -255,7 +255,7 @@ public class DispatcherServlet extends FrameworkServlet {
public static final String FLASH_MAP_MANAGER_ATTRIBUTE = DispatcherServlet.class.getName() + ".FLASH_MAP_MANAGER";
/**
- * Name of request attribute that exposes an Exception resolved with an
+ * Name of request attribute that exposes... | false |
Other | spring-projects | spring-framework | 4dc966b04b5f2bdeb43f4bc02de0675c5b9f5586.json | Include @Inject TCK tests in the build again
Commit 979508a7f3a02df0a2a24a3dfc6968e70786684c removed the JUnit 4
dependency from all modules except spring-test. Unfortunately, the
@Inject TCK tests (SpringAtInjectTckTests) are still based on JUnit 3.
Thus, that commit accidentally excluded those tests from the build.
... | spring-context/spring-context.gradle | @@ -39,4 +39,5 @@ dependencies {
testRuntime("javax.xml.bind:jaxb-api")
testRuntime("org.glassfish:javax.el")
testRuntime("org.javamoney:moneta")
+ testRuntime("org.junit.vintage:junit-vintage-engine") // for @Inject TCK
} | true |
Other | spring-projects | spring-framework | 4dc966b04b5f2bdeb43f4bc02de0675c5b9f5586.json | Include @Inject TCK tests in the build again
Commit 979508a7f3a02df0a2a24a3dfc6968e70786684c removed the JUnit 4
dependency from all modules except spring-test. Unfortunately, the
@Inject TCK tests (SpringAtInjectTckTests) are still based on JUnit 3.
Thus, that commit accidentally excluded those tests from the build.
... | src/checkstyle/checkstyle-suppressions.xml | @@ -17,7 +17,7 @@
<suppress files="RootBeanDefinition" checks="EqualsHashCode" />
<!-- spring-context -->
- <suppress files="SpringAtInjectTckTests" checks="IllegalImportCheck" />
+ <suppress files="SpringAtInjectTckTests" checks="IllegalImportCheck" id="bannedJUnit3Imports" />
<!-- spring-core -->
<suppres... | true |
Other | spring-projects | spring-framework | 8bb165e55c68a50997bb1d5edc5822e82de5c94f.json | Fix typo in EventSourceTransportHandler
Closes gh-23984
* https://github.com/spring-projects/spring-framework/blob/3a0f309e2c9fdbbf7fb2d348be861528177f8555/spring-web/src/main/java/org/springframework/http/codec/ServerSentEvent.java#L24
* https://github.com/spring-projects/spring-framework/blob/3a0f309e2c9fdbbf7fb2d3... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/EventSourceTransportHandler.java | @@ -30,7 +30,7 @@
import org.springframework.web.socket.sockjs.transport.session.StreamingSockJsSession;
/**
- * A TransportHandler for sending messages via Server-Sent events:
+ * A TransportHandler for sending messages via Server-Sent Events:
* <a href="https://dev.w3.org/html5/eventsource/">https://dev.w3.org/... | false |
Other | spring-projects | spring-framework | f2b3953d765782f5bc8bc0027634a32bd2aab5c8.json | Use array.clone() instead of manual array creation | spring-aop/src/main/java/org/springframework/aop/framework/ReflectiveMethodInvocation.java | @@ -212,8 +212,7 @@ public MethodInvocation invocableClone() {
Object[] cloneArguments = this.arguments;
if (this.arguments.length > 0) {
// Build an independent copy of the arguments array.
- cloneArguments = new Object[this.arguments.length];
- System.arraycopy(this.arguments, 0, cloneArguments, 0, this... | true |
Other | spring-projects | spring-framework | f2b3953d765782f5bc8bc0027634a32bd2aab5c8.json | Use array.clone() instead of manual array creation | spring-context-support/src/main/java/org/springframework/mail/SimpleMailMessage.java | @@ -276,9 +276,7 @@ private static String[] copyOrNull(@Nullable String[] state) {
}
private static String[] copy(String[] state) {
- String[] copy = new String[state.length];
- System.arraycopy(state, 0, copy, 0, state.length);
- return copy;
+ return state.clone();
}
} | true |
Other | spring-projects | spring-framework | f2b3953d765782f5bc8bc0027634a32bd2aab5c8.json | Use array.clone() instead of manual array creation | spring-context/src/main/java/org/springframework/cache/interceptor/SimpleKey.java | @@ -48,8 +48,7 @@ public class SimpleKey implements Serializable {
*/
public SimpleKey(Object... elements) {
Assert.notNull(elements, "Elements must not be null");
- this.params = new Object[elements.length];
- System.arraycopy(elements, 0, this.params, 0, elements.length);
+ this.params = elements.clone();
... | true |
Other | spring-projects | spring-framework | f2b3953d765782f5bc8bc0027634a32bd2aab5c8.json | Use array.clone() instead of manual array creation | spring-core/src/main/java/org/springframework/util/FastByteArrayOutputStream.java | @@ -206,9 +206,7 @@ public byte[] toByteArrayUnsafe() {
*/
public byte[] toByteArray() {
byte[] bytesUnsafe = toByteArrayUnsafe();
- byte[] ret = new byte[bytesUnsafe.length];
- System.arraycopy(bytesUnsafe, 0, ret, 0, bytesUnsafe.length);
- return ret;
+ return bytesUnsafe.clone();
}
/** | true |
Other | spring-projects | spring-framework | c4ec6aea6825011fd0f400d58b3c1fdf5d4fe002.json | Fix Checkstyle violations
See gh-23784 | spring-context/src/main/java/org/springframework/context/event/ApplicationListenerMethodAdapter.java | @@ -295,9 +295,11 @@ private boolean shouldHandle(ApplicationEvent event, @Nullable Object[] args) {
@Nullable
protected Object doInvoke(Object... args) {
Object bean = getTargetBean();
+ // Detect package-protected NullBean instance through equals(null) check
if (bean.equals(null)) {
- return null;
+ ... | true |
Other | spring-projects | spring-framework | c4ec6aea6825011fd0f400d58b3c1fdf5d4fe002.json | Fix Checkstyle violations
See gh-23784 | spring-context/src/test/java/org/springframework/context/event/AnnotationDrivenEventListenerTests.java | @@ -16,8 +16,6 @@
package org.springframework.context.event;
-import java.io.Closeable;
-import java.io.IOException;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -627,12 +625,13 @@ public void listenersReceiveEarlyEvents() {
}
... | true |
Other | spring-projects | spring-framework | d494621ee3d2e0d6c706f401028b0bbd62491495.json | avoid store all bean name | spring-context/src/main/java/org/springframework/context/support/ApplicationListenerDetector.java | @@ -59,7 +59,9 @@ public ApplicationListenerDetector(AbstractApplicationContext applicationContext
@Override
public void postProcessMergedBeanDefinition(RootBeanDefinition beanDefinition, Class<?> beanType, String beanName) {
- this.singletonNames.put(beanName, beanDefinition.isSingleton());
+ if (ApplicationLi... | false |
Other | spring-projects | spring-framework | f638bfc6a9231591f4e605c4caced092cd7cd32f.json | Fix status code in webmvc.adoc
Closes gh-22396 | src/docs/asciidoc/web/webmvc.adoc | @@ -4818,7 +4818,7 @@ as the following example shows:
There are three variants for checking conditional requests against `eTag` values, `lastModified`
values, or both. For conditional `GET` and `HEAD` requests, you can set the response to
304 (NOT_MODIFIED). For conditional `POST`, `PUT`, and `DELETE`, you can inste... | false |
Other | spring-projects | spring-framework | 91f5f42d136ccae798e01e71356787d4a12913e6.json | Add tests for PrincipalMethodArgumentResolver | spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/PrincipalMethodArgumentResolverTests.java | @@ -0,0 +1,76 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 91f5f42d136ccae798e01e71356787d4a12913e6.json | Add tests for PrincipalMethodArgumentResolver | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/PrincipalMethodArgumentResolverTests.java | @@ -42,7 +42,7 @@ public class PrincipalMethodArgumentResolverTests {
private final PrincipalMethodArgumentResolver resolver =
new PrincipalMethodArgumentResolver(ReactiveAdapterRegistry.getSharedInstance());
- private ResolvableMethod testMethod = ResolvableMethod.on(getClass()).named("handle").build();
+ priv... | true |
Other | spring-projects | spring-framework | afae8c304539f0e29f3d068194edb44071ef4172.json | Avoid default "Accept" from HttpUrlConnection
Closes gh-23740 | spring-web/src/main/java/org/springframework/web/client/RestTemplate.java | @@ -739,6 +739,9 @@ protected <T> T doExecute(URI url, @Nullable HttpMethod method, @Nullable Reques
if (requestCallback != null) {
requestCallback.doWithRequest(request);
}
+ if ((method == HttpMethod.DELETE || method == HttpMethod.PUT) && request.getHeaders().getAccept().isEmpty()) {
+ request.getHe... | true |
Other | spring-projects | spring-framework | afae8c304539f0e29f3d068194edb44071ef4172.json | Avoid default "Accept" from HttpUrlConnection
Closes gh-23740 | spring-web/src/test/java/org/springframework/web/client/RestTemplateTests.java | @@ -25,8 +25,13 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Map.Entry;
import java.util.Set;
+import java.util.stream.Collectors;
+import okhttp3.mockwebserver.MockResponse;
+import okhttp3.mockwebserver.MockWebServer;
+import okhttp3.mockwebserver.RecordedRequest;
... | true |
Other | spring-projects | spring-framework | 627a9be65460dae2bd4c4050070fb721a6a70743.json | Update WebMvcConfigurer#addInterceptors Javadoc
Closes gh-23908 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurer.java | @@ -90,15 +90,9 @@ default void addFormatters(FormatterRegistry registry) {
/**
* Add Spring MVC lifecycle interceptors for pre- and post-processing of
- * controller method invocations. Interceptors can be registered to apply
- * to all requests or be limited to a subset of URL patterns.
- * <p><strong>Note<... | false |
Other | spring-projects | spring-framework | 203977972b9c6e0a26cf99e30b620f9ab127bc5b.json | Fix issue with path matching options
Closes gh-23907 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerMapping.java | @@ -163,7 +163,7 @@ protected RequestMappingInfo getMappingForMethod(Method method, Class<?> handler
if (this.embeddedValueResolver != null) {
prefix = this.embeddedValueResolver.resolveStringValue(prefix);
}
- info = RequestMappingInfo.paths(prefix).build().combine(info);
+ info = RequestMap... | true |
Other | spring-projects | spring-framework | 203977972b9c6e0a26cf99e30b620f9ab127bc5b.json | Fix issue with path matching options
Closes gh-23907 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerMapping.java | @@ -232,7 +232,7 @@ protected RequestMappingInfo getMappingForMethod(Method method, Class<?> handler
}
String prefix = getPathPrefix(handlerType);
if (prefix != null) {
- info = RequestMappingInfo.paths(prefix).build().combine(info);
+ info = RequestMappingInfo.paths(prefix).options(this.config).build... | true |
Other | spring-projects | spring-framework | 203977972b9c6e0a26cf99e30b620f9ab127bc5b.json | Fix issue with path matching options
Closes gh-23907 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerMappingTests.java | @@ -32,6 +32,7 @@
import org.springframework.core.annotation.AliasFor;
import org.springframework.http.MediaType;
+import org.springframework.mock.web.test.MockHttpServletRequest;
import org.springframework.stereotype.Controller;
import org.springframework.util.ClassUtils;
import org.springframework.web.accept.C... | true |
Other | spring-projects | spring-framework | 9960ed55aa3ce3f75dd8c5a0e550438323a0344a.json | Fix condition in ServletInvocableHandlerMethod
Closes gh-23775 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ServletInvocableHandlerMethod.java | @@ -166,7 +166,7 @@ private boolean isRequestNotModified(ServletWebRequest webRequest) {
}
private void disableContentCachingIfNecessary(ServletWebRequest webRequest) {
- if (!isRequestNotModified(webRequest)) {
+ if (isRequestNotModified(webRequest)) {
HttpServletResponse response = webRequest.getNativeRes... | true |
Other | spring-projects | spring-framework | 9960ed55aa3ce3f75dd8c5a0e550438323a0344a.json | Fix condition in ServletInvocableHandlerMethod
Closes gh-23775 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletInvocableHandlerMethodTests.java | @@ -31,6 +31,7 @@
import org.springframework.core.MethodParameter;
import org.springframework.core.ResolvableType;
import org.springframework.core.annotation.AliasFor;
+import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import o... | true |
Other | spring-projects | spring-framework | 9da15ee23aff3960bb36caa980872dd04d9dbd9f.json | Improve usage of String.substring()
Closes gh-23923 | spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AspectMetadata.java | @@ -127,9 +127,9 @@ public AspectMetadata(Class<?> aspectClass, String aspectName) {
*/
private String findPerClause(Class<?> aspectClass) {
String str = aspectClass.getAnnotation(Aspect.class).value();
- str = str.substring(str.indexOf('(') + 1);
- str = str.substring(0, str.length() - 1);
- return str;
+ ... | true |
Other | spring-projects | spring-framework | 9da15ee23aff3960bb36caa980872dd04d9dbd9f.json | Improve usage of String.substring()
Closes gh-23923 | spring-webflux/src/main/java/org/springframework/web/reactive/resource/CssLinkResourceTransformer.java | @@ -221,7 +221,7 @@ protected String getKeyword() {
@Override
protected int extractUnquotedLink(int position, String content, Set<ContentChunkInfo> result) {
- if (content.substring(position, position + 4).equals("url(")) {
+ if (content.startsWith("url(", position)) {
// Ignore, UrlFunctionContentPars... | true |
Other | spring-projects | spring-framework | 9da15ee23aff3960bb36caa980872dd04d9dbd9f.json | Improve usage of String.substring()
Closes gh-23923 | spring-webmvc/src/main/java/org/springframework/web/servlet/resource/CssLinkResourceTransformer.java | @@ -182,7 +182,7 @@ protected String getKeyword() {
@Override
protected int extractLink(int index, String content, SortedSet<ContentChunkInfo> linksToAdd) {
- if (content.substring(index, index + 4).equals("url(")) {
+ if (content.startsWith("url(", index)) {
// Ignore, UrlLinkParser will take care
... | true |
Other | spring-projects | spring-framework | 9da15ee23aff3960bb36caa980872dd04d9dbd9f.json | Improve usage of String.substring()
Closes gh-23923 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/AbstractView.java | @@ -147,11 +147,10 @@ public void setAttributesCSV(@Nullable String propString) throws IllegalArgument
"At least 2 characters ([]) required in attributes CSV string '" + propString + "'");
}
String name = tok.substring(0, eqIdx);
- String value = tok.substring(eqIdx + 1);
-
// Delete first and... | true |
Other | spring-projects | spring-framework | 9da15ee23aff3960bb36caa980872dd04d9dbd9f.json | Improve usage of String.substring()
Closes gh-23923 | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java | @@ -472,8 +472,7 @@ protected boolean validateRequest(String serverId, String sessionId, String tran
private boolean validatePath(ServerHttpRequest request) {
String path = request.getURI().getPath();
int index = path.lastIndexOf('/') + 1;
- String filename = path.substring(index);
- return (filename.indexOf(... | true |
Other | spring-projects | spring-framework | 444c8185b62f11f69f933c45b4e2d649982b64c4.json | Add document on async support in WebMvc.fn
This commit adds reference documentation about the support for
asynchronous types in WebMvc.fn. | src/docs/asciidoc/web/webflux-functional.adoc | @@ -125,7 +125,7 @@ For more on that, see <<web-reactive.adoc#webflux-reactive-libraries, Reactive L
[[webflux-fn-request]]
-=== `ServerRequest`
+=== ServerRequest
`ServerRequest` provides access to the HTTP method, URI, headers, and query parameters,
while access to the body is provided through the `body` met... | true |
Other | spring-projects | spring-framework | 444c8185b62f11f69f933c45b4e2d649982b64c4.json | Add document on async support in WebMvc.fn
This commit adds reference documentation about the support for
asynchronous types in WebMvc.fn. | src/docs/asciidoc/web/webmvc-functional.adoc | @@ -117,7 +117,7 @@ access to the HTTP request and response, including headers, body, method, and st
[[webmvc-fn-request]]
-=== `ServerRequest`
+=== ServerRequest
`ServerRequest` provides access to the HTTP method, URI, headers, and query parameters,
while access to the body is provided through the `body` meth... | true |
Other | spring-projects | spring-framework | 2533ba5253ed285c00dd6f883d114eb7a0f3b29f.json | Use Mono.fromDirect for Jetty ReactiveRespnose
Closes gh-25849 | spring-web/src/main/java/org/springframework/http/client/reactive/JettyClientHttpConnector.java | @@ -120,7 +120,7 @@ public Mono<ClientHttpResponse> connect(HttpMethod method, URI uri,
Request request = this.httpClient.newRequest(uri).method(method.toString());
return requestCallback.apply(new JettyClientHttpRequest(request, this.bufferFactory))
- .then(Mono.from(ReactiveRequest.newBuilder(request).buil... | false |
Other | spring-projects | spring-framework | 3303a68436c23fa4928c402bbec52d2da88818b0.json | Use registry to convert to CompletableFuture
Use the ReactiveAdapterRegistry to convert to CompletableFuture,
and remove the ToFutureSubscriber. | spring-webmvc/src/main/java/org/springframework/web/servlet/function/AsyncServerResponse.java | @@ -33,8 +33,6 @@
import javax.servlet.http.HttpServletResponse;
import org.reactivestreams.Publisher;
-import org.reactivestreams.Subscriber;
-import org.reactivestreams.Subscription;
import org.springframework.core.ReactiveAdapter;
import org.springframework.core.ReactiveAdapterRegistry;
@@ -138,67 +136,22 @@... | false |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/AsyncServerResponse.java | @@ -0,0 +1,348 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java | @@ -41,6 +41,8 @@
import org.reactivestreams.Subscription;
import org.springframework.core.ParameterizedTypeReference;
+import org.springframework.core.ReactiveAdapter;
+import org.springframework.core.ReactiveAdapterRegistry;
import org.springframework.core.io.InputStreamResource;
import org.springframework.core... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerResponseBuilder.java | @@ -17,21 +17,17 @@
package org.springframework.web.servlet.function;
import java.io.IOException;
-import java.io.UncheckedIOException;
import java.net.URI;
import java.time.Instant;
import java.time.ZonedDateTime;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/EntityResponse.java | @@ -52,7 +52,7 @@
/**
* Create a builder with the given object.
* @param t the object that represents the body of the response
- * @param <T> the type of element contained in the publisher
+ * @param <T> the type of element contained in the entity
* @return the created builder
*/
static <T> Builder<T>... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/ErrorHandlingServerResponse.java | @@ -0,0 +1,95 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/HandlerFilterFunction.java | @@ -112,9 +112,8 @@ default HandlerFunction<R> apply(HandlerFunction<T> handler) {
return (request, next) -> {
try {
T t = next.handle(request);
- if (t instanceof DefaultServerResponseBuilder.AbstractServerResponse) {
- ((DefaultServerResponseBuilder.AbstractServerResponse) t)
- .addErrorHandl... | true |
Other | spring-projects | spring-framework | 4e76a4780c4e0f5d496c9c0b75e1f9dab2d0b57c.json | Add ServerResponse.async() in WebMvc.fn
This commit introduces a new async(Object) method in the WebMvc.fn,
taking a asynchronous response as argument in the form of a
CompletableFuture or Publisher. This allows for asynchronous setting
of headers and status (and not just body, which was already possible).
Closes gh-... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/ServerResponse.java | @@ -24,6 +24,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;
import java.util.function.BiFunction;
import java.util.function.Consumer;
@@ -36,6 +37,7 @@
import org.reactivestreams.Publisher;
im... | true |
Other | spring-projects | spring-framework | 86f2ebec1b1f5438ba4d9908c71c710ef2f14219.json | Fix recursion issue caused by previous commit
See gh-25821 | spring-messaging/src/main/java/org/springframework/messaging/support/NativeMessageHeaderAccessor.java | @@ -113,7 +113,7 @@ public void setImmutable() {
public void setHeader(String name, @Nullable Object value) {
if (name.equalsIgnoreCase(NATIVE_HEADERS)) {
// Force removal since setHeader checks for equality
- removeHeader(NATIVE_HEADERS);
+ super.setHeader(NATIVE_HEADERS, null);
}
super.setHeader(na... | false |
Other | spring-projects | spring-framework | 97cc89630dce6e65dbe3f80e3d777f897c944667.json | Remove inefficiency in HttpStatus.series()
Prior to this commit, the Series value for an HttpStatus was always
evaluated which resulted in an allocation of a Series array by invoking
Series.values() which makes a defensive copy.
This commit addresses this issue by hardcoding the corresponding Series
within the HttpSt... | spring-web/src/main/java/org/springframework/http/HttpStatus.java | @@ -39,391 +39,393 @@ public enum HttpStatus {
* {@code 100 Continue}.
* @see <a href="https://tools.ietf.org/html/rfc7231#section-6.2.1">HTTP/1.1: Semantics and Content, section 6.2.1</a>
*/
- CONTINUE(100, "Continue"),
+ CONTINUE(100, Series.INFORMATIONAL, "Continue"),
/**
* {@code 101 Switching Protoco... | true |
Other | spring-projects | spring-framework | 97cc89630dce6e65dbe3f80e3d777f897c944667.json | Remove inefficiency in HttpStatus.series()
Prior to this commit, the Series value for an HttpStatus was always
evaluated which resulted in an allocation of a Series array by invoking
Series.values() which makes a defensive copy.
This commit addresses this issue by hardcoding the corresponding Series
within the HttpSt... | spring-web/src/test/java/org/springframework/http/HttpStatusTests.java | @@ -128,4 +128,12 @@ public void fromEnumToMap() {
}
}
+ @Test
+ public void allStatusSeriesShouldMatchExpectations() {
+ // a series of a status is manually set, make sure it is the correct one
+ for (HttpStatus status : HttpStatus.values()) {
+ HttpStatus.Series expectedSeries = HttpStatus.Series.valueOf(s... | true |
Other | spring-projects | spring-framework | b9ef5416b9af95b8739e0b977e55310ef9eaed11.json | Expose combine method in CorsConfiguration
Closes gh-25716 | spring-webflux/src/main/java/org/springframework/web/reactive/config/CorsRegistration.java | @@ -134,6 +134,18 @@ public CorsRegistration maxAge(long maxAge) {
return this;
}
+ /**
+ * Apply the given {@code CorsConfiguration} to the one being configured via
+ * {@link CorsConfiguration#combine(CorsConfiguration)} which in turn has been
+ * initialized with {@link CorsConfiguration#applyPermitDefault... | true |
Other | spring-projects | spring-framework | b9ef5416b9af95b8739e0b977e55310ef9eaed11.json | Expose combine method in CorsConfiguration
Closes gh-25716 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/CorsRegistration.java | @@ -135,6 +135,18 @@ public CorsRegistration maxAge(long maxAge) {
return this;
}
+ /**
+ * Apply the given {@code CorsConfiguration} to the one being configured via
+ * {@link CorsConfiguration#combine(CorsConfiguration)} which in turn has been
+ * initialized with {@link CorsConfiguration#applyPermitDefault... | true |
Other | spring-projects | spring-framework | 6aa522b3c1d74f1ce3c07f030b576ad0be07f581.json | Apply LONG_RUNNING test group properly
See gh-24830 | spring-jdbc/src/test/java/org/springframework/jdbc/datasource/DataSourceTransactionManagerTests.java | @@ -28,6 +28,8 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.InOrder;
import org.springframework.core.testfixture.... | true |
Other | spring-projects | spring-framework | 6aa522b3c1d74f1ce3c07f030b576ad0be07f581.json | Apply LONG_RUNNING test group properly
See gh-24830 | spring-jdbc/src/test/java/org/springframework/jdbc/support/JdbcTransactionManagerTests.java | @@ -28,6 +28,8 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.InOrder;
import org.springframework.core.testfixture.... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | integration-tests/src/test/java/org/springframework/scheduling/annotation/ScheduledAndTransactionalAnnotationIntegrationTests.java | @@ -40,7 +40,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.mockito.Mockito.mock;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.T... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-aop/src/test/java/org/springframework/aop/target/dynamic/RefreshableTargetSourceTests.java | @@ -21,7 +21,7 @@
import org.springframework.core.testfixture.EnabledForTestGroups;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Rob ... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-aspects/src/test/java/org/springframework/scheduling/aspectj/AnnotationAsyncExecutionAspectTests.java | @@ -38,15 +38,15 @@
import org.springframework.util.concurrent.ListenableFuture;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* Unit tests for ... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-context-support/src/test/java/org/springframework/scheduling/quartz/QuartzSupportTests.java | @@ -46,7 +46,7 @@
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Jue... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-context/src/test/java/org/springframework/context/support/DefaultLifecycleProcessorTests.java | @@ -30,7 +30,7 @@
import org.springframework.core.testfixture.EnabledForTestGroups;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Mark... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-context/src/test/java/org/springframework/scheduling/annotation/EnableSchedulingTests.java | @@ -35,7 +35,7 @@
import org.springframework.scheduling.config.TaskManagementConfigUtils;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* Tests ... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-context/src/test/java/org/springframework/scheduling/concurrent/ScheduledExecutorFactoryBeanTests.java | @@ -32,7 +32,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Rick E... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-context/src/test/java/org/springframework/scripting/support/ScriptFactoryPostProcessorTests.java | @@ -33,14 +33,14 @@
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
import static org.mockito.Mockito.mock;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframe... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-jdbc/src/test/java/org/springframework/jdbc/datasource/DataSourceTransactionManagerTests.java | @@ -57,7 +57,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Juerge... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-jdbc/src/test/java/org/springframework/jdbc/support/JdbcTransactionManagerTests.java | @@ -63,7 +63,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Juerge... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/DelegatingWebConnectionTests.java | @@ -42,7 +42,7 @@
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
... | true |
Other | spring-projects | spring-framework | e02d3f32b4a17effd3bf56006feb476405f4c4d5.json | Requalify tests as LONG_RUNNING
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-2483... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/AbstractSockJsIntegrationTests.java | @@ -69,7 +69,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
-import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
+import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* Abstract base class for in... | true |
Other | spring-projects | spring-framework | 9ad5a8ead0f573d8442d570209414d5a1da1f8f9.json | Add KClass variant to Coroutines web API
Closes gh-24967 | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensions.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ import org.springframework.co... | true |
Other | spring-projects | spring-framework | 9ad5a8ead0f573d8442d570209414d5a1da1f8f9.json | Add KClass variant to Coroutines web API
Closes gh-24967 | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensions.kt | @@ -30,6 +30,7 @@ import reactor.core.publisher.Flux
import reactor.core.publisher.Mono
import java.net.InetSocketAddress
import java.security.Principal
+import kotlin.reflect.KClass
/**
* Extension for [ServerRequest.bodyToMono] providing a `bodyToMono<Foo>()` variant
@@ -62,6 +63,16 @@ inline fun <reified T :... | true |
Other | spring-projects | spring-framework | 9ad5a8ead0f573d8442d570209414d5a1da1f8f9.json | Add KClass variant to Coroutines web API
Closes gh-24967 | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensionsTests.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -31,6 +31,7 @@ import reactor.core.publisher... | true |
Other | spring-projects | spring-framework | 9ad5a8ead0f573d8442d570209414d5a1da1f8f9.json | Add KClass variant to Coroutines web API
Closes gh-24967 | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensionsTests.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,6 +37,7 @@ import java.util.*
* Mock o... | true |
Other | spring-projects | spring-framework | c04400890f54bb2d342348085666066072b7bab9.json | Avoid repeated Charset resolution in MimeType
Closes gh-25808 | spring-core/src/main/java/org/springframework/util/MimeType.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -103,6 +103,9 @@ public class MimeType imple... | false |
Other | spring-projects | spring-framework | 9795883d9190b9618d4b9fe79acd000e875e7bbf.json | Avoid repeated Charset resolution in MimeType
Closes gh-25808 | spring-core/src/main/java/org/springframework/util/MimeType.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -103,6 +103,9 @@ public class MimeType imple... | false |
Other | spring-projects | spring-framework | f9167c3df59edbca2f8a99541750d87957d34a49.json | Improve Javadoc of ContentCachingRequestWrapper
Closes gh-27068 | spring-web/src/main/java/org/springframework/web/util/ContentCachingRequestWrapper.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,9 +40,15 @@
* the {@linkplain #getInpu... | false |
Other | spring-projects | spring-framework | fbf4724d781a30347b3830567417eef0dd803c3b.json | Replace Jetty 9 only constant with explicit value
Closes gh-27121 | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/Jetty10RequestUpgradeStrategy.java | @@ -29,7 +29,6 @@
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
-import org.eclipse.jetty.websocket.server.HandshakeRFC6455;
import org.springframework.aop.framework.ProxyFactory;
import org.springframework.aop.target.EmptyTargetSource;
@@ -56,7 +55,7 @@
... | true |
Other | spring-projects | spring-framework | fbf4724d781a30347b3830567417eef0dd803c3b.json | Replace Jetty 9 only constant with explicit value
Closes gh-27121 | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/JettyRequestUpgradeStrategy.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -31,7 +31,6 @@
import org.eclipse.jetty.w... | true |
Other | spring-projects | spring-framework | 564c6f7f86467e1f831d107d571ec34501104b18.json | improve the performance of iteration | spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionReader.java | @@ -489,9 +489,9 @@ else if (args[0] instanceof Map) {
resolveConstructorArguments(args, 2, hasClosureArgument ? args.length - 1 : args.length);
this.currentBeanDefinition = new GroovyBeanDefinitionWrapper(beanName, (Class<?>) args[1], constructorArgs);
Map<?, ?> namedArgs = (Map<?, ?>) args[0];
- f... | false |
Other | spring-projects | spring-framework | 94f56a2684a3f23cc0b64d93ee6e24acdbfca91f.json | Improve Jetty 10 check on client-side
Before this commit, JettyClientHttpResponse checked for the presence of
a server-side class to determine whether it is running on Jetty 10.
Unfortunately, that class is not necessarily present when just using the
Jetty client.
This commit improves the Jetty 10 check, so that it a... | spring-web/src/main/java/org/springframework/http/client/reactive/JettyClientHttpResponse.java | @@ -33,7 +33,6 @@
import org.springframework.http.ResponseCookie;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
-import org.springframework.util.ClassUtils;
import org.springframework.util.CollectionUtils;
import org.springframework.util.LinkedMultiValueMap;
import org.springfr... | false |
Other | spring-projects | spring-framework | 403e1f2505335bc6f5a17546a838a15f53ca2e3a.json | Update copyright year of changed file
See gh-27102 | spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectiveConstructorResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | f39c6d36c70fbbbbb0323fabf7a1ee6d1c0f4d7c.json | Simplify Comparator using method references
See gh-27102 | spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectiveConstructorResolver.java | @@ -19,6 +19,7 @@
import java.lang.reflect.Constructor;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Comparator;
import java.util.List;
import org.springframework.core.MethodParameter;
@@ -59,11 +60,7 @@ public ConstructorExecutor resolve(EvaluationContext context, String typeName, L
... | false |
Other | spring-projects | spring-framework | 411745f4cb13bbf0420ad8177ec3ac554bf8686d.json | Update copyright year of changed file
See gh-27101 | spring-jms/src/main/java/org/springframework/jms/support/SimpleJmsHeaderMapper.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 6427a4b5c0489071f84f31c703b2513aba66461e.json | Fix typo in core-beans.adoc
See gh-27113 | src/docs/asciidoc/core/core-beans.adoc | @@ -5388,7 +5388,7 @@ matching an `account` qualifier against beans marked with the same qualifier lab
For beans that are themselves defined as a collection, `Map`, or array type, `@Resource`
is a fine solution, referring to the specific collection or array bean by unique name.
-That said, as of 4.3, collection, yo... | false |
Other | spring-projects | spring-framework | 3ccbf1edeb34259751fd3e5ce80d4cd4d3e029e2.json | Increase fudge factor in StopWatchTests | spring-core/src/test/java/org/springframework/util/StopWatchTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -41,7 +41,7 @@ class StopWatchTests {
pr... | false |
Other | spring-projects | spring-framework | b0f724a597bddec3dfc27396ccdaa1ef7510a5f1.json | Update copyright year of changed file
See gh-27105 | spring-context/src/main/kotlin/org/springframework/context/support/BeanDefinitionDsl.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 9add04f800f66ad8790dff7d546065a8ffa22df4.json | Fix typo in BeanDefinitionDsl.kt
See gh-27105 | spring-context/src/main/kotlin/org/springframework/context/support/BeanDefinitionDsl.kt | @@ -1110,7 +1110,7 @@ open class BeanDefinitionDsl internal constructor (private val init: BeanDefinit
}
/**
- * Return an provider for the specified bean, allowing for lazy on-demand retrieval
+ * Return a provider for the specified bean, allowing for lazy on-demand retrieval
* of instances, including ... | false |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAdviceParameterNameDiscoverer.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -625,7 +625,7 @@ private PointcutBody getPoi... | true |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcut.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -547,7 +547,7 @@ public String toString() {
... | true |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/main/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPoint.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -255,19 +255,19 @@ private String toString(b... | true |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/main/java/org/springframework/aop/support/AbstractBeanFactoryPointcutAdvisor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -137,7 +137,7 @@ public String toString() {
... | true |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/main/java/org/springframework/aop/target/AbstractBeanFactoryBasedTargetSource.java | @@ -191,9 +191,9 @@ public int hashCode() {
@Override
public String toString() {
StringBuilder sb = new StringBuilder(getClass().getSimpleName());
- sb.append(" for target bean '").append(this.targetBeanName).append("'");
+ sb.append(" for target bean '").append(this.targetBeanName).append('\'');
if (this.t... | true |
Other | spring-projects | spring-framework | a2ef6badc4c76790128910851fdde0df55ec15f9.json | Use StringBuilder.append(char) where possible
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098 | spring-aop/src/test/java/org/springframework/aop/aspectj/AspectJAdviceParameterNameDiscovererTests.java | @@ -276,14 +276,14 @@ protected void assertException(Method method, String pointcut, String returning,
private static String format(String[] names) {
StringBuilder sb = new StringBuilder();
- sb.append("(");
+ sb.append('(');
for (int i = 0; i < names.length; i++) {
sb.append(names[i]);
if ((i + 1) ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.